Packages/TYPO3.CMS.git
22 months ago[BUGFIX] Extbase distinct query result handling 70/53670/5
Oliver Hader [Mon, 21 Aug 2017 08:13:20 +0000 (10:13 +0200)]
[BUGFIX] Extbase distinct query result handling

Since Doctrine DBAL has been integrated into the TYPO3 core during
version 8 development and Extbase queries have been adjusted with
TYPO3 version 8.4.0, the behavior on distinct query results were
mixed up as well.

Extbase queries using the query-builder until TYPO3 7 LTS contained a
dedicated `SELECT DISTINCT` when retrieving data which lead to unique
entities, especially when implicit `LEFT JOIN` statements have been
added to the query to resolve cardinalities of the types one-to-many
and many-to-many.

Besides that using `GROUP BY` is not reliable in this particular
Extbase scenario. Further details can be found in MySQL documentation:
https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html

Change-Id: Ic5fd1d4752eefec7fcff37d8d62f55ea7299e8d6
Resolves: #80380
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit f8aaf85cc5602a45a6f6b949a77ce109bbacc8f8)
Reviewed-on: https://review.typo3.org/53670
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[TASK] Cleanup .gitignore 63/53663/6
Philipp Gampe [Sun, 13 Aug 2017 10:39:30 +0000 (12:39 +0200)]
[TASK] Cleanup .gitignore

Make sure root level excludes are prefix with
a forward slash (/).

Sort the .gitignore into logical groups.

Releases: 7.6, 8.7, master
Resolves: #81992
Change-Id: If1cb4105e57fb7ab3c28448abc3eaeb898da60e3
Reviewed-on: https://review.typo3.org/53663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[TASK] Update php-cs-fixer to 2.5.0 95/53795/2
Wouter Wolters [Wed, 23 Aug 2017 16:45:54 +0000 (18:45 +0200)]
[TASK] Update php-cs-fixer to 2.5.0

Add 2 new rules

* no_superfluous_elseif
* no_useless_else

Both rules only apply if the if-statement contains a return. If this
is the case the obsolete else/elseif part is dropped.

Resolves: #82183
Releases: master,8.7
Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a
Reviewed-on: https://review.typo3.org/53795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class 93/53793/3
Mathias Brodala [Fri, 18 Aug 2017 12:53:03 +0000 (14:53 +0200)]
[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class

Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7
Resolves: #82131
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] CGL fixes after upgrade to php-cs-fixer 1.4 92/53792/2
Christian Kuhn [Tue, 22 Aug 2017 17:33:24 +0000 (19:33 +0200)]
[TASK] CGL fixes after upgrade to php-cs-fixer 1.4

Change a series of cgl details after update of php-cs-fixer
from 1.0 to 1.4.

Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f
Resolves: #82171
Related: #82164
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Mark not set Install Tool password as secure 86/53786/3
Frans Saris [Mon, 21 Aug 2017 13:59:35 +0000 (15:59 +0200)]
[BUGFIX] Mark not set Install Tool password as secure

To completely disable the Install Tool you can just leave the
`installToolPassword` value empty in your LocalConfiguration.
Problem here is that not all password hashing methods can handle an
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install
password hashing/check when there is no password.

Releases: master, 8.7
Resolves: #82147
Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5
Reviewed-on: https://review.typo3.org/53786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
22 months ago[BUGFIX] Throw exception if encryption key is not set 84/53784/2
Helmut Hummel [Thu, 17 Aug 2017 16:41:39 +0000 (18:41 +0200)]
[BUGFIX] Throw exception if encryption key is not set

The encryption key is a vital part to ensure security
of TYPO3. Not having it set (by accident) can lead
to severe security issues.

Therefore enforce it to be set and throw an exception
in case it isn't, instead of just reporting a warning.

Releases: master, 8.7, 7.6
Resolves: #82169
Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3
Reviewed-on: https://review.typo3.org/53784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[!!!][TASK] Extension manager: Drop "Download SQL Dump" 83/53783/3
Christian Kuhn [Tue, 22 Aug 2017 19:13:54 +0000 (21:13 +0200)]
[!!!][TASK] Extension manager: Drop "Download SQL Dump"

Remove the "Download SQL Dump" button from extension manager.

Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070
Resolves: #82148
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[TASK] travis-ci: Execute unit test only 81/53781/2
Christian Kuhn [Tue, 22 Aug 2017 18:11:00 +0000 (20:11 +0200)]
[TASK] travis-ci: Execute unit test only

travis-ci still chockes on executing the functional tests
which take ages, even with various tricks in place.
The patch reduces the travis execution to unit tests
only since all main tests are executed via our bamboo
environment anyway beforehand.

Change-Id: I809f38d79f0ac7848e6b7e155d35aab575f4d81a
Resolves: #82172
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] travis-ci: Less parallel jobs 78/53778/2
Christian Kuhn [Tue, 22 Aug 2017 16:54:52 +0000 (18:54 +0200)]
[TASK] travis-ci: Less parallel jobs

travis-ci still chockes on functional tests, even if
splitting them among lots of single tasks. Run less
tests in parallel and split to ever more jobs to have
a higher chance for 10 minute output with given cpu
constraints.

Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7
Resolves: #82170
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl 77/53777/2
Jan Helke [Fri, 4 Aug 2017 10:04:38 +0000 (12:04 +0200)]
[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl

This file is only used by typo3/testing-framework and has
been moved to that repository since version 1.1.1.

Releases: master, 8.7
Resolves: #81900
Change-Id: I5f88bd89c4cadd2fe65f4d0bc9f4494e172f4d2a
Reviewed-on: https://review.typo3.org/53777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update typo3/testing-framework to 1.1.1 74/53774/2
Christian Kuhn [Tue, 22 Aug 2017 16:30:27 +0000 (18:30 +0200)]
[TASK] Update typo3/testing-framework to 1.1.1

Fix three issues blocking core patches.

Change-Id: I07deff6294061d04e15bd1a7707e504413bb30c9
Resolves: #82168
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update dev dependencies 72/53772/3
Wouter Wolters [Tue, 22 Aug 2017 14:26:33 +0000 (16:26 +0200)]
[TASK] Update dev dependencies

* codeception/codeception (2.3.3 => 2.3.5)
* enm1989/chromedriver (2.30 => 2.31)
* friendsofphp/php-cs-fixer (v2.0.0 => v2.4.1)

Resolves: #82164
Releases: master, 8.7
Change-Id: I2543b99a7e4751c09ebd733335cc3eddc025d189
Reviewed-on: https://review.typo3.org/53772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Functional tests for translated tt_content rendering in Extbase 56/53756/2
Tymoteusz Motylewski [Sat, 19 Aug 2017 17:16:49 +0000 (19:16 +0200)]
[TASK] Functional tests for translated tt_content rendering in Extbase

Introduce and Extbase version of the LocalizedContentRenderingTest.
It tests how language related TS settings influences content rendering.

Also changes exception code in ContentController, to make bamboo happy.

This test suite is documenting current behaviour, which is in fact
inconsistent with TypoScript tt_content rendering.

The next step is to provide a fix for extbase with a feature switch,
so this test suite will become a version with feature swich being disabled.

Resolves: #81823
Releases: master, 8.7, 7.6
Change-Id: Ia616e5089b0209cfb895216726f7192f39c88a45
Reviewed-on: https://review.typo3.org/53756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
22 months ago[TASK] Remove non existing param from checkForUpdate 55/53755/2
Frans Saris [Mon, 21 Aug 2017 09:49:05 +0000 (11:49 +0200)]
[TASK] Remove non existing param from checkForUpdate

Releases: master, 8,7
Resolves: #82144
Change-Id: I24b2d57e37f6ff95b7ec7bdab7cda0f21e85c90b
Reviewed-on: https://review.typo3.org/53755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[TASK] travis-ci: Split functional tests into more parts 53/53753/2
Christian Kuhn [Mon, 21 Aug 2017 11:43:47 +0000 (13:43 +0200)]
[TASK] travis-ci: Split functional tests into more parts

With the ever growing number of functional tests, we
split the suite into more parts to prevent
"No output has been received in the last 10 mins".

Change-Id: I55665c723f91f77347b376992f7a7a28da67b0fd
Resolves: #82145
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Catch error due to invalid record in Linkvalidator scheduler task 41/53741/2
Andreas Fernandez [Tue, 15 Aug 2017 12:42:06 +0000 (14:42 +0200)]
[BUGFIX] Catch error due to invalid record in Linkvalidator scheduler task

Resolves: #82103
Releases: master, 8.7, 7.6
Change-Id: I3e04559c05381c49ab390dc3ad0d3eebddc5a57f
Reviewed-on: https://review.typo3.org/53741
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record 46/53746/2
Wouter Wolters [Tue, 15 Aug 2017 18:05:14 +0000 (20:05 +0200)]
[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record

The type field contains a non existing field. Do not select this
field in the query.

Resolves: #82105
Releases: master, 8.7, 7.6
Change-Id: I9840712f4f87135740512ddf91a2b921b2515612
Reviewed-on: https://review.typo3.org/53746
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Prevent XSS in scheduler extension 36/53736/3
Wouter Wolters [Thu, 17 Aug 2017 11:37:20 +0000 (13:37 +0200)]
[BUGFIX] Prevent XSS in scheduler extension

Releases: master,8.7,7.6
Resolves: #82079
Change-Id: I21a6ebcff4ebd0c6f2d2c83e0aa6d9e2c03d32d9
Reviewed-on: https://review.typo3.org/53736
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[TASK] Change upper limits for endtime of various records 35/53735/2
Georg Ringer [Thu, 3 Aug 2017 18:23:56 +0000 (20:23 +0200)]
[TASK] Change upper limits for endtime of various records

Instead of using 2020 use the technical limit of 32bit
which is 2038.

Resolves: #81940
Releases: master, 8.7
Change-Id: If0b1bee101b4917d7a974dd0e91f79bc24139227
Reviewed-on: https://review.typo3.org/53735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Fix hide and delete button in SysAction->RecordList 32/53732/2
Wouter Wolters [Fri, 18 Aug 2017 11:50:05 +0000 (13:50 +0200)]
[BUGFIX] Fix hide and delete button in SysAction->RecordList

The AjaxDataHandler JavaScript must be loaded to add the on
click handlers.

Resolves: #81685
Releases: master,8.7
Change-Id: If3616ee99a73171be3a878abce40de7e5c0e8225
Reviewed-on: https://review.typo3.org/53732
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[BUGFIX] Prevent XSS in PageLayoutController 33/53733/2
Wouter Wolters [Thu, 17 Aug 2017 11:32:01 +0000 (13:32 +0200)]
[BUGFIX] Prevent XSS in PageLayoutController

Correctly use htmlspecialchars for the link.

Resolves: #82077
Releases: master,8.7,7.6
Change-Id: I87ea4010aa187f5f601c31423fb1a0fc05a23107
Reviewed-on: https://review.typo3.org/53733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Drop sorting in COUNT() query in list module 80/53680/2
Susanne Moog [Fri, 11 Aug 2017 11:07:18 +0000 (13:07 +0200)]
[BUGFIX] Drop sorting in COUNT() query in list module

The list module throws an exception on mssql as there
is a COUNT(*) query done with an ORDER BY sorting.

Sorting the count is pretty useless and has been
removed.

Change-Id: I8d94da2dc3dfecb7c20308180e9916b16b152b01
Resolves: #82084
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Remove leftover code for db_mountpoints in ActionTask 27/53727/2
Wouter Wolters [Thu, 17 Aug 2017 14:00:59 +0000 (16:00 +0200)]
[TASK] Remove leftover code for db_mountpoints in ActionTask

Resolves: #81999
Releases: master,8.7
Change-Id: Ib3311a4f10d7393b41c04fd193e8614d5984f35f
Reviewed-on: https://review.typo3.org/53727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Correct type of argument passed to BackendUtility::viewOnClick 28/53728/2
Tymoteusz Motylewski [Thu, 17 Aug 2017 15:12:41 +0000 (17:12 +0200)]
[BUGFIX] Correct type of argument passed to BackendUtility::viewOnClick

Third argument passed to BackendUtility::viewOnClick should be
an array or null.

Resolves: #82124
Releases: master, 8.7
Change-Id: I330d2fcbbc30d9f22f4758ad84599755a1d707ad
Reviewed-on: https://review.typo3.org/53728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Use DriverInterface instead AbstractDriver for method signature 25/53725/2
Franz Koch [Sat, 12 Aug 2017 08:14:28 +0000 (10:14 +0200)]
[BUGFIX] Use DriverInterface instead AbstractDriver for method signature

FAL drivers are not obligated to extend the AbstractDriver but only
to implement the DriverInterface. Having custom drivers that are not
based on AbstractDriver (because they are f.e. non hierarchical)
currently causes an Exception because PreviewProcessing expects an
instance of AbstractDriver as method argument.

This patch changes te signature from AbstractDriver to DriverInterface.

Resolves: #82114
Releases: master, 8.7, 7.6
Change-Id: Ia27c6c1c7510ecfe5afd0f7d8bedf81bf3d31c84
Reviewed-on: https://review.typo3.org/53725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Changes indentation in new page wizard 16/53716/2
Thomas Löffler [Mon, 14 Aug 2017 16:26:45 +0000 (18:26 +0200)]
[BUGFIX] Changes indentation in new page wizard

On a page without subpages the indentation for
creating a new page below this page was wrong.
This fix changes the indentation in this special case.

Resolves: #72011
Releases: master, 8.7, 7.6
Change-Id: I505a96126ab8cf69ebae32c5a84aa9dbfa59c87f
Reviewed-on: https://review.typo3.org/53716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Extend Lowlevel lost_files to accept customPath 60/53660/2
Tomas Norre Mikkelsen [Thu, 13 Jul 2017 16:08:37 +0000 (18:08 +0200)]
[BUGFIX] Extend Lowlevel lost_files to accept customPath

This allows the lowlevel lost_files cleaner to use
customPaths as input too.

Resolves: #72202
Releases: master,8.7
Change-Id: I1481d036c8c337eee54a97d8a192d6a39a6af404
Reviewed-on: https://review.typo3.org/53660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Do not allow users to edit doktypes without permissions 61/53661/2
Markus Hoelzle [Wed, 22 Feb 2017 09:27:49 +0000 (10:27 +0100)]
[BUGFIX] Do not allow users to edit doktypes without permissions

Disallow backend users to edit pages which doktypes are not allowed
via backend usergroup permissions.

Resolves: #79954
Releases: master, 8.7, 7.6
Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720
Reviewed-on: https://review.typo3.org/53661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Implode array values in SaveToDatabaseFinisher 05/53705/2
Andreas Fernandez [Wed, 9 Aug 2017 10:11:47 +0000 (12:11 +0200)]
[BUGFIX] Implode array values in SaveToDatabaseFinisher

Array values being processed by SaveToDatabaseFinisher are now
imploded by a comma. This may happen when using a `MultiCheckbox` element.

Resolves: #82061
Releases: master, 8.7
Change-Id: Ic84af11ba00611aa89b043cd3b1c36dedb356c68
Reviewed-on: https://review.typo3.org/53705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] YouTubeRenderer "controls" option 08/53708/2
Česlav Przywara [Mon, 7 Aug 2017 09:40:11 +0000 (11:40 +0200)]
[BUGFIX] YouTubeRenderer "controls" option

The "controls" parameter appended to YouTube embed URL is either set to
value provided in $options array or to default backwards-compatible
value (controls=2).

Specifically, if controls option is set to 0, the controls parameter
must be present in URL, because default value for it is 1.

Fix is applied to related unit test too.

Resolves: #82044
Releases: master, 8.7, 7.6
Change-Id: I1519b5f515f85eb473f590762171b250d26f32c4
Reviewed-on: https://review.typo3.org/53708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Allow to override RTE config presets via PageTS 06/53706/2
Hannes Lau [Sun, 16 Jul 2017 11:51:58 +0000 (13:51 +0200)]
[TASK] Allow to override RTE config presets via PageTS

Reorder the steps to load the RTE configuration, so that presets can be
overridden by additional PageTS configuration.

Resolves: #81882
Releases: master, 8.7
Change-Id: I0189822f8a4a0cf3b8293d6651eac4f8b5159566
Reviewed-on: https://review.typo3.org/53706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] _LOCAL_LANG overwrite via TypoScript with nested keys 04/53704/2
Susanne Moog [Tue, 15 Aug 2017 07:41:08 +0000 (09:41 +0200)]
[BUGFIX] _LOCAL_LANG overwrite via TypoScript with nested keys

If language labels are set for the top level key and sub
keys in TypoScript the top level key was not taken into
account as it got stored with 'typoScriptNodeValue' as key.

Special handling for that specific key was introduced, to
make overwriting of top level keys possible again.

Change-Id: Ibd5f5a939b1de530ba93840cfb7ba5ab5bc85c2f
Resolves: #81095
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53704
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Cover rendering of hidden tt_content with functional tests 02/53702/2
Tymoteusz Motylewski [Mon, 31 Jul 2017 15:16:14 +0000 (17:16 +0200)]
[TASK] Cover rendering of hidden tt_content with functional tests

Two new cases are covered in LocalizedContentRenderingTest:
- when record is hidden in default language but its translation
  is not hidden
- when visible default language record has hidden translation

Resolves: #82012
Releases: master, 8.7, 7.6
Change-Id: I924c0082f010bf9d9de642111cc3d65844f00f1f
Reviewed-on: https://review.typo3.org/53702
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Filter http/verify option for guzzle to boolean 98/53698/3
Wolfgang Klinger [Mon, 7 Aug 2017 06:30:26 +0000 (08:30 +0200)]
[BUGFIX] Filter http/verify option for guzzle to boolean

guzzle expects a real boolean value.
This fix filters the given verify option to either the boolean
equivalent or leaves any other string (path to certificate) as is.

Resolves: #78729
Releases: master, 8.7
Change-Id: I3cc74692303e74b724683e54edad10ecb37e75c7
Reviewed-on: https://review.typo3.org/53698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Do not render <li> in section menu when CE has no header 97/53697/2
Tymoteusz Motylewski [Mon, 14 Aug 2017 14:14:11 +0000 (16:14 +0200)]
[BUGFIX] Do not render <li> in section menu when CE has no header

Section menu is now not rendering empty <li> when CE has no header.

Resolves: #82099
Releases: master, 8.7
Change-Id: I095be0050ac9fa6c4a70ea4d4c942c01def0432f
Reviewed-on: https://review.typo3.org/53697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] EXT:form - fix templateRootPaths support for email finishers 92/53692/2
Ralf Zimmermann [Fri, 30 Jun 2017 09:17:05 +0000 (11:17 +0200)]
[BUGFIX] EXT:form - fix templateRootPaths support for email finishers

Fixes "templateRootPaths" support for email finishers.
"templatePathAndFilename" is still functional to avoid breaking changes.

Resolves: #80974
Releases: master, 8.7
Change-Id: Ic8055a925c0608a9166f98b52c34435ac2a56082
Reviewed-on: https://review.typo3.org/53692
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Set anchor in all preview links of content elements 91/53691/2
Dan Untenzu [Tue, 4 Jul 2017 12:06:03 +0000 (14:06 +0200)]
[BUGFIX] Set anchor in all preview links of content elements

The button »View webpage« in the list module opens a popup
with a link to the current page and an anchor to the
selected content element. This behaviour is expected as well
while selecting the »Show« option in the context menu of
content elements or the »Save and view page« button in
edit forms. Both places didn't added the anchor.

Resolves: #81250
Releases: master, 8.7
Change-Id: Ifa8da940eb12820f9b0c54957928fd8d9f3703b5
Reviewed-on: https://review.typo3.org/53691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] parseInt values before comparison for Fluid be.widget.paginate 88/53688/2
Wolfgang Klinger [Sat, 12 Aug 2017 18:15:48 +0000 (20:15 +0200)]
[BUGFIX] parseInt values before comparison for Fluid be.widget.paginate

Resolves: #82034
Releases: master, 8.7
Change-Id: If56166e33c048a45b01ab70a5938a51525a49db4
Reviewed-on: https://review.typo3.org/53688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Allow translating content on MSSQL 81/53681/2
Susanne Moog [Fri, 11 Aug 2017 10:31:02 +0000 (12:31 +0200)]
[BUGFIX] Allow translating content on MSSQL

Translating content on MSSQL installations has
been impossible due to SQL errors.

The GROUP BY statements in page module and
localizationRepository have been fixed.

Change-Id: I20a4778e3c0858aca80060ba333ce6a47e42ce38
Resolves: #82085
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53681
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
22 months ago[BUGFIX] Let all toplevel exceptions extend the core exception 75/53675/2
Mathias Brodala [Mon, 7 Aug 2017 10:50:16 +0000 (12:50 +0200)]
[BUGFIX] Let all toplevel exceptions extend the core exception

This is a small step to unify exception handling in TYPO3 by
ensuring no internal and 3rd party code is forced to catch the
toplevel PHP exception.

This change e.g. actually allows the FormPagePreviewRenderer to
handle form loading errors.

Resolves: #82052
Releases: master, 8.7
Change-Id: I5cb0b8f2c56a6bbbecc34d87474d6d8b3ad2015c
Reviewed-on: https://review.typo3.org/53675
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Add cglFixMyCommit.bat 78/53678/2
Susanne Moog [Thu, 10 Aug 2017 07:09:38 +0000 (09:09 +0200)]
[TASK] Add cglFixMyCommit.bat

This patch introduces a bat file to run php-cs-fixer
with TYPO3 core config on Windows. It does not disable xdebug
like its linux counterpart.

Change-Id: If4543cac0b5026a8eab469f16e234130f999ba78
Resolves: #81949
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Add sorting to group by for SQL compatibility 76/53676/2
Susanne Moog [Fri, 11 Aug 2017 08:16:01 +0000 (10:16 +0200)]
[BUGFIX] Add sorting to group by for SQL compatibility

Page module, view module and edit document selected data
with an incomplete group by statement, missing the sorting
column. This resulted in an error on mssql servers.

The sorting field was added to the relevant queries.

Change-Id: If1fb314542e0f27cdf18989fa2b8427c1e31e2d3
Resolves: #79298
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53676
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Move install tool entry point to typo3/install.php 20/53620/6
Helmut Hummel [Mon, 24 Jul 2017 13:57:28 +0000 (15:57 +0200)]
[TASK] Move install tool entry point to typo3/install.php

To streamline and unify the entry scripts, the install tool
entry point is now moved to typo3/install.php

Calling the old entry scripts and the shortcut typo3/install/
is deprecated.

All access to public resources is changed to properly use
the resource view helper, so that the path to the assets
are not hard coded any more.

Resolves: #81951
Releases: master, 8.7
Change-Id: Ia8827130bb041802e743767907d16269cda2fef0
Reviewed-on: https://review.typo3.org/53620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Sedef Serin <s.serin@neusta.de>
22 months ago[BUGFIX] New values created by AddController are added correctly 62/53662/2
Andreas Fernandez [Fri, 4 Aug 2017 14:55:25 +0000 (16:55 +0200)]
[BUGFIX] New values created by AddController are added correctly

New values created by AddController are now added again to the FlexForm
value by fixing the value parsing.

Additionally, the mixed up append/prepend values of `setValue` are fixed.

Resolves: #82049
Resolves: #82050
Releases: master, 8.7
Change-Id: Ifc2a4bf4ddd39a1b004db9945f832ca6cf9d765d
Reviewed-on: https://review.typo3.org/53662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Update FAL metadata if file is added with REPLACE method 56/53656/2
Johannes Kasberger [Mon, 7 Aug 2017 16:16:31 +0000 (18:16 +0200)]
[BUGFIX] Update FAL metadata if file is added with REPLACE method

Make sure the meta data is updated whenever a file is added to
a storage with DuplicationBehavior::REPLACE. This is important
as otherwise the internally stored file size is wrong!

Resolves: #78009
Releases: master, 8.7, 7.6
Change-Id: I93b0700afc62268f8c7a61eea7183f86a87a075e
Reviewed-on: https://review.typo3.org/53656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Do not detect single select fields as relation 55/53655/2
Helmut Hummel [Fri, 21 Jul 2017 15:10:05 +0000 (17:10 +0200)]
[BUGFIX] Do not detect single select fields as relation

With https://review.typo3.org/50879/ all TCA select fields
are detected as relation to many, even when they are configured
as simple static select.

This leads to the row value to be pre-set as string (to hold comma
separated values), which leads to an exception in MySQL Strict Mode
when the select value field is defined as integer.

Therefore only detect renderType === selectMultipleSideBySide
as relational field

Resolves: #81043
Releases: master, 8.7
Change-Id: I54effaace3eb19034d86a9a74bbd5cc207e867f1
Reviewed-on: https://review.typo3.org/53655
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Change order of tablename and alias in restriction container 49/53649/2
Sebastian Fischer [Fri, 4 Aug 2017 13:28:13 +0000 (15:28 +0200)]
[BUGFIX] Change order of tablename and alias in restriction container

Changing the order of tablename and alias in method call properties
makes if possible to get correct values from registered restrictions

Resolves: #82046
Releases: master, 8.7
Change-Id: I17151c47c29fb48829ce0d3256ca99a4feadbf4a
Reviewed-on: https://review.typo3.org/53649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[TASK] Extract cli binary into separate package 35/53635/2
Helmut Hummel [Tue, 25 Jul 2017 17:37:43 +0000 (19:37 +0200)]
[TASK] Extract cli binary into separate package

Remove the bin definition in typo3/cms composer.json
And require the package with the binary instead.

Composer command: composer req typo3/cms-cli

Resolves: #81980
Releases: master, 8.7
Change-Id: I504cbd08dd8d57e2b66d974d9f11150c38ab49c8
Reviewed-on: https://review.typo3.org/53635
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
22 months ago[BUGFIX] Jump Links in indexed_search Template 34/53634/2
Achim Fritz [Fri, 14 Jul 2017 20:42:26 +0000 (22:42 +0200)]
[BUGFIX] Jump Links in indexed_search Template

Use Page.Link ViewHelper in indexed_search Search Template for jump links

Resolves: #79982
Releases: master, 8.7
Change-Id: I85a32714c4d098a1afc5b35ab90189e61ba16ea9
Reviewed-on: https://review.typo3.org/53634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Install tool fatal errors at select database action 29/53629/2
Markus Hoelzle [Fri, 14 Jul 2017 21:20:18 +0000 (23:20 +0200)]
[BUGFIX] Install tool fatal errors at select database action

Catch the fatal database exceptions in installation progress
"DatabaseSelect" and show a error message.

Releases: 8.7, master
Resolves: #81726
Change-Id: Id7edbdaafa97374451493d6bb9c9fdaabd2f2674
Reviewed-on: https://review.typo3.org/53629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Prevent PHP warning on entering an empty install tool password 28/53628/2
Markus Hoelzle [Fri, 28 Jul 2017 10:27:26 +0000 (12:27 +0200)]
[BUGFIX] Prevent PHP warning on entering an empty install tool password

Show a useful message if an empty install tool password is entered.

Resolves: #81936
Releases: master, 8.7
Change-Id: I17aaf2aaeb5b31a68c8701cdaa560c00364bea1e
Reviewed-on: https://review.typo3.org/53628
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Catch error in GeneralUtility::validEmail and GeneralUtility:isValidUrl 25/53625/2
Nicole Cordes [Mon, 5 Jun 2017 12:32:31 +0000 (14:32 +0200)]
[BUGFIX] Catch error in GeneralUtility::validEmail and GeneralUtility:isValidUrl

If a wrong email address or URL is parsed and the domain cannot be converted,
an exception is thrown by \Mso\IdnaConvert\IdnaConvert::encode(). This
exception needs to be caught.

Resolves: #81471
Releases: master, 8.7, 7.6
Change-Id: I76f9b8898655d9220e5176a60f388067a6c493b3
Reviewed-on: https://review.typo3.org/53625
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Add conflicts to core extensions' composer.json 18/53618/2
Helmut Hummel [Wed, 26 Jul 2017 15:58:34 +0000 (17:58 +0200)]
[BUGFIX] Add conflicts to core extensions' composer.json

Core extensions installed individually (from subtree split)
must never be installed together with the typo3/cms package

We can avoid this, by adding a conflict section in each
composer.json

Resolves: #81982
Releases: master, 8.7
Change-Id: Ia6a346227852237f58875a3e3216d3cad298f8bf
Reviewed-on: https://review.typo3.org/53618
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
23 months ago[TASK] Max path length checker 11/53611/3
Christian Kuhn [Wed, 26 Jul 2017 09:39:47 +0000 (11:39 +0200)]
[TASK] Max path length checker

Windows still has a relatively short max path length limitation
in some situation which the core tends to violate.
The patch introduces a test script activated in bamboo to test
the relative path length does not exceed an arbitrary number and
shortens some long path segments.
This allows a statement "If your source / unpack location path
prefix is not longer than x characters, you are fine".

Change-Id: If182fd570c8aec28f1bab9687f2712fc3003b4ed
Resolves: #81968
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53611
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Always hide the loading spinner of System Information 05/53605/2
Andreas Fernandez [Thu, 27 Jul 2017 05:40:05 +0000 (07:40 +0200)]
[BUGFIX] Always hide the loading spinner of System Information

If the AJAX request that fetches information for the System Information
toolbar item fails for whatever reason, the spinner is now removed.

This may happen when the session times out and the re-login modal is shown
for a longer period.

Resolves: #81984
Releases: master, 8.7
Change-Id: Ibe9566d29d403e64d55fd0f462d452413d863f0a
Reviewed-on: https://review.typo3.org/53605
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Set TYPO3 version to 8.7.5-dev 89/53589/2
Benni Mack [Tue, 25 Jul 2017 16:09:13 +0000 (18:09 +0200)]
[TASK] Set TYPO3 version to 8.7.5-dev

Change-Id: I130290f15a8bfeeb8868ed3fc03c2fbbf4550605
Reviewed-on: https://review.typo3.org/53589
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[RELEASE] Release of TYPO3 8.7.4 88/53588/2 8.7.4 TYPO3_8-7-4 v8.7.4
Benni Mack [Tue, 25 Jul 2017 16:07:25 +0000 (18:07 +0200)]
[RELEASE] Release of TYPO3 8.7.4

Change-Id: Id00e0758a0e403a707baa6344b8005d6bdb7f798
Reviewed-on: https://review.typo3.org/53588
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] CSS Styled Content should render image captions 84/53584/2
Benni Mack [Tue, 25 Jul 2017 13:40:55 +0000 (15:40 +0200)]
[BUGFIX] CSS Styled Content should render image captions

When adding two CEs with one image each (textpic), the
TypoScript register is using faulty data from file:current:description
for the caption.

This behaviour was fixed with #77645 but now shows that
CSS Styled Content did use this part in a wrong way instead
of using the custom register that is explictly used before.

Resolves: #81866
Releases: 8.7, 7.6
Change-Id: Ia61556a7e65d6a5b2ed0e13db0fbd876c279356e
Reviewed-on: https://review.typo3.org/53584
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[BUGFIX] Prevent error with DateTimePicker on IE/Edge 83/53583/2
Erich Manser [Mon, 24 Jul 2017 07:15:43 +0000 (09:15 +0200)]
[BUGFIX] Prevent error with DateTimePicker on IE/Edge

Change-Id: I3ed07ead31d7f572615916be90ef4c3882360d8b
Resolves: #81729
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53583
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
23 months ago[BUGFIX] Attach CKEditor instance to RteLinkBrowser Modal, so it can be found 86/53586/2
Johannes Schlier [Thu, 20 Jul 2017 13:07:26 +0000 (15:07 +0200)]
[BUGFIX] Attach CKEditor instance to RteLinkBrowser Modal, so it can be found

Previously if the RteLinkBrowser was called from a CKEditor instance that
is within an extra iframe, the CKEditor instance could not be found.
Attaching it directly to the Modal fixes this.

Resolves: #81929
Releases: master, 8.7
Change-Id: I384fc946ed671c12b1e82732f0418a347ee9f01e
Reviewed-on: https://review.typo3.org/53586
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] DataMapProcessor::synchronizeInlineRelations removes entities 81/53581/2
Oliver Hader [Wed, 19 Jul 2017 10:52:41 +0000 (12:52 +0200)]
[BUGFIX] DataMapProcessor::synchronizeInlineRelations removes entities

In case RelationHandler::readForeignField() is called with invalid UID
values for a parent record (e.g. zero, or non-numeric values), all records
might be selected if the database default value for a parent pointer field
is set to zero instead of NULL.

Besides that DataMapProcessor::synchronizeInlineRelations() uses the
mentioned RelationHandler method to resolve suggested and actually
persisted relations. The processing is adjusted to avoid invoking
RelationHandler using non-numeric parent pointer values.

Resolves: #81915
Releases: master, 8.7
Change-Id: I108501c69c9cdb732bb88526830f0f73f2d680af
Reviewed-on: https://review.typo3.org/53581
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[BUGFIX] Use HTTP 400 instead of 500 when client is faulty 80/53580/3
Xavier Perseguers [Fri, 21 Jul 2017 11:53:38 +0000 (13:53 +0200)]
[BUGFIX] Use HTTP 400 instead of 500 when client is faulty

When checking for precondition in the request, HTTP 400 code should
be returned whenever the client is responsible for having issued a
bad request.

HTTP 500 indicates an internal error on the server, which is not the
case under such circumstance.

Change-Id: Ib7e63428b1a84b63e1a2a0c9d95513972be83d33
Resolves: #81941
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53580
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Correct invalid complex query in Doctrine for fetching workspaces 78/53578/2
Xavier Perseguers [Mon, 24 Jul 2017 11:49:05 +0000 (13:49 +0200)]
[BUGFIX] Correct invalid complex query in Doctrine for fetching workspaces

Change-Id: I447274bc29d1a32745224b6cf5c2e2f76c7dfc2f
Resolves: #81947
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53578
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[BUGFIX] Respect lowercase „as“ in quoteIdentifiersForSelect 76/53576/2
Frank Naegler [Mon, 24 Jul 2017 09:33:55 +0000 (11:33 +0200)]
[BUGFIX] Respect lowercase „as“ in quoteIdentifiersForSelect

QueryBuilder->quoteIdentifiersForSelect() now supports lowercase
and mixedcase „as“ to detect alias names for fields.

Resolves: #81946
Releases: master, 8.7
Change-Id: Ib79088e3dd677efd24674d7aa9f5c3f4c973ec8d
Reviewed-on: https://review.typo3.org/53576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
23 months ago[BUGFIX] Make sure correct sys_language_uid is set for irre items 70/53570/2
Frans Saris [Thu, 6 Jul 2017 12:55:04 +0000 (14:55 +0200)]
[BUGFIX] Make sure correct sys_language_uid is set for irre items

Resolves: #76440
Releases: master, 8.7, 7,6
Change-Id: I519641eadd3342369b66252da2d50ca54726aacb
Reviewed-on: https://review.typo3.org/53570
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Unset file properties after signals are triggered 68/53568/2
Helmut Hummel [Sun, 16 Jul 2017 18:06:23 +0000 (20:06 +0200)]
[BUGFIX] Unset file properties after signals are triggered

Unsetting file properties needs to happen AFTER
the storage deleted the file, because the storage emits a signal,
which passes the file object to the slots,
which may need all file properties of the deleted file.

Resolves: #81926
Related: #80359
Releases: master, 8.7, 7.6
Change-Id: Ie8e25b30dd99d1ed2afb8ca7b1cc83797887de98
Reviewed-on: https://review.typo3.org/53568
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] MM Relation with add wizard resets the MM Relation 14/53414/2
Thomas Hohn [Tue, 7 Mar 2017 14:22:07 +0000 (15:22 +0100)]
[BUGFIX] MM Relation with add wizard resets the MM Relation

Use the TcaDatabaseRecord instead of OnTheFly instance. This
in done to ensure what we have the same data as in
TYPO3\CMS\Backend\Controller\EditDocumentController makeEditForm
method.

Resolves: #76863
Relates: #80172
Releases: master, 8.7, 7.6
Change-Id: Ie733491e65169101fda52465e9b980b3db9e20c2
Reviewed-on: https://review.typo3.org/53414
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Outdated resource pointers crash for TCA type group 62/53562/2
Oliver Hader [Wed, 19 Jul 2017 12:24:46 +0000 (14:24 +0200)]
[BUGFIX] Outdated resource pointers crash for TCA type group

Using TCA type "group" with internal_type "folder" crashes in
the backend if existing resource pointers have been moved in
the filesystem (e.g. renamed or deleted).

Resolves: #81918
Releases: master, 8.7, 7.6
Change-Id: I1aadee90d1fe81cd821cc3df594351dbfc101482
Reviewed-on: https://review.typo3.org/53562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Escape value in FormEngine.removeOption selector 57/53557/2
Wolfgang Klinger [Fri, 14 Jul 2017 21:47:49 +0000 (23:47 +0200)]
[BUGFIX] Escape value in FormEngine.removeOption selector

Resolves: #81806
Releases: master, 8.7, 7.6
Change-Id: I1efc630a5579be8c8a1569667253f2572b9261ed
Reviewed-on: https://review.typo3.org/53557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Fix felogin documentation formatting (Configuration chapter) 61/53561/2
Tymoteusz Motylewski [Thu, 20 Jul 2017 14:32:49 +0000 (16:32 +0200)]
[TASK] Fix felogin documentation formatting (Configuration chapter)

https://docs.typo3.org/typo3cms/extensions/felogin/Configuration/Index.html

Resolves: #81934
Releases: master, 8.7
Change-Id: I50217f1d846f4ff40b061921d9757b1df5214d81
Reviewed-on: https://review.typo3.org/53561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Code example in feature .rst 59/53559/2
Jacob Dreesen [Thu, 20 Jul 2017 11:50:50 +0000 (13:50 +0200)]
[BUGFIX] Code example in feature .rst

Releases: master, 8.7
Resolves: #81928
Change-Id: I7dc15a12e54f11630d162e670e04fb793b07aa5f
Reviewed-on: https://review.typo3.org/53559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Allow to override RTE config via PageTS 51/53551/2
Hannes Lau [Sat, 15 Jul 2017 13:29:00 +0000 (15:29 +0200)]
[BUGFIX] Allow to override RTE config via PageTS

Fix the merging of YAML and PageTS provided RTE configuration to allow
editor configuration via PageTS

Resolves: #81880
Releases: master, 8.7
Change-Id: Ic06627686b6ee77d79df34a6dda7b5610ccb06cb
Reviewed-on: https://review.typo3.org/53551
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] EXT:form - add email finishers explanations 47/53547/2
Ralf Zimmermann [Wed, 5 Jul 2017 10:34:00 +0000 (12:34 +0200)]
[TASK] EXT:form - add email finishers explanations

Reduce confusion caused by the naming of the email finishers and
add some explanations to the recipient address/name and
sender address/name properties.

Resolves: #81798
Releases: master, 8.7
Change-Id: I0dc12e2983d7cb1204bdfc9709265c8c034a58f6
Reviewed-on: https://review.typo3.org/53547
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] EXT:form - add missing documentation for select element options 49/53549/2
Ralf Zimmermann [Wed, 5 Jul 2017 09:08:22 +0000 (11:08 +0200)]
[TASK] EXT:form - add missing documentation for select element options

Add documentation for select elements "prependOptionLabel" and
"prependOptionValue" options.

Resolves: #81797
Releases: master, 8.7
Change-Id: I0fd1d3ccbe7e2a2cbcbb08c7c30d81376353cda3
Reviewed-on: https://review.typo3.org/53549
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] EXT:form - fix wrong "templateFileName" usage within the docs 48/53548/2
Ralf Zimmermann [Wed, 5 Jul 2017 10:41:43 +0000 (12:41 +0200)]
[BUGFIX] EXT:form - fix wrong "templateFileName" usage within the docs

Resolves: #81799
Releases: master, 8.7
Change-Id: I89a653bf58376e42a02da0fefd5bbc7879a07a45
Reviewed-on: https://review.typo3.org/53548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] Remove the dependency of EXT:tstemplate to EXT:frontend 50/53550/2
Georg Ringer [Sun, 16 Jul 2017 10:37:00 +0000 (12:37 +0200)]
[TASK] Remove the dependency of EXT:tstemplate to EXT:frontend

Use the RootlineUtility directly in EXT:tstemplate to get
the rootline instead of using EXT:frontend which then
calls the RootlineUtility.

Resolves: #81889
Releases: master, 8.7
Change-Id: I66153204db4e1b67bf0a80efe1c5d2c73ce585fa
Reviewed-on: https://review.typo3.org/53550
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] EXT:form - Add documentation 22/53422/3
Ralf Zimmermann [Tue, 18 Apr 2017 16:29:18 +0000 (18:29 +0200)]
[TASK] EXT:form - Add documentation

Resolves: #80198
Releases: master,8.7
Change-Id: Iaad2a96c2b1d7413220521dc188b09700110e391
Reviewed-on: https://review.typo3.org/53422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Show message if no extension repo exists in extensionmanager 36/53536/2
Markus Hoelzle [Fri, 14 Jul 2017 19:26:24 +0000 (21:26 +0200)]
[BUGFIX] Show message if no extension repo exists in extensionmanager

Show a useful error message instead an exception in extensionmanager on
update extension list.

Releases: 7.6, 8.7, master
Resolves: #81146
Change-Id: I9989d17890c381a12f17a0806b46ce269ab1ca5d
Reviewed-on: https://review.typo3.org/53536
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Correct composer.json files of system extensions 37/53537/2
Georg Ringer [Fri, 14 Jul 2017 12:11:51 +0000 (14:11 +0200)]
[TASK] Correct composer.json files of system extensions

- add autoload-dev if missing
- add class-alias-map if missing

Resolves: #81867
Releases: master, 8.7
Change-Id: I2643125f2a9761cc7968563323eeeb020b279dde
Reviewed-on: https://review.typo3.org/53537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Create missing files/folders for ExtensionCompatibilityTester 35/53535/2
Christoph Bessei [Wed, 14 Jun 2017 19:56:34 +0000 (21:56 +0200)]
[BUGFIX] Create missing files/folders for ExtensionCompatibilityTester

* Create path to errorProtocolFile if it doesn't exist yet
* Create empty errorProtocolFile to avoid 404 errors

Resolves: #80547
Releases: master,8.7
Change-Id: I302909189d7ff4600325c91e525d9924810c4c5c
Reviewed-on: https://review.typo3.org/53535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Fix multi edit link in TableListViewHelper 34/53534/2
Georg Ringer [Fri, 14 Jul 2017 17:15:54 +0000 (19:15 +0200)]
[BUGFIX] Fix multi edit link in TableListViewHelper

Load the proper requireJS module and provide the variable
T3_THIS_LOCATION to make the multi edit links working again.

Resolves: #81850
Releases: master, 8.7
Change-Id: I45af43359f4f9ee8fbd9da51a3a434c40dda9d4e
Reviewed-on: https://review.typo3.org/53534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Clone ObjectStorage in ObjectAccess 33/53533/2
Daniel Goerz [Sat, 15 Jul 2017 16:45:25 +0000 (18:45 +0200)]
[BUGFIX] Clone ObjectStorage in ObjectAccess

The ObjectStorage Object passed to iterator_to_array() ends up
with the pointer at the last item, so that any ongoing iteration
through the ObjectStorage wrapping the call of ObjectAccess is
interrupted.
This patch ensures that the ObjectStorage is cloned before converted
to an array so that the original object keeps it original iteration
state.

Resolves: #81597
Relates: #66995
Releases: master, 8.7
Change-Id: Ied025ff616e100cc5eb5dedd5b7b6a95293ddfcf
Reviewed-on: https://review.typo3.org/53533
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Optimize comment for sys_language_contentOL 27/53527/2
Ruslan Steiger [Fri, 14 Jul 2017 20:26:05 +0000 (22:26 +0200)]
[TASK] Optimize comment for sys_language_contentOL

Resolves: #81622
Releases: master, 8.7
Change-Id: Ibe6097846cd7945ef5dc9808d936346591fa1d56
Reviewed-on: https://review.typo3.org/53527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[BUGFIX] Allow cloning of the QueryBuilder 24/53524/2
Tymoteusz Motylewski [Sat, 8 Jul 2017 16:08:12 +0000 (18:08 +0200)]
[BUGFIX] Allow cloning of the QueryBuilder

In order to be able to implement pagination
it has to be possible to clone QueryBuilder.

Doctrine query builder already supports cloning,
so it's just about allowing it in our wrapper.

Resolves: #81822
Releases: master, 8.7
Change-Id: I059bdc51d1181cac08a3d9f30de174b025c6e89d
Reviewed-on: https://review.typo3.org/53524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Fixes required CKeditor fields in flexforms 19/53519/2
Armin Vieweg [Fri, 14 Jul 2017 20:31:48 +0000 (22:31 +0200)]
[BUGFIX] Fixes required CKeditor fields in flexforms

CKeditor throwed errors in javascript, when field identifier
contained dot's. Using array syntax for CKEDITOR.instances
solved this issue.

Releases: master, 8.7
Resolves: #81390
Change-Id: I1f876de7aab1b6370aa89420600079c1439d339d
Reviewed-on: https://review.typo3.org/53519
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Fix broken icon for 'Federated States of Micronesia' in sys_language 17/53517/2
Moritz von Wirth [Sat, 15 Jul 2017 09:20:50 +0000 (11:20 +0200)]
[BUGFIX] Fix broken icon for 'Federated States of Micronesia' in sys_language

If someone has 'Federated States of Micronesia' selected in "Select flag icon"
the value will become invalid after this patch is applied.
It has to be manually changed to "fm" by the editor.

Resolves: #81878
Releases: master, 8.7
Change-Id: Ia60e12138495ade51e4c45da1533ff3cc3826d06
Reviewed-on: https://review.typo3.org/53517
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Info->Pagetree overview - Drop "red plus" icon 16/53516/2
Tim Spiekerkötter [Fri, 14 Jul 2017 20:32:39 +0000 (22:32 +0200)]
[BUGFIX] Info->Pagetree overview - Drop "red plus" icon

The "red plus" "has sub pages" indicator in Info->pagetree Overview
brings no sane and usable benefit and is dropped.

Resolves: #81872
Releases: master, 8.7
Change-Id: Ifb68d47ae48b0db1a68001644062fd7dd6d7126a
Reviewed-on: https://review.typo3.org/53516
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Correct label for cut release in clickmenu 15/53515/2
Christian Fries [Fri, 14 Jul 2017 21:33:57 +0000 (23:33 +0200)]
[BUGFIX] Correct label for cut release in clickmenu

Add different label for cut release in clickmenu instead of using
the same label as cut.

Releases: master, 8.7
Resolves: #81875
Change-Id: I80b5247133e3a9a92888d38e9c6b5a435e2342c1
Reviewed-on: https://review.typo3.org/53515
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Fix syntax error in RST file 14/53514/2
Daniel Siepmann [Sat, 15 Jul 2017 09:26:04 +0000 (11:26 +0200)]
[TASK] Fix syntax error in RST file

As some might copy and paste the configuration structure, there should be
no syntax error.
Therefore the missing comma was added.

Releases: master, 8.7
Resolves: #81879
Change-Id: Icaa718fd29ffd52ea1cf9f858ed61b599cfc0ba9
Reviewed-on: https://review.typo3.org/53514
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Don't duplicate thumbnails in file list and file selector 08/53508/2
Tymoteusz Motylewski [Tue, 4 Jul 2017 20:03:27 +0000 (22:03 +0200)]
[BUGFIX] Don't duplicate thumbnails in file list and file selector

Default width and height for thumbnails is now applied in ProcessedFile
thus configuration column of the sys_file_processedfile table is filled
even if empty configuration was passed to File->Process().

This prevents thumbnails with the same content but different names being
generated, thus improves performance.

Resolves: #81776
Releases: master, 8.7, 7.6
Change-Id: Ie001e3d6404b52c251d9ed24bcac461ed75050b8
Reviewed-on: https://review.typo3.org/53508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[BUGFIX] Allow comma in config.linkVars values 07/53507/2
Sascha Egerer [Fri, 14 Jul 2017 15:56:48 +0000 (17:56 +0200)]
[BUGFIX] Allow comma in config.linkVars values

The config.linkVars TypoScript setting is splitted by comma.
This will fail if the optional value, wrapped by braces,
does contain a comma.
The string must only be splitted by commas that are not inside
of braces.

Resolves: #81810
Releases: master,8.7
Change-Id: If11615b0f4ed9ca55aea4ac3baf79284b35da398
Reviewed-on: https://review.typo3.org/53507
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] Add attribute "placeholder" to PasswordViewHelper 02/53502/2
Daniel Diesenreither [Fri, 14 Jul 2017 21:58:07 +0000 (23:58 +0200)]
[TASK] Add attribute "placeholder" to PasswordViewHelper

Resolves: #81873
Releases: master, 8.7
Change-Id: I99af134d1d6afe14c66de7a950da5f73bee1c1bb
Reviewed-on: https://review.typo3.org/53502
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Indexed search has wrong language keys in search template 95/53495/2
Jörg Bösche [Fri, 14 Jul 2017 20:01:23 +0000 (22:01 +0200)]
[BUGFIX] Indexed search has wrong language keys in search template

The search template uses language keys from the old pi base
language file and has to replaced with the keys from locallang.xlf.

Releases: master,8.7
Resolves: #79984
Change-Id: Ic68543e3921dbf58baab50538787ac785e189d65
Reviewed-on: https://review.typo3.org/53495
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Allow any navigation component to load in BE 89/53489/2
Benni Mack [Tue, 28 Feb 2017 10:12:32 +0000 (11:12 +0100)]
[BUGFIX] Allow any navigation component to load in BE

Since the ExtJS viewport refactoring in 8.5, it is not possible
anymore to load any other registered navigation component,
which makes EXT:commerce to not work anymore.

The patch changes the hard-coded pagetree app component
to fetch it from the pool of available navigation components.

Resolves: #80058
Releases: master, 8.7
Change-Id: I49be1b0b231f6085a7a9e9d5c633b073a92ad301
Reviewed-on: https://review.typo3.org/53489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Replace empty value constants in TypoScript Object-Browser 91/53491/2
Pascal Hinz [Wed, 5 Jul 2017 12:19:26 +0000 (14:19 +0200)]
[BUGFIX] Replace empty value constants in TypoScript Object-Browser

After the constants replacement was changed to a regular expression,
the expression doesn't match empty value constants and leaves the
markers untouched. With this bugfix the regular expression also
replaces empty values.

Resolves: #81773
Releases: master, 8.7, 7.6
Change-Id: I0346b2d0d81b09dc63e52e34f28581dc40cd1fac
Reviewed-on: https://review.typo3.org/53491
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[TASK] Style select in EXT:saltedpasswords with bootstrap 74/53474/2
Georg Ringer [Thu, 13 Jul 2017 16:59:48 +0000 (18:59 +0200)]
[TASK] Style select in EXT:saltedpasswords with bootstrap

Style the select box in extension configuration of EXT:saltedpasswords.

Resolves: #81860
Releases: master, 8.7
Change-Id: I78fc38390463b6e20590b51a356d19f998fc67f8
Reviewed-on: https://review.typo3.org/53474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Respect default label in TranslateViewHelper again 73/53473/2
Daniel Goerz [Thu, 13 Jul 2017 20:54:40 +0000 (22:54 +0200)]
[BUGFIX] Respect default label in TranslateViewHelper again

Resolves: #81862
Related: #81168
Releases: master, 8.7
Change-Id: Iee90dd123da8f445544e06ce9b61a83be2ff662b
Reviewed-on: https://review.typo3.org/53473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Fix database query in StaticRecordCollection 69/53469/2
Tymoteusz Motylewski [Sat, 8 Jul 2017 17:44:10 +0000 (19:44 +0200)]
[BUGFIX] Fix database query in StaticRecordCollection

Fix the query to fetch collection records to use an alias for the
foreign table instead of the MM tables and properly join on uid_local
and uid_foreign.

Change-Id: Idf9bacd84f4a2980470183ede034e7edaa489a3f
Resolves: #81353
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53469
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] Unify ext_emconf setting clearCacheOnLoad 63/53463/3
Georg Ringer [Wed, 12 Jul 2017 12:13:08 +0000 (14:13 +0200)]
[TASK] Unify ext_emconf setting clearCacheOnLoad

Some system extensions are using a lowercase version
of this setting. Unify to the correct one.

The extension manager still checks both versions

Resolves: #81841
Releases: master, 8.7
Change-Id: Id3ef5741b1accded57405ffb86132640f1079632
Reviewed-on: https://review.typo3.org/53463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>