Packages/TYPO3.CMS.git
5 years ago[FEATURE] New FAL Indexer and ExtractorRegistry 70/25370/6
Steffen Ritter [Wed, 13 Nov 2013 12:09:18 +0000 (13:09 +0100)]
[FEATURE] New FAL Indexer and ExtractorRegistry

A new Indexer for FAL according to the concept of the BluePrint, also
adding a new ExtractorRegistry where extensions can register their
extraction classes (implementing ExtractorInterface).

See: http://wiki.typo3.org/Blueprints/FAL-IndexerRework

Releases: 6.2
Resolves: #52841, #53599
Change-Id: I06e8d011096c88221aaf62bd0a25e681692dbfa0
Reviewed-on: https://review.typo3.org/25370
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Renaming file does not update hash values 51/25451/4
Frans Saris [Fri, 15 Nov 2013 19:12:29 +0000 (20:12 +0100)]
[BUGFIX] Renaming file does not update hash values

When you rename a file the indentifier in the sys_file record
is updated but the indentifier_hash and folder_hash are not.
This results in a new sys_file record when accessing the
renamed/moved file.

Now when the identifier is changed the identifier and folder hash
are updated.

Releases: 6.2
Resolves: #53614
Change-Id: Iad7559d15705ab836e88860b1b198783f0420386
Reviewed-on: https://review.typo3.org/25451
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years agoRevert "[BUGFIX] EM: Fetch list as html, not as json" 46/25446/4
Helmut Hummel [Fri, 15 Nov 2013 17:40:37 +0000 (18:40 +0100)]
Revert "[BUGFIX] EM: Fetch list as html, not as json"

This reverts commit 8a80c2336eabed5c794b2401981b1d35608787e1

This change did not work at all, left unused
templates behind (List/Ter.json),
and caused further bugs #53661

Change-Id: I62d1c6c06a5acb8aeed0a12226b3e7ed1bd3282b
Reviewed-on: https://review.typo3.org/25446
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Remove table prefix check in CONTENT 16/25316/3
Marc Bastian Heinrichs [Tue, 12 Nov 2013 15:10:27 +0000 (17:10 +0200)]
[BUGFIX] Remove table prefix check in CONTENT

Records of sys_category could not be rendered with
the content object CONTENT, because only tables
prefixed with pages,tt,fe,tx,ttx,user and static are
allowed. Nowadays this limitation isn't practical
anymore, because other tables don't matching the
prefix will follow.

Resolves: #44961
Releases: 6.2
Change-Id: Iab6671edff8d6f3558ca4a56caa4dae797c66187
Reviewed-on: https://review.typo3.org/25316
Reviewed-by: Helmut Hummel
Reviewed-by: Ernesto Baschny
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove hash_base from page cache data 91/25191/11
Alexander Opitz [Fri, 15 Nov 2013 15:57:32 +0000 (16:57 +0100)]
[TASK] Remove hash_base from page cache data

The hash_base (the array from which the cache hash is calculated) is
saved into the cache. But this information isn't required. Also it isn't
processed after read from cache. So this data gets removed to save
bandwidth and to reduce the string to be unserialized.

Resolves: #53404
Releases: 6.2
Change-Id: I76411a9d89e483fed1b29573359b001fa921b244
Reviewed-on: https://review.typo3.org/25191
Reviewed-by: Mathias Schreiber
Tested-by: Mathias Schreiber
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Correct old naming "Text w/image" into "Text & Images" 21/25421/2
Alexander Opitz [Fri, 15 Nov 2013 12:13:15 +0000 (13:13 +0100)]
[BUGFIX] Correct old naming "Text w/image" into "Text & Images"

The content element was renamed long time ago, so the documentation
should be updated.

Resolves: #22914
Releases: 6.2
Change-Id: Ia2948c8fe7b9f9ca2b348773546ebf0b1e9718b1
Reviewed-on: https://review.typo3.org/25421
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] no hover effect for db_list 09/25409/2
Stefan Froemken [Thu, 14 Nov 2013 19:44:15 +0000 (20:44 +0100)]
[BUGFIX] no hover effect for db_list

If alternateBgColors in pageTSconfig is set
you have more contrast in db_list, but there
is no hover effect for the darker rows

Resolves: #23536
Releases: 6.2, 6.1, 6.0
Change-Id: If17aa33e414edda0ea1ce8bf3b5ca1576a759c11
Reviewed-on: https://review.typo3.org/25409
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] foreign_match_fields not fully supported 20/21120/5
Stefan Froemken [Mon, 7 Oct 2013 11:15:06 +0000 (13:15 +0200)]
[BUGFIX] foreign_match_fields not fully supported

foreign_match_fields were not fully supported
Resolves: #47694
Relates: #45337
Releases: 6.2, 6.1
Change-Id: I212cbdb5d4a3791c1d8ed1e431007e10dd9f11e8
Reviewed-on: https://review.typo3.org/21120
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FILES.folder does not work 16/25016/2
Stefan Froemken [Sat, 26 Oct 2013 13:58:27 +0000 (15:58 +0200)]
[BUGFIX] FILES.folder does not work

cObject IMAGE was executed with empty values
because given key contains filenames instead of
numbers

Resolves: #45724
Releases: 6.2, 6.1, 6.0
Change-Id: I5582b63080b7e6124c3780a8430efb410876a662
Reviewed-on: https://review.typo3.org/25016
Reviewed-by: Gernot Ploiner
Tested-by: Gernot Ploiner
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Em: Get preconfigured distribution causes warning 01/25401/2
Nicole Cordes [Thu, 14 Nov 2013 13:41:47 +0000 (14:41 +0100)]
[BUGFIX] Em: Get preconfigured distribution causes warning

This patch adds an early return for empty file name which happens if an
extension isn't installed.

Resolves: #53641
Releases: 6.2
Change-Id: I1cc3605bf5cddfd4e83c363b974a83d20172d0ce
Reviewed-on: https://review.typo3.org/25401
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Render extension icons in EM directly 93/25393/5
Jigal van Hemert [Thu, 14 Nov 2013 06:07:47 +0000 (07:07 +0100)]
[TASK] Render extension icons in EM directly

To increase performance of building the extension list the icons are
rendered directly instead of using an image viewhelper. The height is
corrected using CSS.

Change-Id: I60ddbdf409ed67a668f556cdcbc01799097a8109
Resolves: #53627
Releases: 6.2
Reviewed-on: https://review.typo3.org/25393
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Install Tool: Show titles of failed image tests 96/25396/2
Sebastian Michaelsen [Thu, 14 Nov 2013 09:13:50 +0000 (10:13 +0100)]
[BUGFIX] Install Tool: Show titles of failed image tests

"Test image formats" tries to convert different media types
to JPG. If one of these conversions fails, you will get an
error message but no hint about what media type failed to convert.

Change-Id: Ie35c7e3529064c99cb8b3ef7d6eb542142b58a56
Resolves: #53632
Releases: 6.2
Reviewed-on: https://review.typo3.org/25396
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Dan Untenzu
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] FormDataTraverser::getFieldValueRecursive() might return NULL 66/25366/2
Oliver Hader [Wed, 13 Nov 2013 09:52:29 +0000 (10:52 +0100)]
[TASK] FormDataTraverser::getFieldValueRecursive() might return NULL

FormDataTraverser::getFieldValueRecursive() might return NULL or
any other type as well, as it has been provided by the database.
Thus, PHPdoc comments are modified to reflect the possible return
values as well.

Fixes: #53573
Releases: 6.2
Change-Id: Idcdbe21ccdcf694b8ceb5ecf0b4a192ad51c4871
Reviewed-on: https://review.typo3.org/25366
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix broken edit icons on cType HTML 62/20562/3
Loek Hilgersom [Mon, 6 May 2013 20:13:29 +0000 (22:13 +0200)]
[BUGFIX] Fix broken edit icons on cType HTML

Fix the wrong Typoscript configuration for front-end edit icons
for cType HTML (for the traditional fe-editing).

Resolves: #17493
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I743d8d8ee77bd76bd9ed2a12cd34817196d3719a
Reviewed-on: https://review.typo3.org/20562
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Use default BE layout if current not available 74/25374/2
Georg Ringer [Wed, 13 Nov 2013 13:21:39 +0000 (14:21 +0100)]
[BUGFIX] Use default BE layout if current not available

If a specific backend layout is selected in the page properties
and the backend layout is removed later on, the page module is
empty and shows nothing. As a solution the default layout should
be loaded like it is the case if no BE layout is defined at all.

Resolves: #53608
Releases: 6.2
Change-Id: I192833aacc4785a7dfd8e1fb5ed34f12e33d4f5c
Reviewed-on: https://review.typo3.org/25374
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Distinguish unassigend columns and colPos 0 49/18349/7
Georg Ringer [Sun, 17 Feb 2013 17:06:51 +0000 (18:06 +0100)]
[BUGFIX] Distinguish unassigend columns and colPos 0

When using backend layout columns without a colPos value they should be
just placeholders with the label "not assigned". Currently they are
showing the content of the column 0 instead if there is such a column in
the backend layout.

The label "not assigned" is used for columns without any
label, otherwise the label is used together with the suffix
"(not assigned)".

Change-Id: I02c418eebdd9345c3066aa8c3eeec353d2cd9e58
Resolves: #25157
Resolves: #45550
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/18349
Reviewed-by: Carsten Lausen
Tested-by: Carsten Lausen
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
5 years ago[TASK][!!!] Extend FAL Api for more efficient usage 63/25363/4
Steffen Ritter [Wed, 13 Nov 2013 09:03:49 +0000 (10:03 +0100)]
[TASK][!!!] Extend FAL Api for more efficient usage

This changeset extends the Driver-API to allow the ResourceStorage
to list Files in a Folder (recursively) without getting the whole
FileInformation array. Extracting the FileInformation is very
expensive in terms of IO and runtime.

Additionally when doing IndexMaintenance it might be useful to
check if the File changed (content-wise) and therefore must be
hashed. While indexing you might not yet have a FileObject
since you are just about to create it. Therefore a HashFile
Method in ResourceStorage is extended to do that just based on
the Identifier.

Since this change already breaks the Driver API and we decided
that architecturally it is not wise, that the driver knows
about object and not only about identifiers, the hash method
is changed accordingly there, too.

Since only the ResourceStorage is allowed to access the Driver
objects directly this is only relevant for custom driver
implementations.

Releases: 6.2
Resolves: #53585
Change-Id: I6ec47e9071550826aab4f4886700772254cfc8d0
Reviewed-on: https://review.typo3.org/25363
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Native date and datetime values do not consider timezone 49/23749/2
Oliver Hader [Wed, 11 Sep 2013 14:12:20 +0000 (16:12 +0200)]
[BUGFIX] Native date and datetime values do not consider timezone

The TCA configuration property "dbType" allows to store "date"
or "datetime" values directly in the database (instead of using
a timestamp value).
However, the timezone is not recognized correctly - besides that,
the serverTimeZone is applied which does not make much sense at
all, since it leaves out DST handling.

Fixes: #51918
Releases: 6.0, 6.1, 6.2
Change-Id: I45da65d8cee2611358303e93305cb5c793223746
Reviewed-on: https://review.typo3.org/23749
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Remove useless comment in layout of viewpage 62/25362/3
Eric Chavaillaz [Wed, 13 Nov 2013 08:17:24 +0000 (09:17 +0100)]
[TASK] Remove useless comment in layout of viewpage

Since rendering of the view icon has changed,
the comment above it is now useless.

Resolves: #53581
Releases: 6.2
Change-Id: I6fcf8150361fda8607eea602aae47d0a39db2005
Reviewed-on: https://review.typo3.org/25362
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Responsive Images - Remove whitespaces in tags 67/25067/4
Sascha Egerer [Wed, 30 Oct 2013 09:52:51 +0000 (10:52 +0100)]
[BUGFIX] Responsive Images - Remove whitespaces in tags

Remove some unnecessary whitespaces in the html
tags that are genereted by the responsive image feature.

Resolves: #53220
Releases: 6.2
Change-Id: I49e73d92c74a1d3e656b0e847b22473cecf19a53
Reviewed-on: https://review.typo3.org/25067
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] RWD Images data Attribute is not wrapped with space 00/25000/3
Ingo Schmitt [Fri, 25 Oct 2013 07:36:27 +0000 (09:36 +0200)]
[BUGFIX] RWD Images data Attribute is not wrapped with space

added noTrimWrap to data.source

Resolves: #53003
Releases: 6.2
Change-Id: I2287c491ff9a04686bec934420819a970e9066d4
Reviewed-on: https://review.typo3.org/25000
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong usage-text for cli_dispatch 03/25303/2
Tomita Militaru [Tue, 12 Nov 2013 12:05:14 +0000 (14:05 +0200)]
[BUGFIX] Wrong usage-text for cli_dispatch

Correct usage text for cli_dispatch, use --refindex update
instead of -e

Resolves: #53399
Releases: 6.2, 6.1, 6.0
Change-Id: I6e571e8ba1cc139c7a4004800491637d5b3af6d7
Reviewed-on: https://review.typo3.org/25303
Tested-by: Jan Bartels
Reviewed-by: Jan Bartels
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[!!!][DB][BUGFIX] Update all storages in upgrade wizard 39/25339/5
Nicole Cordes [Tue, 12 Nov 2013 21:14:49 +0000 (22:14 +0100)]
[!!!][DB][BUGFIX] Update all storages in upgrade wizard

With commit I805085948e01544efd692498f5e3537612c62050 a new hash was
introduced to sys_file table. The updater misses to update all storages
except the one with uid=1. Furthermore the default storage zero, where
all core related files are stored, is missing completely.
This triggers a fatal error all over the backend.

This patch adds the default storage and fixes the bug, which
did not update other storages beside uid=1.

It is very important to run the upgrade wizard in the
Install Tool after this patch is applied.

Resolves: #53575
Releases: 6.2
Change-Id: Ifa60e8b4e3bf50159b7475cc9af5dab0274340cd
Reviewed-on: https://review.typo3.org/25339
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Tested-by: Christian Kuhn
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] dataTables: Avoid sending cookie-data too often 85/24885/2
Stefan Neufeind [Thu, 17 Oct 2013 23:05:25 +0000 (01:05 +0200)]
[BUGFIX] dataTables: Avoid sending cookie-data too often

All core-modules currently using jQuery-dataTables are
called through mod.php. So by adding that to the
cookie-path we can at least prevent sending those cookies
with requests like JS/CSS/images.

Change-Id: Ia9ea30e8967564572c7104600eb8dcc67647382d
Resolves: #52934
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24885
Reviewed-by: Sebastian Fischer
Reviewed-by: Pascal Dürsteler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor PageRenderer tests 04/25304/3
Christian Kuhn [Sun, 10 Nov 2013 12:57:21 +0000 (13:57 +0100)]
[TASK] Refactor PageRenderer tests

The existing tests of ext:core/Page/PageRenderer are in fact
functional tests since most of them trigger lots of dependencies
and call the main API method "render()" to check for something.

The patch moves most detail tests to two general functional tests
doing the main work and adds some more functional tests for more
specific cases.
The unit tests are stripped down to those parts that test only single
methods or smaller systems with proper mocking.

In effect, the full unit test suite does no longer depend on
initialization of $GLOBALS['LANG'], it is now removed from unit
test bootstrap.

Change-Id: I9f3f54ba52673e16bfcd303b46755e079d240de6
Resolves: #53558
Related: #51436
Related: #53476
Releases: 6.2
Reviewed-on: https://review.typo3.org/25304
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] EM: Mask overlay stays active after error message 09/25309/2
Nicole Cordes [Tue, 12 Nov 2013 13:37:01 +0000 (14:37 +0100)]
[BUGFIX] EM: Mask overlay stays active after error message

If you try to install a new extension from TER which is incompatible
with the current TYPO3 version, an error is shown but the loading mask
isn't removed. This patch unmask the overlay to be able to work again.

Resolves: #53460
Releases: 6.2
Change-Id: Ibf9a31de6a8f56715e20ba5b5f2c49e555b16e12
Reviewed-on: https://review.typo3.org/25309
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[FEATURE] Make getPlaceholderValue recursive for __row 37/24537/12
Alexander Stehlik [Wed, 30 Oct 2013 20:39:35 +0000 (21:39 +0100)]
[FEATURE] Make getPlaceholderValue recursive for __row

If __row|uid_foreign|field is a reference its not evaluated
recursive the placeholder shows a uid. With this patch the
content of the field is shown.

Additonally the type of the metadata field of sys_file was changed
to inline because select does not support the foreign_field property.

Resolves: #52630
Releases: 6.2
Change-Id: Iee30274d2e94f73e877b761d119801bb205689c1
Reviewed-on: https://review.typo3.org/24537
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] sys_file.metadata does not use TCA type inline 20/25320/2
Oliver Hader [Tue, 12 Nov 2013 15:33:24 +0000 (16:33 +0100)]
[BUGFIX] sys_file.metadata does not use TCA type inline

The field sys_file.metadata defines the TCA property
"foreign_field" that is only defined for the TCA type "inline".
Using "foreign_field" with the select type does not make much
sense, since select elements can be seen as m:n reference that
is persisted with each parent record and thus could have
multiple parents.

Fixes: #53567
Releases: 6.2
Change-Id: I2c8e12b6343275d7f38853ba25ac6a0427c13dbd
Reviewed-on: https://review.typo3.org/25320
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] File identifiers are case-insensitive 98/23398/10
Andreas Wolf [Wed, 28 Aug 2013 11:25:37 +0000 (13:25 +0200)]
[BUGFIX] File identifiers are case-insensitive

With the default collations used by most databases, casing is ignored.
This leads to problems when searching for an entry in the file database:
If there are two files with the same name in different casings, only one
of the two will be indexed. This index record will be used for both
files, as the database does not see a difference when querying for their
identifiers.

The problem is solved by this commit with the help of a new field
identifier_hash. To also solve the problems arising on case-insensitive
file systems (where all casings are possible and thus the same file
could be indexed multiple times when being created with differently
cased identifiers), file identifiers for these storages are converted to
all-lowercase before hashing.

Change-Id: I805085948e01544efd692498f5e3537612c62050
Resolves: #43027
Resolves: #46553
Resolves: #45504
Releases: 6.2
Reviewed-on: https://review.typo3.org/23398
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Evaluator in JS fails with namespaces 41/25041/7
Stefan Aebischer [Mon, 28 Oct 2013 22:07:09 +0000 (23:07 +0100)]
[BUGFIX] Evaluator in JS fails with namespaces

If you add an own evaluator, you have to insert the
class inclusive namespaces. JavaScript in TYPO3
backend fails to use the correct class set in
namespaces.

Resolves: #52904
Releases: 6.2,6.1,6.0
Change-Id: I356a2a7ff169462307506c64234741e6a690f8e2
Reviewed-on: https://review.typo3.org/25041
Reviewed-by: Stefan Aebischer
Reviewed-by: Felix Nagel
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Blank page in Firefox view module 48/24948/5
Stefan Neufeind [Mon, 11 Nov 2013 22:09:33 +0000 (23:09 +0100)]
[BUGFIX] Blank page in Firefox view module

When you click on the view icon of the view module,
a new page is opened to the website. In Firefox,
if you return to the TYPO3 backend in the view mod,
you got a blank page with a [object Window] text.

Resolves: #52616
Releases: 6.2
Change-Id: If81ecea02550a6ef72f15deeeb40bc74e36ee431
Reviewed-on: https://review.typo3.org/24948
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Make be.buttons.icon-ViewHelper extensible 93/25293/3
Stefan Neufeind [Mon, 11 Nov 2013 22:43:29 +0000 (23:43 +0100)]
[BUGFIX] Make be.buttons.icon-ViewHelper extensible

Many of the standard-ViewHelpers (tag-based) at least support
additionalAttributes. Introduce this for be.buttons.icon as well
to allow for attributes like onclick or target. Those arguments
will be assigned to the surrounding a-tag if an uri is specified.

Change-Id: I0b8ef12842a818ed5d49437a003287aff9b08f13
Resolves: #53538
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25293
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] EM: Missing message when installing incompatible extension 07/25307/2
Nicole Cordes [Tue, 12 Nov 2013 13:31:55 +0000 (14:31 +0100)]
[BUGFIX] EM: Missing message when installing incompatible extension

If you try to install an extension which depends on a TYPO3 version
lower that the current one the extension isn't installed and any
error is shown. This patch adds the flash message to the queue so it is
visible afterwards.

Resolves: #53461
Releases: 6.2
Change-Id: Id35987db9b4d24e2161863186ebbe5683a7738fc
Reviewed-on: https://review.typo3.org/25307
Reviewed-by: Steffen Ritter
Reviewed-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Oliver Hader
5 years agoRevert "[BUGFIX] Correctly apply Extbase-validator-options / Add tests" 99/25299/2
Stefan Neufeind [Tue, 12 Nov 2013 10:47:45 +0000 (11:47 +0100)]
Revert "[BUGFIX] Correctly apply Extbase-validator-options / Add tests"

This reverts commit 742a5dff0acc5c931793396421076ff2fc22edda

Change-Id: Ia68211d95f6181f54675614fc26d019118c3e176
Reviewed-on: https://review.typo3.org/25299
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix menu popup for all IE versions 27/23227/3
Alexander Opitz [Wed, 21 Aug 2013 15:09:23 +0000 (17:09 +0200)]
[BUGFIX] Fix menu popup for all IE versions

The IE has problems with base URLs in JS on window.open()
function calls. This problem was already fixed for content
objects but not for the menu.

This change adds the baseUrlWrap and also the quoteJSvalue
function call like in ContentObjectRenderer::typoLink().

Resolves: #22136
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: Ia1ad859d2acb358378bc4ffa3f6a9162b3fc6937
Reviewed-on: https://review.typo3.org/23227
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Follow-up: Hard-coded labels in file collections 82/25282/3
Wouter Wolters [Mon, 11 Nov 2013 19:05:18 +0000 (20:05 +0100)]
[TASK] Follow-up: Hard-coded labels in file collections

Change-Id: If2d567f2e381e0cdfdaf883cd4452807d88f44e2
Related: #52727
Resolves: #53532
Releases: 6.2
Reviewed-on: https://review.typo3.org/25282
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Hard-coded labels in file collections 64/25264/3
Tomita Militaru [Mon, 11 Nov 2013 14:29:35 +0000 (16:29 +0200)]
[TASK] Hard-coded labels in file collections

Adds labels for file collection types in TCA

Resolves: #52727
Release: 6.2, 6.1, 6.0
Change-Id: I0aafc385d824a41a4e6045a9708d726dee06ea39
Reviewed-on: https://review.typo3.org/25264
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] NEWS.txt entry about removed PATH_t3lib constant 66/25266/3
Tomita Militaru [Mon, 11 Nov 2013 16:18:39 +0000 (18:18 +0200)]
[BUGFIX] NEWS.txt entry about removed PATH_t3lib constant

Adds information about removed PATH_t3lib constant and moved
JavaScript files from t3lib.

Resolves: #52785
Releases: 6.2
Change-Id: I366a6d8f78e034ec321872f9e6d5301093be13b6
Reviewed-on: https://review.typo3.org/25266
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ContentObjectRenderer still calls t3lib_div 76/25276/2
Francois Suter [Mon, 11 Nov 2013 17:51:36 +0000 (18:51 +0100)]
[BUGFIX] ContentObjectRenderer still calls t3lib_div

When trying to determine which scheme to use for property
forceAbsoluteUrl, class ContentObjectRenderer calls
t3lib_div::getIndpEnv('TYPO3_SSL').
This must be replaced with GeneralUtility.

Resolves: #53530
Releases: 6.2
Change-Id: I7b7de9373fbbee3f981a28065a12d159eb37ca26
Reviewed-on: https://review.typo3.org/25276
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Correctly append additionalTreelistUpdateFields 78/11978/5
Bart Dubelaar [Tue, 27 Nov 2012 00:45:21 +0000 (01:45 +0100)]
[BUGFIX] Correctly append additionalTreelistUpdateFields

The list of additionalTreelistUpdateFields was not correctly
appended to the updateRequiringFields array.

Resolves: #37948
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I7df514649203bf607a6ac3550c875c429e0f7328
Reviewed-on: https://review.typo3.org/11978
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Update backend page title 24/25224/4
Tomita Militaru [Fri, 8 Nov 2013 16:34:25 +0000 (18:34 +0200)]
[TASK] Update backend page title

Updates the document title in backend following the brand change
from TYPO3 to TYPO3 CMS

Resolves: #53455
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I62782f3aa2c1dd30dc1429999e0757823ed8dbd7
Reviewed-on: https://review.typo3.org/25224
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Call to FlashMessageQueue::addMessage() method in extbase 80/24280/4
Markus Klein [Wed, 2 Oct 2013 20:40:23 +0000 (22:40 +0200)]
[BUGFIX] Call to FlashMessageQueue::addMessage() method in extbase

Extbase still uses the addMessage method, which is deprecated.
The official API is now enqueue(), let's use this one.

Resolves: #52488
Releases: 6.1, 6.2
Change-Id: I85097ee53ded9c2d2ccdc6c240667ddaa3768999
Reviewed-on: https://review.typo3.org/24280
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Correctly apply Extbase-validator-options / Add tests 10/24010/7
Stefan Neufeind [Tue, 24 Sep 2013 00:12:03 +0000 (02:12 +0200)]
[BUGFIX] Correctly apply Extbase-validator-options / Add tests

* Check supplied options
* Apply default-values of validator if needed
* Check for required options
* Provide options via constructor instead of via setOptions()
  (which is deprecated)
* Add tests for AbstractValidator and AbstractCompositeValidator

Change-Id: I02c72eff93125a002d57e23710b954c44cc84465
Resolves: #52208
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24010
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add cache to getPagesTSconfig() 23/25223/4
Stefan Neufeind [Fri, 8 Nov 2013 16:10:02 +0000 (17:10 +0100)]
[TASK] Add cache to getPagesTSconfig()

Add a cache also to BackendUtility::getPagesTSconfig() to save parsing
etc. for multiple lookups in various places inside TYPO3.

The core only uses the first parameter, therefore the cache is only
based on the page ID and ignored if other parameters are given.

Change-Id: I63d49c398ed16daa5c2d8ae707d67f934a24a312
Resolves: #53462
Releases: 6.2
Reviewed-on: https://review.typo3.org/25223
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] EM: Fetch list as html, not as json 12/25212/2
Stefan Neufeind [Fri, 8 Nov 2013 13:40:14 +0000 (14:40 +0100)]
[BUGFIX] EM: Fetch list as html, not as json

After performing an update from TER currently the extension-list
is fetched as format=json. This however leads to that situation
that links in the list also have format=json and won't work
anymore (example: pagination-widget).

Change-Id: Id37ab27bb3acd821e9dc0cadb23978aa3e5d9784
Resolves: #53423
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25212
Reviewed-by: Pascal Dürsteler
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Pascal Dürsteler
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Introduce Signals in IndexRecord- and MetaDataRepository 96/24896/6
Steffen Ritter [Fri, 18 Oct 2013 12:55:09 +0000 (14:55 +0200)]
[TASK] Introduce Signals in IndexRecord- and MetaDataRepository

In order to allow custom code to act on changes in the FAL
Layer the repositories now emit signals on create, update
and delete.

Releases: 6.2
Resolves: #52952
Change-Id: Ib42c1cb2aef199af3b4565560bdb2e094ac1cf06
Reviewed-on: https://review.typo3.org/24896
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Add hashcolumn to field configuration of sys_file_processedfile 34/24734/5
Georg Ringer [Mon, 14 Oct 2013 11:14:06 +0000 (13:14 +0200)]
[TASK] Add hashcolumn to field configuration of sys_file_processedfile

Because of perfomance reason it would be good to have a hash column for
the field configuration of the table sys_file_processedfile.

Change-Id: I310428afff335217afaa77f1a2ee6d628c80e8ef
Resolves: #52788
Releases: 6.2
Reviewed-on: https://review.typo3.org/24734
Reviewed-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] getProcessedValue ignores sorting of select field values 82/2882/12
Johannes Feustel [Sat, 10 Nov 2012 20:34:39 +0000 (21:34 +0100)]
[BUGFIX] getProcessedValue ignores sorting of select field values

Keep sorting of select field values which is lost during database select.

Change-Id: If0347f6c92e71a3855a00fd24bbbada7c15af386
Fixes: #27519
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/2882
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Catch exception in element browser 42/24842/3
Markus Hoelzle [Wed, 16 Oct 2013 13:47:26 +0000 (15:47 +0200)]
[BUGFIX] Catch exception in element browser

If the last selected folder doesn't exist anymore an exeption in the
element browser was thrown.

Resolves: #52306
Releases: 6.2, 6.1, 6.0
Change-Id: Ia6645fd61b879ecaedd98f7f7fa17bd3dd7c162b
Reviewed-on: https://review.typo3.org/24842
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Don't use destructor as shutdown function 77/24277/4
Thorsten Kahler [Wed, 2 Oct 2013 14:48:29 +0000 (16:48 +0200)]
[TASK] Don't use destructor as shutdown function

GeneralUtility::makeInstanceService() registers service classes'
destructors as shutdown functions. This has two drawbacks:
* destructors are called twice usually
* service classes need to have destructors

The shutdown function for temp file cleanup in AbstractService is
registered on demand instead.

Change-Id: I0c41d821dc2279eeb126badf306f73d3b53b3010
Resolves: #52463
Releases: 6.2
Reviewed-on: https://review.typo3.org/24277
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] No duplicate html encoding in file titles 52/25052/2
Alexander Stehlik [Tue, 29 Oct 2013 15:50:49 +0000 (16:50 +0100)]
[BUGFIX] No duplicate html encoding in file titles

This patch makes sure that UserFileInlineLabelService only parses the
title of a file through htmlspecialchars if this was not already done by
a BackendUtility method like getRecordTitle() or getRecordTitlePrep().

Titles that are cropped by getRecordTitlePrep() will be displayed
correctly in the Backend.

Resolves: #53200
Releases: 6.2
Change-Id: I960e599372aeecfb2e5e6469ac4d644c578cfabc
Reviewed-on: https://review.typo3.org/25052
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Performance: remove unneeded basename call in CacheManager 45/25245/2
Ingo Schmitt [Sat, 9 Nov 2013 22:11:28 +0000 (23:11 +0100)]
[BUGFIX] Performance: remove unneeded basename call in CacheManager

$filename is already containing basername from $pathAndFilename
thus replace in if and else basename($pathAndFilename) by
filename

Resolves: #53478
Releases: 6.2
Change-Id: Ia71d4ec654edd6effb7c8b290d0738f5f1a77bb4
Reviewed-on: https://review.typo3.org/25245
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Fix superfluous strlen() on constant strings 42/25242/2
Steffen Ritter [Sat, 9 Nov 2013 21:41:29 +0000 (22:41 +0100)]
[TASK] Fix superfluous strlen() on constant strings

Releases: 6.2, 6.1, 6.0
Resolves: #53477
Change-Id: I27817df25c126beb216c2b933c82ad9c35b74d80
Reviewed-on: https://review.typo3.org/25242
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Better mocking of $GLOBALS['LANG'] 34/25234/3
Christian Kuhn [Sat, 9 Nov 2013 15:43:06 +0000 (16:43 +0100)]
[TASK] Better mocking of $GLOBALS['LANG']

To further remove dependencies in unit tests, some tests are
adapted to correctly mock $GLOBALS['LANG']. The PageRenderer
tests still need adaptions in a separate patch, so the test
bootstrap still initializes the language handling for now.

Change-Id: I5d6a8a0a0fe738fef676fbc637a02fe9700ccee3
Resolves: #53476
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/25234
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Set active SCHEME using typolink with forceAbsoluteUrl 89/21589/2
Ferdinand Kuhl [Thu, 20 Jun 2013 16:28:24 +0000 (18:28 +0200)]
[BUGFIX] Set active SCHEME using typolink with forceAbsoluteUrl

If you use forceAbsoluteUrl at a page which has "default" as option and
is called per https the link will be generated with "http" - and not as
"default" means with the active protocol.
This patch fixes that behaviour.

Resolves: #49293
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: Iab087469f63a63267213d9f1c4fc45223b7f45dc
Reviewed-on: https://review.typo3.org/21589
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Enable treeConfig overriding by Page TSconfig 40/19740/5
Stefan Froemken [Mon, 8 Apr 2013 10:58:15 +0000 (12:58 +0200)]
[BUGFIX] Enable treeConfig overriding by Page TSconfig

Add treeConfig to whitelist to allow overriding rootUid
as described in the documentation. Example:

TCEFORM.pages.categories.config.treeConfig.rootUid = 1

Resolves: #47040
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: Idd55593b063daa0be3c2943400f82617b0bf6218
Reviewed-on: https://review.typo3.org/19740
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Correct storage selection (follow-up) 71/24071/2
Ernesto Baschny [Thu, 26 Sep 2013 14:44:59 +0000 (16:44 +0200)]
[BUGFIX] Correct storage selection (follow-up)

The new matching did not consider Windows paths names as the
previous version did. Using PathUtility is safer.

Releases: 6.2, 6.1, 6.0
Resolves: #52173
Change-Id: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27
Reviewed-on: https://review.typo3.org/24071
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FAL: Always load meta data of files 87/25187/3
Markus Klein [Wed, 6 Nov 2013 18:59:57 +0000 (19:59 +0100)]
[BUGFIX] FAL: Always load meta data of files

There's one place in the File class where the
according meta data were not loaded.

Resolves: #46020
Releases: 6.2
Change-Id: I41ccb6abcf8abf47a3a5f16875203f2982872f1e
Reviewed-on: https://review.typo3.org/25187
Reviewed-by: Wouter Wolters
Tested-by: Martin Holtz
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] filemetadata: differenciate between file types 35/25035/3
Ernesto Baschny [Mon, 28 Oct 2013 20:57:47 +0000 (21:57 +0100)]
[BUGFIX] filemetadata: differenciate between file types

filemetadata provides different set of meta data fields depending on
the file type.  This is now working as intended by referring to the
type field in the sys_file table.

Resolves: #52851
Releases: 6.2
Change-Id: I394a417af50312dbacfdfccbcbe2730866e9c5a1
Reviewed-on: https://review.typo3.org/25035
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Use getPagesTSconfig($tscPID) only once per ID 81/25181/6
Jo Hasenau [Tue, 5 Nov 2013 22:34:08 +0000 (23:34 +0100)]
[BUGFIX] Use getPagesTSconfig($tscPID) only once per ID

PageLayoutView::isRTEforField is called on every record that is
displayed in a Web>Page. And this will call
BackendUtility::getPagesTSconfig($tscPID)
every time once and again,
and thus parsing the PageTS over and over on the same hit.
If you have 50 content elements on a page,
this can get very expensive.

Solution: Create a variable that stores the RTEsetup for
 a particular ID

Resolves: #53368
Releases: 6.2

Change-Id: I7efcefb0c12c856e9417ca8bb655acaabd4f15cc
Reviewed-on: https://review.typo3.org/25181
Reviewed-by: Oliver Klee
Reviewed-by: Jo Hasenau
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Reviewed-by: Peter Foerger
Tested-by: Peter Foerger
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Escape title, extension, description of scheduler tasks 32/25132/3
Tomita Militaru [Sat, 2 Nov 2013 22:14:14 +0000 (00:14 +0200)]
[BUGFIX] Escape title, extension, description of scheduler tasks

Properly escapes the title, description and extension of
displayed scheduler tasks

Resolves: #29179
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie03383f694863e435bfb96341226f8c78be426e5
Reviewed-on: https://review.typo3.org/25132
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Extensionmanager: Update jQuery-usage 28/15828/20
Stefan Neufeind [Thu, 17 Oct 2013 19:15:31 +0000 (21:15 +0200)]
[TASK] Extensionmanager: Update jQuery-usage

* Use central jQuery 1.9.x
* Update jQuery UI
* Dropped jQuery Tools
* Added Validator
  (previously used from jQuery Tools)
* Made tabs work again

Change-Id: Iabe4fa307beda89cf5e54575179b286fe675ff90
Resolves: #42197
Releases: 6.2
Reviewed-on: https://review.typo3.org/15828
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Sebastian Fischer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] The Install Tool welcome text is outdated 25/25125/4
Tomita Militaru [Sat, 2 Nov 2013 12:26:56 +0000 (14:26 +0200)]
[BUGFIX] The Install Tool welcome text is outdated

Updates the welcome text of the Install Tool with
information about the new modules.

Resolves: #53081
Releases: 6.2
Change-Id: I30b486a7503ca3c62675c33725c3483190b919ea
Reviewed-on: https://review.typo3.org/25125
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] File PackageStates.php isn't created at all 94/25194/3
Nicole Cordes [Thu, 7 Nov 2013 12:12:56 +0000 (13:12 +0100)]
[BUGFIX] File PackageStates.php isn't created at all

With the patch I71bba56361a4cc85fb253199acbfee5829defa29 the access to
the PackageStates.php file is checked. If the file doesn't exists yet
the error is thrown as well. This patch adds a test if the file can be
created so the update process can be executed again.

Resolves: #53410
Releases: 6.2
Change-Id: I1e79c7f0ab0f0c69a20086c8b8e5be2c37bdb5f3
Reviewed-on: https://review.typo3.org/25194
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Replace calls to ExtensionManagementUtility with PackageManager 41/24941/3
Thomas Maroschik [Mon, 21 Oct 2013 17:38:34 +0000 (19:38 +0200)]
[TASK] Replace calls to ExtensionManagementUtility with PackageManager

The ExtensionManagementUtility is used by the Extensionsmanagers
InstallUtility and just forwards all calls the InstallUtility does to the
PackageManager.

The superfluous calls to the ExtensionManagementUtility are replaced
by calls to the PackageManager.

Resolves: #53013
Releases: 6.2
Change-Id: I0dbcbafa89d3a3c7cb6f6c65bdb16320cb737108
Reviewed-on: https://review.typo3.org/24941
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add pageId to getBackendLayout() method 85/25085/2
Georg Ringer [Thu, 31 Oct 2013 08:48:36 +0000 (09:48 +0100)]
[TASK] Add pageId to getBackendLayout() method

The new BackendLayout providers should be able to get the page id.
Otherwise it might be hard for some cases to return the correct layout.
E.g if working with TsConfig, a page id is needed to get the correct
tsconfig

Change-Id: If455f951b735c3af406cd9c96f057dad1eebb2bc
Resolves: #53244
Releases: 6.2
Reviewed-on: https://review.typo3.org/25085
Reviewed-by: Wouter Wolters
Reviewed-by: Jo Hasenau
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Endless loop in check for broken extensions 52/25152/2
Oliver Hader [Mon, 4 Nov 2013 13:02:43 +0000 (14:02 +0100)]
[BUGFIX] Endless loop in check for broken extensions

The check for broken extensions in the Install Tool checks for
PHP fatal errors, excludes possibly faulty extensions and
continues this process until all errors are gone or all
extensions have been marked as broken.

If PHP warnings (or any other content) are outputted directly
to the client, this will lead to a mixed data representation of
JSON encoded content and the plain text output, like e.g.
  Warning:  array_keys() expects parameter 1 to be array...
  "OK"

To avoid that, the output buffer needs to be cleaned.

Change-Id: I7efb0be23e1897af4d98c7c7726eec2003fb6296
Fixes: #53236
Releases: 6.2
Reviewed-on: https://review.typo3.org/25152
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Make admin modules only available for admins 86/25186/2
Helmut Hummel [Wed, 6 Nov 2013 17:53:31 +0000 (18:53 +0100)]
[BUGFIX] Make admin modules only available for admins

The extension manager and backend user module
are targeted for admins only.
Reflect that in the module configuration.

Releases: 6.2, 6.1, 6.0
Change-Id: I3604fd245c712a41f70c6e1672a238dcdbaaeddc
Reviewed-on: https://review.typo3.org/25186
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Show flash message if package states are not writable 75/24975/4
Stefan Rotsch [Wed, 23 Oct 2013 13:14:45 +0000 (15:14 +0200)]
[BUGFIX] Show flash message if package states are not writable

When trying to install/uninstall an extension and PackageStates.php
is not writable, an error flash message is shown.

Resolves: #53077
Releases: 6.2
Change-Id: I71bba56361a4cc85fb253199acbfee5829defa29
Reviewed-on: https://review.typo3.org/24975
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Catch exceptions in itemsProcFunc 86/24786/5
Francois Suter [Tue, 15 Oct 2013 09:06:45 +0000 (11:06 +0200)]
[TASK] Catch exceptions in itemsProcFunc

It may be helpful to let itemsProcFuncs for field (e.g. select, check
and radio types) throw exceptions that are caught and displayed
properly as error message.

Actually https://review.typo3.org/#/c/24066/ introduces such an
exception.

Releases: 6.2
Resolves: #52836
Documentation: #52839
Change-Id: Icabdc528668844d5713142f0aad2d3923742dd11
Reviewed-on: https://review.typo3.org/24786
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Peter Foerger
Tested-by: Peter Foerger
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Use correct variable name for backend layouts 82/25182/2
Georg Ringer [Wed, 6 Nov 2013 05:31:17 +0000 (06:31 +0100)]
[BUGFIX] Use correct variable name for backend layouts

Because of using a wrong variable name the backend layouts
are not working anymore inside a content element as the items of the
colpos list are never changed

Resolves: #53304
Releases: 6.2
Change-Id: I021e4eaaf3be56ee1ce05bd9707ffd537edb5dcc
Reviewed-on: https://review.typo3.org/25182
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Add property icon to category domainmodel 70/25170/2
Stefan Froemken [Tue, 5 Nov 2013 10:39:02 +0000 (11:39 +0100)]
[BUGFIX] Add property icon to category domainmodel

Add missing icon property

Resolves: #53341
Releases: 6.2
Change-Id: Ib84e60c59a46d6f19adc1426760f177a37ddfe61
Reviewed-on: https://review.typo3.org/25170
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Do not encode links from non-local storages 86/23786/4
Helmut Hummel [Thu, 12 Sep 2013 12:39:26 +0000 (14:39 +0200)]
[BUGFIX] Do not encode links from non-local storages

The check for non file URLs that was introduced
in #42223 does not take relative URLs into account,
which are also perfectly valid for some drivers.

Just check if the image resource URL is a local
file, because only then it makes sense to maybe
transform it to a GIF.

We also remove an obsolete check for file
in imageLinkWrap as the URL there can be either
an URL to a remote storage or an integer.

Related: #42223
Resolves: #51949
Releases: 6.0, 6.1, 6.2
Change-Id: I67c8cea1c3b4997558b99d244bae5ea6d509f923
Reviewed-on: https://review.typo3.org/23786
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Deprecate ext_emconf.php key "docPath" 53/25153/2
Xavier Perseguers [Mon, 4 Nov 2013 13:21:35 +0000 (14:21 +0100)]
[TASK] Deprecate ext_emconf.php key "docPath"

Resolves: #53307
Releases: 6.2
Documentation: #53308
Change-Id: Ib283f5cb6620e2e359899d0523ec4afe1dd0d15c
Reviewed-on: https://review.typo3.org/25153
Reviewed-by: Stefan Froemken
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Removed empty defaults for backend_layouts 34/25134/2
Jo Hasenau [Sat, 2 Nov 2013 23:22:28 +0000 (00:22 +0100)]
[BUGFIX] Removed empty defaults for backend_layouts

The new default value has to be 0 due to the backend layout
configuration we introduced with data providers. So replacing
the default 0 with an empty string must be avoided.

Resolves: #53269
Releases: 6.2
Change-Id: Ieca1a836cba5abe261c0a099e0beb9fcab0ff462
Reviewed-on: https://review.typo3.org/25134
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove go-up button in filelist 86/25086/2
Georg Ringer [Thu, 31 Oct 2013 09:06:17 +0000 (10:06 +0100)]
[TASK] Remove go-up button in filelist

There is no go-up funtionality currently. The current icon links to the
current page. Therefore it should be removed

Change-Id: I177ad4d136bfb008861a1f890d246d790ce23c23
Resolves: #53226
Releases: 6.2
Reviewed-on: https://review.typo3.org/25086
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Mention new default for cookieHttpOnly in NEWS.txt 40/25140/2
Steffen Müller [Sun, 3 Nov 2013 13:41:36 +0000 (14:41 +0100)]
[TASK] Mention new default for cookieHttpOnly in NEWS.txt

Resolves: #53291
Releases: 6.2
Change-Id: Ie941ada0519c8ac22153b07bb2b1a297333332df
Reviewed-on: https://review.typo3.org/25140
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[FEATURE] Enable cookieHttpOnly by default 22/25122/3
Tomita Militaru [Sat, 2 Nov 2013 09:39:02 +0000 (11:39 +0200)]
[FEATURE] Enable cookieHttpOnly by default

Enable cookieHttpOnly by default, which prevents
JavaScript from accessing the session cookie

Resolves: #24647
Releases: 6.2
Change-Id: Id000c9221232aeae325c82db079539564cd36b93
Reviewed-on: https://review.typo3.org/25122
Reviewed-by: Ingo Schmitt
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[BUGFIX] Show icons of backend layouts 87/25087/2
Georg Ringer [Thu, 31 Oct 2013 09:22:11 +0000 (10:22 +0100)]
[BUGFIX] Show icons of backend layouts

Since changing the implementation of backend layouts (#37208) the icons
of backend layouts are not shown anymore.

This change fixed the path so that it is working again.

Change-Id: I7de03ac7fa90c5f62ec66b14dd391a316b858a98
Resolves: #52953
Releases: 6.2
Reviewed-on: https://review.typo3.org/25087
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Render smallRetina sourceCollection in image CType 17/24917/5
Sebastian Fischer [Mon, 21 Oct 2013 09:06:46 +0000 (11:06 +0200)]
[BUGFIX] Render smallRetina sourceCollection in image CType

The smallRetina sourceCollection is rendered for any
layoutKey constant other than "default".

Resolves: #52991
Releases: 6.2
Change-Id: I63881b08e46d2b9d421b284b7d3d5533ca6aa05b
Reviewed-on: https://review.typo3.org/24917
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[TASK] Fix static call to non-static method 32/25032/4
Georg Ringer [Mon, 28 Oct 2013 12:24:58 +0000 (13:24 +0100)]
[TASK] Fix static call to non-static method

The WS toolbar calls a method as static which is not

Change-Id: I06c15ba0545177a469f259bf1882a6c13b3585fc
Resolves: #53161
Releases: 6.2
Reviewed-on: https://review.typo3.org/25032
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Optimize performance of the class loader 50/24950/2
Thomas Maroschik [Tue, 22 Oct 2013 07:30:10 +0000 (09:30 +0200)]
[TASK] Optimize performance of the class loader

This change eliminates some file_exists calls and removes
an expensive regex that validated the class name.

Resolves: #53029
Releases: 6.2
Change-Id: I3d9ead0c3cdb999a540d303c8bd0709d4b827efd
Reviewed-on: https://review.typo3.org/24950
Reviewed-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Incorrect class names used in Install.php script 42/25042/3
Claus Due [Mon, 28 Oct 2013 23:17:50 +0000 (00:17 +0100)]
[BUGFIX] Incorrect class names used in Install.php script

Fixes an incorrect use of lowercase extension-key component
in "install" extension's Install.php script.

Releases: 6.2
Resolves: #53187
Change-Id: I67a9190fb861a9b22d6c83ea5147429ae76a729a
Reviewed-on: https://review.typo3.org/25042
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[FEATURE] Add DESC sorting for FILES-cObject 23/25023/4
Stefan Froemken [Mon, 28 Oct 2013 09:34:35 +0000 (10:34 +0100)]
[FEATURE] Add DESC sorting for FILES-cObject

Add new property "direction" in sorting
to order fileObjects in reverse order

Documentation: #53183
Resolves: #53130
Releases: 6.2
Change-Id: I2b31d1ca3afb3738d267ed0de8e1c3ca791f0980
Reviewed-on: https://review.typo3.org/25023
Reviewed-by: Gernot Ploiner
Tested-by: Gernot Ploiner
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] T3editor: Make errors/exceptions show correctly 99/24999/3
Stefan Neufeind [Thu, 24 Oct 2013 23:26:02 +0000 (01:26 +0200)]
[BUGFIX] T3editor: Make errors/exceptions show correctly

* Display T3editor.lang.errorWhileSaving in a flashmessage.
* Pass exception-messages through the AJAX-call and display
  them in the flashmessage as well.

Change-Id: Ia743b5a3fc9a7b272854920bcc0e9d081d4822ef
Resolves: #53115
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24999
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix text of t3skin update in Install-Tool 22/25022/2
Georg Ringer [Mon, 28 Oct 2013 08:11:00 +0000 (09:11 +0100)]
[BUGFIX] Fix text of t3skin update in Install-Tool

The description is currently returned as array but should
be a string. Furthermore the text needs to small update.

Change-Id: I93835ae6efefe308e685a1b3797444a6eabf27f7
Resolves: #53163
Releases: 6.2
Reviewed-on: https://review.typo3.org/25022
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Exception class not found in ApplicationContext 51/25051/3
Stefan Froemken [Tue, 29 Oct 2013 15:13:02 +0000 (16:13 +0100)]
[BUGFIX] Exception class not found in ApplicationContext

If a wrong application context is set, an exception
should be thrown, however the exception class is
not found.

Resolves: #53162
Releases: 6.2
Change-Id: Ia863d162a2a983a46341a6f2b124702080a94542
Reviewed-on: https://review.typo3.org/25051
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[BUFGIX] set password length to 8 in installtool 50/25050/2
Stefan Froemken [Tue, 29 Oct 2013 14:50:00 +0000 (15:50 +0100)]
[BUFGIX] set password length to 8 in installtool

The installtool requires a password length of 8 letters,
but background of new password changes to yellow
after just 6 letters.

Resolves: #53159
Releases: 6.2
Change-Id: I6031e1a93af13f8db3fd1fb5a514da5746b7aa4e
Reviewed-on: https://review.typo3.org/25050
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] T3editor: Honour fileDenyPattern on saving included TS 46/25046/2
Stefan Neufeind [Tue, 29 Oct 2013 11:31:23 +0000 (12:31 +0100)]
[BUGFIX] T3editor: Honour fileDenyPattern on saving included TS

fileDenyPattern is only checked on loading so far.
Needs to be added for saving as well taken into account, since
otherwise an arbitrary file (including .php) can be overwritten.

Change-Id: Ia7edc83c8954942fb848746abc0980a304a1a6df
Resolves: #53195
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/25046
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Add xlf to [SYS][textfile_ext] 08/25008/3
Alexander Stehlik [Fri, 25 Oct 2013 14:37:38 +0000 (16:37 +0200)]
[TASK] Add xlf to [SYS][textfile_ext]

Add the xlf file extension to the list of textfile extensions in the
default configuration.

Resolves: #53136
Releases: 6.2
Change-Id: I2ea509c8a027bb21d77a59313cce4dfa9495c280
Reviewed-on: https://review.typo3.org/25008
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Compressor resolves dots in filenames correctly 75/24875/5
Christian Kuhn [Thu, 17 Oct 2013 16:46:47 +0000 (18:46 +0200)]
[BUGFIX] Compressor resolves dots in filenames correctly

Method getFilenameFromMainDir() tries to resolve a given file path
to a path relative to the document root and takes care of file
existance.

Sometimes it is fed with a path like '../path/to/file' and then
prepends it with the document root to call an is_file() on it. The
constructed path is then '/path/to/doc/root/typo3/../path/to/file'. If
now 'root' is a symlink to some sub structure itself, is_file()
will fail, because it does not solve the '..' part correctly anymore.

Using resolveBackPath() on the path before feeding it to is_file()
transforms the path to '/path/to/doc/root/path/to/file'. So the dots
are resolved and is_file is happy.

Change-Id: I20b4f4bbea695aeb02e3d92469236bc63cd05d97
Resolves: #52926
Releases: 6.2, 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/24875
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] EXT:documentation: Remove box around links 88/24888/2
Xavier Perseguers [Fri, 18 Oct 2013 06:35:17 +0000 (08:35 +0200)]
[TASK] EXT:documentation: Remove box around links

Since the base CSS has been updated to underline links on
mouse hover, the box that is shown in EXT:documentation
should be removed.

Resolves: #52935
Releases: 6.2
Change-Id: I385b703dc533ccfecf85aa86537bfed43ec2a995
Reviewed-on: https://review.typo3.org/24888
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Available extension list not updated on CLI 72/24972/2
Stefan Rotsch [Wed, 23 Oct 2013 11:59:04 +0000 (13:59 +0200)]
[BUGFIX] Available extension list not updated on CLI

On installing a manually downloaded extension usign the
extension:install CLI API, the list of available extensions does not
get updated prior to the installation, causing it to fail.

Resolves: #53071
Releases: 6.2
Change-Id: I8610f27b8fe36c15f02d88e7b4275099e5443b96
Reviewed-on: https://review.typo3.org/24972
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] TypoScript: Condition for Windows 8 83/24783/5
Stefan Neufeind [Tue, 15 Oct 2013 08:05:08 +0000 (10:05 +0200)]
[TASK] TypoScript: Condition for Windows 8

Reports itself as "Windows NT 6.2"
or "Windows NT 6.3" in user-agent.

Change-Id: Ibdc4b749d6009ca36a6c8c5c621d81838888f6cf
Resolves: #51813
Documentation: #51814
Releases: 6.2
Reviewed-on: https://review.typo3.org/24783
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[FEATURE] Custom inline record creation link label 24/24924/2
Alexander Stehlik [Mon, 21 Oct 2013 13:31:42 +0000 (15:31 +0200)]
[FEATURE] Custom inline record creation link label

Introduce a new TCA setting for columns of type "inline" called
[appearance][newRecordLinkTitle] for overwriting the label of the link
that adds a new inline record to the parent record.

Resolves: #53007
Releases: 6.2
Change-Id: Ia1275aab8eadfd516d0bb58e7704dfb37fecc7c3
Reviewed-on: https://review.typo3.org/24924
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Constant styles.content.imgtext.responsive is not used 18/24918/2
Ingo Schmitt [Mon, 21 Oct 2013 10:41:34 +0000 (12:41 +0200)]
[BUGFIX] Constant styles.content.imgtext.responsive is not used

Removed the entry from constants.txt

Resolves: #52998
Releases: 6.2
Change-Id: I896bc6113ff4dd6015fecaf2f80d573aeab8a02f
Reviewed-on: https://review.typo3.org/24918
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Check for query failures in admin methods 40/24940/2
Thomas Maroschik [Mon, 21 Oct 2013 17:18:23 +0000 (19:18 +0200)]
[BUGFIX] Check for query failures in admin methods

 In the DatabaseConnection class the two methods admin_get_fields
 and admin_get_keys throw a fatal error when a query failure occurs.

 This fix introduces two checks that prevent the methods from fataling
 and return an empty result on failure.

 Fixes: #53014
 Releases: 6.2

Change-Id: I40f7e52fe14b7d75766f0484e42834b0e1b1a5dc
Reviewed-on: https://review.typo3.org/24940
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix typo in PageRenderer comments 28/24928/3
Mattias Nilsson [Mon, 21 Oct 2013 13:55:22 +0000 (15:55 +0200)]
[BUGFIX] Fix typo in PageRenderer comments

Fixes: #53009
Releases: 6.2
Change-Id: I95f95f568f3d9745aaed8e4c7bb8ec10957cf698
Reviewed-on: https://review.typo3.org/24928
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Replace __DIR__ with absolute path in class cache 40/24840/9
Alexander Stehlik [Wed, 16 Oct 2013 19:59:31 +0000 (21:59 +0200)]
[BUGFIX] Replace __DIR__ with absolute path in class cache

Since the directory constant __DIR__ is not always the same in all
environments (web, command line) we only allow absolute paths in the
class cache.

This requires the class cache to be cleared after the TYPO3 instance
was moved to another directory.

Resolves: #52885
Releases: 6.2
Change-Id: I0fc4c13d2977883e6881b5d7dda189813f97ae36
Reviewed-on: https://review.typo3.org/24840
Tested-by: Sebastian Fischer
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
Reviewed-by: Jigal van Hemert
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Make OpenID login work with identifier select 73/21373/13
Christian Weiske [Wed, 12 Jun 2013 19:23:06 +0000 (21:23 +0200)]
[BUGFIX] Make OpenID login work with identifier select

The OpenID protocol has an option which is called
identifier_select which let's the OpenID provider
return the unique OpenID identifier for a user.
A notable example is Google:
Their OpenID for all users is https://www.google.com/accounts/o8/id
while the actual OpenID identity is different, e.g.
https://www.google.com/accounts/o8/id?id=AItOawm2w
(for users without a google+ profile).

Because of this, we cannot verify that the OpenID URL
given by the user during login exists in our database
before starting the OpenID process.
Instead, we first need to run the OpenID process
to get the final OpenID identifier of the user and
only then check if a user with that ID exists
in our database.

This change also also introduces a new field in the
backend login form, "openid_url". The field is needed
to cleanly distinguish OpenID from normal logins,
to make full OpenID URL normalization possible
(i.e. adding http:// automatically if missing).

Resolves: #25322
Releases: 6.2
Change-Id: Id31238760fe4e58e2a823beddaeb454ba28d59be
Reviewed-on: https://review.typo3.org/21373
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind