Packages/TYPO3.CMS.git
17 months ago[TASK] Make FormManagerControllerTest notice free 69/56269/2
Jan Helke [Sat, 17 Mar 2018 08:37:50 +0000 (09:37 +0100)]
[TASK] Make FormManagerControllerTest notice free

Releases: master
Resolves: #84394
Change-Id: I9c506e7f85fb1fc1c3e2108d485004911abe4daa
Reviewed-on: https://review.typo3.org/56269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make Typo3DatabaseBackendTest notice free 67/56267/2
Sascha Löffler [Sat, 17 Mar 2018 08:28:18 +0000 (09:28 +0100)]
[TASK] Make Typo3DatabaseBackendTest notice free

Resolves: #84389
Releases: master
Change-Id: I89ebd6120a11d0ef16862e1b338ebd56136d0b2a
Reviewed-on: https://review.typo3.org/56267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
17 months ago[TASK] Make FormEditorControllerTest notice free 68/56268/2
Jan Helke [Sat, 17 Mar 2018 08:29:19 +0000 (09:29 +0100)]
[TASK] Make FormEditorControllerTest notice free

Releases: master
Resolves: #84390
Change-Id: I02b5861bae1ee15ef6491daf3a0c970e2ca71617
Reviewed-on: https://review.typo3.org/56268
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Increase RequireJS timeout to 30s 70/56270/2
Tymoteusz Motylewski [Sat, 17 Mar 2018 08:42:17 +0000 (09:42 +0100)]
[TASK] Increase RequireJS timeout to 30s

RequireJS default timeout of 7s is sometimes too low, especially
on slow mobile connections and when running PHP build in webserver
during acceptance testing.

Resoves: #84395
Releases: master
Change-Id: I5e19b78f837651070e0f06bd2c99f1060a3e9e66
Reviewed-on: https://review.typo3.org/56270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make FileHandlingUtilityTest notice free 60/56260/3
Jan Helke [Fri, 16 Mar 2018 21:29:35 +0000 (22:29 +0100)]
[TASK] Make FileHandlingUtilityTest notice free

Releases: master
Resolves: #84383
Change-Id: Ib73cd4d2933131728cb4aa1a5fedc733e0599bf4
Reviewed-on: https://review.typo3.org/56260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make ListUtilityTest notice free 63/56263/2
Jan Helke [Fri, 16 Mar 2018 21:40:59 +0000 (22:40 +0100)]
[TASK] Make ListUtilityTest notice free

Releases: master
Resolves: #84385
Change-Id: I0ba97419cd7a5dcf851ccd46e2db0e0dad699f42
Reviewed-on: https://review.typo3.org/56263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make IconViewHelperTest notice free 62/56262/3
Sascha Löffler [Fri, 16 Mar 2018 21:38:06 +0000 (22:38 +0100)]
[TASK] Make IconViewHelperTest notice free

Resolves: #84382
Releases: master
Change-Id: Ie3636104caf9ce61da3071ab738cb0e1f7a05e89
Reviewed-on: https://review.typo3.org/56262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
17 months ago[TASK] Make InstallUtilityTest notice free 61/56261/2
Jan Helke [Fri, 16 Mar 2018 21:35:53 +0000 (22:35 +0100)]
[TASK] Make InstallUtilityTest notice free

Releases: master
Resolves: #84384
Change-Id: Ia43a39337ccbeed748b1da857bc3e051fc7e7af5
Reviewed-on: https://review.typo3.org/56261
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make EmConfUtilityTest notice free 59/56259/2
Jan Helke [Fri, 16 Mar 2018 21:16:47 +0000 (22:16 +0100)]
[TASK] Make EmConfUtilityTest notice free

Releases: master
Resolves: #84381
Change-Id: I56332d89f4c98643bbf24df5b811ae54731e5dac
Reviewed-on: https://review.typo3.org/56259
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in Wizard/EditController 32/56232/6
Saskia Schreiber [Fri, 16 Mar 2018 14:25:04 +0000 (15:25 +0100)]
[TASK] Use ServerRequestInterface in Wizard/EditController

This patch changes the EditController to consistently use
ServerRequestInterface instead of GeneralUtility and
HttpUtility.

The method main() is kept to keep this change non-breaking,
it translates the given response objects back to strings/redirects
which match existing behaviour.

Also, to prepare for refactoring in v10,
main() and the new protected properties will throw a
deprecation notice if called.

Resolves: #84327
Releases: master
Change-Id: I9bd055f4a81e5f9ca324954bc03206c9f463cb11
Reviewed-on: https://review.typo3.org/56232
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Fail acceptance tests on JavaScript errors in browser console 96/56196/13
Tymoteusz Motylewski [Fri, 16 Mar 2018 20:58:22 +0000 (21:58 +0100)]
[TASK] Fail acceptance tests on JavaScript errors in browser console

Raise typo3/testing-framework to 3.3.0

composer update typo3/testing-framework

Acceptance tests are configured to fail if JavaScript
errors are raised in the console.
See https://github.com/TYPO3/testing-framework/blob/master/Resources/Core/
Build/Configuration/Acceptance/Support/Helper/Acceptance.php

This commit also fixeds a bug found by the tests.
A requireJS error was thrown - timeout on loading `nprogress`
from within Loader.js.

Resolves: #84322
Releases: master
Change-Id: Iea9b6e0c435a73be6e6a4f9567d09f35880822ab
Reviewed-on: https://review.typo3.org/56196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Make PdoBackendTest notice free 58/56258/2
Sascha Löffler [Fri, 16 Mar 2018 21:16:41 +0000 (22:16 +0100)]
[TASK] Make PdoBackendTest notice free

Resolves: #84378
Releases: master
Change-Id: Ia17ae3e651da32507d43c313cab73e7bd34632e9
Reviewed-on: https://review.typo3.org/56258
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Make ExtensionManagementServiceTest notice free 57/56257/2
Jan Helke [Fri, 16 Mar 2018 21:11:12 +0000 (22:11 +0100)]
[TASK] Make ExtensionManagementServiceTest notice free

Releases: master
Resolves: #84380
Change-Id: Iff2cf91dbd4bc7ae43aa8d81d3b88edc7c2fef67
Reviewed-on: https://review.typo3.org/56257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Make IconFactoryTest notice free 55/56255/5
Sascha Löffler [Fri, 16 Mar 2018 19:56:16 +0000 (20:56 +0100)]
[TASK] Make IconFactoryTest notice free

Resolves: #84377
Releases: master
Change-Id: I13aee8542becdb3d537f622de4068abbea3aa0b5
Reviewed-on: https://review.typo3.org/56255
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[TASK] Make FormViewHelperTest notice free 49/56249/5
Jan Helke [Fri, 16 Mar 2018 18:44:50 +0000 (19:44 +0100)]
[TASK] Make FormViewHelperTest notice free

Releases: master
Resolves: #84370
Change-Id: I2290665353e844e29fbcd168f21e03260a56fa8c
Reviewed-on: https://review.typo3.org/56249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make ExtensionStatusTest notice free 56/56256/2
Jan Helke [Fri, 16 Mar 2018 21:05:38 +0000 (22:05 +0100)]
[TASK] Make ExtensionStatusTest notice free

Releases: master
Resolves: #84379
Change-Id: I9d50c3d19ddf3d7ebac1ee332937a55eb60d13a8
Reviewed-on: https://review.typo3.org/56256
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make WebProcessorTest notice free 51/56251/3
Sascha Löffler [Fri, 16 Mar 2018 19:12:57 +0000 (20:12 +0100)]
[TASK] Make WebProcessorTest notice free

Resolves: #84371
Releases: master
Change-Id: I8757018564757a7768265a615ab6295851695c37
Reviewed-on: https://review.typo3.org/56251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make PageViewHelperTest notice free 50/56250/3
Jan Helke [Fri, 16 Mar 2018 19:06:12 +0000 (20:06 +0100)]
[TASK] Make PageViewHelperTest notice free

Releases: master
Resolves: #84372
Change-Id: Ibe6212e13ccab98a662e603772ca816bcec9245a
Reviewed-on: https://review.typo3.org/56250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in NewRecordController 29/56229/11
Mathias Brodala [Fri, 16 Mar 2018 14:38:39 +0000 (15:38 +0100)]
[TASK] Use ServerRequestInterface in NewRecordController

* deprecate public properties
* deprecate public (non-routed) methods

Change-Id: Ie3aa92be5e8a58f2ae51808cb0b8c3bf3aa0d235
Resolves: #84341
Releases: master
Reviewed-on: https://review.typo3.org/56229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make TypolinkViewHelper notice free 52/56252/2
Jan Helke [Fri, 16 Mar 2018 19:20:34 +0000 (20:20 +0100)]
[TASK] Make TypolinkViewHelper notice free

Releases: master
Resolves: #84373
Change-Id: I793ef881ef085c80f6c90a8281f6a88dcc56d642
Reviewed-on: https://review.typo3.org/56252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in LoginFramesetController 46/56246/7
Łukasz Uznański [Fri, 16 Mar 2018 17:39:33 +0000 (18:39 +0100)]
[TASK] Use ServerRequestInterface in LoginFramesetController

* deprecate public properties
* deprecate public (non-routed) methods

Resolves: #84368
Releases: master
Change-Id: Ib3f4724dc77384ece76cc6b3c6b9adee38c595e8
Reviewed-on: https://review.typo3.org/56246
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make TextfieldViewHelperTest notice free 42/56242/4
Jan Helke [Fri, 16 Mar 2018 16:39:19 +0000 (17:39 +0100)]
[TASK] Make TextfieldViewHelperTest notice free

Releases: master
Resolves: #84365
Change-Id: I09df5639ba60d7532dd5b8d7dddb1298086fe010
Reviewed-on: https://review.typo3.org/56242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make CharsetConverterTest notice free 48/56248/2
Sascha Löffler [Fri, 16 Mar 2018 18:39:16 +0000 (19:39 +0100)]
[TASK] Make CharsetConverterTest notice free

Resolves: #84366
Releases: master
Change-Id: I0dcd7f4277c4576938dbb6b94adf5c40d6424dfe
Reviewed-on: https://review.typo3.org/56248
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make TextareaViewHelperTest notice free 37/56237/3
Jan Helke [Fri, 16 Mar 2018 15:51:00 +0000 (16:51 +0100)]
[TASK] Make TextareaViewHelperTest notice free

Releases: master
Resolves: #84359
Change-Id: I648bdb8d7fcc1ab07887926d61105fdda9bf03d2
Reviewed-on: https://review.typo3.org/56237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make CObjectViewHelperTest notice free 25/56225/5
Jan Helke [Fri, 16 Mar 2018 14:12:51 +0000 (15:12 +0100)]
[TASK] Make CObjectViewHelperTest notice free

Releases: master
Resolves: #84345
Change-Id: I845ff3db453eee41fbcaf46f76efdeb406c51c53
Reviewed-on: https://review.typo3.org/56225
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make SelectViewHelperTest notice free 27/56227/5
Jan Helke [Fri, 16 Mar 2018 14:33:03 +0000 (15:33 +0100)]
[TASK] Make SelectViewHelperTest notice free

Releases: master
Resolves: #84348
Change-Id: Iaa508825bd9386669ead4848150412304561832c
Reviewed-on: https://review.typo3.org/56227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make ServerRequestFactoryTest notice free 40/56240/3
Sascha Löffler [Fri, 16 Mar 2018 16:38:29 +0000 (17:38 +0100)]
[TASK] Make ServerRequestFactoryTest notice free

Resolves: #84362
Releases: master
Change-Id: Ief9d31b20d58f28cc777659a7a4d87663b3b17c5
Reviewed-on: https://review.typo3.org/56240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Failing test for Extbase’s ExtensionUtility 41/56241/5
Andreas Wolf [Fri, 16 Mar 2018 16:40:54 +0000 (17:40 +0100)]
[BUGFIX] Failing test for Extbase’s ExtensionUtility

Change-Id: I903ea2f2039e7e5d7e6a53e847da7a34c867fb7f
Resolves: #84367
Releases: master
Reviewed-on: https://review.typo3.org/56241
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
17 months ago[TASK] Make ArrayUtilitsTest.php notice free 35/56235/2
Sascha Löffler [Fri, 16 Mar 2018 15:29:00 +0000 (16:29 +0100)]
[TASK] Make ArrayUtilitsTest.php notice free

Resolves: #84355
Releases: master
Change-Id: I7200e476376bc6f76297e2305049fbf4e5310ac0
Reviewed-on: https://review.typo3.org/56235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Prevent type converters from being registered multiple times 63/54263/3
Romain Canon [Mon, 2 Oct 2017 22:09:15 +0000 (00:09 +0200)]
[BUGFIX] Prevent type converters from being registered multiple times

Registering an exact same type converter class name with the Exbase method
`\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerTypeConverter()` will now
add it only once to the global array.

This will prevent issues that could occur during a strong cache clearing, in
which case the `ext_localconf.php` files are included twice, leading to the
Extbase default type converters being registered twice.

If type converters were to be used early during the runtime (just after the
caches were cleared), a `DuplicateTypeConverterException` would be thrown when
it should not be.

---

Resolves: #82651
Releases: master, 8.7
Change-Id: I01e1f6c2399473ff65c22d9a33f919963f49608f
Reviewed-on: https://review.typo3.org/54263
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
17 months ago[TASK] Make FileSizeValidatorTest.php notice free 31/56231/2
Sascha Löffler [Fri, 16 Mar 2018 14:54:12 +0000 (15:54 +0100)]
[TASK] Make FileSizeValidatorTest.php notice free

Resolves: #84350
Releases: master
Change-Id: I4ab0027f86517f6f607a891a2ad5a1417935af1b
Reviewed-on: https://review.typo3.org/56231
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make FileLinkHandlerTest notice free 33/56233/2
Sascha Löffler [Fri, 16 Mar 2018 15:06:04 +0000 (16:06 +0100)]
[TASK] Make FileLinkHandlerTest notice free

Resolves: #84351
Releases: master
Change-Id: I9300d5668ac17b850bff94fb756cdc4961cc404d
Reviewed-on: https://review.typo3.org/56233
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make FlashMessagesViewHelperTest notice free 26/56226/2
Jan Helke [Fri, 16 Mar 2018 14:22:24 +0000 (15:22 +0100)]
[TASK] Make FlashMessagesViewHelperTest notice free

Releases: master
Resolves: #84346
Change-Id: Ie42bb8d7263ec0ca44b38ca6fb8d39aba5dcd43a
Reviewed-on: https://review.typo3.org/56226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Remove irc notification from travis.yml 28/56228/2
Christian Kuhn [Fri, 16 Mar 2018 14:34:08 +0000 (15:34 +0100)]
[TASK] Remove irc notification from travis.yml

irc is unused.

Resolves: #84347
Releases: master, 8.7
Change-Id: I6d52ca238d698d21a446da624438ac46d099b93b
Reviewed-on: https://review.typo3.org/56228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in File/RenameFileController 09/56209/3
Mathias Brodala [Fri, 16 Mar 2018 10:49:57 +0000 (11:49 +0100)]
[TASK] Use ServerRequestInterface in File/RenameFileController

* deprecate public properties
* deprecate public (non-routed) methods

Change-Id: Ic0b65e5fbbcffae4aa1ae5625c8166222a0f3f4b
Resolves: #84332
Releases: master
Reviewed-on: https://review.typo3.org/56209
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in Wizard/ListController 16/56216/4
Łukasz Uznański [Fri, 16 Mar 2018 11:38:31 +0000 (12:38 +0100)]
[TASK] Use ServerRequestInterface in Wizard/ListController

* deprecate public properties
* deprecate public (non-routed) methods
* replace usages of _GP, getIndpEnv

Resolves: #84337
Releases: master
Change-Id: I6f6e139cf4dc4b6d9281c99c436562b435ebfe5b
Reviewed-on: https://review.typo3.org/56216
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Use ServerRequestInterface in Wizard/AddController 00/56200/12
Łukasz Uznański [Thu, 15 Mar 2018 21:51:17 +0000 (22:51 +0100)]
[TASK] Use ServerRequestInterface in Wizard/AddController

Replace _GP, getIndpEnv, public methods, public properties

Resolves: #84321
Releases: master
Change-Id: I911927568b8ea86b4edb2bef5a25e84c625e27ef
Reviewed-on: https://review.typo3.org/56200
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Use ServerRequestInterface Object in File/FileController 08/56208/5
Anja [Fri, 16 Mar 2018 09:44:42 +0000 (10:44 +0100)]
[TASK] Use ServerRequestInterface Object in File/FileController

Use ServerRequestInterface object introduced earlier throughout the
controller instead accessing the global variables directly.

Visibility of properties and methods became more restrictive and will
report external usage by throwing deprecated errors.

Change-Id: I68f220c4b7bb097006118d2b2065ab9f4e554b8f
Resolves: #84324
Releases: master
Reviewed-on: https://review.typo3.org/56208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make IfAuthenticatedViewHelperTest notice free 15/56215/2
Jan Helke [Fri, 16 Mar 2018 11:32:24 +0000 (12:32 +0100)]
[TASK] Make IfAuthenticatedViewHelperTest notice free

Releases: master
Resolves: #84340
Change-Id: I97b586423513ab7d2dde4660ccfecf542468ab50
Reviewed-on: https://review.typo3.org/56215
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make ProcessedFileTest.php notice free 10/56210/2
Sascha Löffler [Fri, 16 Mar 2018 11:02:39 +0000 (12:02 +0100)]
[TASK] Make ProcessedFileTest.php notice free

Resolves: #84333
Releases: master
Change-Id: I6a99c31dfd353e57ce2d762ff47745c8f884ee29
Reviewed-on: https://review.typo3.org/56210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make LinkServiceTest notice free 07/56207/2
Sascha Löffler [Fri, 16 Mar 2018 10:16:51 +0000 (11:16 +0100)]
[TASK] Make LinkServiceTest notice free

Resolves: #84328
Releases: master
Change-Id: I2e8ae22db7c3e9853d6ae59d6c42f960001d5e74
Reviewed-on: https://review.typo3.org/56207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Fix notice in EditFileController 14/56214/6
Mathias Brodala [Fri, 16 Mar 2018 11:22:22 +0000 (12:22 +0100)]
[BUGFIX] Fix notice in EditFileController

Change-Id: I3b7d0742237219f014fee7f9455a2c518c3e36d9
Resolves: #84295
Releases: master
Reviewed-on: https://review.typo3.org/56214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in File/ReplaceFileController 12/56212/4
Mathias Brodala [Fri, 16 Mar 2018 11:06:12 +0000 (12:06 +0100)]
[TASK] Use ServerRequestInterface in File/ReplaceFileController

* deprecate public properties
* deprecate public (non-routed) methods

Change-Id: Ibc8d9f48b026da94fed65ee1fbad962dcb98af7c
Resolves: #84334
Releases: master
Reviewed-on: https://review.typo3.org/56212
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Error in record info when displaying references 17/56217/2
Saskia Schreiber [Fri, 16 Mar 2018 12:10:06 +0000 (13:10 +0100)]
[BUGFIX] Error in record info when displaying references

This fixes the regression introduced in task #84284
(PSR-7 rewrite of ElementInformationController).

getRecordActions() expects the full request as third parameter,
not the requestUri parameter.

Resolves: #84342
Related: #84284
Releases: master
Change-Id: I8fe91098cadfeaf7c90edf202c2ad7e2aa039abe
Reviewed-on: https://review.typo3.org/56217
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make WidgetRequestBuilderTest notice free 04/56204/3
Jan Helke [Fri, 16 Mar 2018 09:11:43 +0000 (10:11 +0100)]
[TASK] Make WidgetRequestBuilderTest notice free

It also throws now an exception, is no fluid-widget-id was given.
Also this exception is covered by a test.

Releases: master
Resolves: #84329
Change-Id: Ibeb7a404f2ab2ebfa0b233279facee978ded41aa
Reviewed-on: https://review.typo3.org/56204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in File/FileUploadController 06/56206/7
Mathias Brodala [Fri, 16 Mar 2018 09:53:17 +0000 (10:53 +0100)]
[TASK] Use ServerRequestInterface in File/FileUploadController

* deprecate public properties
* deprecate public (non-routed) methods
* fix rendering of "Overwrite" checkbox

Change-Id: Ia5b15ad5fd32ab156cab5f3231bbf0c2b78a617c
Resolves: #84326
Releases: master
Reviewed-on: https://review.typo3.org/56206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Trigger submit of RSA encrypted form properly 42/56142/2
Andreas Fernandez [Wed, 14 Mar 2018 08:29:55 +0000 (09:29 +0100)]
[BUGFIX] Trigger submit of RSA encrypted form properly

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Resolves: #84253
Related: #76120
Releases: master, 8.7, 7.6
Change-Id: Id30f4536dccec28edc0d909114c8fde71614bc30
Reviewed-on: https://review.typo3.org/56142
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
17 months ago[BUGFIX] Use correct returnUrl for AddWizard caller 13/56213/2
Anja [Fri, 16 Mar 2018 11:15:16 +0000 (12:15 +0100)]
[BUGFIX] Use correct returnUrl for AddWizard caller

The wrong property has been used to construct the return
URL for the redirect. This has been corrected.

Change-Id: I0d2011a153a34e6c272c69c5a88d66eb498b0707
Resolves: #84336
Relates: #84195
Releases: master
Reviewed-on: https://review.typo3.org/56213
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[BUGFIX] Call autocomplete only if field is available 11/56211/2
Andreas Fernandez [Fri, 16 Mar 2018 11:07:38 +0000 (12:07 +0100)]
[BUGFIX] Call autocomplete only if field is available

Resolves: #84335
Related: #82592
Related: #82969
Releases: master
Change-Id: I6afa442fdfb86e2ffeff0b3c39c12ed2c7e8df6c
Reviewed-on: https://review.typo3.org/56211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Remove StandaloneViewTest 05/56205/3
Jan Helke [Fri, 16 Mar 2018 09:47:25 +0000 (10:47 +0100)]
[TASK] Remove StandaloneViewTest

The "unit" test is basically a test of controller-like
glue code and does not add value. Remove it.

Releases: master
Resolves: #84330
Change-Id: I5ec5c9a148c07b5090f5de34aa2caa3e7f031b3e
Reviewed-on: https://review.typo3.org/56205
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[TASK] Make AbstractWidgetViewHelperTest notice free 03/56203/2
Jan Helke [Fri, 16 Mar 2018 08:35:26 +0000 (09:35 +0100)]
[TASK] Make AbstractWidgetViewHelperTest notice free

Releases: master
Resolves: #84325
Change-Id: I1c1a90dd0eb214aa1a5d655207eaf3e01401d489
Reviewed-on: https://review.typo3.org/56203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Expose interfaces of AjaxDataHandler 41/56041/4
Andreas Fernandez [Wed, 7 Mar 2018 20:02:31 +0000 (21:02 +0100)]
[BUGFIX] Expose interfaces of AjaxDataHandler

Since the AjaxDataHandler is meant to be used in other modules as well,
the interfaces responsible for the response and the messages need to be
public to be able to write type-safe callbacks.

Resolves: #84172
Releases: master
Change-Id: Ib49f25181bc8c83a0cdc89da3a9b466b6bd25d59
Reviewed-on: https://review.typo3.org/56041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Make reloadFrames() non-static 02/56202/3
Andreas Fernandez [Fri, 16 Mar 2018 07:23:22 +0000 (08:23 +0100)]
[BUGFIX] Make reloadFrames() non-static

This patch makes the reloadFrames() method non-static, as the method is
required in an instance context.

Resolves: #84323
Related: #82597
Releases: master
Change-Id: I3bdcfdc91721bb2c145fd42ae4448b09a72e636e
Reviewed-on: https://review.typo3.org/56202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Use ServerRequestInterface in LoginController 76/56176/25
Łukasz Uznański [Thu, 15 Mar 2018 16:09:32 +0000 (17:09 +0100)]
[TASK] Use ServerRequestInterface in LoginController

Replace _GP, getIndpEnv usages

Resolves: #84274
Releases: master
Change-Id: Ic90a83214b0c7cb8d4334f5b72c581968f193766
Reviewed-on: https://review.typo3.org/56176
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[BUGFIX] checkIntegrityCsvFixtures.php displays error reason 24/56124/6
Markus Klein [Mon, 12 Mar 2018 23:25:16 +0000 (00:25 +0100)]
[BUGFIX] checkIntegrityCsvFixtures.php displays error reason

- output details about the columns if a mismatch is detected
- support windows paths for output formatting

Resolves: #84228
Releases: master, 8.7
Change-Id: I02bee0cb4ff99c18632907395989ea7f96c1c625
Reviewed-on: https://review.typo3.org/56124
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Respect empty allowedMimeTypes for file uploads 69/55869/5
Ralf Zimmermann [Thu, 22 Feb 2018 23:13:26 +0000 (00:13 +0100)]
[BUGFIX] Respect empty allowedMimeTypes for file uploads

Make it possible to allow all mime types (except php) within file upload
form elements.
Since there are some default mime types configured within the ext:form
standard setup, you have to remove this default mime types within your
form definition (or reconfigure the default values within your custom
ext:form setup).

FileUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null
    3: null

ImageUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null

Releases: master, 8.7
Resolves: #82670
Change-Id: Ifa07cceb47978b913f36b8607d4df4724ae22eef
Reviewed-on: https://review.typo3.org/55869
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[TASK] Use ServerRequestInterface in File/EditFileController 83/56183/7
Anja [Thu, 15 Mar 2018 17:49:18 +0000 (18:49 +0100)]
[TASK] Use ServerRequestInterface in File/EditFileController

Use ServerRequestInterface object introduced earlier throughout the
controller instead accessing the global variables directly.

Visibility of properties and methods became more restrictive and will
report external usage by throwing deprecated errors.

Change-Id: I70764c6b1feb8da39c9a441dc2c22de838da3a43
Resolves: #84295
Releases: master
Reviewed-on: https://review.typo3.org/56183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Cast return value of postProcessDatabaseInsert to integer 18/56118/4
Susanne Moog [Thu, 15 Mar 2018 14:03:13 +0000 (15:03 +0100)]
[BUGFIX] Cast return value of postProcessDatabaseInsert to integer

Connection::lastInsertId returns a string but
DataHandler::postProcessDatabaseInsert has a strict integer return
value, so the value has to be casted to integer on return.

Additionally, when using sqlserver doctrine fails to fetch the last
inserted id under certain circumstances. An additional retrieval
method was introduced to mitigate that error.

Resolves: #84219
Releases: master, 8.7
Change-Id: I94dc0dc964aef26380703f641691c6a80ec5180d
Reviewed-on: https://review.typo3.org/56118
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodArgumentDroppedMatcherTest notice free 87/56187/3
Jan Helke [Thu, 15 Mar 2018 19:37:00 +0000 (20:37 +0100)]
[TASK] Make MethodArgumentDroppedMatcherTest notice free

Resolves: #84314
Releases: master
Change-Id: Ic8cba1972407b51d7deedb40bc4161dc19ab1601
Reviewed-on: https://review.typo3.org/56187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodArgumentRequiredMatcherTest notice free 89/56189/3
Jan Helke [Thu, 15 Mar 2018 19:42:47 +0000 (20:42 +0100)]
[TASK] Make MethodArgumentRequiredMatcherTest notice free

Releases: master
Resolves: #84316
Change-Id: Icf9cf8fe0dcd67be550c918d59e4cec34562ea32
Reviewed-on: https://review.typo3.org/56189
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodArgumentRequiredStaticMatcherTest notice free 90/56190/3
Jan Helke [Thu, 15 Mar 2018 19:46:34 +0000 (20:46 +0100)]
[TASK] Make MethodArgumentRequiredStaticMatcherTest notice free

Releases: master
Resolves: #84317
Change-Id: Ib758d64aa3613d7af4885338f8cf856412fbd6f9
Reviewed-on: https://review.typo3.org/56190
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodCallMatcherTest notice free 92/56192/3
Jan Helke [Thu, 15 Mar 2018 19:52:23 +0000 (20:52 +0100)]
[TASK] Make MethodCallMatcherTest notice free

Releases: master
Resolves: #84319
Change-Id: Iabb6167b952d5cbd456b9829452ca835f432af30
Reviewed-on: https://review.typo3.org/56192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodArgumentDroppedStaticMatcherTest notice free 88/56188/3
Jan Helke [Thu, 15 Mar 2018 19:40:00 +0000 (20:40 +0100)]
[TASK] Make MethodArgumentDroppedStaticMatcherTest notice free

Releases: master
Resolves: #84315
Change-Id: I6bb30f6289d5c5a9e5c36f21ab89cf4b84b5bad7
Reviewed-on: https://review.typo3.org/56188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Remove dependency to extbase from reports module 25/56125/10
Georg Ringer [Tue, 13 Mar 2018 08:13:36 +0000 (09:13 +0100)]
[TASK] Remove dependency to extbase from reports module

Simplify the reports module by removing usage of extbase.

Resolves: #84231
Releases: master
Change-Id: I33d55e60b454b0945a7a98f7cafb15bfc69dc18d
Reviewed-on: https://review.typo3.org/56125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[TASK] Make ArrayDimensionMatcherTest notice free 86/56186/2
Jan Helke [Thu, 15 Mar 2018 19:16:38 +0000 (20:16 +0100)]
[TASK] Make ArrayDimensionMatcherTest notice free

Resolves: #84313
Releases: master
Change-Id: I0834cf0cf8fb8aa802b1e4b1a005192cd5e2c276
Reviewed-on: https://review.typo3.org/56186
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodCallStaticMatcherTest notice free 93/56193/3
Jan Helke [Thu, 15 Mar 2018 19:54:32 +0000 (20:54 +0100)]
[TASK] Make MethodCallStaticMatcherTest notice free

Releases: master
Resolves: #84320
Change-Id: I7f1d2f09609a60586c8b894ff7e939f956c10833
Reviewed-on: https://review.typo3.org/56193
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make MethodArgumentUnusedMatcherTest notice free 91/56191/3
Jan Helke [Thu, 15 Mar 2018 19:50:02 +0000 (20:50 +0100)]
[TASK] Make MethodArgumentUnusedMatcherTest notice free

Releases: master
Resolves: #84318
Change-Id: I04cf297b740ec6022a70f8b48d4d7be48e72854b
Reviewed-on: https://review.typo3.org/56191
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in ContentElement/NewContentElementController 80/56180/10
Mathias Brodala [Thu, 15 Mar 2018 16:28:56 +0000 (17:28 +0100)]
[TASK] Use ServerRequestInterface in ContentElement/NewContentElementController

Change-Id: I247fc40072fb84fdb6dffe406786426ff5b9e10e
Resolves: #84307
Releases: master
Reviewed-on: https://review.typo3.org/56180
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make AbstractCoreMatcherTest notice free 85/56185/2
Jan Helke [Thu, 15 Mar 2018 19:03:23 +0000 (20:03 +0100)]
[TASK] Make AbstractCoreMatcherTest notice free

Resolves: #84312
Releases: master
Change-Id: Iee54bf0b2ff71668b666020dbcba7ca2dcc03296
Reviewed-on: https://review.typo3.org/56185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[FEATURE] Show value of fields in debug mode 47/56147/11
Georg Ringer [Wed, 14 Mar 2018 13:55:47 +0000 (14:55 +0100)]
[FEATURE] Show value of fields in debug mode

If the configuration `['BE']['debug']` is enabled and the current user is an administrator,
the value of select, radio and checkbox fields which are generated by
the `FormEngine` is appended to its label.

Resolves: #83748
Releases: master
Change-Id: I735bd3c83b5b12eb3cddcc66d1b92d48cf5e5991
Reviewed-on: https://review.typo3.org/56147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Extract html into fluid template from info module in admin panel 59/56159/7
Joerg Boesche [Thu, 15 Mar 2018 11:53:08 +0000 (12:53 +0100)]
[TASK] Extract html into fluid template from info module in admin panel

The info module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84286
Releases: master
Change-Id: Idcd0a21c8f7b3410ca7e67f746d45031652dce07
Reviewed-on: https://review.typo3.org/56159
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[TASK] Extract html into fluid template from preview module in admin panel 67/56167/9
Tobi Kretschmann [Thu, 15 Mar 2018 13:56:32 +0000 (14:56 +0100)]
[TASK] Extract html into fluid template from preview module in admin panel

The preview module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84211
Releases: master
Change-Id: I6b0a449216ff5b591eb123fdd2f9641fafeba3d8
Reviewed-on: https://review.typo3.org/56167
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[TASK] Use ServerRequestInterface in ContentElement/ElementInformationController 72/56172/8
Saskia Schreiber [Thu, 15 Mar 2018 14:47:01 +0000 (15:47 +0100)]
[TASK] Use ServerRequestInterface in ContentElement/ElementInformationController

This patch changes the ElementInformationController to consistently
use the ServerRequestInterface object instead of GeneralUtility
for the retrieval of POST/GETvars and server environment variables.

Also, to prepare for refactoring in v10,
all public properties and methods except mainAction() will throw
a deprecation notice if called.

Resolves: #84284
Releases: master
Change-Id: I5e9e22833aa0868319daef6d3744966f2f35fbb8
Reviewed-on: https://review.typo3.org/56172
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make L10nModeUpdaterTest notice free 84/56184/2
Jan Helke [Thu, 15 Mar 2018 17:53:23 +0000 (18:53 +0100)]
[TASK] Make L10nModeUpdaterTest notice free

Resolves: #84311
Releases: master
Change-Id: I494b83a27e333eed77837bee2586e448f5903566
Reviewed-on: https://review.typo3.org/56184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in MoveElementController 63/56163/12
Mathias Brodala [Thu, 15 Mar 2018 12:27:04 +0000 (13:27 +0100)]
[TASK] Use ServerRequestInterface in MoveElementController

Change-Id: Id817e4aa991ddfccaf1fcb6838d7354bc64235d6
Resolves: #84285
Releases: master
Reviewed-on: https://review.typo3.org/56163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make LogRecordTest notice free 78/56178/4
Sascha Löffler [Thu, 15 Mar 2018 16:10:44 +0000 (17:10 +0100)]
[TASK] Make LogRecordTest notice free

Resolves: #84309
Releases: master
Change-Id: I494c587ae28d4370e6c6da8edd467beba8eb436a
Reviewed-on: https://review.typo3.org/56178
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[TASK] Make SilentConfigurationUpgradeServiceTest notice free 82/56182/2
Jan Helke [Thu, 15 Mar 2018 17:37:09 +0000 (18:37 +0100)]
[TASK] Make SilentConfigurationUpgradeServiceTest notice free

Resolves: #84310
Releases: master
Change-Id: I6a3418fe449badd8beb1ec04f3d522c05696ce94
Reviewed-on: https://review.typo3.org/56182
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make DirectoryNodeTest notice free 77/56177/3
Jan Helke [Thu, 15 Mar 2018 16:10:24 +0000 (17:10 +0100)]
[TASK] Make DirectoryNodeTest notice free

Resolves: #84302
Releases: master
Change-Id: I6d0ea9879d4b4b37282b5446809ef28a01fdec51
Reviewed-on: https://review.typo3.org/56177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make FileNodeTest notice free 79/56179/3
Jan Helke [Thu, 15 Mar 2018 16:15:17 +0000 (17:15 +0100)]
[TASK] Make FileNodeTest notice free

Resolves: #84304
Releases: master
Change-Id: Ib45020524a699ae94f93ef6181e06100ccff1ffd
Reviewed-on: https://review.typo3.org/56179
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in LogoutController 64/56164/9
Łukasz Uznański [Thu, 15 Mar 2018 13:24:04 +0000 (14:24 +0100)]
[TASK] Use ServerRequestInterface in LogoutController

Set public methods deprecated, replace them by protected
methods and use them in class, set declare strict types.

Resolves: #84275
Releases: master
Change-Id: I4351a3a422347d643353b41188f07a6965e5e92a
Reviewed-on: https://review.typo3.org/56164
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make LocalizationUtilityTest notice free 71/56171/5
Jan Helke [Thu, 15 Mar 2018 14:55:56 +0000 (15:55 +0100)]
[TASK] Make LocalizationUtilityTest notice free

Releases: master
Resolves: #84281
Change-Id: Ibf5135a154c01bcd612f59a1ba9660f0f59fe5c6
Reviewed-on: https://review.typo3.org/56171
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Make ClassNamingUtilityTest notice free 54/56154/10
Jan Helke [Thu, 15 Mar 2018 10:53:29 +0000 (11:53 +0100)]
[TASK] Make ClassNamingUtilityTest notice free

Releases: master
Resolves: #84277
Change-Id: Ia0f884a217c9cceaf07b91cb34042f7c708356cf
Reviewed-on: https://review.typo3.org/56154
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[TASK] Make AbstractNodeTest notice free 75/56175/2
Jan Helke [Thu, 15 Mar 2018 16:03:31 +0000 (17:03 +0100)]
[TASK] Make AbstractNodeTest notice free

Resolves: #84301
Releases: master
Change-Id: I06da4d2dcebdb1dedd6609dca8b4239f9a48c9cf
Reviewed-on: https://review.typo3.org/56175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Make LinkNodeTest notice free 81/56181/3
Jan Helke [Thu, 15 Mar 2018 16:37:53 +0000 (17:37 +0100)]
[TASK] Make LinkNodeTest notice free

Resolves: #84305
Releases: master
Change-Id: Iecdf134051c03acc76452c637522a1201efff517
Reviewed-on: https://review.typo3.org/56181
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[FEATURE] Add debug attribute to RenderViewHelper 73/56173/5
Frank Naegler [Thu, 15 Mar 2018 15:37:18 +0000 (16:37 +0100)]
[FEATURE] Add debug attribute to RenderViewHelper

Resolves: #84216
Releases: master
Change-Id: I5eda479d37e31ad9d246ef3808f74a9c96d981c2
Reviewed-on: https://review.typo3.org/56173
Reviewed-by: Hendrik Stender <h.stender@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[TASK] Make LocalizationFactoryTest notice free 60/56160/4
Jan Helke [Thu, 15 Mar 2018 11:54:39 +0000 (12:54 +0100)]
[TASK] Make LocalizationFactoryTest notice free

Resolves: #84282
Releases: master
Change-Id: I8ba82db0dd83cf8bc8c2011bb5760f44763de109
Reviewed-on: https://review.typo3.org/56160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[BUGFIX] Use correct identifier for page tree icons binding 74/56174/2
Tymoteusz Motylewski [Thu, 15 Mar 2018 15:57:48 +0000 (16:57 +0100)]
[BUGFIX] Use correct identifier for page tree icons binding

The `stateIdentifier` is correct for nodes, but for icons `identifier`
 should be used.

Resolves: #84300
Releases: master
Change-Id: If014a19e4472d9737ee09c75970fd78e2615f150
Reviewed-on: https://review.typo3.org/56174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in File/CreateFolderController 68/56168/7
Anja [Thu, 15 Mar 2018 14:03:59 +0000 (15:03 +0100)]
[TASK] Use ServerRequestInterface in File/CreateFolderController

Use ServerRequestInterface object introduced earlier throughout the
controller instead accessing the global variables directly.

Visibility of properties and methods became more restrictive and will
report external usage by throwing deprecated errors.

Change-Id: Icf13b2b74507652541245453fd45558e7a24ea13
Resolves: #84289
Releases: master
Reviewed-on: https://review.typo3.org/56168
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Use ServerRequestInterface in FileSystemNavigationFrameController 56/56156/13
Łukasz Uznański [Thu, 15 Mar 2018 10:44:46 +0000 (11:44 +0100)]
[TASK] Use ServerRequestInterface in FileSystemNavigationFrameController

Change public properties to protected, add protected methods in
replacement of public, deprecate public methods, rewrite _GP

Resolves: #84273
Releases: master
Change-Id: I927829018e4e477e8176bfc3df0a21582f5d2261
Reviewed-on: https://review.typo3.org/56156
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Activate email validation for pages.author_email 55/56155/3
Josef Glatz [Thu, 15 Mar 2018 10:31:15 +0000 (11:31 +0100)]
[TASK] Activate email validation for pages.author_email

Activate email validation for pages.author_email as the field
is intended to hold an e-mail address of the author.

Resolves: #84279
Releases: master
Change-Id: Ib025ef413379fd94c4956401bce5a4bbc76bdb3f
Reviewed-on: https://review.typo3.org/56155
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Make LocallangXmlParserTest notice free 69/56169/4
Sascha Löffler [Thu, 15 Mar 2018 14:22:19 +0000 (15:22 +0100)]
[TASK] Make LocallangXmlParserTest notice free

Resolves: #84283
Releases: master
Change-Id: I9a047f95ca3cc57d951a36d5b9910678900e100f
Reviewed-on: https://review.typo3.org/56169
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
17 months ago[TASK] Extract html into fluid template from TS debug module in admin panel 53/56153/4
Joerg Boesche [Thu, 15 Mar 2018 09:27:57 +0000 (10:27 +0100)]
[TASK] Extract html into fluid template from TS debug module in admin panel

The TS debug module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84271
Releases: master
Change-Id: I351f2a2f67ad21b06859d9da1cd7bad7e1ae0e1d
Reviewed-on: https://review.typo3.org/56153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Hendrik Stender <h.stender@neusta.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
17 months ago[BUGFIX] Fix redirect after page/content move 65/56165/4
Mathias Brodala [Thu, 15 Mar 2018 13:26:35 +0000 (14:26 +0100)]
[BUGFIX] Fix redirect after page/content move

Change-Id: Ic72670657631c6f0ae792be4bcbd76fa63c0ac33
Resolves: #84292
Releases: master
Reviewed-on: https://review.typo3.org/56165
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[BUGFIX] LinkHandler creates wrong TS configuration 52/56152/2
Stefan Froemken [Thu, 15 Mar 2018 09:06:45 +0000 (10:06 +0100)]
[BUGFIX] LinkHandler creates wrong TS configuration

DatabaseRecordLinkBuilder creates a wrong
TypoScript configuration because of using
array_merge_recursive which joins all array elements
instead of replacing them.

Resolves: #84116
Releases: master,8.7
Change-Id: I212b70f86baf2929f9466fa665cec30fe477c6b8
Reviewed-on: https://review.typo3.org/56152
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wolfgang Wagner <wolfgang.wagner.fn@gmail.com>
Reviewed-by: Pascal Rinker <prinker@jweiland.net>
Tested-by: Pascal Rinker <prinker@jweiland.net>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[TASK] Notice free ExtensionUtility testing 61/56161/3
Anja [Thu, 15 Mar 2018 11:55:34 +0000 (12:55 +0100)]
[TASK] Notice free ExtensionUtility testing

Change-Id: I090939179f545acaaecb77f0c6ce7addabcde090
Resolves: #84278
Releases: master
Reviewed-on: https://review.typo3.org/56161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Throw exception when StringUtility is called with array 58/56158/5
Sascha Löffler [Thu, 15 Mar 2018 10:34:59 +0000 (11:34 +0100)]
[TASK] Throw exception when StringUtility is called with array

Throw exception when calling StringUtility with array and
remove suppressNotices in StringUtilityTest.

Change-Id: Ic2b7075f2943bda284d4747b8aaa4f4b6fb70e3b
Resolves: #84276
Releases: master
Reviewed-on: https://review.typo3.org/56158
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[BUGFIX] Make RecordBrowser highlight selected record again 70/54370/18
Stanislas Rolland [Wed, 11 Oct 2017 21:54:27 +0000 (17:54 -0400)]
[BUGFIX] Make RecordBrowser highlight selected record again

When using the element browser wizard with a configured record link
handler, the record browser now highlights the currently linked
record again.

Resolves: #82739
Releases: master, 8.7
Change-Id: Iba47f18bf150bb4646729c6a5ecdae46b7d56754
Reviewed-on: https://review.typo3.org/54370
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
17 months ago[BUGFIX] Accept configuration for external plugins from presets in ckeditor 57/52857/7
Marcus Schwemer [Thu, 18 May 2017 20:57:25 +0000 (22:57 +0200)]
[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Resolves: #81263
Releases: master,8.7
Change-Id: I4fc7c4f6f6ab40fe06e495e3ff98e067427c7d03
Reviewed-on: https://review.typo3.org/52857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[BUGFIX] Apply potential changes after form editor save operation 58/55958/2
Ralf Zimmermann [Wed, 28 Feb 2018 23:21:36 +0000 (00:21 +0100)]
[BUGFIX] Apply potential changes after form editor save operation

Apply potential form definition changes within the form editor,
if the form definition changes while saving it.
This is possible through the hook ['ext/form']['beforeFormSave']

Releases: master
Resolves: #84081
Change-Id: I0c20e0d20f9ec9ec8ccc0f279f68f9b4ebdfc306
Reviewed-on: https://review.typo3.org/55958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[BUGFIX] Database compare must show errors 96/56096/2
Guido Schmechel [Sun, 11 Mar 2018 14:12:33 +0000 (15:12 +0100)]
[BUGFIX] Database compare must show errors

If database compare fails because of wrong SQL,
it shows now the error message.

Resolves: #84137
Releases: master, 8.7
Change-Id: Ie9b92b5ee656f5d5bfe1e5bdac52afa6c61eff03
Reviewed-on: https://review.typo3.org/56096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>