Packages/TYPO3.CMS.git
2 years ago[BUGFIX] EXT:form - fix error on single database insert 69/53969/2
Mathias Brodala [Thu, 7 Sep 2017 18:37:13 +0000 (20:37 +0200)]
[BUGFIX] EXT:form - fix error on single database insert

Resolves: #81805
Releases: master, 8.7
Change-Id: I8ee3582170db9812d7be2b9710cb4d46335ec86a
Reviewed-on: https://review.typo3.org/53969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Install tool: CLI user is no system maintainer 81/53981/3
Mathias Brodala [Fri, 8 Sep 2017 06:51:00 +0000 (08:51 +0200)]
[BUGFIX] Install tool: CLI user is no system maintainer

Prevent selection of _cli_ user as system maintainer.

Related: #82319
Resolves: #82367
Releases: master
Change-Id: Ia1e67faea383817d4931c956a166525e1aa9e8e0
Reviewed-on: https://review.typo3.org/53981
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails 83/53383/8
Ralf Zimmermann [Mon, 3 Jul 2017 10:23:09 +0000 (12:23 +0200)]
[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails

Add a "renderingOptions" property called "_isHiddenFormElement" to
prevent form elements from being shown within summary pages and emails.

Resolves: #81770
Releases: master, 8.7
Change-Id: Iea3232879fc2be2cae00e5ed5cea565e68e192f3
Reviewed-on: https://review.typo3.org/53383
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - change naming and icon in new content element wizard 57/53957/5
Thomas Kieslich [Thu, 7 Sep 2017 15:04:00 +0000 (17:04 +0200)]
[TASK] EXT:form - change naming and icon in new content element wizard

Change language labels and move them to ext:form locallang.xlf.
Change the icon to content-form.

Resolves: #81650
Releases: master, 8.7
Change-Id: I1c497b78da92dc589ad9d7a47dde35c5aeba488a
Reviewed-on: https://review.typo3.org/53957
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Remove not working "Lock Install Tool" button 71/53971/3
Matthias Vogel [Thu, 7 Sep 2017 19:49:37 +0000 (21:49 +0200)]
[BUGFIX] Remove not working "Lock Install Tool" button

Resolves: #82359
Releases: master
Change-Id: Id439a0b04e6af11214d0df7b30cb20e7c94dd99c
Reviewed-on: https://review.typo3.org/53971
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error'] 17/53817/5
Benni Mack [Mon, 28 Aug 2017 04:48:14 +0000 (06:48 +0200)]
[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error']

The global variable $GLOBAL['error'] is used only in ExtJS-context for ExtDirect
(via ExtDirectDebug) however, but evaluates at every request.

This is the first of a series of patches to remove ExtJS in total.

The global methods debugBegin() and debugEnd() are removed as well.

Resolves: #37180
Releases: master
Change-Id: I00843d85660e85c213ac66059abdd84344c4fe3f
Reviewed-on: https://review.typo3.org/53817
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install tool: System maintainer administration 31/53931/6
Christian Kuhn [Wed, 6 Sep 2017 17:22:33 +0000 (19:22 +0200)]
[TASK] Install tool: System maintainer administration

Adds a card to the "Settings" menu to allow configuration of
"System Maintainers" in the install tool writing SYS/systemMaintainers
array to LocalConfiguration.

Change-Id: I0219b60e9a261373befab7b846e55b61ea215e5e
Resolves: #82319
Releases: master
Reviewed-on: https://review.typo3.org/53931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - fix values with dots within form editor 56/53956/7
Ralf Zimmermann [Thu, 7 Sep 2017 15:16:13 +0000 (17:16 +0200)]
[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53956
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] EXT:form - fix missing id attribute 59/53959/3
protos [Thu, 7 Sep 2017 15:33:32 +0000 (17:33 +0200)]
[BUGFIX] EXT:form - fix missing id attribute

Insert missing id attribute for image and file upload element.

Resolves: #82223
Releases: master, 8.7
Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd
Reviewed-on: https://review.typo3.org/53959
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - cleanup of leftovers, better wording 51/53951/3
protos [Thu, 7 Sep 2017 14:04:08 +0000 (16:04 +0200)]
[TASK] EXT:form - cleanup of leftovers, better wording

Change some wording for better understanding in frontend and backend.

Resolves: #82326
Releases: master, 8.7
Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae
Reviewed-on: https://review.typo3.org/53951
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] EXT:form - Add HTML5 form types / attributes 16/52016/19
Ralf Zimmermann [Sun, 12 Mar 2017 18:26:40 +0000 (19:26 +0100)]
[FEATURE] EXT:form - Add HTML5 form types / attributes

It is now possible to add HTML5 elements with its needs.

Resolves: #80130
Resolves: #80128
Resolves: #80127
Resolves: #80125
Resolves: #80126
Releases: master
Change-Id: I1088d77c8ee52cca93878847a5d59c6b92faf1de
Reviewed-on: https://review.typo3.org/52016
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] EXT:form - fix page drag & drop 49/53949/4
Ralf Zimmermann [Thu, 7 Sep 2017 13:29:54 +0000 (15:29 +0200)]
[BUGFIX] EXT:form - fix page drag & drop

Fix JavaScript errors on page drag & drop within the form editor

Resolves: #82337
Releases: master, 8.7
Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb
Reviewed-on: https://review.typo3.org/53949
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[FEATURE] Store extension configuration as plain array 57/53657/8
Susanne Moog [Thu, 20 Jul 2017 16:37:23 +0000 (18:37 +0200)]
[FEATURE] Store extension configuration as plain array

Extension configuration is now stored as plain array
instead of serialized values. To ensure backwards-
compatibility and stream-line core usage, the old
values will still be stored and written in
$GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'] whereas
the new array will be stored in
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF'].

As a second step we are going to introduce an API for
retrieving extension configuration to remove the necessity
for GLOBALS access in this case.

Resolves: #82254
Releases: master
Change-Id: I52ef7768491633e114e7e1b153a4ba63e07243ff
Reviewed-on: https://review.typo3.org/53657
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install Tool: Remove authentication from backend context 60/53860/7
Benni Mack [Fri, 1 Sep 2017 07:00:10 +0000 (09:00 +0200)]
[TASK] Install Tool: Remove authentication from backend context

Currently calling the install tool modules from within the Backend does a
simple redirect with adding GET variables.

That's the reason why you need to re-authenticate again, and the context
is handed over as a query parameter, which is simply not needed at all.

Now, the redirect is removed, as the Backend entrypoint / request handler
handles the authentication of the backend user, and the standalone entry
point deals with the install tool password etc.

The context parameter is now detected by the entry point (!) as well,
allowing to get rid of quite some code.

There are some more consequences:
- Calling the install tool from the backend does not validate if you configuration
is set up (= recovery necessary) -> since you're already in the backend we guess
you're fine anyway.
- Redirect functionality is almost not needed anymore in the regular request handler
- routeParameters concept was removed again (which was introduced a couple of weeks ago)

Additionally, the contextService could be replaced at a later stage with just
a string.

Resolves: #82306
Releases: master
Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c
Reviewed-on: https://review.typo3.org/53860
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Properly render multiline form values 50/53950/2
Daniel Lorenz [Thu, 7 Sep 2017 13:25:50 +0000 (15:25 +0200)]
[BUGFIX] Properly render multiline form values

Properly render multiline form values in summary page
and HTML emails.

Resolves: #82026
Releases: master, 8.7
Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587
Reviewed-on: https://review.typo3.org/53950
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Shorten form doc file paths 46/53946/3
Mathias Brodala [Thu, 7 Sep 2017 12:25:34 +0000 (14:25 +0200)]
[TASK] Shorten form doc file paths

Use shorter file paths to reduce the risk of hitting the Windows
file path limit.

Resolves: #82336
Releases: master
Change-Id: Ibbba15a71b6b69df52ccf009ebe298f09840d864
Reviewed-on: https://review.typo3.org/53946
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Tests for rendering tt_content with FAL in Extbase 21/53921/5
Tymoteusz Motylewski [Wed, 6 Sep 2017 07:01:49 +0000 (09:01 +0200)]
[TASK] Tests for rendering tt_content with FAL in Extbase

Functional tests checking Extbase rendering of tt_content
records with FAL images.

Also fixes two typos in fixture data.

Resolves: #82298
Releases: master, 8.7, 7.6
Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5
Reviewed-on: https://review.typo3.org/53921
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Do not use LIMIT/OFFSET on total count query 40/53940/2
Susanne Moog [Thu, 7 Sep 2017 08:27:30 +0000 (10:27 +0200)]
[BUGFIX] Do not use LIMIT/OFFSET on total count query

Usage of limit > 0 or offset in a count query do not
make sense and result in broken pagination in the list
module as the returned total count of items is always 0.

Reset given offsets/limit for that exact query.

Change-Id: I18b1964b860e51256a6d0a5f39fd4c40544bac85
Resolves: #82325
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - catch exceptions within page module and form engine 01/52701/5
Ralf Zimmermann [Thu, 4 May 2017 10:58:06 +0000 (12:58 +0200)]
[BUGFIX] EXT:form - catch exceptions within page module and form engine

* Show messages within page module and form engine if the backend user
  does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
  ext:form configuration is invalid.

Resolves: #80678
Resolves: #81113
Releases: master, 8.7
Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d
Reviewed-on: https://review.typo3.org/52701
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Move DefaultConfigurationDescription to Yaml format 23/53923/4
Benni Mack [Wed, 6 Sep 2017 05:13:45 +0000 (07:13 +0200)]
[TASK] Move DefaultConfigurationDescription to Yaml format

Defining all configuration options in TYPO3 Install Tool is now handled
via a Yaml file which additionally specifies the "type" of the configuration
option, allowing to use further render settings, one of them already introduced
for "allowedValues". This moves the "All Configuration" to a more flexible output
rendering of dropdowns for a specific type.

Resolves: #82312
Releases: master
Change-Id: Id23c6a8e57177a68659fe98cbe7278f8744c0c34
Reviewed-on: https://review.typo3.org/53923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove runtime cache and early return from TemplatePaths 17/53917/6
Claus Due [Tue, 5 Sep 2017 15:10:18 +0000 (17:10 +0200)]
[BUGFIX] Remove runtime cache and early return from TemplatePaths

This patch removes the previously introduced runtime cache
and early returns from TemplatePaths, both of which were
implemented in an attempt to prevent excessive TypoScript
parsing - an issue which has since been solved by optimising
the TypoScript parsing enough that a cache and early return
is no longer necessary (no longer constitutes a significant
performance increase).

The early return and caching introduced regressions described
in the related forge issues. Removing both solves those problems.

In addition, the method resolving TypoScript paths is now
covered by extensive unit tests confirming everything from
merging to sorting of template paths. An average of 8 tests
cover the method's lines. Each of the expected behaviors
is now declared as specific test.

Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63
Resolves: #82196
Resolves: #82181
Related: #79662
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update guzzlehttp/guzzle dependency to 6.3.0 24/53924/2
Benni Mack [Wed, 6 Sep 2017 07:57:40 +0000 (09:57 +0200)]
[TASK] Update guzzlehttp/guzzle dependency to 6.3.0

This brings PHP 7.2 support for guzzle functionality.

Verified that guzzle still runs with PHP7.0 (min requirement for us)

Resolves: #82313
Releases: master, 8.7
Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e
Reviewed-on: https://review.typo3.org/53924
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent empty sorting field to be quoted and put into an array 15/53915/2
Xavier Perseguers [Tue, 5 Sep 2017 14:17:26 +0000 (16:17 +0200)]
[BUGFIX] Prevent empty sorting field to be quoted and put into an array

Change-Id: I807a888ac7d977606d94f5ad9ccdfeee07ee61ec
Resolves: #82307
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Allow string as $subpartContent 16/53916/3
Sebastian Fischer [Tue, 5 Sep 2017 14:40:13 +0000 (16:40 +0200)]
[TASK] Allow string as $subpartContent

The parameter $subpartContent of substituteSubpart() can be either
string or array. IDEs need to have both present in the comment to not
show warnings for given parameters that are correct.

Resolves: #82308
Releases: master, 8.7
Change-Id: Ifcceb8dcd5ad8be56695cef161949046ff74c994
Reviewed-on: https://review.typo3.org/53916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Apply CGL fixes 05/53905/2
Oliver Hader [Tue, 5 Sep 2017 10:01:20 +0000 (12:01 +0200)]
[TASK] Apply CGL fixes

Releases: master, 8.7, 7.6
Change-Id: I167c68d7d04dd4b8c876b1f6f8f939cf3d933478
Reviewed-on: https://review.typo3.org/53905
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
2 years ago[!!!][TASK] Remove unused constant TYPO3_user_agent 08/53908/4
Benni Mack [Tue, 5 Sep 2017 10:20:18 +0000 (12:20 +0200)]
[!!!][TASK] Remove unused constant TYPO3_user_agent

The constant TYPO3_user_agent is removed as it is not in use anymore
since TYPO3 v8.

Resolves: #82296
Releases: master
Change-Id: I4860e291c1888251be5c64c2c454022f5d51643b
Reviewed-on: https://review.typo3.org/53908
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Add functional tests for rendering translated tt_content with FAL 98/53798/14
Tymoteusz Motylewski [Mon, 4 Sep 2017 12:07:01 +0000 (14:07 +0200)]
[TASK] Add functional tests for rendering translated tt_content with FAL

Functional tests checking TypoScript rendering of tt_content
records with FAL images.

Releases: master, 8.7, 7.6
Resolves: #82187
Change-Id: I5889ab13183b28dc2ff1ccc2c00c18f01ceacc76
Reviewed-on: https://review.typo3.org/53798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[SECURITY] Disallow pht as file extension 04/53904/2
Susanne Moog [Tue, 5 Sep 2017 09:37:42 +0000 (11:37 +0200)]
[SECURITY] Disallow pht as file extension

Some web servers allow and accept pht files as PHP files
and execute them. Thus, pht should be part of the default
file deny pattern and PHP file extensions.

Resolves: #82078
Releases: master, 8.7, 7.6
Security-Commit: d7e19499bfa4bd552d4428a2b9a943005c20c61d
Security-Bulletin: TYPO3-CORE-SA-2017-007
Change-Id: Ibadcaa8c32b70b9aec569027862918d0360ec075
Reviewed-on: https://review.typo3.org/53904
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Remove version from default User-Agent 03/53903/2
Susanne Moog [Tue, 5 Sep 2017 09:37:28 +0000 (11:37 +0200)]
[SECURITY] Remove version from default User-Agent

TYPO3 does no longer send the concrete TYPO3 version as
part of the default User-Agent header when doing requests.

Resolves: #82072
Releases: master, 8.7, 7.6
Security-Commit: f5558a5d745f2bafe3c27d5621ef1ce26f3989a9
Security-Bulletin: TYPO3-CORE-SA-2017-006
Change-Id: If9d7745d909e93899e2b405e016518a9284a1006
Reviewed-on: https://review.typo3.org/53903
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Respect permissions of storages in a file collection 02/53902/2
Georg Ringer [Tue, 5 Sep 2017 09:37:22 +0000 (11:37 +0200)]
[SECURITY] Respect permissions of storages in a file collection

If a user creates a sys_file_collection record, only those
storage records must be shown which are allowed for the
user.

Resolves: #82029
Releases: master, 8.7, 7.6
Security-Commit: 45cdfccd52a224d8128e537214606848c717d8e7
Security-Bulletin: TYPO3-CORE-SA-2017-005
Change-Id: Iee94cd84f07ee0dc0730fe1ce84d228dad2f75a2
Reviewed-on: https://review.typo3.org/53902
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Escape record title in RecordsOverview 01/53901/2
Georg Ringer [Tue, 5 Sep 2017 09:37:15 +0000 (11:37 +0200)]
[SECURITY] Escape record title in RecordsOverview

The record title must be properly escaped.

Resolves: #81967
Releases: master, 8.7
Security-Commit: bb686f45996424aadd68185871c14bb4544107c2
Security-Bulletin: TYPO3-CORE-SA-2017-004
Change-Id: I71c8bdef21e76fafdae170c6ebd9f0f0834d5b0e
Reviewed-on: https://review.typo3.org/53901
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Fluid: Migrate same methods into AbstractTemplateView 31/53831/3
Benni Mack [Wed, 30 Aug 2017 06:10:20 +0000 (08:10 +0200)]
[TASK] Fluid: Migrate same methods into AbstractTemplateView

StandaloneView currently replicates a lot of code which is already
present within TemplateView (= Extbase), however, both classes inherit
from AbstractTemplateView.

In order to see which parts are different (and continue on streamlining
fluid) the parts can be placed within AbstractTemplateView.

Resolves: #82269
Releases: master
Change-Id: I4184a5899b98227cf50f93db6c3ae38812cc86ec
Reviewed-on: https://review.typo3.org/53831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Space before class has a typo in access list for page content 75/53875/2
Jörg Bösche [Mon, 4 Sep 2017 11:15:30 +0000 (13:15 +0200)]
[BUGFIX] Space before class has a typo in access list for page content

The locallang_ttc.xlf has a typo in the key "space_before_class" which
is shown in the access list of a page content field.

Resolves: #82284
Releases: master, 8.7
Change-Id: Id61c8c7d5c5da11b8f7bb3e55e49d7613e593730
Reviewed-on: https://review.typo3.org/53875
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser 73/53873/2
Georg Ringer [Mon, 4 Sep 2017 06:44:56 +0000 (08:44 +0200)]
[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser

Remove a not needed </td> tag which has not been removed with the
refactoring.

Resolves: #82279
Releases: master, 8.7, 7.6
Change-Id: I2077e9e0b0119e6b064b0a6d4ebb9c3dc1d848a4
Reviewed-on: https://review.typo3.org/53873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Install Tool: Use PSR-7 for fetching all POST parameters 59/53859/4
Benni Mack [Thu, 31 Aug 2017 21:07:28 +0000 (23:07 +0200)]
[TASK] Install Tool: Use PSR-7 for fetching all POST parameters

Resolves: #82270
Releases: master
Change-Id: I37fbb8c1d5199239eaa4cd432fb49d958bc86123
Reviewed-on: https://review.typo3.org/53859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Improve performance of Fluid TemplatePaths 24/53824/3
Claus Due [Mon, 28 Aug 2017 20:27:26 +0000 (22:27 +0200)]
[TASK] Improve performance of Fluid TemplatePaths

This patch improves the performance of TemplatePaths
in two ways:

* GeneralUtility::removeDotsFromTS() is called on a far
  smaller array instead of all TypoScript.
* Fallback paths are allowed to be cached in the runtime
  cache which avoids re-reading TypoScript when no
  paths are configured in TS.

Saves several thousand calls to removeDotsFromTs
which in turn saves several tens of thousands of calls
to in_array.

Change-Id: Ib8aef69dc9136d355441ac05f21fe391e524eacc
Resolves: #82232
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53824
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Fix broken validation translation form docs 51/53851/3
Justus Leon Moroni [Thu, 31 Aug 2017 16:59:39 +0000 (18:59 +0200)]
[TASK] Fix broken validation translation form docs

The TranslationService uses the additional key 'error' in its translations
of the validation errors.

See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Service/TranslationService.php#L428.

Releases: master,8.7
Resolves: #82264
Change-Id: Id00b60de0bf1b2b882f583f538be9bc8e40c010f
Reviewed-on: https://review.typo3.org/53851
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Install Tool: Introduce PSR-7 response objects 56/53856/5
Benni Mack [Thu, 31 Aug 2017 18:34:22 +0000 (20:34 +0200)]
[TASK] Install Tool: Introduce PSR-7 response objects

Uses PSR-7 instead of plain echo() and die - and shutdown the
install tool properly (except for redirects currently).

In the future, we should introduce proper PSR-7 response objects
for certain responses (JSON, Redirect) but this will happen in
a separate step.

Resolves: #82268
Releases: master
Change-Id: If8124f975936f6205f45009d30d979204765d8d1
Reviewed-on: https://review.typo3.org/53856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Only allow access to install tool for system maintainers 30/53830/11
Benni Mack [Tue, 29 Aug 2017 21:09:27 +0000 (23:09 +0200)]
[FEATURE] Only allow access to install tool for system maintainers

A new option $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers']
is introduced, which contains a list of Backend User uids. It is
then possible to restrict access to backend modules to system
maintainers - most importantly the four Install Tool modules.

When this option is not set in LocalConfiguration.php, then all
admins are system maintainers, same goes for accessing TYPO3
in Development context.

This is the first step to remove the necessary "enter your
intall tool password" when accessing the install tool from
within TYPO3 Backend.

Resolves: #82266
Releases: master
Change-Id: If0026748ede694394b4e7f39788a650816160146
Reviewed-on: https://review.typo3.org/53830
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Remove suhosin mentions 58/53858/2
Christian Kuhn [Thu, 31 Aug 2017 19:12:27 +0000 (21:12 +0200)]
[TASK] Remove suhosin mentions

The master version of this 8.7 patch just removes
last mentions of suhosin from the codebase.

Change-Id: If003a8db37660662c65290a1e1bf25ef61375b80
Resolves: #82267
Related: #82257
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53858
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Install Tool: Migrate authentication logic into AuthenticationService 37/53837/6
Benni Mack [Wed, 30 Aug 2017 11:23:47 +0000 (13:23 +0200)]
[TASK] Install Tool: Migrate authentication logic into AuthenticationService

The PHP request flow logic for authentication against the install tool password
is moved into a new class called AuthenticationService.

Additionally, all logic which is only needed inside the StepController is moved
from the AbstractController into the StepController or the recovery request handler.

ToolController and AjaxController are now free of session handling completely.

Resolves: #82265
Releases: master
Change-Id: Ib75c920877da81d7d859feaa5e6cbbcf4f0fd2cf
Reviewed-on: https://review.typo3.org/53837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Install tool: Use ext:core messaging 35/53835/12
Christian Kuhn [Wed, 30 Aug 2017 10:39:07 +0000 (12:39 +0200)]
[TASK] Install tool: Use ext:core messaging

The install tool brought its own "status message" class
structure since the 6.2 refactoring. This is used at many
places in the install tool for message handling.

The core has a very similar class construct "Messaging"
with only little dependencies, too. To simplify a later
separation of 'install tool' and 'installer' the internal
status message class structure is removed and transitioned
to the core Messaging structure. to get rid of just
another special thing the install tool does.

The ext:core FlashMessage and FlashMessageQueue now both
implement the \JsonSerialize interface. This allows direct
json_encode() calls on these objects, helpful for instance
for ajax responses.

In ext:install "Environment checks" suhosin specific checks
have been removed since the project is dead and only has a
pre-alpha php 7.0 fork, so probably nobody is using
that with the given core PHP constraints anymore.

Change-Id: Ifecd3cd4889d8db5aaf3e87f317c98be706ae82b
Resolves: #82257
Releases: master
Reviewed-on: https://review.typo3.org/53835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Move signal slots from EXT:install to EXT:core 36/53836/4
Benni Mack [Wed, 30 Aug 2017 10:38:40 +0000 (12:38 +0200)]
[TASK] Move signal slots from EXT:install to EXT:core

The left-over signals in EXT:install/ext_localconf.php belong
to EXT:core (uses classes from EXT:core anyways) and since
both extensions are required at any time (part of minimal system)
this is just a separation cleanup.

Resolves: #82241
Releases: master
Change-Id: I9ec93ada9b4985ced285276fa5c33b851ec0be8f
Reviewed-on: https://review.typo3.org/53836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Improve exception for invalid transOrigPointerField 88/53788/3
Mathias Brodala [Wed, 23 Aug 2017 06:52:09 +0000 (08:52 +0200)]
[TASK] Improve exception for invalid transOrigPointerField

Resolves: #82175
Releases: master, 8.7
Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed
Reviewed-on: https://review.typo3.org/53788
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] a div around no-result to style it 99/53799/2
Fabian Thommen [Thu, 24 Aug 2017 14:49:08 +0000 (16:49 +0200)]
[TASK] a div around no-result to style it

Releases: master
Resolves: #82194
Change-Id: I6bb00c14dc331ec362614d00e48bf169da7cd572
Reviewed-on: https://review.typo3.org/53799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sidoine Ghomsi Nokam <s.ghomsinokam@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Only reorder integer keys in ArrayUtility 05/53805/2
Susanne Moog [Fri, 25 Aug 2017 05:17:57 +0000 (07:17 +0200)]
[BUGFIX] Only reorder integer keys in ArrayUtility

PHP already converts strings representing 8-bit integers
to int - so there are no numeric array keys that are
of type string that ArrayUtility should reorder.

Change-Id: Ieff77f4b1b8d6cbadba73dad06e9ec02d8748e85
Resolves: #82201
Releases: master
Reviewed-on: https://review.typo3.org/53805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix broken identifier in form docs 25/53825/5
Daniel Siepmann [Tue, 29 Aug 2017 09:32:04 +0000 (11:32 +0200)]
[TASK] Fix broken identifier in form docs

Within the docs, an incorrect identifier is used for a custom finisher.
This has been fixed and is in line with the example code above.

Releases: master,8.7
Resolves: #82234
Change-Id: I41881f825e7961f4945805360683c3189f2f9fcb
Reviewed-on: https://review.typo3.org/53825
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - use configured finisher identifiers for translations 63/53363/3
Ralf Zimmermann [Fri, 30 Jun 2017 08:12:19 +0000 (10:12 +0200)]
[BUGFIX] EXT:form - use configured finisher identifiers for translations

Use the configured finisher identifier for translation keys instead of
the finisher class name.

Resolves: #81591
Releases: master, 8.7
Change-Id: Ib78e942121b4b6e299ae394c30261603760444f7
Reviewed-on: https://review.typo3.org/53363
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Denis Mir <mir.denis@googlemail.com>
Tested-by: Denis Mir <mir.denis@googlemail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.1.2 40/53840/2
Christian Kuhn [Thu, 31 Aug 2017 10:45:52 +0000 (12:45 +0200)]
[TASK] Update typo3/testing-framework to 1.1.2

Brings a bug fix in frontend functional test parsing.

Change-Id: I3e95f4ee12069bbbfc225fb5045793273eff6f95
Resolves: #82256
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use proper key name in db config 33/53833/3
Ludwig Rafelsberger [Wed, 30 Aug 2017 07:47:32 +0000 (09:47 +0200)]
[BUGFIX] Use proper key name in db config

Releases: master,8.7
Resolves: #82239
Change-Id: I90d4ecdb4917c567a652a7bf5d24b55b39d646fd
Reviewed-on: https://review.typo3.org/53833
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Install Tool: Split up Checks into RequestHandlers 00/53800/21
Benni Mack [Thu, 24 Aug 2017 19:20:09 +0000 (21:20 +0200)]
[TASK] Install Tool: Split up Checks into RequestHandlers

In order to get the controllers free of security checks, the logic of
authentication/session handling is moved from various controllers into
the RequestHandler and the Application.

Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced
which acts as a fallback if TYPO3 is not installed yet, or the installation is
broken (e.g. missing PackageStates.php).

This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler
(which can handle any request) dealing with the StepController, and the
regular RequestHandler (with higher priority) for handling the maintenance
functionality for running installations.

Resolves: #82238
Releases: master
Change-Id: I906ab3f15479bbe70202608f6bd7838cc22d9e3a
Reviewed-on: https://review.typo3.org/53800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update Fluid dependency to 2.4.0+ 23/53823/4
Claus Due [Mon, 28 Aug 2017 15:56:52 +0000 (17:56 +0200)]
[TASK] Update Fluid dependency to 2.4.0+

This patch updates the composer Fluid dependency
to version 2.4.0 and above. Fixes multiple bugs and
performance issues - and adds a few new features.

Full list of changes:

https://github.com/TYPO3/Fluid/compare/2.3.4...2.4.0

Change-Id: I2d16c6c95ecb6c985da772736d066d8e10da8761
Resolves: #82230
Releases: master
Reviewed-on: https://review.typo3.org/53823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Install tool: Disable/Enable db analyzer buttons 21/53821/4
Christian Kuhn [Mon, 28 Aug 2017 10:39:39 +0000 (12:39 +0200)]
[BUGFIX] Install tool: Disable/Enable db analyzer buttons

The database analyzer buttons "Run again" and "Apply" are
now disabled when a scan is in progress.
This prevents multiple ajax calls in
parallel which lead to duplicate output.

Change-Id: I28df15e2c7169960e0889aed903bbd72034f07cc
Resolves: #82152
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53821
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove extended fluid core class CmsVariableProvider 27/53227/4
Benni Mack [Thu, 15 Jun 2017 20:28:16 +0000 (22:28 +0200)]
[TASK] Remove extended fluid core class CmsVariableProvider

The CmsVariableProvider within EXT:fluid extends a Fluid core class with
the same functionality and can be removed. A class alias ensures that the
PHP class is still available.

Resolves: #82229
Releases: master
Change-Id: I71eb7beaf0684631d9c7e857bbed91f08b75d47c
Reviewed-on: https://review.typo3.org/53227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update CKEditor to 4.7.2 51/53751/3
Anders Kostending [Mon, 21 Aug 2017 10:38:12 +0000 (12:38 +0200)]
[TASK] Update CKEditor to 4.7.2

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/release-notes

Fixes:
 * Added Advanced Content Filter integration with the Justify plugin.
 * [Chrome] Fixed: Clicking the scrollbar throws an Uncaught TypeError:
 element.is is not a functionerror.
 * Fixed: Widgets cannot be properly pasted into a table cell.
 * Fixed: Internal cke_table-faked-selection-table class is visible
 in the Stylesheet Classes field of the Table Properties dialog.
 * [Edge] Fixed: Error thrown when pressing the Select All button
 in Source Mode.
 * Fixed: Double slash in the path to stylesheet needed by the
 Table Selection plugin.
 * Fixed: Unnecessary dependency on the Editor Toolbar plugin inside
 the Notification plugin.
 * Fixed: Error thrown into the browser console after opening the
 Styles Combo plugin menu in the editor without any selection.
 * Fixed: Double click does not open the dialog for modifying anchors
 inserted via the Link plugin.
 * [IE8-9] Fixed: Clicking inside an empty read-only editor throws
 an error.
 * [IE10] Fixed: Clicking below a single horizontal rule throws
 an error.
 * Fixed: The range.cloneContents method selects the whole element when
 the selection starts at the beginning of that element.
 * Fixed: The range.extractContents method returns an incorrect result
 when multiple nodes are selected.
 * Fixed: The elementPath.contains method incorrectly excludes the last
 element instead of root when the fromTop parameter is set to true.
 * Fixed: SCAYT leaves underlined word after the CKEditor Replace
 dialog corrects it.
 * Added the CKEDITOR.dom.nodeList.toArray method which returns an
 array representation of a node list.

Resolves: #82143
Releases: master, 8.7
Change-Id: I6f6037e48d768e4a2887c799c1791f3201ce40c8
Reviewed-on: https://review.typo3.org/53751
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Always show input field for empty link fields 90/53790/2
Johannes Schlier [Wed, 23 Aug 2017 14:34:01 +0000 (16:34 +0200)]
[BUGFIX] Always show input field for empty link fields

The trigger values can be hardcoded here, as the previous
filtering only gives us fields for which we want to hide
the explanation and show the input field.
Previuosly each time a new link field was created  (as an
IRRE element for example) the input and explanation fields
were triggered. This created confusion with editors and
also broke the trigger button, so that fields that were in
the explanation mode could not be triggered back to input mode.

Resolves: #82179
Releases: master, 8.7
Change-Id: Ic92129c6cdafe5fab19fbc76b9e9b7713b9e8736
Reviewed-on: https://review.typo3.org/53790
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Install tool: Presets with custom im/gm paths 22/53822/2
Christian Kuhn [Mon, 28 Aug 2017 12:06:21 +0000 (14:06 +0200)]
[BUGFIX] Install tool: Presets with custom im/gm paths

Fix "Find imagemagick / graphicsmagic in specific direcory" input
field in image preset handling.
The preset handling is still a bit ugly and does not integrate
too well into the ajax based handling all other cards use. This
needs a bigger refactoring and is not done with this patch.
For now, submitting a path to the image preset path input field
reloads the view and executes the path test, so the functionality
is there, it's just a bit ugly to use.

Change-Id: I2da1680b44ff34df05aecc4eb589a293bb8d72c2
Resolves: #82188
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Render additionalAttributes and data-* attr in media renderer 88/53488/11
Markus Hoelzle [Fri, 14 Jul 2017 20:19:52 +0000 (22:19 +0200)]
[FEATURE] Render additionalAttributes and data-* attr in media renderer

Render additionalAttributes and data-* attributes in VideoTag,
YouTube, Vimeo and AudioRenderer if set in the Fluid MediaViewHelper.

Releases: master
Resolves: #81741
Change-Id: Ieef9eae905a33e09e225d3a563c3f31988a65a57
Reviewed-on: https://review.typo3.org/53488
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix links to backend admin / frontend website in Install Tool 03/53803/3
Andreas Fernandez [Thu, 24 Aug 2017 19:28:15 +0000 (21:28 +0200)]
[BUGFIX] Fix links to backend admin / frontend website in Install Tool

The install tool (/typo3/install.php) is at the same directory location
as the backend interface. The links are fixed to point to the correct
locations.
Remove an obsolete f:if along the way, this partial is only loaded
in non backend context anyway.

Resolves: #82199
Related: #76084
Releases: master
Change-Id: I73ff8b0a3bd22827fa2a2c319b0e0bb2ad4e5afa
Reviewed-on: https://review.typo3.org/53803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make extbase language handling consistent with TYPO3 v7 96/53796/3
Tymoteusz Motylewski [Wed, 23 Aug 2017 19:05:56 +0000 (21:05 +0200)]
[BUGFIX] Make extbase language handling consistent with TYPO3 v7

During doctrine migration a change of behaviour was introduced.
In v7 when a translated record is hidden, it's not shown,
while before this patch, a record from default language was shown.

Resolves: #82161
Releases: master, 8.7
Change-Id: Ib8127eff7218f9dd064febbab4956af44f3164b9
Reviewed-on: https://review.typo3.org/53796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Add missing blank lines below `code-block` in ExtendT3editor.rst 14/53814/2
Andreas Fernandez [Sun, 27 Aug 2017 18:16:52 +0000 (20:16 +0200)]
[BUGFIX] Add missing blank lines below `code-block` in ExtendT3editor.rst

Due to invalid syntax used at the code blocks, the code is not rendered at
all. This patch adds the missing blank linkes.

Resolves: #82218
Related: #81901
Releases: master
Change-Id: Iadb034f0cfd250cf1871b65d417844e999d836e5
Reviewed-on: https://review.typo3.org/53814
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][TASK] Use protocol in pages.url and migrate pages.urltype 98/53198/11
Benni Mack [Tue, 13 Jun 2017 11:01:44 +0000 (13:01 +0200)]
[!!!][TASK] Use protocol in pages.url and migrate pages.urltype

The field pages.urltype contains "0", "1", "2" which maps to a protocol,
however most people want to just paste the url in the "pages.url" field.

This change drops the DB field "pages.urltype" and merges the value
into "pages.url" directly.

Resolves: #71306
Releases: master
Change-Id: I309724ba48ac9c5674a75e79da6cbb6e4880e521
Reviewed-on: https://review.typo3.org/53198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Use codemirror-minified package 06/53806/2
Andreas Fernandez [Fri, 25 Aug 2017 08:57:33 +0000 (10:57 +0200)]
[TASK] Use codemirror-minified package

CodeMirror is offered as a minified version. As there is no benefit of
using a "full-blown" version, switch to minified version instead.

Resolves: #82204
Releases: master
Change-Id: I8e15e1ea8266951430ebeb86445b3cd2db524caf
Reviewed-on: https://review.typo3.org/53806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Install tool: Remove fatal error handling 04/53804/4
Christian Kuhn [Thu, 24 Aug 2017 22:11:57 +0000 (00:11 +0200)]
[TASK] Install tool: Remove fatal error handling

Before refactoring of the install tool with #76084, a
'fatal error handler' was in place to redirect to the
extension checker if a fatal php error was detected
during one of the main "tool" actions.
Now, the main controllers of the install tool never
load non-core extension data anymore, those can't
fail due to issues with specific ext_localconf.php or
ext_tables.php files. This extension loading now happens
only in ajax actions and thus can't kill the whole install
tool anymore.
Left over error handler code is removed from the
ToolController with this patch.

Change-Id: I0d0398f7b66a6a2c64dec48fe60a722698688a59
Resolves: #82200
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53804
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Class references to SqlExpectedSchemaService 01/53801/3
Christian Kuhn [Thu, 24 Aug 2017 19:18:48 +0000 (21:18 +0200)]
[BUGFIX] Class references to SqlExpectedSchemaService

With the doctrine migration a signal formerly located in class
SqlExpectedSchemaService has been moved to class SqlReader.
The old SqlExpectedSchemaService has been removed with issue #82148.
Slot for that moved signal should now switch to the string
literal of the class name.

Change-Id: Id1cb28b236c7025308b0f0be3f969903df4c4ea5
Resolves: #82197
Related: #82148
Releases: master
Reviewed-on: https://review.typo3.org/53801
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix markup of module icon in Install Tool 02/53802/2
Andreas Fernandez [Thu, 24 Aug 2017 19:23:07 +0000 (21:23 +0200)]
[BUGFIX] Fix markup of module icon in Install Tool

Resolves: #82198
Releases: master
Change-Id: I62e3f378031197d87c318b2062d434a99c9a71a4
Reviewed-on: https://review.typo3.org/53802
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Extbase distinct query result handling 58/53658/28
Oliver Hader [Mon, 21 Aug 2017 08:13:20 +0000 (10:13 +0200)]
[BUGFIX] Extbase distinct query result handling

Since Doctrine DBAL has been integrated into the TYPO3 core during
version 8 development and Extbase queries have been adjusted with
TYPO3 version 8.4.0, the behavior on distinct query results were
mixed up as well.

Extbase queries using the query-builder until TYPO3 7 LTS contained a
dedicated `SELECT DISTINCT` when retrieving data which lead to unique
entities, especially when implicit `LEFT JOIN` statements have been
added to the query to resolve cardinalities of the types one-to-many
and many-to-many.

Besides that using `GROUP BY` is not reliable in this particular
Extbase scenario. Further details can be found in MySQL documentation:
https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html

Change-Id: Ic5fd1d4752eefec7fcff37d8d62f55ea7299e8d6
Resolves: #80380
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Install tool: strict_types fatal in environment 97/53797/2
Christian Kuhn [Wed, 23 Aug 2017 19:51:03 +0000 (21:51 +0200)]
[BUGFIX] Install tool: strict_types fatal in environment

If im / gm are not configured, the Environment module may
throw a fatal since refactoring. The patch sanitizes that
and fixes the "Current configuration" view in
"Image Processing" card which broke during refactoring, too.

Change-Id: I6180a10150e63182c23dd7d7e8257e99a8652533
Resolves: #82160
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Install tool: Use CardLayout events to init card 94/53794/3
Frank Naegler [Wed, 23 Aug 2017 18:07:59 +0000 (20:07 +0200)]
[BUGFIX] Install tool: Use CardLayout events to init card

Some install tool cards load content on opening the card.
The patch now fires events on open and modules single card
JS binds to those events to load content.
This fixes the prev/next buttons in docheader to init
card content correctly.

Resolves: #82185
Releases: master
Change-Id: Iad04a0fc560df8511f716982456b2ac3ae0644bb
Reviewed-on: https://review.typo3.org/53794
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update php-cs-fixer to 2.5.0 91/53791/6
Wouter Wolters [Wed, 23 Aug 2017 16:45:54 +0000 (18:45 +0200)]
[TASK] Update php-cs-fixer to 2.5.0

Add 2 new rules

* no_superfluous_elseif
* no_useless_else

Both rules only apply if the if-statement contains a return. If this
is the case the obsolete else/elseif part is dropped.

Resolves: #82183
Releases: master,8.7
Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a
Reviewed-on: https://review.typo3.org/53791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class 31/53731/5
Mathias Brodala [Fri, 18 Aug 2017 12:53:03 +0000 (14:53 +0200)]
[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class

Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7
Resolves: #82131
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53731
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] CGL fixes after upgrade to php-cs-fixer 1.4 76/53776/3
Christian Kuhn [Tue, 22 Aug 2017 17:33:24 +0000 (19:33 +0200)]
[TASK] CGL fixes after upgrade to php-cs-fixer 1.4

Change a series of cgl details after update of php-cs-fixer
from 1.0 to 1.4.

Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f
Resolves: #82171
Related: #82164
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Mark not set Install Tool password as secure 57/53757/5
Frans Saris [Mon, 21 Aug 2017 13:59:35 +0000 (15:59 +0200)]
[BUGFIX] Mark not set Install Tool password as secure

To completely disable the Install Tool you can just leave the
`installToolPassword` value empty in your LocalConfiguration.
Problem here is that not all password hashing methods can handle an
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install
password hashing/check when there is no password.

Releases: master, 8.7
Resolves: #82147
Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5
Reviewed-on: https://review.typo3.org/53757
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Upgrade version of D3.js to version 4.10.0 74/53574/4
Anders Kostending [Mon, 24 Jul 2017 07:37:16 +0000 (09:37 +0200)]
[TASK] Upgrade version of D3.js to version 4.10.0

Updates D3.js to the latest release version, 4.10.0.

Release notes:
https://github.com/d3/d3/releases/tag/v4.10.0

Fixes:
 * Add d3.areaRadial; deprecate d3.radialArea.
 * Add d3.lineRadial; deprecate d3.radialLine.
 * Add d3.pointRadial.
 * Add zoom.translateTo.
 * Re-implement d3.packEnclose using Matoušek-Sharir-Welzl.
 * Fix d3.packSiblings to center the circles more consistently
 around a fixed origin.
 * Fix axis rendering when a scale has a non-numeric range.
 * Fix interval.offset on filtered time intervals when step
 is negative.
 * Fix invocation of requestAnimationFrame in Edge.
 * Invoke nest.sortValues comparator prior to nest.rollup
 aggregator.
 * Drag & zoom behaviors now only register touch event
 listeners when touch is supported.
 * Drag & zoom behaviors now set the touch-action style to
 “none” when touch is supported.

Resolves: #81945
Releases: master, 8.7
Change-Id: Idcd0826d2bd50467558d1bd6229d84651b93f4b0
Reviewed-on: https://review.typo3.org/53574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morten Pless <mpl@systime.dk>
Tested-by: Morten Pless <mpl@systime.dk>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Throw exception if encryption key is not set 24/53724/6
Helmut Hummel [Thu, 17 Aug 2017 16:41:39 +0000 (18:41 +0200)]
[BUGFIX] Throw exception if encryption key is not set

The encryption key is a vital part to ensure security
of TYPO3. Not having it set (by accident) can lead
to severe security issues.

Therefore enforce it to be set and throw an exception
in case it isn't, instead of just reporting a warning.

Releases: master, 8.7, 7.6
Resolves: #82169
Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3
Reviewed-on: https://review.typo3.org/53724
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Extension Scanner finds files on Windows 63/53763/4
Jigal van Hemert [Tue, 22 Aug 2017 06:53:55 +0000 (08:53 +0200)]
[BUGFIX] Extension Scanner finds files on Windows

The extension scanner now also works on windows, as
the paths have been fixed to contain only one type of
slashes.

Change-Id: I9859f28029931f19f06873145e1de572fbb8bdfa
Resolves: #82153
Releases: master
Reviewed-on: https://review.typo3.org/53763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update Build/tsconfig.json 82/53782/3
Christian Kuhn [Tue, 22 Aug 2017 18:51:42 +0000 (20:51 +0200)]
[TASK] Update Build/tsconfig.json

Executing 'npm run build-js' in Build/ directory
reveals an update to tsconfig.json which has not
been applied to core yet.

Change-Id: Ida813943c3c8dc13059a707a9ea89954a14b3fd4
Resolves: #82173
Related: #81847
Releases: master
Reviewed-on: https://review.typo3.org/53782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Extension manager: Drop "Download SQL Dump" 64/53764/3
Christian Kuhn [Mon, 21 Aug 2017 15:05:08 +0000 (17:05 +0200)]
[!!!][TASK] Extension manager: Drop "Download SQL Dump"

The em in "Installed Extensions" has a button "Download SQL Dump"
for all extensions that provide ext_tables.sql. On click, an sql
dump file is sent.

This feature is severely flawed:
* Dumps of extensions that add fields to existing tables contain
  a 'drop table' of these tables, the 'import into' statements are
  broken and only (try to) add these fields again. This easily
  leads to hazard in DB if importing such a dump.
* There are no charset specs and other meta data whatsoever in the dump.
* The dump is not dbal compatible, field definitions and imports
  are incomplete.

We assume nobody really used this feature in a sane way, even at
this prominent position in em. The lack of bug reports to this
broken feature and the fact there have been zero changes in this
area since main em refactoring years ago support this view.

There are way better options to retrieve proper data specifications:
* The list module has a csv export
* Ext:impexp supports export and import in a much better way
  including proper relation handling and other options.
* Low level db exports and backups should be done on cli or
  with more powerful guis like phpmyadmin or other db engine
  specific tools.

The feature is dropped without substitution.

The v8 backport of this patch will just remove the button from
the em list view, but keep all code.

Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070
Resolves: #82148
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove devlog constants 12/53212/7
Benni Mack [Wed, 14 Jun 2017 16:30:36 +0000 (18:30 +0200)]
[!!!][TASK] Remove devlog constants

Drop three error related constants from bootstrap:
TYPO3_DLOG, TYPO3_ERROR_DLOG, TYPO3_EXCEPTION_DLOG

Removal of these constants has been prepared in v8
and can be done now. This unblocks further logging
related works.

Along the way, the two TYPO3_CONF_VARS "enable_errorDLOG"
and "enable_exceptionDLOG" can be dropped.

The extension scanner can find usages of these constants,
making the patch not less breaking, but usage detection
within extensions is safe and thus helps a lot to spot them.

A new matcher is added to the extension scanner to
scan for usages of global constants.

Resolves: #82162
Releases: master
Change-Id: I6310866738e5cda79a807239846f64996ec76974
Reviewed-on: https://review.typo3.org/53212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] travis-ci: Execute unit test only 80/53780/2
Christian Kuhn [Tue, 22 Aug 2017 18:11:00 +0000 (20:11 +0200)]
[TASK] travis-ci: Execute unit test only

travis-ci still chockes on executing the functional tests
which take ages, even with various tricks in place.
The patch reduces the travis execution to unit tests
only since all main tests are executed via our bamboo
environment anyway beforehand.

Change-Id: I809f38d79f0ac7848e6b7e155d35aab575f4d81a
Resolves: #82172
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53780
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl 43/53643/3
Jan Helke [Fri, 4 Aug 2017 10:04:38 +0000 (12:04 +0200)]
[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl

This file is only used by typo3/testing-framework and has
been moved to that repository since version 1.1.1.

Releases: master, 8.7
Resolves: #81900
Change-Id: I5f88bd89c4cadd2fe65f4d0bc9f4494e172f4d2a
Reviewed-on: https://review.typo3.org/53643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] travis-ci: Less parallel jobs 75/53775/2
Christian Kuhn [Tue, 22 Aug 2017 16:54:52 +0000 (18:54 +0200)]
[TASK] travis-ci: Less parallel jobs

travis-ci still chockes on functional tests, even if
splitting them among lots of single tasks. Run less
tests in parallel and split to ever more jobs to have
a higher chance for 10 minute output with given cpu
constraints.

Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7
Resolves: #82170
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.1.1 73/53773/3
Christian Kuhn [Tue, 22 Aug 2017 16:30:27 +0000 (18:30 +0200)]
[TASK] Update typo3/testing-framework to 1.1.1

Fix three issues blocking core patches.

Change-Id: I07deff6294061d04e15bd1a7707e504413bb30c9
Resolves: #82168
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update dev dependencies 69/53769/4
Wouter Wolters [Tue, 22 Aug 2017 14:26:33 +0000 (16:26 +0200)]
[TASK] Update dev dependencies

* codeception/codeception (2.3.3 => 2.3.5)
* enm1989/chromedriver (2.30 => 2.31)
* friendsofphp/php-cs-fixer (v2.0.0 => v2.4.1)

Resolves: #82164
Releases: master, 8.7
Change-Id: I2543b99a7e4751c09ebd733335cc3eddc025d189
Reviewed-on: https://review.typo3.org/53769
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] bamboo nightly 71/53771/2
Christian Kuhn [Tue, 22 Aug 2017 15:09:12 +0000 (17:09 +0200)]
[BUGFIX] bamboo nightly

The bamboo nightly job [1] fails due to a minor CGL issue
which somehow slipped through.

[1] https://bamboo.typo3.com/browse/CORE-GTN

Change-Id: I9e0af185e757192846185c0b7e601ff33e05e491
Resolves: #82165
Releases: master
Reviewed-on: https://review.typo3.org/53771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool: Double <hr> in upgrade wizards 68/53768/2
Christian Kuhn [Tue, 22 Aug 2017 10:39:30 +0000 (12:39 +0200)]
[BUGFIX] Install tool: Double <hr> in upgrade wizards

Remove <hr> of last wizard.

Change-Id: I25a52d882e99333d4598e1dcc632300e2a8860ac
Resolves: #82158
Releases: master
Reviewed-on: https://review.typo3.org/53768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Make Notifications module usable in install tool 60/53760/3
Frank Naegler [Mon, 21 Aug 2017 19:14:19 +0000 (21:14 +0200)]
[BUGFIX] Make Notifications module usable in install tool

This patch makes the Notification module in standalone install tool
usable by adding the required CSS and fixing the dependency
to the global TYPO3 object, which only exist in backend context.

Resolves: #82138
Releases: master
Change-Id: I954324e9d19569eedb1eb5e0ecfaf821fcecb070
Reviewed-on: https://review.typo3.org/53760
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not renumber unique keys in ArrayUtility 67/53767/3
Susanne Moog [Tue, 22 Aug 2017 10:10:50 +0000 (12:10 +0200)]
[BUGFIX] Do not renumber unique keys in ArrayUtility

In various places throughout the core we are using timestamps followed
by a dot as unique identifiers for array keys (for example the avatar
service is registered that way). The ArrayUtility renumbering function
renumbers these keys on writing configuration, meaning that you cannot
overwrite services registered like that via the configuration manager.

ArrayUtility should not re-order strings containing a number ending with
a single dot.

Change-Id: I7dc1625cfdbab6704df87a8cc06f331d92992d24
Releases: master
Resolves: #82155
Reviewed-on: https://review.typo3.org/53767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Refactoring of CardLayout.js 62/53762/3
Frank Naegler [Mon, 21 Aug 2017 20:35:34 +0000 (22:35 +0200)]
[BUGFIX] Refactoring of CardLayout.js

This patch refactors the CardLayput.js to prevent some trouble with
the navigation icons in the doc header.

Resolves: #82151
Releases: master
Change-Id: I6739de816b458a7b8c85c519d46664831dfa070c
Reviewed-on: https://review.typo3.org/53762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Fix broken table layout of Upgrade Wizards table 66/53766/2
Christian Kuhn [Tue, 22 Aug 2017 10:00:05 +0000 (12:00 +0200)]
[FOLLOWUP][BUGFIX] Fix broken table layout of Upgrade Wizards table

Change an invalid class name.

Change-Id: I146cbb27dae6e9b1044ef8e296989d7a6dba7056
Resolves: #82150
Releases: master
Reviewed-on: https://review.typo3.org/53766
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix broken table layout of Upgrade Wizards table 61/53761/2
Frank Naegler [Mon, 21 Aug 2017 19:36:14 +0000 (21:36 +0200)]
[BUGFIX] Fix broken table layout of Upgrade Wizards table

Resolves: #82150
Releases: master
Change-Id: I962a41df0f0375bbf1b325f29d270d8fe2da0e5f
Reviewed-on: https://review.typo3.org/53761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove leftover reference to ext:func from Gruntfile 65/53765/4
Christian Kuhn [Tue, 22 Aug 2017 08:55:36 +0000 (10:55 +0200)]
[BUGFIX] Remove leftover reference to ext:func from Gruntfile

The ext:func module menu image building is still
referenced in the Gruntfile.

Change-Id: Iaafed19faa9d99eca2ebce41ea622ef85728eabc
Resolves: #82154
Releases: master
Reviewed-on: https://review.typo3.org/53765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install tool: Improve 'clear tables' view 43/53743/4
Christian Kuhn [Sun, 20 Aug 2017 11:24:05 +0000 (13:24 +0200)]
[TASK] Install tool: Improve 'clear tables' view

Refactor the 'clear tables' view of the install tool:
* Main content is loaded on opening the card via ajax
* Tables with 0 rows are no longer shown
* Refresh view after 'clear this table' ajax action has been clicked

Change-Id: I8608e6561eaf9d0ae06da8e27b25c5ce879a5b62
Resolves: #82136
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53743
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove non existing param from checkForUpdate 50/53750/4
Frans Saris [Mon, 21 Aug 2017 09:49:05 +0000 (11:49 +0200)]
[TASK] Remove non existing param from checkForUpdate

Releases: master, 8,7
Resolves: #82144
Change-Id: I24b2d57e37f6ff95b7ec7bdab7cda0f21e85c90b
Reviewed-on: https://review.typo3.org/53750
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Functional tests for translated tt_content rendering in Extbase 26/53426/9
Tymoteusz Motylewski [Sat, 19 Aug 2017 17:16:49 +0000 (19:16 +0200)]
[TASK] Functional tests for translated tt_content rendering in Extbase

Introduce and Extbase version of the LocalizedContentRenderingTest.
It tests how language related TS settings influences content rendering.

Also changes exception code in ContentController, to make bamboo happy.

This test suite is documenting current behaviour, which is in fact
inconsistent with TypoScript tt_content rendering.

The next step is to provide a fix for extbase with a feature switch,
so this test suite will become a version with feature swich being disabled.

Resolves: #81823
Releases: master, 8.7, 7.6
Change-Id: Ia616e5089b0209cfb895216726f7192f39c88a45
Reviewed-on: https://review.typo3.org/53426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] travis-ci: Split functional tests into more parts 52/53752/2
Christian Kuhn [Mon, 21 Aug 2017 11:43:47 +0000 (13:43 +0200)]
[TASK] travis-ci: Split functional tests into more parts

With the ever growing number of functional tests, we
split the suite into more parts to prevent
"No output has been received in the last 10 mins".

Change-Id: I55665c723f91f77347b376992f7a7a28da67b0fd
Resolves: #82145
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53752
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool: Trigger ext scan on ext open 44/53744/2
Christian Kuhn [Sun, 20 Aug 2017 11:49:29 +0000 (13:49 +0200)]
[BUGFIX] Install tool: Trigger ext scan on ext open

In the extension scanner, if opening a single extension view
for the first time, the scanner is correctly triggered again.

Change-Id: I72d18a17d735d67109135205684f25c75dc77711
Resolves: #82140
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53744
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Install tool: Empty messages in TCA migration 42/53742/3
Christian Kuhn [Sun, 20 Aug 2017 08:43:10 +0000 (10:43 +0200)]
[BUGFIX] Install tool: Empty messages in TCA migration

The JsonView should return the detail message text as
'message' array and not as 'status'.

Change-Id: I492d31ee8fe3895c97e0229369c5f3ca09f7b713
Resolves: #82137
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool: Configure settings toggle all button 45/53745/2
Christian Kuhn [Sun, 20 Aug 2017 12:08:13 +0000 (14:08 +0200)]
[BUGFIX] Install tool: Configure settings toggle all button

Fix a JS selector to correctly toggle on "Toggle All" again.

Change-Id: Ie21c8c41fb9ba1aba4eedb197603a8c2a7111477
Resolves: #82141
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record 10/53710/4
Wouter Wolters [Tue, 15 Aug 2017 18:05:14 +0000 (20:05 +0200)]
[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record

The type field contains a non existing field. Do not select this
field in the query.

Resolves: #82105
Releases: master, 8.7, 7.6
Change-Id: I9840712f4f87135740512ddf91a2b921b2515612
Reviewed-on: https://review.typo3.org/53710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>