Packages/TYPO3.CMS.git
4 months ago[BUGFIX] Only process arrays in BackendUserConfigurationUpdate 68/62368/2
Daniel Goerz [Fri, 22 Nov 2019 09:28:10 +0000 (10:28 +0100)]
[BUGFIX] Only process arrays in BackendUserConfigurationUpdate

A check is added to assure the unserialized content of
a be_users uc field is actually an array before passing it to
array_walk_recursive(). This is needed because the uc field
can also contain null.

Resolves: #89638
Related: #89268
Releases: master, 9.5
Change-Id: I9a3d56525b9434522e719d88300240abe9c9c5be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62368
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Cast id to integer in class BackendUserConfigurationUpdate 50/62350/2
Christian Eßl [Thu, 21 Nov 2019 07:52:41 +0000 (08:52 +0100)]
[BUGFIX] Cast id to integer in class BackendUserConfigurationUpdate

The newly introduced BackendUserConfigurationUpdate tries to pass a
string value id to the updateBackendUser() function, which requires an
integer. This commit solves that problem

Resolves: #89683
Releases: master, 9.5
Change-Id: Ieca98c01ec44b7e3a4275d645fa6d25ea09d63a2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62350
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Omit hostname in site auto-generation called via CLI 70/62370/2
Oliver Hader [Fri, 22 Nov 2019 10:29:35 +0000 (11:29 +0100)]
[BUGFIX] Omit hostname in site auto-generation called via CLI

Invoking DataHandler in CLI (e.g. when importing data-sets) fails
due to flaws in CreateSiteConfiguration which uses $_SERVER as
fallback even when it does not contain any web-related information.

Thus, hostname and schema prefix is omitted when being called in
CLI context.

Releases: master
Resolves: #89739
Change-Id: Ic8d3e5d4dd81067f2be3fa1d092c180885ba1783
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62370
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant 67/62367/2
Benni Mack [Fri, 22 Nov 2019 09:09:46 +0000 (10:09 +0100)]
[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant

This resolves the most common issues related to
PHP 7.4 PHP changes:
- implode() argument order
- using "{}" instead of "[]" in PHP array keys
- PHP notices for invalid array key access

Resolves: #89737
Releases: master, 9.5, 8.7
Change-Id: Iff0b8a46279d328f66ae6bab927aef2bca881774
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62367
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Migrate EXT:form slots to PSR-14 listeners 64/62364/3
Benni Mack [Thu, 21 Nov 2019 21:51:25 +0000 (22:51 +0100)]
[TASK] Migrate EXT:form slots to PSR-14 listeners

EXT:form consumes migrated Signals in FAL, which
should be migrated in order to avoid deprecations.

All FAL logic and persistence functionality
continues to work as is.

Resolves: #89734
Releases: master
Change-Id: Ife4785ba73159bf49b7ed76a6705ce5bb2361fac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62364
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
4 months ago[BUGFIX] Ensure hoa/core is not a dependency 65/62365/3
Benni Mack [Fri, 22 Nov 2019 08:43:14 +0000 (09:43 +0100)]
[BUGFIX] Ensure hoa/core is not a dependency

When running composer update --prefer-lowest
the abandoned package hoa/core could still
be installed via codeception/codeception,
which in turn results in issues running
our test suite.

See https://github.com/hoaproject/Protocol/issues/8

This is also needed for PHP 7.4 compatibility.

Resolves: #89736
Releases: master
Change-Id: I51d2e73875650222bcf9c829cfc684cefd59b612
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62365
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Document variables assigned to mail templates 63/62363/2
Mathias Brodala [Thu, 21 Nov 2019 19:43:16 +0000 (20:43 +0100)]
[TASK] Document variables assigned to mail templates

Resolves: #89730
Releases: master, 9.5
Change-Id: I1754168d86cd9d69d866accee9fc042f8e967490
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62363
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make FileUpload and ImageUpload mimetype validation more strict 17/60617/6
Ralf Zimmermann [Sun, 28 Apr 2019 21:00:07 +0000 (23:00 +0200)]
[BUGFIX] Make FileUpload and ImageUpload mimetype validation more strict

Only use the "allowedMimeTypes" property values from the form definition
for the mime type validation of an uploaded file.

Resolves: #88238
Releases: master
Change-Id: Ic4cfdfc7d6b435e7936e3c312affb775093d856a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Fix PHP error in SoftReferenceParserHook for missing form definitions 14/62314/3
Stephan Großberndt [Wed, 13 Nov 2019 09:50:28 +0000 (10:50 +0100)]
[BUGFIX] Fix PHP error in SoftReferenceParserHook for missing form definitions

This patch adds a safe guard to make sure the `$file` object is not null
on trying to update the soft reference. This is necessary as
`ResourceFactory->retrieveFileOrFolderObject()` returns null instead of
throwing an exception in several cases (e.g. missing form definition
located in an extension).

Resolves: #89665
Releases: master, 9.5
Change-Id: I09537ddb5a4e9083992ce0fb321f4d81cd279ccf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62314
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
4 months ago[FEATURE] Unified PageTS resolving and parsing 49/62349/6
Benni Mack [Wed, 20 Nov 2019 23:29:44 +0000 (00:29 +0100)]
[FEATURE] Unified PageTS resolving and parsing

This change introduces two new API classes relevant for PageTSconfig:

- PageTsConfigLoader
- PageTsConfigParser

The loader class collects all PageTS found in a rootline, which was
previously available in two places - BackendUtility and TSFE, although
they were similar, they were not the same and error-prone in the past.

The previous "TsConfigParser" class had an unusal dependency to
the BackendConditionMatcher only, which did not even allow to send in
custom arguments.

The TSFE part is now also evaluating TSconfig conditions properly,
which was not the case in the past. This part is also now cached properly.

The TSconfig inclusion ("include from the list of TSconfig inclusions")
functionality is now built into the Info module.

In addition, the hard-coded "ConditionMatcher" is now seamlessly
injected into the parsing process, allowing
- Decoupling of Logic and Implementation of parsing in different contexts
- Making the ConditionMatcher extensible by having a new ConditionMatcherInterface

In the next steps:
- the UserTsConfig parsing can be applied separately and split from BE_USER
- ConditionMatcher Interface can be used properly
- TypoScriptParser can be split up
- BackendUtility can be cleaned up further.

The following functionality is deprecated:
- TYPO3\CMS\Core\Configuration\TsConfigParser
- TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig()

Resolves: #89718
Releases: master
Change-Id: Ibd0a2d086d7e5166f16213fa4aadffd41ecb645c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62349
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Raise testing framework to version 5.0.16 59/62359/7
Benni Mack [Thu, 21 Nov 2019 13:06:00 +0000 (14:06 +0100)]
[TASK] Raise testing framework to version 5.0.16

The next version has PHP 7.4 support and was
cleaned up a lot.

Used composer command:
    composer req typo3/testing-framework:~5.0.16 \
        --update-with-all-dependencies --dev

Resolves: #89725
Releases: master
Change-Id: Iba181feb693c9ee61b8792cd0d0197c1e3b1f59a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62359
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Deprecate TSFE->divSection 47/62347/3
Benni Mack [Wed, 20 Nov 2019 18:30:43 +0000 (19:30 +0100)]
[TASK] Deprecate TSFE->divSection

DivSection was used to create GMENU_LAYERS functionality,
injecting global inline JavaScript right after the rendered pages'
<body> tag.

GMENU_LAYERS was removed with TYPO3 v8, however the property
was still replaced every single time in the TYPO3 Frontend when
a USER_INT was on the page. This is not needed anymore, marking
the property as unused. That's why it is deprecated.

Resolves: #89722
Releases: master
Change-Id: Ia8e3910e20bc28831ba3bdce143812f8acb9d139
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62347
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Document unsetting array property items in form variants 64/61764/7
Christian Eßl [Fri, 20 Sep 2019 07:41:52 +0000 (09:41 +0200)]
[BUGFIX] Document unsetting array property items in form variants

It is actually possible to unset array property items like select
options through the magic "__UNSET" feature of the core ArrayUtility.
This should be documented as such.

Resolves: #89204
Releases: master, 9.5
Change-Id: I26e5ceea8b526cc4624e0004f3344d7e42b49a71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61764
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Update symfony dependencies to 4.4 or 5.0 54/62354/10
Benni Mack [Thu, 21 Nov 2019 09:57:46 +0000 (10:57 +0100)]
[TASK] Update symfony dependencies to 4.4 or 5.0

TYPO3 Core v10 should rely on Symfony 4.4 (LTS release)
and add support for 5.0 automatically.

Symfony 4.4 made breaking changes to the Mailer and Mime components
which now need adaptions.

Used composer command:

composer req "symfony/config":"^4.4 || ^5.0" \
"symfony/console":"^4.4 || ^5.0" \
"symfony/dependency-injection":"^4.4 || ^5.0" \
"symfony/expression-language":"^4.4 || ^5.0" \
"symfony/finder":"^4.4 || ^5.0" \
"symfony/mailer":"^4.4 || ^5.0" \
"symfony/mime":"^4.4 || ^5.0" \
"symfony/property-access":"^4.4 || ^5.0" \
"symfony/property-info":"^4.4 || ^5.0" \
"symfony/routing":"^4.4 || ^5.0" \
"symfony/yaml":"^4.4 || ^5.0" --update-with-all-dependencies

Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 27 updates, 0 removals
  - Updating symfony/polyfill-ctype (v1.11.0 => v1.12.0)
  - Updating symfony/filesystem (v4.3.1 => v4.4.0)
  - Updating symfony/config (v4.3.2 => v4.4.0)
  - Updating symfony/service-contracts (v1.1.2 => v1.1.8)
  - Updating symfony/polyfill-php73 (v1.11.0 => v1.12.0)
  - Updating symfony/polyfill-mbstring (v1.11.0 => v1.12.0)
  - Updating symfony/console (v4.3.1 => v4.4.0)
  - Updating symfony/dependency-injection (v4.3.2 => v4.4.0)
  - Updating symfony/var-exporter (v4.3.1 => v4.4.0)
  - Updating symfony/cache-contracts (v1.1.1 => v1.1.7)
  - Updating psr/log (1.0.2 => 1.1.2)
  - Updating symfony/cache (v4.3.1 => v4.4.0)
  - Updating symfony/expression-language (v4.3.1 => v4.4.0)
  - Updating symfony/finder (v4.3.3 => v4.4.0)
  - Updating symfony/polyfill-php72 (v1.11.0 => v1.12.0)
  - Updating symfony/polyfill-intl-idn (v1.11.0 => v1.12.0)
  - Updating symfony/mime (v4.3.2 => v4.4.0)
  - Updating symfony/event-dispatcher-contracts (v1.1.1 => v1.1.7)
  - Updating symfony/event-dispatcher (v4.3.1 => v4.4.0)
  - Updating doctrine/lexer (v1.0.1 => 1.2.0)
  - Updating egulias/email-validator (2.1.9 => 2.1.11)
  - Updating symfony/mailer (v4.3.2 => v4.4.0)
  - Updating symfony/inflector (v4.3.1 => v4.4.0)
  - Updating symfony/property-access (v4.3.1 => v4.4.0)
  - Updating symfony/property-info (v4.3.1 => v4.4.0)
  - Updating symfony/routing (v4.3.1 => v4.4.0)
  - Updating symfony/yaml (v4.3.1 => v4.4.0)

Resolves: #89721
Releases: master
Change-Id: I834a79e3880b3a7a95429c2fe052657e21599ec7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62354
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use array as service chains instead of comma-separated list 43/62043/4
Benni Mack [Tue, 22 Oct 2019 10:59:55 +0000 (12:59 +0200)]
[TASK] Use array as service chains instead of comma-separated list

The serviceChain (services that have been requested before)
are currently added as comma-separated list (string), however,
every time when GeneralUtility::makeInstanceService() is called,
the serviceChain parameter is trimExplode'd to an array, which
leads to unnecessary CPU time when multiple services are queried.

The compat behaviour of handing in a string is now deprecated,
and in TYPO3 v11 only arrays are accepted.

Resolves: #89579
Releases: master
Change-Id: Id2424907b0d6c62fc1f249bcdd23f13d45de9893
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62043
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Remove assignment to unused property in PageRenderer 57/62357/2
Benni Mack [Thu, 21 Nov 2019 11:30:40 +0000 (12:30 +0100)]
[BUGFIX] Remove assignment to unused property in PageRenderer

The property "PageRenderer->metaTagsByAPI" has been removed
with the introduction of the MetaTag API. The left-over assignment
should be removed.

Resolves: #89724
Releases: master, 9.5
Change-Id: I9f6ad9c0eea538c83ee2252590c1632719fbd89d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62357
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[DOCS] Rename Changelog compared to subject 51/62351/2
Joerg Kummer [Thu, 21 Nov 2019 08:16:49 +0000 (09:16 +0100)]
[DOCS] Rename Changelog compared to subject

Change filename of changelog for issue 88902
fixes ordering in rendered documentation menus.

Releases: master
Resolves: #89719
Change-Id: I2e9e6045610d601e904f7f5b46ff6a2f2d27774f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62351
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[DOCS] Fix some minor typos in Changelog 48/62348/3
Björn Jacob [Wed, 20 Nov 2019 19:59:20 +0000 (19:59 +0000)]
[DOCS] Fix some minor typos in Changelog

Releases: master, 9.5
Resolves: #89717
Change-Id: I63dd1bcb540c611618d662c01e9d271f013e07e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62348
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Synchronize TCA enable columns from workspace version 20/62020/8
Oliver Hader [Fri, 8 Nov 2019 17:09:24 +0000 (18:09 +0100)]
[BUGFIX] Synchronize TCA enable columns from workspace version

In case workspace placeholders (new or move) are involved corresponding
explicit TCA control settings in either shadowColumnsForMovePlaceholders
or shadowColumnsForNewPlaceholders are used to update those field values
and synchronize workspace versions with their placeholder records.

Since the data-retrieval process first queries live version pendants and
then tries to overlay those records with version information, values for
enable columns shall be synchronized automatically - otherwise possible
HiddenRestriction or StartTimeRestriction would deny selecting live
versions already in the first place.

Resolves: #89455
Releases: master, 9.5
Change-Id: Ic5763866d5adf4dcb30db3f553edf19eb0c76239
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62020
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Do not add entries to cache_treelist when logged into BE 72/62172/2
Benni Mack [Thu, 31 Oct 2019 15:51:27 +0000 (16:51 +0100)]
[BUGFIX] Do not add entries to cache_treelist when logged into BE

When accessing cache_treelist / cObj->getTreeList()
this information should not be cached at all when logged
into the backend at the same time. This would then result
in wrong lists of IDs.

As treelist is conceptually wrong on a various number of levels,
a short workaround is added so the cache is never written
when accessing the Frontend and having a valid $GLOBALS['BE_USER']
object.

Resolves: #87540
Releases: master, 9.5
Change-Id: I1a2f0da3fffd7790dcf1988c76f6fc68899241d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62172
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Do not use constants in low-level classes 45/62345/6
Benni Mack [Tue, 19 Nov 2019 15:43:44 +0000 (16:43 +0100)]
[TASK] Do not use constants in low-level classes

There are certain PHP classes used in the testing framework that
use constants like "LF" which are defined by the SystemEnvironmentBuilder.

The testing framework depends on these classes, but should not
depend on global constants like "LF". The patch changes the lines to "\n"
allowing to continue slimming down testing framework.

Resolves: #89712
Releases: master, 9.5
Change-Id: Ieace867d13ab320a3273e1119a3a2ecc9268103b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62345
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Remove unused log-related TYPO3_CONF_VARS 96/62296/9
Benni Mack [Mon, 11 Nov 2019 14:51:12 +0000 (15:51 +0100)]
[TASK] Remove unused log-related TYPO3_CONF_VARS

The options

- systemLog
- systemLogLevel

have been marked as unused with TYPO3 v9.0,
and should be removed from any upgrade installation via
the SilentConfigurationUpgrade system.

Resolves: #89645
Releases: master
Change-Id: I432fbd1fb2938e0c35935d1db8fb7974b19027e5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62296
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Avoid processing empty entity ids in DataMapProcessor 43/62343/3
Oliver Hader [Tue, 19 Nov 2019 10:41:09 +0000 (11:41 +0100)]
[TASK] Avoid processing empty entity ids in DataMapProcessor

Avoid executing (more expensive) queries in DataMapProcessor in case
there are actually no entity ids to be retrieved from database.

Resolves: #89710
Releases: master
Change-Id: Id03d6c17d13e5969b707ad4e6c9b61f3fd9b4a07
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62343
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update nikic/php-parser to ^4.3 39/62339/5
Alexander Schnitzler [Mon, 18 Nov 2019 13:17:21 +0000 (14:17 +0100)]
[TASK] Update nikic/php-parser to ^4.3

    composer require nikic/php-parser:"^4.3"

Bump version as PHP 5 support is not necessary for TYPO3
version 10 and modern packages like rector/rector need
a newer version of nikic/php-parser to work.

Releases: master
Resolves: #89704
Change-Id: I402714959750b5203a6e0117e5ef84b62229441b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62339
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Prevent superfluous filters in DataMapProcessor 48/58048/7
Nicole Cordes [Mon, 27 Aug 2018 14:04:20 +0000 (16:04 +0200)]
[TASK] Prevent superfluous filters in DataMapProcessor

For consistency in the filterNumericIds method of DataMapProcessor,
there should only be one result be returned. This patch removes the
second parameter to invert the methods behaviour.

Resolves: #86138
Releases: master
Change-Id: I89bd4949e75818a26dd23c0884ccc0cf41401804
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Start nighly test run at 3am rather than 0:03am 37/62337/3
Anja Leichsenring [Mon, 18 Nov 2019 08:02:51 +0000 (09:02 +0100)]
[BUGFIX] Start nighly test run at 3am rather than 0:03am

The test runs need to finish one after another, the master
currently overlaps with the 9.5, causing unneccessary load
on the build machines.

Resolves: #89699
Related: #89661
Releases: master
Change-Id: I20ae5cf6b756541cdc163e5e45f4e2db3962eeab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62337
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Ensures configuration for resolveAnchorLink is an array 36/62336/2
Susanne Moog [Sun, 17 Nov 2019 16:33:45 +0000 (17:33 +0100)]
[BUGFIX] Ensures configuration for resolveAnchorLink is an array

Strict typing requires $conf to be an array as parameter for
resolveAnchorLink, however it may also be null. The fix ensures that
on calling resolveAnchorLink a null coalescing operator ensures type
array.

Resolves: #89698
Related: #87992
Releases: master, 9.5
Change-Id: Ie459a312845d45bc15a16ff02089b1acf67eb00a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62336
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Respect config.intTarget and extTarget in default ParseFunc 84/62184/3
Benni Mack [Mon, 4 Nov 2019 20:38:49 +0000 (21:38 +0100)]
[BUGFIX] Respect config.intTarget and extTarget in default ParseFunc

Fluid Styled Content's "lib.parseFunc" always sets the extTarget (target for
external URLs) to the constant, but never considers config.extTarget anymore.

Same goes for the internal target, where target is never set, as
the target parameter is already filled.

The patch adds some minor inline information as well as
the proper values.

In the future, it would make sense to use the same target values
for config.*target (which is for ALL links and not just the ones in parseFunc)
which should be populated by the constants, and not have the constants
interfer into lib.parseFunc anymore.

Resolves: #88325
Releases: master, 9.5
Change-Id: Ibfa6578900f167ea465476865c67064878e31bac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62184
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Add Maori locale and flag 33/62333/6
Simon Gilli [Sat, 16 Nov 2019 11:44:57 +0000 (12:44 +0100)]
[TASK] Add Maori locale and flag

This patch adds the locale Maori and it's flag for New Zealand.

Resolves: #89693
Releases: master, 9.5
Change-Id: I79ca0f1926c8d9d16f1c63480e80baf157938073
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62333
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Re-activate acceptance tests for introduction package 52/61852/9
Anja Leichsenring [Thu, 14 Nov 2019 16:30:20 +0000 (17:30 +0100)]
[TASK] Re-activate acceptance tests for introduction package

Now that EXT:introduction is released with site support (v4.2.0),
the tests can be re-enabled again.

Resolves: #89320
Releases: master
Change-Id: Ief9c1b8d681ca6ee9b707a92348b050adecaa6c2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61852
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add examples to ext:backend ViewHelpers 66/62266/2
Oliver Bartsch [Sat, 9 Nov 2019 20:21:47 +0000 (21:21 +0100)]
[TASK] Add examples to ext:backend ViewHelpers

Following ViewHelpers now also feature proper examples:
* AvatarViewHelper
* ThumbnailViewHelper

As the ViewHelpers are not declared as `@internal` custom extension
can use them for e.g. backend modules. Therefore they now contain
examples about the usage.

Resolves: #89629
Releases: master, 9.5
Change-Id: Iff9a4f6e5a0cc02799f093af0a5abf91eff9fcf3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62266
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[FEATURE] Add additional configuration for external URLs 01/61801/10
Sybille Peters [Tue, 24 Sep 2019 17:49:44 +0000 (19:49 +0200)]
[FEATURE] Add additional configuration for external URLs

Additional configuration is added to customize settings for checking
external URLs.

Resolves: #86918
Related: #89287
Releases: master
Change-Id: I1ebfb31fe7760ad5b7c99db3999794c1e363cd17
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61801
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Chris Müller <typo3@krue.ml>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Replace FAL signals with new PSR-14 events 15/61715/19
Benni Mack [Wed, 13 Feb 2019 07:10:09 +0000 (08:10 +0100)]
[FEATURE] Replace FAL signals with new PSR-14 events

All FAL-related signals are migrated to PSR-14 compatible Events.

Existing signals are moved to a compatibility class, so they are still
executed without throwing a deprecation.

This change allows to further decouple EXT:core from other system
extensions (in this case Extbase).

Resolves: #89577
Releases: master
Change-Id: I062c7261de9a0e21140346c1934e9c735fd5b307
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61715
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Prevent PHP type error and stale language cache 08/62308/4
Claus Due [Tue, 12 Nov 2019 16:50:08 +0000 (17:50 +0100)]
[BUGFIX] Prevent PHP type error and stale language cache

In EXT:workspaces, as consequence of changes in #89008,
PHP is raising an error if $pageId cannot be resolved to an
integer value as required by method signature.

Additionally, an internally cached array is built based on a
dynamic value but the internal cache is not keyed by this
value or flushed when the value changes.

This patch:

* Casts an unresolved page ID to integer zero.
* Removes the internal cache of languages since the array
  now depends entirely on a unique input value, $pageId.

Resolves: #89692
Related: #89008
Releases: master
Change-Id: I3d74b4c7575375aae23a7e2473100104c4700966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62308
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[DOCS] Remove confusing "cron command" ambiguity. 71/62271/5
Andrew Murphy [Sun, 10 Nov 2019 22:43:02 +0000 (22:43 +0000)]
[DOCS] Remove confusing "cron command" ambiguity.

Remove the ambiguity of “cron command” that causes confusion for a
first time reader, as happened in https://forge.typo3.org/issues/75802.
Saying “cron command” implies the entire instruction, including the
shell command portion. Instead, we want only the patterns of the first
five fields of a crontab entry input file line, described in “The Open
Group Base Specifications Issue 7, 2018 edition” at
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html.
There is no definitive name for these five fields as a group: “cron
schedule expression” or “crontab schedule expression” are
descriptive.

Releases: master
Resolves: #89632
Change-Id: I52c20b6a4b2fdb626687a5429d0a79503f92e1b8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62271
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
4 months ago[DOCS] Add missing semicolon in rst file 22/62322/5
Franz Holzinger [Wed, 13 Nov 2019 21:56:11 +0000 (21:56 +0000)]
[DOCS] Add missing semicolon in rst file

Releases: master, 9.5
Resolves: #89676
Change-Id: Id215d40c18b28cf9b36a32b33c9a5e88d7840f5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62322
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
4 months ago[TASK] Update dependency CmsComposerInstaller 26/62326/3
Benni Mack [Thu, 14 Nov 2019 12:05:04 +0000 (13:05 +0100)]
[TASK] Update dependency CmsComposerInstaller

This package should be raised to 2.2.3 as
this provides PHP 7.4 compatible tests.

This means, that this package is now shipped
with TYPO3 Core for all tarballs/zip distributions.

Composer-based installations will receive
the update automatically when doing a full
composer update.

Resolves: #89681
Releases: master, 9.5
Change-Id: I06991249984c21e02d287e1536a358760d629a9d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62326
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Rename USER_INT related variables in TSFE 09/62309/3
Benni Mack [Wed, 13 Nov 2019 07:52:06 +0000 (08:52 +0100)]
[TASK] Rename USER_INT related variables in TSFE

The cryptic variables $INTiS_config and internal names are improved
by using "nonCacheable" as naming (everywhere where possible,
not modifying public API methods).

Resolves: #89660
Releases: master
Change-Id: Ia03b1d612f1787f3d927a3724d20cb06caeddc38
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62309
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Johannes Schlier
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix minor typos in form documentation 19/62319/4
Chris Müller [Wed, 13 Nov 2019 18:38:37 +0000 (19:38 +0100)]
[DOCS] Fix minor typos in form documentation

Some typos are fixed. Additionally the spelling of "customise" was
adjusted to en-us.

Resolves: #89674
Releases: master, 9.5
Change-Id: I982c8438405677b6435e38cad5f7dbb6a6e886f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62319
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Use correct ViewHelper namespace in PHPDoc of SubmitViewHelper 15/62315/3
Tomas Norre Mikkelsen [Wed, 13 Nov 2019 10:14:31 +0000 (11:14 +0100)]
[BUGFIX] Use correct ViewHelper namespace in PHPDoc of SubmitViewHelper

In the PHPDoc's example of SubmitViewHelper a wrong namespace was used.
This adds the correct ViewHelper namespace `f:form.submit`.

Resolves: #89667
Releases: master, 9.5
Change-Id: I7b247ca22527f82eb788119c975d4a46d579a087
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62315
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Re-order Frontend Content building process 13/62313/4
Benni Mack [Wed, 13 Nov 2019 09:08:51 +0000 (10:08 +0100)]
[TASK] Re-order Frontend Content building process

This patch streamlines the execution code when a base page is generated
by moving all logic into a few smaller methods to separate the actual
"cacheable page" logic from the PageRenderer population process,
and also adds more documentation to the methods.

In addition, some minor adjustments (site language is now
always available in v10) can be made, as some unnecessary
code execution (e.g. divSection assigment and unsetting
"JScode" explicitly) are made

Resolves: #89663
Releases: master
Change-Id: Ic2ac15a9767f452a89bace0d95fdc6f7f09af922
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62313
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Trigger nightly test builds with more time in between 10/62310/2
Anja Leichsenring [Wed, 13 Nov 2019 08:22:20 +0000 (09:22 +0100)]
[TASK] Trigger nightly test builds with more time in between

Resolves: #89661
Releases: master, 9.5, 8.7
Change-Id: I0b6bd4336037ede11f4218f5c6868025173e4470
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62310
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Move page layout resolving into a separate class 06/62306/4
Benni Mack [Tue, 12 Nov 2019 15:50:03 +0000 (16:50 +0100)]
[TASK] Move page layout resolving into a separate class

The functionality "getData = pagelayout" resolves the
selected backend layout for the current page, which is
used in TypoScript quite frequently.

In order to use this in e.g. TypoScript conditions, this
functionality is now extracted into a separate class,
and multiple unit tests are added.

Resolves: #89655
Releases: master
Change-Id: I5f2af5ec692c0dd98712c8916a7dc2fed8836a95
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62306
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Add empty alt attribute to decorative images 04/62304/6
Michael Telgkamp [Tue, 12 Nov 2019 13:35:18 +0000 (14:35 +0100)]
[BUGFIX] Add empty alt attribute to decorative images

Decorative images should have an empty alt attribute to hide
them from screenreaders.
See https://www.w3.org/WAI/WCAG21/Techniques/failures/F38

This patch adds the attribute to the images generated by the
icon provider classes using <img> tags.

Resolves: #89653
Releases: master
Change-Id: Ie3186902db3d479b6f2e464fbb578425ced43898
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62304
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Put logic of fetching page content from cache into more readable format 05/62305/4
Benni Mack [Tue, 12 Nov 2019 13:53:56 +0000 (14:53 +0100)]
[TASK] Put logic of fetching page content from cache into more readable format

The process of checking if
a) the page content (or parts of the page incl. instructions for uncached objects)
b) the TypoScript parsing for this set up
is available in cache via locking is now cleaned up a bit by

a) calling TemplateService (pagesection cache) with the required parameter directly (internal)
b) moving the "take cached data and move it into the TSFE properties" into a smaller
method

Resolves: #89654
Releases: master
Change-Id: I65ba3aedab38616194cbefdf7c51524a24a29643
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62305
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use Environment API to fetch application context 47/62247/4
Benni Mack [Fri, 8 Nov 2019 08:39:50 +0000 (09:39 +0100)]
[TASK] Use Environment API to fetch application context

The application context is stored in the Environment class since TYPO3 v9,
which is the correct place instead of GeneralUtility::getApplicationContext().

Resolves: #89631
Releases: master
Change-Id: I55de17ef3b9cbd0962a2c604913c736bd52ac6d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62247
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[DOCS] Fix broken link in fluid_styled_content docs 97/62297/3
Jan [Mon, 11 Nov 2019 14:53:09 +0000 (14:53 +0000)]
[DOCS] Fix broken link in fluid_styled_content docs

Fixed a broken link which points to the "register extension key" page.

Releases: master, 9.5
Resolves: #89642
Change-Id: I5a5408b0690a0d3949cf27136ead1223a12a0304
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62297
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Use consistent checks for USER_INT logic 03/62303/4
Benni Mack [Tue, 12 Nov 2019 13:27:24 +0000 (14:27 +0100)]
[TASK] Use consistent checks for USER_INT logic

A few places in TYPO3 Core do manual checks if there
are non-cacheables on a page, which could be simplified
by just using the $TSFE->isINTincScript() method.

In addition, a safer check for a NON-empty INTincScript
value is used, instead of just a typecheck of array.

Resolves: #89652
Releases: master
Change-Id: I24b2b55b3705927720e36181926cf6e752bf0f66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62303
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Move preparation of non-cacheable headerdata into TSFE 02/62302/4
Benni Mack [Tue, 12 Nov 2019 12:08:57 +0000 (13:08 +0100)]
[TASK] Move preparation of non-cacheable headerdata into TSFE

In order to centralize USER_INT ("non-cacheables") into TSFE logic,
some functionality is moved into TSFE regarding headerData,
JS and CSS inclusions.

Resolves: #89651
Releases: master
Change-Id: Ib0f6daa2306f6cba90f27db6baff5bae38403842
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62302
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8 00/62300/2
Stephan Großberndt [Tue, 12 Nov 2019 08:59:43 +0000 (09:59 +0100)]
[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8

This patch adds a cast to the property `$mask` before handing it over to
`IpAnonymizationUtility::anonymizeIp()` as this method requires `$mask`
to be an `int`. This is necessary as when the task was created and saved
in TYPO3 8 it was serialized as `string`.

Resolves: #89646
Releases: master, 9.5
Change-Id: Ie0745028882991204bfa5c25ec1a4bbb7955b7c2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62300
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix minor typo in changelog 94/62294/2
Sebastian Klein [Mon, 11 Nov 2019 10:29:02 +0000 (10:29 +0000)]
[DOCS] Fix minor typo in changelog

The word 'The' was misspelled.

Additionally, the readability of the last sentence was slightly improved.

Releases: master
Resolves: #89637
Change-Id: I21c76732ef5572b26fc5762b5445ba3612aabaf6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62294
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Listen to message when setting an avatar 92/62292/2
Andreas Fernandez [Mon, 11 Nov 2019 07:52:47 +0000 (08:52 +0100)]
[BUGFIX] Listen to message when setting an avatar

Due to the IRRE rewrite done in #88182 the avatar selection for backend
users broke, since the Setup module doesn't use FormEngine, yet.

The controller now adds dedicated JavaScript to listen to the
`typo3:elementBrowser:elementInserted` message sent by the Element
Browser to set the file reference uid correctly.

Resolves: #89634
Related: #88182
Releases: master
Change-Id: I5e6a56b35891ab380634540e9ed5ef0b3a96f082
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62292
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Remove dots from piVars set by _DEFAULT_PI_VARS 46/58846/12
Georg Ringer [Mon, 5 Nov 2018 17:57:34 +0000 (18:57 +0100)]
[BUGFIX] Remove dots from piVars set by _DEFAULT_PI_VARS

Make it possible to set defaults vars for plugins based on the
AbstractPlugin.

Resolves: #17283
Releases: master
Change-Id: Ic066fcf46f299554289e30eddf4529121c088881
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58846
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Move field "description" to SEO tab in page properties 02/62102/11
Kevin Appelt [Thu, 24 Oct 2019 16:27:41 +0000 (18:27 +0200)]
[TASK] Move field "description" to SEO tab in page properties

The description field is one of the most important fields
for SEO. When EXT:seo is installed, the description field can
be found on the SEO tab of the page properties. If EXT:seo
is not installed, the field will still be on the Metadata tab.

Resolves: #86516
Releases: master
Change-Id: I9d31f74bcc6e7f0f88a39e718b8437e2f92b30e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62102
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Fix CGL in tests (static calls) 68/62268/2
Susanne Moog [Sun, 10 Nov 2019 06:49:40 +0000 (07:49 +0100)]
[TASK] Fix CGL in tests (static calls)

Resolves: #89630
Releases: master
Change-Id: I00021fb1aaf64f2fcc9ee5c8557837c1c90cff4d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62268
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Add fallback identifier to IRRE fields 65/62265/3
Susanne Moog [Sat, 9 Nov 2019 19:50:29 +0000 (20:50 +0100)]
[BUGFIX] Add fallback identifier to IRRE fields

In case of IRRE in site context not the full form engine variables
are available - therefor a fallback has been implemented.

Resolves: #89628
Releases: master, 9.5
Change-Id: I0c499d41354e4dc369f5a53f2109d8559b5e3bcb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62265
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove htmlspecialchars from path_Workspace 23/59023/9
Devid Messner [Tue, 4 Dec 2018 09:20:51 +0000 (10:20 +0100)]
[BUGFIX] Remove htmlspecialchars from path_Workspace

Remove htmlspecialchars in GridDataService
for path_Workspace and path_Live.

Resolves: #87069
Releases: master, 9.5
Change-Id: I1d5eff4b62ea9657efbe3c88c4a61b8e1b7cf1e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59023
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Move clipboard inline JavaScript into separate modules 41/62041/2
Andreas Fernandez [Tue, 22 Oct 2019 08:27:20 +0000 (10:27 +0200)]
[TASK] Move clipboard inline JavaScript into separate modules

This patch moves the inline JavaScript for clipboard handling into a
separate module that is re-used in record list and in file list.

Additionally, the function `editList` only used in record list context
has been moved into the according module.

Resolves: #89476
Releases: master
Change-Id: I43c972aadd8cd097850139813a01c3560a9b202c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62041
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Consistent version restrictions for PSR packages 60/62260/6
Aimeos [Sat, 9 Nov 2019 13:11:53 +0000 (13:11 +0000)]
[TASK] Consistent version restrictions for PSR packages

    composer require "psr/http-message":"^1.0"
    composer require "psr/log":"^1.0"

Releases: master
Resolves: #89626
Change-Id: Ieeceddba8ea49da1eac66f113f1c22623f479582
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62260
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] IRRE: Create a correct original value identifier 95/62195/4
Andreas Fernandez [Tue, 5 Nov 2019 12:43:37 +0000 (13:43 +0100)]
[BUGFIX] IRRE: Create a correct original value identifier

The value of `data-table-unique-original-value` was accidentally of type
array. This causes runtime errors since a string is expected.

This patch now creates a proper value passed to FormEngine to handle the
original unique value.

Resolves: #89588
Related: #87711
Releases: master, 9.5
Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[DOCS] Extend migration example of deprecation 84993 47/61947/3
Jörg Kummer [Thu, 10 Oct 2019 19:27:22 +0000 (19:27 +0000)]
[DOCS] Extend migration example of deprecation 84993

Change a variable name in migration example for
getPagesTSconfig().

Adds further migration example for getPagesTSconfig() when
retrieving a single value.

Releases: master
Resolves: #89394
Change-Id: I0180126cd531335a7775425d1f350587dd5f7be0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61947
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Show link to online docs in extension manager 32/62032/8
Georg Ringer [Fri, 18 Oct 2019 23:51:28 +0000 (19:51 -0400)]
[FEATURE] Show link to online docs in extension manager

The export of extensions provided by https://extensions.typo3.org
has been extended with the link to the documentation.

This link is now shown in the list and detail view of extensions
in the extensions manager.

Resolves: #89458
Releases: master
Change-Id: If1439bd7b97d9c60c2811716edef97a6e4ed870d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62032
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect language restrictions for direct page title editing 37/60837/8
Gianluigi Martino [Wed, 29 May 2019 12:30:57 +0000 (14:30 +0200)]
[BUGFIX] Respect language restrictions for direct page title editing

If the user has no access to edit the title of the page due to language
restrictions, the pencil next to the title in the page module is
no longer visible.

Resolves: #88337
Releases: master, 9.5
Change-Id: Ia41821dd82821ad2c8d5a60dd053a43cadb0c361
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60837
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make GifBuilder calculation of filename hash faster 34/62234/4
Benni Mack [Wed, 6 Nov 2019 22:11:57 +0000 (23:11 +0100)]
[BUGFIX] Make GifBuilder calculation of filename hash faster

The GifBuilder calculation does not need all of setup
to calculate the values for the filename.

Therefore, only the relevant parameters are used, making
the shortMD5 call faster, according to the ticket author.

Resolves: #64158
Releases: master
Change-Id: I9ffd1e1f8a14c8f3904e83f251122225562de606
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62234
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Allow usage of uid in slug generation via Ajax 70/62170/3
Johannes Schlier [Thu, 31 Oct 2019 12:04:37 +0000 (13:04 +0100)]
[BUGFIX] Allow usage of uid in slug generation via Ajax

This commit adds an option to the slug input type which allows it
to use the uid of a record when the update slug button is pressed
in the FormEngine.

Resolves: #89560
Releases: master, 9.5
Change-Id: Id645714f1b26e20e511022d1c74ea793964ffa19
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62170
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[FEATURE] Page title providers visible in admin panel 16/61116/9
Riny van Tiggelen [Fri, 21 Jun 2019 15:23:39 +0000 (17:23 +0200)]
[FEATURE] Page title providers visible in admin panel

The PageTitleProviders are now visible within the adminpanel debug panel.
Since this information is in no way available when the page is cached,
there's a message to view the page in uncached mode.

Resolves: #88609
Releases: master
Change-Id: I15b3187fb219ea488ea88950906545391994bc24
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61116
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Set default controller name in ExtbasePluginEnhancer 59/59659/4
Oliver Hader [Thu, 7 Feb 2019 09:05:15 +0000 (10:05 +0100)]
[BUGFIX] Set default controller name in ExtbasePluginEnhancer

The `defaultController` setting is only applied if both `action` and
`controller` parameters are empty. In Extbase context it happens that
only `action` is defined, but `controller` is empty (since linking to
the very same controller, just changing the action).

The behavior now is the following:
* set `action` and `controller` parameters to default if not given
* set `controller` parameter to default if not given

Resolves: #87337
Releases: master, 9.5
Change-Id: I3ee730f6bc665808c59cc07907467aa98c2de21a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59659
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Log invalid hash generation in FAL Indexer 93/59893/6
Susanne Moog [Thu, 7 Mar 2019 09:37:43 +0000 (10:37 +0100)]
[BUGFIX] Log invalid hash generation in FAL Indexer

The FAL Indexer uses the driver to get a hash for a file. In certain
circumstances (and with 3rd party drivers) the hash generated might be
null or invalid. In that case the ResourceStorage now throws an
exception to alert the developer to the wrong return value. At the same
time the Indexer catches and logs the exception to not interrupt the
whole indexing flow because of it.

For more information, please take a look at the ticket.

Resolves: #66397
Releases: master
Change-Id: I0f97cd23127e96b6d94161a9296750cbe3421075
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59893
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Consider all elements in typo3temp/assets/ when clearing 79/62179/6
Oliver Hader [Sun, 3 Nov 2019 11:15:09 +0000 (12:15 +0100)]
[BUGFIX] Consider all elements in typo3temp/assets/ when clearing

Only first level elements were considered when clearing assets in
typo3temp/assets/ using corresponding functionality in maintenance
section of the TYPO3 install tool.

Resolves: #89569
Releases: master, 9.5
Change-Id: I9237aa3c6200b57cf4da256531b25062f52708ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62179
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Add clarification and tests to SiteBasedRedirectResolver 15/59815/19
Benni Mack [Sat, 9 Nov 2019 13:35:52 +0000 (14:35 +0100)]
[TASK] Add clarification and tests to SiteBasedRedirectResolver

The original issue for endless redirect loops is already fixed via
https://forge.typo3.org/issues/88032
whereas the query does not result in 307's anymore.

Additional information on redirects is added as comment.

Resolves: #87814
Releases: master, 9.5
Change-Id: I8c97b85cc30d217fe793608da1f26be52e8f68dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make EXT:backend independent of EXT:install 99/61999/3
Daniel Siepmann [Tue, 15 Oct 2019 11:22:54 +0000 (13:22 +0200)]
[BUGFIX] Make EXT:backend independent of EXT:install

EXT:backend generates a URL to EXT:install, but has no dependency. This
can lead to composer setups with EXT:backend but without EXT:install,
leading to an exception while generating route.

Therefore a suggest is added as a hint to install also EXT:install.
Existing code is wrapped with an try / catch in order to work under both
circumstances.

Resolves: #89419
Releases: master, 9.5
Change-Id: Idedd299f218ae8f7ba9938800d2ac4a0c4e5614b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Decode tag attributes during HTML parsing 99/61799/9
Helmut Hummel [Tue, 24 Sep 2019 14:09:43 +0000 (16:09 +0200)]
[BUGFIX] Decode tag attributes during HTML parsing

When parsing HTML in parsefunc, we need to make sure
that the attributes that are extracted for further processing
are properly HTML decoded, as per definition they are encoded in
the HTML being parsed.

At the same time we revert a decode that was applied in ExternalUrlLinkBuilder,
as this is the wrong place to handle HTML decoding, as the link builder
is as well called with data from other contexts (TypoScript, data from link fields)
that must not have the URL HTML encoded.

This fix is required to allow email links to add subject and body arguments like:
test@foo.test?subject=foo%20bar&body=baz

and not have the ampersand in the url double encoded when generating links
from RTE content.

Additionally we need to properly encode the masked value for the JavaScript
URI, to prevent browsers from url decoding wrong values.

Releases: master, 9.5
Resolves: #89264
Related: #81625
Related: #80985
Change-Id: I3be2478df83cffc0dfe6af918eb224b4ee480b10
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61799
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Use SiteLanguageAwareInterface to check for trait existence 93/61893/3
Christian Eßl [Sat, 5 Oct 2019 11:55:29 +0000 (13:55 +0200)]
[FEATURE] Use SiteLanguageAwareInterface to check for trait existence

In AspectFactory::enrich(), the function would use class_uses() to
determine, if an aspect uses the trait SiteLanguageAwareTrait. This
however would only work on classes that use this trait, not on classes
that inherit the class with the trait (For example XClasses).
To fix this, a SiteLanguageAwareInterface was introduced, which is
checked against.

Resolves: #87380
Releases: master
Change-Id: I55e90d40ec592dc15564c49f9437e7a2640ffb0d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Provide a way to sort form lists in ext:form 96/61896/5
Christian Eßl [Sun, 6 Oct 2019 09:04:51 +0000 (11:04 +0200)]
[FEATURE] Provide a way to sort form lists in ext:form

Forms in ext:form were previously not sorted in any manner, but just
outputted in the order they were read from the filesystem's directories.

Forms can now be sorted by multiple keys in either ascending or
descending order.
Two new yaml settings were introduced: `sortByKeys` and `sortAscending`.

Resolves: #87798
Releases: master
Change-Id: I2aae2e79cbd39394040a5b1280469a756bf0c7ca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61896
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Deactivate link element's explanation toggle after change 22/61422/9
Michael Straschek [Fri, 2 Aug 2019 22:13:53 +0000 (00:13 +0200)]
[BUGFIX] Deactivate link element's explanation toggle after change

Dynamically fetching/applying additional data for the link explanation
seems to be overdone, so we simply deactivate the toggle button and
remove the icon after selection/modification of the link target.
After persisting the record, the updated link explanation
will be visible.

Resolves: #88737
Releases: master, 9.5
Change-Id: I679abb2178aedfc8a29cccace99950a3a8acaab6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61422
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] RTE: Support anchors without `href` 24/60324/7
Thorben Nissen [Sun, 24 Mar 2019 16:06:07 +0000 (17:06 +0100)]
[BUGFIX] RTE: Support anchors without `href`

Removes enforcing of href attribute when storing RTE text into the
database. Removes adding of absolute scheme on a tags without href
attribute, when loading text from the database. Changes
ContentObjectRenderer::typolink to render a tag without href anyway, if
id or name attribute is present.
Adds unit tests.

Resolves: #87992
Releases: master, 9.5
Change-Id: I4dcd33e6f13dc6a1f364c96b425aa2f241653ae9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60324
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Use indexed menu item array for directory menu 62/61962/6
Alexander Stehlik [Fri, 11 Oct 2019 18:06:08 +0000 (20:06 +0200)]
[BUGFIX] Use indexed menu item array for directory menu

This prevents overwriting existing entries when a mount point
and its target have the same parent.

Resolves: #89402
Releases: master, 9.5
Change-Id: I1e527443410e0f875a95e803d4c3c026b089f5a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Reenable input field for page ID when setting a link via RTE 94/61194/7
Ioulia Kondratovitch [Sat, 29 Jun 2019 20:49:18 +0000 (22:49 +0200)]
[BUGFIX] Reenable input field for page ID when setting a link via RTE

Remove obsolete dot to make following setting work again:
RTE.default.buttons.link.pageIdSelector.enabled = 1

This now renders an input field for a page ID again when setting
a link via RTE.

Resolves: #88656
Releases: master, 9.5
Change-Id: I25a9cd20fd269f3f4f683ee6474f424897601a86
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61194
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Substitute form references for array keys as well in ext:form 90/61890/2
Christian Eßl [Sat, 5 Oct 2019 08:43:21 +0000 (10:43 +0200)]
[BUGFIX] Substitute form references for array keys as well in ext:form

In ext:form, string placeholders, like "{text-1}", can be used inside
the finisher to place form inputs, made by the user, inside fields like
the email subject, reploy to email and name, etc. These string
substitutions however were not done for array keys (only array values).

Resolves: #88550
Releases: master
Change-Id: I727850f3e15479215b56be4cd136d93644b0d435
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61890
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Add forceUid option to Import Command 16/59416/4
Martin [Fri, 11 Jan 2019 17:46:58 +0000 (18:46 +0100)]
[TASK] Add forceUid option to Import Command

Add possibility to force UIDs from Command Line
when importing a t3d/xml file.

Releases: master
Resolves: #87414
Change-Id: I2117079fb0a4af46355448256750978075749fb3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59416
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Support nomodule for JavaScript includes 08/58908/13
Guido Schmechel [Fri, 16 Nov 2018 22:42:53 +0000 (23:42 +0100)]
[FEATURE] Support nomodule for JavaScript includes

Add the property 'nomodule="nomodule"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.nomodule = 1

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #86759
Releases: master
Change-Id: I88db40ac973c17148a87504998f1070eba8d74af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58908
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Deprecate \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController 62/62162/9
Alexander Schnitzler [Wed, 30 Oct 2019 18:53:58 +0000 (19:53 +0100)]
[TASK] Deprecate \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController

The AbstractController is an internal class which never
really had any functionality than to provide some basic
method for the ActionController.

If users implemented their own controllers and
extended the AbstractController directly, the further
execution led to an exception. Unless people used the
AbstractController and implemented the missing logic
of the ActionController themselves, they didn't have
a functional controller, therefore it's safe to assume
that nobody extends the AbstractController directly.

To be on the safe side however, the AbstractController
is properly deprecated and will not be removed until
TYPO3 11.0.

People are - and always have been - encouraged to
extend the ActionController.

Releases: master
Resolves: #89554
Change-Id: I86a45621f4d32249f94deec0d932a930d3a9824f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62162
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Mark broken file links in RTE 91/62091/8
Sybille Peters [Thu, 7 Nov 2019 12:23:30 +0000 (13:23 +0100)]
[FEATURE] Mark broken file links in RTE

Broken file links are now marked in RTE with yellow background and red
border.

This patch uses the previously introduced event
:php:`BrokenLinkAnalysisEvent`.

The broken links are only detected if linkvalidator is installed and
has checked for broken links (e.g. via scheduler).

Resolves: #84990
Releases: master
Change-Id: Iddebe7f9358901c70f90f9751298ce2905684662
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62091
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Respect richtextConfiguration set via TCA 93/61193/12
Ioulia Kondratovitch [Sat, 29 Jun 2019 19:48:59 +0000 (21:48 +0200)]
[BUGFIX] Respect richtextConfiguration set via TCA

If richtextConfiguration is set via TCA for a specific text field
(e.g. for custom elements or within TCA-overrides),
respect the richtextConfiguration and prefer it over the general
RTE.default.preset

Removed 'richtextConfiguration' => 'default' from tt_content, since it is obsolete and breaks the logic of fallback.

New fallback order:
1. preset defined for a specific field via PageTS
2. richtextConfiguration defined for a specific field via TCA
3. general preset defined via PageTS
4. default

Resolves: #88655
Releases: master
Change-Id: I54271732ba862be4c05ccf62352ee685d72fb985
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61193
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update doctrine/dbal to minimum ^2.10 59/62259/3
Susanne Moog [Sat, 9 Nov 2019 09:55:54 +0000 (10:55 +0100)]
[TASK] Update doctrine/dbal to minimum ^2.10

    composer require doctrine/dbal:"^2.10"

Releases: master
Resolves: #89625
Change-Id: I1f0591d2544c34d1785c3cd3ee4b8a6d6643885f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62259
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add additional workspaces tests covering enable fields 55/62255/8
Oliver Hader [Fri, 8 Nov 2019 16:32:02 +0000 (17:32 +0100)]
[TASK] Add additional workspaces tests covering enable fields

Resolves: #89623
Releases: master, 9.5
Change-Id: Ibb2738c792173e8f40f0c98350629754379b74cb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62255
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Use correct icon for menu separator if hidden in menu 50/62250/3
Karsten Nowak [Fri, 8 Nov 2019 11:50:00 +0000 (12:50 +0100)]
[BUGFIX] Use correct icon for menu separator if hidden in menu

Now pages of doktype "menu separator" are using the correct icon
if `nav_hide` is set.

Resolves: #89615
Releases: master, 9.5, 8.7
Change-Id: I0d63b82e7e073fe12be6e073b0b364b5296f6ddf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62250
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect cacheHash excludedParameters in TSFE::reqCHash() 96/60296/22
Grigory Rechkin [Mon, 18 Mar 2019 12:32:05 +0000 (17:32 +0500)]
[BUGFIX] Respect cacheHash excludedParameters in TSFE::reqCHash()

* Requests with a parameter from "excludedParameters" settings
  will not raise a cHash comparison error
* Requests with configured enhancers will not raise the
  "Page ID is missing" error when used with additional parameters

Resolves: #87845
Releases: master, 9.5
Change-Id: I4312aa790d6660e0e7f9214841fe3d27c5f1b4ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60296
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix RTE preset example 51/62251/2
Daniel Siepmann [Fri, 8 Nov 2019 12:22:06 +0000 (13:22 +0100)]
[DOCS] Fix RTE preset example

The example for overwriting preset of a single field for specific type
(e.g. CType) was wrong. This is now fixed.

Also All examples were modified to create a better readable list to be
read from less specific to most specific with separated examples for
syntax and real world usage.

Resolves: #88858
Releases: master, 9.5
Change-Id: I759a606360b4e612e734cf70b7b992718d683dc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62251
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Prevent indexing of XML sitemaps by search engines 53/62253/3
Chris Müller [Fri, 8 Nov 2019 13:41:22 +0000 (14:41 +0100)]
[BUGFIX] Prevent indexing of XML sitemaps by search engines

The content of a XML sitemap should not be listed on search engine result
pages. This patch adds the HTTP header "X-Robots-Tag:noindex" to the
XML sitemaps.

Resolves: #89617
Releases: master, 9.5
Change-Id: I307b15ebcb26973846edc17f9b46562c1d38db45
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62253
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[TASK] Extend TCA shadowColumns instead of overriding them 56/62256/2
Oliver Hader [Fri, 8 Nov 2019 17:00:18 +0000 (18:00 +0100)]
[TASK] Extend TCA shadowColumns instead of overriding them

ext:irre_tutorial is extending corresponding TCA settings now.

Resolves: #89624
Resolves: master, 9.5, 8.7
Change-Id: I943a343d37808b38c4c6b14164e12380cc316dba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62256
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Don't escape decimal character group 20/62120/3
Matthias Vogel [Fri, 25 Oct 2019 19:09:23 +0000 (21:09 +0200)]
[BUGFIX] Don't escape decimal character group

Resolves: #87471
Releases: master, 9.5, 8.7
Change-Id: I0d139369c5ddc3acd8acbd278fe9841961002ca0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62120
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Avoid using deprecated Doctrine types 49/62249/4
Oliver Hader [Fri, 8 Nov 2019 11:07:50 +0000 (12:07 +0100)]
[TASK] Avoid using deprecated Doctrine types

Issue #89592 upgraded Doctrine to v2.10.0 - usages of deprecated
`TYPE::*` constants have not been adjusted (see doctrine/dbal
changelog https://github.com/doctrine/dbal/releases/tag/v2.10.0).

Resolves: #89592
Releases: master
Change-Id: Ic7aacf5041f22016876ed9daae4d167b0d15c493
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62249
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Remove references to "alternativeTempPath" 54/62254/3
Benni Mack [Fri, 8 Nov 2019 13:57:38 +0000 (14:57 +0100)]
[BUGFIX] Remove references to "alternativeTempPath"

The previous TypoScript option "alternativeTempPath"
was removed some years ago (before 6.2), but the option
was still present in tsref.xml, which is now
removed.

Resolves: #89618
Releases: master, 9.5, 8.7
Change-Id: I9d97ef0afb8cf0f10329a68fbf1eaaed48661412
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62254
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Pluralize term dynamically 74/62174/2
Oliver Bartsch [Fri, 1 Nov 2019 11:21:37 +0000 (12:21 +0100)]
[BUGFIX] Pluralize term dynamically

This adds a static method `pluralize` to dynamically pluralize
a term which changes during runtime to prevent a grammatically
wrong number.

Resolves: #89565
Releases: master, 9.5
Change-Id: Ib335d610bf680d2e4ecb494b19a99534e59e2ebb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62174
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Fix PHPDoc of BackendUtility::getRecordLocalization 00/62200/6
Tomita Militaru [Tue, 5 Nov 2019 22:16:24 +0000 (23:16 +0100)]
[BUGFIX] Fix PHPDoc of BackendUtility::getRecordLocalization

Now the return annotation states out that an empty array will
be returned if no localized records can be found and FALSE only
if the table is not localizable.

Resolves: #89584
Releases: master
Change-Id: Ibd2d1c345b79eb099c935604151a7972e755085f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62200
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Ditscheid <kevin@the-coding-owl.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Kevin Ditscheid <kevin@the-coding-owl.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Update doctrine/dbal to 2.10.0 03/62203/4
Manuel Selbach [Wed, 6 Nov 2019 10:49:51 +0000 (11:49 +0100)]
[TASK] Update doctrine/dbal to 2.10.0

With this change the new release of doctrine/dbal will be applied,
which will solve different bugfixes and introduce some new features.

For further information:

https://github.com/doctrine/dbal/releases/tag/v2.10.0

Resolves: #89592
Releases: master, 9.5
Change-Id: I30151e51372f1ecf349c28de78678924dc58dfc0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62203
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext 43/62243/4
Benni Mack [Thu, 7 Nov 2019 21:17:18 +0000 (22:17 +0100)]
[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext

The applicationContext tests were only checking
the string "applicationContext" and not the actual
object that was injected by the provider.

The change adapts the tests to make them actually
useful.

Resolves: #89612
Releases: master, 9.5
Change-Id: I1a155fa81817d42a8b4bd2ce853e0a0ed863c3e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62243
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Make site title configurable per website language 01/62101/9
Richard Haeser [Thu, 24 Oct 2019 14:54:40 +0000 (16:54 +0200)]
[FEATURE] Make site title configurable per website language

The site title can now be configured with the site module instead of
using the sys_template record. If you don't need localized site titles
you can also set the title on a site base.

The site title in the sys_template record is deprecated now and will be
used as a fallback in v10.

Resolves: #85592
Releases: master
Change-Id: I1caea88ef9bb7c1a4550d68bff1ede91b6f5cb2a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62101
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Chris Müller <typo3@krue.ml>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months agoRevert "[TASK] Speed up DB query for tables with versions" 09/62209/2
Oliver Hader [Wed, 6 Nov 2019 19:13:52 +0000 (20:13 +0100)]
Revert "[TASK] Speed up DB query for tables with versions"

This reverts commit 98c74eb212b728db2818c256994c501a6173ab7b.

The change resulted in AJAX timeouts when dealing with lots of
database records on MySQL 5.6 - it was fine however on MySQL 5.7.

Reverts: #86945
Resolves: #89464
Releases: master, 9.5, 8.7
Change-Id: Ied400255186f5e72521d3318521c3edb0f4f7784
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62209
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>