Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Reimplement custom BE languages 68/59068/7
Guido Schmechel [Sun, 9 Dec 2018 11:12:25 +0000 (12:12 +0100)]
[BUGFIX] Reimplement custom BE languages

Because of a regression the backend does not load custom BE languages.
The loading order is changed so that custom languages are available
again.

Resolves: #87101
Releases: master, 9.5
Change-Id: I0530957abc49f775497d9644047cbb49ceffcda9
Reviewed-on: https://review.typo3.org/59068
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[!!!][TASK] Drop evaluation of @inject annotations 82/58882/6
Alexander Schnitzler [Sat, 10 Nov 2018 14:47:35 +0000 (15:47 +0100)]
[!!!][TASK] Drop evaluation of @inject annotations

@inject will no longer trigger dependency injection

Releases: master
Resolves: #86899
Change-Id: Id440e94b71f62e7b2c396ec1c865ebd109026a04
Reviewed-on: https://review.typo3.org/58882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[!!!][TASK] Remove last batch of old class aliases 39/59239/3
Christian Kuhn [Thu, 20 Dec 2018 12:08:38 +0000 (13:08 +0100)]
[!!!][TASK] Remove last batch of old class aliases

Extbase extension is the last core extension that
delivered class aliases. Drop them.

Resolves: #87240
Releases: master
Change-Id: I89074e9d32a4f9f639199edf12c2ebd71be2f8e4
Reviewed-on: https://review.typo3.org/59239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Remove unused deprecation trait 36/59236/2
Christian Kuhn [Thu, 20 Dec 2018 10:52:48 +0000 (11:52 +0100)]
[BUGFIX] Remove unused deprecation trait

Resolves: #87239
Related: #87235
Releases: master
Change-Id: Idffa45715e19d71b0f08ff5885d665e0c6b44af8
Reviewed-on: https://review.typo3.org/59236
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Do not show error when copying a record was succesful 02/59202/3
Christoph Lehmann [Tue, 18 Dec 2018 22:23:52 +0000 (23:23 +0100)]
[TASK] Do not show error when copying a record was succesful

https://review.typo3.org/#/c/32356/ introduced the log message

The change was about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language

Due to https://review.typo3.org/#/c/51070/ $overrideValues contains

['l10n_source' => 0]

When an element is copied inside an earlier copyRecord() call
the error log message is generated which leads to an error
flash message editors see when copying a page, but everything
(copying the records once) went fine.

A earlier call of copyRecord() can occur when using extension like
gridelements when copying a content element laying inside a
grid container element.

Resolves: #82032
Releases: master, 9.5, 8.7
Change-Id: I0d5be8e8920852a0e0c5a5ee93a67f9a6426e941
Reviewed-on: https://review.typo3.org/59202
Reviewed-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Lange <lange@networkteam.com>
Tested-by: Christian Lange <lange@networkteam.com>
Reviewed-by: DANIEL Rémy <dogawaf@free.fr>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[!!!][TASK] Remove deprecated code from EXT:tstemplate 01/59201/8
Wouter Wolters [Tue, 18 Dec 2018 22:35:03 +0000 (23:35 +0100)]
[!!!][TASK] Remove deprecated code from EXT:tstemplate

Resolves: #87233
Releases: master
Change-Id: Ib5604ec4b46b2906565154274ba025a959ea102a
Reviewed-on: https://review.typo3.org/59201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[!!!][TASK] Remove deprecated code related to TSFE 26/59226/7
Benni Mack [Wed, 19 Dec 2018 19:46:45 +0000 (20:46 +0100)]
[!!!][TASK] Remove deprecated code related to TSFE

The following code related to TSFE has been removed:

PHP classes:
* TYPO3\CMS\Core\PageTitle\AltPageTitleProvider
* TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler
* TYPO3\CMS\Frontend\Page\PageGenerator
* TYPO3\CMS\Frontend\Page\EidUtility

PHP interfaces:
* TYPO3\CMS\Frontend\Http\UrlHandlerInterface

Methods that have been marked as protected
* tempPageCacheContent()
* realPageCacheContent()
* setPageCacheContent()
* clearPageCacheContent_pidList()
* setSysLastChanged()
* contentStrReplace()

Dropped TSFE methods
* mergingWithGetVars()
* connectToDB()
* initFEuser()
* checkAlternativeIdMethods()
* initializeBackendUser()
* getPageShortcut()
* pageUnavailableAndExit()
* pageNotFoundAndExit()
* checkPageUnavailableHandler()
* pageUnavailableHandler()
* pageNotFoundHandler()
* pageErrorHandler()
* makeCacheHash()
* initTemplate()
* handleDataSubmission()
* initializeRedirectUrlHandlers()
* redirectToExternalUrl()
* checkPageForMountpointRedirect()
* checkPageForShortcutRedirect()
* redirectToCurrentPage()
* processOutput()
* sendCacheHeaders()
* sendHttpHeadersDirectly()
* storeSessionData()
* previewInfo()
* hook_eofe()
* addTempContentHttpHeaders()
* setCSS()
* getUniqueId()
* readLLfile()
* getLLL()
* initLLvars()
* convPOSTCharset()
* convertCharsetRecursivelyToUtf8()
* domainNameMatchesCurrentRequest()
* getDomainDataForPid()
* getDomainNameForPid()

Dropped TSFE properties
* activeUrlHandlers
* page_cache_reg1
* siteScript
* loginUser
* gr_list
* beUserLogin
* workspacePreview
* ADMCMD_preview_BEUSER_uid
* showHiddenPage
* showHiddenRecords
* debug
* MP_defaults
* sys_language_uid
* sys_language_mode
* sys_language_content
* sys_language_contentOL
* altPageTitle
* lang

TSFE Properties now marked as protected
* loginAllowedInBranch
* loginAllowedInBranch_mode
* cacheTimeOutDefault
* cacheContentFlag
* cacheExpires
* isClientCachable
* no_cacheBeforePageGen
* tempContent
* pagesTSconfig
* pageCacheTags
* uniqueCounter
* uniqueString
* pageAccessFailureHistory

TSFE Method Signature changes
* calculateLinkVars now 1st parameter is required
* preparePageContentGeneration now 1st parameter is required
4th Parameter of TSFE->__construct() now unused

Removed TypoScript
* config.typolinkCheckRootline
* config.titleTagFunction
* config.USERUID_substToken
* config.USERNAME_substToken

Hooks
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc']

Database fields:
* index_phash.data_page_reg1

Resolves: #87235
Releases: master
Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41
Reviewed-on: https://review.typo3.org/59226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[!!!][TASK] Remove deprecated GeneralUtility functionality 30/59230/6
Christian Kuhn [Wed, 19 Dec 2018 21:23:42 +0000 (22:23 +0100)]
[!!!][TASK] Remove deprecated GeneralUtility functionality

Resolves: #87234
Releases: master
Change-Id: I07eb0387b8ad1921f715637a5a48581f3eaf9c42
Reviewed-on: https://review.typo3.org/59230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[!!!][TASK] Remove deprecated adminpanel/feedit code 05/59205/4
Benni Mack [Wed, 19 Dec 2018 08:59:28 +0000 (09:59 +0100)]
[!!!][TASK] Remove deprecated adminpanel/feedit code

The following previously deprecated classes/interfaces have been removed:

* TYPO3\CMS\Adminpanel\View\AdminPanelView
* TYPO3\CMS\Adminpanel\View\AdminPanelViewHookInterface
* TYPO3\CMS\Core\FrontendEditing\FrontendEditingController

The following methods have been removed:
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->displayAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isAdminPanelVisible()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->checkBackendAccessSettingsFromInitPhp()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extPageReadAccess()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetTreeList()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetLL()

The following public properties have been removed
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdmEnabled
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->adminPanel
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->frontendEdit
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdminConfig

The following PageTSconfig option has no effect anymore:
* TSFE.frontendEditingController

Resolves: #87231
Releases: master
Change-Id: I88cc3ac18077f054cc8895f5ccfb65291e94defa
Reviewed-on: https://review.typo3.org/59205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[!!!][TASK] Remove old fluid related class aliases 27/59227/4
Christian Kuhn [Wed, 19 Dec 2018 19:50:11 +0000 (20:50 +0100)]
[!!!][TASK] Remove old fluid related class aliases

Drops old fluid class aliases. Note most of them have
been deprecated with core v8 already.

Resolves: #87230
Releases: master
Change-Id: I509019be4e1df77bfeb94a7498a1ba795c128e86
Reviewed-on: https://review.typo3.org/59227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Require styleguide 10.0.1 28/59228/3
Christian Kuhn [Wed, 19 Dec 2018 20:17:18 +0000 (21:17 +0100)]
[TASK] Require styleguide 10.0.1

Styleguide used old fluid related class aliases
which is fixed with this raise.

composer require --dev typo3/cms-styleguide:~10.0.1

Change-Id: I77648c6c919f60866acec9bdaf4cefce437a074c
Resolves: #87232
Related: #87230
Releases: master
Reviewed-on: https://review.typo3.org/59228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[!!!][TASK] Remove deprecated frontend-related hooks and include scripts 17/59217/7
Benni Mack [Wed, 19 Dec 2018 15:56:44 +0000 (16:56 +0100)]
[!!!][TASK] Remove deprecated frontend-related hooks and include scripts

The following hooks have been removed:
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preBeUser']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkAlternativeIdMethods-PostProc']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkDataSubmission']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo']

The class EidRequestHandler has been removed.

eID targets cannot include a scriptpath anymore:
- $GLOBALS['TYPO3_CONF_VARS']['FE']['eID_include']['my_eID'] = 'EXT:benni/Scripts/download.php';

Instead, they must contain a target (callable, class/method, function).

The various hooks are still in place in deprecated methods within TSFE which will be removed
in the next patch. Also, now hardly usable PSR-15 middlewares will be cleaned up separately
as well.

Resolves: #87220
Releases: master
Change-Id: Ic54af83c97f2e6d2fba4346e382240d0fac6a2dc
Reviewed-on: https://review.typo3.org/59217
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Add checkDataSubmission hook to extension scanner 24/59224/2
Benjamin Franzke [Wed, 19 Dec 2018 18:59:19 +0000 (19:59 +0100)]
[BUGFIX] Add checkDataSubmission hook to extension scanner

This one slipped through in https://review.typo3.org/c/59217/
Also add it to the deprecation .rst file.

Releases: master, 9.5
Resolves: #87229
Related: #86279
Change-Id: Idc5a3d0cc05906938e134fd2b6cea367324a773a
Reviewed-on: https://review.typo3.org/59224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[!!!][TASK] Remove old class aliases from core extension 22/59222/3
Christian Kuhn [Wed, 19 Dec 2018 18:10:18 +0000 (19:10 +0100)]
[!!!][TASK] Remove old class aliases from core extension

Resolves: #87228
Releases: master
Change-Id: I400fa0bc7882b0ee366c6f923c8e21c30b30a5f6
Reviewed-on: https://review.typo3.org/59222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated migration for PackageStates.php v4 version 21/59221/2
Benjamin Franzke [Wed, 19 Dec 2018 15:33:27 +0000 (16:33 +0100)]
[!!!][TASK] Remove deprecated migration for PackageStates.php v4 version

This migration was deprecated during v8 phase in
https://review.typo3.org/46389 and then expanded to be removed in v10
during v9 deprecation removal. Remove this one now.

Releases: master
Resolves: #87226
Related: #73041
Change-Id: I1ffcf0c8f50e311d90e7be935ece30c50eb2e4b6
Reviewed-on: https://review.typo3.org/59221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated cObj/stdWrap functionality 18/59218/3
Benni Mack [Wed, 19 Dec 2018 16:07:40 +0000 (17:07 +0100)]
[!!!][TASK] Remove deprecated cObj/stdWrap functionality

The following methods within cObj have been removed:
- enableFields()
- currentPageUrl()
- typolinkWrap()
- calcIntExplode()
- filelink()
- addParams()
- filelist()
- stdWrap_filelink()
- stdWrap_addParams()
- stdWrap_filelist()

The following TypoScript stdWrap properties are now removed:
- filelist
- filelink
- addParams

Resolves: #87221
Releases: master
Change-Id: I08ca55b0ac51412356fd40f34193f6b3869c3071
Reviewed-on: https://review.typo3.org/59218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove several deprecated PHP classes 16/59216/4
Christian Kuhn [Wed, 19 Dec 2018 15:49:07 +0000 (16:49 +0100)]
[!!!][TASK] Remove several deprecated PHP classes

Various classes that have no huge dependencies to
other deprecated code are removed.

Resolves: #87219
Releases: master
Change-Id: I2eb6c56b379b50028fe166c20995ad61f16469fd
Reviewed-on: https://review.typo3.org/59216
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated class Package\DependencyResolver 12/59212/5
Benjamin Franzke [Wed, 19 Dec 2018 10:55:45 +0000 (11:55 +0100)]
[!!!][TASK] Remove deprecated class Package\DependencyResolver

Also remove deprecations that were introduced with the deprecation
of the DependencyResolver in https://review.typo3.org/55977

Removed classes:
  - TYPO3\CMS\Core\Package\DependencyResolver

Removed methods:
  - TYPO3\CMS\Core\Package\PackageManager->injectDependencyResolver()

Method signature changes:
  - TYPO3\CMS\Core\Package\PackageManager->__construct():
    First argument mandatory

Releases: master
Resolves: #87213
Change-Id: Icb1fb060387ec00e5c7aa4429620b0ee251463b8
Reviewed-on: https://review.typo3.org/59212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove a series of old class aliases 13/59213/3
Christian Kuhn [Wed, 19 Dec 2018 14:27:43 +0000 (15:27 +0100)]
[!!!][TASK] Remove a series of old class aliases

Drop all "easy" cases of old class aliases, only
some bigger extensions are left for dedicated patches.

Resolves: #87217
Releases: master
Change-Id: I61eda47a02ab32430564edb063a5cbf59d560337
Reviewed-on: https://review.typo3.org/59213
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove old recordList classes 15/59215/2
Christian Kuhn [Wed, 19 Dec 2018 14:57:46 +0000 (15:57 +0100)]
[!!!][TASK] Remove old recordList classes

Remove unused AbstractRecordList
and AbstractDatabaseRecordList.

Resolves: #87218
Releases: master
Change-Id: I20b7e1c469eb6bed4a2774d5c050fa7ef9407cbd
Reviewed-on: https://review.typo3.org/59215
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder 14/59214/3
Benjamin Franzke [Wed, 19 Dec 2018 13:45:02 +0000 (14:45 +0100)]
[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder

These constant redefintion guards were forgotten to be updated when
Bootstrap::getInstance() and the call to SystemEnvironmentBuilder::run()
in Bootstrap::baseSetup() were removed.

These guards are no longer necessary for regular execution as baseSetup()
does no longer (conditionally) invoke SystemEnvironmentBuilder::run()
(which was provided for deprecated and now removed bootstrapping code).

We do still leave the guards in, as they are needed in unit tests,
but update the comments.

Releases: master
Resolves: #87216
Related: #87202
Change-Id: I3b1c60ea32163d68b7f314b6539c54d8c048c323
Reviewed-on: https://review.typo3.org/59214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from TemplateService 04/59204/5
Benni Mack [Wed, 19 Dec 2018 07:27:57 +0000 (08:27 +0100)]
[!!!][TASK] Remove deprecated code from TemplateService

The TemplateService class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- absoluteRootLine
- matchAll
- nextLevel
- outermostRootlineIndexWithTemplate
- rootId
- rowSum
- sectionsMatch
- simulationHiddenOrTime
- sitetitle

Removed properties:
- allowedPaths
- debug
- fileCache
- frames
- MPmap
- whereClause

Methods now marked as protected:
- flattenSetup()
- mergeConstantsFromPageTSconfig()
- prependStaticExtra()
- processIncludes()
- substituteConstants()
- versionOL()

Removed public methods:
- getFileName()
- getFromMPmap()
- init()
- initMPmap_create()
- linkData()
- printTitle()

Resolves: #87207
Releases: master
Change-Id: I264a44ee00450cb9cef23aad365a2266bb7bfa70
Reviewed-on: https://review.typo3.org/59204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Remove unused argument $entryPointLevel from Bootstrap 11/59211/2
Christian Kuhn [Wed, 19 Dec 2018 12:26:08 +0000 (13:26 +0100)]
[BUGFIX] Remove unused argument $entryPointLevel from Bootstrap

The argument is optional and can be removed without
further notice.

Resolves: #87212
Related: #87202
Releases: master
Change-Id: I667a091b84986111562a581c0bb22d29f624fd19
Reviewed-on: https://review.typo3.org/59211
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove $response preparation in route dispatching 09/59209/4
Christian Kuhn [Wed, 19 Dec 2018 11:50:51 +0000 (12:50 +0100)]
[!!!][TASK] Remove $response preparation in route dispatching

Calling controllers with a prepared $response object is
dropped, together with the b/w compat feature
'simplifiedControllerActionDispatching'.

Resolves: #87211
Releases: master
Change-Id: Ia1cba4cc78e1cf8527f9c2a8b8f20655bc6af611
Reviewed-on: https://review.typo3.org/59209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated module classes from backend 08/59208/3
Christian Kuhn [Wed, 19 Dec 2018 10:06:46 +0000 (11:06 +0100)]
[!!!][TASK] Remove deprecated module classes from backend

Removed classes:
TYPO3\CMS\Backend\Module\AbstractFunctionModule
TYPO3\CMS\Backend\Module\AbstractModule
TYPO3\CMS\Backend\Module\BaseScriptClass

Resolves: #87210
Releases: master
Change-Id: I56c92246e7b18fd87707e767f743fd4c84f043a1
Reviewed-on: https://review.typo3.org/59208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add acceptance test for Template and Sites creation 84/59184/8
Steffen Dietrich [Mon, 17 Dec 2018 16:23:38 +0000 (17:23 +0100)]
[TASK] Add acceptance test for Template and Sites creation

Extends the existing site configuration acceptance test
by adding a default FE ts snipped and verifying FE is
rendered.

Resolves: #87191
Releases: master, 9.5
Change-Id: I369980f2de240db9647550dad73a2923a1aa6371
Reviewed-on: https://review.typo3.org/59184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from Bootstrap 96/59196/5
Benjamin Franzke [Tue, 18 Dec 2018 10:34:24 +0000 (11:34 +0100)]
[!!!][TASK] Remove deprecated code from Bootstrap

Remove code that is not needed due to the static bootstrap
and PSR-15 refactoring during v9 phase.

All deprecated methods and state is removed from the Bootstrap class,
which includes the Bootstrap instance itself. Bootstrap is provided as
statically invoked utility now.
The Bootstrap instance was deprecated implictly due to the deprecation
of getInstance() (combined with the protected constructor).
We therefore remove the constructor and all (now unused) class properties
and the method-chaining (which was only useful to reduce calls to the
getInstance() method).

Releases: master
Resolves: #87202
Change-Id: Ie97e824294a03d8de88430772fdab4adaf7e3f1f
Reviewed-on: https://review.typo3.org/59196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated $GLOBALS['TYPO3_GLOBALS_EXT'] 07/59207/2
Benjamin Franzke [Wed, 19 Dec 2018 09:48:48 +0000 (10:48 +0100)]
[!!!][TASK] Remove deprecated $GLOBALS['TYPO3_GLOBALS_EXT']

$GLOBALS['TYPO3_GLOBALS_EXT'] was deprecated in
https://review.typo3.org/58408 and is now removed together
with the internal helper classes LoadedExtensionsArray
and LoadedExtensionArrayElement which powered this array.

Releases: master
Resolves: #87209
Change-Id: Ic323f881b5d07aa70046becf837a2d1dda0d9400
Reviewed-on: https://review.typo3.org/59207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Remove unused if in PasswordHashing 06/59206/2
Christian Kuhn [Wed, 19 Dec 2018 09:44:23 +0000 (10:44 +0100)]
[BUGFIX] Remove unused if in PasswordHashing

A useless if can be dropped since the deprecation
removals.

Resolves: #87208
Releases: master
Change-Id: Ib664a3d50fb4aeb7956606b054e46a0be84d1e92
Reviewed-on: https://review.typo3.org/59206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from PageRepository 93/59193/7
Benni Mack [Tue, 18 Dec 2018 07:25:31 +0000 (08:25 +0100)]
[!!!][TASK] Remove deprecated code from PageRepository

The PageRepository class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- sys_language_uid
- versioningWorkspaceId

Removed properties:
- versioningPreview
- workspaceCache
- error_getRootLine
- error_getRootLine_failPid

Removed public methods:
- getFirstWebPage()
- getDomainStartPage()
- getRootLine()
- getRecordsByField()
- deleteClause()
- checkWorkspaceAccess()
- getFileReferences()

Removed arguments from public methods:
- 4th argument of getRawRecord()

Special argument handling for public methods:
- getPageOverlay() second argument "-1" has to be "null" now
- getPagesOverlay() second argument "-1" has to be "null" now

Resolves: #87195
Releases: master
Change-Id: Iaf7d5e68054db0f9e78d8ea2fc0d8bb712bf3b74
Reviewed-on: https://review.typo3.org/59193
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing 97/59197/6
Christian Kuhn [Tue, 18 Dec 2018 18:05:53 +0000 (19:05 +0100)]
[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing

Removed classes:
TYPO3\CMS\Core\Crypto\PasswordHashing\AbstractComposedSalt

Removed interfaces:
TYPO3\CMS\Core\Crypto\PasswordHashing\ComposedPasswordHashInterface
TYPO3\CMS\Core\Crypto\PasswordHashing\ExtensionManagerConfigurationUtility
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordService
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordsUtility

Removed class aliases:
TYPO3\CMS\Saltedpasswords\Salt\AbstractSalt
TYPO3\CMS\Saltedpasswords\Salt\AbstractComposedSalt
TYPO3\CMS\Saltedpasswords\Salt\Argon2iSalt
TYPO3\CMS\Saltedpasswords\Salt\BcryptSalt
TYPO3\CMS\Saltedpasswords\Salt\BlowfishSalt
TYPO3\CMS\Saltedpasswords\Salt\ComposedSaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Md5Salt
TYPO3\CMS\Saltedpasswords\Salt\SaltFactory
TYPO3\CMS\Saltedpasswords\Salt\SaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Pbkdf2Salt
TYPO3\CMS\Saltedpasswords\Salt\PhpassSalt
TYPO3\CMS\Saltedpasswords\SaltedPasswordsService
TYPO3\CMS\Saltedpasswords\Utility\ExensionManagerConfigurationUtility
TYPO3\CMS\Saltedpasswords\Utility\SaltedPasswordsUtility

Removed methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMinHashCount()

Protected methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Decode()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->base64Encode()

Removed static methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::determineSaltingHashingMethod()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getSaltingInstance()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::setPreferredHashingMethod()

Second method argument dropped:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashedPassword()

Ignored options:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods']

Dropped constants:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MIN_HASH_COUNT

Removed language file aliases:
EXT:saltedpasswords/Resources/Private/Language/locallang.xlf
EXT:saltedpasswords/Resources/Private/Language/locallang_em.xlf

Change-Id: Ia6a18209f104ca1abc6981508fb8b640ef2eb1a3
Resolves: #87203
Releases: master
Reviewed-on: https://review.typo3.org/59197
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated methods from BackendUtility 03/59203/4
Christian Kuhn [Wed, 19 Dec 2018 00:24:48 +0000 (01:24 +0100)]
[!!!][TASK] Remove deprecated methods from BackendUtility

Removes most deprecated code from BackendUtility, except a method
that has bigger cross dependencies to other deprecated code.

Removed methods:
TYPO3\CMS\Backend\Utility\BackendUtility::deleteClause()
TYPO3\CMS\Backend\Utility\BackendUtility::getOriginalTranslationTable()
TYPO3\CMS\Backend\Utility\BackendUtility::getTCAtypes()
TYPO3\CMS\Backend\Utility\BackendUtility::storeHash()
TYPO3\CMS\Backend\Utility\BackendUtility::getHash()
TYPO3\CMS\Backend\Utility\BackendUtility::getListGroupNames()
TYPO3\CMS\Backend\Utility\BackendUtility::getModTSconfig()
TYPO3\CMS\Backend\Utility\BackendUtility::unsetMenuItems()
TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl()
TYPO3\CMS\Backend\Utility\BackendUtility::getPidForModTSconfig()
TYPO3\CMS\Backend\Utility\BackendUtility::getDomainStartPage()
TYPO3\CMS\Backend\Utility\BackendUtility::shortcutExists()

Method signatures:
TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfig() - Second and third argument dropped

Other notes:
Overriding page TSconfig on user TSconfig level with the 'mod.' prefix
is dropped, used 'page.mod' instead.

Resolves: #87206
Releases: master
Change-Id: Ib4102bfc24a99a22891deb46d4b1bb227ffd3936
Reviewed-on: https://review.typo3.org/59203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated PHP classes from EXT:workspaces 98/59198/5
Wouter Wolters [Tue, 18 Dec 2018 21:38:58 +0000 (22:38 +0100)]
[!!!][TASK] Remove deprecated PHP classes from EXT:workspaces

Resolves: #87204
Releases: master
Change-Id: If697a2761c6c0eb42848c45dd17373d0e1dea5da
Reviewed-on: https://review.typo3.org/59198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Typo 'boostrap' should be 'bootstrap' 99/59199/2
Christian Kuhn [Tue, 18 Dec 2018 21:45:17 +0000 (22:45 +0100)]
[TASK] Typo 'boostrap' should be 'bootstrap'

Resolves: #87205
Releases: master, 9.5
Change-Id: Idb22d2178bbd20982d4876b5dff45b06dea4100d
Reviewed-on: https://review.typo3.org/59199
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated PHP classes from EXT:core 95/59195/5
Benni Mack [Tue, 18 Dec 2018 17:27:21 +0000 (18:27 +0100)]
[!!!][TASK] Remove deprecated PHP classes from EXT:core

The following previously deprecated PHP classes are now removed:
- TYPO3\CMS\Core\Encoder\JavaScriptEncoder
- TYPO3\CMS\Core\Resources\Utility\BackendUtility
- TYPO3\CMS\Core\Utility\ClientUtility
- TYPO3\CMS\Core\Utility\PhpOptionsUtility

Resolves: #87201
Releases: master
Change-Id: I0b1896692ebf1f15948a9a3661fdc10ab6f019ff
Reviewed-on: https://review.typo3.org/59195
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated code from charset converter 90/59190/6
Benni Mack [Tue, 18 Dec 2018 06:30:00 +0000 (07:30 +0100)]
[!!!][TASK] Remove deprecated code from charset converter

The CharsetConverter class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- parsedCharsets
- noCharByteVal
- toASCII
- twoByteSets
- eucBasedSets

Removed properties:
- synonyms

Removed public methods:
- parse_charset
- convArray
- utf8_to_entities
- entities_to_utf8
- crop
- convCaseFirst
- utf8_char2byte_pos

Removed arguments from public methods:
- 4th argument $useEntityForNoChar of conv

Resolves: #87194
Releases: master
Change-Id: I7ec967a076e9c43f62d95f1912574d3784b924d1
Reviewed-on: https://review.typo3.org/59190
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Do not try to delete already remove file 86/59186/2
Helmut Hummel [Mon, 17 Dec 2018 21:33:23 +0000 (22:33 +0100)]
[BUGFIX] Do not try to delete already remove file

When using the FAL API to add a file to a folder,
the local file is deleted by default already.

Thus the attempt to remove the file again results in a warning.

Therefore remove the obsolete unlink to avoid the warning.

Resolves: #87192
Releases: 8.7, 9.5, master
Change-Id: I23f3192e2760cd705429337464c8a5506cf41205
Reviewed-on: https://review.typo3.org/59186
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Streamline UX for File Upload module 75/59175/2
Benni Mack [Mon, 17 Dec 2018 08:08:40 +0000 (09:08 +0100)]
[BUGFIX] Streamline UX for File Upload module

When using the file upload module (called via File list), the dialog uses
non-bootstrap classes from historical times back in the day.

Using proper HTML makes the view look more like the rest of
TYPO3 Backend.

Resolves: #87178
Releases: master, 9.5
Change-Id: I4d6a4c8f96414d5fb776270db6ef8aa677e788b7
Reviewed-on: https://review.typo3.org/59175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add missing use statement in CObjectViewHelper 85/59185/3
Georg Ringer [Mon, 17 Dec 2018 18:53:49 +0000 (19:53 +0100)]
[BUGFIX] Add missing use statement in CObjectViewHelper

The use statement for TypoScriptFrontendController is added.

Resolves: #87186
Releases: master, 9.5
Change-Id: I2b758b3ac9bcd4002844160614ee1a9c7bc72585
Reviewed-on: https://review.typo3.org/59185
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Do not depend on global TSFE for link generation 36/59036/6
Benni Mack [Wed, 5 Dec 2018 10:41:42 +0000 (11:41 +0100)]
[BUGFIX] Do not depend on global TSFE for link generation

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Resolves: #87143
Releases: master, 9.5
Change-Id: I77f2da501d1a78f0579626ebb50ef47a0026f1f7
Reviewed-on: https://review.typo3.org/59036
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[TASK] Streamline dependencies in package.json 74/59174/3
Benni Mack [Mon, 17 Dec 2018 07:49:12 +0000 (08:49 +0100)]
[TASK] Streamline dependencies in package.json

Several changes to Build/package.json are
adapted:
- define compatible node/yarn versions
- adapt version and URL to typo3.org

Resolves: #87177
Releases: master, 9.5, 8.7
Change-Id: Ie812cd69913e2969dc88db8e8c52edbb6d482243
Reviewed-on: https://review.typo3.org/59174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Matthias Stegmann <matthias.stegmann@b13.de>
Tested-by: Matthias Stegmann <matthias.stegmann@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Mark form as changed after using the image cropper 66/59166/3
Andreas Fernandez [Sun, 16 Dec 2018 11:24:45 +0000 (12:24 +0100)]
[BUGFIX] Mark form as changed after using the image cropper

The image cropper now marks the form as "changed" after saving new
cropping information.

Resolves: #86998
Releases: master, 9.5, 8.7
Change-Id: Ia6a6abeb88b1d9a590e76b50890ebcbac16f7472
Reviewed-on: https://review.typo3.org/59166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] bamboo sends nightly build messages to intercept 68/59168/2
Christian Kuhn [Sun, 16 Dec 2018 14:46:54 +0000 (15:46 +0100)]
[TASK] bamboo sends nightly build messages to intercept

Resolves: #87171
Releases: master, 9.5, 8.7
Change-Id: Ia71eb5ce2824ff3c39dbc526ec3a3d93b4990eca
Reviewed-on: https://review.typo3.org/59168
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing 65/59165/2
Christian Kuhn [Sat, 15 Dec 2018 12:14:10 +0000 (13:14 +0100)]
[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing

With latest changes in master and helper repositories, we do
not need the COMPOSER_ROOT_VERSION setting in tests anymore.
Remove that to have one detail less to maintain.

Resolves: #87170
Releases: master
Change-Id: Iea54bb6f17d0b08b4b248c40ad60691aa5cb0cb3
Reviewed-on: https://review.typo3.org/59165
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] composer update without progress in bamboo 63/59163/3
Christian Kuhn [Fri, 14 Dec 2018 20:05:18 +0000 (21:05 +0100)]
[TASK] composer update without progress in bamboo

To prevent garbled output in test logs, composer update
commands add --no-progress option.

Resolves: #87169
Releases: master, 9.5
Change-Id: I89f27fbf3fea44216f5a01fc3be20f6614dbe8d0
Reviewed-on: https://review.typo3.org/59163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Disable ext:introduction installer ac test 62/59162/3
Christian Kuhn [Fri, 14 Dec 2018 19:42:10 +0000 (20:42 +0100)]
[TASK] Disable ext:introduction installer ac test

Core v10 compatible releases of ext:introduction and
ext:bootstrap_package will take time until the other day.
To not disable all install related tests, the
ext:introduction related ac tests are skipped for master
for the time being.

Resolves: #87168
Releases: master
Change-Id: I498a9962beca9b9d5e87f7c19fd02ea72db961ac
Reviewed-on: https://review.typo3.org/59162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0 61/59161/3
Christian Kuhn [Fri, 14 Dec 2018 18:35:56 +0000 (19:35 +0100)]
[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0

A first v10 core compatible styleguide

composer require --dev typo3/cms-styleguide:~10.0.0

Change-Id: I1c9ceb172c72cd52382e090f65c0e7a6a9914b03
Resolves: #87167
Releases: master
Reviewed-on: https://review.typo3.org/59161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0 58/59158/3
Christian Kuhn [Fri, 14 Dec 2018 17:03:09 +0000 (18:03 +0100)]
[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0

Version 5.0.0 of typo3/testing-framework brings core v10
compatibility. This fixes a 'requirements could not be resolved'
message from composer for core master branch.

composer require --dev typo3/testing-framework:~5.0.0

Resolves: #87164
Releases: master
Change-Id: I3dab9b83d872545eff71705a3f4da2a73c40e0da
Reviewed-on: https://review.typo3.org/59158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update TYPO3 version to 10.0.0-dev 50/59150/4
Benni Mack [Fri, 14 Dec 2018 08:58:05 +0000 (09:58 +0100)]
[TASK] Update TYPO3 version to 10.0.0-dev

In order to distinguish between v10-dev / dev-master,
and 9.5, all dependencies are updated to v10.0.0-dev.

For ext_emconf.php the fixed version 10.0.0 is used
as in all other branches.

Resolves: #87159
Releases: master
Change-Id: Ie1f135663527f8c7d1654e085b874d699b677529
Reviewed-on: https://review.typo3.org/59150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Update URL to use HTTPS 28/59128/2
Ben Abbott [Wed, 12 Dec 2018 22:29:21 +0000 (23:29 +0100)]
[TASK] Update URL to use HTTPS

Releases: master
Resolves: #87140
Change-Id: I567b92746e26043b50f9cb735d89aa02f4ccda00
Reviewed-on: https://review.typo3.org/59128
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.4-dev 45/59145/3
Oliver Hader [Fri, 14 Dec 2018 07:29:45 +0000 (08:29 +0100)]
[TASK] Set TYPO3 version to 9.5.4-dev

Change-Id: I99d51f3836de8d062bc5503bcc58e05cdfacb83c
Reviewed-on: https://review.typo3.org/59145
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.3 44/59144/2 v9.5.3
Oliver Hader [Fri, 14 Dec 2018 07:28:19 +0000 (08:28 +0100)]
[RELEASE] Release of TYPO3 9.5.3

Change-Id: Iee75e14be97ac5018cedf4f7f94664d8d4fe43f0
Reviewed-on: https://review.typo3.org/59144
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[DOC] Add ChangeLog index of 9.5.x 24/59124/3
Sybille Peters [Wed, 12 Dec 2018 18:17:18 +0000 (19:17 +0100)]
[DOC] Add ChangeLog index of 9.5.x

In order to get a rendered list of changes since the release of 9.5.0 an
additional index file is needed for the 9.5.x changes.

Resolves: #87135
Releases: master
Change-Id: I14713eace6493220852aea55ae431b1c4182ee80
Reviewed-on: https://review.typo3.org/59124
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix positioning of arrows in Element Browser 36/59136/2
Andreas Fernandez [Thu, 13 Dec 2018 16:18:09 +0000 (17:18 +0100)]
[BUGFIX] Fix positioning of arrows in Element Browser

The positioning of the collapse/expand arrows is changed to fix the break
in trees with very deep nesting.

Resolves: #86790
Releases: master, 8.7
Change-Id: Ie1a916da8220468c6fbb4034c1668675f379f588
Reviewed-on: https://review.typo3.org/59136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Properly separate markup for modal windows in extension manager 35/59135/4
Oliver Hader [Thu, 13 Dec 2018 15:41:12 +0000 (16:41 +0100)]
[BUGFIX] Properly separate markup for modal windows in extension manager

Due to recent security releases and fixes against cross-site scripting
in central modal window component, templates are separated in order to
distinguish between (secure) HTML and attribute or text nodes.

Resolves: #87146
Releases: master, 8.7
Change-Id: I1264cbe9005e54d1fe30eaba23efbbad07937cb1
Reviewed-on: https://review.typo3.org/59135
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in modal of OnlineMedia.ts 20/59120/10
Georg Ringer [Tue, 11 Dec 2018 19:33:18 +0000 (20:33 +0100)]
[BUGFIX] Fix HTML in modal of OnlineMedia.ts

Allows to call the OnlineMedia modal box again.

This change also adapts the buttons within
a Modal to be text-only.
Resolves: #87144
Releases: master, 8.7
Change-Id: Id08356aad3eb319c59af1411a14131715c8159d0
Reviewed-on: https://review.typo3.org/59120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js 21/59121/4
Stefan Neufeind [Tue, 11 Dec 2018 20:56:41 +0000 (21:56 +0100)]
[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js

Resolves: #87145
Releases: master
Change-Id: Ie3abd71840ca8fbd48150ae2b4f34efc5273ce63
Reviewed-on: https://review.typo3.org/59121
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] getTreeList inserts duplicate keys in cache_treelist 27/59127/6
Alexander Schnitzler [Wed, 12 Dec 2018 21:53:07 +0000 (22:53 +0100)]
[BUGFIX] getTreeList inserts duplicate keys in cache_treelist

Unfortunately https://review.typo3.org/58951/ did not actually
solve issues #86028 and #86491 for good.

There are two issues concerning the former approach:

1) The expiration time of all created caches was 0, which resulted
   in a permanent creation and deletion of cache entries. This
   behaviour cannot be called caching.

2) Number 1) increases the chance for race conditions where several
   parallel requests tried to create the same cache entry.

To fix this, the check for an existing cache entry will be reverted
to behave like before the regression, i.e. cache entries with an
expiration timestamp of 0 are considered valid again.

Also, new caches are created within a transaction, which prevents
duplicate key errors.

Releases: master, 8.7
Resolves: #87139
Change-Id: If9470f6e0f875c0ec4fe3c092c9bd0dfc059de2d
Reviewed-on: https://review.typo3.org/59127
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 37/59137/2
Benni Mack [Thu, 13 Dec 2018 16:35:50 +0000 (17:35 +0100)]
[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This reverts commit c23b1e1970d44cb3fc836db697650be568788218
as now frontend rendering is different from 8.7.19 and 8.7.20.

Change-Id: Ia640ed3eda1619b0a34b5cd6afd07a665e372792
Resolves: #86819
Reverts: #83795
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/59137
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump() 32/59132/4
Mathias Brodala [Thu, 13 Dec 2018 14:21:15 +0000 (15:21 +0100)]
[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump()

Resolves: #87149
Releases: master, 8.7
Change-Id: I8cf2cfab94634276a67fd3d0dd36215c12ae5490
Reviewed-on: https://review.typo3.org/59132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Tested-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[TASK] Silence composer install progress in bamboo 25/59125/2
Christian Kuhn [Wed, 12 Dec 2018 19:43:07 +0000 (20:43 +0100)]
[TASK] Silence composer install progress in bamboo

Resolves: #87136
Releases: master, 8.7
Change-Id: Idbac64bf44b8f79ccd8a169f4abade462873e17d
Reviewed-on: https://review.typo3.org/59125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer 52/58952/3
Benni Mack [Mon, 26 Nov 2018 14:46:27 +0000 (15:46 +0100)]
[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer

In Extbase, it is possible to configure a custom namespace for
plugin arguments:

plugin.tx_bennimack.view.pluginNamespace = bmack

This is now also respected in the Extbase Plugin Enhancer by omitting
"extension" and "plugin" properties and just using the "namespace"
property.

Resolves: #87005
Releases: master
Change-Id: I19c6338ec0d103837a5c5217ad7ba6643b6b6c54
Reviewed-on: https://review.typo3.org/58952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Aimeos <aimeos@aimeos.org>
Tested-by: Aimeos <aimeos@aimeos.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Remove @ in doc comment of TypoScriptParser 74/59074/3
Georg Ringer [Mon, 10 Dec 2018 11:17:57 +0000 (12:17 +0100)]
[BUGFIX] Remove @ in doc comment of TypoScriptParser

To avoid exceptions by the Doctrine annotations parser, the @ character
is removed from the doc comment.

Resolves: #87115
Releases: master
Change-Id: I779374e2b9894272087153860de525fa0ce02712
Reviewed-on: https://review.typo3.org/59074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Add filter for be_users and be_groups 70/59070/4
Guido Schmechel [Sun, 9 Dec 2018 20:26:34 +0000 (21:26 +0100)]
[TASK] Add filter for be_users and be_groups

Add textfield filter for select fields from type
"selectMultipleSideBySide" for system tables.

Affected system tables: be_groups, be_users

Resolves: #87112
Releases: master, 8.7
Change-Id: Iba8b837a9fc5f2ec64be7e5ad313b454c4373feb
Reviewed-on: https://review.typo3.org/59070
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.3-dev 16/59116/2
Oliver Hader [Tue, 11 Dec 2018 12:43:54 +0000 (13:43 +0100)]
[TASK] Set TYPO3 version to 9.5.3-dev

Change-Id: If92f54c5a28edba2dc330ca8e32e5dcfda817f6f
Reviewed-on: https://review.typo3.org/59116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.2 15/59115/2 v9.5.2
Oliver Hader [Tue, 11 Dec 2018 12:42:51 +0000 (13:42 +0100)]
[RELEASE] Release of TYPO3 9.5.2

Change-Id: Ib5214342439fd510cfd599d9880b1612ff9b4cc1
Reviewed-on: https://review.typo3.org/59115
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Adjust modal window processing and RequireJS loading 07/59107/5
Oliver Hader [Tue, 11 Dec 2018 11:46:40 +0000 (12:46 +0100)]
[BUGFIX] Adjust modal window processing and RequireJS loading

Resolves: #87123
Releases: master, 8.7, 7.6
Change-Id: Idceecb174682261b967ea284e12e1836bb7e7bea
Reviewed-on: https://review.typo3.org/59107
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Avoid DoS in Online Media Helper 05/59105/2
Oliver Hader [Tue, 11 Dec 2018 09:57:31 +0000 (10:57 +0100)]
[SECURITY] Avoid DoS in Online Media Helper

Using large media files (*.youtube, *.vimeo in the TYPO3 core)
might lead to denial of service scenarios. In order to avoid
that, media files are limited to have a content size of 2048
bytes as a maximum. Usually these files contain just the remote
identifier - thus, ~20 bytes should have been sufficient already.

Resolves: #85381
Releases: master, 8.7, 7.6
Security-Commit: 36c64c45461dee1c4018b7c72a989952d1e2dd45
Security-Bulletin: TYPO3-CORE-SA-2018-011
Change-Id: Ib54cd9ab822ee33a44170822cc0a3c4da4132c95
Reviewed-on: https://review.typo3.org/59105
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Remove TYPO3 version from installer 04/59104/2
Benni Mack [Tue, 11 Dec 2018 09:57:24 +0000 (10:57 +0100)]
[SECURITY] Remove TYPO3 version from installer

When installing TYPO3, the current version
is shown without any kind of authentication
provided (no FIRST_INSTALL). This information
disclosure is solved.

Resolves: #86254
Releases: master, 8.7, 7.6
Security-Commit: a69d09ab4eabd0474f0191f5daf525d91ebaa32f
Security-Bulletin: TYPO3-CORE-SA-2018-010
Change-Id: Ib8359937716dce4839d76b054b0d0d549bd4aa0c
Reviewed-on: https://review.typo3.org/59104
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Make InstallTool session cookie HTTP-only 03/59103/2
Andreas Wolf [Tue, 11 Dec 2018 09:57:18 +0000 (10:57 +0100)]
[SECURITY] Make InstallTool session cookie HTTP-only

Resolves: #86955
Releases: master, 8.7, 7.6
Security-Commit: d251175e031aaa9943f93f5e5297f5490b99e513
Security-Bulletin: TYPO3-CORE-SA-2018-009
Change-Id: Ia50cac61ee2d649e98cba2102162c1360487bb20
Reviewed-on: https://review.typo3.org/59103
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Prevent XSS with fe_users data in felogin/TSFE 02/59102/2
Benni Mack [Tue, 11 Dec 2018 09:57:11 +0000 (10:57 +0100)]
[SECURITY] Prevent XSS with fe_users data in felogin/TSFE

Two occurrences allow to render data of the currently logged in
frontend user that is not sanitized and thus allow XSS attacks
by frontend users.

1. EXT:fe_login adds ###FEUSER_{fieldname}### for each
field that exists in the fe_users DB table, which CAN be processed
by TypoScript but is insecure by default.

2. config.USERNAME_substToken = <!--###USERNAME###-->
sets the username dynamically, which is then insecure.

Adding htmlspecialchars as a default configuration
solves this problem.

Resolves: #87053
Releases: master, 8.7, 7.6
Security-Commit: 1cc57f4aa7dfb5b1e3e4db581c57aacd69dd4d9d
Security-Bulletin: TYPO3-CORE-SA-2018-008
Change-Id: I72a1a4ea60f23c81016b87cbbd1ba63161c52df0
Reviewed-on: https://review.typo3.org/59102
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Prevent XSS in modal component and PageTree 01/59101/2
Frank Naegler [Tue, 11 Dec 2018 09:57:05 +0000 (10:57 +0100)]
[SECURITY] Prevent XSS in modal component and PageTree

Resolves: #84190
Releases: master, 8.7, 7.6
Security-Commit: 0aaf266ae75d04efc6a943f9414448d5c2787309
Security-Bulletin: TYPO3-CORE-SA-2018-007
Change-Id: Ic5beb5217326d8f3d72445d4bf9cc7ace705a5a0
Reviewed-on: https://review.typo3.org/59101
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Properly escape videoId for YouTube/Vimeo 00/59100/2
Susanne Moog [Tue, 11 Dec 2018 09:56:58 +0000 (10:56 +0100)]
[SECURITY] Properly escape videoId for YouTube/Vimeo

Resolves: #83184
Releases: master, 8.7, 7.6
Security-Commit: c51313ed68970cd6d2f2172a0e3d74454cf05812
Security-Bulletin: TYPO3-CORE-SA-2018-006
Change-Id: Id982d4fc28e7817eeb88eb63f52dc3380365f3b1
Reviewed-on: https://review.typo3.org/59100
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Update library CKEditor to 4.11.1 99/59099/2
Benni Mack [Tue, 11 Dec 2018 09:56:50 +0000 (10:56 +0100)]
[SECURITY] Update library CKEditor to 4.11.1

CKEditor 4.11 was released including a XSS fix where
an attacker could add invalid HTML markup by switching
to the Source mode of CKEditor and back.

Used commands:
  cd Build/
  yarn add ckeditor#4.11.1 --dev
  grunt build

Resolves: #84800
Releases: master, 8.7
Security-Commit: 4a44c536a4f80b1fbf4599070761368e7919980c
Security-Bulletin: TYPO3-CORE-SA-2018-005
Change-Id: I50412f24393c306a989dac448d7c0ee66a6760fb
Reviewed-on: https://review.typo3.org/59099
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Check for valid FrontendInterface for page title cache 82/59082/2
Richard Haeser [Mon, 10 Dec 2018 21:33:56 +0000 (22:33 +0100)]
[BUGFIX] Check for valid FrontendInterface for page title cache

The PageTitleProviderManager will now check if the page cache object
is an instance of FrontendInterface before getting the value from cache.

Resolves: #87116
Releases: master
Change-Id: I14838b41a7cba653d5f4e6c875c647f547673644
Reviewed-on: https://review.typo3.org/59082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Respect GET parameters when generating canonicalized URLs 11/58611/22
Richard Haeser [Wed, 10 Oct 2018 21:49:03 +0000 (23:49 +0200)]
[BUGFIX] Respect GET parameters when generating canonicalized URLs

Add current query string to the generated canonicalized URL to make the
hreflang and canonical work with additional parameters as well.

Parameters that are excluded from cache hash generation and not included
in $GLOBALS['TYPO3_CONF_VARS']['FE']['additionalCanonicalizedUrlParameters'],
are excluded from the canonicalized URL.

Resolves: #86577
Resolves: #86866
Resolves: #86865
Releases: master
Change-Id: Ib574e2f6c7aa869b4ffa798c7122a60f4cf13f13
Reviewed-on: https://review.typo3.org/58611
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Add default icon overlay fields to rootline 30/59030/4
Tim Karliczek [Tue, 4 Dec 2018 17:27:34 +0000 (18:27 +0100)]
[TASK] Add default icon overlay fields to rootline

Add fields, which modify page icon rendering,
to default field list of rootline page requests.
Ensures more detailed rendering of page status icons
in FLUID using ViewHelper core:iconForRecord

Resolves: #87076
Releases: master
Change-Id: I11adbaa627c77ceaaa23ca28229510cb19936ad3
Reviewed-on: https://review.typo3.org/59030
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add proper scope for styling of DebugExceptionHandler 70/58870/4
Georg Ringer [Wed, 7 Nov 2018 22:35:16 +0000 (23:35 +0100)]
[BUGFIX] Add proper scope for styling of DebugExceptionHandler

The styling of the debug output is "namespaced" with `.exception-page`
to avoid influencing other CSS definitions.

Resolves: #86879
Releases: master
Change-Id: I5561b7995826abfd5e1ea53b2b31b30b19c2f208
Reviewed-on: https://review.typo3.org/58870
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Poerschke <markus@poerschke.nrw>
Tested-by: Markus Poerschke <markus@poerschke.nrw>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Accept Unicode characters in email spam protection 33/59033/8
Oliver Bartsch [Tue, 4 Dec 2018 22:50:50 +0000 (23:50 +0100)]
[BUGFIX] Accept Unicode characters in email spam protection

Use multibyte handling to properly process all Unicode characters for
the spam protection email address handling.

Resolves: #87071
Releases: master
Change-Id: I9fec60c000a202ae34927ec4917e29e2d0e64a5c
Reviewed-on: https://review.typo3.org/59033
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Display exact error message of handlePageError() 26/59026/7
Peter Kraume [Tue, 4 Dec 2018 14:15:01 +0000 (15:15 +0100)]
[TASK] Display exact error message of handlePageError()

Show getUrl() error message when fetching content of error page.

Resolves: #87073
Releases: master
Change-Id: I9b2d548fc1d9a4bd07ea56c7d5776447c0c596d2
Reviewed-on: https://review.typo3.org/59026
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Ignore wizards with no upgrades in report 48/59048/2
Alexander Stehlik [Thu, 6 Dec 2018 21:57:39 +0000 (22:57 +0100)]
[BUGFIX] Ignore wizards with no upgrades in report

The reports module now ignores upgrade wizards that do
not have any necessary upgrades (shouldRenderWizard property
is false).

This makes the behavior fully consistent with the install tool
because there the wizards that should not be rendered are not
displayed either.

Resolves: #86632
Releases: master
Change-Id: I87caf45023a0ca4eca71418e029bc8ed7091c0e4
Reviewed-on: https://review.typo3.org/59048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Remove composer max update from regular randomizer 60/59060/4
Anja Leichsenring [Sat, 8 Dec 2018 10:20:47 +0000 (11:20 +0100)]
[BUGFIX] Remove composer max update from regular randomizer

Fix a nightly test setup for a wrong composer dependency
in "main" stage. Disable the phpunit randomizer in
"composer update max" stage for now since young phpunit
collides with our current randomizer call.

Change-Id: I4a5d9cd3eea1686969fe0185433a2384aad87a90
Resolves: #87106
Releases: master
Reviewed-on: https://review.typo3.org/59060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Simplify bamboo variable to label handling 63/59063/2
Christian Kuhn [Sat, 8 Dec 2018 13:52:56 +0000 (14:52 +0100)]
[TASK] Simplify bamboo variable to label handling

Intercept has been adapted, the variable to label handing
can be simplified a bit.

Resolves: #87109
Releases: master, 8.7, 7.6
Change-Id: I27255ef9f5eb515c89f5d89e7061fc473e2abec1
Reviewed-on: https://review.typo3.org/59063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Do not resolve languageFilePath to absolutePath 24/59024/7
Achim Fritz [Tue, 4 Dec 2018 11:06:54 +0000 (12:06 +0100)]
[BUGFIX] Do not resolve languageFilePath to absolutePath

Resolving the path here breaks the localization Override
in the LocalizationFactory Class

Resolves: #86683
Releases: master
Change-Id: Ib7037bcfba0dd02cf46c1b31f98d7808e7974b3c
Reviewed-on: https://review.typo3.org/59024
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Avoid overwriting page context in TSFE->cObj by f:cObject 61/58661/11
Thorben Nissen [Fri, 19 Oct 2018 09:03:58 +0000 (11:03 +0200)]
[BUGFIX] Avoid overwriting page context in TSFE->cObj by f:cObject

Change `CObjectViewHelper::getContentObjectRenderer` to return a new
instance of `ContentObjectRenderer` instead of returning a reference to
`TSFE->cObj`.

Change unit test and add prepared instance of `ContentObjectRenderer`
to `GeneralUtility` via `addInstance` method.

Resolves: #86979
Releases: master
Change-Id: Ibdb8fd1d974a525f3583929a743447a8650ca1ab
Reviewed-on: https://review.typo3.org/58661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Swap mixed up labels in admin panel page cache info 80/58980/3
Nikita Hovratov [Thu, 29 Nov 2018 13:18:45 +0000 (14:18 +0100)]
[BUGFIX] Swap mixed up labels in admin panel page cache info

Due to the fact that the translation keys for the page cache info
were double negated (noCache_no = yes) they ended up being mixed up.
This patch just swaps the labels. In v10 the keys can be renamed to
prevent confusion.

Resolves: #87039
Releases: master
Change-Id: I34f4d3aa2c0d659eee5c99c8df092260bcef7f5b
Reviewed-on: https://review.typo3.org/58980
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add full configuration to SiteLanguage::toArray 25/59025/4
Georg Ringer [Tue, 4 Dec 2018 12:28:19 +0000 (13:28 +0100)]
[TASK] Add full configuration to SiteLanguage::toArray

Make the full configuration of a SiteLanguage available. This is required
to get access to an extended site language configuration.

To be in sync to the Site object, the property attributes is renamed to
configuration.

Resolves: #87027
Releases: master
Change-Id: I8962c5f7cafb38398bf9ded77058af38828e7182
Reviewed-on: https://review.typo3.org/59025
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Fix nested arrays in conditions 35/58935/9
Wolfgang Klinger [Fri, 23 Nov 2018 12:23:25 +0000 (13:23 +0100)]
[BUGFIX] Fix nested arrays in conditions

The RequestWrapper::getParsedBody method must return an array,
otherwise the a condition like [request.getParsedBody()['foo'] == 1]
results in a silent exception if the body is empty.

ConditionMatcher::normalizeExpression is now using an advanced regex
to handle multiple [] parts correctly.

Resolves: #86915
Releases: master
Change-Id: Ia3f951d1a3994d545025691e35521ca05b97a39a
Reviewed-on: https://review.typo3.org/58935
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Raphael Graf <r@undefined.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Styling of TCA description text with custom css selector 51/59051/4
Joerg Boesche [Fri, 7 Dec 2018 12:09:11 +0000 (13:09 +0100)]
[BUGFIX] Styling of TCA description text with custom css selector

Resolves: #87097
Releases: master
Change-Id: I1a6415c5b43e478ac90bb5f2db4437fb498fc568
Reviewed-on: https://review.typo3.org/59051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Florian Peters <fpeters1392@googlemail.com>
Tested-by: Florian Peters <fpeters1392@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Mark changes in `selectMultipleSideBySide` 56/59056/2
Andreas Fernandez [Fri, 7 Dec 2018 18:50:39 +0000 (19:50 +0100)]
[BUGFIX] Mark changes in `selectMultipleSideBySide`

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Resolves: #87082
Releases: master, 8.7
Change-Id: I9f50576270db667751c14e3513d1a7cd31c1135e
Reviewed-on: https://review.typo3.org/59056
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Set active tab when DOM is ready 55/59055/2
Andreas Fernandez [Fri, 7 Dec 2018 18:01:27 +0000 (19:01 +0100)]
[BUGFIX] Set active tab when DOM is ready

The latest used tab must be set to active only when the DOM has been
loaded.

Resolves: #84027
Releases: master
Change-Id: I52c8c190c5e58f1793335470427fc18203e4c561
Reviewed-on: https://review.typo3.org/59055
Reviewed-by: Florian Peters <fpeters1392@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Florian Peters <fpeters1392@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update package `doctrine/instantiator` 24/58924/3
Romain Canon [Wed, 21 Nov 2018 15:03:21 +0000 (16:03 +0100)]
[TASK] Update package `doctrine/instantiator`

In parallel to TYPO3, in order to require the package
`doctrine/orm:^2.6.0` (and further), the package `doctrine/instantiator`
must be required at least with version `1.1.0`.

Used composer command: `composer req doctrine/instantiator:^1.0`

Resolves: #86965
Releases: master
Change-Id: I473caa015bc1d6431654cbb889148cd396e7412b
Reviewed-on: https://review.typo3.org/58924
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Großberger <garfieldius67@gmail.com>
Tested-by: Georg Großberger <garfieldius67@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Prevent double pointer parameter in record list 54/58954/2
Vladimir Falcon Piva [Mon, 26 Nov 2018 14:59:06 +0000 (15:59 +0100)]
[BUGFIX] Prevent double pointer parameter in record list

This fix makes sure that the pointer parameter is added just once into
the record list pagination urls

Resolves: #87007
Releases: master, 8.7
Change-Id: I6db00dd0af0d09277aa9a005e561330acb386809
Reviewed-on: https://review.typo3.org/58954
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Revert UrlEncoding for GeneralUtility functions 56/58956/5
Anja Leichsenring [Mon, 26 Nov 2018 20:42:34 +0000 (21:42 +0100)]
[BUGFIX] Revert UrlEncoding for GeneralUtility functions

URLencoding applied to linkThisScript and linkThisUrl make
links fail that are only used and executed by Javascript.
Reverting to old behavior fixes the failure.

Change-Id: I992c9c362190bb7d4f6135bab059fd7ec058d2bb
Resolves: #87010
Relates: #83334
Releases: master
Reviewed-on: https://review.typo3.org/58956
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Tim Karliczek <tkarliczek@3pc.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Add missing translation value for Modals 48/58948/8
Preben Rather Sørensen [Sun, 25 Nov 2018 19:47:00 +0000 (20:47 +0100)]
[BUGFIX] Add missing translation value for Modals

Changes syntax for translation key and add default language value.

Resolves: #87001
Releases: master, 8.7
Change-Id: I5a634aff013f6d4af68f25b8288ed04bc340e823
Reviewed-on: https://review.typo3.org/58948
Reviewed-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Disable file compression for external urls in js and css includes 67/58867/3
Benjamin Kott [Wed, 7 Nov 2018 16:45:19 +0000 (17:45 +0100)]
[BUGFIX] Disable file compression for external urls in js and css includes

Resolves: #53123
Releases: master, 8.7
Change-Id: I8030e434a27ae2f2c5934706eec6f64e64e31cd3
Reviewed-on: https://review.typo3.org/58867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] PageLayoutView - Keep copy settings if disabled 16/59016/7
André Schließer [Mon, 3 Dec 2018 12:37:27 +0000 (13:37 +0100)]
[BUGFIX] PageLayoutView - Keep copy settings if disabled

Disable copy option if setting mod.web_layout.localization.enableCopy = 0
in all cases.

As a newly translated page has no copies or translations this variable
will be false and this results in $allowCopy = true.
To disable the copy mode the initial setting $allowCopy
is taken into account.

Resolves: #76910
Releases: master
Change-Id: I38f16a11038885c1ba0d455d7913d729e9669817
Reviewed-on: https://review.typo3.org/59016
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[FEATURE] Allow replacing strings in slug 51/58851/16
Georg Ringer [Tue, 6 Nov 2018 06:46:33 +0000 (07:46 +0100)]
[FEATURE] Allow replacing strings in slug

The new setting `replacement` makes it possible to search and replace
strings inside a slug.

Resolves: #86740
Releases: master
Change-Id: Icc8fe167fcb5d48502ace2c43e0535884bc10341
Reviewed-on: https://review.typo3.org/58851
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName() 49/59049/3
Andreas Fernandez [Fri, 7 Dec 2018 10:53:08 +0000 (11:53 +0100)]
[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName()

Resolves: #87096
Releases: master, 8.7
Change-Id: I0a46420cb910d19223a8bb133d9e7457fbd29ee2
Reviewed-on: https://review.typo3.org/59049
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add missing RsT about existing language update tasks 34/59034/2
Josef Glatz [Wed, 5 Dec 2018 05:24:50 +0000 (06:24 +0100)]
[TASK] Add missing RsT about existing language update tasks

Add info about the manual steps to remove an existing
and add a working language:update scheduler task which
is necessary after an upgrade to TYPO3 >= 9.2

Releases: master
Resolves: #87081
Change-Id: I0970011b972239d3ebab50d6d06b1f8e33e099f5
Reviewed-on: https://review.typo3.org/59034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>