Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Fix position of TCEforms required field icon 68/31368/2
Frans Saris [Wed, 25 Jun 2014 08:08:17 +0000 (10:08 +0200)]
[BUGFIX] Fix position of TCEforms required field icon

If a palette is placed directly after a form field the icon to
open the pallete is placed inside the formfield wrapper. As result
the position of the required field icon is wrong.

This patch moves the palette icon outside of the wrapper.

Resolves: #59865
Releases: 6.2, 6.3
Change-Id: I35a3d4728a0dfb5ed315731366cc5ca04a7aa87e
Reviewed-on: https://review.typo3.org/31368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incomplete mock in ext:install 62/31362/2
Christian Kuhn [Sat, 5 Jul 2014 16:01:21 +0000 (18:01 +0200)]
[BUGFIX] Incomplete mock in ext:install

"ExtensionCompatibilityTesterTests" triggers loadBaseTca() that
loads TCA and TCA overrides of all active packages. Since the
unit test package manager activates all extensions found, this
may lead to unexpected effects with extensions hanging around
in typo3conf/ext.
The patch creates a backup of the package manager and mocks it
properly in some tests.

Change-Id: Ia5b1ccb449f1611837e6436cab226820b22a9047
Resolves: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31362
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warning in addPlugin() 61/31361/2
Christian Kuhn [Sat, 5 Jul 2014 16:10:42 +0000 (18:10 +0200)]
[BUGFIX] Warning in addPlugin()

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31361
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Clean up buildBaseTcaFromSingleFiles() 60/31360/2
Christian Kuhn [Sat, 5 Jul 2014 16:07:17 +0000 (18:07 +0200)]
[TASK] Clean up buildBaseTcaFromSingleFiles()

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31360
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Removed clickMenu code around header icon in info window 58/31358/2
Frans Saris [Thu, 19 Jun 2014 15:58:41 +0000 (17:58 +0200)]
[BUGFIX] Removed clickMenu code around header icon in info window

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/31358
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides. 52/31352/2
Anja Leichsenring [Tue, 10 Jun 2014 19:01:45 +0000 (21:01 +0200)]
[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31352
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides 51/31351/2
Anja Leichsenring [Fri, 20 Jun 2014 14:57:30 +0000 (16:57 +0200)]
[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31351
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Empty class selector crashes Update image 50/31350/2
Francois Suter [Fri, 27 Jun 2014 13:40:35 +0000 (15:40 +0200)]
[BUGFIX] Empty class selector crashes Update image

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31350
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup EXT:version 49/31349/2
Wouter Wolters [Sun, 22 Jun 2014 20:56:32 +0000 (22:56 +0200)]
[TASK] Cleanup EXT:version

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31349
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Updating deactivated extensions installs them 48/31348/2
Nicole Cordes [Fri, 4 Jul 2014 22:59:48 +0000 (00:59 +0200)]
[BUGFIX] Updating deactivated extensions installs them

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31348
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides. 47/31347/2
Jost Baron [Mon, 9 Jun 2014 10:15:55 +0000 (12:15 +0200)]
[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.3,6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/31347
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename 46/31346/2
Jost Baron [Tue, 1 Jul 2014 12:22:31 +0000 (14:22 +0200)]
[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31346
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Use string as constant name in FormProtectionFactory. 45/31345/2
Jost Baron [Tue, 1 Jul 2014 12:31:35 +0000 (14:31 +0200)]
[BUGFIX] Use string as constant name in FormProtectionFactory.

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31345
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides. 41/31341/2
Anja Leichsenring [Tue, 10 Jun 2014 20:10:03 +0000 (22:10 +0200)]
[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I789ea89318d76d0c709229139b0f5296042cded7
Resolves: #59466
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31341
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides 42/31342/2
Anja Leichsenring [Fri, 20 Jun 2014 15:04:19 +0000 (17:04 +0200)]
[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I1f92a7b536ffb19d30bb580ea30452fc488cd0f6
Resolves: #59705
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31342
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides. 43/31343/2
Anja Leichsenring [Tue, 10 Jun 2014 18:52:23 +0000 (20:52 +0200)]
[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Idb1be39c754d5566e52623103477b94887077cdb
Resolves: #59463
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30648
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 57b9fd213897663b4c12d025375a8564cb7d60b2)
Reviewed-on: https://review.typo3.org/31343
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides 44/31344/2
Anja Leichsenring [Fri, 20 Jun 2014 09:46:16 +0000 (11:46 +0200)]
[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I7b5240eccde3d49531bb734adf26ee623829dc59
Resolves: #59698
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30910
Reviewed-by: Olivier Dobberkau
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 920f93cc4a150c74e91a65d0309291327e600c39)
Reviewed-on: https://review.typo3.org/31344
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides 39/31339/2
Anja Leichsenring [Tue, 10 Jun 2014 19:56:42 +0000 (21:56 +0200)]
[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31339
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides 40/31340/2
Anja Leichsenring [Tue, 10 Jun 2014 20:31:58 +0000 (22:31 +0200)]
[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31340
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tooltip for a shortcut in list view shows id=0 37/31337/2
Wouter Wolters [Fri, 4 Jul 2014 19:02:17 +0000 (21:02 +0200)]
[BUGFIX] Tooltip for a shortcut in list view shows id=0

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 683ae94fb8bdf022981c9045c81e37149c32160e)
Reviewed-on: https://review.typo3.org/31337

5 years ago[BUGFIX] Give extension key to addPlugin() in registerPlugin() 36/31336/2
Christian Kuhn [Sat, 5 Jul 2014 11:44:19 +0000 (13:44 +0200)]
[BUGFIX] Give extension key to addPlugin() in registerPlugin()

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31336
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Unit tests to addPlugin() 35/31335/2
Anja Leichsenring [Sat, 5 Jul 2014 11:51:35 +0000 (13:51 +0200)]
[TASK] Unit tests to addPlugin()

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31335
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix property access for ObjectStorage 14/31314/2
Markus Klein [Mon, 9 Jun 2014 10:02:51 +0000 (12:02 +0200)]
[BUGFIX] Fix property access for ObjectStorage

When enabling access to the content of ObjectStorages by
integer number, it was overlooked that property access might
be desired too, which has also been working before.

Fix this by not aborting the access when addressing a
non-integer property on ObjectStorages.

Resolves: #59412
Releases: 6.3, 6.2
Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e
Reviewed-on: https://review.typo3.org/31314
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix usergroup condition in user TSconfig 51/31151/2
Markus Klein [Tue, 24 Jun 2014 14:18:59 +0000 (16:18 +0200)]
[BUGFIX] Fix usergroup condition in user TSconfig

usergroup conditions in user TSconfig are currently failing as
the list of groups the user is part of, is not yet compiled when
the TSconfig is evaluated.

This can be fixed by moving the group evaluation some lines upwards,
as this does not influence the remaining code.

Resolves: #59813
Releases: 6.3, 6.2, 6.1
Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0
Reviewed-on: https://review.typo3.org/31151
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Two png files should have filemode 664 95/31295/2
Martin Bless [Wed, 2 Jul 2014 16:33:24 +0000 (18:33 +0200)]
[BUGFIX] Two png files should have filemode 664

Resolves: #60065
Releases: 6.3,6.2
Change-Id: I27917fed2a65f9810176b4afa716e8e752d7eff1
Reviewed-on: https://review.typo3.org/31295
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create a Getter for CacheManager inside Datahandler 89/31289/3
Stefano Kowalke [Wed, 2 Jul 2014 11:26:16 +0000 (13:26 +0200)]
[TASK] Create a Getter for CacheManager inside Datahandler

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Resolves: #60059
Releases: 6.2, 6.3
Change-Id: I9f83ec017da94778e542410cc9d03faacddc245c
Reviewed-on: https://review.typo3.org/31289
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Workspace not always applied in RelationHandler queries 86/31286/2
Oliver Hader [Wed, 2 Jul 2014 09:28:32 +0000 (11:28 +0200)]
[BUGFIX] Workspace not always applied in RelationHandler queries

The possibly submitted value to RelationHandler::setWorkspaceId()
is not used for SQL queries to read IRRE foreign field relations.
In that case the current $BE_USER->workspace value is used which
might be different to the requested workspace id.

Resolves: #60053
Releases: 6.2, 6.3
Change-Id: Ib01e4df798ff2e1fcc8c29997f6effb814dc4344
Reviewed-on: https://review.typo3.org/31286
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Create workspace label placeholder that matches field conditions 83/31283/2
Sascha Egerer [Wed, 7 Aug 2013 17:10:04 +0000 (19:10 +0200)]
[BUGFIX] Create workspace label placeholder that matches field conditions

If a workspace placeholder record is generated the field, that
is configured as label for a table, is filled with a placeholder.
This is a hardcoded string.
If database field does not allow strings (integer, double...)
a TYPO3 warning is displayed. "... Propably value mismatch ...".
This message is very confusing because the user does not know
where it comes from.

The label should be evaluated against the TCA eval configuration
before it is written to the database.

Resolves: #31757
Releases: 6.3, 6.2, 6.1
Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9
Reviewed-on: https://review.typo3.org/31283
Reviewed-by: Oliver Hader
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
5 years ago[BUGFIX] IRRE records are listed comma separated 81/31281/2
Thomas Löffler [Fri, 20 Jun 2014 19:15:14 +0000 (21:15 +0200)]
[BUGFIX] IRRE records are listed comma separated

IRRE records with foreign_field instead of MM table
are now listed as a comma separated list instead
of wrongly using the number of records as the UID.

Change-Id: Ib1434561ee823d931cc983e103fb58490ca83719
Resolves: #59671
Releases: 6.3,6.2
Reviewed-on: https://review.typo3.org/31281
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char 76/31276/2
Frans Saris [Fri, 27 Jun 2014 19:49:26 +0000 (21:49 +0200)]
[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Resolves: #59950
Releases: 6.3, 6.2
Change-Id: I65d89ab741ae77f5bbef9421923b3878f2295570
Reviewed-on: https://review.typo3.org/31276
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix RTE width 74/31274/2
Markus Klein [Fri, 20 Jun 2014 16:58:45 +0000 (18:58 +0200)]
[BUGFIX] Fix RTE width

edit_wideDocument option has been removed with #57295 but it was forgotten
to adjust RTE accordingly.

Wide screens are default now, so we remove the check for this option
also in RTE. Furthermore the settings for small screens are superfluous
too.

Documentation is adjusted as well.

Resolves: #59692
Releases: 6.3, 6.2
Change-Id: I9bb5fc2a892f3de446137856e9fa18317f40b5c1
Reviewed-on: https://review.typo3.org/31274
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add action selector in toolbar in workspaces menu 73/31273/2
Oliver Hader [Thu, 26 Jun 2014 09:42:45 +0000 (11:42 +0200)]
[TASK] Add action selector in toolbar in workspaces menu

Currently there are two selectors in the bottom toolbar of
the workspace module. One to handle stage changes on selected
elements and one for mass actions (publish, swap, discard) for
the whole workspace. To circumvent this, an additional selector
shall be added for record selections.

Resolves: #59898
Releases: 6.2, 6.3
Change-Id: I5991cc16a65ba5ac473ec380f534379ec925cad3
Reviewed-on: https://review.typo3.org/31273
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Update phpdoc for all FormEngine members 72/31272/2
Markus Klein [Sat, 21 Jun 2014 23:17:20 +0000 (01:17 +0200)]
[CLEANUP] Update phpdoc for all FormEngine members

Furthermore ensure the initial values are correct.
All usages of the members have been checked such that no violation can
happen if the initial values have been modified.

This patch contains no change in functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I4566849bb930535b9fef8d38dba940d6a6fd86cc
Reviewed-on: https://review.typo3.org/31272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] FormEngine: Use getters for global objects 71/31271/2
Markus Klein [Sat, 21 Jun 2014 22:29:21 +0000 (00:29 +0200)]
[CLEANUP] FormEngine: Use getters for global objects

Introduce getters for global objects like TYPO3_DB or LANG.
This patch does not change any functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: Ia9a4f3adc656927467f2f51207396d9a41befe8c
Reviewed-on: https://review.typo3.org/31271
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Let live search use getRecordTitle 47/31247/3
Markus Klein [Sat, 28 Jun 2014 17:03:28 +0000 (19:03 +0200)]
[BUGFIX] Let live search use getRecordTitle

Live search uses the label configuration from TCA to get the title of a
record. An existing TODO note already suggests to use the method for
this from BackendUtility. Do this now.

Resolves: #59893
Resolves: #59957
Releases: 6.3, 6.2
Change-Id: Ic4aaabed47922863602e770b588fb8dacd9386de
Reviewed-on: https://review.typo3.org/31247
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue() 69/31269/2
Markus Klein [Mon, 30 Jun 2014 11:06:42 +0000 (13:06 +0200)]
[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue()

BackendUtility::getProcessedValue() fails to initialize a variable which
causes a PHP warning on array access.

Fix this by initializing the variable to array properly.

Resolves: #59994
Releases: 6.3, 6.2
Change-Id: I26711b512a9a7fad40000de6f2de6a2b4a81ac75
Reviewed-on: https://review.typo3.org/31269
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Show errors on distribution installation 68/31268/2
Sascha Egerer [Mon, 30 Jun 2014 09:36:00 +0000 (11:36 +0200)]
[BUGFIX] Show errors on distribution installation

When you install a distribution and an error occurred, you get a fluid
error: "Sorry, the requested view was not found."

There is currently no template / view for the action. This patch renders
the error messages as flash messages and redirects to the list view of
distributions where the errors are shown.

Resolves: #59564
Resolves: #59952
Releases: 6.3, 6.2
Change-Id: Ie0e055dfd5620d4e0a08ecf87b2f458e7877ee76
Reviewed-on: https://review.typo3.org/31268
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use correct array structure for EM error messages 67/31267/2
Sascha Egerer [Mon, 30 Jun 2014 09:27:51 +0000 (11:27 +0200)]
[BUGFIX] Use correct array structure for EM error messages

The extension manager stores errors (like exceptions that
are thrown while installing an extension) in an array and
passes them to a fluid template.

The array has to be in a defined structure like
$errorMessages[extension name][i] = array(
»       error code,
»       error message
)

Currently, if an extension is installed from ter and an error occurs
while downloading the extension, the code and text are stored directly
under the extension name and therefore the array is not correctly parsed
by the fluid template.

Resolves: #59991
Releases: 6.3, 6.2
Change-Id: Id330f0af2a99ab99cb8b736332cb8506c857716c
Reviewed-on: https://review.typo3.org/31267
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Re-work/simplify copyright header in JS files 48/31248/2
Michael Schams [Fri, 27 Jun 2014 02:18:19 +0000 (12:18 +1000)]
[TASK] Re-work/simplify copyright header in JS files

This patch replaces the copyright/license header in JS files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

Resolves: #59916
Releases: 6.3, 6.2
Change-Id: I312bd9682fc1cf30ec327ba5d17567a3e9609c7d
Reviewed-on: https://review.typo3.org/31164
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 1ae7b94b86a64ab6a86d7417a5dfb1f19777ee75)
Reviewed-on: https://review.typo3.org/31248

5 years ago[BUGFIX] Unique IDs for pagetree root nodes 46/31246/2
Alexander Stehlik [Fri, 21 Mar 2014 18:06:33 +0000 (19:06 +0100)]
[BUGFIX] Unique IDs for pagetree root nodes

To make sure that every ID in the pagetree is unique in pagetrees
with a virtual root node (which is used for normal editors) the
page UIDs of the webmounts are set in the mountpoint property of
the tree nodes. This makes sure that all tree node ids are unique.

Resolves: #57163
Releases: 6.3, 6.2
Change-Id: Ia938a9bf4839524d60056d55c0186196dbd11289
Reviewed-on: https://review.typo3.org/31246
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years agoRevert "[TASK] Rebuild the calcAge functionality" 37/31237/5
Christian Kuhn [Sun, 29 Jun 2014 21:25:14 +0000 (23:25 +0200)]
Revert "[TASK] Rebuild the calcAge functionality"

This change was considered to need some more work during
merge post review:
* 6.2 version adds not allowed deprecations to a released branch
* It adds two arbitrary (public) constants CEIL and FLOOR
* Method names need improvement
* Violation of single responsibility
* The static utility class has dependencies
* The patch adds another "always loaded" file to main bootstrap
* Undocumented (minor) breaking changes
* (Minor) code style issues

Reverted: #20016
Releases: 6.3, 6.2

This reverts commit 4c52cb3cfe4f6819a29f1daa064859affe23989d
Change-Id: I6dff8aaa8bf8cfdb80cca56c9c967f2a2ea6fb52
Reviewed-on: https://review.typo3.org/31237
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove TCA building aspect and move code to bootstrap 34/31234/2
Christian Kuhn [Sat, 21 Jun 2014 16:25:04 +0000 (18:25 +0200)]
[TASK] Remove TCA building aspect and move code to bootstrap

The patch moves the slot code that implements the override loading
logic back to the bootstrap but keeps the signal.

Resolves: #59770
Related: #59414
Related: #59468
Releases: 6.3, 6.2
Change-Id: Ib4691eaa94f258ebd96f2609fb267cadc8356090
Reviewed-on: https://review.typo3.org/31234
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add extension key to API 35/31235/2
Helmut Hummel [Sun, 29 Jun 2014 18:19:35 +0000 (20:19 +0200)]
[TASK] Add extension key to API

Instead of relying on a "magic" global $_EXTKEY
being set, add a new parameter to API where
this was used beforehand.

Resolves: #59770
Releases: 6.2, 6.3
Change-Id: I531bb6067d79aa42c9c592e88f3564dc7f40b29d
Reviewed-on: https://review.typo3.org/31235
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Rebuild the calcAge functionality 31/31231/2
Alexander Opitz [Sat, 12 Oct 2013 14:36:25 +0000 (16:36 +0200)]
[TASK] Rebuild the calcAge functionality

We have two calcAge functions with same functionality and same issues.
So this is moved to a new DateTimeUtility class and deprecated in the
the original classes. Also time functions from GeneralUtility are moved
to the new class.

Following issues are resolved:
* Age calculation does not respect leap years.
* Age calculation may round up so something seams older than it is.
* Between days and years there are months missing, so we get now 2 months
  instead of 60 days.

Resolves: #20016
Releases: 6.3, 6.2
Change-Id: Ie323f30b1fb97b68f89d43605ccda67f219a965a
Reviewed-on: https://review.typo3.org/31231
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Improve travis notifications to channels 24/31224/2
Helmut Hummel [Sun, 29 Jun 2014 12:00:15 +0000 (14:00 +0200)]
[TASK] Improve travis notifications to channels

By default travis notifies on each build when
posting to channels (irc, slack)

We can reduce the number of notifications by only
posting successful builds when it previously failed.

Additionally encrypt the API token for posting to slack.

Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I882d34903c972201454e6cc5b9041393e3bd3661
Reviewed-on: https://review.typo3.org/31224
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Create required directories in test bootstrap 19/31219/2
Sebastian Bergmann [Sun, 29 Jun 2014 10:07:05 +0000 (12:07 +0200)]
[BUGFIX] Create required directories in test bootstrap

When running the core unit tests without setting up TYPO3
using the normal installation procedure then the uploads,
typo3temp, and typo3conf/ext directories do not exist.

Resolves: #59977
Releases: 6.3,6.2
Change-Id: Ib6b8ecd480b83cf818f54d865a4ff61fe62d2893
Reviewed-on: https://review.typo3.org/31216
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f0803359e5b1b53fd626bd5d0a846b918c3afced)
Reviewed-on: https://review.typo3.org/31219

5 years ago[TASK] Update Travis CI notification settings 08/31208/2
Michael Stucki [Tue, 24 Jun 2014 08:27:07 +0000 (10:27 +0200)]
[TASK] Update Travis CI notification settings

Notify on Slack and IRC, remove email notification.

Resolves: #59838
Releases: 6.3, 6.2, 4.5
Change-Id: Ic4dacd5c7b6b4e6e2b8cfa92ae7976b666209747
Reviewed-on: https://review.typo3.org/31208
Reviewed-by: Nicole Cordes
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
5 years ago[BUGFIX] Fix insufficient mocking in ContentObjectRenderer 06/31206/2
Markus Klein [Sat, 28 Jun 2014 19:31:38 +0000 (21:31 +0200)]
[BUGFIX] Fix insufficient mocking in ContentObjectRenderer

Resolves: #59967
Releases: 6.3, 6.2
Change-Id: Ie30b8e522f9045c7cd6cbe9c032413c0ad936b1a
Reviewed-on: https://review.typo3.org/31206
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Gifbuilder: Fix image-mask-functionality 01/31201/2
Stefan Neufeind [Fri, 6 Jun 2014 14:10:26 +0000 (16:10 +0200)]
[BUGFIX] Gifbuilder: Fix image-mask-functionality

Mask-functionality is broken since the
introduction of FAL.

Change-Id: Iff28d9561e10f7581041bcc35bd56dfc972954b3
Resolves: #59392
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/31201
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add a function for clearing the rootline caches 99/31199/2
Oliver Klee [Tue, 13 May 2014 12:44:05 +0000 (14:44 +0200)]
[TASK] Add a function for clearing the rootline caches

The RootlineUtility uses two local caches and one additional cache from
the caching framework. If a unit test uses the RootlineUtility, it needs
a way of purging these caches so it does not change the environment.

Resolves: #58763
Releases: 6.3, 6.2, 6.1
Change-Id: Ia9878b808acfa03f018086829f90b84d4c5e8512
Reviewed-on: https://review.typo3.org/31199
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] BE shortcuts do not show up for editors 98/31198/2
Frans Saris [Fri, 27 Jun 2014 18:16:16 +0000 (20:16 +0200)]
[BUGFIX] BE shortcuts do not show up for editors

Due to some wrong or missing checks the link to create a shortcut
to a create new record form misses the correct name of the
"motherModName" as a result the shortcut links are not rendered
for non-admins. For admins these links do not work if PHP notices
are transformed to exceptions.

Resolves: #59946
Releases: 6.3, 6.2
Change-Id: I9acd74fd5dfefea62badc79e42e380466ce6c497
Reviewed-on: https://review.typo3.org/31198
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use stable phpunit 4.1 instead of master 82/31182/2
Christian Kuhn [Sat, 28 Jun 2014 12:01:42 +0000 (14:01 +0200)]
[TASK] Use stable phpunit 4.1 instead of master

We had to update to phpunit "master" recently due to an issue with
phpunit-mock-objects that was not released yet but fixed in master.
The fix was released with phpunit-mock-objects 2.1.5 today, so we
can switch back to a stable combination of those packages.

Resolves: #59958
Related: #59685
Releases: 6.3, 6.2
Change-Id: I92336adef0291239c7dad606002721c91b2991fa
Reviewed-on: https://review.typo3.org/31179
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ee2dd7719711ec3786a86d8ded7dc5a085a7d7e9)
Reviewed-on: https://review.typo3.org/31182

5 years ago[TASK] Add more files in gitignore file 47/31147/2
Fabien Udriot [Thu, 12 Jun 2014 08:00:44 +0000 (10:00 +0200)]
[TASK] Add more files in gitignore file

Whenever running the Functional Tests
directly from the Core, the framework requires
some additional folders that can be added
to the gitignore file.

More info about Functional Testing:
http://wiki.typo3.org/Functional_testing

Change-Id: If51851f32ebeda0eb6829dc3f16d87709904824a
Releases: 6.3, 6.2
Resolves: #59514
Reviewed-on: https://review.typo3.org/31147
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix RewriteRule for context to avoid HTTP 500 15/31115/2
Armin Ruediger Vieweg [Thu, 22 May 2014 14:07:53 +0000 (16:07 +0200)]
[BUGFIX] Fix RewriteRule for context to avoid HTTP 500

The affected rules are those for TYPO3_CONTEXT.
These rules should just set the ENV variable,
but should not touch the URL.
According to apache httpd docs this has to be
indicated by using a dash.

Also unnecessary grouping in the regexp has been
removed.

Resolves: #59037
Releases: 6.3, 6.2
Change-Id: I56cadcfb3cfae0a0ee679c6886cda9f5498fc47c
Reviewed-on: https://review.typo3.org/31115
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years agoRevert "[BUGFIX] Fix loading order for extensions" 98/31098/2
Markus Klein [Tue, 24 Jun 2014 01:12:29 +0000 (03:12 +0200)]
Revert "[BUGFIX] Fix loading order for extensions"

This reverts commit c0779513b431b19413873893bf630aa3de6fc1fc

The patch has two flaws:
 * Easy: packagePathStack also includes package folder which
         is incompatible to the excludedPaths search
 * Nightmare: Upon uninstalling extensions the PackageManager
         fails due to missing packagePathStack information

Change-Id: I27642b3dea7541cb5f7363172edff147d34999d1
Resolves: #59831
Reverts: #59147
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31098
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] FollowUp: Fix signal returns for associated signal arguments 73/31073/2
Marc Bastian Heinrichs [Mon, 23 Jun 2014 07:47:40 +0000 (09:47 +0200)]
[BUGFIX] FollowUp: Fix signal returns for associated signal arguments

Fix broken functional tests. Add a fallback for earlier used associated
returns. Furthermore this patch reintroduces referenced signal arguments
to support old registered slots.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Icfe997998476b9bdf77aba280eb87ca42786def8
Reviewed-on: https://review.typo3.org/31073
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix a JS error in with TCE select wizard 21/30821/3
Rémy DANIEL [Wed, 18 Jun 2014 15:38:32 +0000 (17:38 +0200)]
[BUGFIX] Fix a JS error in with TCE select wizard

Fixes an exception with decodeURI when an item containing
a % (percent) character is added to a select.
jQuery is now only used to append the option and its label to the DOM.

Resolves: #59655
Releases: 6.3, 6.2
Change-Id: I245f2fbec347b7e149aeea1cb7148591dc47e6f8
Reviewed-on: https://review.typo3.org/30821
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make Extbase respect sys_language_mode=strict 61/31061/2
Georg Ringer [Mon, 16 Jun 2014 17:40:52 +0000 (19:40 +0200)]
[BUGFIX] Make Extbase respect sys_language_mode=strict

The Extbase query parser currently doesn't respect strict language mode
because it doesn't consider records that are only present in a localized
language version, but not in the default language.

As a consequence, records only present in a localized language version
are not fetched at all while for counting/paging the count of the default
language version is used.

This change adds a check for strict language mode and additional query
parts to solve this issue.

Releases: 6.3, 6.2
Resolves: #47183
Change-Id: Ifb0ff6dda648fb4a686992ee6f7c00419a3ee934
Reviewed-on: https://review.typo3.org/31061
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Fix signal returns for associated signal arguments 58/31058/2
Nicole Cordes [Sun, 22 Jun 2014 10:36:42 +0000 (12:36 +0200)]
[BUGFIX] Fix signal returns for associated signal arguments

The call of the dispatcher functions doesn't allow associated signal
arguments as all arguments are passed as parameter to the slot function.
This patch removes all associated signal arguments and uses numeric
arrays.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Ie265c6c7dbf4c2b0972d3436164480bb741e15fa
Reviewed-on: https://review.typo3.org/31058
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 9 55/31055/2
Michael Schams [Sun, 22 Jun 2014 06:08:42 +0000 (16:08 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 9

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59785 for further details.

Resolves: #59785
Releases: 6.3, 6.2
Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e
Reviewed-on: https://review.typo3.org/31055
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 8 54/31054/2
Michael Schams [Sun, 22 Jun 2014 05:56:21 +0000 (15:56 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 8

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59784 for further details.

Resolves: #59784
Releases: 6.3, 6.2
Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d
Reviewed-on: https://review.typo3.org/31054
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 7 53/31053/2
Michael Schams [Sun, 22 Jun 2014 05:52:40 +0000 (15:52 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 7

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31053
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 6 52/31052/2
Michael Schams [Sun, 22 Jun 2014 05:49:03 +0000 (15:49 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 6

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59782 for further details.

Resolves: #59782
Releases: 6.3, 6.2
Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
Reviewed-on: https://review.typo3.org/31052
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 5 51/31051/2
Michael Schams [Sun, 22 Jun 2014 05:21:16 +0000 (15:21 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 5

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59781 for further details.

Resolves: #59781
Releases: 6.3, 6.2
Change-Id: I7429b8e9c507a4833215750268d1975402679828
Reviewed-on: https://review.typo3.org/31051
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 4 56/31056/2
Michael Schams [Sun, 22 Jun 2014 05:18:31 +0000 (15:18 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 4

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59780 for further details.

Resolves: #59780
Releases: 6.3, 6.2
Change-Id: I00eff31cdff19774527e3b1bb06e29152928414c
Reviewed-on: https://review.typo3.org/31056
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 3 50/31050/2
Michael Schams [Sun, 22 Jun 2014 05:14:02 +0000 (15:14 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 3

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59779 for further details.

Resolves: #59779
Releases: 6.3, 6.2
Change-Id: I30ad23ccfccd86ba9e98a3b46b11836c1628f499
Reviewed-on: https://review.typo3.org/31050
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 2 49/31049/2
Michael Schams [Sun, 22 Jun 2014 04:56:28 +0000 (14:56 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 2

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59778 for further details.

Resolves: #59778
Releases: 6.3, 6.2
Change-Id: I155df27e66ec103a4f83356adef7dc441585b54a
Reviewed-on: https://review.typo3.org/31049
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 1 48/31048/2
Michael Schams [Sun, 22 Jun 2014 04:12:59 +0000 (14:12 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 1

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59777 for further details.

Resolves: #59777
Releases: 6.3, 6.2
Change-Id: Idf5ef5a0da53dd052af54d42a115e951bc9d0e91
Reviewed-on: https://review.typo3.org/31048
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Merge GPL.txt and LICENSE.txt 47/31047/2
Markus Klein [Sun, 22 Jun 2014 10:55:58 +0000 (12:55 +0200)]
[TASK] Merge GPL.txt and LICENSE.txt

Resolves: #59535
Releases: 6.3, 6.2
Change-Id: Ia3c442ec4d838bd5c3b350a74ced3f90ef971a21
Reviewed-on: https://review.typo3.org/31047
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years agoRevert "[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler" 45/31045/2
Helmut Hummel [Sun, 22 Jun 2014 10:22:43 +0000 (12:22 +0200)]
Revert "[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler"

This introduced a regression. It turns out that it needs more work
to get all cases covered correctly.

Resolves: #58728
Reverts: #16472
Releases: 6.1, 6.2, 6.3
This reverts commit 9ab3b9b5dd96ae0f955277a8997abb4bd69a66ff

Change-Id: I395e052c1f31adde715f5a25f9d1716c092dd908
Reviewed-on: https://review.typo3.org/31045
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Introduce unique signal registration 37/31037/2
Nicole Cordes [Sat, 21 Jun 2014 17:48:50 +0000 (19:48 +0200)]
[TASK] Introduce unique signal registration

Signals should be dispatch in own emit functions for better locating.
This patch moves signals to separate functions and attaches missing
suffixes to existing ones.

Resolves: #59774
Releases: 6.3, 6.2
Change-Id: I7a1411566a78e326f1f870b2d345631e7ca265e0
Reviewed-on: https://review.typo3.org/31013
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-on: https://review.typo3.org/31037

5 years ago[BUGFIX] Fix loading order for extensions 21/31021/2
Markus Klein [Tue, 27 May 2014 15:36:45 +0000 (17:36 +0200)]
[BUGFIX] Fix loading order for extensions

Stick to the documented loading order of extensions.
That means following this order: sysext, global, local, composer

The same extension found in the latter will be loaded instead of
the former. Also adjust the Dependency resolver accordingly for the
edge-case of overwriting sysexts.

Resolves: #59147
Releases: 6.3, 6.2
Change-Id: I50c7849e32b309a28f792340f3ff892e516dadb8
Reviewed-on: https://review.typo3.org/31021
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[CLEANUP] Clean code in FormEngine 16/31016/2
Sebastian Michaelsen [Wed, 21 May 2014 13:01:58 +0000 (15:01 +0200)]
[CLEANUP] Clean code in FormEngine

\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:

* Import some classes to avoid unnecessary fully qualified class names
* Fix some PHPdoc issues
* Slightly adjust some method signatures
  (when 0, 1, or '' were used for boolean information)
* Remove some unused local variables

Resolves: #58995
Releases: 6.3, 6.2
Change-Id: Ic79acf80e75b78f9b8b70c946dd15e5b32996fb2
Reviewed-on: https://review.typo3.org/31016
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove misspelled setting rootlevel for sys_file_collection 11/31011/2
Marc Bastian Heinrichs [Sat, 21 Jun 2014 17:24:56 +0000 (19:24 +0200)]
[BUGFIX] Remove misspelled setting rootlevel for sys_file_collection

The correct setting would have been rootLevel. So it was never
evaluated, remove it.

Resolves: #59773
Releases: 6.3, 6.2, 6.1
Change-Id: I594924caed47c5c911def94524148354790b77b4
Reviewed-on: https://review.typo3.org/31011
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Signal for BackendUtility::getPagesTSconfig() 02/31002/2
Alexander Stehlik [Fri, 20 Jun 2014 11:58:23 +0000 (13:58 +0200)]
[TASK] Signal for BackendUtility::getPagesTSconfig()

A signal is dispatched in BackendUtility::getPagesTSconfig()
before the include lines are calculated.

This enables to supply additional PageTS for each page
programmatically, even in multi-site environments.

Releases: 6.3, 6.2
Resolves: #59703
Change-Id: I1cc1188eebbf6dee769c64a654339837e0cdce59
Reviewed-on: https://review.typo3.org/31002
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Prevent error message for correct imports of sys_file_metadata 87/30987/2
Marc Bastian Heinrichs [Thu, 15 May 2014 13:02:57 +0000 (15:02 +0200)]
[BUGFIX] Prevent error message for correct imports of sys_file_metadata

If sys_file_metadata records are updated on import, a wrong error message
is logged.

Resolves: #58826
Releases: 6.3, 6.2
Change-Id: I023306a69da9c725d52d076d196bf22178ff1f62
Reviewed-on: https://review.typo3.org/30987
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix empty globalString LIT condition comparison 85/30985/2
Marc Bastian Heinrichs [Wed, 4 Jun 2014 14:40:53 +0000 (16:40 +0200)]
[BUGFIX] Fix empty globalString LIT condition comparison

An empty "LIT:" condition results in NULL, so the strict compare
doesn't match with the empty string.

Solution is to cast the haystack to string before, like it was
done anyway later in the preg_match.

Releases: 6.3, 6.2, 6.1
Resolves: #59344
Change-Id: I1e4b00e454d921eedd0c03a1767d4ec57c321bd7
Reviewed-on: https://review.typo3.org/30985
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Don't ignore file imports in fallback storage 79/30979/2
Marc Bastian Heinrichs [Thu, 15 May 2014 16:22:44 +0000 (18:22 +0200)]
[BUGFIX] Don't ignore file imports in fallback storage

An export could contain sys_file records that are "stored" in the
fallback storage (ID 0). They must not be ignored.

Resolves: #58841
Releases: 6.3, 6.2
Change-Id: I39855810621310831ab1353c5e56f4529a7ac3aa
Reviewed-on: https://review.typo3.org/30979
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Treat link handler links as internal URLs 75/30975/2
Alexander Stehlik [Tue, 18 Feb 2014 09:55:05 +0000 (10:55 +0100)]
[BUGFIX] Treat link handler links as internal URLs

The RteHtmlParser will now check if a scheme found by parse_url()
matches a configured typolinkLinkHandler. If this is the case the
link will be treated as internal.

Resolves: #49036
Releases: 6.3, 6.2, 6.1
Change-Id: Ie4e6bded7a1c4d0c61e4f1a20bc23115612c1519
Reviewed-on: https://review.typo3.org/30975
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Raise recommended max nesting level 19/30919/2
Thomas Christiansen [Fri, 6 Jun 2014 13:37:06 +0000 (15:37 +0200)]
[TASK] Raise recommended max nesting level

Raise recommended max nesting level to 400 as
the current value of 250 does not suffice.

Resolves: #59391
Releases: 6.3, 6.2
Change-Id: Ibccb61991809e24baddb21bd46f190cd0b8d907d
Reviewed-on: https://review.typo3.org/30919
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Check for logged in user before showing cookie warning 18/30918/2
Tomita Militaru [Sat, 14 Jun 2014 11:52:38 +0000 (14:52 +0300)]
[BUGFIX] Check for logged in user before showing cookie warning

If a redirect for login error is setup, the warning cookie
message is displayed instead of redirecting.

Resolves: #59493
Releases: 6.3, 6.2
Change-Id: I2f63b6630863ece0704198f247980c4d6c08f65a
Reviewed-on: https://review.typo3.org/30918
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make Functional tests work on fast machines 14/30914/2
Tymoteusz Motylewski [Thu, 12 Jun 2014 14:02:20 +0000 (16:02 +0200)]
[BUGFIX] Make Functional tests work on fast machines

Adds more entropy to the uniqid() call. So each call inside
foreach loop will generate unique value.
As uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.

On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.

Resolves: #59529
Relates: #58602
Releases: 6.3, 6,2
Change-Id: I7476f85961e906905acaca7fd816e37375c9817c
Reviewed-on: https://review.typo3.org/30696
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 86c63e3be8888b1a065d0585bb4c94ff1498336b)
Reviewed-on: https://review.typo3.org/30914

5 years ago[BUGFIX] Get unit tests working again 06/30906/2
Markus Klein [Thu, 19 Jun 2014 18:10:15 +0000 (20:10 +0200)]
[BUGFIX] Get unit tests working again

Changed serialize behaviour in PHP triggers funny phpunit issues in
some tests. Switching to phpunit master for now and skipping some
tests makes travis-ci green again and gives us time for detail fixes.

Change-Id: I1c694c0c5dba98b31b9ef7c826fa6614ffa512df
Resolves: #59685
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30889
Reviewed-by: Christian Mueller
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ccc3e1fba54bbf2227b48a4cabafb14443bff74c)
Reviewed-on: https://review.typo3.org/30906

5 years ago[TASK] Increase Extension Manager->showConfiguration input field width 05/30905/2
Felix Kopp [Fri, 20 Jun 2014 08:51:18 +0000 (10:51 +0200)]
[TASK] Increase Extension Manager->showConfiguration input field width

Increases the width of string input fields to 300 pixels.

Resolves: #59679
Releases: 6.2, 6.3
Change-Id: Ia415a6cdf81e4f6192a7e3fb93d8f01d8a749c6a
Reviewed-on: https://review.typo3.org/30905
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Pass field name variable to flexform DS utility 90/30890/2
Claus Due [Mon, 9 Jun 2014 21:30:37 +0000 (23:30 +0200)]
[BUGFIX] Pass field name variable to flexform DS utility

A field name parameter is not being passed from within
DataHandler when copying a record which has a FlexForm
DF associated with it. This causes dynamic FlexForm DS
definitions to not be able to depend on the field name,
in turn causing the problem that an incorrect DS may be
returned from the DS utility which makes TYPO3 process
the data value incorrectly (for example, not detecting
file fields and processing the values accordingly).

To solve this the $field parameter is passed.

Resolves: #59423
Releases: 6.3, 6.2, 6.1
Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7
Reviewed-on: https://review.typo3.org/30890
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove warnings in ImportExportController.php 88/30888/2
Nicole Cordes [Mon, 5 May 2014 20:21:49 +0000 (22:21 +0200)]
[BUGFIX] Remove warnings in ImportExportController.php

This patch adds cleanup to prevent warnings when accessing the
import/export module.

Resolves: #58534
Releases: 6.3, 6.2
Change-Id: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b
Reviewed-on: https://review.typo3.org/30888
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Extension manager: default sorting for Extensions 86/30886/2
Felix Kopp [Sun, 15 Jun 2014 09:13:17 +0000 (11:13 +0200)]
[TASK] Extension manager: default sorting for Extensions

EM "Get Extension" does not show the awesome extension culture
that lives in the TER. Change sorting basically with the primary goal
to order extensions by update.

Resolves: #59583
Releases: 6.3, 6.2
Change-Id: Ie8aebc13c41427e0603fa5313b794996d01fbc44
Reviewed-on: https://review.typo3.org/30886
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Ensure that cli user is admin on extension install and uninstall 85/30885/2
Marc Bastian Heinrichs [Fri, 13 Jun 2014 14:24:57 +0000 (16:24 +0200)]
[TASK] Ensure that cli user is admin on extension install and uninstall

Extension install and uninstall is an admin task. Calling the belonging
CommandController on cli should ensure, that the user has admin
rights.

This adds API to the CommandController to avoid code duplication
in every controller to achieve this.

Distribution packages could be installed via cli without errors now.

Resolves: #59556
Releases: 6.3, 6.2
Change-Id: Icd1b6bf4379322c8bec07531a15d2171b103e076
Reviewed-on: https://review.typo3.org/30715
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-on: https://review.typo3.org/30885

5 years ago[BUGFIX] Fix RTE file links migration 82/30882/2
Markus Klein [Wed, 18 Jun 2014 15:07:19 +0000 (17:07 +0200)]
[BUGFIX] Fix RTE file links migration

Links in RTE might be stored as <LINK or <link.
Currently the upgrade wizards lacks support for <LINK.
Add this to the regular expression.

Resolves: #51800
Releases: 6.3, 6.2
Change-Id: Ic22983db1144fb1317d6102907c792871e1eeaed
Reviewed-on: https://review.typo3.org/30882
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong check for showing folder clickmenu 92/30792/2
Frans Saris [Mon, 16 Jun 2014 19:39:04 +0000 (21:39 +0200)]
[BUGFIX] Wrong check for showing folder clickmenu

This patch fixes a wrong check that prevents the clickmenu
from showing for folders in the filelist.

Resolves: #59568
Releases: 6.3, 6.2
Change-Id: Ic1e8bb28f64717631c4b57bc44221bd1132b876e
Reviewed-on: https://review.typo3.org/30792
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Typos in t3skin css files 91/30791/2
Markus Klein [Thu, 22 May 2014 14:10:21 +0000 (16:10 +0200)]
[BUGFIX] Typos in t3skin css files

Remove the lines as they have not been valid, nobody will miss them.

Resolves: #57716
Releases: 6.3, 6.2
Change-Id: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36
Reviewed-on: https://review.typo3.org/30791
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Correctly align datepicker clear input and trigger icon 87/30787/2
Frans Saris [Mon, 16 Jun 2014 19:26:54 +0000 (21:26 +0200)]
[BUGFIX] Correctly align datepicker clear input and trigger icon

This patch fixed the alignment of the clear input icon in the
date input fields and the trigger icon outside the datepicker input
fields.

Resolves: #59615
Releases: 6.3, 6.2
Change-Id: I0943ea0a8c4157d46fc07ca055ac8c1ab67c9a5b
Reviewed-on: https://review.typo3.org/30787
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Undefined method in extension manager 77/30777/2
Oliver Hader [Tue, 17 Jun 2014 13:35:14 +0000 (15:35 +0200)]
[BUGFIX] Undefined method in extension manager

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Resolves: #59624
Releases: 6.2
Change-Id: I84ff3685a94625cbc94af1967ac65b61cf9f5e43
Reviewed-on: https://review.typo3.org/30777
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Page tree does not visualize move targets 73/30473/2
Oliver Hader [Wed, 28 May 2014 13:40:01 +0000 (15:40 +0200)]
[BUGFIX] Page tree does not visualize move targets

If moving an element to a different page, the page tree only
visualizes the change in the source page, but does not visualize
the target page.

The reason is that the move-pointer is used (t3ver_state=4)
instead of the move-placeholder (t3ver_state=3) in that case.

Resolves: #59114
Releases: 6.2
Change-Id: Iefa01e4c85e9fb753873d03e7638ac592c09a657
Reviewed-on: https://review.typo3.org/30473
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Define precedence of states in workspace module 67/30467/2
Oliver Hader [Wed, 28 May 2014 11:03:58 +0000 (13:03 +0200)]
[BUGFIX] Define precedence of states in workspace module

The workspace module defines several states:
edited, moved, created, hidden, unhidden, deleted

The states "hidden" and "unhidden" are currently applied
after the action states. This change only uses the hidden
states if a record has been modified.

Resolves: #59118
Releases: 6.2
Change-Id: I95981306d61df38939a47579cb320dd93d51ce5b
Reviewed-on: https://review.typo3.org/30467
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Preview of moved workspace elements on source page 74/30474/2
Oliver Hader [Wed, 28 May 2014 13:42:21 +0000 (15:42 +0200)]
[BUGFIX] Preview of moved workspace elements on source page

If e.g. a content element gets moved to a different page, the
workspace preview link opens the source page (which does not
contain the element anymore, because it was moved).

Since the elements are shown on the correct page in the
workspace backend module, using the target page in the preview
link for the frontend is just obvious.

Resolves: #59143
Releases: 6.2
Change-Id: Ib84e65766e825cc26a66cbda9ffa8132c3a3ec18
Reviewed-on: https://review.typo3.org/30474
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years agoRevert "[BUGFIX] Session cookie is not recreated on login" 53/30753/6
Helmut Hummel [Mon, 16 Jun 2014 14:36:12 +0000 (16:36 +0200)]
Revert "[BUGFIX] Session cookie is not recreated on login"

This reverts commit 76741dff7b967b88aa1d6e556500a77716c7a97a
(https://review.typo3.org/29626)

This change is not needed any more as the fix done
for #58713 also fixes the issues targeted with this fix.

This should be reverted not only because it is not needed
any more but especially because it "abuses" the property
->newSessionID which should only be set when really
a new ID has been generated and not to force the cookie
to be set again.

Releases: 6.2
Resolves: #59614
Reverts: #57751
Related: #58713
Change-Id: I5324769b0795bcc1b1f1e385c73fd085d7b3f571
Reviewed-on: https://review.typo3.org/30753
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGIFX] Field labels not shown in workspaces history 13/30713/2
Oliver Hader [Fri, 13 Jun 2014 11:23:01 +0000 (13:23 +0200)]
[BUGIFX] Field labels not shown in workspaces history

Field labels are not shown if opening the history of an
element in the workspace module.

Resolves: #59546
Releases: 6.2
Change-Id: I3f522957dad8e36046b508dde658496f1cec6008
Reviewed-on: https://review.typo3.org/30713
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Broken tests due to modified PostProcessor constructor 14/30714/2
Oliver Hader [Fri, 13 Jun 2014 13:03:49 +0000 (15:03 +0200)]
[BUGFIX] Broken tests due to modified PostProcessor constructor

Issue #31951 introduced a breaking change in changing the order
of constructor arguments in the form PostProcessor. This could
have been avoided since new TypoScriptFactory object is and was
a singleton.

Resolves: #59549
Releases: 6.2
Change-Id: I1134d4440437e9fe03129241e63c0f0004712176
Reviewed-on: https://review.typo3.org/30714
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Own Layout Breaks Mail Message 26/28526/9
Cornel Boppart [Wed, 19 Mar 2014 15:23:03 +0000 (16:23 +0100)]
[BUGFIX] Own Layout Breaks Mail Message

With this patch it is possible to configure custom layouts
for the form, confirmation, and each type of post processor.
The backward compatibility is given, because this does not override
or break already existing configurations but provides some more
options to configure specific steps of the form process independent
of each other.
Therefore it prevents from breaking the layout of the confirmation view
and the HTML mail.

Resolves: #31951
Releases: 6.2
Change-Id: I3c015b53cd6d6efbd070d16bdc2111c7d60671aa
Reviewed-on: https://review.typo3.org/28526
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov