Packages/TYPO3.CMS.git
6 years ago[TASK] Protect bootstrap methods
Christian Kuhn [Sun, 25 Nov 2012 12:29:14 +0000 (13:29 +0100)]
[TASK] Protect bootstrap methods

With 6.0 the bootstrap related core code was split into small methods
and transferred to a group of encapsulating classes.
While this is an important step to get a flexible and maintainable
bootstrap in the end, this process is not completed and still misses
for example a real concept for scopes.
The patch groups methods used in all scopes in bootstrap wrapper
methods and makes the business methods protected. The whole API and
all affected classes are marked as "internal", together with a
warning that this API will change in the future and shouldn't be
used by 3rd party code that is not under core control.
This gives freedom for future development of this core code without
taking care of backwards compatibility. With previous versions there
was no API at all, so this is not a feature loss from an extension
point of view.

Change-Id: Ib841a19c766691fdeb7dab07280a005d6b67a938
Resolves: #43285
Releases: 6.0
Reviewed-on: http://review.typo3.org/16724
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] FormWizard does not save
Florian Scholz [Sat, 24 Nov 2012 21:20:06 +0000 (22:20 +0100)]
[BUGFIX] FormWizard does not save

This adds a mapping for the JsonToTyposcript class to resolve
the wrong instantiation due to different versions of file and
class names (Typoscript vs TypoScript).

Resolves: #43272
Releases: 6.0

Change-Id: I9c4eef2547462849e356617e15389976c9c343a6
Reviewed-on: http://review.typo3.org/16715
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Rootline relation overlay does not work for translated pages
Steffen Ritter [Sun, 25 Nov 2012 14:23:24 +0000 (15:23 +0100)]
[BUGFIX] Rootline relation overlay does not work for translated pages

Overlays for the relation fields of a page in the rootline,
introduced with the rootline class refactoring, do not work for
translated pages.
The problem is that the language overlay for the rootline is done outside
the RootlineUtility, or former PageRepository, and therefore also never
has been cached.

Use Rootline utility to do that Job and benefit fom caching, too.

Change-Id: If32830b384b08e189d155532aee7281b040b7dd5
Resolves: #42029
Releases: 6.0
Reviewed-on: http://review.typo3.org/16540
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix early calls to makeInstance
Helmut Hummel [Sun, 25 Nov 2012 15:41:03 +0000 (16:41 +0100)]
[BUGFIX] Fix early calls to makeInstance

In case of an early call to makeInstance
the object configuration might not be set.

We can fix this by not calling makeInstance to
create the configuration manager and just
return the original class in that case.

Fixes: #43290
Related: #43269
Releases: 6.0

Change-Id: I30d9c70f2fda9dd6df6aad60a5ae5327c1fc3c52
Reviewed-on: http://review.typo3.org/16730
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Obey option SYS: loginCopyrightShowVersion
Felix Kopp [Sun, 25 Nov 2012 14:53:57 +0000 (15:53 +0100)]
[BUGFIX] Obey option SYS: loginCopyrightShowVersion

Due to a bug introduced in #41992 the current version number
is always displayed within copyright notice underneath login form.

Change-Id: I9a0c48183eb0f56a1303cedf31ed13ff1c78c41b
Fixes: #43289
Releases: 6.0
Reviewed-on: http://review.typo3.org/16729
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Allow Folder and Storage to recursively retrieve Files from Driver
Steffen Ritter [Fri, 23 Nov 2012 14:11:44 +0000 (15:11 +0100)]
[TASK] Allow Folder and Storage to recursively retrieve Files from Driver

The drivers in FAL are capable of retrieving files recursively.
This might be sinful in some cases and custom usages. Anyhow,
the parameter $recursive is not passed up until Storage and
Folder objects. With that users are forced to work with the
driver directly.

As it is highly discouraged to work directly on the driver,
just pass up the parameter within the abstraction layers.

Change-Id: Ibe8f9aa9e906617a42a9a7d5edba43f24f613587
Releases: 6.0
Fixes: #43249
Reviewed-on: http://review.typo3.org/16697
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup trailing newline after ?>
Steffen Ritter [Sun, 25 Nov 2012 13:03:14 +0000 (14:03 +0100)]
[TASK] Cleanup trailing newline after ?>

Change-Id: Ib027351a353ca1fc5ee33bb13b18317d64267d8e
Releases: 6.0
Resolves: #43287
Reviewed-on: http://review.typo3.org/16728
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] Raise submodule pointer
TYPO3 Release Team [Sun, 25 Nov 2012 13:05:51 +0000 (14:05 +0100)]
[TASK] Raise submodule pointer

Change-Id: I7b1cefba3bdeb975caadcc403b520a91fdb312c9
Reviewed-on: http://review.typo3.org/16726
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years agoRevert "[BUGFIX] Use correct parameter type in insertPositionIcon"
Jigal van Hemert [Sun, 25 Nov 2012 12:20:33 +0000 (13:20 +0100)]
Revert "[BUGFIX] Use correct parameter type in insertPositionIcon"

This reverts commit 8e0b7cba6649ee92cd741b119277f05a7481df8a

Change-Id: I03c5aa86d3ef07dab5a9de9f4c59f1c3b3fb9a48
Reviewed-on: http://review.typo3.org/16723
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Use correct parameter type in insertPositionIcon
Jigal van Hemert [Sun, 25 Nov 2012 11:47:23 +0000 (12:47 +0100)]
[BUGFIX] Use correct parameter type in insertPositionIcon

PagePositionMap::printContentElementsColumns must call insertPositionIcon
with fake row array instead of empty string as first parameter.

Change-Id: I11afd7e8cad47b6892f0cd60feea8b53ff4d5945
Fixes: #43284
Releases: 6.0
Reviewed-on: http://review.typo3.org/16722
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Introduce object implementation registry
Helmut Hummel [Sat, 24 Nov 2012 17:48:28 +0000 (18:48 +0100)]
[TASK] Introduce object implementation registry

With 6.0 all Xclass inclusion in the classes have been
removed and registration of Xclasses have previously been
moved to the autoloader. This added additional complexity
and another concern to the class loader.

To enable extensions to override classes, an object
implementation registry is now introduced, where you
can now define which implementation class name should
be used for an original class.

This not only is a complete replacement for former
Xclasses, but at the same time adds the possibility
to have the implementation class name within the namespace
and scope of the extension which registers the override.

On top it would also be possible to register implementations
for interfaces.

Since only class names are mapped here, we again have a
clear separation of concerns, where the class loader
is only responsible to resolve paths for class names
and the "object manager" method makeInstance for resolving
the final class name to instantiate.

The path of the target class can be resolved automatically
by the class loader if naming conventions are met or the
target class name is put into the autoloading registry.

An implementation of a class can be registered like this:

$TYPO3_CONF_VARS['SYS']['Objects']['originalClass'] =
  array('className' => 'targetClass');

The patch adjusts the ClassLoader and makeInstance.
The unit tests for the ClassLoader are removed since
it is not responsible for resolving Xclasses any more.

Instead unit tests for makeInstance are added to test
the new behavior.

Resolves: #43269
Releases: 6.0

Change-Id: I04198b178aa41f02d7a5b7ee990ff24f483990f5
Reviewed-on: http://review.typo3.org/16712
Reviewed-by: Steffen Ritter
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Repair table header row styles
Felix Kopp [Sun, 25 Nov 2012 10:04:35 +0000 (11:04 +0100)]
[BUGFIX] Repair table header row styles

Restores css styles for table header rows.
Keeps newly introduced style for content element header.

Change-Id: Ic368eeb5f98fa7026508f7273499e1c64d4ce30f
Fixes: #43281
Releases: 6.0
Reviewed-on: http://review.typo3.org/16721
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Impexp is broken
Philipp Gampe [Sun, 25 Nov 2012 04:26:17 +0000 (05:26 +0100)]
[BUGFIX] Impexp is broken

The autoloader assumes that classes are located inside Classes, but the
directory is still lower case classes.

Rename the directory to conform to the default behavior.

Fixes: #43280
Releases: 6.0

Change-Id: Id8fc4c4e2f5290a45d4aac62ca577d6fdbfb5266
Reviewed-on: http://review.typo3.org/16720
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Styling of Page module
Ivan Kartolo [Sat, 24 Nov 2012 16:02:45 +0000 (17:02 +0100)]
[TASK] Styling of Page module

Overwork the styling of the Page module:

* New style for columns
* Hide new icons by default, show on hover
* Style Drag & Drop

Thanks to Lars Zimmermann and Jens Hoffmann

Change-Id: I7f06382c51561e8c9855af0ef15afea1a8dd6acb
Resolves: #43208
Releases: 6.0
Reviewed-on: http://review.typo3.org/16700
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Hide version selector if workspaces are used
Helmut Hummel [Sat, 24 Nov 2012 11:15:32 +0000 (12:15 +0100)]
[BUGFIX] Hide version selector if workspaces are used

All versioning information and actions should be
hidden if workspaces are used.

One remaining selector is in the page module when
a page has been versioned in a workspace.

Hide this selector when workspaces extension is installed.

Fixes: #43264
Related: #27969, #25962
Releases: 4.5, 4.6, 4.7, 6.0

Change-Id: If96f1fe99f2a7a5b5b48f1f8a1aca8f053a6622a
Reviewed-on: http://review.typo3.org/16706
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Split FLUIDTEMPLATE class to smaller methods
Christian Kuhn [Tue, 20 Nov 2012 22:33:22 +0000 (23:33 +0100)]
[TASK] Split FLUIDTEMPLATE class to smaller methods

The patch splits the FLUIDTEMPLATE content object to smaller
and more readable code pieces. Additionally, 27 new unit tests
are added for the public API method, checking all important
code areas and documenting current behavior.

Change-Id: I049718a7f00da20534d28353796878310871adf4
Resolves: #43182
Releases: 6.0
Reviewed-on: http://review.typo3.org/16639
Reviewed-by: Helge Funk
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update SwiftMailer license exception
Michael Stucki [Thu, 22 Nov 2012 15:03:36 +0000 (16:03 +0100)]
[TASK] Update SwiftMailer license exception

Change-Id: Ia4c9ec4cb174493810e90d018082a92d37485194
Resolves: #42422
Releases: 6.0
Reviewed-on: http://review.typo3.org/16684
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Rename Swiftmailer license exception file
Michael Stucki [Thu, 22 Nov 2012 14:56:23 +0000 (15:56 +0100)]
[TASK] Rename Swiftmailer license exception file

Change-Id: Ia1de8910ee216767dfc286590cb81a5cee9f640f
Resolves: #42422
Releases: 6.0
Reviewed-on: http://review.typo3.org/16683
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix header thumbnail for new inserted records
Helmut Hummel [Wed, 21 Nov 2012 09:24:16 +0000 (10:24 +0100)]
[BUGFIX] Fix header thumbnail for new inserted records

The header thumbnail is not correctly rendered when
inserting new images because the code tries to fetch
the record which is not created yet.

Use the data of the temporary record instead, to be able to
correctly create the thumbnail in the header.

Fixes: #43189
Releases: 6.0

Change-Id: Ic75fd6c70c8c10777a762f585c4c4b3ec467fe75
Reviewed-on: http://review.typo3.org/16657
Tested-by: Anja Leichsenring
Reviewed-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Typos in language labels and variables in EM
Jigal van Hemert [Wed, 21 Nov 2012 08:50:23 +0000 (09:50 +0100)]
[BUGFIX] Typos in language labels and variables in EM

Fix a few typos.

Change-Id: Id1087e7972e65f0d4463d6d4c7c0613039bbb98e
Fixes: #43188
Releases: 6.0
Reviewed-on: http://review.typo3.org/16656
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Set TYPO3 version to 6.0-dev
TYPO3 Release Team [Wed, 21 Nov 2012 00:02:46 +0000 (01:02 +0100)]
[TASK] Set TYPO3 version to 6.0-dev

Change-Id: I4a43697dd6fa44910243b3a6b4ea57fe499df64b
Reviewed-on: http://review.typo3.org/16649
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.0rc2
TYPO3 Release Team [Wed, 21 Nov 2012 00:02:34 +0000 (01:02 +0100)]
[RELEASE] Release of TYPO3 6.0.0rc2

Change-Id: If2ba9153384609a7f87d8ab3e74c293ae0c77b3a
Reviewed-on: http://review.typo3.org/16648
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Raise submodule pointer
TYPO3 Release Team [Tue, 20 Nov 2012 23:45:01 +0000 (00:45 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ibc293fdca09d424718f858e4b7585082ebf1e461
Reviewed-on: http://review.typo3.org/16647
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Placeholder JavaScript handling is active for Non-IE browsers
Oliver Hader [Tue, 20 Nov 2012 23:36:49 +0000 (00:36 +0100)]
[BUGFIX] Placeholder JavaScript handling is active for Non-IE browsers

The jsfunc.placeholder.js file was introduced to have a fallback
for Internet Explorer on the HTML5 placeholder feature. However,
this handling is currently active in all browsers and results in
broken NULL values for textarea, since textarea don't have a
human readable representation like input fields.

Fixes: #43183
Releases: 6.0
Thus, only activate the handling in Internet Explorer.

Change-Id: Ie27c8e8544fa99cad14f3a74fa960524cc7e834a
Reviewed-on: http://review.typo3.org/16644
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Integrate possibility to determine NULL values in TypoScript
Oliver Hader [Tue, 20 Nov 2012 20:14:45 +0000 (21:14 +0100)]
[FEATURE] Integrate possibility to determine NULL values in TypoScript

Currently there's no possibility to handle NULL values in
TypoScript. This is related to the feature "Add possibility
to store NULL values (#41773)".

Thus, two new elements are integrated:
* (stdWrap).ifNull -> string/stdWrap
* (stdWrap).if.isNull -> stdWrap

Change-Id: I77a29341c66edaf3bef14de33f65c702fbbb9fbd
Resolves: #43133
Releases: 6.0
Reviewed-on: http://review.typo3.org/16637
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Deactivated textarea elements are not visualized
Oliver Hader [Tue, 20 Nov 2012 20:08:42 +0000 (21:08 +0100)]
[BUGFIX] Deactivated textarea elements are not visualized

Deactivated textarea elements, fields that have a NULL value
stored in the database, are not visualized correctly when
loading the backend editing form. The status is currently set
using JavaScript and triggered by TBE_EDITOR.fieldSet().
However, textareas don't have a human readable clone and thus
fieldSet() is not called and thus no status is set.

This issue is fixed by directly rendering the status in the
FormEngine.

Change-Id: I2dded816853f452b25f6edf6e7d7f6dca1387739
Fixes: #43175
Releases: 6.0
Reviewed-on: http://review.typo3.org/16636
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Fix styling of NULL value fields
Oliver Hader [Tue, 20 Nov 2012 23:20:07 +0000 (00:20 +0100)]
[TASK] Fix styling of NULL value fields

Change-Id: Ib1b9f2f4bc274bcb1f180507a8ca0257323fd4bc
Releases: 6.0
Reviewed-on: http://review.typo3.org/16642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Make headerThumbnail in IRRE records configurable
Kai Vogel [Sat, 10 Nov 2012 13:51:28 +0000 (14:51 +0100)]
[BUGFIX] Make headerThumbnail in IRRE records configurable

This patch allows the configuration of the thumbnail image in IRRE
record headers. It is possible to configure e.g. height and width
using the TCA configuration in "headerThumbnail".

Resolves: #42837
Releases: 6.0

Change-Id: I284e9d04676fb3d4031eac6d2f8548761e167e69
Reviewed-on: http://review.typo3.org/16377
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Fix fatal error in indexed_search
Helmut Hummel [Tue, 20 Nov 2012 23:01:30 +0000 (00:01 +0100)]
[BUGFIX] Fix fatal error in indexed_search

Fixes: #42932
Related: #42806
Releases: 6.0

Change-Id: I05c179c917ed43cb70c2966984080670192713d4
Reviewed-on: http://review.typo3.org/16641
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Use new class names in indexed_search
Helmut Hummel [Tue, 20 Nov 2012 22:53:30 +0000 (23:53 +0100)]
[TASK] Use new class names in indexed_search

Fixes: #42930
Releases: 6.0

Change-Id: I71780306d8edcd0da769ba7c56d4d4e3e386b77c
Reviewed-on: http://review.typo3.org/16640
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fallback of FAL properties does not work
Oliver Hader [Tue, 20 Nov 2012 19:59:34 +0000 (20:59 +0100)]
[BUGFIX] Fallback of FAL properties does not work

The fields title, description and alternative are available
in file references and files. If those in file references
are not defined, those of files shall be used.

Besides that, some fields are not configured yet to be shown
as placeholder element in the backend.

The flaws are fixed by adding accordant TCA configuration and
adding the fallback behaviour for the FileReference object.

Change-Id: I28fa94faeb88958ce6c6cb942ba9a88bd555acdf
Fixes: #43173
Releases: 6.0
Reviewed-on: http://review.typo3.org/16635
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Refactor FAL file processing
Andreas Wolf [Fri, 19 Oct 2012 15:20:12 +0000 (17:20 +0200)]
[TASK] Refactor FAL file processing

File processing is a central part of TYPO3's file usage, as e.g. all
images in content elements have to be resized when they don't fit the
requirements. However, the current implementation of file processing
with FAL has several drawbacks and shortcomings, not to mention quite a
few bugs.

This patch brings a completely reworked infrastructure behind the
File Processing Service, while keeping the external API unchanged.

The processing to be done is described in tasks, which are part of a
ProcessedFile's properties. The processing itself is now moved to
processors, which could execute the tasks using different utilities,
e.g. ImageMagick or some cloud image processing service. Currently,
there is only a local image processor implementation, which relies on
ImageMagick/GraphicsMagick (i.e. uses the same configuration as the old
processing).

The processed file class now also supports safe handling of unchanged
files, i.e. files that should have been processed, but didn't need
processing.

Fixes: #43059
Fixes: #39904
Fixes: #40033
Fixes: #40669
Releases: 6.0

Change-Id: I186a46f9923dacd98be655d72be2bd89b43866c2
Reviewed-on: http://review.typo3.org/14310
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Remove isLoaded('fluid') call from FLUIDTEMPLATE
Christian Kuhn [Tue, 20 Nov 2012 19:01:14 +0000 (20:01 +0100)]
[BUGFIX] Remove isLoaded('fluid') call from FLUIDTEMPLATE

EXT:fluid is a required extension since TYPO3 6.0. The
isLoaded('fluid') call in FLUIDTEMPLATE content object
can be removed.

Change-Id: I514163bffc19fa264501dc2d88e1fe59f0e9a062
Fixes: #43172
Releases: 6.0
Reviewed-on: http://review.typo3.org/16633
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Some unit tests fail in Core::LocalDriverTest
Nicole Cordes [Tue, 20 Nov 2012 00:30:28 +0000 (01:30 +0100)]
[BUGFIX] Some unit tests fail in Core::LocalDriverTest

Some tests fail on Windows systems. Mostly this is because of a missing
file and folder permission handling. Those tests have to be skipped.
Furthermore there is some path fixing needed in basic class.

Change-Id: Ib89e84539af2742dbb3a6e2f53ae5a0c121a0626
Fixes: #43126
Release: 6.0
Reviewed-on: http://review.typo3.org/16596
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Migrate contentObjectRenderer data only when array
Marc Bastian Heinrichs [Mon, 19 Nov 2012 22:52:32 +0000 (23:52 +0100)]
[BUGFIX] Migrate contentObjectRenderer data only when array

Passed $data in start method could be a non-array, e.g. in fluid
CObjectViewHelper or in extensions. Migrate $data only if it's a
not empty array and the table is set.

Makes the fieldArray fallback to TSFE->page in getData working again.

Change-Id: I469e8fa6131579a2de399516c65f4822275b187b
Fixes: #43068
Fixes: #43055
Releases: 6.0
Reviewed-on: http://review.typo3.org/16546
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Default behaviour for field rendering of configuration is dropped
Nicole Cordes [Sat, 17 Nov 2012 00:10:43 +0000 (01:10 +0100)]
[BUGFIX] Default behaviour for field rendering of configuration is dropped

In TYPO3 4.7 (and below) the default field of a configuration was a text
field. With a wrong configuration type in ext_conf_template.txt now the
field isn't rendered any more. There should be a fallback to a normal
input field like it used to.

Fixes: #43042
Releases: 6.0

Change-Id: Ic49c9b19a7f8f1795889f17ed5c1efa364dfd9b9
Reviewed-on: http://review.typo3.org/16503
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGIFX] File Reference cannot be used to disable specific meta data
Oliver Hader [Tue, 20 Nov 2012 13:24:35 +0000 (14:24 +0100)]
[BUGIFX] File Reference cannot be used to disable specific meta data

The meta data (like description, title, ...) in File References
cannot be used to disable the inherited data from the parent
File object. Currently values can be blank which results in
using data from the parent. To really override by using blanks,
the new NULL feature for TCA fields needs to be used.

Change-Id: I61e5f5e6a0d848e95e2e0402913778ef9f63a093
Fixes: #43132
Releases: 6.0
Reviewed-on: http://review.typo3.org/16602
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] RootlineUtility uses backticks which leads to crashing dbal
Nicole Cordes [Tue, 20 Nov 2012 17:03:00 +0000 (18:03 +0100)]
[BUGFIX] RootlineUtility uses backticks which leads to crashing dbal

In some queries backticks are used to generate the WHERE clause. Those
backticks lead to an error when using dbal. Therefore they have to be
removed.

Change-Id: If6aa29f73fda93cfc122af51201730cc6475a8c1
Fixes: #43168
Release: 6.0
Reviewed-on: http://review.typo3.org/16629
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Missing separator in tables.sql
Nicole Cordes [Tue, 20 Nov 2012 16:52:26 +0000 (17:52 +0100)]
[BUGFIX] Missing separator in tables.sql

For the table sys_category_record_mm after the first KEY command there is
a missing comma which leads to dbal crash.

Change-Id: Ib5d88df46c166a9e7fffd5106e5158679cd947d8
Fixes: #43167
Release: 6.0
Reviewed-on: http://review.typo3.org/16628
Reviewed-by: Anja Leichsenring
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Activating NULL value field does not work with blank string
Oliver Hader [Tue, 20 Nov 2012 11:20:35 +0000 (12:20 +0100)]
[BUGFIX] Activating NULL value field does not work with blank string

Activating a field that supports NULL values and just using a
blank string ("") does not work. The problem is a strcmp() call
that returns a false-positive on comparing NULL to blank strings

Change-Id: I59417f5f5cd814db15e2b6b725f1778d098014f6
Fixes: #43139
Releases: 6.0
Reviewed-on: http://review.typo3.org/16599
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Integrate possibility to call inaccessible methods in BaseTestCase
Oliver Hader [Tue, 20 Nov 2012 11:17:24 +0000 (12:17 +0100)]
[TASK] Integrate possibility to call inaccessible methods in BaseTestCase

The BaseTestCase already has a possibility to create full blown
accessible object proxies. However if one does not want to have
the class stack cluttered with temporary existing classes, there
shall be a possibility to directly invoke protected/private
methods of a fixture object.

The new method callInaccessibleMethod method is taken and
rewritten from ModuleControllerTest.

Example to use it in unit tests:
$this->fixture = new \TYPO3\CMS\Core\SomeClassName();
$result = $this->callInaccessibleMethod(
  $this->fixture,
  'privateMethod',
  $first, $second, $third, ...
);

Change-Id: I2c90c136c350129b28809d8b8b88286149894a10
Resolves: #43145
Releases: 6.0
Reviewed-on: http://review.typo3.org/16598
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Tests failing in Core::CategoryCollectionTest
Nicole Cordes [Mon, 19 Nov 2012 21:55:01 +0000 (22:55 +0100)]
[BUGFIX] Tests failing in Core::CategoryCollectionTest

Some tests are failing in
TYPO3\CMS\Core\Tests\Functional\Category\Collection\CategoryCollectionTest
due to false CREATE TABLE statement.

Change-Id: I8fe03b4d02c8f85fcddf8be06010eb8b2f079102
Fixes: #43122
Release: 6.0
Reviewed-on: http://review.typo3.org/16594
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer
Christian Kuhn [Mon, 19 Nov 2012 21:54:39 +0000 (22:54 +0100)]
[TASK] Raise submodule pointer

Change-Id: I3f333615f87c7682d251987df1e58403720d331b
Reviewed-on: http://review.typo3.org/16592
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Comment legacy files to be removed with 6.2
Christian Kuhn [Mon, 19 Nov 2012 21:21:51 +0000 (22:21 +0100)]
[TASK] Comment legacy files to be removed with 6.2

The 'old' class files before namespace switch are commented
to be removed with TYPO3 7.0, but they should be scheduled
for removal with 6.2.

Change-Id: I2db757db54410c5764ab21aef90918a7771f2c92
Resolves: #43120
Releases: 6.0
Reviewed-on: http://review.typo3.org/16590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] cache_imagesizes schema defined twice
Christian Kuhn [Mon, 19 Nov 2012 20:31:45 +0000 (21:31 +0100)]
[BUGFIX] cache_imagesizes schema defined twice

EXT:cms/ext_tables.sql and t3lib/stddb/tables.sql define
an identical table schema of table cache_imagesizes.
Since cache_imagesizes is used in core classes, the
duplication in EXT:cms is removed with the patch.

Change-Id: I67a861afe34f3e388f898fc3f0bad5b5c574d626
Resolves: #43119
Releases: 6.0
Reviewed-on: http://review.typo3.org/16583
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove deprecated Fluid classes from IDE file
Marc Bastian Heinrichs [Sun, 18 Nov 2012 12:54:03 +0000 (13:54 +0100)]
[TASK] Remove deprecated Fluid classes from IDE file

The deprecated classes have been removed in Fluid.
Remove them from the IDE file.

Related: #43069
Releases: 6.0

Change-Id: I2d51053009fe0455e3d085645de37ac037363d41
Reviewed-on: http://review.typo3.org/16553
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] adjust LegacyClassesForIde
Anja Leichsenring [Fri, 9 Nov 2012 07:31:08 +0000 (08:31 +0100)]
[TASK] adjust LegacyClassesForIde

The class extbase/Reflection/Service is renamed to
extbase/Reflection/ReflectionService, so the LegacyClassesForIde
must be adjusted accordingly.

Resolves: #42810
Relates: #42808,#42809
Releases: 6.0

Change-Id: Iecd47910ed6708fcde06b4ab25c73d8cbea9f44f
Reviewed-on: http://review.typo3.org/16343
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Raise submodule pointer
Christian Kuhn [Mon, 19 Nov 2012 20:17:24 +0000 (21:17 +0100)]
[TASK] Raise submodule pointer

Change-Id: If47b70fb9183b9a36f88a8908ec455de7d1e7fa4
Reviewed-on: http://review.typo3.org/16582
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove not needed require for language service
Helmut Hummel [Mon, 19 Nov 2012 19:24:17 +0000 (20:24 +0100)]
[TASK] Remove not needed require for language service

The Bootstrap still contains a require statement
for the language service, which can now perfectly be
loaded by the autoloader.

Resolves: #43115
Releases: 6.0

Change-Id: I04eacb1e459f4e7f1e14a46597cdbee7a1ce7a74
Reviewed-on: http://review.typo3.org/16579
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Optimize compatibilty class loader
Helmut Hummel [Mon, 29 Oct 2012 18:24:01 +0000 (19:24 +0100)]
[TASK] Optimize compatibilty class loader

Do not save rewritten code in compatibility class loader
if no replacements have been found but require the
original class instead.
Additionally do not touch classes that do not start
with 'tx_' or other known TYPO3 specific prefixes.

Resolves: #42497
Releases: 6.0

Change-Id: Ic3cdafbfec3814ef61046500c1ac4f916bade133
Reviewed-on: http://review.typo3.org/16018
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Replace calls of tslib_gifbuilder with namespaced class
Nicole Cordes [Mon, 19 Nov 2012 17:33:21 +0000 (18:33 +0100)]
[BUGFIX] Replace calls of tslib_gifbuilder with namespaced class

In some functions the old class tslib_gifbuilder is still called and
should be replaces with the namespaced class.

Change-Id: I313ce18f667e0f7cc636422d9a784433851d59d8
Fixes: #43111
Releases: 6.0
Reviewed-on: http://review.typo3.org/16577
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove extList from LocalConfiguration
Christian Kuhn [Mon, 19 Nov 2012 12:50:38 +0000 (13:50 +0100)]
[TASK] Remove extList from LocalConfiguration

extList was kept next to the new extListArray in LocalConfiguration.
Both hold the current list of loaded extensions. This leads to
confusion which variable is the one that takes precedence.
The patch removes extList from the upgrade wizard in the install tool
and only writes extListArray. This way, only one key is kept in
LocalConfiguration.php. For compatibility reasons, the array entry
'extList' is added to $GLOBALS['TYPO3_CONF_VARS'] at runtime during
bootstrap.

Change-Id: I6102b2b4da9761c86189ae3f73ad3a423715e037
Resolves: #43094
Releases: 6.0
Reviewed-on: http://review.typo3.org/16566
Reviewed-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
6 years ago[TASK][DB] Increase length of tt_content CType
Andreas Kie├čling [Mon, 19 Nov 2012 08:23:33 +0000 (09:23 +0100)]
[TASK][DB] Increase length of tt_content CType

The length of the CType file is often too small to contain the name of
the extension that creates a new content element type. It should be
increased from 30 to 255.

Resolves: #43062
Releases: 6.0

Change-Id: I5ac23f7bdaa40ea9764d08ee330883da5be5a1ef
Reviewed-on: http://review.typo3.org/16560
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGIFX] Fix Exception name in beuser module
Helmut Hummel [Sun, 18 Nov 2012 11:27:39 +0000 (12:27 +0100)]
[BUGIFX] Fix Exception name in beuser module

Add the missing TYPO3 prefix to the full qualified
class name.

Releases: 6.0

Change-Id: I6a6417dc63a7ef87947b8186aefff12bdeb929f2
Reviewed-on: http://review.typo3.org/16545
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] EXT:frontend still uses old table name sys_language_overlay
Patrick Broens [Thu, 15 Nov 2012 13:49:51 +0000 (14:49 +0100)]
[BUGFIX] EXT:frontend still uses old table name sys_language_overlay

The extension "frontend" is still using the old table name
sys_language_overlay

This patch fixes this issue by renaming it to pages_language_overlay

Change-Id: Ida5444d113ba089652adba7d0cbd01729ce9ab48
Resolves: #43001
Releases: 6.0
Reviewed-on: http://review.typo3.org/16454
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Invalid behavior of search for integer in Backend search
Soren Malling [Fri, 21 Sep 2012 12:02:36 +0000 (14:02 +0200)]
[BUGFIX] Invalid behavior of search for integer in Backend search

In fact current implementation does not replace the LIKE
operator with an SQL equal statement for numeric fields
but whenever a query that can be interpreted as integer
is encountered, regardless of the underlying column type.

Example: If you have pages "102 W", "102 E", you used
to be able to search for "102" and get them, but now
the query is casted to an integer and the page title
is search for an equality on "102" resulting in
an empty result list.

The underlying column type should be used
instead (code to cache this information is already
available within DBAL and Helmut started months
ago to backport it to Core itself: #28654).

Thanks to Clio Online for sponsoring this fix!

Resolves: #33700
Releases: 6.0, 4.7, 4.6

Change-Id: I8c4cceac5320b9135ccf9e99892cc57dcfffadc5
Reviewed-on: http://review.typo3.org/13990
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[TASK] Remove @package and @subpackage annotations
Christian Kuhn [Fri, 16 Nov 2012 11:41:06 +0000 (12:41 +0100)]
[TASK] Remove @package and @subpackage annotations

With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.

Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Fix deprecated $doc->isCMlayers()
Georg Ringer [Sat, 22 Sep 2012 22:25:27 +0000 (00:25 +0200)]
[TASK] Fix deprecated $doc->isCMlayers()

Function TYPO3\CMS\Backend\Template\DocumentTemplate->isCMlayers()
is not needed and can be removed.

Change-Id: I7cef6a7711055c8cd6ce7ca0b3bf94b22e50a62f
Resolves: #41272
Releases: 6.0
Reviewed-on: http://review.typo3.org/14955
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] GeneralUtility::validEmail() can throw warnings
Christian Kuhn [Thu, 15 Nov 2012 21:37:55 +0000 (22:37 +0100)]
[BUGFIX] GeneralUtility::validEmail() can throw warnings

If GeneralUtility::validEmail() is called with array or object
as parameter, warnings or errors are thrown of type "strlen()
expects parameter 1 to be string" or similar.
The patch sanitizes the method by returning early with FALSE if
input parameter is not a string.

Change-Id: I56c8ec91c730e47d341de7f09c14c7ee0492a616
Fixes: #42792
Releases: 6.0
Reviewed-on: http://review.typo3.org/16462
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Follow-up clean-up to #19938
Christian Kuhn [Thu, 15 Nov 2012 12:46:11 +0000 (13:46 +0100)]
[BUGFIX] Follow-up clean-up to #19938

Refactoring #19938 a loose end was forgotten to be removed in one test.

Change-Id: I36d1f9368eb829afebd5c3be2282811b010ed5ff
Related: #19938
Releases: 6.0
Reviewed-on: http://review.typo3.org/16453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EXT:felogin: Multiple bugs with preserveGETvars
Jigal van Hemert [Fri, 30 Dec 2011 19:32:32 +0000 (20:32 +0100)]
[BUGFIX] EXT:felogin: Multiple bugs with preserveGETvars

Refactor and fix handling of preserveGETvars in felogin.
 * Add support for multi dimensional arrays
 * urlencode() values
 * Preserve only parameters defined in 'preserveGETvars'

The patch adds a new ArrayUtility method to handle
recursive array intersections. See the unit tests for details.

Change-Id: I90e2f8eb79586369a9c15c7ef19f7658b1d65ed3
Fixes: #19938
Fixes: #23324
Fixes: #23649
Fixes: #36894
Fixes: #38589
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/7638
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Form shows Fatal Error in Frontend
Ingo Pfennigstorf [Fri, 9 Nov 2012 14:47:05 +0000 (15:47 +0100)]
[BUGFIX] Form shows Fatal Error in Frontend

This resolves the wrong instantiation of all classes
that contain uppercase characters within a certain
class name part, by adding the lowercased versions
to the class alias map.

Fixes: #40850
Releases: 6.0

Change-Id: I973393a5476e5b0ee8a2500117de636e43513666
Reviewed-on: http://review.typo3.org/16362
Reviewed-by: Thomas Maroschik
Reviewed-by: Mattias Nilsson
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Remove dependency to iconv lib in form
Helmut Hummel [Wed, 14 Nov 2012 23:49:15 +0000 (00:49 +0100)]
[BUGFIX] Remove dependency to iconv lib in form

The form extension uses iconv_strlen to determine
the string length, which fails when this method
is not present in PHP.

Use the CharsetConverter class instead.

Fixes: #42990
Releases: 6.0

Change-Id: Ibf7e82c85bd808f036c7d0715f55d6f1f9e5b8d5
Reviewed-on: http://review.typo3.org/16449
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Raise submodule pointer
Christian Kuhn [Wed, 14 Nov 2012 19:55:22 +0000 (20:55 +0100)]
[TASK] Raise submodule pointer

Change-Id: I19bf442d362fc1ba7dd2df2d5d7e55c592222e27
Reviewed-on: http://review.typo3.org/16447
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Re-implement extension status for reports module
Christian Kuhn [Sun, 4 Nov 2012 21:44:36 +0000 (22:44 +0100)]
[TASK] Re-implement extension status for reports module

The reports module to show the main typo3.org TER repository
extension list status and the security state of loaded and
existing extensions was not implemented with the new
extension manager.
The patch adds the missing reports.

Resolves: #39914
Releases: 6.0

Change-Id: Ib26dad4d798829ee96d900a80311aa28bb021c2c
Reviewed-on: http://review.typo3.org/16446
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Labels in EM are not translated
Georg Ringer [Tue, 13 Nov 2012 16:40:45 +0000 (17:40 +0100)]
[BUGFIX] Labels in EM are not translated

The configuration of an extension can make use of
labels and those are not translated in a select box.

Therefore use LANG->sL()

Change-Id: I12c09b3cf0b68e5f5f0f1d03ac5f78dd89d7bbde
Fixes: #42931
Releases: 6.0
Reviewed-on: http://review.typo3.org/16437
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Improve wincache has() function
Georg Ringer [Mon, 5 Nov 2012 23:29:42 +0000 (00:29 +0100)]
[TASK] Improve wincache has() function

Change-Id: Ia90500734c71095c82f774ac6c0acd16ce28f096
Resolves: #42253
Releases: 6.0
Reviewed-on: http://review.typo3.org/16224
Reviewed-by: Philipp Gampe
Reviewed-by: Tomasz Krawczyk
Tested-by: Tomasz Krawczyk
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix missing option labels in EXT:saltedpasswords ext config
Tilo Baller [Sat, 10 Nov 2012 00:05:56 +0000 (01:05 +0100)]
[BUGFIX] Fix missing option labels in EXT:saltedpasswords ext config

The labels for the options of the settings "Hashing method for the
backend|frontend" are missing because the class names of the
salt methods, which changed in previous commits, are part of the
language key for the labels.

Change the language key generation to use the class name without
the prepended namespace and add the corresponding language key in the
actual language file.

Fixes: #42832
Releases: 6.0

Change-Id: I1ae96bd90bf153f0379159e1695701ecf5f9f004
Reviewed-on: http://review.typo3.org/16369
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Tilo Baller
Tested-by: Tilo Baller
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix userfunc paths in EXT:saltedpasswords ext_conf_template.txt
Tilo Baller [Fri, 9 Nov 2012 23:27:32 +0000 (00:27 +0100)]
[BUGFIX] Fix userfunc paths in EXT:saltedpasswords ext_conf_template.txt

Paths to the class files and class names for the user functions used
in the extension configuration of EXT:saltedpasswords are wrong, since
they were moved and namespaced.

Thus opening the extension configuration in extension manager fails
with a fatal error, because the required class files can not be loaded.

Load the right classes.

Fixes: #42829
Releases: 6.0

Change-Id: I9e9dd6f3f8ceacf0196971db91f108d7dc963bcd
Reviewed-on: http://review.typo3.org/16368
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Mattias Nilsson
Reviewed-by: Tilo Baller
Tested-by: Tilo Baller
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Regression in t3lib_iconWorks::imagecopyresized
Tymoteusz Motylewski [Sun, 11 Nov 2012 18:51:44 +0000 (19:51 +0100)]
[BUGFIX] Regression in t3lib_iconWorks::imagecopyresized

t3lib_iconWorks::imagecopyresized was refactored
in #26660. Unfortunatelly that change introduced
a regression. Parameter names were changed in
the method definition, but not inside this method.

This change makes parameter names consistent.

Change-Id: I819da83ea059ecc7d17348c12ca64b37fac6dae0
Fixes: #39563
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/13488
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Fix TYPO3 logos
Helmut Hummel [Sun, 11 Nov 2012 00:26:58 +0000 (01:26 +0100)]
[TASK] Fix TYPO3 logos

The logos have been changed to match the new CI,
but were cut out sloppily.

Exchange the most prominent logos with proper ones.

Fixes: #42850
Releases: 6.0, 4.7, 4.6, 4.5

Change-Id: Id5ac815b8c2b381bef89f9e152345fd29a822bf6
Reviewed-on: http://review.typo3.org/16391
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Set TYPO3 version to 6.0-dev
TYPO3 Release Team [Sat, 10 Nov 2012 21:06:50 +0000 (22:06 +0100)]
[TASK] Set TYPO3 version to 6.0-dev

Change-Id: I68301629737a66a76332e59b3ccd674bb7d05722
Reviewed-on: http://review.typo3.org/16387
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.0rc1
TYPO3 Release Team [Sat, 10 Nov 2012 21:06:37 +0000 (22:06 +0100)]
[RELEASE] Release of TYPO3 6.0.0rc1

Change-Id: Id506e3479c6b48526b7a9cdfdd211bc33c1a61d6
Reviewed-on: http://review.typo3.org/16386
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Add "suggests" as valid dependency type
Tilo Baller [Fri, 9 Nov 2012 20:14:41 +0000 (21:14 +0100)]
[BUGFIX] Add "suggests" as valid dependency type

Currently extensions with "suggests" contraint in ext_emconf.php
fail to install in Extension Manager with exception
"suggestwas not a valid dependency type.".

Example (taken from EXT:saltedpasswords ext_emconf.php):
    'constraints' => array(
        [...]
        'suggests' => array(
            'rsaauth' => ''
        )
    ),

NOTE: This patch does not implement the missing handling
for suggested extensions.

Fixes: #42594
Releases: 6.0

Change-Id: I326de368508c5c9a350d7b7e84b07f3bc1582437
Reviewed-on: http://review.typo3.org/16367
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix update translation handling
Helmut Hummel [Sat, 10 Nov 2012 17:39:11 +0000 (18:39 +0100)]
[BUGFIX] Fix update translation handling

The current translation handling does not respect
subfolders in the zip file during extraction.
This leads to partly missing translations as the
translation files were not in the correct folder
structure.

Create the folder structure during zip file extraction
and improve the path calculation so that path traversal
is not possible any more.

Fixes: #42840
Releases: 6.0

Change-Id: I9e03622879f38d294b2487c63e9ced0ba40d8142
Reviewed-on: http://review.typo3.org/16381
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Tested-by: Oliver Hader
Reviewed-by: Oliver Hader
6 years ago[FEATURE] Add possibility to store NULL values
Oliver Hader [Tue, 9 Oct 2012 18:17:43 +0000 (20:17 +0200)]
[FEATURE] Add possibility to store NULL values

The current implementation in the TYPO3 backend does not allow
to store NULL values, only empty strings or zero as number are
allowed.
Since the overlay behavior of FAL takes e.g. the description
property from the original file object an empty value in the
disposal (the referenced file) cannot be defined to be blank,
thus not clearing the original file description.

For this case we need a new behavior to allow NULL values in
the storage and to handle that in the backend view.

This feature is enabled by adding "null" to the eval list of
the TCA configuration of a field, example:

'columns' => array(
  'title' => array(
    'config' => array(
      'type' => 'text',
      'eval' => 'null',
    )
  )
)

Besides that, of course the database field definition needs to
be updated to support NULL values.

Change-Id: Ib5cd0e34e34d084df7ba3380ae81e5240bcf76d6
Resolves: #41773
Releases: 6.0
Reviewed-on: http://review.typo3.org/15458
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Enable IRRE fields in FlexForms
Kai Vogel [Tue, 6 Nov 2012 16:45:07 +0000 (17:45 +0100)]
[FEATURE] Enable IRRE fields in FlexForms

This patch enables IRRE fields in flexform. They can be used
identically to the TCA.

FlexForm segments are separated by a new divider "---" to
easily have the possiblity to recognize and parse them when
handline the IRRE object identifiers.

Besides that a new remapping level for FlexForms has been
introduced to the DataHandler to update accordant FlexForm
references after all child records have been written.

Unit tests have been extended to check the new additions to
the accordant object identifiers and form names. This is
important to any processing of IRRE in the form view.

Change-Id: Icadb89c2e496a5f1ad7de298ebee06d144475a11
Resolves: #18957
Releases: 6.0
Reviewed-on: http://review.typo3.org/13968
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Kai Vogel
Tested-by: Kai Vogel
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Rename SUViewHelper to SwitchUserViewHelper
Helmut Hummel [Fri, 9 Nov 2012 20:06:21 +0000 (21:06 +0100)]
[BUGFIX] Rename SUViewHelper to SwitchUserViewHelper

On case sensitive file systems the SUViewHelper
cannot be found, as the file is named SUViewHelper.php
and the class SuViewHelper.

Rename both file and class to match and to be more
speaking.

Resolves: #42826
Releases: 6.0

Change-Id: I19c0b7c39b77ba2d7b192a989e5d45b2b7d4a2c7
Reviewed-on: http://review.typo3.org/16366
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Content Elements "uploads" ignores translations
Steffen Ritter [Fri, 9 Nov 2012 16:18:05 +0000 (17:18 +0100)]
[BUGFIX] Content Elements "uploads" ignores translations

The TypoScript Object "FILES" has been changed to be aware
of translations in the meantime. Anyhow the Content Element
uploads does not benefit from that, as it hardcodes the uid
of the related element and therefore the automatic logic
recognizing translations does not work.

Remove the affected line of TypoScript.

Change-Id: Ia70272a2d646c2d29eca311c44dc6a0706d1778c
Releases: 6.0
Fixes: #40607
Reviewed-on: http://review.typo3.org/16363
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Improve rendering of non existent content types
Georg Ringer [Mon, 5 Nov 2012 23:23:46 +0000 (00:23 +0100)]
[TASK] Improve rendering of non existent content types

If a custom content element is created by using
an extension and the ext is removed, an empty content
element is rendered in the page module.

Now the same warning is shown as if a non existent
plugin is rendered

Change-Id: Ib98ff3fdf17d7383b51e6c108854a2fc34d5def4
Resolves: #42510
Releases: 6.0
Reviewed-on: http://review.typo3.org/16223
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Add configuration for default categorized tables
Fabien Udriot [Fri, 6 Jul 2012 15:25:51 +0000 (17:25 +0200)]
[TASK] Add configuration for default categorized tables

A list of default categorized tables is put within the Install Tool
for now, since we don't have a dedicated BE module for category

Change-Id: I1b620652a09ae9712cbd5cd38a8bed8ab8605b6e
Resolves: #38716
Releases: 6.0
Reviewed-on: http://review.typo3.org/12674
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Raise submodule pointer
Helmut Hummel [Thu, 8 Nov 2012 23:26:02 +0000 (00:26 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ia33701578c100bb67beb66d010f76208d9c16457
Reviewed-on: http://review.typo3.org/16338
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix SEARCHRESULT content object
Helmut Hummel [Thu, 8 Nov 2012 22:54:06 +0000 (23:54 +0100)]
[BUGFIX] Fix SEARCHRESULT content object

During namespacing the SEARCHRESULT content object,
which had two classes, has been messed up.

Combine both classes into one.

Resolves: #42806
Releases: 6.0

Change-Id: If757121be3dc5c93d215dfbb958090ed39a7f507
Reviewed-on: http://review.typo3.org/16337
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix OTABLE content object
Helmut Hummel [Thu, 8 Nov 2012 22:40:53 +0000 (23:40 +0100)]
[BUGFIX] Fix OTABLE content object

During namespacing the OTABLE content object
which had of two classes has been messed up.

Combine both classes into one.

Resolves: #42805
Releases: 6.0

Change-Id: Ibc7a076cc6c9aa5fe3e3cfeff0dbb3db95ea5a2b
Reviewed-on: http://review.typo3.org/16336
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup alias map and recreate IDE file
Helmut Hummel [Thu, 8 Nov 2012 21:54:01 +0000 (22:54 +0100)]
[TASK] Cleanup alias map and recreate IDE file

Releases: 6.0

Change-Id: I0f8863ae6e711f1da710b39f7644f24212ad41ef
Reviewed-on: http://review.typo3.org/16330
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Add "Abstract" prefix to abstract task class
Helmut Hummel [Thu, 8 Nov 2012 21:34:05 +0000 (22:34 +0100)]
[TASK] Add "Abstract" prefix to abstract task class

All abstract classes should be start with an Abstract
prefix in the class name.

Adjust the abstract task class to this naming convention.

Resolves: #42803
Releases: 6.0

Change-Id: Ibef1d71f1d3a6aa3683331464b33118b88b1ec01
Reviewed-on: http://review.typo3.org/16329
Reviewed-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Update version number in system extensions
Michael Klapper [Tue, 6 Nov 2012 13:52:40 +0000 (14:52 +0100)]
[TASK] Update version number in system extensions

Update the version number in system extensions which
have been forgotten.

Resolves: #42728
Releases: 6.0
Change-Id: I05089f5f0706f3df685bccc68ab8915620f90609
Reviewed-on: http://review.typo3.org/16235
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michael Klapper
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[SECURITY] Fix SQL injection and XSS in record history
Oliver Hader [Thu, 8 Nov 2012 11:44:57 +0000 (12:44 +0100)]
[SECURITY] Fix SQL injection and XSS in record history

This patch fixes the SQL injection possibilities in the record
history view as well as fixing XSS possibilities. The submitted
GET/POST data gets sanitized now besides that.

Change-Id: Ia92b5f7a2244412f87d9affdd73d2e0a6f7076ef
Fixes: #42696
Releases: 6.0, 4.7, 4.6, 4.5
Security-Commit: a386933537b6193d3a3d7173721c5b3b961a7f0d
Security-Bulletin: TYPO3-CORE-SA-2012-005
Reviewed-on: http://review.typo3.org/16307
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] XSS in TCA Tree
Oliver Hader [Thu, 8 Nov 2012 11:44:51 +0000 (12:44 +0100)]
[SECURITY] XSS in TCA Tree

Properly html encode the label of tree nodes.

Fixes: #42774
Releases: 6.0, 4.7, 4.6, 4.5

Change-Id: I56b823bdd7ac8f4e8d533604cc91eb99e3bcd808
Security-Commit: b1b0b68d026795d04721f73c436eab2de72285d9
Security-Bulletin: TYPO3-CORE-SA-2012-005
Reviewed-on: http://review.typo3.org/16306
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Fix potential XSS in BackendUtlility::getFuncCheck
Helmut Hummel [Thu, 8 Nov 2012 11:44:45 +0000 (12:44 +0100)]
[SECURITY] Fix potential XSS in BackendUtlility::getFuncCheck

The method getFuncCheck creates an URL from input variables and puts
it in JavaScript context without properly encoding them.

This might lead to XSS if the input variables come from untrusted source.

Fixes: #42776
Releases: 6.0, 4.7, 4.6, 4.5

Change-Id: Ia312e96791bc23460462c2374c0d08f47f762447
Security-Bulletin: TYPO3-CORE-SA-2012-005
Reviewed-on: http://review.typo3.org/16305
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Raise submodule pointer for fluid
Helmut Hummel [Thu, 8 Nov 2012 10:04:13 +0000 (11:04 +0100)]
[TASK] Raise submodule pointer for fluid

Releases: 6.0

Change-Id: I490683562533dfbfaa34310a04f7682cde91f0d2
Reviewed-on: http://review.typo3.org/16294
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Raise submodule pointer
TYPO3 Release Team [Thu, 8 Nov 2012 09:32:20 +0000 (10:32 +0100)]
[TASK] Raise submodule pointer

Change-Id: I2e83cbd81b729242404f0fc8ef553f663ae87073
Reviewed-on: http://review.typo3.org/16290
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Make hardcoded backend favicon configurable
Johannes Feustel [Fri, 2 Nov 2012 21:51:07 +0000 (22:51 +0100)]
[BUGFIX] Make hardcoded backend favicon configurable

Since #37868 the backend comes with hardcoded favicon.
This should be configurable like logo_login to brand
the backend for certain projects and for better usability
when working with multiple projects.

Change-Id: Icc0f9c3f764c92a39ea46b5af749d57e2d2b30dc
Resolves: #39947
Releases: 6.0
Reviewed-on: http://review.typo3.org/13906
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[TASK] Fix PHPdoc of methods and type hint comments
Oliver Hader [Wed, 7 Nov 2012 22:39:16 +0000 (23:39 +0100)]
[TASK] Fix PHPdoc of methods and type hint comments

Change-Id: I3c3078b6e69f937d4383eb8677dbd60f249d2c8d
Releases: 6.0
Reviewed-on: http://review.typo3.org/16276
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Editors do not have rights to edit file metadata
Steffen Ritter [Mon, 3 Sep 2012 07:31:09 +0000 (09:31 +0200)]
[TASK] Editors do not have rights to edit file metadata

File records are stored in PID 0. In TYPO3 non-admins do not
have access to anything stored in PID 0. As FAL won't work
without granting access to file-meta-data for non-admins,

A new TCA control configuration allows to ignore those
permission restrictions for sys_file and sys_file_reference:

* TCA/<table>/ctrl/security/ignoreWebMountRestriction
  Allows users to access records that are not in their
  defined web-mount and by-passes this restriction..
* TCA/<table>/ctrl/security/ignoreRootLevelRestriction
  Allows users (non-admins) to access records that are
  stored on the root-level (page-id 0) and by-passes this
  restriction.

Change-Id: If92b07b0ba63a0d544a337ddf4f55973fafcd345
Fixes: #39805
Releases: 6.0
Reviewed-on: http://review.typo3.org/13658
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Fix include path in file "t3lib/class.t3lib_cli.php"
Michael Klapper [Tue, 6 Nov 2012 15:18:44 +0000 (16:18 +0100)]
[BUGFIX] Fix include path in file "t3lib/class.t3lib_cli.php"

Resolves: #42731
Releases: 6.0

Change-Id: Icd08c7e9d1bb9f014ce77aae697e804aa4e17625
Reviewed-on: http://review.typo3.org/16238
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Migrate images and links to files to FAL on way to RTE
Stanislas Rolland [Tue, 9 Oct 2012 22:00:28 +0000 (00:00 +0200)]
[BUGFIX] Migrate images and links to files to FAL on way to RTE

Links to files or folders in pre-FAL RTE-content should be transformed
to FAL-compliant on way to RTE, whenever possible, otherwise they are
viewed as external links.
FAL-related attributes should also be added to images, whenever
possible, on way to the RTE.

Change-Id: I17e649986a57865fee738575be058c53ac30a50d
Releases: 6.0
Fixess: #36827
Reviewed-on: http://review.typo3.org/10984
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Change the default doctype to html5
Georg Ringer [Mon, 5 Nov 2012 23:00:34 +0000 (00:00 +0100)]
[FEATURE] Change the default doctype to html5

Change-Id: If99bd9fb5357a39660f44a79f88cdd22528be3d8
Resolves: #39957
Releases: 6.0
Reviewed-on: http://review.typo3.org/13952
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Drag&Drop of Content-Elements in Page-Module
Jigal van Hemert [Wed, 26 Sep 2012 18:20:08 +0000 (20:20 +0200)]
[TASK] Drag&Drop of Content-Elements in Page-Module

Change-Id: I1fca2b537f134b57f3161d6ae636c6d9e67012e0
Resolves: #17198
Releases: 6.0
Reviewed-on: http://review.typo3.org/15103
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] EM: Improve appearance of "get extensions"
Hans Christian Reinl [Tue, 23 Oct 2012 19:48:22 +0000 (21:48 +0200)]
[TASK] EM: Improve appearance of "get extensions"

* Change order of table-heads to reflect scribble better
* Include link to all version of extensions as arrow
* Move details of author into description and hide for now
* Move loading mask on extension table

Resolves: #42327
Releases: 6.0

Change-Id: I9e042f972a77e09482a5eeab429214bb13108f71
Reviewed-on: http://review.typo3.org/15916
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel