Packages/TYPO3.CMS.git
12 months ago[TASK] Replace static variable with class variable in FileInfo 67/56867/7
Anja Leichsenring [Sun, 6 May 2018 06:48:14 +0000 (08:48 +0200)]
[TASK] Replace static variable with class variable in FileInfo

By removing the graphicFunctions object from global scope, unit
tests are easier to add in this area.

Change-Id: I8ddf4e0282d42325ecb03c98bede91bf6e1b636c
Resolves: #84933
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56867
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[BUGFIX] Avoid calling frontend page preparations twice 98/56898/2
Helmut Hummel [Wed, 9 May 2018 09:49:07 +0000 (11:49 +0200)]
[BUGFIX] Avoid calling frontend page preparations twice

With the introduced cleanup, one removed condition was
essential to avoid calling page rendering preparations twice.

Resolves: #84945
Releases: master
Change-Id: Ic7b977b2d2c52dc619686f95e9001eed4202717b
Reviewed-on: https://review.typo3.org/56898
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Remove two unneeded packages from composer.lock 97/56897/2
Christian Kuhn [Wed, 9 May 2018 08:22:28 +0000 (10:22 +0200)]
[TASK] Remove two unneeded packages from composer.lock

Two packages are defined in composer.lock that are no
dependents of any other package. Remove them:

composer remove symfony/polyfill-php54 gecko-packages/gecko-php-unit

Change-Id: I1051c78b8f7101e3aa07f543df275b2917a6dd44
Resolves: #84952
Releases: master
Reviewed-on: https://review.typo3.org/56897
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Add unit tests for ImageInfo 68/56868/4
Anja Leichsenring [Sun, 6 May 2018 07:33:09 +0000 (09:33 +0200)]
[TASK] Add unit tests for ImageInfo

Change-Id: I3d9ef96e3296de676d02aa84a5ebd926b10cae53
Resolves: #84934
Relates: #84583
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Simplify frontend page generation code 84/56884/4
Helmut Hummel [Tue, 1 May 2018 16:57:06 +0000 (18:57 +0200)]
[TASK] Simplify frontend page generation code

The additional isINTincScript check stems from the time
where this code was in a separate file, which
was included two times and page generation should be
skipped for the second inclusion. As INT scripts are only generated
during page rendering (or when fetching the page from cache)
we can safely remove this condition now.

Additionally, we can now easily get rid of the elseif
and move the page rendering preparation directly
after the same condition is checked later in the code flow.

This is fine, because this code does not need to be
executed before the lock is released. Last but not least
we clean up admin panel messages to clearly distinguish
between page generation and rendering preparation.

As this is a pure non breaking cleanup, this can
safely go into 8.7 branch as well.

Resolves: #84945
Releases: master, 8.7
Change-Id: If12b82a549d4cc47619c46f73c5423df70621b1b
Reviewed-on: https://review.typo3.org/56884
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
12 months ago[TASK] Make failing acceptance tests after image update run again 85/56885/12
Anja Leichsenring [Sun, 6 May 2018 20:27:16 +0000 (22:27 +0200)]
[TASK] Make failing acceptance tests after image update run again

The agent update introduced a higher chromedriver version that
caused several acceptance tests to fail. Adjusting wait states
brings them back to green.

The bamboo plan update now uses a php.ini without xdebug and
simplifies the unit test runs in this area, too.

And we need a patch for typo3/testing-framework version 3.4.2:
composer update typo3/testing-framework

Change-Id: Icc7b6b062ad652db2c92ae7a7c5197477abf2b7d
Resolves: #84939
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56885
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[BUGFIX] Set correct foreign parentkey when writing inline relations 96/46996/3
Philipp Wrann [Wed, 2 Mar 2016 12:46:39 +0000 (13:46 +0100)]
[BUGFIX] Set correct foreign parentkey when writing inline relations

When attaching or updating 1:N relations via extbase (INLINE) the
parents uid property was taken as parentKey for the relation entity.

This behaviour is inconsistant to the FormEngine resulting in
wrong weird rendering resconstitution of 1:N relations.

This patch sets the _localizedUid of the parent object (if set)
as parentKey to the parentKeyFieldColumn.

Resolves: #73726
Releases: master
Change-Id: I47fa0f05eb46353f5b893fff07f0123325a0d515
Reviewed-on: https://review.typo3.org/46996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Migrate ContextMenu to TypeScript 65/56865/2
Andreas Fernandez [Sat, 5 May 2018 20:20:24 +0000 (22:20 +0200)]
[TASK] Migrate ContextMenu to TypeScript

Resolves: #82579
Releases: master
Change-Id: I58165fff637ca72e921057e9441f6bc73f175808
Reviewed-on: https://review.typo3.org/56865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Make new toggle checkboxes keyboard accessible 71/56871/3
Carsten Dietrich [Sun, 6 May 2018 12:40:01 +0000 (14:40 +0200)]
[TASK] Make new toggle checkboxes keyboard accessible

Make the checkbox input field transparent, instead of hiding it completely,
so it can still be accessed via keyboard.

Use the :focus CSS pseudo-class to highlight the input label
with a box shadow, similar to current text input fields.

Resolves: #84936
Releases: master
Change-Id: I9e176cea1517617c978f05b63d881ab6af99380f
Reviewed-on: https://review.typo3.org/56871
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Make core/Tests/Unit/Package/ notice free 60/56760/2
Jan Helke [Fri, 20 Apr 2018 16:05:24 +0000 (18:05 +0200)]
[TASK] Make core/Tests/Unit/Package/ notice free

Releases: master
Resolves: #84817
Change-Id: Id3d2cc7c47c7ba3ff46b8689970a3c8490261802
Reviewed-on: https://review.typo3.org/56760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Have bamboo plan updates and minor ac test stabilization 83/56883/2
Christian Kuhn [Mon, 7 May 2018 17:09:11 +0000 (19:09 +0200)]
[TASK] Have bamboo plan updates and minor ac test stabilization

* bamboo composer environment is a9.3.0@dev
* Adapt a test result parsing to slightly changed git
  output in younger versions
* Raise a timeout when installing introduction package in ac
  tests for less false positives.

Resolves: #84944
Releases: master
Change-Id: I3f0ec103985a96d05d4a42fab8edd92fad219114
Reviewed-on: https://review.typo3.org/56883
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Simplify fetching section labels in global settings 76/56876/5
Helmut Hummel [Sun, 6 May 2018 18:16:50 +0000 (20:16 +0200)]
[TASK] Simplify fetching section labels in global settings

Put labels into the configuration description file
to have everything in one place.

With that in place, we can put the description directly
into the configuration data that is prepared for the edit view.

If we do so, we can get rid of the view helper
and one method in the configuration service which only
returned the labels.

Resolves: #84938
Releases: master
Change-Id: I12e5cf1ce3873d41789a52e41e6bac87da86cf9e
Reviewed-on: https://review.typo3.org/56876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[TASK] Cleanup workspaces backend AJAX calls 72/56872/2
Benni Mack [Sun, 6 May 2018 14:24:07 +0000 (16:24 +0200)]
[TASK] Cleanup workspaces backend AJAX calls

The AJAX endpoints for the workspaces backend module
on the PHP side still are 1:1 like the good old ExtJS times.

In order to abstract and separate concerns in this area,
and make the AJAX-based endpoints true PSR-7 compliant
requests and responses, some cleanups are necessary.

In this first step, the AbstractHandler is removed,
as some methods can be removed or simplified in the
child classes.

Resolves: #84937
Releases: master
Change-Id: If390d4b51d19059b18f579691371669c27a337d4
Reviewed-on: https://review.typo3.org/56872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[FEATURE] Allow to sort subpages by nav title 66/56866/2
Benni Mack [Sat, 5 May 2018 20:50:40 +0000 (22:50 +0200)]
[FEATURE] Allow to sort subpages by nav title

The sort-subpages functionality available in the
context menu of a page now also allows to sort by
nav_title.

This also fixes a typo ("create" instead of "crdate") and
streamlines some templating functionality.

Resolves: #84932
Releases: master
Change-Id: I5a59745214c7cb1682e652efb865fcd949a0e413
Reviewed-on: https://review.typo3.org/56866
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[BUGFIX] Obsolete keywords in t3editor tokenizer 70/56870/2
Christian Kuhn [Sun, 6 May 2018 09:44:13 +0000 (11:44 +0200)]
[BUGFIX] Obsolete keywords in t3editor tokenizer

Some removed Page TSconfig related properties were
still found in the t3editor tokenizer keywords file.

Resolves: #84935
Releases: master
Change-Id: I89cf78cc3dc33fb6528bb1f4dad3943288a9b226
Reviewed-on: https://review.typo3.org/56870
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Update composer-dep enm1989/chromedriver 29/56129/7
Stefan Neufeind [Tue, 13 Mar 2018 10:40:40 +0000 (11:40 +0100)]
[TASK] Update composer-dep enm1989/chromedriver

Minor-update 2.33 to 2.38

Command used:
composer update enm1989/chromedriver

Resolves: #84238
Releases: master, 8.7
Change-Id: Ic15ba59fb8706134c36b1ee36147272342440707
Reviewed-on: https://review.typo3.org/56129
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[BUGFIX] Do not copy icon of former EXT:lang during build 64/56864/2
Andreas Fernandez [Sat, 5 May 2018 14:37:48 +0000 (16:37 +0200)]
[BUGFIX] Do not copy icon of former EXT:lang during build

The `grunt build` command copies icons of the icon repository into
different locations. Since EXT:lang does not exist anymore, the icon of
the former extension must not be copied into the now invalid location.

The configuration is removed from the Gruntfile to avoid a re-creation of
the extension directory.

Resolves: #84931
Related: #84680
Releases: master
Change-Id: I8387528ab074fab0a1e8a9bb492e69fa67490dce
Reviewed-on: https://review.typo3.org/56864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[!!!][FEATURE] Enhanced new MetaTag API 38/56738/46
Richard Haeser [Thu, 19 Apr 2018 13:43:50 +0000 (15:43 +0200)]
[!!!][FEATURE] Enhanced new MetaTag API

It is now possible to use a new MetaTag API having managers to handle
specific Meta Tag "families" like OpenGraph.

You can use the API by TypoScript and from PHP. It will use the
DependencyOrderingService to define the order of the managers.

Besides the managers shipped by core, you can also add and register
your own managers.

Resolves: #81464
Releases: master
Change-Id: I64f349c32e542087597f033eb48e4d218a5cd53c
Reviewed-on: https://review.typo3.org/56738
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[TASK] Make PageRepositoryTest notice free 24/56824/3
Sybille Peters [Sat, 28 Apr 2018 10:04:58 +0000 (12:04 +0200)]
[TASK] Make PageRepositoryTest notice free

Resolves: #84889
Releases: master
Change-Id: Ied9640b8cf664086a5533b910e5ff2b1a2e6aece
Reviewed-on: https://review.typo3.org/56824
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[FEATURE] Add TypoScript conditions based on the site configuration 11/56711/3
Georg Ringer [Tue, 17 Apr 2018 14:19:36 +0000 (16:19 +0200)]
[FEATURE] Add TypoScript conditions based on the site configuration

Two new TypoScript conditions are added to check for the currently
used site configuration of a Frontend Request.

[site = identifier = angelo]
[site = base = https://www.benni.com/]
[siteLanguage = typo3Language = default]
[siteLanguage = locale = de_CH.UTF-8]

Resolves: #84760
Releases: master
Change-Id: I6914211871de1cfc15c5ac0e4ed5ed2d245b39e8
Reviewed-on: https://review.typo3.org/56711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[FEATURE] Add scheduler task to anonymize IP addresses of tables 32/56732/9
Georg Ringer [Thu, 19 Apr 2018 11:36:03 +0000 (13:36 +0200)]
[FEATURE] Add scheduler task to anonymize IP addresses of tables

IP anonymizing improves the privacy of users and required as part of
the GDPR.

Resolves: #84781
Releases: master, 8.7, 7.6
Change-Id: Idd938136bed8f29e86b5e3e541c9fb8c9afd48ff
Reviewed-on: https://review.typo3.org/56732
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[TASK] Improve wording in maintenance section of Install Tool 48/56848/2
Georg Ringer [Thu, 3 May 2018 11:34:16 +0000 (13:34 +0200)]
[TASK] Improve wording in maintenance section of Install Tool

Use proper HTML markup to improve readability.

Resolves: #84912
Releases: master
Change-Id: I384b5b048ed39cf0ebae017e7a2f1dbb1b52bc49
Reviewed-on: https://review.typo3.org/56848
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
12 months ago[BUGFIX] Do not block UI rendering when checking for broken extensions 30/56830/5
Andreas Fernandez [Mon, 30 Apr 2018 07:57:20 +0000 (09:57 +0200)]
[BUGFIX] Do not block UI rendering when checking for broken extensions

This patch replaces the highly discouraged and deprecated `async: false`
approach by promises to un-block the UI rendering of the browser.

Resolves: #84898
Releases: master
Change-Id: I630fef820784c33758e713e6121c575577af91ed
Reviewed-on: https://review.typo3.org/56830
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Move page rendering preparations into middleware 33/56833/2
Helmut Hummel [Tue, 1 May 2018 12:19:33 +0000 (14:19 +0200)]
[TASK] Move page rendering preparations into middleware

In the course of making TSFE request/response aware,
we split the rendering preparations of TSFE
into a PSR-15 middleware.

This the first step to extract other parts, like
redirecting to shortcuts/ mountpoints and sending
http headers as well into middleware implementations.

Resolves: #84909
Releases: master
Change-Id: I704ae89a23c8e254574e19a78ecec363f182c747
Reviewed-on: https://review.typo3.org/56833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[FEATURE] Add RuntimeCacheWriter to Logging Framework 28/56828/2
Susanne Moog [Sun, 29 Apr 2018 16:07:32 +0000 (18:07 +0200)]
[FEATURE] Add RuntimeCacheWriter to Logging Framework

To be able to easily log request specific information
via the logging framework a new log writer has been
introduced which writes into the TYPO3 runtime cache.

Related: #84044
Resolves: #84894
Releases: master
Change-Id: I0c868d775c9ffe4d4711338778cf6202200c575c
Reviewed-on: https://review.typo3.org/56828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Inform user if TS condition does not make sense 35/56835/4
Markus Klein [Wed, 2 May 2018 22:23:05 +0000 (00:23 +0200)]
[TASK] Inform user if TS condition does not make sense

Empty conditions `[]` always evaluate to false. Warn the user
if such a condition is present.

Resolves: #84911
Releases: master, 8.7
Change-Id: I499e64aad30e29fe3698c40fed57e1f1c87ce885
Reviewed-on: https://review.typo3.org/56835
Reviewed-by: Robert Wildling <robertwildling@gmail.com>
Tested-by: Robert Wildling <robertwildling@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[TASK] Use later hook for rendering of adminPanel 27/56827/2
Susanne Moog [Sun, 29 Apr 2018 15:50:51 +0000 (17:50 +0200)]
[TASK] Use later hook for rendering of adminPanel

The admin panel should be rendered as late as possible
to display a mostly complete set of data.

Relates: #84044
Resolves: #84893
Releases: master
Change-Id: Ib06dbfed15318492247353275b079e2f03249fa5
Reviewed-on: https://review.typo3.org/56827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[BUGFIX] Streamline and move labels for checkboxes 32/56832/3
Frank Naegler [Mon, 30 Apr 2018 17:30:40 +0000 (19:30 +0200)]
[BUGFIX] Streamline and move labels for checkboxes

This patch is a followup patch for the checkbox toggle switch
changes. Labels are moved into correct positions and fixed in
case of a wrong reference.

Resolves: #84903
Releases: master
Change-Id: Ic32055b0c88b70cafe680379bf0a405eda0e685d
Reviewed-on: https://review.typo3.org/56832
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
12 months ago[TASK] Use "assets" cache for t3editor configuration 11/56811/4
Andreas Fernandez [Wed, 25 Apr 2018 16:28:16 +0000 (18:28 +0200)]
[TASK] Use "assets" cache for t3editor configuration

The t3editor cache is now stored in the `assets` cache, as `cache_core`
is discouraged for extensions.
As the cache only needs to store JavaScript-based configuration, this is
also a more appropriate cache.

Resolves: #84875
Releases: master
Change-Id: If77e6f91b4a540259fbd5b45a30ba441b110130c
Reviewed-on: https://review.typo3.org/56811
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
12 months ago[BUGFIX] Prevent re-initialization of logger in SignalSlot Dispatcher 23/56823/5
Nicole Cordes [Sat, 28 Apr 2018 06:35:25 +0000 (08:35 +0200)]
[BUGFIX] Prevent re-initialization of logger in SignalSlot Dispatcher

Resolves: #84890
Releases: master
Change-Id: I41917d5d9feab62701da893c5c4c7ba08e5fbc58
Reviewed-on: https://review.typo3.org/56823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[TASK] Make core/Tests/Unit/Database/ notice free 60/56660/5
Jan Helke [Sat, 14 Apr 2018 14:57:46 +0000 (16:57 +0200)]
[TASK] Make core/Tests/Unit/Database/ notice free

Releases: master
Resolves: #84723
Change-Id: I4ed49cd7002fa8a0c002222c54249d714e91a379
Reviewed-on: https://review.typo3.org/56660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
12 months ago[TASK] Log signal dispatching to debug log 22/56822/2
Susanne Moog [Fri, 27 Apr 2018 09:37:34 +0000 (11:37 +0200)]
[TASK] Log signal dispatching to debug log

To be able to find out which signals are triggered
during requests debug logging has been implemented
in the SignalSlotDispatcher.

Related: #84044
Resolves: #84888
Releases: master
Change-Id: I2c25c51644e8294848f8f053908984d85c5a1e83
Reviewed-on: https://review.typo3.org/56822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[TASK] Replace PATH_thisScript with Environment API call 19/56819/2
Benni Mack [Thu, 26 Apr 2018 16:46:01 +0000 (18:46 +0200)]
[TASK] Replace PATH_thisScript with Environment API call

All occurrences in the TYPO3 core have been replaced with
Environment::getCurrentScript() in order to slowly migrate
away from constants, and also detect dependencies to Environment
related functionality easier.

Resolves: #84883
Releases: master
Change-Id: I5197020bb539d9471cfa2aa3c7a09fa4b1a7d83c
Reviewed-on: https://review.typo3.org/56819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Change checkboxes in sys_file_storage 56/56756/7
Ingo Nolden [Fri, 20 Apr 2018 14:04:29 +0000 (16:04 +0200)]
[TASK] Change checkboxes in sys_file_storage

Some checkboxes are changed to new rendertype checkboxToggle.
One checkbox is type => user and the rendering is adapted
in the userFunc.

Resolves: #84813
Related: #84793
Release: master
Change-Id: Id61ee825d2bcf026ef39427bfdded88c90245cd1
Reviewed-on: https://review.typo3.org/56756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[TASK] Amend Installer text 83/56783/5
Tom Warwick [Mon, 23 Apr 2018 08:54:01 +0000 (09:54 +0100)]
[TASK] Amend Installer text

This commit is intended to improve the language
used in the Installer.

[+] Review each paragraph and amend if required
[+] Consistent buttons names

[-] Remove unnecessary text that is not relevant
to the installation process.

Resolves: #84839
Releases: master

Change-Id: I1288f3942214cc2687b8e5ef0d51f678f2d5bc23
Reviewed-on: https://review.typo3.org/56783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Change checkboxes in tx_scheduler_task_group and index_config 68/56768/7
Ingo Nolden [Fri, 20 Apr 2018 20:33:19 +0000 (22:33 +0200)]
[TASK] Change checkboxes in tx_scheduler_task_group and index_config

Some checkboxes are changed to new rendertype checkboxToggle.

Resolves: #84829
Related: #84793
Releases: master
Change-Id: I5862378e03dcd5c1c9e5e7ca510997d662c8ff69
Reviewed-on: https://review.typo3.org/56768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
12 months ago[TASK] Change checkboxes in be_groups and be_users to new rendertype 41/56741/10
Ingo Nolden [Thu, 19 Apr 2018 16:17:05 +0000 (18:17 +0200)]
[TASK] Change checkboxes in be_groups and be_users to new rendertype

Some checkboxes are changed to new rendertype checkboxToggle.
One checkbox label (IPlockState) is added.

Resolves: #84794
Related: #84793
Releases: master
Change-Id: I6acc23d5e72e561e5cb84de84d73abe15a3839fd
Reviewed-on: https://review.typo3.org/56741
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
12 months ago[TASK] Change checkboxes in pages to new rendertype 47/56747/7
Ingo Nolden [Thu, 19 Apr 2018 19:39:34 +0000 (21:39 +0200)]
[TASK] Change checkboxes in pages to new rendertype

Some checkboxes are changed to new rendertype checkboxToggle.
Four checkbox labels are added.

Resolves: #84796
Related: #84793
Releases: master
Change-Id: Icdda84d1682e87ceff404068be1ae97264a2efb2
Reviewed-on: https://review.typo3.org/56747
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
12 months ago[TASK] Change checkboxes in tt_content 67/56767/6
Ingo Nolden [Fri, 20 Apr 2018 19:47:52 +0000 (21:47 +0200)]
[TASK] Change checkboxes in tt_content

Some checkboxes are changed to new rendertype checkboxToggle.

Resolves: #84828
Related: #84793
Release: master
Change-Id: Id6d0305a19e6bd82609dae8bf0817119bdf53a5c
Reviewed-on: https://review.typo3.org/56767
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
12 months ago[FEATURE] Introduce fluid data-processor for language menus 97/56597/19
Simon Gilli [Fri, 6 Apr 2018 19:00:04 +0000 (21:00 +0200)]
[FEATURE] Introduce fluid data-processor for language menus

The HMENU is extended to support the auto filling of the special.value
with all languages defined for the current site. To each menu item the
corresponding SiteLanguage is appended as array to be available at
TypoScript.

This menu processor utilizes HMENU to generate a json encoded language
menu string that will be decoded again and assigned to FLUIDTEMPLATE as
variable.

Resolves: #84650
Resolves: #84775
Releases: master
Depends: #Iabeeb6835a98c8f5a71d502379ed63a68dfad6dd
Change-Id: I5b602256962deb47e89fc190401dc0281dc5ebb0
Reviewed-on: https://review.typo3.org/56597
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
12 months ago[BUGFIX] ErrorController is called via PSR-7 request 96/56796/2
Benni Mack [Wed, 25 Apr 2018 05:40:27 +0000 (07:40 +0200)]
[BUGFIX] ErrorController is called via PSR-7 request

One call to the ErrorController->pageNotFoundAction is missing the PSR-7
object, which is now added.

Resolves: #84858
Releases: master
Change-Id: Ie0339e055400a615f33dc3435c95e2a78875202f
Reviewed-on: https://review.typo3.org/56796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
12 months ago[TASK] Replace TYPO3_OS constant with Environment check 92/56792/6
Benni Mack [Wed, 25 Apr 2018 04:22:15 +0000 (06:22 +0200)]
[TASK] Replace TYPO3_OS constant with Environment check

In order to move away from using hard-coded constants,
the Environment class method "isWindows" is used.

Resolves: #84854
Releases: master
Change-Id: I30bc72017d00caafe9dfef912c52044a6cd03338
Reviewed-on: https://review.typo3.org/56792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Update testing framework to latest version 18/56818/2
Susanne Moog [Thu, 26 Apr 2018 15:50:36 +0000 (17:50 +0200)]
[TASK] Update testing framework to latest version

composer command:
- composer update typo3/testing-framework

Resolves: #84882
Releases: master
Change-Id: Ie6cfcf1417b095048cb9fec61ceffbf90ef03d9e
Reviewed-on: https://review.typo3.org/56818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
12 months ago[TASK] Change checkboxes in sys_action and sys_note 63/56763/4
Ingo Nolden [Fri, 20 Apr 2018 18:52:32 +0000 (20:52 +0200)]
[TASK] Change checkboxes in sys_action and sys_note

Checkboxes are changed to new rendertype checkboxToggle in the following files:
sys_note
sys_action

This patch requires patch https://review.typo3.org/c/56736

Resolves: #84824
Related: #84793
Release: master
Change-Id: I9985f78774574017ec1af616d8cd682875b8d875
Reviewed-on: https://review.typo3.org/56763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Tested-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Change checkboxes in sys_workspace 70/56770/4
Ingo Nolden [Fri, 20 Apr 2018 20:43:23 +0000 (22:43 +0200)]
[TASK] Change checkboxes in sys_workspace

Two checkboxes are changed to new rendertype checkboxToggle.

Resolves: #84830
Related: #84793
Releases: master
Change-Id: I23c6a23c0080fa7968245cb4f527fea3ac322c45
Reviewed-on: https://review.typo3.org/56770
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Change checkboxes in EXT: core TCA files 55/56755/5
Ingo Nolden [Fri, 20 Apr 2018 13:55:28 +0000 (15:55 +0200)]
[TASK] Change checkboxes in EXT: core TCA files

Checkboxes are changed to new rendertype checkboxToggle in the following
files:
sys_category
sys_collection
sys_file_collection
sys_file_reference
sys_filemounts
sys_language
sys_news

Resolves: #84812
Related: #84793
Releases: master
Change-Id: Id3c1280d403a97c6dc023dc98bc12311b13e6bce
Reviewed-on: https://review.typo3.org/56755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Change checkboxes in sys_redirect 58/56758/7
Ingo Nolden [Fri, 20 Apr 2018 15:33:02 +0000 (17:33 +0200)]
[TASK] Change checkboxes in sys_redirect

Some checkboxes are changed to new rendertype checkboxToggle.
One checkbox label (hitcountState) is added.
This patch requires patch #56736 and #56745

Resolves: #84815
Related: #84793
Releases: master
Change-Id: Ic9d182bc9a4267b1107ca5c67a4176df01686240
Reviewed-on: https://review.typo3.org/56758
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Change checkboxes in EXT:frontend TCA files 61/56761/7
Ingo Nolden [Fri, 20 Apr 2018 16:13:34 +0000 (18:13 +0200)]
[TASK] Change checkboxes in EXT:frontend TCA files

Some checkboxes are changed to new rendertype checkboxToggle in:
sys_domain
sys_template
backend_layout

Resolves: #84819
Related: #84793
Releases: master
Change-Id: I5cf3298a624c78363b7784abf32d11f10144a129
Reviewed-on: https://review.typo3.org/56761
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Change checkboxes in fe_users and fe_groups 62/56762/6
Ingo Nolden [Fri, 20 Apr 2018 16:24:57 +0000 (18:24 +0200)]
[TASK] Change checkboxes in fe_users and fe_groups

Some checkboxes are changed to new rendertype checkboxToggle.

Resolves: #84820
Related: #84793
Releases: master
Change-Id: I5a9cbcf674dd8641d275eb8c520a846b0716d15c
Reviewed-on: https://review.typo3.org/56762
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[BUGFIX] Catch exceptions for invalid form configuration files 97/56797/2
Benni Mack [Wed, 25 Apr 2018 06:39:05 +0000 (08:39 +0200)]
[BUGFIX] Catch exceptions for invalid form configuration files

Resolves: #84859
Releases: master, 8.7
Change-Id: I64b14c87758178f76258bdbf747931b008d9a71c
Reviewed-on: https://review.typo3.org/56797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Ensure webmounts in list module are calculated only once 05/56805/3
Benni Mack [Wed, 25 Apr 2018 13:46:28 +0000 (15:46 +0200)]
[BUGFIX] Ensure webmounts in list module are calculated only once

When using the backend search the list module is fetching the list of
PIDs to recursively look for every single TCA table.

A runtime cache is added in order to only look up this information once
per request.

Resolves: #84869
Releases: master, 8.7
Change-Id: Iad9af42a5ba88324da1f23fc354847bc96d9331d
Reviewed-on: https://review.typo3.org/56805
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Correctly check for a key in getPageForRootline 04/56804/3
Tymoteusz Motylewski [Wed, 25 Apr 2018 10:58:02 +0000 (12:58 +0200)]
[BUGFIX] Correctly check for a key in getPageForRootline

Move coalescing operator to inside is_array. It was was introduced
in https://review.typo3.org/#/c/54558/

Releases: master, 8.7
Resolves: #84868
Related: #82921
Change-Id: I54e60cd3fbd2ab36e945cd2e2ed9c6fc02a5bf5a
Reviewed-on: https://review.typo3.org/56804
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[BUGFIX] Only show default language pages for sorting 08/56808/2
Benni Mack [Wed, 25 Apr 2018 15:31:28 +0000 (17:31 +0200)]
[BUGFIX] Only show default language pages for sorting

The sorting of subpages also shows all translations
which leads to very bad side-effects due to the removal
of pages_language_overlay. This case wasn't fixed yet.

The query for fetching all subpages is now adapted to
only fetch pages with sys_language_uid=0.

Resolves: #84871
Releases: master
Change-Id: Id5e491db2d05fb03f297b4b843971ba8d45dfba9
Reviewed-on: https://review.typo3.org/56808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Respect multi-byte values in search sword 95/56795/2
Benni Mack [Wed, 25 Apr 2018 04:34:30 +0000 (06:34 +0200)]
[BUGFIX] Respect multi-byte values in search sword

Resolves: #84857
Releases: master, 8.7
Change-Id: I72563fad6233f0508273f6a75b2f7ab51894e501
Reviewed-on: https://review.typo3.org/56795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Skip extra rendering of fields in ElementInformation 75/56675/3
Georg Ringer [Mon, 16 Apr 2018 08:09:55 +0000 (10:09 +0200)]
[BUGFIX] Skip extra rendering of fields in ElementInformation

tstamp & crdate fields must be added in the TCA columns
section to have those available in extbase models. Skip
those 2 fields in the ElementInformationController rendering to
still show the date instead of the timestamp.

Resolves: #84737
Releases: master, 8.7
Change-Id: Idadff6eb5ada56b24c872468fa2c18c35d168a6a
Reviewed-on: https://review.typo3.org/56675
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Sort languages of field typo3Language in Site Management 91/56691/2
Georg Ringer [Mon, 16 Apr 2018 16:01:15 +0000 (18:01 +0200)]
[TASK] Sort languages of field typo3Language in Site Management

Sort the languages by its name instead of identifier.

Resolves: #84732
Releases: master
Change-Id: I0337cbc6a4003eb1b28b4523058b915b1712b4b2
Reviewed-on: https://review.typo3.org/56691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[!!!][TASK] Move last language files away from language extension 17/56017/17
Wouter Wolters [Mon, 5 Mar 2018 20:41:43 +0000 (21:41 +0100)]
[!!!][TASK] Move last language files away from language extension

This commit moves any language file of EXT:lang into a proper
destination, which renders EXT:lang obsolete.
This change requires an update of typo3/testing-framework, done with this
command:

composer update typo3/testing-framework

Resolves: #84680
Releases: master
Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d
Reviewed-on: https://review.typo3.org/56017
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Validate column count before using it 80/56680/2
Georg Ringer [Mon, 16 Apr 2018 10:40:37 +0000 (12:40 +0200)]
[BUGFIX] Validate column count before using it

Fix a regression introduced with #84338 to check the column count
first before using it.

Resolves: #84491
Releases: master
Change-Id: I7dbfc7f59a3e79bc69ddbca946888f86d96f5fed
Reviewed-on: https://review.typo3.org/56680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Fix spelling in InheritancesResolverService 00/56800/2
Benni Mack [Wed, 25 Apr 2018 07:07:29 +0000 (09:07 +0200)]
[BUGFIX] Fix spelling in InheritancesResolverService

Resolves: #84862
Releases: master
Change-Id: I40bff1e106efad9c43780e2df1e6ddb54b64fd1f
Reviewed-on: https://review.typo3.org/56800
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
13 months ago[TASK] Move TypoScript inclusion into ext_localconf 99/56799/2
Benni Mack [Wed, 25 Apr 2018 07:04:15 +0000 (09:04 +0200)]
[TASK] Move TypoScript inclusion into ext_localconf

The Form configuration is now included inline instead
of a separate file.

Resolves: #84861
Releases: master
Change-Id: I06b0ca7b0f650c6701069ab3f11005e78b48d67a
Reviewed-on: https://review.typo3.org/56799
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Remove legacy styling in Web->Template module 94/56794/2
Benni Mack [Wed, 25 Apr 2018 04:32:12 +0000 (06:32 +0200)]
[TASK] Remove legacy styling in Web->Template module

Some values (bgColor4) for rendering the tree in the Web->Template module
are never used, and are removed as they are not in use anymore since TYPO3 v7.

Resolves: #84856
Releases: master
Change-Id: Ie3cd0d1e36de29036dc1442849f7fbd76548fd93
Reviewed-on: https://review.typo3.org/56794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Add tests for BackendUtility::splitTable_Uid 93/56793/2
Benni Mack [Wed, 25 Apr 2018 04:29:12 +0000 (06:29 +0200)]
[TASK] Add tests for BackendUtility::splitTable_Uid

Resolves: #84855
Releases: master
Change-Id: I20c189b082c616590bcb2bdabff9e2f2c22a1bce
Reviewed-on: https://review.typo3.org/56793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Remove double inclusion of PageTSconfig 98/56798/2
Benni Mack [Wed, 25 Apr 2018 06:43:03 +0000 (08:43 +0200)]
[BUGFIX] Remove double inclusion of PageTSconfig

Due to some mixup in patches the PageTSconfig for
the form framework is included twice.

Resolves: #84860
Releases: master
Change-Id: I0c18fc712e6b0076417e07b0666bb9e807928a62
Reviewed-on: https://review.typo3.org/56798
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
13 months ago[!!!][TASK] Update doctrine/dbal 2.6.3 ❯ 2.7.1 81/56681/6
Stefan Neufeind [Mon, 16 Apr 2018 11:26:36 +0000 (13:26 +0200)]
[!!!][TASK] Update doctrine/dbal 2.6.3 ❯ 2.7.1

Command used:
composer require doctrine/dbal:^2.7

Resolves: #84744
Releases: master
Change-Id: I7b063cd15d8bc7f9c466d654f890c6c56eeb3c25
Reviewed-on: https://review.typo3.org/56681
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[BUGFIX] Fix type of additionalConfig in media viewhelper 89/56789/2
Georg Ringer [Tue, 24 Apr 2018 13:54:24 +0000 (15:54 +0200)]
[BUGFIX] Fix type of additionalConfig in media viewhelper

Change the type from string to array.

Resolves: #84848
Releases: master, 8.7
Change-Id: I28071b1116b2c9b4fcdcc639c378b3b9c0503066
Reviewed-on: https://review.typo3.org/56789
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Add hook for resolving custom link types 30/56730/7
Daniel Goerz [Wed, 18 Apr 2018 17:11:42 +0000 (19:11 +0200)]
[TASK] Add hook for resolving custom link types

The extendability of the link wizard is incomplete since the
refactoring of it. This patch adds a missing hook to resolve custom
link syntax in the LinkService. It is now possible (again) to
resolve links that start with <identifier>:

Resolves: #79647
Releases: master, 8.7
Change-Id: Iaf0c18f72aa799ab44a8bd14bddd0ca6c3530198
Reviewed-on: https://review.typo3.org/56730
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[TASK] Correct description for QueryGenerator->getTreeList 87/56787/2
Tymoteusz Motylewski [Tue, 24 Apr 2018 13:26:26 +0000 (15:26 +0200)]
[TASK] Correct description for QueryGenerator->getTreeList

Resolves: #84847
Releases: master, 8.7
Change-Id: Ica8a5cc234c6ea90a1964c87228136d06d9713ac
Reviewed-on: https://review.typo3.org/56787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Add sorting to menu of categorized content 88/56688/3
Georg Ringer [Mon, 16 Apr 2018 14:27:58 +0000 (16:27 +0200)]
[BUGFIX] Add sorting to menu of categorized content

Sort content elements of menu type "categorized content" by the
sorting value.

This improves the output if all content elements are from the same page.

Resolves: #84739
Releases: master
Change-Id: Ib1701c8403f1e41fbdc9dd895a262c692cd73827
Reviewed-on: https://review.typo3.org/56688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
13 months ago[BUGFIX] Execution order of hooks preprocessRequest and pageIndexing changed 33/56733/2
Timo Hund [Thu, 19 Apr 2018 11:27:55 +0000 (13:27 +0200)]
[BUGFIX] Execution order of hooks preprocessRequest and pageIndexing changed

Between 8 LTS and 9.2 the order of the execution of the following hooks was changed:

8.7

- First: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest']
- Second: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing']

9.2

- First: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing']
- Second: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest']

This patch, changes the RequestMiddlewares configuration to do "typo3/cms-frontend/tsfe"
after "typo3/cms-frontend/eid"

Resolves: #84785
Releases: master
Change-Id: I215ee170774dd1b73f2e12519bc1b6ccf557e361
Reviewed-on: https://review.typo3.org/56733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[FEATURE] Password fields in the Install tool 81/56781/2
Guido Schmechel [Sun, 22 Apr 2018 17:23:12 +0000 (19:23 +0200)]
[FEATURE] Password fields in the Install tool

Now it is possible to define password fields in the Install tool
configuration.

Now the field transport_smtp_password uses a password field.

Resolves: #81794
Releases: master
Change-Id: Ia7c297e0f6676885ebe2089aabfd5ae8e3b1a3df
Reviewed-on: https://review.typo3.org/56781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[TASK] Use ImageInfo class instead of direct PHP GD call 22/56622/3
Markus Klein [Mon, 9 Apr 2018 22:01:21 +0000 (00:01 +0200)]
[TASK] Use ImageInfo class instead of direct PHP GD call

This ensures maximum compatibility with all available graphics
commands.

Resolves: #78600
Releases: master, 8.7
Change-Id: Id7a95fbdf7782fef59e18de3dc4522d7c68b690a
Reviewed-on: https://review.typo3.org/56622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Florian Weiss <typo3org@leblanc.at>
Tested-by: Florian Weiss <typo3org@leblanc.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
13 months ago[TASK] Add new language labels 36/56736/5
Ingo Nolden [Thu, 19 Apr 2018 13:07:45 +0000 (15:07 +0200)]
[TASK] Add new language labels

New labels for the new checkbox rendertypes.
The visibility checkbox in most record types uses the same language
label. The new rendertype checkboxToggle for the visibility checkbox
needs a new label to avoid breaking changes to checkboxes that don´t
get the new rendertype.

Resolves: #84795
Related: #84793
Release: master
Change-Id: Iff5714e505ff7af17c4fcb671e0b9a83cdb1ddaf
Reviewed-on: https://review.typo3.org/56736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Dirk Jüttner <dirk.juettner@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[!!!][TASK] Remove the explicitConfirmationOfTranslation setting 54/56754/9
Rens Admiraal [Fri, 20 Apr 2018 12:45:18 +0000 (14:45 +0200)]
[!!!][TASK] Remove the explicitConfirmationOfTranslation setting

This feature is unused, and the used buttons are being removed
in the "unsplit the split button" concept. This change removes
the buttons and installation tool setting.

Resolves: #84810
Releases: master
Change-Id: I0fa1f57df7e276b2d44f47c708cee78f08a43d81
Reviewed-on: https://review.typo3.org/56754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Always exclude E_USER_DEPRECATED from exceptionalErrors 52/56752/6
Helmut Hummel [Fri, 20 Apr 2018 10:28:28 +0000 (12:28 +0200)]
[BUGFIX] Always exclude E_USER_DEPRECATED from exceptionalErrors

There is a limited use case for exceptions to be thrown
on deprecation messages. To ease the upgrade path to TYPO3 9
and to not allow "accidental" configuration that breaks the system,
deprecation messages will never throw exceptions.

Users with other use cases, can still implement and configure their
own exception handler.

Resolves: #84802
Releases: master
Change-Id: Iebbc2c201ba8bb68fa5725b90fba516d37d168be
Reviewed-on: https://review.typo3.org/56752
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
13 months ago[BUGFIX] Resolve recursing DOM manipulation 72/56772/2
Andreas Fernandez [Sat, 21 Apr 2018 07:58:49 +0000 (09:58 +0200)]
[BUGFIX] Resolve recursing DOM manipulation

To fix the recursive DOM manipulation, the selector class name used to
find the "blueprint" is removed from the actual clone.

Resolves: #84832
Related: #84772
Releases: master
Change-Id: Id1a26ca9d20d95c8395998c6783715e677f16780
Reviewed-on: https://review.typo3.org/56772
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Hamid <ph@supertrumpf.at>
Tested-by: Philipp Hamid <ph@supertrumpf.at>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Use jQuery iterator for proper contextual variable handover 71/56771/2
Ralf Zimmermann [Fri, 20 Apr 2018 21:21:12 +0000 (23:21 +0200)]
[BUGFIX] Use jQuery iterator for proper contextual variable handover

Use jQuery's each() method to handover variables from within the loop
to objects which are decoupled through jQuery's promise() method.

Resolves: #84826
Releases: master
Change-Id: I140a586b2fd6a0483d415d4618dfcf148a466dea
Reviewed-on: https://review.typo3.org/56771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Harden CSS of install tool 66/56766/2
Philipp Hamid [Fri, 20 Apr 2018 19:44:23 +0000 (21:44 +0200)]
[BUGFIX] Harden CSS of install tool

Capsulated CSS classes in _module_install.scss.

Releases: master
Resolves: #84825
Change-Id: I664318f44e02bdf381856728938473820fd930d8
Reviewed-on: https://review.typo3.org/56766
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Make labeledToggleCheckbox localizable 45/56745/4
Mathias Schreiber [Thu, 19 Apr 2018 18:54:06 +0000 (20:54 +0200)]
[BUGFIX] Make labeledToggleCheckbox localizable

The labels of a labeledToggleCheckbox are now localizable using
the well known LLL syntax.

Resolves: #84803
Releases: master
Change-Id: Iaaa3c84393ce1b998752b5db18dafc2aa7d385d3
Reviewed-on: https://review.typo3.org/56745
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jan Delius <me@jandelius.eu>
Tested-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Make translation of form validation errors consistent 46/56746/5
Kay Strobach [Thu, 19 Apr 2018 19:07:08 +0000 (21:07 +0200)]
[BUGFIX] Make translation of form validation errors consistent

The labels have been made consistent with a native speaker.

Resolves: #84804
Releases: master

Change-Id: Iec8e6aed75314d91abf0669614a5aa57260e7204
Reviewed-on: https://review.typo3.org/56746
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Improve Install Tool UX 65/56065/21
Philipp Hamid [Thu, 8 Mar 2018 16:15:20 +0000 (17:15 +0100)]
[TASK] Improve Install Tool UX

Implemented card layout and modals instead of gridder.
Action buttons like clear all cache trigger it's action now directly.
Upcomming Notfications are displayed via backend notifications.
Content for modals is completly loaded via ajax calls. The icon api
is now available for the standalone mode of the install tool.
"libs/chosen" is imported in backend.scss to display proper styling of
chosen selects in modals.

Releases: master
Resolves: #84772
Change-Id: Ib5efbcd45c00b9c3dc973446e3fc1ef39c1f1146
Reviewed-on: https://review.typo3.org/56065
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Wait some seconds before click in modal content 49/56749/2
Frank Naegler [Fri, 20 Apr 2018 08:22:38 +0000 (10:22 +0200)]
[BUGFIX] Wait some seconds before click in modal content

Some acceptance tests fails because of a timing issues. If a modal is not
ready the next click fails. This patch adds a wait before click.

Resolves: #84806
Releases: master
Change-Id: Idb41eee4930441c36f99a8f5d5faa0e74c380a5c
Reviewed-on: https://review.typo3.org/56749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Check if file exists for backend logo 31/56731/2
Lidia Demin [Thu, 19 Apr 2018 08:33:08 +0000 (10:33 +0200)]
[BUGFIX] Check if file exists for backend logo

If an invalid file path is given, an exception is thrown if trying to
access its properties and the backend is not accessible any more.
Check if file exists before accessing. If not use default.

Resolves #84791
Releases: master, 8.7

Change-Id: Ide4c58dd03cbad1ed06ad66f558d170cd2170482
Reviewed-on: https://review.typo3.org/56731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[FEATURE] Add HTML5 date form element 22/56322/11
Ralf Zimmermann [Sat, 17 Mar 2018 16:11:05 +0000 (17:11 +0100)]
[FEATURE] Add HTML5 date form element

Add an HTML5 date form element and a date range server side validator to
the form framework.

Resolves: #82511
Releases: master
Change-Id: Iab9432fd1d2dbc68b9440d244cd655f82561d8f1
Reviewed-on: https://review.typo3.org/56322
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Do not write empty array values in form definitions 48/55848/11
Ralf Zimmermann [Tue, 20 Feb 2018 22:44:00 +0000 (23:44 +0100)]
[BUGFIX] Do not write empty array values in form definitions

Symfony YAML dumps empty arrays as sequence ("{  }"). Due to this, some
JavaScript modules of the form framework fail to interpret/ set the
correct data type for those properties.

If applied, this commit will ensure that the formEditor unsets empty
array keys on load/ save.

The problem only affects the backend module, not the frontend
formDefinition interpreter.

Resolves: #83985
Releases: master, 8.7
Change-Id: I913b8954790510b4ffcc80a47f9dbb7646239ff1
Reviewed-on: https://review.typo3.org/55848
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Check if client supports localStorage 29/56729/3
Andreas Fernandez [Wed, 18 Apr 2018 15:45:12 +0000 (17:45 +0200)]
[BUGFIX] Check if client supports localStorage

Resolves: #84788
Releases: master, 8.7
Change-Id: If7a1c3e1b04c4de391d0bdb943d989971def6e8a
Reviewed-on: https://review.typo3.org/56729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
13 months ago[BUGFIX] Prevent recursive AJAX calls 39/56739/3
Ralf Zimmermann [Thu, 19 Apr 2018 15:25:07 +0000 (17:25 +0200)]
[BUGFIX] Prevent recursive AJAX calls

The form editor calls the icon API within
jQuery's beforeSend() AJAX hook.
Since the Icon API also makes use of AJAX the result is a recursion.
This patch moves the icon requests out of the jQuery AJAX hook.

Resolves: #84797
Releases: master
Change-Id: Ie21806152802774f3f00b3d0320115aa5c0f26e7
Reviewed-on: https://review.typo3.org/56739
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Validation error arguments are not applied 28/56328/4
Ralf Zimmermann [Sat, 17 Mar 2018 16:50:26 +0000 (17:50 +0100)]
[BUGFIX] Validation error arguments are not applied

If an extbase error object wants to be translated through EXT:form and
no translation is found, the original error message will be shown.
Possibly existing error message arguments must be applied by calling
the error objects __toString() method.

Resolves: #84449
Releases: master, 8.7
Change-Id: I3d1f92a7d9c9abcc239bdab17b42a2cbb9e98d94
Reviewed-on: https://review.typo3.org/56328
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[FEATURE] Make indexed_search ready for GDPR 76/56676/16
Georg Ringer [Mon, 16 Apr 2018 08:46:57 +0000 (10:46 +0200)]
[FEATURE] Make indexed_search ready for GDPR

To be compatible with the GDPR, 2 new features are added to
the indexed_search extension:

- Make the index_stat_search table part of the garbage collector task
- Make the IP tracking configurable

Resolves: #84740
Releases: master, 8.7, 7.6
Change-Id: I8e1bcd937a3d4095fb1a048064e82845ff1a5344
Reviewed-on: https://review.typo3.org/56676
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[FEATURE] Store icons in localStorage 21/56721/7
Andreas Fernandez [Wed, 18 Apr 2018 08:03:59 +0000 (10:03 +0200)]
[FEATURE] Store icons in localStorage

The icons that get requested by the Icon API on JavaScript side are not
stored in the client's localStorage.
To have a proper invalidation, a hash of the IconRegistry is built and
stored in the localStorage, too. If the hash changes, all icons in the
localStorage get flushed.

To achieve this, the Storage/Client module is extended to allow removing
values by a given prefix.

Resolves: #84780
Releases: master
Change-Id: Ic2137b05530201a8a94a7ea6c28ae1a012206221
Reviewed-on: https://review.typo3.org/56721
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Disable "Create new translation headers" when no selection is made 41/56441/12
Oskar Dydo [Fri, 23 Mar 2018 14:33:11 +0000 (15:33 +0100)]
[BUGFIX] Disable "Create new translation headers" when no selection is made

The "Create new translation headers" is now disabled if no page to be
translated is selected to avoid errors in the target action. A small
TypeScript is added that unlocks the aforementioned button if at least
one checkbox was selected.

Resolves: #76676
Releases: master, 8.7
Change-Id: I163ed7322066d81597547dd2b2774434a086f082
Reviewed-on: https://review.typo3.org/56441
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Compress flag icons 27/56727/6
Benjamin Kott [Wed, 18 Apr 2018 14:22:17 +0000 (16:22 +0200)]
[TASK] Compress flag icons

Following command was used to add grunt-contrib-imagemin
yarn add grunt-contrib-imagemin --dev

Resolves: #84783
Releases: master
Change-Id: Ia4bc6ec492f698dc6224adb83098d2625cc749cb
Reviewed-on: https://review.typo3.org/56727
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Perform the translation key look-up as it was before #81775 56/56356/5
Ralf Zimmermann [Sun, 18 Mar 2018 13:56:38 +0000 (14:56 +0100)]
[BUGFIX] Perform the translation key look-up as it was before #81775

If a form is rendered through the "form" content element,
the identifier of the form is modified with a suffix since #81775.
The translation key look-up must act like before #81775
and must perform the search for translation keys with the suffixed
form identifiers in addition.

Resolves: #84471
Releases: master
Change-Id: I92b708e1c392ad005c4a1bcd59f1c31788d7756f
Reviewed-on: https://review.typo3.org/56356
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Use stricter types in JsonView and its test 00/56500/6
Oliver Klee [Sat, 31 Mar 2018 18:56:06 +0000 (20:56 +0200)]
[TASK] Use stricter types in JsonView and its test

Also clean up the code a bit, use more imports, and use
assertSame to do type-safe checks.

Resolves: #84571

Releases: master
Change-Id: I933a8354b0cd866ffcb2178664899c94821219a4
Reviewed-on: https://review.typo3.org/56500
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Render systeminformation toolbar items inline 15/56715/2
Benjamin Kott [Tue, 17 Apr 2018 20:54:52 +0000 (22:54 +0200)]
[BUGFIX] Render systeminformation toolbar items inline

Resolves: #84773
Releases: master, 8.7
Change-Id: Ib92146527fdae9c8b2c4ccc23ba387b89412eb6e
Reviewed-on: https://review.typo3.org/56715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Cast floor’ed division to int 26/56726/2
Andreas Fernandez [Wed, 18 Apr 2018 13:33:16 +0000 (15:33 +0200)]
[BUGFIX] Cast floor’ed division to int

The division is rounded by a `floor()` call. Since `floor()` returns a
value of type `double`, the result must get casted to an integer to have
the strict comparisons functional again.

Resolves: #84782
Related: #83556
Releases: master
Change-Id: Ief5d154f0447d2826c013c8cadb792ceb2288320
Reviewed-on: https://review.typo3.org/56726
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Preserve multivalue property sorting in form fields 65/55865/4
Ralf Zimmermann [Thu, 22 Feb 2018 18:30:18 +0000 (19:30 +0100)]
[BUGFIX] Preserve multivalue property sorting in form fields

This ensures e.g. the order of select options is preserved between
form edits.

Background: If you put "{"5":"5","4":"4"}" into JavaScript the order is
arbitrary. Internally this issue is already covered by the form editor
by transforming such values into some meta structure like
"[{'_label': '5', '_value': '5'}, ]{'_label': '4', '_value': '4'}".

This fails if some multivalue properties are already set, and such a
formDefinition is opened by the form editor: "{"5":"5","4":"4"}" becomes
"{"4":"4","5":"5"}".

This fix converts such multivalue properties right before this data is
interpreted by JavaScript.

Resolves: #83911
Releases: master, 8.7
Change-Id: Ife5f6be959958fcf9a2cf5c3942b2549f33287a1
Reviewed-on: https://review.typo3.org/55865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Let form framework finisher parseOption respect arrays 20/55820/23
Ralf Zimmermann [Tue, 20 Feb 2018 09:17:49 +0000 (10:17 +0100)]
[BUGFIX] Let form framework finisher parseOption respect arrays

The method "parseOption()" can now handle arrays. This is necessary if a
finisher option references a form element value through an
identifier like "someOption: '{<elemenIdentifier>}'" and if
the form element value is an array (e.g. MultiCheckbox).
Furthermore "parseOption()" resolves form element references
within localized option values.

Resolves: #83477
Resolves: #82715
Releases: master, 8.7
Change-Id: I15bcdb1d7799a174e48330de91a444735250bfa1
Reviewed-on: https://review.typo3.org/55820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Move rst file into the correct folder 20/56720/4
Frank Naegler [Wed, 18 Apr 2018 07:05:21 +0000 (09:05 +0200)]
[TASK] Move rst file into the correct folder

With #84053 the new API to anonymize IP addresses was introduced, but
the RST file was placed in the wrong directory, because of the backports
to 7.6 the file location must be in 7.6.x folder.

Resolves: #84778
Related: #84053
Change-Id: I32c798bc80dbae0f3bc81901fe7d56f012863aef
Reviewed-on: https://review.typo3.org/56720
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Improve the form manager 94/56694/3
Björn Jacob [Mon, 16 Apr 2018 19:09:25 +0000 (21:09 +0200)]
[TASK] Improve the form manager

Improve the form manager in several ways:

- add reload button to docheader
- add 'for' attribute to all labels in form wizard
- improve wording when no form has been created
- change icon
- change documentation

Resolves: #84756
Releases: master
Change-Id: Ic2292beeccce64c523a971f9ee22e6c568c6c12e
Reviewed-on: https://review.typo3.org/56694
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
13 months ago[BUGFIX] Unregister formeditor events through off() 73/56673/3
Ralf Zimmermann [Mon, 16 Apr 2018 07:33:15 +0000 (09:33 +0200)]
[BUGFIX] Unregister formeditor events through off()

Resolves a variable naming collision within the formeditor model method
off() to make it possible to unregister formeditor events registered
via on().

Releases: master, 8.7
Resolves: #84736
Change-Id: Ia2214a920f034a45e79e0d756985038b41873742
Reviewed-on: https://review.typo3.org/56673
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>