Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Delete modified record in WS just deletes WS version 67/24567/2
Sascha Egerer [Fri, 4 Oct 2013 09:57:35 +0000 (11:57 +0200)]
[BUGFIX] Delete modified record in WS just deletes WS version

If you edit a record in a workspace and then you try to
delete the record, the record it not deleted but the
version (workspace-change record) is.

Resolves: #52530
Releases: 6.2, 6.1, 6.0
Change-Id: I6a77f9a398276af98c41d841053641f3e07b2e33
Reviewed-on: https://review.typo3.org/24567
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Don't show duplicates in workspace preview 08/24008/2
Timo Webler [Mon, 3 Dec 2012 08:51:02 +0000 (09:51 +0100)]
[BUGFIX] Don't show duplicates in workspace preview

Fixed workspace filters in case of workspace preview
in TYPO3\CMS\Frontend\Page\PageRepository::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24008
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Cannot upload an extension as zip 31/24531/2
Xavier Perseguers [Wed, 25 Sep 2013 07:41:58 +0000 (09:41 +0200)]
[BUGFIX] Cannot upload an extension as zip

The file extension ".zip" should be systematically removed when
extracting the extension key from the uploaded file name.

Fixes: #52178
Releases: 6.2, 6.1, 6.0
Change-Id: I5316b995533fa324d3b19407ad9bb6365ab8858b
Reviewed-on: https://review.typo3.org/24037
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit e1db658c3f6d332f4c1971f333b55c168aed43df)
Reviewed-on: https://review.typo3.org/24531

5 years ago[BUGFIX] Fields of type file_reference are not properly indexed 48/24448/2
Martin Borer [Mon, 12 Aug 2013 10:44:46 +0000 (12:44 +0200)]
[BUGFIX] Fields of type file_reference are not properly indexed

sys_refindex entries for TCA-fields of type group->file_reference
are not correct. The fields ref_table and ref_uid are not filled.
This results in a wrong number of references in the Ref column of
the Filelist module and prevents a warning that a resource is still
in use when deleting it.

Resolves: #49538
Releases: 6.2, 6.1, 6.0
Change-Id: I1c44fc98b7ceefd6247ec372e5b28f8682a47bf1
Reviewed-on: https://review.typo3.org/24448
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing closing tag in ElementBrowser 37/24437/2
Philipp Gampe [Sun, 6 Oct 2013 22:10:12 +0000 (00:10 +0200)]
[BUGFIX] Missing closing tag in ElementBrowser

There is missing " />" at the end for $clickIcon, which refers to
the thumbnail in the element browser.
Resolves: #52546
Releases: 6.2, 6.1, 6.0
Change-Id: I2da27190db0ca627c2967750f828c6748b039356
Reviewed-on: https://review.typo3.org/24437
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Use instanceof comparison instead of string comparison 98/24398/2
Benjamin Serfhos [Wed, 2 Oct 2013 12:28:17 +0000 (14:28 +0200)]
[TASK] Use instanceof comparison instead of string comparison

This allows the ViewHelper to render elements which are extending
the model.

Resolves: #52469
Releases: 6.2, 6.1, 6.0
Change-Id: If4b9b3019b44e38a5a25cb74ff993e572464bb9d
Reviewed-on: https://review.typo3.org/24398
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TS is fetched from cache incorrectly sometimes 77/24177/2
Dmitry Dulepov [Mon, 3 Dec 2012 09:40:25 +0000 (13:40 +0400)]
[BUGFIX] TS is fetched from cache incorrectly sometimes

If $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] or
$TYPO3_CONF_VARS['FE']['defaultTypoScript_setup'] are set through
the PHP code, cached TS will not be found in cache. This would
result in TS parsing every time when there are USER_INT objects
on the page. It may slow down the page with USER_INT objects
by about 300% comparing to the cached version.

This change is re-added after it got reverted due to lack of reviews in
Ia0fd65a35897c71d60c48c0b03098ce67ad16c70.

Change-Id: Ief3a065451644423b236489729716b906f3d4500
Resolves: #43540
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24177
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix wrong handling of php and TYPO3 dependencies 26/24126/2
Susanne Moog [Sun, 8 Sep 2013 13:26:22 +0000 (15:26 +0200)]
[BUGFIX] Fix wrong handling of php and TYPO3 dependencies

Due to a superfluos try-catch block dependencies for TYPO3 and
PHP version were not checked correctly.

Additionally the TER version comparison was wrong as it did not
include the given version (only less or greater was checked, not
...OrEqual).

Resolves: #48809
Resolves: #51730
Resolves: #51182
Releases: 6.2, 6.1, 6.0
Change-Id: I773e1af014cd3e8525794c2fcdc615ea8a5f36a1
Reviewed-on: https://review.typo3.org/24126
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Initialize extension name in command requests 24/24124/2
Alexander Stehlik [Wed, 25 Sep 2013 06:40:37 +0000 (08:40 +0200)]
[BUGFIX] Initialize extension name in command requests

This patch initializes the extension name in the configuration manager
as soon as it is available during an Extbase command line request.

Resolves: #51329
Releases: 6.2, 6.1, 6.0
Change-Id: I73b0f0e7a0b20e1773c9eb92f0d2175416ce2bb1
Reviewed-on: https://review.typo3.org/24124
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] EmConfUtility accesses non-arrays 97/24097/2
Markus Klein [Mon, 16 Sep 2013 19:20:12 +0000 (21:20 +0200)]
[BUGFIX] EmConfUtility accesses non-arrays

Properly check for array-type before accessing
or counting the variable.

Resolves: #52045
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id161fddadbbcadd462de36e8227278107f2e7a3a
Reviewed-on: https://review.typo3.org/24097
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Clear cached menu by tag 95/24095/2
Zbigniew Jacko [Tue, 3 Sep 2013 22:10:48 +0000 (00:10 +0200)]
[BUGFIX] Clear cached menu by tag

This change adds a table cf_cache_hash for clear cache by tag
for example for cached menu.

Resolves: #51588
Releases: 6.2, 6.1, 6.0
Change-Id: I18b8aad3ac82737bbc52d4aae49be9028b6df944
Reviewed-on: https://review.typo3.org/23624
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Piotr Molewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f6a8c13d3f71be582147be19d105046fce1d82ad)
Reviewed-on: https://review.typo3.org/24095

5 years ago[BUGFIX] Fix jumpToUrl()-Usage in Element Browser 93/24093/2
Benjamin Pick [Wed, 18 Sep 2013 14:53:44 +0000 (16:53 +0200)]
[BUGFIX] Fix jumpToUrl()-Usage in Element Browser

The Javascript functions jumpToUrl(URL,anchor) and jumpToUrl(URL,formEl)
cannot be used interchangeably. This leads to a javascript error,
because the formElement is rendered as string
("[object HTMLInputElement]").

Resolves: #50437
Releases: 6.0, 6.1, 6.2
Change-Id: I53e1be3c157a2ef6c646f02af15e8c746b6e6375
Reviewed-on: https://review.typo3.org/24093
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Check for string before using strlen 89/24089/2
Kilian Hann [Tue, 24 Sep 2013 13:34:15 +0000 (15:34 +0200)]
[BUGFIX] Check for string before using strlen

If pi_flexform is converted to an array already, checking via strlen
produces a warning. An additional check via is_string suppresses the
warning.

Resolves: #52091
Resolves: #51684
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I97c41cdedb1afb28e2a9ca39e1d9cfb3921d9f47
Reviewed-on: https://review.typo3.org/24089
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] groupFor-VH does not work with @lazy 87/24087/2
Stefan Froemken [Wed, 25 Sep 2013 13:50:41 +0000 (15:50 +0200)]
[BUGFIX] groupFor-VH does not work with @lazy

If you group an property with annotated @lazy option
f:groupedFor-ViewHelper can't group by this property.

Resolves: #52266
Releases: 6.2, 6.1, 6.0
Change-Id: Ie208b67eec8500fee87ee1c62b1bd348c0ed5598
Reviewed-on: https://review.typo3.org/24087
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix PHP warning trigged in getAuthInfoArray() 02/24002/2
Christian Finkemeier [Thu, 8 Aug 2013 13:18:55 +0000 (15:18 +0200)]
[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()

AbstractUserAuthentication::getAuthInfoArray() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #50913
Relates: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I42ddf8fed715c5f8ce060e6ca5826ef3ed8f223e
Reviewed-on: https://review.typo3.org/24002
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fatal in DefaultConfiguration 85/24085/2
Christian Kuhn [Thu, 26 Sep 2013 20:00:46 +0000 (22:00 +0200)]
[BUGFIX] Fatal in DefaultConfiguration

Change-Id: I6f6c8a2ddc26a6c7584e6a067c887768cf3ae5b1
Resolves: #52316
Related: #52305
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24084
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 951e705be57cf183db1f19ab9aa41396c2ac0035)
Reviewed-on: https://review.typo3.org/24085

5 years ago[BUGFIX] Configure main extbase caches for unlimited entry lifetime 81/24081/2
Christian Kuhn [Thu, 26 Sep 2013 14:12:25 +0000 (16:12 +0200)]
[BUGFIX] Configure main extbase caches for unlimited entry lifetime

The extbase reflection and object caches are "stable" cache entries
and only need to be deleted if extensions change or are updates. The
extension manager takes care of flushing in this case.
Currently, the default lifetime of those cache entries is only one
hour, so they are recalculated pretty often. This is especially a
problem if the site was not accessed for more than an hour, since
tons of cache entries exceeded their lifetime and require
recalculation.
The patch moves the cache configuration of the required extbase
extension to DefaultConfiguration and sets unlimited default
lifetime for object and reflection cache.

Change-Id: I671692645aeb104f7fa73595cc79b25ed5984b85
Resolves: #52305
Related: #51116
Related: #52304
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24069
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 690a3713830fc25e39e9f26937376b0aba10412d)
Reviewed-on: https://review.typo3.org/24081

5 years ago[TASK] Use SimpleFileBackend for t3lib_l10n cache 79/24079/2
Christian Kuhn [Thu, 26 Sep 2013 13:00:08 +0000 (15:00 +0200)]
[TASK] Use SimpleFileBackend for t3lib_l10n cache

The language cache by default uses the FileBackend to store its data.
Language cache entries need to be deleted only if new extensions are
loaded and if new language overlays are fetched. They do not need
tagging and can have an unlimited lifetime.
Switching to SimpleFileBackend removes the tagging and sets unlimited
lifetime by to reduce read and write load on this cache.

Change-Id: I5c4778f4c38ae369b6873574e961fa65208d77a1
Resolves: #52295
Related: #52125
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24064
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 3d0008feb8afa84b1f39ceeb017de2a2d4aca3e4)
Reviewed-on: https://review.typo3.org/24079

5 years ago[BUGFIX] EM does not link to docs.typo3.org 53/24053/2
Xavier Perseguers [Tue, 24 Sep 2013 12:57:27 +0000 (14:57 +0200)]
[BUGFIX] EM does not link to docs.typo3.org

docs.typo3.org is new official documentation platform supporting both
OpenOffice and Sphinx manuals.

Fixes: #52226
Releases: 6.2, 6.1, 6.0
Change-Id: Ie5f27bf15f5174a6e1bb53bedd575ceeb362add8
Reviewed-on: https://review.typo3.org/24017
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/24053

5 years ago[BUGFIX] Increase performance of exports for caches 51/24051/2
Markus Klein [Mon, 23 Sep 2013 10:20:01 +0000 (12:20 +0200)]
[BUGFIX] Increase performance of exports for caches

Exporting arrays for caches is now done with var_export().

Resolves: #51116
Releases: 6.2, 6.1, 6.0
Change-Id: I7519fd9c2ab21cc22a3f4e092b611c6bca58c30f
Reviewed-on: https://review.typo3.org/23969
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 8167fb19bc4539814a222185a8380be9add2e465)
Reviewed-on: https://review.typo3.org/24051

5 years ago[BUGFIX] Remove duplicate exception code 46/24046/2
Fabien Udriot [Wed, 25 Sep 2013 07:59:08 +0000 (09:59 +0200)]
[BUGFIX] Remove duplicate exception code

Exception code "1314354065" is used twice: once in the abstract
Resource repository and the other one in the File Collection repository.
Since exception code must be unique, the patch simply renames one
occurrence.

Change-Id: I41474db5de7e8f575275d57e9585252857334ee2
Releases: 6.0, 6.1, 6.2
Resolves: #52243
Reviewed-on: https://review.typo3.org/24038
Reviewed-by: Kilian Hann
Tested-by: Kilian Hann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/24046

5 years ago[BUGFIX] Correct storage selection (common prefixes) 93/23993/2
Ernesto Baschny [Mon, 23 Sep 2013 08:29:56 +0000 (10:29 +0200)]
[BUGFIX] Correct storage selection (common prefixes)

If there is a local storage "uploads/test/" and a requested file
is in "uploads/other/file.txt", the storage matching will not
consider this storage for this file anymore, although they share a
common prefix, but will use a correct matching storage (e.g. 0).

Releases: 6.2, 6.1, 6.0
Resolves: #52173
Change-Id: Id14ffd6620554c086b6e77dca285ade8dee39ab2
Reviewed-on: https://review.typo3.org/23993
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix broken Unit-test for #44825 12/24012/2
Wouter Wolters [Mon, 23 Sep 2013 20:16:32 +0000 (22:16 +0200)]
[BUGFIX] Fix broken Unit-test for #44825

Change-Id: Id1ecce2b4fe789b655f63cd8b5f78ab20eadfbd5
Resolves: #52201
Related: #44825
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24012
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix page.headerData + USER_INT 81/23981/2
Helmut Hummel [Thu, 12 Sep 2013 13:25:58 +0000 (15:25 +0200)]
[BUGFIX] Fix page.headerData + USER_INT

INT scripts placed in page.headerData.XX were
not replaced any more after introducing USER_INT
capabilities of the pageRenderer in #22273

This change reprocesses _INT placeholders after
the pageRenderer replacements have been done.

Resolves: #44825
Releases: 6.0, 6.1, 6.2
Change-Id: If11b692ed75120dbf122d95ca497b5e382fdf349
Reviewed-on: https://review.typo3.org/23981
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Increase length of identifier field in sys_file 37/23937/2
Nicole Cordes [Tue, 17 Sep 2013 21:36:53 +0000 (23:36 +0200)]
[BUGFIX] Increase length of identifier field in sys_file

Sometimes the identifier is longer than 200 chars. This patch increases
the maximum length to 512 characters.

Resolves: #48912
Releases: 6.2, 6.1, 6.0
Change-Id: I67edc1facf972d2ffef09a3204edc556464afda5
Reviewed-on: https://review.typo3.org/23882
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Jon Langeland
Tested-by: Jon Langeland
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ec0fa11769e123e6e37e248824eaa5853cc4aa07)
Reviewed-on: https://review.typo3.org/23937

5 years ago[BUGFIX] Wrong exception on renaming folder 25/23925/2
Francois Suter [Tue, 17 Sep 2013 07:04:05 +0000 (09:04 +0200)]
[BUGFIX] Wrong exception on renaming folder

When a user tries to rename a folder without the permissions
to do so, the ResourceStorage throws a
"InsufficientFileAccessPermissionsException" instead of a
"InsufficientUserPermissionsException".

Resolves: #52056
Releases: 6.0, 6.1, 6.2
Change-Id: I83e75038bd6763f201ef03ebf37018368e990e1a
Reviewed-on: https://review.typo3.org/23925
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Fix PHP warning when writing to Backend user log 16/23916/2
Alexander Stehlik [Thu, 15 Aug 2013 16:05:10 +0000 (18:05 +0200)]
[BUGFIX] Fix PHP warning when writing to Backend user log

The writelog method for the BackendUserAuthentication object is now
checking if there is actually an uid available in the user array
before it tries to access it.

This prevents a PHP warning about an illegal string offset when writing
log messages in an authentication service.

Releases: 6.0, 6.1, 6.2
Resolves: #49328
Change-Id: I006c6b0ccd8f03292715a7d7ab8e457914637d93
Reviewed-on: https://review.typo3.org/23116
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f36574c7a975e93c3a1faf9f3fcace280cda71a8)
Reviewed-on: https://review.typo3.org/23916

5 years ago[BUGFIX] Faulty expand/collapse behavior in Element Browser 77/23877/5
Oliver Hader [Wed, 7 Aug 2013 17:01:53 +0000 (19:01 +0200)]
[BUGFIX] Faulty expand/collapse behavior in Element Browser

On using the element browser in combination with files, the
expand/collapse behavior is wrong. On opening a collapsed folder,
an AJAX call fetches the sub-nodes that will be added to the DOM
tree. However, the calling scope of the original rendering
process and the AJAX call differ a lot.
The only possibility to get this working is to transfer the
scope and rebuild it in the AJAX context.

Change-Id: I1bf7b56ae2d82d15e0246bd651f77793adde705b
Fixes: #45859
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/23877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix cropping of transparent gifs with im6. 72/23872/2
Stefan Neufeind [Thu, 25 Apr 2013 12:06:49 +0000 (14:06 +0200)]
[BUGFIX] Fix cropping of transparent gifs with im6.

The usage of the ! operator to force cropping empty image
canvas is inverted between ImageMagick v4 and v6 while
GraphicsMagick accepts both syntaxes. Because im4 is
deprecated, we can always use im6 syntax.

Fixes: #19045
Releases: 6.2, 6.1, 6.0
Change-Id: Iee1260a94f2686a512ce1b1df65c384319a4c4de
Reviewed-on: https://review.typo3.org/23872
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons 75/23875/2
Ernesto Baschny [Tue, 17 Sep 2013 16:03:03 +0000 (18:03 +0200)]
[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons

Resolves: #50907
Releases: 6.2, 6.1, 6.0
Change-Id: I232498fea18b270e9436aeaf710f728a62365a4b
Reviewed-on: https://review.typo3.org/23875
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Also consider JPEG files for IM/GM 15/23815/2
Markus Klein [Fri, 13 Sep 2013 14:37:32 +0000 (16:37 +0200)]
[BUGFIX] Also consider JPEG files for IM/GM

The Core does not check for the JPEG file extension
when converting images with IM/GM.

Resolves: #51981
Releases: 6.2, 6.1, 6.0
Change-Id: I148ecb0d3c71fdee563476c33865cd18420b2384
Reviewed-on: https://review.typo3.org/23815
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use a 401 header if login is not successful 00/23800/2
Georg Ringer [Fri, 6 Sep 2013 08:00:04 +0000 (10:00 +0200)]
[TASK] Use a 401 header if login is not successful

If login is not correct, a 401 should be used instead of a 200.

Change-Id: Ia2fa139e89fe19df77bb0530b4fbce502506f524
Resolves: #51803
Releases: 6.2,6.1,6.0,4.5
Reviewed-on: https://review.typo3.org/23800
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Replace SHOW DATABASE by query to schema 95/23795/2
Alexander Opitz [Thu, 5 Sep 2013 12:55:47 +0000 (14:55 +0200)]
[BUGFIX] Replace SHOW DATABASE by query to schema

The SQL query "SHOW DATABASE" may be restricted on the SQL Server.
Since MySQL 5.0 (which is minimum since TYPO3 CMS 4.7) we can also query
the information_schema table to gather the information to which table
we have access.

Resolves: #47744
Releases: 6.2, 6.1
Change-Id: Ie65abadeed54cbc54bee401bdc1aab18ffc8eea6
Reviewed-on: https://review.typo3.org/23795
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Call to undefined method setTemplateFile 92/23792/2
Wouter Wolters [Tue, 10 Sep 2013 17:13:11 +0000 (19:13 +0200)]
[BUGFIX] Call to undefined method setTemplateFile

Call to undefined method when setting
'pageHeaderFooterTemplateFile' in TypoScriptFrontendController.
This needs to be called on the page renderer object.

Change-Id: Ic4407addb5d22f09fc4cd6482cc79ad5af724582
Resolves: #51891
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23734
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit eee040cc3ba06154638f94ed1b59c7e2a78e4064)
Reviewed-on: https://review.typo3.org/23792

5 years ago[TASK] Set TYPO3 version to 6.1.6-dev 74/23774/2
TYPO3 Release Team [Thu, 12 Sep 2013 08:59:01 +0000 (10:59 +0200)]
[TASK] Set TYPO3 version to 6.1.6-dev

Change-Id: I5fa98428e5a7cca5162c8d2b0c7636dae87cde67
Reviewed-on: https://review.typo3.org/23774
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.1.5 73/23773/2 TYPO3_6-1-5
TYPO3 Release Team [Thu, 12 Sep 2013 08:58:34 +0000 (10:58 +0200)]
[RELEASE] Release of TYPO3 6.1.5

Change-Id: Icf49a0e16d336e6d942a56a178207c13834dc676
Reviewed-on: https://review.typo3.org/23773
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix SQL error for sys_file 69/23769/2
Markus Klein [Wed, 11 Sep 2013 22:06:15 +0000 (00:06 +0200)]
[BUGFIX] Fix SQL error for sys_file

Regression for SQL error introduced with #51562.

Resolves: #51929
Releases: 6.2, 6.1
Change-Id: Ib9756234fed6284c5c7547284dff9f3308360c35
Reviewed-on: https://review.typo3.org/23769
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest 65/23765/2
Anja Leichsenring [Wed, 11 Sep 2013 16:59:28 +0000 (18:59 +0200)]
[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest

All tests in the class belong to AbstractRepository, so the tests move.

Change-Id: I5e78e0d61a2d8f8bcfd06d871a909b749417e616
Resolves: #51923
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23765
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Empty __call() function hides implementation errors 64/23764/2
Anja Leichsenring [Wed, 11 Sep 2013 17:06:53 +0000 (19:06 +0200)]
[BUGFIX] Empty __call() function hides implementation errors

Throw an Exception if this method hits.

Change-Id: Ide94043bb008e1dfaf19b452570ce70d5f2aa432
Resolves: #51924
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/23764
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Move forgotten getEnvironmentMode() 60/23760/2
Anja Leichsenring [Wed, 11 Sep 2013 16:47:30 +0000 (18:47 +0200)]
[BUGFIX] Move forgotten getEnvironmentMode()

getWhereClauseForEnabledFields() moved from StorageRepository
to AbstractRepository, but getEnvironmentMode() stayed
in StorageRepository although getWhereClauseForEnabledFields()
relies on it. Move getEnvironmentMode() as well.

Change-Id: Id252c8bd3b9e09a2c38d5ea1ebe6497dd76c12ae
Resolves: #51562
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23760
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] FAL ResourceStorage must not access sys_file table directly 56/23756/2
Steffen Ritter [Wed, 11 Sep 2013 15:45:47 +0000 (17:45 +0200)]
[TASK] FAL ResourceStorage must not access sys_file table directly

The ResourceStorage accesses the index table sys_file directly via
a call to the $GLOBALS[TYPO3_DB]. The interaction with the sys_file
index table should be managed only by an according repository to
allow changes within that mechanism.

This patch rearranges the factory method to use the according
call within the FileRepository and adapts it, as the FileRepository
will return a file Object instead of an array.

This serves as a preparation for further indexing optimisations,
which need IndexRecords to be handled centrally.

Releases: 6.2, 6.1, 6.0
Resolves: #51519
Change-Id: I5aa2d212b936b218db1808ea3d0384b8292287a9
Reviewed-on: https://review.typo3.org/23756
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Follow-Up: Missing signals on adding file 53/23753/2
Stefan Neufeind [Wed, 11 Sep 2013 15:04:37 +0000 (17:04 +0200)]
[BUGFIX] Follow-Up: Missing signals on adding file

Mocked driver needs to return a proper "file" on calls to addFile().

Change-Id: Iddfc2f9b7e71101ad229a513727f65f64d654d45
Releases: 6.2, 6.1, 6.0
Resolves: #50795
Reviewed-on: https://review.typo3.org/23753
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove sys_file.deleted flag and it's usage 42/23742/3
Ernesto Baschny [Wed, 11 Sep 2013 12:39:43 +0000 (14:39 +0200)]
[TASK] Remove sys_file.deleted flag and it's usage

This also fixes the 'Uncaught TYPO3 Exception #1317178604
No file found for given UID.' that appears when some sys_file
entries have a deleted flag set by mistake.

Resolves: #51562
Releases: 6.2, 6.1, 6.0
Change-Id: Id23636d2732f3562b8a155025656b26041c9a4e2
Reviewed-on: https://review.typo3.org/23742
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Missing signals on adding file 45/23745/2
Andreas Wolf [Mon, 5 Aug 2013 13:28:01 +0000 (15:28 +0200)]
[BUGFIX] Missing signals on adding file

There are signals for most operations performed in the file storage, but
not for adding a file. Especially this operation is interesting for
things like file indexing, automatic generation of variants (renditions)
etc., therefore this patch adds the two missing signals.

Resolves: #50795
Releases: 6.2, 6.1, 6.0
Change-Id: I0def7b44ff8977a42916e01388604fcbf2d6d299
Reviewed-on: https://review.typo3.org/23745
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage 23/23723/3
Stefan Neufeind [Mon, 9 Sep 2013 22:11:50 +0000 (00:11 +0200)]
[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage

Adjust unittest to changed conditions.

Change-Id: Ia885ba544a159cb1666464cece30c3e6ea3558b6
Fixes: #49386
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23723
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents 12/23712/2
Thomas Maroschik [Mon, 24 Jun 2013 14:33:02 +0000 (16:33 +0200)]
[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents

Fixes the handling of the mismatch between the file info property
"mimetype" and the file object property "mime_type" by using the
exposed API methods.

Fixes: #49386
Releases: 6.2, 6.1, 6.0
Change-Id: If948de2a8bead340ae97097b3e4e391a27296362
Reviewed-on: https://review.typo3.org/23712
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] excludeFromUpdates flag ignored 19/23519/3
Francois Suter [Wed, 14 Aug 2013 11:51:22 +0000 (13:51 +0200)]
[BUGFIX] excludeFromUpdates flag ignored

Since the 6.0 Extension Manager, the "excludeFromUpdates" state
is ignored. It should be checked for and the update button in the
list view hidden in such a case.

Resolves: #51018
Releases: 6.0, 6.1, 6.2
Change-Id: I734331d1b85728dc86732f66ad495a9f83cd0aca
Reviewed-on: https://review.typo3.org/23519
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] mounts of same storage had same subfolder count in Filelist 41/23641/2
Simon Schick [Wed, 22 May 2013 17:42:14 +0000 (19:42 +0200)]
[BUGFIX] mounts of same storage had same subfolder count in Filelist

When you opened the filelist module as user who just was allowed to see
a bunch of filemounts, the filemounts had either all or none the expand-
icon, based on the first file-mount of this storage the user has access
to.

Resolves: #48467
Releases: 6.2, 6.1, 6.0
Change-Id: I1e6a29e351a643f52c0f7a42fde38c9d9b2fc5cb
Reviewed-on: https://review.typo3.org/23641
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Extbase scheduler task serialization 08/23708/2
arjenhoekema [Thu, 5 Sep 2013 07:49:11 +0000 (09:49 +0200)]
[BUGFIX] Extbase scheduler task serialization

When using Command Controllers as scheduled tasks the Extbase
Scheduled Task is serialized. Some singleton properties like
'objectManager', 'commandManager' and 'taskExecutor' are serialized
leading to duplicates of this objects.

Added magic "__sleep" and "__wakeup" methods destructing and
re-constructing the above objects.

Resolves: #50723
Releases: 6.2, 6.1, 6.0
Change-Id: I0a84487a1d8885f75dd4b4eaf004bb0dc93645c2
Reviewed-on: https://review.typo3.org/23708
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Replace double quotes in exceptions 06/23706/2
Wouter Wolters [Wed, 4 Sep 2013 17:34:48 +0000 (19:34 +0200)]
[TASK] Replace double quotes in exceptions

Replace double quotes in exceptions to single quotes

Change-Id: I1a98d783d34eaf4f131b14ab27098c6a4759c9a0
Resolves: #51743
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23706
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Cleanup 04/23704/2
Wouter Wolters [Wed, 4 Sep 2013 17:45:48 +0000 (19:45 +0200)]
[TASK] Cleanup

Replace \' with " in exceptions

Add missing PHP closing tag in StoragePermissionsAspect

Restructure a select query in the
BackendUserAuthentication class.

Change-Id: Id161c761288be93b8f43a2f855254ac954c32d5b
Resolves: #51744
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23704
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Filename not displayed in selector (file_reference) 81/23681/3
Martin Borer [Thu, 5 Sep 2013 21:29:49 +0000 (23:29 +0200)]
[BUGFIX] Filename not displayed in selector (file_reference)

The selector values in BE-fields with type group->file_reference are
empty. The filename should be displayed at this place.

Resolves: #47414
Releases: 6.2, 6.1, 6.0
Change-Id: I9fa237d2cd14ff0e9b347736090bd2171eb8a747
Reviewed-on: https://review.typo3.org/23681
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Ignore userTSConfig if not set in getModTSconfig() 02/23702/2
Helmut Hummel [Mon, 9 Sep 2013 18:06:17 +0000 (20:06 +0200)]
[BUGFIX] Ignore userTSConfig if not set in getModTSconfig()

It can happen that settings that are not defined in
userTSConfig can overwrite pageTSConfig settings
with a null value because of the change in #51007

This case is now checked so that in this case
the original pageTSConfig value is preserved.

Resolves: #51871
Releases: 6.0, 6.1, 6.2
Change-Id: I3fa356a1e5aa20716a6bc83f7c76b8b755fc0bbf
Reviewed-on: https://review.typo3.org/23702
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Disable caching for ADMCMD_view parameter 66/23666/3
Philipp Kitzberger [Tue, 3 Sep 2013 14:11:31 +0000 (16:11 +0200)]
[BUGFIX] Disable caching for ADMCMD_view parameter

This prevents that previewing a page leads to an entry for this page
in the TYPO3 cache table because contents on this page might be set
hidden.

Resolves: #51682
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I154d790454bf6bf0215b83e493919107a6c5bd93
Reviewed-on: https://review.typo3.org/23666
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Do not add trailing slashes to files 98/23698/2
Helmut Hummel [Mon, 9 Sep 2013 15:13:09 +0000 (17:13 +0200)]
[BUGFIX] Do not add trailing slashes to files

In the security fix #50883 a canonicalize method
for folders has been used where items could
either be files or folders.

This added a trailing slash to files which triggered
a basedir PHP warning if basedir is configured
in PHP.

Use the canonicalize method for file paths instead
to fix this issue.

Resolves: #51761
Releases: 6.0, 6.1, 6.2
Change-Id: I9ef4b6a90ca257ad0104115bd7d48c4de68f135f
Reviewed-on: https://review.typo3.org/23698
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Enable ProcessedFiles to do file exists 64/23664/2
Helmut Hummel [Fri, 6 Sep 2013 10:53:15 +0000 (12:53 +0200)]
[BUGFIX] Enable ProcessedFiles to do file exists

Make storage 0 folder readable, browsable and writable
to mitigate the problems that arise with non
readable processing directories.

Also allow file exists in general if the
identifier in subject is in processing folder.

Resolves: #51808
Releases: 6.0, 6.1, 6.2
Change-Id: I1959d7911d955592db1771d608e8fafcc26c45e9
Reviewed-on: https://review.typo3.org/23664
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix viewObjectNamePattern regression in Extbase 79/23679/2
Alexander Schnitzler [Sat, 7 Sep 2013 10:19:14 +0000 (12:19 +0200)]
[BUGFIX] Fix viewObjectNamePattern regression in Extbase

http://forge.typo3.org/issues/47609 introduced an Extbase
regression by changing the behaviour of viewObjectNamePattern
in the ActionController without deprecating it first.

This patch fixes this regression but keeps the wanted behaviour
by resetting the value of viewObjectNamePattern and introducing
a namespacedViewObjectNamePattern with the namespaced pattern.

Resolves: #51758
Releases: 6.2, 6.1, 6.0
Change-Id: Ie32b178e1799c396e969fd48f81f9fe6243f6e70
Reviewed-on: https://review.typo3.org/23679
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[FEATURE] Find best-matching local storage instead of default-storage 60/23560/4
Stefan Neufeind [Fri, 15 Feb 2013 02:21:57 +0000 (03:21 +0100)]
[FEATURE] Find best-matching local storage instead of default-storage

If no storage-UID is given usually the default-storage will be
used ("legacy-storage"). Some problems with not up-to-date
index-records etc. can be prevented by using a matching storage
instead of falling back to the default-storage (ID 0).

Implement search for best matching storage.

Resolves: #45498
Releases: 6.0, 6.1, 6.2
Change-Id: Ife00d68314fe43804227bb26280d0d475cbaf10b
Reviewed-on: https://review.typo3.org/23560
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Recreate processig folder without permission checks 55/23655/2
Helmut Hummel [Thu, 5 Sep 2013 07:45:13 +0000 (09:45 +0200)]
[BUGFIX] Recreate processig folder without permission checks

When fetching the processing folder and it does not
exist, it is created on the fly. This should be done
without checking permissions. However by making
storage 0 not browsable, permissions will be checked
when fetching subfolders.

Instead we now fetch the folder objects directly
from the driver, where no permission checks are done.

Resolves: #51747
Releases: 6.0, 6.1, 6.2
Change-Id: I1a4c3b183323151c436969a478c669adb3856476
Reviewed-on: https://review.typo3.org/23655
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Do not register storage factory slot during install 53/23653/2
Helmut Hummel [Wed, 4 Sep 2013 17:55:56 +0000 (19:55 +0200)]
[BUGFIX] Do not register storage factory slot during install

In install tool context TYPO3_MODE is set to BE
but there is no backend user initialized.
Because of that the storage permission aspect
fails as it requires a valid backend user object.

Do not register the slot when in install tool context.

Releases: 6.0, 6.1, 6.2
Resolves: #51733
Change-Id: I45090b389ba8c641ba49e9f8e59004aac47853e7
Reviewed-on: https://review.typo3.org/23653
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[FEATURE] Render icon with button view helper 50/23650/2
Francois Suter [Fri, 23 Aug 2013 16:32:05 +0000 (18:32 +0200)]
[FEATURE] Render icon with button view helper

Fluid is currently lacking a view helper to render a skinned icon.
By making the button icon view helper accept an empty URI as an
argument, we let it render an unlinked icon, rather than adding
a new view helper with very similar code.

This patch also cleans up the class phpDoc block, which
contained several errors.

Although initially planned for 6.2 only, this change
will go into 6.0 and 6.1 also to fix the regression
in #51767

Resolves: #51305
Resolves: #51767
Releases: 6.0, 6.1
Change-Id: I74b1dc3346e20c9094313a2da451bcb6c1f60f29
Reviewed-on: https://review.typo3.org/23650
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Remove conflict code 22/23622/2
Wouter Wolters [Wed, 4 Sep 2013 18:09:13 +0000 (20:09 +0200)]
[TASK] Remove conflict code

Remove conflict code which was luckily inside doc-comments.

Resolves: #51745
Releases: 6.1, 6.0
Change-Id: I2a175000028fb12a7a1558494e70b9183dd61786
Reviewed-on: https://review.typo3.org/23622
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.1.5-dev 12/23612/2
TYPO3 Release Team [Wed, 4 Sep 2013 12:42:57 +0000 (14:42 +0200)]
[TASK] Set TYPO3 version to 6.1.5-dev

Change-Id: Ie229907579f6581ba396dcb5373e18d024995fdc
Reviewed-on: https://review.typo3.org/23612
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[RELEASE] Release of TYPO3 6.1.4 11/23611/2 TYPO3_6-1-4
TYPO3 Release Team [Wed, 4 Sep 2013 12:42:16 +0000 (14:42 +0200)]
[RELEASE] Release of TYPO3 6.1.4

Change-Id: I4eac865bdbe7c838ebbd9351cd39d899fb03ba5e
Reviewed-on: https://review.typo3.org/23611
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Prohibit accessing storage 0 from backend UI 06/23606/2
Steffen Ritter [Wed, 4 Sep 2013 11:23:44 +0000 (13:23 +0200)]
[SECURITY] Prohibit accessing storage 0 from backend UI

Manually accessing backend entry-points regarding files passing
an identifier with storage 0 may allow unfiltered access for read,
write, rename, create and delete actions.

The user interface must never deal with storage 0. Therefore
implement checks for storage 0 as protection.

Change-Id: I97a33aca451719c0d6d4ce3652a31a867a700438
Releases: 6.2, 6.1, 6.0
Fixes: #50886
Security-Commit: b813a875ad76aa7860b76602eb1f32dcfc9fadcd
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23606
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Identifiers may refer to resources outside the storage 05/23605/2
Steffen Ritter [Wed, 4 Sep 2013 11:23:36 +0000 (13:23 +0200)]
[SECURITY] Identifiers may refer to resources outside the storage

The Driver needs to canonicalize all incoming identifiers at first,
and than check for their validity on every action performed.
If a canonicalized path resided inside a storage it does not contain
any ../ anymore.
An exception is thrown in that case.

Change-Id: I4b11034e2adc98c9a5b7ebeddbe3c8ee54df16b5
Releases: 6.2, 6.1, 6.0
Fixes: #50883
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23605
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Deny arbitrary code execution possibility for editors 04/23604/2
Helmut Hummel [Wed, 4 Sep 2013 11:23:29 +0000 (13:23 +0200)]
[SECURITY] Deny arbitrary code execution possibility for editors

Because the filename is sanitized in the driver
after the check for denied file extensions is
performed, it was still possible to rename files
with denied file extensions.

We now perform the file extension check
on the final filename which is going to be used
by the driver.

This change makes the sanitizing method public
and introduces a basic implementation in
AbstractDriver to not break existing driver
implementations.

Change-Id: I74b3596e194e79135d7affa3111b3f9e40a72693
Fixes: #51495
Releases: 6.2, 6.1, 6.0
Security-Commit: d9aa75ad0169e90065656ca78b19ab966d1c76c1
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23604
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Refactor and fix FAL user permission handling 03/23603/2
Helmut Hummel [Wed, 4 Sep 2013 11:23:22 +0000 (13:23 +0200)]
[SECURITY] Refactor and fix FAL user permission handling

* User permissions are only applied to storage objects
  that are attached to a member variable of
  BackendUserAuthentication. This is error prone
  and leads to insufficient (no) checks if the code
  fetches a storage directly from the factory
  (like edit document controller does)
  Instead, apply the permissions by using a signal
  in StorageFactory directly after the storage object
  is built.

* Refactor the mount point handling, especially the
  user and group home directories, which was completely
  broken after the introduction of FAL. File mounts
  are now also applied to the storage on creation.

* Make fallback storage 0 read only and not browsable.

Change-Id: I5987cc760581f8dabd12b6f0162645eaa687edea
Fixes: #51327
Releases: 6.2, 6.1, 6.0
Security-Commit: 5460c76e1373698bde82883ab4087607fee5e6f5
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23603
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Add possibility to en-/disable file permission checks 02/23602/2
Helmut Hummel [Wed, 4 Sep 2013 11:23:15 +0000 (13:23 +0200)]
[SECURITY] Add possibility to en-/disable file permission checks

For admins and for front end request, we must be able
to deactivate permission checks completely, while
it must be possible to restrict backend users
to not have any file permissions thus, not be able to
see/change any file.

Fixes: #51326
Releases: 6.2, 6.1, 6.0

Change-Id: I0f0288d52ca769acbf5d0cc06cdd896467b24fdf
Security-Commit: 49092a77f9e4f391aaf94d30501d4a2c47f60a88
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23602
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Check permissions in all actions of ResourceStorage 01/23601/2
Steffen Ritter [Wed, 4 Sep 2013 11:23:07 +0000 (13:23 +0200)]
[SECURITY] Check permissions in all actions of ResourceStorage

The ResourceStorage omits checks for the configured user and
group permissions within the actions on that Storage.

This patch refines some naming within the security methods
as well as adding security checks to every method.

PHP file extensions are now also removed from the
text file extension list.

Change-Id: I2dbea79707cc054b6c532f3d6c250f7a05baa3e6
Releases: 6.2, 6.1, 6.0
Fixes: #51079
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23601
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] CGL Cleanup of ResourceStorage 59/23559/3
Helmut Hummel [Tue, 3 Sep 2013 13:14:13 +0000 (15:14 +0200)]
[TASK] CGL Cleanup of ResourceStorage

To ease further backporting this change
backports some non functional CGL cleanup
to 6.0 branch

Releases: 6.1

Change-Id: Idf9d728a9143ab5cec311401fb6f56220c1f58a4
Reviewed-on: https://review.typo3.org/23556
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/23559

5 years ago[BUGFIX] Storage is offline but is still used 32/23232/2
Frans Saris [Wed, 7 Aug 2013 10:09:54 +0000 (12:09 +0200)]
[BUGFIX] Storage is offline but is still used

Check before generating a publicUrl if storage is online.

Resolves: #49842
Releases: 6.2, 6.1, 6.0
Change-Id: I766e337cf5e7dfcb309bbce0bbd7c4d8df733c84
Reviewed-on: https://review.typo3.org/23232
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Faulty check for missing SMTP port 15/23515/2
Tomita Militaru [Sat, 31 Aug 2013 07:56:41 +0000 (10:56 +0300)]
[BUGFIX] Faulty check for missing SMTP port

Check also for null port to avoid a fatal error.

Resolves: #31998
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ibf45b3c0783a70e5afba33f90d1d8e05f76834cf
Reviewed-on: https://review.typo3.org/23515
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Backend Layout Grid Wizard not fully visible in Mac Firefox 22 11/23511/2
Roland Schenke [Fri, 30 Aug 2013 08:30:16 +0000 (10:30 +0200)]
[BUGFIX] Backend Layout Grid Wizard not fully visible in Mac Firefox 22

Under Firefox the outer table's height and width of the backend layout
wizard is set to 100%. Since there is content before the table, this
leads to the table being cut of, as there are no scrollbars. According
to the suggestion of Philipp Gampe the table's height and width are
changed to 90%.

Resolves: #50424
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I589fdfd8de0a8d6ebb4b3ee4fd2a173341116016
Reviewed-on: https://review.typo3.org/23511
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGIFX] Missing argument in EM List view VH 93/23493/2
Francois Suter [Fri, 30 Aug 2013 13:36:35 +0000 (15:36 +0200)]
[BUGIFX] Missing argument in EM List view VH

Due to a careless backport, the EM List view now calls on the
\TYPO3\CMS\Fluid\ViewHelpers\Be\Buttons\IconViewHelper VH
without the required "uri" argument, causing the List view
to crash.

Resolves: #51585
Releases: 6.0, 6.1
Change-Id: I8c96bbe783ea9713e2ca5a2434854e653c2f01d4
Reviewed-on: https://review.typo3.org/23493
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Only log file/directory actions which were done 89/23389/2
Helmut Hummel [Sun, 25 Aug 2013 20:01:16 +0000 (22:01 +0200)]
[BUGFIX] Only log file/directory actions which were done

Some file/directory actions were logged as they were
successfully performed, even when they failed.

Resolves: #51328
Releases: 6.2, 6.1, 6.0

Change-Id: Iab03e668d3f7d0e8feec09851ea50a59ab4b71a0
Reviewed-on: https://review.typo3.org/23389
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Sprite manager cache improvement 79/23479/2
Christian Kuhn [Thu, 29 Aug 2013 19:40:15 +0000 (21:40 +0200)]
[BUGFIX] Sprite manager cache improvement

The sprite manager cache entry is created and then required
directly again. This may lead to runtime issues if the file
is required already before it is fully written.
The patch optimizes that by setting the runtime information
directly from the given data.

Change-Id: I3f6250d8513dad32e266538a075abc8e3daeb68c
Resolves: #51544
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23479
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] TCA 'group' selectedListStyle with 'width' breaking layout 74/23474/2
Ernesto Baschny [Tue, 27 Aug 2013 22:47:50 +0000 (00:47 +0200)]
[BUGFIX] TCA 'group' selectedListStyle with 'width' breaking layout

The problem came from a row of icons which was always rendered below
the select list with a hardcoded width of "250px", regardless if there
was content or not. Solution is not to render this icon row if there are
no icons, thus allowing the select list to be reduced in width.

Releases: 6.2, 6.1, 6.0
Resolves: #50707
Change-Id: I23520c1c547de1155091e38c69013a18fed9e559
Reviewed-on: https://review.typo3.org/23391
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 447814734d640b6811e71085d5939727dd5766de)
Reviewed-on: https://review.typo3.org/23474

5 years ago[BUGFIX] Database integrity check fatal error 67/23467/2
Stefan Fürst [Wed, 28 Aug 2013 14:08:10 +0000 (16:08 +0200)]
[BUGFIX] Database integrity check fatal error

If a file or directory below uploads/ is not readable by the
executing user, the integrity check system in db check module
menu may fatal. This is sanatized by the patch.

Resolves: #51460
Releases: 6.2, 6.1, 6.0
Change-Id: Ide3401c014aa7bec33585083f81f30c00100da09
Reviewed-on: https://review.typo3.org/23424
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 81d22419488af753e394d82fc1338feff0c5795c)
Reviewed-on: https://review.typo3.org/23467

5 years ago[BUGFIX] Cast autoload and classAliasMap to Array 56/23456/2
Michel Georgy [Thu, 29 Aug 2013 07:34:21 +0000 (09:34 +0200)]
[BUGFIX] Cast autoload and classAliasMap to Array

If you create an empty ext_autoload.php or an empty classAliasMap.php
file or fail to return an array, NULL is merged with the existing
array which results in NULL for the array $classRegistry or
$aliasToClassNameMapping
This patch casts the required Array(which is possibly NULL) to an
Array to prevent array_merge with NULL values.

Fixes: #51474
Releases: 6.2, 6.1, 6.0
Change-Id: I1887da3a942b17e441338a95cb7da49a17535907
Reviewed-on: https://review.typo3.org/23441
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christoph Dörfel
Tested-by: Christoph Dörfel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 8cc7f45526bc8828dada995bc91804038d326eea)
Reviewed-on: https://review.typo3.org/23456

5 years ago[BUGFIX] Add missing API method FileInterface::getNameWithoutExtension 54/23454/2
Ernesto Baschny [Tue, 6 Aug 2013 17:17:07 +0000 (19:17 +0200)]
[BUGFIX] Add missing API method FileInterface::getNameWithoutExtension

This method was supposed to be in the interface, but due to a syntax
error in the closing comment tag, it was not (and was not detected as a
PHP syntax error).

This finally adds this method and implements it also in the class
FileReference which hadn't had this method before but also implements
this interface.

Resolves: #51509
Releases: 6.2, 6.1, 6.0
Change-Id: I8ee1ecc155e9cfaeec7ac0ac7086f75df13f4c34
Reviewed-on: https://review.typo3.org/23454
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Exclude empty passwords from password hashing check 32/23432/2
Nicole Cordes [Wed, 28 Aug 2013 14:02:36 +0000 (16:02 +0200)]
[BUGFIX] Exclude empty passwords from password hashing check

The test for insecure passwords handles empty passwords as insecure and
recommends to use the saltedpasswords scheduler task to convert all
insecure passwords. But the scheduler task doesn't convert empty
passwords, so a never ending story exists. Therefore this patch exludes
empty passwords being handled as insecure.

Resolves: #36244
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bdd5c8807a07841850c1e4c22afe57eec28b335
Reviewed-on: https://review.typo3.org/23432
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] utf8/multibyte character breaks menu filelist 78/23378/2
Peter Niederlag [Thu, 22 Aug 2013 11:17:25 +0000 (13:17 +0200)]
[BUGFIX] utf8/multibyte character breaks menu filelist

Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
Reviewed-on: https://review.typo3.org/23378
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Make the extension titles link to the configuration 76/23376/2
Nicole Cordes [Mon, 29 Jul 2013 16:13:53 +0000 (18:13 +0200)]
[TASK] Make the extension titles link to the configuration

In the extension manager make the extension titles link to the
configuration again. This will provide an additional clickable area and
it allows the integrators to continue using the known behavior.

Resolves: #50234
Releases: 6.2, 6.1, 6.0
Change-Id: I120e8fb47628fe118291cbdd57951a0238ebcd71
Reviewed-on: https://review.typo3.org/23376
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Hide translations in categories selector 58/23358/2
Francois Suter [Fri, 23 Aug 2013 16:09:54 +0000 (18:09 +0200)]
[BUGFIX] Hide translations in categories selector

The \TYPO3\CMS\Core\Category\CategoryRegistry::addTcaColumn() method
provides an API for adding a system categories selector to a given
table. However the generated TCA misses a condition in
"foreign_table_where" to hide translated categories.

Resolves: #51304
Releases: 6.0, 6.1, 6.2
Change-Id: I2622371a89c8eabeb29e835c7f6673ffc6349186
Reviewed-on: https://review.typo3.org/23280
Reviewed-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-on: https://review.typo3.org/23358

5 years ago[BUGFIX] Tests in Localization\Parser\LocallangXmlParserTest fail 50/23350/2
Nicole Cordes [Wed, 7 Aug 2013 11:27:50 +0000 (13:27 +0200)]
[BUGFIX] Tests in Localization\Parser\LocallangXmlParserTest fail

If the system is already translated into French two tests in
Localization\Parser\LocallangXmlParserTest fail. This is because another
localization file is taken where test strings are not included.

As the tested functions can't work system independent, the test has to
make sure no system dependencies are used. Therefore the patch
introduces a new language "md5" to prove the workflow.

Resolves: #50870
Releases: 6.2, 6.1, 6.0
Change-Id: I64e8864a7d746c4f5c278f5e67d8dae068d8f920
Reviewed-on: https://review.typo3.org/23350
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Escape title tag of image links 44/23344/2
Alexander Stehlik [Sun, 4 Aug 2013 11:54:53 +0000 (13:54 +0200)]
[BUGFIX] Escape title tag of image links

This patch adds a missing call to htmlspecialchars() when
the title tag of image links is initialized.

Resolves: #50760
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: If41f33d9621f7790c0ff0de4aebcd7cdcb59707f
Reviewed-on: https://review.typo3.org/23344
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Page tree filtering broken in IE7 & IE8 37/23337/3
Aske Ertmann [Mon, 22 Jul 2013 18:46:23 +0000 (20:46 +0200)]
[BUGFIX] Page tree filtering broken in IE7 & IE8

The page tree doesn't show the result when using the filter
in the page tree in IE7 & IE8. ExtJS somehow breaks silently
when trying to use a non-tag (text) as a drag handle. This fix
works with the original change that introduced this, meaning it
doesn't break the functionality of dragging of locked records.

Change-Id: I3f33fb3e4f6bd7622f502a9265897fee9d3e4ed3
Resolves: #25327
Resolves: #37026
Related: #M17952
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/23337
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Ignore permission checks for processed files 14/23214/2
Helmut Hummel [Wed, 14 Aug 2013 14:49:55 +0000 (16:49 +0200)]
[BUGFIX] Ignore permission checks for processed files

It must be possible that processed files are generated
even if the user has read only permissions on a storage.

Additionally add a method to Storage, to specifically
update a processed file with a local file.

Resolves: #51209
Releases: 6.0, 6.1, 6.2
Change-Id: I847b02f070c55647e06695c1c70b0b7e8e238177
Reviewed-on: https://review.typo3.org/23214
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years agoRevert "[BUGFIX] Check for incompatible SQL modes" 42/23242/2
Stefan Neufeind [Thu, 22 Aug 2013 10:18:58 +0000 (12:18 +0200)]
Revert "[BUGFIX] Check for incompatible SQL modes"

The sysenv-check is not the proper place for a check that needs a working db-connection. But we'll find a different place for this check shortly and then reintroduce it.

This reverts commit e727d5ff0b8ee93de38983555164b19f6bf87377

Change-Id: I117f38df6796bf04c285d6d5345a0829f32fbfc3
Reviewed-on: https://review.typo3.org/23242
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Missing "Interface" in Backend-Annotation 40/23240/2
Stefan Froemken [Thu, 22 Aug 2013 09:53:22 +0000 (11:53 +0200)]
[BUGFIX] Missing "Interface" in Backend-Annotation

ObjectMapper does not work for Backend-Mappings
because of missing "Interface" in Backend-Annotation

Resolves: #51249
Releases: 6.2, 6.1
Change-Id: I45a6f1c57ddcf71282853c44e261bfa877854b85
Reviewed-on: https://review.typo3.org/23240
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Check for incompatible SQL modes 37/23237/2
Sascha Egerer [Thu, 22 Aug 2013 09:32:54 +0000 (11:32 +0200)]
[BUGFIX] Check for incompatible SQL modes

If the SQL mode "STRICT_ALL_TABLES" is enabled you
will not be able to save most records. (Enable it in
your my.cnf and try to save a tt_content record)

This patch adds a check in the install tool for the
incompatible SQL modes "STRICT_ALL_TABLES" and
"NO_BACKSLASH_ESCAPES".

The automatic fix for "NO_BACKSLASH_ESCAPES" has been
removed because we don't want to change the mysql
environment automatically.

Resolves: #20052
Resolves: #18866
Resolves: #18821
Releases: 6.2, 6.1, 6.0
Change-Id: Ifd2d7901935f06534a273374bf48266916e23698
Reviewed-on: https://review.typo3.org/23237
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] No version overlay should be done for sys_language 03/23203/2
Lienhart Woitok [Tue, 27 Nov 2012 01:43:04 +0000 (02:43 +0100)]
[BUGFIX] No version overlay should be done for sys_language

The tables sys_language and static_languages do not support
versioning. Therefore, when doing a version preview, no
version overlay should be applied to them.

Change-Id: I37be782601fc37e78a74d2459b6f246c5107b701
Fixes: #37892
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23203
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Files with unclean path indexed multiple times 99/23199/2
Stefan Neufeind [Sat, 6 Apr 2013 15:11:52 +0000 (17:11 +0200)]
[BUGFIX] Files with unclean path indexed multiple times

When adding a file or requesting a file by an identifier
cleanup any . and .. in the path before handing off
to the driver so files are not indexed multiple times.

Fixes: #46989
Releases: 6.2, 6.1, 6.0
Change-Id: I4198a8885a6a148e68e1e0f717775f9af976a9ef
Reviewed-on: https://review.typo3.org/23199
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FlashMessageQueue PHP strict warning 97/23197/2
Christian Kuhn [Sun, 18 Aug 2013 13:50:54 +0000 (15:50 +0200)]
[BUGFIX] FlashMessageQueue PHP strict warning

FlashMessageQueue exends \SplQueue and overwrites enqueue($value).
In \SplQueue enqueue() has no type hint on $value, but
FlashMessageQueue adds a type hint to FlashMessage. This raises
a PHP strict warning.

Solution is to remove the type hint and add an exception instead
if given argument is not an instance of FlashMessage.

Change-Id: I882aab33a55d84de6614a45c6cc045223adba0cd
Resolves: #51159
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/23197
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] FilesContentObject::stdWrapValue(): only execute stdWrap once 79/23179/2
Stefan Neufeind [Thu, 1 Aug 2013 01:03:20 +0000 (03:03 +0200)]
[TASK] FilesContentObject::stdWrapValue(): only execute stdWrap once

Change-Id: I4bad84460e1d1b16e05498e382644cd5946c3be8
Resolves: #50614
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23179
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Language-module icons need to display in correct size 77/23177/2
Stefan Neufeind [Wed, 31 Jul 2013 14:07:39 +0000 (16:07 +0200)]
[BUGFIX] Language-module icons need to display in correct size

Since inline:display-block was missing on those icons, those
icons didn't display in their intended size although they
had a width/height-attribute set.

Change-Id: I5ba318e6a3ca4602714d0c4b5f12674e2e305952
Resolves: #43428
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23177
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] TCA: subtypes_addlist not processed 59/23159/2
Benjamin Mack [Sat, 6 Apr 2013 09:54:32 +0000 (11:54 +0200)]
[BUGFIX] TCA: subtypes_addlist not processed

TCA: subtypes_addlist is not processed
if the subtype_value_field is in a palette

Fixes: #30636
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bcaaf36c330962c1d7d9fdd4a73ae502e9710dc
Reviewed-on: https://review.typo3.org/23159
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Query parameters of external link may get altered 57/23157/2
Stanislas Rolland [Tue, 30 Jul 2013 02:34:54 +0000 (22:34 -0400)]
[BUGFIX] Query parameters of external link may get altered

If an external link is set to the same domain as the BE domain and
the id query parameter is present, any other query parameters will
be altered (and repeated).
Solution: href of external link should remain unaltered.

Resolves: #47844
Releases: 6.0, 6.1, 6.2
Change-Id: I79564ebf63ee4f92bfd3f95b17f72592ea849163
Reviewed-on: https://review.typo3.org/23157
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Disable scheduler-tests if EXT:scheduler not loaded 34/23134/2
Stefan Neufeind [Fri, 16 Aug 2013 11:53:27 +0000 (13:53 +0200)]
[TASK] Disable scheduler-tests if EXT:scheduler not loaded

Change-Id: I62ec38fc27330e74c4bc3eed6ded3a2f4a6de550
Resolves: #51115
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23134
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring