Packages/TYPO3.CMS.git
2 years ago[TASK] Add unit test for Typolink resolveTargetAttribute 66/52766/2
Elmar Hinz [Fri, 31 Mar 2017 19:49:21 +0000 (21:49 +0200)]
[TASK] Add unit test for Typolink resolveTargetAttribute

Add a unit test for AbstractTypolinkBuilder::resolveTargetAttribute.

Releases: master, 8.7
Resolves: #80618
Change-Id: I429900c036371be4f0bd57e75d841f9d0dfe7720
Reviewed-on: https://review.typo3.org/52305
Reviewed-on: https://review.typo3.org/52766
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use DBAL Restrictions for index_config queries 65/52765/2
Benni Mack [Thu, 11 May 2017 06:26:58 +0000 (08:26 +0200)]
[BUGFIX] Use DBAL Restrictions for index_config queries

The IndexSearch repository calls $TSFE->sys_page->enableFields
for queries on index_config which has very static information
(deleted/hidden) which the default restriction container handles.

Changing this code was simply forgotton to migrate to the
restriction container.

Resolves: #81188
Releases: master, 8.7
Change-Id: I159b4c2cf898e97b0e92fd2a57bcd30de0806146
Reviewed-on: https://review.typo3.org/52765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action 69/52769/2
Georg Ringer [Wed, 3 May 2017 03:48:50 +0000 (05:48 +0200)]
[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action

The field t3_tables of sys_action must be rendered as a single
select field. This was also the behaviour before the regression
introduced with #69822.

Resolves: #81119
Releases: master, 8.7, 7.6
Change-Id: I2c885ea3494d7e2be22fad6df1b2a4791991551b
Reviewed-on: https://review.typo3.org/52769
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix path to Header partial in Textmedia and Textpic 63/52763/2
Olli [Sun, 16 Apr 2017 14:31:11 +0000 (16:31 +0200)]
[BUGFIX] Fix path to Header partial in Textmedia and Textpic

Fix path to call the existing partial Partials/Header/All instead of
Partials/Header.

Releases: master,8.7
Resolves: #80859
Change-Id: Ib4743acd3f3673fdfbe414cf4563c38e2f153055
Reviewed-on: https://review.typo3.org/52763
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make DataHandler multibyte-safe 64/52764/2
Benni Mack [Thu, 11 May 2017 04:51:01 +0000 (06:51 +0200)]
[BUGFIX] Make DataHandler multibyte-safe

There are still a few places left where multibyte string functions
are not used. Since 8.x the core delivers a mbstring polyfill
and can be used in various places.

Resolves: #19774
Releases: master, 8.7
Change-Id: I16f022b109749e9f547c177c511fee3bcc5d4b60
Reviewed-on: https://review.typo3.org/52764
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string 62/52762/2
Daniel Goerz [Thu, 20 Apr 2017 13:46:16 +0000 (15:46 +0200)]
[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string

Resolves: #80919
Releases: master, 8.7
Change-Id: I3fddc6e83a117d25ec7abeb7d82130275321c2c7
Reviewed-on: https://review.typo3.org/52762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher 60/52760/2
Andreas Allacher [Wed, 22 Mar 2017 07:25:35 +0000 (08:25 +0100)]
[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher

In order to support all conditions correctly
whether one is in FE or BE the condition
has to be matched against the correct
ConditionMatcher instead of always
using the one for BE.

Releases: master, 8.7, 7.6
Resolves: #80385
Change-Id: Id5e216da40000b408f96822855d97799f254d0fb
Reviewed-on: https://review.typo3.org/52760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] travis-ci: Drop JS unit tests 59/52759/2
Christian Kuhn [Thu, 11 May 2017 10:24:36 +0000 (12:24 +0200)]
[TASK] travis-ci: Drop JS unit tests

Drop the jasmine / karma based JS unit tests from travis. They're
becoming unstable and are executed as pre-merge tests anyway.
Supporting one executing platform that keeps an eye on
nodejs & friends should be enough.

Change-Id: Ie2134c08c50d9da33ff39bc1a0fe3f4a416e7b45
Resolves: #81192
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:scheduler:action icons and sorting 57/52757/2
Daniel Windloff [Sat, 29 Apr 2017 11:39:11 +0000 (13:39 +0200)]
[TASK] EXT:scheduler:action icons and sorting

In order to be consistent, add action icons
and sort multi action buttons according to the single action.

Resolves: #81080
Releases: master, 8.7
Change-Id: If987643eaea17ed98722b933fc8c57818e7a7a93
Reviewed-on: https://review.typo3.org/52757
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Improve BE description of mount point overlay 49/52749/2
Elmar Hinz [Sun, 7 May 2017 17:52:04 +0000 (19:52 +0200)]
[TASK] Improve BE description of mount point overlay

Give a more precise description of the mount point overlay behaviour:

- Update labels of the page tree.
- Update lables of the page form.

Releases: master, 8.7
Resolves: #81163
Change-Id: Ib1046e5caf29e7126b05446d4d3063bb87e3c9fa
Reviewed-on: https://review.typo3.org/52749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure Frontend User image update is not offered 48/52748/2
Markus Klein [Wed, 10 May 2017 11:28:03 +0000 (13:28 +0200)]
[BUGFIX] Ensure Frontend User image update is not offered

Releases: master, 8.7
Resolves: #81180
Change-Id: I87a8a5b694ad579f6ba31feb10094298ecabf9e7
Reviewed-on: https://review.typo3.org/52748
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[DOC] Fix version number in documentation files 47/52747/3
Markus Klein [Wed, 10 May 2017 12:19:02 +0000 (14:19 +0200)]
[DOC] Fix version number in documentation files

Releases: master, 8.7
Resolves: #81181
Change-Id: Ic99ff9d38b4f813a86b37e645b17cf4203a5a5a0
Reviewed-on: https://review.typo3.org/52747
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Do not sort tree nodes after each append 29/52729/2
Christer Vindberg [Thu, 27 Apr 2017 09:30:21 +0000 (11:30 +0200)]
[BUGFIX] Do not sort tree nodes after each append

Nodes should not be sorted after each element append but only once at
the end.

This will reduce the execution time of
DatabaseTreeDataProvider::buildRepresentationForNode() a lot e.g. when
a category menu tree is generated.

Resolves: #81039
Releases: master, 8.7
Change-Id: I9cb57630f0179a0b2b3c921ca1eb97e7455ce962
Reviewed-on: https://review.typo3.org/52729
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Correct typos in AbstractPlugin::pi_list_browseresults() 26/52726/2
Christian Futterlieb [Fri, 5 May 2017 14:12:22 +0000 (16:12 +0200)]
[BUGFIX] Correct typos in AbstractPlugin::pi_list_browseresults()

* Add a forgotten '$'
* Encapsulate ternary condition before concatenating strings

Resolves: #81153
Releases: master, 8.7
Change-Id: I0e180d2115435f0f41fb7b89862ff5d868c4dbd5
Reviewed-on: https://review.typo3.org/52726
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Add missing SQL index for EM repository update 25/52725/2
Claus Due [Mon, 1 May 2017 15:29:51 +0000 (17:29 +0200)]
[BUGFIX] Add missing SQL index for EM repository update

Due to the large number of extensions, the query that
checks if an extension exists needs an index that
covers all of the columns used for joining/clauses.

Change-Id: I73bd78a7d923a1e49594374b0dd8fee270fa30a3
Reviewed-on: https://review.typo3.org/52725
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[CLEANUP] Cleanup of method updateRefIndexTable 22/52722/2
Andreas Allacher [Thu, 9 Mar 2017 11:45:13 +0000 (12:45 +0100)]
[CLEANUP] Cleanup of method updateRefIndexTable

Limit the selected SQL fields to hash value only, since this
is sufficient for the processing. Use a boolean value for
$currentRelations to reduces memory footprint.

Resolves: #80207
Releases: master, 8.7
Change-Id: I323fa797b221c915848fc63cef78fb752a55ea26
Reviewed-on: https://review.typo3.org/52722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Avoid exceptions during indexing with indexed_search 05/52705/2
Georg Ringer [Thu, 4 May 2017 12:29:05 +0000 (14:29 +0200)]
[BUGFIX] Avoid exceptions during indexing with indexed_search

The exception "you need to add at least one set of values before
generating the SQL" occurs if the bulkInsert is triggered with
empty values. A check must be done before trying the query.

Resolves: #81140
Releases: master, 8.7
Change-Id: Ia0fe09e49d8e4b8341bda64ee248284c7ca2f3bd
Reviewed-on: https://review.typo3.org/52705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add `config.contentObjectExceptionHandler` to tsref.xml 98/52698/2
Andreas Fernandez [Mon, 1 May 2017 09:41:28 +0000 (11:41 +0200)]
[BUGFIX] Add `config.contentObjectExceptionHandler` to tsref.xml

The TypoScript setting `config.contentObjectExceptionHandler` was
introduced in TYPO3 7.0 but is still missing in tsref.xml. This patch
adds the configuration.

Resolves: #81093
Releases: master, 8.7, 7.6
Change-Id: Ib46891699aca91329aef302d87e562ac317892f2
Reviewed-on: https://review.typo3.org/52698
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Ignore open_basedir warning for files outside the website root 94/52694/2
Christian Toffolo [Wed, 26 Apr 2017 14:33:39 +0000 (16:33 +0200)]
[BUGFIX] Ignore open_basedir warning for files outside the website root

Suppress warnings generated by getFilenameFromMainDir() when it needs
to check file paths outside the website root and open_basedir
is in effect.

Resolves: #81024
Releases: master, 8.7
Change-Id: Ia339c907577547374545c0a94393f698828523c7
Reviewed-on: https://review.typo3.org/52694
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Show copy and cut buttons in filelist options 87/52687/2
Gianluigi Martino [Thu, 20 Apr 2017 16:15:24 +0000 (18:15 +0200)]
[TASK] Show copy and cut buttons in filelist options

At the moment it is only possible to copy or cut files / folder over the
clickmenu. With this patch the copy and cut functions are also listed as
buttons in option list.

Resolves: #80920
Releases: master, 8.7, 7.6
Change-Id: I75d4b8666858b78c4ed01514d43af4471cef5c2e
Reviewed-on: https://review.typo3.org/52687
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Resolve empty table row issue 85/52685/2
Henrik Elsner [Fri, 28 Apr 2017 15:38:58 +0000 (17:38 +0200)]
[TASK] Resolve empty table row issue

When saving a table content element an empty row was added
each time.
This issue is resolved by combining the lines to prevent
new line generation.

Resolves: #81050
Releases: master, 8.7
Change-Id: Id67808f10e1f573e587a08c9ff383fc7e0cc4dd5
Reviewed-on: https://review.typo3.org/52685
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Catch SQL Errors in SysRefindexHashUpdater 86/52686/2
Morton Jonuschat [Sat, 8 Apr 2017 22:04:12 +0000 (15:04 -0700)]
[BUGFIX] Catch SQL Errors in SysRefindexHashUpdater

Show the actual SQL error message to the user when an error
occurs while executing the update statements in the
SysRefindexHashUpdater instead of rethrowing the exception.

Change-Id: Ic3ca404438c221db6eecc5c912dcd416d2be6cde
Resolves: #80734
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Allow arbitrary protocols in new LinkService 84/52684/2
Benni Mack [Wed, 26 Apr 2017 18:40:21 +0000 (20:40 +0200)]
[BUGFIX] Allow arbitrary protocols in new LinkService

Since TYPO3 v8 it is not possible to simply create a link to "tel:+491727144385" anymore,
which was possible in TYPO3 v7. Instead an exception is thrown as the "toString()" method
cannot handle legacy links which have no specific type.

The patch checks for a "url" attribute allowing to represent a URL and to render a link via typolink.

Resolves: #80217
Releases: master, 8.7
Change-Id: I617e280295b4789a8c295f5ee21463a643e58afc
Reviewed-on: https://review.typo3.org/52684
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove unused property "cache_getRootline" in PageRepository 72/52672/2
Benni Mack [Tue, 2 May 2017 04:58:23 +0000 (06:58 +0200)]
[TASK] Remove unused property "cache_getRootline" in PageRepository

The protected property $cache_getRootLine is not in use anymore
and can safely be removed.

Resolves: #81101
Releases: master, 8.7
Change-Id: I4a91ed5ad9d3ae188063a060252d3da34c69abca
Reviewed-on: https://review.typo3.org/52672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] allow deletion folder with deleted references to files 79/52679/2
Andreas Allacher [Sat, 29 Apr 2017 18:27:32 +0000 (20:27 +0200)]
[BUGFIX] allow deletion folder with deleted references to files

Filelist currently doesn't allow the deletion of a folder
with references to files that have been deleted
because with doctrine migration the check for deleted=0 was
forgotten.

This patch adds the necessary check again.

Resolves: #81087
Releases: master, 8.7
Change-Id: Ie30704b7e6f41805150f44c5e41e7f679c903756
Reviewed-on: https://review.typo3.org/52679
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Info Pagetree Overview spaces between icons and text 78/52678/2
Gianluigi Martino [Mon, 10 Apr 2017 13:05:35 +0000 (15:05 +0200)]
[TASK] Info Pagetree Overview spaces between icons and text

Improved rendering of "Pagetree Overview" under the info module

Releases: master, 8.7
Resolves: #76472
Change-Id: Icb3a976c0b8080528dff3235950595052a65725d
Reviewed-on: https://review.typo3.org/52678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] LinkService must handle old ?id=xyz links 73/52673/2
Christer Vindberg [Mon, 1 May 2017 07:52:19 +0000 (09:52 +0200)]
[FOLLOWUP][BUGFIX] LinkService must handle old ?id=xyz links

Changed so ../index.php?id=xyz links are also matched.

Resolves: #80986
Releases: master, 8.7
Change-Id: Idc4cb14df406cc3e4b334fe59c6d8396ac54bc4c
Reviewed-on: https://review.typo3.org/52673
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Use absolute URL for avatars 69/52669/2
Benni Mack [Thu, 20 Apr 2017 22:43:41 +0000 (00:43 +0200)]
[BUGFIX] Use absolute URL for avatars

Rendering avatar URLs which are not on a remote (gravatar etc)
is the only part which deals with references as in ".." preventing
the TYPO3 Backend entryscript to be placed somewhere else as in typo3/.

Resolves: #81025
Releases: master, 8.7
Change-Id: I9abc51532149fe90ba027608cfb6bad6ea66115d
Reviewed-on: https://review.typo3.org/52669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure tables already processed are skipped when resuming upgrade 55/52655/2
Xavier Perseguers [Fri, 28 Apr 2017 13:17:27 +0000 (15:17 +0200)]
[BUGFIX] Ensure tables already processed are skipped when resuming upgrade

Change-Id: I991a9cbae2685abbcc606ce39d9f8395574491d1
Resolves: #81067
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52654
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: https://review.typo3.org/52655

2 years ago[BUGFIX] Fix typo in sys_registry key for fetching last wizard position 52/52652/2
Xavier Perseguers [Fri, 28 Apr 2017 12:27:53 +0000 (14:27 +0200)]
[BUGFIX] Fix typo in sys_registry key for fetching last wizard position

This fix will let upgrade wizard "Execute database migrations on single rows" restore
last reached position whenever the wizard is run again.

Change-Id: Iccaa14f82db4501447e7c553498a36074898b85b
Resolves: #81066
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52651
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: https://review.typo3.org/52652

2 years ago[BUGFIX] Load PageTSconfig in localconf for LinkHandler 47/52647/2
Benni Mack [Fri, 28 Apr 2017 08:49:04 +0000 (10:49 +0200)]
[BUGFIX] Load PageTSconfig in localconf for LinkHandler

The pageTSconfig for LinkHandler is only loaded in ext_tables.php
which means it is only evaluated in the Frontend when a Backend User
is logged in.

However the functionality did work before, if a compiled pageTS was
available in the cache. This could have happened that the pageTS cache
was filled while a BE user was logged in, so it worked (but only in
random cases).

Resolves: #81057
Releases: master, 8.7
Change-Id: I2a2462799a492af2dac90778c51c29cc5c11a782
Reviewed-on: https://review.typo3.org/52647
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] EXT:form - let the CountValidator provide its arguments 41/52641/3
Ralf Zimmermann [Mon, 3 Apr 2017 11:40:56 +0000 (13:40 +0200)]
[BUGFIX] EXT:form - let the CountValidator provide its arguments

* Provide the validator's arguments to TYPO3\CMS\Extbase\Validation\Error
* Prevent PHP errors if sprintf is tried to be called in case of empty
  argument arrays

Resolves: #80653
Releases: master, 8.7
Change-Id: I0f399501bc1091aa0034bd4de8652564535ce3f0
Reviewed-on: https://review.typo3.org/52641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use correct field `fe_group` instead of non-existent `fe_groups` 45/52645/2
Andreas Fernandez [Thu, 27 Apr 2017 17:41:43 +0000 (19:41 +0200)]
[BUGFIX] Use correct field `fe_group` instead of non-existent `fe_groups`

Since #80317, `BackendUtility::ADMCMD_previewCmds()` uses the field
`fe_groups` for the `pages` table, which does not exist. This patch
fixes the regression by using `fe_group` again.

Resolves: #81052
Related: #80317
Releases: master, 8.7
Change-Id: I08106704589fcab7607a9448b2eae646c611de93
Reviewed-on: https://review.typo3.org/52645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] CKEditor: Configuration properties not translatable 40/52640/2
Thorben Nissen [Thu, 20 Apr 2017 12:20:19 +0000 (14:20 +0200)]
[BUGFIX] CKEditor: Configuration properties not translatable

Adding custom stylesSets it is not possible to use "LLL:..." syntax. I
would be just display as is.

Add recursive resolving of "LLL:..." references in the configuration
properties.

Resolves: #80914
Releases: master, 8.7
Change-Id: I5c65f54cc3cc15cc4950df200828b48e124325f3
Reviewed-on: https://review.typo3.org/52640
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Load requireJS when requested 38/52638/2
Markus Klein [Thu, 27 Apr 2017 13:11:00 +0000 (15:11 +0200)]
[BUGFIX] Load requireJS when requested

When using requireJS in FE the method loadRequireJs() is called
implicitly when requiring modules.
A refactoring introduced a regression which causes the basic
requireJS code not to be loaded anymore.

Switch the lines to make this work again.

Releases: master, 8.7
Resolves: #81046
Change-Id: Ie511116a9a01c5c4b906f1e16712afa9f023d434
Reviewed-on: https://review.typo3.org/52638
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Code and comment clean up 34/52634/3
Benni Mack [Thu, 27 Apr 2017 05:02:55 +0000 (07:02 +0200)]
[TASK] Code and comment clean up

There are several places with typos, or wrong comments.

Additionally, some places still contain a check for PATH_site which dates
back to TYPO3 versions before a clean bootstrap was in place, and
where strict checks in conditions were forgotten.

Resolves: #81031
Releases: master, 8.7
Change-Id: I44e4f1647c52d0eaa843664b08cd05d56ab66aaf
Reviewed-on: https://review.typo3.org/52634
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove wrong usage of PageRepository->error_getRootLine_failPid 35/52635/2
Benni Mack [Wed, 26 Apr 2017 19:38:35 +0000 (21:38 +0200)]
[BUGFIX] Remove wrong usage of PageRepository->error_getRootLine_failPid

The TypoScript frontend calls TSFE->sys_page->getRootline() which fills
the public property "error_getRootLine_failPid" when the third parameter
is set. Otherwise it throws an exception.

Setting this option was actually removed in TYPO3 when the RootlineUtility
was introduced, making the third parameter very non-useful, as it does not
throw exceptions but instead writing some weird values in the error_getRootLine
property.

It also goes back to the case where branch versioning was still supported.

In case of regular frontend requests there is a lot of dead code now because
of always-false checks on $TSFE->sys_page->error_getRootLine_failPid == -1.

Resolves: #81027
Releases: master, 8.7
Change-Id: I141f145c1855f09c33f003422c8e34653bf7f951
Reviewed-on: https://review.typo3.org/52635
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update comments in ExtensionManagementUtility 32/52632/2
Jigal van Hemert [Thu, 13 Apr 2017 11:11:43 +0000 (13:11 +0200)]
[TASK] Update comments in ExtensionManagementUtility

Comments now mention that functions in ExtensionManagementUtility
must not be used in ext_tables.php

Resolves: #80837
Releases: master, 8.7
Change-Id: Ib36bdb1b6b6cc055759498199931f09b03065ebe
Reviewed-on: https://review.typo3.org/52632
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Initialize pagesTSconfig for link handler in FE 29/52629/2
Benni Mack [Wed, 26 Apr 2017 18:56:45 +0000 (20:56 +0200)]
[BUGFIX] Initialize pagesTSconfig for link handler in FE

In TYPO3 v8, $TSFE->pagesTSconfig is only initialized
when the frontend editing is active, but the link handler depends on the
value of pageTSconfig, for this reason, the method for initializing
should be used instead of the public property.

Resolves: #80883
Releases: master, 8.7
Change-Id: I6e7519c23f34867850160135ea8798911907338b
Reviewed-on: https://review.typo3.org/52629
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Set Fluid cache backend to SimpleFileBackend 22/52622/2
Claus Due [Tue, 25 Apr 2017 09:52:15 +0000 (11:52 +0200)]
[TASK] Set Fluid cache backend to SimpleFileBackend

A significant performance increase can be achieved
by switching to this backend because FileBackend
will do excessive calls to file_get_contents.

Affects every currently supported TYPO3 version.

Change-Id: I231c5b2ff7be3eecc8a4138cbd05af494d228297
Resolves: #81006
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] LinkService must handle old ?id=xyz links 18/52618/2
Markus Klein [Mon, 24 Apr 2017 12:42:36 +0000 (14:42 +0200)]
[BUGFIX] LinkService must handle old ?id=xyz links

Resolves: #80986
Releases: master, 8.7
Change-Id: Ibad311e95abca06f2e20656b3b34000a4dfdb8a0
Reviewed-on: https://review.typo3.org/52618
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Properly set format of StandaloneView 16/52616/2
Markus Klein [Tue, 25 Apr 2017 08:52:12 +0000 (10:52 +0200)]
[BUGFIX] Properly set format of StandaloneView

The internal TemplatePaths object of the BaseRenderingContext
needs to updated as well, when the format of a view is changed.

Resolves: #81003
Releases: master, 8.7
Change-Id: Ibb157f6f042b387ba008d1c9cebfcf3a3681141b
Reviewed-on: https://review.typo3.org/52616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add PAGES_TYPES to configuration view 04/52604/2
Christian Kuhn [Tue, 25 Apr 2017 11:05:27 +0000 (13:05 +0200)]
[TASK] Add PAGES_TYPES to configuration view

The 'configuration' module misses a clickable array
browser for $GLOBALS['PAGES_TYPES']. Add it.

Change-Id: I2679d5ebc8c3b195b0f7a5a6761ed299acfae9de
Resolves: #81007
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52604
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Switch to chrome in ac tests 03/52603/2
Christian Kuhn [Sun, 23 Apr 2017 18:03:46 +0000 (20:03 +0200)]
[TASK] Switch to chrome in ac tests

The acceptance tests currently rely on firefox esr build
and younger firefox versions don't run with given web driver.

The patch updates selenium dependency to youngest version,
adds chrome webdriver as dependency, hands over some start
arguments to chrome and fixes a couple of tests to stabilize
the acceptance tests with chrome.

Goal is a quicker acceptance tests execution with chrome
instead of firefox. Furthermore, it is now much easier to
execute the acceptance tests locally since just a "current"
chrome version is needed instead of an outdated firefox nobody
has installed by default. Additionally, chrome strives for
a headless version in its current dev build, which is an
additional option for the tests later to drop another dependency.

Change-Id: I2688969d70d95849145f931d86879e81d0d493f6
Resolves: #81010
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Jasmine update triggers JS test fails 96/52596/2
Christian Kuhn [Tue, 25 Apr 2017 08:49:48 +0000 (10:49 +0200)]
[BUGFIX] Jasmine update triggers JS test fails

jasmine js test framework update to 2.6.0 requires a function as
second argument of xdescribe(). Add it.

Change-Id: Ide0df9c3d05d465048d85a5426b4787d08df0cc6
Resolves: #81002
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Install Tool: Handle PCRE errors in row updater 70/52570/2
Markus Klein [Wed, 5 Apr 2017 17:32:38 +0000 (19:32 +0200)]
[BUGFIX] Install Tool: Handle PCRE errors in row updater

Add a check for the link updater to ensure
failed regex executions are detected and logged.

Resolves: #80712
Releases: master, 8.7
Change-Id: I90168939638520b36173d6d30191ec180667406f
Reviewed-on: https://review.typo3.org/52570
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Do not ask for current password if admin 56/52556/2
Markus Klein [Fri, 21 Apr 2017 20:29:43 +0000 (22:29 +0200)]
[BUGFIX] Do not ask for current password if admin

Hide the field for the current password, if the current user is
admin anyway. If the admin changes the password for someone else
he/she doesn't know the current password of this person anyway.

Besides that, a password can always be changed without providing
a current password by an admin using the BE users module.

Resolves: #80951
Releases: master, 8.7, 7.6
Change-Id: Ic9673197e651df5d1fe5886c4b6f6f76a303062f
Reviewed-on: https://review.typo3.org/52556
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use real BE user for logging user setting changes 54/52554/2
Markus Klein [Fri, 21 Apr 2017 19:14:52 +0000 (21:14 +0200)]
[BUGFIX] Use real BE user for logging user setting changes

When editing someone else's user settings as admin the log
should still show the editing user as responsible for the changes.

Resolves: #80947
Releases: master, 8.7, 7.6
Change-Id: I4d57826d65ae34325bea9efdfbd076e47fff0d6d
Reviewed-on: https://review.typo3.org/52554
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not override global BE_USER for user settings simulation 51/52551/2
Markus Klein [Fri, 21 Apr 2017 19:07:01 +0000 (21:07 +0200)]
[BUGFIX] Do not override global BE_USER for user settings simulation

Instead of replacing the global user for simulating another user
to edit user settings, store the "user to edit" in the controller.

This prevents a whole lot of possible errors.

Resolves: #80948
Releases: master, 8.7
Change-Id: I302fa9fc3cb17083f2285d786b2072607eb37bb6
Reviewed-on: https://review.typo3.org/52551
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove horizontal scrollbar 50/52550/2
Henrik Elsner [Thu, 20 Apr 2017 08:54:21 +0000 (10:54 +0200)]
[BUGFIX] Remove horizontal scrollbar

Remove the horizontal scrollbar in
Install Tool - System environment, when phpinfo is shown.
Also add some small space for the mobile menu.

Resolves: #79907
Releases: master, 8.7
Change-Id: Ic60e77e768c287ccb25e9c89cd0f37bcc97074a5
Reviewed-on: https://review.typo3.org/52550
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove some outdated keys from tokenizetyposcript.js 46/52546/2
Christian Kuhn [Fri, 21 Apr 2017 17:19:40 +0000 (19:19 +0200)]
[BUGFIX] Remove some outdated keys from tokenizetyposcript.js

Keys 'allSaveFunctions' and 'disableTabInTextarea' have been removed
from the setup module a while ago.

Change-Id: I60e857a9d976ed801b46068565f811ad45d44e0b
Resolves: #80946
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52546
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add new bootstrap-slider version 44/52544/2
Henrik Elsner [Thu, 20 Apr 2017 10:57:51 +0000 (12:57 +0200)]
[TASK] Add new bootstrap-slider version

Add new bootstap-slider version 9.7.3
Changes:
- Updates unit test suite to Jasmine 2.x.x

Resolves: #80907
Releases: master, 8.7
Change-Id: I10e47e2ef8fc6eb95aedb2d25e0756e1e00dd3fe
Reviewed-on: https://review.typo3.org/52544
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use correct TypoScriptService in ClickEnlargeViewHelper 41/52541/2
Wouter Wolters [Thu, 20 Apr 2017 18:23:59 +0000 (20:23 +0200)]
[BUGFIX] Use correct TypoScriptService in ClickEnlargeViewHelper

The Extbase TypoScriptService is used but should use the one from
the core.

Resolves: #80918
Releases: master,8.7
Change-Id: Ice000c0b6807482d442705362ba5fa444baf8eba
Reviewed-on: https://review.typo3.org/52541
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Ensure Install Tool is not using a deprecated property 36/52536/2
Benni Mack [Thu, 20 Apr 2017 18:15:32 +0000 (20:15 +0200)]
[BUGFIX] Ensure Install Tool is not using a deprecated property

The install tool still uses a variable which is deprecated.

Instead, the install tool already defines absPrefix as PATH_site which
is the way to go here.

Resolves: #80690
Releases: master, 8.7
Change-Id: Ib87e0a91e6e7b2151e019881dd137a0b011ae488
Reviewed-on: https://review.typo3.org/52536
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework from 1.0.1 to 1.0.5 34/52534/3
Christian Kuhn [Thu, 20 Apr 2017 20:15:08 +0000 (22:15 +0200)]
[TASK] Update typo3/testing-framework from 1.0.1 to 1.0.5

A couple of composer changes and removal of a deprecated core call.

Change-Id: I8c3ad0689800f8848c39a31a4a76dc411314314f
Resolves: #80930
Releases: 8.7
Reviewed-on: https://review.typo3.org/52534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Replace old optionSplit method calls 04/52504/2
Benni Mack [Wed, 19 Apr 2017 11:54:22 +0000 (13:54 +0200)]
[BUGFIX] Replace old optionSplit method calls

The Core has marked "TemplateService->splitConfArray" as deprecated, but
it is still used in some areas which have been forgotten.

The patch replaces the according calls to use the new TypoScriptService->
explodeConfigurationForOptionSplit method.

Resolves: #80892
Releases: master, 8.7
Change-Id: Ic8fe18c93f6658c24f3585142ec777fe0b4fca46
Reviewed-on: https://review.typo3.org/52504
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Set TYPO3 version to 8.7.2-dev 89/52489/2
TYPO3 Release Team [Tue, 18 Apr 2017 17:03:31 +0000 (19:03 +0200)]
[TASK] Set TYPO3 version to 8.7.2-dev

Change-Id: Ib6d099e6110eebdfb863d6fbe67ac09e7046c207
Reviewed-on: https://review.typo3.org/52489
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 8.7.1 88/52488/2 8.7.1 TYPO3_8-7-1
TYPO3 Release Team [Tue, 18 Apr 2017 17:01:48 +0000 (19:01 +0200)]
[RELEASE] Release of TYPO3 8.7.1

Change-Id: I0584cf00ac9234d2dfd3f17e45573760b187b4da
Reviewed-on: https://review.typo3.org/52488
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] Update branch alias for composer version 78/52478/7
Benni Mack [Tue, 18 Apr 2017 11:50:39 +0000 (13:50 +0200)]
[BUGFIX] Update branch alias for composer version

After branching it must be clear that 9.x is the latest development
branch where 8.x is mapped to TYPO3_8-7.

Additionally for the testing framework, composer needs to know
TYPO3_8-7 is handled as a version branch and not a feature branch.

Resolves: #80877
Releases: 8.7
Change-Id: I59857537167e552be786af1ef9756226d8e468b6
Reviewed-on: https://review.typo3.org/52478
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use new CLI binary in docs instead of cli_dispatch.phpsh 73/52473/3
Benni Mack [Mon, 17 Apr 2017 21:45:29 +0000 (23:45 +0200)]
[TASK] Use new CLI binary in docs instead of cli_dispatch.phpsh

There are still some places left where legacy functionality is used
or documented related to cli_dispatch.phpsh instead of the generic
typo3/sysext/core/bin/typo3 binary.

Resolves: #80868
Releases: master, 8.7
Change-Id: Iad3392403a0e1b16ed42422f840de647f0b9ce0d
Reviewed-on: https://review.typo3.org/52473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use correct value for EU flag in sys_language records 36/52436/2
Daniel Goerz [Thu, 13 Apr 2017 07:50:42 +0000 (09:50 +0200)]
[BUGFIX] Use correct value for EU flag in sys_language records

Change-Id: I6cb873b0013f8324f247a19de4f663ca2e4d4848
Resolves: #80834
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52436
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix bug due to improper usage of boolean as object 35/52435/6
sven_carstens [Tue, 11 Apr 2017 13:44:21 +0000 (15:44 +0200)]
[BUGFIX] Fix bug due to improper usage of boolean as object

\Doctrine\DBAL\Statement returns a boolean from calls to the execute() method.
To get the results of the query we obviously can't use that and must use the
original instance of \Doctrine\DBAL\Statement in $realStatement.

Resolves: #80781
Releases: master
Change-Id: If1443a9c519bf2fddf7e3983f4b740ea025b3c2d
Reviewed-on: https://review.typo3.org/52435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/cms-styleguide from 8.0.8 to 8.0.9 64/52464/2
Christian Kuhn [Sun, 16 Apr 2017 14:16:44 +0000 (16:16 +0200)]
[TASK] Update typo3/cms-styleguide from 8.0.8 to 8.0.9

Change-Id: Ic3d0d13d333f4e74e1dd416c8777e685a809b3d2
Resolves: #80858
Releases: master
Reviewed-on: https://review.typo3.org/52464
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] AbstractMessage should have string, but integer is given 45/52445/2
Oliver Hader [Fri, 14 Apr 2017 10:54:41 +0000 (12:54 +0200)]
[BUGFIX] AbstractMessage should have string, but integer is given

FlashMessage setter have been extended with strict scalar types,
however the disposal for e.g. Exception has not been adjusted to
ensure proper types.

Change-Id: Idcfbef5a7ee6a401977c69bebd9f9516ec1b6997
Resolves: #80762
Releases: master
Reviewed-on: https://review.typo3.org/52445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] EXT:form - Fix default file upload mime types 12/52312/2
Ralf Zimmermann [Sat, 1 Apr 2017 15:40:07 +0000 (17:40 +0200)]
[BUGFIX] EXT:form - Fix default file upload mime types

This patch fixes the wrong mime types of file upload form elements.

Resolves: #80627
Releases: master
Change-Id: I208570bc1595946c08a386c177525d999dea5222
Reviewed-on: https://review.typo3.org/52312
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Cover trivial setters and getters of cObj with unit tests 58/52258/7
Elmar Hinz [Thu, 30 Mar 2017 12:22:37 +0000 (14:22 +0200)]
[TASK] Cover trivial setters and getters of cObj with unit tests

Cover trivial setters and getters of ContentObjectRenderer with
unit tests.

Releases: master
Resolves: #80574
Change-Id: Ibcad1c1d7166ad4f51eabd092a0b1301291c4875
Reviewed-on: https://review.typo3.org/52258
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use correct order of SQL parameters in SysRefindexHashUpdater 97/52397/4
Morton Jonuschat [Sat, 8 Apr 2017 21:31:36 +0000 (14:31 -0700)]
[BUGFIX] Use correct order of SQL parameters in SysRefindexHashUpdater

Supply the positional parameter arguments to the update statement in
the correct order. The statement used for the updates reads
'UPDATE `sys_refindex` SET `hash` = ? WHERE `hash` = ?'
and thus the parameters should be in the order new hash, old hash,
not the other way around.
It's the final order in the statement that's relevant when supplying the
parameters, not the order in which they are defined in PHP.

Changed the definition order in PHP to match the order in the final
SQL statement as well.

Change-Id: I7829bbc835a6b0f263b61fa07b2e39b36d846275
Resolves: #80766
Releases: master
Reviewed-on: https://review.typo3.org/52397
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Quote table and fieldnames in BackendUtility::BEenableFields 01/52401/2
Morton Jonuschat [Sat, 8 Apr 2017 22:24:12 +0000 (15:24 -0700)]
[BUGFIX] Quote table and fieldnames in BackendUtility::BEenableFields

Use Doctrine API to quote table and field names in BEenableFields().

Resolves: #80768
Releases: master
Change-Id: Ia473b2c25b9745059263be5b2dc3eb6a30343e0b
Reviewed-on: https://review.typo3.org/52401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Extbase: quote table and field names in join statements 00/52400/2
Morton Jonuschat [Sat, 8 Apr 2017 22:20:40 +0000 (15:20 -0700)]
[BUGFIX] Extbase: quote table and field names in join statements

Properly quote table and field names when building join statements
within Typo3DbQueryParser.

Change-Id: Ia2c977d198e6fe67999eaa5b0441a568cbf1b5c9
Resolves: #80767
Releases: master
Reviewed-on: https://review.typo3.org/52400
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] EXT:form - minor UX/ UI optimizations 28/52328/4
Ralf Zimmermann [Mon, 3 Apr 2017 09:40:22 +0000 (11:40 +0200)]
[TASK] EXT:form - minor UX/ UI optimizations

* Add module description text
* Change order of form elements within the "create new element" modal
* Allow changing labels of submit, previous, and next button within the
  form editor

Resolves: #80650
Releases: master
Change-Id: Ibeced5cdfcbc5c0124b74dea599d21c446c76eb4
Reviewed-on: https://review.typo3.org/52328
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Change TYPO3-logo from png to svg 14/52414/3
Henrik Elsner [Tue, 11 Apr 2017 11:17:02 +0000 (13:17 +0200)]
[TASK] Change TYPO3-logo from png to svg

Resolves: #78508
Releases: master
Change-Id: Ia31a0cb2e222408a831bdd5c322864dcf378a593
Reviewed-on: https://review.typo3.org/52414
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Use named parameters in Extbase IN() queries 92/52392/2
Morton Jonuschat [Sat, 8 Apr 2017 04:43:21 +0000 (21:43 -0700)]
[BUGFIX] Use named parameters in Extbase IN() queries

Try to infer the parameter type from the value and create a named
parameter per value passed to the IN() comparison.

Change-Id: Ifc9761d077154fe4f6cbf580519b1d65dc8912c1
Releases: master
Resolves: #80744
Reviewed-on: https://review.typo3.org/52392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Luis García
Tested-by: Luis García
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Show same edit icon in filelist clickmenu 09/52309/2
Gianluigi Martino [Sat, 1 Apr 2017 09:46:40 +0000 (11:46 +0200)]
[TASK] Show same edit icon in filelist clickmenu

In filelist clickmenu the wrong editfile icon is used

Resolves: #80624
Releases: master
Change-Id: Ib7e4b79cdc5b474253fb3df4554de4e800cf331a
Reviewed-on: https://review.typo3.org/52309
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Mark ext:form as stable 13/52413/2
Henrik Elsner [Tue, 11 Apr 2017 09:08:44 +0000 (11:08 +0200)]
[TASK] Mark ext:form as stable

Resolves: #80674
Releases: master
Change-Id: Iac7ff82460de670402702fa829d8a21b368ea25d
Reviewed-on: https://review.typo3.org/52413
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Make EXT:form checkbox markup compatible to Bootstrap 29/52329/3
Ralf Zimmermann [Mon, 3 Apr 2017 09:57:06 +0000 (11:57 +0200)]
[BUGFIX] Make EXT:form checkbox markup compatible to Bootstrap

Resolves: #80647
Releases: master
Change-Id: I915238b0179c7bbb81196b70a982642b34299773
Reviewed-on: https://review.typo3.org/52329
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[BUGFIX] Do not prefix FAL file links with absRefPrefix 80/52380/3
Helmut Hummel [Thu, 6 Apr 2017 20:31:36 +0000 (22:31 +0200)]
[BUGFIX] Do not prefix FAL file links with absRefPrefix

When using an external FAL storage the public URLs of files contain a scheme.
Check for the scheme before prefixing with absRefPrefix
in file link builder.

Resolves: #80740
Releases: 7.6, master
Change-Id: I98c1027931f6c4c05561e35d1d7938aefd66eda0
Reviewed-on: https://review.typo3.org/52380
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Minor UX optimization in "Record selector" pop-up window 70/52370/3
Gianluigi Martino [Wed, 5 Apr 2017 18:31:39 +0000 (20:31 +0200)]
[TASK] Minor UX optimization in "Record selector" pop-up window

Improved rendering of "Record selector" pop-up window on smaller screens

Releases: master
Resolves: #80644
Change-Id: I21e18da9e3c5b424be59b55f80920abeb9026d23
Reviewed-on: https://review.typo3.org/52370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Add extra info to description in SysRefindexHashUpdater 82/52382/4
Thomas Hohn [Fri, 7 Apr 2017 08:57:18 +0000 (10:57 +0200)]
[TASK] Add extra info to description in SysRefindexHashUpdater

Installations having a large sys_refindex should perform the
update of the hash from the command line instead of using the
"Upgrade Wizard" since it will fail due to excessive memory
and time usage.

Resolves: #80743
Related: #80734
Releases: master
Change-Id: I70c1e5e5c35a1603c4a7d088e87eabe320465d9e
Reviewed-on: https://review.typo3.org/52382
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Email links with parameters in LegacyLinkNotationConverter 02/52402/3
Morton Jonuschat [Sat, 8 Apr 2017 23:06:55 +0000 (16:06 -0700)]
[BUGFIX] Email links with parameters in LegacyLinkNotationConverter

Email addresses in link can have added query parameters to control
fields like the subject in the mail client.
Add a test to the LinkServiceTest for this case and add support for
this feature to the converter.

Change-Id: I06cbb2e12eace70825aac179d1af85227804ce39
Resolves: #80723
Releases: master
Reviewed-on: https://review.typo3.org/52402
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Correct stylelint violations in scss files 84/52384/2
Benjamin Kott [Fri, 7 Apr 2017 11:50:00 +0000 (13:50 +0200)]
[BUGFIX] Correct stylelint violations in scss files

Resolves: #80747
Releases: master
Change-Id: Ifdf78f52dcbdb349c1a507d0e3324fa482cc0862
Reviewed-on: https://review.typo3.org/52384
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Hide download distributions in composer mode 54/52354/3
Frans Saris [Tue, 4 Apr 2017 08:40:38 +0000 (10:40 +0200)]
[BUGFIX] Hide download distributions in composer mode

When installation is done with composer hide the
download distributions options in the install steps.

Resolves: #80673
Releases: master
Change-Id: I0cce6888b1af84cec879ce415106acf81fbac146
Reviewed-on: https://review.typo3.org/52354
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Correct view webpage link anchor in list module 37/52337/2
Gianluigi Martino [Mon, 3 Apr 2017 12:18:46 +0000 (14:18 +0200)]
[TASK] Correct view webpage link anchor in list module

Without this patch you land to the top of the page if you open the preview
of a content element in list module. Adding "c" as letter to the anchor
link the browser scroll to the desired content element.

Resolves: #80598
Releases: master, 7.6
Change-Id: Ief0c3764a57911f9dd46dd7b9e19be964b0e2671
Reviewed-on: https://review.typo3.org/52337
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Ignore deleted references when deleting a file 87/52387/2
Frans Saris [Fri, 7 Apr 2017 14:16:34 +0000 (16:16 +0200)]
[BUGFIX] Ignore deleted references when deleting a file

With the doctrine migration the check for deleted=0 was forgotten.

This patch brings this check back and now files with deleted references
can be deleted again.

Resolves: #80692
Releases: master
Change-Id: Ie7c8103a7c6ee308b57576777e26b961a4f6c644
Reviewed-on: https://review.typo3.org/52387
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - Avoid JavaScript errors 38/52338/3
Ralf Zimmermann [Mon, 3 Apr 2017 12:40:08 +0000 (14:40 +0200)]
[BUGFIX] EXT:form - Avoid JavaScript errors

Avoid JavaScript errors especially if you try to remove a
"Required field" validator from an element which has no validator
select list (like a checkbox).

Resolves: #80657
Releases: master
Change-Id: Id117250ad131a2367c87fc39b6fdb698d84cd421
Reviewed-on: https://review.typo3.org/52338
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGIFX] Allow file replace for editors 79/52379/3
Helmut Hummel [Thu, 6 Apr 2017 19:07:16 +0000 (21:07 +0200)]
[BUGIFX] Allow file replace for editors

When file extension permissions are configured, replacing
a file fails with an error message, because the file extension
is checked on the local path of the temporary file.

Remove this bogus check to allow file replace for editors.

Resolves: #77855
Releases: 6.2, 7.6, master
Change-Id: Icaf01252b3dbcfbdfb89349281389465f9e0ce9a
Reviewed-on: https://review.typo3.org/52379
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not use doctrine constraints without bind values 62/52362/3
Christer Vindberg [Tue, 4 Apr 2017 10:59:17 +0000 (12:59 +0200)]
[BUGFIX] Do not use doctrine constraints without bind values

Changed so doctrine constraints without the corresponding
bind values aren't passed around.

The $constraints variable defined in CleanerTask->cleanTable
is reused in CleanerTask->deleteFilesForTable, but without
the doctrine createNamedParameter bind variables, since the
querybuilder is recreated. This caused the task to fail.

Resolves: #80675
Releases: master
Change-Id: I2da9b33f884f51bf9d90a9d08841fb4491eedea2
Reviewed-on: https://review.typo3.org/52362
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Install tool css id used twice 46/52346/2
Christian Kuhn [Mon, 3 Apr 2017 20:04:42 +0000 (22:04 +0200)]
[BUGFIX] Install tool css id used twice

css id 't3-install-password' is used twice in 'change install tool password'
and again in 'create administrator', clicking the password label of the admin
section thus sets focus on the 'change install tool password' input field.

Rename css if of the 'create administrator' section.

Change-Id: Iaacd87b5df77cee20593018303e5943df4801d0a
Resolves: #80607
Releases: master
Reviewed-on: https://review.typo3.org/52346
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Add unit test to cover ContentObjectRenderer::linkWrap 81/52281/7
Elmar Hinz [Fri, 31 Mar 2017 08:42:48 +0000 (10:42 +0200)]
[TASK] Add unit test to cover ContentObjectRenderer::linkWrap

Add unit test to cover ContentObjectRenderer::linkWrap.

Releases: master
Resolves: #80596
Change-Id: I9cdc5a443e8f9518960bbcbc10d4938877cde5a1
Reviewed-on: https://review.typo3.org/52281
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Allow editing of yaml files in the backend 34/52334/3
Ingo Pfennigstorf [Mon, 3 Apr 2017 11:34:56 +0000 (13:34 +0200)]
[BUGFIX] Allow editing of yaml files in the backend

This adds the yaml file extension to the known textfile extensions for
the backend, so that i.e. form manifests are editable in the backend.

Resolves: #80654
Releases: master
Change-Id: I9306211c16ec83128c002e04ba30dd7d6c1f80be
Reviewed-on: https://review.typo3.org/52334
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Point new user to correct folder on first install 53/52353/3
Frans Saris [Tue, 4 Apr 2017 07:23:51 +0000 (09:23 +0200)]
[BUGFIX] Point new user to correct folder on first install

The FIRST_INSTALL needs to be created in the web root of your project
and not in the root of your project as that can be below the web root.

Releases: master
Resolves: #80671
Change-Id: Ib6ffc32e93b18d6792193761970fa9c1c866ba4f
Reviewed-on: https://review.typo3.org/52353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Avoid unused xpath when parsing locallang.xml 51/51851/4
Stephan Großberndt [Sat, 25 Feb 2017 11:30:09 +0000 (12:30 +0100)]
[TASK] Avoid unused xpath when parsing locallang.xml

Increased performance by avoiding an xpath query if the requested
element is not 'target'.

Releases: master, 7.6
Resolves: #80016
Change-Id: I509de5bfb79701efe966d16bc29aaae6a46050ef
Reviewed-on: https://review.typo3.org/51851
Reviewed-by: Faton Haliti <fha@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Determine default severity for modals correctly 56/52356/5
Andreas Fernandez [Tue, 4 Apr 2017 09:15:36 +0000 (11:15 +0200)]
[BUGFIX] Determine default severity for modals correctly

This patch fixes the determination of the default severity for modals.
This ensures that the modal's header and its default button receive
the same coloring.

Resolves: #80677
Related: #80579
Releases: master
Change-Id: I7bfc5bff21a28318b2fea03f5fe534264e47cbb0
Reviewed-on: https://review.typo3.org/52356
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Prevent replace of <link> tags in TypoScript setup 66/52366/3
Frank Naegler [Wed, 5 Apr 2017 12:42:07 +0000 (14:42 +0200)]
[BUGFIX] Prevent replace of <link> tags in TypoScript setup

This patch prevent the wizard "Execute database migrations on single rows"
to deletes the whole TypoScript setup from sys_template.

Resolves: #80680
Releases: master
Change-Id: I90162b4add42781445dfa2a12d1b6fcb2fb57c00
Reviewed-on: https://review.typo3.org/52366
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Fix typo in a typoscript comment 65/52365/5
Albrecht Köhnlein [Wed, 5 Apr 2017 09:58:40 +0000 (11:58 +0200)]
[CLEANUP] Fix typo in a typoscript comment

Correct spelling of the word "compatibility"

Resolves: #80691
Releases: master
Change-Id: Iaae10ff0717af3b7dd81ebe9e3fa95acbf7e5f9f
Reviewed-on: https://review.typo3.org/52365
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Adapt fluid_styled_content paths in initial page 64/52364/4
Helmut Hummel [Wed, 5 Apr 2017 07:46:12 +0000 (09:46 +0200)]
[BUGFIX] Adapt fluid_styled_content paths in initial page

When installing TYPO3 with the option to create a page with
TypoScript template, the template does not match the latest
state of fluid_styled_content.

Adapt path and reference the content rendering instead of copying it.

Resolves: #80685
Releases: master
Change-Id: I983dea9ba64d6fb17336828fd0212dadae557ef8
Reviewed-on: https://review.typo3.org/52364
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Set TYPO3 version to 8.7.1-dev 61/52361/2
TYPO3 Release Team [Tue, 4 Apr 2017 10:53:54 +0000 (12:53 +0200)]
[TASK] Set TYPO3 version to 8.7.1-dev

Change-Id: I66c96891492626a868c2e9de7963ffe5a9761837
Reviewed-on: https://review.typo3.org/52361
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 8.7.0 60/52360/2 8.7.0 TYPO3_8-7-0
TYPO3 Release Team [Tue, 4 Apr 2017 10:51:49 +0000 (12:51 +0200)]
[RELEASE] Release of TYPO3 8.7.0

Change-Id: I39ef41f945fc2b9bbc74aefc87fb3bbd3a087fcd
Reviewed-on: https://review.typo3.org/52360
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] Introduction package fails in DataMapProcessor 57/52357/3
Oliver Hader [Tue, 4 Apr 2017 09:19:56 +0000 (11:19 +0200)]
[BUGFIX] Introduction package fails in DataMapProcessor

Change-Id: Icf785d1c79d739fff70aeed8e7745cfedc3993ac
Resolves: #80676
Releases: master
Reviewed-on: https://review.typo3.org/52357
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Creating typolink in backend should not throw an exception 51/52351/3
Benni Mack [Tue, 4 Apr 2017 06:38:15 +0000 (08:38 +0200)]
[BUGFIX] Creating typolink in backend should not throw an exception

The global $TSFE object is not available in the Backend anymore.

In order to use <f:link.typolink> in e.g. a toolbar item or a preview
element, the TSFE object should be created as dummy so at least an index.php
URL (or external URL) is shown.

Resolves: #80669
Releases: master
Change-Id: I24a23a2d562c62e5663753bb80c75cc05164a6c9
Reviewed-on: https://review.typo3.org/52351
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent Exception when form folder doesn't exists 52/52352/2
Frans Saris [Tue, 4 Apr 2017 06:49:34 +0000 (08:49 +0200)]
[BUGFIX] Prevent Exception when form folder doesn't exists

When for ext:form an addition allowedFileMounts is set to an
not existing folder you get an FolderDoesNotExistException when
opening the form editor.

This patch catches the FolderDoesNotExistException and ignores the
folder when not present.

Releases: master
Resolves: #80670
Change-Id: I40994cf0f7b7a005c0b902736c71dcb006b612dd
Reviewed-on: https://review.typo3.org/52352
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>