Packages/TYPO3.CMS.git
3 years ago[TASK] Remove $db property in UserAuthentication classes 66/48366/2
Markus Klein [Sat, 28 May 2016 16:14:18 +0000 (18:14 +0200)]
[TASK] Remove $db property in UserAuthentication classes

Resolves: #76353
Releases: master
Change-Id: I90799c3652e7edd8ee3048f39b50237470fed19b
Reviewed-on: https://review.typo3.org/48366
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess 60/48360/4
Stephan Großberndt [Sat, 28 May 2016 12:17:21 +0000 (14:17 +0200)]
[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess

Resolves: #76352
Releases: master, 7.6
Change-Id: I8332c93f1171d030d4198091779c8f1242c9337b
Reviewed-on: https://review.typo3.org/48360
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Add comment explaining spamProtectEmailAddresses=ascii 59/48359/2
Stephan Großberndt [Sat, 28 May 2016 12:08:51 +0000 (14:08 +0200)]
[TASK] Add comment explaining spamProtectEmailAddresses=ascii

Resolves: #76351
Releases: master
Change-Id: Ic6971eaa4f2bf195022334c103e5af0a6079aed3
Reviewed-on: https://review.typo3.org/48359
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Deprecate the argument 'hsc' for getLL, getLLL and sL 53/48353/4
Valentin Despa [Sat, 28 May 2016 11:22:03 +0000 (13:22 +0200)]
[TASK] Deprecate the argument 'hsc' for getLL, getLLL and sL

This patch deprecates the parameter 'hsc' within the following
methods of TYPO3\CMS\Lang\LanguageService:

    * getLL
    * getLLL
    * sL

Resolves: #71917
Releases: master
Change-Id: I0aa9d0ad12d20719f2367459765dccb57cac69e8
Reviewed-on: https://review.typo3.org/48353
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Deprecate path prefixes in callUserFunction and getUserObj 52/48352/5
Benni Mack [Sat, 28 May 2016 11:31:04 +0000 (13:31 +0200)]
[TASK] Deprecate path prefixes in callUserFunction and getUserObj

The possibility to call "GeneralUtility::callUserFunc()"
and "getUserObj()" with the first parameter containing the file reference
to the function or class separated by a colon is deprecated.

An example is "EXT:realurl/class.tx_realurl.php:tx_realurl->encodeSpURL".

Calling one of the methods above with this syntax now triggers a
deprecation message.

It is encouraged to use the common autoloading functionality of
composer or via the fallback autoloader by TYPO3 to achieve the
same functionality.

Resolves: #76345
Releases: master
Change-Id: Iaaa2f825d330681199f0b0928727b93bbd3c73a7
Reviewed-on: https://review.typo3.org/48352
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Display version selector in info module 51/48351/2
Stephan Großberndt [Sat, 28 May 2016 10:49:23 +0000 (12:49 +0200)]
[BUGFIX] Display version selector in info module

This patch restores the version selector in info module which was
broken during the fluidification of the info module.

Resolves: #76343
Related: #74360
Releases: master
Change-Id: I5488f5b7ca7efd28c5508c1e1e50cf55d3e14f38
Reviewed-on: https://review.typo3.org/48351
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of getLL part 4/3 50/48350/2
Markus Klein [Sat, 28 May 2016 10:36:27 +0000 (12:36 +0200)]
[TASK] Remove second parameter of getLL part 4/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: I71ed4d93c48731cad8cf88cc1de002190f38ba9a
Reviewed-on: https://review.typo3.org/48350
Reviewed-by: Valentin Despa <info@vdespa.de>
Tested-by: Valentin Despa <info@vdespa.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Use a getter for the LanguageService in ext:version 37/48337/7
Wouter Wolters [Fri, 27 May 2016 14:06:04 +0000 (16:06 +0200)]
[TASK] Use a getter for the LanguageService in ext:version

Resolves: #76330
Releases: master
Change-Id: Ifff1c2bf9af25bf1a57de4f80ce356dad3462b64
Reviewed-on: https://review.typo3.org/48337
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Cache requireJS configuration 30/42730/12
Markus Klein [Tue, 18 Aug 2015 19:59:20 +0000 (21:59 +0200)]
[TASK] Cache requireJS configuration

This avoids lots of filesystem I/O because it does not crawl all
extensions on each BE request anymore.

Resolves: #69172
Releases: master
Change-Id: Ibe83caed164f78f51718fbd34e334f980a8e40d8
Reviewed-on: https://review.typo3.org/42730
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Unit test to cover stdWrap_stripHTML 42/48242/5
Elmar Hinz [Mon, 23 May 2016 07:03:42 +0000 (09:03 +0200)]
[TASK] Unit test to cover stdWrap_stripHTML

Resolves: #76261
Releases: master
Change-Id: I64ed81604b92e1c929a5252b396c0d3a21098c2b
Reviewed-on: https://review.typo3.org/48242
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Deprecate DocumentTemplate methods 69/47769/8
Benni Mack [Tue, 19 Apr 2016 05:27:23 +0000 (07:27 +0200)]
[TASK] Deprecate DocumentTemplate methods

This patch deprecates the following parameters/methods within
DocumentTemplate:

* sectionFlag (is internal)
* viewPageIcon()
* getHeader()
* getResourceHeader()
* header()
* icons()
* t3Button()
* wrapScriptTags()
* loadJavascriptLib()
* getContextMenuCode()

Resolves: #72859
Releases: master
Change-Id: I589c364ec506793439ac007b002cf28a6e1ca69d
Reviewed-on: https://review.typo3.org/47769
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Add proper comments in DefaultConfiguration options 41/48341/2
Benni Mack [Fri, 27 May 2016 15:06:27 +0000 (17:06 +0200)]
[BUGFIX] Add proper comments in DefaultConfiguration options

Some descriptions of options in DefaultConfiguration are not visible in
the Install Tool. These are added and made sure to be rendered
in the Install Tool.

Resolves: #76333
Releases: master, 7.6
Change-Id: I87d90b7614d5c90a1d212d0a214ef26dc2d5fcfc
Reviewed-on: https://review.typo3.org/48341
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of sL - Part 3/3 46/48346/3
Valentin Despa [Fri, 27 May 2016 17:23:10 +0000 (19:23 +0200)]
[TASK] Remove second parameter of sL - Part 3/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3
Reviewed-on: https://review.typo3.org/48346
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove second parameter of sL - Part 2/3 44/48344/3
Valentin Despa [Fri, 27 May 2016 16:20:33 +0000 (18:20 +0200)]
[TASK] Remove second parameter of sL - Part 2/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: Ibaae459cb81a4fb9616e953d772603acf85e4d11
Reviewed-on: https://review.typo3.org/48344
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of sL - Part 1/3 38/48338/2
Valentin Despa [Fri, 27 May 2016 14:10:07 +0000 (16:10 +0200)]
[TASK] Remove second parameter of sL - Part 1/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: I6267c45daeddf9a652ad63acb014c824721df25f
Reviewed-on: https://review.typo3.org/48338
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Fix undefined property rUri in TableController 34/48334/2
Wouter Wolters [Fri, 27 May 2016 13:38:27 +0000 (15:38 +0200)]
[BUGFIX] Fix undefined property rUri in TableController

Resolves: #76329
Releases: master,7.6
Change-Id: Ie5320e71aa8ded5b744997b6f1ca71c3542aa2f0
Reviewed-on: https://review.typo3.org/48334
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] unserialize() without objects in impexp 33/48333/2
Christian Kuhn [Fri, 27 May 2016 13:19:42 +0000 (15:19 +0200)]
[TASK] unserialize() without objects in impexp

Change-Id: I09d769584dc4389d0d6e0d2ffa3e8e1b0fa571ad
Resolves: #76327
Releases: master
Reviewed-on: https://review.typo3.org/48333
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Remove second parameter of getLL part 3/3 32/48332/3
Wouter Wolters [Fri, 27 May 2016 13:21:09 +0000 (15:21 +0200)]
[TASK] Remove second parameter of getLL part 3/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: I513c5915c9273c906b6b828d65425ac8ee485e12
Reviewed-on: https://review.typo3.org/48332
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of getLL part 2/3 30/48330/2
Wouter Wolters [Fri, 27 May 2016 12:20:21 +0000 (14:20 +0200)]
[TASK] Remove second parameter of getLL part 2/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: Ieabcf550883ebcf85fe13232caab249b0f37e4b1
Reviewed-on: https://review.typo3.org/48330
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Obsolete unserialize(serialize()) 27/48327/3
Christian Kuhn [Fri, 27 May 2016 11:36:13 +0000 (13:36 +0200)]
[TASK] Obsolete unserialize(serialize())

There is a funny comment for this call within TypoScriptParser.
Reading the code, there seems to be no part that works with
references on this variable in setVal().

The patch now removes this odd construct. In the
unlikely case some issue still pops up later, we would
at least have a clear way to reproduce then ...

Change-Id: I70f5f8915386a7a4b5038d66611b4ec359f5c1fa
Resolves: #76323
Releases: master
Reviewed-on: https://review.typo3.org/48327
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] IconViewHelper should generate absolute URLs 21/48321/4
Benni Mack [Fri, 27 May 2016 11:16:09 +0000 (13:16 +0200)]
[TASK] IconViewHelper should generate absolute URLs

This change allows the IconViewHelper in the reports module
to be used not just from typo3/ (e.g. if a person puts typo3/index.php
to a different place or wants to show the reports in the install tool).

Resolves: #76322
Releases: master
Change-Id: I7067654b3fff5ac75fb9883b708ddb28a9ddc7d1
Reviewed-on: https://review.typo3.org/48321
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Doctrine: Use compatible charset name for database connection 10/48310/3
Morton Jonuschat [Fri, 27 May 2016 08:23:35 +0000 (10:23 +0200)]
[BUGFIX] Doctrine: Use compatible charset name for database connection

Use the charset name 'utf8' instead of 'utf-8' for MySQL connections as
some MySQL server versions silently ignore the connection charset name
'utf-8' and work with the global default connection charset instead.
Using 'utf8' as charset name doesn't exhibit this behavior.

Also changes the silent upgrade wizard to only set the default driver
and connection charset if no value has been configured, this avoids
silently changing non-default values for these options.

Change-Id: I94e1e7c557aff890cec357ef9ee069ae9aa052c6
Resolves: #76265
Releases: master
Reviewed-on: https://review.typo3.org/48310
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Unit test to cover stdWrap_char 07/48307/4
Elmar Hinz [Fri, 27 May 2016 07:22:04 +0000 (09:22 +0200)]
[TASK] Unit test to cover stdWrap_char

Releases: master
Resolves: #76316
Change-Id: I40c05c0d6a342b3d3c19dc164ae7716076aa3df2
Reviewed-on: https://review.typo3.org/48307
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Unit test to cover stdWrap_brTag 93/48293/4
Elmar Hinz [Thu, 26 May 2016 10:05:30 +0000 (12:05 +0200)]
[TASK] Unit test to cover stdWrap_brTag

Resolves: #76307
Releases: master
Change-Id: Ie75ab139102cedb6e5bc01ffb59bbf51c900dded
Reviewed-on: https://review.typo3.org/48293
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Unit test to cover stdWrap_rawUrlEncode 84/48284/4
Elmar Hinz [Wed, 25 May 2016 07:51:32 +0000 (09:51 +0200)]
[TASK] Unit test to cover stdWrap_rawUrlEncode

Resolves: #76294
Releases: master
Change-Id: Ifca415dd965473cde9cec29ca21a476491540845
Reviewed-on: https://review.typo3.org/48284
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Fix broken disable overlay in FormEngine 10/48110/3
Frank Naegler [Fri, 13 May 2016 08:24:55 +0000 (10:24 +0200)]
[BUGFIX] Fix broken disable overlay in FormEngine

Resolves: #75397
Releases: master, 7.6
Change-Id: I7cb4f04e38e3d9f755aaf92012eb56d71a1ad6f7
Reviewed-on: https://review.typo3.org/48110
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Re-enables fileDenyPattern check for admin users 10/32610/12
Torben Hansen [Thu, 26 May 2016 19:20:23 +0000 (21:20 +0200)]
[BUGFIX] Re-enables fileDenyPattern check for admin users

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Resolves: #60173
Releases: master, 7.6, 6.2
Change-Id: I3b819e70cf2218a4580203ac7b7a6b0c3c5087ab
Reviewed-on: https://review.typo3.org/32610
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[TASK] unserialize() without objects for extConf 14/48314/4
Christian Kuhn [Fri, 27 May 2016 10:22:18 +0000 (12:22 +0200)]
[TASK] unserialize() without objects for extConf

To mitigate potential "unsecure unserialize()" issues, the new PHP7
feature to allow only specific classes or to totally deny object
creation is rolled out throughout the core in v8.

Since a lot of places use unserialize() and some are critical or
hard to understand, this is done with a series of patches for
single areas.

This patch denies object creation at all places where
$GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['anExtension'] is
unserialized() - the extension manager and ext_conf_template.txt
handling never handles objects at this place, so it should be
safe to deny objects at all places.

Change-Id: Ie96e6fb6837418fd765f883b216b7a9c5af5795d
Resolves: #76320
Releases: master
Reviewed-on: https://review.typo3.org/48314
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Deprecate single slash comments in TypoScript 51/48051/17
Elmar Hinz [Mon, 9 May 2016 19:59:37 +0000 (21:59 +0200)]
[TASK] Deprecate single slash comments in TypoScript

Double slash one-line comments are standard in many languages.
Make them standard in TypoScript, too.

Deprecated:
  / Line comment headed by single slash

Resolves: #76104
Releases: master
Change-Id: Id78391f973cdf8147bf91b269996f31d475de717
Reviewed-on: https://review.typo3.org/48051
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Remove second parameter of getLL part 1/3 20/48320/5
Wouter Wolters [Fri, 27 May 2016 11:04:16 +0000 (13:04 +0200)]
[TASK] Remove second parameter of getLL part 1/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: Iaccd3e31b235632fac9022e9120a35426bd5d99b
Reviewed-on: https://review.typo3.org/48320
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Deprecate MenuViewHelperTrait 11/48111/7
Frank Naegler [Fri, 27 May 2016 10:53:10 +0000 (12:53 +0200)]
[TASK] Deprecate MenuViewHelperTrait

The MenuViewHelperTrait has been marked as deprecated.
All methods of the Trait have been implemented in a new
AbstractMenuViewHelper class.

Resolves: #75209
Releases: master
Change-Id: Ie8cad645c80c3cb7814dd2b69f22feb729334779
Reviewed-on: https://review.typo3.org/48111
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Optimise comment of $sortedConf in the stdWrap function 32/48132/6
Elmar Hinz [Sat, 14 May 2016 09:10:38 +0000 (11:10 +0200)]
[TASK] Optimise comment of $sortedConf in the stdWrap function

Explain the creation and name of the variable in concise words.

Resolves: #76195
Related: #76194
Releases: master
Change-Id: Ifff61c38dbb4ea07f79cb42cfe7f6aca41e5fbe1
Reviewed-on: https://review.typo3.org/48132
Reviewed-by: Olaf Schmidt-Wischhöfer <osw@eadi.org>
Tested-by: Olaf Schmidt-Wischhöfer <osw@eadi.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration 18/48318/2
Andreas Fernandez [Fri, 27 May 2016 10:49:41 +0000 (12:49 +0200)]
[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration

Use `$table` for logging instead of the hardcoded `pages` table.

Resolves: #74125
Releases: master, 7.6
Change-Id: I13b4306bdc54cf461d23c401d54c04983059df46
Reviewed-on: https://review.typo3.org/48318
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Check if `$rows` is an array before iteration 11/48311/6
Andreas Fernandez [Fri, 27 May 2016 08:59:26 +0000 (10:59 +0200)]
[BUGFIX] Check if `$rows` is an array before iteration

In case `$rows` in the method `DataHandler::copySpecificPage()` is null,
the foreach loop will throw an error.
`$rows` may become null if an extension brings TCA but the table does not
have `uid` field, for example.

It's now checked whether the result being iterated is an array, otherwise
an error is logged.

Resolves: #74125
Releases: master, 7.6
Change-Id: I20cb101155632309b9e08600fcd33e655c1c9d2f
Reviewed-on: https://review.typo3.org/48311
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][TASK] Deprecate removeBadHTML 13/48313/3
Frank Naegler [Fri, 27 May 2016 09:58:32 +0000 (11:58 +0200)]
[FOLLOWUP][TASK] Deprecate removeBadHTML

Mark stdWrap_removeBadHTML as deprecated in doc comment.

Resolves: #15415
Releases: master
Change-Id: I4534a8b93b731f8e736752e712c0c13293b0b05d
Reviewed-on: https://review.typo3.org/48313
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Deprecate removeBadHTML 01/48301/4
Wouter Wolters [Thu, 26 May 2016 18:50:36 +0000 (20:50 +0200)]
[TASK] Deprecate removeBadHTML

Resolves: #15415
Releases: master
Change-Id: Iac92d6d36e2a84b069fa7c4a17d2dc567d952309
Reviewed-on: https://review.typo3.org/48301
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Update the comment of stdWrap_char to include ASCII limitation 06/48306/3
Elmar Hinz [Fri, 27 May 2016 07:03:53 +0000 (09:03 +0200)]
[TASK] Update the comment of stdWrap_char to include ASCII limitation

The PHP char() function only works reliably with ASCII codes
independent of the actual char set.

See http://php.net/manual/en/function.chr.php

Releases: master
Resolves: #76315
Change-Id: Ia87b95239fc4678f297571704f031003f84a5759
Reviewed-on: https://review.typo3.org/48306
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager 20/48220/4
Morton Jonuschat [Fri, 20 May 2016 04:50:26 +0000 (06:50 +0200)]
[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager

Instead of passing the simple value "1" to QueryGenerator->getTreeList()
use a page permission clause created using $BE_USER->getPagePermsClause()
when determining the recursive storage pids. Passing the unprocessed value
"1" causes invalid SQL statements and does not perform any access checks.

Releases: master, 7.6
Resolves: #75912
Change-Id: I6edadd627c0a9c01a78c3cb55805455fed710d14
Reviewed-on: https://review.typo3.org/48220
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a... 76/48276/7
Andreas Fernandez [Tue, 24 May 2016 13:11:57 +0000 (15:11 +0200)]
[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a new tab

It's possible to open some backend modules (e.g. RTE or
EditDocumentController) in a new tab. However, the configuration for
popups is missing in such case, causing e.g. opening the "Insert image"
wizard of RTE is not possible anymore.

Place configuration inline in TYPO3.settings to not have this problem of
missing configuration.

Resolves: #76285
Releases: master
Change-Id: I1405dd90e4e00fc709d504af2ed0a936a6374fce
Reviewed-on: https://review.typo3.org/48276
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Deprecate RemoveXSS 02/48102/16
Georg Ringer [Thu, 12 May 2016 13:04:36 +0000 (15:04 +0200)]
[TASK] Deprecate RemoveXSS

Due to the wrong approach of RemoveXSS it is not 100%
safe and does not keep its promise.

Resolves: #76164
Releases: master
Change-Id: I8aa0a05f7866041f392441fa852bae5a7c202142
Reviewed-on: https://review.typo3.org/48102
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab 90/48290/2
Markus Klein [Wed, 25 May 2016 21:51:23 +0000 (23:51 +0200)]
[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab

Resolves: #76303
Releases: master, 7.6
Change-Id: Ia03f62ccc1c7c989a4284de36ac814758c63d288
Reviewed-on: https://review.typo3.org/48290
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Simplify and harden pagination Fluid JS usage 91/48291/5
Helmut Hummel [Wed, 25 May 2016 22:34:01 +0000 (00:34 +0200)]
[TASK] Simplify and harden pagination Fluid JS usage

Fluid variables must never be used in JavaScript context.
Instead they should be put into data attributes, which can be
accessed from JavaScript easily.

Resolves: #76304
Releases: master
Change-Id: I16c0d6b265ad446d73cbe285be7653d1a8ebcfd2
Reviewed-on: https://review.typo3.org/48291
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Output HTML code only if requested 87/48287/2
Helmut Hummel [Wed, 25 May 2016 16:28:14 +0000 (18:28 +0200)]
[BUGFIX] Output HTML code only if requested

When adding visibility information in DebuggerUtility
it was not respected that this utility can also be used to output in cli.

Add the missing condition and output HTML only if requested.

Additionally when the property has nested objects,
the visibility info must be right after the property not after
every nested object.

Also prettify object type output on command line on the go.

Resolves: #76301
Related: #76008
Releases: master
Change-Id: If82192bf9d1fb0ca1dc843242167d01b1a915f6e
Reviewed-on: https://review.typo3.org/48287
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Improve rendering of file paths in reports 82/48282/3
Georg Ringer [Tue, 24 May 2016 21:22:32 +0000 (23:22 +0200)]
[TASK] Improve rendering of file paths in reports

By using the <code>-tag, the output of paths is improved:

- XCLASS usage
- Path to ENABLE_INSTALL_TOOL
- Path to deprecation log

Resolves: #76288
Releases: master, 7.6
Change-Id: I591009cd52ba1dec6d25ff135e76b7b536b84193
Reviewed-on: https://review.typo3.org/48282
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Don't HSC URI in JS in BE paginate VH 83/48283/3
Jigal van Hemert [Tue, 24 May 2016 21:41:05 +0000 (23:41 +0200)]
[BUGFIX] Don't HSC URI in JS in BE paginate VH

The URI is HSC'd by default. Using the output unformatted produces
a correct URI for use inside JS.

Resolves: #76289
Releases: master
Change-Id: Iec7b9aaa0a26ec9acfe6ba49924373965a989a2f
Reviewed-on: https://review.typo3.org/48283
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Do not escape system information label with HTML 86/48286/2
Markus Klein [Wed, 25 May 2016 12:07:17 +0000 (14:07 +0200)]
[BUGFIX] Do not escape system information label with HTML

Resolves: #76296
Releases: master
Change-Id: I039e031ff6f46c94d474c35c43de372cfc5b0fc2
Reviewed-on: https://review.typo3.org/48286
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Suggest wizard inserts correct items again 77/48277/2
Markus Klein [Tue, 24 May 2016 13:41:03 +0000 (15:41 +0200)]
[BUGFIX] Suggest wizard inserts correct items again

The patch for #70463 introduced a regression which caused
added elements to include HTML markup.

Resolves: #76286
Releases: master, 7.6
Change-Id: I596602b03fd65f2e8d95171c2f2f79ff57006f14
Reviewed-on: https://review.typo3.org/48277
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add a few additional tests for PageRepository 78/48078/2
Helmut Hummel [Wed, 11 May 2016 12:50:55 +0000 (14:50 +0200)]
[TASK] Add a few additional tests for PageRepository

Resolves: #76150
Releases: master
Change-Id: Ia51ec33ba4aacabc884292d4a9508ce0d2c4cd9d
Reviewed-on: https://review.typo3.org/48078
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove reintroduced obsolete LocalConfiguration settings 38/48238/2
Wouter Wolters [Sun, 22 May 2016 12:43:46 +0000 (14:43 +0200)]
[TASK] Remove reintroduced obsolete LocalConfiguration settings

With the introduction of Doctrine DBAL the obsolete settings of
all upgrade wizards related to TYPO3 CMS 7 are added again.

Remove them now again.

Resolves: #76258
Related: #75454
Releases: master
Change-Id: Ib86591525724b2fd189038a04dfa645815f4fe55
Reviewed-on: https://review.typo3.org/48238
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Adds missing tablename sys_language in fetchOriginLanguage function 46/48046/3
Marvin Dettinger [Mon, 9 May 2016 15:38:10 +0000 (17:38 +0200)]
[BUGFIX] Adds missing tablename sys_language in fetchOriginLanguage function

Resolves: #76098
Releases: master, 7.6
Change-Id: I4ceb644328671cd3355340d6b6991d60e88b265a
Reviewed-on: https://review.typo3.org/48046
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christoph Kratz <ckr@rtp.ch>
Tested-by: Christoph Kratz <ckr@rtp.ch>
Reviewed-by: Marvin Dettinger <mde@rtp.ch>
Tested-by: Marvin Dettinger <mde@rtp.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Allow non critical request arguments with @ 65/48265/5
Helmut Hummel [Tue, 24 May 2016 09:08:23 +0000 (11:08 +0200)]
[BUGFIX] Allow non critical request arguments with @

Resolves: #76278
Releases: master, 8.1, 7.6, 6.2
Change-Id: Iedb71737ab3b69f2873292ea1cab165e0ec21cec
Reviewed-on: https://review.typo3.org/48265
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[SECURITY] Validate complete referring request 58/48258/2
Helmut Hummel [Tue, 24 May 2016 07:44:23 +0000 (09:44 +0200)]
[SECURITY] Validate complete referring request

Instead of only checking for valid request arguments by using a hmac,
we now check the complete request including action, controller and vendor
to avoid spoofing these arguments and bypassing other security checks
during forwarding to the referring action.

Additionally, ReferringRequest is now separate from regular Request.
The meaning of properties starting with "@" is only valid for
processing a referring request. To avoid mixed concerns in using
the same Request implementation for regular requests and referring
requests, they are separated now.

Resolves: #76231
Resolves: #76256
Releases: master, 7.6, 6.2
Security-Commit: 3562e177f1720e62cab84232dcc67c580a3cc3db
Security-Bulletin: TYPO3-CORE-SA-2016-013
Change-Id: Ic94e11341df98c1326dc73c92a5c9e061a64cc9e
Reviewed-on: https://review.typo3.org/48258
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Use `find()` to get option tags from select 44/48044/4
Andreas Fernandez [Mon, 9 May 2016 15:04:25 +0000 (17:04 +0200)]
[BUGFIX] Use `find()` to get option tags from select

Using `children()` to get the option tags from the select fields
will fail if the select field contains `optgroup` tags (e.g. rendered
by a hook).

This patch replaces `children()` with `find()` to cover this
edge case.

Resolves: #76097
Releases: master, 7.6
Change-Id: Ib80f422d465d9e48232b1820e524a01a97eb94e6
Reviewed-on: https://review.typo3.org/48044
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] EM: Decode HTML in conflict message 02/48202/4
Andreas Fernandez [Tue, 17 May 2016 14:55:03 +0000 (16:55 +0200)]
[BUGFIX] EM: Decode HTML in conflict message

The message in the extension manager that notices about installing a
conflicting extension contains HTML. As all output is encoded by default,
the HTML is obviously also encoded.
Wrap the text in `f:format.raw` to decode the HTML and get a functional
list again.

Resolves: #76214
Releases: master
Change-Id: I0b31b907d95679b528a2dc8422cd41c497fe8ec3
Reviewed-on: https://review.typo3.org/48202
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fixes rendering of page content titles 06/48106/3
Tomita Militaru [Thu, 12 May 2016 15:41:54 +0000 (17:41 +0200)]
[BUGFIX] Fixes rendering of page content titles

Removes the htmlspecialchars from the rendering of
page content titles / tooltips.

Resolves: #76149
Releases: master, 7.6
Change-Id: Ia5ad3df56101fe3962e4a5814df53dabdf5a4bbc
Reviewed-on: https://review.typo3.org/48106
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Make driver registry TCA change cacheable 47/48047/4
Helmut Hummel [Mon, 9 May 2016 17:54:04 +0000 (19:54 +0200)]
[TASK] Make driver registry TCA change cacheable

Instead of calling the driver registry on every request,
we can cache the TCA addition, by putting the call into overrides.

Resolves: #76102
Releases: 7.6, master
Change-Id: I8cfc72f0e7dbb133eecc754fd3cb774637a0d4bf
Reviewed-on: https://review.typo3.org/48047
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Use push parser instead of pull parser on fetching extension list 89/48189/2
Oliver Hader [Tue, 17 May 2016 10:15:49 +0000 (12:15 +0200)]
[BUGFIX] Use push parser instead of pull parser on fetching extension list

Issue #75022 reported problems with libxml and operations on compressed
file streams. The work around for that patch showed drawbacks with memory
consumption. That's why the push parser is used as default now.

Resolves: #75721
Related: #75022
Releases: master, 7.6, 6.2
Change-Id: I6daadd4b375634cf45272bb249e4bfa083f03646
Reviewed-on: https://review.typo3.org/48189
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Correctly treat uploaded file when replacing a file 81/48181/2
Markus Klein [Tue, 17 May 2016 08:38:28 +0000 (10:38 +0200)]
[BUGFIX] Correctly treat uploaded file when replacing a file

Uploaded files must be moved with the specific PHP function,
otherwise permissions may be wrong.

Resolves: #76205
Releases: master, 7.6
Change-Id: Ic96e6b8927ed5d21131952004805fa72fb8b6857
Reviewed-on: https://review.typo3.org/48181
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years agoRevert "[BUGFIX] Load XML files of Extension Manager properly" 82/48182/2
Oliver Hader [Tue, 17 May 2016 09:49:24 +0000 (11:49 +0200)]
Revert "[BUGFIX] Load XML files of Extension Manager properly"

This reverts commit 3d449f91fc7402f5db0637c89908383c42989774.

This change did not completely solve the libxml issue and introduced
additional trouble on memory consumption with the current pull parsers.

Related: #75022
Releases: master, 7.6, 6.2
Change-Id: I42454d61ab444860fc53b29715df69e65a2f0475
Reviewed-on: https://review.typo3.org/48182
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Make "$hookObject must implement interface FooInterface" more verbose 15/48115/3
Andreas Fernandez [Fri, 13 May 2016 14:59:05 +0000 (16:59 +0200)]
[TASK] Make "$hookObject must implement interface FooInterface" more verbose

The exceptions show now the affected class that does not
implement the required interface. Where possible, the FQCN
in the exception message string was replaced with the shorter
::class syntax.

Resolves: #76187
Releases: master, 7.6
Change-Id: Id2c290a0cf29bdec5da504a8959996bb747f1c27
Reviewed-on: https://review.typo3.org/48115
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Deprecated methods in unit tests 91/48091/4
Adrian Mot [Thu, 12 May 2016 08:32:40 +0000 (11:32 +0300)]
[TASK] Deprecated methods in unit tests

- Use expectedException() and expectedExceptionCode() instead of
  deprecated setExpectedException()
- Fix a couple of incomplete tests in core/Http section, add some
  and slightly refactor a bit

Resolves: #76159
Releases: master
Change-Id: I3333f94494ce76601a61e4b5286cfef982867f8f
Reviewed-on: https://review.typo3.org/48091
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Adrian Mot <adrian.mot@gmail.com>
Tested-by: Adrian Mot <adrian.mot@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Disable ac tests in travis 08/48108/2
Wouter Wolters [Thu, 12 May 2016 17:48:30 +0000 (19:48 +0200)]
[TASK] Disable ac tests in travis

Resolves: #76173
Releases: master
Change-Id: I2a273c0e3ab4d4fad7db11ebad84fe00ca4493a1
Reviewed-on: https://review.typo3.org/48108
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Add basic test for category 96/48096/4
Adam Marcinkowski [Thu, 12 May 2016 09:44:33 +0000 (11:44 +0200)]
[TASK] Add basic test for category

* Add fixture with categories
* Add test to check if categories are visible in list module
* Add test to check if category is editable

Releases: master
Resolves: #76162
Change-Id: Ia518e059d23238f52f79224acffccd21bf8aaa88
Reviewed-on: https://review.typo3.org/48096
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FEATURE] Adds support for ogg, flac and opus files 86/48086/3
Tomita Militaru [Wed, 11 May 2016 20:02:23 +0000 (22:02 +0200)]
[FEATURE] Adds support for ogg, flac and opus files

Adds support in the media field for opensource formats:
* ogg
* flac
* opus

Resolves: #76072
Releases: master
Change-Id: Ie17e1572a5eeb8d4b8954158e4a62e0b54ec6e86
Reviewed-on: https://review.typo3.org/48086
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[FOLLOWUP][TASK] Hide selected items in multipleSideBySide 62/48062/5
Andreas Fernandez [Tue, 10 May 2016 11:53:18 +0000 (13:53 +0200)]
[FOLLOWUP][TASK] Hide selected items in multipleSideBySide

The original patch introduced some regressions which are fixed now:

- Deletion of multiple items works correctly now
- Inserting items by the Element Browser does not throw an error anymore

Resolves: #76071
Releases: master, 7.6
Change-Id: Ie16a1d404c2f12e6c952dc5022caff08ec6af171
Reviewed-on: https://review.typo3.org/48062
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Tomita Militaru <militarutomita@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Added compatibility7 conflict specification in conf file 52/48052/8
Adrian Mot [Mon, 9 May 2016 15:51:58 +0000 (18:51 +0300)]
[TASK] Added compatibility7 conflict specification in conf file

This patch adds a constrain to compatibility7 extension in order to
avoid conflicts with compatibility6

Resolves: #76099
Releases: master
Change-Id: Icaf2781b31581380df97a856129a9e28dbd77bdb
Reviewed-on: https://review.typo3.org/48052
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Adrian Mot <adrian.mot@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Tweak of the Formhandler acceptance tests 68/48068/8
Nikola Stojiljkovic [Tue, 10 May 2016 14:36:43 +0000 (17:36 +0300)]
[TASK] Tweak of the Formhandler acceptance tests

Includes:
* Added testing of persistence
* Added tests for datetime fields
* Prevent random timeouts from affecting the test results
* Added displaying of modal with error message instead of an alert
  on trying to save a form with validation errors

The tests are stable using Selenium with Firefox. Using phantomjs gives
erratic results due to "QIODevice::write (QTcpSocket): device not open"
bug which randomly pops up.

Resolves: #76122
Releases: master
Change-Id: Ia0c06fc4dbd83e2373d33bb07c48559894fc3ec5
Reviewed-on: https://review.typo3.org/48068
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][BUGFIX] Prevent validation from altering the field value 84/48084/2
Nicole Cordes [Wed, 11 May 2016 18:46:33 +0000 (20:46 +0200)]
[FOLLOWUP][BUGFIX] Prevent validation from altering the field value

This follow up ensures the initialization of the value.

Resolves: #76124
Releases: master
Change-Id: Ie9981971e97d740df1df8545eb2bbd2dae0b465e
Reviewed-on: https://review.typo3.org/48084
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tomita Militaru <militarutomita@gmail.com>
Reviewed-by: Nikola Stojiljković <nikola.stojiljkovic@essentialdots.com>
Tested-by: Nikola Stojiljković <nikola.stojiljkovic@essentialdots.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Removes extra space from important 00/48100/2
Tomita Militaru [Thu, 12 May 2016 12:40:36 +0000 (14:40 +0200)]
[BUGFIX] Removes extra space from important

Removes extra space from between ! and important
override from rtehtmlarea CSS.

Resolves: #75958
Releases: master
Change-Id: If19ff8cc80c11fe650c12e914a07d5b6938a8ab8
Reviewed-on: https://review.typo3.org/48100
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Corrects link to Extbase documentation 05/48105/2
Tomita Militaru [Thu, 12 May 2016 13:15:28 +0000 (15:15 +0200)]
[BUGFIX] Corrects link to Extbase documentation

Replaces old TYPO3 Forge link regarding skip default
arguments feature in Extbase to TYPO3 Wiki.

Resolves: #75909
Releases: master
Change-Id: If4d6cce26c22d296af3404c283a39b6851314394
Reviewed-on: https://review.typo3.org/48105
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FEATURE] Adds property visibility to DebuggerUtility::var_dump 87/48087/4
Tomita Militaru [Wed, 11 May 2016 20:25:18 +0000 (22:25 +0200)]
[FEATURE] Adds property visibility to DebuggerUtility::var_dump

Adds property visibility information to DebuggerUtility::var_dump
after each property in the dump.

Resolves: #76008
Releases: master
Change-Id: I196bfd45dbd70a52fa4cf29ec1ed24bbcdef2aee
Reviewed-on: https://review.typo3.org/48087
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][TASK] Make the update button in extension manager clickable 99/48099/2
Nicole Cordes [Thu, 12 May 2016 11:31:05 +0000 (13:31 +0200)]
[FOLLOWUP][TASK] Make the update button in extension manager clickable

Convert spaces to tabs.

Resolves: #76136
Releases: master
Change-Id: Ic17bfd0d54b38c1a80ee51d065ce8e3fe4d19efa
Reviewed-on: https://review.typo3.org/48099
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[TASK] Make the whole update button in extension manager clickable 92/48092/2
Gianluigi Martino [Thu, 12 May 2016 08:28:48 +0000 (10:28 +0200)]
[TASK] Make the whole update button in extension manager clickable

The click area of the update button in extension manager was to small.
The click handler is now assigned to the whole button.

Change-Id: I8b2103dcbde5dcc37a7968780719abca384528a1
Resolves: #76136
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48092
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Prevent escaping the output of RenderChildrenViewHelper 59/48059/3
Nicole Cordes [Tue, 10 May 2016 09:22:32 +0000 (11:22 +0200)]
[BUGFIX] Prevent escaping the output of RenderChildrenViewHelper

This patch prevents escaping the output of the RenderChildrenViewHelper.

Resolves: #76112
Releases: master
Change-Id: I6cbb95c99b7bfc9d14b563edae33129080fc32ec
Reviewed-on: https://review.typo3.org/48059
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Raise hostname length to 255 characters 70/48070/3
Anja Leichsenring [Wed, 11 May 2016 08:11:08 +0000 (10:11 +0200)]
[BUGFIX] Raise hostname length to 255 characters

When installing TYPO3 in a cloud environment, the 50 character
limit is not high enough. Therefor it is raised to 255 chars,
what most protocols define as the max limit.

Releases: master, 7.6
Resolves: #76132
Change-Id: I59383911e791b635fc80cb6b6b3c76d4433c8e0d
Reviewed-on: https://review.typo3.org/48070
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Tomita Militaru <militarutomita@gmail.com>
Reviewed-by: Adrian Mot <adrian.mot@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Mark render function as deprecated 73/48073/5
Marcin Krzyżanowski [Wed, 11 May 2016 09:13:35 +0000 (12:13 +0300)]
[TASK] Mark render function as deprecated

Render function from SoloFieldContainer class has been
marked as deprecated now. It is not used in core anymore.

Resolves: #76101
Releases: master
Change-Id: I276f6b047b6104863f7f7d6c31a713c4df545fbf
Reviewed-on: https://review.typo3.org/48073
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Raise styleguide to 8.0.2 77/48077/2
Christian Kuhn [Wed, 11 May 2016 12:28:38 +0000 (14:28 +0200)]
[TASK] Raise styleguide to 8.0.2

8.0.1 to 8.0.2 brings some new fields, a list of cleanups
and fixes.

Change-Id: Iff59861d6db1f2a67f48545da69a6abb02519e79
Resolves: #76148
Releases: master
Reviewed-on: https://review.typo3.org/48077
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Update Fluid library to version 1.0.7 69/48069/3
Nicole Cordes [Tue, 10 May 2016 16:58:04 +0000 (18:58 +0200)]
[TASK] Update Fluid library to version 1.0.7

Fixes the following issues:

* https://github.com/TYPO3Fluid/Fluid/pull/97
  [TASK] Remove references to non existing convertArgumentValue
* https://github.com/TYPO3Fluid/Fluid/pull/98
  Revert "[BUGFIX] Avoid double HTML encoding on chained view helpers"
* https://github.com/TYPO3Fluid/Fluid/pull/101
  [TASK] Simplifiy encoding behavior
* https://github.com/TYPO3Fluid/Fluid/pull/102
  [BUGFIX] Fix interceptor call for self-closing view helpers

Resolves: #76128
Releases: master
Change-Id: I1ac5fd3eaf79df18d22f6667108e2a2574ed79c2
Reviewed-on: https://review.typo3.org/48069
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Paul Ilea <paul@target-e.com>
Tested-by: Paul Ilea <paul@target-e.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Deprecate the $icon setter/getter in the Extbase Category model 34/48034/5
Wouter Wolters [Sat, 7 May 2016 12:04:57 +0000 (14:04 +0200)]
[TASK] Deprecate the $icon setter/getter in the Extbase Category model

Resolves: #75904
Releases: master
Change-Id: Ifa27348ae8204af7cac777756282016a88b0be6b
Reviewed-on: https://review.typo3.org/48034
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Paul Ilea <paul@target-e.com>
Reviewed-by: Marcin Krzyżanowski <m.krzyzanowski@macopedia.pl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Cleanup translate view helper calls in install tool module 50/48050/3
Helmut Hummel [Mon, 9 May 2016 19:42:25 +0000 (21:42 +0200)]
[TASK] Cleanup translate view helper calls in install tool module

Use inline syntax for view helpers and correctly use raw view helper
for output, since these labels contain HTML.

Also fix the html entity for the button label.

Resolves: #76103
Releases: master
Change-Id: Iabcb1296dd05d33b04d7f343f0b60702debd56c8
Reviewed-on: https://review.typo3.org/48050
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Marcin Krzyżanowski <m.krzyzanowski@macopedia.pl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Prevent validation from altering the field value 67/48067/4
Nikola Stojiljkovic [Tue, 10 May 2016 14:27:26 +0000 (17:27 +0300)]
[BUGFIX] Prevent validation from altering the field value

Resolves: #76124
Releases: master
Change-Id: Ib53e24c17c0f662db06f4db039c39c0e9eeb4b30
Reviewed-on: https://review.typo3.org/48067
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Filter out space char on client-side from alpha/num/alphanum/alphanum_x... 66/48066/5
Nikola Stojiljkovic [Tue, 10 May 2016 14:20:44 +0000 (17:20 +0300)]
[BUGFIX] Filter out space char on client-side from alpha/num/alphanum/alphanum_x fields

Resolves: #76125
Releases: master
Change-Id: I9d542a7a1a380a32f39f1c61f7cb4cf2d4b316b5
Reviewed-on: https://review.typo3.org/48066
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Show new content button for editors in page module again 57/48057/7
Gianluigi Martino [Tue, 10 May 2016 08:48:26 +0000 (10:48 +0200)]
[BUGFIX] Show new content button for editors in page module again

Editors (group) doesn't see the new content button without page edit
permission in page module. with this bugfix editors can insert new content
again.

Change-Id: Ie8957b3386dfca8a91b7718bedba16af7559b373
Resolves: #76036
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48057
Reviewed-by: Adrian Mot <adrian.mot@gmail.com>
Tested-by: Adrian Mot <adrian.mot@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Prevent output escaping in AvatarViewHelper 58/48058/2
Nicole Cordes [Tue, 10 May 2016 09:17:39 +0000 (11:17 +0200)]
[BUGFIX] Prevent output escaping in AvatarViewHelper

As the AvatarViewHelper returns HTML, the output should not be escaped.

Resolves: #76111
Releases: master
Change-Id: I4853de751c23dd726c30c11730b4c365625be5d0
Reviewed-on: https://review.typo3.org/48058
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Adrian Mot <adrian.mot@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[TASK] Hide selected items in multipleSideBySide 31/48031/9
Andreas Fernandez [Sat, 7 May 2016 08:30:06 +0000 (10:30 +0200)]
[TASK] Hide selected items in multipleSideBySide

If a multipleSideBySide form element is not allowed to add the same
value multiple times, its selected values are hidden now and it's not
possible to add them again unless the values are removed from the
selection.

Resolves: #76071
Releases: master, 7.6
Change-Id: I99d6c609ca081f4b8cb6f8ad07f74385a23b7a5c
Reviewed-on: https://review.typo3.org/48031
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Don't disable redirect after logout with showLogoutFormAfterLogin=1 25/48025/2
Daniel Goerz [Fri, 6 May 2016 13:44:14 +0000 (15:44 +0200)]
[BUGFIX] Don't disable redirect after logout with showLogoutFormAfterLogin=1

This patch fixes a regression where showLogoutFormAfterLogin was added
as a condition to disable redirects in fe_login at all when it should
only disable redirects after login.

Change-Id: Ide5c17f202618c9c0696bc777473a7be1b089276
Resolves: #73144
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48025
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Allow opening custom doktype in the frontend 36/48036/2
Wouter Wolters [Sat, 7 May 2016 15:20:43 +0000 (17:20 +0200)]
[BUGFIX] Allow opening custom doktype in the frontend

A few doktype are checked now to open the frontend page.
Others will redirect to the homepage. Allow custom doktypes now
too with opening the frontend page.

Resolves: #75499
Resolves: #70094
Releases: master,7.6
Change-Id: Iaffe03dfff3f1181f26964f26611d80e71406b5c
Reviewed-on: https://review.typo3.org/48036
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Marcin Krzyżanowski
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Match SQL field lengths in TCA 33/48033/3
Ludwig Rafelsberger [Sat, 7 May 2016 11:16:20 +0000 (13:16 +0200)]
[TASK] Match SQL field lengths in TCA

This is a follow-up to ee448440bc, matching the TCA max field-length to
the already increased SQL lenghtes.

Resolves: #76075
Releases: master
Change-Id: Id65f9a87c73d914e221bebfb77d6595c6dd84d48
Reviewed-on: https://review.typo3.org/48033
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Prevent temp file generation in Unit Test 27/48027/2
Nicole Cordes [Fri, 6 May 2016 17:10:55 +0000 (19:10 +0200)]
[BUGFIX] Prevent temp file generation in Unit Test

Running Unit Tests creates file /tmp/typo3.log. On Windows systems
this file is stored on the root of the drive. This patch uses the
defined temp folder for storing the file.

Resolves: #76070
Releases: master, 7.6, 6.2
Change-Id: Id77684e41020feb1a1ecff5051a80d2919250bf8
Reviewed-on: https://review.typo3.org/48027
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
3 years ago[TASK] Pass guzzle exception with report in case getUrl fails 26/48026/3
Markus Klein [Fri, 6 May 2016 14:21:15 +0000 (16:21 +0200)]
[TASK] Pass guzzle exception with report in case getUrl fails

GeneralUtility::getUrl() may fail. Guzzle provides detailed information
in the exception it throws upon error.
Allow consumers of getUrl() to make more detailed failure analysis
by passing on the raw exception with the report.

Resolves: #76068
Releases: master
Change-Id: I63393a224695b5fd942da436672b3f75e1b1fc34
Reviewed-on: https://review.typo3.org/48026
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Make .htaccess Apache 2.4 suitable 23/48023/4
Marc von Schalscha-Ehrenfeld [Fri, 6 May 2016 11:25:22 +0000 (13:25 +0200)]
[TASK] Make .htaccess Apache 2.4 suitable

This patch makes EXT:documentation/Resources/Private/.htaccess and
EXT:extbase/Resources/Private/.htaccess Apache 2.4 suitable

Resolves: #76066
Resolves: #76064
Releases: master, 7.6, 6.2
Change-Id: I91c6e683eeb1bc92e1192d2b3800d2dcb8a9d4b9
Reviewed-on: https://review.typo3.org/48023
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Fix navbar toggle in Install Tool 22/48022/3
Thorsten Griebenow [Fri, 6 May 2016 10:50:31 +0000 (12:50 +0200)]
[BUGFIX] Fix navbar toggle in Install Tool

Releases: master
Resolves: #76065
Change-Id: Icd40dd50898d96fbebd2560bfd5575baca09ffd9
Reviewed-on: https://review.typo3.org/48022
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Set correct ordering in EM "A/D" 20/48020/5
Markus Sommer [Fri, 6 May 2016 08:14:36 +0000 (10:14 +0200)]
[BUGFIX] Set correct ordering in EM "A/D"

Resolves: #72211
Releases: master, 7.6
Change-Id: I3c7539743b534c0584e7f6685d1a96066063ca51
Reviewed-on: https://review.typo3.org/48020
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[!!!][TASK] Drop RTE config skipAlign and skipClass 28/47728/5
Benni Mack [Sat, 16 Apr 2016 10:36:18 +0000 (12:36 +0200)]
[!!!][TASK] Drop RTE config skipAlign and skipClass

The two options to define whether to not allow align or class
attributes on <p> tags when converting from RTE to the DB
are dropped in favor of using keepPDIVattribs and adding them there
by default.

Resolves: #75710
Releases: master
Change-Id: Ie981a3f15f02f81c9721e2ee9421e183319f5b90
Reviewed-on: https://review.typo3.org/47728
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Only focus RTE if current focus is on body tag 28/47528/8
Andreas Fernandez [Thu, 7 Apr 2016 08:09:44 +0000 (10:09 +0200)]
[BUGFIX] Only focus RTE if current focus is on body tag

Focus the RTE (or its textarea fallback) only if the current focus
is on the body tag, which is the default after loading a page.
This prevents focus stealing if the focus is e.g. on an input field
before the RTE was initialized.

Resolves: #72900
Releases: master, 7.6
Change-Id: I238cd0ce1972f41e451ace674eeff350690cb427
Reviewed-on: https://review.typo3.org/47528
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Doctrine: Add support for aggregate SQL functions 26/47826/2
Morton Jonuschat [Wed, 20 Apr 2016 17:59:47 +0000 (19:59 +0200)]
[TASK] Doctrine: Add support for aggregate SQL functions

This patch extends the SQL Expressionbuilder with support for generating
expressions for MIN, MAX, AVG, SUM and COUNT aggregate functions, as
well as adding support for selecting literal (unquoted) SQL expressions
with the QueryBuilder using ->selectLiteral() and ->addSelectLiteral().

Releases: master
Resolves: #75822
Change-Id: Id1043ec8a60be1e6d3c273278a776e92bb8c973e
Reviewed-on: https://review.typo3.org/47826
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Doctrine: migrate EXT:backend/TranslationConfigurationProvider 93/47893/5
Michael Oehlhof [Sun, 24 Apr 2016 19:18:13 +0000 (21:18 +0200)]
[TASK] Doctrine: migrate EXT:backend/TranslationConfigurationProvider

Migrate EXT:backend/Configuration/TranslationConfigurationProvider

Resolves: #75898
Releases: master
Change-Id: If0eac81344152b5f5248c9b0fdc81ea8c53a46e2
Reviewed-on: https://review.typo3.org/47893
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Doctrine: migrate ext:recycler/DeletedRecords 63/47763/6
Michael Oehlhof [Mon, 18 Apr 2016 20:32:05 +0000 (22:32 +0200)]
[TASK] Doctrine: migrate ext:recycler/DeletedRecords

Resolves: #75718
Releases: master
Change-Id: I27a14e694cd17132bf71d2687b8ea2366409fa27
Reviewed-on: https://review.typo3.org/47763
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Doctrine: migrate ext:felogin 14/47814/6
Loek Hilgersom [Tue, 19 Apr 2016 14:42:14 +0000 (16:42 +0200)]
[TASK] Doctrine: migrate ext:felogin

Resolves: #75781
Releases: master
Change-Id: Iffdf7512bcc83a05c89e057ef7e7695b0ac1cb85
Reviewed-on: https://review.typo3.org/47814
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[!!!][TASK] Doctrine: migrate ext:backend/Tree 93/47693/5
Jan Helke [Fri, 15 Apr 2016 08:54:30 +0000 (10:54 +0200)]
[!!!][TASK] Doctrine: migrate ext:backend/Tree

Releases: master
Resolves: #75645
Change-Id: I4ee542e4c939388cfccdb896ff1e38e849965849
Reviewed-on: https://review.typo3.org/47693
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>