Packages/TYPO3.CMS.git
5 years ago[BUGFIX] FollowUp to "Invalid localization overlay of cObject FILES" 66/30666/4
Steffen Ritter [Wed, 11 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] FollowUp to "Invalid localization overlay of cObject FILES"

When fixing language overlay of cObject FILES, the mocking in the unit
test was not adapted.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8f939e31a13e437e437624dfccddf5f39526fb8b
Reviewed-on: https://review.typo3.org/30666
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Add default TypoScript setting for extbase query cache 63/29763/4
Marc Bastian Heinrichs [Fri, 25 Apr 2014 11:54:40 +0000 (13:54 +0200)]
[TASK] Add default TypoScript setting for extbase query cache

The extbase query cache is enabled by default. This patch
adds a TypoScript setting to enable or disable the cache in general
and on a plugin level.

Resolves: #57280
Releases: 6.2
Change-Id: I620a3c4d2c4e508630d97731f12cc11c617aae75
Reviewed-on: https://review.typo3.org/29763
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Detect and import xml file as well as t3d on ext initialization 64/30464/2
Marc Bastian Heinrichs [Wed, 28 May 2014 07:50:15 +0000 (09:50 +0200)]
[TASK] Detect and import xml file as well as t3d on ext initialization

Whenever installing an extension, the file located at
EXT:ext_key/Initialisation/data.t3d is detected and its content imported.
This patch adds support for EXT:ext_key/Initialisation/data.xml file as
well.

Resolves: #59154
Releases: 6.2
Change-Id: Ie5cf843ed7fff24c0cc022892d68fa86ba14a674
Reviewed-on: https://review.typo3.org/30464
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Fix set_no_cache() log level severity 63/30663/2
Alexander Stehlik [Wed, 11 Jun 2014 14:40:00 +0000 (16:40 +0200)]
[BUGFIX] Fix set_no_cache() log level severity

The array key that is used to check if a Backend user is logged in
is fixed.

Resolves: #59495
Releases: 6.2
Change-Id: Ida6609c3bde998e17a0d9e9184adb48f227507f5
Reviewed-on: https://review.typo3.org/30663
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Invalid localization overlay of cObject FILES 39/29739/9
Oliver Hader [Wed, 30 Apr 2014 07:44:01 +0000 (09:44 +0200)]
[BUGFIX] Invalid localization overlay of cObject FILES

The TypoScript cObject FILES does not consider localization
overlays and behavior correctly when it comes additional
translation table (e.g. for pages).

Concerning pages_language_overlay.media, there is no default
fallback to the values of the default language. This behavior
is the same to TYPO3 4.5. If the localization shall fallback
to the default language, the "mergeIfNotBlank" property needs
to be used for the accordant field.

For having the localization handling working properly the
FILES cObject section "references" must not set the properties
"table" and "uid" - otherwise the values will just be overriden
by those TypoScript settings.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8e915654e5ab1ed1eafe86411930f9fbfcc225ae
Reviewed-on: https://review.typo3.org/29739
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] EM: Add possibility to bypass system dependency checks 45/29845/18
Nicole Cordes [Sat, 3 May 2014 14:05:10 +0000 (16:05 +0200)]
[TASK] EM: Add possibility to bypass system dependency checks

This patch adds a new action to show all unresolved dependencies and
adds the possibility to bypass all system and version checks. Required
extensions are still tried to be fetched from TER.

Resolves: #54512
Releases: 6.2
Change-Id: I11cca622875d013ab6fd385d2c659477e803f6a2
Reviewed-on: https://review.typo3.org/29845
Reviewed-by: Markus Klein
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards 98/30498/5
Steffen Kamper [Sat, 31 May 2014 12:05:08 +0000 (14:05 +0200)]
[BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards

The placeholder PAGE_TSCONFIG_ID may be used in a foreign_table_where
TCA condition but is not available as parameter when using a wizard
to create new records. This patch fixes this issue.

Fixes: #59245
Releases: 6.2
Change-Id: I19ae9d72e14c047a08107fe6152093a4b04c27f6
Reviewed-on: https://review.typo3.org/30498
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Erroneous date sorting in File List 57/30657/2
Francois Suter [Wed, 11 Jun 2014 09:38:24 +0000 (11:38 +0200)]
[BUGFIX] Erroneous date sorting in File List

The sorting by date fails in the Filelist module when more
than 9 files with the same date are found since the numerical
suffix used to avoid overwriting existing entries in the
sorting array is not properly padded.

Fixes: #59458
Releases: 6.2
Change-Id: I2c80a00dd1692b0987da3d461cc5a21fcea4c97d
Reviewed-on: https://review.typo3.org/30657
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Activate 'Flush system caches' with Preset 'Development' 56/30656/4
Zbigniew Jacko [Wed, 11 Jun 2014 09:04:46 +0000 (11:04 +0200)]
[TASK] Activate 'Flush system caches' with Preset 'Development'

Add a new configuration in Install Tool (['SYS']['clearCacheSystem']).
If set, the toolbar of clearing system cache is visible (only for
admin users).

Add it also for Configuration Preset. For Production it is set to FALSE,
for Development it is set to TRUE.

Resolves: #57230
Releases: 6.2
Change-Id: Id45496c6bc1e64b4454ed7ff78e8db1179387b0f
Reviewed-on: https://review.typo3.org/30656
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] File Relations don't work with workspaces 12/29712/9
Benjamin Mack [Mon, 28 Apr 2014 13:28:53 +0000 (15:28 +0200)]
[BUGFIX] File Relations don't work with workspaces

The file repository used to resolve all sys_file_references
handles enable fields manually currently, which is bad because
it forgets to handle the workspace-related where clause.

The attached patch splits the behavior into frontend and
backend context. In backend the RelationHandler is capable
of automatically resolving IRRE structures. In frontend mode
the enableFiels and version preview settings are relevant to
show correct results.

Resolves: #43916
Releases: 6.2
Change-Id: I6c19e5d7b4cd7a2134921c669b82ab90b54844de
Reviewed-on: https://review.typo3.org/29712
Tested-by: Lorenz Ulrich
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Guard FAL API when called with invalid identifiers 26/30526/5
Helmut Hummel [Mon, 2 Jun 2014 18:16:07 +0000 (20:16 +0200)]
[BUGFIX] Guard FAL API when called with invalid identifiers

When calling ResourceFactory::getInstance()
->getFileObjectFromCombinedIdentifier($identifier)
with $identifier === NULL or $identifier === ''
an index entry is written for storage 0 which contains the
last path segment of PATH_site as identifier.

Guard the API in two places by throwing exceptions
when an invalid file identifier is given.

Resolves: #59295
Releases: 6.2
Change-Id: Ie2d6d811193ee21b865161984ddbac240388573b
Reviewed-on: https://review.typo3.org/30526
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Improve styling of sys_action "Create Backend User" 46/30646/3
Lorenz Ulrich [Tue, 10 Jun 2014 15:38:51 +0000 (17:38 +0200)]
[TASK] Improve styling of sys_action "Create Backend User"

The styling of sys_action "Create Backend User" is outdated
and should be slightly improved to enhance usability of
this module.

Releases: 6.2
Resolves: #59338
Change-Id: Ifaba21a78687589af9ba0decad8bc2b9fdc4d29d
Reviewed-on: https://review.typo3.org/30646
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Add additional TS for contentRenderingTemplates loaded by file 44/30544/2
Marc Bastian Heinrichs [Tue, 3 Jun 2014 16:40:08 +0000 (18:40 +0200)]
[BUGFIX] Add additional TS for contentRenderingTemplates loaded by file

Loading extensions TS, that provide contentRenderingTemplates, like
css_styled_content, using INCLUDE_TYPOSCRIPT was fixed in
https://review.typo3.org/#/c/21679/.

Since making TS content templates more flexible in
https://review.typo3.org/#/c/27587/ the contentRenderingTemplates wasn't
added to "defaultTypoScript_setup." and "defaultTypoScript_constants."
arrays anymore and breaks the mentioned fix.

Solution is to check the required key in contentRenderingTemplates and
add the defaultContentRendering string now.

Resolves: #59318
Releases: 6.2
Change-Id: I8a367f462f304e07bbcec99fd26818bc98148eb4
Reviewed-on: https://review.typo3.org/30544
Reviewed-by: Benjamin Mack
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] IRRE children show no field values with useCombination 37/19337/3
Stefan Froemken [Wed, 27 Mar 2013 07:47:52 +0000 (08:47 +0100)]
[BUGFIX] IRRE children show no field values with useCombination

The IRRE option useCombination enables to use bi-directional
relations with IRRE items. This enables you to re-use IRRE
items multiple times (similar as FAL is working with IRRE).

To prevent the same child record from being used multiple
times, items already used are removed from the select box.
The code removing the item was written to remove an item
from a select box, but (accidentially) also targets a hidden
item which causes the JavaScript to break so that the field
values of the child objects are not filled on expanding.

By adding an additional check, this can be prevented.
For steps to reproduce refer to #46477.

Resolves: #46477
Releases: 6.2
Change-Id: Ie7fd89f6ef887b5d45c734dea8ec6ad9ac2a8d2c
Reviewed-on: https://review.typo3.org/19337
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Move TCA for fe_users and fe_groups into TCA/Overrides 20/30620/8
Anja Leichsenring [Sat, 7 Jun 2014 06:58:30 +0000 (08:58 +0200)]
[BUGFIX] Move TCA for fe_users and fe_groups into TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes.

Change-Id: Ie919a856fbd8242d19110c8db8d01ff7865c913c
Resolves: #59397
Releases: 6.2
Reviewed-on: https://review.typo3.org/30620
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Fetch RSA public key by Ajax before FE login 64/30364/11
Frans Saris [Fri, 23 May 2014 13:29:02 +0000 (15:29 +0200)]
[BUGFIX] Fetch RSA public key by Ajax before FE login

Instead of generating and saving the public/private keys for
an RSA enabled login form on rendering the form the keys are
fetched on submit. This resolves the issue with outdated keys
and the problem that the login box on first page doesn't work
anymore when a page in a second tab is opened.

Resolves: #59041
Releases: 6.2
Change-Id: I0ad13775f029a29f6f67e302a1a63f3860e902b5
Reviewed-on: https://review.typo3.org/30364
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] FollowUp to "Include suggest info into package metadata" 38/30638/2
Steffen Ritter [Tue, 10 Jun 2014 10:12:14 +0000 (12:12 +0200)]
[TASK] FollowUp to "Include suggest info into package metadata"

A small follow-up renaming the variable of the loop which
has not been renamed after copy and paste.

Resolves: #58701
Releases: 6.2
Change-Id: I70af6722200fda48b09734e21c6d90d3a4e9b868
Reviewed-on: https://review.typo3.org/30638
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] rtehtmlarea user settings are not shown in setup ext 06/30006/5
Markus Klein [Sat, 10 May 2014 23:54:25 +0000 (01:54 +0200)]
[BUGFIX] rtehtmlarea user settings are not shown in setup ext

Fix this by adding the suggestion already present in
the ext_emconf.php also to the composer.json.

Resolves: #58694
Releases: 6.2
Change-Id: I9ded17691ed91fce099638bdac4b4f425cb47ea6
Reviewed-on: https://review.typo3.org/30006
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Jacco van der Post
Tested-by: Jacco van der Post
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Observe ext suggestions for ext loading order 05/30005/6
Markus Klein [Sat, 10 May 2014 23:48:32 +0000 (01:48 +0200)]
[TASK] Observe ext suggestions for ext loading order

Let the DependencyResolver take the suggest-part of the composer.json
or ext_emconf.php files into account. This solves issues where it is
necessary to ensure a certain loading order of extensions without
having a real dependency between those.

Resolves: #57825
Releases: 6.2
Change-Id: Ia771813b7945409e5ddaec3f19da27239be16e67
Reviewed-on: https://review.typo3.org/30005
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Thomas Maroschik
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Include suggest info into package metadata 15/30015/3
Markus Klein [Sun, 11 May 2014 21:30:37 +0000 (23:30 +0200)]
[TASK] Include suggest info into package metadata

Enhance the Package metadata with information about suggested packages.
This information may be loaded from composer.json or ext_emconf.php.

Resolves: #58701
Releases: 6.2
Change-Id: Ie7415ebe60d2c6164ccc52976a666fe07fd4afe0
Reviewed-on: https://review.typo3.org/30015
Reviewed-by: Thomas Maroschik
Tested-by: Fabien Udriot
Reviewed-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years agoRevert "[TASK] Downgrade to PHPUnit 3.7.*" 23/30623/3
Helmut Hummel [Sat, 7 Jun 2014 15:45:54 +0000 (17:45 +0200)]
Revert "[TASK] Downgrade to PHPUnit 3.7.*"

We can revert this again as the issue has been resolved
upstream:
https://github.com/sebastianbergmann/phpunit-mock-objects/issues/172

We can now switch back to phpunit 4.1.* again.

This reverts commit 7a876ddcfc3d41521b39c073519bad286143508d

Change-Id: If08d3e7200103e5cab77fdc1e098efd2048bde4c
Reviewed-on: https://review.typo3.org/30623
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Use delayedImportElement after uploading files 09/30609/4
Frans Saris [Fri, 6 Jun 2014 14:10:42 +0000 (16:10 +0200)]
[BUGFIX] Use delayedImportElement after uploading files

When uploading multiple files in TCEForm the DrapUploader
adds all uploaded files directly to the inline element of the
form. But when a previous request isn't finished yet, it
breaks the processing of last request.

This patch changes the use of importElement to
delayedImportElement so the next element is only added
when the previous is processed.

Resolves: #58956
Resolves: #57472
Resolves: #57190
Releases: 6.2
Change-Id: Iccad2ee19a5462cb63ed749ad60cb685460eb66d
Reviewed-on: https://review.typo3.org/30609
Reviewed-by: Helmut Hummel
Tested-by: Marc Fell
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Downgrade to PHPUnit 3.7.* 16/30616/2
Helmut Hummel [Fri, 6 Jun 2014 19:00:08 +0000 (21:00 +0200)]
[TASK] Downgrade to PHPUnit 3.7.*

Suddenly build failures occurred on travis which seem
to be related to ReflectionClass::newInstanceWithoutConstructor
which is used by PHPUnit 4.1.* when available.

Downgrade to PHPUnit 3.7.* to have a green build again
as the failures are totally unrelated to our code.

Change-Id: I6c3c200d5eda372e92ee0fd4c39e7fe79183ecab
Reviewed-on: https://review.typo3.org/30616
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix command description 12/30612/2
Mathias Brodala [Fri, 6 Jun 2014 17:49:14 +0000 (19:49 +0200)]
[BUGFIX] Fix command description

Due to using array_pop instead of array_shift the last line
of the command description is dropped instead of the first.

Use array_shift instead to get the full description
annotated for the command method.

Resolves: #59324
Releases: 6.2, 6.1, 4.7
Change-Id: I4d7c320b0ef334adbd15997d15d8e7a56d5739c1
Reviewed-on: https://review.typo3.org/30612
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp 81/30581/4
Jan-Erik Revsbech [Thu, 5 Jun 2014 09:33:54 +0000 (11:33 +0200)]
[BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp

When running TYPO3 behind a reverse proxy, which also handles SSL,
the setting reverseProxySSL should check if the site is requested
from one of the reverse proxies in order to determine whether
the site is using SSL.

It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has
already translated the proxy IP to the end-users IP, thus always
returning FALSE.

Resolves: #37467
Release: 6.2, 6.1
Change-Id: I95615b0fea94e0ef0222e958e4e0bba5e6e9f60a
Reviewed-on: https://review.typo3.org/30581
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Enhance resource storage hooks 25/30525/2
Alexander Stehlik [Mon, 2 Jun 2014 17:52:48 +0000 (19:52 +0200)]
[TASK] Enhance resource storage hooks

Emit postFileCreate and postFileSetContents signals and add
provide the original folder in the postFileMove and the
postFolderMove signals.

Resolves: #59294
Releases: 6.2
Change-Id: Ia4096b38671f3312a1488587972d4883368de05c
Reviewed-on: https://review.typo3.org/30525
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Unified maxitems default value for group fields 78/27378/4
Alexander Stehlik [Tue, 25 Mar 2014 16:18:22 +0000 (17:18 +0100)]
[BUGFIX] Unified maxitems default value for group fields

The maxitems value for a group field defaults to 1 instead of 100000 so
that it is consistent with the TCA reference and the validation in the
DataHandler.

Resolves: #55731
Releases: 6.2
Change-Id: I517e45a9227ab9d971a9e7bc4410498319192517
Reviewed-on: https://review.typo3.org/27378
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Admin panel extGetFeAdminValue() overrides are wrong 30/29730/2
Markus Klein [Tue, 29 Apr 2014 16:58:25 +0000 (18:58 +0200)]
[BUGFIX] Admin panel extGetFeAdminValue() overrides are wrong

The current check does not properly consider the override values.
If a override is set, then its value has to be taken.
The current check only considered overrides which had
boolean value TRUE.

Resolves: #58339
Releases: 6.2, 6.1
Change-Id: Ib714432044c6a88fc92dcb8f36a4e37eb3412378
Reviewed-on: https://review.typo3.org/29730
Reviewed-by: Gerrit Mohrmann
Tested-by: Gerrit Mohrmann
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Disabled backend users shown for workspace stage change 73/26773/3
Stefan Rotsch [Mon, 24 Mar 2014 14:14:40 +0000 (15:14 +0100)]
[BUGFIX] Disabled backend users shown for workspace stage change

On changing the stage of a workspace version, an accordant
dialog is shown with recipients to be informed about this
action. However, disabled backend users are shown in this
dialog as well.

Resolves: #54925
Releases: 6.2
Change-Id: Iefae9e35e9c680783769260e8c3e38180bde5703
Reviewed-on: https://review.typo3.org/26773
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Show images in preview of page module 98/30598/2
Frans Saris [Thu, 5 Jun 2014 19:32:38 +0000 (21:32 +0200)]
[BUGFIX] Show images in preview of page module

For custom content elements with image these are shown
as thumbs in the list module but not in the page module.

This patch also renders the images when present just
like the bodytext.

Resolves: #59375
Releases: 6.2
Change-Id: If39e8b22af6144e5d6990a741559bd7574ee5e09
Reviewed-on: https://review.typo3.org/30598
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Add missing PHP comments in class LogoView 96/30596/2
Fabien Udriot [Thu, 5 Jun 2014 18:30:47 +0000 (20:30 +0200)]
[CLEANUP] Add missing PHP comments in class LogoView

Change-Id: I13d428c7b8a3964e8c376ad2c8d2a4af8c0059f1
Releases: 6.2
Resolves: #59374
Reviewed-on: https://review.typo3.org/30596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Improve the formatting of help of the CommandController 94/30594/3
Stefano Kowalke [Thu, 5 Jun 2014 17:21:30 +0000 (19:21 +0200)]
[BUGFIX] Improve the formatting of help of the CommandController

This aligns the description of the command line options.

Resolves: #59372
Releases: 6.2
Change-Id: I474f8415d3ed62d583553f915edc3caa8189a803
Reviewed-on: https://review.typo3.org/30594
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Illegal string offset 'uid' in TypoScriptFrontendController 88/30588/2
Robert Vock [Thu, 5 Jun 2014 11:54:58 +0000 (13:54 +0200)]
[BUGFIX] Illegal string offset 'uid' in TypoScriptFrontendController

Logoff sets user property to an empty string instead of NULL. This
leads to a PHP Warning in PHP 5.4

Change-Id: Ib0e1a31dbf2fd3fcbcf1e7afd972b53d60c3ab5d
Resolves: #59364
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30588
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Warning in SearchController 12/30512/5
Christian Zenker [Mon, 2 Jun 2014 11:49:00 +0000 (13:49 +0200)]
[BUGFIX] Warning in SearchController

$this->sWArr is not defined SearchController.
Fix this to use the correct $this->searchWords variable.

Change-Id: Iba888f1a47dcc0952ffbbb1e3bb4413435c2a95e
Resolves: #59277
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30512
Reviewed-by: Alexander Opitz
Reviewed-by: Christian Zenker
Tested-by: Christian Zenker
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show content elements from hidden pages in preview 12/30212/3
Markus Klein [Wed, 21 May 2014 11:45:23 +0000 (13:45 +0200)]
[BUGFIX] Show content elements from hidden pages in preview

Content elements from hidden pages are no longer shown in previews.

Fix this by checking with a strong comparison in enableFields() whether
the $show_hidden parameter is set to the default value.

Fixes: #58148
Related: #57814
Releases: 6.2
Change-Id: I2e20db88a513adb1a4d7599591fd3affdb60f209
Reviewed-on: https://review.typo3.org/30212
Tested-by: Dirk Klimpel
Reviewed-by: Mario Rimann
Reviewed-by: David Hoeckele
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix frontend unit tests if executed standalone 60/30560/2
Helmut Hummel [Wed, 4 Jun 2014 14:23:07 +0000 (16:23 +0200)]
[BUGFIX] Fix frontend unit tests if executed standalone

* Allow HTTP_HOST access for all unit tests
* Remove allow all in data provider

The latter implicitly caused a global allow, as PHPUint parses
all data providers before any test is run, thus setting globals there
will cause them to be preserved (and restored when backup globals is true).

Releases: 6.2, 6.1, 6.0
Resolves: #59343
Change-Id: I646294bb472027e22d6edc0622068698fe9a88fc
Reviewed-on: https://review.typo3.org/30560
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show storage and folder of file/folder 58/30558/4
Frans Saris [Wed, 4 Jun 2014 14:45:26 +0000 (16:45 +0200)]
[BUGFIX] Show storage and folder of file/folder

To make it possible for an editor to find the real
location of a used file, the storage and folder are
added to the ElementInformation view of a file and folder.

Resolves: #57798
Releases: 6.2
Change-Id: I7c8104809bad49a6df1ec625cf3463a96526ede2
Reviewed-on: https://review.typo3.org/30558
Reviewed-by: Einar Gislason
Tested-by: Einar Gislason
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show file instead of file_reference info 51/29651/3
Frans Saris [Fri, 25 Apr 2014 06:53:56 +0000 (08:53 +0200)]
[BUGFIX] Show file instead of file_reference info

The irre elements of FAL items have an info icon which shows
some details info about the file_reference. But this is not
the info an editor is looking for he wants the file info.

This patch changes the link behind the info icon for FAL items
so it shows the file info.

Resolves: #57302
Resolves: #57832
Releases: 6.2
Change-Id: I3c4b867ceb5bc05e1cb62525450102784793fadc
Reviewed-on: https://review.typo3.org/29651
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Nico de Haen
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] List module pagination broken 49/29949/3
Markus Klein [Thu, 8 May 2014 18:07:13 +0000 (20:07 +0200)]
[BUGFIX] List module pagination broken

A wrong formula is used to calculate the pointer
for the pages.
This patch also introduces a central function for
calculating the pointer to a page.

Resolves: #55320
Releases: 6.2
Change-Id: Ia4eec61f4f87b52d0d5e940e542998f9f82aa140
Reviewed-on: https://review.typo3.org/29949
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Old TYPO3 logo still in use in ext:workspaces 48/30548/2
Wouter Wolters [Tue, 3 Jun 2014 21:38:05 +0000 (23:38 +0200)]
[BUGFIX] Old TYPO3 logo still in use in ext:workspaces

Replace old logo with the new logo.

Resolves: #59321
Releases: 6.2
Change-Id: I1b4386e0ee614096b4033f00d9fe9136d11a63c7
Reviewed-on: https://review.typo3.org/30548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] DataHandler::log() must not return NULL 79/30479/3
Markus Klein [Wed, 28 May 2014 17:38:29 +0000 (19:38 +0200)]
[BUGFIX] DataHandler::log() must not return NULL

Ensure the DataHandler::log() function does return integers
in all cases as denoted in the doc header.

Resolves: #59185
Releases: 6.2, 6.1, 6.0
Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1
Reviewed-on: https://review.typo3.org/30479
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Check and use current file hash and size on export 61/30061/3
Marc Bastian Heinrichs [Tue, 13 May 2014 14:26:11 +0000 (16:26 +0200)]
[TASK] Check and use current file hash and size on export

On creating exports the file hash and size is used from the
sys_file table. Since this could be not up-to-date in real live
projects, those files fail to be imported.

To prevent this, use the correct data for the export and show
an error to the user.

Resolves: #58761
Releases: 6.2
Change-Id: I7aacc6f00c52bc01c753af4ee32202a9219c02a1
Reviewed-on: https://review.typo3.org/30061
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use created folder object for adding images in impexp 84/29984/2
Marc Bastian Heinrichs [Fri, 9 May 2014 16:04:34 +0000 (18:04 +0200)]
[BUGFIX] Use created folder object for adding images in impexp

A folder to be created could change the name by sanitizing. So
the name of the created folder could differ from the requested
name. For adding the image the returned folder object should be
used.

To avoid that sanitized ones should be created over and over again
a mapping is buffered.

Resolves: #58682
Releases: 6.2
Change-Id: Ia3443c36c6dda8531c8791c221d2a835b25b10b2
Reviewed-on: https://review.typo3.org/29984
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ElementBrowser: correct link attributes 83/30483/3
Markus Klein [Thu, 29 May 2014 10:40:58 +0000 (12:40 +0200)]
[BUGFIX] ElementBrowser: correct link attributes

This is a regression fix for #55983, which introduced
additional urlencoding for title, class, ...

Remove the encoding again.

Resolves: #59199
Releases: 6.2
Change-Id: I28650676f4ae0b74256a770af12054750027cbfa
Reviewed-on: https://review.typo3.org/30483
Reviewed-by: Markus Bucher
Tested-by: Markus Bucher
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix wrong JS function name in RTE 31/30531/2
Markus Klein [Tue, 3 Jun 2014 10:02:04 +0000 (12:02 +0200)]
[BUGFIX] Fix wrong JS function name in RTE

RTE feature "userlinks" generates a wrong JS function
name due to the automatic replacement during the
namespace conversion.

Revert this line to use the correct JS function name.

Resolves: #59302
Releases: 6.2, 6.1, 6.0
Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97
Reviewed-on: https://review.typo3.org/30531
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Canonicalize path before checking existence 32/30532/3
Nils Blattner [Tue, 3 Jun 2014 11:14:57 +0000 (13:14 +0200)]
[BUGFIX] Canonicalize path before checking existence

ResourceFactory fails to detect files in symlinked
scenarios, because the path is not canonicalized before
file existence is checked.

Solution is to canonicalize it and check then.

Resolves: #59303
Releases: 6.2
Change-Id: I4fd763f7076e909f2163af79ed2b7f8642da8ed7
Reviewed-on: https://review.typo3.org/30532
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Request update broken for select fields 44/30044/2
Francois Suter [Tue, 13 May 2014 11:09:32 +0000 (13:09 +0200)]
[BUGFIX] Request update broken for select fields

For select-type fields displayed as two side-by-side selectors
which are registered as "requestUpdate" fields, the form submission
happens before the value is copied to the left-hand selector.
The form is thus saved without value.

Full description in the bug report, which also contains a
test extension and steps to reproduce.

Resolves: #58755
Releases: 6.2
Change-Id: Ie94def723537202287655c650cee7dfa09815f4f
Reviewed-on: https://review.typo3.org/30044
Reviewed-by: Peter Foerger
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Tomas Norre Mikkelsen
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA maxitems for FAL permissions wrong 18/30518/2
Markus Klein [Mon, 2 Jun 2014 13:49:03 +0000 (15:49 +0200)]
[BUGFIX] TCA maxitems for FAL permissions wrong

The setting for maxitems in the TCA of be_users and be_groups for
FAL permissions are wrong.
Fix the value to match the number of available options.

Resolves: #59263
Releases: 6.2
Change-Id: Ib38aab8bbd1f5fe9287ff0523139f88520f27e37
Reviewed-on: https://review.typo3.org/30518
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Make object access work with ObjectStorage 23/29923/6
Helmut Hummel [Wed, 7 May 2014 17:30:57 +0000 (19:30 +0200)]
[BUGFIX] Make object access work with ObjectStorage

ObjectAccess->getPropertyPath() does not work with
ObjectStorage and numerical indexes, but it should be
because without it form fluid fields cannot be
properly handled as the value is always null.

Fixing fetching objects from ObjectStorage by index
will also enable shorter access of single objects in Fluid.

Imagine you want to render the first image in your
template. Previously you had to write this:

<f:for each="{object.images}" as="image" iteration="iterator">
<f:if condition="{iterator.isFirst}">
<f:image image="{image}" alt="" width="50"/>
</f:if>
</f:for>

Now you can just write:

<f:image image="{object.images.0}" alt="" width="50"/>

Resolves: #37126
Related: #37000
Releases: 6.2
Change-Id: I45122bd145b5a179ad3e9e3894520f9a614906c8
Reviewed-on: https://review.typo3.org/29923
Reviewed-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Fabien Udriot
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Keep session cookie if session data is present 85/30485/5
Helmut Hummel [Sun, 1 Jun 2014 12:20:17 +0000 (14:20 +0200)]
[BUGFIX] Keep session cookie if session data is present

The AbstractUserAuthentication::checkAuthentication() method calls
the logoff() method on every failed login attempt.

Since a logoff also causes a removal of the cookie,
any (anonymous) session data will be left unaccessible.

Keep the cookie when session data is present.

Releases: 6.2
Resolves: #58713
Change-Id: I744456f62197a7278635d8564d4883564d954dd2
Reviewed-on: https://review.typo3.org/30485
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Always add wrapping div if dividers2tabs is disabled 61/30461/3
Frans Saris [Wed, 28 May 2014 08:04:09 +0000 (10:04 +0200)]
[BUGFIX] Always add wrapping div if dividers2tabs is disabled

TCEforms is not wrapped in a div when dividers2tabs is disabled
and a inline-element form element is present. As a result there
is no background image/color shown.

This changes removes the check as the wrap is also needed when
inline-elements are present.

Resolves: #59163
Releases: 6.2
Change-Id: I8772fce0d99bacdf18692308c700c02c0a0defcf
Reviewed-on: https://review.typo3.org/30461
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Do not use self:: within closures 89/30489/2
Markus Klein [Thu, 29 May 2014 14:39:20 +0000 (16:39 +0200)]
[BUGFIX] Do not use self:: within closures

This is not possible in PHP 5.3.

Resolves: #59203
Releases: 6.2
Change-Id: I108578f7635c50493a3b5d7a7fc81c021805abf8
Reviewed-on: https://review.typo3.org/30489
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Flexform element title is cropped to hardcoded length 42/30242/3
Sebastian Michaelsen [Wed, 21 May 2014 07:53:52 +0000 (09:53 +0200)]
[BUGFIX] Flexform element title is cropped to hardcoded length

The title of a flexform element is cropped to maximum length of 30
characters. Instead it should obey the maximum title length in the user
settings.

Resolves: #58910
Releases: 6.2, 6.1
Change-Id: I28c6fc94b2d492217479bf014ff8f67463b4e98f
Reviewed-on: https://review.typo3.org/30242
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Admin panel text selection 18/30118/5
Goran Medakovic [Wed, 14 May 2014 16:26:35 +0000 (18:26 +0200)]
[BUGFIX] Admin panel text selection

Fixes: #58485
Releases: 6.2
Change-Id: I9c3243b2cca9edb89d262a4d3f9cde17b906d440
Reviewed-on: https://review.typo3.org/30118
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use self:: where possible in GeneralUtility 57/30257/2
Sebastian Michaelsen [Wed, 21 May 2014 14:10:16 +0000 (16:10 +0200)]
[TASK] Use self:: where possible in GeneralUtility

It's common sense to use self:: where possible because it's quicker and
makes code better understandable.

This change fixes 2 violations in \TYPO3\CMS\Core\Utility\GeneralUtility

Releases: 6.2
Resolves: #59001
Change-Id: Ie56a6697186426e3ff082b1694572c885c8420f5
Reviewed-on: https://review.typo3.org/30257
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix redirect to install tool in new installations 76/30376/6
Markus Klein [Sat, 24 May 2014 18:45:17 +0000 (20:45 +0200)]
[BUGFIX] Fix redirect to install tool in new installations

When setting up a new TYPO3 installation, TYPO3 should redirect
to the install tool, when accessing the frontend or backend.

This redirect fails since introduction of the trustedHostsPattern
since no configuration is available at this point, while the
request itself is a BE or FE request, which will be denied in this
case.
Solution is to set the REQUEST_TYPE to INSTALL before doing the redirect
to install tool so that creating the redirect is allowed.

Resolves: #59087
Releases: 6.2, 6.1
Change-Id: I31bcbc20fa1c9bca0d6bf2b940bf26b9affe893b
Reviewed-on: https://review.typo3.org/30376
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] EM: Handle missing dependencies in emconf 47/29947/2
Markus Klein [Thu, 8 May 2014 16:48:11 +0000 (18:48 +0200)]
[BUGFIX] EM: Handle missing dependencies in emconf

ext_emconf.php may lack the dependencies array. This will cause
a PHP warning in a foreach loop.

Fix this by checking for the type first.

Resolves: #58640
Releases: 6.2
Change-Id: Ifb04268e04f5349282f895f6b3d7354dbc45affc
Reviewed-on: https://review.typo3.org/29947
Reviewed-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Indexed search static call to non-static function 69/30069/3
Markus Klein [Tue, 13 May 2014 15:57:58 +0000 (17:57 +0200)]
[BUGFIX] Indexed search static call to non-static function

Resolves: #58756
Releases: 6.2
Change-Id: Ide09c7792e9b24afe480230893cac18570ce4f19
Reviewed-on: https://review.typo3.org/30069
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Correct minor typo in "About TYPO3 CMS" 76/30476/3
Michael Schams [Wed, 28 May 2014 14:52:53 +0000 (00:52 +1000)]
[BUGFIX] Correct minor typo in "About TYPO3 CMS"

This patch corrects a minor typo in module: Web -> About TYPO3 CMS.
It currently reads "TYPO3 CMS is a enterprise-class...", but it should
read: "...is an enterprise..." ("an" with a "n").

Resolves: #59187
Releases: 6.2
Change-Id: I4e77e54dded08ef4cbdd484d81660a1e39241986
Reviewed-on: https://review.typo3.org/30476
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Parent language is not applied to new child records 48/30448/2
David Greiner [Tue, 27 May 2014 14:07:41 +0000 (16:07 +0200)]
[BUGFIX] Parent language is not applied to new child records

If localizing a parent-child structure, usually the language
of the parent element shall be applied to related child records
as well as new child records.

Due to a missing array segment, the accordant section in the
the InlineElement source code never was processed.

Resolves: #57063
Releases: 6.2, 6.1
Change-Id: I7e563044f9889538f9b8171f71f7685722db8266
Reviewed-on: https://review.typo3.org/30448
Reviewed-by: Markus Klein
Reviewed-by: David Greiner
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Added missing TCEforms palette-header padding 58/30458/3
Frans Saris [Wed, 28 May 2014 07:09:27 +0000 (09:09 +0200)]
[BUGFIX] Added missing TCEforms palette-header padding

With the cleanup of the backend styles a padding of the
pallete header got missing.

This patch adds this padding just like the other headers
in the TCEforms.

Resolves: #59160
Releases: 6.2
Change-Id: I25ca0ccb0bbd7f4f6d014e12f1cebe1b12050718
Reviewed-on: https://review.typo3.org/30458
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] New content elements are always stored on pid 0 89/30389/3
Nicole Cordes [Sun, 25 May 2014 17:30:54 +0000 (19:30 +0200)]
[BUGFIX] New content elements are always stored on pid 0

Due to patch https://review.typo3.org/#/c/30305/ the string comparison
on colPos fails and new content elements are always stored on pid 0.
This patch corrects the check for an integer colPos type by setting the
unused variable to NULL.

Resolves: #59059
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Iecd7f0cacf5c9315d882eebeb3893bcfa63ae7eb
Reviewed-on: https://review.typo3.org/30389
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Inserting custom element in RTE throws exception 21/30221/2
Stanislas Rolland [Tue, 20 May 2014 00:15:50 +0000 (20:15 -0400)]
[BUGFIX] Inserting custom element in RTE throws exception

Problem: Token validation fails.
Solution: Use BackendUtility::getModuleUrl to ensure validity of token.

Resolves: #58371
Releases: 6.2
Change-Id: I334826dbeb2a11a6b28d4fd610670fe4d7558e1a
Reviewed-on: https://review.typo3.org/30221
Tested-by: Chris Müller
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Alternative implementations for view helpers do not work 57/24057/8
Marc Bastian Heinrichs [Sat, 15 Feb 2014 10:29:55 +0000 (11:29 +0100)]
[BUGFIX] Alternative implementations for view helpers do not work

Extbase allows to register alternative implementations for
objects. However that does not work for view helpers using
a closing tag. The resolved (alternative) object is compared
to the name of the original view helper and throws an
exception like:

  #1224485398: Templating tags not properly nested. Expected:
  "AlternativeViewHelper"; Actual: "OriginalViewHelper"

A simple solution is to save the class name of the object returned
from the object manager in a runtime cache and check this when
resolving a view helper name. A nice side effect is, that a same
view helper name must not be calculated over and over again.

Fixes: #52272
Releases: 6.0, 6.1, 6.2
Change-Id: Ie49e5e83c779b4748dc2059f8fbc85552ce4b406
Reviewed-on: https://review.typo3.org/24057
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Raise maximum settable numbers in export 02/30202/2
Marc Bastian Heinrichs [Mon, 19 May 2014 09:43:07 +0000 (11:43 +0200)]
[TASK] Raise maximum settable numbers in export

The maximums for today's exports are limited to strict.
It's 10MB for a settable file size included in exports;
raise it to 1000MB. The maximum settable number of
records is 10000; raise it to 1000000.

Resolves: #58912
Releases: 6.2
Change-Id: If2613b453cfbfda5c4909770064f112c23eca83b
Reviewed-on: https://review.typo3.org/30202
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[CLEANUP] Code cleanup for LanguageService 60/30260/3
Sebastian Michaelsen [Wed, 21 May 2014 15:00:36 +0000 (17:00 +0200)]
[CLEANUP] Code cleanup for LanguageService

* Avoid unnecessary fully qualified class names
* Add return NULL for consistency if a method only returns a value
  in some cases

Releases: 6.2
Resolves: #59006
Change-Id: I8c005a3e20fc49d65123e415025bef1c41ad7854
Reviewed-on: https://review.typo3.org/30260
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix saving non public export presets 12/30112/2
Marc Bastian Heinrichs [Wed, 14 May 2014 14:34:42 +0000 (16:34 +0200)]
[BUGFIX] Fix saving non public export presets

Fix sql error "Column 'public' cannot be null" on saving
with unchecked box public.

Resolves: #57405
Releases: 6.2
Change-Id: I1582728cc56781fdc12409956008fc82a6cd0d03
Reviewed-on: https://review.typo3.org/30112
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Set default permissions for new files to 0664 13/30113/2
Caspar Stuebs [Wed, 14 May 2014 14:34:52 +0000 (16:34 +0200)]
[BUGFIX] Set default permissions for new files to 0664

Change-Id: I4c71414dca763d9ba29ab93b18a0389941f51af7
Resolves: #58809
Releases: 6.2
Reviewed-on: https://review.typo3.org/30113
Reviewed-by: Dmitry Dulepov
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix url for youtube embeds 52/29952/3
Thomas Löffler [Thu, 8 May 2014 19:14:16 +0000 (21:14 +0200)]
[BUGFIX] Fix url for youtube embeds

Additionally solve the problem when http:// is missing
due to usage of the link wizard.

Change-Id: I676d14b4ddf81d5d3ec0fc0d0ebb32d08910047a
Resolves: #58569
Resolves: #58986
Releases: 6.2
Reviewed-on: https://review.typo3.org/29952
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Wrong HTML in locallang_csh_pages.xlf 20/30220/2
Markus Klein [Mon, 19 May 2014 18:38:30 +0000 (20:38 +0200)]
[BUGFIX] Wrong HTML in locallang_csh_pages.xlf

lang/4.5/locallang_csh_pages.xlf contains invalid
HTML structure a <p> tag should actually be a <b> tag.

Resolves: #58936
Releases: 6.2, 6.1, 4.5
Change-Id: Id37d424296628202d8d434e0cf9cafd8529da2c3
Reviewed-on: https://review.typo3.org/30220
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix relative path resolution in include static 68/29468/4
Markus Klein [Mon, 14 Apr 2014 23:01:50 +0000 (01:01 +0200)]
[BUGFIX] Fix relative path resolution in include static

Fix the usage of relative paths in INCLUDE_TYPOSCRIPT inclusions of
static templates from extensions.

EXT:myext/Configuration/TypoScript/setup.txt:
<INCLUDE_TYPOSCRIPT: source="DIR:./Setup/">

EXT:myext/Configuration/TypoScript/Setup/ holds some TS files.

Resolves: #57447
Releases: 6.2
Change-Id: I64ba190fa6959eb27a2d6f1c278cfb9c9c3cbfaf
Reviewed-on: https://review.typo3.org/29468
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jan Kiesewetter
Tested-by: Jan Kiesewetter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath 67/29467/4
Markus Klein [Mon, 14 Apr 2014 22:50:49 +0000 (00:50 +0200)]
[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath

PathUtility::getAbsolutePathOfRelativeReferencedFileOrPath()
Add a check to the function to identify a given basepath as described
in the function header.

Resolves: #57918
Releases: 6.2, 6.1
Change-Id: I8de12cb917b2f32490bb160686ce06a036abfd85
Reviewed-on: https://review.typo3.org/29467
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix failing unit tests for HTTP host check in CLI mode 23/30323/4
Helmut Hummel [Thu, 22 May 2014 09:33:09 +0000 (11:33 +0200)]
[BUGFIX] Fix failing unit tests for HTTP host check in CLI mode

The unit tests for the recent HTTP host fix are failing
if executed in CLI mode.
In CLI mode no server environments and HTTP headers are available,
that's why the behavior needs to know about the
test execution process.

We solve this by mocking allowed request types.

Resolves: #59022
Releases: 6.2, 6.1, 6.0
Change-Id: I3c93d181dcec5f34064798e7c31240877fde610d
Reviewed-on: https://review.typo3.org/30323
Reviewed-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.2.4-dev 17/30317/2
TYPO3 Release Team [Thu, 22 May 2014 08:33:00 +0000 (10:33 +0200)]
[TASK] Set TYPO3 version to 6.2.4-dev

Change-Id: Ic42722b40b91e61dfd839241b91b9ff31a322259
Reviewed-on: https://review.typo3.org/30317
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.3 16/30316/2 6.2.3 TYPO3_6-2-3
TYPO3 Release Team [Thu, 22 May 2014 08:32:30 +0000 (10:32 +0200)]
[RELEASE] Release of TYPO3 6.2.3

Change-Id: Ib7b6505d59bdec51f537afec80678c11c0ad0b89
Reviewed-on: https://review.typo3.org/30316
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[SECURITY] Add trusted HTTP_HOST configuration 07/30307/2
Helmut Hummel [Thu, 22 May 2014 07:34:08 +0000 (09:34 +0200)]
[SECURITY] Add trusted HTTP_HOST configuration

TYPO3 uses the values of HTTP_HOST in several
places without validating them. This could
lead to a situation where links are generated
using the host part from HTTP_HOST.

Since HTTP_HOST headers are user input and
can be spoofed by an attacker, it leads
into several potential and actual security issues.

To address this, a configuration option for
trusted hosts is added, which is evaluated every
time getIndpEnv('HTTP_HOST') is called.

The configuration option is

$GLOBALS['TYPO3_CONF_VARS']['SYS']['trustedHostsPattern']

and can contain either a regular expression or the
value "SERVER_NAME"

To properly output the exception message in case
the trustedHostPattern does not match,
we need to adapt the exception handlers slightly
to not log information in this case and to actually
show the message even in production context to not
confuse admins on what is currently going wrong.

To not break all existing installations, the default
pattern is set to 'SERVER_NAME' which allows all
HTTP_HOST values matching the SERVER_NAME (and
optionally the SERVER_PORT if a port is specified
in the HTTP_HOST value).

This will secure all installation which use properly
configured name based virtual hosts, but leaves
installations where the web server is not bound
to a specific host name still in an insecure state.

Change-Id: I42fe77fe919755942636108a71c31175647449a9
Fixes: #30377
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30307
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in (old) extension manager information function 06/30306/2
Nicole Cordes [Thu, 22 May 2014 07:34:03 +0000 (09:34 +0200)]
[SECURITY] XSS in (old) extension manager information function

Needs to be fixed also in 6.x, but the affected function is not
used anymore.

Change-Id: If10b0cf25015eada0657aaebc19da3e3364f738a
Fixes: #54111
Fixes: #54113
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: d23f0ccc8960832c184a0e6c5daced98a0b6d096
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30306
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in new content element wizard 05/30305/2
Marcus Krause [Thu, 22 May 2014 07:33:58 +0000 (09:33 +0200)]
[SECURITY] XSS in new content element wizard

Sanitize user-input colPos in new content element wizard.

Change-Id: Ifa90ea1ede3b6c2a5436c505993c533803306d01
Fixes: #48695
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: bad0160450fb5786e1cb1e393c76c3da38c2ffe7
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30305
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in template tools on root page 04/30304/2
Marc Bastian Heinrichs [Thu, 22 May 2014 07:33:51 +0000 (09:33 +0200)]
[SECURITY] XSS in template tools on root page

Change-Id: I2b5214e666d1c9edc5354dd3983401038e9aaf66
Fixes: #54109
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: e17bc3297e95f6ffd5d1df682235bfaac7a5ad53
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30304
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in Backend Layout Wizard 03/30303/2
Helmut Hummel [Thu, 22 May 2014 07:33:47 +0000 (09:33 +0200)]
[SECURITY] XSS in Backend Layout Wizard

Change-Id: I096d26b3eee20493b146633bda11529890be59dc
Fixes: #57576
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: b49bd72b12f709e1c3dffd4f471d138ad1dcceb5
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30303
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Encode URL for use in JavaScript 02/30302/2
Jigal van Hemert [Thu, 22 May 2014 07:33:41 +0000 (09:33 +0200)]
[SECURITY] Encode URL for use in JavaScript

The url for the Open in New Window button must be quoted for
use in JavaScript to prevent XSS issues.

Change-Id: I3e55f31c3c857989d71a5ef1a0368b96aa5e2c31
Fixes: #48693
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 4d9cd3e6f589c77b5a366497a33f7eb2099dc749
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30302
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Session timeout can be circumvented once 01/30301/2
Markus Klein [Thu, 22 May 2014 07:33:36 +0000 (09:33 +0200)]
[SECURITY] Session timeout can be circumvented once

Fix the AbstractUserAuthentication class to properly invalidate
the current session if it timed out.

Change-Id: Id50ee1abd197674fa9379b52b46b63ecf770c964
Fixes: #57673
Releases: 6.2
Security-Commit: 38e24be1ff26fa181f16b91c57a0fcbe4da5065a
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30301
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Remove charts.swf to get rid of XSS vulnerability 00/30300/2
Helmut Hummel [Thu, 22 May 2014 07:33:31 +0000 (09:33 +0200)]
[SECURITY] Remove charts.swf to get rid of XSS vulnerability

The file charts.swf is vulnerable to XSS, is delivered
by ExtJS but not used in TYPO3 CMS at all.

Since the vendor of ExtJS did not fix this vulnerability,
we decided to remove it from TYPO3 sources.

Change-Id: Ib30cac84983f5a30956d0a09af933b0fbca1d6ff
Fixes: #54526
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 2402b6cfa3ab2a054ef3e28f3d8de8f7dfee17ec
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30300
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] RTE Remove Format removes too much 23/30223/2
Stanislas Rolland [Tue, 20 May 2014 01:08:22 +0000 (21:08 -0400)]
[BUGFIX] RTE Remove Format removes too much

The remove format function with msword selected removes too much
content when there is more than one style block in content.

Note: Thanks to Volker Burggräf

Resolves: #58310
Releases: 6.2, 6.1, 4.5
Change-Id: Ia29767239d92fde20ceee97ece47786d3fd3a9a5
Reviewed-on: https://review.typo3.org/30223
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] indexed_search plugin cannot be translated 03/30103/5
Robert Vock [Wed, 14 May 2014 11:30:34 +0000 (13:30 +0200)]
[BUGFIX] indexed_search plugin cannot be translated

The experimental extbase plugin of indexed_search is not
translatable on Pootle because it is still using locallang.xml
instead of a XLIFF translation file.

Change-Id: Ia3a45573737f8be0f802bfdbf5bd4f36add66b07
Resolves: #58796
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30103
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Missing check if $row[t3ver_state] is set in IconUtility 52/30152/5
Frans Saris [Thu, 15 May 2014 20:21:57 +0000 (22:21 +0200)]
[BUGFIX] Missing check if $row[t3ver_state] is set in IconUtility

As a result of a missing check if $row['t3ver_state'] exists,
an exception is thrown when IconUtility::getIcon() is called
with only the required params set.

This patch adds the missing check.

Resolves: #58846
Releases: 6.2
Change-Id: I70da9ee79a5c0ee1ad4fe8892e8ed28f904a11da
Reviewed-on: https://review.typo3.org/30152
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Cleanup DataHandler functional tests 77/30177/3
Oliver Hader [Fri, 16 May 2014 12:27:29 +0000 (14:27 +0200)]
[TASK] Cleanup DataHandler functional tests

Some DataHandler functional test cases are duplicated or are not
required anymore. Here's a list of what has changed and moved
into some existing testing structure:

Core:
* DataHandlerTest::canCreateTtContent
** Regular\Modify\ActionTest::createContents
* DataHandlerTest::canLocalizeTtContent
** Regular\Modify\ActionTest::localizeContent
* DataHandlerTest::canCopyPasteTtContent
** Regular\Modify\ActionTest::copyPasteContent
* DataHandlerTest::canCutPasteTtContent
** Regular\Modify\ActionTest::movePasteContentToDifferentPage
* IRRE\MtoNMMAsymetricLocalizationKeepTest::*
** IRRE\CSV\Modify\ActionTest::localizeParentContent*
** IRRE\ForeignField\Modify\ActionTest::localizeParentContent*
* IRRE\MtoNMMAsymetricLocalizationSelectTest::*
** IRRE\CSV\Modify\ActionTest::localizeParentContent*
** IRRE\ForeignField\Modify\ActionTest::localizeParentContent*

Workspaces:
* IRRE\MToNMMTest::*
** ManyToMany\Modify\ActionTest::*
** ManyToMany\Publish\ActionTest::*
** ManyToMany\PublishAll\ActionTest::*
* IRRE\OneToNCSVTest::*
** IRRE\CSV\Modify\ActionTest::*
** IRRE\CSV\Publish\ActionTest::*
** IRRE\CSV\PublishAll\ActionTest::*
* IRRE\OneToNForeignFieldTest::*
** IRRE\ForeignField\Modify\ActionTest::*
** IRRE\ForeignField\Publish\ActionTest::*
** IRRE\ForeignField\PublishAll\ActionTest::*

Resolves: #58870
Releases: 6.2
Change-Id: I0c75fcf826d05f8515a5609cb00c153992ba7b44
Reviewed-on: https://review.typo3.org/30177
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Extend DataHandler IRRE functional tests 76/30176/3
Oliver Hader [Fri, 16 May 2014 11:40:33 +0000 (13:40 +0200)]
[TASK] Extend DataHandler IRRE functional tests

Extend CSV and ForeignField test with
* copyParentContentToDifferentPage
* modifyHotelChild

Resolves: #58854
Releases: 6.2
Change-Id: Iba332ccee1728bf1e28ff5719029b6ab73a30c53
Reviewed-on: https://review.typo3.org/30176
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Unify DataHandler test structure 75/30175/2
Oliver Hader [Fri, 16 May 2014 11:23:31 +0000 (13:23 +0200)]
[TASK] Unify DataHandler test structure

Resolves: #58868
Releases: 6.2
Change-Id: I0f5aeb1d211e542cb323fba11b07a0b8be7d3ed0
Reviewed-on: https://review.typo3.org/30175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong system requirements link 50/30150/3
Markus Klein [Thu, 15 May 2014 17:08:06 +0000 (19:08 +0200)]
[BUGFIX] Wrong system requirements link

Resolves: #58842
Releases: 6.2, 6.1
Change-Id: Ibaf87d32778349d5a87009bcd2b365447e6488fa
Reviewed-on: https://review.typo3.org/30150
Reviewed-by: Johannes Kasberger
Tested-by: Johannes Kasberger
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Wrong path reference for installToolPassword option 27/30027/4
Markus Klein [Mon, 12 May 2014 17:01:02 +0000 (19:01 +0200)]
[BUGFIX] Wrong path reference for installToolPassword option

The [BE][installToolPassword] contains a suggestion to additionally
protect the Install Tool by protecting its folder by some server means.
The path specified is the legacy path /typo3/install/ which is only
a redirect to typo3/sysext/install/Start/, so the protection should
be on that folder.

Resolves: #58720
Releases: 6.2
Change-Id: I593b54878d0be7bd0307a6a5625173e6bbc58fa0
Reviewed-on: https://review.typo3.org/30027
Reviewed-by: Christian Ludwig
Tested-by: Christian Ludwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Restore registers before early returns 80/28280/3
Jo Hasenau [Tue, 11 Mar 2014 22:34:04 +0000 (23:34 +0100)]
[BUGFIX] Restore registers before early returns

Having an empty image list or a list of images with empty values
will not restore the loaded registers.
So we must restore the registers before any return.

Additionally, the $conf array does not need to contain any
values when calling RESTORE_REGISTER, since it won't handle
parameters anyway, so parameters would just waste memory.

Resolves: #56796
Releases: 6.2
Change-Id: I3e81c614b5c37a14da4b97e18a310e202ae7b766
Reviewed-on: https://review.typo3.org/28280
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Don't rely on not found database records impexp 93/29993/3
Marc Bastian Heinrichs [Fri, 9 May 2014 16:51:45 +0000 (18:51 +0200)]
[BUGFIX] Don't rely on not found database records impexp

The function exec_SELECTgetSingleRow could also return
FALSE in addition to NULL, so add a additional check.

Resolves: #58688
Resolves: #57348
Releases: 6.2
Change-Id: Ic04071f67f02cce12b11c34d46c084bc28ccc83a
Reviewed-on: https://review.typo3.org/29993
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] MM relations are not correctly resolved in Backend view 37/30037/2
Oliver Hader [Tue, 13 May 2014 08:19:58 +0000 (10:19 +0200)]
[BUGFIX] MM relations are not correctly resolved in Backend view

DataPreprocessor is taking care of preparing data for the form
view processed in the FormEngine. However, MM relations are not
correctly resolved in a workspace context.

The method DataPreprocessor::getDataIdList() is used for a mixed
kind of relations there, without properly applying the differences
for MM records. The rule is, to always use the live default id,
except for MM relations - use the specific workspace value.

Resolves: #58735
Releases: 6.2
Change-Id: I256969adb46bfea80681160e2901387a8c7c9a7d
Reviewed-on: https://review.typo3.org/30037
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Invalid module token in openid wizard 26/30026/2
Markus Klein [Mon, 12 May 2014 16:54:56 +0000 (18:54 +0200)]
[BUGFIX] Invalid module token in openid wizard

Fix the double htmlspecialchars call by removing the one
in the controller. Fluid does it anyway.

Resolves: #58719
Releases: 6.2
Change-Id: I1a62c41b94150494e429cec913eb43e1ec3f7ca8
Reviewed-on: https://review.typo3.org/30026
Reviewed-by: Mathias Brodala
Tested-by: Mathias Brodala
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Sprite icons not shown 46/30046/2
Frans Saris [Tue, 13 May 2014 11:56:40 +0000 (13:56 +0200)]
[BUGFIX] Sprite icons not shown

If first hit after clearing cache was not in BE context
some icons are not part of the sprite css.

This patch makes sure that these icons are registered
in every context.

Releases: 6.2
Resolves: #58758
Change-Id: I4c44c0f241f096c15e8257975b665ec89b60d2e4
Reviewed-on: https://review.typo3.org/30046
Reviewed-by: Fabien Udriot
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Category tab not shown for file when filemetadata installed 45/29945/5
Frans Saris [Thu, 8 May 2014 16:02:08 +0000 (18:02 +0200)]
[BUGFIX] Category tab not shown for file when filemetadata installed

As a result of the TCA caching changes the order of
the manipulations done in the sys_file_metadata TCA
have changed. As a result the categories tab disappears
when you install ext:filemetadata.

This patch ads an extra check in the TCA override and
adds the categories tab when sys_file_metadata is categorized.

Resolves: #58620
Releases: 6.2
Change-Id: I75c7d7ccf40d5a2cc200c7d0a4e69f674024f628
Reviewed-on: https://review.typo3.org/29945
Reviewed-by: Jan Kiesewetter
Tested-by: Jan Kiesewetter
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Remove failing extension installations 23/29123/12
Nicole Cordes [Wed, 2 Apr 2014 19:13:55 +0000 (21:13 +0200)]
[BUGFIX] Remove failing extension installations

This patch takes care about removing extracted extension folders if an
installation fails. For new extensions the folder is simply removed, for
already existing ones a backup in typo3temp is done before the
installation process and restored if anything fails.

Resolves: #57606
Releases: 6.2
Change-Id: If6f251ebc5950aecfcdb97d722146d95cb7cfa74
Reviewed-on: https://review.typo3.org/29123
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] DataProviderContext uses wrong member field in setter 28/30028/2
Tim Schreiner [Mon, 12 May 2014 17:21:19 +0000 (19:21 +0200)]
[BUGFIX] DataProviderContext uses wrong member field in setter

Resolves: #58731
Releases: 6.2
Change-Id: Ic3c5417d19b165009ae500a19b565569e2d8b2b2
Reviewed-on: https://review.typo3.org/30028
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Update to phpunit 4.1 84/29584/6
Christian Kuhn [Sun, 20 Apr 2014 12:46:13 +0000 (14:46 +0200)]
[TASK] Update to phpunit 4.1

Do not forget to "composer update" test instances!

Updating from phpunit 3.7 to 4.1 is smooth, except two details:

* The mock framework dropped staticExpects, two test cases must
  be refactored to circumvent this.

* The mocker now tries to resolve method argument type hints, so
  those classes must exist and autoloaded, some FLOW dependencies
  are affected here.

Change-Id: Ie74bdad000182dde808d3771fa6eec4764a133da
Resolves: #58676
Releases: 6.2
Reviewed-on: https://review.typo3.org/29584
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel