Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Fix incomplete mocking in several tests 66/28666/2
Helmut Hummel [Sun, 23 Mar 2014 13:23:03 +0000 (14:23 +0100)]
[BUGFIX] Fix incomplete mocking in several tests

IndexerServiceTest and ExtensionManagementServiceTest
both execute emit signal methods which in turn
try to instantiate the SignalSlotDispatcher,
which can fail.

Resolve this by mocking these methods.

Resolves: #57206
Releases: 6.2
Change-Id: I0a239abeb7c94839a413870c58f22ae59fed8470
Reviewed-on: https://review.typo3.org/28666
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix position of search field clearer in extension manager. 59/28659/2
Jost Baron [Sun, 23 Mar 2014 09:59:21 +0000 (10:59 +0100)]
[BUGFIX] Fix position of search field clearer in extension manager.

The jquery plugin is not a real external contribution, but was written
specifically for TYPO3, so modifying it in the contrib-folder should be
ok.

Change-Id: I263d827b8e08a83c345b3525c53124483eba5620
Resolves: #57051
Releases: 6.2
Reviewed-on: https://review.typo3.org/28659
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Protect Ajax calls of core extensions 54/28654/3
Helmut Hummel [Sun, 23 Mar 2014 00:13:30 +0000 (01:13 +0100)]
[TASK] Protect Ajax calls of core extensions

All core extensions need to benefit from
the new Ajax API and will be CSRF protected by that.

Resolves: #57196
Releases: 6.2
Change-Id: I8f6f45fc9426a0e9ae15e61670f52b7cf9f461af
Reviewed-on: https://review.typo3.org/28654
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Localized labels for EM options 64/28664/2
Francois Suter [Sun, 23 Mar 2014 11:43:12 +0000 (12:43 +0100)]
[TASK] Localized labels for EM options

Make all system extensions use localized labels for their
configuration options, to make the TYPO3 BE better
translatable.

Resolves: #57203
Releases: 6.2
Change-Id: I6dcbfc6477ba32037595dbef20d630f6294dde0b
Reviewed-on: https://review.typo3.org/28664
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Ensure backwards compatibility in element browser 18/28618/2
Helmut Hummel [Fri, 21 Mar 2014 18:34:14 +0000 (19:34 +0100)]
[BUGFIX] Ensure backwards compatibility in element browser

Hooks that used the element browser used the JavaScript
function jumpToUrl with relative URLs.

After refactoring the element browser, it was necessary
to compute the absolute URL.

To stay backwards compatible we catch this case
in JavaScript and rewrite the URL according
to the new requirements.

By doing so, we can simplify our code again.

The method getThisScript might still be needed in
Hooks for other purposes, so we make it public.

Resolves: #56721
Releases: 6.2
Change-Id: Ieed6d037b428c5c15d18905341ff46dece1d67a7
Reviewed-on: https://review.typo3.org/28618
Reviewed-by: Ernesto Baschny
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Option labels not translated anymore 57/28657/2
Francois Suter [Sun, 23 Mar 2014 09:46:11 +0000 (10:46 +0100)]
[BUGFIX] Option labels not translated anymore

The configuration options labels are not translated anymore
in the Extension Manger.

This is due to a recent refactoring, which encapsulated
the translation process in a separate method,
but forgot to return the translated value.

Resolves: #57198
Releases: 6.2
Change-Id: Ib0051225860c408b00827bf7212835beafbbd2fa
Reviewed-on: https://review.typo3.org/28657
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Followup to "Cleanup Ajax URL inline settings" 58/28658/2
Stefan Neufeind [Sun, 23 Mar 2014 09:57:23 +0000 (10:57 +0100)]
[TASK] Followup to "Cleanup Ajax URL inline settings"

commit 7ccbb22f3c28b38ed6879d0c768b0424a2253276
added ajaxUrls to TYPO3.settings. The functional test
needs to be adapted accordingly

Change-Id: I24267feaab39f0260db934e2151f33c948036080
Resolves: #57096
Releases: 6.2
Reviewed-on: https://review.typo3.org/28658
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Module Menu throws PHP warning for top level menu items 39/28639/3
Benjamin Mack [Sat, 22 Mar 2014 12:53:56 +0000 (13:53 +0100)]
[BUGFIX] Module Menu throws PHP warning for top level menu items

When rendering the module menu icons, the menu items
on the top level (Web, File, User, Admin) don't have an icon,
however the getModuleIcon functionality processes them,
and checks for getimagesize() even though no image is added.

To overcome this, the function needs to be modified slightly to
only call getimagesize if there is actually an icon.

Releases: 6.2, 6.1
Resolves: #57179
Change-Id: Icb45d53a3a61d308b5ff56612f1b9b9b54245a53
Reviewed-on: https://review.typo3.org/28639
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Cleanup Ajax URL inline settings 02/28602/5
Helmut Hummel [Fri, 21 Mar 2014 12:27:08 +0000 (13:27 +0100)]
[TASK] Cleanup Ajax URL inline settings

This change streamlines the use of Ajax URLs
by auto-publishing all Ajax URLs to JavaScript
inline settings.

All Ajax URLs can now also be looked up in
JavaScript by providing the AjaxID like that:

var ajaxUrl = TYPO3.settings.ajaxUrls['TxMyExt::process'];

All code has been adapted to reflect this change.

Resolves: #57096
Documentation: #56347
Releases: 6.2
Change-Id: I4a441f51dcb3551874082077c52918b3fc6a9b0f
Reviewed-on: https://review.typo3.org/28602
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Do not load LocalConfiguration in unit test bootstrap 91/28491/3
Christian Kuhn [Tue, 18 Mar 2014 12:28:36 +0000 (13:28 +0100)]
[BUGFIX] Do not load LocalConfiguration in unit test bootstrap

The patch removes loadConfigurationAndInitialize() from unit test
bootstrap and substitutes it with some more fine grained bootstrap
calls. In effect, the instance specific LocalConfiguration.php is
no longer loaded and removes another depencency from unit tests
to the instance.

Change-Id: Ia6591fe8d40d530558a514832c8d649c46b4ccc9
Resolves: #57035
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28491
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Tests: Remove some useless tests 44/28644/4
Christian Kuhn [Sat, 22 Mar 2014 17:55:00 +0000 (18:55 +0100)]
[BUGFIX] Tests: Remove some useless tests

Some tests of GeneralUtility depend on LocalConfiguration
settings and can not easily be mocked in a sane way. They
are also not very helpfull and the functionality tested is
unlikly to break. They are removed for now.

Change-Id: Ic162e950d4df75e1b8aea63a6c547139efabdf15
Resolves: #57185
Related: #51436
Related: #57035
Releases: 6.2
Reviewed-on: https://review.typo3.org/28644
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Remove db setup from .travis.yml 45/28645/2
Christian Kuhn [Sat, 22 Mar 2014 18:29:42 +0000 (19:29 +0100)]
[TASK] Remove db setup from .travis.yml

With proper mocking in place we no longer need an
initialized database to run unit tests.

Change-Id: I3913186540bbd1b1419c37132cddaaa34ea9ca34
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28645
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Fix duplicated array keys in tests 41/28641/2
Tymoteusz Motylewski [Sat, 22 Mar 2014 13:47:24 +0000 (14:47 +0100)]
[TASK] Fix duplicated array keys in tests

In few tests dataproviders have duplicated array keys,
which results in some cases not being tested.
This patch removes duplicated entries and changes array
key names where needed.

Resolves: #57180
Releases: 6.2
Change-Id: I68ea38f89ed7f304b57165ca1d225ffdbe2a7a15
Reviewed-on: https://review.typo3.org/28641
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] EM: Split Distributions in official and community-based packages 40/28640/4
Benjamin Mack [Sat, 22 Mar 2014 13:31:02 +0000 (14:31 +0100)]
[TASK] EM: Split Distributions in official and community-based packages

The output of the distributions should be handled for the introduction
package and all other packages.

As there is no distinction between official (published by the Core Team)
and community-based distributions, the check is done via the username
for now, but could be easily modified in one place.

Releases: 6.2
Resolves: #57181
Change-Id: I8f2584532dda4738c66bd27e69743bcff91bc422
Reviewed-on: https://review.typo3.org/28640
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove not needed autoload registry of form 43/28643/2
Helmut Hummel [Sat, 22 Mar 2014 15:36:53 +0000 (16:36 +0100)]
[TASK] Remove not needed autoload registry of form

The autoload registry entry of the form wizard
is superfluous now, so remove it.

Resolves: #57184
Releases: 6.2
Change-Id: Icc9e7a4791c5a2be95923f2e8bcad980dac611e8
Reviewed-on: https://review.typo3.org/28643
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.2-dev 27/28627/2
TYPO3 Release Team [Sat, 22 Mar 2014 01:58:09 +0000 (02:58 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I218e938c33a34c74ebd0b0720c35cd00b83d2605
Reviewed-on: https://review.typo3.org/28627
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0rc1 26/28626/2 TYPO3_6-2-0rc1
TYPO3 Release Team [Sat, 22 Mar 2014 01:57:34 +0000 (02:57 +0100)]
[RELEASE] Release of TYPO3 6.2.0rc1

Change-Id: I3a9e09d95b86395258b32924625ed48e316b236b
Reviewed-on: https://review.typo3.org/28626
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[!!!][BUGFIX] Cast negative int to boolean (true) in BooleanNode 84/26784/9
Alexander Schnitzler [Mon, 13 Jan 2014 13:52:56 +0000 (14:52 +0100)]
[!!!][BUGFIX] Cast negative int to boolean (true) in BooleanNode

Currently Fluid treats negative integers as false which
results in <f:if condition="-9"> rendering else instead
of then.

When casting integers to boolean using php all integers
other than 0 (zero) are casted to true, just 0 results in
false. Therefore, casting of BooleanNode::convertToBoolean
must be adjusted to act like plain php.

This bugfix is a breaking change as people might have
deliberately used the wrong behaviour.

Releases: 6.2
Resolves: #54243
Resolves: #33597
Change-Id: Iebaa578cf071909610ca0e1abfc9bfaad7459231
Reviewed-on: https://review.typo3.org/26784
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Invalid relations of MM records in workspaces 24/28624/4
Oliver Hader [Fri, 21 Mar 2014 21:11:58 +0000 (22:11 +0100)]
[BUGFIX] Invalid relations of MM records in workspaces

The basic problem with MM (ManyToMany) relations in workspaces is
that the intermediate table (MM table) does not have any
information about actually being a reference in a particular
workspace - there is no "t3ver_wsid" field. Thus, the meaning of
a relation needs to be determined from the entities on both sides
of the relation. The following is possible:

* both sides are live -> valid in live only
* exactly one side is versioned -> valid in a workspace only
* both sides are versioned -> valid in a workspace only

The difficulties now start with versioning one side first and
after some time the other side - thus the relation with exactly
one version and one live entity needs to be turned into an entry
pointing to both versions.

Resolves: #57169
Releases: 6.2
Change-Id: Idb043d520c30f15e85d54a016e52690f5f05cedc
Reviewed-on: https://review.typo3.org/28624
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Invalid relations of IRRE records in workspaces 74/27774/16
Oliver Hader [Mon, 17 Mar 2014 13:47:43 +0000 (14:47 +0100)]
[BUGFIX] Invalid relations of IRRE records in workspaces

* general -> always use live id as pointer value
* create records -> automatically fill placeholder pointers
* copy records -> currently leads to problems with sorting
* move records -> follow and create child move placeholders
* delete records -> forward delete data in copy(!) process
* ReferenceIndex needs to hold the most specific relations
  since the CommandMap handler is based on this information
* ReleationHandler is extended for IRRE references to fetch
  the live default parent pointer automatically (this new
  behaviour can be disabled by public methods for each
  RelationHandler instance)
* The method version_swap_procBasedOnFieldType of the version
  DataHandlerHook is completely removed since IRRE records are
  now referenced using the live default parent pointer value
* UserTSconfig property options.workspaces.swapMode is set
  to "pages" per default - thus, if a page gets published all
  accordant records on that page are published as well

Resolves: #56376
Releases: 6.2
Change-Id: I75248d10b000de73ca623770f07e8c2e89d4cdd8
Reviewed-on: https://review.typo3.org/27774
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[FEATURE] Enable queries using "root" and "-1" for pidInList 23/28623/5
Oliver Hader [Fri, 21 Mar 2014 22:13:57 +0000 (23:13 +0100)]
[FEATURE] Enable queries using "root" and "-1" for pidInList

The version preview in the frontend rendering process basically
selects only the live versions and then overlays those records
with possible versions. Since the MM handling is changed to
directly point to the most specific version in that regard (this
is an exception to the "always live, overlay then" approach), the
versions also need to be selected directly. ContentObjectRenderer
uses the method PageRepository::enableFields() which adds an
additional SQL WHERE part, like " AND tablename.pid<>-1" to
exclude possible versions.

Besides that, elements (like sys_catagory) that are stored on the
root-level cannot be queried at all which leads to custom code in
the end just to perform these queries.

This change allows selections on the root-level and disables the
"pid<>-1" constraint if the opposite has been defined in the
pidInList property.

Example:
select.pidInList = root,-1

Resolves: #57168
Documentation: #57171
Releases: 6.2
Change-Id: I6fb91f89f70614d59c83d808f07e890833248880
Reviewed-on: https://review.typo3.org/28623
Reviewed-by: Ernesto Baschny
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Re-added the 1-2-3 bullets in the Step Installer 25/28425/4
Ernesto Baschny [Wed, 12 Mar 2014 18:36:04 +0000 (19:36 +0100)]
[TASK] Re-added the 1-2-3 bullets in the Step Installer

Resolves: #56941
Releases: 6.2
Change-Id: I5dfabf2c5df8c495fbdce30cb170260d2656e6b4
Reviewed-on: https://review.typo3.org/28425
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Mandatory for Selectbox with TCA not possible 69/27169/4
Benjamin Mack [Thu, 30 Jan 2014 20:30:53 +0000 (21:30 +0100)]
[BUGFIX] Mandatory for Selectbox with TCA not possible

It's not possible to create a backend selectbox
that is mandatory with only 1 item selectable.

Releases: 6.2, 6.1
Resolves: #24925
Resolves: #24871
Change-Id: Idaef6475f61c70cd8c3f6074ccd0b0195d90c581
Reviewed-on: https://review.typo3.org/27169
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Hide "new page buttons" for users who can't create new pages 64/28464/7
Georg Ringer [Tue, 18 Mar 2014 09:41:59 +0000 (10:41 +0100)]
[BUGFIX] Hide "new page buttons" for users who can't create new pages

There are 2 icons in the New Element wizard which should not belong there
and get the user into a blank page if the user got no access to create
page records.

- in the toolbar: icon to create a new page
- in the wizard: icon to create new page

Change-Id: I5ab638f17eebfc740ab64dd57ce655681552f901
Resolves: #56992
Releases: 6.2
Reviewed-on: https://review.typo3.org/28464
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Manipulation of file field migration config 60/23360/4
Alexander Stehlik [Thu, 27 Feb 2014 08:57:05 +0000 (09:57 +0100)]
[BUGFIX] Manipulation of file field migration config

This patch introduces new methods to the FrontendContentAdapterServer
that allow the manipulation of the file field migration configuration.
It is now possible to add additional (content) types for which the
migration should be active and to add custom migration configurations.

Releases: 6.2
Resolves: #46067
Documentation: #56365
Change-Id: Ibc23be8a414192c8795d9bb4f09316cf608e240b
Reviewed-on: https://review.typo3.org/23360
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Tom Peters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Backport Flow JsonView 42/27642/4
Jan Kiesewetter [Sun, 16 Feb 2014 14:38:12 +0000 (15:38 +0100)]
[TASK] Backport Flow JsonView

Change-Id: Ia750e9997bb69b00652a6cc30dd3442574c0b97b
Resolves: #56007
Releases: 6.2
Reviewed-on: https://review.typo3.org/27642
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Speed up page ID resolving in Extbase BE 43/27243/6
Benjamin Mack [Sat, 1 Feb 2014 21:41:22 +0000 (22:41 +0100)]
[TASK] Speed up page ID resolving in Extbase BE

Extbase does some simple calls to determine the
page ID of the current request, and does not cache it.

This costs some mySQL calls, which are unneeded
once the current page ID is found. The page ID is
now stored in the ConfigurationManager to retrieve
with a simple runtime cache.

Resolves: #55566
Resolves: #57125
Releases: 6.2
Change-Id: Id5fe4a25591c77ce8a81cefa018a04e803ba7e8a
Reviewed-on: https://review.typo3.org/27243
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Support for static table titles in new record wizard 10/28510/4
Nicole Cordes [Tue, 18 Mar 2014 20:01:33 +0000 (21:01 +0100)]
[BUGFIX] Support for static table titles in new record wizard

With a static table name the extension key is not updated which sets a
wrong table title for the extension before. This patch resolves table
title from configuration with a fallback to table name part and sets
group name and extension key. This helps to prevent any conflict between
different extensions.

Resolves: #23478
Releases: 6.2
Change-Id: I5f33b0a9ab616256f0b328a6d7c793677213531b
Reviewed-on: https://review.typo3.org/28510
Reviewed-by: Vladimir Podkovanov
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Reduce length of identifier key in sys_file_processedfile 22/28622/2
Nicole Cordes [Fri, 21 Mar 2014 21:13:34 +0000 (22:13 +0100)]
[BUGFIX] Reduce length of identifier key in sys_file_processedfile

To support a smooth upgrade from a 6.0 or 6.1 system, we have to reduce
the length if the identifier field for the key "identifier".

Resolves: #57002
Releases: 6.2
Change-Id: Ic5928ceae1f288cfb3005ad271e493f356679c82
Reviewed-on: https://review.typo3.org/28622
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FlashMessage styles missing in Reports module 20/28620/6
Wouter Wolters [Fri, 21 Mar 2014 20:02:36 +0000 (21:02 +0100)]
[BUGFIX] FlashMessage styles missing in Reports module

When deleting the deprecation log file a not styled flash
message is shown afterwards. This is fixed by setting
renderMode to div.

Resolves: #57162
Releases: 6.2
Change-Id: I4ccc3620b008cd765b8fb1d124957e66aee448b5
Reviewed-on: https://review.typo3.org/28620
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Fetch folder and environment status through AJAX 19/28619/6
Wouter Wolters [Fri, 21 Mar 2014 18:42:31 +0000 (19:42 +0100)]
[TASK] Fetch folder and environment status through AJAX

Resolves: #57166
Releases: 6.2
Change-Id: I72aa55cff3322bbe46d271758fd04f3aba860ae7
Reviewed-on: https://review.typo3.org/28619
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[FEATURE] Save current workspace in ReferenceIndex 72/28472/4
Oliver Hader [Mon, 17 Mar 2014 14:08:15 +0000 (15:08 +0100)]
[FEATURE] Save current workspace in ReferenceIndex

To reduce queries to accordant relations saved in the reference
index, add the current workspace that is used. This information
will be used later during publishing nested record sets (e.g.
for Inline Relational Record Editing).

Resolves: #56977
Releases: 6.2
Change-Id: I92851e243581a525bb99fafc9ed656fd613eeb82
Reviewed-on: https://review.typo3.org/28472
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Workspace toolbar styling fix (UL) 91/28591/4
Eric Chavaillaz [Fri, 21 Mar 2014 08:12:24 +0000 (09:12 +0100)]
[BUGFIX] Workspace toolbar styling fix (UL)

When you open the workspace toolbar, the bullets
of the list are shown. It should not.

Resolves: #57114
Related: #55819
Releases: 6.2
Change-Id: Ia58ddd1cd8005d6e2410c04e28a2a7b2111665c4
Reviewed-on: https://review.typo3.org/28591
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor install tool enable file checks 24/28524/12
Pascal Dürsteler [Wed, 19 Mar 2014 14:50:08 +0000 (15:50 +0100)]
[TASK] Refactor install tool enable file checks

As annotated in the files, a refactoring is made to
remove duplicated code.

Resolves: #57072
Releases: 6.2
Change-Id: Idef2c3c194aa1659603c8b6bcc0a515ccff13a23
Reviewed-on: https://review.typo3.org/28524
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[FEATURE] Introduce shadowColumnsForMovePlaceholders property 73/28473/6
Oliver Hader [Mon, 17 Mar 2014 13:52:04 +0000 (14:52 +0100)]
[FEATURE] Introduce shadowColumnsForMovePlaceholders property

$TCA[<table>]['ctrl']['shadowColumnsForMovePlaceholders'] behaves
similar to shadowColumnsForNewPlaceholders but is only used for
move placeholders.

If shadowColumnsForMovePlaceholders is not defined in particular
for a table, but shadowColumnsForNewPlaceholders is defined,
then that value is used as a fallback - since that property
existed for a longer time already.

Resolves: #56994
Documentation: #56749
Releases: 6.2
Change-Id: Icdbd35234efae8162cfb2dc15a2838acd22370b1
Reviewed-on: https://review.typo3.org/28473
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Added .sass-cache to .gitignore 17/28617/2
Ernesto Baschny [Fri, 21 Mar 2014 18:32:07 +0000 (19:32 +0100)]
[TASK] Added .sass-cache to .gitignore

Releases: 6.2
Change-Id: I3278984b1a7aa4ee704b9568f01d3ff3edf94da9
Reviewed-on: https://review.typo3.org/28617
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[SECURITY] Implement Click Jacking Protection 01/28601/3
Helmut Hummel [Fri, 21 Mar 2014 11:54:13 +0000 (12:54 +0100)]
[SECURITY] Implement Click Jacking Protection

To protect the backend from click jacking attacks
a HTTP header needs to be sent, which prevents
embedding backend pages in an iframe on domains
different than the one used to access the backend.

All recommended browsers respect this header
and prevents the backend page to be shown in an
iframe, so we do not need to implement further
JavaScript frame busting solutions.

Resolves: #54201
Documentation: #57144
Releases: 6.2
Change-Id: Ic83cae4917bb62ff8fe8b55a947ace7dba86d223
Reviewed-on: https://review.typo3.org/28601
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[!!!][SECURITY] Allow first install only with FIRST_INSTALL file 12/28612/5
Helmut Hummel [Thu, 27 Feb 2014 14:09:23 +0000 (15:09 +0100)]
[!!!][SECURITY] Allow first install only with FIRST_INSTALL file

It was previously possible to access the install tool
by using a specially crafted URL, which caused
the install tool enable file check to fail.

As there was no easy solution to solve this issue,
we now introduce the need to create a file on first
install.

So in the installation directory the following must
be present:

d typo3
f index.php
f FIRST_INSTALL

After the installation the file will be removed.

Resolves: #55387
Releases: 6.2
Change-Id: I583581f18b939ba032950451bab17ac20131683b
Reviewed-on: https://review.typo3.org/28612
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Allow FrontendContentAdapter to be disabled 07/26807/9
Steffen Ritter [Tue, 14 Jan 2014 13:34:14 +0000 (14:34 +0100)]
[TASK] Allow FrontendContentAdapter to be disabled

The FrontendContentAdapter transforms tt_content and pages records
within cObject to the format which they have been stored in in pre
6.x installations, so probably existing legacy TypoScript config
can deal with the same data.

This patchset introduces an AllConfiguration flag allowing to disable
that service. For new installations the service is disabled by default,
upgrading installations have the service enabled.

Resolves: #54979
Releases: 6.2
Change-Id: I254f5c170c3e6a9f5ee214c0fe0e7a58e080cf34
Reviewed-on: https://review.typo3.org/26807
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Form Wizard styling fix (UL/OL) 85/28585/2
Ernesto Baschny [Thu, 20 Mar 2014 23:06:24 +0000 (00:06 +0100)]
[BUGFIX] Form Wizard styling fix (UL/OL)

Resolves: #57126
Related: #55810
Releases: 6.2
Change-Id: Iea0e324b6942ec90a8da387a28ff0e7d926d63f8
Reviewed-on: https://review.typo3.org/28585
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Test follow-up to #57152 11/28611/2
Christian Kuhn [Fri, 21 Mar 2014 16:12:06 +0000 (17:12 +0100)]
[BUGFIX] Test follow-up to #57152

Fix a failing unit test after change c23414d5a73

Change-Id: I427663a1a528b24a0e63d2fc9ed2a6371902a4f4
Resolves: #57159
Related: #57152
Releases: 6.2
Reviewed-on: https://review.typo3.org/28611
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[CLEANUP] Cleanup code style in PageLayoutView 95/25295/15
Markus Klein [Tue, 12 Nov 2013 01:14:34 +0000 (02:14 +0100)]
[CLEANUP] Cleanup code style in PageLayoutView

* Cleanup code style
* Fix code issues like forgotten return values

Resolves: #53539
Releases: 6.2
Change-Id: Iec21bbb118d15e46bb464389d6a7bf3661b007a5
Reviewed-on: https://review.typo3.org/25295
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Mitigate race condition on cache flush 94/28594/2
Helmut Hummel [Fri, 21 Mar 2014 10:05:09 +0000 (11:05 +0100)]
[BUGFIX] Mitigate race condition on cache flush

When file caches are flushed, the cache directory
is also deleted.

Now when a second request comes in and creates
the caches it happens that the cache directory of
a given cache is still there for this cache when
calling setCache in the SimpleFileBackend,
but is deleted by the first request afterwards.

Now the cache directory for the second request
does not exist and setting cache entries will fail.

Mitigate this by immediately recreating
the cache directory.

Resolves: #57136
Releases: 6.2
Change-Id: I3c4c5c63c6c754447549285d9718798272f9e585
Reviewed-on: https://review.typo3.org/28594
Reviewed-by: Ernesto Baschny
Reviewed-by: Thomas Maroschik
Reviewed-by: Pascal Dürsteler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] First install lists directory errors 05/28605/4
Ernesto Baschny [Fri, 21 Mar 2014 14:00:44 +0000 (15:00 +0100)]
[BUGFIX] First install lists directory errors

For a first installer the directory structure is empty and the
first step will try to create it. We do not need to show these
as errors to the user, only if the root directory cannot be
written.

To achieve this we raise "Warnings" instead (which are
not shown in first step). To keep the Folder Structure menu
item on the left menu in the Install Tool showing a red badge
for non existing directories, we change this to also include
Warnings.

Resolves: #57152
Releases: 6.2
Change-Id: Idd628ecdf946f9befdb7fefd7a9bb7bccc175c2b
Reviewed-on: https://review.typo3.org/28605
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Invalid HTML for the top toolbar in Backend 87/28587/6
Xavier Perseguers [Fri, 21 Mar 2014 10:39:59 +0000 (11:39 +0100)]
[BUGFIX] Invalid HTML for the top toolbar in Backend

Additional attributes must be concatenated with a leading blank
space in order to get valid HTML content.

Fixes: #57127
Releases: 6.2
Change-Id: Iac0cf3033af37efd8e1a8efeb777083503166c5c
Reviewed-on: https://review.typo3.org/28587
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Show clipboard if it contains elements 03/28603/3
Nicole Cordes [Fri, 21 Mar 2014 13:21:38 +0000 (14:21 +0100)]
[BUGFIX] Show clipboard if it contains elements

On empty pages no page content is rendered at all. This patch brings the
clipboard back, if it contains elements so you can check those on the
empty pages. Besides the drawFooterHook is shown again on empty pages.
this isn't set in the core itself and extension authors should be able
to choose if the content should be visible on empty pages.

Resolves: #57062
Releases: 6.2
Change-Id: Ie7bd6fda730e801b285d7876a1eff39c3ba1eff0
Reviewed-on: https://review.typo3.org/28603
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Rename escapeJsValue and make it context specific 71/28571/4
Jigal van Hemert [Thu, 20 Mar 2014 14:05:55 +0000 (15:05 +0100)]
[TASK] Rename escapeJsValue and make it context specific

The stdWrap property escapeJsValue actually encodes the
content and should thus be called
encodeForJavaScriptValue. Also the value must be
enclosed in quotes to prevent it from being used outside
the target context of string values in JavaScript.

Releases: 6.2
Resolves: #57107
Documentation: #57108
Change-Id: Id5f850d36a87d71ca80eb58e3359ddacdd5b655e
Reviewed-on: https://review.typo3.org/28571
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years agoRevert "[TASK] Create new processor registry" 98/28598/2
Ernesto Baschny [Fri, 21 Mar 2014 10:49:09 +0000 (11:49 +0100)]
Revert "[TASK] Create new processor registry"

This reverts commit 077144553df1ad3000c041787f5652b3083bb798

This new interface is not being used throughout the Core,
as this was just the first step of three to complete this
functionality. So we revert and postpone this change for
the next release.

Change-Id: I5dd0e074a0026ff49b1d096ff4fd8926370aba3f
Reviewed-on: https://review.typo3.org/28598
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[FOLLOWUP] Class loader handles invalid classes 96/28596/2
Helmut Hummel [Fri, 21 Mar 2014 10:20:08 +0000 (11:20 +0100)]
[FOLLOWUP] Class loader handles invalid classes

The check if we have class information
can be simplified to !empty()

Resolves: #57117
Related: #56933
Releases: 6.2
Change-Id: I8532b26142cc39da2b9bcca9880df715da57d59e
Reviewed-on: https://review.typo3.org/28596
Reviewed-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGIFX] Improve labels in clear cache menu items 88/28588/2
Francois Suter [Fri, 21 Mar 2014 08:01:48 +0000 (09:01 +0100)]
[BUGIFX] Improve labels in clear cache menu items

With the changes introduced by the new cache grouping system, the
"Clear all cache" menu item in the clear cache menu has become
ambiguous. Labels and tooltips can be improved.

Resolves: #57128
Releases: 6.2
Change-Id: I2c723e3581605f7040f8a1cc1598053155ee80a4
Reviewed-on: https://review.typo3.org/28588
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Ludwig Rafelsberger
Reviewed-by: Stephan Großberndt
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Class loader handles information about invalid classes 77/28577/5
Markus Klein [Thu, 20 Mar 2014 18:53:19 +0000 (19:53 +0100)]
[BUGFIX] Class loader handles information about invalid classes

Resolves: #57117
Related: #56933
Releases: 6.2
Change-Id: Ie305b808b0a9b9e10b5adca4af9e2562cf5123f6
Reviewed-on: https://review.typo3.org/28577
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Move PhpInfo utility to a ViewHelper 83/28583/5
Wouter Wolters [Thu, 20 Mar 2014 21:49:53 +0000 (22:49 +0100)]
[TASK] Move PhpInfo utility to a ViewHelper

Resolves: #57124
Related: #55116
Releases: 6.2
Change-Id: I26ce6a340c06f6dfccf255b9b6c9424d9bd70efb
Reviewed-on: https://review.typo3.org/28583
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Follow up: File and folder permission check on Windows 79/28579/3
Nicole Cordes [Thu, 20 Mar 2014 19:28:55 +0000 (20:28 +0100)]
[TASK] Follow up: File and folder permission check on Windows

Install tool shows errors for file and folder permissions on Windows
system. As those are writable by default the errors should be turned
into information.

Resolves: #57118
Releases: 6.2
Change-Id: Idc9f1126916e161bcde1e48c91ada2f9846a9ef9
Reviewed-on: https://review.typo3.org/28579
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Add functional tests for impexp FlexForm fields 66/28466/3
Marc Bastian Heinrichs [Thu, 13 Mar 2014 09:54:47 +0000 (10:54 +0100)]
[TASK] Add functional tests for impexp FlexForm fields

This patch add functional tests for exporting and importing
FlexForm fields of types "group" internal_type "file" and
"file_reference" and a field with a soft reference link to a file.

Resolves: #56612
Releases: 6.2
Change-Id: Ic66257dab15ec7a2fde522be9f74170eec346877
Reviewed-on: https://review.typo3.org/28466
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix refindex for FlexForm fields type group file_reference 65/28465/3
Marc Bastian Heinrichs [Thu, 13 Mar 2014 16:56:00 +0000 (17:56 +0100)]
[BUGFIX] Fix refindex for FlexForm fields type group file_reference

According to the fixes for the normal TCA fields of type "group"
internal_type "file_reference" in #49538 and #56353, this needs also
to be fixed for the FlexForm fields: handle the internal_type
file_reference as an db reference to sys_file.

Resolves: #56991
Releases: 6.2, 6.1, 6.0
Change-Id: Ie66c86c1bf3f0386d23259d0aee6706564beace3
Reviewed-on: https://review.typo3.org/28465
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Unify use of getter for $GLOBALS['TYPO3_DB'] 78/28578/4
Xavier Perseguers [Thu, 20 Mar 2014 19:26:49 +0000 (20:26 +0100)]
[TASK] Unify use of getter for $GLOBALS['TYPO3_DB']

Resolves: #57119
Releases: 6.2
Change-Id: I9be8b51fd695e2470e22fe084eeec507fd78f6f2
Reviewed-on: https://review.typo3.org/28578
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Getters for global objects in PageLayoutView 47/25547/7
Markus Klein [Wed, 20 Nov 2013 19:28:29 +0000 (20:28 +0100)]
[TASK] Getters for global objects in PageLayoutView

Resolves: #53812
Releases: 6.2
Change-Id: I41ac63010ff245ccbd7b1c09f6ee9f42b64e79cd
Reviewed-on: https://review.typo3.org/25547
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Install Tool Improve Default File/Directory permission warnings 92/28492/3
Ernesto Baschny [Tue, 18 Mar 2014 14:19:00 +0000 (15:19 +0100)]
[TASK] Install Tool Improve Default File/Directory permission warnings

The recommended setup (660/770) should generate a green "ok" and not a
Notice. It now also includes a comment if group read/writeable about
the potential risk and if configured a hint to BE/createGroup.

Also display errors in case the configured mask does not include user
read/writeable flags.

Resolves: #57025
Releases: 6.2
Change-Id: If42d505e0b1bac10cfca1d7b76faec058989ccb2
Reviewed-on: https://review.typo3.org/28492
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Fix tests for DirectoryNodeTest 13/28513/3
Markus Klein [Tue, 18 Mar 2014 21:20:02 +0000 (22:20 +0100)]
[TASK] Fix tests for DirectoryNodeTest

The tests have not been adjusted when
http://forge.typo3.org/issues/52668
was merged.

Resolves: #57055
Releases: 6.2
Change-Id: I259c7b5462d372f3244ee4c2e89a96cef0780478
Reviewed-on: https://review.typo3.org/28513
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Use correct warning icon in time tracker 75/28575/2
Alexander Stehlik [Thu, 20 Mar 2014 17:59:05 +0000 (18:59 +0100)]
[BUGFIX] Use correct warning icon in time tracker

The icon_warning2.gif is used instead of the deleted icon_warning.gif.

Resolves: #57116
Releases: 6.2
Change-Id: I3a902a0bfb362c29e8ff6b384b844bf1f7f63cf8
Reviewed-on: https://review.typo3.org/28575
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Invalid file used to compute image ratio in text with picture 58/28558/3
Xavier Perseguers [Thu, 20 Mar 2014 11:52:57 +0000 (12:52 +0100)]
[BUGFIX] Invalid file used to compute image ratio in text with picture

Fixes: #57075
Releases: 6.2
Change-Id: Ided1204857dabf4fb15045056cc8a14010a53ae9
Reviewed-on: https://review.typo3.org/28558
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cached class loader misses are not considered 19/28419/12
Thomas Maroschik [Sat, 15 Mar 2014 12:28:51 +0000 (13:28 +0100)]
[BUGFIX] Cached class loader misses are not considered

The class loader caches if it doesn't find a class name
for subsequent calls. But currently it only checks for
NULL results from the cache and not the empty strings
returned from the cache and thus tries to resolve the
non existing class name over and over again.

The fix converts the empty string to a NULL and
changes the semantics of NULL to FALSE in the class
loader.

Fixes: #56933
Releases: 6.2
Change-Id: I4cd1a18b4a4496c287a937d6d9882ae21d3ee9a3
Reviewed-on: https://review.typo3.org/28419
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix import of type group internal_type file_reference 21/28021/6
Marc Bastian Heinrichs [Thu, 27 Feb 2014 18:31:39 +0000 (19:31 +0100)]
[BUGFIX] Fix import of type group internal_type file_reference

This patch fixes the import of fields type "group" "internal_type"
"file_reference" and adds functional tests for exporting and
importing records with fields of type "group" "internal_type"
"file" and "file_reference", the types for file handling before
introducing the File Abstraction Layer.

Resolves: #56516
Resolves: #56071
Releases: 6.2
Change-Id: I4298f27ee77a89230188aa0df1b187429d555188
Reviewed-on: https://review.typo3.org/28021
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Add SoftIndex parser typolink to link in sys_file_reference 84/28484/2
Marc Bastian Heinrichs [Mon, 17 Mar 2014 22:32:43 +0000 (23:32 +0100)]
[BUGFIX] Add SoftIndex parser typolink to link in sys_file_reference

The field "link" of the table "sys_file_reference" handles links. To
make the SoftReferenceIndex, which is used by impexp and
linkvalidator, work right, the “softref” key "typolink" should be
registered.

Resolves: #57010
Releases: 6.2, 6.1, 6.0
Change-Id: I95cb8dbfa0c6d84926cd57d1fe4e4dad93e9c21a
Reviewed-on: https://review.typo3.org/28484
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] clearCache.system does not show up 18/28518/5
Francois Suter [Wed, 19 Mar 2014 08:30:02 +0000 (09:30 +0100)]
[BUGFIX] clearCache.system does not show up

New TSconfig option clearCache.system does not work as expected
because class \TYPO3\CMS\Backend\Toolbar\ClearCacheToolbarItem
wrongly checks access to that option. Thus if only clearCache.system
is set the clear cache menu does not show up at all.

Resolves: #57064
Releases: 6.2
Change-Id: I51c9605c830a9099f21d254ae86d8d6cc430b02a
Reviewed-on: https://review.typo3.org/28518
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Named parameters in Extbase comparison queries 11/28511/6
Alexander Stehlik [Tue, 18 Mar 2014 20:28:17 +0000 (21:28 +0100)]
[BUGFIX] Named parameters in Extbase comparison queries

Instead of using unnamend parameters (?) in parseComparison() in the
Extbase Typo3DbQueryParser the matching parameter identifier will be
used for building the comparison SQL.

Additionally the non existing "$parameters" method parameter is removed
from a lot of method calls.

Resolves: #57053
Related: #55167
Releases: 6.2
Change-Id: I1123275af57e8803ecd792d65f91627cef54f501
Reviewed-on: https://review.typo3.org/28511
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Regenerate missing RTE magic image on rendering 84/27884/15
Stanislas Rolland [Wed, 26 Feb 2014 20:55:00 +0000 (15:55 -0500)]
[BUGFIX] Regenerate missing RTE magic image on rendering

Problem: Magic images inserted in RTE content may be missing,
for instance after flushing the _processed_ directory.
Solution: Regenerate any missing magic image when rendering the content
element.

Revolves: #56147
Releases: 6.2
Change-Id: Ifa156791bcd1c446c7ae61888465bb680abdf36d
Reviewed-on: https://review.typo3.org/27884
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Several typos in Page Browsing ViewHelper 58/27058/12
Benjamin Rau [Sun, 26 Jan 2014 13:00:26 +0000 (14:00 +0100)]
[BUGFIX] Several typos in Page Browsing ViewHelper

Fixing several typos and slips of the pen in the
PageBrowsing ViewHelper.

Without fixing all of them the page browsing ViewHelper
is not functional properly, that´s why i want to submit
them at once and also supply the fix for it.

That are these errors:
* Undefined but used class property prefixId
* Overwriting instead of appending content to already defined variable
* Not using UpperCamelCase for extensionName in Localization Utilty
* Accidentally using wrong variables
* Defining variable in for-loop which could be defined outside also
* Using undefined variable freeIndexUid

Resolves: #55340
Releases: 6.2, 6.1
Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800
Reviewed-on: https://review.typo3.org/27058
Reviewed-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Reviewed-by: Cedric Ziel
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Use HTTP Status 307 for all page shortcut modes 33/27933/4 33/27933/5
Christoph Dörfel [Fri, 28 Feb 2014 10:22:51 +0000 (11:22 +0100)]
[BUGFIX] Use HTTP Status 307 for all page shortcut modes

Fixes cases where the shortcut page is cached by some
devices leading to exceptions or wrong behaviour.

Resolves: #56423
Releases: 6.2
Change-Id: I71252b13320417ecffa9c28db6af9476d667d58f
Reviewed-on: https://review.typo3.org/27933
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix impexp with images in RTE and links to files 05/28105/6
Marc Bastian Heinrichs [Thu, 27 Feb 2014 18:32:55 +0000 (19:32 +0100)]
[BUGFIX] Fix impexp with images in RTE and links to files

This patch fixes the import and export of RTE contents
including images and links to files as well as softreference
links to files (file:{uid}) and adds functional tests
for this use cases.

Resolves: #56089
Resolves: #56285
Related: #56286
Releases: 6.2
Change-Id: I29312b304d265581bf9f35bdc2692a19d2df5a93
Reviewed-on: https://review.typo3.org/28105
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Follow-up: Cleanup ext_localconf.php of sysexts 19/28519/5
Marc Bastian Heinrichs [Wed, 19 Mar 2014 08:52:12 +0000 (09:52 +0100)]
[TASK] Follow-up: Cleanup ext_localconf.php of sysexts

The Extbase implementation registrations don't have to
be initialized in BE mode only.

Resolves: #55593
Releases: 6.2
Change-Id: I78a643fba62d48734fc727d7bf78bf774e6c3ddd
Reviewed-on: https://review.typo3.org/28519
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Reviewed-by: Markus Kasten
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Catch exception in filelist when file is missing 84/28284/5
Frans Saris [Wed, 12 Mar 2014 08:48:37 +0000 (09:48 +0100)]
[BUGFIX] Catch exception in filelist when file is missing

The code responsible for rendering the thumbs belonging to a
record doesn't catch the exceptions when a file couldn't be found.

This change adds a try catch around the functions that
tries to retrieve the file and displays a flash message when
the file is missing.

Resolves: #56077
Releases: 6.2
Change-Id: Icc6550db43c8738c74fd7ea8faac6e99a54bc0f3
Reviewed-on: https://review.typo3.org/28284
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] RTE Linking with file upload fails 47/28247/4
Tymoteusz Motylewski [Tue, 11 Mar 2014 10:10:21 +0000 (11:10 +0100)]
[BUGFIX] RTE Linking with file upload fails

Catch exceptions raised when the potential target folder or
the default user upload folder does not exist.

The change  https://review.typo3.org/27323 from ticket
http://forge.typo3.org/issues/48512 should be applied
in few places more.

Resolves: #56751
Related: #48512
Releases: 6.2
Change-Id: I7446697d64a580203f8f772d4bba690542dd7cb2
Reviewed-on: https://review.typo3.org/28247
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Unify NULL default value handling 08/26408/9
Alexander Stehlik [Mon, 13 Jan 2014 10:20:06 +0000 (11:20 +0100)]
[TASK] Unify NULL default value handling

If a field is configured to allow NULL values ("eval" is set to "null")
and the default value in the TCA is explicitly set to NULL the value
will not be converted to a string.

Additionally the mode setting "useOrOverridePlaceholder" will not have
any influence any more on the default value when creating new records.

Resolves: #54412
Releases: 6.2
Documentation: #56584
Change-Id: Ica43a1af33e6f86dd042b66781acc0e9cd904cf9
Reviewed-on: https://review.typo3.org/26408
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Fix automatic core updater 93/28393/9
Markus Klein [Tue, 18 Mar 2014 22:39:24 +0000 (23:39 +0100)]
[BUGFIX] Fix automatic core updater

AbstractCoreUpdate redefines the $view member to be
a JsonView, but does not re-implement the parent methods
that rely on $view being an AbstractView.

Fix this by re-implementing the initializeHandle() method.
This method can be merged with the former initializeCoreUpdate(),
which wasn't called at all in most actions.

Resolves: #56865
Releases: 6.2
Change-Id: I85260a0e57e915ac941569cfbdde1f96cdaec5e6
Reviewed-on: https://review.typo3.org/28393
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove obsolete node in import test data header xml 96/28496/2
Marc Bastian Heinrichs [Tue, 18 Mar 2014 16:07:07 +0000 (17:07 +0100)]
[BUGFIX] Remove obsolete node in import test data header xml

Resolves: #57045
Releases: 6.2
Change-Id: I439305e5143b3c51a03befc642caf66286264679
Reviewed-on: https://review.typo3.org/28496
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Add ManyToMany copyPage functional test 88/28488/2
Oliver Hader [Tue, 18 Mar 2014 11:19:30 +0000 (12:19 +0100)]
[TASK] Add ManyToMany copyPage functional test

Add the copyPage() functional test for live and workspace.

Resolves: #57030
Releases: 6.2
Change-Id: Id9ddea21a50c449c3f2674d704c10fefb2da12ff
Reviewed-on: https://review.typo3.org/28488
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Failng Import/Export functional tests 12/28512/2
Oliver Hader [Tue, 18 Mar 2014 20:44:11 +0000 (21:44 +0100)]
[BUGFIX] Failng Import/Export functional tests

As a follow-up to issue #57046 (which fixed a bug in
sys_file_metadata pointing to sys_file_reference as
translation parent), these corrections need to be
updated in the functional test assertions as well.

Resolves: #57054
Releases: 6.2
Change-Id: I1a3d395fb4fcb1271d2684af38e5fc32a10463fc
Reviewed-on: https://review.typo3.org/28512
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Exception in Locker if typo3temp does not exist 82/28482/10
Alexander Opitz [Tue, 18 Mar 2014 11:15:05 +0000 (12:15 +0100)]
[BUGFIX] Exception in Locker if typo3temp does not exist

Follow-up to 2268f64c18b607ba39d06b1580afb0ccd786d6b1

If typo3temp does not exist, the Locker should throw an exception.
The ClassLoader needs to catch this exception and acts upon
depending on whether we are in the Installer or not.

When in the Installer, locking has to be skipped completely due to
missing typo3temp directory.

Resolves: #57008
Releases: 6.2
Change-Id: Ic595dc97826cd94d6f173b7c681194ed754ed3e0
Reviewed-on: https://review.typo3.org/28482
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix foreign_table for l10n_parent in sys_file_metadata 01/28501/2
Marc Bastian Heinrichs [Tue, 18 Mar 2014 16:40:21 +0000 (17:40 +0100)]
[BUGFIX] Fix foreign_table for l10n_parent in sys_file_metadata

Instead of sys_file_metadata sys_file_reference was configured.

Resolves: #57046
Releases: 6.2
Change-Id: I1194012cbacb0415993672338d6ac6ee0a515dc1
Reviewed-on: https://review.typo3.org/28501
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Cleanup ext_localconf.php of sysexts 86/27286/9
Benjamin Mack [Sun, 2 Feb 2014 14:58:46 +0000 (15:58 +0100)]
[TASK] Cleanup ext_localconf.php of sysexts

As TYPO3 is loading all ext_localconf.php on each call,
the existing code can be cleaned up by removing
old information, putting BE-only functionality in
TYPO3_MODE == 'BE' and install-tool only
in Install only mode.

Also, some hardcoded require_once statements are
removed.

Benefits are that FE does not need to load everything
all the time.

I haven't noticed any side-effects so far, but please
test extensively.

Resolves: #55593
Releases: 6.2
Change-Id: Ibc37e84cb2af05ddb6b227290330aad31037a018
Reviewed-on: https://review.typo3.org/27286
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Respect table mapping on caching 74/27874/8
Andreas Fernandez [Wed, 26 Feb 2014 15:51:37 +0000 (16:51 +0100)]
[BUGFIX] Respect table mapping on caching

The method analyzeFields() of DBAL's DatabaseConnection caches the
table structure. The cache always uses the real table name, ignoring
any mapping, which results in a RuntimeException:

"Could not update BLOB >>>> no WHERE clause found!"

The method now checks for a possible mapping and sets the alias
as table name.

Resolves: #56349
Releases: 6.2
Change-Id: I9599cebc8604103c3749bc142cd44b813f018a72
Reviewed-on: https://review.typo3.org/27874
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Simplify TYPO3_DB->cleanIntArray 34/28234/3
Bernhard Kraft [Mon, 10 Mar 2014 17:28:34 +0000 (18:28 +0100)]
[TASK] Simplify TYPO3_DB->cleanIntArray

Instead of iterating over the array and calling "intval" for each
element the "array_map" php function gets used.

Change-Id: I5ae699f9bc158eb0caebf1fc9ea8ebaa3cdd73ca
Resolves: #56738
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/28234
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Use language overlay for image rendering 10/28210/3
Alexander Stehlik [Mon, 10 Mar 2014 09:00:39 +0000 (10:00 +0100)]
[BUGFIX] Use language overlay for image rendering

In the image rendering TypoScript configuration of css_styled_content
the uid is removed from the references configuration of the FILES
content object.

This makes sure that the language overlay mechanism from the FILES
content object is used.

Resolves: #56712
Releases: 6.2
Change-Id: Iaea43ca006826facfba40a846da67704dd3154ea
Reviewed-on: https://review.typo3.org/28210
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Execute native prepared queries 31/28231/10
Xavier Perseguers [Mon, 10 Mar 2014 15:41:14 +0000 (16:41 +0100)]
[FEATURE] Execute native prepared queries

As TYPO3 is now using mysqli, prepared queries are natively supported
and should be used.

DBAL, however, does not yet actually use native prepared queries but
falls back to standard queries by replacing placeholders and executing
the underlying SQL query.

Change-Id: If50da6e6d27af89e01c0439bcb9d39a85615a75d
Resolves: #27372
Releases: 6.2
Reviewed-on: https://review.typo3.org/28231
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Retry request on 403 in linkvalidator 89/26489/6
Alexander Stehlik [Thu, 19 Dec 2013 13:53:11 +0000 (14:53 +0100)]
[TASK] Retry request on 403 in linkvalidator

When the linkvalidator detects a 403 error when doing a HEAD request to
an external URL it will retry the request using the GET method.

Resolves: #54513
Releases: 6.2
Change-Id: Ib36b6cbb8e981b95c348afd5a063ca4f5040de75
Reviewed-on: https://review.typo3.org/26489
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove reference to old tx_templavoila nesting tag 82/26482/4
Claus Due [Wed, 18 Dec 2013 22:08:45 +0000 (23:08 +0100)]
[TASK] Remove reference to old tx_templavoila nesting tag

This change removes a reference to the old <tx_templavoila>
nesting tag which was switched away from in TYPO3 4.7, making
section objects inside sections in flexforms, use the proper
array index path "title" instead of "tx_templavoila.title".

Releases: 6.2
Resolves: #54503
Change-Id: I4c975cf4eed127ca90ead3d7566fbc826f5b78db
Reviewed-on: https://review.typo3.org/26482
Reviewed-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Reviewed-by: Dmitry Dulepov
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[CLEANUP] Fix docheader param for Folder:addFile() 76/28476/2
Marc Bastian Heinrichs [Mon, 17 Mar 2014 17:24:45 +0000 (18:24 +0100)]
[CLEANUP] Fix docheader param for Folder:addFile()

Add missing conflictMode 'changeName'.

Releases: 6.2, 6.1, 6.0
Resolves: #57004
Change-Id: Ie5c32e96c1292dbaecc505d54240f1a7a5c720fe
Reviewed-on: https://review.typo3.org/28476
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Enrich many-to-many functional tests in live workspace 86/28486/2
Oliver Hader [Tue, 18 Mar 2014 08:39:22 +0000 (09:39 +0100)]
[TASK] Enrich many-to-many functional tests in live workspace

Resolves: #57014
Change-Id: Ib3a5688a111d3ce38c3672fad0a11b195839323d
Reviewed-on: https://review.typo3.org/28486
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Respect timezone in online Backend user list 62/28462/2
Alexander Stehlik [Mon, 17 Mar 2014 11:17:11 +0000 (12:17 +0100)]
[BUGFIX] Respect timezone in online Backend user list

To display the session timestamps in the online Backend users list
in the correct timezone the DateViewHelper will now create the
DateTime object because it already takes care of the correct timezone
handling.

Resolves: #56985
Releases: 6.2
Change-Id: I65003c3f5505f4fe96160f917131fe13a3a53416
Reviewed-on: https://review.typo3.org/28462
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Element browser doesn't use FAL info to for file dimensions 04/28404/2
Frans Saris [Fri, 14 Mar 2014 21:46:00 +0000 (22:46 +0100)]
[BUGFIX] Element browser doesn't use FAL info to for file dimensions

The dimensions of a file are fetch during indexing. These values
should be used as for remote files or certain filetype getimagesize()
will not work or give unwanted overhead.

Resolves: #56864
Releases: 6.2
Change-Id: I14ece9c0dbf414f4cb0759d3065a1c5b5782ca29
Reviewed-on: https://review.typo3.org/28404
Reviewed-by: Markus Klein
Reviewed-by: Tomita Militaru
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Tested-by: Markus Klein
5 years ago[TASK] Use queryCache in generic persistence 55/27555/12
Felix Oertel [Tue, 11 Feb 2014 17:15:17 +0000 (18:15 +0100)]
[TASK] Use queryCache in generic persistence

At the moment extbase persistence is quite slow. To some degree,
the query building is responsible for that. For each and every
query the parseQuery() and buildQuery() methods are called.

This patch introduces a query cache to store the query structure.
This way a query can be reused, even when fired with different
parameters.

* Introduce a parameterIdentifier to the comparison
In the way the extbase query object model works, it's hard to
identify an object in a way which is unique and still compre-
hensible. To ease this, an identifier is introduced.

* Move parsing to an external QueryParser
All the query parsing is now seperated from the storageBackend.
The query parsing is mostly left the way it was, it should be
re-profiled later.

* introduce cache extbase_typo3dbbackend_queries

* No more statement handling by reference
Make getStatementParts() return the query and parameters in an
array instead of handing down the parameters by reference.

* Split up parseQuery in preparsing and real parsing with caching
In every call the query has to be preparsed to determine the
identifier and extract the parameters. The identifier can then
be used to look up the query structure in the cache. If it is
not (yet) cached, Extbase will do the real parsing which takes
some more time.

* Introduce useQueryCache to querySettings
Like preparedStatements, caching the queries does not always
make sense and will spam your cache under certain conditions.
It's enabled by default and can be disabled on a per-query-
basis.

* Use named parameter's placeholders
Instead of using "?" as parameter's placeholder and relying
on the right order of parameters in the array, named place-
holders are used to ensure the correct association.

* Move unit tests around to fit the new queryParser

Resolves: #55167
Releases: 6.2
Change-Id: I517c0500cad75cae96fd739f2ff7222db80b42a5
Reviewed-on: https://review.typo3.org/27555
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Follow-up: Use prepared statements in generic persistence 42/28442/3
Marc Bastian Heinrichs [Sun, 16 Mar 2014 13:57:21 +0000 (14:57 +0100)]
[TASK] Follow-up: Use prepared statements in generic persistence

Fixes using $query->statement() without parameters.

Resolves: #56915
Resolves: #55360
Releases: 6.2
Change-Id: Ia149313f5f9f719d7dba0a21a3eb39ea4f5052e8
Reviewed-on: https://review.typo3.org/28442
Reviewed-by: Markus Klein
Reviewed-by: Dennis J
Tested-by: Dennis J
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Documentation does not initialize signal slot dispatcher 81/28481/3
Philipp Gampe [Mon, 17 Mar 2014 21:36:10 +0000 (22:36 +0100)]
[BUGFIX] Documentation does not initialize signal slot dispatcher

The documentation module does not initialize the signal slot dispatcher
in its ext_localconf.php, but rather reuses the already set variable
from another core extension.

Create the object explicitly before using it.

Resolves: #57009
Releases: 6.2
Change-Id: Ifbd3199f9cef0b2d2d6dacc4569280c5e668822c
Reviewed-on: https://review.typo3.org/28481
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Prevent Inclusion of ResourceStorage from Bootstrap 16/28416/3
Thomas Maroschik [Sat, 15 Mar 2014 11:43:38 +0000 (12:43 +0100)]
[BUGFIX] Prevent Inclusion of ResourceStorage from Bootstrap

During bootstrapping the ResourceStorage and ResourceFactory
is loaded and evaluated just because of two constants containing
signal names used in ext_localconf. This introduces unnecessary
overhead especially in eID context.

The constants have been extracted to an interface that are way
faster parsed.

Resolves: #56335
Releases: 6.2
Change-Id: I509593d2720c595fa7e4f1c9b5c63fd09fea724c
Reviewed-on: https://review.typo3.org/28416
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Implement locking in ClassLoader 80/28480/2
Alexander Opitz [Fri, 7 Mar 2014 11:37:47 +0000 (12:37 +0100)]
[BUGFIX] Implement locking in ClassLoader

After cache clearing we can run in the situation that 2 processes will
rebuild the ClassLoader cache which will lead to a non useable cache,
which produces fatals. As the data is generated more than once the load
of the server increases per request while ClassLoader cache is build.

The implemented Locking will stop this issue. Every process waits till
the first is ready and then looks if data was generated and stops re-
generating the cache.

To-Do: Make it work also for first time installation when there is
no typo3temp/ directory yet.

Resolves: #55099
Releases: 6.2
Change-Id: I9c1916b5b5860e86fe19a1fc292d8ab5a196d960
Reviewed-on: https://review.typo3.org/28480
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fields of type group file are not properly indexed 10/27310/10
Marc Bastian Heinrichs [Mon, 3 Feb 2014 22:52:43 +0000 (23:52 +0100)]
[BUGFIX] Fields of type group file are not properly indexed

If an record with a field of type "group", internal_type "file"
should be indexed in the ReferenceIndex an SQL error exception
gets thrown. So the relation to the file isn't represented in the
refindex. Thus those files are also missing in exports created
with system extension impexp.

This is caused by wrong array keys and incorrectly storing a file
relation as DB relation since merge of FAL.

Resolves: #56353
Resolves: #56352
Releases: 6.2, 6.1, 6.0
Change-Id: I78211efcb6bf3032811ef0b0e20ed7f98f9fa8fb
Reviewed-on: https://review.typo3.org/27310
Tested-by: Sebastian Fischer
Tested-by: Christian Zenker
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Ext:rtehtmlarea entry scripts cleanup 08/28208/3
Nicole Cordes [Sun, 9 Mar 2014 23:06:09 +0000 (00:06 +0100)]
[TASK] Ext:rtehtmlarea entry scripts cleanup

This patch turns all remaining RTE module scripts (mod4, mod5, mod6)
into CSRF protected wizards.

Resolves: #55674
Releases: 6.2
Change-Id: I8421ff05240f6eedcaf40c805d9dd92ea7d4c30b
Reviewed-on: https://review.typo3.org/28208
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cleanup EXT:cshmanual 03/28303/7
Wouter Wolters [Wed, 12 Mar 2014 16:48:47 +0000 (17:48 +0100)]
[BUGFIX] Cleanup EXT:cshmanual

* Removed require_once which is deprecated.
* Introduced a use-statement for GeneralUtility
* Removed TYPO3_MOD_PATH
* Links generated by make_seeAlso() were double htmlspecialchars
  encoded after security patch https://review.typo3.org/27636

Resolves: #56826
Related: #55509
Releases: 6.2
Change-Id: I8effc7c6bf9828dde4f1c69754b207864b3122ba
Reviewed-on: https://review.typo3.org/28303
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Avoid superfluous IRRE child record duplication 52/26552/4
Alexander Stehlik [Mon, 23 Dec 2013 16:47:20 +0000 (17:47 +0100)]
[BUGFIX] Avoid superfluous IRRE child record duplication

If copying a page, all records on that page will be copied to
the accordant destination page. IRRE parent-child structures
are cloned along the way as well. However, if a table (that is
defined a IRRE child) is processed before the accordant parent
record, the parent itself will duplicate its children again.
This behaviour leads to superfluous duplicates and is wrong.

A check in DataHandler::copyRecord_procBasedOnFieldType() now
ensures that records are only copied once during the accordant
DataHander copy process.

Resolves: #44795
Releases: 6.2
Change-Id: Ia1e4129432f37c0dd6bfedb5fd69394e2c244d34
Reviewed-on: https://review.typo3.org/26552
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader