Packages/TYPO3.CMS.git
14 months ago[BUGFIX] Decouple thumbnail generation from controllers 65/56765/14
Mathias Schreiber [Fri, 20 Apr 2018 19:23:35 +0000 (21:23 +0200)]
[BUGFIX] Decouple thumbnail generation from controllers

Deferred rendering of thumbnails via an external request speed up
the backend performance. This currently works in all places that use
BackendUtility::thumbsCode.

Resolves: #85605
Releases: master, 8.7
Change-Id: Id5635fc9cd340b8bcf21995cd457415aaa1a8926
Reviewed-on: https://review.typo3.org/56765
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[BUGFIX] Use correct hook name for mime type guessers 79/57679/2
Andreas Fernandez [Wed, 25 Jul 2018 08:52:01 +0000 (10:52 +0200)]
[BUGFIX] Use correct hook name for mime type guessers

Resolves: #85641
Related: #60019
Releases: master, 8.7, 7.6
Change-Id: If9c94c020da6991dc070fa6aa8395042686b2752
Reviewed-on: https://review.typo3.org/57679
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
14 months ago[TASK] Use RootlineUtility directly 90/57590/8
Benni Mack [Fri, 13 Jul 2018 18:53:44 +0000 (20:53 +0200)]
[TASK] Use RootlineUtility directly

Instead of calling PageRepository to fetch the rootline, RootlineUtility
can do that now directly.

However, all exceptions are more specific and caught specifically, for
each use-case.

Additionally, PageRepository->getRootline() is deprecated now. For this
reason, the deprecation for the argument $ignoreMPerrors is removed
again, as it does not make sense anymore.

Resolves: #85557
Releases: master
Change-Id: I5a9192311c5616f5a58e89a39c3869b593e97968
Reviewed-on: https://review.typo3.org/57590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Remove skipped test in DisjunctionValidatorTest 64/57664/3
Anja Leichsenring [Mon, 23 Jul 2018 19:05:21 +0000 (21:05 +0200)]
[TASK] Remove skipped test in DisjunctionValidatorTest

The functionality guarded by the test does not apply anymore.
After the test has been skipped since a long time already,
it is safe to just remove it.

Change-Id: I7757b57e7f7424d2631f67b736d927f525e01f0b
Resolves: #85625
Releases: master
Reviewed-on: https://review.typo3.org/57664
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate PageRepository->versioningWorkspaceId 92/57592/3
Benni Mack [Fri, 13 Jul 2018 18:56:31 +0000 (20:56 +0200)]
[TASK] Deprecate PageRepository->versioningWorkspaceId

The property does not need to be accessed from the outside anymore,
and can be marked as protected/deprecated, as this information is all
stored within the given context of the page repository.

Resolves: #85556
Releases: master
Change-Id: I36072c06b6ac5c5faa5ebce5b373e76530af7509
Reviewed-on: https://review.typo3.org/57592
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Run test suite with composer update 63/57663/2
Christian Kuhn [Mon, 23 Jul 2018 13:23:58 +0000 (15:23 +0200)]
[TASK] Run test suite with composer update

We recently had an issue where a dependency released new versions
that break our build. Our composer.json definitions were not strict
enough and we did not find this issue before release.

The patch extends the bamboo nightly plan with a new stage that
does a full 'composer update --with-dependencies' before running
tests, additionally to the usual 'composer install' that loads
dependencies according to our composer.lock definitions.

This way, we should find depency releases that break our
system much quicker next time.

Resolves: #85624
Related: #85552
Releases: master
Change-Id: I1d10260cdfea4d10f54e6d77de3a837bc52632b7
Reviewed-on: https://review.typo3.org/57663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update codeception to latest patch level 62/57662/2
Christian Kuhn [Mon, 23 Jul 2018 15:14:57 +0000 (17:14 +0200)]
[TASK] Update codeception to latest patch level

composer update codeception/codeception --with-dependencies

Updates codeception from 2.4.1 to 2.4.4 and brings
phpunit 7.1.4 to 7.1.5 along with some deeper dependencies.
The younger phpunit bundle seems to be a bit more picky on
string assertions, so we need to fix two unit tests that
silently used the bug before.

Resolves: #85623
Releases: master
Change-Id: Iceae98384b4e2e45a8b8958835b42faca9ee704a
Reviewed-on: https://review.typo3.org/57662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update php-cs-fixer to latest minor 60/57660/3
Christian Kuhn [Mon, 23 Jul 2018 13:53:39 +0000 (15:53 +0200)]
[TASK] Update php-cs-fixer to latest minor

Updates friendsofphp/php-cs-fixer from 2.11.1 to 2.12.2
The 'no_unused_imports' scanner is a bit more picky and
finds another unused import fixed along with the update.

composer update friendsofphp/php-cs-fixer

Change-Id: I40a724371c35ae4202fd8e90f43eafcb1a70c0a9
Resolves: #85621
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Use new acceptance test splitter script 58/57658/5
Christian Kuhn [Mon, 23 Jul 2018 12:02:27 +0000 (14:02 +0200)]
[TASK] Use new acceptance test splitter script

The script to split acceptance tests into chunks has been
rewritten in typo3/testing-framework and is used in pre-merge
and nightly plan. It should lead to a more fair split into
single jobs so they end up with similar runtimes again.
One test file is additionally split into three to allow
better distribution.

composer update typo3/testing-framework

Resolves: #85618
Releases: master
Change-Id: Ic65c29c5d0e4813d3953d1e70bd0c746df2b8ff4
Reviewed-on: https://review.typo3.org/57658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Remove unnecessary extbase test 49/57649/3
Anja Leichsenring [Sat, 21 Jul 2018 10:16:42 +0000 (12:16 +0200)]
[TASK] Remove unnecessary extbase test

The removed test was skipped for a long time, and its intended
guarding against the usage of objects in extbase requests does
not apply.

Resolves: #85610
Releases: master
Change-Id: Icf401ff50badba4d8d33405d86708ec7af157516
Reviewed-on: https://review.typo3.org/57649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
14 months ago[TASK] Enable functional tests on microsoft sql server again 41/57641/10
Christian Kuhn [Fri, 20 Jul 2018 12:11:26 +0000 (14:11 +0200)]
[TASK] Enable functional tests on microsoft sql server again

Executing functional tests on mssql has been disabled a while
ago since the daemon crashed frequently: The server can not
run on tmpfs volumes that we usually use to speed up database
operations. sql server uses O_DIRECT i/o system calls which
tmpfs does not support. Find details at
https://github.com/Microsoft/mssql-docker/issues/12

We now run mssql tests on hard disks again, but enable them
only as nightly since they are too slow as pre-merge tests.

Change-Id: Iefc61670dcf74012fcdaada8e5b771538e7cf8c3
Resolves: #85614
Releases: master
Reviewed-on: https://review.typo3.org/57641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Preserve order of finisher options in Form CE 20/57420/4
Ioulia Kondratovitch [Fri, 29 Jun 2018 19:30:59 +0000 (21:30 +0200)]
[BUGFIX] Preserve order of finisher options in Form CE

In content elements of form_formframework, the order of
finisher options offered for overriding will be
in accordance with the order defined in FormEditorSetup.yaml.

Resolves: #85435
Releases: master, 8.7
Change-Id: Ie506858bc363c62af02a123b27c84cb9754dbda3
Reviewed-on: https://review.typo3.org/57420
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Refer to SimpleDataHandlerController instead of tce_db.php 36/57636/5
Tymoteusz Motylewski [Thu, 19 Jul 2018 21:07:00 +0000 (23:07 +0200)]
[TASK] Refer to SimpleDataHandlerController instead of tce_db.php

Update comments in the code not to mention tce_db.php.

The tce_db.php entry point is gone since v8.
The SimpleDataHandlerController is responsible for pushing data
from request to DataHandler.

Resolves: #85600
Releases: master, 8.7
Change-Id: I6d323a9aab77ab67ff811970ff3c0f47dbf84340
Reviewed-on: https://review.typo3.org/57636
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Remove skipped test in extbase 52/57652/2
Anja Leichsenring [Sun, 22 Jul 2018 07:06:50 +0000 (09:06 +0200)]
[TASK] Remove skipped test in extbase

The test was skipped, its guarded functionality does not exist.

Change-Id: I683a3be8ace5556052e948ca9d35eedcadd79c29
Resolves: #85612
Releases: master
Reviewed-on: https://review.typo3.org/57652
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Deprecate PageRepository->checkWorkspaceAccess 93/57593/7
Benni Mack [Fri, 13 Jul 2018 19:43:27 +0000 (21:43 +0200)]
[TASK] Deprecate PageRepository->checkWorkspaceAccess

An unused if() statement removes the last occurrence
of this method, so it can be deprecated.

Resolves: #85554
Releases: master
Change-Id: Ica80f66f7fdce4d72c8d97d0405360c307ca14dd
Reviewed-on: https://review.typo3.org/57593
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Switch from git.typo3.org to github for testing 43/57643/3
Christian Kuhn [Fri, 20 Jul 2018 15:35:16 +0000 (17:35 +0200)]
[TASK] Switch from git.typo3.org to github for testing

typo3.org git/gerrit show flakiness lately. To not torture
the poor servers with our pesky testing so much we switch
the git clones to github/TYPO3/TYPO3.CMS and hope merges
are mirrored over there more quickly and they sustain our
testing load easily.

Resolves: #85606
Releases: master, 8.7, 7.6
Change-Id: I772d945a3bf697172cb26edb761f01e6cb8da4bf
Reviewed-on: https://review.typo3.org/57643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Define "label" for tt_content form elements within form setup 16/57616/2
Ralf Zimmermann [Tue, 17 Jul 2018 06:55:18 +0000 (08:55 +0200)]
[BUGFIX] Define "label" for tt_content form elements within form setup

Define the "label" property for tt_content form elements within
the form setup to allow saving tt_content form elements.

Resolves: #85578
Releases: master, 8.7
Change-Id: I490a43692a9f54ef843e9362d0f700a9e5552106
Reviewed-on: https://review.typo3.org/57616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
14 months ago[TASK] Deprecate enableConcatenateFiles 29/57629/4
Benni Mack [Thu, 19 Jul 2018 10:01:17 +0000 (12:01 +0200)]
[TASK] Deprecate enableConcatenateFiles

Also config.concatenateJsAndCss TypoScript is replaced
with concatenateCss and concatenateJs since TYPO3 v6.0,
and can now be deprecated.

Resolves: #65578
Releases: master
Change-Id: I23ee9637a3c880c67a93a6f9771a9bfab5ed6ac3
Reviewed-on: https://review.typo3.org/57629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Replace gettype calls type-specific checks 68/57468/4
Wouter Wolters [Wed, 4 Jul 2018 18:45:58 +0000 (20:45 +0200)]
[TASK] Replace gettype calls type-specific checks

Resolves: #85479
Releases: master
Change-Id: I576ab5fb6a7937016497a93d3b4dd025478e81bd
Reviewed-on: https://review.typo3.org/57468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Avoid SQL error in indexed search administration 34/57634/2
Benni Mack [Thu, 19 Jul 2018 15:58:51 +0000 (17:58 +0200)]
[BUGFIX] Avoid SQL error in indexed search administration

The field "uid" is never fetched, so no count() is possible
in the DB count query.

Resolves: #85252
Releases: master, 9.3
Change-Id: I9a3f1cb13bf20dcbe4bfb5451afd465e5981ecb4
Reviewed-on: https://review.typo3.org/57634
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[TASK] Deprecate cObj->enableFields() 98/57598/3
Benni Mack [Fri, 13 Jul 2018 21:04:09 +0000 (23:04 +0200)]
[TASK] Deprecate cObj->enableFields()

The method is just a wrapper for PageRepository->enableFields()
which should be used instead.

Resolves: #85558
Releases: master
Change-Id: I5fd18ef3e101325bc95f4d0147899d961f5898f6
Reviewed-on: https://review.typo3.org/57598
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Enable acceptance tests again 35/57635/8
Christian Kuhn [Thu, 19 Jul 2018 18:46:33 +0000 (20:46 +0200)]
[TASK] Enable acceptance tests again

Bring back backend acceptance test execution as pre-merge
and nightly tests. They are hopefully more stable now and
we'll test if they survive the hard pre-merge load without
being too flaky..
The patch changes the bamboo plan specs accordingly but disables
a couple for FormEngine related detail tests that need further
investigation.
The patch also fetches a new patch level of testing-framework
to have proper ac path definition of the ac splitter script:

composer update typo3/testing-framework

Change-Id: Iffcfd60391ba60d5ab2196a00a5bd0a4a93fff7f
Resolves: #85599
Releases: master
Reviewed-on: https://review.typo3.org/57635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Use a dedicated logger for E_USER_DEPRECATION 25/57125/5
Markus Klein [Mon, 4 Jun 2018 20:32:26 +0000 (22:32 +0200)]
[TASK] Use a dedicated logger for E_USER_DEPRECATION

Resolves: #85238
Releases: master
Change-Id: Ie47e1ba0a4f0ba3e5e1a8d62bc137cabd3ae4d1e
Reviewed-on: https://review.typo3.org/57125
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] Deprecate TYPO3_OS constant 32/57632/2
Benni Mack [Thu, 19 Jul 2018 15:25:15 +0000 (17:25 +0200)]
[TASK] Deprecate TYPO3_OS constant

The TYPO3_OS constant is deprecated with
the introduction of Environment API.

Resolves: #85597
Releases: master
Change-Id: Ie0f844d2d024f2a3f6acdf5af24debead6ba836b
Reviewed-on: https://review.typo3.org/57632
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[BUGFIX] Fix typo in RST file 33/57633/2
Benni Mack [Thu, 19 Jul 2018 15:27:44 +0000 (17:27 +0200)]
[BUGFIX] Fix typo in RST file

Resolves: #85598
Related: #85553
Releases: master
Change-Id: Ib5c0a6850c79880eac0eb47dab957083ca328e2b
Reviewed-on: https://review.typo3.org/57633
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update Feature-82014-ExtensionScanner.rst 31/57631/2
Ramon Zöllner [Thu, 19 Jul 2018 13:28:05 +0000 (15:28 +0200)]
[TASK] Update Feature-82014-ExtensionScanner.rst

Fixed Link to Extension-Scanner Docs

Releases: master
Resolves: #85595
Change-Id: I181b34497db5d0f2807c035d6228f6fb9f2f31a4
Reviewed-on: https://review.typo3.org/57631
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate -1 in language-related calls of PageRepository 91/57591/5
Benni Mack [Fri, 13 Jul 2018 18:54:42 +0000 (20:54 +0200)]
[TASK] Deprecate -1 in language-related calls of PageRepository

The default value for
- PageRepository->getPageOverlay()
- PageRepository->getPagesOverlay()
should be "null" and not some magic "-1" usage.

Resolves: #85553
Releases: master
Change-Id: Ic665c4a563e6496678ab944c80901db26f2b72ba
Reviewed-on: https://review.typo3.org/57591
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] Only use SaltedHashingMethods marked as available 20/57520/5
Oliver Hader [Mon, 9 Jul 2018 20:30:35 +0000 (22:30 +0200)]
[BUGFIX] Only use SaltedHashingMethods marked as available

When determining the SaltedHashingMethod of a salted hash check only
SaltedHashingMethods which are marked as available.

Resolves: #85526
Releases: master, 8.7
Change-Id: I72ca88ce35c891dc149d0628543d30b6c4122407
Reviewed-on: https://review.typo3.org/57520
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
14 months ago[FEATURE] Add infix option for filenames used by FileWriter 98/57198/6
Markus Klein [Mon, 4 Jun 2018 20:32:26 +0000 (22:32 +0200)]
[FEATURE] Add infix option for filenames used by FileWriter

Resolves: #85236
Releases: master
Change-Id: Iad1047b7a91adee4d0dcad766d5116bea27e34ce
Reviewed-on: https://review.typo3.org/57198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[BUGFIX] Set the redirect hook before the page-resolver 69/57569/5
Michael Giek [Thu, 12 Jul 2018 10:14:18 +0000 (12:14 +0200)]
[BUGFIX] Set the redirect hook before the page-resolver

The source page redirects now also with get-parameters to the
target page.

Resolves: #85538
Related: #85488
Releases: master
Change-Id: Ibc1ae6afdbe11065156201e8118838203e427cf3
Reviewed-on: https://review.typo3.org/57569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[FEATURE] Allow TCA description property 97/57397/6
Christian Kuhn [Wed, 27 Jun 2018 14:46:00 +0000 (16:46 +0200)]
[FEATURE] Allow TCA description property

When the site configuration module has been introduced, it came
with a custom functionality to show an additional help text
when editing site records between the field label and the field input.

This useful feature is now changed into a general TCA feature
available everywhere: A new field information node expansion / "wizard"
is added to all form elements, the inline and flex containers: If
the property "description" is set for a TCA column type (same array
level as "label", it will show the value as localized string between
the field label and the input section.

There are three available render types for "wizard a-like" output:
* Field information - text between label+field
* Field control - buttons next to input sections like the link popup button
* Field wizards - clickable stuff below the input section, for example
  the localization state selector
If a field has been set to readOnly=true in TCA, field control and field
wizards do not make sense to render since they are meant to act with the
field value.
The field information node however has only informational character
which is useful for readOnly fields, too. Thus, this node expansion
type is now the only one that is always rendered, even if a field has
been set to readOnly.

Note this patch is fully covered by ext:styleguide (master) to have
examples for all changed elements now using the description property.

Resolves: #85410
Releases: master
Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f
Reviewed-on: https://review.typo3.org/57397
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Fix doctrine dependencies and pin to dbal 2.7 13/57613/10
Andreas Fernandez [Mon, 16 Jul 2018 14:57:30 +0000 (16:57 +0200)]
[BUGFIX] Fix doctrine dependencies and pin to dbal 2.7

Since our code does not work with doctrine/dbal 2.8.0
we for now pin to the previous minor release.

A hidden dependency to doctrine/collections is also
removed by using the ExpressionBuilder constant instead.

Used command:

composer require doctrine/dbal ~2.7.0

Resolves: #85575
Related: #85552
Releases: master
Change-Id: Icc8d41c566cf39d15a4eae500b8b216a44689dce
Reviewed-on: https://review.typo3.org/57613
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Fix typo in form documentation 24/57624/4
sascha307050 [Wed, 18 Jul 2018 18:46:03 +0000 (20:46 +0200)]
[BUGFIX] Fix typo in form documentation

Releases: master,8.7
Resolves: #85589
Change-Id: I965f559b0307bd477e8f64340a12513a9827842d
Reviewed-on: https://review.typo3.org/57624
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Fix FlashMessage when dumping autoload-information in composer-mode 11/57511/2
Stefan Neufeind [Mon, 9 Jul 2018 10:33:54 +0000 (12:33 +0200)]
[BUGFIX] Fix FlashMessage when dumping autoload-information in composer-mode

In composer-mode the autoload-information can't be dumped. A FlashMessage
is shown as a notice. But the message itself was left empty and instead
a message-title was given which is not shown in the backend.

Resolves: #85515
Releases: master
Change-Id: Ie8e59fb5272f1a1682b19652ac991e5dbee6a4e3
Reviewed-on: https://review.typo3.org/57511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Do not re-sort IRRE children when sorting parent 59/57259/6
Tymoteusz Motylewski [Mon, 25 Jun 2018 18:59:30 +0000 (20:59 +0200)]
[BUGFIX] Do not re-sort IRRE children when sorting parent

When PID of the parent record has not changed, child records should
not be moved/sorted.

Little background helping reviewing the patch:

The 2 important changes are made in DataHandler.php line 4603
and DataHandlerHook.php around line 346.
In both cases the condition is added checking if the destination PID
of the record is the same as current one.
In that case, processing of the IRRE children is skipped.

All the changes made in the .csv files are reflecting that.
To validate them one can compare the content of the csv files
with LiveDefaultElements.csv datasets.

For example, check that sorting values in file:
core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv
are the same as in the:
core/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv

In the Workspaces related datasets, you will see that there
are no move placeholders for IRRE children any more
(and versioned records have 0 instead of 4 in the t3ver_state).

See e.g.:
workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/changeContentSorting.csv
or
workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv

This patch also solves the issue that sorting of the LIVE records (IRRE children)
were modified, when sorting parent record in the Workspaces,
see e.g. record tx_irretutorial_1nff_hotel uid 2 and 5 in file:
workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/changeParentContentSorting.csv

Releases: master, 8.7
Resolved: #85304
Change-Id: I44573b334873400af628066beae84705c5af0408
Reviewed-on: https://review.typo3.org/57259
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jord de Jong <jord.dejong@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[FEATURE] Add getEnv value modifier to TS parser 15/57115/4
Felix Althaus [Sun, 3 Jun 2018 14:07:52 +0000 (16:07 +0200)]
[FEATURE] Add getEnv value modifier to TS parser

Use :=getEnv() in TypoScript to read values from environment variables.

Resolves: #85146
Releases: master
Change-Id: I6c480627e4b07f76f4d8887df0db9d95fd75e6d9
Reviewed-on: https://review.typo3.org/57115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Hannes Lau <office@hanneslau.de>
Tested-by: Hannes Lau <office@hanneslau.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Streamline backend module menu and viewport initialization 26/57526/2
Oliver Hader [Tue, 10 Jul 2018 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] Streamline backend module menu and viewport initialization

ModuleMenu and Viewport initialization need to be defered to ensure
that DOM is available in order to apply further behavior in mentioned
client implementation.

Resolves: #80312
Releases: master, 8.7
Change-Id: I9581a7f2164050f73683928b8f2ebe1d69a6d5e7
Reviewed-on: https://review.typo3.org/57526
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Move extension configuration to first place 84/57584/3
Peter Kraume [Fri, 13 Jul 2018 07:57:22 +0000 (09:57 +0200)]
[TASK] Move extension configuration to first place

This patch improves the usability of the new Settings module by moving
the extension configuration card in the first place since this will
probably be the most used card in the Settings module.

Resolves: #85546
Releases: master
Change-Id: I21aa5bcccacd49b0ab6a67c5bf87812f295b0c49
Reviewed-on: https://review.typo3.org/57584
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls 49/57249/3
Wouter Wolters [Sun, 17 Jun 2018 15:01:21 +0000 (17:01 +0200)]
[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls

Resolves: #85293
Releases: master
Change-Id: Ifabbb20c1ef4ad482df676fe9999dcbdf18eb704
Reviewed-on: https://review.typo3.org/57249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Setting BE-debug appends fieldnames to labels 99/57499/2
Stefan Neufeind [Sun, 8 Jul 2018 07:41:26 +0000 (09:41 +0200)]
[TASK] Setting BE-debug appends fieldnames to labels

The description so far says fieldnames are prepended.

Resolves: #85507
Releases: master
Change-Id: I06fccdc2aee70a95e64cb14adccba0e24a22c1cb
Reviewed-on: https://review.typo3.org/57499
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Deprecate TypoScriptFrontendController->getUniqueId 97/57597/4
Benni Mack [Fri, 13 Jul 2018 20:26:45 +0000 (22:26 +0200)]
[TASK] Deprecate TypoScriptFrontendController->getUniqueId

The unused method TypoScriptFrontendController->getUniqueId() is marked
as deprecated, as this method conceptually should go into a custom
service with a singleton pattern or a runtime cache, but not within
TypoScriptFrontendController.

Resolves: #85555
Releases: master
Change-Id: Ib3af4b32e3c03d90b832ee725dcf9846af92f9ba
Reviewed-on: https://review.typo3.org/57597
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Extract request processing from ShortcutToolbarItem 31/56331/24
Mathias Brodala [Sat, 17 Mar 2018 17:16:47 +0000 (18:16 +0100)]
[TASK] Extract request processing from ShortcutToolbarItem

Change-Id: I9f396da2084880b3dd813c8d7f0777c36ac989d9
Resolves: #84414
Releases: master
Reviewed-on: https://review.typo3.org/56331
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fix apc/apcu cache backend tests 21/57621/4
Christian Kuhn [Tue, 17 Jul 2018 20:52:52 +0000 (22:52 +0200)]
[BUGFIX] Fix apc/apcu cache backend tests

bamboo php 7.2 has apc & apcu support again. Two
unit tests fail. These two however don't make much
sense in the first place since they md5(internal-knowledge).
Remove them.

Resolves: #85584
Releases: master
Change-Id: I5f1e1589189866508e684a7ca1bb6cae87d22fad
Reviewed-on: https://review.typo3.org/57621
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Bamboo proper passwd mapping 18/57618/3
Christian Kuhn [Tue, 17 Jul 2018 17:08:48 +0000 (19:08 +0200)]
[TASK] Bamboo proper passwd mapping

The bamboo containers need a better passwd mapping
per agent to set a proper home directory, otherwise
ssh tasks may fail.

Resolves: #85582
Releases: master, 8.7, 7.6
Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c
Reviewed-on: https://review.typo3.org/57618
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Test rendering of translated select MM relations in Extbase 74/57474/6
Tymoteusz Motylewski [Mon, 16 Jul 2018 11:41:40 +0000 (13:41 +0200)]
[TASK] Test rendering of translated select MM relations in Extbase

It's based on tt_content and categories.

Releases: master, 8.7
Resolves: #85493
Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599
Reviewed-on: https://review.typo3.org/57474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Also add doctrine/lexer to typo3/cms-core 03/57603/3
Markus Klein [Sat, 14 Jul 2018 20:57:29 +0000 (22:57 +0200)]
[BUGFIX] Also add doctrine/lexer to typo3/cms-core

Resolves: #85552
Releases: master, 8.7
Change-Id: I1056a5825fd79df4c495894970721713b10728cd
Reviewed-on: https://review.typo3.org/57603
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Turn redis cache backend unit into functional tests 07/57607/4
Christian Kuhn [Mon, 16 Jul 2018 00:08:31 +0000 (02:08 +0200)]
[TASK] Turn redis cache backend unit into functional tests

Our unit tests should not rely on running daemons, there is
a functional test environment to take care of this. The patch
turns redis cache backend unit tests into funcitional tests
and adapts the unit test setup to no longer start dependencies.

Resolves: #85565
Releases: master
Change-Id: I8d81209ed339d35af11bb06fb7cb191845b6b587
Reviewed-on: https://review.typo3.org/57607
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Run tests on new bamboo infrastructure 22/57522/50
Christian Kuhn [Mon, 9 Jul 2018 22:41:03 +0000 (00:41 +0200)]
[TASK] Run tests on new bamboo infrastructure

A new bamboo agent infrastructure has been deployed that
significantly changes how tests are executed: The agent
docker containers are now "stupid" and no longer bundle
specific php versions or daemons. Instead, they can run
own containers to start needed daemons for specific jobs
and execute needed php commands in ad-hoc containers that
provide the required php version.
Daemons needed for single jobs are defined in a
docker-compose.yml file provided by core itself.
This docker-compose.yml file can not be used directly for
local test execution since it has to fiddle quite a bit
with docker volume mounts, networks and executing users
that is specific to the bamboo environment.
However, another yml file can be added later to ease local
test execution in a similar way.
The patch rewrites the bamboo plan pre-merge and nightly
specs of core master to use the new infrastructure and brings
a couple of minor changes to tests that rely on a running
memcached or redis to retrieve the daemon host from an
environment variable.
There will be separated patche for older core versions.

Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af
Resolves: #85563
Resolves: #36934
Releases: master
Reviewed-on: https://review.typo3.org/57522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Use same line endings in test as in function 01/57501/3
Jigal van Hemert [Sun, 8 Jul 2018 09:42:58 +0000 (11:42 +0200)]
[BUGFIX] Use same line endings in test as in function

In CommandTest::testGetDescription() now also LF is used as line ending,
just as in the tested function.

Resolves: #85509
Releases: master, 8.7
Change-Id: I907e24b19d87d94a3fb1b3cbee9947d68358e5cc
Reviewed-on: https://review.typo3.org/57501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[TASK] Use static constant call for PageRepository 99/57599/2
Benni Mack [Fri, 13 Jul 2018 21:44:20 +0000 (23:44 +0200)]
[TASK] Use static constant call for PageRepository

Minor fix to use the static constant directly, like in all other usages.

Resolves: #85559
Releases: master
Change-Id: I163bea97ddd78b6f37945daaf7aecaab6c47bdff
Reviewed-on: https://review.typo3.org/57599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Require doctrine/lexer to get removed lexer classes 89/57589/4
Andreas Fernandez [Fri, 13 Jul 2018 18:15:30 +0000 (20:15 +0200)]
[BUGFIX] Require doctrine/lexer to get removed lexer classes

With the release of doctrine/dbal in version 2.8, the class
`Doctrine\Common\Lexer` got removed. To circumvent this issue, the
package `doctrine/lexer` will be used.

Used composer command:

    composer require doctrine/lexer:^1.0

Resolves: #85552
Releases: master, 8.7
Change-Id: I5dd007c3b95be42dfd3305f750606ae4fcabedf2
Reviewed-on: https://review.typo3.org/57589
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir 87/57587/3
Oliver Hader [Fri, 13 Jul 2018 14:45:43 +0000 (16:45 +0200)]
[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Resolves: #85547
Releases: master, 8.7, 7.6
Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930
Reviewed-on: https://review.typo3.org/57587
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Add LanguageAspect to Contexts 24/57424/24
Benni Mack [Sun, 1 Jul 2018 12:46:04 +0000 (14:46 +0200)]
[TASK] Add LanguageAspect to Contexts

This change adds a new Aspect called "Language" which bundles
most existing TypoScript options on frontend language fetching.
A factory allows to migrate the logic from TSFE.

Major / Important Changes:
- RootlineUtility is decoupled from PageRepository
- TSFE->sys_language_mode is not necessary anymore
- TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect
- A new PageRepository->getLanguageOverlay() bundles all other methods
- A lot of common public properties in TSFE are now deprecated

Next steps:
- Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE
- Migrate PageRepository "-1" parameters to "null"
- Migrate usages PageRepository->getRootline() to RootlineUtility::__construct()
- Then deprecate PageRepository->getRootLine()
- Migrate Extbase QuerySettings to Contexts

Resolves: #85543
Releases: master
Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20
Reviewed-on: https://review.typo3.org/57424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Move verbosity settings into TemplateService 81/57581/4
Benni Mack [Thu, 12 Jul 2018 18:13:45 +0000 (20:13 +0200)]
[TASK] Move verbosity settings into TemplateService

The constructor of TemplateService now has
a context, which knows everything to define
public settings to define if tt_track and verbose
should be set.

Resolves: #85542
Releases: master
Change-Id: I11306a57c64e8c5cb0d0a069b73e06f066b72d8e
Reviewed-on: https://review.typo3.org/57581
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[FEATURE] Add context check for TypoScript 88/57588/3
Benni Mack [Fri, 13 Jul 2018 14:46:09 +0000 (16:46 +0200)]
[FEATURE] Add context check for TypoScript

The new Context API is added so TypoScript
can check this in cObject like this:

10 = TEXT
10.data = context:workspace:id

where as the key is context:[aspectName]:[propertyName]

Arrays are automatically converted to comma-separated lists,
which is useful for reading info on user groups.

Resolves: #85550
Releases: master
Change-Id: I86673055e088ec4e65288df6145399f8e45055c8
Reviewed-on: https://review.typo3.org/57588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Add Content-Type to test mail plain part 36/57536/2
Mathias Brodala [Thu, 12 Jul 2018 07:53:55 +0000 (09:53 +0200)]
[BUGFIX] Add Content-Type to test mail plain part

Resolves: #85536
Releases: master, 8.7
Change-Id: Ie1f5c97af1a315eb5b8d7bf4bc7a31872362750d
Reviewed-on: https://review.typo3.org/57536
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] LanguagePackCommand: Hide progress output by default 30/57530/10
Josef Glatz [Wed, 11 Jul 2018 08:54:23 +0000 (10:54 +0200)]
[BUGFIX] LanguagePackCommand: Hide progress output by default

Show progress bar only if verbosity level is set. The default output
of this command is disabled by default to limit the amount of e-mails
sent by the TYPO3 scheduler (which normally makes only sense, if any
error occurs).

You can activate the output if you set the verbosity while calling the
command ("-v" option).

Resolves: #85533
Releases: master
Change-Id: I6f95559cc1228afd66192f7382e81f9ae91c0ed8
Reviewed-on: https://review.typo3.org/57530
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Remove post-autoload-dump section from composer.json 37/57537/7
Anja [Thu, 12 Jul 2018 08:23:09 +0000 (10:23 +0200)]
[TASK] Remove post-autoload-dump section from composer.json

The included task in not subject to be executed upon each
`composer install`.

Resolves: #85537
Related: #83249
Releases: master, 8.7
Change-Id: I12240cbd7ea571b1872effd6942a3bd65bf37a89
Reviewed-on: https://review.typo3.org/57537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fix test isolation and pre-requisites 70/57570/5
Susanne Moog [Thu, 12 Jul 2018 10:37:06 +0000 (12:37 +0200)]
[BUGFIX] Fix test isolation and pre-requisites

FormDefinitionValidationServiceTest modified the encryption key in
test data-provider functions. Those functions are executed prior to
actually executing the tests and causes side-effects during running
the test suite.

Resolves: #85539
Releases: master, 9.3, 8.7
Change-Id: I9fbd60905eb37470fa3661225b681476ff9df3c3
Reviewed-on: https://review.typo3.org/57570
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Fix CGL issues 65/57565/2
Oliver Hader [Thu, 12 Jul 2018 09:58:10 +0000 (11:58 +0200)]
[TASK] Fix CGL issues

Resolves: #.....
Releases: master, 8.7
Change-Id: Iace5c4d064182c628e9d3b03876c73e19dd725cd
Reviewed-on: https://review.typo3.org/57565
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY][TASK] Remove support for native PHP yaml extension 63/57563/2
Oliver Hader [Thu, 12 Jul 2018 09:36:39 +0000 (11:36 +0200)]
[SECURITY][TASK] Remove support for native PHP yaml extension

Resolves: #85424
Releases: master, 8.7
Security-Commit: 82619eb231e725d77fb8196f0b6bfca9f722bc4f
Security-Bulletin: TYPO3-CORE-SA-2018-004
Change-Id: Ic104c79ebfc1daff0b05b0f5531345b5bf7ce74b
Reviewed-on: https://review.typo3.org/57563
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Filter disallowed properties in form editor 62/57562/2
Ralf Zimmermann [Thu, 12 Jul 2018 09:36:23 +0000 (11:36 +0200)]
[SECURITY] Filter disallowed properties in form editor

The form editor save and preview actions now check the submitted
form definition against configured possibilities within the form
editor setup.

Releases: master, 8.7
Resolves: #85044
Security-Commit: f4a1a09378ed286f3744d6a72f09bfa11a6ba87e
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: Ibf6083ab98b9fe73effe217380f555892c9c6bb0
Reviewed-on: https://review.typo3.org/57562
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[!!!][SECURITY] Deny direct FAL commands for form definitions 61/57561/2
Susanne Moog [Thu, 12 Jul 2018 09:36:05 +0000 (11:36 +0200)]
[!!!][SECURITY] Deny direct FAL commands for form definitions

Before this change, form definitions have been persisted in regular
`.yaml` files. In order to make the meaning and purpose of those
files more explicit, the new file ending `.form.yaml` is introduced.

Invocations of the file abstraction layer API for those form files
have to be allowed explicitly by granting commands individually using
`FilePersistenceSlot::allowInvocation`.

New form definitions are created with the new file ending per default.
An upgrade wizard renames existing form definitions that are stored in
according storage folders (`allowedFileMounts`). In addition references
in FlexForm of content elements are adjusted to the new file names as
well - in case a form definition has been referenced before.

The file list user interface disabled according direct actions for
`.form.yaml` files or redirects those to the according form module.

Using just `.yaml` instead of `.form.yaml` from site packages
is deprecated. Using just `.yaml` instead of `.form.yaml` from
file storages is not allowed anymore.

Resolves: #84910
Releases: master, 8.7
Security-Commit: 444f9dc4f1902871391bd1f139d19b46a63a162f
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: I456c03f745e614729cdbf2915efc6b5e6d11fc0f
Reviewed-on: https://review.typo3.org/57561
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Explicitly deny object deserialization 60/57560/2
Oliver Hader [Thu, 12 Jul 2018 09:35:49 +0000 (11:35 +0200)]
[SECURITY] Explicitly deny object deserialization

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: f4d645d131fabc98cbbdcefcffb951040d2dd246
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Ia138f22856c7dd754e373803af799273868c622b
Reviewed-on: https://review.typo3.org/57560
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Mitigate phar stream wrapper 59/57559/2
Christian Kuhn [Thu, 12 Jul 2018 09:35:37 +0000 (11:35 +0200)]
[SECURITY] Mitigate phar stream wrapper

SoftReferenceIndex throws exceptions on phar streams
LegacyLinkNotationConverter throws exceptions on phar streams

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: 4fde9d6a2333435af9033f55e9a5e2d428f6ea0d
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I69333fff4d94dc7369ba729333a39e8be5dda7a3
Reviewed-on: https://review.typo3.org/57559
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Introduce PHP stream wrapper for phar:// protocol 58/57558/2
Oliver Hader [Thu, 12 Jul 2018 09:35:24 +0000 (11:35 +0200)]
[SECURITY] Introduce PHP stream wrapper for phar:// protocol

This custom stream wrapper for the phar:// protocol overrides
PHP's native handling. In case Phar bundles shall be loaded from
a valid directory, the custom wrapper falls back to the native PHP
wrapper in order to invoke Phar-related actions.

In case the location is not trustworthy, an according exception
is thrown. The custom stream wrapper is registered in the beginning
of TYPO3's bootstrap class.

Truested locations are those in typo3conf/ext/* - anything else is
denied and not considered as trustworthy.

Releases: master, 8.7, 7.6
Resolves: #85385
Security-Commit: efa085d9a5aebfac6b92309ea53c455b95a81fcc
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Ifd38eab7a5757e6cfbd6f773a3fed8f3d742e09d
Reviewed-on: https://review.typo3.org/57558
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Deny authentication bypass using blowfish/md5 encryption 57/57557/2
Oliver Hader [Thu, 12 Jul 2018 09:35:12 +0000 (11:35 +0200)]
[SECURITY] Deny authentication bypass using blowfish/md5 encryption

Using password hashing methods that are related by class inheritance
can lead to authentication bypass by just knowing a valid username.

Resolves: #84703
Releases: master, 8.7, 7.6
Security-Commit: 2951c4fc0529ec0fd6047786edd3b7189428e574
Security-Bulletin: TYPO3-CORE-SA-2018-001
Change-Id: I859a20c85305291e1cd79b61e630bbbfc4e0568a
Reviewed-on: https://review.typo3.org/57557
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Streamline usage of Logging 15/57515/2
Benni Mack [Mon, 9 Jul 2018 12:33:42 +0000 (14:33 +0200)]
[TASK] Streamline usage of Logging

The Logger can be used with the LoggerAwareInterface+Trait combination
and was fogot for FAL related areas.

The LocalImageProcessor and FileProcessingService did not have any usage
of the logger, thus, they were removed.

Additionally, one should reference against the interfaces, not the implementation
classes directly.

Resolves: #85519
Releases: master
Change-Id: Ie381b1fc9a7007e76ea1c487fa9b1bda4a793bc0
Reviewed-on: https://review.typo3.org/57515
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Simplify setting BE/warning_mode 00/57500/2
Stefan Neufeind [Sun, 8 Jul 2018 09:06:02 +0000 (11:06 +0200)]
[TASK] Simplify setting BE/warning_mode

The setting used bits 1 and 2. But useful values were only 0/1/2.
So this setting can be simplified.

Resolves: #85508
Releases: master
Change-Id: Ib78174035bcefdec7658f37dae9071062dcb52c1
Reviewed-on: https://review.typo3.org/57500
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[FEATURE] Introduce conditional variants for form elements 82/54982/64
Ralf Zimmermann [Fri, 8 Dec 2017 08:03:38 +0000 (09:03 +0100)]
[FEATURE] Introduce conditional variants for form elements

Variants allow you to change properties of a form element.

Variants can contain conditions. If a concrete condition
is TRUE the variant is applied. If no condition exists the
variant will be ignored.

Variants make it possible to manipulate form element values,
validator options, and finisher options based on conditions.
This allows you among other things:

* translation of form element values depending on the frontend
  language
* set and remove validators of one form element depending on the
  value of another form element
* hide entire pages depending on the value of a form element
* set finisher values depending on the value of a form element
* hiding a form element in certain finishers and on the
  summary page

This feature implements variants for the frontend rendering and
the ability to define variants in the formDefinition. The
implementation to define variants in the form editor is out of
scope of this patchset.

Releases: master
Resolves: #84133
Change-Id: I9efeeea5af67df2d2f9252339c26baf8a03cf9c8
Reviewed-on: https://review.typo3.org/54982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Simplify and clean up error log system information 13/57513/2
Helmut Hummel [Mon, 9 Jul 2018 10:59:06 +0000 (12:59 +0200)]
[TASK] Simplify and clean up error log system information

Remove inheritance from abstract log module

Inheritance was used only to be able to get the time
from which to start to look for errors. This however never
really worked, because the constraint only had a startTimestamp
value set, if the user selected a custom time frame when viewing the log.

Therefore we can just assume errors have not been seen, unless
they are confirmed through the system information toolbar.

Resolves: #85517
Releases: master
Change-Id: Id6aa21fbbe0c56baeb19633aba0f9f7ff6215c0e
Reviewed-on: https://review.typo3.org/57513
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
15 months ago[BUGFIX] Use real HTTP status code as default for redirects 10/57510/6
Michael Giek [Mon, 9 Jul 2018 08:52:53 +0000 (10:52 +0200)]
[BUGFIX] Use real HTTP status code as default for redirects

TCA defines default status code as 307, which seems
like a good default. However the SQL definition should
match this definition to avoid any invalid redirect
status codes.

Releases: master
Resolves: #85513
Related: #85488
Change-Id: I972d83bd782592c77b6606cd6f7d6a1fc82d2414
Reviewed-on: https://review.typo3.org/57510
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Remove superfluous Doctrine restriction check 12/57512/4
Benni Mack [Mon, 9 Jul 2018 10:37:39 +0000 (12:37 +0200)]
[BUGFIX] Remove superfluous Doctrine restriction check

Similar to https://review.typo3.org/#/c/57434/
the check for TSFE->showHiddenRecords is unneeded
as the RestrictionContainer evaluates this information
(now done via aspects) directly anyway.

Resolves: #85516
Releases: master
Change-Id: Icc88b1995fe603f3707c9a83e83bf03ff549422e
Reviewed-on: https://review.typo3.org/57512
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Bring back the maintenance information message 06/56706/7
Frank Naegler [Tue, 17 Apr 2018 10:09:17 +0000 (12:09 +0200)]
[BUGFIX] Bring back the maintenance information message

In case the adminOnly flag is set, an information window is shown.
The middleware now creates a valid JSON response to show
the information window again.

Resolves: #84765
Releases: master
Change-Id: Ibe36b9d2c06b730bb2687d528d011268af4da660
Reviewed-on: https://review.typo3.org/56706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Scheduler: Show correct description for ipAnonymization-task 07/57507/3
Stefan Neufeind [Mon, 9 Jul 2018 08:15:13 +0000 (10:15 +0200)]
[BUGFIX] Scheduler: Show correct description for ipAnonymization-task

Resolves: #85512
Releases: master, 8.7, 7.6
Change-Id: I4077fe7481063feb97014048580c3fb1b1ca5e2a
Reviewed-on: https://review.typo3.org/57507
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Use ServerRequestInterface in SchedulerModuleController 64/56264/18
Łukasz Uznański [Fri, 16 Mar 2018 22:17:10 +0000 (23:17 +0100)]
[TASK] Use ServerRequestInterface in SchedulerModuleController

* replace usages of _GP, getIndpEnv
* add return hints

Resolves: #84387
Releases: master
Change-Id: I156f9005c132ab91abfbd72b97084ede6708d0dc
Reviewed-on: https://review.typo3.org/56264
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Refactor acceptance tests 61/57461/17
Davert [Wed, 4 Jul 2018 15:02:15 +0000 (18:02 +0300)]
[TASK] Refactor acceptance tests

typo3/testing-framework got a major release:
composer update typo3/testing-framework ^4.0

* codeception acceptance tests now live in a proper php namespace
* merged installation suites yml files into one
* installer tests are now one suite with different environment settings
* aligned with changes in typo3/testing-framework
* renamed Acceptance test suite to Backend test suite
* removed Admin/Editor steps, replaced with useExistingLogin('role')

Resolves: #85472
Releases: master
Change-Id: Ia049b43f5f9f645dddb509bde557ad83a7ac9023
Reviewed-on: https://review.typo3.org/57461
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Document loginSecurityLevel change when removing rsaauth 82/57482/4
moger-xx [Fri, 6 Jul 2018 13:49:09 +0000 (15:49 +0200)]
[TASK] Document loginSecurityLevel change when removing rsaauth

Releases: master
Resolves: #85500
Change-Id: I060e27a52a2a840dca2fd65db0e206f73dc5c8f9
Reviewed-on: https://review.typo3.org/57482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Re-add .panel-collapsed for caret handling 95/57495/2
Andreas Fernandez [Fri, 6 Jul 2018 20:38:19 +0000 (22:38 +0200)]
[BUGFIX] Re-add .panel-collapsed for caret handling

Resolves: #85505
Releases: master
Change-Id: I73315ce0c958cccbce401875b13514b7dae58f27
Reviewed-on: https://review.typo3.org/57495
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Set „scanned“ flag when scanning all extensions 94/57494/2
Andreas Fernandez [Fri, 6 Jul 2018 20:33:15 +0000 (22:33 +0200)]
[BUGFIX] Set „scanned“ flag when scanning all extensions

Resolves: #85504
Releases: master
Change-Id: I75580fb05c0217b1c28a2109b7f6bc2147d458d8
Reviewed-on: https://review.typo3.org/57494
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Use str_replace instead of strtr to improve readability and clarity purposes 65/57465/3
Wouter Wolters [Wed, 4 Jul 2018 18:08:27 +0000 (20:08 +0200)]
[TASK] Use str_replace instead of strtr to improve readability and clarity purposes

Resolves: #85476
Releases: master
Change-Id: I879bb7546e7e7ca0d46e8d682eb739f76df61b01
Reviewed-on: https://review.typo3.org/57465
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Scan extension by clicking panel 93/57493/3
Andreas Fernandez [Fri, 6 Jul 2018 19:41:48 +0000 (21:41 +0200)]
[BUGFIX] Scan extension by clicking panel

The extension scanner now scans an extension by opening its
panel again.

Resolves: #85440
Releases: master
Change-Id: I7b72f8c658d200c5c4d4ca90f7d6b55828c33efd
Reviewed-on: https://review.typo3.org/57493
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Fix orientiation of carets in panels 92/57492/2
Andreas Fernandez [Fri, 6 Jul 2018 19:08:39 +0000 (21:08 +0200)]
[BUGFIX] Fix orientiation of carets in panels

The styling of the caret was only applied, if it is a child of
`.panel-collapsed`, which is no official Bootstrap markup.

The CSS is now changed to rotate the caret icon with the correct
markup, too. This fixes the issue in the System Maintenance Area
that the caret rotation is broken.

Resolves: #85503
Releases: master
Change-Id: I095b7339c3ae8d86e6642fb1953d3bff2b042bfb
Reviewed-on: https://review.typo3.org/57492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Replace misused in_array calls 63/57463/4
Wouter Wolters [Wed, 4 Jul 2018 17:55:09 +0000 (19:55 +0200)]
[TASK] Replace misused in_array calls

Resolves: #85474
Releases: master
Change-Id: I62b1fe0b5ea3e1b5340aa18c216c7491d2d64fad
Reviewed-on: https://review.typo3.org/57463
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Check for exceptions instead of number of affected rows 58/57358/2
Georg Ringer [Sun, 24 Jun 2018 16:22:30 +0000 (18:22 +0200)]
[BUGFIX] Check for exceptions instead of number of affected rows

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Resolves: #85366
Releases: master, 8.7
Change-Id: I474e16478cb09ad4940aaab5fe1d3eb21498c4c4
Reviewed-on: https://review.typo3.org/57358
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Migrate EXT:backend LoginRefresh to TypeScript 75/57475/7
Frank Naegler [Thu, 5 Jul 2018 11:25:09 +0000 (13:25 +0200)]
[TASK] Migrate EXT:backend LoginRefresh to TypeScript

Resolves: #82595
Releases: master
Change-Id: Iebec35d3f1be6b70e3976a04c9820c9277a845e3
Reviewed-on: https://review.typo3.org/57475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Convert date objects to string in SaveToDatabase finisher 05/57205/6
Ralf Zimmermann [Tue, 12 Jun 2018 16:57:56 +0000 (18:57 +0200)]
[BUGFIX] Convert date objects to string in SaveToDatabase finisher

The SaveToDatabase now converts DateTime(Immutable) objects to strings
to make it possible to save values from "Date" or "DatePicker" form elements
into the database.

Resolves: #85246
Releases: master, 8.7
Change-Id: I1533252d462d08bf7b743884d4e8e5fab12f6423
Reviewed-on: https://review.typo3.org/57205
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Lidia Demin <typecat@gmx.net>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl 79/57479/5
Markus Klein [Thu, 5 Jul 2018 20:26:14 +0000 (22:26 +0200)]
[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl

When fetching only headers from an URL there is no need
to download the whole content.
This was overlooked when migrating the core to use Guzzle.

Resolves: #85491
Releases: master, 8.7
Change-Id: I6475b405d51135372e022b5e133368f15a917687
Reviewed-on: https://review.typo3.org/57479
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Migrate LayoutModule/DragDrop.js to TypeScript 81/56281/8
Andreas Wolf [Sat, 17 Mar 2018 10:01:47 +0000 (11:01 +0100)]
[TASK] Migrate LayoutModule/DragDrop.js to TypeScript

Change-Id: If29efc14acf4155ac820dfbd966fd7cdc8003fe2
Resolves: #84168
Releases: master
Reviewed-on: https://review.typo3.org/56281
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Code cleanup in /frontend/Tests/Unit/ContentObject/ 81/57481/6
Jan Helke [Fri, 6 Jul 2018 12:41:08 +0000 (14:41 +0200)]
[TASK] Code cleanup in /frontend/Tests/Unit/ContentObject/

This patch is just groundwork for upcomming "make test xxx notice free"
patches.

Resolves: #85497
Related: #84456
Releases: master
Change-Id: Ib4517cbccadced40e828ded0f76115f00abb5530
Reviewed-on: https://review.typo3.org/57481
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jord de Jong <jord.dejong@windinternet.nl>
Tested-by: Jord de Jong <jord.dejong@windinternet.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Use in_array instead of array_search 69/57469/2
Wouter Wolters [Wed, 4 Jul 2018 19:04:04 +0000 (21:04 +0200)]
[TASK] Use in_array instead of array_search

Resolves: #85480
Releases: master
Change-Id: I0c666be36a30add9742fdba33d8211daf839fcf9
Reviewed-on: https://review.typo3.org/57469
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Streamline templates in System Maintenance Area 54/57454/9
Andreas Fernandez [Tue, 3 Jul 2018 07:40:35 +0000 (09:40 +0200)]
[TASK] Streamline templates in System Maintenance Area

- Introduce proper `<html>` tag
- Use callouts instead of alerts
- Deleted obsolete template files
- Streamline handling of inline vs. modal
- Fix CSS for nested panels, if parent is `flat`

Resolves: #85463
Releases: master
Change-Id: Ide545367d2153da5c170eda1e69397005bb8ed58
Reviewed-on: https://review.typo3.org/57454
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jord de Jong <jord.dejong@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Add various Composer scripts 59/54959/44
Mathias Brodala [Thu, 7 Dec 2017 11:05:07 +0000 (12:05 +0100)]
[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

    composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

    composer t:p:u

Also arbitrary arguments can be passed to the executed command:

    composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54959
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Tested-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Use secure deserialization in extension manager 58/57458/3
Oliver Hader [Tue, 3 Jul 2018 14:16:19 +0000 (16:16 +0200)]
[TASK] Use secure deserialization in extension manager

In order to harden the deserialization of scalar and array values
in extension manager unserialize() calls are hardened further to
disallow object reconstitution. The information is retrieved from
the TYPO3 extension repository (TER) where according countermeasures
are in place to protect object injections - that's why this change
is considered as hardening and not as security issue.

Resolves: #85466
Releases: master, 8.7
Change-Id: I65b61d61e08d0c50b27ae9102d7ba4c4518a8788
Reviewed-on: https://review.typo3.org/57458
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Fix double slashes in RequireJS config of install tool 70/57470/2
Benni Mack [Wed, 4 Jul 2018 19:37:39 +0000 (21:37 +0200)]
[BUGFIX] Fix double slashes in RequireJS config of install tool

RequireJS configs do not have a slash at the end of the path.

The Debug Console shows that files are loaded with double
slashes in the install tool, so they should be avoided.

Resolves: #85481
Releases: master
Change-Id: I80326d176c6dbd54847f1c188d312da1c5e55078
Reviewed-on: https://review.typo3.org/57470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example 62/57462/3
Daniel Siepmann [Wed, 4 Jul 2018 15:26:25 +0000 (17:26 +0200)]
[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example

Releases: master, 8.7, 7.6
Resolves: #85473
Change-Id: Ic0ac284bb8f02c7275e17bde67e79bb20a7fd919
Reviewed-on: https://review.typo3.org/57462
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fixing login logo height in IE 20/57320/3
Roberto Presedo [Fri, 22 Jun 2018 21:41:16 +0000 (23:41 +0200)]
[BUGFIX] Fixing login logo height in IE

Resolves: #78592
Releases: master, 8.7
Change-Id: Ia7b3a25f6af61fce5376a68c1188c9564d603a23
Reviewed-on: https://review.typo3.org/57320
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Robert Vierke <robert.vierke+typo3@gmail.com>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Update complete database after extension installation 29/57429/11
Nicole Cordes [Sun, 1 Jul 2018 14:54:19 +0000 (16:54 +0200)]
[BUGFIX] Update complete database after extension installation

If an extension and its dependencies get installed, the whole
database needs to be updated instead of executing each extensions
SQL on its own.

Resolves: #79094
Releases: master, 8.7
Change-Id: I9a870e0efb6af241eeae563adbaa14af100edaec
Reviewed-on: https://review.typo3.org/57429
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Stabilize acceptance tests 60/57460/2
Christian Kuhn [Wed, 4 Jul 2018 14:22:37 +0000 (16:22 +0200)]
[TASK] Stabilize acceptance tests

This is one patch in the 'stabilize acceptance tests'
again mission. It changes various details in the Cest files.
At the same time changes within typo3/testing-framework
and the bamboo test execution are prepared, the version
bumps for those will follow with single patches later.

Resolves: #85470
Releases: master
Change-Id: I6ebe2499337e075f818b2726886ed02d743bb144
Reviewed-on: https://review.typo3.org/57460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Bodnarchuk <davert.ua@gmail.com>
Tested-by: Michael Bodnarchuk <davert.ua@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Improve custom CE explanation in FSC 53/57453/4
Mathias Brodala [Tue, 3 Jul 2018 07:26:53 +0000 (09:26 +0200)]
[TASK] Improve custom CE explanation in FSC

Resolves: #85459
Releases: master, 8.7
Change-Id: I1732782fa920ffa0f7bfd42016a45ac6437bff0a
Reviewed-on: https://review.typo3.org/57453
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Tested-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>