Packages/TYPO3.CMS.git
2 years ago[FOLLOWUP][BUGFIX] Respect SQL table names max length in install tool 65/50865/2
Anja Leichsenring [Sat, 3 Dec 2016 08:27:03 +0000 (09:27 +0100)]
[FOLLOWUP][BUGFIX] Respect SQL table names max length in install tool

Respect the max length of 64 chars in sql if removing (renaming)
an SQL table. Add unit test.

Resolves: #78636
Releases: master
Change-Id: I94f38c40f6539d5e53e2ac9bad5ed1c059836333
Reviewed-on: https://review.typo3.org/50865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Use ISO-8601 dates for display and processing 24/47124/16
Andreas Wolf [Sat, 5 Mar 2016 22:51:56 +0000 (23:51 +0100)]
[TASK] Use ISO-8601 dates for display and processing

This changes the internal date processing for FormEngine and DataHandler
to use ISO-8601 dates including a proper timezone. Dates are converted
to ISO-8601 as early as possible and converted back to UNIX timestamps
as late as possible.

As before, the database values are always values in the server’s
timezone, interpreted as UTC. Also, the client side inputs are
interpreted as UTC.

The main advantage is that once and for all we get rid of the timezone
issues that may potentially arise if the server and client use different
timezones. Additionally, the values are human readable (which is of
course not so much of an issue for hidden fields) and we can directly
use Moment.js for all heavy lifting.

Another big advantage is that we can make the date formats configurable
and decouple displayed dates and internally stored dates (by putting the
Moment objects to the input fields).

Change-Id: I3461915c2beaa96cd29c52c60e65a2e5005065b7
Resolves: #77702
Releases: master
Reviewed-on: https://review.typo3.org/47124
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Make showAccessRestrictedPages work 96/50696/8
Claus Due [Thu, 17 Nov 2016 12:14:24 +0000 (13:14 +0100)]
[BUGFIX] Make showAccessRestrictedPages work

This patch fixes a problem where setting showAccessRestrictedPages
setting in HMENU etc. did not result in the correct behavior according
to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html.

The patch changes the behavior caused by using `NONE` as
keyword in the setting.

Before: using the option renders `<a>Page title</a>` when page is inaccessible.

After: using the option renders `<a href="index.php?id=123">Page title</a>`
when page is not accessible.

Change-Id: I4364f7ec9f44e1e0b70654830efc236f20e6bf30
Resolves: #17904
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50696
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Flaky child references handling for pages_language_overlay 95/48495/5
Andreas Allacher [Wed, 8 Jun 2016 05:47:17 +0000 (07:47 +0200)]
[BUGFIX] Flaky child references handling for pages_language_overlay

IRRE records have to point to their specific localized parent record.
This works in general for tables containing records of the default
language as well as localizations. For the "pages" table this look-up
has to be extended to query from "pages_language_overlay".

Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5
Resolves: #76174
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48495
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Streamline ElementInformation template 51/50851/2
Daniel Windloff [Fri, 2 Dec 2016 12:15:30 +0000 (13:15 +0100)]
[TASK] Streamline ElementInformation template

- Change "Show" button to btn-default
- Use infobox for missing files
- Streamline button order and groups
    - preview / edit
    - history
    - opens list module

Resolves: #78864
Releases: master
Change-Id: I1e74b5e5d75a0678ab385b40f53802a30028980a
Reviewed-on: https://review.typo3.org/50851
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Respect SQL table names max length in install tool 83/50583/5
Markus Hoelzle [Thu, 10 Nov 2016 19:47:14 +0000 (20:47 +0100)]
[BUGFIX] Respect SQL table names max length in install tool

Respect the max length of 64 chars in sql if removing (renaming)
an SQL table. Add unit test.

Resolves: #78636
Releases: master
Change-Id: I5f5d4b239f467a205edfdceeac97da5625631a83
Reviewed-on: https://review.typo3.org/50583
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Rothmund <alexander@rothmund.ch>
Tested-by: Alexander Rothmund <alexander@rothmund.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Reduce expensive calls in AbstractMenuContentObject 52/50652/4
Claus Due [Mon, 14 Nov 2016 14:21:43 +0000 (15:21 +0100)]
[BUGFIX] Reduce expensive calls in AbstractMenuContentObject

This patch reduces the number of SQL queries and PHP calls
which get performed when rendering menus. The patch has
two parts:

* Runtime cache is used to remember a generated link and
  is given a cache identifier which includes a hash of all
  parameters which may affect the link.
* Runtime cache is used to remember the decision if a page
  is a submenu.

The item rendering function is called every time the same page
is rendered in any menu in the same request, and the decision
function to check if page is a sub-menu is called at least three
times with the same UID when generating a menu. Both of these
implements together reduce the necessary re-calling of methods
which generate the same output given the same arguments.

Change-Id: Idd6225081e8fb3f8160270af3d865b48208b756e
Releases: master, 7.6
Resolves: #78693
Reviewed-on: https://review.typo3.org/50652
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Alder <dalder@snowflake.ch>
Tested-by: Daniel Alder <dalder@snowflake.ch>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Reset hidden field information in FormViewhelper 86/50486/2
Nicole Cordes [Wed, 2 Nov 2016 23:26:04 +0000 (00:26 +0100)]
[BUGFIX] Reset hidden field information in FormViewhelper

If a checkbox or a multiple selectbox is rendered, a hidden field is
automatically inserted before to send an empty default value. Field
information are stored within an own viewHelperVariableContainer
variable. After a form is rendered, this information has to be reset to
be able to render another form with same field names. This patch adds
the missing reset of the hidden field information.

Resolves: #78551
Releases: master, 7.6, 6.2
Change-Id: I3cde5618d07cae39b7841875504471cb2341dc17
Reviewed-on: https://review.typo3.org/50486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now 86/50786/3
Michael Oehlhof [Sun, 27 Nov 2016 13:36:39 +0000 (14:36 +0100)]
[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now

Resolves: #76408
Releases: master, 7.6
Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563
Reviewed-on: https://review.typo3.org/50786
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Gleb Levitin <gleb.levitin@dkd.de>
Tested-by: Gleb Levitin <gleb.levitin@dkd.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Add missing type for method getServicePathStatus 44/50844/5
Wouter Wolters [Thu, 1 Dec 2016 22:09:47 +0000 (23:09 +0100)]
[TASK] Add missing type for method getServicePathStatus

Small other code cleanups are done as well.

Resolves: #78861
Releases: master
Change-Id: I983e1f76d8ad46dd4d6c231b99b41ab8f05fe454
Reviewed-on: https://review.typo3.org/50844
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[FEATURE] ViewHelpers f:form.select.option and f:form.select.optgroup 81/48281/10
Claus Due [Tue, 24 May 2016 13:56:56 +0000 (15:56 +0200)]
[FEATURE] ViewHelpers f:form.select.option and f:form.select.optgroup

Allows manually defining all options and optgroups for
the f:form.select parent field as tag contents of the
select field. The added ViewHelpers are TagBasedViewHelpers
which means they support all standard HTML attributes.

Note that while tag content rendering is now supported,
it is *STILL* not possible to create ``<option>`` tags
manually - you *HAVE* to use the form fields!

Change-Id: I5f122f746a5309671ad0faf2feccda2d29fef4c7
Releases: master
Resolves: #29399
Reviewed-on: https://review.typo3.org/48281
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] FormEngine suggest wizard in flex form sections 39/50839/3
Christian Kuhn [Thu, 1 Dec 2016 19:29:25 +0000 (20:29 +0100)]
[BUGFIX] FormEngine suggest wizard in flex form sections

The suggest wizard does not work in FormEngine flex form
section containers for existing containers.

The patch splits the ajax controller action and the FormEngine
wizard display into two classes to have a dedicated entry point
for the ajax action and refactors the flex form field configuration
search logic to find the correct configuration for existing
containers, too.

Change-Id: Ia870618629943b1f3c665cb3a10a7f3769a02540
Resolves: #78558
Releases: master
Reviewed-on: https://review.typo3.org/50839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Valentin Funk <valentin.funk@computerfabrik.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] Enforce cHash argument for Extbase actions 76/49976/20
Helmut Hummel [Wed, 21 Sep 2016 20:26:16 +0000 (23:26 +0300)]
[FEATURE] Enforce cHash argument for Extbase actions

TypoScriptFrontendController::reqCHash() is now called for Extbase
frontend plugin actions just like they were usually called for the
legacy AbstractPlugin.

This throws a 404, if plugin arguments are present, but cHash is not,
which would also happen, if the plugin arguments were added
to "cHashRequiredParameters" configuration.

This provides a more reliable page caching behavior
by default and with zero configuration for extension authors.

With the feature switch "requireCHashArgumentForActionArguments" this
behavior can be disabled, which could be useful, if all actions in a plugin
are uncached or one wants to manually control the cHash behavior.

Resolves: #78002
Releases: master
Change-Id: Ic6f71c3e5c8a94a0d422372a08c944aef5663f06
Reviewed-on: https://review.typo3.org/49976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Enforce Linux Line endings in .gitattributes 91/49791/3
Kay Strobach [Fri, 2 Sep 2016 20:12:10 +0000 (22:12 +0200)]
[TASK] Enforce Linux Line endings in .gitattributes

This settings enforces LF consistently on all plattforms
and fits it to the .editorconfig

Resolves: #77808
Releases: master, 7.6, 6.2
Change-Id: Ibc6efbf9a2a2360d84aa0ed4c3b74ff731ef1398
Reviewed-on: https://review.typo3.org/49791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Fluidification of ElementInformationController 42/50642/8
Michael Oehlhof [Sun, 13 Nov 2016 14:01:38 +0000 (15:01 +0100)]
[TASK] Fluidification of ElementInformationController

Moved all HTML from PHP code to an own Fluid template.

Resolves: #78644
Releases: master
Change-Id: I5351ce114618c4f9a56070e51df7ebe9de983a21
Reviewed-on: https://review.typo3.org/50642
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Tested-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Valentin Funk <valentin.funk@computerfabrik.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Resolves editing problem in language mode 25/50525/3
Markus Sommer [Mon, 7 Nov 2016 15:02:21 +0000 (16:02 +0100)]
[BUGFIX] Resolves editing problem in language mode

* Resolves the problem with many languages
* Set width to min-width to enlarge the viewport

Resolves: #78594
Releases: master, 7.6

Change-Id: I7360f620021d2614800f03da7960bb9acd2360e1
Reviewed-on: https://review.typo3.org/50525
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Fix maximum height of preview links dialog 11/49511/5
Alexander Opitz [Thu, 18 Aug 2016 15:50:02 +0000 (17:50 +0200)]
[BUGFIX] Fix maximum height of preview links dialog

If there are many previewable languages on one page the modal dialog
now will have a scroll bar for more than 4 entries, so it doesn't
break the UI any more.

Add 'modal-inner-scroll' class to modal 'show' call to let the
JS framework handle the maximum height / scroll behavior.

Resolves: #69637
Releases: master, 7.6
Change-Id: I59f91c4364d0d611c5822492b9ace513b1a45a33
Reviewed-on: https://review.typo3.org/49511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Opening be_groups records may throw exception 20/50820/2
Christian Kuhn [Thu, 1 Dec 2016 13:30:26 +0000 (14:30 +0100)]
[BUGFIX] Opening be_groups records may throw exception

The new flex form data structure handling in more picky and throws
exception if a given data structure identifier can not be resolved.
The FormEngine logic that displays exclude fields of flex forms
has to do some guess work to find possible data structures. This
may fail, resulting in an exception.
The patch changes the according general exception to a specific one,
catches it in the find flex form access rights logic, and adds
more docu on what exactly is happening in this code.

Change-Id: I2b808cbe804ba4ab967c8d95b17c0a12ec65ffd4
Resolves: #78852
Related: #78581
Releases: master
Reviewed-on: https://review.typo3.org/50820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Alexander Rothmund <alexander@rothmund.ch>
Tested-by: Alexander Rothmund <alexander@rothmund.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Reset FormViewHelper on execution 04/49104/10
Helmut Hummel [Tue, 19 Jul 2016 14:23:36 +0000 (16:23 +0200)]
[BUGFIX] Reset FormViewHelper on execution

This commit ensures that the FormViewHelper is in a clean state and
can render the required hidden fields (again).

Resolves: #77097
Releases: master, 7.6, 6.2
Change-Id: I82f90ee7c0aaf44cd48a9abde6dbb012f536543e
Reviewed-on: https://review.typo3.org/49104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FOLLOWUP][TASK] Remove support for transForeignTable in TCA 45/50845/2
Oliver Hader [Fri, 2 Dec 2016 09:44:49 +0000 (10:44 +0100)]
[FOLLOWUP][TASK] Remove support for transForeignTable in TCA

Resolves: #78191
Releases: master
Change-Id: I944601b8ccd2c2aa5c15bd7473eae5f4246d52a3
Reviewed-on: https://review.typo3.org/50845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Fluidification of ReplaceFileController 26/50726/3
Michael Oehlhof [Thu, 1 Dec 2016 12:27:49 +0000 (13:27 +0100)]
[TASK] Fluidification of ReplaceFileController

Resolves: #78764
Releases: master
Change-Id: I0cdedd33540a917ba7744f3dad96c7b728967fad
Reviewed-on: https://review.typo3.org/50726
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Alexander Rothmund <alexander@rothmund.ch>
Tested-by: Alexander Rothmund <alexander@rothmund.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years agoRevert "[BUGFIX] ResourceCompressor must deal with absolute web paths" 43/50843/3
Wouter Wolters [Thu, 1 Dec 2016 21:35:55 +0000 (22:35 +0100)]
Revert "[BUGFIX] ResourceCompressor must deal with absolute web paths"

This reverts commit 1d65ffe0f772e56dc0e19b8ffc84bf1a498cbbfd.

Resolves: #78856
Related: #78803
Change-Id: I5ef82b6b5c32de798b6d2677bc9a6dd6089d386a
Reviewed-on: https://review.typo3.org/50843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Alexander Rothmund <alexander@rothmund.ch>
Tested-by: Alexander Rothmund <alexander@rothmund.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][TASK] Move language files in ext:lang to Resources folder 42/50842/2
Wouter Wolters [Thu, 1 Dec 2016 21:12:11 +0000 (22:12 +0100)]
[FOLLOWUP][TASK] Move language files in ext:lang to Resources folder

Move missed parts during rebase in MoveElement.html

Resolves: #78647
Releases: master
Change-Id: I1e907235766fc83e735f3a452f375cf15bf61996
Reviewed-on: https://review.typo3.org/50842
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Alder <dalder@snowflake.ch>
Tested-by: Daniel Alder <dalder@snowflake.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[!!!][TASK] Remove support for transForeignTable in TCA 19/50819/9
Johannes Goslar [Thu, 1 Dec 2016 12:43:48 +0000 (13:43 +0100)]
[!!!][TASK] Remove support for transForeignTable in TCA

Remove support for transForeignTable and transOrigPointerTable in TCA.
More details in Breaking-78191-RemoveSupportForTransForeignTableInTCA.rst

Resolves: #78191
Releases: master
Change-Id: Ibd7e1a963fdbf84ca7f4b5926b4a8cd02ba24631
Reviewed-on: https://review.typo3.org/50819
Reviewed-by: Valentin Funk <valentin.funk@computerfabrik.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Karma Bootstrap does not use proper base path 40/50840/2
Oliver Hader [Thu, 1 Dec 2016 20:43:03 +0000 (21:43 +0100)]
[BUGFIX] Karma Bootstrap does not use proper base path

Resolves: #78859
Releases: master
Change-Id: I4b6ca84c119430d87d5d603ad07ccb8ea76f2f91
Reviewed-on: https://review.typo3.org/50840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Force string casting of $parserList 38/50838/3
Andreas Fernandez [Thu, 1 Dec 2016 19:05:41 +0000 (20:05 +0100)]
[BUGFIX] Force string casting of $parserList

The method `BackendUtility::explodeSoftRefParserList()` checks whether
`$parserList` is an empty string. This check may fail, as the variable may
be null instead. `$parserList` is now casted to a string, which converts
null to an empty string.

Resolves: #78858
Releases: master, 7.6
Change-Id: Ia833fd64f3349c5856a879e917bb3cd6f581caa0
Reviewed-on: https://review.typo3.org/50838
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Avoid RTE context menu collapse to arrows only 79/50779/3
Claus Due [Fri, 25 Nov 2016 11:57:44 +0000 (12:57 +0100)]
[BUGFIX] Avoid RTE context menu collapse to arrows only

Solves an issue in Chrome where calculating the height of
the editor window returns zero. Solved by hardcoding a
minimum context menu height of 150 pixels; applied via
Math.max()'ing the resolved height and 150.

Change-Id: Ie79507d661128f6aff31c12573b9c020b913ec8a
Resolves: #78795
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50779
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Fluidification of CreateFolderController 19/50719/5
Michael Oehlhof [Sun, 20 Nov 2016 20:38:29 +0000 (21:38 +0100)]
[TASK] Fluidification of CreateFolderController

Resolves: #78756
Releases: master
Change-Id: Ia2bb170811c310d16154529bb2d4af27a1c6412b
Reviewed-on: https://review.typo3.org/50719
Reviewed-by: Valentin Funk <valentin.funk@computerfabrik.de>
Tested-by: Valentin Funk <valentin.funk@computerfabrik.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Remove has-call to caching framework in explodeSoftRefParserList 52/50752/3
Wouter Wolters [Tue, 22 Nov 2016 22:22:07 +0000 (23:22 +0100)]
[TASK] Remove has-call to caching framework in explodeSoftRefParserList

No need to call has on the caching framework in the function
explodeSoftRefParserList. Furthermore we do not need to store false
to the runtime cache if parseList is an empty string.

Resolves: #78773
Releases: master
Change-Id: Iaa3fae35d4d07a78eb0fde8efc892a9ddb46b974
Reviewed-on: https://review.typo3.org/50752
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Small code cleanup in CacheHashCalculator 69/50769/3
Wouter Wolters [Thu, 24 Nov 2016 22:13:48 +0000 (23:13 +0100)]
[TASK] Small code cleanup in CacheHashCalculator

Resolves: #78814
Releases: master
Change-Id: I18475fa8daa006e8887cf4b1c3855bf0e870fdc6
Reviewed-on: https://review.typo3.org/50769
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate callUserFunction "&" token for persistent objects 93/50693/6
Benni Mack [Thu, 17 Nov 2016 11:04:16 +0000 (12:04 +0100)]
[TASK] Deprecate callUserFunction "&" token for persistent objects

The method GeneralUtility::callUserFunction() method allows
to call "&" to put this logic into a "persistent" pool. We already
have the SingletonInterface which should be used for objects
that should be persistent.

Currently there are two "persistent object pools", one for
makeInstance and one for callUserFunc, which makes it very hard
to understand which object is used when. Reducing complexity
and using the SingletonInterface everywhere should be the best practice.

Resolves: #78733
Releases: master
Change-Id: I6d3c57056c2b5ab411a9b9f488dc48c757b4a148
Reviewed-on: https://review.typo3.org/50693
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[FOLLOWUP][BUGFIX] Don't set resource storages permanently offline 36/50836/2
Oliver Hader [Thu, 1 Dec 2016 16:30:47 +0000 (17:30 +0100)]
[FOLLOWUP][BUGFIX] Don't set resource storages permanently offline

Resolves: #75184
Releases: master, 7.6
Change-Id: Iff4ea23dfc1e8d96c45ba675aab6484830468718
Reviewed-on: https://review.typo3.org/50836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Fluidification of MoveElementController 55/50655/5
Michael Oehlhof [Mon, 14 Nov 2016 19:02:32 +0000 (20:02 +0100)]
[TASK] Fluidification of MoveElementController

Moved all HTML from PHP code to an own Fluid template.

Resolves: #78688
Releases: master
Change-Id: If91b2e76d13679c852fdb397848bb1108e37ba48
Reviewed-on: https://review.typo3.org/50655
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gleb Levitin <gleb.levitin@dkd.de>
Tested-by: Gleb Levitin <gleb.levitin@dkd.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Remove unused language labels from EXT:sys_action 66/50466/7
Wouter Wolters [Mon, 31 Oct 2016 22:19:55 +0000 (23:19 +0100)]
[!!!][TASK] Remove unused language labels from EXT:sys_action

The labels that are not used anymore in the core are removed.

Resolves: #78855
Releases: master
Change-Id: I8b7ac0ee8670f7abbf57f275e20c8c4fbbf36436
Reviewed-on: https://review.typo3.org/50466
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Valentin Funk <valentin.funk@computerfabrik.de>
Tested-by: Valentin Funk <valentin.funk@computerfabrik.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Show errors on ajax file actions 53/50753/3
Alexander Opitz [Wed, 23 Nov 2016 11:43:21 +0000 (12:43 +0100)]
[BUGFIX] Show errors on ajax file actions

Respond with status code 500 on ajax file actions, so JS can differ
between success and failure.

Resolves: #78776
Related: #69916
Releases: master, 7.6
Change-Id: I166cb86be64a26d1a3b44bfba626bba3fd151df1
Reviewed-on: https://review.typo3.org/50753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gleb Levitin <gleb.levitin@dkd.de>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] Introduce fluid data-processor for menus 08/50608/5
Benjamin Kott [Sat, 12 Nov 2016 15:18:32 +0000 (16:18 +0100)]
[FEATURE] Introduce fluid data-processor for menus

This menu processor utilizes HMENU to generate a json encoded menu
string that will be decoded again and assigned to FLUIDTEMPLATE as
variable. Additional DataProcessing is supported and will be applied
to each record.

Resolves: #78672
Releases: master
Change-Id: Ic7aa230f8fbd524df77a54bf92f4145d6eadaf3e
Reviewed-on: https://review.typo3.org/50608
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Disable not required checks on cli 77/50777/6
Markus Sommer [Fri, 25 Nov 2016 10:54:27 +0000 (11:54 +0100)]
[BUGFIX] Disable not required checks on cli

* $_SERVER['HTTP_HOST'] is not avalible on cli
* Mostly max_execution_time is not set on cli

Resolves: #78786
Releases: master, 7.6
Change-Id: If19dab862e2762fab5fec113c93eba80f75a4aaf
Reviewed-on: https://review.typo3.org/50777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Eglseder <typo3org@vxvr.de>
Tested-by: Oliver Eglseder <typo3org@vxvr.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Add missing space between language flag and title language diff 07/50807/2
Gianluigi Martino [Tue, 29 Nov 2016 16:00:44 +0000 (17:00 +0100)]
[TASK] Add missing space between language flag and title language diff

Adding some space between language flag and title in language diff column

Releases: master, 7.6
Resolves: #78707
Change-Id: Ic8f69d4ab6181c741efa880ceeec67ea7d807ace
Reviewed-on: https://review.typo3.org/50807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Move language files in ext:lang to Resources folder 84/50584/7
Wouter Wolters [Thu, 10 Nov 2016 20:15:11 +0000 (21:15 +0100)]
[TASK] Move language files in ext:lang to Resources folder

Move languages files from the root of ext:lang to
Resources/Private/Language/

Resolves: #78647
Releases: master
Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759
Reviewed-on: https://review.typo3.org/50584
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Don't set resource storages permanently offline automatically 71/50371/12
Marc Willmann [Tue, 25 Oct 2016 15:18:18 +0000 (17:18 +0200)]
[BUGFIX] Don't set resource storages permanently offline automatically

When the storage drive coudn't be initialized correctly the storage is
only put offline for the current request. The error thrown by the driver
is logged to database table sys_log as well.

Resolves: #75184
Releases: master, 7.6
Change-Id: I4b05b732f887c0679e9cdda77793e4b304ac3fdb
Reviewed-on: https://review.typo3.org/50371
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Fluidification of EditFileController 22/50722/5
Michael Oehlhof [Mon, 21 Nov 2016 13:10:06 +0000 (14:10 +0100)]
[!!!][TASK] Fluidification of EditFileController

Resolves: #78759
Releases: master
Change-Id: I2ba72aeda6d56610cc4977f222abe26d124b7f15
Reviewed-on: https://review.typo3.org/50722
Reviewed-by: Gleb Levitin <gleb.levitin@dkd.de>
Tested-by: Gleb Levitin <gleb.levitin@dkd.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] sysext/recordlist: Moved text constants to language file 98/50798/3
Michael Oehlhof [Mon, 28 Nov 2016 18:56:09 +0000 (19:56 +0100)]
[TASK] sysext/recordlist: Moved text constants to language file

Resolves: #78826
Releases: master
Change-Id: I48cab43e191d3f677a236feb9d3b74dd551e3d05
Reviewed-on: https://review.typo3.org/50798
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Alder <dalder@snowflake.ch>
Tested-by: Daniel Alder <dalder@snowflake.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Use strict type checking in TreelistCacheUpdateHooks 72/50772/3
Wouter Wolters [Thu, 24 Nov 2016 23:02:18 +0000 (00:02 +0100)]
[TASK] Use strict type checking in TreelistCacheUpdateHooks

Resolves: #78836
Releases: master
Change-Id: Ib76c95164e228ce3a8afa448cf4a9c1ba6ddec29
Reviewed-on: https://review.typo3.org/50772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix wrong indentation of PageTree in MoveElements 48/50648/2
Michael Oehlhof [Sun, 13 Nov 2016 20:46:15 +0000 (21:46 +0100)]
[BUGFIX] Fix wrong indentation of PageTree in MoveElements

Resolves: #78687
Releases: master, 7.6
Change-Id: Ibe5efa5b81e839f7bc608ca4adffe1aa2d2a9727
Reviewed-on: https://review.typo3.org/50648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] - Let FLUIDTEMPLATE mimic an actual extbase web request 14/50814/2
Ralf Zimmermann [Thu, 1 Dec 2016 02:59:11 +0000 (03:59 +0100)]
[FEATURE] - Let FLUIDTEMPLATE mimic an actual extbase web request

Adds the possibility to let the FLUIDTEMPLATE content element mimic an
actual extbase web request.
This makes it possible to access submitted data like in extbase with
...->controllerContext->getRequest()->getArguments()

Resolves: #78842
Releases: master
Change-Id: I27e34e11ae9d5526ee694825cb74b6fcc6e42061
Reviewed-on: https://review.typo3.org/50814
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gleb Levitin <gleb.levitin@dkd.de>
Tested-by: Gleb Levitin <gleb.levitin@dkd.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Fluidification of RenameFileController 25/50725/2
Michael Oehlhof [Mon, 21 Nov 2016 16:04:46 +0000 (17:04 +0100)]
[TASK] Fluidification of RenameFileController

Resolves: #78762
Releases: master
Change-Id: Ib9306710f92b8ce3cfb49ac23f4d847598a19f98
Reviewed-on: https://review.typo3.org/50725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix doubleclick-doublesubmit touchup 20/50720/10
Markus Timtner [Mon, 21 Nov 2016 10:07:58 +0000 (11:07 +0100)]
[BUGFIX] Fix doubleclick-doublesubmit touchup

If a user double-clicks fast enough on any save-button of any new record
in Chrome, the record gets submitted twice.
This fix introduces a semaphore variable in the corresponding JS
to ensure the record gets submitted only once.

Resolves: #77942
Related: #77729, #77944
Releases: master, 7.6
Change-Id: I73516b6a07b23b947e0756dea7051863546a246d
Reviewed-on: https://review.typo3.org/50720
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Streamline button order in list module / multi selection mode 15/50715/2
Daniel Windloff [Sun, 20 Nov 2016 07:09:53 +0000 (08:09 +0100)]
[TASK] Streamline button order in list module / multi selection mode

Change button order to:
- edit
- delete

- copy
- mark all

Resolves: #78753
Releases: master
Change-Id: Iff131d84a661125d5f6d1f37e481c0c0f5da2c5a
Reviewed-on: https://review.typo3.org/50715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] BackendUtility::getModuleUrl called with correct parameter count 94/50794/2
Michael Oehlhof [Mon, 28 Nov 2016 13:06:39 +0000 (14:06 +0100)]
[BUGFIX] BackendUtility::getModuleUrl called with correct parameter count

The obsolete third and fourth parameter are removed from the calls.

Resolves: #78819
Releases: master

Change-Id: I27639218b18d4e19c0dfbe91e834050c460a2b49
Reviewed-on: https://review.typo3.org/50794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Move FE user intialization into constructor 99/50799/2
Benni Mack [Tue, 29 Nov 2016 09:33:17 +0000 (10:33 +0100)]
[TASK] Move FE user intialization into constructor

Certain options are set from outside as public property,
however these options are always set and can be set from within
FrontendUserAuthentication itself.

This way, more "logic" is moved from TSFE into the appropriate
objects themselves.

Resolves: #78827
Releases: master
Change-Id: Iba0d0ff805a885895fafb09b8852679f9870dbe9
Reviewed-on: https://review.typo3.org/50799
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove unused code in GraphicsFunctions 90/50790/2
Stefan Neufeind [Mon, 28 Nov 2016 10:23:38 +0000 (11:23 +0100)]
[TASK] Remove unused code in GraphicsFunctions

$this->cmds['jpg'] gets set but is overwritten again a few
lines below.

Resolves: #78815
Releases: master
Change-Id: I9136b055e4eb3927249d8eb97486f36ad3a8976c
Reviewed-on: https://review.typo3.org/50790
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] ResourceCompressor must deal with absolute web paths 82/50782/2
Markus Klein [Fri, 25 Nov 2016 19:29:55 +0000 (20:29 +0100)]
[BUGFIX] ResourceCompressor must deal with absolute web paths

ResourceCompressor lacks the ability to compress files which are
registered with their absolute web path (as FormEngine does).
Add a check to resolve such paths correctly.

Resolves: #78803
Releases: master
Change-Id: Id42b0889243e898dfb01a018974e5db51675a15b
Reviewed-on: https://review.typo3.org/50782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FEATURE] EXT:form - integrate new form framework 11/50311/80
Ralf Zimmermann [Sat, 19 Nov 2016 12:06:19 +0000 (13:06 +0100)]
[FEATURE] EXT:form - integrate new form framework

The main purpose of this patch is to integrate a flexible framework for
building forms. It replaces the legacy 'form wizard' based on ExtJS and
the depending frontend rendering system.

The new backend 'form editor' relies on vanilla JS and jQuery.
Different JS patterns have been applied to ensure a modern architecture,
high flexibility and extensibility.

A new backend module lists all existing forms and allows the creation
of new ones. The 'mailform' content element is reworked. It lists
available forms and enables the backend editor to override certain
settings, e.g. 'finisher' settings (formerly known as 'postProcessors').

Till now it was not possible to customize and extend the 'form editor'.
To allow the registration of new finishers, validators and
pre-defined form elements a lot of architectural changes were needed.
After a long conceptional phase the team decided to remove the former
code base, backport the 'form' package of the Flow project and improve
the given concepts. The result is a new form extension. A lot of code
received major improvements and tons of additional features have been
integrated.

The list of features is long and impressive. The documentation - which
is part of a future patch - will explain the ideas, concept and
architecture as well as the functionality in detail.

This patch marks the beginning of a series of patches. Further work is
needed to implement a better UI and more tests. The currently integrated
element tree cannot be finished for now. We plan to use the new TYPO3
SVG tree but have to wait for the drag and drop implementation.
Furthermore, the old form wizard will be moved to a separate extension
for backward compatibility.

Resolves: #77910
Releases: master
Change-Id: Idde8453bc573da835959fa3e51e30f57792d98b0
Reviewed-on: https://review.typo3.org/50311
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Häfner <andreas.haefner@tritum.de>
Tested-by: Andreas Häfner <andreas.haefner@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove old language labels in EXT:setup 68/50768/2
Tymoteusz Motylewski [Thu, 24 Nov 2016 15:29:04 +0000 (16:29 +0100)]
[TASK] Remove old language labels in EXT:setup

After removing features some language labels were left alone.
condensedMode - https://forge.typo3.org/issues/24585
noMenuMode -  http://review.typo3.org/34399
showFieldHelp - https://forge.typo3.org/issues/24623
enableFlashUploader - https://review.typo3.org/#/c/19146/2
disableCMlayers - http://review.typo3.org/7334
edit_wideDocument - https://review.typo3.org/28769

Resolves: #78735
Releases: master
Change-Id: I11676633d3ba14b4063b2a365dd3f88d6377b091
Reviewed-on: https://review.typo3.org/50768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Avoid building SQL deleteClause expression if unused 84/50784/2
Claus Due [Sat, 26 Nov 2016 13:43:57 +0000 (14:43 +0100)]
[BUGFIX] Avoid building SQL deleteClause expression if unused

This patch avoids building an instance of ConnectionPool,
getting a QueryBuilder and building an expression unless
that expression is needed by the function.

Also switches a condition with else clause to an early
return guard clause (cosmetic only).

Change-Id: I804b3ff9e624aa4b8b9c760d2a5e858039b6f9b9
Resolves: #78806
Releases: master
Reviewed-on: https://review.typo3.org/50784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] T3Editor getPlugins must write to response object 81/50781/2
Markus Klein [Fri, 25 Nov 2016 19:05:40 +0000 (20:05 +0100)]
[BUGFIX] T3Editor getPlugins must write to response object

Fix the ajax request target getPlugins to write its response to
the response object and not to the request.

Moreover fix return value of setModeByFile, which is used
only once, but does not need a return value at all.

Resolves: #78802
Releases: master, 7.6
Change-Id: I840de6fe851a3c4e104c4de1ee9bd0e9c4d8f3c6
Reviewed-on: https://review.typo3.org/50781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Fix some typos in PageRepository 71/50771/2
Wouter Wolters [Thu, 24 Nov 2016 22:55:54 +0000 (23:55 +0100)]
[TASK] Fix some typos in PageRepository

Remove some old comments about not loaded TCA too.

Resolves: #78787
Releases: master
Change-Id: Ice141123b91987957101e1193c003410e9c0282f
Reviewed-on: https://review.typo3.org/50771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] addCssInlineBlock function called with too many arguments 70/50770/2
Wouter Wolters [Thu, 24 Nov 2016 22:37:17 +0000 (23:37 +0100)]
[TASK] addCssInlineBlock function called with too many arguments

addCssInlineBlock is called with 5 parameters instead of 4
in PageGenerator. We can safely remove the 5th argument.

Fixed two typos too.

Resolves: #78785
Releases: master
Change-Id: I468345b6792e7103a68858d9d7b59e657d94023a
Reviewed-on: https://review.typo3.org/50770
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[SECURITY] Disallow invalid encoding in GeneralUtility::validPathStr 44/50744/2
Benni Mack [Tue, 22 Nov 2016 10:09:45 +0000 (11:09 +0100)]
[SECURITY] Disallow invalid encoding in GeneralUtility::validPathStr

Directory names, which have an invalid UTF encoding,
cause the preg_match() to return false.
To avoid that the complete statement in GeneralUtility::validPathStr()
returns true in this case, a strict comparison against 0 is added,
so that we ensure that strings with invalid encodings are rejected
by this API method.

As a consequence UTF-16 encoded path names are rejected as well, if the
system / file system does not support them.

Resolves: #73453
Releases: master, 8.4, 7.6, 6.2
Security-Commit: c54aa56d18815aa1867ec54358ad419ea03ec205
Security-Bulletins: TYPO3-CORE-SA-2016-023, 024
Change-Id: Iedd6628050d8cdf2efe429bcd7b577f5a6d11805
Reviewed-on: https://review.typo3.org/50744
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] indexed_search/template_css: Remove useless &nbsp; 85/50685/2
Benjamin Franzke [Tue, 29 Dec 2015 06:35:47 +0000 (07:35 +0100)]
[BUGFIX] indexed_search/template_css: Remove useless &nbsp;

The seachword input field has &nbsp; appended. It's not clear why
that was ever needed. But it's kinda useless and requires quite some
css hacks to hide that, if the label and input field are inlined.

Change-Id: I0387e46c2b0e9f8ae2e9a174cf042b6d4972f18b
Releases: master, 7.6
Resolves: #78727
Reviewed-on: https://review.typo3.org/50685
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Trim input into xml2array 16/50716/2
Anja Leichsenring [Sun, 20 Nov 2016 08:42:59 +0000 (09:42 +0100)]
[BUGFIX] Trim input into xml2array

Preciding whitespace in the xml input string causes xml2array()
to fail with an error message. This whitespace is often
introduced by formatting code via IDE, so blaming the developer
only helps so far. Inserting a trim() before the input is processed
mitigates the problem.

Resolves: #78752
Releases: master, 7.6
Change-Id: I3b9d3c81b64d502e7cefef80e72bef3a1bd9b3da
Reviewed-on: https://review.typo3.org/50716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Compact clear cache button when one item exists 94/50594/5
Claus Due [Fri, 11 Nov 2016 13:50:38 +0000 (14:50 +0100)]
[BUGFIX] Compact clear cache button when one item exists

This change makes the clear cache toolbar item dynamically
either render a drop-down as it did before, or render a single
link directly if there is only a single clear cache action.

If any hooks or permissions add additional items the drop-
down is rendered again.

Change-Id: Iadac80405bf1152a849d4d4269a9bc0728b0b459
Releases: master
Resolves: #78656
Reviewed-on: https://review.typo3.org/50594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Initialize BackendUser options in constructor 96/50596/2
Benni Mack [Fri, 11 Nov 2016 15:24:42 +0000 (16:24 +0100)]
[TASK] Initialize BackendUser options in constructor

Instead of calling / setting properties from the outside, the backend
user constructor can set options like lockIP centralized.

This way, certain implementations from third-party extensions
can just instantiate the object.

Resolves: #78660
Releases: master
Change-Id: If43ca2533968b54c842cbe01531fc6c33ee5352c
Reviewed-on: https://review.typo3.org/50596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Align user dropdown with all others 07/50407/7
Georg Ringer [Fri, 28 Oct 2016 05:06:02 +0000 (07:06 +0200)]
[TASK] Align user dropdown with all others

Provide a title in the backend as well for the user dropdown
Furthermore an empty module section is prevented.

Resolves: #78475
Releases: master
Change-Id: Ie1fd96c345a9bde2c2bc3c7f3248cf56e40729a7
Reviewed-on: https://review.typo3.org/50407
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Option to define ordering of suggest wizard results 60/50460/11
Markus Klein [Mon, 31 Oct 2016 19:45:35 +0000 (20:45 +0100)]
[FEATURE] Option to define ordering of suggest wizard results

This allows to configure the ordering cirteria for suggest wizard search results.

Resolves: #78523
Releases: master
Change-Id: I4bbcbeab765b037ba3b3457a2bc9ca3323f95f59
Reviewed-on: https://review.typo3.org/50460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix API documentation for sessionTimeout 51/50651/3
Alexander Opitz [Mon, 14 Nov 2016 14:14:27 +0000 (15:14 +0100)]
[BUGFIX] Fix API documentation for sessionTimeout

Show sessionTimeout as integer.

Resolves: #78692
Releases: master
Change-Id: Ia8bb8fa48018a3c9df5791ad8b2081e20f2b0211
Reviewed-on: https://review.typo3.org/50651
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Mayer <thomas.mayer@2bis10.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] YouTubeRenderer: urlencode the origin parameter 86/50686/5
Benjamin Franzke [Thu, 17 Nov 2016 05:54:21 +0000 (06:54 +0100)]
[BUGFIX] YouTubeRenderer: urlencode the origin parameter

Commit 84ab413 (https://review.typo3.org/49416) fixed the origin
parameter to include the full host (and thus the scheme).
The full host url was not urlencoded. As the scheme contains
slashes this has to be encoded as well.

Change-Id: Ifb73dfc11ef723049729e0475eb6ac234db6a3eb
Releases: master, 7.6
Resolves: #78728
Reviewed-on: https://review.typo3.org/50686
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove all $GLOBALS['rootline'] usages 95/50695/2
Benni Mack [Thu, 17 Nov 2016 11:54:42 +0000 (12:54 +0100)]
[TASK] Remove all $GLOBALS['rootline'] usages

The getRootline() method of ExtendedTemplateService is broken
because of an incomplete replacement of the web_ts changes.

See https://review.typo3.org/#/c/50626/

The fix replaces the rootline variable in the last occurence
by the correct replacement.

Related: #78675
Resolves: #76545
Releases: master
Change-Id: Ib554679fd86230e183801e9b234a8138d4518cd3
Reviewed-on: https://review.typo3.org/50695
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix regression in RenderingContext::__construct w/o View 08/50708/6
Claus Due [Fri, 18 Nov 2016 16:38:24 +0000 (17:38 +0100)]
[BUGFIX] Fix regression in RenderingContext::__construct w/o View

This patch fixes a regression after https://review.typo3.org/#/c/50590/
which unfortunately caused some custom implementations
(e.g. static info tables extension) to fail with a PHP fatal error.

Change-Id: I61f7327208e20a973471fbfed02fe83c00d3995c
Resolves: #78746
Releases: master
Reviewed-on: https://review.typo3.org/50708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Add check for valid directory name for TCA select fileFolder 99/50699/4
Anja Leichsenring [Thu, 17 Nov 2016 16:29:43 +0000 (17:29 +0100)]
[BUGFIX] Add check for valid directory name for TCA select fileFolder

If an invalid extension name is passed to a 'EXT:...' path, the
GeneralUtility::getFileAbsFileName function returns an empty string.
This results in a scan of '\' in the first place, and the resulting
error is not helpful for finding the source of the missing icons
in the TCA select box.
A check for a valid directory name and an exception in case of
failure will help the situation.

Resolves: #78737
Releases: master, 7.6
Change-Id: I9d5159eac9b511e879144789eecb40eafcc0288c
Reviewed-on: https://review.typo3.org/50699
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] TCA tree refactoring 00/50700/8
Christian Kuhn [Thu, 17 Nov 2016 17:51:13 +0000 (18:51 +0100)]
[TASK] TCA tree refactoring

The patch refactors the TCA tree form engine data calculation.

The tree now works with "new" (not yet persisted) records, even if
the record has types in combination with flex forms. For instance,
a new ext:news tt_content element now renders the category tree
within flex forms, even in new tt_content records that have not been
saved.

The TCA tree no longer fetches all items when opening a record initially,
but defers that to the ajax request. This gives a massive performance
improvement on initial load of a record if the displayed TCA tree is bigger.

The ajax request itself now compiles only data of the requested TCA field,
also resulting in a significant performance improvement.

As example, ext:styleguide "elements select" is now rendered much quicker
and the single ajax calls per tree are reduced from about 4 seconds to less
than a second each with my test data.

Change-Id: If3c4c1779f5fe1510ffc13d1c9f1151bddab13e9
Resolves: #78744
Releases: master
Reviewed-on: https://review.typo3.org/50700
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Update session id in user property 01/50701/2
Helmut Hummel [Thu, 17 Nov 2016 23:56:47 +0000 (23:56 +0000)]
[BUGFIX] Update session id in user property

The session id is also additionally stored in the
user property array in AbstractUserAuthentication.
When regenerating the session id, we must update the
session id in this user property as well, otherwise
it leads to failures in session handling (like #69763).

The workaround introduce for #69763 can stay, because
it mitigates other reasons for invalid tokens in the URL
by redirecting to the login page.

Resolves: #78739
Related: #69763
Releases: master, 7.6, 6.2
Change-Id: Ib58e6b5dacae3b9e431e662e214557411fd668f3
Reviewed-on: https://review.typo3.org/50701
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Move all CSH language files from EXT:lang to Resources/Private/Language 85/50585/3
Wouter Wolters [Thu, 10 Nov 2016 21:26:09 +0000 (22:26 +0100)]
[TASK] Move all CSH language files from EXT:lang to Resources/Private/Language

Move all CSH language files from ext:lang to Resources/Private/Language

Resolves: #78648
Releases: master
Change-Id: I88102b1291b1628e91a5e0ee9c54d648d0160a51
Reviewed-on: https://review.typo3.org/50585
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FOLLOWUP][BUGFIX] Redirect BE user to login on invalid module/route token 88/50688/3
Markus Klein [Thu, 17 Nov 2016 07:10:11 +0000 (08:10 +0100)]
[FOLLOWUP][BUGFIX] Redirect BE user to login on invalid module/route token

Resolves: #69763
Releases: master, 7.6
Change-Id: Ib5ec7e26cadb51b972ff617f23121cebd490bdb5
Reviewed-on: https://review.typo3.org/50688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Clarify code comments in GeneralUtility::getUserObj() 94/50694/2
Benni Mack [Thu, 17 Nov 2016 11:07:14 +0000 (12:07 +0100)]
[TASK] Clarify code comments in GeneralUtility::getUserObj()

The method GeneralUtility::getUserObj() already shows
that it will be exactly the same as makeInstance(), thus it will
be deprecated in TYPO3 v9.0, so the comments can be changed
accordingly already.

Resolves: #78734
Releases: master
Change-Id: I5487e8bc0d1c140110d30098e656f5205750c0f2
Reviewed-on: https://review.typo3.org/50694
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Set dimensions for custom svg TYPO3 backend logo 22/50522/10
Josef Glatz [Mon, 7 Nov 2016 12:16:10 +0000 (13:16 +0100)]
[BUGFIX] Set dimensions for custom svg TYPO3 backend logo

Width and height is automatically set for pixel based backend
logos. This patch makes sure this also is done for svg file format.

Releases: master, 7.6
Resolves: #78590
Change-Id: Iff1dddc827d002e10fd4ec6f3b57bc16920b1c86
Reviewed-on: https://review.typo3.org/50522
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Redirect BE user to login on invalid module/route token 60/50660/2
Frans Saris [Tue, 15 Nov 2016 11:24:01 +0000 (12:24 +0100)]
[BUGFIX] Redirect BE user to login on invalid module/route token

Resolves: #69763
Releases: master, 7.6
Change-Id: I2d9e80b7c669c55067690aedf5a7c91256d7c28b
Reviewed-on: https://review.typo3.org/50660
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not override template processors of fluid 90/50590/4
Sascha Egerer [Fri, 11 Nov 2016 08:25:40 +0000 (09:25 +0100)]
[BUGFIX] Do not override template processors of fluid

Fluid defines it's own template processors that are currently overridden
in the TYPO3 Fluid rendering context.
This becomes important if fluid standalone adds template processors or adjusts
it's RenderingContext constructor like in
https://github.com/TYPO3/Fluid/pull/220

Change-Id: I69b044e308421665ea8c88be7789da1a4323828f
Resolves: #78651
Releases: master
Reviewed-on: https://review.typo3.org/50590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Fix login redirect_url for fresh logins 77/50677/3
Benjamin Franzke [Wed, 16 Nov 2016 13:30:23 +0000 (14:30 +0100)]
[BUGFIX] Fix login redirect_url for fresh logins

The new BE Login form API in commit 9099b64c missed to pass
$_GET['redirect_url'] into the login template, which caused
redirect_url to work only for already logged-in sessions.

Change-Id: I13081f303047e93863d8ce820d8e4fade0cea89b
Resolves: #78719
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Use scheme from EnvironmentVariables for forceAbsoluteUrl 61/50661/2
Frans Saris [Tue, 15 Nov 2016 11:46:57 +0000 (12:46 +0100)]
[BUGFIX] Use scheme from EnvironmentVariables for forceAbsoluteUrl

Resolves: #78699
Releases: master, 7.6
Change-Id: If238a92e20f2382ad3b37a231992a122eff80826
Reviewed-on: https://review.typo3.org/50661
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Catch exceptions while dumping a file 80/48080/5
Wouter Wolters [Wed, 11 May 2016 14:14:53 +0000 (16:14 +0200)]
[BUGFIX] Catch exceptions while dumping a file

While dumping a file in the frontend no exceptions are
caught. When a exception happens a 500 HTTP status is thrown.

Catch all exceptions to return the correct 404 HTTP status.

Releases: master,7.6,6.2
Resolves: #76153
Change-Id: Ice7097b6a41432ec580f99185d352307c5f55394
Reviewed-on: https://review.typo3.org/48080
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Manual require_once of crawler removal 43/50643/4
Benni Mack [Sun, 13 Nov 2016 14:00:50 +0000 (15:00 +0100)]
[TASK] Manual require_once of crawler removal

The crawler is still included via a require_once in indexed_search,
even though the class loader since TYPO3 6.2 does that transparently.

So, the method is still called, which makes it impossible to
move EXT:crawler lib to a different location inside the extension.

The patch removes the call to the method, as the autoloader
fetches the file anyway.

It also deprecates the method call within EXT:indexed_search.

Resolves: #78679
Releases: master
Change-Id: I9654b89a520fe0aefd55a713613db794b8c88f72
Reviewed-on: https://review.typo3.org/50643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Remove leftover code for PHP locallang files 44/50644/2
Wouter Wolters [Sun, 13 Nov 2016 14:58:34 +0000 (15:58 +0100)]
[TASK] Remove leftover code for PHP locallang files

The PHP parser is removed, so we can drop the value from the default
list of available file extensions.

We do not need to check for the php file anymore in the
AbstractFunctionModule class.

Resolves: #78681
Releases: master
Change-Id: I25ea50c7a615374849394298a8b87e7bbf50a8d3
Reviewed-on: https://review.typo3.org/50644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Remove empty else statement in AbstractRecordList 45/50645/2
Wouter Wolters [Sun, 13 Nov 2016 15:10:19 +0000 (16:10 +0100)]
[TASK] Remove empty else statement in AbstractRecordList

Remove the empty else statement in AbstractRecordList which is not
needed.

Resolves: #78682
Releases: master
Change-Id: I135fe879ee6f08be1234704836fa4f2f74a5e12b
Reviewed-on: https://review.typo3.org/50645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate TypoScript option config.mainScript 03/50603/4
Benni Mack [Sat, 12 Nov 2016 12:18:22 +0000 (13:18 +0100)]
[TASK] Deprecate TypoScript option config.mainScript

The TypoScript option config.mainScript allows to set the frontend
entrypoint from "index.php" to something else.

As this has some bigger conceptual flaws (e.g. if this option is
set, backend preview will not work, as the backend preview does not
know about the selected TypoScript in the frontend), the option
is removed in favor of creating custom extensions to e.g. hook
into the frontend rendering to replace index.php.

Resolves: #78668
Releases: master
Change-Id: Idecdbc93fba33d9b8fecfa39c064fbeea4986a8d
Reviewed-on: https://review.typo3.org/50603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] selectTree pageTsConfig addItems 65/50565/10
Frank Naegler [Thu, 10 Nov 2016 10:11:46 +0000 (11:11 +0100)]
[BUGFIX] selectTree pageTsConfig addItems

Adding items for type selectTree with pageTsConfig does not
work as documented. The TCA tree needs multi-root handling
to handle that. Additionally, some slight changes in the order
of elements when items are calculated are needed.

Resolves: #78628
Releases: master
Change-Id: Iecf0225c0eeaab8ea661997cad26e68d255d8460
Reviewed-on: https://review.typo3.org/50565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add correct parameter phpDoc types in LocalizationRepository 40/50640/2
Wouter Wolters [Sun, 13 Nov 2016 13:46:13 +0000 (14:46 +0100)]
[TASK] Add correct parameter phpDoc types in LocalizationRepository

Add missing type information to phpDoc.

Resolves: #78678
Releases: master, 7.6
Change-Id: Id626c849bacc46f7a66c6936d34a71b1b2678f2f
Reviewed-on: https://review.typo3.org/50640
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] Cover t3_origuid in functional tests for Workspaces/Regular/PublishAll 73/50573/3
Tymoteusz Motylewski [Thu, 10 Nov 2016 12:01:53 +0000 (13:01 +0100)]
[TASK] Cover t3_origuid in functional tests for Workspaces/Regular/PublishAll

The t3_origuid field is now covered in functional tests for DataHandler
in workspaces module (Regular/PublishAll suite).

Releases: master, 7.6
Resolves: #78637
Change-Id: I6f10bc4973e86e559744021e1c0e0ca4c53105e8
Reviewed-on: https://review.typo3.org/50573
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Do not serialize variables for TransientMemoryBackend 00/50600/3
Claus Due [Fri, 11 Nov 2016 23:35:37 +0000 (00:35 +0100)]
[BUGFIX] Do not serialize variables for TransientMemoryBackend

This change switches the internal behavior of the VariableFrontend
when combined with the TransientMemoryBackend. Before this
patch the VariableFrontend was only capable of storing strings
and would serialize all variables it received, and unserialize all
variables it retrieves.

Rather than do this unnecessary serializing, a new contract is
implemented to indicate that the backend implementing the
contract is capable of storing non-string values, including
references to objects. When the VariableFrontend detects
this contract it skips the serialize/unserialize steps.

Change-Id: I255dbda2ae3791ad6325c5b4ad67c97e172e22f4
Releases: master, 7.6
Resolves: #78664
Reviewed-on: https://review.typo3.org/50600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Let Extension Manager API also create folders 61/50561/3
Helmut Hummel [Wed, 9 Nov 2016 21:38:20 +0000 (21:38 +0000)]
[BUGFIX] Let Extension Manager API also create folders

The API method added in for #70606 does not
create extension folders, which makes the API
incomplete and more or less useless.

Move the method call to create the folder into the API method.
Although the creation is done later then, the code in question
didn't need the folders anyway.

Resolves: #78631
Related: #70606
Releases: master, 7.6
Change-Id: I17b3527cd2c26e0bb1bdfedcb68dc7ae6064500d
Reviewed-on: https://review.typo3.org/50561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Use HTML5 input type number for backend pagination 45/50545/4
Georg Ringer [Tue, 8 Nov 2016 14:54:46 +0000 (15:54 +0100)]
[TASK] Use HTML5 input type number for backend pagination

Using the type number for the pagination page field improves the
usability.

Resolves: #78608
Releases: master, 7.6
Change-Id: I963bda892bb7a0ec72b2726f6086808dd421ac1c
Reviewed-on: https://review.typo3.org/50545
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Use semver for Symfony versions 65/49965/4
Patrik Karisch [Sun, 18 Sep 2016 12:45:24 +0000 (14:45 +0200)]
[TASK] Use semver for Symfony versions

Symfony has one of the best BC promises in the PHP world. Which means it
will be never a problem to allow all new minor versions of a supported
major release, even if there are deprecations. Deprecations don't infer
with existing code.

Resolves: #77983
Resolves: #76118
Related: #73517
Releases: master, 7.6
Change-Id: I221bb61674b3e4aaa7676d0929dae2ec18e01627
Reviewed-on: https://review.typo3.org/49965
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Resolves extension dependencies recursively 02/50602/7
Nicole Cordes [Sat, 12 Nov 2016 09:19:10 +0000 (10:19 +0100)]
[BUGFIX] Resolves extension dependencies recursively

Currently it is not possible to install an extension which has special
sub-dependencies (e.g. dependencies of sub-extensions). During the
installation of an extension, the download information is fetched too
early and might not contain all necessary downloads. Furthermore later
installation actions add new dependencies, which have to be resolved
before any other extension can be installed.

This patch ensures all dependencies and their sub-dependencies are
fetched before the first installation. All installation information is
now correctly ordered, as the last one added has to be the first one in
the installation queue.

Resolves: #78666
Relates: #66152
Releases: master, 7.6
Change-Id: Idd9242aa1e2ecac3deb542290627fdf9c5479edc
Reviewed-on: https://review.typo3.org/50602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove GLOBAL variables from web_ts 26/50626/3
Benni Mack [Sun, 13 Nov 2016 00:09:08 +0000 (01:09 +0100)]
[TASK] Remove GLOBAL variables from web_ts

The system extension "tstemplate" still uses a
lot of $GLOBAL objects which are only used within
the classes itself.

These are solely related to the "web_ts" (Web => Template)
module.

The code is refactored by using protected object members.

Resolves: #78675
Releases: master
Change-Id: Ic9bbcd9dfd4d9d9f9d976bead46c5d03d887aec6
Reviewed-on: https://review.typo3.org/50626
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] EM must treat line breaks correctly in extension data 16/50516/5
Markus Klein [Mon, 7 Nov 2016 00:38:47 +0000 (01:38 +0100)]
[BUGFIX] EM must treat line breaks correctly in extension data

The XML push-parser now correctly collects the data for
description and upload comment. When the data contain line breaks
the characterData() method is called multiple times
for each line of data.

Resolves: #78306
Releases: master, 7.6
Change-Id: Ibfa446b92904572d1f4530b265e94228857a5f02
Reviewed-on: https://review.typo3.org/50516
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Bind the cHash to the id of the "real" page 84/50184/4
Helmut Hummel [Tue, 11 Oct 2016 13:05:17 +0000 (15:05 +0200)]
[BUGFIX] Bind the cHash to the id of the "real" page

If a link to a mount point or a shortcut is created,
the id argument in the url points to the id of the real page,
where the mount or the shortcut points to.

This is why we need to take the id of the final page
to be hashed and not the one used to generate the link.

We also need to move cHash calculation below shortcut resolving.

Resolves: #78238
Releases: master, 7.6, 6.2
Change-Id: I96c4305c6d769a5851c17d6fdcba3cd7584fc3ec
Reviewed-on: https://review.typo3.org/50184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Do not add empty alert fieldChangeFunc to link browser URL 86/50586/2
Markus Klein [Thu, 10 Nov 2016 22:02:42 +0000 (23:02 +0100)]
[BUGFIX] Do not add empty alert fieldChangeFunc to link browser URL

Adding an empty alert message to the fieldChangeFunc array causes
the fieldChangeFunc_hash to mismatch when pagination or search
is used in the link browser popup.

Add a check for an empty value, which is already present in another
place in Core.

Resolves: #75743
Releases: master, 7.6
Change-Id: I1a15400960d577c1a2a0a905643b56533d957100
Reviewed-on: https://review.typo3.org/50586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] Close document by clicking "Save and create new one" 06/50506/5
Markus Hoelzle [Sat, 5 Nov 2016 11:29:16 +0000 (12:29 +0100)]
[TASK] Close document by clicking "Save and create new one"

Close the current document in 'Open documents' list by
clicking the "Save and create a new one" button.

Resolves: #78545
Releases: master, 7.6
Change-Id: Id401f6471132ef7b66ad35cae4b15c5f384b857e
Reviewed-on: https://review.typo3.org/50506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Cleanup BackendUserAuthentication->unpack_uc() 95/50595/3
Benni Mack [Fri, 11 Nov 2016 14:25:18 +0000 (15:25 +0100)]
[TASK] Cleanup BackendUserAuthentication->unpack_uc()

The backendUser->uc() call is called with a default value,
which is unnecessary and "looks ugly" ;).

Additionally $BE_USER calls unpack_uc() itself, basically doing
a unserialize() before, even though unpack_uc() does the same
thing.

Resolves: #78658
Releases: master
Change-Id: I492326373b61dba5cba61f24e64b31fddf9a2142
Reviewed-on: https://review.typo3.org/50595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Remove htmlspecialchars for values that are used in exceptions 98/50598/3
Wouter Wolters [Fri, 11 Nov 2016 20:30:46 +0000 (21:30 +0100)]
[TASK] Remove htmlspecialchars for values that are used in exceptions

Resolves: #78663
Releases: master
Change-Id: Ic7bcc67886d66d31d2062847568d800ab4e48717
Reviewed-on: https://review.typo3.org/50598
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>