Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows 65/35665/9
Stephan Großberndt [Mon, 29 Dec 2014 19:17:07 +0000 (20:17 +0100)]
[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows

Create TYPO3\CMS\Core\Tests\BaseTestCase->getUniqueId() as a wrapper to
all uniqid()-calls from tests. This fixes fatal errors on tests in
Windows because multiple calls to uniqid() without parameters within
one second will return the same value.

TYPO3\CMS\Core\Tests\Functional\DataHandling\Framework\ActionService
does not inherit from BaseTestCase and thus gets its own implementation
for now.

Resolves: #64055
Releases: master, 6.2
Change-Id: I15536c0f1766ad89a3d8daf7260b0dbe81ef82f8
Reviewed-on: http://review.typo3.org/35665
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Faster garbage collection of caching framework 54/33254/10
Stephan Großberndt [Fri, 10 Oct 2014 22:03:31 +0000 (00:03 +0200)]
[BUGFIX] Faster garbage collection of caching framework

Do the garbage collection of the caching framework with a single DELETE
statement using JOIN instead of fetching all entries by identifier and
deleting them in a separate statement afterwards. This improves
performance especially for big installations.

For EXT:DBAL the old behaviour is kept since Oracle does neither
support subqueries nor DELETE statements with JOINs.

Removed test collectGarbageSelectsExpiredCacheEntries since
collectGarbage() doesn't perform a SELECT query anymore.

Resolves: #61814
Releases: master, 6.2
Change-Id: Ifca9065e274b85219ca81afa87724ce8884cc662
Reviewed-on: http://review.typo3.org/33254
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Reflect mysql comments in SchemaMigrator 78/21478/7
Nico de Haen [Sun, 18 Jan 2015 14:30:34 +0000 (15:30 +0100)]
[FEATURE] Reflect mysql comments in SchemaMigrator

This enables that the database migration and
comparison process includes mysql column comments.

Resolves: #49060
Releases: master

Change-Id: I8785690496bbc4fa80a8bf98ca75029c48f500f9
Reviewed-on: http://review.typo3.org/21478
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Older changelog not showing in "core" documentation 23/35323/3
Francois Suter [Thu, 11 Dec 2014 21:50:17 +0000 (22:50 +0100)]
[BUGFIX] Older changelog not showing in "core" documentation

Change the table of contents of the documentation of extension
"core", so that changes for "archived" version (i.e. 7.0) can
be easily navigated to.

Resolves: #63791
Releases: master
Change-Id: I2dbad6d449f3ae621a68ba81491865a976cc37a5
Reviewed-on: http://review.typo3.org/35323
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Disabled SystemEnvironment check in CLI context 54/35954/2
Frans Saris [Sun, 11 Jan 2015 16:47:25 +0000 (17:47 +0100)]
[BUGFIX] Disabled SystemEnvironment check in CLI context

SystemEnvironment check should not be run in CLI context as
this can give false results.

The php.ini used for CLI can be different from the one used
by the webserver. This may result in false warnings and/or
errors in the email report.

Resolves: #56569
Releases: master, 6.2
Change-Id: Id448853c98342e43f7d82fa7bab9954f2a26f949
Reviewed-on: http://review.typo3.org/35954
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add PageRepository::getPagesOverlay() 54/36054/5
Christian Weiske [Fri, 16 Jan 2015 21:25:16 +0000 (22:25 +0100)]
[FEATURE] Add PageRepository::getPagesOverlay()

PageRepository::getMenu() calls getPageOverlay() for each single page
in a menu, causing a lot of queries to the SQL database.

This patch introduces getPagesOverlay() which is able to fetch multiple
page record overlays at once.
getMenu() is changed to make use of the new method.

It reduces the number of SQL requests on an uncached "features" page
from the introduction package from 721 to 648.

Change-Id: I014c08b6b63bcee99f94567240f1835077f60f0b
Resolves: #64258
Releases: master
Reviewed-on: http://review.typo3.org/36054
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add hook to post-process countVersionsOfRecordsOnPage 71/32871/7
Oliver Hader [Thu, 18 Sep 2014 16:31:44 +0000 (18:31 +0200)]
[FEATURE] Add hook to post-process countVersionsOfRecordsOnPage

Hook to post-process BackendUtility::countVersionsOfRecordsOnPage
result. BackendUtility::countVersionsOfRecordsOnPage is used to
visualize workspace states in e.g. the page tree.

Resolves: #61725
Releases: master
Change-Id: I195167ff7989fb9b4ceeb910e2091fad9c9f475c
Reviewed-on: http://review.typo3.org/32871
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FEATURE] Support 'has*' for properties in ObjectAccess 36/28036/4
Simon Schaufelberger [Tue, 4 Mar 2014 13:28:45 +0000 (14:28 +0100)]
[FEATURE] Support 'has*' for properties in ObjectAccess

Support calling object methods starting with 'has'.

Change-Id: Iec4913203b07fee70e6f5bb3ea9d980d2febc5c9
Resolves: #56529
Releases: master
Reviewed-on: http://review.typo3.org/28036
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Support multiple UID in PageRepository::getMenu() 42/36042/7
Christian Weiske [Fri, 16 Jan 2015 12:56:18 +0000 (13:56 +0100)]
[FEATURE] Support multiple UID in PageRepository::getMenu()

Instead of accepting only a single page ID, PageRepository::getMenu()
now also supports an array of page IDs.
This can be used to fetch the child pages of several pages with a
single SQL query.

Change-Id: I8a8b434177bf9b28a6295a746113c9519bbac997
Resolves: #64257
Releases: master
Reviewed-on: http://review.typo3.org/36042
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] Improve the @param/@return/@var PHPDoc 85/35885/9
Oliver Klee [Wed, 7 Jan 2015 22:57:14 +0000 (23:57 +0100)]
[CLEANUP] Improve the @param/@return/@var PHPDoc

* use "resource" or MySQL result instead of "pointer"
* use the specific class instead of "object"
* drop the @param of some removed parameters
* fix a few typos in comments
* add the missing parameter name in some @param

This changeset does not add any type hinting in order to
not break any existing code.

Resolves: #38270
Releases: master
Change-Id: Ied64439162d45fccafd15694f56ce675b5001a71
Reviewed-on: http://review.typo3.org/35885
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Consider subfolder in absolute links 80/31780/13
Markus Klein [Thu, 24 Jul 2014 18:44:23 +0000 (20:44 +0200)]
[BUGFIX] Consider subfolder in absolute links

Ensure typolink considers the subfolder an instance might be running in
when creating absolute URLs and absRefPrefix is not set.

Resolves: #60545
Releases: master, 6.2
Change-Id: I8d3c2edc46bd01a9aa061cb695cb8795812cd305
Reviewed-on: http://review.typo3.org/31780
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] getRecordLocalization() must respect transForeignTable 92/11092/8
Martin Tepper [Wed, 9 May 2012 07:36:28 +0000 (09:36 +0200)]
[BUGFIX] getRecordLocalization() must respect transForeignTable

Function BackendUtility::getRecordLocalization() needs to respect
TCA['ctrl']['transForeignTable'] in order to work with pages table.

Change-Id: I4c1c9f0faf6de499fe094846874848c611af7cdd
Resolves: #36971
Releases: master
Reviewed-on: http://review.typo3.org/11092
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Collapsing state for ModuleMenu should be user-specific 27/34027/5
Benjamin Mack [Wed, 24 Dec 2014 01:33:21 +0000 (02:33 +0100)]
[BUGFIX] Collapsing state for ModuleMenu should be user-specific

Using SwitchUser Mode keeps the module menu
configuration (e.g. also closing help menu) the
same even if the user has switched (or does not
have the module available). This leads to unexpected
behaviour.

The change uses the new Storage API for JS
and uses the Persistent Storage instead of the
ClientStorage (localStorage) now.

Resolves: #62894
Releases: master
Change-Id: I10bb0ae5e8bc18e11646e9571a9314e5d3266ff6
Reviewed-on: http://review.typo3.org/34027
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Paginate should handle non-query-result objects 87/25687/16
Tom Ruether [Tue, 15 Jul 2014 16:09:14 +0000 (18:09 +0200)]
[FEATURE] Paginate should handle non-query-result objects

Sometimes it is necessary to use an object storage or
an array instead of a query result.

Resolves: #34944
Releases: master
Change-Id: Ibbfbb30f005f9a21d4f59e7db1d3d0c7046b6a51
Reviewed-on: http://review.typo3.org/25687
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Improve error message 'These fields are not properly updated' 07/35507/5
Georg Ringer [Tue, 16 Dec 2014 06:56:16 +0000 (07:56 +0100)]
[TASK] Improve error message 'These fields are not properly updated'

If something went wrong while updating a record via DataHandler show
the table name and record uid too instead of only the field names.

Resolves: #49000
Releases: master
Change-Id: I0e5291324ec2be511ffb12164e4c0aec6f48f096
Reviewed-on: http://review.typo3.org/35507
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] InstallStatusReport 93/36093/4
Oliver Klee [Sun, 18 Jan 2015 12:01:35 +0000 (13:01 +0100)]
[CLEANUP] InstallStatusReport

- reduce code duplication
- add some @var
- add a missing default case in a switch
- small code formatting fixes
- shorten types
- polish some comments
- add an accessor for $GLOBALS['LANG']
- move an onvertVersionNumberToInteger call out of a loop

Resolves: #64340
Releases: master
Change-Id: Iec21be743d684628b2a5845f3e3574d4a7256678
Reviewed-on: http://review.typo3.org/36093
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Hide foreign_selector if maxitems is reached 36/19336/5
Stefan Frömken [Wed, 27 Mar 2013 07:15:24 +0000 (08:15 +0100)]
[BUGFIX] Hide foreign_selector if maxitems is reached

If the number of elements is reached (maxitems) then
foreign_selector is still there. If maxitems is reached
it does not make sense keep showing this selector.

Resolves: #46552
Releases: master
Change-Id: Ic780c2dfae0fcaaf1938c142ae8731a9109ff1b0
Reviewed-on: http://review.typo3.org/19336
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Show FAL captions in Page module 13/36013/6
Mathias Schreiber [Wed, 14 Jan 2015 16:00:49 +0000 (17:00 +0100)]
[BUGFIX] Show FAL captions in Page module

The page module only showed the contents of the old field
tt_content.imagecaption.

With FAL in place we now show the description from the FAL references.

Resolves: #64281
Releases: 6.2, master
Change-Id: I868348e11e59dad3b2affc7114e3913e7f9e985a
Reviewed-on: http://review.typo3.org/36013
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Extend access control for pages 22/23922/10
Thorben Kapp [Fri, 20 Sep 2013 08:30:49 +0000 (10:30 +0200)]
[FEATURE] Extend access control for pages

Add a hook to the end of TYPO3\CMS\Frontend\Page\PageRepository->init()
to make it possible to adjust the where_hid_del and other parts which are
responsible for page visibility.

Resolves: #52131
Releases: master
Change-Id: I27a915d7c345ec09ecead00e575ddd57ed92e939
Reviewed-on: http://review.typo3.org/23922
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] RTE: Cleanup iframe initialization 98/36098/4
Stanislas Rolland [Sun, 18 Jan 2015 16:55:07 +0000 (11:55 -0500)]
[TASK] RTE: Cleanup iframe initialization

Releases: master
Resolves: #64343
Change-Id: I3be65963074d2c95f7617ac8a61ddc8b71adec8a
Reviewed-on: http://review.typo3.org/36098
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE fails to load in IE 11 with "Access denied" 94/36094/3
Stanislas Rolland [Sun, 18 Jan 2015 14:10:46 +0000 (09:10 -0500)]
[BUGFIX] RTE fails to load in IE 11 with "Access denied"

Fix identification of IE 11 as Internet Explorer by RTE.

Note: ExtJS 3.4 will still not recognize IE 11 as Internet Explorer.

Releases: master
Resolves: #55775
Change-Id: Ib2a52159f4c7ec92a3eb9a33203292be64632b13
Reviewed-on: http://review.typo3.org/36094
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make treelist cache work with bigger trees 92/36092/2
Mathias Schreiber [Sun, 18 Jan 2015 10:41:07 +0000 (11:41 +0100)]
[BUGFIX] Make treelist cache work with bigger trees

If the result of a treelist call returns more characters than a normal
TEXT field in MySQL can handle TYPO3 acts unpredictable because of
a corrupted results in the query.
Changing the field to mediumtext for the time being should cover most
usecases.

Resolves: #22982
Releases: master
Change-Id: I8572accfd97101c80634bbd91abaff80e87f20d0
Reviewed-on: http://review.typo3.org/36092
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Replace strlen() with === for zero length check 94/27794/10
Markus Klein [Sun, 23 Feb 2014 10:21:20 +0000 (11:21 +0100)]
[CLEANUP] Replace strlen() with === for zero length check

It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef
Resolves: #54091
Releases: master
Reviewed-on: http://review.typo3.org/27794
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Add attribute "multiple" to f:form.upload viewhelper. 94/33194/7
Jost Baron [Tue, 7 Oct 2014 20:26:45 +0000 (22:26 +0200)]
[FEATURE] Add attribute "multiple" to f:form.upload viewhelper.

This makes it possible to upload multiple files with one upload field.

Resolves: #47666
Releases: master
Change-Id: If048a75d20472ee4bedbd64912a4f2d4a5c0205d
Reviewed-on: http://review.typo3.org/33194
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Respect HTTP headers from JsonView 39/34839/8
Helmut Hummel [Sun, 30 Nov 2014 22:16:46 +0000 (23:16 +0100)]
[BUGFIX] Respect HTTP headers from JsonView

When rendering the json view, headers are set to the response
which are then sent by Extbase after the plugin is rendered.

However this takes place before the core (TypoScriptFrontendController)
sends the same header unless deactivated.

This change adds a new property to TypoScriptFrontendController to
be able for plugins to set the content type header to be sent.

Additionally the JsonView now makes use of this.

This is a temporary solution unless we have a proper
request/response model for frontend rendering.

Releases: master
Resolves: #60624
Change-Id: I29fa92e21495864a3c7777bbb0bc8e375267850e
Reviewed-on: http://review.typo3.org/34839
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Trim submitted login-form-data before usage 43/35943/7
Stefan Neufeind [Sat, 10 Jan 2015 01:06:05 +0000 (02:06 +0100)]
[TASK] Trim submitted login-form-data before usage

Trimming form-data prevents common errors with copied
spaces, tabs or linebreaks in the formfields.

Change-Id: Id1ead90ef405c2c944f4c30e1e61e63597355b79
Resolves: #64229
Releases: master
Reviewed-on: http://review.typo3.org/35943
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Improve error reporting on fixture loading 45/36045/2
Christian Weiske [Fri, 16 Jan 2015 14:53:47 +0000 (15:53 +0100)]
[TASK] Improve error reporting on fixture loading

Show the actual SQL error that happened when loading a fixture
file in the functional tests fails.

Change-Id: I1a7620a3fe1c37ed017f37b16a516b969319353e
Resolves: #64313
Releases: master
Reviewed-on: http://review.typo3.org/36045
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Standalone- and TemplateView must not require ucfirst file names 12/34812/26
Markus Klein [Thu, 27 Nov 2014 14:13:18 +0000 (15:13 +0100)]
[BUGFIX] Standalone- and TemplateView must not require ucfirst file names

There's no reason to require ucfirst file names for Layouts and Partials.
This patch allows free naming of Layouts, Partials and Templates.
For best performance we really suggest to stick to UpperCamelCase though.

Change-Id: I04049e2cd248288efb97e06cac3b5d8000fd1d52
Resolves: #63367
Resolves: #58087
Resolves: #64049
Releases: master
Reviewed-on: http://review.typo3.org/34812
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add a check if TYPO3 version is maintained 11/35811/7
Frederic Gaus [Tue, 6 Jan 2015 08:08:51 +0000 (09:08 +0100)]
[FEATURE] Add a check if TYPO3 version is maintained

Modifies the status report of the install tool. Currently only
bugfix releases are taken into account. With this patch the reports
module will also show an error when the minor version is outdated
(e.g. 7.0 after the 7.1 release)

Change-Id: Ia147d5a4233b225bba435af590f72b77024181fa
Releases: master
Resolves: #62649
Reviewed-on: http://review.typo3.org/35811
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Passwords must be encrypted when saving records 12/35812/2
Nils Heuermann [Tue, 6 Jan 2015 08:35:37 +0000 (09:35 +0100)]
[BUGFIX] Passwords must be encrypted when saving records

Due to old class names in the formevals configuration passwords were
not encrypted by saltedpasswords. Using the namespaced class names in
the configuration ensures that the evaluator methods are called.

Resolves: #64140
Releases: master
Change-Id: I4cde0465bfe0bf4eccc2e7124b0ef8f29598ce14
Reviewed-on: http://review.typo3.org/35812
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] CSS3 function calc must retain whitespace 66/35366/3
Christian Futterlieb [Fri, 14 Nov 2014 18:17:10 +0000 (19:17 +0100)]
[BUGFIX] CSS3 function calc must retain whitespace

Whitespaces within CSS3 function 'calc' must not be stripped
because otherwise browsers won't recognize it anymore.

Although the CSS3 specification requires the whitespaces around
the additive expressions (+/-) only, it might be better to not
remove any whitespace within a calc function in terms of
simplicity.. the minifying is complex enough as it already is.

Resolves: #62463
Releases: master, 6.2
Change-Id: Ied0c02e132aafa97ce9fb6b0e9930898cb17efc1
Reviewed-on: http://review.typo3.org/35366
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Allow nested array access in getData type field 40/36040/5
Mathias Schreiber [Fri, 16 Jan 2015 10:43:43 +0000 (11:43 +0100)]
[FEATURE] Allow nested array access in getData type field

In order to make Typoscript more consistent we now allow to use nested
access to arrays for the datatype "field".

Resolves: #20767
Releases: master
Change-Id: I801054175c94151b7799300c575e34a1a29c7086
Reviewed-on: http://review.typo3.org/36040
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[CLEANUP] Rename variable in addPItoST43 84/36084/2
Andreas Fernandez [Sat, 17 Jan 2015 19:20:40 +0000 (20:20 +0100)]
[CLEANUP] Rename variable in addPItoST43

Rename the variable $prefix to $suffix, since the variable holds a
suffix here.

Resolves: #64335
Releases: master
Change-Id: Ibb217cfa9f0b002ec6b269e6bd6b0bc632c8d14f
Reviewed-on: http://review.typo3.org/36084
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Improve Layout of CType Menu in page module 53/35953/13
Mathias Schreiber [Tue, 13 Jan 2015 12:01:40 +0000 (13:01 +0100)]
[TASK] Improve Layout of CType Menu in page module

CType menu will now display the selected menu_type and a headline.

Fixes: #39646
Releases: master
Change-Id: I69bf3900c791950487e57621579599437a4cc6e5
Reviewed-on: http://review.typo3.org/35953
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties 79/36079/3
Andreas Fernandez [Sat, 17 Jan 2015 17:35:38 +0000 (18:35 +0100)]
[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties

Add a closing parenthesis that got lost in commit
I355893b51cf9e02c0cdfbdaf16fd7760c5687068. Also use $db instead of
$GLOBALS['TYPO3_DB'].

Resolves: #64333
Releases: master, 6.2
Change-Id: I53a7e166215b9fa18e94228194ed1f99a5bdb3ab
Reviewed-on: http://review.typo3.org/36079
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Set range for limit field 78/36078/2
Andreas Fernandez [Sat, 17 Jan 2015 17:01:32 +0000 (18:01 +0100)]
[BUGFIX] Set range for limit field

The PHP part forces the value of "showLimit" in the record search being
between 0 and 10000. The range is applied to the form field now.

Resolves: #64332
Releases: master
Change-Id: I1e72a22dd7a09b52ee4f207adf6914470d4c3eaa
Reviewed-on: http://review.typo3.org/36078
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Make AbstractConditionMatcherTest run on HHVM 58/36058/2
Tymoteusz Motylewski [Fri, 16 Jan 2015 23:19:49 +0000 (00:19 +0100)]
[TASK] Make AbstractConditionMatcherTest run on HHVM

AbstractConditionMatcherTest contains unnecessary method mocking
which is breaking the test in HHVM

Resolves: #64326
Releases: master
Change-Id: I97e81c632b4704541873f0dcd842a527bb482273
Reviewed-on: http://review.typo3.org/36058
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add Page TSConfig overview in Web->Info 39/36039/7
Mathias Schreiber [Fri, 16 Jan 2015 11:52:18 +0000 (12:52 +0100)]
[FEATURE] Add Page TSConfig overview in Web->Info

Analog to the pagetree overview of Web->Template the module
Web->Info->TSConfig will now show a list of pages holding TSConfig
settings if pid 0 is selected.

Fixes: #19833
Releases: master
Change-Id: I83ba1e14fe12ad4d1be80a694c9d4cb40dc85e0c
Reviewed-on: http://review.typo3.org/36039
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Make array utility test do not depend on undefined behaviour 55/36055/4
Tymoteusz Motylewski [Fri, 16 Jan 2015 21:44:27 +0000 (22:44 +0100)]
[TASK] Make array utility test do not depend on undefined behaviour

ArrayUtilityTests expect that order of elements with the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation than PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Resolves: #64322
Releases: master
Change-Id: Ie48e57456eee20ff9b1a0efc0ac38413f16c5de1
Reviewed-on: http://review.typo3.org/36055
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading 35/36035/5
Stanislas Rolland [Fri, 16 Jan 2015 02:25:52 +0000 (21:25 -0500)]
[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading

It may happen, for example, when deleting an empty heading which is
followed by a paragraph, or when backspacing a paragraph or heading
which becomes merged with a preceding heading.
Remove the unwanted span element.

Releases: master, 6.2
Resolves: #59562
Change-Id: I820dfd0e39f2686e07d10b86af6deff59a57cc38
Reviewed-on: http://review.typo3.org/36035
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Incorrect identification of some key events in Chrome 59/36059/3
Stanislas Rolland [Sat, 17 Jan 2015 02:44:53 +0000 (21:44 -0500)]
[BUGFIX] RTE: Incorrect identification of some key events in Chrome

Processing of the browser event key property is incorrect and leads
to errors in Google Chrome which does not support this property.

Releases: master
Resolves: #64328
Change-Id: I79734c54169c9d639478f9da292b93233bf75c3d
Reviewed-on: http://review.typo3.org/36059
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Skip updates if InitialUpdateDatabaseSchema is needed 20/35020/2
Markus Klein [Thu, 4 Dec 2014 01:23:44 +0000 (02:23 +0100)]
[BUGFIX] Skip updates if InitialUpdateDatabaseSchema is needed

In case the InitialUpdateDatabaseSchema needs to add fields
to the database, we must not run any checks (like checkForUpdate)
of other updates, since they may require a new field to
be present already in the database, which would lead to
SQL errors.

Resolves: #63556
Releases: master
Change-Id: I39454c9bacc187276bf30fd55cd06874048d3d6a
Reviewed-on: http://review.typo3.org/35020
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Correct the type of variable $lineNumberOffset 48/36048/2
Michael Oehlhof [Fri, 16 Jan 2015 18:06:41 +0000 (19:06 +0100)]
[CLEANUP] Correct the type of variable $lineNumberOffset

The variable $lineNumberOffset is used as an integer in the whole file,
but was declared as string.

Resolves: #64316
Releases: master
Change-Id: I7c898119c91a702212c0ae2e96340e6fc604b65e
Reviewed-on: http://review.typo3.org/36048
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE: Incorrect event trigger in CopyPaste plugin 32/36032/2
Stanislas Rolland [Thu, 15 Jan 2015 20:15:19 +0000 (15:15 -0500)]
[BUGFIX] RTE: Incorrect event trigger in CopyPaste plugin

The trigger statement still uses the ExtJS syntax.

Releases: master
Resolves: #64304
Change-Id: Iacfd3e4f155efff9569f13785a87c5a649400098
Reviewed-on: http://review.typo3.org/36032
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Abbreviation record does not show up on standard pages 27/36027/2
Stanislas Rolland [Thu, 15 Jan 2015 17:11:30 +0000 (12:11 -0500)]
[BUGFIX] RTE: Abbreviation record does not show up on standard pages

Add the Abbreviation record in ext_tables.php.

Releases: master
Resolves: #64303
Change-Id: I2c8a449020097ebef753d48b3554db4f28ff0e2f
Reviewed-on: http://review.typo3.org/36027
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make output of additionalCSS valid 28/36028/4
Mathias Schreiber [Thu, 15 Jan 2015 17:13:07 +0000 (18:13 +0100)]
[BUGFIX] Make output of additionalCSS valid

INTincScript_loadJSCode no longer wraps CSS in CDATA tags.
Doing so resulted in invalid CSS markup.

Fixes: #20339
Releases: 6.2, master
Change-Id: I5e9d3ff8867c8ba5dfbdc711ba3942124e68b911
Reviewed-on: http://review.typo3.org/36028
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Incorrect tooltip of paste behaviour toggle in toolbar 26/36026/2
Stanislas Rolland [Thu, 15 Jan 2015 16:39:24 +0000 (11:39 -0500)]
[BUGFIX] RTE: Incorrect tooltip of paste behaviour toggle in toolbar

The tooltip for the paste behaviour toggle button in the toolbar
is broken.

Releases: master
Resolves: #64302
Change-Id: Ib816771627aa037af7f7dcc3686d8499b2c9dfbb
Reviewed-on: http://review.typo3.org/36026
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[CLEANUP] SqlParser 30/31730/11
Andreas Fernandez [Wed, 23 Jul 2014 07:05:08 +0000 (09:05 +0200)]
[CLEANUP] SqlParser

Introduce a few optimizations in
the SqlParser classes of "core" and "dbal".

* Change some regular expressions (see benchmark file in forge)
* Strict comparison
* Put often used variable manipulation into a new method
* Definition of $comparatorPatterns was in a while() without any
  modification on it, so make it a protected member

Resolves: #60479
Releases: master
Change-Id: Ica1d3686e30835b7540e159bb5a34127d206f054
Reviewed-on: http://review.typo3.org/31730
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE avoid exception on folder inaccessibility 05/35905/3
Markus Klein [Thu, 8 Jan 2015 14:59:55 +0000 (15:59 +0100)]
[BUGFIX] RTE avoid exception on folder inaccessibility

Catch exceptions that might occur when resolving the parent directory of
a file and the user does not have access to it.

Releases: master, 6.2
Resolves: #64187
Change-Id: I879b341e1eb4c639012da7bc7942d96131bf45b0
Reviewed-on: http://review.typo3.org/35905
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Support void elements without whitespace in parseFunc 04/36004/3
Steffen Müller [Tue, 13 Jan 2015 18:11:09 +0000 (19:11 +0100)]
[BUGFIX] Support void elements without whitespace in parseFunc

xhtml specs require void HTML elements like "<br>" to be
terminated with a "/", for example "<br />".
Whitespaces before the "/" are optional, so tags without
whitespaces are parsed by parseFunc, for example "<br/>"

Resolves: #64267
Releases: master, 6.2
Change-Id: I86a5857b93aeefbc457c309fe4fedd84578ac698
Reviewed-on: http://review.typo3.org/36004
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove width restriction for logo in backend 91/35991/2
Georg Ringer [Tue, 13 Jan 2015 11:46:16 +0000 (12:46 +0100)]
[TASK] Remove width restriction for logo in backend

Remove the restriction of 50px because it makes it very hard
to style the backend a bit different for a client, e.g. adding the
customer's name and the context.

Change-Id: I77e9f0d3e2c41565c34b8f385ba5bb7e673a8f6f
Resolves: #64260
Releases: master
Reviewed-on: http://review.typo3.org/35991
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Hidden content is displayed in view module 17/35817/4
Stefan Froemken [Tue, 6 Jan 2015 12:22:23 +0000 (13:22 +0100)]
[BUGFIX] Hidden content is displayed in view module

Since TYPO3 4.2.3 hidden content elements and hidden
pages are displayed in view page module. There are many people
in the community who wants them to be hidden by default.
This patch reactivates the old way from TYPO3 4.2.2. If you
want to see the hidden elements again you have to add
config.admPanel = 1 in your TypoScript. The checkboxes
in admPanel to display hidden records works now again.

Resolves: #20335
Releases: master, 6.2
Change-Id: I146518fbacf0b381bc7c705aa8cb6275af175712
Reviewed-on: http://review.typo3.org/35817
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add tx_indexedsearch as class alias again 07/36007/5
Mathias Schreiber [Wed, 14 Jan 2015 14:24:28 +0000 (15:24 +0100)]
[BUGFIX] Add tx_indexedsearch as class alias again

Registering a "pibase" frontend plugin with addPItoST43($_EXTKEY)
generates a TypoScript snipped for indexed_search like:

plugin.tx_indexdsearch = USER_INT
plugin.tx_indexedsearch.userFunc = tx_indexedsearch->main

The class will be instantiated and main() is called at render
time. There is no easy way to change this. In case of
indexed_search, the "old" class name "tx_indexedsearch" must
be kept as alias to the namespaced class name for the time being
to not trigger a "class not found" fatal error.

Fixes: #64280
Releases: master
Change-Id: I4f41b51b382f69a15ed4e5f19b044d5b9882ed80
Reviewed-on: http://review.typo3.org/36007
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update vfsStream to 1.4 16/36016/2
Tymoteusz Motylewski [Wed, 14 Jan 2015 18:26:36 +0000 (19:26 +0100)]
[TASK] Update vfsStream to 1.4

Update vfsStream library version as it runs nicely on hhvm.
This library is used only in unit tests.
No functional changes are expected.

Resolves: #64285
Releases: master
Change-Id: I01cce99551b012841e13bdf5f7354e6850841521
Reviewed-on: http://review.typo3.org/36016
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] RTE: Toolbar items do not wrap correctly 15/36015/2
Stanislas Rolland [Wed, 14 Jan 2015 17:07:29 +0000 (12:07 -0500)]
[BUGFIX] RTE: Toolbar items do not wrap correctly

Fix total height of some items.

Releases: master, 6.2
Resolves: #64284
Change-Id: I4c01fde183c0046885eccad37a43d3eb78fae75c
Reviewed-on: http://review.typo3.org/36015
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Modify image dialogue is broken 05/36005/2
Stanislas Rolland [Tue, 13 Jan 2015 18:55:14 +0000 (13:55 -0500)]
[BUGFIX] RTE: Modify image dialogue is broken

Fix references to undefined variables.

Releases: master
Resolves: #64244
Change-Id: Ie5b99224c3a393b866248eca046cfbfa3365c83f
Reviewed-on: http://review.typo3.org/36005
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle 00/36000/2
Andreas Fernandez [Tue, 13 Jan 2015 14:50:46 +0000 (15:50 +0100)]
[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle

The wizards in the Install Tool crash with Oracle due to improper
quoting of the values. Wrap the values with fullQuoteStr() to
ensure correct quoting for the used DBMS.

Releases: master, 6.2
Resolves: #64263
Change-Id: I355893b51cf9e02c0cdfbdaf16fd7760c5687068
Reviewed-on: http://review.typo3.org/36000
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken 55/35155/3
Andreas Fernandez [Mon, 8 Dec 2014 09:12:18 +0000 (10:12 +0100)]
[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken

Updating a table using the Oracle DBMS does not work due to improper
quoting in the oci8 datadict.

Resolves: #63659
Releases: master, 6.2
Change-Id: I831f4affebd161cfd22580506714bc6c7d70f207
Reviewed-on: http://review.typo3.org/35155
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Fix regression in prefixLocalAchors feature 89/35989/2
Helmut Hummel [Mon, 12 Jan 2015 17:23:49 +0000 (18:23 +0100)]
[BUGFIX] Fix regression in prefixLocalAchors feature

The security fix for #62723 missed an edge case were the
TypoScriptFrontendController main cObj property is not yet initialized.

Check for this case and create it.

Resolves: #63896
Releases: 4.5, 6.2, master
Change-Id: Ief9338453517e095d120007d8d13ba6405d6fbb8
Reviewed-on: http://review.typo3.org/35989
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Gassner <og@plan2.net>
Reviewed-by: georg kuehnberger <gk@plan2.net>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Peter Niederlag <peter.niederlag@typo3.org>
Tested-by: Peter Niederlag <peter.niederlag@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title 47/35947/3
Benjamin Mack [Sat, 10 Jan 2015 19:16:12 +0000 (20:16 +0100)]
[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title

If the current (!) page has a slash in the Page Name,
the first part of that page name is also displayed
in the Path at the upper right, which is not correct.

Resolves: #23179
Releases: master, 6.2
Change-Id: I1070f36f02067c291503c22822e84ee068a3e4d6
Reviewed-on: http://review.typo3.org/35947
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] cObjRenderer->prefixComment() needs parameter validation 73/35973/4
Philipp Gampe [Mon, 12 Jan 2015 17:14:17 +0000 (18:14 +0100)]
[BUGFIX] cObjRenderer->prefixComment() needs parameter validation

The method fails to validate the parameters leading to PHP notices
if the function is used incorrectly in TypoScript.

Resolves: #38969
Releases: master,6.2
Change-Id: If27d530cc70bb7ed4e9baa6f040b66ff2213223b
Reviewed-on: http://review.typo3.org/35973
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea 64/35864/4
Alexander Stehlik [Wed, 7 Jan 2015 16:04:04 +0000 (17:04 +0100)]
[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea

The comma seperated list of PIDs is not wrapped in quotes any more
to allow more than one page to be searched in.

Additionally invalid SQL queries with an empty IN parameter are
prevented by avoiding any query if the PID list is empty
and the user is locked to DB mounts.

Resolves: #64169
Releases: master, 6.2
Change-Id: I3cf35a900ea84a5f7110e8b262f7aaccb27f3267
Reviewed-on: http://review.typo3.org/35864
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] DBAL: Throw exception if query fails 65/35965/4
Andreas Fernandez [Mon, 12 Jan 2015 09:19:41 +0000 (10:19 +0100)]
[TASK] DBAL: Throw exception if query fails

Throw an exception if a SELECT query fails on DBAL to avoid subsequent
errors.

Resolves: #64245
Releases: master, 6.2
Change-Id: I7e263a3a0157200b0570be68d8153e69306acad3
Reviewed-on: http://review.typo3.org/35965
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make TCEMAIN.translateToMessage work with lang files 48/35948/2
Benjamin Mack [Sat, 10 Jan 2015 20:04:51 +0000 (21:04 +0100)]
[BUGFIX] Make TCEMAIN.translateToMessage work with lang files

The option TCEMAIN.translateToMessage that prepends
a certain text to a message was apparantly available
with the functionality of "LLL:" in the past.

TCEMAIN.translateToMessage = LLL:EXT:foobar/locallang_be.xml:translateTo

The patch re-introduces the functionality
again which was missing since at least 4.7.

See forge for further details.

Resolves: #41906
Releases: master, 6.2
Change-Id: I7f30ba7fc1d6577073e8a75840762c0912ca5d2c
Reviewed-on: http://review.typo3.org/35948
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add async property to JavaScript files 00/34000/7
Arnd Messer [Tue, 11 Nov 2014 13:40:09 +0000 (14:40 +0100)]
[FEATURE] Add async property to JavaScript files

Add a property 'async="async"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.async = 1

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #28382
Releases: master
Change-Id: I9a86edaba118370d4df9f11216998d808276b634
Reviewed-on: http://review.typo3.org/34000
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Follow up: JavaScript error in language module 62/35962/2
Andreas Fernandez [Mon, 12 Jan 2015 07:36:19 +0000 (08:36 +0100)]
[BUGFIX] Follow up: JavaScript error in language module

This patch solves a JavaScript error in the new language module when
clicking "Download all" in "Installed Languages" section. The CSS
for the icons in the topbar section is also fixed.

Resolves: #64243
Releases: master
Change-Id: I6468fa0cac71f6ad813fcbe6e498912adaead89e
Reviewed-on: http://review.typo3.org/35962
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Properly check TS conditions with key '0' 10/35910/5
Christian Futterlieb [Thu, 8 Jan 2015 18:21:09 +0000 (19:21 +0100)]
[BUGFIX] Properly check TS conditions with key '0'

Global vars and strings from array expressions with key '0' must be
checked correctly in TS conditions.
E.g. when using [globalVar = GP:myoption|0 = 1] the 0 is now
correctly evaluated.

Resolves: #64192
Releases: master, 6.2
Change-Id: I1100042670ffd458dfb81e6a6eac126dbc01a531
Reviewed-on: http://review.typo3.org/35910
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][TASK] Remove option "compat_version" 84/35684/6
Benjamin Mack [Tue, 30 Dec 2014 23:26:10 +0000 (00:26 +0100)]
[!!!][TASK] Remove option "compat_version"

The global option
$TYPO3_CONF_VARS[SYS][compat_version]
was introduced for having old frontend output
while upgrading an installation to a newer version.

For example, it was used for conditions within
CSS Styled Content before separate TS templates
for different versions were introduced.

The option mainly works within
GeneralUtility::compat_version, which
is used in several places.

In a normal installation the value equals the
constant TYPO3_branch.

The according update wizard for updating
the option is not needed anymore and is
removed without substitution.

Resolves: #24900
Releases: master
Change-Id: Id3fef21122ad92a9a5a9e90f60179b50d42b6a11
Reviewed-on: http://review.typo3.org/35684
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Cleanup and update language module 00/34200/21
Kai Vogel [Sat, 15 Nov 2014 12:26:59 +0000 (13:26 +0100)]
[TASK] Cleanup and update language module

This patch modernizes the old language module to fit
the new backend design.

Resolves: #62983
Releases: master
Change-Id: I0a607e3ed25d793bf73f6aa7721a1bb26a6078ba
Reviewed-on: http://review.typo3.org/34200
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Folders created from BE fail to set permissions 17/32917/4
Benjamin Mack [Sat, 10 Jan 2015 18:36:42 +0000 (19:36 +0100)]
[BUGFIX] Folders created from BE fail to set permissions

The created path during folder creation contains double slashes.
Therefore the function used to fix/set the permissions according to the
folderCreateMask setting aborts processing because it identifies the path
as invalid.

This patch causes the concatenation of the path elements to take care of
double slashes.

Resolves: #52309
Releases: master, 6.2
Change-Id: Ib96d6ebc40f155758bbd92cb60b87420bda34597
Reviewed-on: http://review.typo3.org/32917
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Install Tool flash messages in Step Installer styling 63/28263/3
Ernesto Baschny [Tue, 11 Mar 2014 15:45:34 +0000 (16:45 +0100)]
[BUGFIX] Install Tool flash messages in Step Installer styling

Releases: master, 6.2
Resolves: #56770
Change-Id: I17683468f82542f627c886e9234ccd443994e84c
Reviewed-on: http://review.typo3.org/28263
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] EM: Remove ExtJS 01/35901/9
Andreas Fernandez [Thu, 8 Jan 2015 13:25:01 +0000 (14:25 +0100)]
[TASK] EM: Remove ExtJS

Replaces ExtJS dialogs with the new TYPO3 modals. Additionaly, all calls
to TYPO3.l10n.localize() are replaced by accessing the TYPO3.lang array
directly.

Resolves: #63495
Related: #48867
Releases: master
Change-Id: Ibb9be75cf2fab266413e4519c9b6a93ed349e6dc
Reviewed-on: http://review.typo3.org/35901
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Remove option $TYPO3_CONF_VARS[BE][accessListRenderMode] 39/35939/4
Benjamin Mack [Fri, 9 Jan 2015 21:23:41 +0000 (22:23 +0100)]
[!!!][TASK] Remove option $TYPO3_CONF_VARS[BE][accessListRenderMode]

With the recent overhaul to optimize the selection
of access lists (permissions) in BE user / BE groups
via checkbox,
the option $TYPO3_CONF_VARS[BE][accessListRenderMode]
which was set to "checkbox" already, can be removed
as it only serves as a shorthand function
to override TCA settings for be_users and be_groups.

In the front of having strong defaults and a simpler
option list, the option is removed and all values
within be_users/be_groups are set to
renderMode=checkbox directly.

Resolves: #64226
Releases: master
Change-Id: Ic6076fb44b6bb6874041a22ee30069457a17d5a0
Reviewed-on: http://review.typo3.org/35939
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Upgrade jQuery to 1.11.2 41/35941/3
Wouter Wolters [Fri, 9 Jan 2015 21:47:10 +0000 (22:47 +0100)]
[TASK] Upgrade jQuery to 1.11.2

Resolves: #64227
Releases: master
Change-Id: I85720415412ce87e4cf156d0565865902845ef48
Reviewed-on: http://review.typo3.org/35941
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] Remove unnecessary early return in GeneralUtility::instantiateClass 34/35934/2
Frederic Gaus [Fri, 9 Jan 2015 15:50:06 +0000 (16:50 +0100)]
[CLEANUP] Remove unnecessary early return in GeneralUtility::instantiateClass

Remove unnecessary early return statement in
\TYPO3\CMS\Core\Utility\GeneralUtility::instantiateClass

Change-Id: Ia03687ad22493b9d00d64ae688c0c933a90546fa
Resolves: #64219
Releases: master
Reviewed-on: http://review.typo3.org/35934
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[CLEANUP] Use t3js class for resizeable textareas 25/35925/2
Benjamin Kott [Fri, 9 Jan 2015 11:28:38 +0000 (12:28 +0100)]
[CLEANUP] Use t3js class for resizeable textareas

We are going to remove tceform classes from the
form engine, to remain js functionality all javascript
selectors need to be prefixed with t3js.

Releases: master
Resolves: #64209
Change-Id: Ib7717678dd39c6ab0d4a3fb09ace816bd3d7ff20
Reviewed-on: http://review.typo3.org/35925
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Make typolink respect property linkAccessRestrictedPages 08/35908/7
Frederic Gaus [Thu, 8 Jan 2015 17:10:32 +0000 (18:10 +0100)]
[BUGFIX] Make typolink respect property linkAccessRestrictedPages

With this patch typolink does link access restricted pages when
the typolink configuration has $conf['linkAccessRestrictedPages']
set and config.typolinkLinkAccessRestrictedPages is set.

Without the patch, typolink does not link access restricted pages
in this configuration but takes the configuration of
config.typolinkLinkAccessRestrictedPages into account.

Change-Id: Ief1e56fa68e6818e2739d642510cf016e094e399
Resolves: #63804
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35908
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add stdWrap to sorting.direction for FILES 23/35723/3
Benjamin Mack [Fri, 2 Jan 2015 11:02:27 +0000 (12:02 +0100)]
[BUGFIX] Add stdWrap to sorting.direction for FILES

Add the missing stdWrap support for the sorting direction
property of the new FILES cObject.

Resolves: #59297
Releases: master, 6.2
Change-Id: I827f3318419824a9b125b04a09fdd4f7dde443fd
Reviewed-on: http://review.typo3.org/35723
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][FEATURE] FormEngine Checkbox to bootstrap 06/35906/10
Benjamin Kott [Thu, 8 Jan 2015 15:11:07 +0000 (16:11 +0100)]
[!!!][FEATURE] FormEngine Checkbox to bootstrap

* Streamline checkbox styling
* Add inline rendering for checkboxes
* Add responsive breakpoints

Releases: master
Resolves: #64190
Change-Id: I84d4596543131a545070103b73190a9620bda44c
Reviewed-on: http://review.typo3.org/35906
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Follow up: Remove jQueryUI left overs from EM 04/35904/3
Andreas Fernandez [Thu, 8 Jan 2015 14:47:32 +0000 (15:47 +0100)]
[CLEANUP] Follow up: Remove jQueryUI left overs from EM

Removes the now obsolete images and some more CSS definitions due to
jQueryUI removal in I85ecda2c3e0363774f3d8f3e768fec4d0b0e6fc0.

Resolves: #64188
Releases: master
Change-Id: I2b77be4d373baefcd5e4397738c20e95b0c8cce3
Reviewed-on: http://review.typo3.org/35904
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Clean up images for tt_content.imageorient 02/35902/2
Benjamin Mack [Thu, 8 Jan 2015 13:52:32 +0000 (14:52 +0100)]
[TASK] Clean up images for tt_content.imageorient

Remove the old imageorientation images
from typo3/gfx/ and take the
images from t3skin and move them
to EXT:frontend.

Also, use EXT: paths to the images
instead of relative ones.

Resolves: #64186
Releases: master
Change-Id: I5ca6e16c3c0cc02d5ed9ed463a2bf29eae58982b
Reviewed-on: http://review.typo3.org/35902
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] EM: distribution label "Official distribution" should use TWBS 11/35911/2
Benjamin Mack [Thu, 8 Jan 2015 19:36:56 +0000 (20:36 +0100)]
[BUGFIX] EM: distribution label "Official distribution" should use TWBS

Instead of using a custom-defined CSS span class,
the label "Official distribution" in the distributions section
of the EM should use the regular TWBS label styling.

Resolves: #64194
Releases: master
Change-Id: I8ecd2521c95eb8a4a287edf2839bbb3985a28de9
Reviewed-on: http://review.typo3.org/35911
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Shortcut icons now check permissions 74/35874/3
Wouter Wolters [Wed, 7 Jan 2015 18:22:41 +0000 (19:22 +0100)]
[BUGFIX] Shortcut icons now check permissions

Resolves: #36193
Releases: master, 6.2
Change-Id: Idcce6744d1b3d108daafb47103beefaf8d61c27c
Reviewed-on: http://review.typo3.org/35874
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Stefan Froemken <froemken@gmail.com>
4 years ago[BUGFIX] Allow page.config.pageTitleSeparator 50/35750/4
Benjamin Mack [Sat, 3 Jan 2015 10:22:57 +0000 (11:22 +0100)]
[BUGFIX] Allow page.config.pageTitleSeparator

The TypoScript option page.config.pageTitleSeparator
does not work currently, however the unspecific option
config.pageTitleSeparator does work.

This is due to the fact that the PageGenerator class
is preparing all options with TSFE->config and the
TemplateService class is putting everything together
with tmpl->setup which is not the consolidated config
data for this page. In order to streamline the code,
the pageTitleSeparator logic is moved
to PageGenerator where TSFE->config is used instead.

Resolves: #54410
Releases: master, 6.2
Change-Id: I677a852f6a94ea9737dade6e32e19f8b86dc9c89
Reviewed-on: http://review.typo3.org/35750
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Use block element for linebreaks in formengine 92/35892/3
Benjamin Kott [Thu, 8 Jan 2015 10:29:46 +0000 (11:29 +0100)]
[CLEANUP] Use block element for linebreaks in formengine

Linebreaks are used in the form engine to clear a row
within palettes. In transition to bootstrap we will use a
clearing block element to solve this.

Releases: master
Resolves: #64182
Change-Id: I308602e8c9399e94eb1fe02798ceea36cc166de7
Reviewed-on: http://review.typo3.org/35892
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] EM: Remove jQueryUI 99/35899/2
Andreas Fernandez [Thu, 8 Jan 2015 11:14:29 +0000 (12:14 +0100)]
[TASK] EM: Remove jQueryUI

This patch removes jQueryUI from the extension manager which is only
used to style tabs. The tabs are ported to Twitter Bootstrap.
Additionally, the now obsolete CSS gets removed and the configuration
form is cleaned up.

Resolves: #64183
Releases: master
Change-Id: I85ecda2c3e0363774f3d8f3e768fec4d0b0e6fc0
Reviewed-on: http://review.typo3.org/35899
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Deprecate TS property andWhere 00/35800/5
Georg Ringer [Mon, 5 Jan 2015 19:24:12 +0000 (20:24 +0100)]
[TASK] Deprecate TS property andWhere

As the property "where" got full stdWrap support, there is no
need to keep "andWhere".

Resolves: #25112
Releases: master
Change-Id: Iffe166047d022508e2808e681f3693859bc58041
Reviewed-on: http://review.typo3.org/35800
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Element Information 80/35880/4
Benjamin Kott [Wed, 7 Jan 2015 20:55:12 +0000 (21:55 +0100)]
[CLEANUP] Element Information

- Make preview image responsive
- Streamline fields of references
- Correct table classes and markup
- Sort columns of reference items to match recordlist
- Add record icon for references
- Add edit links for references icon and title

Releases: master
Resolves: #64178
Change-Id: I249d9cb93bf30bc91e89f524d060f8d822faba5a
Reviewed-on: http://review.typo3.org/35880
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] tstemplate: deprecate verify_TSobjects() 61/35861/5
Georg Ringer [Wed, 7 Jan 2015 13:11:12 +0000 (14:11 +0100)]
[TASK] tstemplate: deprecate verify_TSobjects()

The method
'TypoScriptTemplateObjectBrowserModuleFunctionController::verify_TSobjects'
is not used in the core and is deprecated.

Change-Id: Ia0f164e027698eae994675e7179c47b70c852de5
Resolves: #64134
Releases: master
Reviewed-on: http://review.typo3.org/35861
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Change label in BackendUserModule compare 91/35891/2
Frank Nägler [Thu, 8 Jan 2015 09:59:32 +0000 (10:59 +0100)]
[TASK] Change label in BackendUserModule compare

Fix misleading label in BackendUser module compare
function.

Resolves: #64181
Releases: master
Change-Id: I4e070af9e4d2a92ccf2c62fb17018f77a3d8ce7e
Reviewed-on: http://review.typo3.org/35891
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] Fix styling of "Deactivate t3editor" checkbox 76/35876/2
Wouter Wolters [Wed, 7 Jan 2015 19:42:14 +0000 (20:42 +0100)]
[TASK] Fix styling of "Deactivate t3editor" checkbox

Resolves: #64177
Releases: master
Change-Id: I15490a24fbbd444efcf54008824e3d203932115b
Reviewed-on: http://review.typo3.org/35876
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[CLEANUP] Remove unused images from typo3/gfx and t3skin 59/35859/2
Benjamin Mack [Wed, 7 Jan 2015 00:13:13 +0000 (01:13 +0100)]
[CLEANUP] Remove unused images from typo3/gfx and t3skin

There are a lot of images and graphics not in use anymore
that can be removed, as the core does not include
them, nor do most of them fit in the current styling scheme.

Resolves: #64155
Releases: master
Change-Id: Icc6e8bfdc315d58c5fed4b8bfd0967b968efb100
Reviewed-on: http://review.typo3.org/35859
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] FormEngine rendermode checkbox to bootstrap 27/35827/3
Benjamin Kott [Tue, 6 Jan 2015 15:46:04 +0000 (16:46 +0100)]
[CLEANUP] FormEngine rendermode checkbox to bootstrap

- convert rendermode checkbox to bootstrap
- enhance visualisation of grouping
- make groups collapsable
- move reset all to group level
- move toggle all to group level
- make lists more accessible

Releases: master
Resolves: #64146
Change-Id: I78af271fe313f75490e4dfe05c6bc800ea986e8e
Reviewed-on: http://review.typo3.org/35827
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Clean up country/language flags 15/35815/4
Benjamin Mack [Tue, 6 Jan 2015 11:27:22 +0000 (12:27 +0100)]
[!!!][TASK] Clean up country/language flags

The core has multiple places
where country flags are stored.

1. typo3/gfx/flags/ - a set of
non-normalized .gif files created by Robert
back in the days. No reference currently in
the usage inside the core since 4.5.

2. t3skin contains png files of a lot more
flags. They are used for selecting a flag
in sys_language records.

3. t3skin also delivers a sprite file with
all png icons. This is used for e.g. the list
view of sys_language records.

Thus, the core delivers flags (old ones, just a
few, as gif, not inside EXT:core) but they are
not in use since TYPO3 4.4. Also
it does not deliver sprites, however, uses the
sprites (flags-multiple etc) in list view already.

t3skin delivers a standard-set which should be
part of EXT:core, included in the right place
from the beginning so no dynamic TCA manipulation
is necessary in ext_tables.php.

Overriding of any styles, icons and sprites
is still possible.

Resolves: #64143
Releases: master
Change-Id: I6abd2325304e03e23752e4ecf0858bf67015683b
Reviewed-on: http://review.typo3.org/35815
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Backend User and Permission Module 55/35855/2
Benjamin Kott [Tue, 6 Jan 2015 23:12:01 +0000 (00:12 +0100)]
[CLEANUP] Backend User and Permission Module

- Adapting to bootstrap markup
- Introduce advanced inline-forms
- Move leftover css to t3skin for later removal

Releases: master
Resolves: #64153
Change-Id: I590746f98b0ca7fbf45be31785906b56e423b43e
Reviewed-on: http://review.typo3.org/35855
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[!!!] Deprecate DocumentTemplate::table() 60/35860/2
Georg Ringer [Wed, 7 Jan 2015 11:00:03 +0000 (12:00 +0100)]
[!!!] Deprecate DocumentTemplate::table()

The method "table" of the class DocumentTemplate is deprecated.

Change-Id: Iccd5763a5ef45450d6d6d67adf121efa1e56709c
Resolves: #62329
Releases: master
Reviewed-on: http://review.typo3.org/35860
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Correct submit btn styles in EM 58/35858/2
Benjamin Mack [Tue, 6 Jan 2015 23:29:44 +0000 (00:29 +0100)]
[BUGFIX] Correct submit btn styles in EM

Adding a "btn btn-default" class to the submit
button in the "Get Extensions" view to
align with the rest of the TWBS styling.

Resolves: #64154
Releases: master
Change-Id: I76414d95b8474cbce6c5fd93994f3549756da462
Reviewed-on: http://review.typo3.org/35858
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Change DB field sys_filemounts.base from tinyint to integer 54/35854/3
Benjamin Mack [Tue, 6 Jan 2015 23:06:04 +0000 (00:06 +0100)]
[BUGFIX] Change DB field sys_filemounts.base from tinyint to integer

sys_filemounts.base holds a reference to a storage, which should
be of DB type "int" as the storage uid is an integer itself as well.

It was a tinyint(4) type and is changed now to int(11).

Resolves: #57584
Releases: master, 6.2
Change-Id: I015293c41d64ba9145a03a6c2b9316c93e7d9e1f
Reviewed-on: http://review.typo3.org/35854
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make pagination inputfield working in recordlist 48/35848/4
Benjamin Kott [Tue, 6 Jan 2015 20:29:53 +0000 (21:29 +0100)]
[BUGFIX] Make pagination inputfield working in recordlist

- Correct inputfield refresh in recordlist
- Unify styling for fluid BE pagination widget and record list

Releases: master
Resolves: #64151
Change-Id: I341cad6bcbe7762ff4adc402dbc391732c706311
Reviewed-on: http://review.typo3.org/35848
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove uc option helpText completely 49/35849/2
Wouter Wolters [Tue, 6 Jan 2015 22:14:30 +0000 (23:14 +0100)]
[TASK] Remove uc option helpText completely

This was already removed since 4.5 but a leftover
still exists in the permission module.

Resolves: #64152
Releases: master
Change-Id: I17a084dc997ee9407edab014a21709b8a63405aa
Reviewed-on: http://review.typo3.org/35849
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>