Packages/TYPO3.CMS.git
6 years ago[TASK] Raise submodule pointer 64/18964/2
Christian Kuhn [Fri, 15 Mar 2013 23:00:46 +0000 (00:00 +0100)]
[TASK] Raise submodule pointer

Change-Id: Id68b495581b7ee0bff119031fd24dd01c4a1a5b8
Reviewed-on: https://review.typo3.org/18964
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Importing extensions from repository fails 62/18962/2
Christian Kuhn [Fri, 15 Mar 2013 21:54:00 +0000 (22:54 +0100)]
[BUGFIX] Importing extensions from repository fails

If importing the extension list from TER, an incoming XML extension
row has a field 'category' that contains either a string like
'plugin' or a category number.
The list is persisted to the 'extension' repository. In the
database, the category is stored as integer. There is a mapping
function in the extension model to get the integer category
index from given XML input. The method is faulty and returns
strings instead of an index if the given category is a string
itself. This results in database errors during insert.

The patch fixes the method, renames it along the way and adds
unit tests to document desired behavior.

Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1
Fixes: #46115
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18962
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGIFX] Extra output block backend thumbnails 59/18959/2
Francois Suter [Tue, 12 Feb 2013 16:09:14 +0000 (17:09 +0100)]
[BUGIFX] Extra output block backend thumbnails

If some inclusion causes output when viewing image thumbnails
in the backend, the output will be broken. Adding a call to
ob_clean() ensures that this does not happen.

Resolves: #31953
Releases: 6.1, 6.0
Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26
Reviewed-on: https://review.typo3.org/18959
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Fix wrong column title in web>list for field colpos" 42/18942/4
Christian Kuhn [Fri, 15 Mar 2013 15:02:19 +0000 (16:02 +0100)]
Revert "[BUGFIX] Fix wrong column title in web>list for field colpos"

This reverts commit 765ebd0cd992b86f8002f932bb51b2a39c0ace99

The patch triggers warnings and errors in multiple extensions. Digging
into the details shows the implementation is neither finished nor
stable. See issue #25113 for a detailed analysis.

Change-Id: I1ff1ea11feb34c71d3ee42789c3deda130aa9a0e
Related: #25113
Fixes: #45833
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18942
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 32/18932/2
Christian Kuhn [Fri, 15 Mar 2013 00:38:45 +0000 (01:38 +0100)]
[TASK] Raise submodule pointer

Change-Id: I64d97afc42424a0f6233fe645453f48c863c671c
Reviewed-on: https://review.typo3.org/18932
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LanguageController has "mixed" type annotations 20/18920/2
Wouter Wolters [Sun, 3 Feb 2013 13:11:07 +0000 (14:11 +0100)]
[BUGFIX] LanguageController has "mixed" type annotations

The LanguageController of the lang sysext throws
exceptions if the rewritten property mapper is enabled.
The type annotation 'mixed' is unknown. The patch fixed
the annotation to the correct string value to make the
property mapper happy.

Change-Id: I57ebd268d2fe82c095ccf20b581e721703fb2868
Fixes: #44672
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18920
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4 02/18902/2
Christian Kuhn [Thu, 14 Feb 2013 00:13:43 +0000 (01:13 +0100)]
[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4

APC has some slam protection that tries to prevent hammering of cache
entries. This can be disabled, but the option does not work at least
in native PHP 5.3.3 on debian squeeze. While it is no problem with
higher PHP version like the current one on travis-ci.org,
some tests are now just skipped on PHP environments knows for issues.

Change-Id: Ibbef201805b58041bb0b3e8aa16f0c1a2e366020
Resolves: #46267
Release: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18902
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private 98/18898/2
Christian Kuhn [Wed, 13 Feb 2013 23:59:20 +0000 (00:59 +0100)]
[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private

Change-Id: I7ada1e5e40067cf1faed8b2b5d338a690e921cad
Fixes: #46264
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18898
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Toolbar items with separator: fix white-space 92/18892/2
Felix Kopp [Sun, 24 Feb 2013 16:14:05 +0000 (17:14 +0100)]
[BUGFIX] Toolbar items with separator: fix white-space

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Change-Id: I09338d17848c8fc74b25e7c532d6ee329956321b
Fixes: #45795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18892
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Numeric translation keys aren't translated right in XML files 11/18211/2
Reinhard Führicht [Mon, 21 Jan 2013 08:52:35 +0000 (09:52 +0100)]
[BUGFIX] Numeric translation keys aren't translated right in XML files

When working with the "old" XML based translation files,
numeric keys aren't translated properly.
The reason is, that LocallangXmlParser uses array_merge to combine the
translation arrays of the default language and the current language.
array_merge renumbers numeric keys. Therefore, numeric key in
translation files result in wrong translations in Frontend.

Fixes: #44626
Releases: 6.0, 6.1
Change-Id: I8fdff385f681428b4cb5a3e994828a4a29305c98
Reviewed-on: https://review.typo3.org/18211
Reviewed-by: Reinhard Führicht
Tested-by: Reinhard Führicht
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Translation of a form makes the form wizard unusable 87/18887/3
Mario Rimann [Tue, 15 Jan 2013 09:20:27 +0000 (10:20 +0100)]
[BUGFIX] Translation of a form makes the form wizard unusable

As soon as the form-configuration for the form wizard gets
loaded, the leading "[Translate to XYZ:] " is stripped off to get the
wizard working (with the leading text, the form config could not
be serialized as needed and the wizard didn't show a single field).

The stripping is only done on localized records.

Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
Fixes: #39127
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/18887
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception when deleted file is in clipboard 84/18884/2
Andreas Wolf [Sun, 10 Feb 2013 17:10:54 +0000 (18:10 +0100)]
[BUGFIX] Exception when deleted file is in clipboard

When a file is deleted while it is part of a clipboard, an exception is
thrown when the clipboard is reconstituted. This exception has to be
catched, otherwise the file module will be unusable.

Change-Id: I8849644ffa7b78559c1797d85ce3cc6e01d03a74
Resolves: #43906
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18884
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager 82/18882/2
Andreas Wolf [Sat, 9 Feb 2013 14:49:32 +0000 (15:49 +0100)]
[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager

The ResourceStorage class of FAL has two inject* methods which are seen
as dependency injectors by the Extbase object manager. Thus an exception
is thrown when a ResourceStorage object is created via Extbase.

This commit changes the two method's names and adjust all usages within
the core. These methods are internal and I don't expect them to be used
anywhere else, so we don't need a backwards compatibility layer.

Change-Id: I4b73445708cf8041b505b5ea8923dc595ddaadb0
Resolves: #45319
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18882
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 64/18864/2
TYPO3 Release Team [Tue, 12 Mar 2013 16:02:47 +0000 (17:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I3c75e82765a4903ca34a19e8fac1ac5e2fdd1635
Reviewed-on: https://review.typo3.org/18864
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Old files of filelist extension are wrong 45/18845/2
Wouter Wolters [Mon, 11 Mar 2013 21:12:20 +0000 (22:12 +0100)]
[BUGFIX] Old files of filelist extension are wrong

During the namespace change the old filelist extenion files
are not correctly set. Instead of "filelist" this was replaced
with "file_list".

Fixes: #46155
Related: #45143
Releases: 6.0

Change-Id: I33ebb12163dd30d35981f45dcd465f7340bf1f5a
Reviewed-on: https://review.typo3.org/18845
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Show better error messages on failed TER update 44/18844/2
Jost Baron [Mon, 4 Mar 2013 21:38:01 +0000 (22:38 +0100)]
[TASK] Show better error messages on failed TER update

This patch shows error messages in a flash message if the ajax request
for a TER-update fails, and resets the extension manager into a sane
state, instead of showing an ever spinning wheel.

Resolves: #46030
Releases: 6.1, 6.0
Change-Id: I1cc67460a11feb206c53c12a38ad0f6db482e04a
Reviewed-on: https://review.typo3.org/18844
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make the update-from-TER link more visible 43/18843/2
Jost Baron [Mon, 4 Mar 2013 20:41:21 +0000 (21:41 +0100)]
[TASK] Make the update-from-TER link more visible

Make the "update from TER"-action in the extension manager more
visible by showing a button for it, instead of a text link.

Also moved the rendering functionality of the update link from
a viewhelper to a partial, as partials tend to be more readable
and bug free.

Resolves: #46029
Releases: 6.1, 6.0
Change-Id: If447bba28bc0dee3e7de286e1a93e062ef59843c
Reviewed-on: https://review.typo3.org/18843
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Handle symlink on extension update 42/18842/2
Philipp Gampe [Sun, 10 Mar 2013 16:15:27 +0000 (17:15 +0100)]
[BUGFIX] Handle symlink on extension update

If an extension is updated and the extension in the file
system is a symlink to a different directory, all
target directory contents is removed and the update fails.

Introduce a check for symlink and just remove the
symlink in this case.

Resolves: #46158
Releases: 6.1, 6.0
Change-Id: I112ae7192fb0edf77ebd703a61804dc09ca506a4
Reviewed-on: https://review.typo3.org/18842
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] More descriptive error message on file upload failure 40/18840/2
Philipp Gampe [Thu, 27 Dec 2012 12:34:12 +0000 (13:34 +0100)]
[TASK] More descriptive error message on file upload failure

Provide the user with more accurate information about what might have
gone wrong.

Resolves: #46160
Releases: 6.0,6.1
Change-Id: I86123b904f36ff7f6db77f2dd13f97c0a01957c3
Reviewed-on: https://review.typo3.org/18840
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Correct check for extTables script 29/18829/3
Francois Suter [Sun, 10 Mar 2013 19:42:19 +0000 (20:42 +0100)]
[BUGFIX] Correct check for extTables script

Existence of the script defined in TYPO3_extTableDef_script is
currently achieved by using file_exists(). This is insufficient
if TYPO3_extTableDef_script is defined, but empty, as
file_exists() will match "typo3conf/" and try to include it.

Resolves: #46161
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18828
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Change-Id: I9d6694228ca27cb2c446629a90e5c8636705e3e3
Reviewed-on: https://review.typo3.org/18829

6 years ago[BUGFIX] Typo in sys_log TCA 12/18812/2
Christian Kuhn [Fri, 8 Mar 2013 10:32:13 +0000 (11:32 +0100)]
[BUGFIX] Typo in sys_log TCA

Wrong table field name in sys_log TCA "detail_nr" instead of
"details_nr" triggers SQL errors in DB check -> Full search module.

Change-Id: I02298019ef29f38def0b6c204236fd6987b92bce
Releases: 6.1, 6.0
Fixes: #45887
Reviewed-on: https://review.typo3.org/18812
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong cmd example in INSTALL.txt 07/18807/2
Markus Klein [Fri, 8 Mar 2013 09:45:52 +0000 (10:45 +0100)]
[BUGFIX] Wrong cmd example in INSTALL.txt

The INSTALL.txt file has an example on how to create a link
in Windows using the MKLINK command.

Unfortunately the parameters in the example have the wrong order.

Resolves: #46119
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ida960d79e0144c15afdd7c21a9cd35466ec24545
Reviewed-on: https://review.typo3.org/18807
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install Tool: Error message gives wrong info 25/18325/3
Thomas Löffler [Sun, 17 Feb 2013 11:04:20 +0000 (12:04 +0100)]
[BUGFIX] Install Tool: Error message gives wrong info

Based on issue #45135 the change not only includes the
check for the variable length for typo_db_password, but
for typo_db, typo_db_host and typo_db_username as well.

Resolves: #45135
Releases: 4.5,4.7,6.0,6.1
Change-Id: Idcf45892a7b8836be31d2648b04252d1415e372b
Reviewed-on: https://review.typo3.org/18325
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix SQL syntax 76/18476/3
Michael Stucki [Tue, 26 Feb 2013 00:19:02 +0000 (01:19 +0100)]
[BUGFIX] Fix SQL syntax

Use single quotes to retain compatibility with PostgreSQL.

Change-Id: I07de0fea0320caed710911750240e35c66f3b679
Resolves: #45826
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18476
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow Setting colorspace in the Install Tool. 04/18804/4
Anja Leichsenring [Sat, 12 Jan 2013 10:50:37 +0000 (11:50 +0100)]
[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/18804
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Deactivating "install" extension leads to exceptions 02/18802/3
Wouter Wolters [Tue, 27 Nov 2012 21:48:44 +0000 (22:48 +0100)]
[BUGFIX] Deactivating "install" extension leads to exceptions

Uninstalling the "install" extension leads to exceptions in
required system extensions like extensionmanager or lang.

The solution is to make "install" a required extension too.

Change-Id: Id5a0ebd9400648cd7c453d98b58e8cad1d155bd8
Fixes: #43361
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18802
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] RTE: Empty paragraphs are not correctly transformed 99/18799/2
Stanislas Rolland [Tue, 11 Dec 2012 16:00:36 +0000 (11:00 -0500)]
[BUGFIX] RTE: Empty paragraphs are not correctly transformed

Problem: Empty paragraphs entered in the RTE may get lost on way to
database if no block is found in content, as well as on way to the RTE
if followed by a block.
Solution: Fix both transformations and add multiple unit test
cases.

Releases: 4.5, 4.7, 6.0, 6.1
Resolves: #36904
Resolves: #26141

Change-Id: I6c5495fb668f29267bcdeb7b44814a4bb9dc0f96
Reviewed-on: https://review.typo3.org/18799
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Clearing cache from toolbar fails in IE8 95/18795/2
Andreas Kießling [Sat, 23 Feb 2013 12:49:47 +0000 (13:49 +0100)]
[BUGFIX] Clearing cache from toolbar fails in IE8

Fix for regression in #45595 that was introduced with #36364
IE8 does not pass the click event to the handler function and thus
raises a JavaScript error. The event can be fetched from the window
object in this case.

Fixes: #45595
Releases: 6.1, 6.0, 4.7, 4.6, 4.5

Change-Id: I9ccd5c8ae660a34e404122d9dd1c816909688b3e
Reviewed-on: https://review.typo3.org/18795
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] pageNotFound_handling never happens 92/18792/3
Thorben Kapp [Sat, 2 Mar 2013 11:57:08 +0000 (12:57 +0100)]
[BUGFIX] pageNotFound_handling never happens

The function \TYPO3\CMS\Core\Utility\RootlineUtility::getRecordArray
throws a \RuntimeException that should be caught in
\TYPO3\CMS\Frontend\Page\PageRepository::getRootline. If the exception
is not caught, the page-not-found-handling is never triggered.

Fixes: #44454
Releases: 6.0, 6.1
Change-Id: I3988b46ebaa8e479ed3c70017a5dda6bc5eaceac
Reviewed-on: https://review.typo3.org/18792
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] ExtensionManagementUtility tries to include non-existing files 91/18791/2
Dmitry Dulepov [Wed, 6 Mar 2013 17:51:13 +0000 (21:51 +0400)]
[BUGFIX] ExtensionManagementUtility tries to include non-existing files

Methods createExtLocalconfCacheEntry() and createExtTablesCacheEntry()
attempt to include files without checking if they exist. This causes
PHP warnings about non-existing files and looses time in a call to
GeneralUtility::getUrl().

Change-Id: Icbee0c8e6e9e0ada1dc48ac471006b6dc59adc6d
Resolves: #46074
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18791
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update copyright year to 2013 86/18786/2
Ernesto Baschny [Thu, 7 Mar 2013 08:32:30 +0000 (09:32 +0100)]
[TASK] Update copyright year to 2013

Resolves: #46085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: Ifc1b4199f17d385cf6ef3d7bc460b1f91e367fc0
Reviewed-on: https://review.typo3.org/18786
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Update copyright year to 2013 82/18782/2
Ernesto Baschny [Thu, 7 Mar 2013 08:32:30 +0000 (09:32 +0100)]
[TASK] Update copyright year to 2013

Resolves: #46085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I970078281d129be8ffef0bef128b23354ce59ddd
Reviewed-on: https://review.typo3.org/18782
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Set TYPO3 version to 6.0.5-dev 78/18778/2
TYPO3 Release Team [Thu, 7 Mar 2013 09:26:11 +0000 (10:26 +0100)]
[TASK] Set TYPO3 version to 6.0.5-dev

Change-Id: Id80061ffec1abd6bec4592c652d7993e9b89a40b
Reviewed-on: https://review.typo3.org/18778
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.4 77/18777/2
TYPO3 Release Team [Thu, 7 Mar 2013 09:26:03 +0000 (10:26 +0100)]
[RELEASE] Release of TYPO3 6.0.4

Change-Id: I83f8cb459f776820f939ceff98d318fd3ad8a542
Reviewed-on: https://review.typo3.org/18777
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUFIX] External URL regression by jumpurl security fix 65/18765/2
Helmut Hummel [Wed, 6 Mar 2013 14:47:57 +0000 (15:47 +0100)]
[BUFIX] External URL regression by jumpurl security fix

With the jumpurl security fix, pages of type
'Link to external URL' throw a jumpurl
hash exception if called in the frontend. This typically
happens if a HMENU renders such page links.

The patch adapts the TSFE logic to write the required
hash dynamically to _GET to make the jumpurl check happy
that is called later on within the same process if
calling such a 'external url' link.

Change-Id: Ie73cd9710929c72aad4e75543f90c8618797997b
Fixes: #46071
Related: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18765
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Set TYPO3 version to 6.0.4-dev 48/18748/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:42 +0000 (12:35 +0100)]
[TASK] Set TYPO3 version to 6.0.4-dev

Change-Id: Ied84dbe8f0b087b325705329414b7db0dc73b773
Reviewed-on: https://review.typo3.org/18748
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.3 47/18747/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:33 +0000 (12:35 +0100)]
[RELEASE] Release of TYPO3 6.0.3

Change-Id: I962e723070598c7cf235bd7ff91432a38bb179ce
Reviewed-on: https://review.typo3.org/18747
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Raise submodule pointer 39/18739/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:02:55 +0000 (12:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I4c87c157f5b71a13cdb7b60ec695f15bee260b48
Reviewed-on: https://review.typo3.org/18739
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[SECURITY] Open redirection with jumpurl 32/18732/2
Franz G. Jahn [Wed, 6 Mar 2013 10:49:12 +0000 (11:49 +0100)]
[SECURITY] Open redirection with jumpurl

jumpurl allows redirect to any given URL. A hash on the url
is now required to know if the jumpurl has been created
by the system or by the outside.

The hook "jumpurlRedirectHandler" can be used to allow
redirects without hash or to custom redirects.

Fixes: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I63da18b1963ec50cd95dd49d1669c9873b7bab54
Security-Commit: db8748be003fdbd7fd179c239dd3dc92543e90bf
Security-Bulletin: TYPO3-CORE-SA-2013-001
Reviewed-on: https://review.typo3.org/18732
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Fix warning in adapter service 00/18700/2
Helmut Hummel [Tue, 5 Mar 2013 16:39:26 +0000 (17:39 +0100)]
[BUGFIX] Fix warning in adapter service

The merge of #45415 introduced a warning
because the new meta column name was
used as array key.

Skip this step when the meta column
is found to fix this issue.

Fixes: #45415
Releases: 6.1, 6.0

Change-Id: I5446104359816d0ccacf6c239b86b9b073783174
Reviewed-on: https://review.typo3.org/18700
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Do not overwrite imagecaption in content adapter 99/18699/2
Helmut Hummel [Tue, 12 Feb 2013 16:57:19 +0000 (17:57 +0100)]
[BUGFIX] Do not overwrite imagecaption in content adapter

Problem:
Create a new content element of type file links,
add a file relation and a description to this file.
Switch this element to be an image element,
add an image and a description of the image

Expected result:
An image with the image description is shown

Actual result:
An image with the description of the file is shown.

Solution:
Check if the field actually is shown in the selected
content element type.

Fixes: #45415
Releases: 6.0, 6.1

Change-Id: I3aa0e47b336cfa881c637b7f5a9e68476ded88ae
Reviewed-on: https://review.typo3.org/18222
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18699

6 years ago[BUGFIX] Fix inconsitency of file reference property getters 98/18698/2
Helmut Hummel [Tue, 12 Feb 2013 17:32:23 +0000 (18:32 +0100)]
[BUGFIX] Fix inconsitency of file reference property getters

The FileReference object has the following getters
for getting properties:

getProperties()
getReferenceProperties()
getProperty($key)
getReferenceProperty($key)

The result from these getters is inconsistent:

getReferenceProperty($key)
Returns the value of a property which is only
in the reference properties

getReferenceProperties()
Returns merged properties form the original
file and the reference properties without
respecting overriding of reference properties
if they are not set to NULL

getProperty($key)
Returns the merged value from original file
and reference, respecting the NULL override
handling. But if a property is only available
in the original file an Exception is thrown.

getProperties()
Returns merged properties form the original
file and the reference properties
respecting overriding of reference properties
if they are not set to NULL
Properties only available in the original file
will be available in the resulting array.

Streamline the behaviour so that all getters
starting with "getReference" will only return
the properties of the reference record and all
other will return the merged properties but
respecting the NULL override handling.

Resolves: #45416
Releases: 6.0, 6.1

Change-Id: I35a84da83be765991b357c5cee89ce018a1f1e24
Reviewed-on: https://review.typo3.org/18223
Reviewed-by: Steffen Ritter
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18698

6 years ago[BUGFIX] Wrong usage of array_unique() 94/18694/2
Andreas Lingott [Tue, 5 Mar 2013 07:31:16 +0000 (08:31 +0100)]
[BUGFIX] Wrong usage of array_unique()

RootlineUtility.php does not use return value of array_unique() call,
which makes the call ineffective.

This causes some huge SQL queries and increases page load time heavily.

Resolves: #46000
Releases: 6.1, 6.0
Change-Id: Ic614a22a97927cc433eab9e5bf1b6125d53b5882
Reviewed-on: https://review.typo3.org/18694
Tested-by: Andreas Lingott
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
6 years ago[BUGFIX] Invalid replacement hints in t3lib/ 84/18584/2
Xavier Perseguers [Mon, 4 Mar 2013 07:38:56 +0000 (08:38 +0100)]
[BUGFIX] Invalid replacement hints in t3lib/

The comment and require_once call in deprecated classes are wrong.

Change-Id: I1d3e49bc977eef1c69551809596a5917a7ccf1f0
Fixes: #45998
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18584
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[BUGFIX] Invalid SQL result after four login failures 83/18583/2
Philipp Gampe [Sun, 3 Mar 2013 20:07:32 +0000 (21:07 +0100)]
[BUGFIX] Invalid SQL result after four login failures

sql_free_result is called too early.
Move the call after the error handling at the end of the method.

Fixes: #45996
Releases: 6.0, 6.1
Change-Id: I54f1edb48e4c3b70629b46cbba365416c01c0917
Reviewed-on: https://review.typo3.org/18579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18583

6 years ago[TASK] Raise submodule pointer 66/18566/2
TYPO3 Release Team [Sun, 3 Mar 2013 08:41:45 +0000 (09:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ie62df0cce2b394c2cbb4120d7638c2287befb7cb
Reviewed-on: https://review.typo3.org/18566
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Make backend user global available early 87/18487/2
Helmut Hummel [Thu, 21 Feb 2013 14:01:02 +0000 (15:01 +0100)]
[BUGFIX] Make backend user global available early

The global must be available very early, because methods below
might trigger code which relies on it. In particular the workspace
overlay of the rootline which is done in certain cases.

Fixes: #45625
Releases: 6.0, 6.1
Change-Id: I035f27e11cd56fc284442b66ad8357060f76e52c
Reviewed-on: https://review.typo3.org/18420
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18487

6 years ago[BUGFIX] Fix of .zip exports of extension 44/18344/2
Jost Baron [Sat, 16 Feb 2013 13:43:22 +0000 (14:43 +0100)]
[BUGFIX] Fix of .zip exports of extension

Before this, all files of an extension where included into its
.zip export. Now $TYPO3_CONF_VARS['EXT']['excludeForPackaging']
is respected.

Also the function responsible for the export is cleaned up and uses
more core API than before.

Change-Id: I1c06084e4da3ee18014563572fd270ea1e4d3ec5
Fixes: #45404
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18344
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Invalid RSA key when submitting form twice 40/18340/2
Benjamin Mack [Tue, 15 Jan 2013 12:05:27 +0000 (13:05 +0100)]
[BUGFIX] Invalid RSA key when submitting form twice

When submitting a RSA-supported form twice, the JS error
"Invalid RSA public key" is thrown. In order to suppress
this double RSA decryption, an additional JS check is needed.
The change also modifies the minified version of the JS
done with http://refresh-sf.com/yui/

Change-Id: I7133e320c76e14a6f6855f477ba5a34e50eecf58
Resolves: #40085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17541
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18340

6 years ago[BUGFIX] Fix the display of references in filelist 35/18335/2
Helmut Hummel [Sat, 16 Feb 2013 20:53:31 +0000 (21:53 +0100)]
[BUGFIX] Fix the display of references in filelist

Currently references are not displayed
in the filelist module when trying to delete a file
which has been referenced.

Fixes: #45538
Releases: 6.0, 6.1
Change-Id: Id88bc954ab0002585ec6bb75dabba901784ddab5
Reviewed-on: https://review.typo3.org/18335
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup "beuser" sysext 22/18322/2
Wouter Wolters [Sun, 10 Feb 2013 14:53:14 +0000 (15:53 +0100)]
[TASK] Cleanup "beuser" sysext

This is a non-functional change that reformats the code, removes
unnecessary empty lines and fixes namespaces in phpDoc. In addition
the following to changes are made:
- add $GLOBALS['TYPO3_DB']->sql_free_result() calls to free some memory
- change bu:SpriteIconForRecord to bu:spriteIconForRecord in templates

Change-Id: I6e832921c46f828c9db0c796d662bd8390b5ac5f
Resolves: #45343
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18322
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Cleanup "belog" sysext 21/18321/3
Wouter Wolters [Mon, 11 Feb 2013 21:08:49 +0000 (22:08 +0100)]
[TASK] Cleanup "belog" sysext

Reformats the code, fixes indents and removes extra empty lines. This is
not a functional change but a visual clean up.

Change-Id: I0d11dd7c43eee5d181c4bc0565c85d651c5c29e1
Resolves: #45392
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18321
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] LocalDriver needs to respect "is_writeable" 17/18317/2
Georg Ringer [Thu, 10 Jan 2013 09:37:21 +0000 (10:37 +0100)]
[BUGFIX] LocalDriver needs to respect "is_writeable"

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Fixes: #44370
Releases: 6.0, 6.1

Change-Id: I404ed51c62ab96d9b5eaaf6c0b7b255bdea3538b
Reviewed-on: https://review.typo3.org/18317
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Set TYPO3 version to 6.0.3-dev 84/18284/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:27 +0000 (16:50 +0100)]
[TASK] Set TYPO3 version to 6.0.3-dev

Change-Id: I99ae446f9ecfef13b7f6e0b553f826446fd0504a
Reviewed-on: https://review.typo3.org/18284
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.2 83/18283/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:17 +0000 (16:50 +0100)]
[RELEASE] Release of TYPO3 6.0.2

Change-Id: I9c9635363f5022c8c21fe34b7b6d67bb676cfbd4
Reviewed-on: https://review.typo3.org/18283
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] L10n fallback does not work for TS labels 70/18270/2
Xavier Perseguers [Thu, 20 Dec 2012 06:59:15 +0000 (07:59 +0100)]
[BUGFIX] L10n fallback does not work for TS labels

When retrieving a label in TypoScript in a locale that is not
available locally, the English label is returned instead of
using the locale fallback mechanism introduced in TYPO3 4.6.

Change-Id: I29f4b25e3fc23497d6afe74659810ca8995a39df
Fixes: #44099
Relates: #41996
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17247
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18270

6 years ago[BUGFIX] L10n fallback does not work for ExtJS in BE 66/18266/2
Xavier Perseguers [Wed, 2 Jan 2013 17:56:09 +0000 (18:56 +0100)]
[BUGFIX] L10n fallback does not work for ExtJS in BE

PageRenderer does not take language dependency into account when reading
localization files to be included as JavaScript labels.

Change-Id: I23d12dd06a99e72968a26d5930decb87901e8af6
Fixes: #44273
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17313
Reviewed-by: Mattias Nilsson
Reviewed-by: Begoña Garea Garcia
Tested-by: Begoña Garea Garcia
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18266

6 years ago[TASK] Raise submodule pointer 74/18274/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:08:16 +0000 (16:08 +0100)]
[TASK] Raise submodule pointer

Change-Id: I59d84f42d187ba46006fe33af62e640388a936e5
Reviewed-on: https://review.typo3.org/18274
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Allow "en" as language key 62/18262/2
Daniel Alder [Tue, 8 Jan 2013 10:21:25 +0000 (11:21 +0100)]
[BUGFIX] Allow "en" as language key

Fix a bug which was introduced by #25397 (commit:cb390c79).
If the selected language key is "en", do not override it to "default".
This allows custom updates to translations even for the English language.

Change-Id: I3fcbd35f0144a0cc152acd45d0861d153cc8b495
Resolves: #42084
Related: #25397
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17414
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18262

6 years ago[BUGFIX] FAL: file properties are not updated 12/18212/2
Stefan Froemken [Wed, 16 Jan 2013 22:43:06 +0000 (23:43 +0100)]
[BUGFIX] FAL: file properties are not updated

The fileproperties are not updated correctly. In
case of this issue it is the filesize which was not
updated in filelist-module

Resolves: #44585
Releases: 6.0, 6.1
Change-Id: I539b6ab94c4f5aa90933302687f0c666953270fa
Reviewed-on: https://review.typo3.org/18212
Reviewed-by: Stefan Froemken
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove not used viewhelper in beuser 83/18183/2
Markus Günther [Sun, 10 Feb 2013 11:11:16 +0000 (12:11 +0100)]
[TASK] Remove not used viewhelper in beuser

The SelectDefaultValueViewHelper in beuser is
not used at the moment and since TYPO3 fluid
6.1 it is possible to add a prependOption
with the default selectViewHelper.

Fixes: #45338
Releases: 6.1, 6.0

Change-Id: Ie47021c2d74441243d116cc6cfcbfbb8fd5fdb1e
Reviewed-on: https://review.typo3.org/18183
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception when scheduling "at" execution time 73/18173/2
Andreas Wolf [Sun, 10 Feb 2013 00:00:25 +0000 (01:00 +0100)]
[BUGFIX] Exception when scheduling "at" execution time

If a recurring task is converted to a single task and the endtime is set
before now, then the exception "Task is past end date" is thrown as the
next execution time for the "at" daemon is calculated.

The fix is to catch the exceptions and ignore them, as we don't care
about tasks that will never run again when calculating the next
execution date.

Fixes: #45265
Releases: 6.1, 6.0
Change-Id: If6fd368e6c11c0b9058eb8a82a736220ef538b70
Reviewed-on: https://review.typo3.org/18173
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Processed files get corrupted when regenerated 53/18153/2
Andreas Wolf [Sat, 9 Feb 2013 10:02:05 +0000 (11:02 +0100)]
[BUGFIX] Processed files get corrupted when regenerated

After a file is being (re)processed, the information about it is updated
in the database by the ProcessedFileRepository. The repository gathers
information for the update from the processed file.

For unprocessed files (i.e. those where the original file should be
used), the ProcessedFile class does a fallback to the original file
object. Unfortunately, this fallback is also applied for the uid
property, which makes the repository overwrite a random record in
sys_file_processedfile. This leads to wrong images being displayed in
the frontend.

This patch makes the processed file only return its own uid.

IMPORTANT: To make sure your sys_file_processedfile data is not
corrupted, empty the table and your processed files folder (usually
fileadmin/_processed_/). This will slow down your site as all processed
files are regenerated, but afterwards all data will be correct.

Change-Id: I40685d5748a5a0fcf015c7d876a374f42154831d
Resolves: #45308
Related: #44616 #45168
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18153
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[TASK] Raise submodule pointer 25/18125/2
Christian Kuhn [Fri, 8 Feb 2013 16:29:56 +0000 (17:29 +0100)]
[TASK] Raise submodule pointer

Change-Id: I7db7cffae997b20990b29de4f2668fd5e7d0293e
Reviewed-on: https://review.typo3.org/18125
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache][PDO] Duplicate cache entry possible 98/18098/2
Leon Dietsch [Tue, 27 Nov 2012 01:12:52 +0000 (02:12 +0100)]
[BUGFIX][Cache][PDO] Duplicate cache entry possible

An identifier must be unique in the database. If some entry is set(),
the PdoBackend removes any entry with a given identifier if the cache
entry exists already. The remove() call is encapsulated with has(),
but has() returns FALSE if a cache entry is expired, so entries with
expired lifetime are not removed properly.
This leads to a \PDOException because of duplicate identifier.

The patch removes the check to has(), so set() will also remove
expired cache entries with this identifier before creating a new one.

Change-Id: Ife4e35223394805fc6d9e0b820a5d42789133f7b
Fixes: #34129
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18098
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache] Method parameter CGL fixes 93/18093/2
Christian Kuhn [Thu, 7 Feb 2013 20:13:15 +0000 (21:13 +0100)]
[BUGFIX][Cache] Method parameter CGL fixes

Change-Id: Ie237c62fcd25d0f4ac2430983183756c7aebc633
Resolves: #45257
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18093
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 51/18051/2
Christian Kuhn [Wed, 6 Feb 2013 12:14:18 +0000 (13:14 +0100)]
[TASK] Raise submodule pointer

Change-Id: I65c1d48dab1bab034ecb7b2021e0be5e634aaa1e
Reviewed-on: https://review.typo3.org/18051
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Crash after file upload on Windows without finfo 49/18049/2
Christian Weiske [Fri, 11 Jan 2013 15:52:54 +0000 (16:52 +0100)]
[BUGFIX] Crash after file upload on Windows without finfo

This patch checks if the finfo extension is available before using it
to determine the MIME type of a file.
If it is not available, the old function mime_content_type is used as
fallback.
When none of them are available, we give up.

This fixes a crash on Windows after uploading a file, since finfo
is by default not installed on PHP windows distributions.

Change-Id: I53a0eef3ee839c17ddaaeb303b9a0b9bae3ee485
Fixes: #37440
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18049
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong SQL statements in TCA for sys_category 44/18044/2
Thomas Löffler [Tue, 5 Feb 2013 21:46:01 +0000 (22:46 +0100)]
[BUGFIX] Wrong SQL statements in TCA for sys_category

Copy and Paste problem. Table name
'tx_taxonomy_domain_model_concept' instead of
'sys_category'

Resolves: #44911
Releases: 6.0, 6.1
Change-Id: I92130a8dc5416b822edc71be148e35f193b5ea3b
Reviewed-on: https://review.typo3.org/18044
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Additional extTables script might not exist 01/18001/2
Philipp Gampe [Sun, 3 Feb 2013 21:59:25 +0000 (22:59 +0100)]
[BUGFIX] Additional extTables script might not exist

During https://review.typo3.org/17381, the constant
TYPO3_extTableDef_script is now always defined.

Change the bootstrap to only include the file if it really
exists.

Related: #44331
Fixes: #45122
Releases: 6.0, 6.1
Change-Id: I547c5e141b2395eb8b684ce245bb0440096f14df
Reviewed-on: https://review.typo3.org/18001
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Misspelling in scheduler documentation 83/17983/2
Tomita Militaru [Sat, 2 Feb 2013 13:38:11 +0000 (15:38 +0200)]
[BUGFIX] Misspelling in scheduler documentation

Corrects certain words / phrases from the documentation manual.

Fixes: #33936
Releases: 6.1, 6.0
Change-Id: I89ad923280cd1df6d126884e88987abaa9d5f7df
Reviewed-on: https://review.typo3.org/17983
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] tools_dbint needs to be called via mod.php 82/17982/2
Philipp Gampe [Sun, 3 Feb 2013 16:34:39 +0000 (17:34 +0100)]
[BUGFIX] tools_dbint needs to be called via mod.php

Fixes: #45112
Releases: 6.0, 6.1
Change-Id: I69b22d8d5fcb94e9b3cefcce600fd6b154de6c9d
Reviewed-on: https://review.typo3.org/17982
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] IE9 compatibility clear cache menu 71/17971/2
Andreas Kiessling [Sun, 3 Feb 2013 09:54:02 +0000 (10:54 +0100)]
[BUGFIX] IE9 compatibility clear cache menu

The prototype library shipped with TYPO3 is not compatible with IE9
anymore. Since prototype will be replaced in the near future the easiest
solution is to use plain JavaScript.

Change-Id: I1dc732a61531fa585ed8e0ba6ce8df1b23f3b8bd
Resolves: #36364
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17971
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Hook call modifyDBRow in ContentContentObject 48/17948/4
Alina Fleser [Sat, 2 Feb 2013 11:11:28 +0000 (13:11 +0200)]
[BUGFIX] Hook call modifyDBRow in ContentContentObject

Replace $this->TYPO3_CONF_VARS with $GLOBALS['TYPO3_CONF_VARS']

Fixes: #44416
Releases: 6.0, 6.1, 4.7, 4.6, 4.5
Change-Id: I1f2b6a2479cc879c2a9144d03e176b74d895d52f
Reviewed-on: https://review.typo3.org/17948
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install tool documentation default installTollPassword 47/17947/4
Tomita Militaru [Sat, 2 Feb 2013 10:55:40 +0000 (12:55 +0200)]
[BUGFIX] Install tool documentation default installTollPassword

The fatal error message instructs to use array position EXT instead
of position BE for installToolPassword.
Replaces EXT with BE in the error message.

Fixes: #44682
Releases: 6.0, 6.1
Change-Id: Ic262e9c9838dc07dc523e9a85cf92e8f1f79e634
Reviewed-on: https://review.typo3.org/17947
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Labels for grouping bookmarks are missing 51/17951/2
Bindea Silviu [Sat, 2 Feb 2013 13:55:25 +0000 (15:55 +0200)]
[BUGFIX] Labels for grouping bookmarks are missing

Using function sL to load locallang with labels for bookmarks

Fixes: #44691
Releases: 6.1, 6.0
Change-Id: I509aa06e379e1397fea50c6a2c137db3994eff2a
Reviewed-on: https://review.typo3.org/17951
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix misspelling in RTE meta menu 56/17956/2
Tomita Militaru [Sat, 2 Feb 2013 09:55:26 +0000 (11:55 +0200)]
[BUGFIX] Fix misspelling in RTE meta menu

Corrects the label for inserting unordered bullet lists.

Fixes: #43886
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I4190dbcc8cadc90ae00d1ec1aa405a5a75863594
Reviewed-on: https://review.typo3.org/17956
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Impossible to save the TCA configuration 44/17944/2
Philipp Gampe [Sat, 5 Jan 2013 22:59:39 +0000 (23:59 +0100)]
[BUGFIX] Impossible to save the TCA configuration

The configuration module allows to save changes to the TCA array.

If no extTablesDefinitionScript is defined, constant
TYPO3_extTableDef_script is defined as empty. This results in an
attempt to write to a directory (because the filename is empty).
This is not obvious as the constant is not needed much and the
error message is misleading.

Solution is to fall back to the default value during bootstrap if
extTablesDefinitionScript is not set in LocalConfiguration.php.

Change-Id: Id759aa73146669cccae9a83d8452340f9f78927b
Fixes: #44331
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17944
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] load TCA before manipulation 40/17940/2
Jigal van Hemert [Sat, 15 Dec 2012 08:58:54 +0000 (09:58 +0100)]
[BUGFIX] load TCA before manipulation

Load the TCA before manipulating the contents in form and
css_styled_content, otherwise the checks for later calls to
loadTCA will fail while the TCA is not fully loaded.

Change-Id: Id2d96d8dab0fc53661689f778871ebb078272062
Resolves: #38505
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17940
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Restore support for Update script 38/17938/2
Francois Suter [Tue, 29 Jan 2013 19:31:52 +0000 (20:31 +0100)]
[BUGFIX] Restore support for Update script

The new EM is missing support for the class.ext_update.php script.
This patch restores it, giving it its own icon in the extension
list view.

Change-Id: Id5ea243bb689882959aa85cdbe700e784d83b2c0
Resolves: #43244
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17938
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Misspelled class name FrontendUserAuthtenication 26/17926/2
Christian Kuhn [Fri, 1 Feb 2013 15:21:54 +0000 (16:21 +0100)]
[BUGFIX] Misspelled class name FrontendUserAuthtenication

Fix class name, rename file, fix usage
FrontendUserAuth*ten*ication
FrontendUserAuth*ent*ication

Change-Id: Id851db64a50a5938496dd4411caaec0bf7ba85af
Fixes: #43464
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17926
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] add check for empty form values in FORM View 22/17922/2
Alexander Stehlik [Fri, 1 Feb 2013 12:32:15 +0000 (13:32 +0100)]
[BUGFIX] add check for empty form values in FORM View

If a FORM is submitted without any value a Fatal Error is thrown in
typo3/sysext/form/Classes/View/Confirmation/Confirmation.php on line
101. The patch adds a check for that case.

Fixes: #28606
Releases: 6.1, 6.0, 4.7, 4.6

Change-Id: I77cd57f0d56e9bdcf9517683ea21c3dc9ec1bc45
Reviewed-on: https://review.typo3.org/17922
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] StorageRepository must respect 'deleted' flag 19/17919/2
Sebastian Michaelsen [Fri, 18 Jan 2013 10:44:47 +0000 (11:44 +0100)]
[BUGFIX] StorageRepository must respect 'deleted' flag

The FAL's Storage Repository find* methods also load
deleted file storages at the moment.

Reproduce:
* Create some "File Storage" records on the root page and
delete some of them
* Open the File module, it will showdeleted File Storages

Resolves: #44630
Releases: 6.1, 6.0
Change-Id: I5c60f16261508978ddbe47aa26b52be5b05a82bc
Reviewed-on: https://review.typo3.org/17919
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove delete button for sys_file 16/17916/2
Helmut Hummel [Fri, 1 Feb 2013 10:27:16 +0000 (11:27 +0100)]
[BUGFIX] Remove delete button for sys_file

The edit view of file meta data currently has
a delete button, which sets the record of this
file to deleted, but does not delete the file itself.

It might be useful at some point
to use this to implement some recycler
functionality, but currently the FAL layer
has no support for it and a file with a deleted
meta data record is an inconsistent state
which has to be avoided by all means.

Resolves: #45065
Releases: 6.0, 6.1

Change-Id: I5033107cf4021d127e274bbe12e3aa08ea1b4ef6
Reviewed-on: https://review.typo3.org/17916
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource 13/17913/2
Anja Leichsenring [Sat, 12 Jan 2013 15:40:07 +0000 (16:40 +0100)]
[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource

In the Core/Classes/Resource Folder many calls to classes can be
used with shorthand syntax (without the namespace).

Many docheaders miss one or more @throws clauses for Exceptions to throw.

Resolves: #44476
Releases: 6.1, 6.0

Change-Id: Ia9c4b6e29fa924d42df8ff0e1e68ed607ce8256f
Reviewed-on: https://review.typo3.org/17913
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper 12/17912/2
Sebastian Michaelsen [Tue, 15 Jan 2013 10:05:09 +0000 (11:05 +0100)]
[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper

Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper this
is not used anymore in the core.

Resolves: #44527
Releases: 6.1, 6.0

Change-Id: I06925b20d7399181be6bb2d5f5439cade1fca7c1
Reviewed-on: https://review.typo3.org/17540
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-on: https://review.typo3.org/17912

6 years ago[TASK] DataHandler::getAutoVersionId() should be public 07/17907/2
Oliver Hader [Thu, 31 Jan 2013 18:17:41 +0000 (19:17 +0100)]
[TASK] DataHandler::getAutoVersionId() should be public

The method getAutoVersionId() in DataHandler/t3lib_TCEmain
should be public. The method is a helper to access the accordant
member variable that get's filled during workspace actions and
thus is useful in hooks as well.

Change-Id: Ie1f55d92b8e72e6ab68a563f0c1c52762239e102
Resolves: #45050
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17907
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Remove save and new button for sys_file 99/17899/2
Helmut Hummel [Thu, 31 Jan 2013 16:46:22 +0000 (17:46 +0100)]
[BUGFIX] Remove save and new button for sys_file

The save and new button does not make any sense for file
meta data, so we should not display it.

Resolves: #45044
Releases: 6.0,6.1

Change-Id: Ic25edee5b208103f74c7d566acb93099bdd3c19f
Reviewed-on: https://review.typo3.org/17899
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] ext:aboutmodules broken link to ext:reports 77/17877/3
Christian Kuhn [Wed, 30 Jan 2013 21:11:36 +0000 (22:11 +0100)]
[BUGFIX] ext:aboutmodules broken link to ext:reports

ext:aboutmodules shows some message box if ext:reports
is installed and found some serious problem. The message
has a link to reports module that is broken and fixed
by the patch.

Change-Id: I7d0b2b6573eb960028cb1de0463808eaf5860fbc
Resolves: #40218
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17877
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] displayWarningMessages uses wrong returnUrl 75/17875/2
Sebastian Michaelsen [Tue, 15 Jan 2013 13:29:33 +0000 (14:29 +0100)]
[BUGFIX] displayWarningMessages uses wrong returnUrl

The warning in the "About Modules" module about an
insecure admin offers a link to edit this user. Following
this link and then closing the form again leads to a 404.
The reason is a wrong returnUrl in
BackendUtility:: displayWarningMessages.

Resolves: #44537
Releases: 6.1, 6.0
Change-Id: I41d361d8b7314ac0bace8b8a5979a6f69128657c
Reviewed-on: https://review.typo3.org/17875
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LocalConfiguration extListArray should be written without keys 72/17872/2
Jan-Erik Revsbech [Tue, 29 Jan 2013 19:46:05 +0000 (20:46 +0100)]
[BUGFIX] LocalConfiguration extListArray should be written without keys

When writing LocalConfiguration.php, arrays should be written without keys
if all the keys are numeric, even if the keys contain leaps.

Fixes: #44938
Releases: 6.1, 6.0
Change-Id: Ic1d929d54a75b091ecbe4f0f4b82049d507ccd95
Reviewed-on: https://review.typo3.org/17872
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reset legacy fields if no relations are found 71/17871/2
Helmut Hummel [Wed, 30 Jan 2013 16:39:28 +0000 (17:39 +0100)]
[BUGFIX] Reset legacy fields if no relations are found

If you add multiple images to a tt_content element
but mark all of them hidden, an image is shown which has
the uid of the number of images added to the element.

This is the case because TYPO3 puts the relation count in the
field and the frontend adapter service does not reset
the field if no relations are found.

The solution is to set the legacy fields in any case.

This change adds a test which fails without a fix
and another test which shows that the original behaviour
is not affected.

Change-Id: I2cacfe185e1371331ab7564413e43c7d6cce8556
Resolves: #44988
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17871
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Add missing labels for Extension Manager 70/17870/2
Wouter Wolters [Tue, 29 Jan 2013 21:18:01 +0000 (22:18 +0100)]
[BUGFIX] Add missing labels for Extension Manager

The Extension Manager is missing the labels when opening
the About Modules in the backend.

Change-Id: I4ea3a312e707dd1af22f6a693298170c32e19ecc
Fixes: #44941
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17870
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Compatibility fix for get_html_translation_table() 80/17180/3
Michael Stucki [Tue, 27 Nov 2012 00:12:31 +0000 (01:12 +0100)]
[BUGFIX] Compatibility fix for get_html_translation_table()

t3lib_cs::entities_to_utf8() triggers a PHP warning on versions
lower than 5.3.4 because too many parameters were given.
See http://php.net/manual/en/function.get-html-translation-table.php

Change-Id: Ic302f2b8c2902ec8685dfb2d974273071bbbdcb7
Fixes: #39287
Releases: 6.0, 4.7
Reviewed-on: https://review.typo3.org/17180
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
6 years ago[BUGFIX] Remove obsolete flushByTags() from wincache 10/17810/2
Christian Kuhn [Tue, 29 Jan 2013 19:29:31 +0000 (20:29 +0100)]
[BUGFIX] Remove obsolete flushByTags() from wincache

Method flushByTags() was removed from the cache backend interface
since core version 4.6 and fully removed in 6.0. The wincache
backend still implements this method, but it is never used
anywhere, so it can be removed.

Change-Id: I038f1839f77b33173122bb8a0485dd005ee8a5a4
Fixes: #44937
Related: #35818
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Register suite integrity tests again 08/17808/2
Christian Kuhn [Tue, 29 Jan 2013 19:13:13 +0000 (20:13 +0100)]
[BUGFIX] Register suite integrity tests again

The integrity unit tests executed at the very bottom of the
test suite very accidentally removed during issue #40950.
Add them again.

Change-Id: Ifc59f201c98a79e1cf376e1c1e1124408cd37c10
Fixes: #44936
Related: #40950
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17808
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Set TYPO3 version to 6.0.2-dev 02/17802/2
TYPO3 Release Team [Tue, 29 Jan 2013 16:48:30 +0000 (17:48 +0100)]
[TASK] Set TYPO3 version to 6.0.2-dev

Change-Id: I88c4aa51d1aea00cab2e7fc546230b32e41f5bdf
Reviewed-on: https://review.typo3.org/17802
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.1 01/17801/2
TYPO3 Release Team [Tue, 29 Jan 2013 16:48:19 +0000 (17:48 +0100)]
[RELEASE] Release of TYPO3 6.0.1

Change-Id: Ic05e7a2a5edba74ca6ff8bfc90b388440a54515f
Reviewed-on: https://review.typo3.org/17801
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file 00/17800/3
Christian Kuhn [Tue, 29 Jan 2013 16:09:03 +0000 (17:09 +0100)]
[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file

Due to some weird instance re-usage in the content object renderer
the view object in FLUIDTEMPLATE content object must be re-created
for every call to render() to avoid some nasty cache issues.

Change-Id: If2ec0b171b8227aba9204d343a9e9010b69ecc78
Resolves: #44610
Related: #42182
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17800
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EXT:reports Improve xclass reporting 78/17778/2
Christian Kuhn [Mon, 28 Jan 2013 22:19:47 +0000 (23:19 +0100)]
[TASK] EXT:reports Improve xclass reporting

Since TYPO3 CMS 6.0, the XCLASS registration changed and the old
registration style does not work anymore. Additionally, 6.0 comes
with a basic check for old XCLASS registration to warn users about
that.

The patch adds a new report for newly registered XCLASS'es and
adapts the messages to better notify that neither old nor new
registrations are a real problem, but that those classes should
be kept an eye on during upgrading.

Change-Id: I8c0052b9c7fb0e88aff62a71c9592bf51bcec7ad
Resolves: #44895
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17778
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn