Packages/TYPO3.CMS.git
2 years ago[TASK] Improve TCA cache 62/54062/4
Helmut Hummel [Sat, 9 Sep 2017 12:32:20 +0000 (14:32 +0200)]
[TASK] Improve TCA cache

Currently TCA is cached as serialized string using
the core cache.

Simplify the cache retrieval by taking advantage of
the code cache by using requireOnce and previously
storing the cache as PHP file that returns an array.
This significantly improves performance
with opcode cache enabled.

The cache identifier is changed to avoid conflicts
with previously stored data.

Resolves: #82408
Releases: master, 8.7
Change-Id: I59210fa800d10c14d21aceb7416ea418988d6ca5
Reviewed-on: https://review.typo3.org/54062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[FEATURE] Inject logger into newly created objects 01/54101/9
Markus Klein [Sun, 10 Sep 2017 12:06:11 +0000 (14:06 +0200)]
[FEATURE] Inject logger into newly created objects

Instantiating new objects with makeInstance or the ObjectManager
will automatically inject a logger into the new objects, if those
implement the LoggerAwareInterface.

Resolves: #82441
Releases: master
Change-Id: I38e1a4619857f3fc2d88b0b95a9721b289c679d3
Reviewed-on: https://review.typo3.org/54101
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[!!!][BUGFIX] EXT:form - FlexForm settings overrule TypoScript settings 71/54071/6
Łukasz Uznański [Sat, 9 Sep 2017 16:35:10 +0000 (18:35 +0200)]
[!!!][BUGFIX] EXT:form - FlexForm settings overrule TypoScript settings

Releases: master
Resolves: #82252
Change-Id: I5cddefe1fd3fbf97e2cdc1aea1f373ef2076da72
Reviewed-on: https://review.typo3.org/54071
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use Response objects directly in Install Tool actions 59/54059/6
Benni Mack [Sat, 9 Sep 2017 11:48:42 +0000 (13:48 +0200)]
[TASK] Use Response objects directly in Install Tool actions

The patch introduces three shorthand Response classes for output:
HtmlResponse, JsonResponse and RedirectResponse which are used
throughout all the actions inside the Install Tool.

Resolves: #82415
Releases: master
Change-Id: I9edc15c341084fcb59a3b1dc45b42a6f65d87e7f
Reviewed-on: https://review.typo3.org/54059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fluid: Strict type checking when adding debug namespace 32/53832/3
Benni Mack [Wed, 30 Aug 2017 06:13:13 +0000 (08:13 +0200)]
[BUGFIX] Fluid: Strict type checking when adding debug namespace

The check on BE_USER->uc() in frontend context is cleaned up and more
strict, checking whether the object exists currently.

Additionally, the specific request type is used here.

Resolves: #82397
Releases: master, 8.7
Change-Id: Ibe0b533c23e1ba9c35ed2b6b9b0301e1a449c2e3
Reviewed-on: https://review.typo3.org/53832
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[!!!][TASK] Remove legacy entrypoint for Install Tool 93/54093/2
Benni Mack [Sun, 10 Sep 2017 09:27:23 +0000 (11:27 +0200)]
[!!!][TASK] Remove legacy entrypoint for Install Tool

The entrypoint located under "typo3/sysext/install/Start/Install.php" has been
removed, as the entrypoint "typo3/install.php" is the new way to access the install
tool. The legacy entrypoint "typo3/install/index.php" will still be kept, as it is
easy for existing users to get a simple redirect (still marked as deprecated).

Resolves: #82433
Releases: master
Change-Id: I36a165649c7ca5a988379b70328e570fc45285b0
Reviewed-on: https://review.typo3.org/54093
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Provide missing example configuration for TYPO3 on Microsoft IIS 79/53379/4
Benjamin Kott [Sun, 2 Jul 2017 19:29:38 +0000 (21:29 +0200)]
[TASK] Provide missing example configuration for TYPO3 on Microsoft IIS

Releases: master, 8.7
Resolves: #81769
Change-Id: I92df0fc254b4a729298f32d1482ad2a0f39502bf
Reviewed-on: https://review.typo3.org/53379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix parameters in recursiveConfigurationFetching() call 95/54095/2
Simon Praetorius [Sun, 10 Sep 2017 09:45:24 +0000 (11:45 +0200)]
[BUGFIX] Fix parameters in recursiveConfigurationFetching() call

Resolves: #82435
Relates: #82399
Releases: master
Change-Id: Ic2bb90883c0a6cec5e6bec051cb308c723392d75
Reviewed-on: https://review.typo3.org/54095
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[FEATURE] Add crossorigin property to JavaScript files 55/48455/8
Jacob Dreesen [Sat, 9 Sep 2017 16:30:55 +0000 (18:30 +0200)]
[FEATURE] Add crossorigin property to JavaScript files

Add a property 'crossorigin="some-value"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.crossorigin = some-value

The crossorigin property is automatically set to the value "anonymous" for
external JavaScript files with an integrity property if not explicitly set.

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #76459
Releases: master
Change-Id: Ie8d1d86ca5a8863c2a637395f1f87a463729691c
Reviewed-on: https://review.typo3.org/48455
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Calculate workspace module route correctly 97/54097/3
Andreas Fernandez [Sun, 10 Sep 2017 10:45:44 +0000 (12:45 +0200)]
[BUGFIX] Calculate workspace module route correctly

Resolves: #82434
Related: #82406
Releases: master
Change-Id: I67182a131c2499713410807099f5d658a3858d63
Reviewed-on: https://review.typo3.org/54097
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Route dispatching: Don't rely on id being an integer 98/54098/2
Andreas Fernandez [Sun, 10 Sep 2017 11:19:43 +0000 (13:19 +0200)]
[BUGFIX] Route dispatching: Don't rely on id being an integer

The route dispatcher can't rely on id being an integer, as file list for
example uses string identifier.

It is now checked whether the id is an int instead.

Resolves: #82440
Related: #82406
Releases: master
Change-Id: Idddc8484e0a597fec9d61c509d06f36736990c67
Reviewed-on: https://review.typo3.org/54098
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Raise typo3/testing-framework to 1.1.4 96/54096/2
Christian Kuhn [Sun, 10 Sep 2017 10:22:04 +0000 (12:22 +0200)]
[TASK] Raise typo3/testing-framework to 1.1.4

The raise brings an additional UnitTestsDeprecated.xml
setup file dedicated to test deprecated core functionality.

Change-Id: Ic61ce2d76ed7f4e83bc6c2a12dd1337392d6c4aa
Resolves: #82437
Related: #82438
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54096
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove old typoscript constants editor defaults option 86/54086/3
Markus Hoelzle [Sat, 9 Sep 2017 21:02:14 +0000 (23:02 +0200)]
[!!!][TASK] Remove old typoscript constants editor defaults option

Remove support for the special constant comment
`###MOD_TS:EDITABLE_CONSTANTS###`. This constant was used to show
all constants before this comment as default constants in constants
editor and is dropped as ancient and widely unknown and rarely used
feature.

Releases: master
Resolves: #82425
Change-Id: I5345871818e1d627cacb8be6db2ab8629770237e
Reviewed-on: https://review.typo3.org/54086
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use general utility to build html attribute string 19/49819/16
Sascha Egerer [Sat, 3 Sep 2016 08:34:26 +0000 (10:34 +0200)]
[TASK] Use general utility to build html attribute string

There was one leftover place, where an attributes string was
concatenated instead using the helper function.

Resolves: #77824
Releases: master
Change-Id: I0d01a5bde47b333dc11d25f6dd28bde9e7810696
Reviewed-on: https://review.typo3.org/49819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Open the elementbrowser always in modal window 73/54073/12
Benjamin Kott [Sat, 9 Sep 2017 17:19:34 +0000 (19:19 +0200)]
[TASK] Open the elementbrowser always in modal window

Resolves: #82427
Releases: master
Change-Id: Ia0e5f34a0f8bb29a179f1e9f7b90bb1b540b57f7
Reviewed-on: https://review.typo3.org/54073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix file upload and directory creation in file browser 94/54094/2
Andreas Fernandez [Sun, 10 Sep 2017 09:46:21 +0000 (11:46 +0200)]
[BUGFIX] Fix file upload and directory creation in file browser

While #81763 was in development, some locations of the file operation
handling were not adjusted. This patch fixes the left over places.

Resolves: #82436
Related: #81763
Releases: master
Change-Id: I450458f5ef687969b22a194a2387953330b8d17d
Reviewed-on: https://review.typo3.org/54094
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] JS: Init SelectTree after FormEngine 15/53815/3
Alexander Opitz [Sun, 27 Aug 2017 18:54:26 +0000 (20:54 +0200)]
[BUGFIX] JS: Init SelectTree after FormEngine

SelectTree depends on availability of TYPO3.FormEngine,
so add FormEngine as Dependency.

Resolves: #82217
Releases: master, 8.7
Change-Id: I2d1a0c8c77b1140f9c501ea105cf8a66a6cd6a97
Reviewed-on: https://review.typo3.org/53815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove unused configuration settings 77/54077/4
Christian Kuhn [Sat, 9 Sep 2017 18:07:03 +0000 (20:07 +0200)]
[!!!][TASK] Remove unused configuration settings

The patch drops some unused pre-doctrine DB related TYPO3_CONF_VARS.

Change-Id: I9204ef926b1de145f541e2c84dadc6a968e153b9
Resolves: #82421
Releases: master
Reviewed-on: https://review.typo3.org/54077
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Cache calls to SchemaManager()->listTableColumns() 91/53391/3
Stephan Großberndt [Tue, 4 Jul 2017 07:51:55 +0000 (09:51 +0200)]
[BUGFIX] Cache calls to SchemaManager()->listTableColumns()

Caching the calls SchemaManager()->listTableColumns() during runtime
leads to improved performance when doing operations on multiple files or
multiple extbase Domain/Model objects at once as the same information
does not have to be fetched over and over.

Releases: master, 8.7
Resolves: #81778
Change-Id: Ieebcf5046d007dfea40acf148045807053873ac8
Reviewed-on: https://review.typo3.org/53391
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Add frontend debug output as HTTP Response Header 75/54075/4
Benni Mack [Sat, 9 Sep 2017 17:42:29 +0000 (19:42 +0200)]
[FEATURE] Add frontend debug output as HTTP Response Header

The current debug information in the frontend is added as HTML
comment, but breaks non-HTML pages (e.g. JSON output).

The debug information (= parse time of the frontend request) is now sent as HTTP
Response Header found at "X-TYPO3-Parsetime".

Resolves: #82419
Releases: master
Change-Id: Ibd84825fd3ebdcb1c88e0059d00d78b4bb20f53e
Reviewed-on: https://review.typo3.org/54075
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] T3editor: Get default mode if none is defined for a field 85/54085/3
Andreas Fernandez [Sat, 9 Sep 2017 20:33:42 +0000 (22:33 +0200)]
[BUGFIX] T3editor: Get default mode if none is defined for a field

If a field is rendered by t3editor but no mode was defined, the t3editor
falls back to the default mode, which is `html` by default.

Resolves: #82424
Related: #81901
Releases: master
Change-Id: I4b94e5257429219ccd72a917faa170fbc56c34ad
Reviewed-on: https://review.typo3.org/54085
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[BUGFIX] Remove NOT NULL constraints from l1[08]n_diffsource fields 84/54084/3
Andreas Fernandez [Sat, 9 Sep 2017 20:01:35 +0000 (22:01 +0200)]
[BUGFIX] Remove NOT NULL constraints from l1[08]n_diffsource fields

Having NOT NULL collides with MySQL strict mode, so these constraints
get removed.

Resolves: #82423
Releases: master, 8.7
Change-Id: Ic7a71ee40b6ad276a47405e3fd81c501868abb76
Reviewed-on: https://review.typo3.org/54084
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Replace `get_class($this)` calls with `static::class` 69/54069/2
Romain Canon [Sat, 9 Sep 2017 16:13:26 +0000 (18:13 +0200)]
[TASK] Replace `get_class($this)` calls with `static::class`

Improves runtime performance of these calls by approximately 1/3.

See https://belineperspectives.com/2017/03/13/get_classthis-vs-staticclass/

Resolves: #82416
Releases: master
Change-Id: I7a069068ed66cbb4ebd83bdad56c621166bf8139
Reviewed-on: https://review.typo3.org/54069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Remove TYPO3.jQuery 74/54074/2
Benni Mack [Sat, 9 Sep 2017 17:32:38 +0000 (19:32 +0200)]
[FOLLOWUP][TASK] Remove TYPO3.jQuery

This followup ensures that the Frontend Request including jQuery behaves
the same as the TYPO3 Backend (noConflict is default).

Related: #79221
Resolves: #82378
Releases: master
Change-Id: Ic16fcfb6932cc32d4190e715708c58f234dde5d7
Reviewed-on: https://review.typo3.org/54074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Introduce Source Sans Pro and drop Share Font 63/54063/3
Benjamin Kott [Sat, 9 Sep 2017 13:02:51 +0000 (15:02 +0200)]
[TASK] Introduce Source Sans Pro and drop Share Font

To improve readability in the backend, Source Sans Pro typeface is now
introduced and replaces the Share Font.

Resolves: #82410
Releases: master
Change-Id: Id9a71b37bb41ff0e0b7fb514e62aebd380ff3d2b
Reviewed-on: https://review.typo3.org/54063
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add descriptions to dropdowns in Install Tool - All Configuration 72/54072/3
Benni Mack [Sat, 9 Sep 2017 16:54:10 +0000 (18:54 +0200)]
[TASK] Add descriptions to dropdowns in Install Tool - All Configuration

Resolves: #82418
Releases: master
Change-Id: Ic5a59c485df3ce9aaaad0bd51206c0d53f445690
Reviewed-on: https://review.typo3.org/54072
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Migrate modules to regular backend routing 81/53881/13
Matthias Vogel [Sat, 9 Sep 2017 11:04:20 +0000 (13:04 +0200)]
[!!!][TASK] Migrate modules to regular backend routing

This patch removes the separate request handler for backend modules,
which was accessed via "&M=moduleName" GET parameter. This is now
migrated into the RouteDispatcher which can dispatch modules as well.

Now, modules are called via the "&route" parameter like all other routes.

Additionally, the requested URLs for modules were requested with the additional
"moduleToken" which is now called "token".

This way, special treatment for modules when dispatching is removed,
however the security checks are still in place so this is kept as is.

All places where URLs are generated can now still be accessed via
`BackendUtility::getModuleUrl()` which can deal with routes, module names
and routePaths (from the URL) to keep backwards-compatibility.

Next Steps:
- Migration wizard for bookmarks + Streamline bookmarks code (see todos)
- Check what needs to be added in ExtensionManagementUtility
- Introduce slugs in routes for BE, e.g. /file-edit/{fileId}/ and /module/page/view/{id}
- Document reserved GET parameters "id", "route" and "token"
- Cleanup usage of determineScriptId and getModuleUrl to use new API

Resolves: #82406
Releases: master
Change-Id: If11c3d5289e14bc9ea766468b8e94cce95c23c71
Reviewed-on: https://review.typo3.org/53881
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use correct values in settings InstallTool 49/54049/4
Simon Praetorius [Sat, 9 Sep 2017 08:54:32 +0000 (10:54 +0200)]
[BUGFIX] Use correct values in settings InstallTool

Currently, the InstallTool will use the global TYPO3_CONF_VARS for the
settings form. In backend context, this contains merged TypoScript,
which shouldn't be added to LocalConfiguration.php.

Resolves: #82399
Releases: master
Change-Id: I0aabbde5c8fb8574fe30422fa687849271a3d618
Reviewed-on: https://review.typo3.org/54049
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Support defer attribute for JavaScript includes in TypoScript 53/54053/3
Simon Praetorius [Sat, 9 Sep 2017 10:13:36 +0000 (12:13 +0200)]
[FEATURE] Support defer attribute for JavaScript includes in TypoScript

When including JavaScript files in TypoScript, the HTML5 attribute
`defer` is now supported.

Resolves: #80542
Releases: master
Change-Id: I81ff3968360585692ec586449f64856dc0541f93
Reviewed-on: https://review.typo3.org/54053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Distinguish install tool actions with button colors 55/54055/2
Simon Praetorius [Sat, 9 Sep 2017 11:08:35 +0000 (13:08 +0200)]
[TASK] Distinguish install tool actions with button colors

Resolves: #82405
Releases: master
Change-Id: Id28b655b8ebf4853e960b3dd97414d31d42ff6de
Reviewed-on: https://review.typo3.org/54055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Tested-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove old typoscript constants "TSConstantEditor" 48/54048/6
Markus Hoelzle [Fri, 8 Sep 2017 22:38:12 +0000 (00:38 +0200)]
[!!!][TASK] Remove old typoscript constants "TSConstantEditor"

Remove support for the special constant "TSConstantEditor".
This constant was used to show additional helping information
in the constants editor and is dropped as ancient and widely
unknown and rarely used feature.

Releases: master
Resolves: #82398
Change-Id: I9825ca5a321c6c92159a5cd94ca5ed6c9ea1d0ff
Reviewed-on: https://review.typo3.org/54048
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Perform rollback only once if undeleting CE with History/Undo 73/53973/6
Lukasz Uznanski [Thu, 7 Sep 2017 19:19:15 +0000 (21:19 +0200)]
[BUGFIX] Perform rollback only once if undeleting CE with History/Undo

Releases: master, 8.7
Resolves: #81649
Change-Id: I1cb9a681b46327af56c2cb080c92b3cc273b0e10
Reviewed-on: https://review.typo3.org/53973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Render backend icon list by existing files 61/54061/6
Patricia Tiedemann [Sat, 9 Sep 2017 12:19:39 +0000 (14:19 +0200)]
[FOLLOWUP][TASK] Render backend icon list by existing files

* Re-added the "spinning" option for spinners (thx Nathan)
* Changed cache from backend_core to asset (thx @helhum)

Resolves: #82348
Releases: master
Change-Id: I1e59da79dc7072b582866213a571e35bfee4b639
Reviewed-on: https://review.typo3.org/54061
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Render backend icon list by existing files 20/54020/13
Patricia Tiedemann [Fri, 8 Sep 2017 12:50:39 +0000 (14:50 +0200)]
[TASK] Render backend icon list by existing files

Until now all of the backend icons were a manually edited array of file
paths. With this patch defined icon folders in the core are scanned
for existing icon files and build most of that static array
automatically.

For historic reason (and hopefully soon to be removed alltogether) a
second array of statically declared icons is added and merged into.

Some icons that were in the original static list but whose files
actually are missing or misnamed are marked as deprecated.

Resolves: #82348
Releases: master
Change-Id: I8dc4fbbe815d923eda55e1c1b072369e62f66d87
Reviewed-on: https://review.typo3.org/54020
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Make Extbase pagination work with QueryBuilder queries 09/53409/12
Tymoteusz Motylewski [Mon, 14 Aug 2017 14:27:22 +0000 (16:27 +0200)]
[BUGFIX] Make Extbase pagination work with QueryBuilder queries

Now you can pass a query built by QueryBuilder to $query->statement(),
and use the QueryResult for pagination.

So inside repository you can create custom query like:

$queryBuilder->select('*')->...
$query = $this->createQuery();
$query->statement($queryBuilder);
return $query->execute();

and pass the result to paginate ViewHelper.

Resolves: #81887
Releases: master, 8.7
Change-Id: Ia00f673039362afaa8ef7232ba4bc89c520d5a46
Reviewed-on: https://review.typo3.org/53409
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix using contains in query on property of group 93/53993/8
Łukasz Uznański [Fri, 8 Sep 2017 09:29:36 +0000 (11:29 +0200)]
[BUGFIX] Fix using contains in query on property of group

Related: master, 8.7
Resolves: #80215
Change-Id: I6f5c88650d6167550a46ad2200c846ec9d11d34a
Reviewed-on: https://review.typo3.org/53993
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Migrate cHash configuration on silent upgrade wizard 02/53202/11
Benni Mack [Tue, 13 Jun 2017 15:19:06 +0000 (17:19 +0200)]
[TASK] Migrate cHash configuration on silent upgrade wizard

The cHash calculation is done on every TYPO3 request, which is
really unnecessary overhead, as this could be taken care by the
SilentConfigurationUpgradeService once and store the new value.

Resolves: #81568
Releases: master
Change-Id: I30b562c0b9376d1044979cd7264c67a79209f6b6
Reviewed-on: https://review.typo3.org/53202
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update localization rendering tests to newest Testing Framework 51/54051/2
Tymoteusz Motylewski [Sat, 9 Sep 2017 10:20:18 +0000 (12:20 +0200)]
[TASK] Update localization rendering tests to newest Testing Framework

addTypoScriptToTemplateRecord method was added to FunctionalTestCase.php
in Testing Framework.
So we can remove it from test cases.
Fix two other germlins also (unneeded comment and unused variable).

Resolves: #82401
Releases: master, 8.7, 7.6
Change-Id: I8144bae5a807d60123ef5228a44eba579a7705c7
Reviewed-on: https://review.typo3.org/54051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Create multiple pages: cast bool values to int 54/54054/2
Andreas Fernandez [Sat, 9 Sep 2017 11:00:25 +0000 (13:00 +0200)]
[BUGFIX] Create multiple pages: cast bool values to int

Resolves: #82403
Related: #81768
Releases: master
Change-Id: Id6610c9f7fbc445c142c999bb41c7b7c6eb83729
Reviewed-on: https://review.typo3.org/54054
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Move felogin type icon registration 61/53961/2
Mathias Brodala [Thu, 7 Sep 2017 16:29:43 +0000 (18:29 +0200)]
[TASK] Move felogin type icon registration

Resolves: #82350
Releases: master
Change-Id: I60280df8d62cc65250bf5edbf8c26a65dbb5f250
Reviewed-on: https://review.typo3.org/53961
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Remove legacy code for version extension 44/54044/5
Matthias Vogel [Fri, 8 Sep 2017 21:15:39 +0000 (23:15 +0200)]
[BUGFIX] Remove legacy code for version extension

The "Display version" module of ext:version has been
moved to ext:compatibility7 with v8. The list module links
to this view but the link is dead if compat7 is not loaded.
The v8 version of the patch now checks for "loaded version,
loaded compat7, but not loaded workspaces" to render the link,
in master, this button is removed entirely

Resolves: #82394
Related: #79942
Releases: master, 8.7
Change-Id: I4e32a63b144b658f84362e25bda1cc312247367e
Reviewed-on: https://review.typo3.org/54044
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix system maintainer access 65/53965/3
Helmut Hummel [Thu, 7 Sep 2017 17:27:13 +0000 (19:27 +0200)]
[BUGFIX] Fix system maintainer access

Fix a check to not allow acces to admin users
but system maintainers only.

Change-Id: I2e5209bbaf7c3e3cee013d1fa08f48ff7e776956
Resolves: #82396
Related: #82306
Related: #82395
Releases: master
Reviewed-on: https://review.typo3.org/53965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Replace all system_extinstall urls with corresponding urls 46/54046/4
Matthias Vogel [Fri, 8 Sep 2017 21:42:54 +0000 (23:42 +0200)]
[BUGFIX] Replace all system_extinstall urls with corresponding urls

Resolves: #82393
Releases: master
Change-Id: I0782af0fa9dc36f7a1e54caec8b7ff24334e63c7
Reviewed-on: https://review.typo3.org/54046
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add configurable footnote to login screen 18/53918/8
Christian Heindl [Tue, 5 Sep 2017 16:55:43 +0000 (18:55 +0200)]
[FEATURE] Add configurable footnote to login screen

We are introducing a new option to provide an optional footnote for the
login screen. The footnote can provide for example legal information for
the login screen image or a descriptive text. This option is now
available in the backend extension configuration.

Resolves: #82303
Releases: master
Change-Id: I14f90ecfa8eee538234dcc9542576f6ab9f1d774
Reviewed-on: https://review.typo3.org/53918
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Remove TYPO3.jQuery 37/53237/8
Benni Mack [Fri, 16 Jun 2017 11:32:48 +0000 (13:32 +0200)]
[!!!][TASK] Remove TYPO3.jQuery

This change removes the availability of TYPO3.jQuery within the
TYPO3 Core by default.

The constants PageRenderer::JQUERY_NAMESPACE_DEFAULT / and
PageRenderer: JQUERY_NAMESPACE_DEFAULT_NOCONFLICT namespace options
"jQuery" are removed. This also means the removal
of having custom namespaces of jQuery (e.g. TYPO3.bennis_jQuery) leaving
"noConflict" to be used by default.

Related: #79221
Resolves: #82378
Releases: master
Change-Id: Ibc939999159dbf376b09f53aacac618ed7cc40e8
Reviewed-on: https://review.typo3.org/53237
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Restrict em & lang module to system maintainer 47/54047/3
Christian Kuhn [Fri, 8 Sep 2017 21:44:24 +0000 (23:44 +0200)]
[TASK] Restrict em & lang module to system maintainer

Both extension manager and language pack adiminstration
change system configuration and should be restricted to
system maintainers.

Change-Id: I456ece7726b79a81c375eec0c949a5c63fd97df2
Resolves: #82395
Releases: master
Reviewed-on: https://review.typo3.org/54047
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use TYPO3_OS constant in Services registration 53/53953/2
Benni Mack [Thu, 7 Sep 2017 14:25:20 +0000 (16:25 +0200)]
[TASK] Use TYPO3_OS constant in Services registration

There is a comment that TYPO3_OS is not yet defined, which
is wrong as it is one of the first things available during bootstrap,
so the check can be used directly.

Resolves: #82343
Releases: master, 8.7
Change-Id: I01e0aa7a090bc068195b44474f645d09220f8b71
Reviewed-on: https://review.typo3.org/53953
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - use own folder for form definitions 89/53989/15
Thomas Kieslich [Fri, 8 Sep 2017 08:34:43 +0000 (10:34 +0200)]
[TASK] EXT:form - use own folder for form definitions

Change default filemount for form definitions to fileadmin/form_definitions,
the directory is automatically created if necessary.

Existing forms in fileadmin/user_upload can be listed, duplicated and removed
but not edited.

Since no migration wizard can be provided for this, a manual migration is
necessary which can be done

1) ...by moving all form definitions to the new directory via filesystem or
2) ...by duplicating all form definitions (thus storing them in the new
location) and removing the old form definitions.

Resolves: #82328
Releases: master
Change-Id: Id804f58747a203e92998aca2699b37f81900e9e7
Reviewed-on: https://review.typo3.org/53989
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Remove extended fluid core class CmsVariableProvider 28/54028/3
Benni Mack [Fri, 8 Sep 2017 15:12:06 +0000 (17:12 +0200)]
[FOLLOWUP][TASK] Remove extended fluid core class CmsVariableProvider

Class CmsVariableProvider within EXT:fluid was removed but the tests
were kept, they are removed as well.

Resolves: #82229
Releases: master
Change-Id: I59812100589a7d4e63619896f78a63dadbdda657
Reviewed-on: https://review.typo3.org/54028
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Install tool: Improve ajax error handling 35/54035/3
Markus Hoelzle [Fri, 8 Sep 2017 16:19:59 +0000 (18:19 +0200)]
[TASK] Install tool: Improve ajax error handling

Show an error message if the server answer ajax calls
with http status code 200. This could happen if a proxy
responses to the http request or a network failures
occures.

Releases: master
Resolves: #82388

Change-Id: Ie91832dde42c7d17323be084cfaf67cc98de8535
Reviewed-on: https://review.typo3.org/54035
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] PHP7.2: Check value for NULL before count 38/53938/6
Alexander Opitz [Thu, 7 Sep 2017 07:04:47 +0000 (09:04 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82275
Releases: master, 8.7, 7.6
Change-Id: I77dc811456f4bbd759e28c27284c4652ad09dd23
Reviewed-on: https://review.typo3.org/53938
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove context service from install tool 66/53966/3
Romain Canon [Thu, 7 Sep 2017 17:28:50 +0000 (19:28 +0200)]
[TASK] Remove context service from install tool

This service was not useful anymore as the install tool modules handling
changed.

It is replaced by a single string that allows doing basically the same
job.

Resolves: #82353
Releases: master
Change-Id: I34e28e0d1a716b293897f54f7f800e5e6fb8e0c5
Reviewed-on: https://review.typo3.org/53966
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update typo3/testing-framework to 1.1.3 36/54036/2
Christian Kuhn [Fri, 8 Sep 2017 16:44:10 +0000 (18:44 +0200)]
[TASK] Update typo3/testing-framework to 1.1.3

Three smaller patches to improve functional testing.

Change-Id: I7ff6b9c6b4d5b22b42ab2d09e670337e5bad8162
Resolves: #82389
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54036
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Store extension configuration in key EXTENSIONS 99/53999/7
Matthias Vogel [Fri, 8 Sep 2017 09:53:16 +0000 (11:53 +0200)]
[BUGFIX] Store extension configuration in key EXTENSIONS

The previous patch changed it to EXTCONF,
but this conflicts with other stuff.

Resolves: #82370
Releases: master
Change-Id: Ib515a1364f45739fb7f8e0fa3e781099f1c1a107
Reviewed-on: https://review.typo3.org/53999
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Enforce checkout with linux lf for yaml files 39/54039/2
Benjamin Kott [Fri, 8 Sep 2017 19:06:20 +0000 (21:06 +0200)]
[BUGFIX] Enforce checkout with linux lf for yaml files

Resolves: #82392
Releases: master, 8.7
Change-Id: I2ba42454a6b16aa8b4dd97a5741251b4fe265c0e
Reviewed-on: https://review.typo3.org/54039
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Refactor distribution list view with cards 19/53619/12
Markus Sommer [Fri, 28 Jul 2017 14:43:39 +0000 (16:43 +0200)]
[TASK] Refactor distribution list view with cards

The card component has been extended and is now more flexible to be
more usefull for different usecases, and is now used in the distribution
listing of the extension manager. We have also changed to Documentation
format of the CSS files to match KSS Knyle Style Sheets format.

Releases: master
Resolves: #82000

Change-Id: I61711dd0ee6c38e3c249d9b744a3ee6b2e24273e
Reviewed-on: https://review.typo3.org/53619
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[BUGFIX] Remove restrictions from SQL in InstallTool 76/53976/2
Simon Praetorius [Thu, 7 Sep 2017 20:30:27 +0000 (22:30 +0200)]
[BUGFIX] Remove restrictions from SQL in InstallTool

Since the context of the install tool can now be either standalone
or backend, SQL queries need to be adjusted so that Doctrine
restrictions don't change their results.

Resolves: #82360
Releases: master
Change-Id: Ic1934f06f73d6212d108658ad655228f2e983cc3
Reviewed-on: https://review.typo3.org/53976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[CLEANUP] Remove some unused variables and cleanup some code styles 75/53975/3
Markus Hoelzle [Thu, 7 Sep 2017 20:33:36 +0000 (22:33 +0200)]
[CLEANUP] Remove some unused variables and cleanup some code styles

Remove some unused variable and cleanup some PHP docs and some code styles

Resolves: #82364
Releases: master
Change-Id: I72f69a7c05514088bd318fed0e2c4ecc4710e183
Reviewed-on: https://review.typo3.org/53975
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] SplitButtons: Abort click event if requested 68/53968/3
Andreas Fernandez [Thu, 7 Sep 2017 18:13:17 +0000 (20:13 +0200)]
[BUGFIX] SplitButtons: Abort click event if requested

If any callback is registered by `SplitButtons.addPreSubmitCallback()` and
requests to stop the event by `stopPropagation()`, the event must be
aborted and not only possibly stacked events.
Additionally, the `preventExec` flag gets reset.

Resolves: #82355
Related: #77942
Releases: master, 8.7, 7.6
Change-Id: Ib8478ef4c51915365c804c1c408b3fc16a13da0b
Reviewed-on: https://review.typo3.org/53968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][BUGFIX] Separate sys_history from sys_log db entries 95/53195/29
Benni Mack [Tue, 13 Jun 2017 05:17:18 +0000 (07:17 +0200)]
[!!!][BUGFIX] Separate sys_history from sys_log db entries

Before, the history module fetched info about "modified records" from
sys_history+the authoritive user from a coupled sys_log entry.

Info about "insert" and "delete" was fetched from sys_log solely.

However, when using a scheduled cleanup task to truncate sys_log
then all history information is useless (see bug report).

The patch introduces a new RecordHistoryStore as an abstraction
for adding history entries (currently done solely within DataHandler).

It adds some additional, necessary SQL fields to sys_history to
store all information in there and creates an update wizard
to migrate all coupled sys_history/sys_log entries to a
new sys_history entry itself.

Additionally, the whole existing "RecordHistory" class is
now only necessary for fetching the so-called ChangeLog,
for a page or a specific record, and to do rollbacks, preparing
the history records so they can be worked on.

The whole logic for fetching the GET/POST parameters is moved
into the "ElementHistoryController", everything that is only possible
via Fluid is moved from the RecordHistory object and the
ElementHistoryController into the view.

Referencing from sys_log (Log module) into sys_history is
now done the other way around, storing information about
the corresponding history entry inside sys_log.
As a side-effect, sys_log should load faster.

Abstraction basis:
- sys_history is the only source of truth about the history of a record
- sys_log contains a reference to an history entry now
(inside sys_log.log_data) to link from the backend log module
- RecordHistoryStore exists for tracking changes to records
- RecordHistory is for retrieving, compiling the history/changelog and rollbacks
- ElementHistoryController is doing PSR-7 style request/response
handling and preparing data for the view
- Fluid is handling more view functionality now, removing
the need for doing <f:format.raw> everywhere in the templates.

Sidenotes:
* Data within sys_history is now stored as JSON, not serialized anymore
* Adding/deleting was previously stored in sys_log only, is now within sys_history
* Moving records is now tracked (but not evaluated yet)
* Highlight/Snapshot functionality within the Backend Module
was removed

This functionality is built so it can also be used within Extbase
persistence and in FE in general in a future iteration.

Resolves: #55298
Resolves: #71950
Releases: master
Change-Id: I354317609099bac10c264b9932e331fa908c98be
Reviewed-on: https://review.typo3.org/53195
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:form - catch YAML parsing errors 14/54014/7
Daniel Lorenz [Fri, 8 Sep 2017 11:52:32 +0000 (13:52 +0200)]
[BUGFIX] EXT:form - catch YAML parsing errors

Catche YAML parsing errors and display this them alongside
their form definition files in form module and plugin.

Resolves: #82369
Releases: master, 8.7
Change-Id: Icf71027d21d0a8e30c238a51369676715de2e5c5
Reviewed-on: https://review.typo3.org/54014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove option to allow uploading system extensions 08/54008/3
Benni Mack [Fri, 8 Sep 2017 10:54:12 +0000 (12:54 +0200)]
[!!!][TASK] Remove option to allow uploading system extensions

The extension manager has the option to upload an extension
into typo3/sysext/, which is no recommendation and should
not be an option from the Backend UI itself, as it is heavily
conflicting with core updates where typo3_src/ / sysext is
exchanged.

The option is removed without substitution, if somebody
wants to play with typo3/sysext/ it's at the admins own risk,
and should not be encouraged or mentioned neither in the install
tool (All Configuration) nor Extension Manager.

Resolves: #82377
Releases: master
Change-Id: I19782a4960bb52bd2012b79e912e483610d297d8
Reviewed-on: https://review.typo3.org/54008
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] add document ready for initalize CardLayout 23/54023/2
Matthias Vogel [Fri, 8 Sep 2017 13:18:52 +0000 (15:18 +0200)]
[BUGFIX] add document ready for initalize CardLayout

Resolves: #82385
Releases: master
Change-Id: I7bbb7066e7097b56509bbaaeee3468723420af74
Reviewed-on: https://review.typo3.org/54023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Improve SCSS of Form Framework 62/53962/6
Andreas Steiger [Thu, 7 Sep 2017 15:15:38 +0000 (17:15 +0200)]
[TASK] Improve SCSS of Form Framework

Cleanup SCSS of Form Framework. Improve the usage of variables.
Furthermore, optimize the structure tree spacings of Form Editor.

Resolves: #82327
Releases: master
Change-Id: Ia1088475e16e5a04999140cca5ee3ff7d713e661
Reviewed-on: https://review.typo3.org/53962
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Make "lang:language:update" a symfony console command 28/53928/6
Alexander Schnitzler [Wed, 6 Sep 2017 11:44:36 +0000 (13:44 +0200)]
[TASK] Make "lang:language:update" a symfony console command

This commit migrates the command "lang:language:update" from
an extbase command controller to a symfony console command.

Also, the alias language:update will be flagged deprecated.

Resolves: #82315
Releases: master
Change-Id: If9fd08981ee8286bd8187fe5eaa5b36f625bd576
Reviewed-on: https://review.typo3.org/53928
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Decouple classes extending AbstractRecordList 47/53947/15
Matthias Vogel [Fri, 8 Sep 2017 10:23:25 +0000 (12:23 +0200)]
[!!!][TASK] Decouple classes extending AbstractRecordList

In order to refactor the page module, list module,
and the file module individually,
the classes should become independent from each other.

Resolves: #82334
Releases: master
Change-Id: I2ca6aad28cbe4a88c03ef71f47fc11eb4b7649f7
Reviewed-on: https://review.typo3.org/53947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Fix minor error handler code bugs 17/54017/2
Benni Mack [Fri, 8 Sep 2017 12:21:33 +0000 (14:21 +0200)]
[FOLLOWUP][BUGFIX] Fix minor error handler code bugs

ErrorHandler should deal with the same severity for trigger_error()
for E_USER_DEPRECATED as GeneralUtility::deprecationLog()
when calling GeneralUtility::devLog().

Resolves: #82375
Releases: master, 8.7
Change-Id: Iaff5f96f5bd0a2d94bb3bc76d9d3fec2d019c901
Reviewed-on: https://review.typo3.org/54017
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Separators shown in explicit allow/deny section 09/54009/2
Oliver Hader [Fri, 8 Sep 2017 10:49:01 +0000 (12:49 +0200)]
[BUGFIX] Separators shown in explicit allow/deny section

The explicit allow/deny section of backend user groups (be_groups)
render separators (--div--) in the backend which need to be skipped.

Change-Id: Iac578d43a7a561618d095819b9d667c613621f2b
Resolves: #82379
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54009
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix configuration of distribution packages 05/54005/3
Markus Hoelzle [Fri, 8 Sep 2017 10:24:34 +0000 (12:24 +0200)]
[BUGFIX] Fix configuration of distribution packages

Fix link to configuration of distribution packages
and redirect after saving this confiuration.

Releases: master,8.7
Resolves: #82376
Change-Id: I7f054a32187260e102b30c097937d5348ec121a6
Reviewed-on: https://review.typo3.org/54005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix minor error handler code bugs 02/54002/2
Benni Mack [Fri, 8 Sep 2017 10:00:11 +0000 (12:00 +0200)]
[BUGFIX] Fix minor error handler code bugs

ErrorHandler has a few minor quirks:

1. the protected property is an integer (bitwise-comparison) but initialized as array
2. small indention and repeatable string introduction
3. human-readable text for E_USER_DEPRECATED missing
4. error handling when no autoloader is available is obsolete.

The patch fixes all these minor issues.

Resolves: #82375
Releases: master, 8.7
Change-Id: Id6f9616602021e04ac6a50737438253a62da788c
Reviewed-on: https://review.typo3.org/54002
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years agoRevert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class" 04/54004/3
Christian Kuhn [Fri, 8 Sep 2017 10:14:36 +0000 (12:14 +0200)]
Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac
Releases: master, 8.7
Resolves: #82131
Reverts: #82131
Reviewed-on: https://review.typo3.org/54004
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add the full namespace to afterInitializeCurrentPage 72/53972/4
Daniel [Thu, 7 Sep 2017 20:16:17 +0000 (22:16 +0200)]
[TASK] Add the full namespace to afterInitializeCurrentPage

Releases: master, 8.7
Resolves: #82362
Change-Id: I36a4341aea620027822af1b8714e9197ff4bcb00
Reviewed-on: https://review.typo3.org/53972
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Show spaces of content elements in page module 79/53879/4
Christoph Lehmann [Mon, 4 Sep 2017 15:24:23 +0000 (17:24 +0200)]
[BUGFIX] Show spaces of content elements in page module

Resolves: #82290
Releases: master,8.7
Change-Id: Ie988290ae4431f8a77dc2c38397429b9fa0c95ef
Reviewed-on: https://review.typo3.org/53879
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Unify labels for space before/after 37/53937/3
Stefan Neufeind [Thu, 7 Sep 2017 06:52:46 +0000 (08:52 +0200)]
[BUGFIX] Unify labels for space before/after

Resolves: #82321
Releases: master, 8.7
Change-Id: Idd47fbb0b7af3f5668d45a6aee545c794ec17a1a
Reviewed-on: https://review.typo3.org/53937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Fluid: Fix missing classes 98/53998/2
Andreas Fernandez [Fri, 8 Sep 2017 09:53:15 +0000 (11:53 +0200)]
[FOLLOWUP][TASK] Fluid: Fix missing classes

Fix a forgotten comment.

Resolves: #82335
Releases: master
Change-Id: Iff63f765fd741462cbed56e56543916f92b65444
Reviewed-on: https://review.typo3.org/53998
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Fluid: Fix missing classes 45/53945/4
Benni Mack [Thu, 7 Sep 2017 12:20:48 +0000 (14:20 +0200)]
[TASK] Fluid: Fix missing classes

When TYPO3 v8.0 switched to Fluid standalone, the RootNode
class was removed but the references were kept and done via
class aliases.

The Fluid standalone class should be used instead of the
class alias.

Resolves: #82335
Releases: master, 8.7
Change-Id: I50f74b71b86fcc347dc6bffbde052e6e2adbc842
Reviewed-on: https://review.typo3.org/53945
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] PHP7.2: Check value for NULL before count 39/53939/3
Alexander Opitz [Thu, 7 Sep 2017 07:48:21 +0000 (09:48 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82322
Releases: master, 8.7, 7.6
Change-Id: I31f7bc2db61337e10be7ffd44ac294b77c44d07b
Reviewed-on: https://review.typo3.org/53939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - fix error on single database insert 69/53969/2
Mathias Brodala [Thu, 7 Sep 2017 18:37:13 +0000 (20:37 +0200)]
[BUGFIX] EXT:form - fix error on single database insert

Resolves: #81805
Releases: master, 8.7
Change-Id: I8ee3582170db9812d7be2b9710cb4d46335ec86a
Reviewed-on: https://review.typo3.org/53969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Install tool: CLI user is no system maintainer 81/53981/3
Mathias Brodala [Fri, 8 Sep 2017 06:51:00 +0000 (08:51 +0200)]
[BUGFIX] Install tool: CLI user is no system maintainer

Prevent selection of _cli_ user as system maintainer.

Related: #82319
Resolves: #82367
Releases: master
Change-Id: Ia1e67faea383817d4931c956a166525e1aa9e8e0
Reviewed-on: https://review.typo3.org/53981
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails 83/53383/8
Ralf Zimmermann [Mon, 3 Jul 2017 10:23:09 +0000 (12:23 +0200)]
[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails

Add a "renderingOptions" property called "_isHiddenFormElement" to
prevent form elements from being shown within summary pages and emails.

Resolves: #81770
Releases: master, 8.7
Change-Id: Iea3232879fc2be2cae00e5ed5cea565e68e192f3
Reviewed-on: https://review.typo3.org/53383
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - change naming and icon in new content element wizard 57/53957/5
Thomas Kieslich [Thu, 7 Sep 2017 15:04:00 +0000 (17:04 +0200)]
[TASK] EXT:form - change naming and icon in new content element wizard

Change language labels and move them to ext:form locallang.xlf.
Change the icon to content-form.

Resolves: #81650
Releases: master, 8.7
Change-Id: I1c497b78da92dc589ad9d7a47dde35c5aeba488a
Reviewed-on: https://review.typo3.org/53957
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Remove not working "Lock Install Tool" button 71/53971/3
Matthias Vogel [Thu, 7 Sep 2017 19:49:37 +0000 (21:49 +0200)]
[BUGFIX] Remove not working "Lock Install Tool" button

Resolves: #82359
Releases: master
Change-Id: Id439a0b04e6af11214d0df7b30cb20e7c94dd99c
Reviewed-on: https://review.typo3.org/53971
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error'] 17/53817/5
Benni Mack [Mon, 28 Aug 2017 04:48:14 +0000 (06:48 +0200)]
[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error']

The global variable $GLOBAL['error'] is used only in ExtJS-context for ExtDirect
(via ExtDirectDebug) however, but evaluates at every request.

This is the first of a series of patches to remove ExtJS in total.

The global methods debugBegin() and debugEnd() are removed as well.

Resolves: #37180
Releases: master
Change-Id: I00843d85660e85c213ac66059abdd84344c4fe3f
Reviewed-on: https://review.typo3.org/53817
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install tool: System maintainer administration 31/53931/6
Christian Kuhn [Wed, 6 Sep 2017 17:22:33 +0000 (19:22 +0200)]
[TASK] Install tool: System maintainer administration

Adds a card to the "Settings" menu to allow configuration of
"System Maintainers" in the install tool writing SYS/systemMaintainers
array to LocalConfiguration.

Change-Id: I0219b60e9a261373befab7b846e55b61ea215e5e
Resolves: #82319
Releases: master
Reviewed-on: https://review.typo3.org/53931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - fix values with dots within form editor 56/53956/7
Ralf Zimmermann [Thu, 7 Sep 2017 15:16:13 +0000 (17:16 +0200)]
[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53956
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] EXT:form - fix missing id attribute 59/53959/3
protos [Thu, 7 Sep 2017 15:33:32 +0000 (17:33 +0200)]
[BUGFIX] EXT:form - fix missing id attribute

Insert missing id attribute for image and file upload element.

Resolves: #82223
Releases: master, 8.7
Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd
Reviewed-on: https://review.typo3.org/53959
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - cleanup of leftovers, better wording 51/53951/3
protos [Thu, 7 Sep 2017 14:04:08 +0000 (16:04 +0200)]
[TASK] EXT:form - cleanup of leftovers, better wording

Change some wording for better understanding in frontend and backend.

Resolves: #82326
Releases: master, 8.7
Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae
Reviewed-on: https://review.typo3.org/53951
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] EXT:form - Add HTML5 form types / attributes 16/52016/19
Ralf Zimmermann [Sun, 12 Mar 2017 18:26:40 +0000 (19:26 +0100)]
[FEATURE] EXT:form - Add HTML5 form types / attributes

It is now possible to add HTML5 elements with its needs.

Resolves: #80130
Resolves: #80128
Resolves: #80127
Resolves: #80125
Resolves: #80126
Releases: master
Change-Id: I1088d77c8ee52cca93878847a5d59c6b92faf1de
Reviewed-on: https://review.typo3.org/52016
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] EXT:form - fix page drag & drop 49/53949/4
Ralf Zimmermann [Thu, 7 Sep 2017 13:29:54 +0000 (15:29 +0200)]
[BUGFIX] EXT:form - fix page drag & drop

Fix JavaScript errors on page drag & drop within the form editor

Resolves: #82337
Releases: master, 8.7
Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb
Reviewed-on: https://review.typo3.org/53949
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[FEATURE] Store extension configuration as plain array 57/53657/8
Susanne Moog [Thu, 20 Jul 2017 16:37:23 +0000 (18:37 +0200)]
[FEATURE] Store extension configuration as plain array

Extension configuration is now stored as plain array
instead of serialized values. To ensure backwards-
compatibility and stream-line core usage, the old
values will still be stored and written in
$GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'] whereas
the new array will be stored in
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF'].

As a second step we are going to introduce an API for
retrieving extension configuration to remove the necessity
for GLOBALS access in this case.

Resolves: #82254
Releases: master
Change-Id: I52ef7768491633e114e7e1b153a4ba63e07243ff
Reviewed-on: https://review.typo3.org/53657
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install Tool: Remove authentication from backend context 60/53860/7
Benni Mack [Fri, 1 Sep 2017 07:00:10 +0000 (09:00 +0200)]
[TASK] Install Tool: Remove authentication from backend context

Currently calling the install tool modules from within the Backend does a
simple redirect with adding GET variables.

That's the reason why you need to re-authenticate again, and the context
is handed over as a query parameter, which is simply not needed at all.

Now, the redirect is removed, as the Backend entrypoint / request handler
handles the authentication of the backend user, and the standalone entry
point deals with the install tool password etc.

The context parameter is now detected by the entry point (!) as well,
allowing to get rid of quite some code.

There are some more consequences:
- Calling the install tool from the backend does not validate if you configuration
is set up (= recovery necessary) -> since you're already in the backend we guess
you're fine anyway.
- Redirect functionality is almost not needed anymore in the regular request handler
- routeParameters concept was removed again (which was introduced a couple of weeks ago)

Additionally, the contextService could be replaced at a later stage with just
a string.

Resolves: #82306
Releases: master
Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c
Reviewed-on: https://review.typo3.org/53860
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Properly render multiline form values 50/53950/2
Daniel Lorenz [Thu, 7 Sep 2017 13:25:50 +0000 (15:25 +0200)]
[BUGFIX] Properly render multiline form values

Properly render multiline form values in summary page
and HTML emails.

Resolves: #82026
Releases: master, 8.7
Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587
Reviewed-on: https://review.typo3.org/53950
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Shorten form doc file paths 46/53946/3
Mathias Brodala [Thu, 7 Sep 2017 12:25:34 +0000 (14:25 +0200)]
[TASK] Shorten form doc file paths

Use shorter file paths to reduce the risk of hitting the Windows
file path limit.

Resolves: #82336
Releases: master
Change-Id: Ibbba15a71b6b69df52ccf009ebe298f09840d864
Reviewed-on: https://review.typo3.org/53946
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Tests for rendering tt_content with FAL in Extbase 21/53921/5
Tymoteusz Motylewski [Wed, 6 Sep 2017 07:01:49 +0000 (09:01 +0200)]
[TASK] Tests for rendering tt_content with FAL in Extbase

Functional tests checking Extbase rendering of tt_content
records with FAL images.

Also fixes two typos in fixture data.

Resolves: #82298
Releases: master, 8.7, 7.6
Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5
Reviewed-on: https://review.typo3.org/53921
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Do not use LIMIT/OFFSET on total count query 40/53940/2
Susanne Moog [Thu, 7 Sep 2017 08:27:30 +0000 (10:27 +0200)]
[BUGFIX] Do not use LIMIT/OFFSET on total count query

Usage of limit > 0 or offset in a count query do not
make sense and result in broken pagination in the list
module as the returned total count of items is always 0.

Reset given offsets/limit for that exact query.

Change-Id: I18b1964b860e51256a6d0a5f39fd4c40544bac85
Resolves: #82325
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - catch exceptions within page module and form engine 01/52701/5
Ralf Zimmermann [Thu, 4 May 2017 10:58:06 +0000 (12:58 +0200)]
[BUGFIX] EXT:form - catch exceptions within page module and form engine

* Show messages within page module and form engine if the backend user
  does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
  ext:form configuration is invalid.

Resolves: #80678
Resolves: #81113
Releases: master, 8.7
Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d
Reviewed-on: https://review.typo3.org/52701
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Move DefaultConfigurationDescription to Yaml format 23/53923/4
Benni Mack [Wed, 6 Sep 2017 05:13:45 +0000 (07:13 +0200)]
[TASK] Move DefaultConfigurationDescription to Yaml format

Defining all configuration options in TYPO3 Install Tool is now handled
via a Yaml file which additionally specifies the "type" of the configuration
option, allowing to use further render settings, one of them already introduced
for "allowedValues". This moves the "All Configuration" to a more flexible output
rendering of dropdowns for a specific type.

Resolves: #82312
Releases: master
Change-Id: Id23c6a8e57177a68659fe98cbe7278f8744c0c34
Reviewed-on: https://review.typo3.org/53923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove runtime cache and early return from TemplatePaths 17/53917/6
Claus Due [Tue, 5 Sep 2017 15:10:18 +0000 (17:10 +0200)]
[BUGFIX] Remove runtime cache and early return from TemplatePaths

This patch removes the previously introduced runtime cache
and early returns from TemplatePaths, both of which were
implemented in an attempt to prevent excessive TypoScript
parsing - an issue which has since been solved by optimising
the TypoScript parsing enough that a cache and early return
is no longer necessary (no longer constitutes a significant
performance increase).

The early return and caching introduced regressions described
in the related forge issues. Removing both solves those problems.

In addition, the method resolving TypoScript paths is now
covered by extensive unit tests confirming everything from
merging to sorting of template paths. An average of 8 tests
cover the method's lines. Each of the expected behaviors
is now declared as specific test.

Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63
Resolves: #82196
Resolves: #82181
Related: #79662
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update guzzlehttp/guzzle dependency to 6.3.0 24/53924/2
Benni Mack [Wed, 6 Sep 2017 07:57:40 +0000 (09:57 +0200)]
[TASK] Update guzzlehttp/guzzle dependency to 6.3.0

This brings PHP 7.2 support for guzzle functionality.

Verified that guzzle still runs with PHP7.0 (min requirement for us)

Resolves: #82313
Releases: master, 8.7
Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e
Reviewed-on: https://review.typo3.org/53924
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent empty sorting field to be quoted and put into an array 15/53915/2
Xavier Perseguers [Tue, 5 Sep 2017 14:17:26 +0000 (16:17 +0200)]
[BUGFIX] Prevent empty sorting field to be quoted and put into an array

Change-Id: I807a888ac7d977606d94f5ad9ccdfeee07ee61ec
Resolves: #82307
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>