Packages/TYPO3.CMS.git
5 years ago[BUGFIX] ClassLoader: Clear after Exception 62/34162/2
Alexander Opitz [Fri, 26 Sep 2014 07:55:13 +0000 (09:55 +0200)]
[BUGFIX] ClassLoader: Clear after Exception

Clearing the class cache and release the lock if an exception was
thrown while generating the class loader cache.

Resolves: #61900
Releases: master, 6.2
Change-Id: Iaac534e9cf333fe29f9ac90aed118cc953f857fe
Reviewed-on: http://review.typo3.org/34162
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Add namespace argument for inline settings array 69/34169/3
Frank Nägler [Fri, 14 Nov 2014 12:18:02 +0000 (13:18 +0100)]
[BUGFIX] Add namespace argument for inline settings array

Make it possible to set a namespace for inline settings array

Resolves: #62950
Releases: master, 6.2
Change-Id: I7170ca42ebc49ef56e4dead1274e541c603e0cbf
Reviewed-on: http://review.typo3.org/34169
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix bug in HMENU special prev 61/34061/4
Frederic Gaus [Thu, 13 Nov 2014 12:42:54 +0000 (13:42 +0100)]
[BUGFIX] Fix bug in HMENU special prev

This patch fixes a regression of patch #61721.
The array before this patch had numeric indexes and thus the first
one was not recognized in the prev menu.

Releases: master, 6.2
Resolves: #62482
Related: #61721
Change-Id: I2b05ffa3973fe7ca31b6e4ccd193d44718d1ec1a
Reviewed-on: http://review.typo3.org/34061
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Correct order of key / field deletion 01/34101/2
Alexander Stehlik [Wed, 12 Nov 2014 23:15:29 +0000 (00:15 +0100)]
[BUGFIX] Correct order of key / field deletion

Prevent an SQL error when deleting a key and the field belonging
to the key in the install tool at the same time.

Therefore the order of deleting keys and fields is changed from
field first and key second to key first and field second.

Resolves: #50450
Releases: master, 6.2
Change-Id: I30aff6ea6c2bf01dec6197eec8fd3aa7306cfcbb
Reviewed-on: http://review.typo3.org/34101
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Page module Quickedit: wizards are broken 10/33910/3
Benjamin Mack [Sat, 8 Nov 2014 18:32:49 +0000 (19:32 +0100)]
[BUGFIX] Page module Quickedit: wizards are broken

When using Quickedit mode of Page module, the header link and the RTE
wizards are broken.
Backpath is added twice to the wizard urls.

Releases: master, 6.2
Resolves: #60958
Change-Id: I9ad470f9b7ffd4b74a91e02c4be2615723e79fd3
Change-Id: If2d1a620a6b924521c458c2b9a53c9e79aa1c819
Reviewed-on: http://review.typo3.org/33910
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
5 years ago[BUGFIX] TypoScript userFunc condition does not work with static methods 87/34087/2
Oliver Hader [Thu, 13 Nov 2014 12:55:40 +0000 (13:55 +0100)]
[BUGFIX] TypoScript userFunc condition does not work with static methods

TypoScript allows to utilize functions (user-functions) to
integrate custom condition processing. However, this currently
only works with function defined in the global namespace - it
does not work with static methods.

Thus, something like this snipped won't work:
[userFunc = ConditionMatcherUserFunctions::isTrue(1)]

The solution is simple, replace function_exists() with a more
generic is_callable() check.

Fixes: #62918
Releases: master, 6.2
Change-Id: I260c73cac26dfd14efc67bc9f65ff39d6ba74da8
Reviewed-on: http://review.typo3.org/34087
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix broken form wizard with MSIE 32/34032/2
Romain Leleu [Wed, 20 Aug 2014 14:08:37 +0000 (16:08 +0200)]
[BUGFIX] Fix broken form wizard with MSIE

When "Behavior / Confirmation page" checkbox is checked in a
form content, MSIE fails to show the fields in right panel.
Hovering right panel's fields shows an empty blue box and an empty tooltip.
This bug only occurs when reloading forms with the checkbox enabled
or when enabling the checkbox.

This patch fixes a JS function that sets the value and then refreshes
the right panel when clicking on one of this kind of elements.

Resolves: #59305
Releases: master, 6.2
Change-Id: I7e4cf72cd06a92a4dbdc929b214c79ca6dcd52b2
Reviewed-on: http://review.typo3.org/34032
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Add label for the description of scheduler group record 68/33968/2
Georg Ringer [Mon, 10 Nov 2014 20:23:46 +0000 (21:23 +0100)]
[BUGFIX] Add label for the description of scheduler group record

Add the description also to the xlf file.

Resolves: #62839
Releases: master, 6.2
Change-Id: I238616eb0e8d8720dba193469a754f87672d2a82
Reviewed-on: http://review.typo3.org/33965
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-on: http://review.typo3.org/33968

5 years ago[BUGFIX] Bring datetime picker time fields back in IE10+ 67/33967/2
Nikola Stojiljkovic [Mon, 25 Aug 2014 20:49:28 +0000 (22:49 +0200)]
[BUGFIX] Bring datetime picker time fields back in IE10+

Change-Id: If6245a85a819ece6ab6125e65c6d3ee7d11b693f
Resolves: #61173
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33967
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[BUGFIX] Wrong hint in deprecation log for usage of feInterface 63/33963/2
Xavier Perseguers [Mon, 10 Nov 2014 18:07:04 +0000 (19:07 +0100)]
[BUGFIX] Wrong hint in deprecation log for usage of feInterface

Any extension may set parameter $addTofeInterface to 1 in the
corresponding ext_tables.php file.

Assumption that only EXT:statictemplates was setting this parameter
makes it hard to fix faulty third-party extensions.

Releases: master, 6.2
Resolves: #62835
Change-Id: Ib2e75a618eacfb24df8f532f30aa2b55c29597fb
Reviewed-on: http://review.typo3.org/33960
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/33963

5 years agoRevert "[TASK] Add verbose output to report mail for failed tests" 50/33750/2
Helmut Hummel [Mon, 3 Nov 2014 15:22:32 +0000 (16:22 +0100)]
Revert "[TASK] Add verbose output to report mail for failed tests"

This introduces a new feature, so it cannot go into a released version

This reverts commit 58621d4f2ae14404b242763540214c930fa5977b.

Change-Id: If911d305634f3ac25d4dcc7e86c16c5b96072df1
Reviewed-on: http://review.typo3.org/33750
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
Tested-by: Ernesto Baschny <ernst@cron-it.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] RTE: Multi-line lists in default PageTS configs cause problems 36/33936/2
Stanislas Rolland [Mon, 10 Nov 2014 03:28:10 +0000 (22:28 -0500)]
[BUGFIX] RTE: Multi-line lists in default PageTS configs cause problems

Problem: For the sake of clarity, some of the RTE default PageTS
configurations specify lists as multi-line values. If any of these is
ever json-encoded, as some are, for use in JavaScript, some entries in
the list will start with a line feed.
Solution: Use addToList syntax for each additional line.

Releases: master, 6.2
Resolves: #62805
Change-Id: I6cb5eb6556adf2c61bd2610bb6653d767b5972c8
Reviewed-on: http://review.typo3.org/33936
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE: JS exception regarding property disableStyleOnOptionLabel 16/33916/2
Stanislas Rolland [Sun, 9 Nov 2014 04:45:27 +0000 (23:45 -0500)]
[BUGFIX] RTE: JS exception regarding property disableStyleOnOptionLabel

Problem: BlockStyle plugin checks for property
this.pageTSconfiguration.disableStyleOnOptionLabel without checking
first that this.pageTSconfiguration exists at all.

Releases: master. 6.2
Resolves: #59574
Change-Id: Ic2554e44e6212475826d649416377f6c307df8db
Reviewed-on: http://review.typo3.org/33916
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE.default.buttons.blockstyle not configurable 14/33914/2
Stanislas Rolland [Sun, 9 Nov 2014 03:00:45 +0000 (22:00 -0500)]
[BUGFIX] RTE.default.buttons.blockstyle not configurable

Problem: Data from the TextStyle combobox,derived from the textstyle
configuration, appears in the BlockStyle combobox.
Solution:
1. Load the global classes configuration from PageTSconfig only once.
2. Force the initialization of the parsed classes object in the
HTMLArea.CSS.Parser class constructor. (ExtJS bug?)

Releases: master, 6.2
Resolves: #58034
Change-Id: Iaf2f8b7ee8cca347f5cd08619677965fdd1a0168
Reviewed-on: http://review.typo3.org/33914
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] Extension installer: Handle multiple blanks 41/33841/2
Stefan Froemken [Wed, 15 Oct 2014 12:36:50 +0000 (14:36 +0200)]
[BUGFIX] Extension installer: Handle multiple blanks

The parser of the ext_tables.sql file removes double blanks
from the input line - but only once. So if there are multiple
blanks at least double blanks remain and irritate the later
comparison about whether the field definition is different.

Resolves: #62245
Releases: master,6.2
Change-Id: I6ab4cb543f5373916388567d3d9969c6681fa8e8
Reviewed-on: http://review.typo3.org/33841
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] RTE: Inconsistent delete behaviour 98/33498/3
Stanislas Rolland [Tue, 4 Nov 2014 06:21:34 +0000 (01:21 -0500)]
[BUGFIX] RTE: Inconsistent delete behaviour

In Firefox, depending on how we delete something in RTE, we get
different results.
This change makes the results consistent and identical in all browsers.

Releases: master, 6.2
Resolves: #61747
Change-Id: I7bc15992efb0703b96a59adf6d14484249d9f785
Reviewed-on: http://review.typo3.org/33498
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] Quickedit mode: RTE has no user CSS 23/33823/3
Stanislas Rolland [Wed, 5 Nov 2014 15:12:20 +0000 (10:12 -0500)]
[BUGFIX] Quickedit mode: RTE has no user CSS

A similar issue arises with configured microdata schema.
This is a follow-up to change https://review.typo3.org/#/c/33569/

Releases: master, 6.2
Resolves: #56408
Change-Id: Ic8122d7a40372f1da85b31d1bd3a7677f2c14a2b
Reviewed-on: http://review.typo3.org/33823
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] ADOdb: Set charset properly 07/33807/2
Andreas Fernandez [Fri, 19 Sep 2014 11:55:16 +0000 (13:55 +0200)]
[BUGFIX] ADOdb: Set charset properly

Using ADOdb, the charset might not be set properly, since every
database driver needs to define their own "SetCharSet" method. Every
driver extends from ADOConnection. "SetCharSet" of this class just
returns FALSE.

Resolves: #61738
Releases: master, 6.2
Change-Id: Ia9cef4fa3da76523de883ed7faa5aaebde4b9e9b
Reviewed-on: http://review.typo3.org/33807
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] RTE wraps p tags around ol/ul in chrome and opera 73/33773/3
Stanislas Rolland [Tue, 4 Nov 2014 04:11:35 +0000 (23:11 -0500)]
[BUGFIX] RTE wraps p tags around ol/ul in chrome and opera

This is a follow-up to change https://review.typo3.org/#/c/33655/

Resolves: #62559
Resolves: #59559
Resolves: #52470
Releases: master, 6.2
Change-Id: I66c1ed5cf288cd8aaaac66fc12655c655ac1964c
Reviewed-on: http://review.typo3.org/33773
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE: In IE, the pasting pad sometimes shows an error page 59/33759/2
Stanislas Rolland [Mon, 3 Nov 2014 18:01:48 +0000 (13:01 -0500)]
[BUGFIX] RTE: In IE, the pasting pad sometimes shows an error page

In IE, the pasting pad for plain text pasting sometimes shows an
error page.
Apparently, a timing issue.

Releases: master, 6.2
Resolves: #62658
Change-Id: Idb34ea6bc00d6020da637addee42cfd2db2d87f3
Reviewed-on: http://review.typo3.org/33758
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit c51733a67caacc25ac569035aadc93a3ceebb737)
Reviewed-on: http://review.typo3.org/33759

5 years ago[TASK] RTE: Cleanup references to AllowClipboardHelper for Mozilla 55/33755/2
Stanislas Rolland [Mon, 3 Nov 2014 16:57:52 +0000 (11:57 -0500)]
[TASK] RTE: Cleanup references to AllowClipboardHelper for Mozilla

Support for allowClipboard policy has been removed from Firefox since
version 29. This is a follow-up to change
https://review.typo3.org/#/c/33367/

Relaeses: master, 6.2
Resolves: #62296
Change-Id: I71941c911bc9596495dfea5839d3dba678463357
Reviewed-on: http://review.typo3.org/33755
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[TASK] Add verbose output to report mail for failed tests 49/33749/2
Benedict Burckhart [Mon, 20 Oct 2014 15:45:55 +0000 (17:45 +0200)]
[TASK] Add verbose output to report mail for failed tests

Adds the failed tests messages to the mail.

Change-Id: I104b7ad98b2ce1ab8014a0751f7adc8c72ad6ca2
Resolves: #58786
Related: #62101
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33749
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[CLEANUP] Correct phpDoc of FrontendLoginController->getDisplayText Function 40/33740/2
Frederic Gaus [Mon, 3 Nov 2014 08:22:37 +0000 (09:22 +0100)]
[CLEANUP] Correct phpDoc of FrontendLoginController->getDisplayText Function

The parameter $stdWrapArray is definied as string in the phpDoc
annotation @param. Corrected this to array

Resolves: #62636
Releases: master, 6.2
Change-Id: Ie5b30878fec65f6102ae4afc0a2f24a2b791a356
Reviewed-on: http://review.typo3.org/33740
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix links of shortcuts to restricted pages in menus 26/33726/2
Helmut Hummel [Fri, 24 Oct 2014 01:39:00 +0000 (03:39 +0200)]
[BUGFIX] Fix links of shortcuts to restricted pages in menus

Fix missing links in menus when shortcuts point to access restricted
pages or shortcuts themselves are restricted.

This fixes TypoScript menu option "showAccessRestrictedPages"

Resolves: #60258
Releases: master, 6.2
Change-Id: I25739e776bae99e8b8b9787be515c04a60c2706d
Reviewed-on: http://review.typo3.org/33726
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Fix script URLs for traditional modules 07/33707/2
Helmut Hummel [Thu, 30 Oct 2014 16:44:11 +0000 (17:44 +0100)]
[BUGFIX] Fix script URLs for traditional modules

The introduction of CSRF protection for backend modules
introduced a regression for traditional modules.

Previously the script was calculated correctly if
not provided. Now API calls without providing the script
are assumed to be mod.php dispatched.

Fix that by checking if the M GET argument was sent
and fall back to traditional URL calculation.

Resolves: #62569
Releases: 6.2, master
Change-Id: I26d16acb513d678f117e0b645fe3eefebf909e3d
Reviewed-on: http://review.typo3.org/33707
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] RTE: In Chrome RTE inserts weird span tags 58/33658/2
Stanislas Rolland [Fri, 31 Oct 2014 04:41:30 +0000 (00:41 -0400)]
[BUGFIX] RTE: In Chrome RTE inserts weird span tags

Remove the span tags inserted by Chrome or Opera on execution of native
execCommand. The attributes of these span tags have evolved...
This is a follow-up change to http://review.typo3.org/33392.

Releases: master, 6.2
Resolves: #52470
Change-Id: Ib3c2fa3a1a8f0e378bfa2ca4a5f6e78d1fdf3da7
Reviewed-on: http://review.typo3.org/33658
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE wraps p tags around ol/ul in chrome and opera 56/33656/2
Stanislas Rolland [Fri, 31 Oct 2014 04:16:26 +0000 (00:16 -0400)]
[BUGFIX] RTE wraps p tags around ol/ul in chrome and opera

Releases: master, 6.2
Resolves: #62559
Change-Id: Ib9c0576e82424065e875a73edfa91795c71e841e
Reviewed-on: http://review.typo3.org/33656
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE: Quickedit mode - RTE has no user CSS 69/33569/5
Stanislas Rolland [Mon, 27 Oct 2014 14:11:56 +0000 (10:11 -0400)]
[BUGFIX] RTE: Quickedit mode - RTE has no user CSS

Fix wrong absolute path calculation.

Releases: master, 6.2
Resolves: #56408
Change-Id: Ia96197f0dcf81bb8b52b511c75ae303a85ec9b97
Reviewed-on: http://review.typo3.org/33569
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] Fix PHP warning with date function in FormEngine 61/33661/2
Wouter Wolters [Fri, 24 Oct 2014 09:49:50 +0000 (11:49 +0200)]
[BUGFIX] Fix PHP warning with date function in FormEngine

The timestamp handed to the date function must be of type int
otherwise a warning is issued. Cast the value to int before
passing it to the date function. The important scenarios are
when the timestamp is "0" or "" (blank string).

Add unit test for formatValue function and the possible format
configurations.

Resolves: #62032
Releases: master, 6.2, 6.1, 4.5
Change-Id: I5207ef5b562dd70b9b5e574eef1b9ee59fa836f0
Reviewed-on: http://review.typo3.org/33661
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Fix column layout for New Content Element wizard 44/33644/2
Martin Kästner [Wed, 28 Nov 2012 13:13:25 +0000 (14:13 +0100)]
[BUGFIX] Fix column layout for New Content Element wizard

If adding new content elements in Web>List with the CE wizard,
you get the old column layout & titles even if you have a complete
backend_layout working.

But for Moving Elements the Backend Layout is already correct.
Column titles are already in $tcaItems a few lines before
the lines in the patch for File PagePositionMap.php. Using this
values the backend_layout is correct in Web>List CE Wizard.

Resolves: #42457
Releases: master, 6.2
Change-Id: I5f57aeac493ec5db02aaa92bd9eab97390cdb967
Reviewed-on: http://review.typo3.org/33644
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Add proper URL check to TemplateService::getFileName() 49/33649/2
Markus Klein [Thu, 30 Oct 2014 22:30:37 +0000 (23:30 +0100)]
[BUGFIX] Add proper URL check to TemplateService::getFileName()

This fixes the broken test introduced with #51781

Resolves: #62575
Releases: 6.2
Change-Id: I92541fbf2744399a1385ccc1bbbff2b2bd6709b2
Reviewed-on: http://review.typo3.org/33649
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
5 years ago[BUGFIX] IMAGE content object accepts directories 43/33643/2
Tomita Militaru [Mon, 11 Nov 2013 20:25:29 +0000 (22:25 +0200)]
[BUGFIX] IMAGE content object accepts directories

Adds checks for file existence to avoid returning directory
paths instead of path to file.

Resolves: #51781
Releases: master, 6.2
Change-Id: I8f879f38b95e6d9562a8883d35664550d8fa8774
Reviewed-on: http://review.typo3.org/33643
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Add check if $fileObject is a correct instance 12/33612/2
Frank Nägler [Wed, 10 Sep 2014 19:55:21 +0000 (21:55 +0200)]
[BUGFIX] Add check if $fileObject is a correct instance

In some cases the $fileObject is null and getName() is called on
a null object which results in a fatal error.

This patch add a check if $fileObject is an instance of
FileInterface before call getName().
Also correct the wrong doc comment.

Resolves: #60773
Releases: 6.2, master
Change-Id: I6f3f817a089c665d8cc9e0b3369d6d690ffaf620
Reviewed-on: http://review.typo3.org/33612
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix active page calculation in indexed_search 06/33606/2
Georg Ringer [Wed, 29 Oct 2014 12:21:56 +0000 (13:21 +0100)]
[BUGFIX] Fix active page calculation in indexed_search

Because of introducing a strict comparion in #60346, the active page is
not highlighted anymore as a float and an int value are compared.

Change-Id: Id66c77e64fb4824f5b254240b1774f77adfa6ab9
Resolves: #62532
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33606
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[BUGFIX] Remove wrong escaping of email sender 03/33603/2
Markus Klein [Thu, 23 Oct 2014 23:48:01 +0000 (01:48 +0200)]
[BUGFIX] Remove wrong escaping of email sender

Remove a wrong escaping method from sysext form which causes email
problems.

Resolves: #60437
Releases: master, 6.2
Change-Id: I3a5447b55f4f0723637c04929de0412a4a3b67a7
Reviewed-on: http://review.typo3.org/33603
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Let save and preview button behave as user initiated 90/33590/2
Helmut Hummel [Mon, 27 Oct 2014 17:53:17 +0000 (18:53 +0100)]
[BUGFIX] Let save and preview button behave as user initiated

Browsers started to distinguish how opening a new window
from JavaScript happens. They track "user initiated"
opening and not user initiated opening and behave differently.

A request to open a window by JavaScript which is not
user initiated is caught by a pop up blocker most of the time nowadays.
This means a user must explicitly allow the current page to
open new windows by JavaScript.

Additionally some browsers (e.g. Chrome) always open a new window
instead of a new tab if the request is not user initiated, regardless
of browser settings, which nowadays default to open a new tab.

The "save and preview" button currently initiates a page reload
which saves the document and add some JavaScript to to open a preview
window in the HTML response of this action.
This JavaScript action is then not considered to be user initiated any more
as opening the new window does not follow a direct user click action.

The result is, that if a preview window/tab was opened previously, then
the preview/window tab is just reloaded with the new preview URL.
If it is the first time the window/tab should be opened this request
is caught by the popup blocker.

Other preview buttons in the backend (from Click Menu or action toolbar)
behave differently (correctly) as they are always identified as user initiated.

For that reasons, change the "save and preview" button to directly
open a new window on click (without URL) and let the HTML/ JavaScript response
set the correct preview URL after that.

By doing so we gain a consistent behavior no matter what preview button a user
clicks first.
The only downside is, that in case the preview window is opened
the first time, it remains empty until the page is saved and then reloaded
through the JavaScript code that is already present.

Resolves: #62503
Releases: 6.2, master
Change-Id: I7a96c347453b1ccdeaf0d8d1bd5b080f905563ca
Reviewed-on: http://review.typo3.org/33590
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix suggest wizard for new CE in flexforms 70/33570/2
Markus Klein [Fri, 24 Oct 2014 14:34:59 +0000 (16:34 +0200)]
[BUGFIX] Fix suggest wizard for new CE in flexforms

When having a suggest wizard inside a flexform on a
new content element edit form, we have the problem that
we can't load the wizard's config in the AJAX request due
to missing record information. We don't know what flexform
definition to load, as we don't know what ctype is requested.

Two possible solutions exist:
 - Generate the blank record again in the AJAX request, which
   means we have to copy lots of code from the DataPreProcessor.
   Moreover we would still need to pass the defVal GET parameter
   of the EditDocumentController to the AJAX request handler
   somehow, since we need that information in the DataPreProcessor
   to generate the correct dummy record.
 - Push the record to the AJAX request as serialized array

I chose the second implementation.

Change-Id: If7f8abe66554a3164bbfe98ad396fdf8448f5569
Resolves: #50549
Releases: master, 6.2, 6.1
Reviewed-on: http://review.typo3.org/33570
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[BUGFIX] Declare statically called method static 84/33584/2
Helmut Hummel [Mon, 27 Oct 2014 19:16:32 +0000 (20:16 +0100)]
[BUGFIX] Declare statically called method static

InlineElement::updateInlineView() is only used once throughout the core
and called statically, although the method is not declared to be static.

Fix this by declaring it static.

Resolves: #62501
Releases: 6.2, master
Change-Id: Ifeb8551899ccf285d87a66767bf7de4e8e98b32f
Reviewed-on: http://review.typo3.org/33582
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
(cherry picked from commit fc9666b257896a9fc59aab61b2c2ac8a196ef151)
Reviewed-on: http://review.typo3.org/33584

5 years ago[BUGFIX] Only reload pagetree if pages are changed 81/33581/2
Helmut Hummel [Mon, 27 Oct 2014 16:04:46 +0000 (17:04 +0100)]
[BUGFIX] Only reload pagetree if pages are changed

When using the click menu to hide, unhide or delete
a record, previously the page tree was refreshed,
although those changes are only reflected in the
pagetree if page properties are changed.

Adapt the click menu to only refresh the tree
if a page record is changed or deleted.

Resolves: #40687
Releases: 6.2, master
Change-Id: I32844b359abd790f1dbd6839eec6feeb6e62bd02
Reviewed-on: http://review.typo3.org/33573
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
(cherry picked from commit 4fac3bf53705bbf01b3775ad28aed4ef20ee7a97)
Reviewed-on: http://review.typo3.org/33581

5 years ago[BUGFIX] RTE: Documentation of enableWordClean is wrong 71/33571/2
Stanislas Rolland [Sun, 26 Oct 2014 23:15:02 +0000 (19:15 -0400)]
[BUGFIX] RTE: Documentation of enableWordClean is wrong

The HTMLparser properties must be defined under subproperty HTMLparser
of enableWordClean and not directly under property enableWordClean.

Releases: master, 6.2
Resolves: #58105
Change-Id: I0b21e5789aa4db867e0057e484d17f40a26b5c56
Reviewed-on: http://review.typo3.org/33565
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit 14cea0f39df2902662b6664a03abc208969033ff)
Reviewed-on: http://review.typo3.org/33571

5 years ago[TASK] Replace old fe_users icon with new one 56/33556/2
Felix Kopp [Sun, 26 Oct 2014 10:20:00 +0000 (11:20 +0100)]
[TASK] Replace old fe_users icon with new one

Change path of fe_users icon in TCA to same as in page tree.
See Edit page > Behaviour > Contains plugin

Resolves: #27955
Releases: master, 6.2
Change-Id: Ib2c91ad279249c9ab6a71d23f7c9afca140cc2ec
Reviewed-on: http://review.typo3.org/33556
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Link to ext:perm in clickmenu not working 51/33551/2
Wouter Wolters [Fri, 24 Oct 2014 17:59:24 +0000 (19:59 +0200)]
[BUGFIX] Link to ext:perm in clickmenu not working

The link refers directly to index.php instead of mod.php.
Use BackendUtility::getModuleUrl() for the link to fix the problem.

Change-Id: I7cdda9f592e331c95bbb3c5d301907bd77761ec5
Resolves: #62459
Related: #38099
Releases: master, 6.2, 6.1
Reviewed-on: http://review.typo3.org/33551
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix JS error in SuggestWizard 18/33518/2
Markus Klein [Fri, 24 Oct 2014 02:13:42 +0000 (04:13 +0200)]
[BUGFIX] Fix JS error in SuggestWizard

This is regression fix for #59701.

The ID of new Content Elements now contain a dot character.
Fix the generated JS code of the SuggestWizard to filter this dot.

Resolves: #62438
Releases: master, 6.2
Change-Id: Ifd6937a7645c1bfd509fa1b5912d02f2d01c5e0d
Reviewed-on: http://review.typo3.org/33503
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Tested-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit 85bfe3911eb30a770a138caad5161b7fc9d40b66)
Reviewed-on: http://review.typo3.org/33518

5 years ago[FEATURE] Add multiple parameter in f:form.checkbox 14/33514/2
Stefan Froemken [Fri, 10 Oct 2014 23:12:19 +0000 (01:12 +0200)]
[FEATURE] Add multiple parameter in f:form.checkbox

This patch introduce the multiple parameter
for f:form.checkbox ViewHelper of fluid.

Resolves: #61529
Releases: master,6.2
Change-Id: Ic02b9aaeb19f09be438c18212c5b2f5842bf7468
Reviewed-on: http://review.typo3.org/33257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
(cherry picked from commit ad2cfb7d909b7b7d0d84de3630047c2f6d7833e0)
Reviewed-on: http://review.typo3.org/33514
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] RTE: In Chrome RTE inserts weird span tags 92/33392/2
Stanislas Rolland [Sun, 19 Oct 2014 18:03:20 +0000 (14:03 -0400)]
[BUGFIX] RTE: In Chrome RTE inserts weird span tags

Remove the span tags inserted by Chrome or Opera on execution of
native execCommand. The attributes of these span tags have evolved...

Releases: master, 6.2
Resolves: #52470
Change-Id: Ibb046b86e869bd7d4afc61ab5005595467b288cd
Reviewed-on: http://review.typo3.org/33392
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE: Multilingual classesAnchor titleText not possible 06/33506/2
Stanislas Rolland [Thu, 23 Oct 2014 16:20:58 +0000 (12:20 -0400)]
[BUGFIX] RTE: Multilingual classesAnchor titleText not possible

Content language is not correctly set by RTE controller.

Releases: master, 6.2
Resolves: #62399
Change-Id: I85eb570dc266bdc71e4768a13d27c6f2937f7251
Reviewed-on: http://review.typo3.org/33488
Reviewed-by: Jan Kiesewetter <jan@t3easy.de>
Tested-by: Jan Kiesewetter <jan@t3easy.de>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit 07fb3d8afea5bd3ff35e34e7eac97d59502d9b8a)
Reviewed-on: http://review.typo3.org/33506

5 years ago[BUGFIX] Misaligned radio buttons 96/33096/2
Francois Suter [Wed, 1 Oct 2014 14:14:20 +0000 (16:14 +0200)]
[BUGFIX] Misaligned radio buttons

In the TYPO3 CMS BE, radio buttons are not well aligned
with their labels. Fix it with a top margin definition.

See bug tracker for screenshots.

Resolves: #61992
Releases: 6.2
Change-Id: Iab285ead7c3fee7cdf6c1f00366c883f06c5f3dd
Reviewed-on: http://review.typo3.org/33096
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Missing and invalid warnings on referenced files 95/33495/2
Oliver Hader [Mon, 19 May 2014 10:02:36 +0000 (12:02 +0200)]
[BUGFIX] Missing and invalid warnings on referenced files

The file list module in the backend offers the possibility to
delete files. An interesting use case is the deletion of files
that still have references to other entities. However, currently
proper warnings are only available for sys_file reference.

a) before deleting a file, a popup should be shown
   this does not work since the API is called with
   the identifier instead of a proper UID value

b) after calling the API for deleting a file, references
   should be pointed out
   references are checked, however the description on the
   file usage is missing due to hardcoded "sys_file_reference"
   triggers - thus, no other references are printed out

Resolves: #58913
Releases: master, 6.2, 6.1
Change-Id: Id80361427abc17bda3461c2d00750c4790798c88
Reviewed-on: http://review.typo3.org/33495
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Respect different object mapping for scheduler tasks 93/33493/2
Mathias Brodala [Mon, 14 Jul 2014 07:26:18 +0000 (09:26 +0200)]
[BUGFIX] Respect different object mapping for scheduler tasks

Resolves: #60296
Releases: master, 6.2, 6.1
Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538
Reviewed-on: http://review.typo3.org/33493
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs 91/33491/2
Markus Klein [Wed, 27 Aug 2014 22:30:10 +0000 (00:30 +0200)]
[BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs

Ensure the ErrorHandler stops script execution if an error occurs.

Resolves: #61213
Releases: master, 6.2, 6.1
Change-Id: I0324a571b494576db1d314d8af0a86273e3205d3
Reviewed-on: http://review.typo3.org/33491
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] ClassLoader also needs to check for interfaces 89/33489/2
Markus Klein [Tue, 14 Oct 2014 14:13:20 +0000 (16:13 +0200)]
[BUGFIX] ClassLoader also needs to check for interfaces

An interface might already be defined, check for existence before trying
to require it, which will cause PHP errors if the interface comes from a
different file path.

Resolves: #62212
Releases: master, 6.2
Change-Id: I9cf43402bbcbbb5e27dbebb4ea48a2e1b483f360
Reviewed-on: http://review.typo3.org/33489
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Make ContentSlide work correctly if last element is empty 82/33482/3
Robert Vock [Tue, 23 Sep 2014 07:28:18 +0000 (09:28 +0200)]
[BUGFIX] Make ContentSlide work correctly if last element is empty

When using ContentSlide and the last content element in a column returns
an empty string, the slide continues up in the page list, even when
there are other content elements in the column.
Fix this by checking the correct value.

Change-Id: I6543cf2335197ae8510aa8d805d4d60a8d8a2320
Resolves: #51936
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33482
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Set TYPO3 version to 6.2.7-dev 68/33468/2
TYPO3 Release Team [Wed, 22 Oct 2014 09:10:24 +0000 (11:10 +0200)]
[TASK] Set TYPO3 version to 6.2.7-dev

Change-Id: If7d07a856f639be00c5e15f5fbdee3096fc178dc
Reviewed-on: http://review.typo3.org/33468
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
5 years ago[RELEASE] Release of TYPO3 6.2.6 67/33467/2 6.2.6 TYPO3_6-2-6
TYPO3 Release Team [Wed, 22 Oct 2014 09:09:54 +0000 (11:09 +0200)]
[RELEASE] Release of TYPO3 6.2.6

Change-Id: I39f6cbca69717cc894fbd9145fb1456c8ed79ef4
Reviewed-on: http://review.typo3.org/33467
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
5 years ago[SECURITY] Fix DoS in openid 59/33459/2
Markus Klein [Wed, 22 Oct 2014 08:14:28 +0000 (10:14 +0200)]
[SECURITY] Fix DoS in openid

Upgrade openid to latest upstream version.
This includes the sec fix already.

Change-Id: I2e31f9d15863a13ab34e4c4472e412b62bf12915
Resolves: #62357
Releases: master, 6.2, 6.1, 6.0, 4.7, 4.6, 4.5
Security-Commit: 571fe46d8000868263221a522bcec73f2bbde79e
Security-Bulletin: TYPO3-CORE-SA-2014-002
Reviewed-on: http://review.typo3.org/33459
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[SECURITY] Fix RCE in swiftmailer 58/33458/2
Helmut Hummel [Wed, 22 Oct 2014 08:14:25 +0000 (10:14 +0200)]
[SECURITY] Fix RCE in swiftmailer

A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.

This is not a full upgrade of the library but a backport
of the security fix.

Change-Id: I498163c13b09cb81c70ab7b4fa576b7a3110cbea
Resolves: #59573
Releases: 4.5, 4.6, 4.7, 6.0, 6.1, 6.2
Security-Commit: e8e192dcb778ca69746e7bd79e66aef14a12a2e2
Security-Bulletin: TYPO3-CORE-SA-2014-002
Reviewed-on: http://review.typo3.org/33458
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox 76/33376/2
Stanislas Rolland [Fri, 17 Oct 2014 23:05:32 +0000 (19:05 -0400)]
[BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox

Problem: If a style sheet from another domain is imported by the style
sheet configured for the RTE, a security error is raised by Firefox
when opening the Insert tag dialogue window.
Solution: Catch the error and report it on the console.

Releases: master, 6.2
Resolves: #62316
Change-Id: I093416abbc784f7548cda3b6c9be1d4b7d484040
Reviewed-on: http://review.typo3.org/33375
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit f398739141d2fba74a34a9d3a7a810d1d5c1fb53)
Reviewed-on: http://review.typo3.org/33376

5 years ago[BUGFIX] RTE: Edit element dialogue may raise JavaScript error 74/33374/2
Stanislas Rolland [Fri, 17 Oct 2014 18:44:33 +0000 (14:44 -0400)]
[BUGFIX] RTE: Edit element dialogue may raise JavaScript error

When clicking ok, some tabs may have not been rendered. Check for
presence of elements and values.

Releases: master, 6.2
Resolves: #62314
Change-Id: I928ac7ce8bebe2539f49e2153b4f7f8f2f7c889b
Reviewed-on: http://review.typo3.org/33373
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit bb0cfc607a7a3235f783e46606d1c6e5a32f6f2e)
Reviewed-on: http://review.typo3.org/33374

5 years ago[BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox 68/33368/2
Stanislas Rolland [Fri, 17 Oct 2014 15:55:25 +0000 (11:55 -0400)]
[BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox

Support for allowClipboard policy has been dropped by Firefox 29.
Therefore, remove cut, copy and paste buttons from the RTE toolbar
in Firefox. Remove also dialogue for installing AllowClipboard Helper
Firefox Addon.

Releases: master, 6.2
Resolves: #62296
Change-Id: I772b07cdca148c60ef8f61097f96fe5872fc0309
Reviewed-on: http://review.typo3.org/33367
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit c0d6353654071bdcc614e138da4b7dac7e53876f)
Reviewed-on: http://review.typo3.org/33368

5 years ago[BUGFIX] Handle utf8 strings in TitleCaseFilter 40/33340/2
Graeme Worthy [Thu, 16 Oct 2014 10:50:44 +0000 (12:50 +0200)]
[BUGFIX] Handle utf8 strings in TitleCaseFilter

Use proper charset aware string conversion API to handle
the value given to the TitleCaseFilter.

Resolves: #62279
Releases: master, 6.2
Change-Id: I500af9f1fb6769ea35197e19b2a0a7876d7eb736
Reviewed-on: http://review.typo3.org/33340
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
5 years ago[BUGFIX] Fix unit tests for TypeConverter classes 31/33331/2
Markus Klein [Thu, 16 Oct 2014 08:21:45 +0000 (10:21 +0200)]
[BUGFIX] Fix unit tests for TypeConverter classes

The patch Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a didn't adjust the
unit tests. This fix adds the missing mocks.

Resolves: #49803
Releases: master, 6.2
Change-Id: I829e62eaf3b172edeb295da57093b424edb13d40
Reviewed-on: http://review.typo3.org/33331
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Property of alternative model implementation not found 27/33327/2
Oliver Hader [Thu, 31 Jul 2014 13:17:38 +0000 (15:17 +0200)]
[BUGFIX] Property of alternative model implementation not found

The PersistentObjectConverter is mapping submitted data to a
given target domain model. If a class gets overloaded with
config.tx_extbase.objects, this information is not forwarded
to the ReflectionService. That's why properties in alternative
implementations cannot be determined.

Resolves: #49803
Releases: master, 6.2, 6.1
Change-Id: Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a
Reviewed-on: http://review.typo3.org/33327
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Show correct number of inline records defined in flexform 85/32985/4
Daniel Alder [Fri, 26 Sep 2014 07:42:36 +0000 (09:42 +0200)]
[BUGFIX] Show correct number of inline records defined in flexform

getRelatedRecordsArray() is expecting comma separated list of record ids
Before this patch the full flexform xml was passed.
Now we detect whether a field is a flexform and try to extract the
correct field values from it.

Resolves: #56882
Releases: master, 6.2
Change-Id: I50db5dfd5f07bbc20e369c0a07f2f294afb85321
Reviewed-on: http://review.typo3.org/32985
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Allow lower case for drive letters on Windows in CLI scripts 20/33320/2
Alexander Bohndorf [Mon, 22 Sep 2014 07:46:35 +0000 (09:46 +0200)]
[BUGFIX] Allow lower case for drive letters on Windows in CLI scripts

Resolves: #61749
Releases: master, 6.2, 6.1
Change-Id: I88a3489311e8f94669876ddbe59589f68cd5708e
Reviewed-on: http://review.typo3.org/33320
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Add trim to modificators in TS-Parser 03/33303/2
Stefan Froemken [Mon, 13 Oct 2014 09:17:22 +0000 (11:17 +0200)]
[BUGFIX] Add trim to modificators in TS-Parser

It is documented that modificators are trimmed in
TypoScriptParser. But since #54856 they aren't trimmed anymore.
That's why f.e. "addToList (value)" will not be executed.

Resolves: #62188
Related: #54856
Releases: master,6.2
Change-Id: I3828b22a836656ec808ac5d770d58803b9195102
Reviewed-on: http://review.typo3.org/33303
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Sort BE usergroup records in module "Backend Users" 00/33300/2
Georg Ringer [Mon, 13 Oct 2014 19:52:14 +0000 (21:52 +0200)]
[TASK] Sort BE usergroup records in module "Backend Users"

Add a default ordering for the backend usergroup records
which makes it easier to find a specific group.

Change-Id: I99f490193ca8b070c0d71a3a422bbc4ca4a3f3c6
Resolves: #61686
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix missing new record button with enabled useCombination 89/33289/2
Marc Bastian Heinrichs [Thu, 17 Jul 2014 10:27:39 +0000 (12:27 +0200)]
[BUGFIX] Fix missing new record button with enabled useCombination

Also add it if a record selector is shown.

Resolves: #60370
Related: #57488
Releases: master, 6.2
Change-Id: If4f34521310dc3f479d6c97cada082db91f668c3
Reviewed-on: http://review.typo3.org/33289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Show empty icon in checkbox'ed select field 66/33266/2
Axel Kummer [Thu, 9 Oct 2014 07:11:14 +0000 (09:11 +0200)]
[BUGFIX] Show empty icon in checkbox'ed select field

When a select field has config option renderMode=checkbox, icons
are rendered between checkbox and the label. If no icon is defined,
TYPO3 ought to show an empty icon.
This is broken and a red question mark appears.
This patch fixes the problem so that the empty icon is rendered again.

Change-Id: I2c54695463d98bd7b8bfa66642bd861e7a2ca7a8
Resolves: #62116
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33266
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Wrong usage of count on SimpleXMLElement 65/33265/2
Stefan Froemken [Fri, 10 Oct 2014 12:00:04 +0000 (14:00 +0200)]
[BUGFIX] Wrong usage of count on SimpleXMLElement

SimpleXMLElement comes with its own count implementation,
so no need to call count() on that Element.
Further I have updated some type annotations.

Resolves: #62130
Releases master,6.2
Change-Id: I2d52d54172d2898a89f0649330dc37ebddfe40c7
Reviewed-on: http://review.typo3.org/33265
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Ensure argument is an array in ContentObjectRenderer 63/33263/2
kaystrobach [Fri, 10 Oct 2014 06:49:50 +0000 (08:49 +0200)]
[BUGFIX] Ensure argument is an array in ContentObjectRenderer

This patch ensures that at least an empty array is passed to the
array_replace_recursive function to avoid warnings during rendering.

Inspired by Markus Klein

Resolves: #62139
Releases: master, 6.2
Change-Id: I854b39d7ff54c213bda00dd9060c1e5ee89914eb
Reviewed-on: http://review.typo3.org/33263
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Static access to Enumeration constants 44/33244/2
Sascha Egerer [Mon, 25 Aug 2014 14:46:23 +0000 (16:46 +0200)]
[BUGFIX] Static access to Enumeration constants

To get all available constants for a TYPO3\CMS\Core\Type\Enumeration
an instance of the Enumeration is required. This is changed by
defining the `getConstants` method as static and using
`get_called_class()` instead of `get_class($this)`.

Resolves: #61090
Releases: master,6.2
Change-Id: I45e8241c6f41a23a1748e620c000b6dd59d6f389
Reviewed-on: http://review.typo3.org/33244
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] RTE Spellcheck: PHP warning in SpellCheckingController 40/33240/2
Stanislas Rolland [Fri, 10 Oct 2014 01:55:38 +0000 (21:55 -0400)]
[BUGFIX] RTE Spellcheck: PHP warning in SpellCheckingController

PHP warning in raised in
SpellCheckingController::fixPersonalDictionaryCharacterSet.
If the file does not exist, there is no need to fix anything.

Releases: master, 6.2
Resolves: #62137
Change-Id: I9b15f5cb016ac9d309fb19ad6230a79b885b16f3
Reviewed-on: http://review.typo3.org/33239
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit 767aa0f7b7025bf56ed5229d7acb0cae0c0f740f)
Reviewed-on: http://review.typo3.org/33240

5 years ago[BUGFIX] Possible race condition when creating directory 37/33237/2
Bernhard Kraft [Fri, 19 Sep 2014 08:58:36 +0000 (10:58 +0200)]
[BUGFIX] Possible race condition when creating directory

During various actions in the backend which require a cache directory
in typo3temp/ a race condition can occur while creating the directory.
The race condition is caused by GeneralUtility::createDirectoryPath.

There is a check whether the directory to be created already exists.
Later the directory is created using mkdir(). If in the meantime
another process creates the directory the exception will get thrown.

Resolves: #47269
Releases: master, 6.2
Change-Id: Iff46addd9ad6d738d1760f82a436dec9840c331d
Reviewed-on: http://review.typo3.org/33237
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] RTE Spellcheck:default ISO code dictionary should be lowercase 29/33229/2
Stanislas Rolland [Thu, 9 Oct 2014 14:25:48 +0000 (10:25 -0400)]
[BUGFIX] RTE Spellcheck:default ISO code dictionary should be lowercase

When no default dictionary is configured for the ISO code of the
language of current content, the ISO code itself is taken as the name
of the Aspell dictionary. This should be lowercase.

Releases: master, 6.2
Resolves: #62128
Change-Id: I346469b0c1cd8a44227576b0d17cf231c205f961
Reviewed-on: http://review.typo3.org/33228
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit f6d66f21fccee997e0d5f78d42703d23177c4c88)
Reviewed-on: http://review.typo3.org/33229

5 years ago[BUGFIX] RTE Spellcheck dialogue not correctly displayed 19/33219/2
Stanislas Rolland [Thu, 9 Oct 2014 05:55:48 +0000 (01:55 -0400)]
[BUGFIX] RTE Spellcheck dialogue not correctly displayed

The RTE Spellcheck dialogue is not correctly displayed: the suggestions
and dictionaries fieldsets are never displayed in Firefox and Chrome
due to size constraints. In IE, the trigger elements of the combo boxes
are truncated on the right.

Releases: master, 6.2
Resolves: #62114
Change-Id: Iebff324164dc5975403e2217dd06def77e2eba6f
Reviewed-on: http://review.typo3.org/33218
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit 4e8ede79e40be001a5c6b333b078c73eea86c40d)
Reviewed-on: http://review.typo3.org/33219

5 years ago[BUGFIX] RTE Spellcheck dialogue opens with excessive height 17/33217/2
Stanislas Rolland [Thu, 9 Oct 2014 03:01:49 +0000 (23:01 -0400)]
[BUGFIX] RTE Spellcheck dialogue opens with excessive height

By default, the RTE Spellcheck dialogue opens with excessive height
in Firefox.

Releases: master, 6.2
Resolves: #62113
Change-Id: Ifd92417ddc7c688bb752c4460a4992daf7173651
Reviewed-on: http://review.typo3.org/33216
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit a920538e1ca90067b221d843d4d71c2c9a00238f)
Reviewed-on: http://review.typo3.org/33217

5 years ago[BUGFIX] RTE references non-existent xml files 15/33215/2
Stanislas Rolland [Wed, 8 Oct 2014 21:54:03 +0000 (17:54 -0400)]
[BUGFIX] RTE references non-existent xml files

References should be to xlf files.

Releases: master, 6.2
Resolves: #62112
Change-Id: I670e0f7f8af422d710c85c76f87b25527ceb1c38
Reviewed-on: http://review.typo3.org/33214
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit a56a1367e2758e9b85d1f59aae332bc85b462553)
Reviewed-on: http://review.typo3.org/33215

5 years ago[BUGFIX] Do not use invalid TSConfig in linkvalidator 13/33213/2
Alexander Stehlik [Thu, 19 Dec 2013 21:37:53 +0000 (22:37 +0100)]
[BUGFIX] Do not use invalid TSConfig in linkvalidator

To display the linkvalidator error messages for linkhandler link types,
the name of the linked table is read from the TCA instead from page
TSconfig (from a hardcoded page UID 1).

Resolves: #54523
Releases: master, 6.2
Change-Id: I165813a03cd4574c20981e35a9e53cfdeacfc421
Reviewed-on: http://review.typo3.org/33213
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix PHP warning with CTYPE=media 12/33212/2
Goran Medakovic [Tue, 7 Oct 2014 16:38:17 +0000 (18:38 +0200)]
[BUGFIX] Fix PHP warning with CTYPE=media

Check for array type before checking the variable with isset().
If the variable is a string the isset() will cause a PHP warning.

Resolves: #59544
Releases: master, 6.2
Change-Id: I766292a3dc0365a40acff5fd5f089f7ea78e0b70
Reviewed-on: http://review.typo3.org/33212
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] RTE Language extension refers to non-existent method 11/33211/2
Stanislas Rolland [Wed, 8 Oct 2014 20:14:11 +0000 (16:14 -0400)]
[BUGFIX] RTE Language extension refers to non-existent method

RTE Language extension refers to non-existent method
tx_staticinfotables_div::getCurrentLanguage in Static Info Tables.

Releases: master, 6.2
Resolves: #62111
Change-Id: I9a37a40da367f47da9ee3a015537e79d3ff5a88a
Reviewed-on: http://review.typo3.org/33210
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
(cherry picked from commit 5059981b809b9721fcf5c615ab0b3992a7894ee7)
Reviewed-on: http://review.typo3.org/33211

5 years ago[BUGFIX] Show correct tooltip for page type "Mount Point" 98/33198/2
Georg Ringer [Tue, 7 Oct 2014 04:31:43 +0000 (06:31 +0200)]
[BUGFIX] Show correct tooltip for page type "Mount Point"

The tooltip of pages of the type "Mount Point" lacks the information
about the linked page because the needed fields are not retrieved.

Additionally the shortcut tooltip gets improved for the page tree.

Change-Id: I9c7c65094d23bbc0b0eb6100b0d6a62641c00d22
Resolves: #61951
Related: #60033
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33198
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fluid tries to render folders as templates partials and layouts 95/33195/2
Krzysztof Adamczyk [Sat, 21 Sep 2013 13:42:31 +0000 (15:42 +0200)]
[BUGFIX] Fluid tries to render folders as templates partials and layouts

The file_exists checks in TemplateView and StandaloneView are true for
folders. This leads to unrendered partials with resorted paths.
Use is_file instead.

Releases: master, 6.2, 6.1
Resolves: #47188
Change-Id: I9c168f4793f173f6c2f848e6e3da1f6021ae9c06
Reviewed-on: http://review.typo3.org/33195
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Remove empty values in pageOverlayFields 92/33192/2
Nils Blattner [Tue, 7 Oct 2014 08:47:58 +0000 (10:47 +0200)]
[BUGFIX] Remove empty values in pageOverlayFields

$GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields'] might contain
empty values. Remove those.

Resolves: #62068
Releases: master, 6.2
Change-Id: I79337d9d8dca17fc840a331c8839147054d1b3f0
Reviewed-on: http://review.typo3.org/33192
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Readd frame setting to image configuration 88/33188/2
Manfred Rutschmann [Tue, 7 Oct 2014 03:36:13 +0000 (05:36 +0200)]
[BUGFIX] Readd frame setting to image configuration

The setting "frame" is missing in the processing information in
image handling.

Change-Id: I24410d28daa8017995cc9b352c328dff3f329748
Resolves: #62053
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33188
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] BE login template: fix invalid HTML structure 80/33080/2
Eric Chavaillaz [Tue, 30 Sep 2014 12:53:59 +0000 (14:53 +0200)]
[BUGFIX] BE login template: fix invalid HTML structure

In the backend login template a div tag is nested within a dl tag.
This is prohibited by the HTML specification.
This patch reverses the tag ordering.

Resolves: #61962
Releases: master, 6.2
Change-Id: I4e6410111a2ede2f9294cf390d7e96eedbeb58f6
Reviewed-on: http://review.typo3.org/33080
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Search word markup for UTF8 characters in summary 94/33094/2
Ralf Hettinger [Sun, 28 Apr 2013 18:20:42 +0000 (20:20 +0200)]
[BUGFIX] Search word markup for UTF8 characters in summary

Fix usage of preg_split to use the modifier /u so that search words
are correctly split in a summary.

Resolves: #26172
Releases: master, 6.2, 6.1
Change-Id: I90d8676f5724f194434811378eb8598eaf04cb9e
Reviewed-on: http://review.typo3.org/33094
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Fix functional tests for EXT:impexp 65/33065/4
Oliver Hader [Tue, 30 Sep 2014 08:50:24 +0000 (10:50 +0200)]
[TASK] Fix functional tests for EXT:impexp

After issue #61944 has been merged, sys_file_reference.link does
not support NULL values anymore (which is fine). However, in the
past the default has been NULL and also has been written in the
accordant functional test data assertions.

Thus, NULL assertions are removed from the test. The change of
the "size" property by 5 bytes can be explained by a difference
in serializing NULL values and serializing an empty string.

Releases: master, 6.2
Related: #61944
Change-Id: Ia8700d6b6e374412e3300f12f4d6bb341deb4cfe
Reviewed-on: http://review.typo3.org/33065
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE 67/33067/2
Michael Schams [Mon, 29 Sep 2014 09:54:35 +0000 (19:54 +1000)]
[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE

This patch fixes invalid JavaScript code (adds a missing closing
bracket), that prevents BE users from creating links to anchor tags
in the RTE.

This is a regression fix to #41413.

Resolves: #61943
Releases: master, 6.2
Change-Id: I8e085e01885333d612cf6776495be259b00a093a
Reviewed-on: http://review.typo3.org/33067
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years agoRevert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE" 60/33060/2
Markus Klein [Tue, 30 Sep 2014 09:28:17 +0000 (11:28 +0200)]
Revert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE"

This reverts commit eda10cc0f2f2ddb7fa645c2f7ef6b71ea9f22b94.

The commit message of the original patch references a wrong issue number and the target versions seem to be wrong too.

Change-Id: I37866f1a70f354fae36a4efe3c7dab0c77f84bc8
Resolves: #61968
Reverts: #61943
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33060
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE 55/33055/2
Michael Schams [Mon, 29 Sep 2014 09:54:35 +0000 (19:54 +1000)]
[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE

This patch fixes invalid JavaScript code (adds a missing closing
bracket), that prevents BE users from creating links to anchor tags
in the RTE.

This is a regression fix to #60919.

Resolves: #61943
Releases: master, 6.2, 6.1, 4.7, 4.5
Change-Id: I90ecba126191322048a2c4aca7835d3795764324
Reviewed-on: http://review.typo3.org/33055
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[DB] Increase max length of link fields 52/33052/2
Lars Malach [Mon, 29 Sep 2014 10:21:48 +0000 (12:21 +0200)]
[DB] Increase max length of link fields

The current core supports links with the maximum length of 256 chars in
header links of tt_content elements and links in table
sys_file_reference.

External links can have much more than 256 chars.

Increasing the maximum length to 1024 should be enough - even current
browsers are supporting much more than 1024 chars.

Resolves: #61944
Releases: master, 6.2
Change-Id: I2031ebef959de696bc320b927ec1a462bcd5dd72
Reviewed-on: http://review.typo3.org/33052
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Change explanatory text of SYS error reporting config variables 25/33025/2
Daniel Minder [Mon, 29 Sep 2014 09:28:30 +0000 (11:28 +0200)]
[BUGFIX] Change explanatory text of SYS error reporting config variables

Unify explanatory text of the variables [SYS][errorHandlerErrors],
[SYS][exceptionalErrors], [SYS][syslogErrorReporting] and
[SYS][belogErrorReporting] so that formatting, link to PHP doc and
the numerical default values are similar.

Resolves: #61942
Releases: master, 6.2
Change-Id: Iacdbf18ad5c181c499c23c4c50cebffc6736236c
Reviewed-on: http://review.typo3.org/33025
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Felogin improperly merges flexforms and TS conf 13/33013/2
Markus Klein [Mon, 23 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] Felogin improperly merges flexforms and TS conf

There are two options to show the forgot password link in FE:
 * TypoScript: showForgotPasswordLink
 * Flexforms: showForgotPassword

The flexform values are merged with the TS values, but as these config
options are named differently, they are not overridden properly.

With #50138 the forgot-form is now only displayed when showForgotPassword
is set, hence the TypoScript configuration is not taken into account.

Since we can neither change the flexform, nor the TypoScript, we need to
merge the values in the flexform-merge code part.

This patch reduces the code to use only the documented TypoScript option.

Resolves: #59821
Releases: 6.3, 6.2
Change-Id: I77c391910561a304649d4c747ec868388be3f1a5
Reviewed-on: http://review.typo3.org/33013
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] DBAL admin_query() check array before accessing it 06/33006/2
Markus Klein [Sun, 28 Sep 2014 13:59:09 +0000 (15:59 +0200)]
[BUGFIX] DBAL admin_query() check array before accessing it

Move the $parsedQuery array access after the is_array() check in
DatabaseConnection::admin_query() to avoid PHP warnings.

Releases: master, 6.2
Resolves: #61929
Change-Id: I641d1e0d1dbe0001bd7082fbed1ce5ddb35172f8
Reviewed-on: http://review.typo3.org/33006
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1 93/32993/2
Ralf Hettinger [Tue, 30 Apr 2013 14:15:54 +0000 (16:15 +0200)]
[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1

There was a slight glitch in indexed_search's indexer, which resulted in
a wrong frequency mapping if the ratio between number of current word /
all words is exactly 1.
The "frequency" for this word is now mapped to the highest possible
value.

Resolves: #47745
Releases: master, 6.2
Change-Id: I1c9945b9550b80ad969f907f0bf1f14c3ae872f9
Reviewed-on: http://review.typo3.org/32993
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix indexed_search page browsing calculation 92/32992/2
Markus Klein [Tue, 15 Jul 2014 17:30:24 +0000 (19:30 +0200)]
[BUGFIX] Fix indexed_search page browsing calculation

Fix the calculation of pages shown by the indexed_search page browsers
to avoid negative page numbers or numbers exceeding the maximum available
page number.

Resolves: #60346
Releases: master, 6.2
Change-Id: I97de1c1afe42e29d450733f6741bca049f9803f6
Reviewed-on: http://review.typo3.org/32992
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Suhosin triggers warnings in Install Tool 42/32942/2
Wouter Wolters [Mon, 24 Feb 2014 22:27:18 +0000 (23:27 +0100)]
[BUGFIX] Suhosin triggers warnings in Install Tool

When Suhosin runs in simulation mode, violations are logged
as usual, but nothing is blocked or removed from the request.

Add an extra check to isSuhosinLoaded, to prevent unneeded
warnings.

Resolves: #55886
Releases: master, 6.2
Change-Id: Idd07872d31d51ed3266fcf330e825187656167a8
Reviewed-on: http://review.typo3.org/32942
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Do not check file extension on local file 30/32930/3
Alexander Opitz [Tue, 23 Sep 2014 09:14:15 +0000 (11:14 +0200)]
[BUGFIX] Do not check file extension on local file

If a file is uploaded and file extension deny pattern is set,
we should not test this temporary file for extension permissions.
Also on adding a file into a storage do not need to test the
extension of the local file, the extension of the target file is
enough.

Resolves: #58367
Releases: master, 6.2
Change-Id: I95b1685746150e2b03c56a5680785ae0b2388cd9
Reviewed-on: http://review.typo3.org/32930
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Kiessling <andreas.kiessling@web.de>
Tested-by: Andreas Kiessling <andreas.kiessling@web.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Set TYPO3 version to 6.2.6-dev 40/32940/2
TYPO3 Release Team [Tue, 23 Sep 2014 13:33:40 +0000 (15:33 +0200)]
[TASK] Set TYPO3 version to 6.2.6-dev

Change-Id: Ib005698d0b38bdac0d4a3d174a304058e4a55dbe
Reviewed-on: http://review.typo3.org/32940
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
5 years ago[RELEASE] Release of TYPO3 6.2.5 39/32939/2 6.2.5 TYPO3_6-2-5
TYPO3 Release Team [Tue, 23 Sep 2014 13:33:12 +0000 (15:33 +0200)]
[RELEASE] Release of TYPO3 6.2.5

Change-Id: I36118db416a33e85a4f2cc41c6a8e5e6acd9571f
Reviewed-on: http://review.typo3.org/32939
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>