Packages/TYPO3.CMS.git
6 years ago[BUGFIX] EM: configuration view CSS corrections 61/19661/2
Felix Kopp [Sat, 6 Apr 2013 10:50:57 +0000 (12:50 +0200)]
[BUGFIX] EM: configuration view CSS corrections

Corrects padding+margins for text, group, container in
configureExtension view.

Change-Id: If6ea1f596e13ae1179e01ad3798e900f64ce8dd2
Fixes: #46958
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19661
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] saltedpasswords not installed by default 59/19659/2
Nicole Cordes [Sat, 6 Apr 2013 09:07:54 +0000 (11:07 +0200)]
[BUGFIX] saltedpasswords not installed by default

Because of folder renaming the autoloader of saltedpasswords is not
executed anymore so rsa and saltedpasswords are not installed by default.

Change-Id: Ib4c950e77048f2fcbca20d0f7bf2a0b7f9f11a0e
Fixes: #43241
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19659
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix phpdoc after namespacing 58/19658/2
Philipp Gampe [Sat, 6 Apr 2013 09:35:34 +0000 (11:35 +0200)]
[BUGFIX] Fix phpdoc after namespacing

Fix three occurences of old class names in phpdoc.

Fixes: #46972
Releases: 6.0,6.1
Change-Id: Ia9b37cecf92dd21b8bea83ef351e1006c420b83f
Reviewed-on: https://review.typo3.org/19658
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EM: reduce prominence of state column 57/19657/2
Felix Kopp [Sat, 6 Apr 2013 08:55:56 +0000 (10:55 +0200)]
[BUGFIX] EM: reduce prominence of state column

Decrease the width of state column and invert the coloring.
The prominence of the state column is reduced to minimum.

Change-Id: I979b93b0bd1924fac856087a2b00e9ad30eb12ee
Fixes: #46967
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19657
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EM: easy access to showAllVersions 56/19656/2
Felix Kopp [Sat, 6 Apr 2013 09:17:04 +0000 (11:17 +0200)]
[TASK] EM: easy access to showAllVersions

The showAllVersions view is not easily accessible since only
tiny links point there. This patch adds further links.

Change-Id: I75b7a51a902a43d0ea584d037ee023a695c943ec
Fixes: #46971
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19656
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Throw Exception if typo3 extension repository is not defined" 54/19654/2
Christian Kuhn [Sat, 6 Apr 2013 10:07:38 +0000 (12:07 +0200)]
Revert "[BUGFIX] Throw Exception if typo3 extension repository is not defined"

This reverts commit c24f31bb6aa426ffaab6861bc44c0e3c440c8b19

Change-Id: Iab42d03d47ae0d8478414bec4d546a91f9d31ffc
Reviewed-on: https://review.typo3.org/19654
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Sorting of file links CE is broken 49/19649/2
Nicole Cordes [Sat, 6 Apr 2013 01:17:18 +0000 (03:17 +0200)]
[BUGFIX] Sorting of file links CE is broken

On editing a content element of CType "uploads" ("File Links") you can
define fields for sorting and target of the files. Those fields are not
evaluated during the frontend rendering process.

Change-Id: I3d59f3088e7600b5c4c57c5187f288b600adaf16
Fixes: #46444
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19649
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Automatic creation of processed files folder fails 38/19638/2
Andreas Wolf [Fri, 22 Mar 2013 21:54:24 +0000 (22:54 +0100)]
[BUGFIX] Automatic creation of processed files folder fails

The ResourceStorage tries to automatically create the processed files
folder if it does not exist. The identifier of the folder is taken from
the storage's configuration.

The automatic creation however fails, because when splitting the
identifier (e.g. /someFolder/_processed_/) by '/', the resulting array
always contains empty elements. Creating a folder with an empty name
fails however; therefore, empty elements should be skipped.

Change-Id: Ia9d0fe5314f67cb01da20682dfb684b711bc3cf7
Resolves: #46586
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19638
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Extension Manager does not use calcAge 34/19634/2
Benjamin Mack [Fri, 5 Apr 2013 21:22:21 +0000 (23:22 +0200)]
[BUGFIX] Extension Manager does not use calcAge

The extension manager does his own magic with calculating the age
of the last TER update. This can be done automatically with
BackendUtility::calcAge.

Resolves: #46962
Relates: #46524
Releases: 6.1, 6.0
Change-Id: I1917da7fa97e8692ee5bac799377e2a62ad14864
Reviewed-on: https://review.typo3.org/19634
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][EM] Fix of last update time after update 33/19633/3
Jost Baron [Fri, 22 Mar 2013 21:23:20 +0000 (22:23 +0100)]
[BUGFIX][EM] Fix of last update time after update

The time of the last update in the extension manager was not displayed
correctly immediately after an update, an additional refresh was needed.

Fixes: #46573
Releases: 6.1, 6.0
Change-Id: I51b0c966ddb3dda522cc68573d440e24273e96bc
Reviewed-on: https://review.typo3.org/19633
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK][EM] More readable "time since last update"-strings 17/19617/2
Jost Baron [Wed, 20 Mar 2013 18:00:53 +0000 (19:00 +0100)]
[TASK][EM] More readable "time since last update"-strings

The extensionmanager now shows the time elapsed since the last update,
not the time of the last update. The time of the last update is still
shown in a tooltip. Some english localizations have changed.

Resolves: #46524
Related: #39921
Releases: 6.1, 6.0
Change-Id: I2d5c6e8099e6973826debfcf2cbb597c35bb499c
Reviewed-on: https://review.typo3.org/19617
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] EM: Update button -> display version 31/19631/2
Thomas Löffler [Thu, 7 Feb 2013 19:23:10 +0000 (20:23 +0100)]
[BUGFIX] EM: Update button -> display version

Adds the target version of the extension which
needs an update into the title tag of the update
button.

Releases: 6.0, 6.1
Resolves: #45245
Change-Id: Icd5f98407300abf5759554002c1d42b9214a106c
Reviewed-on: https://review.typo3.org/19631
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Throw Exception if typo3 extension repository is not defined 29/19629/2
Sascha Egerer [Fri, 5 Apr 2013 20:20:17 +0000 (22:20 +0200)]
[BUGFIX] Throw Exception if typo3 extension repository is not defined

When there is no repository with id 1 is defined
in tx_extensionmanager_domain_model_extension you get an exception if
you try to update the extension list

Resolves: #42849
Releases: 6.1, 6.0
Change-Id: Ia60aa2227ab3a801c9002d821295c6eb01043e3f
Reviewed-on: https://review.typo3.org/19629
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EM: Colorpicker in extension configuration is broken 27/19627/2
Wouter Wolters [Fri, 5 Apr 2013 18:25:21 +0000 (20:25 +0200)]
[BUGFIX] EM: Colorpicker in extension configuration is broken

The colorpicker in extension configruation is broken. This is
because of missing images.

Also this fixes an issue with duplicate ID tags on a page. Which
causes some problem when CSS is defined on the same name.

Change-Id: I5c3b7005cd0f1df9399c0e1506bd8d408d661743
Fixes: #46021
Fixes: #46953
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19627
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EM: fix state columns' CSS 24/19624/3
Felix Kopp [Fri, 5 Apr 2013 19:31:45 +0000 (21:31 +0200)]
[BUGFIX] EM: fix state columns' CSS

Brings official typo3.org state colors. Also fixes several
errors for IE and hovering in general.

Change-Id: Ib24edbe60ac0fb4aad259be3e603d836bed27ab0
Fixes: #46955
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19624
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Read permission check for folders is broken 25/19625/2
Nicole Cordes [Sat, 23 Mar 2013 09:31:15 +0000 (10:31 +0100)]
[BUGFIX] Read permission check for folders is broken

The read permission check for folders is broken because there are some
inconsistencies in naming. For files the action to check is called "read",
for folders this check is called "browse". This should be adjusted for
folders to be equal to file check and renamed to "read".

Change-Id: I80862b60ea7d674df75dee0063764fed95570c6b
Fixes: #46582
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19205
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Tom Ruether
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-on: https://review.typo3.org/19625

6 years ago[BUGFIX] RTE: Magic Images are put in root folder 23/19623/2
Benjamin Mack [Sat, 23 Mar 2013 15:28:59 +0000 (16:28 +0100)]
[BUGFIX] RTE: Magic Images are put in root folder

Due to some problems when find the magic folder, currently
all files from the RTE are put in the root directory of the TYPO3
installation.

However, RTE should use the default upload folder of the user
by default.

Resolves: #46605
Releases: 6.1, 6.0
Change-Id: I4f9f6606bccdeefde563d243a2ad1c9311c6ae81
Reviewed-on: https://review.typo3.org/19623
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Respect line breaks in stdWrap.cropHTML 99/19499/2
Alexander Stehlik [Tue, 12 Feb 2013 11:35:00 +0000 (12:35 +0100)]
[BUGFIX] Respect line breaks in stdWrap.cropHTML

By using the PCRE_DOTALL (/s) pattern modifier in the cropHTML
regular expression for preserving HTML entities the dot in the
pattern will include line breaks.

Resolves: #28741
Releases: 6.1, 6.0, 4.5
Change-Id: I8ce6b3e3472fc6d117474f8b8c3dfda6b26ab0a1
Reviewed-on: https://review.typo3.org/19499
Reviewed-by: Mario Rimann
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[FEATURE] Add delete button in file list 40/19240/2
Benjamin Mack [Thu, 21 Mar 2013 21:13:56 +0000 (22:13 +0100)]
[FEATURE] Add delete button in file list

Currently it is not possible to delete a file or folder
in the file list. Additionally, there is translation and
error handling missing. The patch adds the trash
icon to the file list (if the user has the right) and
adds error and success messages.

Releases: 6.1, 6.0
Resolves: #44288
Change-Id: I3a68da487afc4b4718500c198963f05057dc6435
Reviewed-on: https://review.typo3.org/19240
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] respect rootLevel=-1 in exec_foreign_table_where_query 76/18976/2
Stefan Froemken [Thu, 21 Feb 2013 12:34:22 +0000 (13:34 +0100)]
[BUGFIX] respect rootLevel=-1 in exec_foreign_table_where_query

exec_foreign_table_where_query does not interpret the
rootLevel directive correctly.

Resolves: #45703
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I2a4dd0335ac5373562f287427d5592cfd406e2f9
Reviewed-on: https://review.typo3.org/18417
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/18976
Reviewed-by: Stefan Neufeind
6 years ago[TASK] EM: Remove contentWrap container 22/19622/2
Felix Kopp [Fri, 5 Apr 2013 17:56:15 +0000 (19:56 +0200)]
[TASK] EM: Remove contentWrap container

The content wrap container "contentWrap" is removed
as the last memory of tabbed content.

Change-Id: I3d7b54c92a74217917fade99d1edaa4bc640c337
Fixes: #46948
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19614
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-on: https://review.typo3.org/19622

6 years ago[TASK] EM: Add title to "Show all versions" icon 20/19620/2
Wouter Wolters [Fri, 5 Apr 2013 17:50:15 +0000 (19:50 +0200)]
[TASK] EM: Add title to "Show all versions" icon

* Add a title to the icon to show all extension versions
* Add the link for "Show all versions" to the extension title

Change-Id: Iea15bcaf8cda25662a76245e85ecd128cc3f8b6b
Resolves: #46951
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19613
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19620

6 years ago[BUGFIX] Error in filelist for Storage context menu 46/19246/2
Nicole Cordes [Fri, 22 Mar 2013 22:40:35 +0000 (23:40 +0100)]
[BUGFIX] Error in filelist for Storage context menu

The click menu for storage roots or mount points in filelist contains
functions which are not supported (e.g. cut/copy). This patch improves the
menu and only displays options which are allowed for storages/mount points
and for the current user.

Change-Id: I8e729eb3ea2d3977551ec689230ac9accfa76c4c
Resolves: #46575
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19246
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Add version title in showAllVersion view 11/19611/2
Anja Leichsenring [Fri, 5 Apr 2013 17:39:39 +0000 (19:39 +0200)]
[BUGFIX] Add version title in showAllVersion view

Fixes: #46949
Releases: 6.1, 6.0
Change-Id: I2634bc186baec2a0298596c6fb9982a8c32edd7c
Reviewed-on: https://review.typo3.org/19611
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EM: extension info within "Get Extensions" 09/19609/2
Felix Kopp [Fri, 5 Apr 2013 17:05:28 +0000 (19:05 +0200)]
[TASK] EM: extension info within "Get Extensions"

Improves the single view / showAllVersions with further details.
Brings detail view as a base for further improvements.

Change-Id: Ia774a064508d6e98438f6480d929e39cbe7e5534
Fixes: #39919
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19609
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Move EM extension configuration save button to DocHeader 06/19606/2
Anja Leichsenring [Fri, 5 Apr 2013 15:12:41 +0000 (17:12 +0200)]
[BUGFIX] Move EM extension configuration save button to DocHeader

The configuration action brings a Save button.
Save button should be in DocHeader.

Fixes: #46941
Releases: 6.0, 6.1
Change-Id: I05b1c2bf5f6406462ee0a1fcaaa2f5eefbee88f8
Reviewed-on: https://review.typo3.org/19606
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] EM: Add return link to showAllVersions 96/19596/2
Felix Kopp [Fri, 5 Apr 2013 14:39:09 +0000 (16:39 +0200)]
[BUGFIX] EM: Add return link to showAllVersions

Extension manager ShowAllVersions view does not deliver
link to return to the TER list. The return link is added.

Change-Id: Iaf266203222416d4c5656d5d52927c0b750b8860
Fixes: #46938
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19596
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EM: Modules deserve headlines 90/19590/2
Felix Kopp [Fri, 5 Apr 2013 14:00:36 +0000 (16:00 +0200)]
[TASK] EM: Modules deserve headlines

Users should know which context is active.
Display context as module headline.

Change-Id: I7e572c019f3d6a290ee699a695c98a5d4ccc6e4e
Fixes: #46934
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Move EM tabs to function menu 81/19581/2
Felix Kopp [Fri, 5 Apr 2013 08:44:11 +0000 (10:44 +0200)]
[BUGFIX] Move EM tabs to function menu

Changes the tabs in extension manager to a function menu.
The views to manage+get extensions are different from a
user perspective.

Change-Id: I2612667cdb2656fa8954b09ada858581318b3c1d
Fixes: #46931
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19581
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EM: Remove search form in showAllVersions 92/19592/2
Felix Kopp [Fri, 5 Apr 2013 14:51:03 +0000 (16:51 +0200)]
[TASK] EM: Remove search form in showAllVersions

The search form is necessary on TER list but displayed in
showAllVerions. The search form is removed with this patch.

Change-Id: Ic9a6fcd33418209ba0d5def357c5b722051b31c4
Fixes: #46942
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19592
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix breaking t3editor by using hsc() 82/19582/2
Georg Ringer [Tue, 2 Apr 2013 06:08:41 +0000 (08:08 +0200)]
[BUGFIX] Fix breaking t3editor by using hsc()

t3editor misses a htmlspecialchars() when displaying content of
the CE "HTML".

Change-Id: I84b65cd42bee971adc6fb77149f6789e76fc6567
Fixes: #33651
Releases: 6.1,6.0,4.7,4.6,4.5
Reviewed-on: https://review.typo3.org/19582
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Caching framework tables depends on ext_tables.sql 76/19576/2
Nicole Cordes [Sat, 23 Mar 2013 13:17:51 +0000 (14:17 +0100)]
[BUGFIX] Caching framework tables depends on ext_tables.sql

Since TYPO3 version 4.6 the caching framework should be responsible to
create needed tables for itself. But this is only executed when the
extension contains ext_tables.sql file in its extension folder. If you do
not need any other tables/fields no caching framework tables are created.
This should be independent from ext_tables.sql

Change-Id: Ifba3cb7bcc94d09627b38d5b5962cfdb2282306b
Fixes: #46591
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19576
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Extension manager styling 69/19569/2
Felix Kopp [Fri, 1 Mar 2013 00:09:05 +0000 (01:09 +0100)]
[BUGFIX] Extension manager styling

The extension manager never got all defined styles.
Bring several visual improvements:

— placeholder in search field
— show action icons on hover
— style extension state column
— float table header cols left and right

Change-Id: Id6eafa2b28b1d054929a84400bf1648b6e1e6d75
Fixes: #45928
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19569
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] List module shows thumbs on CEs of type text 73/19573/2
Mario Rimann [Wed, 20 Mar 2013 22:29:31 +0000 (23:29 +0100)]
[BUGFIX] List module shows thumbs on CEs of type text

The list module renders a thumbnail for content elements as soon
as they have an image attached - independent of the current type
of the content element.

This patch changes the behavior, so that the thumbnail for
records in the list view are only shown, if the thumbnail-
column is visible for the current type.

Change-Id: Id59d7816f91bd37f49f794827826fca1929f7d0a
Resolves: #26753
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19573
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Let Upgrade wizard recognize $GLOBALS['TYPO3_CONF_VARS'] 46/19546/2
Anja Leichsenring [Mon, 1 Apr 2013 11:15:33 +0000 (13:15 +0200)]
[BUGFIX] Let Upgrade wizard recognize $GLOBALS['TYPO3_CONF_VARS']

The LocalConfiguration wizard rewrites the existing localconf.php to the
new LocalConfiguration.php. To do so, the lines are read and analyzed to
retrieve the value and translate it to the new structure.

Until now, only lines containing the keyword $TYPO3_CONF_VARS are taken
into account. This patch extends the analysis to the keyword
$GLOBALS['TYPO3_CONF_VARS'].

Fixes: #39135
Releases: 6.0, 6.1
Change-Id: I880076d75a312926c8e968ad3ba883c41f364a62
Reviewed-on: https://review.typo3.org/19546
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 20/19520/2
TYPO3 Release Team [Tue, 2 Apr 2013 17:05:57 +0000 (19:05 +0200)]
[TASK] Raise submodule pointer

Change-Id: I2bd3f5433d072e581f1bb9404d8e5f7e92262648
Reviewed-on: https://review.typo3.org/19520
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Optimize clearing file backend caches 12/19512/2
Oliver Hader [Wed, 28 Nov 2012 10:49:36 +0000 (11:49 +0100)]
[TASK] Optimize clearing file backend caches

During concurrent requests it might happen that one request
flushes a cache that is stored in the filesystem and another
different request tries to recreate the data. This will lead
to race conditions if the cached contents are large.

The idea is to move the current cache to a temporary location
and then remove it.

Change-Id: I242fdbc6ab28008363747a8076d021ebce127e17
Resolves: #43382
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19512
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Remove explicit strict test from TypoScriptParserTest 03/19503/2
Oliver Hader [Mon, 1 Apr 2013 20:51:10 +0000 (22:51 +0200)]
[TASK] Remove explicit strict test from TypoScriptParserTest

The TypoScriptParser is executed in strict mode by default.

Change-Id: I95a206e184cbafaebe28f1db592bd0f6a6dda4db
Related: #46839
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19503
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[!!!][BUGFIX] Scope of ProcessedFile cannot be modified 02/19502/2
Oliver Hader [Sat, 30 Mar 2013 08:55:26 +0000 (09:55 +0100)]
[!!!][BUGFIX] Scope of ProcessedFile cannot be modified

A ProcessedFile is used to generate a preview or crop-scaled
version of a File. Actually a Task implementing the
TaskInterface defines the basics and an accordant Helper
object takes care of the modifications to that file.
There are pre-process and post-process signals that seem to
be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile
transformation) and that result shall be used for resizing.
The current task implementation is using the original file
directly, however the task actually shall define which is the
source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile()
method to overcome this limitation.

Change-Id: I280ea9a0bf056f9eee0a06995ab809fdafb8a11a
Fixes: #46795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19502
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Integrate basic TypoScript parsing test 92/19492/2
Oliver Hader [Mon, 1 Apr 2013 14:04:23 +0000 (16:04 +0200)]
[TASK] Integrate basic TypoScript parsing test

Resolves: #46839
Releases: 6.0, 6.1
Change-Id: I3dd007908bbd127386b86dd0f31e927c1034bb97
Reviewed-on: https://review.typo3.org/19492
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Adapt ArrayConstraints in IndexerTest 89/19489/2
Steffen Ritter [Mon, 1 Apr 2013 13:04:19 +0000 (15:04 +0200)]
[TASK] Adapt ArrayConstraints in IndexerTest

The tests for a parameter array check for equality of
the parameter array and the according value.
Instead we only wanna know if two keys are present and
set correctly and we do not care about other array values.

This refactors the Test to be more polite and is a follow-up
for #46596.

Change-Id: Ia7b4a0521b1d11b9494de2ff766f11b3c8bd1f60
Releases: 6.0, 6.1
Related: #46596
Reviewed-on: https://review.typo3.org/19487
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: https://review.typo3.org/19489

6 years ago[BUGFIX] PHP filesystem functions are locale dependent 77/18577/3
Steffen Ritter [Sun, 3 Mar 2013 18:46:38 +0000 (19:46 +0100)]
[BUGFIX] PHP filesystem functions are locale dependent

PHP filesystem functions like pathinfo, dirname and
basename are dependent on the locale set in PHP.
If one enables UTF8filesystem in the install tool, he may
use non-ascii characters in filenames and directory names.
For this to work properly you need to configure
SystemLocale, too.

The file abstraction layer classes need to take care of
the SystemLocale; to avoid code duplication new static
wrapper functions have been introduced.

Change-Id: I635e18d7ed08d928c6c4e427c0348dd46d9c5900
Releases: 6.0, 6.1
Resolves: #45982
Reviewed-on: https://review.typo3.org/18577
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Accept alternative notations for setDBinit 35/19035/4
Michael Stucki [Tue, 19 Mar 2013 10:37:06 +0000 (11:37 +0100)]
[BUGFIX] Accept alternative notations for setDBinit

Allow quotes and upper-case notation when checking if
$TYPO3_CONF_VARS['SYS']['setDBinit'] is configured properly.

Resolves: #24582
Releases: 6.1, 6.0
Change-Id: I51a5f6cf363077c738656c207648f21d726de72b
Reviewed-on: https://review.typo3.org/19035
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
6 years ago[BUGFIX] Javascript for TMENU_LAYERS and GMENU_LAYERS missing 62/19262/4
Michael Stucki [Mon, 25 Mar 2013 12:53:17 +0000 (13:53 +0100)]
[BUGFIX] Javascript for TMENU_LAYERS and GMENU_LAYERS missing

If using GMENU_LAYERS/TMENU_LAYERS and (for example) indexed_search on
the same page, the JavaScript header tags are missing if the page is
loaded from the cache.

Resolves: #36719
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Change-Id: Icd52f68d2b9462360f0b9efd912d93d4b0c1048c
Reviewed-on: https://review.typo3.org/19262
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Detect APC and APCu correctly 69/19469/2
Stefan Neufeind [Sun, 31 Mar 2013 17:54:41 +0000 (19:54 +0200)]
[TASK] Detect APC and APCu correctly

APCu is just the user-data part of APC,
providing the same API.

If installed it currently identifies itself
as both "apcu" and "apc" (for compatibility).
Thus if "apcu" shows up, we actually have an APC
without opcache-support.

Resolves: #46821
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: Id61bcf9277295915a6e204eabab7c65159e98764
Reviewed-on: https://review.typo3.org/19469
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Sending fails on multiple email-addresses 63/19463/2
Stefan Neufeind [Sun, 13 Jan 2013 13:57:44 +0000 (14:57 +0100)]
[BUGFIX] Sending fails on multiple email-addresses

Specifying multiple recipients (To or CC) for emails
leads to an error upon form-submit without further explanation.
This patch implements validation for multiple email addresses of
which only the valid ones are then returned.
The sending-API can already handle multiple recipients.

Change-Id: Ia0a947e1ee7b4d9b352a297840b68ff489f71375
Fixes: #44485
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19463
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Fix of Close-button in flash messages 64/19464/2
Jost Baron [Sun, 24 Mar 2013 22:12:13 +0000 (23:12 +0100)]
[BUGFIX] Fix of Close-button in flash messages

The close button did not work because hide() was called on
a HTMLElement instead of an Ext.Element.

Fixes: #46373
Related: #31368
Releases: 6.1, 6.0, 4.7
Change-Id: I70c65a82683ece39de4ed043a916b0521aabafa1
Reviewed-on: https://review.typo3.org/19464
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] WincacheBackend: Add a "Testing"-context to the tests 59/19459/3
Stefan Neufeind [Sun, 31 Mar 2013 13:20:47 +0000 (15:20 +0200)]
[TASK] WincacheBackend: Add a "Testing"-context to the tests

Resolves: #46817
Related: #46768
Releases: 6.0
Change-Id: I5ebc5f026d92ae8070c2dbfd4679e2889bad6c07
Reviewed-on: https://review.typo3.org/19459
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache] Wincache backend class constructor 39/19439/2
Christian Kuhn [Fri, 29 Mar 2013 14:42:31 +0000 (15:42 +0100)]
[BUGFIX][Cache] Wincache backend class constructor

The class constructor of wincache cache backend misses the first
parameter $context, so $options is treated as $context. Given
backend options are not used this way, for example defaultLifetime
has no effect.
The patch adds the missing constructor parameter to be in line
with the other cache backends.

Change-Id: I488b9996d5ab65420f79b2cab4c75805ae89a77a
Resolves: #46768
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19439
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][BUGFIX] Crop-Scaled images have wrong file content type 97/19397/2
Oliver Hader [Fri, 22 Mar 2013 09:35:53 +0000 (10:35 +0100)]
[!!!][BUGFIX] Crop-Scaled images have wrong file content type

The following scenario is given:
* resize a 300dpi TIFF image to PNG using stdWrap/cObj
* the 'fileExtension' configuration is not set
* the processed file csm_... has the file extension PNG
* but the file content type is still TIFF, so the file
  was just renamed, but not converted to PNG

Since the processing task determines the accordant filename
and file extension of the processed file, the image processor
(e.g. ImageMagick) needs to know about that fact as well.

This change modifies the TaskInterface which is rarely to not
at all used in custom extensions implementing individual tasks
to process files.

Change-Id: I089edc01a39663ac91b1b9df168f659c32954fcb
Fixes: #46530
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19169
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: https://review.typo3.org/19397

6 years ago[BUGFIX] Image rendering of non-existing files throws exception 93/19393/2
Oliver Hader [Fri, 22 Mar 2013 09:31:29 +0000 (10:31 +0100)]
[BUGFIX] Image rendering of non-existing files throws exception

Rendering an image that has no accordant file in a storage in
the frontend (e.g. in TypoScript) fails with an exception like
"Object with identifier xyz does not exist in storage".

A new ResourceDoesNotExistException is introduced to cover
files and folders and is thrown instead of RuntimeException.
This way, the exception is caught in the ContentObjectRenderer
and the frontend rendering just does not output the error,
which is logged instead.

Change-Id: I0affa15a8f0a50bf30a7176972994f209d18daf4
Fixes: #46535
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19393
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Wrong variable name used 88/19388/2
Georg Ringer [Wed, 27 Mar 2013 12:45:19 +0000 (13:45 +0100)]
[BUGFIX] Wrong variable name used

The parameter is called $lgd but is used as $length.

Change-Id: Id5303562d4e3f9bd9222db585da6a5365588a031
Fixes: #46718
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/19388
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Increase Web>List title column width 35/19335/2
Felix Kopp [Sun, 24 Feb 2013 22:04:37 +0000 (23:04 +0100)]
[TASK] Increase Web>List title column width

The column width for the title column in list view is hard-coded.

Increase the width for current screen sized.
Without this patch many titles are wrapped in new lines.

Change-Id: I09cf35cd954edc7909ec05f7bb6ad6ccd4fdee95
Fixes: #45805
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19335
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Subfolders must use the identifier as identifier 34/19334/2
Georg Ringer [Fri, 22 Mar 2013 18:14:45 +0000 (19:14 +0100)]
[BUGFIX] Subfolders must use the identifier as identifier

Currently subfolders don't use the identifier correctly as the name is
used instead. This doesn't really matter if you got a folder structure
anyway but dealing with different identifiers leads to troubles.

createFolderObject() will create a new Folder object which then has the
identifier set wrong.

Change-Id: I04629ffc97766557abc0920f1dbe56f1453d76ac
Fixes: #46568
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/19334
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Settings for local drivers are not shown by default 12/19212/2
Nicole Cordes [Fri, 22 Mar 2013 15:11:35 +0000 (16:11 +0100)]
[BUGFIX] Settings for local drivers are not shown by default

If you create a new storage the LocalDriver is selected by default
(because it is the first registered driver) but the flexform field is not
shown. Because of the hidden configuration field you cannot set up the
base path until you have saved the storage record. Local driver should be
selected by default and configuration field should be displayed every
time.

Change-Id: Ic9c6c1eb7ca3d9f45723dce728558002440ae9da
Fixes: #46555
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19212
Reviewed-by: Alexander Opitz
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Title includes html tags 03/19203/2
Nicole Cordes [Fri, 22 Mar 2013 09:13:21 +0000 (10:13 +0100)]
[BUGFIX] Title includes html tags

In the filelist special folders like _temp_ and _recycler_ folder are
highlighted in bold as they get human readable names. The <strong>
tags are shown in the title tag as well. Therefore the title tag has
to be stripped of any html tags.

Change-Id: I4b21a916851e0d02aa58971eabda32f813bd890c
Fixes: #46532
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19203
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Raise submodule pointer 20/19320/2
Christian Kuhn [Tue, 26 Mar 2013 20:43:02 +0000 (21:43 +0100)]
[TASK] Raise submodule pointer

Change-Id: I34270786b7208b73327e6c3330cc80a3e9be93a3
Reviewed-on: https://review.typo3.org/19320
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove needless "x " on TER-search 18/19318/2
Stefan Neufeind [Wed, 28 Nov 2012 19:38:15 +0000 (20:38 +0100)]
[BUGFIX] Remove needless "x " on TER-search

Keep input field after search for easy re-search.

Change-Id: I658657c89a91e5196ca5a2997d76bc0bba52c820
Fixes: #43410
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19318
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Segfaults on object comparisons 16/19316/3
Andreas Wolf [Sat, 23 Mar 2013 10:12:38 +0000 (11:12 +0100)]
[BUGFIX] Segfaults on object comparisons

In the ResourceStorage class, the identity of source and target storage
has to be verified for several operations (copy, move). When the
comparison is done with a simple equality operator (==), the properties
of both objects are compared when the objects are not identical. This
comparison led to a segfault in several environments, presumably because
of a meanwhile fixed PHP bug (https://bugs.php.net/bug.php?id=61557).

To prevent these segfaults on affected PHP versions, the comparison is
extended to check for object identity (===). This will not affect the
behaviour of the code, as there should always be only one object per
storage.

Change-Id: I378c447f75c00859447cf1443f64b81e54161c54
Resolves: #46584
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19316
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 15/19315/2
Christian Kuhn [Tue, 26 Mar 2013 20:15:57 +0000 (21:15 +0100)]
[TASK] Raise submodule pointer

Change-Id: I14c35e0a265b917b3ceb8663debd7d81f205c1b5
Reviewed-on: https://review.typo3.org/19315
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception with EXT:sys_note is installed 86/19286/2
Oliver Hader [Thu, 21 Mar 2013 15:03:26 +0000 (16:03 +0100)]
[BUGFIX] Exception with EXT:sys_note is installed

If extension sys_note is installed, and the first page does not
have a TypoScript Template with an accordant root flag, a
system exception is thrown, pointing out that the table
"tx_extbase_domain_model_backenduser" could not be found.

The reason for that is:
* the sys_note backend behaviour is based on Extbase
* Extbase is being configured using (front-end) TypoScript
* ext_typoscript_setup.txt files are not processed if there's
  no accordant root template for the current rootline
* the persistence mapping from "be_users" to the mentioned
  "tx_extbase_domain_model_backenduser" would have been defined
  in the external TypoScript file

The solution is to check, whether these external files got
processed during TypoScript parsing and will be processed
explicitely if they have not been integrated yet.

Change-Id: I06a7edecd5cdac9dd7ab3918b281712602ad6b36
Fixes: #46250
Related: #46511
Release: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19286
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Extbase Plugin for Indexed Search not working 54/19254/2
Matthias Nitsch [Tue, 5 Feb 2013 09:09:36 +0000 (10:09 +0100)]
[BUGFIX] Extbase Plugin for Indexed Search not working

The plugin uses wrong classes in several places, which leads to fatal
errors because of missing functions.

Replace all occurences with the right classes.

Resolves: #45162
Releases: 6.1, 6.0
Change-Id: Ie7a0ba25adadf5482b22eaf38c0cf88aaf44cd1a
Reviewed-on: https://review.typo3.org/19254
Reviewed-by: Matthias Nitsch
Tested-by: Matthias Nitsch
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Fix failing unit tests for LocalDriver 44/19244/2
Andreas Wolf [Sun, 24 Mar 2013 10:40:48 +0000 (11:40 +0100)]
[TASK] Fix failing unit tests for LocalDriver

The original patch for #46604 unfortunately broke two (non-critical)
unit tests, which are fixed again by this commit.

Change-Id: I36d2cc62cc6cc744cd482aad573db57a57f832a8
Related: #46604
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19244
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] FAL Upgrade Wizards do not set pid 16/19216/2
Benjamin Mack [Sat, 23 Mar 2013 14:04:41 +0000 (15:04 +0100)]
[BUGFIX] FAL Upgrade Wizards do not set pid

The sys_file_reference records are originally set to
be placed on rootLevel, the upgrade wizard does
exactly that.

However, the concept in this case is flawed
- When creating new sys_file_reference records via IRRE,
   the sys_file_reference is stored on the page
- When copying moving e.g. a tt_content record, all its
   child elements are placed on that new page as
   well (so this works)
- rootLevel restriction is not needed in this case

The patch does the following:
- Modify the existing upgrade wizard to place the
   sys_file_references on the pages of the foreign
   tables (tt_content pid)
- the rootLevel flag for sys_file_reference is removed
- Add a new upgrade wizard is added to ensure the
integrity of the sys-file-reference pids

Releases: 6.1, 6.0
Resolves: #46497
Change-Id: Ic592024669f68ed1606ed36eb050d1dfa5ad66bb
Reviewed-on: https://review.typo3.org/19216
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Default upload folder should be user_upload/ 41/19241/2
Benjamin Mack [Sat, 23 Mar 2013 15:27:52 +0000 (16:27 +0100)]
[BUGFIX] Default upload folder should be user_upload/

The default folder in FAL is set to temp. However, temp should
be used for temporary files like import/export t3d files,
not uploads by the user.
In 99% of the use case, the uploaded files should be accessible
by the frontend (which temp isn't because of a .htaccess file).
That's why the fileadmin/user_upload/ should always be
created in the install tool, AND the user_upload file
should be the default folder for the local driver.

Resolves: #46604
Releases: 6.1, 6.0
Change-Id: I79319bab4bad76c1af9e001a0a5146fae85ce59f
Reviewed-on: https://review.typo3.org/19241
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Folder Tree does not respect _temp_ and _recycler_ 38/19238/2
Benjamin Mack [Sat, 23 Mar 2013 15:06:11 +0000 (16:06 +0100)]
[BUGFIX] Folder Tree does not respect _temp_ and _recycler_

The Folder Tree View does not respect temp and
recycler settings, which are identified by the folder
names.

The file list itself does that, because there is a wrong
use of "getIdentifier".

You can see that the foldertree does not show
"Temporary" but "_temp_"  because the comparison
fails every time. The file list works however.

Resolves: #46603
Releases: 6.1, 6.0
Change-Id: I08de29b737ef3464addceda9f610e9dd0a7b1034
Reviewed-on: https://review.typo3.org/19238
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Resource storage does not emit signals 39/19239/2
Andreas Wolf [Sat, 23 Mar 2013 14:30:38 +0000 (15:30 +0100)]
[BUGFIX] Resource storage does not emit signals

The ResourceStorage class should emit signals before and after most
actions it performs. The emit*() methods are already there, but not
called from the "action" methods. This commit adds the calls where
missing.

Change-Id: Icf1653975aa72762ab61c6d649207c5900e66b1d
Resolves: #46587
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19221
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Tom Ruether
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19239

6 years ago[BUGFIX] Copy and move folders between storages is broken 13/19213/2
Nicole Cordes [Fri, 22 Mar 2013 17:23:39 +0000 (18:23 +0100)]
[BUGFIX] Copy and move folders between storages is broken

If you try to copy a folder from one storage into another one it leads to
a copy in the same (source) storage. This happens because the action is
executed in the source storage and only works with the source folder
object. This is fixed by calling the move method on the target storage
instead.

Besides the copyFolderBetweenStorages function raises an exception which
might be moved into the driver class as the driver should be responsible
for the copy work. Therefore the AbstractDriver should support
(abstract) methods to copy a folder between storages and the local
driver should raises the exception.

Same applies for moving folders between storages.

Change-Id: Ib282e351f39abca21d57f5d621b4bd999f8419d9
Fixes: #46564
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19213
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content 91/19191/2
Benjamin Mack [Tue, 9 Oct 2012 21:51:15 +0000 (23:51 +0200)]
[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content

Problem: sys_refindex should be updated when a link to a file is
inserted in or removed from RTE content.
Solution: Add missing softrefs.

Change-Id: Ice1f46a591bd0129aef043b0b18b21be0469157b
Releases: 6.0
Resolves: #36792
Reviewed-on: https://review.typo3.org/10942
Reviewed-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Reviewed-by: Mattias Nilsson
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19191
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] fallbackRendering is always called 95/19195/2
Simon Schaufelberger [Tue, 22 Jan 2013 22:33:45 +0000 (23:33 +0100)]
[BUGFIX] fallbackRendering is always called

When rendering textpic, the content object rendering is always called for
the Typoscript setting fallbackRendering which is not always defined.

Change-Id: I2ebfffd2ece8022136c4fcc8d0e12d552486dd32
Fixes: #44732
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19195
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Small cleanup in Boostrap.php 39/19039/3
Michael Stucki [Tue, 19 Mar 2013 12:54:00 +0000 (13:54 +0100)]
[TASK] Small cleanup in Boostrap.php

Code cleanup prior to #41596

Releases: 6.1, 6.0
Change-Id: I87294a52e282175b345ee8b1a735604f6993e0f3
Reviewed-on: https://review.typo3.org/19039
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Sorting files in filelist is case sentive 89/19189/2
Nicole Cordes [Fri, 22 Mar 2013 11:55:45 +0000 (12:55 +0100)]
[BUGFIX] Sorting files in filelist is case sentive

The sorting for files in the filelist is case sensitive while the sorting
for folders is not. The sorting should be adjusted to be identical for
files and folders.

Change-Id: I2aee28f42beb1f9b4b1eb969ee5503fd9bea0e23
Fixes: #46541
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19189
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Fix .zip-export on windows and add unit test 18/19118/3
Jost Baron [Fri, 15 Mar 2013 20:06:21 +0000 (21:06 +0100)]
[BUGFIX] Fix .zip-export on windows and add unit test

On Windows servers (xampp), the .zip-export of extensions did not
work because \ZipArchive::addFile can't add directories on Windows.

Added a unit test for the export function.

Fixes: #45140
Releases: 6.0, 6.1
Change-Id: If248bf031d3d7b621971de609b86eedc0ee05a64
Reviewed-on: https://review.typo3.org/19118
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] ExtDirectApi uses an undefined variable 15/19115/2
Dmitry Dulepov [Wed, 6 Mar 2013 18:24:44 +0000 (22:24 +0400)]
[BUGFIX] ExtDirectApi uses an undefined variable

Method generateAPI() sets $className inside the condition but later uses
it without checking if it is empty or not. The result is a PHP warning
"Invalid argument supplied for foreach()".

Change-Id: I7fd2bf88374661a8b54023aee9fe2af5619471b0
Resolves: #46075
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19115
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Usage of deprecated returnFilemounts() 69/19069/2
Markus Klein [Wed, 27 Feb 2013 12:06:46 +0000 (13:06 +0100)]
[BUGFIX] Usage of deprecated returnFilemounts()

Some places in Core still use $GLOBALS['BE_USER']->returnFilemounts()

Resolves: #36405
Releases: 6.0, 6.1
Change-Id: I6252ed1191811a9813e590aa570741d31522895c
Reviewed-on: https://review.typo3.org/19069
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] BELog module error: "vsprintf(): Too few arguments" 67/19067/2
Dmitry Dulepov [Wed, 6 Mar 2013 19:05:01 +0000 (23:05 +0400)]
[BUGFIX] BELog module error: "vsprintf(): Too few arguments"

AbstractExceptionHandler contains a function named writeLog. That
function adds an entry to the system log. System log expects not
just a string but a string format with % characters. Callers of
this methods may supply a URL ("Request URL:" in the log message)
that contains % characters. vsprintf() in the BELog view helper
will complain about missing arguments to such string.

Change-Id: Ie080c0af1d93c28f8521b670a8ae8e63f8c4cfda
Resolves: #46077
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19067
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use minimised version of jquery.dataTables-1.9.4 33/19033/2
Stefan Neufeind [Wed, 21 Nov 2012 00:29:56 +0000 (01:29 +0100)]
[TASK] Use minimised version of jquery.dataTables-1.9.4

Change-Id: Ic8f2f046b6df70c885158f4c1f08cbad1c943cf1
Resolves: #43186
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19033
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 23/19023/2
Christian Kuhn [Mon, 18 Mar 2013 21:03:35 +0000 (22:03 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ia8d085a85e3508a44403e6415de87785cda7ed9a
Reviewed-on: https://review.typo3.org/19023
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Media element not working with FAL 02/19002/2
Andreas Schütte [Wed, 13 Feb 2013 08:45:44 +0000 (09:45 +0100)]
[BUGFIX] Media element not working with FAL

With FAL the path to a file is no longer used,
instead the UID to the specific file is used,
prefixed with "file:"

This patch just adds a check if the filename
starts with "file:" and if so load the specific FileObject
to retrive the url. This check is done before all others,
because FAL should be the default file handler.
Additionally use explode() first to get the filename
if an editor adds (non used)
link parameters: file:740 _blank media-title

This fixes also the problem with audio files mentioned in #39416,
using the same patch.

Resolves: #41280
Related: #39416
Releases: 6.0, 6.1
Change-Id: Ibec6cefda54b6e136c0d5ae43c67ef2eea3b1bb8
Reviewed-on: https://review.typo3.org/19002
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix PHP warning in BackendUtility::lockRecords 92/18992/2
Helmut Hummel [Sat, 16 Mar 2013 15:29:20 +0000 (16:29 +0100)]
[BUGFIX] Fix PHP warning in BackendUtility::lockRecords

This methods triggers a warning "Illegal String offset"
with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed
even if a user is not logged in.

Additionally a delete query is executed in this case which
does not make sense at all.

Properly check if a user is logged in before executing any
functionality in this method.

Fixes: #46361
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: I370e0a8610a55b3d684bef95d7c6905eaaaacbab
Reviewed-on: https://review.typo3.org/18992
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] HMENU rendering uses old tslib_ class names 73/18973/2
Christian Kuhn [Thu, 14 Mar 2013 16:39:14 +0000 (17:39 +0100)]
[BUGFIX] HMENU rendering uses old tslib_ class names

The menu rendering in frontend still instantiates menu classes with
its old tslib_ prefixed names. This is unflexible and a potential
performance issue.

The patch introduces a simple factory instead with a mapping for
existing TypoScript menu types to the implementing classes.
The current variable $menuclasses is obsolete.
Additionally, the naming of three existing classes is adapted to
the correct class names to be in sync with the others.

A method in the factory to register additional menu types will
be added with a second patch.

Change-Id: I3d65258ffe4d30a918705b23349d3facb563c80e
Resolves: #46292
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18973
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Make sure XML parser is created everytime when needed 67/18967/2
Christian Kuhn [Sat, 16 Mar 2013 00:25:29 +0000 (01:25 +0100)]
[BUGFIX] Make sure XML parser is created everytime when needed

Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
is not properly working. The constructor creates the parser and
within parseXML() method the parser resource is freed.
However, when clicking on retrieve/update button method
parseXML() is invoked multiple times which makes subsequent calls
fail.

Creating the parser is now done within parseXML() method.

Change-Id: I7c6c15f65d08fb0264d7d66cc584cbe7ff423b45
Resolves: #25292
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/18967
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 64/18964/2
Christian Kuhn [Fri, 15 Mar 2013 23:00:46 +0000 (00:00 +0100)]
[TASK] Raise submodule pointer

Change-Id: Id68b495581b7ee0bff119031fd24dd01c4a1a5b8
Reviewed-on: https://review.typo3.org/18964
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Importing extensions from repository fails 62/18962/2
Christian Kuhn [Fri, 15 Mar 2013 21:54:00 +0000 (22:54 +0100)]
[BUGFIX] Importing extensions from repository fails

If importing the extension list from TER, an incoming XML extension
row has a field 'category' that contains either a string like
'plugin' or a category number.
The list is persisted to the 'extension' repository. In the
database, the category is stored as integer. There is a mapping
function in the extension model to get the integer category
index from given XML input. The method is faulty and returns
strings instead of an index if the given category is a string
itself. This results in database errors during insert.

The patch fixes the method, renames it along the way and adds
unit tests to document desired behavior.

Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1
Fixes: #46115
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18962
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGIFX] Extra output block backend thumbnails 59/18959/2
Francois Suter [Tue, 12 Feb 2013 16:09:14 +0000 (17:09 +0100)]
[BUGIFX] Extra output block backend thumbnails

If some inclusion causes output when viewing image thumbnails
in the backend, the output will be broken. Adding a call to
ob_clean() ensures that this does not happen.

Resolves: #31953
Releases: 6.1, 6.0
Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26
Reviewed-on: https://review.typo3.org/18959
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Fix wrong column title in web>list for field colpos" 42/18942/4
Christian Kuhn [Fri, 15 Mar 2013 15:02:19 +0000 (16:02 +0100)]
Revert "[BUGFIX] Fix wrong column title in web>list for field colpos"

This reverts commit 765ebd0cd992b86f8002f932bb51b2a39c0ace99

The patch triggers warnings and errors in multiple extensions. Digging
into the details shows the implementation is neither finished nor
stable. See issue #25113 for a detailed analysis.

Change-Id: I1ff1ea11feb34c71d3ee42789c3deda130aa9a0e
Related: #25113
Fixes: #45833
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18942
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 32/18932/2
Christian Kuhn [Fri, 15 Mar 2013 00:38:45 +0000 (01:38 +0100)]
[TASK] Raise submodule pointer

Change-Id: I64d97afc42424a0f6233fe645453f48c863c671c
Reviewed-on: https://review.typo3.org/18932
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LanguageController has "mixed" type annotations 20/18920/2
Wouter Wolters [Sun, 3 Feb 2013 13:11:07 +0000 (14:11 +0100)]
[BUGFIX] LanguageController has "mixed" type annotations

The LanguageController of the lang sysext throws
exceptions if the rewritten property mapper is enabled.
The type annotation 'mixed' is unknown. The patch fixed
the annotation to the correct string value to make the
property mapper happy.

Change-Id: I57ebd268d2fe82c095ccf20b581e721703fb2868
Fixes: #44672
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18920
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4 02/18902/2
Christian Kuhn [Thu, 14 Feb 2013 00:13:43 +0000 (01:13 +0100)]
[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4

APC has some slam protection that tries to prevent hammering of cache
entries. This can be disabled, but the option does not work at least
in native PHP 5.3.3 on debian squeeze. While it is no problem with
higher PHP version like the current one on travis-ci.org,
some tests are now just skipped on PHP environments knows for issues.

Change-Id: Ibbef201805b58041bb0b3e8aa16f0c1a2e366020
Resolves: #46267
Release: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18902
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private 98/18898/2
Christian Kuhn [Wed, 13 Feb 2013 23:59:20 +0000 (00:59 +0100)]
[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private

Change-Id: I7ada1e5e40067cf1faed8b2b5d338a690e921cad
Fixes: #46264
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18898
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Toolbar items with separator: fix white-space 92/18892/2
Felix Kopp [Sun, 24 Feb 2013 16:14:05 +0000 (17:14 +0100)]
[BUGFIX] Toolbar items with separator: fix white-space

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Change-Id: I09338d17848c8fc74b25e7c532d6ee329956321b
Fixes: #45795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18892
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Numeric translation keys aren't translated right in XML files 11/18211/2
Reinhard Führicht [Mon, 21 Jan 2013 08:52:35 +0000 (09:52 +0100)]
[BUGFIX] Numeric translation keys aren't translated right in XML files

When working with the "old" XML based translation files,
numeric keys aren't translated properly.
The reason is, that LocallangXmlParser uses array_merge to combine the
translation arrays of the default language and the current language.
array_merge renumbers numeric keys. Therefore, numeric key in
translation files result in wrong translations in Frontend.

Fixes: #44626
Releases: 6.0, 6.1
Change-Id: I8fdff385f681428b4cb5a3e994828a4a29305c98
Reviewed-on: https://review.typo3.org/18211
Reviewed-by: Reinhard Führicht
Tested-by: Reinhard Führicht
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Translation of a form makes the form wizard unusable 87/18887/3
Mario Rimann [Tue, 15 Jan 2013 09:20:27 +0000 (10:20 +0100)]
[BUGFIX] Translation of a form makes the form wizard unusable

As soon as the form-configuration for the form wizard gets
loaded, the leading "[Translate to XYZ:] " is stripped off to get the
wizard working (with the leading text, the form config could not
be serialized as needed and the wizard didn't show a single field).

The stripping is only done on localized records.

Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
Fixes: #39127
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/18887
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception when deleted file is in clipboard 84/18884/2
Andreas Wolf [Sun, 10 Feb 2013 17:10:54 +0000 (18:10 +0100)]
[BUGFIX] Exception when deleted file is in clipboard

When a file is deleted while it is part of a clipboard, an exception is
thrown when the clipboard is reconstituted. This exception has to be
catched, otherwise the file module will be unusable.

Change-Id: I8849644ffa7b78559c1797d85ce3cc6e01d03a74
Resolves: #43906
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18884
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager 82/18882/2
Andreas Wolf [Sat, 9 Feb 2013 14:49:32 +0000 (15:49 +0100)]
[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager

The ResourceStorage class of FAL has two inject* methods which are seen
as dependency injectors by the Extbase object manager. Thus an exception
is thrown when a ResourceStorage object is created via Extbase.

This commit changes the two method's names and adjust all usages within
the core. These methods are internal and I don't expect them to be used
anywhere else, so we don't need a backwards compatibility layer.

Change-Id: I4b73445708cf8041b505b5ea8923dc595ddaadb0
Resolves: #45319
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18882
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 64/18864/2
TYPO3 Release Team [Tue, 12 Mar 2013 16:02:47 +0000 (17:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I3c75e82765a4903ca34a19e8fac1ac5e2fdd1635
Reviewed-on: https://review.typo3.org/18864
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Old files of filelist extension are wrong 45/18845/2
Wouter Wolters [Mon, 11 Mar 2013 21:12:20 +0000 (22:12 +0100)]
[BUGFIX] Old files of filelist extension are wrong

During the namespace change the old filelist extenion files
are not correctly set. Instead of "filelist" this was replaced
with "file_list".

Fixes: #46155
Related: #45143
Releases: 6.0

Change-Id: I33ebb12163dd30d35981f45dcd465f7340bf1f5a
Reviewed-on: https://review.typo3.org/18845
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Show better error messages on failed TER update 44/18844/2
Jost Baron [Mon, 4 Mar 2013 21:38:01 +0000 (22:38 +0100)]
[TASK] Show better error messages on failed TER update

This patch shows error messages in a flash message if the ajax request
for a TER-update fails, and resets the extension manager into a sane
state, instead of showing an ever spinning wheel.

Resolves: #46030
Releases: 6.1, 6.0
Change-Id: I1cc67460a11feb206c53c12a38ad0f6db482e04a
Reviewed-on: https://review.typo3.org/18844
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make the update-from-TER link more visible 43/18843/2
Jost Baron [Mon, 4 Mar 2013 20:41:21 +0000 (21:41 +0100)]
[TASK] Make the update-from-TER link more visible

Make the "update from TER"-action in the extension manager more
visible by showing a button for it, instead of a text link.

Also moved the rendering functionality of the update link from
a viewhelper to a partial, as partials tend to be more readable
and bug free.

Resolves: #46029
Releases: 6.1, 6.0
Change-Id: If447bba28bc0dee3e7de286e1a93e062ef59843c
Reviewed-on: https://review.typo3.org/18843
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Handle symlink on extension update 42/18842/2
Philipp Gampe [Sun, 10 Mar 2013 16:15:27 +0000 (17:15 +0100)]
[BUGFIX] Handle symlink on extension update

If an extension is updated and the extension in the file
system is a symlink to a different directory, all
target directory contents is removed and the update fails.

Introduce a check for symlink and just remove the
symlink in this case.

Resolves: #46158
Releases: 6.1, 6.0
Change-Id: I112ae7192fb0edf77ebd703a61804dc09ca506a4
Reviewed-on: https://review.typo3.org/18842
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn