Packages/TYPO3.CMS.git
10 months ago[BUGFIX] Fix display of indexed search advanced search fields 60/56960/2
Gianluca Piccolo [Mon, 14 May 2018 07:42:45 +0000 (09:42 +0200)]
[BUGFIX] Fix display of indexed search advanced search fields

There were some advanced search fields in indexed search that
disappeared after the last update.

In SearchController, method processExtendedSearchParameters, there were
some non-existing variables that were used in some conditions.
With this patch, those variables are initialized before the conditions
and all the advanced search fields in indexed search are shown again.

Releases: master, 8.7
Resolves: #84995
Change-Id: I69aef4c7a3d869d519e84866929f4724c61eabd7
Reviewed-on: https://review.typo3.org/56960
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[FEATURE] Add scheduler task to anonymize IP addresses of tables 23/56923/9
Georg Ringer [Thu, 19 Apr 2018 11:36:03 +0000 (13:36 +0200)]
[FEATURE] Add scheduler task to anonymize IP addresses of tables

IP anonymizing improves the privacy of users and required as part of
the GDPR.

Resolves: #84781
Releases: master, 8.7, 7.6
Change-Id: Idd938136bed8f29e86b5e3e541c9fb8c9afd48ff
Reviewed-on: https://review.typo3.org/56923
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] Make RecordBrowser highlight selected record again 45/56945/2
Stanislas Rolland [Sat, 12 May 2018 19:19:16 +0000 (21:19 +0200)]
[BUGFIX] Make RecordBrowser highlight selected record again

When using the element browser wizard with a configured record link
handler, the record browser now highlights the currently linked
record again.

Resolves: #82739
Releases: master, 8.7
Change-Id: Iba47f18bf150bb4646729c6a5ecdae46b7d56754
Reviewed-on: https://review.typo3.org/56945
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] Keep state of extendedSearch 46/54646/4
Peter Niederlag [Wed, 15 Nov 2017 09:53:54 +0000 (10:53 +0100)]
[BUGFIX] Keep state of extendedSearch

formAction has set a bunch of variables that are required by
the frontend for the extendedSearch

Inside searchAction this parameters were not set resulting in
the extendedSearch section being empty in frontend after searching.

With this change the processing of the variables is extracted
into a method and called from formAction and searchAction.

Releases: master, 8.7
Resolves: #82064
Change-Id: Ia21c445ef0aa72e8e084e9bd021bc5caa7a1e74b
Reviewed-on: https://review.typo3.org/54646
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] PSR-7 responses return header using getHeader() 52/56952/3
Christian Kuhn [Sun, 11 Mar 2018 06:02:30 +0000 (07:02 +0100)]
[BUGFIX] PSR-7 responses return header using getHeader()

The base PSR-7 implementation of the Response object does not
sanitize the headers properly when handing them in as an array,
thus, it is stored wrong in the Response object.

Resolves: #84853
Releases: master, 8.7
Change-Id: I7571f1438bc602bcae9367b82f99946ed22d8308
Reviewed-on: https://review.typo3.org/56952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Allow setting SYS/session in ConfigurationManager 50/56950/2
Nicole Cordes [Sat, 12 May 2018 21:37:04 +0000 (23:37 +0200)]
[BUGFIX] Allow setting SYS/session in ConfigurationManager

The config path SYS/session is similar to SYS/caching/cacheConfigurations.
Within the session configuration path session backends can be set
since TYPO3 8.7.

Allow this path for setting values with the ConfigurationManager.

Resolves: #84536
Releases: master, 8.7
Change-Id: I52649673a16937119136d2fbdd0aa93c924d8f31
Reviewed-on: https://review.typo3.org/56950
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[TASK] Use ImageInfo class instead of direct PHP GD call 24/56724/7
Markus Klein [Mon, 9 Apr 2018 22:01:21 +0000 (00:01 +0200)]
[TASK] Use ImageInfo class instead of direct PHP GD call

This ensures maximum compatibility with all available graphics
commands.

Resolves: #78600
Releases: master, 8.7
Change-Id: Id7a95fbdf7782fef59e18de3dc4522d7c68b690a
Reviewed-on: https://review.typo3.org/56724
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[!!!][TASK] Use no-cookie domain for youtube by default 29/56929/5
Georg Ringer [Mon, 7 May 2018 12:44:15 +0000 (14:44 +0200)]
[!!!][TASK] Use no-cookie domain for youtube by default

Improve the privacy of users by using the no-cookie domain of youtube
by default and just use youtube.com if explicitly set.

Resolves: #84843
Releases: master, 8.7, 7.6
Change-Id: I01472f93e32c2011b5494c4670d07f29348016c3
Reviewed-on: https://review.typo3.org/56929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[BUGFIX] Clarify permission legend in access module 39/56939/2
Guido Schmechel [Sat, 21 Apr 2018 10:17:32 +0000 (12:17 +0200)]
[BUGFIX] Clarify permission legend in access module

The legend of the access module now reflects the intended
behavior of the `edit page` and `delete page` bits.

Resolves: #84513
Releases: master, 8.7
Change-Id: I409a1a7575bd8d44ee001cbbc95f154b5625141b
Reviewed-on: https://review.typo3.org/56939
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[TASK] Return full userTS in getTSConfig() 38/56938/2
Christian Kuhn [Sat, 12 May 2018 14:14:57 +0000 (16:14 +0200)]
[TASK] Return full userTS in getTSConfig()

By making the first argument $objectString optional in
BackendUserAuthentication->userTSConfig(), we allow the method to
act as a true getter that returns the full user TSconfig array.

This avoids calls to the public property ->userTS, which will be set
to protected in master with another patch.

This patch request is for both master and v8 to simplify life of
extension developers who want to keep an extension compatible
with v8 and v9, without throwing deprecations in v9.

Resolves: #84982
Releases: master, 8.7
Change-Id: I971fcaf4a402b762add4c469650c62b059264d8f
Reviewed-on: https://review.typo3.org/56938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Enable localizationStateSelector for selectTreeElement 05/56905/3
Christian Kuhn [Sat, 12 May 2018 09:47:27 +0000 (11:47 +0200)]
[BUGFIX] Enable localizationStateSelector for selectTreeElement

This patch enables the localizationStateSelector for the
selectTreeElement, so an editor can select the localization state
when allowLanguageSynchronization is enabled for the element.

Resolves: #84564
Releases: master, 8.7
Change-Id: I7b315bc19b165d7c9603c0a35ee11b03b7f77c4f
Reviewed-on: https://review.typo3.org/56905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Do not move processed files to recycler folder 17/56917/2
Nicole Cordes [Thu, 10 May 2018 22:06:16 +0000 (00:06 +0200)]
[BUGFIX] Do not move processed files to recycler folder

When a file gets moved to the recycler folder on delete. The processed
files should not be moved to the recycler folder but directly deleted.

Resolves: #81836
Releases: master, 8.7
Change-Id: I7a53830ea5d96735243fd9ee89e8c5aa80d084c0
Reviewed-on: https://review.typo3.org/56917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Alessandro Filira <alessandro.filira@pallino.it>
Tested-by: Alessandro Filira <alessandro.filira@pallino.it>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
10 months ago[TASK] Simplify frontend page generation code 93/56893/4
Helmut Hummel [Tue, 1 May 2018 16:57:06 +0000 (18:57 +0200)]
[TASK] Simplify frontend page generation code

The additional isINTincScript check stems from the time
where this code was in a separate file, which
was included two times and page generation should be
skipped for the second inclusion. As INT scripts are only generated
during page rendering (or when fetching the page from cache)
we can safely remove this condition now.

Additionally, we can now easily get rid of the elseif
and move the page rendering preparation directly
after the same condition is checked later in the code flow.

This is fine, because this code does not need to be
executed before the lock is released. Last but not least
we clean up admin panel messages to clearly distinguish
between page generation and rendering preparation.

As this is a pure non breaking cleanup, this can
safely go into 8.7 branch as well.

Resolves: #84945
Releases: master, 8.7
Change-Id: If12b82a549d4cc47619c46f73c5423df70621b1b
Reviewed-on: https://review.typo3.org/56893
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Drop undesired backslashes from Scheduler base tasks docs 03/56903/2
Mathias Brodala [Tue, 8 May 2018 09:57:39 +0000 (11:57 +0200)]
[BUGFIX] Drop undesired backslashes from Scheduler base tasks docs

Releases: master, 8.7, 7.6
Resolves: #84947
Change-Id: I4d81174497158b411c291ee51b331c1d3652e4a1
Reviewed-on: https://review.typo3.org/56903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
10 months ago[BUGFIX] JS error on folder change in file list 27/56927/2
Andreas Wolf [Fri, 11 May 2018 14:33:04 +0000 (16:33 +0200)]
[BUGFIX] JS error on folder change in file list

Change-Id: I9e2b05aee5a283d391703330b99d0378bfeca788
Resolves: #84972
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[BUGFIX] Compatibility for finishers which set content into the response 24/56924/2
Ralf Zimmermann [Mon, 30 Apr 2018 16:58:48 +0000 (18:58 +0200)]
[BUGFIX] Compatibility for finishers which set content into the response

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Since #84495, finishers with output can return this as string instead
of setting this directly into the response
(which results in a double output).
This patch ensures that existing custom finishers which set the content
into the response, get respected.

Resolves: #84901
Releases: master, 8.7
Change-Id: If98de92e6121283572b9146072ab8f9b7bcace8a
Reviewed-on: https://review.typo3.org/56924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[TASK] Make linkvalidator table usable without scrolling 22/56922/2
Ingo Pfennigstorf [Fri, 27 Apr 2018 10:40:47 +0000 (12:40 +0200)]
[TASK] Make linkvalidator table usable without scrolling

Currently using the linkvalidator and the table of broken links may
result in excessive horizontal scrolling, as the lines in the table
become very long.

This adds word breaks to the table cell contents and adds a fixed table
layout.

Releases: master, 8.7
Resolves: #84886
Change-Id: Iee4b4af36b2854512eb841f5b814ca8dc1715a53
Reviewed-on: https://review.typo3.org/56922
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[BUGFIX] No CORS Error in WS preview 18/56918/2
Benni Mack [Fri, 11 May 2018 04:56:13 +0000 (06:56 +0200)]
[BUGFIX] No CORS Error in WS preview

We should not manipulate document.domain in workspace preview as we need
to communicate with our parent master window.

Releases: master, 8.7
Resolves: #78401
Change-Id: Id3f581545a5547ca4ab8c46ee204b1c947ff6e56
Reviewed-on: https://review.typo3.org/56918
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Enforce int for timestamp on DateTime mapping 14/56914/2
Nicole Cordes [Thu, 10 May 2018 16:53:41 +0000 (18:53 +0200)]
[BUGFIX] Enforce int for timestamp on DateTime mapping

This patch ensures using an integer value for turning a timestamp
to a DateTime object as otherwise a PHP error is thrown.

Resolves: #84962
Releases: master, 8.7, 7.6
Change-Id: I18e82c8f91f42c29c4014985a1ad11671b5a31f4
Reviewed-on: https://review.typo3.org/56914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Add more rules for Code sniffer 90/56690/4
Georg Ringer [Mon, 16 Apr 2018 15:08:33 +0000 (17:08 +0200)]
[TASK] Add more rules for Code sniffer

In order to improve code quality, the following code sniffers are added:

- cast_spaces
- declare_equal_normalize
- dir_constant

Resolves: #84590
Releases: master, 8.7
Change-Id: Ib8a353b9ec47bff146b5decc3d5f97d242672efa
Reviewed-on: https://review.typo3.org/56690
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Unify language handling within TranslationStatusController 12/56912/3
Georg Ringer [Thu, 10 May 2018 18:17:32 +0000 (20:17 +0200)]
[BUGFIX] Unify language handling within TranslationStatusController

The localization overview within the info module should hide hidden
sys_language records as those are also not available to editors in
the page or list module.

Resolves: #82400
Releases: master, 8.7
Change-Id: I92cdf995c189187682c01beb1d5f5baff934d2cd
Reviewed-on: https://review.typo3.org/56912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] Remove duplicate database indices 11/56911/2
Stefan Froemken [Fri, 4 May 2018 07:15:56 +0000 (09:15 +0200)]
[BUGFIX] Remove duplicate database indices

Percona toolkit found some duplicate
indices in some ext_tables.sql.
Remove or update the mentioned indices.

Resolves: #82671
Releases: master,8.7
Change-Id: Icdb60e2ee9f16cad097c0371e258e2c176c3b50c
Reviewed-on: https://review.typo3.org/56856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Alessandro <alessandro.filira@pallino.it>
Tested-by: Alessandro <alessandro.filira@pallino.it>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/56911

10 months ago[BUGFIX] Consider `translationSource` for fetching localized records 04/56904/2
Andreas Fernandez [Wed, 9 May 2018 08:07:03 +0000 (10:07 +0200)]
[BUGFIX] Consider `translationSource` for fetching localized records

Using `transOrigPointerField` to fetch localized records does not work
for records that were copied into a different language via DataHandler's
`copyLanguage` command.

`BackendUtility::getRecordLocalization()` now takes `translationSource`
into consideration to fetch the appropriate localization of a record.

Resolves: #84951
Releases: master, 8.7
Change-Id: I8fc9ea3c1fdaf3e54110196c6a27411e0c66b366
Reviewed-on: https://review.typo3.org/56904
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[TASK] Replace static variable with class variable in FileInfo 99/56899/2
Anja Leichsenring [Sun, 6 May 2018 06:48:14 +0000 (08:48 +0200)]
[TASK] Replace static variable with class variable in FileInfo

By removing the graphicFunctions object from global scope, unit
tests are easier to add in this area.

Change-Id: I8ddf4e0282d42325ecb03c98bede91bf6e1b636c
Resolves: #84933
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56899
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[TASK] Add unit tests for ImageInfo 95/56895/3
Anja Leichsenring [Sun, 6 May 2018 07:33:09 +0000 (09:33 +0200)]
[TASK] Add unit tests for ImageInfo

Change-Id: I3d9ef96e3296de676d02aa84a5ebd926b10cae53
Resolves: #84934
Relates: #84583
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[TASK] Make failing acceptance tests after image update run again 78/56878/10
Anja Leichsenring [Sun, 6 May 2018 20:27:16 +0000 (22:27 +0200)]
[TASK] Make failing acceptance tests after image update run again

The agent update introduced a higher chromedriver version that
caused several acceptance tests to fail. Adjusting wait states
brings them back to green.

The bamboo plan update now uses a php.ini without xdebug and
simplifies the unit test runs in this area.

And we need a patch for typo3/testing-framework version 1.2.6:
composer update typo3/testing-framework

Change-Id: Icc7b6b062ad652db2c92ae7a7c5197477abf2b7d
Resolves: #84939
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56878
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[TASK] Run postgres tests on non-default port in v8 core 82/56882/3
Christian Kuhn [Mon, 7 May 2018 16:20:08 +0000 (18:20 +0200)]
[TASK] Run postgres tests on non-default port in v8 core

The bamboo testing images have been updated to ubuntu 18.04 base
which comes with postgres 10 by default. This however breaks
core v8 postgres acceptance and functional tests since doctrine-dbal
version of v8 core does not support postgres 10. This will not be
fixed in the php 7.0 compatible doctrine-dbal versions.
The test images thus now come with a second, version 9.5 based postgres
on "default port +1" (5433). The patch on v8 does:
* Adapt bamboo test plan to use 5433 port for postgres tests
* Raise typo3/testing-framework to 1.2.5 which contains postgres
  db preparations on non-standard port
* Adapt postgres acceptance installer test to fill in port if given
* Cope with a slightly different git output in bamboo plan

Resolves: #84941
Releases: 8.7
Change-Id: Ib52897d753cad43598e7271a0971ba361b9bc0f1
Reviewed-on: https://review.typo3.org/56882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[TASK] Update composer-dep enm1989/chromedriver 69/56869/2
Stefan Neufeind [Tue, 13 Mar 2018 10:40:40 +0000 (11:40 +0100)]
[TASK] Update composer-dep enm1989/chromedriver

Minor-update 2.33 to 2.38

Command used:
composer update enm1989/chromedriver

Resolves: #84238
Releases: master, 8.7
Change-Id: Ic15ba59fb8706134c36b1ee36147272342440707
Reviewed-on: https://review.typo3.org/56869
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Do not sharpen images if GFX/processor_effects is -1 94/56494/4
Guido Schmechel [Fri, 30 Mar 2018 23:45:54 +0000 (01:45 +0200)]
[BUGFIX] Do not sharpen images if GFX/processor_effects is -1

Sharpen images only if the install tool setting GFX/processor_effects is
set to 1 and not if it is set to 0 or -1

Resolves: #81700
Releases: 8.7
Change-Id: I0eab123720741b2f965bf9fc3767914ce46aaba0
Reviewed-on: https://review.typo3.org/56494
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[TASK] Inform user if TS condition does not make sense 36/56836/3
Markus Klein [Wed, 2 May 2018 22:23:05 +0000 (00:23 +0200)]
[TASK] Inform user if TS condition does not make sense

Empty conditions `[]` always evaluate to false. Warn the user
if such a condition is present.

Resolves: #84911
Releases: master, 8.7
Change-Id: I499e64aad30e29fe3698c40fed57e1f1c87ce885
Reviewed-on: https://review.typo3.org/56836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Respect empty allowedMimeTypes for file uploads 97/56197/2
Ralf Zimmermann [Thu, 22 Feb 2018 23:13:26 +0000 (00:13 +0100)]
[BUGFIX] Respect empty allowedMimeTypes for file uploads

Make it possible to allow all mime types (except php) within file upload
form elements.
Since there are some default mime types configured within the ext:form
standard setup, you have to remove this default mime types within your
form definition (or reconfigure the default values within your custom
ext:form setup).

FileUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null
    3: null

ImageUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null

Releases: master, 8.7
Resolves: #82670
Change-Id: Ifa07cceb47978b913f36b8607d4df4724ae22eef
Reviewed-on: https://review.typo3.org/56197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
10 months ago[BUGFIX] Unify the filename sanitation for upload, create, rename 52/56352/2
Wolfgang Klinger [Fri, 9 Mar 2018 22:40:40 +0000 (23:40 +0100)]
[BUGFIX] Unify the filename sanitation for upload, create, rename

isValidFilename allows other characters in file names
than sanitizeFileName. This patch sanitizes new file
names automatically (like it’s done for uploads) and
adds a warning for the user about the invalid original
file name for upload, create and rename.

Resolves: #84178
Releases: master, 8.7
Change-Id: I8f5ff6a0c601f0227c40fe7b401eeb15159b29a6
Reviewed-on: https://review.typo3.org/56352
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
10 months ago[BUGFIX] Catch exceptions for invalid form configuration files 16/56816/2
Benni Mack [Wed, 25 Apr 2018 06:39:05 +0000 (08:39 +0200)]
[BUGFIX] Catch exceptions for invalid form configuration files

Resolves: #84859
Releases: master, 8.7
Change-Id: I64b14c87758178f76258bdbf747931b008d9a71c
Reviewed-on: https://review.typo3.org/56816
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[BUGFIX] Hide save and new button in connected translation mode 17/56817/2
Patrick Broens [Mon, 16 Apr 2018 18:27:45 +0000 (20:27 +0200)]
[BUGFIX] Hide save and new button in connected translation mode

In connected translation mode it should not be possible to use the
save and new button as this would lead to an inconsistent translation
state. This change adds an additional condition for tt_content records
to determine if the content is in free translation mode. Only in free
translation mode the save and new is shown.

Resolves: #84752
Releases: master, 8.7
Change-Id: Id500098ef9f642472e96cce59205b4a25377e421
Reviewed-on: https://review.typo3.org/56817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[BUGFIX] Respect multi-byte values in search sword 02/56802/2
Benni Mack [Wed, 25 Apr 2018 04:34:30 +0000 (06:34 +0200)]
[BUGFIX] Respect multi-byte values in search sword

Resolves: #84857
Releases: master, 8.7
Change-Id: I72563fad6233f0508273f6a75b2f7ab51894e501
Reviewed-on: https://review.typo3.org/56802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
10 months ago[TASK] Add hook for resolving custom link types 90/56790/2
Daniel Goerz [Wed, 18 Apr 2018 17:11:42 +0000 (19:11 +0200)]
[TASK] Add hook for resolving custom link types

The extendability of the link wizard is incomplete since the
refactoring of it. This patch adds a missing hook to resolve custom
link syntax in the LinkService. It is now possible (again) to
resolve links that start with <identifier>:

Resolves: #79647
Releases: master, 8.7
Change-Id: Iaf0c18f72aa799ab44a8bd14bddd0ca6c3530198
Reviewed-on: https://review.typo3.org/56790
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
10 months ago[BUGFIX] Skip extra rendering of fields in ElementInformation 01/56801/2
Georg Ringer [Mon, 16 Apr 2018 08:09:55 +0000 (10:09 +0200)]
[BUGFIX] Skip extra rendering of fields in ElementInformation

tstamp & crdate fields must be added in the TCA columns
section to have those available in extbase models. Skip
those 2 fields in the ElementInformationController rendering to
still show the date instead of the timestamp.

Resolves: #84737
Releases: master, 8.7
Change-Id: Idadff6eb5ada56b24c872468fa2c18c35d168a6a
Reviewed-on: https://review.typo3.org/56801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Fix type of additionalConfig in media viewhelper 91/56791/2
Georg Ringer [Tue, 24 Apr 2018 13:54:24 +0000 (15:54 +0200)]
[BUGFIX] Fix type of additionalConfig in media viewhelper

Change the type from string to array.

Resolves: #84848
Releases: master, 8.7
Change-Id: I28071b1116b2c9b4fcdcc639c378b3b9c0503066
Reviewed-on: https://review.typo3.org/56791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Correct description for QueryGenerator->getTreeList 88/56788/2
Tymoteusz Motylewski [Tue, 24 Apr 2018 13:26:26 +0000 (15:26 +0200)]
[TASK] Correct description for QueryGenerator->getTreeList

Resolves: #84847
Releases: master, 8.7
Change-Id: Ica8a5cc234c6ea90a1964c87228136d06d9713ac
Reviewed-on: https://review.typo3.org/56788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Check if file exists for backend logo 48/56748/2
Lidia Demin [Thu, 19 Apr 2018 08:33:08 +0000 (10:33 +0200)]
[BUGFIX] Check if file exists for backend logo

If an invalid file path is given, an exception is thrown if trying to
access its properties and the backend is not accessible any more.
Check if file exists before accessing. If not use default.

Resolves #84791
Releases: master, 8.7

Change-Id: Ide4c58dd03cbad1ed06ad66f558d170cd2170482
Reviewed-on: https://review.typo3.org/56748
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Do not write empty array values in form definitions 44/56744/3
Ralf Zimmermann [Tue, 20 Feb 2018 22:44:00 +0000 (23:44 +0100)]
[BUGFIX] Do not write empty array values in form definitions

Symfony YAML dumps empty arrays as sequence ("{  }"). Due to this, some
JavaScript modules of the form framework fail to interpret/ set the
correct data type for those properties.

If applied, this commit will ensure that the formEditor unsets empty
array keys on load/ save.

The problem only affects the backend module, not the frontend
formDefinition interpreter.

Resolves: #83985
Releases: master, 8.7
Change-Id: I913b8954790510b4ffcc80a47f9dbb7646239ff1
Reviewed-on: https://review.typo3.org/55848
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-on: https://review.typo3.org/56744
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Check if client supports localStorage 42/56742/2
Andreas Fernandez [Thu, 19 Apr 2018 17:15:13 +0000 (19:15 +0200)]
[BUGFIX] Check if client supports localStorage

Resolves: #84788
Releases: master, 8.7
Change-Id: If7a1c3e1b04c4de391d0bdb943d989971def6e8a
Reviewed-on: https://review.typo3.org/56742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Validation error arguments are not applied 43/56743/2
Ralf Zimmermann [Sat, 17 Mar 2018 16:50:26 +0000 (17:50 +0100)]
[BUGFIX] Validation error arguments are not applied

If an extbase error object wants to be translated through EXT:form and
no translation is found, the original error message will be shown.
Possibly existing error message arguments must be applied by calling
the error objects __toString() method.

Resolves: #84449
Releases: master, 8.7
Change-Id: I3d1f92a7d9c9abcc239bdab17b42a2cbb9e98d94
Reviewed-on: https://review.typo3.org/56328
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-on: https://review.typo3.org/56743

11 months ago[FEATURE] Make indexed_search ready for GDPR 37/56737/2
Georg Ringer [Mon, 16 Apr 2018 08:46:57 +0000 (10:46 +0200)]
[FEATURE] Make indexed_search ready for GDPR

To be compatible with the GDPR, 2 new features are added to
the indexed_search extension:

- Make the index_stat_search table part of the garbage collector task
- Make the IP tracking configurable

Resolves: #84740
Releases: master, 8.7, 7.6
Change-Id: I8e1bcd937a3d4095fb1a048064e82845ff1a5344
Reviewed-on: https://review.typo3.org/56737
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Disable "Create new translation headers" when no selection is made 34/56734/2
Andreas Fernandez [Thu, 19 Apr 2018 12:02:28 +0000 (14:02 +0200)]
[BUGFIX] Disable "Create new translation headers" when no selection is made

The "Create new translation headers" is now disabled if no page to be
translated is selected to avoid errors in the target action. A small
TypeScript is added that unlocks the aforementioned button if at least
one checkbox was selected.

Resolves: #76676
Releases: master, 8.7
Change-Id: I163ed7322066d81597547dd2b2774434a086f082
Reviewed-on: https://review.typo3.org/56734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Preserve multivalue property sorting in form fields 23/56723/2
Ralf Zimmermann [Thu, 22 Feb 2018 18:30:18 +0000 (19:30 +0100)]
[BUGFIX] Preserve multivalue property sorting in form fields

This ensures e.g. the order of select options is preserved between
form edits.

Background: If you put "{"5":"5","4":"4"}" into JavaScript the order is
arbitrary. Internally this issue is already covered by the form editor
by transforming such values into some meta structure like
"[{'_label': '5', '_value': '5'}, ]{'_label': '4', '_value': '4'}".

This fails if some multivalue properties are already set, and such a
formDefinition is opened by the form editor: "{"5":"5","4":"4"}" becomes
"{"4":"4","5":"5"}".

This fix converts such multivalue properties right before this data is
interpreted by JavaScript.

Resolves: #83911
Releases: master, 8.7
Change-Id: Ife5f6be959958fcf9a2cf5c3942b2549f33287a1
Reviewed-on: https://review.typo3.org/55865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-on: https://review.typo3.org/56723

11 months ago[BUGFIX] Let form framework finisher parseOption respect arrays 22/56722/2
Ralf Zimmermann [Tue, 20 Feb 2018 09:17:49 +0000 (10:17 +0100)]
[BUGFIX] Let form framework finisher parseOption respect arrays

The method "parseOption()" can now handle arrays. This is necessary if a
finisher option references a form element value through an
identifier like "someOption: '{<elemenIdentifier>}'" and if
the form element value is an array (e.g. MultiCheckbox).
Furthermore "parseOption()" resolves form element references
within localized option values.

Resolves: #83477
Resolves: #82715
Releases: master, 8.7
Change-Id: I15bcdb1d7799a174e48330de91a444735250bfa1
Reviewed-on: https://review.typo3.org/55820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-on: https://review.typo3.org/56722

11 months ago[FEATURE] Add API to anonymize IP addresses 13/56713/5
Georg Ringer [Tue, 27 Feb 2018 04:28:57 +0000 (05:28 +0100)]
[FEATURE] Add API to anonymize IP addresses

Add an API to anonymize IP addresses.
The core uses this API to anonymize all IP addresses before
storing them. E.g. when logging.

This a necessary tool in order to comply with data and privacy
protections laws.

Resolves: #84053
Releases: master, 8.7, 7.6
Change-Id: Id45ee94696dee4fa2293e1226f2076883f6b9ade
Reviewed-on: https://review.typo3.org/56713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Render systeminformation toolbar items inline 28/56728/2
Benjamin Kott [Tue, 17 Apr 2018 20:54:52 +0000 (22:54 +0200)]
[BUGFIX] Render systeminformation toolbar items inline

Resolves: #84773
Releases: master, 8.7
Change-Id: Ib92146527fdae9c8b2c4ccc23ba387b89412eb6e
Reviewed-on: https://review.typo3.org/56728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[BUGFIX] Form editor breaks if property path does not exist 16/56716/2
Ralf Zimmermann [Sat, 17 Mar 2018 16:41:47 +0000 (17:41 +0100)]
[BUGFIX] Form editor breaks if property path does not exist

If a property path - which should be validated within the form editor -
does not exist within the form definition and this property is not
defined through the 'predefinedDefaults' within the setup, the
form editor must not break.

Resolves: #84448
Releases: master, 8.7
Change-Id: I3c5d4ebb1afb43f5a9bbc5839c8116d0d16e8f4b
Reviewed-on: https://review.typo3.org/56326
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-on: https://review.typo3.org/56716

11 months ago[BUGFIX] Unregister formeditor events through off() 17/56717/2
Ralf Zimmermann [Mon, 16 Apr 2018 07:33:15 +0000 (09:33 +0200)]
[BUGFIX] Unregister formeditor events through off()

Resolves a variable naming collision within the formeditor model method
off() to make it possible to unregister formeditor events registered
via on().

Releases: master, 8.7
Resolves: #84736
Change-Id: Ia2214a920f034a45e79e0d756985038b41873742
Reviewed-on: https://review.typo3.org/56717
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[BUGFIX] Exclude hidden fields within summary pages and mails 59/56359/5
Ralf Zimmermann [Sun, 18 Mar 2018 12:05:35 +0000 (13:05 +0100)]
[BUGFIX] Exclude hidden fields within summary pages and mails

Add a "renderingOptions" property called "_isHiddenFormElement" to
prevent form elements from being shown within summary pages and emails.

Resolves: #81770
Releases: master, 8.7
Change-Id: Iea3232879fc2be2cae00e5ed5cea565e68e192f3
Reviewed-on: https://review.typo3.org/56359
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[TASK] Suggest TCA overrides for ExtensionUtility::registerPlugin() 14/56714/2
Mathias Brodala [Tue, 17 Apr 2018 12:40:51 +0000 (14:40 +0200)]
[TASK] Suggest TCA overrides for ExtensionUtility::registerPlugin()

Resolves: #84766
Releases: master, 8.7
Change-Id: Ibcb51b2b424f556232945f95e68f0ec2bb3f6120
Reviewed-on: https://review.typo3.org/56714
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[BUGFIX] Prevent exception on backend login screen 08/56708/2
Frank Naegler [Tue, 17 Apr 2018 08:18:25 +0000 (10:18 +0200)]
[BUGFIX] Prevent exception on backend login screen

This patch adds an int cast for the second parameter of the date function
in the sys_news handling.

Resolves: #84764
Releases: master, 8.7
Change-Id: I4adc1ec8c49f4ef7ea744933446d01f943daf5b4
Reviewed-on: https://review.typo3.org/56708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Set TYPO3 version to 8.7.14-dev 02/56702/2
Oliver Hader [Tue, 17 Apr 2018 08:16:52 +0000 (10:16 +0200)]
[TASK] Set TYPO3 version to 8.7.14-dev

Change-Id: I931bdfd9f2260d98d75eff35a69697ad63ada51a
Reviewed-on: https://review.typo3.org/56702
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[RELEASE] Release of TYPO3 8.7.13 01/56701/2 8.7.13 TYPO3_8-7-13 v8.7.13
Oliver Hader [Tue, 17 Apr 2018 08:15:41 +0000 (10:15 +0200)]
[RELEASE] Release of TYPO3 8.7.13

Change-Id: I8bc754ecdc116d45d65186aa205f63bf8df6eb6d
Reviewed-on: https://review.typo3.org/56701
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Move file extension detection to FAL driver 96/56696/2
Frans Saris [Tue, 20 Feb 2018 13:36:16 +0000 (14:36 +0100)]
[BUGFIX] Move file extension detection to FAL driver

The only object that is allowed to handle the physical file in the FAL
is the driver. As that's the only instance that knows how to access the
file.

This patch makes sure the Indexer and FileExtensionFilter asks the
driver of the file extension instead of using the PathUtility itself.

Releases: master, 8.7
Resolves: #83976
Change-Id: I80bec3c3f86d1137747e37dd99973ada8909ad36
Reviewed-on: https://review.typo3.org/56696
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Synchronize the form documentation 83/56683/4
Björn Jacob [Mon, 16 Apr 2018 12:15:35 +0000 (14:15 +0200)]
[TASK] Synchronize the form documentation

Manual backport of #84457.

Resolves: #84745
Releases: 8.7
Change-Id: Iec81b41352744ab35ad70a828da013dce5149ed4
Reviewed-on: https://review.typo3.org/56683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Ensure that the „recover“ message is always in jQuery context 74/56674/2
Andreas Fernandez [Thu, 12 Apr 2018 12:45:26 +0000 (14:45 +0200)]
[BUGFIX] Ensure that the „recover“ message is always in jQuery context

When a page is about to get recovered by the recycler, a checkbox is
rendered into the modal text, which requires propert jQuery object.

However, if that checkbox is not required, a simple string is stored in
the `$message` variable, breaking functionality as a jQuery object is
expected. The message is now wrapped in a `<p>` tag to always have a
jQuery object in place.

Resolves: #84701
Relases: master, 8.7
Change-Id: Ie534380aa4be9800ce2754e0226ee52ee9ce5dc1
Reviewed-on: https://review.typo3.org/56674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Fix typos in TCA migration messages 82/56682/2
Georg Ringer [Mon, 16 Apr 2018 10:10:46 +0000 (12:10 +0200)]
[BUGFIX] Fix typos in TCA migration messages

Improve typos and grammar in messages of the TCA migration

Resolves: #84742
Releases: master, 8.7
Change-Id: I5dca04efcd9bfe796907612500735b4d93dddc41
Reviewed-on: https://review.typo3.org/56682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Make categories required for category related menus 84/56684/2
Georg Ringer [Mon, 16 Apr 2018 10:19:42 +0000 (12:19 +0200)]
[BUGFIX] Make categories required for category related menus

Set the minitems of categories of the the menu types "Categorized content"
and "Categorized pages" to 1 to force editors to fill out this field.

Resolves: #84738
Releases: master, 8.7
Change-Id: I84962e35ac1cffe34e1cd1abb0234a4e201eccd6
Reviewed-on: https://review.typo3.org/56684
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
11 months ago[BUGFIX] Make ConfirmationFinisher available in the FormEditor 66/56666/2
Stefan Neufeind [Sun, 15 Apr 2018 09:11:58 +0000 (11:11 +0200)]
[BUGFIX] Make ConfirmationFinisher available in the FormEditor

ConfirmationFinisher is available on 8.7 but can't be added
in the FormEditor. Backport relevant parts from master.

Resolves: #84731
Releases: 8.7
Change-Id: Id400ed6f79909d9f8a84cd9f99cde7887d5c3b17
Reviewed-on: https://review.typo3.org/56666
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
11 months ago[BUGFIX] Fix getPublicUrl return hints 72/56672/2
Kevin Ditscheid [Wed, 11 Apr 2018 20:41:49 +0000 (22:41 +0200)]
[BUGFIX] Fix getPublicUrl return hints

Since getPublicUrl could also return null, we need to
change the return hints to respect that.

Resolves: #84688
Releases: master, 8.7
Change-Id: Ib811b6bbeebf9dec974b094c6acf505ca4ac26e1
Reviewed-on: https://review.typo3.org/56672
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[BUGFIX] Remove quoting of search value in recycler 71/56671/2
Andreas Fernandez [Fri, 13 Apr 2018 06:46:11 +0000 (08:46 +0200)]
[BUGFIX] Remove quoting of search value in recycler

This patch removes a wrong call of `$queryBuilder->quote()` which causes
a wrong SQL statement, as the search filter text gets passed as a named
parameter later on.

Resolves: #84710
Releases: master, 8.7
Change-Id: If9bd45687827e20142558f12acefea6b70290372
Reviewed-on: https://review.typo3.org/56671
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[TASK] Cover adding image to tt_content with acceptance tests 67/56667/5
Tymoteusz Motylewski [Thu, 5 Apr 2018 15:44:46 +0000 (17:44 +0200)]
[TASK] Cover adding image to tt_content with acceptance tests

Add acceptance tests for adding image to tt_content,
when image has metadata filled or not.
As a side effect, it covers https://review.typo3.org/56438
with test.

Releases: master, 8.7
Resolves: #84631
Related: #81235

Change-Id: Idc92c14b6f44825b6082766ee92b72170680d4b3
Reviewed-on: https://review.typo3.org/56667
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Increase title length of filemount 69/56669/2
Guido Schmechel [Sat, 14 Apr 2018 17:59:20 +0000 (19:59 +0200)]
[TASK] Increase title length of filemount

Increase length of sys_filemount.title from 30 to 255 characters.

Resolves: #50979
Releases: master, 8.7
Change-Id: I37fc5a7877073bdfa485adb3d25dc8f2bd9b76ff
Reviewed-on: https://review.typo3.org/56669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Fix nightly CGL check 53/56653/4
Anja Leichsenring [Sat, 14 Apr 2018 10:50:50 +0000 (12:50 +0200)]
[BUGFIX] Fix nightly CGL check

PHP-CS-Fixer introduced a notice about overridden config paths,
which causes the cgl check to fail.
See https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2999

Resolves: #84719
Releases: 8.7
Change-Id: I542a7d91b485569195e3049922dd9823eeba0601
Reviewed-on: https://review.typo3.org/56653
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Finishers with output must return the output 65/56665/3
Ralf Zimmermann [Sun, 15 Apr 2018 08:32:33 +0000 (10:32 +0200)]
[BUGFIX] Finishers with output must return the output

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Now, finishers with output can return this as string instead of setting
this directly into the response (which results in a double output).

Resolves: #84495
Releases: master, 8.7
Change-Id: Ib5accba1004b857b5447ae26dff8a689acfa6579
Reviewed-on: https://review.typo3.org/56665
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[BUGFIX] Fix exception in clipboard inside recycler folders 58/56658/2
Georg Ringer [Thu, 5 Apr 2018 15:17:22 +0000 (17:17 +0200)]
[BUGFIX] Fix exception in clipboard inside recycler folders

To avoid exceptions in a _recycler_ folder in the filelist when
using the clipboard, the image is built without an ImageViewHelper.

Resolves: #84578
Releases: master, 8.7
Change-Id: Ib596f8bdec5eba1b2cc13a0b61abd3b12f186b65
Reviewed-on: https://review.typo3.org/56658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Increase length of sys_filemount.path 57/56657/2
Pinar Oezmen [Fri, 13 Apr 2018 14:05:56 +0000 (16:05 +0200)]
[BUGFIX] Increase length of sys_filemount.path

Increase length of sys_filemount.path from 120 to 255 chars.

Resolves: #84643
Releases: master,8.7
Change-Id: I84ff263a97e30403f5851ba731773e7ab5efde91
Reviewed-on: https://review.typo3.org/56657
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Add missing column in database query 56/56656/2
Georg Ringer [Thu, 5 Apr 2018 15:29:47 +0000 (17:29 +0200)]
[BUGFIX] Add missing column in database query

To avoid exceptions on certain database systems the pid must be selected
as well as it is used in the order statement.

Resolves: #84303
Releases: master, 8.7
Change-Id: I1f41925d9c22c20a2fa3f080b85bb4d17d03a778
Reviewed-on: https://review.typo3.org/56656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[BUGFIX] Do not try to download extensions in composer mode 07/56607/6
Helmut Hummel [Fri, 6 Apr 2018 10:55:08 +0000 (12:55 +0200)]
[BUGFIX] Do not try to download extensions in composer mode

Upgrade wizards that download extensions from TER must
no do so in composer mode as they would create an unusable
system.

But in case the extension is found, in the system, these wizards
still activate them.

Resolves: #82318
Releases: master, 8.7
Change-Id: I5ad1fdfeb81ad809497d8a88db32325639cd236b
Reviewed-on: https://review.typo3.org/56607
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
11 months ago[BUGFIX] Keep parameters in link browser’s upload form 95/56595/4
Andreas Fernandez [Fri, 6 Apr 2018 16:18:32 +0000 (18:18 +0200)]
[BUGFIX] Keep parameters in link browser’s upload form

Any given attribute stored in the `P` parameter is kept and attached to
the return URL of the upload form.

Resolves: #83923
Releases: master, 8.7, 7.6
Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de
Reviewed-on: https://review.typo3.org/56595
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary 90/56590/2
Andreas Fernandez [Tue, 3 Apr 2018 19:08:02 +0000 (21:08 +0200)]
[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary

The checkbox "Show hidden content elements" currently checks any selected
language. This is malfunctioning in case the language "Default" is
selected in the "Language" view, as it won't affect any translation.

The patch now changes the handling to add the language constraint only if
the view renders multiple languages and any language is selected, that is
not the default language.

Resolves: #84589
Resolves: #84573
Releases: master, 8.7
Change-Id: I572d594e5828d423e67a40481f44857df79ebae9
Reviewed-on: https://review.typo3.org/56590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Add hook to upload methods in GeneralUtility 89/56589/2
Frank Naegler [Wed, 4 Apr 2018 09:18:15 +0000 (11:18 +0200)]
[TASK] Add hook to upload methods in GeneralUtility

Resolves: #84600
Releases: master, 8.7, 7.6
Change-Id: I3f4698e892c98aadb41d3e6ba4f1e974a2ca479d
Reviewed-on: https://review.typo3.org/56589
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] Correct wrong type annotation for drawItem_footer hook 88/56588/2
Joshua Westerheide [Fri, 6 Apr 2018 07:28:58 +0000 (09:28 +0200)]
[BUGFIX] Correct wrong type annotation for drawItem_footer hook

Change-Id: I10e4061dcb54dda3460d248bc7ae436ee12103a0
Resolves: #84636
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Sort packages by name in Composer manifests 79/56579/3
Wouter Wolters [Wed, 4 Apr 2018 19:21:19 +0000 (21:21 +0200)]
[TASK] Sort packages by name in Composer manifests

Resolves: #84630
Releases: master, 8.7
Change-Id: Ie3af5ddd3721e546718cfa88ea219c40dc666e51
Reviewed-on: https://review.typo3.org/56579
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Allow tables with adminOnly in cleanup task of recycler 66/56566/2
Georg Ringer [Thu, 5 Apr 2018 14:08:03 +0000 (16:08 +0200)]
[BUGFIX] Allow tables with adminOnly in cleanup task of recycler

Allow also tables with the setting 'adminOnly' to be removed with the
scheduler task of EXT:recycler.

Resolves: #84604
Releases: master, 8.7
Change-Id: I41010359bbc3aa55f88e4bb184e9effe35884a76
Reviewed-on: https://review.typo3.org/56566
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[TASK] Update friendsofphp/php-cs-fixer to latest version 67/56567/2
Wouter Wolters [Thu, 5 Apr 2018 14:45:01 +0000 (16:45 +0200)]
[TASK] Update friendsofphp/php-cs-fixer to latest version

Update from 2.10.2 to 2.11.1

Command used:
composer update friendsofphp/php-cs-fixer php-cs-fixer/diff

Resolves: #84619
Releases: master,8.7
Change-Id: Ic9a30c1085c0fa2140416e371ed4735032f463b0
Reviewed-on: https://review.typo3.org/56567
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[BUGFIX] Allow span tags in fieldInformation return 74/56574/2
Nicole Cordes [Thu, 5 Apr 2018 16:38:14 +0000 (18:38 +0200)]
[BUGFIX] Allow span tags in fieldInformation return

To be able to improve the layout of field information, the span tag is
added to the list of allowed tags in html.

Resolves: #84633
Releases: master, 8.7
Change-Id: If3a60002cb8b7a7473e96820bdb35ac9c8111bab
Reviewed-on: https://review.typo3.org/56574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[BUGFIX] Keep UTF-8 characters unescaped in JsonView 65/56565/3
Oliver Klee [Sat, 31 Mar 2018 19:28:41 +0000 (21:28 +0200)]
[BUGFIX] Keep UTF-8 characters unescaped in JsonView

Resolves: #84572
Releases: master, 8.7
Change-Id: I7ace7322bdefcaeae5ffcc9021a5f13b4f5aeb1a
Reviewed-on: https://review.typo3.org/56565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[TASK] Streamline HTTP Response codes 63/56563/2
Frank Naegler [Thu, 5 Apr 2018 12:57:23 +0000 (14:57 +0200)]
[TASK] Streamline HTTP Response codes

This patch streamlines all lists of HTTP response codes.

Resolves: #84626
Related: #84490
Related: #84481
Releases: master, 8.7
Change-Id: Id7d3675e5f0f07a9c8920c40f70ddd194db994d0
Reviewed-on: https://review.typo3.org/56563
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[TASK] Add missing HTTP status code presets for PSR-7 responses 60/56560/2
Benjamin Franzke [Tue, 20 Mar 2018 05:12:31 +0000 (06:12 +0100)]
[TASK] Add missing HTTP status code presets for PSR-7 responses

They've been synched from the list of status codes at:
http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

This patch also corrects some misspelled reason phrases.

Change-Id: I993d851d6ac5dc5fb2538149d1e399aed62227ad
Releases: master, 8.7
Resolves: #84490
Related: #84481
Reviewed-on: https://review.typo3.org/56375
Reviewed-on: https://review.typo3.org/56560
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Let textareas within finisher inspector properties work 99/56199/2
Ralf Zimmermann [Thu, 15 Mar 2018 21:47:29 +0000 (22:47 +0100)]
[BUGFIX] Let textareas within finisher inspector properties work

Exclude textareas from javascripts sortable logic within the finisher
inspectors (form editor) to make it editable.

Resolves: #84177
Releases: 8.7
Change-Id: Iec983d4d2e5bdba867539122069186327eeb2fd1
Reviewed-on: https://review.typo3.org/56199
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Add rule "return_type_declaration" to php-cs-fixer 53/56553/2
Georg Ringer [Wed, 21 Mar 2018 19:45:15 +0000 (20:45 +0100)]
[TASK] Add rule "return_type_declaration" to php-cs-fixer

Unify the space before the colon of return type.

Resolves: #84515
Releases: master, 8.7
Change-Id: Ie107e574965f834c8fcaa8c2aa4f44f7cc41d7c5
Reviewed-on: https://review.typo3.org/56553
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Fix the return type annotations of JsonView 52/56552/2
Oliver Klee [Sat, 31 Mar 2018 18:41:34 +0000 (20:41 +0200)]
[BUGFIX] Fix the return type annotations of JsonView

transformValue will return the argument (mixed) untransformed if it is no
array or object and thus needs to return mixed as well.

transformObject will return a string for DateTime and hence needs to have
string as an additional return type.

Resolves: #84570
Releases: master, 8.7
Change-Id: I4d73f060eebb20b6f521fa685eca99acb688c702
Reviewed-on: https://review.typo3.org/56499
Reviewed-on: https://review.typo3.org/56552
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[BUGFIX] Show descriptionColumn in PageLayoutView only if not empty 51/56551/2
Georg Ringer [Wed, 4 Apr 2018 13:02:25 +0000 (15:02 +0200)]
[BUGFIX] Show descriptionColumn in PageLayoutView only if not empty

Check if there is actually content provided to build the footer of
content elements in the page module.

Resolves: #84602
Releases: master, 8.7
Change-Id: Ic2be8eed03b7ed06bc6f048f5e56854e5155615c
Reviewed-on: https://review.typo3.org/56551
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Add conflicts with broken sf/finder versions 48/56548/4
Helmut Hummel [Wed, 4 Apr 2018 12:55:00 +0000 (14:55 +0200)]
[BUGFIX] Add conflicts with broken sf/finder versions

A regression was introduced in symfony/finder
https://github.com/symfony/symfony/pull/26337

This caused PackageManager to not find any core packages
any more in case they were symlinked.

Composer command (after adding conflict):
composer update --lock

Resolves: #84601
Releases: 7.6, 8.7, master
Change-Id: I914c3b3c4a6c12375ebd9fe5442c3f7ff407de72
Reviewed-on: https://review.typo3.org/56548
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
11 months ago[BUGFIX] Show image metadata description 06/56506/2
Guido Schmechel [Thu, 22 Mar 2018 23:32:49 +0000 (00:32 +0100)]
[BUGFIX] Show image metadata description

Show the description as a placeholder when an image
is added as a reference.

Resolves: #81235
Releases: master, 8.7
Change-Id: I75363f74ba72bf4fd95b2a2e9a2a061ad250f825
Reviewed-on: https://review.typo3.org/56506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
11 months ago[BUGFIX] Try SVG first when detecting image size 45/56545/2
Anja [Tue, 3 Apr 2018 14:56:50 +0000 (16:56 +0200)]
[BUGFIX] Try SVG first when detecting image size

By processing SVG files first and falling back to IM/GM identify, output
of a 'invalid image content' error for SVG files is avoided.

Change-Id: I44a7d822b100bdc83f7afa8aa544b6f3eff194d0
Resolves: #84586
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56545
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Fix external page link in menu item 47/56447/5
Cyril Janody [Mon, 26 Mar 2018 15:05:41 +0000 (11:05 -0400)]
[BUGFIX] Fix external page link in menu item

Set link target with config.extTarget if none has been specified.

Resolves: #84052
Releases: 8.7

Change-Id: Id18a2588d5fa75f725a95b49e11505fa7cb80b78
Reviewed-on: https://review.typo3.org/56447
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
11 months ago[TASK] Replace validateRstFiles.sh with PHP version 84/56484/2
Sybille Peters [Sun, 11 Mar 2018 09:52:19 +0000 (10:52 +0100)]
[TASK] Replace validateRstFiles.sh with PHP version

Resolves: #84197
Releases: master,8.7
Change-Id: Ie0dcb29243a0852baa1b0de104b2e357edd0ab36
Reviewed-on: https://review.typo3.org/56484
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Properly encode HTML attributes in Toolbar 83/56483/2
Frank Naegler [Thu, 29 Mar 2018 14:43:02 +0000 (16:43 +0200)]
[BUGFIX] Properly encode HTML attributes in Toolbar

Resolves: #84561
Releases: master, 8.7
Change-Id: Iacb5dbf1fc5b709acd9db1c4463a991212a26a91
Reviewed-on: https://review.typo3.org/56483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Unify version/release in Documentation/Settings.cfg 80/56480/2
Sybille Peters [Thu, 29 Mar 2018 13:08:18 +0000 (15:08 +0200)]
[BUGFIX] Unify version/release in Documentation/Settings.cfg

Resolves: #83480
Releases: master, 8.7, 7.6
Change-Id: I87f3d692b4422b2e998076b2ef09ee65c85b8bba
Reviewed-on: https://review.typo3.org/56480
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[FEATURE] Make cHash configurable in Fluid Widget Links 63/56463/7
Georg Ringer [Tue, 27 Mar 2018 05:31:14 +0000 (07:31 +0200)]
[FEATURE] Make cHash configurable in Fluid Widget Links

To be able to support TYPO3 9 and 8 with same templates, the issue
#83244 is backported to 8 as well. The default value is set to true
to make it non breaking.

Resolves: #84537
Releases: 8.7
Change-Id: I45e51ba58fd32c7577d5cd0a67f36884ed7ce57a
Reviewed-on: https://review.typo3.org/56463
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Change the order of the AJAX Request for image cropping 80/56380/3
Giuseppe Cavallaro [Tue, 20 Mar 2018 12:41:57 +0000 (13:41 +0100)]
[BUGFIX] Change the order of the AJAX Request for image cropping

It ensures that the request will not be overwritten by the spinning icon
on fast servers.

Before the changes, the image cropping tool triggered a Console Error
"Uncaught TypeError: Cannot read property 'cropArea' of undefined at
ImageManipulation.init (ImageManipulation.js)."

Resolves: #84499
Releases: master, 8.7
Change-Id: Ic2208ba43d0976a1ba9674d68e5d861e89619d1a
Reviewed-on: https://review.typo3.org/56380
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Renaming files on non LocalDriver storages 75/56475/2
Michael Oehlhof [Sun, 21 Jan 2018 17:37:49 +0000 (18:37 +0100)]
[BUGFIX] Renaming files on non LocalDriver storages

Fixing determination of the parent folder of a file inside the
storage, so it can be used as destination for the renaming.

Resolves: #83628
Releases: master, 8.7
Change-Id: I2b905dc7ba5e3d6fa8bec2b5a728d27f3c4a3258
Reviewed-on: https://review.typo3.org/56475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Add correct context to page tree context menu 76/56376/2
Tymoteusz Motylewski [Sun, 18 Mar 2018 08:56:29 +0000 (09:56 +0100)]
[BUGFIX] Add correct context to page tree context menu

In order to allow user to disable context menu items for certain context,
e.g. page tree, page tree need to correctly pass the context to the JS.

As SvgTree doesnt support context menu, the code is moved to the PageTree.js
Also a bug in the changelog documentation is fixed.

Releases: master, 8.7
Resolves: #84017
Change-Id: I4c3b51aa50d1750b86391342ba45aaec00c70a10
Reviewed-on: https://review.typo3.org/56376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Correctly evaluate LIT:0 in TS conditions 74/56474/2
Markus Klein [Tue, 27 Mar 2018 19:59:19 +0000 (21:59 +0200)]
[BUGFIX] Correctly evaluate LIT:0 in TS conditions

Handle LIT:0 used in TypoScript conditions such that is evaluates
to '0' instead of null.
This makes comparisons for equality working.

Resolves: #84543
Releases: master, 8.7
Change-Id: I5eb16d556098179605646faf696f9defaf6195ac
Reviewed-on: https://review.typo3.org/56474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[BUGFIX] Fix wrong quoting in AdminPanelView 62/56462/3
Sascha Löffler [Mon, 26 Mar 2018 22:39:20 +0000 (00:39 +0200)]
[BUGFIX] Fix wrong quoting in AdminPanelView

Fixes wrong quotes for preview_simulateDate in
AdminPanel.

Resolves: #84524
Related: #83357
Releases: 8.7
Change-Id: I0f9834b6f651538ab6a107f99600b5400497db66
Reviewed-on: https://review.typo3.org/56462
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>