Packages/TYPO3.CMS.git
4 years agoRevert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE" 60/33060/2
Markus Klein [Tue, 30 Sep 2014 09:28:17 +0000 (11:28 +0200)]
Revert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE"

This reverts commit eda10cc0f2f2ddb7fa645c2f7ef6b71ea9f22b94.

The commit message of the original patch references a wrong issue number and the target versions seem to be wrong too.

Change-Id: I37866f1a70f354fae36a4efe3c7dab0c77f84bc8
Resolves: #61968
Reverts: #61943
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33060
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE 55/33055/2
Michael Schams [Mon, 29 Sep 2014 09:54:35 +0000 (19:54 +1000)]
[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE

This patch fixes invalid JavaScript code (adds a missing closing
bracket), that prevents BE users from creating links to anchor tags
in the RTE.

This is a regression fix to #60919.

Resolves: #61943
Releases: master, 6.2, 6.1, 4.7, 4.5
Change-Id: I90ecba126191322048a2c4aca7835d3795764324
Reviewed-on: http://review.typo3.org/33055
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[DB] Increase max length of link fields 52/33052/2
Lars Malach [Mon, 29 Sep 2014 10:21:48 +0000 (12:21 +0200)]
[DB] Increase max length of link fields

The current core supports links with the maximum length of 256 chars in
header links of tt_content elements and links in table
sys_file_reference.

External links can have much more than 256 chars.

Increasing the maximum length to 1024 should be enough - even current
browsers are supporting much more than 1024 chars.

Resolves: #61944
Releases: master, 6.2
Change-Id: I2031ebef959de696bc320b927ec1a462bcd5dd72
Reviewed-on: http://review.typo3.org/33052
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Change explanatory text of SYS error reporting config variables 25/33025/2
Daniel Minder [Mon, 29 Sep 2014 09:28:30 +0000 (11:28 +0200)]
[BUGFIX] Change explanatory text of SYS error reporting config variables

Unify explanatory text of the variables [SYS][errorHandlerErrors],
[SYS][exceptionalErrors], [SYS][syslogErrorReporting] and
[SYS][belogErrorReporting] so that formatting, link to PHP doc and
the numerical default values are similar.

Resolves: #61942
Releases: master, 6.2
Change-Id: Iacdbf18ad5c181c499c23c4c50cebffc6736236c
Reviewed-on: http://review.typo3.org/33025
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Felogin improperly merges flexforms and TS conf 13/33013/2
Markus Klein [Mon, 23 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] Felogin improperly merges flexforms and TS conf

There are two options to show the forgot password link in FE:
 * TypoScript: showForgotPasswordLink
 * Flexforms: showForgotPassword

The flexform values are merged with the TS values, but as these config
options are named differently, they are not overridden properly.

With #50138 the forgot-form is now only displayed when showForgotPassword
is set, hence the TypoScript configuration is not taken into account.

Since we can neither change the flexform, nor the TypoScript, we need to
merge the values in the flexform-merge code part.

This patch reduces the code to use only the documented TypoScript option.

Resolves: #59821
Releases: 6.3, 6.2
Change-Id: I77c391910561a304649d4c747ec868388be3f1a5
Reviewed-on: http://review.typo3.org/33013
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] DBAL admin_query() check array before accessing it 06/33006/2
Markus Klein [Sun, 28 Sep 2014 13:59:09 +0000 (15:59 +0200)]
[BUGFIX] DBAL admin_query() check array before accessing it

Move the $parsedQuery array access after the is_array() check in
DatabaseConnection::admin_query() to avoid PHP warnings.

Releases: master, 6.2
Resolves: #61929
Change-Id: I641d1e0d1dbe0001bd7082fbed1ce5ddb35172f8
Reviewed-on: http://review.typo3.org/33006
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1 93/32993/2
Ralf Hettinger [Tue, 30 Apr 2013 14:15:54 +0000 (16:15 +0200)]
[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1

There was a slight glitch in indexed_search's indexer, which resulted in
a wrong frequency mapping if the ratio between number of current word /
all words is exactly 1.
The "frequency" for this word is now mapped to the highest possible
value.

Resolves: #47745
Releases: master, 6.2
Change-Id: I1c9945b9550b80ad969f907f0bf1f14c3ae872f9
Reviewed-on: http://review.typo3.org/32993
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix indexed_search page browsing calculation 92/32992/2
Markus Klein [Tue, 15 Jul 2014 17:30:24 +0000 (19:30 +0200)]
[BUGFIX] Fix indexed_search page browsing calculation

Fix the calculation of pages shown by the indexed_search page browsers
to avoid negative page numbers or numbers exceeding the maximum available
page number.

Resolves: #60346
Releases: master, 6.2
Change-Id: I97de1c1afe42e29d450733f6741bca049f9803f6
Reviewed-on: http://review.typo3.org/32992
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Suhosin triggers warnings in Install Tool 42/32942/2
Wouter Wolters [Mon, 24 Feb 2014 22:27:18 +0000 (23:27 +0100)]
[BUGFIX] Suhosin triggers warnings in Install Tool

When Suhosin runs in simulation mode, violations are logged
as usual, but nothing is blocked or removed from the request.

Add an extra check to isSuhosinLoaded, to prevent unneeded
warnings.

Resolves: #55886
Releases: master, 6.2
Change-Id: Idd07872d31d51ed3266fcf330e825187656167a8
Reviewed-on: http://review.typo3.org/32942
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Do not check file extension on local file 30/32930/3
Alexander Opitz [Tue, 23 Sep 2014 09:14:15 +0000 (11:14 +0200)]
[BUGFIX] Do not check file extension on local file

If a file is uploaded and file extension deny pattern is set,
we should not test this temporary file for extension permissions.
Also on adding a file into a storage do not need to test the
extension of the local file, the extension of the target file is
enough.

Resolves: #58367
Releases: master, 6.2
Change-Id: I95b1685746150e2b03c56a5680785ae0b2388cd9
Reviewed-on: http://review.typo3.org/32930
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Kiessling <andreas.kiessling@web.de>
Tested-by: Andreas Kiessling <andreas.kiessling@web.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Set TYPO3 version to 6.2.6-dev 40/32940/2
TYPO3 Release Team [Tue, 23 Sep 2014 13:33:40 +0000 (15:33 +0200)]
[TASK] Set TYPO3 version to 6.2.6-dev

Change-Id: Ib005698d0b38bdac0d4a3d174a304058e4a55dbe
Reviewed-on: http://review.typo3.org/32940
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
4 years ago[RELEASE] Release of TYPO3 6.2.5 39/32939/2 6.2.5 TYPO3_6-2-5
TYPO3 Release Team [Tue, 23 Sep 2014 13:33:12 +0000 (15:33 +0200)]
[RELEASE] Release of TYPO3 6.2.5

Change-Id: I36118db416a33e85a4f2cc41c6a8e5e6acd9571f
Reviewed-on: http://review.typo3.org/32939
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
4 years agoRevert "[BUGFIX] Invalid rendering of high resolution icons in lists" 32/32932/3
Oliver Hader [Tue, 23 Sep 2014 11:53:25 +0000 (13:53 +0200)]
Revert "[BUGFIX] Invalid rendering of high resolution icons in lists"

This reverts commit 0db092ee5befc4b0eaf8e5193e7f49c326905d67.

Change-Id: Ib27e83ff31b20c9ba03e34a184dae18a779672d9
Resolves: #61813
Releases: master, 6.2
Change-Id: I0d24095fb1def7a2934c97a37441bec009538891
Reviewed-on: http://review.typo3.org/32932
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Invalid rendering of high resolution icons in lists 09/32909/2
Eric Chavaillaz [Sun, 21 Sep 2014 11:51:40 +0000 (13:51 +0200)]
[BUGFIX] Invalid rendering of high resolution icons in lists

When using high resolution icons (png) in backend modules (32x32) and
this module can be enabled/disabled in the be_groups/be_users records,
the icon is displayed bigger than desired.

This patch introduces width and height attributes in the "getIconHtml"
method to prevent this visual bug.

Resolves: #61656
Releases: master, 6.2
Change-Id: Ida484f794ab632eef8c693e41ee2b5f5d26c5e8f
Reviewed-on: http://review.typo3.org/32909
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Prevent fatal when importing a t3d file without fal information 99/31799/2
Sascha Egerer [Thu, 24 Jul 2014 15:44:16 +0000 (17:44 +0200)]
[BUGFIX] Prevent fatal when importing a t3d file without fal information

Currently the importer expects that an imported t3d file contains
data for fal. This is not the case if the t3d file comes from
a TYPO3 4.5 installation.

As a result a fatal error is caused because fread is called with
a length of 0.

Resolves: #60540
Releases: 6.3, 6.2
Change-Id: Ib112200c2b6cba0252440cd370d57a6ccd048bf2
Reviewed-on: http://review.typo3.org/31799
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Add permission checks to edit icons in filelist and context menu 01/32901/2
Franz Koch [Wed, 27 Aug 2014 20:39:10 +0000 (22:39 +0200)]
[BUGFIX] Add permission checks to edit icons in filelist and context menu

In filelist as well as in context menus the edit/info/cut/copy/paste
icons are always shown and not disabled/removed if related FAL object
doesn't allow these actions. These changes fix this.

Resolves: #61261
Releases: 6.2, 6.3
Change-Id: I318a1112e9ee3c2fda4db219364663c89161320c
Reviewed-on: http://review.typo3.org/32901
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] LocalDriver->calculateBasePath doesn't properly sanitize 89/32889/2
Bernhard Kraft [Mon, 1 Sep 2014 13:36:01 +0000 (15:36 +0200)]
[BUGFIX] LocalDriver->calculateBasePath doesn't properly sanitize

The method "calculateBasePath" of Resource/Driver/LocalDriver.php
does not properly sanitize the passed value.

It misses to use the return value of "canonicalizeAndCheckFilePath".

Change-Id: I8f2561e4a3b432d869ba7931f3ce5877714699c0
Resolves: #61295
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32548
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
(cherry picked from commit 0d5a3c0379d5fc6c208cf267b8b23993cd2b6a55)
Reviewed-on: http://review.typo3.org/32889
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[CLEANUP] Unqoute integer in BackendUserSessionRepository 99/32899/2
Andreas Fernandez [Fri, 19 Sep 2014 13:46:22 +0000 (15:46 +0200)]
[CLEANUP] Unqoute integer in BackendUserSessionRepository

In the method "findByBackendUser" in BackendUserSessionRepository,
the beuser uid used in the WHERE condition is casted to int and is
then quoted again.
This is not necessary and breaks the SQL for some DBMS.

Resolves: #61743
Releases: master, 6.2
Change-Id: Ibff2b6189efa16b8d7ce0acbc1637ce374f5f24d
Reviewed-on: http://review.typo3.org/32899
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] add _loadRealInstance in f:form ViewHelper 95/32895/2
Stefan Froemken [Fri, 1 Aug 2014 13:01:15 +0000 (15:01 +0200)]
[BUGFIX] add _loadRealInstance in f:form ViewHelper

If you edit a form containing subproperties of your domain model,
f:form VH will add some hidden fields to identify your related
domain models (__identity).
But in case of @lazy annotations, these fields will not be
rendered because of a missing _loadRealInstance call
in AbstractFormViewHelper object.

Releases 6.3, 6.2
Resolves: #60726
Change-Id: I67864e5b80752ff4350efabc72bd2b0a89d33bad
Reviewed-on: http://review.typo3.org/32895
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Invalid closure in AbstractMenuContentObject 74/32874/5
Francois Suter [Thu, 18 Sep 2014 20:09:15 +0000 (22:09 +0200)]
[BUGFIX] Invalid closure in AbstractMenuContentObject

Issue #58792 introduced a closure in AbstractMenuContentObject.php
which is not PHP 5.3 compatible. Since TYPO3 6.2 must still
support PHP 5.3, and master should be for now.
The closure is replaced by a simple loop.

Resolves: #61721
Releases: 6.2, master
Change-Id: Icc65bf8f8feec1bc62fcf83d8a2f464db3141c0d
Reviewed-on: http://review.typo3.org/32874
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Transfer curlProxyServer to new HTTP settings 79/31879/2
Ernesto Baschny [Sun, 27 Jul 2014 11:59:20 +0000 (13:59 +0200)]
[BUGFIX] Transfer curlProxyServer to new HTTP settings

Splits up the old curlProxyServer correctly, stripping "http://" and
potentially trailing slashes.

Resolves: #45834
Releases: 6.3, 6.2, 6.1
Change-Id: Ibfefb927b5fd3fe900170870e1093027d4fe34b5
Reviewed-on: http://review.typo3.org/31879
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Always show action icons in tables (em, docs) 33/32833/2
Felix Kopp [Tue, 16 Sep 2014 09:49:26 +0000 (11:49 +0200)]
[TASK] Always show action icons in tables (em, docs)

The goal to hide actions icons has not been reached. Since the
hiding the icons is worse than showing all icons we revert to
the prior behaviour.

In the long run secondary and extended options / actions will
have to move into the Clickmenu. Show only primary actions.

Resolves: #55828
Releases: master, 6.2
Change-Id: Ibf3731822f5a06f1cd04989140d4f11ec5675c65
Reviewed-on: http://review.typo3.org/32833
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Extbase behaviour concerning workspaces 67/32867/2
Oliver Hader [Tue, 10 Jun 2014 10:03:29 +0000 (12:03 +0200)]
[BUGFIX] Extbase behaviour concerning workspaces

Issue #26732 introduced some behaviour into Extbase that cannot
work on the long-run. The usual behaviour of TYPO3 is "fetch
live, then overlay". Avoiding that chain might lead to
several side-effects.

This change integrates a new property "_versionedUid" than
contains the specific uid of the versioned record (this is
similar to the already existing _localizedUid property).
Besides that, changes of issue #26732 are reverted.

Functional frontend tests are enabled for live and workspace
for all IRRE ForeignField scenarios.

Resolves: #59107
Releases: 6.2, 6.3
Change-Id: Idc46fb86830bc3d750972adade178cf9c618ece5
Reviewed-on: http://review.typo3.org/32867
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Workspace Preview not working with lockSSL=3 57/32857/2
Oliver Hader [Thu, 18 Sep 2014 08:07:05 +0000 (10:07 +0200)]
[BUGFIX] Workspace Preview not working with lockSSL=3

The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.

The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.

The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.

The comparison flaw was integrated with issue #54265

Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32857
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Indexed Search: Add missing return statement 29/32829/2
Markus Klein [Wed, 17 Sep 2014 12:09:21 +0000 (14:09 +0200)]
[BUGFIX] Indexed Search: Add missing return statement

Add missing return statement to searchMetaphone() method.

Resolves: #61679
Releases: master, 6.2
Change-Id: Ia87909a3f41fffea4a311c1d682aa97b8d7d5414
Reviewed-on: http://review.typo3.org/32829
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Introduce .editorconfig file 15/32815/2
Frank Nägler [Tue, 16 Sep 2014 07:47:00 +0000 (09:47 +0200)]
[TASK] Introduce .editorconfig file

A lot of IDEs support a .editorconfig file, this file contains
informations for the IDE how to handle and format files.
This little file can be used for any kind of file. If the IDE
support this file, the IDE configure it selfs to use the settings
e.g. to use TAB instead of SPACES.

Resolves: #61621
Releases: 6.2, 6.3
Change-Id: I76fb7901c0cf07a5b848523a0c0e46a6f705db4d
Reviewed-on: http://review.typo3.org/32815
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Follow up: Remove PHP warnings when no icon is found 06/32806/2
Nicole Cordes [Tue, 16 Sep 2014 13:02:08 +0000 (15:02 +0200)]
[BUGFIX] Follow up: Remove PHP warnings when no icon is found

With https://review.typo3.org/32616/ a check with file_exists() was
introduced to prevent warnings on accessing non-image files. The check
returns true for files and folders. Now warnings are thrown, if an image
icon links to a folder. This patch replaces file_exists() with is_file()
to prevent further warnings.

Resolves: #61640
Releases: 6.3, 6.2
Change-Id: If2f7db44588d7fb9f90d05fb3192653002fe0202
Reviewed-on: http://review.typo3.org/32806
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Dummy WHERE condition compatibility 04/32804/2
Andreas Fernandez [Tue, 16 Sep 2014 12:12:30 +0000 (14:12 +0200)]
[BUGFIX] Dummy WHERE condition compatibility

The Typo3DbBackend.php places a dummy where condition in case
$statementParts['where'] is empty. The condition is changed
for compatibility reasons with some DBMS.

Resolves: #61639
Releases: 6.3, 6.2
Change-Id: If3f23af43fea6460407e8b05f9bcd782c6e08f0d
Reviewed-on: http://review.typo3.org/32804
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Don't prepend absolute image URLs 99/32799/2
Franz Koch [Mon, 15 Sep 2014 16:15:20 +0000 (18:15 +0200)]
[BUGFIX] Don't prepend absolute image URLs

The ImageService->getImageUri() method always prepends the public URL of
the image object with a prefix, regardless whether the object already
returns a fully qualified URL. This can be the case when the FAL driver
is connecting a remote image storage that doesn't allow local processing
and requires the images to be loaded from the remote server.

Change-Id: Iac65bc93bc0d1c1cbeb2335b7e13fc2126b728b6
Resolves: #61617
Releases: 6.2, 6.3
Reviewed-on: http://review.typo3.org/32799
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Add a "save and new" button in scheduler module 98/32798/2
Eric Chavaillaz [Sat, 21 Jun 2014 16:53:38 +0000 (18:53 +0200)]
[TASK] Add a "save and new" button in scheduler module

Resolves: #57733
Releases: 6.3, 6.2
Change-Id: I57bd5e842374853a62a5c1e4b419c193837ccb6e
Reviewed-on: http://review.typo3.org/32798
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Change relevance sorting in EM 96/32796/2
Andreas Fernandez [Tue, 26 Aug 2014 13:51:03 +0000 (15:51 +0200)]
[TASK] Change relevance sorting in EM

The Extension Manager creates a virtual "position" field containing
the relevance of a search hit. The relevance is calculated in a hacky
way working in MySQL only. This is replaced by a more understandable
query that is parsable by the SqlParser.

Resolves: #61204
Releases: 6.3, 6.2
Change-Id: I541cbeef745e8dc25131af2a937ec2d028a2fc2c
Reviewed-on: http://review.typo3.org/32796
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove error_reporting from thumbs.php 85/32785/2
Stefan Neufeind [Mon, 15 Sep 2014 14:08:55 +0000 (16:08 +0200)]
[TASK] Remove error_reporting from thumbs.php

Change-Id: I0aab3f628325fb2db3276d5d6d9e878e6328be0f
Resolves: #27250
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32785
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Split xdebug.max_nesting_level into two error levels 82/32782/2
Nicole Cordes [Wed, 10 Sep 2014 15:39:11 +0000 (17:39 +0200)]
[TASK] Split xdebug.max_nesting_level into two error levels

The recommended xdebug.max_nesting_level was raised from 250 to
400 with issue #59391. Since the core itself usually works fine
with 250 and more is usually only needed for extensios with
deeply nested partials in fluid for example, the check is now
split to two error levels: Below 250 throws error level warning,
below 400 throws only a warning level warning.

Resolves: #61523
Related: #59391
Releases: master, 6.2
Change-Id: I366a97fe8077a389fff7f03935ad5b89d1469bc9
Reviewed-on: http://review.typo3.org/32782
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years agoRevert "[BUGFIX] Improve l10n_mode config for sys_file_reference" 59/32759/2
Anja Leichsenring [Sun, 14 Sep 2014 12:18:16 +0000 (14:18 +0200)]
Revert "[BUGFIX] Improve l10n_mode config for sys_file_reference"

This reverts commit f96c1013e89994ed6ce822af6fe1b837e50d3234.

Change-Id: I0440c9f0144c707a8aa15a0024226c7115f84ce2
Reviewed-on: http://review.typo3.org/32759
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Improve l10n_mode config for sys_file_reference 56/32756/2
Alexander Stehlik [Tue, 1 Jul 2014 14:02:19 +0000 (16:02 +0200)]
[BUGFIX] Improve l10n_mode config for sys_file_reference

Since the rendering in the Frontend does not merge the values
the mergeIfNotBlank setting is replaced with prefixLangTitle for
the alternative, description and title field.

For the link field the mergeIfNotBlank setting is removed because
a prefix does not make sense there.

Releases: 6.3, 6.2
Resolves: #59972
Change-Id: I242b687a7ce851270022b86561f13eacea4d3949
Reviewed-on: http://review.typo3.org/32756
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix typos in comment (method header) 55/32755/2
Michael Schams [Sun, 14 Sep 2014 05:04:54 +0000 (15:04 +1000)]
[BUGFIX] Fix typos in comment (method header)

This patch fixes two minor typos in the method description (comment)
in class TYPO3\CMS\Extbase\Persistence\Generic\Query.php for method
logicalAnd().

Change-Id: I4bad1d06bc85a0ccdb8b34f0454957946e07991d
Resolves: #61569
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32755
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Functional Test: force storage record to be caseSensitive "1" 50/32750/2
Fabien Udriot [Thu, 12 Jun 2014 13:24:13 +0000 (15:24 +0200)]
[BUGFIX] Functional Test: force storage record to be caseSensitive "1"

In the context of Functional Tests, makes sure the
storage record in initialized with caseSensitive "1"
which prevents the on-the-fly storage creation
by the Framework as this setting is dependent on the OS.

Change-Id: I0baa8d7743968adc1106768be02671cc5a81628a
Releases: master, 6.2
Resolves: #59527
Reviewed-on: http://review.typo3.org/30693
Reviewed-on: http://review.typo3.org/32750
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Use title & alternative fields in filelinks 48/32748/2
Georg Ringer [Mon, 8 Sep 2014 13:35:54 +0000 (15:35 +0200)]
[BUGFIX] Use title & alternative fields in filelinks

* The field "alternative" of the file should be used if filled.
* The field "title" of the reference should be preferred over the
  name if filled.

Resolves: #60429
Releases: 6.3, 6.2
Change-Id: I969dbb49a292f9980b9efa0e5e72ff2a9bc7e2f3
Reviewed-on: http://review.typo3.org/32748
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Followup 2 to mod.SHARED.colPos_list fix 43/32743/2
Jigal van Hemert [Wed, 10 Sep 2014 19:34:41 +0000 (21:34 +0200)]
[BUGFIX] Followup 2 to mod.SHARED.colPos_list fix

Deal with empty mod.SHARED and fill activeColPosList with colPosList
in case the TSconfig setting is empty.

Resolves: #39967
Releases: 6.2, 6.3
Change-Id: I5e2e4420de8f1d603e13a03758f97803e545d9a3
Reviewed-on: http://review.typo3.org/32743
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Followup to mod.SHARED.colPos_list fix 42/32742/2
Helmut Hummel [Wed, 10 Sep 2014 08:31:05 +0000 (10:31 +0200)]
[BUGFIX] Followup to mod.SHARED.colPos_list fix

The internal property activeColPosList is intermediately
set to an array and not converted to a comma separated list
any more, which breaks related code.

Resolves: #39967
Releases: 6.2, 6.3
Change-Id: I6f2e4710174ad5277f9de47c2d7b2cbb7a5ebb80
Reviewed-on: http://review.typo3.org/32742
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] RootlineUtility wrongly handles group-type fields 25/32725/2
Francois Suter [Tue, 15 Apr 2014 19:48:16 +0000 (21:48 +0200)]
[BUGFIX] RootlineUtility wrongly handles group-type fields

\TYPO3\CMS\Core\Utility\RootlineUtility::enrichWithRelationFields()
tries to resolve relations to the current page record, including
fields with MM-relations. But it wrongly tests only for the
"foreign_table" property, whereas group-type fields will use the
"allowed" property.

This patch checks for "allowed" first and falls back on
"foreign_table". Furthermore a check is added to ensure the final
implode is indeed working on an array.

Resolves: #50396
Releases: 6.3, 6.2, 6.1
Change-Id: I43427061a5051298a25e45584aa995846ebb877c
Reviewed-on: http://review.typo3.org/32725
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Add more files to .gitignore 91/32691/2
Nicole Cordes [Tue, 9 Sep 2014 16:17:54 +0000 (18:17 +0200)]
[TASK] Add more files to .gitignore

composer.lock and everything below typo3conf/ should be excluded if
the core checkout is used as document root directly.

Resolves: #61483
Releases: 6.3, 6.2
Change-Id: I34e706c510c38d953a98f0f30789f87fc968ae52
Reviewed-on: http://review.typo3.org/32691
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Use FE category collection for pages 88/32688/2
Francois Suter [Fri, 8 Aug 2014 13:10:43 +0000 (15:10 +0200)]
[BUGFIX] Use FE category collection for pages

Class CategoryMenuUtility which is used when rendering a list
of categorized pages calls on
\TYPO3\CMS\Core\Category\Collection\CategoryCollection
to collect the pages. This is wrong in a FE context as all
pages will be collected (hidden, deleted, workspace copies, etc.).
It must use
\TYPO3\CMS\Frontend\Category\Collection\CategoryCollection
instead.

Resolves: #59440
Releases: 6.2, 6.3
Change-Id: Ia8df04f5f615f3b6f09d2f67fbfadf69baca8f21
Reviewed-on: http://review.typo3.org/32064
Reviewed-by: Tomita Militaru <militarutomita@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
Reviewed-on: http://review.typo3.org/32688

4 years ago[BUGFIX] Cache missing class information only in productive context 86/32686/2
Nicole Cordes [Tue, 9 Sep 2014 13:18:27 +0000 (15:18 +0200)]
[BUGFIX] Cache missing class information only in productive context

To improve cache handling during development, missing class information
shouldn't be cached anymore. Otherwise each time a class was misspelled
and not found we have to clear the classes_cache.

Resolves: #61475
Releases: 6.3, 6.2
Change-Id: I7de24348e84bd89afd81164b90f776a996fcb8d9
Reviewed-on: http://review.typo3.org/32686
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add unit tests for forceAbsoluteUrl() 78/32678/2
Markus Klein [Sun, 27 Jul 2014 23:00:41 +0000 (01:00 +0200)]
[TASK] Add unit tests for forceAbsoluteUrl()

ContentObjectRenderer::forceAbsoluteUrl() is not covered by unit tests
at all.
Add unit tests and improve mocking in other existing tests.

Resolves: #60629
Releases: 6.3, 6.2
Change-Id: Ie3c03b0cff2118bf7ef38ca03135f2a0a6f120cd
Reviewed-on: http://review.typo3.org/32678
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Enable skipped tests by properly creating mocks 77/32677/2
Helmut Hummel [Sun, 29 Jun 2014 14:39:29 +0000 (16:39 +0200)]
[BUGFIX] Enable skipped tests by properly creating mocks

Latest changes in PHP disallow unserialize on
certain internal classes. Since phpunit uses
unserialize to create objects of such classes
when requesting a mock without calling the constructor
these tests failed with a PHP fatal error.

Instead of skipping the tests, we can simply provide
mocked constructor arguments (if required) so that
phpunit can create a mock object by using the new operator
and passing these mocked constructor arguments.

Releases: 6.3, 6.2
Resolves: #59981
Related: #59685
Change-Id: Ibd3b9aee0376a5043e053cffa6c88f7b93c86e18
Reviewed-on: http://review.typo3.org/32677
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add possibility to register a module as navigation 76/32676/2
Helmut Hummel [Thu, 5 Jun 2014 15:00:18 +0000 (17:00 +0200)]
[TASK] Add possibility to register a module as navigation

While implementing CSRF protection for backend modules,
it was forgotten to implement a solution for navigation components
that also could be modules.

Add this possibility now by introducing yet another
configuration option for modules.

Resolves: #58138
Documentation: #59369
Releases: 6.3, 6.2
Change-Id: I6655ad11cbf8a13c7d1182c9635cf2745183fb49
Reviewed-on: http://review.typo3.org/32676
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Nested flexforms no longer throw exception 75/32675/2
Thomas Christiansen [Thu, 5 Jun 2014 13:33:53 +0000 (15:33 +0200)]
[BUGFIX] Nested flexforms no longer throw exception

This patch prevents nested flexforms from throwing
an exception on saving or opening the record.

Resolves: #59368
Releases: master, 6.2
Change-Id: Iadeeecc3aef92b8bcc4f7fe4e22882d924f10a50
Reviewed-on: http://review.typo3.org/32675
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Remove comment header in ext_emconf 74/32674/2
Christian Kuhn [Sun, 6 Jul 2014 16:43:27 +0000 (18:43 +0200)]
[CLEANUP] Remove comment header in ext_emconf

The "do not touch me" comment header in ext_emconf.php files
of system extensions are misleading since we are editing those
files manually for years now. Remove those headers.

Change-Id: I27f6253effa54dae7f92170175e7705cc706d03a
Resolves: #60129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32674
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Respect tablenames, fieldname when updating mm record 73/32673/2
Frans Saris [Fri, 29 Aug 2014 10:14:31 +0000 (12:14 +0200)]
[BUGFIX] Respect tablenames, fieldname when updating mm record

The Typo3DbBackend doesn't respect the columns tablenames
and fieldname when updating mm releations. As result wrong
relations are adjusted.

Resolves: #61268
Releases: 6.2, 6.3
Change-Id: Ica1c04fb54b2f152ccf0f9bd766091854f01721a
Reviewed-on: http://review.typo3.org/32673
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add CLI option to set DB socket for functional tests 72/32672/2
Steffen Müller [Tue, 9 Sep 2014 08:52:53 +0000 (10:52 +0200)]
[TASK] Add CLI option to set DB socket for functional tests

An additional option "typo3DatabaseSocket" can be set
to configure a custom DB socket when running functional tests
from the commandline interface.

Resolves: #61465
Releases: 6.3, 6.2
Change-Id: If34526264bdc8b91c7c45785dde06a10fb606526
Reviewed-on: http://review.typo3.org/32672
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Improve deprecation message in show_rechis.php 61/32661/2
Wouter Wolters [Mon, 8 Sep 2014 20:52:41 +0000 (22:52 +0200)]
[TASK] Improve deprecation message in show_rechis.php

Use a more detailed message how to link to this script.

Resolves: #61458
Releases: 6.3, 6.2
Change-Id: Ifabac9033b72bea288b13a11d1e649f28b99f950
Reviewed-on: http://review.typo3.org/32661
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Line breaks in string in compile* methods of the SqlParser 48/32648/3
Stefano Kowalke [Tue, 4 Feb 2014 09:30:46 +0000 (10:30 +0100)]
[BUGFIX] Line breaks in string in compile* methods of the SqlParser

There are lines-breaks inside the string which produces
'SELECT * \n\t\t\t\tFROM table_name\n\t\t\t\tWHERE'
queries while compile the sql query back from the array.

This breaks the test for EXT:dbal because debugAndCompare()
function will die.

Releases: 6.3, 6.2
Resolves: #55648
Change-Id: Iab6ad451d30bb94494ebbd3cb3b69e661ee55c00
Reviewed-on: http://review.typo3.org/32648
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Overriding TCA results in Exception 43/32643/2
Stefan Froemken [Mon, 4 Aug 2014 08:15:24 +0000 (10:15 +0200)]
[BUGFIX] Overriding TCA results in Exception

This problem only occours when using "tree" as
display mode for TCA-type "select".
FlexForm-API brings a special configuration to add,
edit and remove items from a selectbox, but in
case of a select-tree it does not make sense. A
completely different API was called to render this tree.
This patch prevents modifying the select-tree.

Releases: 6.3, 6.2
Resolves: #54490
Change-Id: I3ad3c5c608d7968ba90117aa048014b00cfd44af
Reviewed-on: http://review.typo3.org/32643
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add file existence check before processing it 37/32637/2
Frank Nägler [Fri, 5 Sep 2014 14:16:03 +0000 (16:16 +0200)]
[BUGFIX] Add file existence check before processing it

This patch adds a check if a file exists before processing it.
If the file does not exist, all file functions will generate a warning.

Resolves: #61300
Releases: 6.3, 6.2
Change-Id: Ie829ec0ade8357b16f8a550d5f137593900720b9
Reviewed-on: http://review.typo3.org/32637
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Fix clear_cache for XCache < 3.0 36/32636/2
Alexander Opitz [Wed, 27 Aug 2014 16:03:37 +0000 (18:03 +0200)]
[BUGFIX] Fix clear_cache for XCache < 3.0

The XCache API changed with version 3.0. Ubuntu 12.04 uses XCache
version 1.3.2 so we need to support the old API.

Resolves: #61175
Releases: 6.3, 6.2
Change-Id: I76e975222747c965c5ef6e062231209d398a1c15
Reviewed-on: http://review.typo3.org/32636
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Add indexed search icon to plugin wizard 34/32634/3
Kay Strobach [Sun, 26 Feb 2012 20:03:25 +0000 (21:03 +0100)]
[TASK] Add indexed search icon to plugin wizard

Adds a small icon to the plugin wizard to avoid the hacky 2 click access.
The icon is added to the tab "Plug-Ins".

Change-Id: Ib0b9705acaf69c0c49de660174c536caedda9292
Resolves: #34298
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/9221
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/32634

4 years ago[BUGFIX] Remove PHP warnings when no icon is found in FormEngine 25/32625/2
Benjamin Mack [Sun, 7 Sep 2014 15:24:28 +0000 (17:24 +0200)]
[BUGFIX] Remove PHP warnings when no icon is found in FormEngine

If running in development mode and an icon
in FormEngine is not found, TYPO3 shows
the PHP E_WARNING of getimagesize() in a flash message.

The check should therefore be done in a cleaner way,
without the @ symbol.

Releases: 6.3, 6.2
Resolves: #61394
Change-Id: I546faee95bf304e135709c3e1c95292f48daf3d7
Reviewed-on: http://review.typo3.org/32625
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Travis-ci: Disable apc in PHP 5.4 24/32624/2
Christian Kuhn [Sun, 7 Sep 2014 19:43:24 +0000 (21:43 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.4

APC for travis-ci on cli was disabled for PHP 5.3 already because of
instability. This patch kicks out APC for PHP 5.4 as well after
recent failed travis runs in this area.

Releases: master, 6.2
Change-Id: I1182a0fcfc5f94f7f778c9f0fde5f5d8672b17ee
Reviewed-on: http://review.typo3.org/32624
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Use SpriteIcon for Add icon in Scheduler 21/32621/2
Felix Kopp [Sun, 7 Sep 2014 17:40:06 +0000 (19:40 +0200)]
[TASK] Use SpriteIcon for Add icon in Scheduler

Resolves: #61395
Releases: 6.2, 6.3
Change-Id: If77a7b9163ef23d291ca6106c453da059fe5ff21
Reviewed-on: http://review.typo3.org/32621
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix loading of registry entries for namespace 19/32619/2
Frank Nägler [Fri, 5 Sep 2014 19:01:24 +0000 (21:01 +0200)]
[BUGFIX] Fix loading of registry entries for namespace

When calling get(), all entries for the given namespace are loaded only
if no value for this namespace has been set() before in the same run.

This patch fix this by tracking the loading of namespaces and check the
state before set() or get() is processed. In case the namespace was not
loaded before, the loadEntriesByNamespace() is called to prevent
overwrite of values.

Resolves: #53182
Releases: 6.3, 6.2
Change-Id: Ib09e5892e35cef998413d2f0d8039ed49a7e7226
Reviewed-on: http://review.typo3.org/32619
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] colPos_list sets access to edit areas 15/32615/2
Jigal van Hemert [Thu, 24 Jul 2014 23:18:52 +0000 (01:18 +0200)]
[BUGFIX] colPos_list sets access to edit areas

The property mod.SHARED.colPos_list used to determine which columns
were visible in the Page module. With backend layouts it will only
determine which edit areas in the backend layout are accessible for
editing.

Resolves: #39967
Releases: 6.3, 6.2
Change-Id: Iba65ce84adf025802d1b0ebda00dff4d6299a06a
Reviewed-on: http://review.typo3.org/32615
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] indexed_search: in some cases indexing does not work 01/32601/2
Samir Rachidi [Mon, 25 Aug 2014 15:59:09 +0000 (17:59 +0200)]
[BUGFIX] indexed_search: in some cases indexing does not work

In some cases $pObj->register['SYS_LASTCHANGED'] is NULL and therefore
a MySQL error occurs during indexing a page. So, in these cases,
we need to set the 'mtime' value by getting it from the page and we
always want to prevent a NULL-value getting inserted into the DB.

Resolves: #61135
Releases: 6.1, 6.2, 6.3
Change-Id: Idb78af3aa23350db4bd43f58638541e6b3ad3ae3
Reviewed-on: http://review.typo3.org/32601
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make TCA property "exclusiveKeys" work with single key 00/32600/2
Roland Waldner [Thu, 4 Sep 2014 21:32:46 +0000 (23:32 +0200)]
[BUGFIX] Make TCA property "exclusiveKeys" work with single key

It is necessary that "exclusiveValues" is a string in the JavaScript
method FormEngine.setSelectOptionFromExternalSource() because
in JavaScript strings (but not numbers) have a method match() which
is used in FormEngine.setSelectOptionFromExternalSource().

"exclusiveValues" representing a single key (e.g. -1) are of type
"Number" - in this case an JavaScript error is thrown when the
script calls match() on it.

This commit ensures that "exclusiveValues" is always casted to
String.

Resolves: #61276
Releases: 6.3, 6.2
Change-Id: I049a5e6d11b3b27be901baa1e00429ab200b9a04
Reviewed-on: http://review.typo3.org/32600
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] where statement in typoscript select with stdWrap 93/32593/2
Kilian Hann [Thu, 21 Aug 2014 11:37:27 +0000 (13:37 +0200)]
[BUGFIX] where statement in typoscript select with stdWrap

The 'where' part of the statement now takes stdWrap properties
into account.

Resolves: #61117
Releases: 6.3, 6.2
Change-Id: Id1b2fe88a1cc72ca12acdb6628ed4b713e121798
Reviewed-on: http://review.typo3.org/32593
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Allow integers to be converted to objects 92/32592/2
Helmut Hummel [Mon, 1 Sep 2014 09:43:40 +0000 (11:43 +0200)]
[BUGFIX] Allow integers to be converted to objects

In TYPO3 CMS the identity of objects/ records are
integers (uids). Because of that, the persistent object
type converter should be able to convert integers to
objects, not only strings.

Releases: 6.2, 6.3
Resolves: #61292
Change-Id: I0b69295ae7adfdbe49cf19056614b984f34290c6
Reviewed-on: http://review.typo3.org/32592
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Cleanup error handling code and settings description 68/32568/2
Markus Klein [Wed, 27 Aug 2014 22:21:55 +0000 (00:21 +0200)]
[TASK] Cleanup error handling code and settings description

The error handling code for PHP errors needs some cleanup.
So does the description of the related settings in the Install Tool.

Resolves: #61235
Releases: 6.3, 6.2
Change-Id: Ibd95fcdaa6a50a870035037a2332b95d2c5e1266
Reviewed-on: http://review.typo3.org/32568
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] getAvailableWorkspaces called statically 62/32562/2
Wouter Wolters [Fri, 20 Jun 2014 18:28:14 +0000 (20:28 +0200)]
[BUGFIX] getAvailableWorkspaces called statically

Use same call to getAvailableWorkspaces as in
checkAccess.

Resolves: #51420
Releases: 6.3, 6.2
Change-Id: Icbea4611d7bd498e25bf658d7f3fa5a74539f479
Reviewed-on: http://review.typo3.org/32562
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Let Web-View respect TCEMAIN.previewDomain 12/32512/2
Georg Kühnberger [Wed, 27 Aug 2014 14:04:31 +0000 (16:04 +0200)]
[BUGFIX] Let Web-View respect TCEMAIN.previewDomain

Added previewDomain in order to have Web-View functioning in the
same way like Page-Preview does.

Change-Id: I7193cd93a2b9b2d175e162d3fab0b837aefd2487
Fixes: #61226
Related: #30889
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32512
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add missing check in PreparedStatement->execute() 57/32457/2
Jacob Rasmussen [Wed, 27 Aug 2014 15:32:26 +0000 (17:32 +0200)]
[BUGFIX] Add missing check in PreparedStatement->execute()

When using prepared statements for inserts and updates, the
execute method currently fails due to a missing check on the
return value from $this->statement->result_metadata();

Resolves: #61229
Releases: 6.3, 6.2
Change-Id: Ida17f617915c36a0c2e91663eee64b4c358090e2
Reviewed-on: http://review.typo3.org/32457
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] SqlParser: Unify internal usage of tableType/engine 76/32376/2
Stefan Neufeind [Thu, 21 Aug 2014 19:50:05 +0000 (21:50 +0200)]
[TASK] SqlParser: Unify internal usage of tableType/engine

For create-table "tableType" was still used while an alter-table
used "engine".

Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f
Resolves: #61129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32376
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Missing stdWrap for select.recursive TypoScript property 09/32209/2
Matthias Kappenberg [Tue, 13 May 2014 11:09:24 +0000 (13:09 +0200)]
[TASK] Missing stdWrap for select.recursive TypoScript property

Processing stdWrap for the select.recursive TypoScript property
has just been forgotten in the original issue #18822 during the
development of TYPO3 4.6.

Change-Id: I34f2ac45e5112fbcc2becf7936f486f0b53d361a
Resolves: #55707
Releases: 6.3, 6.2, 6.1
Reviewed-on: http://review.typo3.org/32209
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Make context menus work with modules 38/32338/2
Helmut Hummel [Mon, 4 Aug 2014 16:30:44 +0000 (18:30 +0200)]
[BUGFIX] Make context menus work with modules

To make it possible to use the module dispatcher
with a click menu item, it is necessary to add
the CSRF token to the URL of the called click menu
functionality.

Resolves: #60635
Releases: 6.3, 6.2
Change-Id: I0b378c3ba4c22f25b10e39950d08568f608decdb
Reviewed-on: http://review.typo3.org/32338
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] EM using bad indexes 34/32334/2
Stefan Froemken [Mon, 23 Jun 2014 15:16:34 +0000 (17:16 +0200)]
[BUGFIX] EM using bad indexes

The extensionmanager uses bad indexes. It is better
to move col repository to the the end of the indexes.

Resolves: #59809
Releases: 6.3,6.2
Change-Id: I0bb8d5cdfc8591bb35485b204ad5e8dafd1b4d16
Reviewed-on: http://review.typo3.org/32334
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Remove non accessible pages from browse menu 33/32333/2
Kay Strobach [Wed, 14 May 2014 07:26:13 +0000 (09:26 +0200)]
[BUGFIX] Remove non accessible pages from browse menu

This patch enables the browse menu to skip inaccessible items
for prev and next links.

It makes use of the filterMenuPages method, which is already
applied to any kind of menu. Since it has not been applied
to the sections of the browse menu type, which are actually
menus themselves, inaccessible pages made browsing unusable.

This applies to missing translations as well.

Change-Id: I8779731139785dea72b078567912c96e3ad5c7ca
Resolves: #58792
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32333
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix call to undefined function when importing t3x 32/32332/2
René Bigler [Wed, 23 Jul 2014 22:06:38 +0000 (00:06 +0200)]
[BUGFIX] Fix call to undefined function when importing t3x

When importing a t3x file that contains files the function
"getFiles" of the object TYPO3\CMS\Core\Resource\Folder is called
which does not exist.

Resolves: #60474
Releases: 6.3, 6.2
Change-Id: Ibc392bced57a85ad6eae333406ff507af7faefd4
Reviewed-on: http://review.typo3.org/32332
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] QueryGenerator getTreeList negative ids 31/32331/2
Klaas Johan Kooistra [Thu, 31 Jul 2014 09:39:39 +0000 (11:39 +0200)]
[BUGFIX] QueryGenerator getTreeList negative ids

When persistence.recursive is configured when using a command controller no
records can be retrieved because the storagePid is negated in the
AbstractConfigurationManager, while claiming all implementations of getTreeList
support negative ids. Using abs() on the id when it is negative fixes this.
Also see the ContentObjectRenderer implementation of getTreeList

Change-Id: I7732290126a83a79204b8224d52a3cd878360e64
Resolves: #60697
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32331
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Collect correct information on elements in page 26/32326/2
Jigal van Hemert [Fri, 1 Aug 2014 04:55:35 +0000 (06:55 +0200)]
[BUGFIX] Collect correct information on elements in page

In the page module information on neighboring content elements is
collected while building the page layout. This information must
be remembered for other elements on the page instead of generated
new when rendering each element. This makes sure the move buttons and
edit buttons have the correct URLs.

Resolves: #60199
Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I9fec256b145fe8aba229d8b026fba73871942347
Reviewed-on: http://review.typo3.org/32326
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Change fetch of maximum version using LEFT JOIN 88/32288/2
Andreas Fernandez [Fri, 8 Aug 2014 12:03:02 +0000 (14:03 +0200)]
[TASK] Change fetch of maximum version using LEFT JOIN

Currently, the method fetchMaximalVersionsForAllExtensions uses a
subselect to determine the highest available version. This solution is
rather inefficient and incomptabile to DBAL. The query is replaced by
a LEFT JOIN.

Resolves: #60857
Releases: 6.2, 6.3
Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408
Reviewed-on: http://review.typo3.org/32288
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years agoRevert "[BUGFIX] Unified maxitems default value for group fields" 84/32284/2
Wouter Wolters [Fri, 25 Jul 2014 16:03:27 +0000 (18:03 +0200)]
Revert "[BUGFIX] Unified maxitems default value for group fields"

Unexpected behaviour. Default of maxitems in now 1 by default
which doesn't work if you need more items. Previously this
was possible. Revert this to have the old working
behaviour again.

Releases: 6.3,6.2
Resolves: #60263
Reverts: #55731
This reverts commit c578d47617f803c9ea167d88000e63a92c13fa93.

Change-Id: Ice5357aecb1969f11c6821cb81824d2d68200717
Reviewed-on: http://review.typo3.org/32284
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Make sure all new files are indexed 69/32269/2
Frans Saris [Tue, 5 Aug 2014 14:19:19 +0000 (16:19 +0200)]
[BUGFIX] Make sure all new files are indexed

If the FAL indexer scheduler task finds a index record with
same content hash as a new found file the file isn't added to the
index if it isn't marked as missing.

This patch changes the indexer so that new files with same
content hash are added when no index record is found for a missing
file with same content hash.

Resolves: #60764
Releases: 6.3, 6.2
Change-Id: Ifb7f9e6f48ba327c958a7aa0e0b71f0575cabdf7
Reviewed-on: http://review.typo3.org/32269
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Avoid DB error on writing to log 57/32257/2
Markus Klein [Tue, 19 Aug 2014 13:10:33 +0000 (15:10 +0200)]
[BUGFIX] Avoid DB error on writing to log

The writeLog() function of the ErrorHandler tries to log the IP that
caused the error. On CLI there is no IP hence a NULL value is being
tried to insert into the DB, where the DB field is NOT NULL.

Fix this by casting the IP to a string.

Resolves: #61051
Releases: 6.3, 6.2
Change-Id: Id46e97468bf825307258e907811d5f2c77c62161
Reviewed-on: http://review.typo3.org/32257
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] "Illegal mix of collations" in Upgrade Wizard 98/32198/2
Lars Trebing [Tue, 12 Aug 2014 15:20:58 +0000 (17:20 +0200)]
[BUGFIX] "Illegal mix of collations" in Upgrade Wizard

When directly comparing CAST(... AS CHAR) with a CHAR field (including
VARCHAR and TEXT) whose collation isn't the same as that of the database
connection, MySQL gives an error like this:

> Illegal mix of collations (utf8_general_ci,IMPLICIT) and
> (utf8_unicode_ci,IMPLICIT) for operation '<>'

Wrapping the right side of the comparison in CAST(... AS CHAR) as well
keeps the data unchanged while ensuring that both sides have the same
collation.

Change-Id: Icaec66412d6b6441ae30065ffb92565991e9a1e4
Resolves: #36754
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32198
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Refactor file references relations retrieval 57/32157/3
Oliver Hader [Wed, 2 Jul 2014 10:20:27 +0000 (12:20 +0200)]
[TASK] Refactor file references relations retrieval

The retrieval of file references in BackendUtility
is currently bound to the thumbCode() method but
is useful for other components as well.

Resolves: #60054
Releases: master, 6.2
Change-Id: Id92bdeaed24d8924285a640f905ffd55db21da4d
Reviewed-on: http://review.typo3.org/32157
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Simplify record icons in workspace module 56/32156/2
Oliver Hader [Mon, 30 Jun 2014 19:01:20 +0000 (21:01 +0200)]
[TASK] Simplify record icons in workspace module

The record details view renders record icons for both live and
versioned record. However, this representation is shown rather
stand-alone and can be combined with the accordant headers.

Resolves: #60015
Releases: master, 6.2
Change-Id: I2f468a06271f335c491d90d825f7bcef7a9db9f6
Reviewed-on: http://review.typo3.org/32156
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Admin panel shows wrong cache information 68/31868/2
Dmitry Dulepov [Tue, 25 Feb 2014 11:56:28 +0000 (15:56 +0400)]
[BUGFIX] Admin panel shows wrong cache information

When labels were extracted to translation files, a error was made
that changed the meaning of the admin panel entry. But the code
was not modified to reflect the change of the meaning. Thus the
admin panel shows that the page is cached when it is actually not
cached and vice versa. Additionally, it shows 0 and 1 for the
"Page cached" entry. This should be "yes" or "no", not numbers.

Change-Id: I2519593e7da08b71ccdd5d7dc3dd6ced7ecac3ac
Resolves: #56265
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31868
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Extend install tool suhosin checks 52/32152/2
Oliver Hader [Wed, 16 Jul 2014 10:13:35 +0000 (12:13 +0200)]
[TASK] Extend install tool suhosin checks

Extend install tool suhosin checks by
* suhosin.get.max_name_length=200
* suhosin.post.max_name_length=200
* suhosin.request.max_varname_length=200

Resolves: #60356
Releases: 6.2, 6.3
Change-Id: I382e44832918799df58a912e95cd4b0c3f0b81a3
Reviewed-on: http://review.typo3.org/32152
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] JavaScript error in Install Tool 49/32149/3
Wouter Wolters [Fri, 25 Jul 2014 18:06:30 +0000 (20:06 +0200)]
[BUGFIX] JavaScript error in Install Tool

When using toggleButton in "Test setup" a JavaScript
error is thrown because the scrolling handler can only
be used if the fixed footer is available.

Add a check to prevent this JavaScript error.

Resolves: #60577
Releases: 6.3,6.2
Change-Id: Ie7628e83280f6af032b364586cdfb6b386663d9d
Reviewed-on: http://review.typo3.org/32149
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Use defaultMailFromName setting in install tool 51/32151/2
Oliver Hader [Mon, 4 Aug 2014 08:50:36 +0000 (10:50 +0200)]
[BUGFIX] Use defaultMailFromName setting in install tool

The defaultMailFromName setting is not used for sending
the test mails in the install tool.

Resolves: #60758
Releases: master, 6.2
Change-Id: I35e1b887de6b06bb5f301e037d6d412c18ac0b37
Reviewed-on: http://review.typo3.org/32151
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Show properties of stdClass object in <f:debug> 50/32150/2
Christian Weiske [Tue, 12 Aug 2014 12:13:20 +0000 (14:13 +0200)]
[BUGFIX] Show properties of stdClass object in <f:debug>

Using fluid's <f:debug> to get dumps of json_decode()d objects
does not work currently. The DebuggerUtility shows only properties
obtainable via ReflectionClass, which does not work for stdClass objects.

The patch introduces special handling of stdClass objects, using the
properties that actually exist in the object.

Change-Id: I3845178f6defdbceae4b867f45e5080f23443766
Fixes: #60912
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32150
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Updating "current_version" fails with some DBMS 48/32148/2
Andreas Fernandez [Fri, 8 Aug 2014 14:00:19 +0000 (16:00 +0200)]
[BUGFIX] Updating "current_version" fails with some DBMS

Updating the field "current_version" fails with some DMBS because
$uidsOfCurrentVersion has too many elements. This patch chunks
the array into multiple parts and updates the uids in each part.

Resolves: #60859
Releases: 6.2, 6.3
Change-Id: If63f855b250bf7c9b6cd7112f60392cfc8ccfd67
Reviewed-on: http://review.typo3.org/32148
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Correctly parse suhosin configuration 44/32144/2
Markus Klein [Wed, 13 Aug 2014 08:51:22 +0000 (10:51 +0200)]
[BUGFIX] Correctly parse suhosin configuration

The system environment check does not properly parse the suhosin
configuration option for whitelist.
Fix this by changing the code to be less strict about the actual syntax
of this option.

Resolves: #60925
Releases: 6.3, 6.2
Change-Id: I6797a313cedaaf1895cf7b4fddaae9811341006b
Reviewed-on: http://review.typo3.org/32144
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Failing cascaded delete action of localized elements 37/32137/2
Oliver Hader [Wed, 25 Jun 2014 13:50:02 +0000 (15:50 +0200)]
[BUGFIX] Failing cascaded delete action of localized elements

Having a record in live workspace with an accordant localization
leads to the fact that actions to the default language also have
an impact to all localizations.

In a workspace, first deleting the localization, then deleting
the record of the default language, ends up in actually having
reverted the previous deletion of the localization.

The solution is to check for delete placeholders in
DataHandler::deleteL10nOverlayRecords().

Resolves: #59113
Releases: master, 6.2
Change-Id: I888c83a58d591f57bc2ea75a49fa603a56a7f722
Reviewed-on: http://review.typo3.org/32137
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Publishing delete placeholder affects other workspaces 39/32139/2
Oliver Hader [Fri, 11 Jul 2014 08:49:51 +0000 (10:49 +0200)]
[BUGFIX] Publishing delete placeholder affects other workspaces

On publishing a delete placeholder all other versions shall be
deleted as well, since the original record will be deleted after
that action. However, this is only valid for the live workspace
and using the legacy version behavior there.

DataHandler::deleteVersionsForRecord() calls
BackendUtility::selectVersionsOfRecord(), but without the
additional, but required, $workspace argument. Thus, all other
versions in other workspaces are deleted as well. The SQL query
to determine versions needs to be limited to either the live
workspace (for legacy versions) and the current workspace.

Resolves: #60249
Releases: master, 6.2
Change-Id: If90511dc4ac2bc3dde6e58570e6bf10e4ac949db
Reviewed-on: http://review.typo3.org/32139
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Wrong nesting of deleted versioned child records 38/32138/2
Oliver Hader [Wed, 25 Jun 2014 11:19:13 +0000 (13:19 +0200)]
[BUGFIX] Wrong nesting of deleted versioned child records

If deleting an IRRE child reference, the nesting leving in the
workspace module is not shown correctly. The reason for that is,
that the sys_refindex entry points to the live id of the deleted
child record.

This change takes care of correct visualization only, but does not
touch the sys_refindex behavior in this case.

Resolves: #59853
Releases: master, 6.2
Change-Id: I09970d12ba10e528c150275952ec4c9ff8333a0a
Reviewed-on: http://review.typo3.org/32138
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Page Tree not always updated after workspace actions 36/32136/2
Oliver Hader [Mon, 23 Jun 2014 18:34:59 +0000 (20:34 +0200)]
[BUGFIX] Page Tree not always updated after workspace actions

After some workspace actions being performed in the workspaces
module in the TYPO3 Backend, the page tree does not get updated:
* discarding a single workspace version
* performing mass actions which output warnings

Resolves: #59828
Releases: 6.2, master
Change-Id: Ic9fb6613e8647ed351246ea18fcb3696e60ef7b2
Reviewed-on: http://review.typo3.org/32136
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Keep phpunit 4.1 branch 16/32116/2
Christian Kuhn [Tue, 12 Aug 2014 20:22:08 +0000 (22:22 +0200)]
[BUGFIX] Keep phpunit 4.1 branch

composer.json is configured to fetch latest phpunit 4.x branch.
Since 4.2 was just released stable, it will be used now.

phpunit 4.2 now relies on Ocramius/Instantiator to create mocks
that do not call a constructor during instantiation. This project
was created to cope with a recent security fix in PHP unserialize()
that rendered the old way of creating those mocks invalid.

The instantiator project however has issues with PHP versions
5.3 and 5.6 that lead to some failing tests and need further
investigation.

To not run into this during our next merges, the patch nails
phpunit to 4.1.x for now.

Change-Id: I5feb8346e0713fefe6c8fa899c76d3e040dd1973
Resolves: #60923
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32116
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Adjust variable name for install tool password hint 92/31992/2
Anja Leichsenring [Mon, 28 Jul 2014 13:32:16 +0000 (15:32 +0200)]
[BUGFIX] Adjust variable name for install tool password hint

Usage of $TYPO3_CONF_VARS is discouraged, instead
$GLOBALS['TYPO3_CONF_VARS'] should be used. The hint in next to the
install tool login mask spells the discouraged version, which is
corrected with this patch.

Change-Id: Ia7ded107a9b5670c0bc35da92993e84ad45c167e
Releases: master, 6.2
Resolves: #60639
Reviewed-on: http://review.typo3.org/31992
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fetch related records for existing uids only 47/31947/2
Jo Hasenau [Thu, 24 Jul 2014 18:52:12 +0000 (20:52 +0200)]
[BUGFIX] Fetch related records for existing uids only

Before fetching related records from a foreign table, we must ensure
that there is a uid to be considered, since otherwise we will fetch
any record having a 0 value for that field.

There are method calls in the core, that don't provide a uid, so the
default value 0 is used, i.e. when fetching children of translated
gridelements, causing memory outage when tt_content is > 10000 records.

Resolves: #60494
Releases: 6.3, 6.2
Change-Id: I1105964f98f79074bb37dc1921180b493fac4bc6
Reviewed-on: http://review.typo3.org/31947
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Prevent exception in RTE filelinks upgrade wizard 33/31933/2
Mattias Nilsson [Fri, 1 Aug 2014 09:32:24 +0000 (11:32 +0200)]
[BUGFIX] Prevent exception in RTE filelinks upgrade wizard

When using the upgrade wizard for RTE filelinks and the record is
not an array it throws an exception.

To give the end user a better experience an additional condition
for checking that the variable is an array is added.

Resolves: #58898
Releases: 6.3, 6.2
Change-Id: I94ae6cc7272a63fd208267bf375b629cb5a4b2cc
Reviewed-on: http://review.typo3.org/31933
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>