Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Complete datatable structure fe_groups 60/31560/5
Markus Guenther [Thu, 10 Jul 2014 15:24:34 +0000 (17:24 +0200)]
[BUGFIX] Complete datatable structure fe_groups

While creating frontend groups via extbase without any subgroup set,
the record will have the value NULL in the database
for the property subgroup.
This leads to an exception.

This patch only defines TSconfig, subgroups and description not
to accept NULL and to be consistent the tx_extbase_type gets
the default value 0.

Resolves: #60245
Releases: 6.3, 6.2
Change-Id: Ie402d4c47058755efe40cc762f4220ba7dc6b781
Reviewed-on: http://review.typo3.org/31560
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Catch all resource exceptions when parsing RTE links 19/31619/3
Helmut Hummel [Mon, 14 Jul 2014 16:00:30 +0000 (18:00 +0200)]
[BUGFIX] Catch all resource exceptions when parsing RTE links

The RteHtmlParser checks for valid links by trying to retrieve
a file or folder object. The FAL API will throw exceptions
if anything goes wrong with the given path.

Catch all these exceptions to ignore the invalid link
and act the same for invalid paths as for not found files/ folders

Releases: 6.2, 6.3
Resolves: #60316
Change-Id: I0752678eb8ed2b596c3a88536d957ec35c172d7b
Reviewed-on: http://review.typo3.org/31619
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Wrong sys_refindex for deleted child records 90/31590/3
Oliver Hader [Thu, 10 Jul 2014 16:53:03 +0000 (18:53 +0200)]
[BUGFIX] Wrong sys_refindex for deleted child records

Workspace actions using the DataHandler trigger a reprocessing
of the reference index. However, it happened that index entries
of the live workspace have been deleted or modified.

The reason for that is a missing SQL statement to limit those
actions to the current workspace only.

The result can be seen in e.g. the workspace module after
having deleted an IRRE child record and how the nesting could
not be determined correctly for that particular record.

Resolves: #59874
Releases: 6.2, 6.3
Change-Id: I850e2fe88999ce8db280d4ef426e43c85fff06da
Reviewed-on: https://review.typo3.org/31590
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Adjust comment for default HTTP-userAgent 41/31641/2
Stefan Neufeind [Wed, 16 Jul 2014 21:14:06 +0000 (23:14 +0200)]
[BUGFIX] Adjust comment for default HTTP-userAgent

The default userAgent is for example TYPO3/6.2.4

Change-Id: I2412b901a3a42938a433e7d8a414de24587011a3
Resolves: #60365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31641
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Update wrong copyright header in file BrowseLinks.php 31/31731/2
Michael Schams [Wed, 23 Jul 2014 01:54:56 +0000 (11:54 +1000)]
[TASK] Update wrong copyright header in file BrowseLinks.php

A new header in PHP files has been introduced with #59535. This
patch updates the copyright/license header of one file, which still
uses the old, outdated information.

Resolves: #60482
Releases: 6.3, 6.2
Change-Id: I642a4ce13331e2aadbd362988b963a8a5c576a29
Reviewed-on: https://review.typo3.org/31731
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix return value of DatabaseConnection::sql_free_result() 18/31718/3
Stefano Kowalke [Tue, 22 Jul 2014 10:57:50 +0000 (12:57 +0200)]
[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Resolves: #60457
Releases: 6.2, 6.3
Change-Id: I8756d4d2a321adc88738b9ac418207c63b312c86
Reviewed-on: https://review.typo3.org/31718
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix minor issues in functional testing framework 95/31695/2
Helmut Hummel [Sun, 20 Jul 2014 15:03:22 +0000 (17:03 +0200)]
[BUGFIX] Fix minor issues in functional testing framework

The bootstrap for frontend functional tests has some
minor issues, that are now fixed:

* json_decode returns null not false when not successfull
* Properly set the SERVER_PORT
* Use correct array key in error message
* Avoid notices with relative URLs

Releases: 6.2, 6.3
Resolves: #60413
Change-Id: I3ff07f01729d3403374759edbaa5ddcccd2e889a
Reviewed-on: https://review.typo3.org/31695
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] sys_collection_entries column too small 71/31571/3
Wouter Wolters [Thu, 10 Jul 2014 18:37:44 +0000 (20:37 +0200)]
[BUGFIX] sys_collection_entries column too small

Set sys_collection_entries to varchar(64). This is the max
table name length on MySQL.

Resolves: #60180
Releases: 6.3,6.2
Change-Id: I253e6eb6cb35db9e6d13a716bfc5c8d89db4ca7e
Reviewed-on: https://review.typo3.org/31571
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Avoid PHP warning in TypoScriptFrontendController 72/31472/2
Markus Klein [Mon, 7 Jul 2014 21:05:36 +0000 (23:05 +0200)]
[BUGFIX] Avoid PHP warning in TypoScriptFrontendController

TypoScriptFrontendController throws a PHP warning on access to
$BE_USER->user['uid'] which might not be set.
Fix this by simply adding an empty() check.

Resolves: #60126
Releases: 6.3, 6.2
Change-Id: I7005baf73bce55d862b4b6b61697c2aa0a877c7b
Reviewed-on: https://review.typo3.org/31472
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Send test email in Install Tool as HTML 78/31578/3
Wouter Wolters [Thu, 10 Jul 2014 19:27:20 +0000 (21:27 +0200)]
[BUGFIX] Send test email in Install Tool as HTML

Explicitly set the format of the email body to text/html.

Resolves: #60251
Releases: 6.3, 6.2
Change-Id: I350b0f4cb9e69cd20dbd439647f56cd9c641b501
Reviewed-on: https://review.typo3.org/31578
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Menu-links generate two empty spaces at closing anchor 22/25322/4
Tomita Militaru [Tue, 12 Nov 2013 15:52:33 +0000 (17:52 +0200)]
[BUGFIX] Menu-links generate two empty spaces at closing anchor

Checks for ATagParams & access key code before adding empty
spaces between anchor parameters.

Resolves: #50566
Releases: 6.3, 6.2, 6.1
Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb
Reviewed-on: https://review.typo3.org/25322
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Update swiftmailer to 5.2.1 72/31572/3
Wouter Wolters [Thu, 10 Jul 2014 18:54:09 +0000 (20:54 +0200)]
[TASK] Update swiftmailer to 5.2.1

Resolves: #60227
Releases: 6.3
Change-Id: Ic137136005f117ac491cd8897e702f81169a1c0a
Reviewed-on: https://review.typo3.org/31572
Reviewed-by: Michael Bakonyi <m.bakonyi@civit.de>
Tested-by: Michael Bakonyi <m.bakonyi@civit.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[CLEANUP] Final cleanup of TCA Overrides 21/31621/5
Helmut Hummel [Mon, 14 Jul 2014 22:49:33 +0000 (00:49 +0200)]
[CLEANUP] Final cleanup of TCA Overrides

Some of the files still miss the die statement in
the first line. To be consistent, add it to every
file.

One file had a check for TYPO3_MODE === BE which
is wrong in these files because the result is
cached.

If the first hit with empty cache is done in a FE
request, a wrong result would be cached.

Releases: 6.2, 6.3
Resolves: #60317
Change-Id: I839499100da28ba11d5dcbf81fde87b30b61de81
Reviewed-on: https://review.typo3.org/31621
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@mfc-linz.at>
Tested-by: Markus Klein <klein.t3@mfc-linz.at>
5 years ago[CLEANUP] Reformat IRRE JS code 33/29833/6
Andreas Wolf [Sat, 3 May 2014 16:14:05 +0000 (18:14 +0200)]
[CLEANUP] Reformat IRRE JS code

This is an automatic reformat performed by PhpStorm, to get rid of some
ugly constructs like one-line inline methods.

Change-Id: Id24666c673b3822916f9c5233c0b34ce7d38e7aa
Related: #58475
Releases: 6.3
Reviewed-on: https://review.typo3.org/29833
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
5 years ago[TASK] Extend Regular DataHandler functional tests 41/31141/4
Oliver Hader [Wed, 25 Jun 2014 13:02:24 +0000 (15:02 +0200)]
[TASK] Extend Regular DataHandler functional tests

* add third tt_content element with localization in live context
* add new tt_content delete placeholder in different workspace
* populate changes to all scenarios in live and workspace context

Releases: 6.2, 6.3
Resolves: #59881
Change-Id: I644e264048a5c33c0a613d5f8440975cabd40721
Reviewed-on: https://review.typo3.org/31141
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use PATH_site in cache identifier for package cache 65/31565/5
Helmut Hummel [Thu, 10 Jul 2014 16:10:10 +0000 (18:10 +0200)]
[BUGFIX] Use PATH_site in cache identifier for package cache

The package cache writes paths to extension directories
(TYPO3_LOADED_EXT) into the cache.

This will result in wrong caches when the same
TYPO3 instance is called from a different absolute
directory e.g. from a different mount or symlink.

To avoid this, the cache identifier now includes
PATH_site which is the current absolute path
of the TYPO3 instance.

Additionally we now only include the modification
time of the package states file instead of the
md5 of the complete content into account, which should
be much faster and also enough.

Resolves: #58288
Releases: 6.2, 6.3
Change-Id: I7c8de41c608beab282f2b8bbeab39f257a9a6a6f
Reviewed-on: https://review.typo3.org/31565
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Clarify exception message for addPlugin() 56/31556/3
Helmut Hummel [Thu, 10 Jul 2014 13:52:52 +0000 (15:52 +0200)]
[TASK] Clarify exception message for addPlugin()

Add verbosity to the exception message to make it
more clear what is going wrong.

Releases: 6.2, 6.3
Resolves: #60225
Change-Id: I7bb4a16ff94d05b8b97633383d42c61aa600b1cf
Reviewed-on: https://review.typo3.org/31556
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Christian Kuhn
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix page module styling in Languages view 98/31498/4
Tomita Militaru [Tue, 8 Jul 2014 09:44:18 +0000 (12:44 +0300)]
[BUGFIX] Fix page module styling in Languages view

Change in height of table header row for Languages view.

Resolves: #56714
Releases: 6.3, 6.2
Change-Id: Ic6bab8a99695798ecfc115209aec41e241870925
Reviewed-on: https://review.typo3.org/31498
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Collapse icon for accordion not centered in Install Tool 24/31524/2
Wouter Wolters [Tue, 8 Jul 2014 21:24:04 +0000 (23:24 +0200)]
[BUGFIX] Collapse icon for accordion not centered in Install Tool

Resolves: #60192
Releases: 6.3,6.2
Change-Id: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0
Reviewed-on: https://review.typo3.org/31524
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Log errors after initial t3d import also if pages are created 01/30101/9
Marc Bastian Heinrichs [Wed, 14 May 2014 10:33:07 +0000 (12:33 +0200)]
[TASK] Log errors after initial t3d import also if pages are created

Errors are only logged if no pages are created on initial data.t3d
import. They should be logged generally.

Resolves: #58798
Releases: 6.3, 6.2
Change-Id: Ia859d12ec567a1b64bb9b65dd41f5ba996de3139
Reviewed-on: https://review.typo3.org/30101
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup to CacheBackend patch 20/31520/2
Markus Klein [Tue, 8 Jul 2014 21:00:10 +0000 (23:00 +0200)]
[BUGFIX] Followup to CacheBackend patch

Re-add a missing use statement that vanished during rebase.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d
Reviewed-on: https://review.typo3.org/31520
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Too many tags by identifier in CacheBackends 67/30767/13
Alexander Opitz [Tue, 17 Jun 2014 07:58:32 +0000 (09:58 +0200)]
[BUGFIX] Too many tags by identifier in CacheBackends

This applies to Apc/Memcached/Wincache/Xcache backends.

After an array_merge the values aren't unique. This leads to duplicate
tags per identifier. This patch changes that and also moves the
findTagsByIdentifier call out of the foreach loop.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa
Reviewed-on: https://review.typo3.org/30767
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal() 03/31503/3
Markus Klein [Tue, 8 Jul 2014 10:55:07 +0000 (12:55 +0200)]
[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal()

Fix a wrong type hint for the second parameter in
InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of
type integer and not array.

Resolves: #60179
Releases: 6.3, 6.2
Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539
Reviewed-on: https://review.typo3.org/31503
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Superfluous SQL queries on copying records 10/31310/9
Oliver Hader [Thu, 3 Jul 2014 11:12:20 +0000 (13:12 +0200)]
[BUGFIX] Superfluous SQL queries on copying records

On copying a page in the backend there are lots of superfluous
SQL queries containing "... WHERE uid=0". The reason for that
is, that DataHandler::recordInfo() is called for each field
which then tries to fetch the database record for the given
uid "NEW...". Casting the new record placeholder to an integer
value ends up with the "uid=0" condition.

In a test with copying a page with some sub-pages, there was a
total of about 1300 SQL queries, 300 of them have been those
superfluous "uid=0" SELECT statements.

Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482
Resolves: #58357
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31310
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Followup to read only filemounts 00/31500/2
Helmut Hummel [Tue, 8 Jul 2014 09:57:28 +0000 (11:57 +0200)]
[BUGFIX] Followup to read only filemounts

Fix tests by provide proper mocking of the storage

Resolves: #49391
Resolves: #57979
Releases: 6.2, 6.3
Change-Id: I2cd9e1bcffd082e861a7c8ae2fba6c68b461a8cc
Reviewed-on: https://review.typo3.org/31500
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Re-introduce read-only file mounts 85/30685/19
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[BUGFIX] Re-introduce read-only file mounts

This re-introduces the read-only file mounts that were silently dropped
in TYPO3 6.0.

File mounts can be added by User TSconfig the same way they were added
in TYPO3 4.x. But since FAL added Storages, the storage needs to be
configurable.

options.folderTree.altElementBrowserMountPoints = 3:/test

This adds the folder "test" of storage 3 as read-only mount in the File
List and the Element Browser. The old syntax is still supported:

options.folderTree.altElementBrowserMountPoints = documents

If no storage is configured, it is assumed that the folder is in the
default storage.

Resolves: #49391
Resolves: #57979
Documentation: #59648
Releases: 6.3, 6.2
Change-Id: I648c8ae15d4add98cd55e2f9c27d89d8e49d6152
Reviewed-on: https://review.typo3.org/30685
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Movements pollute colPos value of content elements 01/25001/5
Nicole Cordes [Tue, 8 Jul 2014 07:53:33 +0000 (09:53 +0200)]
[BUGFIX] Movements pollute colPos value of content elements

Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information
concerning previous and next content elements in one row is messed up.
This patch helps to build information which depends on colPos again and
prevents records being moved to another column.

Resolves: #48939
Resolves: #49055
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22
Reviewed-on: https://review.typo3.org/25001
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update phpdoc @return of exec_SELECTgetSingleRow() 89/31489/2
Markus Klein [Tue, 8 Jul 2014 08:12:21 +0000 (10:12 +0200)]
[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Resolves: #60172
Releases: 6.3, 6.2
Change-Id: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
Reviewed-on: https://review.typo3.org/31489
Reviewed-by: Thomas Löffler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Sascha Egerer
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 71/31171/3
Alexander Bigga [Fri, 27 Jun 2014 12:57:39 +0000 (14:57 +0200)]
[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1

Using the TCA select renderMode=tree with the option
minitems=1 AND maxitems=1
leads to two bugs since TYPO3 4.5:

First #48943
* A new table entry won't mark the field selection as required. The yellow
  question mark is missing and you can save the entry.
* Once you select a checkbox in the tree and unselect it again, the
  required-check is working.

Second: #31637
* You load an existing table entry with a selection of e.g. a category
  which has been hidden or deleted. The selected checkbox won't be shown,
  but the required-check fails.
* Even worse: You can't select another category as the form thinks you
  have already selected one item (maxitem=1). You can fix this only by
  manipulating the database directly.

The reason for these bugs can be found in
DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
foreign_table element ids for the tree will be fetched by getDataIdList().
These elements won't be checked whether they are valid (hidden/deleted).
This check is done in selectAddForeign() which is used for maxitems > 1.

The patch uses the same procedure as for maxitems > 1 in case
of renderMode = tree.

Resolves: #48943
Resolves: #31637
Releases: 6.3, 6.2, 6.1
Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
Reviewed-on: https://review.typo3.org/31171
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Reviewed-by: Nicole Cordes
Tested-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix suggest wizard item selection 13/30513/6
Benoit Chenu [Mon, 2 Jun 2014 11:44:36 +0000 (13:44 +0200)]
[BUGFIX] Fix suggest wizard item selection

When selecting an item in a suggest list, the first label is always
taken instead of the clicked one.

Resolves: #55835
Releases: 6.3, 6.2
Change-Id: I7590cb290ee19fd807260ef5767805a23ef088b0
Reviewed-on: https://review.typo3.org/30513
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] LiveSearchToolbarItem not initialized correctly 75/31475/3
Gernot Schulmeister [Mon, 7 Jul 2014 21:33:42 +0000 (23:33 +0200)]
[BUGFIX] LiveSearchToolbarItem not initialized correctly

Initialising the LiveSearchToolbarItem class with two leading
backslashes \\ prevents XClasses of the LiveSearchToolbarItem
to be found by the GeneralUtility:makeInstance() function.

Resolves: #59959
Releases: 6.3, 6.2
Change-Id: Iab6bb31379090fa5770ed20f8fa8113e61071fe0
Reviewed-on: https://review.typo3.org/31475
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix position of buttons in RTE full screen mode 74/31474/2
Markus Klein [Mon, 7 Jul 2014 21:20:49 +0000 (23:20 +0200)]
[BUGFIX] Fix position of buttons in RTE full screen mode

Update the HTML markup for the action buttons in the RTE full screen
view to properly position the buttons there.

Releases: 6.3, 6.2
Resolves: #60119
Change-Id: I0c06dd5fa5a7975a3ddcddb58c3b44d41da2192a
Reviewed-on: https://review.typo3.org/31474
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor extension upload controller 50/31250/6
Nicole Cordes [Fri, 4 Jul 2014 22:17:32 +0000 (00:17 +0200)]
[TASK] Refactor extension upload controller

The upload and install functions are needed by the extension coreapi.
In order to support the extension, the UploadExtensionFileController
is refactored and necessary functions are extracted to public functions.

Resolves: #59999
Releases: 6.2, 6.3
Change-Id: I21e734d1ecae2e7c8e7c3f72e129ef1f57532886
Reviewed-on: https://review.typo3.org/31250
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere 95/26695/7
Julian Hofmann [Wed, 8 Jan 2014 17:22:33 +0000 (18:22 +0100)]
[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Resolves: #54843
Releases: 6.3, 6.2
Documentation: #60160
Change-Id: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
Reviewed-on: https://review.typo3.org/26695
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Move signals to own emit functions 32/31432/2
Nicole Cordes [Mon, 7 Jul 2014 07:49:33 +0000 (09:49 +0200)]
[TASK] Move signals to own emit functions

Two new signals were introduced with the patch
https://review.typo3.org/#/c/27746/. This patch moves the dispatch of
the signals into own functions to improve the tracing of signals.

Resolves: #60133
Releases: 6.3, 6.2
Change-Id: Iecb7ff25ec31556c939dff6b0cf8749ebd3ff997
Reviewed-on: https://review.typo3.org/31432
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Report migration errors in TceformsUpdateWizard 00/29100/3
Steffen Müller [Wed, 2 Apr 2014 20:38:31 +0000 (22:38 +0200)]
[BUGFIX] Report migration errors in TceformsUpdateWizard

TceformsUpdateWizard should report errors if a migration
failed due to a missing source file.

Resolves: #57575
Releases: 6.3, 6.2
Change-Id: I68af9a5155f7d6190a22cc4986ef4a467b747737
Reviewed-on: https://review.typo3.org/29100
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Detect missing files in empty storage 34/30534/4
Robert Vock [Tue, 3 Jun 2014 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Detect missing files in empty storage

Improve the check for missing files by properly treating
the case when a storage is empty.

Change-Id: I8fba9be2622a4cd742c0065b68a8daf77f8a484a
Resolves: #54414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30534
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Wrong image reference handling during flexform copying 84/30884/3
Alexey Gafiulov [Thu, 19 Jun 2014 16:12:42 +0000 (22:12 +0600)]
[BUGFIX] Wrong image reference handling during flexform copying

References in flexforms having type=inline are not processed correctly
during copy.

Fix this by properly applying the reference field check.

Resolves: #59664
Releases: 6.3, 6.2, 6.1
Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
Reviewed-on: https://review.typo3.org/30884
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add signal slots to SoftReferenceIndex 46/27746/4
Alexander Stehlik [Mon, 10 Mar 2014 09:42:59 +0000 (10:42 +0100)]
[FEATURE] Add signal slots to SoftReferenceIndex

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Resolves: #21396
Releases: 6.3, 6.2
Change-Id: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f
Reviewed-on: https://review.typo3.org/27746
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest wizard doesn't work in page flexforms 97/30797/5
Bernhard Kraft [Wed, 18 Jun 2014 08:04:28 +0000 (10:04 +0200)]
[BUGFIX] Suggest wizard doesn't work in page flexforms

When using the suggest wizard from within a flexform in a page it
doesn't work properly. The $row variable was only set when processing
tables other than pages but is required for proper flexform handling.

Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab
Resolves: #59642
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/30797
Reviewed-by: Marcin Sągol
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove non-needed URL parameter for standard search 14/25314/3
Tomita Militaru [Tue, 12 Nov 2013 14:57:56 +0000 (16:57 +0200)]
[BUGFIX] Remove non-needed URL parameter for standard search

Removes parameter to prevent duplicate content, speaking
url problems and overloaded urls.

Resolves: #51189
Releases: 6.3, 6.2, 6.1
Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d
Reviewed-on: https://review.typo3.org/25314
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Optimize invocation of cObj::checkIf 43/26943/5
Oliver Hader [Mon, 20 Jan 2014 15:52:37 +0000 (16:52 +0100)]
[TASK] Optimize invocation of cObj::checkIf

The stdWrap property "if" can be used to allow output only if a
defined criterion is met. However, the checkIf() method gets
called even if the property is not set in TypoScript.

Fix this by adding a quick empty() check to all calls.
Also optimizes the code structure to exit early in case the if
does not evaluate to TRUE.

Resolves: #55173
Releases: 6.3, 6.2
Change-Id: Ie1178a5df2e98fd19b848aa2300c901c1200f555
Reviewed-on: https://review.typo3.org/26943
Reviewed-by: Simon Schaufelberger
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Support dots in page.meta 92/31192/6
Markus Klein [Sat, 28 Jun 2014 14:56:36 +0000 (16:56 +0200)]
[BUGFIX] Support dots in page.meta

The parsing of the meta tag TypoScript configuration does a too greedy
check on dots and hence breaks support for examples like DC.author.

Fix this by completely refactoring the meta tag generation and add unit
tests.

Resolves: #59890
Releases: 6.3, 6.2
Change-Id: Id534efff30903d96aee1677989d1bd6d3dd1644b
Reviewed-on: https://review.typo3.org/31192
Reviewed-by: Fabien Udriot
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Felogin improperly merges flexforms and TS conf 81/31081/4
Markus Klein [Mon, 23 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] Felogin improperly merges flexforms and TS conf

There are two options to show the forgot password link in FE:
 * TypoScript: showForgotPasswordLink
 * Flexforms: showForgotPassword

The flexform values are merged with the TS values, but as these config
options are named differently, they are not overridden properly.

With #50138 the forgot-form is now only displayed when showForgotPassword
is set, hence the TypoScript configuration is not taken into account.

Since we can neither change the flexform, nor the TypoScript, we need to
merge the values in the flexform-merge code part.

This patch reduces the code to use only the documented TypoScript option.

Resolves: #59821
Releases: 6.3, 6.2
Change-Id: I77c391910561a304649d4c747ec868388be3f1a5
Reviewed-on: https://review.typo3.org/31081
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[CLEANUP] Remove comment header in ext_emconf 05/31405/2
Christian Kuhn [Sun, 6 Jul 2014 16:43:27 +0000 (18:43 +0200)]
[CLEANUP] Remove comment header in ext_emconf

The "do not touch me" comment header in ext_emconf.php files
of system extensions are misleading since we are editing those
files manually for years now. Remove those headers.

Change-Id: I27f6253effa54dae7f92170175e7705cc706d03a
Resolves: #60129
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31405
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.3 02/31402/2
Christian Kuhn [Sun, 6 Jul 2014 16:23:19 +0000 (18:23 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.3

apc on cli seems to be flaky, disable this php module for
now to see if that help stabilizing travis-ci builds again.

Change-Id: I7e6caa6c2c2d70a26e217e8fbf10a2d79b01f335
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31402
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] ext_emconf files 97/31397/4
Christian Kuhn [Sun, 6 Jul 2014 15:19:31 +0000 (17:19 +0200)]
[CLEANUP] ext_emconf files

Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.

Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31397
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Ensure all variables are set before usage 20/31020/9
Markus Klein [Sun, 22 Jun 2014 00:46:21 +0000 (02:46 +0200)]
[CLEANUP] Ensure all variables are set before usage

This also applies for return values of functions. These are corrected
too if necessary.

Furthermore, some code style updates are done for better readability.

This patch contains no functional changes.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I1e26e0516d79324244948caf091cd836d5f8d3c6
Reviewed-on: https://review.typo3.org/31020
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove unused EM_CONF variables 46/29746/6
Benjamin Mack [Wed, 30 Apr 2014 13:36:24 +0000 (15:36 +0200)]
[TASK] Remove unused EM_CONF variables

The ext_emconf.php are created when e.g. an extension
is downloaded from TER. Based on the data from TER the
extension information is built, but not needed anymore.

There are some values that are not in use in the current
6.2 system anymore, and just make ext_emconf.php
more complicated, as the current EM only runs with TER2
anyway.

The patch cleans up values when writing ext_emconf.php
for an extension. As soon as only 6.2+ is supported, the
TER could remove the values to be shipped in the
xml.gz files, thus saving resources (not much but I'm in
favor of a clean system).

Releases: 6.2,6.3
Resolves: #58365
Change-Id: Ic15247f57b557971e9a7c608e4dadd2080e976a3
Reviewed-on: https://review.typo3.org/29746
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ClearCacheOnLoad camelCased does not work 94/31394/2
Susanne Moog [Sun, 6 Jul 2014 15:10:10 +0000 (17:10 +0200)]
[BUGFIX] ClearCacheOnLoad camelCased does not work

The em_conf setting "clearCacheOnLoad" is both used in
camelCase and lower case but only the latter one is
supported by the extension manager.

Change-Id: I637ace3bef07353b7a44c991f79d01da8e8b5547
Fixes: #60127
Releases: 6.2,6.3
Reviewed-on: https://review.typo3.org/31394
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Replace module token in be shortcut returnUrl 86/31386/3
Frans Saris [Sun, 6 Jul 2014 12:34:46 +0000 (14:34 +0200)]
[BUGFIX] Replace module token in be shortcut returnUrl

During the addition of the token check for mod.php the token
in the BE shortcut url was already replaced (#56359) but
not in the returnUrl parameter that can be present.

This patch makes sure that also the module token is replaced in
the returnUrl param.

Resolves: #59963
Releases: 6.3, 6.2
Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c
Reviewed-on: https://review.typo3.org/31386
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Allow colon in TypoScript key 93/31193/7
Markus Klein [Sat, 28 Jun 2014 15:19:32 +0000 (17:19 +0200)]
[BUGFIX] Allow colon in TypoScript key

The TypoScript parser does not properly parse the := operator.
It searches for : only and hence wrongly breaks a TypoScript key apart.

Fix this by detecting the full operator sequence ":=", do not rely
on ":" only.

Resolves: #59965
Releases: 6.3, 6.2
Change-Id: I6401c87b45432d4d74c4092edeb333d4d9d5914e
Reviewed-on: https://review.typo3.org/31193
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly 01/20901/4
Wouter Wolters [Sat, 18 May 2013 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Change-Id: Ieda08a1df71117b5ac90f2c68260f5171570ff63
Resolves: #16392
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/20901
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Sysext form uses old TCA 13/31113/3
Markus Klein [Tue, 24 Jun 2014 13:38:46 +0000 (15:38 +0200)]
[BUGFIX] Sysext form uses old TCA

Sysext form overrides TCA for tt_content with some completely outdated
configuration.

Fix this to the new TCA of tt_content.

Resolves: #59837
Releases: 6.3, 6.2
Change-Id: Ic2d1d75b767925755160bd337ec6fdfbddc308ab
Reviewed-on: https://review.typo3.org/31113
Reviewed-by: Marcin Sągol
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Extensionmanager: Dependency errors are not reset 30/31330/2
Nicole Cordes [Fri, 4 Jul 2014 22:34:19 +0000 (00:34 +0200)]
[BUGFIX] Extensionmanager: Dependency errors are not reset

Due to changes in https://review.typo3.org/#/c/29845/ dependency errors
are collected and if one error occurred it is returned for every check
regardless of the key. This patch adds a reset for the error array on
every new dependency check.

Resolves: #60106
Releases: 6.3, 6.2
Change-Id: Id734ba1fe8981ffd270d79d4971ac9de9b72b4b4
Reviewed-on: https://review.typo3.org/31330
Reviewed-by: Oliver Klee
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Update ADOdb to 5.19 63/31163/3
Andreas Fernandez [Thu, 26 Jun 2014 15:46:52 +0000 (17:46 +0200)]
[TASK] Update ADOdb to 5.19

Updated ADOdb from 5.18 to 5.19 fixing several bugs.

Resolves: #59911
Releases: 6.3, 6.2
Change-Id: I3173c8b14b3d653f29d4992029dbaa9129200fa2
Reviewed-on: https://review.typo3.org/31163
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Missing label for EM "update"-dependency 54/31354/3
Markus Klein [Sat, 5 Jul 2014 14:57:34 +0000 (16:57 +0200)]
[BUGFIX] Missing label for EM "update"-dependency

Add the missing label for "update"-dependencies to EM locallang.xlf

Resolves: #59974
Releases: 6.3, 6.2
Change-Id: I8e8f1681cd486c2fbb7491c41c5f711c86e64ed0
Reviewed-on: https://review.typo3.org/31354
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Extbase mvc classes 42/29342/10
Markus Klein [Thu, 10 Apr 2014 15:43:25 +0000 (17:43 +0200)]
[CLEANUP] Extbase mvc classes

Add lots of type hints and some checks if the correct class is present.

Resolves: #57812
Releases: 6.3
Change-Id: I6f5e4d30dfbfb73cedf10c0efdbb271ee3bdcecf
Reviewed-on: https://review.typo3.org/29342
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Correctly check stack in DownloadQueue 14/31214/6
Markus Klein [Sun, 29 Jun 2014 09:43:34 +0000 (11:43 +0200)]
[BUGFIX] Correctly check stack in DownloadQueue

The extension manager's DownloadQueue does now properly check
the stack when adding extensions to the queue.

Resolves: #59975
Releases: 6.3, 6.2, 6.1
Change-Id: I90e9699608c6d0f3ebd44dd54eb0f471a4e082d9
Reviewed-on: https://review.typo3.org/31214
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix position of TCEforms required field icon 30/31130/4
Frans Saris [Wed, 25 Jun 2014 08:08:17 +0000 (10:08 +0200)]
[BUGFIX] Fix position of TCEforms required field icon

If a palette is placed directly after a form field the icon to
open the pallete is placed inside the formfield wrapper. As result
the position of the required field icon is wrong.

This patch moves the palette icon outside of the wrapper.

Resolves: #59865
Releases: 6.2, 6.3
Change-Id: I35a3d4728a0dfb5ed315731366cc5ca04a7aa87e
Reviewed-on: https://review.typo3.org/31130
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incomplete mock in ext:install 55/31355/4
Christian Kuhn [Sat, 5 Jul 2014 16:01:21 +0000 (18:01 +0200)]
[BUGFIX] Incomplete mock in ext:install

"ExtensionCompatibilityTesterTests" triggers loadBaseTca() that
loads TCA and TCA overrides of all active packages. Since the
unit test package manager activates all extensions found, this
may lead to unexpected effects with extensions hanging around
in typo3conf/ext.
The patch creates a backup of the package manager and mocks it
properly in some tests.

Change-Id: Ia5b1ccb449f1611837e6436cab226820b22a9047
Resolves: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31355
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warning in addPlugin() 57/31357/2
Christian Kuhn [Sat, 5 Jul 2014 16:10:42 +0000 (18:10 +0200)]
[BUGFIX] Warning in addPlugin()

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31357
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Clean up buildBaseTcaFromSingleFiles() 56/31356/2
Christian Kuhn [Sat, 5 Jul 2014 16:07:17 +0000 (18:07 +0200)]
[TASK] Clean up buildBaseTcaFromSingleFiles()

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31356
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Removed clickMenu code around header icon in info window 83/30883/3
Frans Saris [Thu, 19 Jun 2014 15:58:41 +0000 (17:58 +0200)]
[BUGFIX] Removed clickMenu code around header icon in info window

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/30883
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Change check for TYPO3_MODE 38/31338/4
Wouter Wolters [Sat, 5 Jul 2014 12:19:05 +0000 (14:19 +0200)]
[TASK] Change check for TYPO3_MODE

Change check for TYPO3_MODE:

if (!defined('TYPO3_MODE')) {
die('Access denied.');
}

to

defined('TYPO3_MODE') or die();

Resolves: #60112
Releases: 6.3
Change-Id: I2b4493509c912f620a993dc4ba69c4449fcac04d
Reviewed-on: https://review.typo3.org/31338
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides. 49/30649/10
Anja Leichsenring [Tue, 10 Jun 2014 19:01:45 +0000 (21:01 +0200)]
[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30649
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides 43/30943/3
Anja Leichsenring [Fri, 20 Jun 2014 14:57:30 +0000 (16:57 +0200)]
[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30943
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Empty class selector crashes Update image 69/31169/2
Francois Suter [Fri, 27 Jun 2014 13:40:35 +0000 (15:40 +0200)]
[BUGFIX] Empty class selector crashes Update image

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31169
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup EXT:version 59/31059/5
Wouter Wolters [Sun, 22 Jun 2014 20:56:32 +0000 (22:56 +0200)]
[TASK] Cleanup EXT:version

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31059
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Update jQuery to 1.11.1 38/31038/3
Wouter Wolters [Sun, 22 Jun 2014 10:15:21 +0000 (12:15 +0200)]
[TASK] Update jQuery to 1.11.1

Resolves: #59791
Releases: 6.3
Change-Id: I71e998b693144e313b1d8dbcf70b488ef143141a
Reviewed-on: https://review.typo3.org/31038
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Updating deactivated extensions installs them 31/31331/2
Nicole Cordes [Fri, 4 Jul 2014 22:59:48 +0000 (00:59 +0200)]
[BUGFIX] Updating deactivated extensions installs them

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31331
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides. 29/30629/9
Jost Baron [Mon, 9 Jun 2014 10:15:55 +0000 (12:15 +0200)]
[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/30629
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename 62/31262/3
Jost Baron [Tue, 1 Jul 2014 12:22:31 +0000 (14:22 +0200)]
[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31262
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Use string as constant name in FormProtectionFactory. 63/31263/3
Jost Baron [Tue, 1 Jul 2014 12:31:35 +0000 (14:31 +0200)]
[BUGFIX] Use string as constant name in FormProtectionFactory.

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31263
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides 52/30652/11
Anja Leichsenring [Tue, 10 Jun 2014 20:31:58 +0000 (22:31 +0200)]
[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30652
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides 50/30650/7
Anja Leichsenring [Tue, 10 Jun 2014 19:56:42 +0000 (21:56 +0200)]
[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30650
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tooltip for a shortcut in list view shows id=0 28/31328/2
Wouter Wolters [Fri, 4 Jul 2014 19:02:17 +0000 (21:02 +0200)]
[BUGFIX] Tooltip for a shortcut in list view shows id=0

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Give extension key to addPlugin() in registerPlugin() 33/31333/3
Christian Kuhn [Sat, 5 Jul 2014 11:44:19 +0000 (13:44 +0200)]
[BUGFIX] Give extension key to addPlugin() in registerPlugin()

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31333
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Unit tests to addPlugin() 34/31334/4
Anja Leichsenring [Sat, 5 Jul 2014 11:51:35 +0000 (13:51 +0200)]
[TASK] Unit tests to addPlugin()

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31334
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Stupid array assignment 21/31321/4
Sascha Egerer [Fri, 4 Jul 2014 12:40:31 +0000 (14:40 +0200)]
[CLEANUP] Stupid array assignment

There are two places where a new item is assigned
to an array with `$myArray[] .= ''`.
This would do the same as `$myArray[] = ''` because
it always adds a new item to the array.

Resolves: #60101
Releases: 6.3
Change-Id: I122b0fe80b1ac026c0c9f353446bb48834eba74e
Reviewed-on: https://review.typo3.org/31321
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Fix property access for ObjectStorage 28/30628/5
Markus Klein [Mon, 9 Jun 2014 10:02:51 +0000 (12:02 +0200)]
[BUGFIX] Fix property access for ObjectStorage

When enabling access to the content of ObjectStorages by
integer number, it was overlooked that property access might
be desired too, which has also been working before.

Fix this by not aborting the access when addressing a
non-integer property on ObjectStorages.

Resolves: #59412
Releases: 6.3, 6.2
Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e
Reviewed-on: https://review.typo3.org/30628
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Two png files should have filemode 664 94/31294/2
Martin Bless [Wed, 2 Jul 2014 16:33:24 +0000 (18:33 +0200)]
[BUGFIX] Two png files should have filemode 664

Resolves: #60065
Releases: 6.2
Change-Id: I27917fed2a65f9810176b4afa716e8e752d7eff1
Reviewed-on: https://review.typo3.org/31294
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create a Getter for CacheManager inside Datahandler 88/31288/2
Stefano Kowalke [Wed, 2 Jul 2014 11:26:16 +0000 (13:26 +0200)]
[TASK] Create a Getter for CacheManager inside Datahandler

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Resolves: #60059
Releases: 6.2, 6.3
Change-Id: I9f83ec017da94778e542410cc9d03faacddc245c
Reviewed-on: https://review.typo3.org/31288
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Workspace not always applied in RelationHandler queries 85/31285/3
Oliver Hader [Wed, 2 Jul 2014 09:28:32 +0000 (11:28 +0200)]
[BUGFIX] Workspace not always applied in RelationHandler queries

The possibly submitted value to RelationHandler::setWorkspaceId()
is not used for SQL queries to read IRRE foreign field relations.
In that case the current $BE_USER->workspace value is used which
might be different to the requested workspace id.

Resolves: #60053
Releases: 6.2, 6.3
Change-Id: Ib01e4df798ff2e1fcc8c29997f6effb814dc4344
Reviewed-on: https://review.typo3.org/31285
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Create workspace label placeholder that matches field conditions 35/22935/11
Sascha Egerer [Wed, 7 Aug 2013 17:10:04 +0000 (19:10 +0200)]
[BUGFIX] Create workspace label placeholder that matches field conditions

If a workspace placeholder record is generated the field, that
is configured as label for a table, is filled with a placeholder.
This is a hardcoded string.
If database field does not allow strings (integer, double...)
a TYPO3 warning is displayed. "... Propably value mismatch ...".
This message is very confusing because the user does not know
where it comes from.

The label should be evaluated against the TCA eval configuration
before it is written to the database.

Resolves: #31757
Releases: 6.3, 6.2, 6.1
Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9
Reviewed-on: https://review.typo3.org/22935
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
5 years ago[BUGFIX] IRRE records are listed comma separated 67/30967/3
Thomas Löffler [Fri, 20 Jun 2014 19:15:14 +0000 (21:15 +0200)]
[BUGFIX] IRRE records are listed comma separated

IRRE records with foreign_field instead of MM table
are now listed as a comma separated list instead
of wrongly using the number of records as the UID.

Change-Id: Ib1434561ee823d931cc983e103fb58490ca83719
Resolves: #59671
Releases: 6.3,6.2
Reviewed-on: https://review.typo3.org/30967
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char 75/31175/3
Frans Saris [Fri, 27 Jun 2014 19:49:26 +0000 (21:49 +0200)]
[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Resolves: #59950
Releases: 6.3, 6.2
Change-Id: I65d89ab741ae77f5bbef9421923b3878f2295570
Reviewed-on: https://review.typo3.org/31175
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix RTE width 54/30954/2
Markus Klein [Fri, 20 Jun 2014 16:58:45 +0000 (18:58 +0200)]
[BUGFIX] Fix RTE width

edit_wideDocument option has been removed with #57295 but it was forgotten
to adjust RTE accordingly.

Wide screens are default now, so we remove the check for this option
also in RTE. Furthermore the settings for small screens are superfluous
too.

Documentation is adjusted as well.

Resolves: #59692
Releases: 6.3, 6.2
Change-Id: I9bb5fc2a892f3de446137856e9fa18317f40b5c1
Reviewed-on: https://review.typo3.org/30954
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Frans Saris
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Extbase reflection classes 44/29444/7
Markus Klein [Sun, 13 Apr 2014 15:11:48 +0000 (17:11 +0200)]
[CLEANUP] Extbase reflection classes

Remove unnessessary full qualified class names.
Cleanup docheaders.

Resolves: #57878
Releases: 6.3
Change-Id: I5bcdb80c27da1698fd1446a001907d83c6845507
Reviewed-on: https://review.typo3.org/29444
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add action selector in toolbar in workspaces menu 58/31158/4
Oliver Hader [Thu, 26 Jun 2014 09:42:45 +0000 (11:42 +0200)]
[TASK] Add action selector in toolbar in workspaces menu

Currently there are two selectors in the bottom toolbar of
the workspace module. One to handle stage changes on selected
elements and one for mass actions (publish, swap, discard) for
the whole workspace. To circumvent this, an additional selector
shall be added for record selections.

Resolves: #59898
Releases: 6.2, 6.3
Change-Id: I5991cc16a65ba5ac473ec380f534379ec925cad3
Reviewed-on: https://review.typo3.org/31158
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Update phpdoc for all FormEngine members 19/31019/6
Markus Klein [Sat, 21 Jun 2014 23:17:20 +0000 (01:17 +0200)]
[CLEANUP] Update phpdoc for all FormEngine members

Furthermore ensure the initial values are correct.
All usages of the members have been checked such that no violation can
happen if the initial values have been modified.

This patch contains no change in functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I4566849bb930535b9fef8d38dba940d6a6fd86cc
Reviewed-on: https://review.typo3.org/31019
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] FormEngine: Use getters for global objects 17/31017/6
Markus Klein [Sat, 21 Jun 2014 22:29:21 +0000 (00:29 +0200)]
[CLEANUP] FormEngine: Use getters for global objects

Introduce getters for global objects like TYPO3_DB or LANG.
This patch does not change any functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: Ia9a4f3adc656927467f2f51207396d9a41befe8c
Reviewed-on: https://review.typo3.org/31017
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[FEATURE] Introduce afterPersistObjetct signal slot 38/31238/4
Nico de Haen [Sun, 29 Jun 2014 22:11:09 +0000 (00:11 +0200)]
[FEATURE] Introduce afterPersistObjetct signal slot

At the moment we only have an afterUpdate signal which
is emitted when an object is updated. But we don't have
a signal which is emitted after persisting an existing
aggregate root, if only sub objects or object storages
belonging to the aggregate root are updated.

Since the aggregate root should "encapsulate" the contained
objects to the outer world, we should provide such a signal,
which is fired if all objects of an aggregate root are persisted.

The same signal is emitted in the persistObject method in
the AbstractBackend class in Flow.

Change-Id: I85b2257b127f73afddbf4a01db156ed30489c42a
Resolves: #59986
Releases: 6.3
Reviewed-on: https://review.typo3.org/31238
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue() 43/31243/2
Markus Klein [Mon, 30 Jun 2014 11:06:42 +0000 (13:06 +0200)]
[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue()

BackendUtility::getProcessedValue() fails to initialize a variable which
causes a PHP warning on array access.

Fix this by initializing the variable to array properly.

Resolves: #59994
Releases: 6.3, 6.2
Change-Id: I26711b512a9a7fad40000de6f2de6a2b4a81ac75
Reviewed-on: https://review.typo3.org/31243
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove unused use statements 45/31245/5
Nicole Cordes [Mon, 30 Jun 2014 12:23:24 +0000 (14:23 +0200)]
[TASK] Remove unused use statements

Several classes include unused use statements. This patch removes those
statements or uses them in their code.

Resolves: #59997
Releases: 6.3
Change-Id: I5890a80bcee96976e3c35d967db8c53a9c11b002
Reviewed-on: https://review.typo3.org/31245
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Show errors on distribution installation 41/31241/5
Sascha Egerer [Mon, 30 Jun 2014 09:36:00 +0000 (11:36 +0200)]
[BUGFIX] Show errors on distribution installation

When you install a distribution and an error occurred, you get a fluid
error: "Sorry, the requested view was not found."

There is currently no template / view for the action. This patch renders
the error messages as flash messages and redirects to the list view of
distributions where the errors are shown.

Resolves: #59564
Resolves: #59952
Releases: 6.3, 6.2
Change-Id: Ie0e055dfd5620d4e0a08ecf87b2f458e7877ee76
Reviewed-on: https://review.typo3.org/31241
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use correct array structure for EM error messages 40/31240/5
Sascha Egerer [Mon, 30 Jun 2014 09:27:51 +0000 (11:27 +0200)]
[BUGFIX] Use correct array structure for EM error messages

The extension manager stores errors (like exceptions that
are thrown while installing an extension) in an array and
passes them to a fluid template.

The array has to be in a defined structure like
$errorMessages[extension name][i] = array(
»       error code,
»       error message
)

Currently, if an extension is installed from ter and an error occurs
while downloading the extension, the code and text are stored directly
under the extension name and therefore the array is not correctly parsed
by the fluid template.

Resolves: #59991
Releases: 6.3, 6.2
Change-Id: Id330f0af2a99ab99cb8b736332cb8506c857716c
Reviewed-on: https://review.typo3.org/31240
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Re-work/simplify copyright header in JS files 64/31164/6
Michael Schams [Fri, 27 Jun 2014 02:18:19 +0000 (12:18 +1000)]
[TASK] Re-work/simplify copyright header in JS files

This patch replaces the copyright/license header in JS files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

Resolves: #59916
Releases: 6.3, 6.2
Change-Id: I312bd9682fc1cf30ec327ba5d17567a3e9609c7d
Reviewed-on: https://review.typo3.org/31164
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Let live search use getRecordTitle 97/31197/4
Markus Klein [Sat, 28 Jun 2014 17:03:28 +0000 (19:03 +0200)]
[BUGFIX] Let live search use getRecordTitle

Live search uses the label configuration from TCA to get the title of a
record. An existing TODO note already suggests to use the method for
this from BackendUtility. Do this now.

Resolves: #59893
Resolves: #59957
Releases: 6.3, 6.2
Change-Id: Ic4aaabed47922863602e770b588fb8dacd9386de
Reviewed-on: https://review.typo3.org/31197
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Unique IDs for pagetree root nodes 16/28616/3
Alexander Stehlik [Fri, 21 Mar 2014 18:06:33 +0000 (19:06 +0100)]
[BUGFIX] Unique IDs for pagetree root nodes

To make sure that every ID in the pagetree is unique in pagetrees
with a virtual root node (which is used for normal editors) the
page UIDs of the webmounts are set in the mountpoint property of
the tree nodes. This makes sure that all tree node ids are unique.

Resolves: #57163
Releases: 6.3, 6.2
Change-Id: Ia938a9bf4839524d60056d55c0186196dbd11289
Reviewed-on: https://review.typo3.org/28616
Reviewed-by: Markus Klein
Tested-by: Markus Klein