Packages/TYPO3.CMS.git
19 months ago[TASK] Move info popups to modal windows 59/55659/3
Benjamin Kott [Sat, 10 Feb 2018 22:04:53 +0000 (23:04 +0100)]
[TASK] Move info popups to modal windows

Resolves: #83844
Releases: master
Change-Id: I5fef80a48d52da9800a7a9a2a23445d60168e8b5
Reviewed-on: https://review.typo3.org/55659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Unify Backend Request Handlers 62/55662/4
Benni Mack [Sat, 10 Feb 2018 23:35:03 +0000 (00:35 +0100)]
[TASK] Unify Backend Request Handlers

Due to the middleware PSR-15 concept, the AjaxRequestHandler can
be migrated easily into the generic Backend RequestHandler.

Thus, the AjaxRequestHandler is marked as deprecated.

Resolves: #83853
Releases: master
Change-Id: If7823e2bc30bdea5839a0f07e943971eeeec00c3
Reviewed-on: https://review.typo3.org/55662
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Update php-cs-fixer to v2.10.2 69/55669/2
Stefan Neufeind [Sun, 11 Feb 2018 23:30:29 +0000 (00:30 +0100)]
[TASK] Update php-cs-fixer to v2.10.2

Adjusts comment-indentions for else/elseif.

Commands used:
* composer update friendsofphp/php-cs-fixer --with-dependencies
* Build/Scripts/cglFixMyCommit.sh (modified to run on all php-files)

Resolves: #83851
Releases: master
Change-Id: I0390b3fd612ea2c495696faf9364418a078cd586
Reviewed-on: https://review.typo3.org/55669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] FE: Move Content-Length header to middleware 27/55627/6
Benni Mack [Fri, 9 Feb 2018 13:06:14 +0000 (14:06 +0100)]
[TASK] FE: Move Content-Length header to middleware

Resolves: #83828
Releases: master
Change-Id: Id5f85a5ae38260cc1a1bf730b365a9b1c425bc7e
Reviewed-on: https://review.typo3.org/55627
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Set default values in TCA of sys_file_collection 38/55638/4
Andreas Fernandez [Fri, 9 Feb 2018 21:18:21 +0000 (22:18 +0100)]
[BUGFIX] Set default values in TCA of sys_file_collection

Resolves: #83838
Releases: master, 8.7
Change-Id: I3f27f3e610fd4eae7ac37349a0cf4ff03faa1189
Reviewed-on: https://review.typo3.org/55638
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[BUGFIX] HTML5: use self-closing tags only if allowed 12/50812/8
Esteban Marín [Wed, 30 Nov 2016 14:57:05 +0000 (15:57 +0100)]
[BUGFIX] HTML5: use self-closing tags only if allowed

For HTML5 only certain HTML tags are allowed to be self-closing
(e.g. <img src="..." />), so this needs to be checked when
parsing HTML.

Resolves: #78844
Releases: master, 8.7
Change-Id: If2a319fa83a4baf7d78559aa23ce34903d42d342
Reviewed-on: https://review.typo3.org/50812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[TASK] Popup file id on the right side of "File selector" 52/54452/4
Gianluigi Martino [Fri, 20 Oct 2017 08:08:20 +0000 (10:08 +0200)]
[TASK] Popup file id on the right side of "File selector"

With this patch on the right side of the "File selector" window a popup
with the file id is showing hovering the file icon. The file size was
moved to the popup hovering the title.

Resolves: #82831
Releases: master
Change-Id: I28c256e1d445d5c3291d1ef8ab67946e2e637794
Reviewed-on: https://review.typo3.org/54452
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[FEATURE] Add readonly and required attributes to TextareaViewHelper 28/54328/11
Raphael Graf [Sun, 8 Oct 2017 18:17:09 +0000 (20:17 +0200)]
[FEATURE] Add readonly and required attributes to TextareaViewHelper

The f:form.textarea view helper now supports the HTML attributes
`readonly` and `required`.

Resolves: #82704
Releases: master
Change-Id: I890f8551fb5eccd30dedd2ad8185aa9e9a24c86e
Reviewed-on: https://review.typo3.org/54328
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Fix quoting and cleanup in AdminPanelView 16/55116/5
Stephan Großberndt [Sat, 16 Dec 2017 13:03:13 +0000 (14:03 +0100)]
[BUGFIX] Fix quoting and cleanup in AdminPanelView

In EXT:frontend/Classes/View/AdminPanelView.php add missing
htmlspecialchars() calls, remove unnecessary ones, add quoteJSvalues()
and do cleanup.

Resolves: #83357
Releases: master, 8.7
Change-Id: Ib546bcfaebf5342e187f8b707a9091947a97ca72
Reviewed-on: https://review.typo3.org/55116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Integrate Swift Mailer's spool transport 82/49182/9
Remo H [Sun, 24 Jul 2016 18:23:36 +0000 (20:23 +0200)]
[FEATURE] Integrate Swift Mailer's spool transport

Adds new configuration to the install tool and provides an
extbase schedular task and command.

A small refactoring was required:
* Moved transport creation from mailer to a factory

Possible issues are:
* sending of memory-spooled messages is a bit hacky

Resolves: #76349
Releases: master
Change-Id: I9736d4f943eea2052bf935ac1fc055c336894397
Reviewed-on: https://review.typo3.org/49182
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Allow setting a default replyTo-email-address 63/50263/16
Stefan Neufeind [Tue, 18 Oct 2016 13:25:03 +0000 (15:25 +0200)]
[FEATURE] Allow setting a default replyTo-email-address

If no other email-address is set as reply-to use this address
as default. This is similar to the existing defaultMailFromAddress.

Change-Id: Iabdf282203c1989036867a6c97b9cbe329e61f60
Resolves: #78332
Releases: master
Reviewed-on: https://review.typo3.org/50263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Apply uglify to TypeScript builds 39/55639/5
Andreas Fernandez [Fri, 9 Feb 2018 22:53:06 +0000 (23:53 +0100)]
[TASK] Apply uglify to TypeScript builds

The Grunt task `copy:ts_files` now modifies the uglify configuration
on-the-fly to minify the files compiled by TypeScript.

Resolves: #83251
Releases: master
Change-Id: I11faf7ae39f2605b4e8a8a6972f4f16c4b80138f
Reviewed-on: https://review.typo3.org/55639
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[TASK] Fix flaky Acceptance Tests 34/55634/16
Anja Leichsenring [Fri, 9 Feb 2018 19:45:39 +0000 (20:45 +0100)]
[TASK] Fix flaky Acceptance Tests

The current default timeout to wait for elements is 10 seconds.
Turn up to 30 sec to stabilize the situation.

Change-Id: I2dd6cbe14a7d05cfe3cf6f7ad3437e0b235c96f1
Resolves: #83836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge 03/55203/6
Mathias Brodala [Fri, 22 Dec 2017 16:48:54 +0000 (17:48 +0100)]
[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55203
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome 47/55647/9
Benjamin Franzke [Sat, 10 Feb 2018 12:26:50 +0000 (13:26 +0100)]
[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome

When used with the Chrome browser, the RTE CKEditor misplaces the
position of its dropdowns/context menus (opened via right-click)
when the viewport is scrolled. CKEditor calculates the offset relative
to the <body> and assumes <body> is as long as the content and that
the scrollbar is placed on <html> (both browser defaults).
As the TYPO3 backend uses 'overflow:auto' on <body> and 'overflow: hidden'
on <html> these assumptions conflict: Once the calculated offset exceeds
the <body> height (due tue scrolling) the chrome browser scrols up.

We now move the vertical scollbar into .module-body which implicitly
fixes the CKEditor offset calculation: The calculated menu offsets are
now relative to <body> (as assumed by CKEditor) and the scroll issues
disappear as we removed the scroll bar from <body>.

Resolves: #80116
Resolves: #82780
Releases: master, 8.7
Change-Id: I0481d4aaac1068577c9bad39e607486533ad4b6c
Reviewed-on: https://review.typo3.org/55647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[BUGFIX] Check if UC of recycler was ever set 56/55656/2
Andreas Fernandez [Sat, 10 Feb 2018 19:32:32 +0000 (20:32 +0100)]
[BUGFIX] Check if UC of recycler was ever set

Resolves: #83839
Releases: master
Change-Id: I1e72f959a7ec91c3834fc04ddf175c5c8cb441f2
Reviewed-on: https://review.typo3.org/55656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[TASK] Update UC in recycler only once per action 41/55641/2
Andreas Fernandez [Fri, 9 Feb 2018 23:36:15 +0000 (00:36 +0100)]
[TASK] Update UC in recycler only once per action

The UC of a backend user is now updated only once per request, if there
are actual changes.

Resolves: #83839
Releases: master, 8.7
Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad
Reviewed-on: https://review.typo3.org/55641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers 49/55649/2
Benjamin Kott [Sat, 10 Feb 2018 15:49:31 +0000 (16:49 +0100)]
[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers

Browsers on iOS are ignoring the width property for iframes,
this resulted in iframes beeing rendered too wide and prevented
scrolling on the horizontal axis.

Resolves: #83841
Releases: master, 8.7
Change-Id: I825d6f911959fdb588f1f164f0ec4bbbf5c067c0
Reviewed-on: https://review.typo3.org/55649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[BUGFIX] Fix false icons widths in FormEngine IconSelect 45/55645/2
Mathias Schreiber [Sat, 10 Feb 2018 11:01:52 +0000 (12:01 +0100)]
[BUGFIX] Fix false icons widths in FormEngine IconSelect

The width of Icons in TCA selects adjusted in https://review.typo3.org/c/55568/
has been corrected to have Icons use their proper width (128px) again.

Resolves: #83840
Releases: master, 8.7
Change-Id: Ia1e6dee77012b772c3fd5cae7199b075c66389d7
Reviewed-on: https://review.typo3.org/55645
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[BUGFIX] Show active state for SelectIcons 68/55568/6
Georg Ringer [Tue, 6 Feb 2018 02:42:36 +0000 (03:42 +0100)]
[BUGFIX] Show active state for SelectIcons

Highlight the selected icon. This useful feature has been
removed with the FormEngine rewrite.

Resolves: #83781
Releases: master, 8.7
Change-Id: I06376b073585d39d14de6f40bd02172168425944
Reviewed-on: https://review.typo3.org/55568
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] EXT:filelist Fixed exception when the base path does not exists 76/55476/5
Michael Oehlhof [Sun, 28 Jan 2018 16:26:30 +0000 (17:26 +0100)]
[BUGFIX] EXT:filelist Fixed exception when the base path does not exists

Resolves: #79785
Releases: master, 8.7
Change-Id: I50cf03273747b1fa32a1f8e4aac993a3fbc7b7f0
Reviewed-on: https://review.typo3.org/55476
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Fix typo in field description SYS:ddmmyy 30/55630/4
Reiner Teubner [Fri, 9 Feb 2018 13:30:43 +0000 (14:30 +0100)]
[BUGFIX] Fix typo in field description SYS:ddmmyy

'Date' should be 'Day'.

Resolves: #83829
Related: master, 8.7
Change-Id: If422279d147598b02e342a00f3ebcbb3d3f26723
Reviewed-on: https://review.typo3.org/55630
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Do not check HTTP referrer anymore 56/55556/4
Michael Schams [Mon, 5 Feb 2018 10:04:46 +0000 (21:04 +1100)]
[BUGFIX] Do not check HTTP referrer anymore

Under certain circumstances some browsers do not set the HTTP referrer
anymore due to privacy reasons. Hence, checking the referrer breaks
functionality.

The configuration option [SYS][doNotCheckReferer] is also removed as
it is not needed anymore.

Resolves: #83768
Releases: master, 8.7, 7.6
Change-Id: Ia8f882e07a9e2091ceb38aee814badb97403250d
Reviewed-on: https://review.typo3.org/55556
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Cast values always to string before applying through ini_set 29/55629/5
Benjamin Kott [Fri, 9 Feb 2018 13:17:48 +0000 (14:17 +0100)]
[BUGFIX] Cast values always to string before applying through ini_set

Resolves: #83826
Releases: master
Change-Id: I55d7141ffb26126215be029547e143ed2f777707
Reviewed-on: https://review.typo3.org/55629
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[TASK] Make extension scanner aware of the deprecated EidRequestHandler 31/55631/4
Benjamin Franzke [Fri, 9 Feb 2018 14:19:10 +0000 (15:19 +0100)]
[TASK] Make extension scanner aware of the deprecated EidRequestHandler

Change-Id: I2a664d445ba501a79a13aa634a8e943ef1726cf0
Releases: master
Resolves: #83831
Related: #83511
Related: #83803
Reviewed-on: https://review.typo3.org/55631
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Add missing character in upgrade wizard SectionFrameToFrameClassUpdate 28/55628/4
Pat [Fri, 9 Feb 2018 12:33:44 +0000 (13:33 +0100)]
[BUGFIX] Add missing character in upgrade wizard SectionFrameToFrameClassUpdate

Resolves: #83827
Releases: master
Change-Id: Id1d3c7ab540949d8c83bffbd921f57c6b13da879
Reviewed-on: https://review.typo3.org/55628
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Use MissingArrayPathException in InheritancesResolverService 24/55624/4
Christian Kuhn [Thu, 8 Feb 2018 23:11:35 +0000 (00:11 +0100)]
[BUGFIX] Use MissingArrayPathException in InheritancesResolverService

With change for issue #83238 the specific exception
MissingArrayPathException has been accidently changed
back to a generic \RuntimeException, fix this again.

Change-Id: I60f189c48a21bc7a6e648f4e811f4ae312ccc9ef
Releases: master
Resolves: #83815
Related: #83238
Related: #83615
Reviewed-on: https://review.typo3.org/55624
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Add constraint hook in DatabaseRecordList->makeSearchString 90/48090/9
Tomita Militaru [Wed, 11 May 2016 21:33:29 +0000 (23:33 +0200)]
[FEATURE] Add constraint hook in  DatabaseRecordList->makeSearchString

A newly introduced hook in DatabaseRecordList->makeSearchString allows to
modify the constraints which are applied to the search string.

Resolves: #71911
Releases: master
Change-Id: I7513ce9c17a9dfef76caa4e78a61f8efed21d540
Reviewed-on: https://review.typo3.org/48090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Resolve Todos in InheritancesResolverService 48/54948/4
rschueppel [Wed, 6 Dec 2017 16:44:00 +0000 (17:44 +0100)]
[TASK] Resolve Todos in InheritancesResolverService

Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.

Resolves: #83238
Releases: master, 8.7
Change-Id: I3aed06a76b609ef78641530a19e3379f202c84ec
Reviewed-on: https://review.typo3.org/54948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Align Storage “is_public” checkbox with checkbox styles 15/55615/5
Mathias Schreiber [Thu, 8 Feb 2018 19:27:18 +0000 (20:27 +0100)]
[BUGFIX] Align Storage “is_public” checkbox with checkbox styles

The markup generated by the UserStorageCapabilityService is now
in line with the overall styling of checkboxes in TCA.

Resolves: #83810
Releases: master
Change-Id: I59bb480587bf30e054b855370e33e3d2dbfdfa91
Reviewed-on: https://review.typo3.org/55615
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Use PSR-7 Response objects for external URL redirects 86/55586/3
Benjamin Franzke [Tue, 6 Feb 2018 22:34:20 +0000 (23:34 +0100)]
[TASK] Use PSR-7 Response objects for external URL redirects

Instead of immediately exiting, allow to post-process the response
through the middleware chain.

Change-Id: Icfb47f7cd84c80201a3c3b9927267e8b8aaef440
Releases: master
Resolves: #83794
Reviewed-on: https://review.typo3.org/55586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Move BE-related bootstrap code to PSR-15 middleware 38/55538/8
Benni Mack [Sat, 3 Feb 2018 21:08:49 +0000 (22:08 +0100)]
[TASK] Move BE-related bootstrap code to PSR-15 middleware

Various functionality used by both backend request handlers is moved
into PSR-15 compatible middleware, making the following Bootstrap
methods obsolete:

- checkLockedBackendAndRedirectOrDie()
- checkBackendIpOrDie()
- checkSslBackendAndRedirectIfNeeded()
- initializeBackendTemplate()
- initializeOutputCompression()
- sendHttpHeaders()

The following methods are still needed in other contexts however
- initializeBackendRouter()
- loadExtTables()
- endOutputBufferingAndCleanPreviousOutput()
- initializeBackendAuthentication()
- initializeBackendUser()
- initializeLanguageObject()

Resolves: #83792
Releases: master
Change-Id: I6772bbb73f17100dfc5116f58f1202f52fee1e8d
Reviewed-on: https://review.typo3.org/55538
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting 19/55619/3
Wouter Wolters [Thu, 8 Feb 2018 20:08:26 +0000 (21:08 +0100)]
[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting

The bootstrap throws an exception when the setting SYS/displayErrors
is not set to "-1", "0" or "1". In the Install Tool TYPO3 should not crash.
Instead allow to silently migrate the value to -1

Resolves: #82782
Resolves: #83787
Releases: master,8.7
Change-Id: Ie0180b34a551a81667bb4ac32c6ab2699d9b3d4f
Reviewed-on: https://review.typo3.org/55619
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow workspace preview inside another rootline 41/55341/3
Alexander Opitz [Fri, 12 Jan 2018 16:08:07 +0000 (17:08 +0100)]
[BUGFIX] Allow workspace preview inside another rootline

The rootline for page view now depends on the webmounts of the workspace
the preview link was generated on and not the webmounts the beuser, who
generated the preview link, is at the moment of calling the preview
link.

Resolves: #83547
Releases: master, 8.7
Change-Id: I53c8d45260b79c4d5679f00084fe81b502668ee7
Reviewed-on: https://review.typo3.org/55341
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Deprecate page.javascriptLibs.* 05/55605/3
Frank Naegler [Thu, 8 Feb 2018 14:32:29 +0000 (15:32 +0100)]
[TASK] Deprecate page.javascriptLibs.*

The settings page.javascriptLibs and page.javascriptLibs.jQuery
have been marked as deprecated and will be removed in CMS 10.

Resolves: #83806
Releases: master
Change-Id: I72d20919a30c724716a6c75ba409679f0671c68c
Reviewed-on: https://review.typo3.org/55605
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove usage of fluid legacy classes 06/55606/4
Frank Naegler [Thu, 8 Feb 2018 15:02:23 +0000 (16:02 +0100)]
[BUGFIX] Remove usage of fluid legacy classes

With https://review.typo3.org/#/c/54068/ a lot of fluid classes
were changed and replaced by fluid standalone classes.
Some ViewHelpers still use the legacy classes.
This patch switches all usages to the fluid standlone classes.

Resolves: #83811
Releases: master
Change-Id: If0ee1b694c573d0c8c1a4ea0d9f873997511127e
Reviewed-on: https://review.typo3.org/55606
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Improve file overwriting dialog of the filelist module 99/55199/5
Gianluigi Martino [Fri, 22 Dec 2017 13:44:30 +0000 (14:44 +0100)]
[TASK] Improve file overwriting dialog of the filelist module

- Remove grey background box
- Move buttons on the same row
- Better position for alternatively actions
- Some margins for better positions

Resolves: #82838
Releases: master, 8.7
Change-Id: I2fc1323d8c9acdfbb2b99b3af36e10bd5ea8a7f6
Reviewed-on: https://review.typo3.org/55199
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Respect TSconfig option showHistory 90/51090/7
Tymoteusz Motylewski [Wed, 7 Feb 2018 11:02:22 +0000 (12:02 +0100)]
[BUGFIX] Respect TSconfig option showHistory

The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.

Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.

Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/51090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Fix unset bits in options.alertPopup bitmask 23/50223/11
Mathias Brodala [Fri, 14 Oct 2016 08:29:27 +0000 (10:29 +0200)]
[BUGFIX] Fix unset bits in options.alertPopup bitmask

The validation in JsConfirmation did not allow for a value
based on JsConfirmation:ALL with some bits unset.

Change-Id: I74d43d59ee3cd06498bbebd6b7b7682ca1d79cd5
Resolves: #78240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/50223
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Rewrite eID handling as PSR-15 middleware 96/55596/6
Benjamin Franzke [Wed, 7 Feb 2018 19:57:30 +0000 (20:57 +0100)]
[TASK] Rewrite eID handling as PSR-15 middleware

Releases: master
Resolves: #83803
Change-Id: Id704c5235e5e844d8e42482dd55948e0ad4a2162
Reviewed-on: https://review.typo3.org/55596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Show warning when deleting an element which has references 95/50895/8
Anja Leichsenring [Wed, 7 Feb 2018 20:19:30 +0000 (21:19 +0100)]
[TASK] Show warning when deleting an element which has references

Show the same warning in the page module as done in the list module,
except without the title and the table:uid combination, as this is
not needed in page module. It will always be tt_content records there.

Resolves: #78912
Releases: master
Change-Id: I4dea94204475e322fabf30d7a0772dc5e30edb60
Reviewed-on: https://review.typo3.org/50895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Deprecate broken buildQueryParameters hook 12/55512/7
Frank Naegler [Wed, 31 Jan 2018 15:09:33 +0000 (16:09 +0100)]
[BUGFIX] Deprecate broken buildQueryParameters hook

This change deprecates the "buildQueryParameters" hook in three
different classes and adds two new hooks in DatabaseRecordList
and PageLayoutView to modify the current query.

With #82334 a cleanup of AbstractRecordList has introduced
the same hook into multiple classes, which breaks existing
hooks, because of the sixth parameter which can be one of three
different classes without a common parent class or interface.
This makes it impossible to use a type hint in the hook class.

Another problem is: an extension which implements the hook
for the list module and uses a type hint will break the page module.

The same query manipulation can be achieved with the two
new hooks, which have a separate identifier.

Resolves: #83740
Related: #82334
Releases: master
Change-Id: Ie3b2c8082f86c6632400a8194dca4ca244b428bc
Reviewed-on: https://review.typo3.org/55512
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Add backwards-compatibility for old BE modules 89/55589/3
Benni Mack [Wed, 7 Feb 2018 18:46:35 +0000 (19:46 +0100)]
[TASK] Add backwards-compatibility for old BE modules

Handling of "&M" parameters is added back in order to make
the transition for Backend modules easier.

Resolves: #83800
Related: #82406
Releases: master
Change-Id: Iaa237b62254804d78314b48d80dfbea563fd7af4
Reviewed-on: https://review.typo3.org/55589
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Remove wrong phpDoc for defineTypo3RequestTypes function 93/55593/3
Wouter Wolters [Wed, 7 Feb 2018 20:37:57 +0000 (21:37 +0100)]
[BUGFIX] Remove wrong phpDoc for defineTypo3RequestTypes function

There is no return value, drop the @return tag.
Also add @param int $requestType to setRequestType

Resolves: #83801
Releases: master
Change-Id: I1f371effb5a56c02860af716ca4071ac3db3c4da
Reviewed-on: https://review.typo3.org/55593
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Rewrite the redirect handler as PSR-15 HTTP middleware 39/55539/5
Benjamin Franzke [Wed, 24 Jan 2018 19:31:28 +0000 (20:31 +0100)]
[TASK] Rewrite the redirect handler as PSR-15 HTTP middleware

The code is restructured to clearly distinct between aborting
the middleware chain – returning an own response – and forwarding
the request to the next middleware/request handler.

Change-Id: I51d88b9f9fae8d2aafca343da1e67bf60182d765
Releases: master
Resolves: #83727
Reviewed-on: https://review.typo3.org/55539
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Fix timetracker and pre-process middleware sequence 94/55594/4
Benjamin Franzke [Wed, 7 Feb 2018 20:30:39 +0000 (21:30 +0100)]
[BUGFIX] Fix timetracker and pre-process middleware sequence

Correct middleware configuration to preserve the ordering
timetracker initialization and pre-process hook had prior
the re-implementation as middleware.
The timetracker initialization needs to be first, pre-process second.

Change-Id: Ieecfff459000566f75b692516f27f5d7e176149b
Resolves: #83802
Releases: master
Reviewed-on: https://review.typo3.org/55594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Implement runtime_cache for DataHandler->recUpdateAccessCache 19/51019/4
Thomas Hohn [Mon, 19 Dec 2016 05:48:49 +0000 (06:48 +0100)]
[TASK] Implement runtime_cache for DataHandler->recUpdateAccessCache

Removes "public internal" cache variable and implements runtime_cache
instead.

Change-Id: I8262a699d60db9e9eb04f23c3f7da78ef7e1149d
Resolves: #79071
Releases: master
Reviewed-on: https://review.typo3.org/51019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Use existing js listeners in page module 65/53265/4
Daniel Windloff [Sun, 4 Jun 2017 17:29:27 +0000 (19:29 +0200)]
[TASK] Use existing js listeners in page module

Resolves: #81466
Releases: master, 8.7
Change-Id: Icf9dace3b00667e4d6a17cc5d3559782beffb725
Reviewed-on: https://review.typo3.org/53265
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Reenable all additionals in video tag 56/53356/3
Markus Sommer [Thu, 29 Jun 2017 14:36:16 +0000 (16:36 +0200)]
[TASK] Reenable all additionals in video tag

Enable all additionalAttributes and additionalConfig’s to cover w3c and special spacs.

Resolves: #81743, #81741
Releases: master, 8.7
Change-Id: Ibfce2bd66e6de95eeb7c05eab160eec40ae437ef
Reviewed-on: https://review.typo3.org/53356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Unify layout of tables in submodules 79/53479/5
Jasmina Ließmann [Fri, 14 Jul 2017 16:38:56 +0000 (18:38 +0200)]
[TASK] Unify layout of tables in submodules

Use the same layout for tables in submodules of module 'Info'.

Resolves: #81457
Releases: master
Change-Id: I1135bbf57eaa033fd09538c242192907b5b20ee4
Reviewed-on: https://review.typo3.org/53479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Improve prevention of redirect loop 77/53977/5
Christoph Lehmann [Thu, 7 Sep 2017 20:24:17 +0000 (22:24 +0200)]
[TASK] Improve prevention of redirect loop

This prevents a redirect loop with realurl where an editor
doesn't see the pagetree of his login domain in his workspace
and opens his login domain in the FE. As result he sees the
requested page.

Resolves: #82297
Releases: master, 8.7
Change-Id: Ie948f6defa21e3e1d8766533f54a48769d2220c9
Reviewed-on: https://review.typo3.org/53977
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Properly select Chinese (Simplified) in DatePicker.js 61/51161/3
David Wong [Fri, 6 Jan 2017 08:02:51 +0000 (09:02 +0100)]
[TASK] Properly select Chinese (Simplified) in DatePicker.js

The language identifier key for Chinese in TYPO3s backend is ‘ch’.
The valid identifier should be ‘zh-cn’, but we cannot change the entire translation server
in a meaningful way.

Releases: master
Resolves: #79179
Change-Id: I5fee14f2eceacc5676588bdb8cac2aeceb88fff6
Reviewed-on: https://review.typo3.org/51161
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Use TSFE->isBackendUserLoggedIn() instead of public variable 75/55575/2
Benni Mack [Tue, 6 Feb 2018 12:01:35 +0000 (13:01 +0100)]
[TASK] Use TSFE->isBackendUserLoggedIn() instead of public variable

The public method TSFE->isBackendUserLoggedIn() instead of
TSFE->beUserLogin (public property).

Resolves: #83785
Releases: master
Change-Id: I1e54b7365b3b6810b606e93b0f888a7790492014
Reviewed-on: https://review.typo3.org/55575
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Move frontend pre-process functionality to PSR-15 middleware 84/55584/2
Benni Mack [Sat, 3 Feb 2018 20:53:48 +0000 (21:53 +0100)]
[TASK] Move frontend pre-process functionality to PSR-15 middleware

This patch moves logic out of the RequestHandlers into PSR-15 compatible
middleware classes to call a hook and initialize the time tracker.

Resolves: #83765
Releases: master
Change-Id: I200fdc80390625fb45564a4c09cecd00d846fad8
Reviewed-on: https://review.typo3.org/55584
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Add support for PSR-15 HTTP middlewares 44/55544/7
Benjamin Franzke [Sat, 3 Feb 2018 22:56:37 +0000 (23:56 +0100)]
[FEATURE] Add support for PSR-15 HTTP middlewares

PSR-15 middlewares are hooks on steroids for HTTP requests.
Due to chaining middlewares and the core request handler(s),
middlewares can execute code before and after the application.

Middlewares may return early, that means they can prevent
consecutive middleware and the core application from being executed
at all.

A full middleware coverage for *all* requests will need
a lot of changes to the core and extensions.
We'll eventually need to stop using header()/exit()/die()
or HttpUtility::{redirect,sendRespose}(). Those method calls
need to be replaced by manipulation of PSR-7 message objects.

PSR-15 interfaces are provided by psr/http-server-middleware:

composer require psr/http-server-middleware:^1.0

Change-Id: Ia906d51da2e4309a37fb47a7966b52f873782d8f
Releases: master
Resolves: #83725
Reviewed-on: https://review.typo3.org/55544
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Replace calls to the deprecated PHP function each() 10/55510/20
Reiner Teubner [Wed, 31 Jan 2018 14:30:21 +0000 (15:30 +0100)]
[BUGFIX] Replace calls to the deprecated PHP function each()

This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().

Resolves: #83737
Releases: master, 8.7, 7.6
Change-Id: Ie61a6d44fcdbd4ce6105a6c185085a3a68866fd8
Reviewed-on: https://review.typo3.org/55510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Only scan package base paths if subdirectories exist 18/55018/11
Michael Oehlhof [Sun, 10 Dec 2017 21:58:46 +0000 (22:58 +0100)]
[BUGFIX] Only scan package base paths if subdirectories exist

Include possible package base paths only if subdirectories are available.
Otherwise no extension can be found in the base path anyway.

Resolves: #83070
Releases: master, 8.7, 7.6
Change-Id: I503623c607554a60bd144c83e3f69e78fe5a7ea0
Reviewed-on: https://review.typo3.org/55018
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Forward header in DebugUtility:debug to renderDump 73/55473/4
Georg Ringer [Sun, 28 Jan 2018 11:37:17 +0000 (12:37 +0100)]
[BUGFIX] Forward header in DebugUtility:debug to renderDump

Improve the debug output by forwarding the given title.

Resolves: #83688
Releases: master, 8.7
Change-Id: I160b5676c5ff70c056319446733c9549a663569a
Reviewed-on: https://review.typo3.org/55473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Update screenshots in 'TYPO3 Manual' 16/54316/3
Jasmina Liessmann [Sat, 7 Oct 2017 12:22:56 +0000 (14:22 +0200)]
[TASK] Update screenshots in 'TYPO3 Manual'

Resolves: #82442
Releases: master
Change-Id: I90b596839a85c43c59c2d45870b344c09e59769d
Reviewed-on: https://review.typo3.org/54316
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] EXT:form - fix array overrules within YAML preprocessing 87/55487/7
Ralf Zimmermann [Mon, 29 Jan 2018 13:56:45 +0000 (14:56 +0100)]
[BUGFIX] EXT:form - fix array overrules within YAML preprocessing

If you use the "__inheritance" operator within an EXT:form configuration
file, configuration keys of the parent element can be deleted in the
child element by giving the configuration key in the child element
the value NULL.
See https://docs.typo3.org/typo3cms/extensions/form/latest/Concepts/
Configuration/Index.html#inheritances for further information.

Before the "__inheritance" operators are executed, all configuration
files are merged using
TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule().

However, this does not work if you are using several configuration files.

Let's assume the configuration key in the previous configuration file is
an array. mergeRecursiveWithOverrule() does not delete this
configuration key, if the configuration key in the overriding
configuration file is not an array (for example: NULL). This is simply
ignored by mergeRecursiveWithOverrule().

This patch fixes this issue by adding a variation of
array_merge_recursive().

Resolves: #82051
Releases: master, 8.7
Change-Id: Id9d256226a3eb82f6bc3fd03904f944719e525e7
Reviewed-on: https://review.typo3.org/55487
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Add missing DOM ready checks in filelist 90/55390/12
Frank Naegler [Wed, 17 Jan 2018 22:43:50 +0000 (23:43 +0100)]
[BUGFIX] Add missing DOM ready checks in filelist

Some modules in the filelist are missing DOM ready checks.
This patch adds the missing checks to prevent loading issues.

Resolves: #78976
Releases: master, 8.7
Change-Id: Iee328808a89cf92f4fde1afd59167ae9fa7280be
Reviewed-on: https://review.typo3.org/55390
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
19 months ago[BUGFIX] Improve ErrorHandlerTest handleErrorFetchesDeprecations 62/55562/3
Nicole Cordes [Mon, 5 Feb 2018 11:32:06 +0000 (12:32 +0100)]
[BUGFIX] Improve ErrorHandlerTest handleErrorFetchesDeprecations

The patch decouples the ErrorHandler test from MySQL and some internal
deprecated function.

Related: #83770
Releases: master
Change-Id: Id3b9ed3486d0c5c8a4f6ba030a25f1f8aee75b97
Reviewed-on: https://review.typo3.org/55562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Apply code formating for all JavaScript files 21/55521/9
Frank Naegler [Thu, 1 Feb 2018 14:38:07 +0000 (15:38 +0100)]
[TASK] Apply code formating for all JavaScript files

This is the first step for introduce CGL for JavaScript files.
The settings of the .editorconfig file is now applied to all
JavaScript files. This will prevent merge conflicts for the
next patches.

Resolves: #83752
Releases: master, 8.7
Change-Id: Ie84691e7f7f3a3974f3c62133895a62377b22f67
Reviewed-on: https://review.typo3.org/55521
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Page module: Respect connected mode during drag & drop 53/55453/5
Andreas Fernandez [Thu, 25 Jan 2018 09:20:11 +0000 (10:20 +0100)]
[BUGFIX] Page module: Respect connected mode during drag & drop

This patch adjusts the drag and drop handling on the page module.
Localized content element can't get moved anymore when they are in
connected mode. Languages without a `l18n_parent` may be freely
moved.

Resolves: #83470
Related: #66540
Releases: master, 8.7
Change-Id: I7dcb61279d4bfeb094dcb0e2fbffd416da9c787b
Reviewed-on: https://review.typo3.org/55453
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: Armin Vieweg <armin@v.ieweg.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Update typo3fluid/fluid to 2.5.0 60/55560/2
Christian Kuhn [Sun, 4 Feb 2018 20:09:20 +0000 (21:09 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.0

Fixes various issues, brings PHP 7.2 compatibility
to v8 core branch of standalone fluid.

composer command used:
composer update typo3fluid/fluid

Change-Id: I52c3a97e7dc8dafd7b0dee1e07df5105f29cdbde
Resolves: #83774
Resolves: #82227
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55560
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Prevent enforcing opened database connection with initCommands 48/55548/8
Nicole Cordes [Sun, 4 Feb 2018 11:20:05 +0000 (12:20 +0100)]
[BUGFIX] Prevent enforcing opened database connection with initCommands

This patch moves the execution of configured initCommands to the end
of connect function. This prevents a database connection from being
opened by default due to the execution of commands right after class
initialization and still ensures a connection is configured properly
before first command execution.

Furthermore this patch adds a new functional test for the ErrorHandler.
The test uses some predefined initCommands to enforce the strict mode
of MySQL database to be set. Due to the predefined initCommands the
test failed before as the connection was forced to be opened. For
further information see the referenced forge ticket.

Resolves: #83770
Releases: master, 8.7
Change-Id: I2287600959b3ec06d338e26373562850307ce0b1
Reviewed-on: https://review.typo3.org/55548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
19 months ago[BUGFIX] Add possibility to use session data in TS conditions 08/55408/12
Wolfgang Klinger [Tue, 9 Jan 2018 19:17:56 +0000 (20:17 +0100)]
[BUGFIX] Add possibility to use session data in TS conditions

Bring back the possibility to access FE session data in
TypoScript conditions:
[globalVar = TSFE:fe_user|sesData|some_key > 10]

Resolves: #83506
Releases: master, 8.7
Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521
Reviewed-on: https://review.typo3.org/55408
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Re-apply colorspace to resulting image 91/50791/4
Stefan Neufeind [Mon, 28 Nov 2016 10:33:30 +0000 (11:33 +0100)]
[BUGFIX] Re-apply colorspace to resulting image

When using filters the colorspace is not always applied.
A quickfix is to add the colorspace-setting again before
writing the output-image.
Multiple colorspace-settings on the commandline will be
executed in order. For example the grayscale-filter uses
"-colorspace GRAY". The final output-image can then be
converted to "-colorspace sRGB" again so the brightness
appears correct (not too dark) again.

Resolves: #78816
Releases: master, 8.7
Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd
Reviewed-on: https://review.typo3.org/50791
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Add toggle switches to FormEngine 51/55351/29
Mathias Schreiber [Sat, 13 Jan 2018 17:26:01 +0000 (18:26 +0100)]
[FEATURE] Add toggle switches to FormEngine

In order to give FormEngine a fresher look we add the following
renderTypes to type=checkbox

* checkboxToggle
* checkboxLabeledToggle

Furthermore, checkboxes are now displayed with icons
provided via the IconFactory and can be changed.

Resolves: #83556
Release: master
Change-Id: I24570dc4ee8cb672a5f961399b709fe7da05e2f0
Reviewed-on: https://review.typo3.org/55351
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Provide Foldername in InaccessibleException 41/55541/3
Mathias Schreiber [Sat, 3 Feb 2018 22:17:37 +0000 (23:17 +0100)]
[BUGFIX] Provide Foldername in InaccessibleException

The central InsufficientFolderReadPermissionsException now
displays the name of the folder in question to ease tracing down
errors.

Resolves: #82342
Releases: master
Change-Id: I968c74e6b2e210b07964f7ebb141155525c26ee5
Reviewed-on: https://review.typo3.org/55541
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Catch InvalidPathException for FileStorages 51/55551/3
Mathias Schreiber [Sun, 4 Feb 2018 16:06:12 +0000 (17:06 +0100)]
[BUGFIX] Catch InvalidPathException for FileStorages

Editing faulty FileStorages is possible again due to catching the
respective exception and piping it into a FlashMessage

Resolves: #83762
Releases: master, 8.7
Change-Id: I5081d86fd73076359b1d9eba954ba07c50bcb7b2
Reviewed-on: https://review.typo3.org/55551
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Access parent element in Element Browser correctly 11/55511/9
Andreas Fernandez [Wed, 31 Jan 2018 15:01:00 +0000 (16:01 +0100)]
[BUGFIX] Access parent element in Element Browser correctly

When the element browser is opened in a popup window, the parent element
(=popup) is now accessed properly.

This patch also fixes the case for `list_frame` which didn't work in
Firefox.

Resolves: #83693
Releases: master
Change-Id: I2436942a239b868cd1e3e269c6161a9df92e05ff
Reviewed-on: https://review.typo3.org/55511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Allow flexible search in Suggest Wizard 46/55546/4
Mathias Schreiber [Sun, 4 Feb 2018 10:08:31 +0000 (11:08 +0100)]
[FEATURE] Allow flexible search in Suggest Wizard

The Suggest Wizard now allows to search for multiple
terms in field by splitting the searchterm by +.

This allows to search for a combination of values which
is helpful when dealing with large data sets.

Resolves: #61981
Releases: master
Change-Id: I764039a575ca5d9ccbd97dd3dc57f3947906a5c3
Reviewed-on: https://review.typo3.org/55546
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Don’t show translated pages in SuggestWizard 50/55550/4
Mathias Schreiber [Sun, 4 Feb 2018 13:56:47 +0000 (14:56 +0100)]
[BUGFIX] Don’t show translated pages in SuggestWizard

The SuggestWizard no longer returns translated pages.
For the sake of database relations, relating directly to a translated
page makes no sense and will most likely result in unintended
behavior.

Resolves: #83771
Releases: master
Change-Id: Ibfa8dfa3082245726e0a519e77f26849507e421b
Reviewed-on: https://review.typo3.org/55550
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Increase cache db backend blob 49/55549/2
Christian Kuhn [Sun, 4 Feb 2018 13:45:48 +0000 (14:45 +0100)]
[TASK] Increase cache db backend blob

Sets the typo3 database cache backend "content" field
from mediumblob to longblob.
Mediumblob on mysql equals 16MB max storage, which can
be too small for cache entries. Switching to longblob
increases single cache row size to 4GB and costs only
one additional byte per row.

Change-Id: I1ab5b84b6845280e77e339cbe4a59e0043f84cc2
Resolves: #83772
Releases: master
Reviewed-on: https://review.typo3.org/55549
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Revert "Add support for PSR-15 HTTP middlewares" 43/55543/2
Benni Mack [Sat, 3 Feb 2018 22:45:04 +0000 (23:45 +0100)]
[TASK] Revert "Add support for PSR-15 HTTP middlewares"

This reverts commit f22792eceea631b8f01fbe0fcbf3e62b52246cad
reviewed on https://review.typo3.org/#/c/55528/
due to a fault of mine removing the original ownership of the commit.

Change-Id: Idd8b09754ec124047bd620c7529b0937c823e6b1
Resolves: #83767
Reverts: #83725
Releases: master
Reviewed-on: https://review.typo3.org/55543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Revert "Move frontend pre-process functionality to PSR-15 middleware" 42/55542/2
Benni Mack [Sat, 3 Feb 2018 22:27:31 +0000 (23:27 +0100)]
[TASK] Revert "Move frontend pre-process functionality to PSR-15 middleware"

This reverts commit a1f5a2320cdcf50bf4e5670a191baa116a550310
due to author conflicts.

https://review.typo3.org/#/c/55537/

Change-Id: Ie6003a41e75d395a1214904ecce8994ec63ac798
Resolves: #83766
Reverts: #83785
Releases: master
Reviewed-on: https://review.typo3.org/55542
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Move frontend pre-process functionality to PSR-15 middleware 37/55537/6
Benni Mack [Sat, 3 Feb 2018 20:53:48 +0000 (21:53 +0100)]
[TASK] Move frontend pre-process functionality to PSR-15 middleware

This patch moves logic out of the RequestHandlers into PSR-15 compatible
middleware classes to call a hook and initialize the time tracker.

Resolves: #83765
Releases: master
Change-Id: Ibe2435833a8cbf0fb19cfe1fddd519d47147707e
Reviewed-on: https://review.typo3.org/55537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FEATURE] Add support for PSR-15 HTTP middlewares 28/55528/15
Benni Mack [Sat, 3 Feb 2018 20:03:58 +0000 (21:03 +0100)]
[FEATURE] Add support for PSR-15 HTTP middlewares

PSR-15 middlewares are hooks on steroids for HTTP requests.
Due to chaining middlewares and the core request handler(s),
middlewares can execute code before and after the application.

Middlewares may return early, that means they can prevent
consecutive middleware and the core application from being executed
at all.

A full middleware coverage for *all* requests will need
a lot of changes to the core and extensions.
We'll eventually need to stop using header()/exit()/die()
or HttpUtility::{redirect,sendRespose}(). Those method calls
need to be replaced by manipulation of PSR-7 message objects.

Change-Id: I075639835115f7cf28f18c3814ef6dd190fdf29b
Releases: master
Resolves: #83725
Reviewed-on: https://review.typo3.org/55528
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Element Browser should only render default language pages 36/55536/2
Benni Mack [Sat, 3 Feb 2018 19:57:43 +0000 (20:57 +0100)]
[BUGFIX] Element Browser should only render default language pages

The Browseable Trees (Element Browser) show pages with
language > 0 (page translations), due to a missing fix
during the pages_language_overlay refactoring.

The patch adds the restriction on deleted pages
and sys_language_uid=0 pages, just like PageTreeView
and the new page tree do it.

Resolves: #83764
Releases: master
Change-Id: I90d76a37a0ee146ea549adcbb3aeff027fe42d26
Reviewed-on: https://review.typo3.org/55536
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] D3.js uses basic authentication credentials cached in browser 34/55534/2
Tymoteusz Motylewski [Fri, 2 Feb 2018 16:15:57 +0000 (17:15 +0100)]
[BUGFIX] D3.js uses basic authentication credentials cached in browser

Chrome 64 changed the behaviour regarding xhr.open() calls when passing
null values as password and username.
The d3.js file is manually patched.
Once PR https://github.com/d3/d3-request/pull/34/files is merged we can
use official d3.js version again.

Resolves: #83741
Releases: master, 8.7
Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125
Reviewed-on: https://review.typo3.org/55534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Require "fluid" for "fluid_styled_content" 31/55531/5
Thomas Löffler [Fri, 2 Feb 2018 10:04:56 +0000 (11:04 +0100)]
[TASK] Require "fluid" for "fluid_styled_content"

When requiring fluid_styled_content in an extension
by composer, the extension fluid should be required and
installed, too.

Releases: master
Resolves: #83756
Change-Id: I1cdd00e842e4b0918db0746ccdf58bb871b8790c
Reviewed-on: https://review.typo3.org/55531
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Apply proper button class to BE Layout Modal 32/55532/2
Mathias Schreiber [Fri, 2 Feb 2018 12:42:29 +0000 (13:42 +0100)]
[BUGFIX] Apply proper button class to BE Layout Modal

The modal “OK” button of the BE layout column assignment now sports the correct color
for the button.

Resolves: #83662
Releases: master
Change-Id: I13587241f5f79a555ef7edab6071d1d3f0265ad0
Reviewed-on: https://review.typo3.org/55532
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Ensure HTTP RequestHandlers always return a PSR-7 Repsonse 98/55498/10
Benjamin Franzke [Wed, 24 Jan 2018 21:25:52 +0000 (22:25 +0100)]
[TASK] Ensure HTTP RequestHandlers always return a PSR-7 Repsonse

This is in preparation for PSR-15 middleware support which
will require PSR-7 RespnseInterface return type declarations
for request handlers.

As TSFE powers a concept of outputting nothing [see isOutputting()]
we need to add NullResponse (which implements the PSR-7 ResponseInterface)
which Core/Bootstrap can detect, to stop invoking header() and echo.

Change-Id: Ie3169a4365a85d0472523138cc73bb47cbbcb70f
Releases: master
Resolves: #83724
Reviewed-on: https://review.typo3.org/55498
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Fix "Select & upload files" button for FAL in flexform 16/55516/6
Armin Vieweg [Thu, 1 Feb 2018 09:20:15 +0000 (10:20 +0100)]
[BUGFIX] Fix "Select & upload files" button for FAL in flexform

Fix regular expression in escapeCssSelector method, to convert
e.g. "." to "\.".

Resolves: #83747
Branches: master, 8.7
Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954
Reviewed-on: https://review.typo3.org/55516
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js 17/55517/4
Frank Naegler [Thu, 1 Feb 2018 10:32:01 +0000 (11:32 +0100)]
[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js

This patch removes the uglify task of jquery-ui/sortable.js.
With https://review.typo3.org/#/c/55389/ the lib was patched
and already uglified. This patch prevents a double uglify of the file.

Resolves: #83593
Releases: master, 8.7
Change-Id: I16edd94fc8d3165159b4dc0a47ac7365ff34e37f
Reviewed-on: https://review.typo3.org/55517
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Set TYPO3 version to 9.2.0-dev 05/55505/5
Oliver Hader [Tue, 30 Jan 2018 15:33:03 +0000 (16:33 +0100)]
[TASK] Set TYPO3 version to 9.2.0-dev

Change-Id: I221d472b3bd9ac035221cb804601740cf77847b0
Reviewed-on: https://review.typo3.org/55505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[RELEASE] Release of TYPO3 9.1.0 04/55504/2 v9.1.0
Oliver Hader [Tue, 30 Jan 2018 15:30:49 +0000 (16:30 +0100)]
[RELEASE] Release of TYPO3 9.1.0

Change-Id: I8ebeca67eb5524682846a2fb7d55ee8bbde1a318
Reviewed-on: https://review.typo3.org/55504
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA 00/55500/3
Stephan Großberndt [Tue, 30 Jan 2018 11:12:43 +0000 (12:12 +0100)]
[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA

By casting the JavaScript variable to string this patch avoids an error
if 'eval' => 'int,nospace' is used in a TCA column definition.

Resolves: #83731
Releases: master, 8.7
Change-Id: I5be79bf6cd748ac184505f0aa4bd97c7d934eebd
Reviewed-on: https://review.typo3.org/55500
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Fix example code for TCA "fieldControl" 01/55501/2
Stephan Großberndt [Tue, 30 Jan 2018 14:22:13 +0000 (15:22 +0100)]
[BUGFIX] Fix example code for TCA "fieldControl"

Resolves: #83732
Releases: master, 8.7
Change-Id: I7dccb42445dba584ed1c9a814f62525335d26ab1
Reviewed-on: https://review.typo3.org/55501
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] EXT:filelist Canceling the file exists already modal works now 18/55418/3
Michael Oehlhof [Sun, 21 Jan 2018 01:49:04 +0000 (02:49 +0100)]
[BUGFIX] EXT:filelist Canceling the file exists already modal works now

When renaming a file with the name of an existing file a modal is shown.
Pressing the cancel button no longer renames the file with an unique name.

Resolves: #83624
Releases: master
Change-Id: I9963f6ce0b476f63043056d74e38af251ea0cd3e
Reviewed-on: https://review.typo3.org/55418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[DOCS] 1/1 9.1 Documentation 65/55465/8
Mathias Schreiber [Fri, 26 Jan 2018 19:58:59 +0000 (20:58 +0100)]
[DOCS] 1/1 9.1 Documentation

Proofread documentation for CMS 9.1.

Two rst snippets remain in Changelog/master in order to ease a scheduled
revert by @helhum.

Resolves: #83700
Releases: master
Change-Id: Iebf3db03bd95a6f20b0b786e9776fc84b77d6e3b
Reviewed-on: https://review.typo3.org/55465
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months agoRevert "[FEATURE] EXT:form - introduce YAML "imports"" 22/55422/5
Helmut Hummel [Sun, 21 Jan 2018 17:40:15 +0000 (18:40 +0100)]
Revert "[FEATURE] EXT:form - introduce YAML "imports""

While the intended feature is great (having the possiblity
to extract and re-use parts of the form definition),
implementation wise it needs some rework.

To be able to release 9.1 as stable as possible,
we now revert this implementation for now
and bring it in for 9.2 again.

This reverts commit a52a99220ca24251186ea88d11b3db43436a8156.

Reverts: #82089
Resolves: #83729
Releases: master
Change-Id: I850401d232b642e712801613d3780816f873966a
Reviewed-on: https://review.typo3.org/55422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[FEATURE] Option to globally enable redirect hit count 97/55497/2
Susanne Moog [Mon, 29 Jan 2018 19:15:27 +0000 (20:15 +0100)]
[FEATURE] Option to globally enable redirect hit count

Most websites probably use custom analytics for page
hit statistics or are not interested in the count of
hits on a redirect. Therefor the redirect hit count
has been disabled by default. The option to enable
the hit count globally via LocalConfiguration has been
added.

Change-Id: I71c57784d8c6e0f17c81b1f899aa43e91d37cd76
Resolves: #83677
Releases: master
Reviewed-on: https://review.typo3.org/55497
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[TASK] Improved extension configuration API 34/55434/10
Christian Kuhn [Tue, 23 Jan 2018 12:42:43 +0000 (13:42 +0100)]
[TASK] Improved extension configuration API

The patch implements feedback from the new
ExtensionConfiguration API.
get() now falls back to a parsing of ext_conf_template,
so the parser is moved from the install tool
to the ext:core class. This prevents a chicken-egg
issue in early setup phases.

The move of the synchronize* methods forces a raise
of the testing-framework:

composer require --dev typo3/testing-framework ^2.0.3

Change-Id: I9a6700fc66fe78d9df09038a89ea95f8dba81031
Resolves: #83666
Releases: master
Reviewed-on: https://review.typo3.org/55434
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] NewContentElementWizardController to NewContentElementController 79/55479/6
Oliver Hader [Sun, 28 Jan 2018 22:38:22 +0000 (23:38 +0100)]
[BUGFIX] NewContentElementWizardController to NewContentElementController

NewContentElementWizardController, which has been introduced for TYPO3 v9
to render the new content element process in a dedicated modal was just a
duplicate of the existing NewContentElementController class with some
minor adjustments and code flow enhancements (names, empty checks).

However, there have been several side effects like:
* hook implementing NewContentElementWizardHookInterface would have been
  called by both object instances, having different public properties -
  the most common access to $parentObject->id or ~->sys_language would
  have failed to to property visibility and change names
* the JavaScript closure callback to adjust the URL when interacting in
  the browser was hard-coded to modal rendering, with still having the
  possibility to render the old behavior e.g. in the web>list view

To overcome these flaws both mentioned classes have been merged since the
functionality was not that much different anyway. Besides that different
JavaScript client scopes ('window' or 'list_frame') are forwarded to the
according object instances.

Resolves: #83705
Releases: master
Change-Id: I472a7ec8a5d06c05e6c7053bf98b5cfacb69f9d9
Reviewed-on: https://review.typo3.org/55479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Invalid session token on creating content element in admin panel 88/55488/2
Oliver Hader [Mon, 29 Jan 2018 15:29:33 +0000 (16:29 +0100)]
[BUGFIX] Invalid session token on creating content element in admin panel

When creating a new content element in the frontend using the according
button in the "editing" section of the admin panel, the request to the
TYPO3 backend is rejected due to an invalid XSRF session token:

Validating the security token of this form has failed.
Please reload the form and submit it again.

The reason is, that the URL after issue #70055 looks like the following
"token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became
part of the XSRF session token.

Resolves: #83719
Releases: master, 8.7, 7.6
Change-Id: Ibdd252b2e59d9e8de78bb0be14a95e0789dc0d17
Reviewed-on: https://review.typo3.org/55488
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Correct example in redirects feature documentation 91/55491/2
Benjamin Kott [Mon, 29 Jan 2018 17:17:55 +0000 (18:17 +0100)]
[BUGFIX] Correct example in redirects feature documentation

Resolves: #83723
Releases: master
Change-Id: I010796bd056e6c70d21010ef649f127c4d006a21
Reviewed-on: https://review.typo3.org/55491
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Properly check `serialized_executions` to avoid warnings with PHP 7.2 74/55474/5
Georg Ringer [Sun, 28 Jan 2018 11:42:17 +0000 (12:42 +0100)]
[BUGFIX] Properly check `serialized_executions` to avoid warnings with PHP 7.2

To avoid warnings with PHP 7.2, `serialized_executions` must be checked
for being not an empty value.

Resolves: #83691
Releases: master, 8.7, 7.6
Change-Id: I5855a03d6669ec0e82931cfc0110c2b7ca134ad4
Reviewed-on: https://review.typo3.org/55474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] EXT:filelist Fixed exception when creating new text file 19/55419/2
Michael Oehlhof [Sun, 21 Jan 2018 11:50:51 +0000 (12:50 +0100)]
[BUGFIX] EXT:filelist Fixed exception when creating new text file

The exception does not occur with the LocalDriver.
For testing use the driver mentioned in the forge issue.

Resolves: #83627
Releases: master, 8.7
Change-Id: Iae5fef2cc1ca704998975aba4fb6f5e48aeec4b1
Reviewed-on: https://review.typo3.org/55419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>