Packages/TYPO3.CMS.git
21 months ago[BUGFIX] IRRE actions should render error messages from DataHandler 59/54659/2
Benni Mack [Thu, 16 Nov 2017 11:05:03 +0000 (12:05 +0100)]
[BUGFIX] IRRE actions should render error messages from DataHandler

When IRRE actions (localize/synchronize) are triggered that result in a
DataHandler error (e.g. "Localization failed, "languageField" and
"transOrigPointerField" must be defined for the table") because of a missing
configuration, the current implementation does not evaluate DataHandler
results in the JSON response.

The change adds the same functionality as for other DataHandler calls
to evaluate the JSON response.

Resolves: #83011
Releases: master, 8.7
Change-Id: I7a2069b78cd9c3fa031b7ac194ae5b18596b6a3e
Reviewed-on: https://review.typo3.org/54659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[BUGFIX] Validate page error handler result to report wrong configuration 94/54494/8
Markus Klein [Sun, 29 Oct 2017 17:05:15 +0000 (18:05 +0100)]
[BUGFIX] Validate page error handler result to report wrong configuration

Resolves: #50186
Releases: master, 8.7
Change-Id: I082a2d48608d43856cd60076852a19aec8a21a7e
Reviewed-on: https://review.typo3.org/54494
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Resolve translated page IDs to default language page in FE 70/54670/6
Benni Mack [Thu, 16 Nov 2017 21:26:52 +0000 (22:26 +0100)]
[TASK] Resolve translated page IDs to default language page in FE

Currently, when accessing a translated page ID via index.php?id=23,
the TypoScript cannot be resolved, as the GET parameter is no valid
page where records (e.g. sys_template etc).

In order to achieve this, the TYPO3 Frontend now resolves the $id
to the default page ID, but also sets $this->sys_language_uid and
$this->sys_language_content.

Resolves: #83017
Releases: master
Change-Id: I910909ce52c2efdb02717952d67e17d8897f4d17
Reviewed-on: https://review.typo3.org/54670
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Correctly resolve dots inside flexform field names 36/51236/6
Christian Weiske [Tue, 10 Jan 2017 13:23:34 +0000 (14:23 +0100)]
[BUGFIX] Correctly resolve dots inside flexform field names

When a flexform field index attribute contained a dot, only
the last value was kept.
We now correctly append the new values to the existing ones now.

Change-Id: I73e541e834c143c33ba34f7e3f3ea7a22726b074
Resolves: #79245
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/51236
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[TASK] Visual tweak of "SelectMultipleSideBySideElement" 30/54730/2
Gianluigi Martino [Mon, 20 Nov 2017 12:47:43 +0000 (13:47 +0100)]
[TASK] Visual tweak of "SelectMultipleSideBySideElement"

The position of the buttons aside the wizard are not correct.

Releases: master, 8.7
Resolves: #83072

Change-Id: Ib60a4015b6a51997ee56381ec63fea79605b16c1
Reviewed-on: https://review.typo3.org/54730
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Prepared statement contains too many placeholders 01/54801/3
Pawel Cieslik [Mon, 27 Nov 2017 19:06:31 +0000 (20:06 +0100)]
[BUGFIX] Prepared statement contains too many placeholders

Fix method findInStorageAndNotInUidList where $uidList
contains more then 65536 records in MySQL, 64000 in Oracle,
34464 in PostgreSQL by avoiding using prepared statements
and just passing values directly in query.

Resolves: #82233
Releases: master, 8.7
Change-Id: Ic72fa540936631274ae542d3c02128e159bd3fb1
Reviewed-on: https://review.typo3.org/54801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] Only update fe_users.is_online if user is logged in 56/54756/3
Benni Mack [Fri, 24 Nov 2017 22:35:08 +0000 (23:35 +0100)]
[BUGFIX] Only update fe_users.is_online if user is logged in

The field is_online is updated in TSFE right after a user has authenticated,
but if the user has no usergroup, he/she is not logged in.

The update should be moved in the TSFE->fe_user and the check
should only be called when a logged-in user is found.

Resolves: #83086
Releases: master
Change-Id: I14b31662d99772b29e0e37153d44925b4309d69c
Reviewed-on: https://review.typo3.org/54756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Redirect to the list after save&close in text file edit form 57/54757/4
Tymoteusz Motylewski [Fri, 24 Nov 2017 23:00:24 +0000 (00:00 +0100)]
[BUGFIX] Redirect to the list after save&close in text file edit form

Clicking on the Save & Close button in the FileList
text file editing form redirects back to the list view.

Releases: master
Resolves: #83090
Change-Id: I14576da7a77835232ca9573a8964f0d754f52aff
Reviewed-on: https://review.typo3.org/54757
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Switch isset() and is_array() to null coalesce 16/52416/13
Tymoteusz Motylewski [Mon, 20 Nov 2017 10:33:42 +0000 (11:33 +0100)]
[TASK] Switch isset() and is_array() to null coalesce

Several hundred function calls and vast numbers
of indentations can be saved by using the null
coalesce operator instead of checking empty/array.

Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a
Releases: master
Resolves: #80812
Reviewed-on: https://review.typo3.org/52416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[TASK] Deprecate BE/FE delete clause methods 69/54769/5
Benni Mack [Mon, 27 Nov 2017 07:20:34 +0000 (08:20 +0100)]
[TASK] Deprecate BE/FE delete clause methods

Prior to Doctrine DBAL, all queries used the deleteClause for BE/FE
in various places, but this is gone, and this functionality is now handled
via TYPO3's Restrictions functionality within the new database API.

The left-over methods are deprecated and will be removed in TYPO3 v10.

Resolves: #83118
Releases: master
Change-Id: Iae35782b95ccd0ce180908f91de8c7430e4b83ae
Reviewed-on: https://review.typo3.org/54769
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Deprecate BackendUtility::getHash/storeHash 58/54758/4
Benni Mack [Fri, 24 Nov 2017 23:07:57 +0000 (00:07 +0100)]
[TASK] Deprecate BackendUtility::getHash/storeHash

The methods are only wrappers for the Caching framework, and come
from the time where the caching framework wasn't available.

Resolves: #83116
Releases: master
Change-Id: I6e3293f1bde654ee6548898742daa77d044d2107
Reviewed-on: https://review.typo3.org/54758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Deprecate DataHandler->newlog2() 96/54796/4
Benni Mack [Mon, 27 Nov 2017 17:14:37 +0000 (18:14 +0100)]
[TASK] Deprecate DataHandler->newlog2()

The "shorthand" method "newlog2()" is deprecated in favor of starting
to integrate a better logging API.

Resolves: #83121
Releases: master
Change-Id: Ieff947e021efb9547fd11d1c527dd072d443d6d8
Reviewed-on: https://review.typo3.org/54796
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[FEATURE] Separation of search result path to title, uri, linkTag 49/54149/7
Joerg Boesche [Fri, 15 Sep 2017 13:34:53 +0000 (15:34 +0200)]
[FEATURE] Separation of search result path to title, uri, linkTag

For styling and individual html markup of the result of indexed_search
it is now possible to get the path information in separate keys.
Introduced keys: pathTitle, pathUri.

Resolves: #82260
Releases: master
Change-Id: Iacb0e155c36778a5f1d5ed96db55c35794f6d091
Reviewed-on: https://review.typo3.org/54149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Tested-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Colorpicker in irre records 31/54731/4
Frank Naegler [Thu, 23 Nov 2017 16:04:16 +0000 (17:04 +0100)]
[BUGFIX] Colorpicker in irre records

This patch checks if a value is set before writing
a possbile empty value to the field.

Resolves: #83000
Releases: master, 8.7
Change-Id: I3badd9b9ff1a567351d971b5ae0199bf347e0f72
Reviewed-on: https://review.typo3.org/54731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Changed logical operator. 10/53610/3
Gabriel Comte [Thu, 27 Jul 2017 08:34:33 +0000 (10:34 +0200)]
[BUGFIX] Changed logical operator.

As the Exception says: It is not allowed to have a section without a type
OR a type without a section. So it is not allowed to have one without the
other, but it's allowed to have both or none of them. --> This is a
EXCLUSIVE OR situation.

Releases: master
Resolves: #81985
Change-Id: I00594b75c99b02d1950be106dc4c3389709af231
Reviewed-on: https://review.typo3.org/53610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Use general functionality for fetching templates 53/54753/3
Benni Mack [Fri, 24 Nov 2017 22:27:52 +0000 (23:27 +0100)]
[TASK] Use general functionality for fetching templates

Some places in the TYPO3 Core can use the general coding functionality
to fetch absolute URLs, but "GeneralUtility::getFileAbsFileName" should
be used in these places.

Resolves: #83084
Releases: master
Change-Id: Ic723060b4b01eac51256d54e619a7770e0ad65fa
Reviewed-on: https://review.typo3.org/54753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[FEATURE] Replace @cascade with @Extbase\ORM\Cascade 61/54761/4
Alexander Schnitzler [Sat, 25 Nov 2017 13:57:05 +0000 (14:57 +0100)]
[FEATURE] Replace @cascade with @Extbase\ORM\Cascade

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Cascade"
annotation that replaces the @cascade annotation which is
deprecated from now on.

Releases: master
Resolves: #83093
Change-Id: I1637d69b8bed0cdf85c009b43c3afd45ee7d29ff
Reviewed-on: https://review.typo3.org/54761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Send correct Cache-Control header if no client side caching 88/54788/5
Łukasz Uznański [Mon, 27 Nov 2017 12:20:45 +0000 (13:20 +0100)]
[BUGFIX] Send correct Cache-Control header if no client side caching

Add 'Cache-Control: no-store' if conditions allowing client caching
are not met. This change will prevent caching content by browser.

Resolves: #81160
Releases: master, 8.7, 7.6
Change-Id: Ia91a339178b8cd8387706679bbea40ed0d1b0548
Reviewed-on: https://review.typo3.org/54788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] fix missing l18n fields in blog tag table 86/54786/9
Sebastian Hofer [Mon, 27 Nov 2017 11:47:11 +0000 (12:47 +0100)]
[BUGFIX] fix missing l18n fields in blog tag table

The field l18n_parent was missing in table
tx_blogexample_domain_model_tag, but configured in TCA.
This causes an exception with adding a new tag in BE.
Also the field l18n_diffsource was missing in TCA and database.

* Add the fields l18n_parent and l18_diffsource to
  the databse table tx_blogexample_domain_model_tag
* Add TCA configuration for field l18n_diffsource to
  tx_blogexample_domain_model_tag TCA

Also add missing icon and label for
tx_blogexample_domain_model_dateexample.

Remove "allow tables on standard pages". This is not
necessary.

Fixes: #83113
Releases: master, 8.7
Change-Id: I10f809cc4b00df07c6e5a064bb89018578f3abf3
Reviewed-on: https://review.typo3.org/54786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[TASK] Move llXmlAutoFileName() into AbstractXmlParser 52/54752/3
Benni Mack [Fri, 24 Nov 2017 22:24:48 +0000 (23:24 +0100)]
[TASK] Move llXmlAutoFileName() into AbstractXmlParser

The global function in GeneralUtility is moved into the AbstractXmlParser.

Resolves: #83083
Releases: master
Change-Id: If4caa3c6253f994e572e5fe36bcb791e1aec2599
Reviewed-on: https://review.typo3.org/54752
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[FEATURE] Replace @transient with @Extbase\ORM\Transient 60/54760/5
Alexander Schnitzler [Sat, 25 Nov 2017 13:13:29 +0000 (14:13 +0100)]
[FEATURE] Replace @transient with @Extbase\ORM\Transient

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Transient"
annotation that replaces the @transient annotation which is
deprecated from now on.

Releases: master
Resolves: #83092
Change-Id: Ib678b5e1b9d0c3034962b9c708d84b0a3c6b0671
Reviewed-on: https://review.typo3.org/54760
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] Replace @lazy with @Extbase\ORM\Lazy 47/54747/6
Alexander Schnitzler [Fri, 24 Nov 2017 12:38:51 +0000 (13:38 +0100)]
[FEATURE] Replace @lazy with @Extbase\ORM\Lazy

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Lazy"
annotation that replaces the @lazy annotation which is
deprecated from now on.

Releases: master
Resolves: #83078
Change-Id: Ic90ee3acf220288824d506c8ed63979e1236e583
Reviewed-on: https://review.typo3.org/54747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[BUGFIX] Use config.extTarget for menu links to external URLs 54/54754/3
Benni Mack [Fri, 24 Nov 2017 22:28:50 +0000 (23:28 +0100)]
[BUGFIX] Use config.extTarget for menu links to external URLs

Resolves: #78151
Releases: master
Change-Id: I65356a01f76d1c693a45e4ba84884f6ad01cdf65
Reviewed-on: https://review.typo3.org/54754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
21 months ago[TASK] Use proper PHPdoc type annotations in Extbase error layer 82/54782/2
Oliver Hader [Mon, 27 Nov 2017 10:58:17 +0000 (11:58 +0100)]
[TASK] Use proper PHPdoc type annotations in Extbase error layer

Resolves: #83111
Releases: master, 8.7
Change-Id: Ifde44802b9cf120f1a6ba3490022ccda1458e00d
Reviewed-on: https://review.typo3.org/54782
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL 36/54436/3
Stephan Großberndt [Wed, 18 Oct 2017 14:01:26 +0000 (16:01 +0200)]
[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL

Avoid a SQL error on PostgreSQL when editing a FileStorage from FileTree
by passing the UID instead of a combined identifier like '1:/' to
EditDocumentController. Additionally fix the possibility for an SQL
error in BackendUtility::getRecord() by casting the UID.

Releases: master, 8.7
Resolves: #82799
Change-Id: I5cfde8b53767da1166ebd5f778e36ca85825a173
Reviewed-on: https://review.typo3.org/54436
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Use @DoctrineAnnotation ruleset for php-cs-fixer 80/54780/2
Alexander Schnitzler [Mon, 27 Nov 2017 10:36:48 +0000 (11:36 +0100)]
[TASK] Use @DoctrineAnnotation ruleset for php-cs-fixer

As doctrine annotations have been introduced in the core
the ruleset for proper formatting should be enabled.

Releases: master
Resolves: #83110
Change-Id: I3269fb04f4c28c066615060f98cd54290e3b5b46
Reviewed-on: https://review.typo3.org/54780
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[TASK] Ensure introduction package is properly installed 38/54038/9
Andreas Fernandez [Fri, 8 Sep 2017 18:59:28 +0000 (20:59 +0200)]
[TASK] Ensure introduction package is properly installed

Resolves: #83108
Releases: master, 8.7
Change-Id: I72d30fdab6ea3cc72078d5cf50b38915ff388fa2
Reviewed-on: https://review.typo3.org/54038
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[CLEANUP] Alwas put null at the last position 79/54779/2
Alexander Schnitzler [Mon, 27 Nov 2017 10:25:34 +0000 (11:25 +0100)]
[CLEANUP] Alwas put null at the last position

This patch applies the phpdoc_types_order rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order

Releases: master, 8.7
Resolves: #83109
Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad
Reviewed-on: https://review.typo3.org/54779
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] bamboo: Label parsing 74/54774/3
Christian Kuhn [Mon, 27 Nov 2017 09:23:05 +0000 (10:23 +0100)]
[BUGFIX] bamboo: Label parsing

The bamboo test setup relies on a funny solution to determine the
gerrit patch id and patch set, used for reporting results back
to gerrit.

The regex based solution started behaving weird with latest
bamboo versions and is now quoted slightly differently to fix that.

Special thanks to atlassian support for being friendly, helpful,
quick and providing a working solution to our issue.

Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc
Resolves: #83107
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[CLEANUP] The correct case must be used for standard PHP types in phpdoc 70/54770/4
Alexander Schnitzler [Mon, 27 Nov 2017 08:10:31 +0000 (09:10 +0100)]
[CLEANUP] The correct case must be used for standard PHP types in phpdoc

This patch applies the phpdoc_types rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types

Releases: master, 8.7
Resolves: #83106
Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770
Reviewed-on: https://review.typo3.org/54770
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Add missing initialization of GraphicalFunctions 17/54717/5
Joschi Kuphal [Wed, 22 Nov 2017 09:53:06 +0000 (10:53 +0100)]
[BUGFIX] Add missing initialization of GraphicalFunctions

Add missing initialization of the GraphicalFunctions helper
during image processing.

Resolves: #83058
Releases: master, 8.7
Change-Id: Ic5552c573f866faf3dcb0e0bc11012d83c805033
Reviewed-on: https://review.typo3.org/54717
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[CLEANUP] Remove/Replace non-standard phpdoc annotations 68/54768/3
Alexander Schnitzler [Sun, 26 Nov 2017 16:41:42 +0000 (17:41 +0100)]
[CLEANUP] Remove/Replace non-standard phpdoc annotations

Over the years many different non-standard phpdoc anotations
made it into that core which will now break the AnnotationReader
of doctrine. Therefore either all these annotations need to be
ignored or removed/replaced.

As it is easier to actually solve the issues instead of hiding them
this patch removes or replaces most non-standard annotations and
configures to ignore some of them like @extensionScannerIgnoreFile
and @extensionScannerIgnoreLine which are introduced by TYPO3 but
cannot be replaced as they provide a decent functionality

Releases: master
Resolves: #83103
Change-Id: Iba8f39600fe7273dd560592cef40ad56f83a5e73
Reviewed-on: https://review.typo3.org/54768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs 02/54602/13
Frank Naegler [Thu, 9 Nov 2017 14:02:47 +0000 (15:02 +0100)]
[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs

Because of the broken dependency manager logic in NPM this patch introduce
yarn as dependency manager for node modules.
Also this patch downgrade some libs, which was updated accidentally in past.

To install node modules you have to install yarn first and call
`yarn install`, do not use `yarn update` until you really want
update a dependency.

Resolves: #83038
Releases: master, 8.7
Change-Id: I842636241d76b88f2b9e3836230fdb6629d22fc3
Reviewed-on: https://review.typo3.org/54602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
21 months ago[BUGFIX] Don't show “cut” and “cut release” at the same time 32/54732/4
Frank Naegler [Thu, 23 Nov 2017 16:13:35 +0000 (17:13 +0100)]
[BUGFIX] Don't show “cut” and “cut release” at the same time

This patchs prevents showing “cut” and “cut release” at the same time in
the clickmenu of the page tree.

Resolves: #81890
Releases: master, 8.7
Change-Id: Ibfc07efec0f2064ffc9885047fce246cd935d368
Reviewed-on: https://review.typo3.org/54732
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[FEATURE] Exclude doktypes in path of search result 71/53671/3
Jörg Bösche [Thu, 10 Aug 2017 11:32:20 +0000 (13:32 +0200)]
[FEATURE] Exclude doktypes in path of search result

The search result has a path with the pagetree structure.
It must be possible to exclude doktypes from the path.

Releases: master
Resolves: #82070
Change-Id: I15d6bb0765aa237ab86cb75e6ffff0c26d8f504d
Reviewed-on: https://review.typo3.org/53671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
21 months ago[TASK] EXT:Scheduler: Extract HTML markup from "editAction" into Fluid 62/50962/11
Michael Oehlhof [Wed, 14 Dec 2016 22:19:44 +0000 (23:19 +0100)]
[TASK] EXT:Scheduler: Extract HTML markup from "editAction" into Fluid

Resolves: #68683
Releases: master
Change-Id: I5bb4327b685d18b6575137f166d18d9640662af2
Reviewed-on: https://review.typo3.org/50962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
21 months ago[BUGFIX] Use correct runtime cache identifier for locked records 26/54726/4
Benni Mack [Wed, 22 Nov 2017 22:44:52 +0000 (23:44 +0100)]
[BUGFIX] Use correct runtime cache identifier for locked records

The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.

A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.

Related: #79345
Resolves: #83068
Releases: master, 8.7
Change-Id: Id422fbc81b145db3559c194774334692863b4699
Reviewed-on: https://review.typo3.org/54726
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[!!!][TASK] Remove fixed year 2038 in FormEngine validation JavaScript 88/54488/8
Frank Naegler [Fri, 27 Oct 2017 15:59:47 +0000 (17:59 +0200)]
[!!!][TASK] Remove fixed year 2038 in FormEngine validation JavaScript

This patch removes the fixed year 2038 from the validation.
The validation has been simplified.

Resolves: #81973
Releases: master
Change-Id: If5577b1ce59c8a0310e6a63a8e1ac14dd8944387
Reviewed-on: https://review.typo3.org/54488
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
21 months ago[TASK] Migrate EXT:backend Login.js and UserPassLogin.js to TypeScript 71/54371/9
Frank Naegler [Wed, 11 Oct 2017 22:05:42 +0000 (00:05 +0200)]
[TASK] Migrate EXT:backend Login.js and UserPassLogin.js to TypeScript

Resolves: #82594
Resolves: #82608
Releases: master
Change-Id: Ibc3fce2983d5a193db17d8acc1c4dab2baee31db
Reviewed-on: https://review.typo3.org/54371
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Optimize FormEngineValidation, Part II 92/48192/8
Andreas Fernandez [Wed, 30 Mar 2016 13:12:08 +0000 (15:12 +0200)]
[TASK] Optimize FormEngineValidation, Part II

Some functions inside FormEngineValidation are optimized to reduce
runtime or run multiple validations on fields that are already
marked as "failed".

Resolves: #81053
Releases: master
Change-Id: I751d5e99df2b58c14f629c84b305ec49bcc0d411
Reviewed-on: https://review.typo3.org/48192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
21 months ago[BUGFIX] Fix broken back button in EXT:form 16/54716/4
Frank Naegler [Tue, 21 Nov 2017 13:04:27 +0000 (14:04 +0100)]
[BUGFIX] Fix broken back button in EXT:form

This patch fix a regression, introduced with #82668

Resolves: #83057
Related: #82668
Releases: master, 8.7
Change-Id: I421be116be6696c52733a77a94a61f81c84864f4
Reviewed-on: https://review.typo3.org/54716
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Felix Nagel <info@felixnagel.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Make category tree filterable for editors with category mounts 41/54141/6
Christoph Lehmann [Wed, 13 Sep 2017 21:34:45 +0000 (23:34 +0200)]
[BUGFIX] Make category tree filterable for editors with category mounts

TCEFORM.pages.categories.config.treeConfig.rootUid should filter
the category tree. Non-Admin users with category mounts currently
need every child category of rootUid in their category mounts
since the rootline of rootUid is not checked against the category
mounts.

Resolves: #78274
Releases: master, 8.7
Change-Id: Id02ae69111df7397207939a034ed05797eb160ad
Reviewed-on: https://review.typo3.org/54141
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[BUGFIX] Page tree nodes can be (un)mounted again 06/54706/2
Andreas Fernandez [Mon, 20 Nov 2017 18:55:06 +0000 (19:55 +0100)]
[BUGFIX] Page tree nodes can be (un)mounted again

(Un)mounting nodes in the page tree is now possible again by fixing calls
to the page tree objects.

Resolves: #83051
Releases: master, 8.7
Change-Id: I978308e301b712fa75d677337d790e4895dc997a
Reviewed-on: https://review.typo3.org/54706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Use `Storage/Persistent` in page tree 05/54705/4
Andreas Fernandez [Mon, 20 Nov 2017 18:15:54 +0000 (19:15 +0100)]
[BUGFIX] Use `Storage/Persistent` in page tree

There is a left over usage of `top.TYPO3.Storage` in the ExtJS based
page tree. This usage is replaced with the `Storage/Persistent` module.

Resolves: #83050
Related: #82603
Releases: master
Change-Id: I68a33d257599f316eb8e169121ec8408397748e8
Reviewed-on: https://review.typo3.org/54705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE 15/54715/2
Stefan Neufeind [Tue, 21 Nov 2017 12:05:42 +0000 (13:05 +0100)]
[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE

Add for/id so clicking the label toggles the checkbox.

Resolves: #83040
Releases: master, 8.7, 7.6
Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326
Reviewed-on: https://review.typo3.org/54715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] Use correct argument name in PageViewHelper 19/54719/2
Georg Ringer [Wed, 22 Nov 2017 06:55:12 +0000 (07:55 +0100)]
[BUGFIX] Use correct argument name in PageViewHelper

Fix a variable name which has been changed with the latest
refactoring to make it possible again to set links without
a cHash.

Resolves: #83063
Releases: master
Change-Id: I684d42f85a94179f19dabef5df47f09ce6b34df8
Reviewed-on: https://review.typo3.org/54719
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Fix thrown \InvalidArgumentException in access module 13/54713/2
Andreas Fernandez [Tue, 21 Nov 2017 07:10:55 +0000 (08:10 +0100)]
[BUGFIX] Fix thrown \InvalidArgumentException in access module

The returnUrl is not available if the access module is accessed via
context menu of the page tree. The module now checks whether the
returnUrl is available and renders the close button only in such case.

Resolves: #83053
Releases: master, 8.7
Change-Id: I37c5c65c1505b42acf7ac734fbc7a9f53629a6a1
Reviewed-on: https://review.typo3.org/54713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] GIFBUILDER files cannot be delivered via web server 77/54677/2
Oliver Hader [Fri, 17 Nov 2017 13:53:10 +0000 (14:53 +0100)]
[BUGFIX] GIFBUILDER files cannot be delivered via web server

GIFBUILDER uses provided file names and text snippets in order to
generate the final name for files to be written to. In case text
snippets start with a dot, this is also reflected into the file
name - preventing some web servers to deliver the file since it's
considered to be internal.

Resolves: #83029
Releases: master, 8.7
Change-Id: Iebed832c1c2429c7400373a6af4d5ae14a9ea18e
Reviewed-on: https://review.typo3.org/54677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Reload page tree if `extendToSubpages` flag changes 09/54709/2
Andreas Fernandez [Mon, 20 Nov 2017 19:28:05 +0000 (20:28 +0100)]
[BUGFIX] Reload page tree if `extendToSubpages` flag changes

Resolves: #83052
Releases: master, 8.7
Change-Id: I9d86c38f8d1749583e154bd52c77b168d20af7dc
Reviewed-on: https://review.typo3.org/54709
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] Prevent javascript error in backend 94/54694/4
Markus Günther [Mon, 20 Nov 2017 08:18:27 +0000 (09:18 +0100)]
[BUGFIX] Prevent javascript error in backend

Adding a condition to check if a backend user has permissions on the
search to prevent a JS error while initializing the autocomplete module.

Fixes: #82969
Releases: master, 8.7, 7.6
Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6
Reviewed-on: https://review.typo3.org/54694
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Catch Exception while extracting metadata 34/53834/5
rickymk [Tue, 29 Aug 2017 11:18:10 +0000 (16:48 +0530)]
[BUGFIX] Catch Exception while extracting metadata

Catch InsufficientFileAccessPermissionsException while extracting
metadata. Reason for this exception could be that the file extension is
not allowed by the ['BE']['fileDenyPattern'] setting.

This patch makes sure that the indexer doesn't break and is able to
extract the other files from storage.

Resolves: #82060
Release: master, 8.7, 7.6
Change-Id: I37950aa70f4f59b388c6b9203e1922708ad07b71
Reviewed-on: https://review.typo3.org/53834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ricky Mathew <ricky.mk@pitsolutions.com>
Tested-by: Ricky Mathew <ricky.mk@pitsolutions.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Fix sorting extensions in "Get Extensions" module 99/54699/3
Nicole Cordes [Mon, 20 Nov 2017 14:33:53 +0000 (15:33 +0100)]
[BUGFIX] Fix sorting extensions in "Get Extensions" module

During some Doctrine cleanup the constraint for fetching extension by
extension key got messed up. This patch removes double named parameter
in search constraint.

Resolves: #80555
Releases: master, 8.7
Change-Id: I84636b4a86d8b3946c552031e3cb23ae69cd3f2a
Reviewed-on: https://review.typo3.org/54699
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Fix notices in Filelist module 51/54651/4
Tymoteusz Motylewski [Thu, 16 Nov 2017 12:01:20 +0000 (13:01 +0100)]
[BUGFIX] Fix notices in Filelist module

Resolves: #83002
Releases: master
Change-Id: I06c09f282df7fdcc0d8af11d65c5113f33a9c849
Reviewed-on: https://review.typo3.org/54651
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[TASK] Example for a RTE Flexform config after migration 79/54679/6
Velletti [Sat, 18 Nov 2017 11:03:23 +0000 (12:03 +0100)]
[TASK] Example for a RTE Flexform config after migration

Releases: master, 8.7
Resolves: #83031
Change-Id: I918ef9ca5ae28f9c605e3c7940cea53b6ed3325a
Reviewed-on: https://review.typo3.org/54679
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Fix class name of success button in the install tool 93/54693/4
Markus Günther [Mon, 20 Nov 2017 10:46:09 +0000 (11:46 +0100)]
[BUGFIX] Fix class name of success button in the install tool

Releases: master, 8.7, 7.6
Fixes: #83044
Change-Id: I2c16f160a18f4c0e58b87261b59fbde90aca2f82
Reviewed-on: https://review.typo3.org/54693
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
21 months ago[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE 82/54682/2
Markus Klein [Sun, 19 Nov 2017 01:34:46 +0000 (02:34 +0100)]
[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE

Move the hidden form field out of the label tag to ensure clicking
the label's content (eg. fa icon) really toggles the checkbox.

Resolves: #82998
Releases: master, 8.7, 7.6
Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4
Reviewed-on: https://review.typo3.org/54682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGIFX] Fix JS error in filtering page tree 88/54688/2
Helmut Hummel [Sun, 19 Nov 2017 20:12:18 +0000 (21:12 +0100)]
[BUGIFX] Fix JS error in filtering page tree

While fixing #82877 a mistake was introduced which leads
to a JavaScript error when filtering the page tree.

Problem is that PageTree.select() is called with
the filter tree currently active, but this method
is only functional for the full page tree since quite
a while now.

We now avoid calling this method and document the behavior
properly in method annotations.

Additionally a typo in the variable name is fixed,
which lead to a jquery warning when selecting a page.

Resolves: #83039
Releases: master, 8.7
Change-Id: I6440fb7f6cfd6ead8b5b29dea7c5081dd688a5c3
Reviewed-on: https://review.typo3.org/54688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Tested-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[FEATURE] Show page translations in list module 30/54530/10
Benni Mack [Thu, 2 Nov 2017 11:04:34 +0000 (12:04 +0100)]
[FEATURE] Show page translations in list module

Translations of the current page can now be listed and edited through the
list module again.

This is a follow-up change to the pages_language_overlay removal.

Resolves: #83016
Releases: master
Change-Id: I38b41ba6b1b3164ab1b9cdfc03bca14780c38c08
Reviewed-on: https://review.typo3.org/54530
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] use included TSconfig files in frontend 76/54276/4
Jigal van Hemert [Tue, 3 Oct 2017 21:47:10 +0000 (23:47 +0200)]
[BUGFIX] use included TSconfig files in frontend

The files included in the field tsconfig_includes are now included
when collecting the page TSconfig in the TypoScriptFrontendController.

Resolves: #82662
Releases: master, 8.7
Change-Id: I226f942045647a3b7c4130b9e5d39b6d982efd1b
Reviewed-on: https://review.typo3.org/54276
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[TASK] Correct link to a 7.6 changelog resource 73/54673/2
Robert Wildling [Fri, 17 Nov 2017 11:06:54 +0000 (12:06 +0100)]
[TASK] Correct link to a 7.6 changelog resource

The link pointing to the positioning of own handlers (a changelog of v7.6)
was missing a version paramater after "core/".

Releases: master
Resolves: #83025
Change-Id: I52d22ad30b4669b2fe59728551a24f761efd423d
Reviewed-on: https://review.typo3.org/54673
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[FEATURE] Hook to modify the display results before FluidView assignment 48/54148/6
Joerg Boesche [Fri, 15 Sep 2017 08:45:40 +0000 (10:45 +0200)]
[FEATURE] Hook to modify the display results before FluidView assignment

To modify the display result rows before data is assigned to the fluid
view there is a new hook inside the `getDisplayResults()` method
called `getDisplayResults_postProc`.

Resolves: #82488
Releases: master
Change-Id: I2f0ac073692fb28b9c71a18def027c71a418606f
Reviewed-on: https://review.typo3.org/54148
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[!!!][TASK] Always use "Localization view" in list module 33/54633/8
Benni Mack [Tue, 14 Nov 2017 06:30:01 +0000 (07:30 +0100)]
[!!!][TASK] Always use "Localization view" in list module

When working with localizations in a system,
the option "Localization view" in the list module is
a pre-requisite for all editors, for all installations
without languages, the checkbox is not necessary.

To streamline this behaviour, the option is removed
and the functionality is enabled BY DEFAULT.

Resolves: #82991
Releases: master
Change-Id: I2005413405d009935e3b7d7d046e4aac284ee013
Reviewed-on: https://review.typo3.org/54633
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Set l10n_state before synchronizing fields 57/54657/8
Helmut Hummel [Wed, 15 Nov 2017 17:17:49 +0000 (18:17 +0100)]
[BUGFIX] Set l10n_state before synchronizing fields

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Resolves: #83006
Releases: master, 8.7
Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f
Reviewed-on: https://review.typo3.org/54657
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Fix keepItems and removeItems handling with 0 values 23/54623/2
Helmut Hummel [Sun, 12 Nov 2017 18:27:49 +0000 (19:27 +0100)]
[BUGFIX] Fix keepItems and removeItems handling with 0 values

TSConfig properties keepItems and removeItems are checked
with a weak in_array() test (third argument not set to true),
which leads to the situation, that arbitrary string values
are treated equal to integer 0

This is now fixed by flipping the array and check for the
array index. This works nicely because PHP silently
converts strings which look like integer to integer for the keys.

Tests are added which cover these cases and demonstrate
the failure before the change.

Resolves: #82980
Releases: 8.7, master
Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f
Reviewed-on: https://review.typo3.org/54623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[FOLLOWUP][TASK] FAL-based database fields moved to integer 68/54668/2
Oliver Hader [Thu, 16 Nov 2017 17:19:56 +0000 (18:19 +0100)]
[FOLLOWUP][TASK] FAL-based database fields moved to integer

Remove duplicated "image" field definition in test scenario.

Related: #69909
Releases: master, 8.7
Change-Id: Ie87e2e62e036fa70fb837f9bd05f2c3ba13019fa
Reviewed-on: https://review.typo3.org/54668
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Avoid invalid references in DataMapProcessor 55/54655/6
Oliver Hader [Wed, 15 Nov 2017 15:07:57 +0000 (16:07 +0100)]
[BUGFIX] Avoid invalid references in DataMapProcessor

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Resolves: #83009
Releases: master, 8.7
Change-Id: Ie370007521c45dac8bca03978a387b4662952b1d
Reviewed-on: https://review.typo3.org/54655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[FEATURE] Replace @inject with @TYPO3\CMS\Extbase\Annotation\Inject 90/54590/10
Alexander Schnitzler [Wed, 8 Nov 2017 13:57:33 +0000 (14:57 +0100)]
[FEATURE] Replace @inject with @TYPO3\CMS\Extbase\Annotation\Inject

This patch introduces the usage of doctrine annotations.
Therefore the AnnotationRegistry is configured during the
bootstrap and the annotation "TYPO3\CMS\Extbase\Annotation\Inject"
is evaluated when building a ClassSchema for a class.

On top of that this patch puts the static variable
$ignoredTags into the DocCommentParser class, which
saved quite some bytes of RAM when reconstituting
the ClassSchema objects from the cache.

Resolves: #82869
Releases: master
Change-Id: I99d17706395ebc0c308c7f611c59f207fe0b6233
Reviewed-on: https://review.typo3.org/54590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Fix notices in UserAuthentication 52/54652/3
Tymoteusz Motylewski [Wed, 15 Nov 2017 14:20:07 +0000 (15:20 +0100)]
[BUGFIX] Fix notices in UserAuthentication

Resolves: #83003
Releases: master, 8.7
Change-Id: Iceaa7ab9bd436322229e591677c0aee16cd69f5c
Reviewed-on: https://review.typo3.org/54652
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Add correct conversion of RTE pageTS config 11/54511/8
Frans Saris [Tue, 31 Oct 2017 15:32:51 +0000 (16:32 +0100)]
[BUGFIX] Add correct conversion of RTE pageTS config

Add all pageTS.RTE options to config without dots appended to the key
to be able to override the RTE config with pageTS like before.

Resolves: #82865
Releases: master, 8,7
Change-Id: Idb7d7d3b39d44ec37be8f93cc9de8b42b9c8a55c
Reviewed-on: https://review.typo3.org/54511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Remove "[newlog()] " from DataHandler log info 60/54660/2
Benni Mack [Thu, 16 Nov 2017 11:10:55 +0000 (12:10 +0100)]
[BUGFIX] Remove "[newlog()] " from DataHandler log info

DataHandlers' newlog() function is a shorthand method that
should act as a simple API, which it does, but it also adds
a "[newlog()] " info in front of the error message, which is
completely useless and only clutters DB and the log module.

Resolves: #83012
Releases: master, 8.7
Change-Id: I9e1ea083461de9cdf66fad1a30019e51130a0186
Reviewed-on: https://review.typo3.org/54660
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Use correct parameters for trimExplode 40/54640/3
Wouter Wolters [Tue, 14 Nov 2017 18:05:15 +0000 (19:05 +0100)]
[BUGFIX] Use correct parameters for trimExplode

In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of
trimExplode is inserted. To prevent notices array_pad is added.

Resolves: #82995
Releases: master,8.7
Change-Id: If35efcf5c8c3fd5b0360ae8795f9b92ae87250ab
Reviewed-on: https://review.typo3.org/54640
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
22 months ago[BUGFIX] Fix some PHP Notices thrown when rendering page module 58/54558/9
Tymoteusz Motylewski [Mon, 6 Nov 2017 08:12:26 +0000 (09:12 +0100)]
[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[BUGFIX] Do not iterate over empty logger configuration 53/54653/2
Tymoteusz Motylewski [Wed, 15 Nov 2017 14:23:32 +0000 (15:23 +0100)]
[BUGFIX] Do not iterate over empty logger configuration

Fixes PHP notices thrown by accessing non existing array key.

Resolves: #83004
Releases: master
Change-Id: Ib5ff0ace0c9eb9a9987693176c4bee25026e2eb8
Reviewed-on: https://review.typo3.org/54653
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[FEATURE] Add hook for used/unused content record processing 11/53811/15
Claus Due [Sat, 26 Aug 2017 19:28:43 +0000 (21:28 +0200)]
[FEATURE] Add hook for used/unused content record processing

This patch adds a new hook to determine whether a content record is
used or not. Since the default decision is fairly basic (only checks if
$columns contains $record['colPos']) a hook makes it possible for third
party extensions to change the decision and validate on their own.

Included rst file shows how to register to the hook and provides example
code how to determine the result.

Resolves: #82213
Releases: master
Change-Id: Id338254dae6575ba7b91141c10a42b99401614c9
Reviewed-on: https://review.typo3.org/53811
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] FileStorageExtractionTask breaks if file not found 69/51969/7
Thomas Hohn [Tue, 7 Mar 2017 07:19:46 +0000 (08:19 +0100)]
[BUGFIX] FileStorageExtractionTask breaks if file not found

Before the file is processed a extra check is done to be sure the file
exists. If the file doesn't exist it's marked as missing.

Resolves: #80061
Releases: master, 8.7
Change-Id: Ifda396b75d2ace0ce126057a4e118856b15c05e0
Reviewed-on: https://review.typo3.org/51969
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] Allow all fields in felogin hook "forgotPasswordMail" 28/54628/5
Tom Novotny [Mon, 13 Nov 2017 14:56:51 +0000 (15:56 +0100)]
[TASK] Allow all fields in felogin hook "forgotPasswordMail"

Return all fields to ease the work with hooks.
Intention is not having to query again in hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['forgotPasswordMail']
to change "Hello [username],..." to "Hello [fist_name] [last_name],..."
in password forgot mail to user.

Change-Id: I18e18845e61d36aadd043758f902dc6627ad5f37
Resolves: #82996
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54628
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 19/54619/5
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/54619
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Ensure "pid" and "parentid" of pages - inline fields are correct 32/54632/6
Benni Mack [Mon, 13 Nov 2017 19:33:53 +0000 (20:33 +0100)]
[BUGFIX] Ensure "pid" and "parentid" of pages - inline fields are correct

When doing translations with pages and inline elements (e.g. pages.media),
there is an inconsistency when an additional inline element is added to the
TRANSLATED page (e.g. language=1).

Current (wrong) when adding a translation to a page
- localized IRRE children get pid = default page ID (correct)
- localized IRRE children only localization get parentid = default page ID (should be translated page ID)

Current (wrong) behaviour when adding a IRRE child only available in a translation:
- parentid gets localized page => correct
- pid gets set to localized page => must be default language

The patch corrects this behaviour by always set
- the relation (parentid) to the localized page ID
- the page ID (pid) to the default language page ID

Additionally, when adding an Inline element (IRRE) via AJAX
on page properties, the PID gets resolved correctly to be sent
to DataHandler.

Resolves: #82983
Releases: master
Change-Id: Id8bf39524ee608acf452e2b7103087d4299c1e28
Reviewed-on: https://review.typo3.org/54632
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Do not silently ignore exceptions in ImageViewhelper 61/54561/5
Sascha Egerer [Fri, 3 Nov 2017 19:48:56 +0000 (20:48 +0100)]
[TASK] Do not silently ignore exceptions in ImageViewhelper

Exceptions in the ImageViewhelper are currently silently ignored.
So you'll get no information if a wrong value has been passed
to the src attribute or if there went something wrong.
The exception is not rethrown as Fluid viewhelper exception so
it will be catched and logged in Production Context by the
AbstractViewhelper that calls the render method.

Change-Id: I95124ebb945366d260b4351ccb85d61a399c50b5
Resolves: #82918
Releases: master
Reviewed-on: https://review.typo3.org/54561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
22 months ago[BUGFIX] Stabilize Language Acceptance tests 31/54631/10
Mathias Schreiber [Mon, 13 Nov 2017 17:57:01 +0000 (18:57 +0100)]
[BUGFIX] Stabilize Language Acceptance tests

Stabilize the acceptance tests to activate and deactivate a language by
checking only for the alerts instead of the enabled/disabled rows.

Additionally make the download a language test fail immediately if the
language is enabled.

Resolves: #82972
Releases: master, 8.7
Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e
Reviewed-on: https://review.typo3.org/54631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Remove orderBy in count query 38/54638/2
Susanne Moog [Tue, 14 Nov 2017 14:19:25 +0000 (15:19 +0100)]
[BUGFIX] Remove orderBy in count query

OrderBy does not make sense in a count only query and
fails on SQL Server, hence it is removed.

Change-Id: I676d1913f75c29dd71345dbc0f626e99df0d242f
Resolves: #82994
Releases: master
Reviewed-on: https://review.typo3.org/54638
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility 00/54600/5
Mathias Brodala [Thu, 9 Nov 2017 08:42:04 +0000 (09:42 +0100)]
[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility

Variadic arguments are optional but do not have a default value, thus
properly check this.

Also render the variadic operator ("...") in the output.

Resolves: #82956
Releases: master, 8.7
Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775
Reviewed-on: https://review.typo3.org/54600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Add label to page ID field in PageLinkHandler 75/54575/4
Georg Ringer [Tue, 7 Nov 2017 07:08:42 +0000 (08:08 +0100)]
[BUGFIX] Add label to page ID field in PageLinkHandler

Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54575
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[TASK] Deprecate usage of @inject with non-public properties 18/54618/7
Alexander Schnitzler [Sat, 11 Nov 2017 13:53:26 +0000 (14:53 +0100)]
[TASK] Deprecate usage of @inject with non-public properties

When using private or protected properties for Dependency Injection
via `@inject`, Extbase needs to use the object reflection API to
make these properties settable from the outside, which is quite
slow and cannot be cached in any way. Therefore property injection
should only work for public properties.

Releases: master
Resolves: #82975
Change-Id: Ia9c6eb48c34c46634e626f7cd97a2e743a6aba7b
Reviewed-on: https://review.typo3.org/54618
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion 14/54614/6
Andreas Fernandez [Sun, 5 Nov 2017 12:09:17 +0000 (13:09 +0100)]
[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion

With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported
by code completion.

Resolves: #82967
Releases: master, 8.7
Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc
Reviewed-on: https://review.typo3.org/54614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[TASK] Upgrade chromedriver to 2.33 29/54629/4
Christian Kuhn [Mon, 13 Nov 2017 16:53:48 +0000 (17:53 +0100)]
[TASK] Upgrade chromedriver to 2.33

Use latest chromedriver to deal with youngest chrome
in acceptance tests.

Change-Id: I7d637022fa9e327e771198625943b11b986b5a04
Resolves: #82987
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Improve performance iterating local files 76/54576/4
Stephan Großberndt [Tue, 7 Nov 2017 08:44:24 +0000 (09:44 +0100)]
[BUGFIX] Improve performance iterating local files

Improve performance iterating local files by avoiding multiple calls to
SplFileInfo.

Releases: master, 8.7
Resolves: #82936
Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc
Reviewed-on: https://review.typo3.org/54576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
22 months ago[BUGFIX] Fix path-resolution for template-resource in EXT:felogin 22/54622/4
Daniel Siepmann [Sun, 12 Nov 2017 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Fix path-resolution for template-resource in EXT:felogin

Do not use frontend inclusion API for private template resource.
Instead resolve to full absolute path for inclusion.

Releases: master, 8.7
Resolves: #82978
Resolves: #82979
Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734
Reviewed-on: https://review.typo3.org/54622
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[FOLLOWUP][TASK] Migrate pages_language_overlay into pages 91/54591/2
Benni Mack [Wed, 8 Nov 2017 13:25:24 +0000 (14:25 +0100)]
[FOLLOWUP][TASK] Migrate pages_language_overlay into pages

An additional SQL index is added to the database.

Resolves: #82445
Releases: master
Change-Id: I94d1eab5f492b465fafbf3620b0f532e1403be76
Reviewed-on: https://review.typo3.org/54591
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots 07/54007/7
Oliver Hader [Fri, 8 Sep 2017 10:43:03 +0000 (12:43 +0200)]
[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54007
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Add missing code-block:: php line in feature rst file 12/54612/2
Frans Saris [Fri, 10 Nov 2017 10:54:40 +0000 (11:54 +0100)]
[BUGFIX] Add missing code-block:: php line in feature rst file

Resolves: #82964
Releases: master, 8.7
Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233
Reviewed-on: https://review.typo3.org/54612
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
22 months ago[BUGFIX] Show deleted page actions in record history 80/54580/5
Helmut Hummel [Tue, 7 Nov 2017 14:09:08 +0000 (15:09 +0100)]
[BUGFIX] Show deleted page actions in record history

Because users have no access to deleted pages,
the access check always fails, leading to delete page
actions not being shown in the history despite being
properly tracked.

We now check this case and do a more lightweight check
so that we still have the permissions checked,
but can show deleted pages without disclosing unwanted
information.

Resolves: #45056
Releases: 7.6, 8.7, master
Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c
Reviewed-on: https://review.typo3.org/54580
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] Update typo3/cms-composer-installers 70/54570/3
Alexander Opitz [Mon, 6 Nov 2017 12:05:21 +0000 (13:05 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest (1.4.5) release.
This version is marked as PHP 7.2 compatible.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7
Reviewed-on: https://review.typo3.org/54570
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[TASK] EXT:form - cache merged YAML settings 06/54106/7
Ralf Zimmermann [Sun, 10 Sep 2017 16:51:35 +0000 (18:51 +0200)]
[TASK] EXT:form - cache merged YAML settings

Cache the merged YAML settings into the assets cache to improve the
performance.

Resolves: #82373
Releases: master, 8.7
Change-Id: I601364d5957f26f1b369b513534936820f72b78e
Reviewed-on: https://review.typo3.org/54106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Reduce PHP queries of pagetree SQL 74/54574/13
Benni Mack [Tue, 7 Nov 2017 06:36:31 +0000 (07:36 +0100)]
[TASK] Reduce PHP queries of pagetree SQL

The TYPO3 Backend PageTree, built in TYPO3 4.5, has
some strange quirks resolving DB records, doing
a lot of queries for fetching a single page multiple
times. This is unnecessary because this can be fetched
with one query, which happens anyway. Additionally,
the WSOL should only happen when a workspace is selected.

Explicitly querying for "-1" pid etc. should be handled
via SQL, and not explicitly implemented by the page tree.

Bottom line: Remove one SQL-query per page which is loaded.

As most of the PHP classes will be restructured with the upcoming
ExtJS / ExtDirect removal, the removed methods will be part
of the breaking change of ExtJS removal.

Resolves: #82945
Releases: master
Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e
Reviewed-on: https://review.typo3.org/54574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Properly encode text in JS in install tool 86/54586/4
Susanne Moog [Wed, 8 Nov 2017 14:30:11 +0000 (15:30 +0100)]
[BUGFIX] Properly encode text in JS in install tool

Several times the install tool was using html()
instead of text(). Use text() whenever possible.

Resolves: #82949
Releases: master
Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a
Reviewed-on: https://review.typo3.org/54586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] Update ext:styleguide to 9.0.0 92/54592/4
Christian Kuhn [Wed, 8 Nov 2017 14:54:06 +0000 (15:54 +0100)]
[TASK] Update ext:styleguide to 9.0.0

The v9/master branch of styleguide generates correct
page localizations of styleguide demo data pages in
table pages instead of pages_language_overlay.

Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc
Resolves: #82952
Related: #82445
Releases: master
Reviewed-on: https://review.typo3.org/54592
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update ext:styleguide to 8.0.13 88/54588/3
Christian Kuhn [Wed, 8 Nov 2017 13:03:51 +0000 (14:03 +0100)]
[TASK] Update ext:styleguide to 8.0.13

This is probably the last version with v8 and v9
in sync before branching off styleguide v8.

Styleguide introduced a new table with 8.0.13, one
of the acceptance tests that uses a rather hard coded
xpath now needs a slightly different selector to cope
with that.

Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0
Resolves: #82951
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page 87/54587/3
Andreas Fernandez [Wed, 8 Nov 2017 12:31:17 +0000 (13:31 +0100)]
[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page

Ensure that jQuery is available in NewRecordController.

Resolves: #75676
Releases: master
Change-Id: Idf437554fb136e8e4ae18ce0d229d6b3ed8a58e4
Reviewed-on: https://review.typo3.org/54587
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
22 months ago[FEATURE] Load new content element wizard via modal instead of new page 99/52999/40
Cybercraft [Thu, 1 Jun 2017 16:22:40 +0000 (18:22 +0200)]
[FEATURE] Load new content element wizard via modal instead of new page

Instead of having the new content element wizard in a separate module page
it will be opened in a modal now.

Resolves: #75676
Releases: master
Change-Id: If117fe3f2d55a4163bcb5c153b47938953050348
Reviewed-on: https://review.typo3.org/52999
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>