[BUGFIX] ArrayIterator::seek() warning in ElementBrowser

ElementBrowser calls Folder::getFiles() with wrong parameters.
Properly implement the file extensions filter.

Resolves: #51752
Releases: 6.2, 6.1, 6.0
Change-Id: I56468c79225e2d3baa5e5784571074532e2287ad
Reviewed-on: https://review.typo3.org/25359
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[BUGFIX] Uncaught exception if editor has no file mount

If an editor has got no file mounts, an uncaught exception
is shown in the element browser.

Fix this by checking if there is a selected folder at all.

Resolves: #52969
Releases: 6.2
Change-Id: I5f9e8cc7994edd69f6db6ae1cc647ee31e4930c6
Reviewed-on: https://review.typo3.org/25357
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[BUGFIX] felogin: Unknown modifier in regular expression

A regular expression in FrontendLoginController
contains an unknown modifier. Fix it by replacing the
/ to # at the beginning and the end of the regular
expression.

Change-Id: Id4d3439c1cdbec691d977570bf76ba0c7bad493c
Resolves: #52059
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23881
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Form Wizard saving destroys Radio Buttons

This fixes a wrong parsing of \r\n characters for radio
button options.

Resolves: #53727
Releases: 6.2, 6.1, 6.0
Change-Id: I9a88be010a7dd982776bee4a98ba99d97fcc406b
Reviewed-on: https://review.typo3.org/25482
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Remove ElementBrowser::isReadOnlyFolder

ElementBrowser::isReadOnlyFolder is not required any more because the
check if the folder is writable has been moved to the methods that
create the file upload and folder creation forms.

The method and the parts where it was used were removed.

Additionally the check if the user is allowed to create folders
by TSConfig was moved to the createFolder method to reduce the amount
of duplicate code.

Resolves: #47648
Releases: 6.2, 6.1, 6.0
Change-Id: Ic6504c8def80012cbe420fc83539cfa859a53c0d
Reviewed-on: https://review.typo3.org/25358
Reviewed-by: DANIEL Rémy
Tested-by: DANIEL Rémy
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[BUGFIX] Pagetree pointer cursor broken since ExtJS upgrade

Icons in the pagetree should show cursor:pointer on hover.
This changed with ExtJS-upgrade in #52933 because of
x-unselectable.

Since in the pagetree we need x-unselectable unfortunately
manually bring back the old cursor-behaviour.

Change-Id: If6fa45b0e3491d9180855a4d0a462c5fb559d476
Resolves: #54238
Releases: 6.2
Reviewed-on: https://review.typo3.org/26099
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[TASK] Cleanup usage of getPageRenderer()

Change-Id: Id2dc49c9a5e5ca3ede14bc82218dd9ccdc7628ca
Resolves: #54123
Releases: 6.2
Reviewed-on: https://review.typo3.org/25844
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] fileadmin is hardcoded in install tool

In the class "DefaultFactory", "fileadmin" is hardcoded.
The function "getDefaultStructureDefinition"
must take care of the $GLOBALS['TYPO3_CONF_VARS']
['BE']['fileadminDir'] configuration variable.

Resolves: #53872
Releases: 6.2
Change-Id: I17c836a58ea70d218170a33e28ca578bb50eef0b
Reviewed-on: https://review.typo3.org/25640
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Superfluous comparison in OpendocsController

Fix superfluous comparison against boolean in
OpendocsController::checkAccess

Change-Id: I0682042848f2f25856506d5949fc724853c43948
Resolves: #54052
Releases: 6.2
Reviewed-on: https://review.typo3.org/25739
Reviewed-by: Jo Hasenau
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Superfluous comparison in DataHandler

Fix superfluous comparison against boolean in
DataHandler::versionizeRecord

Change-Id: I345917b9eb29f3cbb39a137f624926888dec623a
Resolves: #54051
Releases: 6.2
Reviewed-on: https://review.typo3.org/25738
Reviewed-by: Jo Hasenau
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Superfluous comparison in RelationHandler

Fix superfluous comparison against boolean in
RelationHandler::readForeignField

Change-Id: I77f17dee6a14da7779dfe8e37bc73f33a3d02cb5
Resolves: #54048
Releases: 6.2
Reviewed-on: https://review.typo3.org/25735
Reviewed-by: Jo Hasenau
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Superfluous comparison in Language

Fix superfluous comparison against boolean in
Laguage::getLanguages

Change-Id: Idbf4c1f234eb1c60c01ea130095759ef49ce71c0
Resolves: #54054
Releases: 6.2
Reviewed-on: https://review.typo3.org/25741
Reviewed-by: Xavier Perseguers
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Fix side effect for new class instantiation

With commit 6eb7a54 performance optimized class
instantiation code has been committed. This code
removed the side effect of a reflection exception
being thrown when a not existing class is instantiated.

Code in ContentObjectRenderer relied on this side
effect, so we have to fix that and properly test
if the class exists instead.

Additionally this change adds some more comments
to the new instantiation code that has been forgotten
in the last commit.

Resolves: #54425
Releases: 6.2
Change-Id: I8962434d60f80daf77ccdce7a8148e26f8fee267
Reviewed-on: https://review.typo3.org/26440
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Anja Leichsenring
Reviewed-by: Anja Leichsenring
Tested-by: Tobias Liegl
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[TASK] Optimize speed for instantiating class with arguments

PHP reflection has quite an overhead in performance.
Use a switch construct like in Flow instead to
instantiate classes with up to 8 arguments without
reflection.

Resolves: #53682
Releases: 6.2, 6.1, 6.0
Change-Id: I82ecf0b1ea9a412a39b4429d7689f2bb6489f3df
Reviewed-on: https://review.typo3.org/26363
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Create valid file reference index data

This patch prevents the creation of sys_refindex entries that point to no
table and no record.

Additionally it fixes the array structure for the creation of
sys_refindex records for sys_file relations.

For deleted file references no reference will be created between
sys_file and the referenced table.

The configuration for the uid_foreign field was changed from a select
field for tt_content records to a normal input field to prevent the
creation of invalid refindex data. To which table uid_foreign is
pointing depends on the tablenames field.

To make sure both sides of the relation of a sys_file_reference appear
in the refindex table the exclusion of sys_file_reference as
foreign_table is removed.

Resolves: #53712
Releases: 6.2, 6.1, 6.0
Change-Id: Ic864ade10e4e97fbd9017b9c779be68d911dd626
Reviewed-on: https://review.typo3.org/25476
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[BUGFIX] Followup Fluid Template Fallback paths

In the previously merged patch are some glitches and a regression:
- The usage (and test for existence) of deprecated functions has been
  removed.
- The value passed by the old behaviour is now considered last place
  in the array providing the lookup paths
- The typo preventing usage setLayoutPaths() has been removed.

Intended usage:
plugin.tx_a.view.templateRootPaths {
default = <some default path>
extendedA = <some additional path>
}
The array gets reversed and the first hit will be used as template.
In case only numeric indizes are used, the entries get ordered.
See unit tests for a more specific description.

Change-Id: If4fa75347614cf9b352c6016430a928833cc62cd
Resolves: #52971
Documentation: #52761
Releases: 6.2
Reviewed-on: https://review.typo3.org/24903
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

[BUGFIX] No double htmlspecialchars for filemount select

Since the labels and values of select items are run through
htmlspecialchars by the FormEngine there is no need to use
htmlspecialchars in the renderTceformsSelectDropdown() method which
generates the select items for the filemount Backend form.

The current code will htmlencode the select value twice which results
in a htmlencoded value in the database which causes problems with
directory names that contain special characters.

Resolves: #54027
Releases: 6.2, 6.1, 6.0
Change-Id: I7ec8262f6c3d20879cde0679636a6a8e5c1d19cd
Reviewed-on: https://review.typo3.org/25770
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Fix travis builds

Due some regressions on side of travis
(https://github.com/travis-ci/travis-ci/issues/1710) an older git version
is used which doesn't support things like "--single-branch".

To avoid this, git is updated to latest version on the build server before
starting cloning

Change-Id: Ic5f698e84f378b9fed6bd64398b8058a20be860e
Resolves: #54369
Releases: 6.2
Reviewed-on: https://review.typo3.org/26366
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[BUGFIX] Clear statcache after writing file contents

To make sure calls to filesize() etc. return correct values the PHP
method clearstatcache() is called in the LocalDriver after contents
were written to a file.

Resolves: #54302
Releases: 6.2
Change-Id: Ia30e519d17aa3cf37856096f1cdac567b5729aec
Reviewed-on: https://review.typo3.org/26278
Reviewed-by: Markus Klein
Reviewed-by: Frans Saris
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[SECURITY] XSS in header link of all content elements

The second typolink parameter, that is the target, can be abused to
introduce XSS code into the generated link. Escaping the parameter
with quoteJSvalue solves the problem.

Change-Id: Ie91b022a2ffed039fb365e6b0be2ea39f7096514
Fixes: #31206
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 484cf1aea8d3e66db547325fe4d843d50a668162
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26225
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] XSS in colorpicker wizard

Encode user-input in JavaScript context for colorpicker.

Change-Id: I1121d6d20c90e476a2d0ea4f000b180e843a4ce0
Fixes: #42772
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: b6fec0611604ccdce95d4d33cd7dcae0911a5d9a
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26224
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] Prevent editor controlled hmac content

An hmac of the editor controlled auto respond message was used to verifiy
the correctness of this message on submit. To prevent this, we add an
additional secret.

Change-Id: I1551feebd4dd84abeb3fb098175384f425f605a9
Fixes: #45043
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: 344975268f4b9eb4ce7c664958647b9268ea03a8
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26223
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] XSS in backend user adminstration

Change-Id: I88807af69635d75f1fbefc62b4672e945397fb07
Fixes: #48691
Releases: 6.2, 6.1, 6.0
Security-Commit: 715b2c58c53f0109acce8c52df08d5dffea79f49
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26222
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] Information Disclosure in Wizards

It has been possible for authenticated editors
to show content of arbitrary tables and fields
that are defined in TCA by manipulating
GET parameters of the forms and table wizard.

This change adds a check if the editor has access
to the given record.

Change-Id: I8e27e5ffbccf148d951b50b21d9e15cc8e317442
Fixes: #41714
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: 52d4e3eced81639820db6d75f3d65d14c5234072
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26221
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] Fix open redirection in openid extension

The eID script of the openid extension does not
validate the given redirect url, leading to
an open redirection vulnerability.

Add and verify hmac of the redirect url.

Change-Id: I0d65390b61dd5cf92151d36e490a194624b98b8f
Fixes: #54099
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 5c6a45c0f843a93ab048a3df4bb352b8e02099b2
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26220
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] XSS in be_layout wizard

Usage of unverified input parameters in wizard URL leads to a possible
XSS vulnerability in backend_layout wizard.
The solution is the introduction of a hmac validation of the parameters
used in JavaScript.

Change-Id: I48f89309fc062d132e283d4fd9179ccbfdcfda4c
Fixes: #36768
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: a3ac48f5d66c566d241295d87cc8d7eb4d10c274
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26219
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] XSS in beuser VH

The tree Display/* ViewHelpers introduce a XSS vulnerability by
using unescaped parameters in HTML.

Change-Id: I0dadb03105d3eaa520f10f0375a46c83fa56c269
Fixes: #47086
Releases: 6.2, 6.1, 6.0
Security-Commit: 1e0f51f204efd9efacec8aef8ea08e2a8122177b
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26218
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] Remove possible XSS from ActionController Error output

As parameters passed to an ErrorObject can be user input, the
output of those parameters in the ActionController::errorAction() method
could lead to a cross side scripting possibility.

The offending output has been removed without substitution.

Change-Id: I01385c54bb384a86fc6428f67171e7010b821cc2
Fixes: #54074
Releases: 6.2, 6.1, 6.0, 4.7. 4,5
Security-Commit: ec947ba22bd673827899c5e82857b293dff8b4b0
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26217
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[SECURITY] Unsafe unserialize of GET parameter in Add-Wizard

If the TCEforms wizard "add" is used, the original opened document
is closed and a new one is created in which you then add a new
element to be related.

In order to "store" the originating document which has been
edited, the Wizard/AddController and EditDocumentController
exchange state data in an URL-parameter.

This state-array is serialized in the EditDocumentController
and again unserialized in the Wizard/AddController from that
GET parameter. Without any checks, every code can be injected
to be unserialized here - even though we just need an array
with some data.

This patch changes serialize/unserialize to json_encode and
json_decode. Since the GET parameter only is used in
conjunction of these two classes it is save to changes the
format how the URL parameters are serialized.

Change-Id: I3b41bd0a688f067af2ea4a345ce0264f61bdecf7
Fixes: #54073
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 7148349140f9c8ccb6d847ef58cf1e032711315b
Security-Bulletin: TYPO3-CORE-SA-2013-004
Reviewed-on: https://review.typo3.org/26216
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Revert "[FEATURE] Fallback/default case for SwitchViewhelper"

This reverts commit 8e022bcbea4f7775ce10fee30b4682a6047c461c

Merged a Feature after Feature Freeze is not acceptable. Sorry. Patch is pushed new but will not be available in 6.2.

Change-Id: I39baa58c70b0e942d01c1c37bbf793b873db385d
Reviewed-on: https://review.typo3.org/26055
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

[FEATURE] Fallback/default case for SwitchViewhelper

In order to provide the full functionality known from the
switch/case PHP function, a default case possibility is
introduced. Use it like:
<f:switch expression="{person.gender}">
  <f:case value="female">Mrs.</f:case>
  <f:case value="male">Mr.</f:case>
  <f:case default="TRUE">Mrs. or Mr.</f:case>
</f:switch>

Resolves: #49371
Documentation: #54283
Change-Id: I6b71ec39173ab957aa392bd595a65ceddadc81c9
Releases: 6.2
Reviewed-on: https://review.typo3.org/23739
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

[BUGFIX] Allow Editing field creator_tool in sys_file_metadata

The filemetadata extension adds additional fields to the sys_file_metadata
table. The field creator_tool is defined in SQL and TCA, but not added to
any palette or tab. This patch adds the field to the palette with
related authoring information.

Releases: 6.2
Fixes: #54259
Change-Id: I9e3c3af618b04ddde1c96b3dcb1e4cdf209f6eec
Reviewed-on: https://review.typo3.org/25993
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[TASK] Add editing of file metadata to ClickMenu

The Context-Menu of files misses the editing pen allowing
to directly edit the metadata of the file. Currently it
only shows the edit-content possibility in case it is a
text file.

This patch adds the missing option.

Resolves: #52835
Releases: 6.2
Change-Id: I869d8a57d2cacc04455df5189b5cc7af02c2e9cf
Reviewed-on: https://review.typo3.org/25811
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[BUGFIX] Re-Introduce feature to go one level up in file list

When the file list has been reworked to use FAL instead of
plain PHP file functions the feature to go one level up has
been removed accidentilly. This patch reintroduces the
original behaviour known from TYPO3 CMS 4.x.

Releases: 6.2
Resolves: #51866
Change-Id: Iad334c90d575f2b2f3b47af71e23c721edd76e1e
Reviewed-on: https://review.typo3.org/25812
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller

[TASK] Superfluous comparison in CronCommand

Fix superfluous comparison against boolean in
CronCommand::dayMatchesCronCommand

Change-Id: Ia1d852ffbbc772dd89587d304b1234e11e372d2d
Resolves: #54050
Releases: 6.2
Reviewed-on: https://review.typo3.org/25737
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] ClassAliasMap, Tx_ VH namespace and closing tag throws Exception

When using aliased ViewHelper class names and old Tx_ namespace in
template and ViewHelper uses closing tag (not self-closing) an
error is thrown, saying closing tag ViewHelper is not the same
as openening tag ViewHelper (closing tag uses old class name,
opening tag uses new). To solve, TemplateParser now checks if
resolved ViewHelper class names are aliases of other classes and
if so, uses the real class name instead of the alias.

Steps to reproduce error:

* template namespace: {namespace myext=Tx_Myext_ViewHelpers}
* template code: <myext:vh>test</myext:vh>
* namespaced VH class: \Myext\ViewHelpers\VhViewHelper
* ClassAliasMap: Tx_Myext_ViewHelpers_VhViewHelper ->
  \Mext\ViewHelpers\VhViewHelper
* framework: render template using any View

Error 1224485398 "closing tag does not match opening tag" thrown.

Steps taken to fix error:

* run constructed class name through alias resolve method.

Fixes: #54115
Releases: 6.2, 6.1, 6.0
Change-Id: I070b6199095ec84c7213cfc0c3775f5f08340840
Reviewed-on: https://review.typo3.org/25814
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

[BUGFIX] ClientUtility does not detect Internet Explorer 11

Since the Release of Microsoft IE 11 there is no "MSIE" hint in
its user agent header anymore. Therefore the existing patterns
fail and the browser is detected as unknown browser.

TYPO3 deactivates several features for unknown browser. As a
result f.e. the RTE does not load.

This change adds special treatment for IE11+ by introducing an
additional regular expression matching the new user agent format
and looking for the Trident engine to be present.

In addition unit tests for common IE 9-11 user agents are added.

Change-Id: I389f344a498ac77f3e6445656dd125fd5d236a98
Resolves: #54124
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/25848
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Cleanly unset cookies on login in cookie-check

Needed to workaround a login-problem with IE11.

ExtJS tries to clear a cookie with different settings than when
setting the cookie. In IE11 this leads to problems with the cookie
being set twice on the next call to set(). The get() however
would return the first (empty) cookie.

Using set() with a date in the past also clears the cookie but
will correctly use the same path-settings.

Change-Id: Ieff22129895cd89ca2e1429703daf1636596ecb6
Resolves: #53818
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/25852
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Installer: textarea for [FE][defaultTypoScript_setup]

The defaultTypoScript_setup has a different configuration than
defaultTypoScript_constants.
Make them equal.

Resolves: #53852
Releases: 6.2
Change-Id: Ide8be9b4653ed17e3a0ee7a0222bd384a986b3ce
Reviewed-on: https://review.typo3.org/25634
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Faulty and superfluous code in import/export module

There is faulty and superfluous code in import/export module:
* ModuleFunctionController does not work at all, this points
  back to issue #22921 during TYPO3 4.4 development
* ImportExportTask fetches thumbnail files from a (faulty)
  storage that are not used at all

Since the required class "mod_user_task" has been removed in
TYPO3 4.4, the module function component was broken since then.
Thus, it will be removed completely with this change.

Fixes: #53555
Releases: 6.2, 6.1, 6.0
Change-Id: I1cbdd967dc47ac2fcd256e7eefc756278822ad84
Reviewed-on: https://review.typo3.org/25302
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Fix broken references in LegacyClassesForIde

The LegacyClassesForIde.php contains some class definition
which extend non-existing or wrong classes.

Also fix some issues in ClassAliasMaps of ext:frontend

Resolves: #54059
Releases: 6.2
Change-Id: Id0918cfc3b187ea1110ad5e745a2b904ea50502c
Reviewed-on: https://review.typo3.org/25750
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Remove non-evaluated parameter from _GP function calls

Remove second (no longer evaluated) _GP() function call parameter.

Resolves: #54106
Releases: 6.2
Change-Id: I5b8f6401a07a7291c893a7e82f224c89f0e6404e
Reviewed-on: https://review.typo3.org/25803
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Missing phpinfo() module in install tool

Adds phpinfo() information in System Environment section from
the Install Tool, after warning / error messages.

Fixes: #53271
Releases: 6.2
Change-Id: I8582a65247de998f373d3143f013fa91cb47bff9
Reviewed-on: https://review.typo3.org/25263
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

[TASK] Simplify returns in ConfigurationManager

writeLocalConfiguration() and writeAdditionalConfiguration()
have return statements like:
return $result === FALSE ? FALSE : TRUE;

This can be reduced to:
return $result;

Moreover the return value of canWriteConfiguration()
can be optimized as well.

Change-Id: I8e571459179e4bfeca3bba0a4969fb76d18058e2
Resolves: #54019
Releases: 6.2
Reviewed-on: https://review.typo3.org/25715
Reviewed-by: Markus Klein
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

[TASK] ext:adodb Remove connection wizard

Extension adodb can be used together with TER extension "datasource".
ext:adodb delivers a wizard and flexform code to connect to this
third party extension. Last release of ext:datasource was in 2005,
the extension in unmaintained and always had an experimental
character. Since core extension functionality should not depend on
third party code, the datasource related code of ext:adodb is fully
removed with this patch in 6.2.

Change-Id: Ib7de137599d9bb55d6b9dd98667cbbe3dd70c986
Resolves: #42651
Releases: 6.2
Reviewed-on: https://review.typo3.org/25759
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Franz G. Jahn
Tested-by: Franz G. Jahn
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] ext:adodb Remove obsolete diffs from doc/

Remove some ancient and obsolete patch files from ext:adodb/doc.

Change-Id: Ib2183abb3358de8b4d7e1dad71731b1df96a9a80
Fixes: #54078
Releases: 6.2
Reviewed-on: https://review.typo3.org/25758
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Franz G. Jahn
Tested-by: Franz G. Jahn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

[TASK] Use array access instead of traversing hook array

Instead of making a slow array traversal simply check if there is
a hook object for the cObject being rendered by using an array access.
And check if the object exists before.

Change-Id: I6b16703b1194eca4d1ed5c3d5543076e2cae495d
Resolves: #51283
Releases: 6.2
Reviewed-on: https://review.typo3.org/23267
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] ExtJS-upgrade 3.4.0 to 3.4.1.1

From 3.4.0, released June 9, 2011
To 3.4.1.1, released March 29, 2013

Change-Id: I009c472975262f1813711b8b204518c9f1c8f463
Resolves: #52933
Releases: 6.2
Reviewed-on: https://review.typo3.org/24883
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Superfluous comparison in InlineElement

Fix superfluous comparison against boolean in
InlineElement::renderForeignRecord().

Change-Id: I75bb1625ad7ead08e8e38fe46daa03071bc76113
Resolves: #54018
Releases: 6.2
Reviewed-on: https://review.typo3.org/25714
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Redundant compare: GeneralUtility::inList()

GeneralUtility::inList() does a comparison resulting in a boolean value.
Then based on this value it will return TRUE or FALSE.

It suffices to return the result of the comparison.

Change-Id: I12f9dd699a643a187f871940175e32ab2bcca7de
Resolves: #54017
Releases: 6.2
Reviewed-on: https://review.typo3.org/25713
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[TASK] Replace URLs of bugs.typo3.org with forge.typo3.org

The old issue tracker on http://bugs.typo3.org will be shut down
by the end of 2013.

Therefore replace *all* occurrences of such URLs with the new
location on http://forge.typo3.org.

Change-Id: Ia44742efeab22837dd5be7076f21eb286aaf5a82
Resolves: #54020
Releases: 6.2
Reviewed-on: https://review.typo3.org/25716
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[TASK] Remove disableDocModuleInAB TSconfig option in ModuleMenuView

The option disableDocModuleInAB has already been removed in the
documentation since TYPO3 4.2 according to
http://wiki.typo3.org/Documentation_changes_in_4.2

Current documentation also lacks information about this option.

Change-Id: I0ae2ddd88956c8936ae24091f64d95f4195ebf12
Resolves: #53991
Releases: 6.2
Reviewed-on: https://review.typo3.org/25703
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[BUGFIX] t3skin calls addIconSprite for each lang

The t3skin extension adds icon sprites for each language. And that's
great, but not so great that it calls addIconSprite for each language.

Instead the iconArray can be built up and submitted once to
addIconSprite.

This saves 248 calls to addIconSprite which calls array_merge etc.

This saves ~ 22 ms for each request.

Change-Id: I0fdc09de46899e4160f907aefd8b3b3b596a2df3
Resolves: #53918
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25670
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

[BUGFIX] TS: Allow "0" as strPad.padWith

Replaces the test with empty() by isset() and
strlen() > 0. So other strings which are
handled by PHP as empty can be used for padding.

Resolves: #51650
Releases: 6.2, 6.1
Change-Id: Iee62f19f97b958ab2d02c6ca73052810a3c91117
Reviewed-on: https://review.typo3.org/23536
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Fix ordering of stages in action dropdown

If multiple stages exist and a user is member of only a few stages,
then in many cases the ordering of the stages is mixed up.

Change-Id: Ifab7e0afd412f63de574ef262ad4b982cfe1e5e4
Fixes: #36469
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21107
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[CLEANUP] Improve code style of RelationHandler class

* add missing class properties, that are used in the code
* fix invalid PHPDoc variable types
* remove unused variables
* fix or remove invalid return values
* fix invalid variable types
* make sure unused variables are initialized

Resolves: #53718
Releases: 6.2
Change-Id: I90c1b73d0a4a7bb4666679e772805460786c805d
Reviewed-on: https://review.typo3.org/25479
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Page module: Allow to paste in empty columns

Since quite a long time it was not possible to paste a content
element into an empty column of the page module. This patch
introduces an icon in the top right corner of each column if
a tt_content element is on the clipboard (Default pad). When
the icon gets clicked the content elements from the clipboard
get moved/copied into the selected column/language.

Resolves: #15080
Releases: 6.2, 6.1
Change-Id: If52905446eb11c268d0fee83f150efae0945fa29
Reviewed-on: https://review.typo3.org/25532
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] Hardcoded "admin" user in Installer template

The hardcoded username "admin" is removed from the HTML template
since the username can now be freely chosen.

Resolves: #53905
Releases: 6.2
Change-Id: I1c2846e60ee57f5e220405a9217fc1023d4d8bee
Reviewed-on: https://review.typo3.org/25668
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[TASK] Replace ClassLoader cache with standard caches

The class loader can now use all available cache backends
for retrieval of class loading information.

Using it with APC for example brings a good performance
boost.

Resolves: #53744
Releases: 6.2
Change-Id: I55db9686fa2d5b6462b4cb56c452ad2e99e1d2e7
Reviewed-on: https://review.typo3.org/25489
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler

[TASK] Remove deprecated methods in PageLayoutView

Resolves: #53811
Releases: 6.2
Change-Id: I14574f3725bc77b130255d8f70cedabd78d74947
Reviewed-on: https://review.typo3.org/25548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I2e11bc29d40124ffb5d026633c182b542a9e3dd2
Reviewed-on: https://review.typo3.org/25624
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

[RELEASE] Release of TYPO3 6.2.0beta2

Change-Id: Ie872f8aa920c00feb82784957e6ea02b826c6e7c
Reviewed-on: https://review.typo3.org/25623
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

[BUGFIX] Fix moving/copying files and folders between storages

When a file or folder is moved between 2 storages the target
storages is asked for the filepermissions of the source
file/folder. This breaks because current storages + driver
can not access/find source.

This patch makes sure that on places where a source can be
from an other storage the source storage is used for the
permission check.

Releases: 6.0, 6.1, 6.2
Resolves: #53802
Change-Id: Ib2c1443fad295a3b7eeeb01ab38359fcdf6849ab
Reviewed-on: https://review.typo3.org/25553
Reviewed-by: Fabien Udriot
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Can not delete Files with metadata records

When a sys_file record has relation with a sys_file_metadata
record the file can not be deleted.

This patch excludes tables sys_file_metadata from the
reference check.

Resolves: #53672
Releases: 6.2
Change-Id: Ib7a5b55fce9f5cf19ffe3b18eddfc7238a8e8626
Reviewed-on: https://review.typo3.org/25456
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Fabien Udriot
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Fix regression in ResourceCompressor

Resolves: #53844
Related: #53243
Releases: 6.2, 6.1, 6.0
Change-Id: I7f6a178b063d71c9182316a81e787c9ab5246b8e
Reviewed-on: https://review.typo3.org/25613
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Replace TCA cache with serialized array

The TCA isn't stored as php array anymore,
but instead as serialized array string. Unserialize
seems to be much faster in this regard although
opcode caches have been tested.

Resolves: #53747
Releases: 6.2
Change-Id: I540cae2ecee0ef09635ceff0b91b7a940dae01f7
Reviewed-on: https://review.typo3.org/25492
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik

[TASK] CleanUp canonicalizing identifiers in FAL-drivers

In https://review.typo3.org/23398 the possibility was
created, to use case-sensitive fileIdentifiers in
database collations which are not case sensitive. To
do so a new sanitiation of file-identifiers has been
introduced into the drivers.

During the patch-sets a new function has been created
while there would have been already some functions
perfectly fitting that task.

Introducing this new functionality in the old ones
showed, that these are used for non-identifier
path (absolute external), too which created problems.
Therefore this has been split out.

Finally the getAbsolutePath and variants manually
concatenating the basePath have been revised, and
duplicate calls to the canonicalize functions have
been removed.

Releases: 6.2
Resolves: #53604
Change-Id: I415cce898298e9cdaadf7ef4310b15a68c3bb5c6
Reviewed-on: https://review.typo3.org/25382
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

[TASK] Wrong method phpdoc

In class "DataHandlerHook" of extension "version" the method
description of "processCmdmap_deleteAction" is just a copy from
the method above.

Change-Id: I280c3a2f364383696a24c5ad47f199cd5e55b560
Resolves: #53820
Releases: 6.2
Reviewed-on: https://review.typo3.org/25552
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

[BUGFIX] Reload list module on clickmenu action

This solves the problem of a not refreshing list module
when the clickmenu of an element is used to copy/move the
element.

Releases: 6.2, 6.1, 6.0, 4.5
Resolves: #15958
Change-Id: I2eee6162636e0c78ed361c26f81ce2bfe8835283
Reviewed-on: https://review.typo3.org/25531
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Filemtime / Filesize trigger warning

Adds check for file_exists before calling filemtime / filsize
to avoid warning message.

Resolves: #53243
Releases: 6.2, 6.1, 6.0
Change-Id: I0f7da0c3e1920ddcf7d2d427a48ddcca71a6a4a3
Reviewed-on: https://review.typo3.org/25283
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Fluid paginate widget wrong number of links

If the maximumNumberOfLinks configuration option is set to 8
the widget will render 10 links.

Solved the problem by changing a plus to a minus in the calculation
of the display range end and added unit tests for several cases.

Resolves: #53458
Releases: 6.2, 6.1, 6.0
Change-Id: Ic1c55b0bf925b546d119c67433f63e662493a08b
Reviewed-on: https://review.typo3.org/25222
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Improve confirmation dialog in drag'n'drop fileupload

This patch introduces the following changes to the drag'n'drop
fileuploader:

* Only ask for confirmation to overwrite files, if at least
one of the uploaded files will overwrite an existing file on
the server
* Display the files which will be overwritten in the confirmation
dialog
* If the user selects "Cancel", cancel the whole action, and
don't upload any files.
* If no files will be overwritten, just upload them without
disturbing the user with a confirmation message.

Resolves: #53776
Releases: 6.2
Change-Id: I415c2d31b5bf1248f8a865d225a81ddd96e47d78
Reviewed-on: https://review.typo3.org/25523
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[CLEANUP] Fix various spelling mistakes

Resolves: #53793
Releases: 6.2
Change-Id: Iefe8a2a96f41903ca33b02da4aace71690951cbf
Reviewed-on: https://review.typo3.org/25530
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Updated README / INSTALL / NEWS files

* Added README.md (which was formerly part of the individual
  distributions)
* Transformed the text into markdown for nice visualisation i.e.
  on Github
* Rewritten the installation steps
* Rewritten the system requirements

Releases: 6.2
Resolves: #53745
Change-Id: I293bde1a046e9f7c712d5d8d9cc13138a303efc2
Reviewed-on: https://review.typo3.org/25490
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Revert "[BUGFIX] Page module: Allow to paste in empty columns"

This patch introduces sever problems with DataHandler.

Change-Id: I591440395b6e7fb7d0ffb33c107e94a7a3b25b5a
Releases: 6.2, 6.1
Related: #44002
Reviewed-on: https://review.typo3.org/25527
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Remove gaps in tree of New Record Wizard

Replacing line breaks with a div allows styling to be applied to
each line in the tree.

Change-Id: I1c89c9b6a9998185895a280564ccc95a224060eb
Resolves: #53652
Releases: 6.2
Reviewed-on: https://review.typo3.org/25475
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[CLEANUP] SpriteBuildingHandler uses deprecated SpriteGenerator API

Resolves: #53778
Releases: 6.2
Change-Id: Ife895d07c67e519553248a62917de921c6e31a76
Reviewed-on: https://review.typo3.org/25524
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Page module: Allow to paste in empty columns

Since quite a long time it was not possible to paste a content
element into an empty column of the page module. This patch
introduces an icon in the top right corner of each column if
a tt_content element is on the clipboard (Default pad). When
the icon gets clicked the content elements from the clipboard
get moved/copied into the selected column/language.

As a side effect this patch also resolves issues with the list
module not reloading when using the copy/cut entries from the
clickmenu (context menu): #25176, #15958

Change-Id: I635bb584d5e03b764bd5df5189555fb9b34ab926
Resolves: #44002
Resolves: #35980
Resolves: #15080
Resolves: #21622
Resolves: #25176
Resolves: #15958
Releases: 6.1, 6.2
Reviewed-on: https://review.typo3.org/22201
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] l10n_mode for "pages" table and group fields.

This patch respects the l10modes for pages, and mergeIfNotBlank for
type "group" fields.

Change-Id: I18a4caffc5761f91dae4ae0cf175ccd51ffe8c29
Fixes: #38766
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/12714
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Improve updates of metadata in MetaDataRepository

If you run the FAL update wizard for tt_content images the
MetaDataRepository requests database fields for each update separately.
This information should be stored in an internal array to avoid
unnecessary database requests and increase performance.

Resolves: #53709
Releases: 6.2
Change-Id: Icbef451f9a02395d758626254be004e87f350039
Reviewed-on: https://review.typo3.org/25470
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Exception thrown in update wizard if file does not exists

When fetching a file that does not exists a exception is
thrown in the update wizard to update RTE file links to FAL.
The exception will now be catched.

Resolves: #53127
Releases: 6.2
Change-Id: I81a204506abfe2f462142ccc504f3a4e2cef138f
Reviewed-on: https://review.typo3.org/25004
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Fix JS error in lang module

The tables of the language module do not resize
on change of windows height. This fixes the
Javascript error.

Releases: 6.0, 6.1, 6.2
Resolves: #53773
Change-Id: I614d370108092b224059d5a5d07d78a10a10e2a2
Reviewed-on: https://review.typo3.org/25517
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[TASK] Render extension icons in Language module directly

Just like in the Extension Manager the icons for the extensions
can be rendered directly to increase speed. CSS takes care of scaling.

Change-Id: I1d6dc13d2b52c35be546af0ecaaae75960f2089e
Resolves: #53771
Releases: 6.2
Reviewed-on: https://review.typo3.org/25516
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Rework image viewHelper to use FAL

Currently in the worst case images are transformed
from Extbase domain objects to FAL objects to paths
to FAL objects again just to render an image.

Avoid back and forth conversions an directly use
FAL API instead of using the detour through
the content object renderer.

Resolves: #53700
Releases: 6.2
Change-Id: I5fe8d7c9d4ad94e99b5bac06e54ff1346e8cc187
Reviewed-on: https://review.typo3.org/24911
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

[BUGFIX] Deprecation log is spammed with getReturnRawQueryResult()

Typo3QuerySettings->getReturnRawQueryResult() is called by
query->execute() to maintain backwards compatibility.
The call to getReturnRawQueryResult() must NOT be logged in the
deprecation log as the setter is already logged.

Resolves: #53769
Releases: 6.2
Change-Id: Ie2ca425de93e02d136409d6e0d20f26a580a656a
Reviewed-on: https://review.typo3.org/25513
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Bring back module menu accordion arrows

To visualize that the module groups can be expanded and collapsed, the UX
team decided that the arrows are required. This brings them back on the
right with a very light gray to avoid distractions.

Resolves: #53651
Releases: 6.2
Change-Id: Ie289b59dfb24077ed99964e7e944c8dfd443af59
Reviewed-on: https://review.typo3.org/25415
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[FEATURE] Categories-based tt_content menu

Provide a new menu/sitemap type for displaying list
of categorized content elements. The default rendering
simply provides links to the parent page with
anchor pointing to the specific content element.
Refactor the RECORDS object.

Resolves: #52137
Documentation: #52920
Releases: 6.2
Change-Id: I59c9eeb63148eaf12d8810fd7e64628e3f2d61aa
Reviewed-on: https://review.typo3.org/23905
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] Scheduler extension sql file is invalid

On import into MySQL an error is thrown and MySQL
refuses to create the table:

ERROR 1067 (42000) at line 4: Invalid default value for 'uid'

This is due to the fact that a default value is being set
for an auto_increment field.

Change-Id: Ic072d3ec21b4e8adbecf9ff88e6ac4a2919959ec
Resolves: #53750
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25502
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[TASK] Change injectMethods to annotations

Change injectMethods as already done in extbase
to inject annotations

Resolves: #52040
Releases: 6.2
Change-Id: I1e4ba873981c4692cc0b3d867bd3756934661a90
Reviewed-on: https://review.typo3.org/23865
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein

[BUGFIX] fix javascript error "TBE_EDITOR not defined" in sys_action

This fixes the error "TBE_EDITOR not defined" which occured when using
sys_action > create backend user and assigning a db mount.

Resolves: #34544
Releases: 6.2, 6.1, 6.0
Change-Id: Idb78c23e2dea576fb1cab41979d4b068ca45a8b7
Reviewed-on: https://review.typo3.org/20206
Tested-by: uwe trotzek
Reviewed-by: Christian Buelter
Tested-by: Christian Buelter
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] ExtDirect StateProvider should store all settings

ExtDirect StateProvider seems to queue Ext.state.Manager.set() calls and
collects them to fire only one AJAX call.

In TYPO3\CMS\Backend\InterfaceState\ExtDirect on the other hand setState()
only stores the first item of the data array to $GLOBALS['BE_USER']->uc
the other settings are just ignored. Instead it should iterate the data
array and store all items.

Change-Id: I8d8bd01131545a6cad1a3933184c25c6d5f26149
Fixes: #51998
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23843
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Fix height of body in backend

The body-tag had 100% height in the backend. In views, where scrolling
is possible (e.g. login screen in a small window), this made the
background-color stop too soon.

Resolves: #53692
Releases: 6.2
Change-Id: I08df23c808b6b4d1ea7422a25a2431cf18d0ae70
Reviewed-on: https://review.typo3.org/25460
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[TASK] Optimization in AbstractViewHelper

Small optimization in AbstractViewHelper to fetch the type
after the check for the default value of the argument.

Change-Id: Ie9b68d892f4a20521606709b8fdfba83099c3d70
Resolves: #53746
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25491
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik

[BUGFIX] Rename hook in VariableFrontend.php

Due to the namespace changes the hook in
typo3\sysext\core\Classes\Cache\Frontend\VariableFrontend.php was
renamed. This patch changes name back to the one before.

Resolves: #53707
Releases: 6.2, 6.1, 6.0
Change-Id: Ibb86188b38aba9ca7e7e2670f843234fae16fa87
Reviewed-on: https://review.typo3.org/25466
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Warning in Install Tool if APC is installed but not enabled

Resolves: #53748
Releases: 6.2
Change-Id: I22a2b60871639075dc108946bbaeae3730fc7085
Reviewed-on: https://review.typo3.org/25493
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] additionalAttributes for be.buttons.icon-VH misses hsc

The values of the additional attributes for the backend icon viewhelper
need to be processed through htmlspecialchars().

Resolves: #53711
Releases: 6.2, 6.1, 6.0
Change-Id: I89794c77ad1bb7bad99517e24ae7345e0803616e
Reviewed-on: https://review.typo3.org/25483
Reviewed-by: Wouter Wolters
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

[BUGFIX] Install System Extensions in update wizard fails

In the update wizard it isn't possible to install any system extension
because the PackageManager isn't initialized. During bootstrap only the
class FilesafePackageManager is loaded and registered. This patch
registers the initialized FailsafePackageManager as singleton instance.

Resolves: #53708
Releases: 6.2
Change-Id: I9eb9ab8ac1fd655fd642e386cd51895f1d8c1e21
Reviewed-on: https://review.typo3.org/25467
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller

[BUGFIX] Improve output for "deprecated RTE properties" updater

When running the update wizard for "Deprecated RTE properties in Page
TSconfig" the output contains html tags which are htmlspecialchared.
Furthermore the output of the custom messages is corrected to show the
information when available.

Resolves: #53710
Releases: 6.2
Change-Id: Ia488d0fd0368c318617bb245a0f9fcd25099506b
Reviewed-on: https://review.typo3.org/25472
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

[BUGFIX] Don't underline Web>Page content elements on hover

Resolves: #53683
Releases: 6.2
Change-Id: I71af8c928e0a83698e887e9053d1c6de1e8d8ffb
Reviewed-on: https://review.typo3.org/25464
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

[TASK] Set X-UA compatibility version to IE=10

This change allows IE users to work with multiple fileuploads.

Change-Id: I2734d147a0f85e8302fd3bf62fc9770045a2b33d
Resolves: #52186
Releases: 6.2
Reviewed-on: https://review.typo3.org/24000
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Jigal van Hemert
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny