Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Show warning label for linkhandler if no label is defined 58/51558/2
Markus Klein [Fri, 3 Feb 2017 21:25:33 +0000 (22:25 +0100)]
[BUGFIX] Show warning label for linkhandler if no label is defined

If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a hint
that the configuration is evaluated correctly.

Resolves: #79621
Releases: master, 7.6
Change-Id: Ib00a86be339908408c4e31eedb3c8ea57468fa87
Reviewed-on: https://review.typo3.org/51558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Wrong position of init 50/51550/2
Stefan Froemken [Wed, 18 Jan 2017 14:48:00 +0000 (15:48 +0100)]
[BUGFIX] Wrong position of init

As storeIncomingData depends on some data,
which is generated in init, the init method
has to be called before.

Resolves: #79374
Releases: master, 7.6
Change-Id: I55e9f1317db83205b3a9ad0105eb8b493203ced7
Reviewed-on: https://review.typo3.org/51550
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Limit primary key length on be_session and fe_session table 39/51539/5
Christian Kuhn [Sat, 4 Feb 2017 12:44:51 +0000 (13:44 +0100)]
[BUGFIX] Limit primary key length on be_session and fe_session table

Patch for issue #79566 increased the field length of ses_name in
fe_session and be_session table from 32 to 255.
This field is used together with ses_id as primary key.
With utf8, this now exceeds maximum key length of 757 bytes.
To fix the issue, ses_name is cut down to 100 for the time being,
the patch should be fine for master and 7.6 this way.

Change-Id: I06abecca0f8df483590cf0a3c193134083e8f5f1
Resolves: #79628
Related: #79566
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51539
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix missing variable initialization in AbstractTreeView 28/51528/4
Markus Klein [Fri, 3 Feb 2017 20:42:34 +0000 (21:42 +0100)]
[TASK] Fix missing variable initialization in AbstractTreeView

https://review.typo3.org/49750 introduced code that lacks
proper variable initialization.
Get this straight.

Resolves: #79620
Releases: master, 7.6
Change-Id: I1b5735807f7f0fc476a5370f23d6b7d4654e4599
Reviewed-on: https://review.typo3.org/51528
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow long cookie names 05/51505/2
Marco Huber [Tue, 31 Jan 2017 10:29:36 +0000 (11:29 +0100)]
[BUGFIX] Allow long cookie names

With this patch cookie names longer than 32 chars are possible.

Resolves: #79566
Releases: master, 7.6
Change-Id: I5132defab6e7524ed4aaf48ea29e44da40aee516
Reviewed-on: https://review.typo3.org/51505
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Clear search field in Install Tool with ESC 86/51486/2
Georg Ringer [Tue, 31 Jan 2017 10:33:30 +0000 (11:33 +0100)]
[TASK] Clear search field in Install Tool with ESC

As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on the
ESC key to clear the search again.

Resolves: #79567
Releases: master, 7.6
Change-Id: I9a304bb455153429f99354a4ef684326b1baa612
Reviewed-on: https://review.typo3.org/51486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[CLEANUP] Simplify updating of timestamp in writeForeignField 54/51454/2
Thomas Hohn [Thu, 15 Dec 2016 10:45:22 +0000 (11:45 +0100)]
[CLEANUP] Simplify updating of timestamp in writeForeignField

There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both a call to getRecord and a loop through fields,
casting and checking each field value comparing to DB.

Change-Id: Ic807030c5cea83d36e543ed0f75cf980c3872d1e
Releases: master, 7.6
Resolves: #79004
Reviewed-on: https://review.typo3.org/51454
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Change EM composer mode message to info level 50/51450/2
Benjamin Franzke [Thu, 29 Dec 2016 12:10:17 +0000 (13:10 +0100)]
[BUGFIX] Change EM composer mode message to info level

As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer mode message
should no longer be a warning but an info.

Releases: master, 7.6
Fixes: #79107
Change-Id: Ic9fcb134c113172de504833ed81f7a46a0ba4e2c
Reviewed-on: https://review.typo3.org/51450
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Persist traversable domain objects via identifier 46/51446/2
Mathias Brodala [Thu, 12 Jan 2017 13:03:04 +0000 (14:03 +0100)]
[BUGFIX] Persist traversable domain objects via identifier

Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implement the
Traversable interface.

Change-Id: Iccb53d6e7ded9b6b5300e111e8503641b10615f4
Resolves: #79294
Related: #57255
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51446
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Only perform reindex if data has indeed changed 45/51445/2
Thomas Hohn [Tue, 13 Dec 2016 20:46:38 +0000 (21:46 +0100)]
[BUGFIX] Only perform reindex if data has indeed changed

Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add .php_cs.cache to .gitignore 44/51444/2
Georg Ringer [Thu, 26 Jan 2017 20:24:52 +0000 (21:24 +0100)]
[TASK] Add .php_cs.cache to .gitignore

The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.

Resolves: #79510
Releases: master, 7.6
Change-Id: Ia85f825416ad767a07d280de35a18c318e1a5133
Reviewed-on: https://review.typo3.org/51444
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup code of LocalizationController::process 36/51436/2
Manuel Selbach [Wed, 18 Jan 2017 20:12:16 +0000 (21:12 +0100)]
[TASK] Cleanup code of LocalizationController::process

Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://review.typo3.org/51436
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Adjust Cs-Fixer 2.0 hits 33/51433/3
Anja Leichsenring [Wed, 25 Jan 2017 21:23:39 +0000 (22:23 +0100)]
[TASK] Adjust Cs-Fixer 2.0 hits

With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
applying those suggested changes.

Change-Id: I1326b698da1a9615729733d8408b583d150de284
Resolves: #79469
Relates: #79361
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51433
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update php-cs-fixer to version 2.0 32/51432/4
Anja Leichsenring [Wed, 25 Jan 2017 20:49:57 +0000 (21:49 +0100)]
[TASK] Update php-cs-fixer to version 2.0

Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Debugger output: split lines before escaping them 35/51435/2
Markus Klein [Fri, 20 Jan 2017 09:16:29 +0000 (10:16 +0100)]
[BUGFIX] Debugger output: split lines before escaping them

This fixes the issue that lines are wrapped within a HTML entity.

Resolves: #79398
Releases: master, 7.6
Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002
Reviewed-on: https://review.typo3.org/51435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Render metatags on uncached pages 03/51403/2
Daniel Dorndorf [Thu, 5 Jan 2017 10:11:11 +0000 (11:11 +0100)]
[BUGFIX] Render metatags on uncached pages

Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to adding any
entries with the 'render-preProcess' hook.

Resolves: #79162
Releases: master, 7.6
Change-Id: I2142a5c91fcb0840993d9235caa1e883bbb0c2b4
Reviewed-on: https://review.typo3.org/51403
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix broken links to permission module 01/51401/2
Frank Naegler [Mon, 16 Jan 2017 17:37:05 +0000 (18:37 +0100)]
[BUGFIX] Fix broken links to permission module

This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring:
http://review.typo3.org/33402

Resolves: #79329
Related: #62339
Releases: master, 7.6
Change-Id: Iafe66352a7bac593e249ef09c07f1c9dc9b15359
Reviewed-on: https://review.typo3.org/51401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] FormEngine: Do not add <br> to readonly textarea content 90/51390/2
Markus Klein [Fri, 20 Jan 2017 14:57:12 +0000 (15:57 +0100)]
[BUGFIX] FormEngine: Do not add <br> to readonly textarea content

Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.

Resolves: #79399
Releases: master, 7.6
Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7
Reviewed-on: https://review.typo3.org/51390
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use official TYPO3.Icon repository 78/51378/2
Benjamin Kott [Sat, 21 Jan 2017 11:04:52 +0000 (12:04 +0100)]
[TASK] Use official TYPO3.Icon repository

The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/TYPO3/TYPO3.Icons

Resolves: #79404
Releases: master, 7.6
Change-Id: I9c4a78bbf52f681d61e69f2e7245fb1c2cac561f
Reviewed-on: https://review.typo3.org/51378
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1 71/51371/2
Sascha Egerer [Fri, 13 Jan 2017 09:00:16 +0000 (10:00 +0100)]
[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1

The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Since PHP 7.1 there is
a different handling of invalid array usage. If a variable is
accessed as an array but is not an array the value of that variable
becomes a string 'A'.

PHP 7
php > $config = '';
php > $config['foo'] = 'bar';
php > print_r($config)
Array
(
    [foo] => bar
)

PHP 7.1
php > $config = '';
php > $config['foo'] = 'bar';
> Warning: Illegal string offset 'foo' in php shell code on line 1
php > print_r($config)
A

Related PHP "Bug" (It's not a bug, it's a feature)
https://bugs.php.net/bug.php?id=73081

Change-Id: I6d5b75ed60f0506ecacdead01a318fdc26757394
Resolves: #79052
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51302
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
(cherry picked from commit f39c2f1c0fcf92c8c4923f9a4e77cc0631834fd5)
Reviewed-on: https://review.typo3.org/51371

2 years ago[BUGFIX] Restrict l10n fallback to cms extension 48/51348/4
Philipp Gampe [Wed, 18 Jan 2017 15:53:20 +0000 (16:53 +0100)]
[BUGFIX] Restrict l10n fallback to cms extension

The check for the l10n fallback for the cms extension was too wide, also
covering arbitrary extension names starting with "cms".

Restrict the check to "cms/" now.

Resolves: #79377
Releases: 7.6
Change-Id: Idb07d4499fe0b75a0027e58a0d421c377054624f
Reviewed-on: https://review.typo3.org/51348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Use reflection information in getGettablePropertyNames 61/51361/3
Nicole Cordes [Wed, 12 Oct 2016 15:55:27 +0000 (17:55 +0200)]
[BUGFIX] Use reflection information in getGettablePropertyNames

In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Currently all get/is/has
methods are joined as they can be fetch from Extbase as well. But for
those methods it is necessary to respect their arguments as Extbase
calls those functions without any argument.
This can trigger PHP warnings.

The patch uses a class reflection to get public properties and inspect
the method arguments. Only those functions without arguments or only
optional arguments are considered as valid property name.

Resolves: #78270
Releases: master, 7.6
Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d
Reviewed-on: https://review.typo3.org/51361
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Fix minor typo in DateTimePicker.js 47/51347/2
Wouter Wolters [Wed, 18 Jan 2017 15:25:19 +0000 (16:25 +0100)]
[BUGFIX] Fix minor typo in DateTimePicker.js

Heven't replaced with haven't

Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332602e
Reviewed-on: https://review.typo3.org/51347
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Make persistent connections available for Redis cache backend 12/51312/3
Kasper Ligaard [Thu, 15 Dec 2016 13:59:26 +0000 (14:59 +0100)]
[BUGFIX] Make persistent connections available for Redis cache backend

The Redis cache backend allows configuration of all connection
setting, except setting persistent connections. This omission
is fixed by this patch. Being unable to use persistent connections
under high load can hurt performance in cloud setups. Persistent
connections has been part of phpredis since 2010 and thus is
broadly available, but is impossible to use with TYPO3.

Resolves: #79005
Releases: master, 7.6
Change-Id: Ie5476e894072bb9979691f28bc7a1e10e86ef454
Reviewed-on: https://review.typo3.org/51312
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years agoRevert "[BUGFIX] Skip main extension repository check in Composer mode" 81/51281/2
Nicole Cordes [Thu, 12 Jan 2017 09:08:51 +0000 (10:08 +0100)]
Revert "[BUGFIX] Skip main extension repository check in Composer mode"

This reverts commit e538ed3f154f447ddbaf78785a31c9ab2ee72a17.

We do need the information about the main repository status as there is
currently no other possibility to get information about the (security)
status of extension besides the TER itself.

Resolves: #79285
Related: #79277
Releases: master, 7.6
Change-Id: Ia769dc95eaeff405f291d5929b7790a50c332a83
Reviewed-on: https://review.typo3.org/51281
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Skip main extension repository check in Composer mode 79/51279/2
Mathias Brodala [Wed, 11 Jan 2017 14:41:36 +0000 (15:41 +0100)]
[BUGFIX] Skip main extension repository check in Composer mode

Extensions are not installed and updated from the main extension
repository in Composer mode, thus skip this check completely.

Change-Id: If5bad978ed7eae92954198f9569a90effc123525
Resolves: #79277
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51279
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Filelist: Info dialog shows image dimensions 75/51275/3
Michael Oehlhof [Wed, 28 Dec 2016 08:03:36 +0000 (09:03 +0100)]
[TASK] Filelist: Info dialog shows image dimensions

The file info modal now contains the width and height of images

Resolves: #65822
Releases: master, 7.6
Change-Id: Iadb64ae3db4558bf74f15aaeac1fe29848120563
Reviewed-on: https://review.typo3.org/51275
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] ResourceCompressor does not persist external resources 74/51274/2
Benni Mack [Wed, 11 Jan 2017 17:05:50 +0000 (18:05 +0100)]
[BUGFIX] ResourceCompressor does not persist external resources

The condition in the ResourceCompressor for fetching
external files never worked, as it was a simple typo
to update an external resource.

So the first time the local file did not exist (and thus, the md5
did not match) and the file was fetched but due to the
wrong check, the file never got updated.

Resolves: #79269
Releases: master, 7.6
Change-Id: If6942284ccd46f400e23d199e827d4e7a696961d
Reviewed-on: https://review.typo3.org/51274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments 69/51269/2
Oliver Hader [Wed, 11 Jan 2017 14:17:12 +0000 (15:17 +0100)]
[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments

ADMCMD arguments are not filtered when calculating the cache-hash
which results in a page not found error. The behavior can be
triggered by creating and opening a preview link in the workspace
module which implicitly sets ADMCMD_previewWS during runtime.

Resolves: #79275
Releases: master, 7.6, 6.2
Change-Id: I339c2787e7de1adf47bb1322c91e0a78c476f790
Reviewed-on: https://review.typo3.org/51269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use POST for storing uc-related Storage in BE 63/51263/2
Benni Mack [Wed, 11 Jan 2017 01:14:08 +0000 (02:14 +0100)]
[BUGFIX] Use POST for storing uc-related Storage in BE

The AJAX call to store uc settings should be handled
as POST request, and not a GET request to ensure that
even long data can be stored on the server and not
run in Firewall/HTTP GET length restrictions.

Additionally a really bad typo did not allow any
POST requests in UserSettingsController as the key
evaluation was wrong.

Resolves: #79266
Releases: master, 7.6
Change-Id: I0fd10090416b1a16f6a9bdc6a07efceccf147336
Reviewed-on: https://review.typo3.org/51263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Correct declaration of $rL_uidRegister 74/50974/5
Kasper Ligaard [Thu, 15 Dec 2016 12:30:42 +0000 (13:30 +0100)]
[BUGFIX] Correct declaration of $rL_uidRegister

$rL_uidRegister was declared as a string but was
used as an array therefore in PHP 7.1 an exception was
thrown.

This is a delayed backport of https://review.typo3.org/48799/.

Resolves: #79001
Related: #76934
Releases: 7.6
Change-Id: Ia0285bb60b6f0f9c5ccde732cce33505c195eb0a
Reviewed-on: https://review.typo3.org/50974
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove range from sorting field 27/51227/2
Georg Ringer [Tue, 20 Dec 2016 07:06:57 +0000 (08:06 +0100)]
[BUGFIX] Remove range from sorting field

The range configuration for a sorting field doesn't make any sense
and can lead to unexpected bugs as sorting can be rewritten

Resolves: #78986
Releases: master, 7.6, 6.2
Change-Id: I738877e6f9587d2570506f695fb7426a7536a964
Reviewed-on: https://review.typo3.org/51227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] IconFactory check arrays for key 17/51217/2
Alexander Opitz [Thu, 15 Dec 2016 10:47:25 +0000 (11:47 +0100)]
[BUGFIX] IconFactory check arrays for key

This reduces PHP notices, as we check arrays before acessing them.

Resolves: #78992
Releases: master, 7.6
Change-Id: Ib0fc72be9e7957a27990d60dde844068ca9e24d1
Reviewed-on: https://review.typo3.org/51217
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[BUGFIX] Fix sys_log table on strict database 16/51216/2
Wouter Wolters [Mon, 9 Jan 2017 13:41:56 +0000 (14:41 +0100)]
[BUGFIX] Fix sys_log table on strict database

The column details must have a default value
because of NOT NULL.

Resolves: #79220
Related: #77306
Releases: 7.6
Change-Id: I1d3e730283f61d4c456b3bc55baca092ad114ef9
Reviewed-on: https://review.typo3.org/51216
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Functional tests for free mode translation 13/51213/2
Tymoteusz Motylewski [Thu, 5 Jan 2017 16:25:37 +0000 (17:25 +0100)]
[TASK] Functional tests for free mode translation

Functional tests for following scenarios:
- free-mode translation of a record in non-default language
(live and in workspaces)
- copy page translated in free mode (workspaces, live is already covered)

Resolves: #79170
Releases: master, 7.6
Change-Id: Iff69e2b4333dfff7511871573352b270add4de01
Reviewed-on: https://review.typo3.org/51213
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Make copy mode of translation modal use localize 09/51109/8
Tymoteusz Motylewski [Fri, 30 Dec 2016 23:48:56 +0000 (00:48 +0100)]
[BUGFIX] Make copy mode of translation modal use localize

...  omitting TransOrigPointer

While translating elements with the localization modal we have to
make sure that the "Copy" mode does more than just a plain copy
followed by an update of the sys_language_uid. Otherwise related
elements will just be copied along but don't get a new language.

This patch replaces the copy action with a new action called
copyToLanguage. It behaves like localize action but does not set
TransOrigPointer fields, so child elements get the correct
language and are not connected to a language parent.

Resolves: #75400
Releases: master, 7.6
Change-Id: If57af3c94c67824ab8bbbc62a8c6bea283e96fca
Reviewed-on: https://review.typo3.org/51109
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix typo in ext:backend fluid template 11/51211/2
Benni Mack [Mon, 9 Jan 2017 09:03:48 +0000 (10:03 +0100)]
[BUGFIX] Fix typo in ext:backend fluid template

Resolves: #79202
Releases: master, 7.6
Change-Id: Ie47e6b42a7429ce75a8d750c7e7aa7f1c1cb9bec
Reviewed-on: https://review.typo3.org/51211
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove leftover info about config.uniqueLinkVars 10/51210/2
Josef Glatz [Sun, 8 Jan 2017 23:14:31 +0000 (00:14 +0100)]
[BUGFIX] Remove leftover info about config.uniqueLinkVars

Remove obsolete info about a removed setting in tsref.xml
and remove one duplicate `to` just two lines later.

Resolves: #79208
Related: #62888
Releases: master, 7.6
Change-Id: I4c2a437edb657eb380ffb2377947977a850da497
Reviewed-on: https://review.typo3.org/51210
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TAKS] Add missing variables in WorkspaceService doc comments 99/51199/2
Tymoteusz Motylewski [Sun, 8 Jan 2017 13:35:00 +0000 (14:35 +0100)]
[TAKS] Add missing variables in WorkspaceService doc comments

Resolves: #79200
Releases: master, 7.6
Change-Id: I745f9762122dba5f2e1ecca8deafd440a78f8329
Reviewed-on: https://review.typo3.org/51199
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Get folder’s identifier for exception message 82/51182/2
Andreas Fernandez [Sat, 7 Jan 2017 16:18:49 +0000 (17:18 +0100)]
[BUGFIX] Get folder’s identifier for exception message

The identifier of the folder object is now retrieved and used in the
exception message.

Resolves: #79194
Releases: master, 7.6
Change-Id: Iebea177434c6913bab705df119d750b497238252
Reviewed-on: https://review.typo3.org/51182
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update copyright year to 2017 76/51176/2
Wouter Wolters [Thu, 5 Jan 2017 10:12:36 +0000 (11:12 +0100)]
[TASK] Update copyright year to 2017

Resolves: #79165
Releases: master, 7.6, 6.2
Change-Id: Ia3211ad00a3b6bd915b0a099bdb8d98a8b12dc7f
Reviewed-on: https://review.typo3.org/51176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix sorting in language list 57/51157/2
Markus Sommer [Fri, 23 Dec 2016 13:48:06 +0000 (14:48 +0100)]
[BUGFIX] Fix sorting in language list

* Add sorting field for A/D
* disable senseless sorting of actions

Resolves: #79085
Releases: master, 7.6
Change-Id: Ib7b31c43522d31dcecf9e97042b98be434616068
Reviewed-on: https://review.typo3.org/51157
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Clean up @see annotation in DataHandler functional tests 12/51112/2
Tymoteusz Motylewski [Tue, 3 Jan 2017 22:48:13 +0000 (23:48 +0100)]
[TASK] Clean up @see annotation in DataHandler functional tests

Resolves: #79146
Releases: master, 7.6
Change-Id: I567031de638d5a03c4e38796b4bfd17569c361e7
Reviewed-on: https://review.typo3.org/51112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Documentation of sessionTimeout 49/50949/2
Alexander Opitz [Tue, 13 Dec 2016 09:35:09 +0000 (10:35 +0100)]
[BUGFIX] Documentation of sessionTimeout

A sessionTimeout <= 0 means that a user will be logged out
instantly after login.

Resolves: #78822
Releases: master, 7.6, 6.2
Change-Id: I1890cb7d52347faab1fa3884eb46c9294d997da3
Reviewed-on: https://review.typo3.org/50949
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Set TYPO3 version to 7.6.16-dev 02/51102/2
TYPO3 Release Team [Tue, 3 Jan 2017 11:24:45 +0000 (12:24 +0100)]
[TASK] Set TYPO3 version to 7.6.16-dev

Change-Id: I942ba77f461fe34395d1a20dda70393d65c230c7
Reviewed-on: https://review.typo3.org/51102
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.15 01/51101/2 7.6.15 TYPO3_7-6-15
TYPO3 Release Team [Tue, 3 Jan 2017 11:24:07 +0000 (12:24 +0100)]
[RELEASE] Release of TYPO3 7.6.15

Change-Id: Iea9d6a4e6196b27df8dc1a9ed2c0c9f69b63fc3c
Reviewed-on: https://review.typo3.org/51101
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[SECURITY] Protect Mailtransport 94/51094/4
Wouter Wolters [Mon, 2 Jan 2017 12:08:46 +0000 (13:08 +0100)]
[SECURITY] Protect Mailtransport

Fix CVE-2016-10074 by disallowing potentially unsafe shell characters.

Resolves: #79114
Releases: master, 8.5, 7.6, 6.2
Change-Id: I8578b63c8c571964c2d52a65e4bfbf705c20f816
Reviewed-on: https://review.typo3.org/51094
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure correct field ordering in CSV export 87/51087/2
Nicole Cordes [Mon, 12 Dec 2016 22:01:14 +0000 (23:01 +0100)]
[BUGFIX] Ensure correct field ordering in CSV export

Due to patch https://review.typo3.org/48998/ the whole database record
is fetched from the database instead of only the visible fields. This
screws up the CSV export as this on relies of the field sorting of the
database row. This patch ensures a correct sorting of the row fields
before they are added to the CSV export.

Resolves: #78908
Releases: master, 7.6
Change-Id: I64f0213695c0cd13fecaa96343a5b1d9af1582f4
Reviewed-on: https://review.typo3.org/51087
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Add functional test covering copying a page translated in free mode 84/51084/2
Tymoteusz Motylewski [Sat, 31 Dec 2016 17:35:13 +0000 (18:35 +0100)]
[TASK] Add functional test covering copying a page translated in free mode

This test is a safe net before implementing features like l10n_source

Releases: master, 7.6
Resolves: #79126
Change-Id: I89f5b819735623a33468a8e5898a1b7825aa0c9b
Reviewed-on: https://review.typo3.org/51082
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 43d0a5b6a965e91ca7f5c1cd1e4d47b94886c0a5)
Reviewed-on: https://review.typo3.org/51084

2 years ago[BUGFIX] Do not use realpath for temporary file names 83/51083/2
Stefan Froemken [Thu, 3 Nov 2016 10:44:51 +0000 (11:44 +0100)]
[BUGFIX] Do not use realpath for temporary file names

Generating a temporary file with the PHP function tempnam,
returns the realpath of the file. There are however
situations where PATH_site has some symlinks or mounts, thus
comparing those paths will fail.

Instead of just using the path the function returns, we only
use the filename and prefix that with PATH_site, so that
the check if the temporary path is within PATH_site will succeed.

Resolves: #70106
Releases: master, 7.6, 6.2
Change-Id: I39a1830ff1a5791aa3fdc91056e3870fbb6dde1f
Reviewed-on: https://review.typo3.org/51083
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Remove relations from MM table 80/51080/2
Nicole Cordes [Fri, 7 Oct 2016 11:58:00 +0000 (13:58 +0200)]
[BUGFIX] Remove relations from MM table

If extbase deletes an object it doesn't delete its relations in an
MM table. This patch adds the check for a possible MM relation table and
ensures all relations get deleted as well. If the parent table supports
a deleted flag, no relations will be deleted to be able to restore the
parent record again.

Resolves: #78128
Releases: master, 7.6
Change-Id: Ibe2497c05838e261f9c67a80216385d6e60607cb
Reviewed-on: https://review.typo3.org/51080
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix interaction with versions on "All workspaces" tab 06/51006/5
Oliver Hader [Tue, 20 Dec 2016 12:08:57 +0000 (13:08 +0100)]
[BUGFIX] Fix interaction with versions on "All workspaces" tab

Interacting with workspace versions using the "All workspaces"
tab in the workspace module was not possible. The process tried
to use the current workspace, which in this case was the virtual
workspace with ID -98 - which of course did not exist.

Change-Id: If512ef8ccc838348230531450e82b25a00f27908
Resolves: #79048
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51006
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Check for loaded EXT:version in getLiveVersionIdOfRecord 74/51074/2
Thomas Hohn [Mon, 12 Dec 2016 11:41:10 +0000 (12:41 +0100)]
[BUGFIX] Check for loaded EXT:version in getLiveVersionIdOfRecord

Omit SQL queries for each record by checking whether the "version"
extension is loaded in BackendUtility->getLiveVersionIdOfRecord()

Resolves: #78974
Releases: master, 7.6
Change-Id: If702866803d0c2b1eafc9a0c003b0e3e71c91367
Reviewed-on: https://review.typo3.org/51074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Show loading label while scanning broken extensions 22/51022/2
Nicole Cordes [Thu, 15 Dec 2016 22:30:04 +0000 (23:30 +0100)]
[BUGFIX] Show loading label while scanning broken extensions

When switching to Bootstrap in the Install Tool, the class adjustment
for the loading message in LoadExtensions.html was missing. This patch
ensures the correct class is used to show the message.

Resolves: #79010
Related: #78376
Releases: master, 7.6
Change-Id: I9c467dd3e0cf7c801ac25774425df7e1d85b4c0a
Reviewed-on: https://review.typo3.org/51022
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Documentation of #53542 contains wrong issue number 16/51016/2
Stephan Großberndt [Wed, 21 Dec 2016 16:13:39 +0000 (17:13 +0100)]
[BUGFIX] Documentation of #53542 contains wrong issue number

Resolves: #79064
Related: #53542
Releases: 7.6
Change-Id: If2393a5325a9b5ba21c7ee852e65b9d16c6c3b3a
Reviewed-on: https://review.typo3.org/51016
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Set title for select icons 10/51010/2
Marco Huber [Mon, 19 Dec 2016 16:50:02 +0000 (17:50 +0100)]
[BUGFIX] Set title for select icons

Use the select options label as title instead of
an uninitialized variable.

Resolves: #79037
Releases: master, 7.6
Change-Id: I690b687f5dd854556ac799d89c8462f4ce9966a4
Reviewed-on: https://review.typo3.org/51010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Optimize cache handling in ReflectionService 80/50980/2
Helmut Hummel [Tue, 13 Dec 2016 22:39:13 +0000 (23:39 +0100)]
[BUGFIX] Optimize cache handling in ReflectionService

Method reflection objects are used temporarily to extract information
from methods. This information is eventually stored in the cache.
However the method reflection objects themselves must stay outside the cache
because they cannot be serialized. They also do not provide much value
as the information is stored in the cache anyway.
The only additional info these reflections provided is whether a method
existed or not in the class, which we now also cache as plain array.

Furthermore the information whether cache relevant properties were
updated and the cache needs to be saved again is now reset once it was
written. This ensures that the cache is only written once even the
ReflectionService is used multiple times.

Resolves: #78915
Resolves: #78977
Releases: master, 7.6, 6.2
Change-Id: I1d00f596633adab886c0db0dfddd71358fb67303
Reviewed-on: https://review.typo3.org/50980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now 81/50981/2
Michael Oehlhof [Sun, 27 Nov 2016 13:36:39 +0000 (14:36 +0100)]
[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now

Resolves: #76408
Releases: master, 7.6
Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563
Reviewed-on: https://review.typo3.org/50981
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Improve DataHandler handling for dbType fields 72/50672/2
Nicole Cordes [Mon, 1 Feb 2016 10:26:35 +0000 (11:26 +0100)]
[BUGFIX] Improve DataHandler handling for dbType fields

Currently we have some issues with handling database fields with type
"date" or "datetime". Those fields can't have an empty default value
in the database but might have defined default values or null. This
patch adds proper handling for both default value cases.

Resolves: #72654
Resolves: #62660
Releases: master, 7.6, 6.2
Change-Id: I429bf4fdfa32531c0034e8346ee11d3d1fb81242
Reviewed-on: https://review.typo3.org/50672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Load page info when only getting external tables 73/50973/2
Johannes Schlier [Wed, 14 Dec 2016 12:46:45 +0000 (13:46 +0100)]
[BUGFIX] Load page info when only getting external tables

Previously the PageLayoutView would only set the page info when getting
the tt_content of the page in function ‘getTable_tt_content’.
If a user only has rights to view/edit records from other tables, but
not tt_content, the page info is null, as ‘getTable_tt_content’ is never
called.

Resolves: #78991
Releases: master, 7.6
Change-Id: Iabcad89a23b245e8c6a8e23fa420fcab5c1ea8e4
Reviewed-on: https://review.typo3.org/50973
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years agoRevert "[BUGFIX] Reflection Cache does not save methodReflections" 68/50968/2
Helmut Hummel [Thu, 15 Dec 2016 00:20:22 +0000 (01:20 +0100)]
Revert "[BUGFIX] Reflection Cache does not save methodReflections"

Internal PHP classes including the \ReflectionMethod are not serlializable. Doing so results in a fatal error at some point.
The reported issue must be solved differently.

This reverts commit a5c1e222bf9858f5a44af1007cd9e1677b9a534d.

Reverts: #78915
Resolves: #78977
Releases: master, 7.6, 6.2
Change-Id: I1161b97eb04d0b1ba8ca59b3008d3f62c6ea1cf5
Reviewed-on: https://review.typo3.org/50968
Reviewed-by: Stefan Rotsch <stefan.rotsch@aoe.com>
Tested-by: Stefan Rotsch <stefan.rotsch@aoe.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Fix exception in QuickEdit mode for empty pages 45/50945/3
Manuel Selbach [Thu, 8 Dec 2016 22:22:15 +0000 (23:22 +0100)]
[BUGFIX] Fix exception in QuickEdit mode for empty pages

If there is no content on a page the parameter $this->eRParts[1] will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Change-Id: If33c5de067b7685e5723ceb7aa1586640abc99d8
Resolves: #78925
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/50910
Reviewed-on: https://review.typo3.org/50945
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Order extensions by integerVersion instead of version 33/50933/2
Ulrik Høyer Kold [Thu, 8 Dec 2016 14:53:16 +0000 (15:53 +0100)]
[BUGFIX] Order extensions by integerVersion instead of version

Return the results of findByExtensionKeyOrderedByVersion ordered by
column 'integerVersion' instead of 'version' in order to avoid a wrong
order for version numbers like "1.9.2" and "1.10.0".

Releases: master, 7.6
Resolves: #78923
Change-Id: I89f5cf54aa4ee7ac87c5af2aa4ac3946d53f10d6
Reviewed-on: https://review.typo3.org/50933
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Reflection Cache does not save methodReflections 29/50929/2
Valentin Despa [Fri, 9 Dec 2016 09:22:42 +0000 (10:22 +0100)]
[BUGFIX] Reflection Cache does not save methodReflections

The cached data of the Reflection Cache (table cf_extbase_reflection)
is not stored in its complete form.

The data/part of property 'methodReflections' is NOT stored in the cache.
As a result, the Reflection Cache will be deleted/inserted each time the
methodReflections property is needed

Resolves: #78915
Releases: master,7.6,6.2
Change-Id: I7b2f7477132abca2e10826bed6e78cb1195d2b26
Reviewed-on: https://review.typo3.org/50929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use proper .xlf file ending for RTE demo config 22/50922/2
Benni Mack [Fri, 9 Dec 2016 15:05:27 +0000 (16:05 +0100)]
[BUGFIX] Use proper .xlf file ending for RTE demo config

Resolves: #78942
Releases: master, 7.6
Change-Id: If233cf0d4812f0d57deccbb6d4ebe33b2393b148
Reviewed-on: https://review.typo3.org/50922
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] SwapLocking should use proper file name 09/50909/2
Benni Mack [Thu, 8 Dec 2016 16:39:28 +0000 (17:39 +0100)]
[BUGFIX] SwapLocking should use proper file name

When using a swap locking file, the file name should not contain
a colon (":") in the filename.

Resolves: #78924
Releases: master, 7.6
Change-Id: I4012ad01e3ef948df691a6ebf1fab79cc1bebe87
Reviewed-on: https://review.typo3.org/50909
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix IP lock clause when [FE][lockIP] is 0 08/50908/2
Wouter Wolters [Wed, 7 Dec 2016 09:11:14 +0000 (10:11 +0100)]
[BUGFIX] Fix IP lock clause when [FE][lockIP] is 0

The method getNewSessionRecord doesn't check
lockIP setting 0 correctly. Add a check to disable checking
when lockIP is 0.

Resolves: #78902
Releases: master,7.6
Change-Id: Ic060ed36e9a7d4fdb1534ffe76ce8bbbee31038c
Reviewed-on: https://review.typo3.org/50908
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not fetch pages with pid < 0 in prepareCacheFlush 07/50907/2
Steffen Göde [Thu, 11 Feb 2016 14:46:29 +0000 (15:46 +0100)]
[BUGFIX] Do not fetch pages with pid < 0 in prepareCacheFlush

Do not fetch workspace related pages to prepare cache flushing.

Resolves: #73241
Releases: master,7.6,6.2
Change-Id: I49bac4f1289848ded8c74b77fc4473ef925086dd
Reviewed-on: https://review.typo3.org/50907
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] rtehtmlarea: Fix isRequiredClass check 93/50893/2
Benjamin Franzke [Thu, 17 Nov 2016 08:34:14 +0000 (09:34 +0100)]
[BUGFIX] rtehtmlarea: Fix isRequiredClass check

Given the following TSConfig:

  RTE {
    classes {
      btn-default {
        name = Default Button
        requires = btn
      }
      btn-primary {
        name = Primary Button
        requires = btn
      }
      btn.selectable = 0
    }
  }

The incorrect isRequiredClass check causes the btn class to be
removed from the RTE toolbarbuttons. This happens because it's
considered unneeded in DOM.removeClass(), which is called by
DOM.addClass() (to remove incompatible classes).

The check in isRequiredClass was probably copied from
some classesRequired lookups, but forgot to inverse the
class that's searched for.

This also fixes the RTE to properly remove the selectable=0 class
(e.g. btn), when a class that requires the aformentioned is removed
(e.g. btn-primary).

Releases: master, 7.6
Resolves: #78730
Change-Id: I5a6ac42c7080835d5018608ab17a39b36a0fb70a
Reviewed-on: https://review.typo3.org/50893
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Reset hidden field information in FormViewhelper 56/50856/2
Nicole Cordes [Wed, 2 Nov 2016 23:26:04 +0000 (00:26 +0100)]
[BUGFIX] Reset hidden field information in FormViewhelper

If a checkbox or a multiple selectbox is rendered, a hidden field is
automatically inserted before to send an empty default value. Field
information are stored within an own viewHelperVariableContainer
variable. After a form is rendered, this information has to be reset to
be able to render another form with same field names. This patch adds
the missing reset of the hidden field information.

Resolves: #78551
Releases: master, 7.6, 6.2
Change-Id: I3cde5618d07cae39b7841875504471cb2341dc17
Reviewed-on: https://review.typo3.org/50856
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix missing tooltips in insert special character window 91/50891/2
Wouter Wolters [Wed, 7 Dec 2016 09:29:43 +0000 (10:29 +0100)]
[BUGFIX] Fix missing tooltips in insert special character window

The extjs popups don't work anymore. Use native title instead.

Resolves: #78903
Releases: 7.6
Change-Id: Ia361c45264346634f9605df144aacf174774311e
Reviewed-on: https://review.typo3.org/50891
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[CLEANUP] Simplify registerPageTSConfigFile description 87/50887/2
Mathias Brodala [Mon, 5 Dec 2016 10:09:43 +0000 (11:09 +0100)]
[CLEANUP] Simplify registerPageTSConfigFile description

Resolves: #78886
Releases: master, 7.6
Change-Id: I1e5922ed510f0f43a6374f9dde061356290b72d9
Reviewed-on: https://review.typo3.org/50887
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[CLEANUP] Simplify addStaticFile description 86/50886/2
Mathias Brodala [Mon, 5 Dec 2016 10:25:02 +0000 (11:25 +0100)]
[CLEANUP] Simplify addStaticFile description

Resolves: #78887
Releases: master, 7.6
Change-Id: Ifb6de078816e851915372d1c5611552fd58f2cce
Reviewed-on: https://review.typo3.org/50886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] T3Editor getPlugins must write to response object 82/50882/2
Markus Klein [Fri, 25 Nov 2016 19:05:40 +0000 (20:05 +0100)]
[BUGFIX] T3Editor getPlugins must write to response object

Fix the ajax request target getPlugins to write its response to
the response object and not to the request.

Moreover fix return value of setModeByFile, which is used
only once, but does not need a return value at all.

Resolves: #78802
Releases: master, 7.6
Change-Id: I840de6fe851a3c4e104c4de1ee9bd0e9c4d8f3c6
Reviewed-on: https://review.typo3.org/50882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Skip swapping/publishing of deleted records 77/50877/4
Oliver Hader [Sat, 3 Dec 2016 15:44:24 +0000 (16:44 +0100)]
[BUGFIX] Skip swapping/publishing of deleted records

In case a content element and the accordant page have been deleted in
separate actions and get published together, the workspace process will
trigger an error message since the removed content element cannot be
published anymore (since it has been processed already with the page).

To avoid this behavior deleted records are collected and checked in the
workspace swapping/publishing process.

Change-Id: If04a198abf81efdc88e75da79da0c01cfaa361ff
Resolves: #47384
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix display of HTTP headers using pageNotFound handler 76/50876/4
Michael Oehlhof [Fri, 21 Oct 2016 19:28:16 +0000 (21:28 +0200)]
[BUGFIX] Fix display of HTTP headers using pageNotFound handler

When using the pageNotFound handler with a curl proxy there are no longer
HTTP headers displayed.

Resolves: #67136
Releases: 7.6
Change-Id: I7c6a9fa3bffbd265345e1a7bfa3ebf25bb2d80b9
Reviewed-on: https://review.typo3.org/50876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Install extension when dependency check is skipped 73/50873/2
Nicole Cordes [Sun, 13 Nov 2016 12:21:16 +0000 (13:21 +0100)]
[BUGFIX] Install extension when dependency check is skipped

You can skip the dependency check if you want to enforce the installation
of an extension. This patch ensures that dependencies which are available
in the system but marked as not compatible are installed anyways.

Resolves: #78677
Releases: master, 7.6
Change-Id: I552ff949524e884bfbb5b8e270cfee0dc4691187
Reviewed-on: https://review.typo3.org/50873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years agoRevert "[BUGFIX] Disable not required checks on cli" 74/50874/2
Alexander Stehlik [Sat, 3 Dec 2016 14:46:07 +0000 (15:46 +0100)]
Revert "[BUGFIX] Disable not required checks on cli"

This reverts commit c02d4e37e44d12125969657e4e5706ff68eb1808.

The condition for checking for CLI mode in ext_tables.php of
the install tool is correct in the 7.6 branch.

The additional checks are not required.

Change-Id: I4d364fc08c68c7c25d9210c08b813247bee7d47f
Resolves: #78854
Relates: #78786
Reviewed-on: https://review.typo3.org/50874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Unify line endings in ext-lang-am.js 68/50868/2
Alexander Stehlik [Sat, 3 Dec 2016 10:21:54 +0000 (11:21 +0100)]
[BUGFIX] Unify line endings in ext-lang-am.js

The ext-lang-am.js now has unique linux linebreaks.
Before it had a mixture of windows and linux linebreaks.

Change-Id: I4f74677c66611e2ca2143cf249934cb69b5e5ea5
Resolves: #78871
Relates: #77808
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50868
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix maximum height of preview links dialog 66/50866/2
Manuel Glauser [Sat, 3 Dec 2016 09:19:13 +0000 (10:19 +0100)]
[BUGFIX] Fix maximum height of preview links dialog

If there are many previewable languages on one page the modal dialog
now will have a scroll bar for more than 4 entries, so it doesn't
break the UI any more.

Add 'modal-inner-scroll' class to modal 'show' call to let the
JS framework handle the maximum height / scroll behavior.

Resolves: #69637
Releases: master, 7.6
Change-Id: I59f91c4364d0d611c5822492b9ace513b1a45a33
Reviewed-on: https://review.typo3.org/50866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix doubleclick-doublesubmit touchup 57/50857/2
Markus Timtner [Mon, 21 Nov 2016 10:07:58 +0000 (11:07 +0100)]
[BUGFIX] Fix doubleclick-doublesubmit touchup

If a user double-clicks fast enough on any save-button of any new record
in Chrome, the record gets submitted twice.
This fix introduces a semaphore variable in the corresponding JS
to ensure the record gets submitted only once.

Resolves: #77942
Related: #77729, #77944
Releases: master, 7.6
Change-Id: I73516b6a07b23b947e0756dea7051863546a246d
Reviewed-on: https://review.typo3.org/50857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Make showAccessRestrictedPages work 75/50775/4
Claus Due [Thu, 17 Nov 2016 12:14:24 +0000 (13:14 +0100)]
[BUGFIX] Make showAccessRestrictedPages work

This patch fixes a problem where setting showAccessRestrictedPages
setting in HMENU etc. did not result in the correct behavior according
to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html.

The patch changes the behavior caused by using `NONE` as
keyword in the setting.

Before: using the option renders `<a>Page title</a>` when page is inaccessible.

After: using the option renders `<a href="index.php?id=123">Page title</a>`
when page is not accessible.

Change-Id: I4364f7ec9f44e1e0b70654830efc236f20e6bf30
Resolves: #17904
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Avoid duplicate calls to update reference index 74/50774/4
Claus Due [Mon, 21 Nov 2016 15:52:03 +0000 (16:52 +0100)]
[BUGFIX] Avoid duplicate calls to update reference index

This patch adds a check when processing the update
reference index stack, in order to avoid calling the
update function more than once with the same input
arguments (which are $table and $uid).

Saves around 100 SQL queries when doing a standard
copy of 25 (nested) pages with 25 content elements.

Change-Id: If162218d4eabb749a92270e18c7c39108fd15f34
Resolves: #78761
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50774
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Reduce expensive calls in AbstractMenuContentObject 76/50776/5
Claus Due [Mon, 14 Nov 2016 14:21:43 +0000 (15:21 +0100)]
[BUGFIX] Reduce expensive calls in AbstractMenuContentObject

This patch reduces the number of SQL queries and PHP calls
which get performed when rendering menus. The patch has
two parts:

* Runtime cache is used to remember a generated link and
  is given a cache identifier which includes a hash of all
  parameters which may affect the link.
* Runtime cache is used to remember the decision if a page
  is a submenu.

The item rendering function is called every time the same page
is rendered in any menu in the same request, and the decision
function to check if page is a sub-menu is called at least three
times with the same UID when generating a menu. Both of these
implements together reduce the necessary re-calling of methods
which generate the same output given the same arguments.

Change-Id: Idd6225081e8fb3f8160270af3d865b48208b756e
Releases: master, 7.6
Resolves: #78693
Reviewed-on: https://review.typo3.org/50776
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Set dimensions for custom svg TYPO3 backend logo 64/50864/2
Georg Ringer [Thu, 17 Nov 2016 07:49:08 +0000 (08:49 +0100)]
[BUGFIX] Set dimensions for custom svg TYPO3 backend logo

Width and height is automatically set for pixel based backend
logos. This patch makes sure this also is done for svg file format.

Releases: master, 7.6
Resolves: #78590
Change-Id: Iff1dddc827d002e10fd4ec6f3b57bc16920b1c86
Reviewed-on: https://review.typo3.org/50864
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Flaky child references handling for pages_language_overlay 59/50859/2
Andreas Allacher [Wed, 8 Jun 2016 05:47:17 +0000 (07:47 +0200)]
[BUGFIX] Flaky child references handling for pages_language_overlay

IRRE records have to point to their specific localized parent record.
This works in general for tables containing records of the default
language as well as localizations. For the "pages" table this look-up
has to be extended to query from "pages_language_overlay".

Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5
Resolves: #76174
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Resolves editing problem in language mode 58/50858/2
Markus Sommer [Mon, 7 Nov 2016 15:02:21 +0000 (16:02 +0100)]
[BUGFIX] Resolves editing problem in language mode

* Resolves the problem with many languages
* Set width to min-width to enlarge the viewport

Resolves: #78594
Releases: master, 7.6

Change-Id: I7360f620021d2614800f03da7960bb9acd2360e1
Reviewed-on: https://review.typo3.org/50858
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Enforce Linux Line endings in .gitattributes 55/50855/3
Kay Strobach [Fri, 2 Sep 2016 20:12:10 +0000 (22:12 +0200)]
[TASK] Enforce Linux Line endings in .gitattributes

This settings enforces LF consistently on all plattforms
and fits it to the .editorconfig

Resolves: #77808
Releases: master, 7.6
Change-Id: Ibc6efbf9a2a2360d84aa0ed4c3b74ff731ef1398
Reviewed-on: https://review.typo3.org/50855
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FOLLOWUP][BUGFIX] Reset FormViewHelper on execution 49/50849/2
Anja Leichsenring [Fri, 2 Dec 2016 11:18:53 +0000 (12:18 +0100)]
[FOLLOWUP][BUGFIX] Reset FormViewHelper on execution

Incomplete backport caused unit tests to fail.

Change-Id: Ib447b2327c5c54956d86149c08c503d9a463c2b4
Resolves: #77097
Releases: 7.6
Reviewed-on: https://review.typo3.org/50849
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Reset FormViewHelper on execution 47/50847/2
Helmut Hummel [Tue, 19 Jul 2016 14:23:36 +0000 (16:23 +0200)]
[BUGFIX] Reset FormViewHelper on execution

This commit ensures that the FormViewHelper is in a clean state and
can render the required hidden fields (again).

Resolves: #77097
Releases: master, 7.6, 6.2
Change-Id: I82f90ee7c0aaf44cd48a9abde6dbb012f536543e
Reviewed-on: https://review.typo3.org/50847
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Force string casting of $parserList 41/50841/2
Andreas Fernandez [Thu, 1 Dec 2016 19:05:41 +0000 (20:05 +0100)]
[BUGFIX] Force string casting of $parserList

The method `BackendUtility::explodeSoftRefParserList()` checks whether
`$parserList` is an empty string. This check may fail, as the variable may
be null instead. `$parserList` is now casted to a string, which converts
null to an empty string.

Resolves: #78858
Releases: master, 7.6
Change-Id: Ia833fd64f3349c5856a879e917bb3cd6f581caa0
Reviewed-on: https://review.typo3.org/50841
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Avoid RTE context menu collapse to arrows only 78/50778/2
Claus Due [Fri, 25 Nov 2016 11:57:44 +0000 (12:57 +0100)]
[BUGFIX] Avoid RTE context menu collapse to arrows only

Solves an issue in Chrome where calculating the height of
the editor window returns zero. Solved by hardcoding a
minimum context menu height of 150 pixels; applied via
Math.max()'ing the resolved height and 150.

Change-Id: Ie79507d661128f6aff31c12573b9c020b913ec8a
Resolves: #78795
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove has-call to caching framework in explodeSoftRefParserList 83/50783/3
Wouter Wolters [Tue, 22 Nov 2016 22:22:07 +0000 (23:22 +0100)]
[TASK] Remove has-call to caching framework in explodeSoftRefParserList

No need to call has on the caching framework in the function
explodeSoftRefParserList. Furthermore we do not need to store false
to the runtime cache if parseList is an empty string.

Resolves: #78773
Releases: master, 7.6
Change-Id: Iaa3fae35d4d07a78eb0fde8efc892a9ddb46b974
Reviewed-on: https://review.typo3.org/50783
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Don't set resource storages permanently offline 37/50837/2
Oliver Hader [Thu, 1 Dec 2016 16:30:47 +0000 (17:30 +0100)]
[FOLLOWUP][BUGFIX] Don't set resource storages permanently offline

Resolves: #75184
Releases: master, 7.6
Change-Id: Iff4ea23dfc1e8d96c45ba675aab6484830468718
Reviewed-on: https://review.typo3.org/50837
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Show errors on ajax file actions 35/50835/2
Alexander Opitz [Wed, 23 Nov 2016 11:43:21 +0000 (12:43 +0100)]
[BUGFIX] Show errors on ajax file actions

Respond with status code 500 on ajax file actions, so JS can differ
between success and failure.

Resolves: #78776
Related: #69916
Releases: master, 7.6
Change-Id: I166cb86be64a26d1a3b44bfba626bba3fd151df1
Reviewed-on: https://review.typo3.org/50835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] RTE TYPO3Link PopupWindow size fallback 73/49873/2
Pierrick Caillon [Tue, 6 Sep 2016 14:06:04 +0000 (16:06 +0200)]
[BUGFIX] RTE TYPO3Link PopupWindow size fallback

The RTE TYPO3Link.js link chooser popup uses the
'''top.TYPO3.configuration.RTEPopupWindow''' sizes.
When using Frontend Editing, this object is not available.
As fallback, '''top.TYPO3.configuration.PopupWindow''' is used.

Resolves: #75980
Releases: 7.6
Change-Id: Iaf4389abce3e7a49ddfa42165a7322923e520fde
Reviewed-on: https://review.typo3.org/49873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Disable not required checks on cli 18/50818/2
Markus Sommer [Fri, 25 Nov 2016 10:54:27 +0000 (11:54 +0100)]
[BUGFIX] Disable not required checks on cli

* $_SERVER['HTTP_HOST'] is not avalible on cli
* Mostly max_execution_time is not set on cli

Resolves: #78786
Releases: master, 7.6
Change-Id: If19dab862e2762fab5fec113c93eba80f75a4aaf
Reviewed-on: https://review.typo3.org/50818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Add missing space between language flag and title language diff 17/50817/2
Gianluigi Martino [Tue, 29 Nov 2016 16:00:44 +0000 (17:00 +0100)]
[TASK] Add missing space between language flag and title language diff

Adding some space between language flag and title in language diff column

Releases: master, 7.6
Resolves: #78707
Change-Id: Ic8f69d4ab6181c741efa880ceeec67ea7d807ace
Reviewed-on: https://review.typo3.org/50807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-on: https://review.typo3.org/50817

2 years ago[BUGFIX] Don't set resource storages permanently offline automatically 16/50816/2
Marc Willmann [Tue, 25 Oct 2016 15:18:18 +0000 (17:18 +0200)]
[BUGFIX] Don't set resource storages permanently offline automatically

When the storage drive coudn't be initialized correctly the storage is
only put offline for the current request. The error thrown by the driver
is logged to database table sys_log as well.

Resolves: #75184
Releases: master, 7.6
Change-Id: I4b05b732f887c0679e9cdda77793e4b304ac3fdb
Reviewed-on: https://review.typo3.org/50816
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix incorrect position of RTE context menu 80/50780/3
Claus Due [Fri, 25 Nov 2016 13:16:53 +0000 (14:16 +0100)]
[BUGFIX] Fix incorrect position of RTE context menu

Fixes the position of the context menu to the cursor,
preventing it from being displayed outside of the
RTE frame.

Change-Id: Ib1bf23da6463beb32c49a9272bf225e73c4bc9f6
Resolves: #78001
Releases: 7.6
Reviewed-on: https://review.typo3.org/50780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Glauser <mail@manuelglauser.ch>
Tested-by: Manuel Glauser <mail@manuelglauser.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>