Packages/TYPO3.CMS.git
5 years ago[TASK] Create new processor registry 58/27958/9
Frans Saris [Fri, 28 Feb 2014 22:34:57 +0000 (23:34 +0100)]
[TASK] Create new processor registry

File processing might be different for external storages.
Therefore it must be possible to register your own File Processors
and make the registry driver aware.

Resolves: #56775
Releases: 6.2
Change-Id: I187f6f987f7b0bc92989ed38cbef248449a7f59f
Reviewed-on: https://review.typo3.org/27958
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Add FAL support for import in sys extension impexp 36/27836/8
Marc Bastian Heinrichs [Fri, 21 Feb 2014 15:31:05 +0000 (16:31 +0100)]
[TASK] Add FAL support for import in sys extension impexp

Until now only files from TCA type group internal_type file or
file_reference could be imported and exports from version 6.x
including sys_file records leads to exceptions on importing.
The patch adds support for handling record types introduced
with the File Abstraction Layer.

Resolves: #55532
Resolves: #55528
Resolves: #55906
Releases: 6.2
Change-Id: I7521c84094b0a0424e13c5f91c26b630bbbccbfe
Reviewed-on: https://review.typo3.org/27836
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] PHP Runtime Notice in saltedpasswords 61/28261/2
Xavier Perseguers [Tue, 11 Mar 2014 15:23:11 +0000 (16:23 +0100)]
[BUGFIX] PHP Runtime Notice in saltedpasswords

Declaration of method compareUident() should be compatible with its
parent class.

Change-Id: I66979bd76b204bbb762c41037cdaae5f006debb5
Fixes: #56769
Releases: 6.2
Reviewed-on: https://review.typo3.org/28261
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Layout category tree is broken 50/28250/2
Patrick Broens [Tue, 11 Mar 2014 10:43:02 +0000 (11:43 +0100)]
[BUGFIX] Layout category tree is broken

There are several issues with the layout of the category tree.

When hovering the whole element, the categories (text) get underlined.
The categories text is not aligned properly with the icon and checkbox.
The glow on a checkbox with focus is bigger than the checkbox itself.

This patch fixes these issues by adding CSS for the tree when used in
TCEforms.

Change-Id: Id9faaf906c786a95246d12f15821372648fc44b6
Resolves: #56752
Releases: 6.2
Reviewed-on: https://review.typo3.org/28250
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[FEATURE] Allow Storages outside the webroot 60/27760/11
Steffen Ritter [Thu, 20 Feb 2014 17:26:20 +0000 (18:26 +0100)]
[FEATURE] Allow Storages outside the webroot

Storages can be marked as not public or be outside of webroot.
There are no direct links to the files posible.

This change adds a eID implementation to create urls to these files.
It also implements a hook in het eID dispatcher that makes is possible
to add custom security/access checks when delivering files.

Releases: 6.2
Resolves: #36420
Change-Id: Ie7fc9c8a674a3200ea2b29d1adc17327d10bd6e5
Reviewed-on: https://review.typo3.org/27760
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Wrong note in ResourceFactory 23/28223/3
Frans Saris [Mon, 10 Mar 2014 14:23:52 +0000 (15:23 +0100)]
[BUGFIX] Wrong note in ResourceFactory

A note in the phpdoc header of ResourceFactory states it is a
lowlevel API. But this is wrong as at least since 6.2 this is
the public API and therefor this note is removed.

Resolves: #56731
Releases: 6.2
Change-Id: I90ed0dafa12656efe6d037abebee7b92de54a6f7
Reviewed-on: https://review.typo3.org/28223
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Flash messages are not shown with AJAX requests 00/28200/4
Xavier Perseguers [Sun, 9 Mar 2014 16:56:21 +0000 (17:56 +0100)]
[BUGFIX] Flash messages are not shown with AJAX requests

Due to the use of DragUploader to upload files, flash messages
are not shown immediately but after manually reloading the page.

Change-Id: Ia2e8750792bd04209b5a1f2ce0e2a63f970ba3a8
Fixes: #56561
Releases: 6.2
Reviewed-on: https://review.typo3.org/28200
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Return ProcessedFile instead of File if possible 53/27753/9
Steffen Ritter [Thu, 20 Feb 2014 12:16:55 +0000 (13:16 +0100)]
[TASK] Return ProcessedFile instead of File if possible

You can query the FAL-API for files by their filename. If the file resides
in the processing-folder of a storage it is a valid file to the storage.
Therefore creating a file-object and indexing it would be a valid thing.

Since this is not intended additionally to the storage the ResourceFactory
must know about that, too. This change implements this awareness, so there
is no way to create a FileObject for files which reside within the
processing folder.
In 6.0 and 6.1 there has been a dirty workaround for that by marking those
files as not indexable which was removed silently when introducing the new
indexer.

Releases: 6.2
Resolves: #54234
Change-Id: I274c47717560a6efc175fa94aacc4770a578fd3f
Reviewed-on: https://review.typo3.org/27753
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing argument in ReferenceIntegrity updater 33/28233/2
Eric Chavaillaz [Mon, 10 Mar 2014 16:55:35 +0000 (17:55 +0100)]
[BUGFIX] Missing argument in ReferenceIntegrity updater

When trying to use the upgrade wizards, a fatal error
is thrown because the mandatory where_clause is missing
in a call to exec_SELECTquery.

Resolves: #56737
Releases: 6.2
Change-Id: I4814b9c2b0b30cea11e81bbf64d94ba8213a07cb
Reviewed-on: https://review.typo3.org/28233
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie 27/28227/3
Nicole Cordes [Mon, 10 Mar 2014 15:21:29 +0000 (16:21 +0100)]
[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie

In the current master every time when removeCookie is triggered a
Set-Cookie header is generated. A cookie should only be deleted if it
was set before. As removeCookie can handle different cookie names, the
check is performed before calling removeCookie function.

Resolves: #56733
Releases: 6.2
Change-Id: I518220ce2def8d9db901b1e8daa87de745317629
Reviewed-on: https://review.typo3.org/28227
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Remove loadExtensionTables() from unit test bootstrap 35/28235/3
Christian Kuhn [Mon, 10 Mar 2014 18:01:19 +0000 (19:01 +0100)]
[TASK] Remove loadExtensionTables() from unit test bootstrap

With proper mocking in place, loadExtensionTables() can be
removed from unit test bootstrap.
This speeds up the test suite quite a bit since the huge
$GLOBALS['TCA'] is no longer initialized and gives backup code
of phpunit less headaches.

Change-Id: I9ac96047a49914f3c6ab7acc318bbc36488b6c5b
Resolves: #56739
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28235
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Improve mocking in IconUtilityTest 20/28220/2
Christian Kuhn [Mon, 10 Mar 2014 13:26:42 +0000 (14:26 +0100)]
[BUGFIX] Tests: Improve mocking in IconUtilityTest

The IconUtility tests depend on initialized $GLOBALS['TBE_STYLES']
and sometimes on initialized $GLOBALS['TCA']. This dependency is
removed by properly setting up needed arrays now, this also makes
the tests more obvious and easier to understand.
Additionally, the static cache property introduced with #56110 now
uses late static binding, enabling the tests to extend the class
and route any static cache changes to an test internal overlay
class to not pollute the static property of the base class.

Change-Id: I01166058da051a26d7aa2df315858468828ed346
Resolves: #56725
Related: #51436
Related: #56110
Releases: 6.2
Reviewed-on: https://review.typo3.org/28220
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Change notification level for missing opcode cache 16/28216/3
Sebastian Müller [Mon, 10 Mar 2014 11:22:10 +0000 (12:22 +0100)]
[BUGFIX] Change notification level for missing opcode cache

Now the notification level is set to notice instead of warning.
Therefore no email notification will be send if the user has not
set his cache or his cache has only medium performance

Resolves: #55392
Releases: 6.2
Change-Id: I90758ba658477a4b92f1a110228eb7950648ec39
Reviewed-on: https://review.typo3.org/28216
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Improve mocking in ext:belog 15/28215/2
Christian Kuhn [Mon, 10 Mar 2014 10:57:53 +0000 (11:57 +0100)]
[BUGFIX] Tests: Improve mocking in ext:belog

The subject method initialize() calls some static dependencies
that can not be mocked. They do DB actions in the end. The patch
now mocks TYPO3_DB to suppress this DB call.

Change-Id: I43b0e002bfab081ed41a5c259011f465b507a74b
Resolves: #56718
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28215
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong IRC URL for Packagist 11/28211/2
Fabien Udriot [Mon, 10 Mar 2014 09:31:02 +0000 (10:31 +0100)]
[BUGFIX] Wrong IRC URL for Packagist

Packagist complains about current IRC URL format.

Change-Id: Id8abcad6525c06d6941144cd2e1e8ea372cc975a
Releases: 6.2
Resolves: #56713
Reviewed-on: https://review.typo3.org/28211
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Tests: Improve Mocking in ext:extbase 07/28207/3
Anja Leichsenring [Sun, 9 Mar 2014 23:39:10 +0000 (00:39 +0100)]
[BUGFIX] Tests: Improve Mocking in ext:extbase

Change-Id: I61f7f92da42d691b0556f1e53b20d39eb082c12f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28207
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Improve TCA mocking in BackendUtility 06/28206/3
Christian Kuhn [Sun, 9 Mar 2014 23:20:17 +0000 (00:20 +0100)]
[BUGFIX] Tests: Improve TCA mocking in BackendUtility

ext:core BackendUtilityTest no longer depends on initialized TCA.

Change-Id: I5b97b86d57da15b6176dd3033ec8fda1f4209f85
Resolves: #56699
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28206
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend 04/28204/2
Anja Leichsenring [Sun, 9 Mar 2014 22:28:24 +0000 (23:28 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA'].

Change-Id: Ib38f2dd94288c5c4f8940d3c8c969ea0459ebbcb
Resolves: #56698
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core 03/28203/2
Christian Kuhn [Sun, 9 Mar 2014 22:16:39 +0000 (23:16 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA']

Change-Id: I7dee44b5a98f2384c2b77c51ebc678ff15669475
Resolves: #56696
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28203
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Added composer.json for the TYPO3 CMS project 23/27423/5
Christian Opitz [Fri, 7 Feb 2014 16:17:33 +0000 (17:17 +0100)]
[TASK] Added composer.json for the TYPO3 CMS project

Added a composer.json file that contains
* name, description, keywords, homepage and license
* authors (core team and community)
* several support addresses
* requirements (php, php extensions and the composer typo3 installer)
* suggestions for php extensions
* branch alias for current development version (6.2)
* the packages, that are provided (system extensions)

Resolves: #55770
Releases: 6.2
Change-Id: Ibb94787ee12f9e580dedb1652c444f35e51d1aa9
Reviewed-on: https://review.typo3.org/27423
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[TASK] Add missing logDeprecatedFunction() to getAliasForClassName() 72/27172/4
Stefan Neufeind [Sun, 9 Mar 2014 18:20:43 +0000 (19:20 +0100)]
[TASK] Add missing logDeprecatedFunction() to getAliasForClassName()

Function is already deprecated but didn't write to
deprecation-log so far.

Resolves: #55481
Releases: 6.2
Change-Id: I5b8150e7b2d7be8fdc87a3a4a93932a04cb2cb09
Reviewed-on: https://review.typo3.org/27172
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Tests: Simplify unit test bootstrap 99/28199/2
Christian Kuhn [Sun, 9 Mar 2014 16:00:31 +0000 (17:00 +0100)]
[TASK] Tests: Simplify unit test bootstrap

There is no need to initialize $GLOBALS['BE_USER'] anymore
in unit tests since mocking of this dependency is complete.

Change-Id: I21ab751d4b66ba2d9658becbd6e0fcd16d139c4b
Resolves: #56689
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28199
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Resolve incomplete mocking for sysext:fluid 98/28198/3
Anja Leichsenring [Sun, 9 Mar 2014 15:43:26 +0000 (16:43 +0100)]
[BUGFIX] Resolve incomplete mocking for sysext:fluid

Some Tests in sysext:backend rely on an existing BackendUserAuth object.
In order to decouple the tests from the TYPO3 Environment,
those are mocked now.

Change-Id: Ibfd9de2f5a7673eecca61c35e59852017edd2f0d
Resolves: #56688
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28198
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking in be_user 96/28196/2
Christian Kuhn [Sun, 9 Mar 2014 15:31:45 +0000 (16:31 +0100)]
[BUGFIX] Tests: Incomplete mocking in be_user

ModuleDataStorageServiceTest now mocks $GLOBALS['BE_USER']
to not rely on instantiation of this global.

Change-Id: I5ab6b962d95f2ab183dfc1b1b53dea7deaa464c5
Resolves: #56687
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28196
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Resolve incomplete mocking for sysext:backend 93/28193/4
Anja Leichsenring [Sun, 9 Mar 2014 15:07:18 +0000 (16:07 +0100)]
[BUGFIX] Resolve incomplete mocking for sysext:backend

Some Tests in sysext:backend rely on an existing BackendUserAuth object.
In order to decouple the tests from the TYPO3 Environment,
those are mocked now.

Change-Id: I2760f301aeb79e963a87f02258df04306a68cec6
Resolves: #56686
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28193
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mock in ResourceFactoryTest 92/28192/3
Christian Kuhn [Sun, 9 Mar 2014 15:03:32 +0000 (16:03 +0100)]
[BUGFIX] Tests: Incomplete mock in ResourceFactoryTest

FAL ResourceFactoryTest retrieveFileOrFolderObject* not only
tests the method but also lots of not mocked dependencies. The
tests are renamed and changed to stick to test the subject only.

Resolves: #56684
Related: #51436
Releases: 6.2
Change-Id: If247e923b8e79995279ad48bdc35f5b8976bfd57
Reviewed-on: https://review.typo3.org/28192
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Reduce unit test bootstrap 90/28190/2
Christian Kuhn [Sun, 9 Mar 2014 13:13:02 +0000 (14:13 +0100)]
[TASK] Reduce unit test bootstrap

With the removal of $GLOBALS['FILEMOUNTS'] the unit test no longer
depend on initialization of backend user mounts. Remove this
bootstrap line.

Change-Id: Ie9860dd7b15a4baff330c8e3cad16d3ae3092e75
Resolves: #56681
Related: #55547
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28190
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Introduce failsafe view in install tool 67/27067/11
Helmut Hummel [Thu, 6 Mar 2014 08:40:41 +0000 (09:40 +0100)]
[BUGFIX] Introduce failsafe view in install tool

The installer does not work, if doc comment reflection
is broken, so we need to make the first install step
more robust by using inject methods and introducing
a failsafe view which does simple php templating
in case critical errors (like doc comments disabled)
occur.

Resolves: #55352
Releases: 6.2
Change-Id: I424d6a290b65ae023ec19a745477cfaecdef72c7
Reviewed-on: https://review.typo3.org/27067
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ResourceStorage::SIGNAL_PreFileAdd should be triggered earlier 99/28099/4
Xavier Perseguers [Thu, 6 Mar 2014 10:43:16 +0000 (11:43 +0100)]
[BUGFIX] ResourceStorage::SIGNAL_PreFileAdd should be triggered earlier

The PreFileAdd signal should be triggered before the file exist check.
So the name and/or content can be manipulated before the target filename
is checked.

Change-Id: I0bbe32a4efa395a99278c480210310bd7466f259
Fixes: #56394
Releases: 6.2
Reviewed-on: https://review.typo3.org/28099
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Wrong file icon in info popup 19/27819/4
Frans Saris [Mon, 24 Feb 2014 20:55:40 +0000 (21:55 +0100)]
[BUGFIX] Wrong file icon in info popup

In the info popup of a file/folder the wrong icon is shown.

This patch changes it so IconUtility::getSpriteIconForResource()
is used and moves the rendering of the header to the
DocumentTemplate.

Resolves: #56251
Releases: 6.2
Change-Id: I7fc40af85b8bc623112bcec29c2409221a937718
Reviewed-on: https://review.typo3.org/27819
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Deprecate insertModuleFunction "$classPath" parameter 62/24462/9
Ernesto Baschny [Mon, 7 Oct 2013 16:45:32 +0000 (18:45 +0200)]
[TASK] Deprecate insertModuleFunction "$classPath" parameter

Deprecates the need to specify the $classPath when registering a submodule
with ExtensionManagementUtility::insertModuleFunction. Remove the
parameter's usage throughout the system extensions.

Also re-adds the removed include_once that were removed without proper
deprecation before (see #49992).

Resolves: #52594
Releases: 6.2
Change-Id: I090278b8e2e7a15e05b14dca757ae2b8ef1e5fb4
Reviewed-on: https://review.typo3.org/24462
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Unnatural processing order in IRRE tests 87/27887/4
Oliver Hader [Thu, 27 Feb 2014 11:18:18 +0000 (12:18 +0100)]
[BUGFIX] Unnatural processing order in IRRE tests

The IRRE tests for creating and modifying records first process
offer, hotel then content which is the unnatural order compared
to the processing delivered by the FormEngine (t3lib_TCEforms).
To avoid incorrect testing behaviour and invalid testing
results, the order is changed to content, hotel and offer
(parent to child).

Resolves: #56374
Releases: 6.2
Change-Id: Ib14fc2d50b493e4be982faeba77401b320868639
Reviewed-on: https://review.typo3.org/27887
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Install Tool does not save Extbase object cache Configuration 75/28175/3
Michiel Roos [Fri, 7 Mar 2014 20:57:59 +0000 (21:57 +0100)]
[BUGFIX] Install Tool does not save Extbase object cache Configuration

Change-Id: I1ee28a5af824b048863c61321a226bf7c9843f77
Resolves: #55556
Releases: 6.2
Reviewed-on: https://review.typo3.org/28175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[FEATURE] TypoScript property escapeJsValue 77/28177/3
Jigal van Hemert [Sat, 8 Mar 2014 08:46:39 +0000 (09:46 +0100)]
[FEATURE] TypoScript property escapeJsValue

The stdWrap property escapeJsValue allows content to be
included in JavaScript strings.

Resolves: #56642
Documentation: #56665
Releases: 6.2
Change-Id: I43f59889caec1a89970b94c93c93894d589243c9
Reviewed-on: https://review.typo3.org/28177
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Improve AbstractDataHandlerActionTestCase 16/27816/6
Marc Bastian Heinrichs [Mon, 24 Feb 2014 15:21:33 +0000 (16:21 +0100)]
[TASK] Improve AbstractDataHandlerActionTestCase

Improvements for the AbstractDataHandlerActionTestCase to
get better functional test results in general and working
functional tests in impexp (e.g. for FlexForm XML):

* collect all fail messages before calling fail()
* check records for left rows that was not assigned in csv
* do strict compare if value is NULL
* compare XML, e.g. FlexForm

Resolves: #56241
Releases: 6.2
Change-Id: Ic21c27261cbe18dc5fd37c4869c10264880b731e
Reviewed-on: https://review.typo3.org/27816
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Cleanup jumpToUrl() and unused JS in Backend 80/28180/4
Benjamin Mack [Sat, 8 Mar 2014 10:43:06 +0000 (11:43 +0100)]
[CLEANUP] Cleanup jumpToUrl() and unused JS in Backend

The jumpToUrl() is defined in every
second module as inline JS. As the
duplicated code is erroneous and
can be shimmed completely, the
function is added to every doc-template
code by default, but can be overriden and
removed completely - which is still the case
in some existing modules.

Additionally the variable "script_ended"
is not used at all anymore, and was removed
as well.

Releases: 6.2
Resolves: #56667
Change-Id: I716611bffce402c5f423c3d64c763d6675a79d14
Reviewed-on: https://review.typo3.org/28180
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Make Import/Export work with Package Manager 83/28183/4
Benjamin Mack [Sat, 8 Mar 2014 11:29:56 +0000 (12:29 +0100)]
[BUGFIX] Make Import/Export work with Package Manager

When displaying the import/export backend module
there are warnings and an empty extension list,
because the extension Selector does not use the
API to fetch the extension list, but does a raw
$TYPO3_LOADED_EXT instead.

Resolves: #56670
Releases: 6.2
Change-Id: I851cc1f7e01acd9f743559a9400340364280ba7e
Reviewed-on: https://review.typo3.org/28183
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Use function for temp. page tree in BrowseLinks too 79/28179/2
Markus Klein [Sat, 8 Mar 2014 10:38:29 +0000 (11:38 +0100)]
[TASK] Use function for temp. page tree in BrowseLinks too

The new introduced function ElementBrowser::getTemporaryTreeMountCancelNotice()
shall also be used in its subclass to remove code duplication.

Resolves: #56666
Releases: 6.2
Change-Id: I0d7aca1c0695479f7ced9323098c0e7b04f1abda
Reviewed-on: https://review.typo3.org/28179
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Extension upload as zip on Windows systems ignores directories 11/26911/2
Wouter Wolters [Fri, 17 Jan 2014 20:13:58 +0000 (21:13 +0100)]
[BUGFIX] Extension upload as zip on Windows systems ignores directories

Using DIRECTORY_SEPARATOR on Windows environments is a "\" instead of
a "/". Fix this by replacing the constant with '/'.

Resolves: #53740
Resolves: #53346
Releases: 6.2
Change-Id: Ia745a17fd47c527b57e78babef76b67f30af0454
Reviewed-on: https://review.typo3.org/26911
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Temporary DB tree mount notice missing in ElementBrowser 01/17101/12
Lorenz Ulrich [Tue, 11 Dec 2012 14:57:18 +0000 (15:57 +0100)]
[BUGFIX] Temporary DB tree mount notice missing in ElementBrowser

If "Stop Page Tree" is set for a page, it is possible to set temporary
DB tree mounts in the element browser/link browser.
If such a tree mount is set, a notice is displayed right above the tree.

This notice is necessary to cancel this temporary mount.
Currently the ElementBrowser misses this notice when used
for e.g. header_link.

Change-Id: I942aad0e54d17ceb793008850f0563bb416503be
Fixes: #43885
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/17101
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove deprecated doDisplayTopFrameCM 20/28120/2
Wouter Wolters [Thu, 6 Mar 2014 20:38:29 +0000 (21:38 +0100)]
[TASK] Remove deprecated doDisplayTopFrameCM

Resolves: #56623
Releases: 6.2
Change-Id: Ib24adf0029f23053b1218340cb11b6390964fefd
Reviewed-on: https://review.typo3.org/28120
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Remove references to $GLOBALS['FILEMOUNTS'] 27/27227/6
Benjamin Mack [Sat, 1 Feb 2014 11:19:38 +0000 (12:19 +0100)]
[CLEANUP] Remove references to $GLOBALS['FILEMOUNTS']

Global filemounts are not supported with FAL anymore
as the implementation is done via file storages directly.
All references to the global FILEMOUNTS is removed as
it was an empty array since 6.0.

Next step (but not part of this patch) is to clean up the
functions in BasicFileUtility that make use of the filemounts.

Releases: 6.2
Resolves: #55547
Change-Id: I07e08afe54c174d1c3a67c41645819e5831fd1e3
Reviewed-on: https://review.typo3.org/27227
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove unused function BackendUtility::updatePagesTSconfig() 28/25228/4
Philipp Gampe [Sat, 9 Nov 2013 08:51:55 +0000 (09:51 +0100)]
[TASK] Remove unused function BackendUtility::updatePagesTSconfig()

The function is not used in the core and marked as @internal since the
beginning of the time (revision 1). Therefore it is removed directly.

Resolves: #53471
Releases: 6.2
Change-Id: Ib74fa65b24caa9879b16921e13e3d0bed894b712
Reviewed-on: https://review.typo3.org/25228
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix Misleading CommandController naming for Language update 11/24511/5
Cedric Ziel [Wed, 9 Oct 2013 23:12:14 +0000 (01:12 +0200)]
[BUGFIX] Fix Misleading CommandController naming for Language update

Due to CommandControllers' nature, an UpdateCommandController leads to the
execution of `cli_dispatch.phpsh extbase update:update`.

This patch fixes it to `cli_dispatch.phpsh extbase language:update`.

Also contains a minor change and adds a type-hint for IDE's.

Resolves: #54128
Releases: 6.2
Change-Id: I1b21b8f715bfd1928f1e857846c0542d90705b6f
Reviewed-on: https://review.typo3.org/24511
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow user update without password changes in sys_action 77/27377/4
Nicole Cordes [Thu, 6 Feb 2014 10:59:45 +0000 (11:59 +0100)]
[BUGFIX] Allow user update without password changes in sys_action

If you want to edit a user within the sys_action module, you have to
set a (new) password as otherwise the record won't be updated. This
patch allows an empty password field for updates while new users
still need a defined password.

Resolves: #25700
Releases: 6.2
Change-Id: I37c20a706b15ebce458033c4f5fe4016236ef1d8
Reviewed-on: https://review.typo3.org/27377
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Deprecate usage of $GLOBALS['typo3CacheManager'] 01/28101/7
Helmut Hummel [Thu, 6 Mar 2014 10:53:07 +0000 (11:53 +0100)]
[TASK] Deprecate usage of $GLOBALS['typo3CacheManager']

* Replace all instances of $GLOBALS['typo3CacheManager']
  in the core with a makeInstance call.
* Adapt the tests.
* Make use of dependency injection where possible.
* Add compatibility layer with deprecation message
  for $GLOBALS['typo3CacheManager'] and $GLOBALS['typo3CacheFactory']

Resolves: #56597
Releases: 6.2
Change-Id: Idb035723626b24cfd768204bf24987171f5b0feb
Reviewed-on: https://review.typo3.org/28101
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Improve code style for FormEngine::getTSCpid() 67/28167/2
Alexander Stehlik [Fri, 7 Mar 2014 15:22:49 +0000 (16:22 +0100)]
[CLEANUP] Improve code style for FormEngine::getTSCpid()

The PHPDoc is fixed. The method returns an array and not an integer.

Additionally the class variable that is used in this method for
storing the cached values is added as a property.

Releases: 6.2
Resolves: #56658
Change-Id: I6010cf97781001cd760c891da3df3bfb7a605b73
Reviewed-on: https://review.typo3.org/28167
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] SoftReferenceIndex typolink lacks support for title attributes 83/28083/8
Marc Bastian Heinrichs [Wed, 5 Mar 2014 16:07:20 +0000 (17:07 +0100)]
[BUGFIX] SoftReferenceIndex typolink lacks support for title attributes

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for the title attributes was missing.
This leads to lost title attributes on typolinks in exports from impexp.

Resolves: #56580
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I9bf5c02b79ae4c9024322f0da99dcca37b678daa
Reviewed-on: https://review.typo3.org/28083
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warn about apc.enable_cli=0 on command line 35/28035/4
Christian Weiske [Tue, 4 Mar 2014 13:18:50 +0000 (14:18 +0100)]
[BUGFIX] Warn about apc.enable_cli=0 on command line

When running a CLI script via typo3/cli_dispatch.phpsh,
using the APC caching backend will lead to errors like
> TYPO3 Exception #1232986877: Could not set value.

This patch checks if TYPO3 is running on CLI, and validates the
apc.enable_cli setting to give a proper error message.

Change-Id: Icbeb619fc2054634274b492df94dbbc89958a8b6
Resolves: #25274
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/28035
Reviewed-by: Ernesto Baschny
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Refactor init() function of ElementBrowser 31/27631/10
Tymoteusz Motylewski [Fri, 14 Feb 2014 12:29:01 +0000 (13:29 +0100)]
[TASK] Refactor init() function of ElementBrowser

Splits huge method (~450 lines) into several small methods,
in the similar way it was done for BrowseLinks and SelectImage.

It also removes some duplicated code between these classes.
This patch is not changing functionality, just moving code around.

Resolves: #55983
Releases: 6.2
Change-Id: I916058485acb9d9abe0086785763edc721a360f0
Reviewed-on: https://review.typo3.org/27631
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] RTE on first new IRRE record keeps loading in IE 24/27624/2
Stanislas Rolland [Thu, 13 Feb 2014 21:20:49 +0000 (16:20 -0500)]
[BUGFIX] RTE on first new IRRE record keeps loading in IE

Problem: IE raises a syntax error when it encounters html comments in
the JavaScript code. The html comments are added by the page renderer.
Solution: There is no need for the page renderer to wrap inline
javascript as html comments.

Resolves: #55457
Releases: 6.2, 6.1
Change-Id: Iae180a73778ca3bb1c9934c887315b969888b10d
Reviewed-on: https://review.typo3.org/27624
Reviewed-by: Oliver Klee
Tested-by: Leon de Rijke
Tested-by: Simon Ouellet
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Default size for group-type fields 16/28116/4
Christian Plattner [Thu, 6 Mar 2014 17:09:34 +0000 (18:09 +0100)]
[BUGFIX] Default size for group-type fields

Missing size property on group-type fields causes various
problems, like missing controls (move to top and move to
bottom) or misbehaving JS. Adding a default size ensures
that a forgotten size property does not break everything.

Additionally the size property is added to the sys_collection
table, since all Core tables should be cleanly defined.

Resolves: #23552
Documentation: #56627
Releases: 6.1, 6.2
Change-Id: Idafb1912f9702fddf85b7c2c222f408419e50ecf
Reviewed-on: https://review.typo3.org/28116
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add cache to IconUtility::getSpriteIcon() 13/27713/8
Michiel Roos [Wed, 19 Feb 2014 11:03:25 +0000 (12:03 +0100)]
[TASK] Add cache to IconUtility::getSpriteIcon()

Cache calls to getSpriteIcon() that only use the first parameter.

Change-Id: I63e7dbaf81473b733a73f4a964e419dae0650f5f
Resolves: #56110
Releases: 6.2
Reviewed-on: https://review.typo3.org/27713
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Consolidate regexp for utf8 and non-utf8 file systems 39/23439/13
Lucas Bremgartner [Thu, 14 Nov 2013 23:45:26 +0000 (00:45 +0100)]
[TASK] Consolidate regexp for utf8 and non-utf8 file systems

This patch enables the @ character to be usable now
also for non-utf8 file systems.

Resolves: #50538
Releases: 6.2, 6.1
Change-Id: I72ce24393003af8733af6fc650e69781df4a272c
Reviewed-on: https://review.typo3.org/23439
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[!!!][SECURITY] Remove old backend_layout wizard 21/28121/2
Wouter Wolters [Thu, 6 Mar 2014 20:44:02 +0000 (21:44 +0100)]
[!!!][SECURITY] Remove old backend_layout wizard

Keeping the old wizard script would not solve
the CSRF attack vector as they could still
be referenced in this kind of attack.

Because of that, we remove it now.

This change provides a backwards compatibility layer.

It will however break code which link to the
old scripts directly in other places.

Resolves: #56625
Releases: 6.2
Change-Id: I07577dca0e16cf095e114799ace4a6e344ad5aa3
Reviewed-on: https://review.typo3.org/28121
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] ExtendedFileUtility.php: func_delete 19/28019/2
Rico Sonntag [Tue, 4 Mar 2014 07:23:26 +0000 (08:23 +0100)]
[BUGFIX] ExtendedFileUtility.php: func_delete

This fixes an issue within method func_delete trying to catch a file
access exception instead of expected folder access exception during
delete of an folder.

Change-Id: Iaf76100cd668ef4b1a36a5d9052a6f185ffa6b7b
Resolves: #56511
Releases: 6.2
Reviewed-on: https://review.typo3.org/28019
Reviewed-by: Frans Saris
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] FAL readonly: Directory copying results in BE exception 94/27994/2
Rico Sonntag [Mon, 3 Mar 2014 13:51:55 +0000 (14:51 +0100)]
[BUGFIX] FAL readonly: Directory copying results in BE exception

Changed parent class of folder permission exceptions to
InsufficientFolderAccessPermissionsException so excecption
could be catched properly.

Change-Id: I1c85e4c0e4652f1e3394fd58f98d95ea6ca8cc34
Resolves: #56494
Releases: 6.2
Reviewed-on: https://review.typo3.org/27994
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] UnitTests create SQL error if openid is installed 90/28090/3
Philipp Gampe [Thu, 6 Mar 2014 02:07:16 +0000 (03:07 +0100)]
[BUGFIX] UnitTests create SQL error if openid is installed

AbstractUserAuthenticationTest is actually supposed to test
processLoginData from AuthenticationService from ext:sv.
However it fails to properly setup all auth parameters, therefore auth
services that depend on further settings fail.

This moves the test to the actually tested code (extension sv).
The test is adopted accordingly.

Additionally both tests are cleaned up from unneeded setUp/tearDown
functions.

Resolves: #56586
Releases: 6.2
Change-Id: I7406a56e5274ea54d400c1c116a8ea81c5cf4cea
Reviewed-on: https://review.typo3.org/28090
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Remove superflous check in getModuleUrl 18/28118/3
Helmut Hummel [Thu, 6 Mar 2014 19:51:59 +0000 (20:51 +0100)]
[BUGFIX] Remove superflous check in getModuleUrl

There is a check in getModuleUrl that checks
access rights to modules and returns false
if this is not the case.

However access rights are checked in each
module independently anyway.

So we remove this check here.

Resolves: #56611
Releases: 6.2
Change-Id: I63901cba3e882aab23de17929a461f08bd899cf1
Reviewed-on: https://review.typo3.org/28118
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Remove wrong quoting 19/28119/3
Helmut Hummel [Thu, 6 Mar 2014 20:33:21 +0000 (21:33 +0100)]
[BUGFIX] Remove wrong quoting

While moving the element browser to a module
quoting was added in several places.

However quoting DocumentTemplate::issueCommand
calls does not work, as the returned string
contains JavaScript.

Remove the quoting in these places.

Resolves: #56622
Releases: 6.2
Change-Id: I1b9ec8b4a5900940a5c5dfd81ed712f2994ecef3
Reviewed-on: https://review.typo3.org/28119
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] concatenateCSS may produce invalid css 23/22623/7
Stefan Neufeind [Sun, 24 Nov 2013 22:11:18 +0000 (23:11 +0100)]
[BUGFIX] concatenateCSS may produce invalid css

css-files with statements like @import might become corrupted. This is due
a wrong regex in case no quotes (single or double) are provided.

Adjust regex and add testcases.

Resolves: #50491
Releases: 6.2, 6.1
Change-Id: I8c35be97147da51e3cfc4be6de114f3c19c1abca
Reviewed-on: https://review.typo3.org/22623
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Redirect to distributions after first login 66/27866/5
Benjamin Mack [Wed, 26 Feb 2014 12:24:55 +0000 (13:24 +0100)]
[TASK] Redirect to distributions after first login

For the users to select a distribution, the installation should
redirect directly to the extension manager, after the first
login of the admin, who set up the site.

Then, the list of TER extensions is loaded initially and all
distributions are shown.

For this to happen, the install tool needs to add another option
that sets a UC flag in the just created admin user.
This UC flag is evaluated when the start module is to be shown.

Also, it adds some more logic when redirecting to the start module
to allow to directly jump to a modfunc/action.

Additionally, the distribution action should initially load all
extensions from TER on first hit.

Releases: 6.2
Resolves: #56321
Change-Id: I1e86b5804011e84f7936514e4b88c4a257905e56
Reviewed-on: https://review.typo3.org/27866
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Fatal error in database connect install step 02/28102/2
Christian Kuhn [Thu, 6 Mar 2014 12:57:45 +0000 (13:57 +0100)]
[TASK] Fatal error in database connect install step

Patch df239a6d599 renamed bootstrap method setCoreCacheToNullBackend
to disableCoreAndClassesCache but missed a usage in installer.

Change-Id: Ie4939384a7c476c489d8734ecd7badf5f0dcebdc
Resolves: #56605
Related: #56583
Releases: 6.2
Reviewed-on: https://review.typo3.org/28102
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Reduce memory footprint of unit test suite 89/28089/2
Christian Kuhn [Wed, 5 Mar 2014 22:37:38 +0000 (23:37 +0100)]
[TASK] Reduce memory footprint of unit test suite

Switching to transientMemoryBackend for some caches raises the
memory footprint of unit test. Change the bootstrap a bit to not
use this cache backend in unit tests.

Change-Id: I3bc4774c4c9c6a24314681491bfdf23a9eab570d
Resolves: #56585
Related: #56583
Releases: 6.2
Reviewed-on: https://review.typo3.org/28089
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Follow up: Remove icon doesn't work 10/28010/4
Nicole Cordes [Mon, 3 Mar 2014 22:18:51 +0000 (23:18 +0100)]
[BUGFIX] Follow up: Remove icon doesn't work

With patch 6711c14 the function setFormValueManipulate was corrected but
if called it returns an array instead of the first form element. This
patch makes sure that the first object is always returned.

Resolves: #56221
Releases: 6.2
Change-Id: I03445afcb15d9323cd899974ac1cf378945e4ecb
Reviewed-on: https://review.typo3.org/28010
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make text in All Configuration selectable 82/27882/2
Markus Klein [Wed, 26 Feb 2014 20:36:13 +0000 (21:36 +0100)]
[BUGFIX] Make text in All Configuration selectable

Remove the click function on the whole item.
This prevents selecting the text.
The input fields are be enough to select them easily.

Resolves: #56350
Releases: 6.2
Change-Id: I929ef24383460964288696d268959b32fae3b705
Reviewed-on: https://review.typo3.org/27882
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Add functional tests for impexp irre records 93/27993/3
Marc Bastian Heinrichs [Fri, 28 Feb 2014 17:56:33 +0000 (18:56 +0100)]
[TASK] Add functional tests for impexp irre records

This patch adds functional tests for exporting and
importing all irre_tutorial relation types.

Resolves: #56287
Releases: 6.2
Change-Id: I9fe650151cca11e1f7fcb0d4b1d3ebdbbc0b75ad
Reviewed-on: https://review.typo3.org/27993
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix no caching behavior of bootstrap 88/28088/4
Helmut Hummel [Thu, 27 Feb 2014 14:09:23 +0000 (15:09 +0100)]
[BUGFIX] Fix no caching behavior of bootstrap

Install Tool and tests are intended to work
without caches being active.

Currently this functionality is broken in bootstrap
because it is applied too late and does not
respect classes cache.

Resolves: #56583
Releases: 6.2
Change-Id: I45bb11d3b7951b189c1f12c3da6969285575d72b
Reviewed-on: https://review.typo3.org/28088
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Extend functional tests with creation of additional folders 79/27779/4
Marc Bastian Heinrichs [Fri, 21 Feb 2014 17:32:41 +0000 (18:32 +0100)]
[TASK] Extend functional tests with creation of additional folders

Extends the functional tests with the possibility to create additional
folders inside the TYPO3 CMS test instance created within typo3temp.

Resolves: #56194
Releases: 6.2
Change-Id: I3271b3877fc953a2d876e56fc18af823d2e2a609
Reviewed-on: https://review.typo3.org/27779
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Bernhard Kraft
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Functional tests for persisting relations in Extbase 92/27492/4
Tymoteusz Motylewski [Sat, 8 Feb 2014 20:33:13 +0000 (21:33 +0100)]
[TASK] Functional tests for persisting relations in Extbase

Add functional tests for persisting 1:M and M:M relations
in Extbase.
This patch adds blog_example as an fixture extension.

Resolves: #55786
Releases: 6.2
Change-Id: If90c854c9cb86fd45dcdbc14319a0a416e9447a0
Reviewed-on: https://review.typo3.org/27492
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Import/Export Module uses module dispatcher 63/28063/7
Anja Leichsenring [Tue, 4 Mar 2014 20:35:35 +0000 (21:35 +0100)]
[TASK] Import/Export Module uses module dispatcher

Change-Id: I1ac785adf3b0573a50954855befdda838fd01c33
Resolves: #55671
Releases: 6.2
Reviewed-on: https://review.typo3.org/28063
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] MySQLi for DBAL 75/27875/14
Markus Klein [Wed, 26 Feb 2014 16:24:46 +0000 (17:24 +0100)]
[TASK] MySQLi for DBAL

Properly implement MySQLi for DBAL native mode.

Resolves: #50752
Releases: 6.2
Change-Id: I0c36e7d2828c94cc7c726757f3adc086ffd68015
Reviewed-on: https://review.typo3.org/27875
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Make browse_links.php a wizard 81/27981/4
Helmut Hummel [Sun, 2 Mar 2014 18:01:34 +0000 (19:01 +0100)]
[TASK] Make browse_links.php a wizard

Resolves: #56470
Releases: 6.2
Change-Id: I7bf8c20ab7e084efca352840f88007a574f7e270
Reviewed-on: https://review.typo3.org/27981
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] userPermissions => recursiveDeleteFolder 30/28030/2
Rico Sonntag [Tue, 4 Mar 2014 11:46:13 +0000 (12:46 +0100)]
[BUGFIX] userPermissions => recursiveDeleteFolder

This commit fixed the backend user/groups TCA to set the right option
to allow recursive deletion of folders.

Change-Id: I6f763ce820a09aa8b3f555ff6dfc5666fd7f81bf
Resolves: #56527
Releases: 6.2
Reviewed-on: https://review.typo3.org/28030
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Export binary data from sys_file records 64/27364/11
Marc Bastian Heinrichs [Wed, 5 Feb 2014 19:51:34 +0000 (20:51 +0100)]
[TASK] Export binary data from sys_file records

Until now files from TCA type group internal_type
file or file_reference were included as binary data in
the export only. Include also the binary data from
sys_file records in a separate array.

Resolves: #55431
Releases: 6.2
Change-Id: I9a1b1f090705f6a42ff34f98ec95b62a3a79c9c1
Reviewed-on: https://review.typo3.org/27364
Reviewed-by: Bernhard Kraft
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix executable permissions on files 72/28072/2
Thomas Luzat [Wed, 5 Mar 2014 11:15:09 +0000 (12:15 +0100)]
[BUGFIX] Fix executable permissions on files

A large number of files were stored with executable permissions. This
may be a (minor) security risk and can be confusing. The patch removes
the executable permissions on all files but:

* typo3/cli_dispatch.phpsh
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh

Resolves: #56571
Releases: 6.2
Change-Id: Ib6a9fb19fe716d7d5405d5a7120b50269bdbf5f8
Reviewed-on: https://review.typo3.org/28072
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Could not parse where clause 96/27996/6
Xavier Perseguers [Mon, 3 Mar 2014 14:37:01 +0000 (15:37 +0100)]
[BUGFIX] Could not parse where clause

SQL parser is unable to parse the complex Upgrade Wizard query. As we
know that it is compatible with DBMS we actively support (MySQL,
PostgreSQL, Oracle, MS SQL), a pragmatic solution is implemented to
bypass the parser while keeping compatibility with DBAL and its remapping
feature.

Releases: 6.2
Fixes: #56390
Change-Id: I54c01a3eca73668be579fb45e6fea907664290d6
Reviewed-on: https://review.typo3.org/27996
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Allow search for FAL related DB records 28/27928/3
Benjamin Mack [Fri, 28 Feb 2014 08:24:22 +0000 (09:24 +0100)]
[BUGFIX] Allow search for FAL related DB records

The backend search is currently not
working for file collections etc as there
is no searchFields string provided.

The patch adds them, and also
adds it to non-visible records like
sys_file and sys_file_records as they
might be used in a different
visualization when having a filesearch
service.

The patch is easily testable if you
take a file collection and name it
"my collection". Searching in the list
module on that page for "collection"
does not show anything without
the patch.

see
https://review.typo3.org/#/c/16725/9

Releases: 6.2
Resolves: #56410
Change-Id: I0e99b3b291f085b81560e8f823d3e258a8645fc0
Reviewed-on: https://review.typo3.org/27928
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.2-dev 62/28062/2
TYPO3 Release Team [Tue, 4 Mar 2014 20:41:18 +0000 (21:41 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: Ie70bf11000e9b70f60bbd6923ab1516904164edd
Reviewed-on: https://review.typo3.org/28062
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta6 61/28061/2 TYPO3_6-2-0beta6
TYPO3 Release Team [Tue, 4 Mar 2014 20:40:49 +0000 (21:40 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta6

Change-Id: I034ed6f244869918e9e3b7c189a629825d76df79
Reviewed-on: https://review.typo3.org/28061
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] OpCache XCache cannot be cleared if xcache.admin.enable_auth 59/28059/5
Ernesto Baschny [Tue, 4 Mar 2014 20:16:06 +0000 (21:16 +0100)]
[BUGFIX] OpCache XCache cannot be cleared if xcache.admin.enable_auth

We can only clear the opcache in XCache if xcache.admin.enable_auth is not
set, else you get a fatal error.

Resolves: #56554
Related: #55252
Releases: 6.2
Change-Id: Ia33afc4141852c58266f6c7dfedec82f4c35148d
Reviewed-on: https://review.typo3.org/28059
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Install Tool: Optimize class structure 65/24665/11
Markus Klein [Sat, 12 Oct 2013 11:15:14 +0000 (13:15 +0200)]
[TASK] Install Tool: Optimize class structure

Refine the class and interface structure of
Install Tool actions.

Resolves: #52736
Releases: 6.2
Change-Id: Id1b0107670859e140169767233ba9944822e0d8d
Reviewed-on: https://review.typo3.org/24665
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove EXT/extListArray from DefaultConfiguration 54/28054/2
Christian Kuhn [Tue, 4 Mar 2014 19:20:46 +0000 (20:20 +0100)]
[TASK] Remove EXT/extListArray from DefaultConfiguration

extListArray is obsolete and can be removed. It is already taken
core off in the install tool upgrade process.

Change-Id: Ie9b86f28deebd3aab1031a725d72d852374e5607
Resolves: #56552
Releases: 6.2
Reviewed-on: https://review.typo3.org/28054
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Cache Identifiers shorten the MD5 hash 78/27878/2
Michiel Roos [Wed, 26 Feb 2014 19:14:10 +0000 (20:14 +0100)]
[BUGFIX] Cache Identifiers shorten the MD5 hash

Cache Identifiers shorten the MD5 hash - This is superfluous substr() work
without any gain - remove it.

Change-Id: I0061337afb74df2f29aae69f868a1a0bbe3ad966
Resolves: #56313
Releases: 6.2
Reviewed-on: https://review.typo3.org/27878
Reviewed-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Setting capabilities to readonly show always drag+drop dialog 46/27946/6
Rico Sonntag [Fri, 28 Feb 2014 13:57:47 +0000 (14:57 +0100)]
[BUGFIX] Setting capabilities to readonly show always drag+drop dialog

If a driver is readonly, the upload button in the file list disappears,
but the DragUploader is still activated - on the whole page.
Clicking anywhere on the list page causes an upload file selection to
pop up. Additionally the new button is shown but has no functionality.
The patch removes DragUploader and superfluous button.

Change-Id: I3f6c2e932d9f66feb6590f08229ddaaad06e688e
Resolves: #56443
Releases: 6.2
Reviewed-on: https://review.typo3.org/27946
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Rico Sonntag
Tested-by: Rico Sonntag
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Improve usability with multiple tabs open 54/27954/7
Helmut Hummel [Fri, 28 Feb 2014 18:28:51 +0000 (19:28 +0100)]
[TASK] Improve usability with multiple tabs open

When the backend user session expires, currently
a popup window is shown which asks the user to
relogin when salted passwords or rsaauth are used
(which is currently our default).

However when a user works with multiple browser tabs
open, it is easy to overlook this popup. When realizing
that the session is expired and the user logs
into the backend again in one tab, the session
is authenticated in all other open tabs, but a
new CSRF protection token has been generated, which
makes working in this tab impossible, especially
because the tokens are now checked for virtually
any action.

This changes cleans up the AjaxLogin functionality
by making use of the new Ajax API introduced lately
and functionality is added so that AjaxLogin also
works with rsaauth and saltedpasswords enabled.

Additionally the form protection framework is slightly
reworked to better support the re-login and token
restore functionality in the AjaxLogin.

The "showRefreshLoginPopup" functionality is still
kept, because AjaxLogin can still not handle
OpenID logins.

Resolves: #56453
Releases: 6.2
Change-Id: Ic6c3415f292d346293c7d2c775288f4ba62ebc15
Reviewed-on: https://review.typo3.org/27954
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register backend_layout wizard 77/27977/7
Wouter Wolters [Sun, 2 Mar 2014 15:33:11 +0000 (16:33 +0100)]
[TASK] Use new way to register backend_layout wizard

Resolves: #56471
Releases: 6.2
Change-Id: I8bd844326566715201ab3ae82811c945566b5b88
Reviewed-on: https://review.typo3.org/27977
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[CLEANUP] Enhance TCA - FAL migration for tt_content 21/25621/21
Benjamin Mack [Mon, 16 Dec 2013 15:50:56 +0000 (16:50 +0100)]
[CLEANUP] Enhance TCA - FAL migration for tt_content

The upgrade wizard to migrate the fields like e.g.
tt_content->image and pages->media fetches all records
of each table and loops over them. This is basic, and not
very clever, especially when the max_execution_time is
less than the upgrade wizards needs to process all fields
or if the memory_limit is reached because ALL of the
records are fetched.

Thus, the patch modifies the behavior in the following ways:
* As all TCA value are switched from text to integer
 (the value itself, not the DB field yet) the SQL is done to
only fetch records that are not empty, not integer
(and not deleted). This reduces the memory footprint
massively.
* The check for a record is now done for each table and
then for each field of the table (as the SQL has been changed).
* The field is only marked as "done" if no more records were
found in the migration run.
* Also, the redudant myfile_05.jpg are not moved if the
first file with that name (myfile.jpg) was moved already.

The migration wizard can now be run multiple times
(and the counter shows how many records are left).

Furthermore the wizard hides itself now once all migrations
are done.

Resolves: #53845
Resolves: #53891
Releases: 6.2
Change-Id: I835a07158e6869d80b4426d9774754421963ef81
Reviewed-on: https://review.typo3.org/25621
Reviewed-by: Jigal van Hemert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix OpcodeCache for PHP 5.3 48/28048/4
Alexander Opitz [Tue, 4 Mar 2014 16:54:30 +0000 (17:54 +0100)]
[BUGFIX] Fix OpcodeCache for PHP 5.3

In PHP 5.3 anonymous functions can't be bound to static/self so an extra
call to a public function is needed.

Resolves: #56546
Related: #55252
Releases: 6.2
Change-Id: I56fc8c4ae92e50c35e972413540b43ec1fa714fc
Reviewed-on: https://review.typo3.org/28048
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] New filename does not get sanitized 06/27806/5
Frans Saris [Mon, 24 Feb 2014 07:27:23 +0000 (08:27 +0100)]
[BUGFIX] New filename does not get sanitized

When adding a new file through the ResourceStorage there
is a check to see if the file already exists. But this check
does not sanitize the target filename, so it could happen that
you get a false positive because when the file really is added
to the file system the target filename is sanitized.

This patch sanitizes the file name before the fileExists check.

Releases: 6.2, 6.1
Resolves: #55299
Change-Id: I519220040448b08883146caf463ed58544a18453
Reviewed-on: https://review.typo3.org/27806
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] TCA maximumRecordsChecked should display message 64/27264/3
Benjamin Mack [Sun, 2 Feb 2014 14:38:45 +0000 (15:38 +0100)]
[BUGFIX] TCA maximumRecordsChecked should display message

The new eval function "maximumRecordsChecked"
silently disables the checkbox again when the
maximum number of records has been reached.

The patch adds a log entry for the user on saving
the record.

You can test this change with #55177.

Resolves: #55590
Releases: 6.2
Change-Id: Ie8489f6b8fe519130689098968ae28fabe7c7b8e
Reviewed-on: https://review.typo3.org/27264
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ADOdb: Invalid override method signature 02/20602/4
Xavier Perseguers [Tue, 7 May 2013 19:19:47 +0000 (21:19 +0200)]
[BUGFIX] ADOdb: Invalid override method signature

Classes are not overriding the method with a compatible list
of parameters.

Fixes: #48034
Releases: 6.2
Change-Id: I1e288cb90e12e3dc50b38c13bd76988f0be16cab
Reviewed-on: https://review.typo3.org/20602
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] getLabelsFromItemsList() returns no value 89/27689/4
Xavier Perseguers [Tue, 18 Feb 2014 13:01:31 +0000 (14:01 +0100)]
[BUGFIX] getLabelsFromItemsList() returns no value

Method getLabelsFromItemsList() is expected to return an empty list
when the column is populating items from a foreign_table configuration
option. Method getProcessedValue() is explicitly checking this to
retrieve the label from the corresponding foreign record if it could not
be resolved from the list of static items.

This reverts commits 5dd32b83e7085ed44713c9b97d5c2c47d820765e and
9596d4da3ac8110a76cb3eadabb9307b67971793 and moves the business logic
into method getProcessedValue().

Releases: 6.2, 6.1
Fixes: #54131
Change-Id: I15dcf0c4bcb76ecc85de8e3202b1376a24981b06
Reviewed-on: https://review.typo3.org/27689
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use FAL functions for image rendering 11/25511/13
Alexander Stehlik [Sun, 2 Feb 2014 17:07:35 +0000 (18:07 +0100)]
[TASK] Use FAL functions for image rendering

Instead of relying on the backward compatiblity layer of the
FrontendContentAdapterService when rendering images with
css_styled_content the render_textpic method is modified so that it
is also be possible to use FAL functions and properties for image
rendering.

The captionsSplit / imageTextSplit constants are removed because
every image has its own properties for that with FAL and they are
not needed any more.

The globalCaption rendering was removed because the captions are now
always attached to a single image.

The longdescURL handling was also removed because the files do not
have this property at the moment and the longdescURL field for
tt_content records is also not visible in the Backend.

Resolves: #53764
Releases: 6.2
Change-Id: I1d9c8ad1d7a498816e724960613818a05d587d4f
Reviewed-on: https://review.typo3.org/25511
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[CLEANUP] Enhance RTE Magic Image FAL migration wizard 22/25622/2
Benjamin Mack [Thu, 21 Nov 2013 18:27:54 +0000 (19:27 +0100)]
[CLEANUP] Enhance RTE Magic Image FAL migration wizard

If the RTE magic images FAL migration upgrade wizard in the
install tool ever fails (due to max_execution_time) or some
SQL error, then the migration stops and can be run again.

However, if the wizard is run again, it always checks
if the source file still exists. The wizard should rather
check if the target file exists, if not, move the source file
to the target file.

As a separate "step" in this wizard, if the target file (already)
exists, then the DB change can be done.

Additionally, a typo for the output is fixed as well.

Resolves: #53846
Releases: 6.2
Change-Id: Id7c3b6176997848210d83c54cd133819ab15f435
Reviewed-on: https://review.typo3.org/25622
Reviewed-by: Wouter Wolters
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Upgrade Wizard for FAL references, check for missing tables 14/25414/6
Ernesto Baschny [Thu, 14 Nov 2013 21:43:37 +0000 (22:43 +0100)]
[TASK] Upgrade Wizard for FAL references, check for missing tables

In case sys_file_reference contains references to tables that no longer
exist physically (i.e. for extensions that were deinstalled and tables
then deleted through "Database Compare"), the sys_reference_table
upgrade wizard now no longer fails with an exception. Instead the buggy
rows will be deleted from the table.

Resolves: #53650
Releases: 6.2
Change-Id: I6a95b4abef77848de3ed97a1cf9b212434be7c98
Reviewed-on: https://review.typo3.org/25414
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Break out of foreach if there're no rows in table 54/27554/8
Stefan Froemken [Tue, 11 Feb 2014 18:10:11 +0000 (19:10 +0100)]
[BUGFIX] Break out of foreach if there're no rows in table

Instead of using a slow COUNT on huge tables, we add an
additional query here, which tries to get the first
found record in oder to test if records exists
or not. This new query is extremely fast, because it
uses indexes. It only needs one huge table
like sys_log in your database to see a performance
boost in BE list module.

Resolves: #55891
Releases: 6.2
Change-Id: I920729421bcece8af3b7cdd5f53446e5a1be5300
Reviewed-on: https://review.typo3.org/27554
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cannot use contain with multivalued static enumeration column 87/27787/4
Xavier Perseguers [Sat, 1 Mar 2014 10:17:21 +0000 (11:17 +0100)]
[BUGFIX] Cannot use contain with multivalued static enumeration column

When a column is defined as a multivalued static enumeration:
'somecolumn' => array(
    'exclude' => 0,
    'label' => 'Some label',
    'config' => array(
        'type' => 'select',
        'items' => array(
            array('Option 1', 1),
            array('Option 2', 2),
            array('Option 3', 3),
            array('Option 4', 4),
        ),
        'size' => 4,
        'maxitems' => 4,
        'eval' => ''
    ),
),
it is not possible to query the domain model using operation "contains":
$value = 2;
$query->matching(
    $query->contains('somecolumn', $value)
);

Releases: 6.2, 6.1
Fixes: #56205
Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b
Reviewed-on: https://review.typo3.org/27787
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Flush opcode caches while saving PHP files. 24/27024/20
Alexander Opitz [Thu, 23 Jan 2014 13:43:36 +0000 (14:43 +0100)]
[BUGFIX] Flush opcode caches while saving PHP files.

After manipulating PHP files, which we include with "require" we should
clear the opcode cache, if there is one installed.

So we introduce OpcodeCacheUtility to handle the clearing of the opcode
cache. Also to have a way to give feedback to the install tool which
can show the quality of the opcode cache in use. It also checks if an
opcode cache is enabled in the configuration, not only if the extension
is installed.

Use of this opcode cache clearing is added to the ConfigurationManager,
PackageManager and the cache (Simple)FileBackend.

Make use of this data in the SystemEnvironmentCheck.

Resolves: #55252
Releases: 6.2, 6.1, 6.0
Change-Id: I881f3fbe055c9566663c2c3c238de62ae30f7149
Reviewed-on: https://review.typo3.org/27024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make standard-search working with EXT:form installed 42/28042/2
Oliver Hader [Tue, 4 Mar 2014 15:08:34 +0000 (16:08 +0100)]
[BUGFIX] Make standard-search working with EXT:form installed

The standard-search relies on basic form-functionality.
But if EXT:form is installed, that functionality is overlaid
and the result is wrong.

Provide a flag so that standard-search can request to use
the "basic" form-functionality, preventing EXT:form from
dealing with it.

Change-Id: I52cbd6cecc7222217ff766393dd37ad9d1a9aa30
Resolves: #50274
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/28042
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert