Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Create typo3temp/_processed_/ by default 57/36557/2
Sebastian Fischer [Sun, 1 Feb 2015 09:33:02 +0000 (10:33 +0100)]
[BUGFIX] Create typo3temp/_processed_/ by default

By this the needed folder for files from default storage
is created.

Resolves: #55833
Releases: master, 6.2
Change-Id: I5f31203a58d2a093362305aebf1f264f175980c3
Reviewed-on: http://review.typo3.org/36557
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Felogin: Ignore scheme in isInCurrentDomain 70/17170/10
Jigal van Hemert [Fri, 14 Dec 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Felogin: Ignore scheme in isInCurrentDomain

While determining if the referrer is in the current domain the
scheme part should be ignored. This makes it possible to have the
login page using https and the rest http.

Change-Id: Ic411e3b18d22b96ae5e5a955d88d6270a05116a7
Resolves: #32618
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/17170
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] ExtractorRegistry can not handle Extractors with same priority 02/36502/3
Fabien Udriot [Sat, 31 Jan 2015 13:24:11 +0000 (14:24 +0100)]
[BUGFIX] ExtractorRegistry can not handle Extractors with same priority

The ExtractorRegistry::getExtractors() overrides existing
instances with the same execution priority. There is no check
or notification about this. As instance, it could be that you
have a extractor for Local driver and an extractor for a remote
driver with the same execution priority, that is currently not possible.

The change set also keep in sync some part of the code with
the FileRenderRegistry which is very close to the Extractor Registry.

Change-Id: I42fdd3916410536a0b097d96cf833129f5359d72
Releases: master, 6.2
Resolves: #56727
Reviewed-on: http://review.typo3.org/36502
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Missing stream_cast() in FileStreamWrapper 22/36522/7
Philipp Gampe [Sat, 31 Jan 2015 15:51:31 +0000 (16:51 +0100)]
[BUGFIX] Missing stream_cast() in FileStreamWrapper

Resolves: #64693
Releases: master
Change-Id: Ib3eeee53d9937e4ae8a1cdfd0da2acf51644241f
Reviewed-on: http://review.typo3.org/36522
Reviewed-by: Altan Tosun <a.tosun@gmx.de>
Tested-by: Altan Tosun <a.tosun@gmx.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
4 years ago[BUGFIX] FAL: Do not paste a folder into itself 86/36386/10
Helmut Hummel [Thu, 29 Jan 2015 21:03:57 +0000 (22:03 +0100)]
[BUGFIX] FAL: Do not paste a folder into itself

If a folder is selected in fileadmin, which is already in
the clipboard, the paste icon is not shown to prevent
a endlessly nested folder structure.

Also the correct exception is thrown in ResourceStorage
if it occurs anyway.

Resolves: #51670
Releases: master, 6.2
Change-Id: I996cb8eede1371e479f756f18e1ede03f65950cb
Reviewed-on: http://review.typo3.org/36386
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[TASK] Make move_el.php dispatched 11/36511/3
Wouter Wolters [Sat, 31 Jan 2015 15:01:14 +0000 (16:01 +0100)]
[TASK] Make move_el.php dispatched

Use dispatching for move_el.php

Resolves: #64691
Releases: master
Change-Id: Ice9733d6b323ea998d28879db5908696ed7f1fa1
Reviewed-on: http://review.typo3.org/36511
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix folder casing of Icons/Flags 40/36540/5
Sebastian Fischer [Sat, 31 Jan 2015 18:24:56 +0000 (19:24 +0100)]
[BUGFIX] Fix folder casing of Icons/Flags

Rename folder Icons/flags to Icons/Flags to fix the missing language
flags in case-sensitive file systems.

Resolves: #64702
Releases: master
Change-Id: I77aee2b2c066faa96555387fe68324c848d3cfd4
Reviewed-on: http://review.typo3.org/36540
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[CLEANUP] Move functions to GraphicalFunctions 67/36367/6
Zbigniew Jacko [Thu, 29 Jan 2015 16:04:09 +0000 (17:04 +0100)]
[CLEANUP] Move functions to GraphicalFunctions

Clean up the code by moving IM related function
from GeneralUtility to GraphicalFunctions class.

Change-Id: I714435ad76e542e9aff297cad779964fd543a2c5
Resolves: #46589
Releases: master
Reviewed-on: http://review.typo3.org/36367
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP] Move legacy "search" CType to compatibility6 39/36539/2
Stephan Großberndt [Sat, 31 Jan 2015 18:23:42 +0000 (19:23 +0100)]
[FOLLOWUP] Move legacy "search" CType to compatibility6

Fix use statement and call to log deprecation.

Releases: master
Resolves: #64696
Change-Id: I8c41afaced3dd650c31b2083451c0b395fae2bdc
Reviewed-on: http://review.typo3.org/36539
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Use statement for GeneralUtility in UriBuilder 31/36531/3
Stephan Großberndt [Sat, 31 Jan 2015 17:10:30 +0000 (18:10 +0100)]
[CLEANUP] Use statement for GeneralUtility in UriBuilder

Resolves: #64699
Releases: master
Change-Id: Ice37ae02c4aba6edef531a523ec16e6b786ededf
Reviewed-on: http://review.typo3.org/36531
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add test for NULL fields when comparing SQL field definitions 29/36529/2
Stephan Großberndt [Sat, 31 Jan 2015 16:43:33 +0000 (17:43 +0100)]
[TASK] Add test for NULL fields when comparing SQL field definitions

Resolves: #64697
Releases: master, 6.2
Change-Id: I6d08445633af54d64f9176fc7b691e318d08d897
Reviewed-on: http://review.typo3.org/36529
Reviewed-by: Ronny Vorpahl <vorpahl@artplan21.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Move legacy "search" CType to compatibility6 26/36526/3
Benjamin Mack [Sat, 31 Jan 2015 16:24:58 +0000 (17:24 +0100)]
[!!!][TASK] Move legacy "search" CType to compatibility6

The primitive search, which is loaded via
"Search" CType contains a cObject called
"SEARCHRESULTS". The search is based on
a form based on FORM (old functionality already
moved to compatibility6), is moved to
compatibility6.

The following parts are moved:
- New Content Element Wizard
- cObject SEARCHRESULTS
- TypoScript from CSS Styled Content
- The TCA configuration

Due to the limited possibility to
add a CType (select item in general)
at a specific position (e.g. as first item
of an item group divided with --div--),
the patch also provides compatibility
for EXT:felogin and EXT:form by doing
TCA overrides for the CType element.

This also fixes some sideffects that came
with the previous patches for "mailform".

Releases: master
Resolves: #64696
Change-Id: I722e3bd7d3b7fad7d198e61d8ad1abde4dfdba2b
Reviewed-on: http://review.typo3.org/36526
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Change TS property includeJSlibs to proper camelcase 12/33312/7
Stefan Froemken [Tue, 14 Oct 2014 19:36:39 +0000 (21:36 +0200)]
[BUGFIX] Change TS property includeJSlibs to proper camelcase

LowerCamelCase told us to use includeJSLibs
instead of includeJSlibs. We also use
includeJSFooter.

Resolves: #61605
Releases: master
Change-Id: I65966482c32b28c59d3d7402b01f6ff80129e3c9
Reviewed-on: http://review.typo3.org/33312
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Improve link area in Install Tool navigation 35/36535/2
Doreen Gröger [Sat, 31 Jan 2015 16:58:56 +0000 (17:58 +0100)]
[FEATURE] Improve link area in Install Tool navigation

Currently only the text from the Install Tool navigation is clickable.
To improve the user experience this patch extends CSS to enlarge the
link area to the whole navigation item.

Releases: master
Resolves: #64698
Change-Id: I6c4b130a931c1cf0c7d07261f2742b1a4fb6a9d3
Reviewed-on: http://review.typo3.org/36535
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FOLLOWUP][TASK] Move xhtml_cleaning check to compatibility6 36/36536/2
Benjamin Mack [Sat, 31 Jan 2015 18:00:27 +0000 (19:00 +0100)]
[FOLLOWUP][TASK] Move xhtml_cleaning check to compatibility6

Resolves: #62855
Releases: master
Change-Id: I5148e6fe06a73308283bb5f42427cef3d814dbfa
Reviewed-on: http://review.typo3.org/36536
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Rework/simplify copyright header and remove @package 19/36519/3
Stephan Großberndt [Sat, 31 Jan 2015 15:29:14 +0000 (16:29 +0100)]
[CLEANUP] Rework/simplify copyright header and remove @package

Align some files with old copyright headers, mostly in extbase and
fluid sysext which were missed in Task #59535. Also remove some left
@package statements missed in Task #43019.

Resolves: #64689
Releases: master, 6.2
Change-Id: I9838c9be73cb3a310ef2572fcc3843ff53dbf724
Reviewed-on: http://review.typo3.org/36519
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Deactivate output buffer for FileDumpEID.php 85/36485/6
Roman Schuermann [Sat, 31 Jan 2015 09:33:29 +0000 (10:33 +0100)]
[BUGFIX] Deactivate output buffer for FileDumpEID.php

If you try to download large file via FileDumpEID.php you may
get an out of memory error.

Resolves: #64273
Releases: master, 6.2
Change-Id: Ie1fcf9eac5d8e7466bbfe6eb8357ed9ce62fa649
Reviewed-on: http://review.typo3.org/36485
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Tested-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
4 years ago[!!!][TASK] Move xhtml_cleaning check to compatibility6 27/36527/6
Jan Helke [Sat, 31 Jan 2015 16:24:32 +0000 (17:24 +0100)]
[!!!][TASK] Move xhtml_cleaning check to compatibility6

XHTML cleaning is not neccessary anymore, after modern technology
bases completely on HTML5. Therefore the according functionality
has been moved to the legacy extension "compatibility6".

Resolves: #62855
Releases: master
Change-Id: I4f4b7cfd2388d516951b0f37b399b0359b44c487
Reviewed-on: http://review.typo3.org/36527
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Make use of possible imports and remove unused ones 13/36513/6
Göran Bodenschatz [Sat, 31 Jan 2015 15:02:27 +0000 (16:02 +0100)]
[CLEANUP] Make use of possible imports and remove unused ones

Resolves: #64690
Releases: master
Change-Id: Ia785278f0210416a0075e8e6eed712d97fd7272a
Reviewed-on: http://review.typo3.org/36513
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Respect (NOT) NULL when comparing SQL field definitions 00/36400/4
Stephan Großberndt [Fri, 30 Jan 2015 10:23:17 +0000 (11:23 +0100)]
[BUGFIX] Respect (NOT) NULL when comparing SQL field definitions

When comparing the database or updating extensions the definitions for
NULL / NOT NULL in fields are now respected and updated.

Resolves: #64616
Releases: master, 6.2
Change-Id: I70c63339505b373023f24973313a2e673e8eaf86
Reviewed-on: http://review.typo3.org/36400
Tested-by: Ronny Vorpahl <vorpahl@artplan21.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Improve functional test execution on Windows system 91/36491/3
Nicole Cordes [Sat, 31 Jan 2015 11:01:09 +0000 (12:01 +0100)]
[BUGFIX] Improve functional test execution on Windows system

On Windows systems you can execute several commands using '&' like
set typo3DatabaseUsername=root & set typo3DatabasePassword=root.
Unfortunately Windows sets those parameter with a trailing space. This
causes database connections not to work. Therefore the patch adds a trim
on getting system environment variables for database credentials for
functional tests.

Furthermore the PHP versions on Windows throw a warning on setting the
database name when the connection is closed. The warning is caught by
PHPUnit but the database tables aren't initialized correctly. This patch
adds an '@' to mute the warning.

Releases: master, 6.2
Resolves: #64680
Change-Id: If649b5bd440a3bd504f028a3c9c96c9d294d380c
Reviewed-on: http://review.typo3.org/36491
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[CLEANUP] Move array specific functions to ArrayUtility 71/36371/8
Göran Bodenschatz [Thu, 29 Jan 2015 16:53:36 +0000 (17:53 +0100)]
[CLEANUP] Move array specific functions to ArrayUtility

1. Move functions + tests to ArrayUtility class
2. Change function calls throughout Core
3. Deprecate functions in GeneralUtility

Resolves: #62807
Releases: master
Change-Id: Ib5c00b74d2326a377a76a1f24d1b541c33a2d956
Reviewed-on: http://review.typo3.org/36371
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove inline styles from parsed blockquote tag 58/17758/5
Jan Helke [Fri, 30 Jan 2015 21:36:48 +0000 (22:36 +0100)]
[BUGFIX] Remove inline styles from parsed blockquote tag

When passing blockquote tags trough lib.parseFunc_RTE (this
is commonly done when rendering TS objects in Fluid templates)
their attributes will be replaced with some inline styles.
I don't know what the intention of this behavior is, but it's been
like this at least since 2004. Inline styles should generally be
avoided.
I suggest to simple remove this rule.

Code to reproduce the issue and test the change:
https://gist.github.com/4654874

Resolves: #44879
Releases: master
Change-Id: If8954fa392b906d78a8cc32aba9e5b23d84decd9
Reviewed-on: http://review.typo3.org/17758
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Ensure unix like paths for temp files 93/36493/4
Nicole Cordes [Sat, 31 Jan 2015 11:18:32 +0000 (12:18 +0100)]
[BUGFIX] Ensure unix like paths for temp files

Using tempnam() on Windows systems returns paths containing backslashes.
As other paths inside the core are already transformed to paths using
forward slashes some string comparisons fail. This patch ensures correct
transforming of slashes after the usage of tempnam().

Releases: master, 6.2
Resolves: #64682
Change-Id: Ic85e06d9ed32c9f668efd5bb74b9bc14df367e1b
Reviewed-on: http://review.typo3.org/36493
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Sections not properly handled by record collector 92/35692/3
Bernhard Kraft [Wed, 31 Dec 2014 14:12:57 +0000 (15:12 +0100)]
[BUGFIX] Sections not properly handled by record collector

When using the Unit-Test framework frontend record collector the
resulting response is not correct.

Instead of adding records only to the specific section (configured via
TypoScript) the records pile up in $this->records and get added to
every section. The reason this only true for $this->records of the
Collector is, that for the other class variables (like $this->structure)
there are appropriate array keys used anyways.

Solution is to reset the internal member variables used for collecting
record information each time after attaching a section.

Resolves: #64066
Releases: master
Change-Id: I7a1ff945e0d267f1e0c6608637479ea0cc28fe70
Reviewed-on: http://review.typo3.org/35692
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP] Harmonize allowed characters of backend usernames 01/36501/2
Oliver Klee [Sat, 31 Jan 2015 13:49:22 +0000 (14:49 +0100)]
[FOLLOWUP] Harmonize allowed characters of backend usernames

Drop an now-unnecessary trim on the user name.

Relates: #50875
Releases: master
Change-Id: I771a5340212da81da08e8cb668e096acd97dc9b9
Reviewed-on: http://review.typo3.org/36501
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[TASK] Harmonize allowed characters of backend usernames 97/35997/3
Georg Ringer [Tue, 13 Jan 2015 12:41:44 +0000 (13:41 +0100)]
[TASK] Harmonize allowed characters of backend usernames

When creating new backend users from the intall tool, any
character is now accepted for the username. Whitespaces get
trimmed and uppercase is converted to lowercase.
This is already the case for TCA of be_users.username

Change-Id: I0edabd2cb82dc59bdc52dd385c1e198f04be6017
Resolves: #50875
Releases: master
Reviewed-on: http://review.typo3.org/35997
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Move old mailform to compatibility6 79/36479/6
Benjamin Mack [Fri, 30 Jan 2015 21:34:48 +0000 (22:34 +0100)]
[!!!][TASK] Move old mailform to compatibility6

Due to the replacement of the better
EXT:form logic, the fallback and default
mailform when EXT:form is not installed,
is moved to compatibility6.

There are certain parts that are migrated
as well and therefore removed from the
main core installation.

 * Various methods in ContentObjectRenderer,
and especially TypoScriptFrontendRenderer
which specifically served the purpose.
 * The FORM Content Object
 * The TCA tt_content mailform configuration
 * The TypoScript from css styled content
 * The newContentElement wizard configuration
 * Related tests to the form-related methods
 * The preview functionality for a mailform in "Web"=>"Page"

The submission class (DataSubmissionController)
has been moved and renamed as well, and now
hooks into the checkDataSubmission of TSFE.

Additionally, the related tests to the methods
have been removed.

Resolves: #64668
Releases: master
Change-Id: Iefbaf11322678f811d5c38d82f7d81be56b1d378
Reviewed-on: http://review.typo3.org/36479
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move old SVN ChangeLog entries to wiki.typo3.org/ChangeLog 92/36492/3
Benjamin Mack [Sat, 31 Jan 2015 11:14:18 +0000 (12:14 +0100)]
[TASK] Move old SVN ChangeLog entries to wiki.typo3.org/ChangeLog

In order to keep our base distribution a bit
smaller, the SVN part (pre 2011) of the ChangeLog
file is moved to http://wiki.typo3.org/ChangeLog

Resolves: #64681
Releases: master
Change-Id: I86523a111d311d349748e760bead47d6c3d9ddfc
Reviewed-on: http://review.typo3.org/36492
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Take table permissions in account for file edit icon 16/36416/8
Philipp Thiele [Fri, 30 Jan 2015 12:34:03 +0000 (13:34 +0100)]
[BUGFIX] Take table permissions in account for file edit icon

Hides the file edit icon in filelist if the user has no modify
permissions for sys_file_metadata.

Resolves: #64634
Releases: master
Change-Id: Id0070849032d0596e8fe30c9f17a314f31adc6fa
Reviewed-on: http://review.typo3.org/36416
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] FAL: Remove old publishing leftovers 94/36494/2
Benjamin Mack [Sat, 31 Jan 2015 11:23:19 +0000 (12:23 +0100)]
[TASK] FAL: Remove old publishing leftovers

The initial concept of having publishers
in the File Abstraction Layer was never
implemented.

The leftover code is removed.
No dependencies to the protected
method are found and can safely be
removed.

Resolves: #64683
Releases: master, 6.2
Change-Id: I4eca172bc9fd618ce80bd7c0158da73b01745a77
Reviewed-on: http://review.typo3.org/36494
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Inform user about possibly missing Ghostscript tools 87/36487/3
Markus Klein [Sat, 31 Jan 2015 10:33:36 +0000 (11:33 +0100)]
[TASK] Inform user about possibly missing Ghostscript tools

Extend the error message for failing image tests to include a note
about possibly missing Ghostscript tools on the server.

Releases: master, 6.2
Resolves: #64677
Change-Id: I9dbc9e3b4afb8280c54d4ac87456f9272bdb0874
Reviewed-on: http://review.typo3.org/36487
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Show allowed file extensions in FAL field 43/36443/3
Armin Ruediger Vieweg [Fri, 30 Jan 2015 15:44:51 +0000 (16:44 +0100)]
[FEATURE] Show allowed file extensions in FAL field

Above the list of file relations are buttons to add or upload new images.
Now, behind these buttons a label appears, which shows the allowed file
extensions to upload/use.

Resolves: #45428
Releases: master
Change-Id: I6e7caea22c6198819084db4c737088cc6f7eb02f
Reviewed-on: http://review.typo3.org/36443
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[!!!][TASK] Move Content Object IMGTEXT to compatibility6 84/36484/2
Benjamin Mack [Sat, 31 Jan 2015 09:16:51 +0000 (10:16 +0100)]
[!!!][TASK] Move Content Object IMGTEXT to compatibility6

The predecessor of css styled content-based
text w/ image, called IMGTEXT, is moved to
compatibility6.

The only place where it is used when it is called
directly (page.10 = IMGTEXT), and specifically
requested within CSS Styled Content in
renderTextpic() if ".renderMethod" is empty or
explicitly set to "table".

Releases: master
Resolves: #64671
Change-Id: I3b56ac9b044adfaa4295a3d54070187e14caf576
Reviewed-on: http://review.typo3.org/36484
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Use resource API to deleted files from uploads in DataHandler 01/31001/6
Marc Bastian Heinrichs [Sat, 21 Jun 2014 13:49:34 +0000 (15:49 +0200)]
[TASK] Use resource API to deleted files from uploads in DataHandler

The DataHandler deletes files from the uploads folder. Since also a
sys_file record could exist for such file, the resource API should be
used to delete it.

Resolves: #58967
Releases: master, 6.2
Change-Id: I6c0b3683657e1c4da5f9ab0a2016e33b1e472f62
Reviewed-on: http://review.typo3.org/31001
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Files to FileStorage relations are now recorded in sys_refindex 12/36412/3
alinafleser [Fri, 30 Jan 2015 11:59:48 +0000 (13:59 +0200)]
[BUGFIX] Files to FileStorage relations are now recorded in sys_refindex

When a file (sys_file) is added/modified/deleted,
the relation to the file storage (sys_file_storage)
is recorded and updated in sys_refindex

Resolves: #64631
Related: #50871
Releases: master, 6.2
Change-Id: If95fac13c5530041948b3f9c896ebb390c31956a
Reviewed-on: http://review.typo3.org/36412
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Gracefully show missing files in IRRE relations 44/29544/15
Andre Hähnel [Thu, 17 Apr 2014 13:24:58 +0000 (15:24 +0200)]
[BUGFIX] Gracefully show missing files in IRRE relations

When the database is inconsistent and a sys_file entry linked
from sys_file_reference does not exist anymore, an exception
is shown in the "page" module in the backend:

> No file found for given UID.

We will now gracefully show the reference as "broken" and let
the action up to the editor. Works for temporarily unavailable
storages too.

Releases: master, 6.2
Resolves: #58013
Change-Id: Ibce9bb3b60e9294aa1902b95c1b99337d3a8e2e6
Reviewed-on: http://review.typo3.org/29544
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove old PHP version leftovers 40/35940/4
Markus Klein [Fri, 9 Jan 2015 21:31:56 +0000 (22:31 +0100)]
[TASK] Remove old PHP version leftovers

Releases: master
Resolves: #64670
Change-Id: Ia54cb96e20cd0392bd43cec366b3d8b9ab0a02df
Reviewed-on: http://review.typo3.org/35940
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] Path of a storage must be required 78/36478/7
Altan Tosun [Fri, 30 Jan 2015 22:12:08 +0000 (23:12 +0100)]
[BUGFIX] Path of a storage must be required

Remove the default 'fileadmin/' and introduce a placeholder
instead.
The field is required now.

Resolves: #64650
Releases: master
Change-Id: I517fc816f4c84be8592199f3341f11a3395b8079
Reviewed-on: http://review.typo3.org/36478
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Display Info of File in popup instead of File Metadata 94/33294/5
Fabien Udriot [Mon, 13 Oct 2014 15:20:20 +0000 (17:20 +0200)]
[BUGFIX] Display Info of File in popup instead of File Metadata

To stay inline with the File List, the popup from the list
should display info of a File and not of the File Metadata. Otherwise,
it will display misleading information for the End User such
as different creation / modification date.

Change-Id: I84ac293dc63d222d1111dd35bd1474709449bafa
Releases: master, 6.2
Resolves: #56655
Reviewed-on: http://review.typo3.org/33294
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Set correct workspace ID when updating referenceIndex for files 44/36044/7
Markus Klösges [Fri, 16 Jan 2015 13:00:35 +0000 (14:00 +0100)]
[BUGFIX] Set correct workspace ID when updating referenceIndex for files

When publishing a workspace the referenceIndex entries of the affected
sys_file_reference rows were not updated with the new workspace. That's
because the user is always in the affected workspace and therefore
the workspace is not set to live as expected.
Now updating referenceIndex for both workspaces when swapping.

Resolves: #64253
Releases: master, 6.2
Change-Id: Icfb4fcd1ae92da4ea881105b387c3d6db20ece95
Reviewed-on: http://review.typo3.org/36044
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[FEATURE] Display the bad class name in makeInstance 72/36472/2
Oliver Klee [Fri, 30 Jan 2015 19:53:19 +0000 (20:53 +0100)]
[FEATURE] Display the bad class name in makeInstance

The class name provided to GeneralUtility::makeInstance must not
start with a backslash. To help track down the offending code parts,
makeInstance now includes the offending class name in the exception
message.

Resolves: #64665
Releases: master
Change-Id: I745840f9d6497b0b73bd2f1872310728e780ae5e
Reviewed-on: http://review.typo3.org/36472
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Add test for categories with multiple tables 77/36477/2
Zbigniew Jacko [Fri, 30 Jan 2015 20:17:27 +0000 (21:17 +0100)]
[TASK] Add test for categories with multiple tables

Add test for #45332. Remove one relation and check count of collection.

Change-Id: I59871058df97614f7f339c0df241de30e17358b9
Resolves: #50091
Release: master
Reviewed-on: http://review.typo3.org/36477
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP] Disable functionality to hide file storage 74/36474/2
Helmut Hummel [Fri, 30 Jan 2015 20:07:31 +0000 (21:07 +0100)]
[FOLLOWUP] Disable functionality to hide file storage

Also remove an obsolete sql key and remaing TCA from the hidden column

Releases: master
Resolves: #59017
Change-Id: I0b4bfa0036eab6a69cb548bd5e21d0569b7dfbf7
Reviewed-on: http://review.typo3.org/36474
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
4 years ago[BUGFIX] Take table permissions in account for file translate icon 71/36471/2
Philipp Thiele [Fri, 30 Jan 2015 19:43:52 +0000 (20:43 +0100)]
[BUGFIX] Take table permissions in account for file translate icon

Hides the translate icon in file list if the user has no
modify permissions for sys_file_metadata

Resolves: #55576
Releases: master
Change-Id: Ida3ea7a437c2b4fb49099ff7a3448ceccf063bd2
Reviewed-on: http://review.typo3.org/36471
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] FAL Indexer follow symlinks now 29/36429/2
Roman Schuermann [Fri, 30 Jan 2015 14:14:37 +0000 (15:14 +0100)]
[BUGFIX] FAL Indexer follow symlinks now

Currently the indexing scheduler task from FAL ignores symlinks and all files behind symlinks are not indexed.

Resolves: #60511
Releases: master
Change-Id: If4eb503e96eccebaf39a9f3ba48ffc469e038f4b
Reviewed-on: http://review.typo3.org/36429
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Disable functionality to hide file storage 61/36461/5
ruud [Fri, 30 Jan 2015 18:01:31 +0000 (19:01 +0100)]
[BUGFIX] Disable functionality to hide file storage

Disables the functionality to hide a file storage.

Resolves: #59017
Releases: master
Change-Id: Ibe542f384b4ecff033ae8c73b002fad266b61683
Reviewed-on: http://review.typo3.org/36461
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] DateValidator fails to validate incorrect dates 67/36467/3
Nicole Cordes [Fri, 30 Jan 2015 18:35:11 +0000 (19:35 +0100)]
[BUGFIX] DateValidator fails to validate incorrect dates

If the function "strptime" is not present in the environment (mostly on
Windows systems) the fallback to check a given date in the dateValidator
fails to detect invalid dates. The conversion from the given string to
a date object respects invalid dates and just converts them to valid
ones (by moving in next month/year). Therefore the function returns an
object instead of false. This patch adds a value comparison between old
and new value to be sure still the same date string is returned.

Releases: master, 6.2
Resolves: #64661
Change-Id: I739d309278143bb5fc24c48ca7bb884a1e25a442
Reviewed-on: http://review.typo3.org/36467
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[TASK] Drop support and tests for FreeType 1 53/36153/6
Stefan Neufeind [Wed, 21 Jan 2015 08:43:40 +0000 (09:43 +0100)]
[TASK] Drop support and tests for FreeType 1

We've been using FreeType 2 for quite some time.
FreeType 1 is history meanwhile.

Change-Id: I45add19b77c9168bc00def15295ed85f4a7353e9
Resolves: #48542
Releases: master
Reviewed-on: http://review.typo3.org/36153
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Adjust visibility of setUp() and tearDown() 38/36438/4
Anja Leichsenring [Fri, 30 Jan 2015 15:08:32 +0000 (16:08 +0100)]
[BUGFIX] Adjust visibility of setUp() and tearDown()

Protected is the correct visibility for those functions, as
given by the base class.

Change-Id: If8ed81c49c6c5cdd6933dd61647f1c2ad1bfc746
Resolves: #64642
Releases: master
Reviewed-on: http://review.typo3.org/36438
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Distributions: Import files before database 28/34428/4
Sascha Egerer [Fri, 21 Nov 2014 08:27:39 +0000 (09:27 +0100)]
[BUGFIX] Distributions: Import files before database

The distribution import does sometimes not import the Assets
(Resources/Files/) of the distribution. This is because the
t3d-file is imported before the files are imported.
That means that the t3d import will create FAL file relations
to files that do not exists. This will end up in an FAL exception.
Files should be imported before the t3d-file is imported.

Resolves: #63121
Releases: master,6.2
Change-Id: Ibb3695b0b92ed2a257380c8684e4451851a2248f
Reviewed-on: http://review.typo3.org/34428
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Always display errors when running the tests 62/36462/3
Oliver Klee [Fri, 30 Jan 2015 18:01:50 +0000 (19:01 +0100)]
[TASK] Always display errors when running the tests

With some default php.ini files (e.g., the file shipped with MAMP PRO),
display_errors is set to "off", and the memory limit is rather low.

As the bootstraps for the unit and functional tests do not read the
current installation's settings, the default values from the php.ini
are used. This can cause the tests to fail at some point due to
insufficient memory, but without any visible messages.

This change makes sure that PHP errors always are output when running
the unit or functional tests using the Core bootstrap files.

Resolves: #64659
Releases: master, 6.2
Change-Id: I28773515b354811a42f0ce262e950603218927b6
Reviewed-on: http://review.typo3.org/36462
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE not resizable in IE 64/36464/2
Stanislas Rolland [Fri, 30 Jan 2015 18:19:51 +0000 (13:19 -0500)]
[BUGFIX] RTE not resizable in IE

Incorrect test of support for CSS3 resize property.

Releases: master
Resolves: #64660
Change-Id: Id137f476920dcbf05fa028940039fa3191d808f4
Reviewed-on: http://review.typo3.org/36464
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FEATURE] Add gracetime for session-timestamp-updates 38/35838/4
Stefan Neufeind [Tue, 6 Jan 2015 16:33:23 +0000 (17:33 +0100)]
[FEATURE] Add gracetime for session-timestamp-updates

Don't update the session-timestamp more often than
needed. Skipping updates for some seconds/minutes
makes no difference but may save quite some
updates.

Change-Id: Ic812993f3c7556fc90a1a5dee7b5462e822d9f45
Resolves: #64148
Releases: master
Reviewed-on: http://review.typo3.org/35838
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Failing unit test in SqlSchemaMigrationServiceTest 59/36459/2
Nicole Cordes [Fri, 30 Jan 2015 17:46:55 +0000 (18:46 +0100)]
[BUGFIX] Failing unit test in SqlSchemaMigrationServiceTest

Currently the test for handling multiple white spaces within the sql
field definitions fails on Windows systems because of a different key
for the table name within the expected and actual array. This is caused
by a strict lowercase converting in the code for Windows systems. As the
table name is irrelevant for the test itself, this patch simply converts
table name to lower case.

Releases: master, 6.2
Resolves: #64657
Change-Id: I8d083e988b9a7403f0ff514af1ebe54adf065383
Reviewed-on: http://review.typo3.org/36459
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] sysext:recordlist 87/36087/10
Markus Klein [Sat, 17 Jan 2015 20:11:59 +0000 (21:11 +0100)]
[CLEANUP] sysext:recordlist

Resolves: #64337
Releases: master
Change-Id: Ie813bf610bbaaf75e87fe22e40478bb09ab109db
Reviewed-on: http://review.typo3.org/36087
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Failing unit tests due to wrong path handling 55/36455/2
Nicole Cordes [Fri, 30 Jan 2015 17:07:21 +0000 (18:07 +0100)]
[BUGFIX] Failing unit tests due to wrong path handling

In some tests of the StandaloneViewTest case the configured expections
aren't met which results in failing tests on Windows systems. The mock
is configured to return values when calling with giving parameter. The
parameter contains the path to a layout root. During runtime the used
paths are converted to unix like paths but the tests are configured to
expect Windows paths (forward slashes vs. backward slashes). This patch
converts paths to unix like paths before the expectations are configured
to not fail on Windows systems.

Releases: master, 6.2
Resolves: #64656
Change-Id: Ie362cc4e2efa41b6cee068e60313c1bfb22340b2
Reviewed-on: http://review.typo3.org/36455
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Wrong generation of metadata in FAL 90/33990/8
Frederic Gaus [Tue, 11 Nov 2014 18:35:36 +0000 (19:35 +0100)]
[BUGFIX] Wrong generation of metadata in FAL

This patch fixes the generation of metadata if the metadata
of a file is missing in sys_file_metadata. Without this patch
the metadata is generated without taking care of images and their
width and height. As a result, images are generated with
width=0 height=0. See bugreport for details.

The change also introduces the basic structure to fetch
general info of files via the SplFileInfo objects API.

Resolves: #62829
Releases: master, 6.2
Change-Id: Ie99fc74f3439cef5dbd3702e57596b37390da679
Reviewed-on: http://review.typo3.org/33990
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Change visibility of suhosin specific checks in SystemEnvironment 44/36444/6
Göran Bodenschatz [Fri, 30 Jan 2015 15:52:52 +0000 (16:52 +0100)]
[TASK] Change visibility of suhosin specific checks in SystemEnvironment

As the PHP extension suhosin is currently not distributed in a larger
manner (e. g. Debian dropped support), the checks for load status and
suhosin specific parameters in Install Tool are only displayed if the
extension is available and loaded.

Resolves: #64647
Releases: master, 6.2
Change-Id: Iac2e984031c84f28f2d41fb6cf69ffbe1d5f6045
Reviewed-on: http://review.typo3.org/36444
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] t3lib_div::getAllFilesAndFoldersInPath no md5 for folders 35/36435/7
Mateusz Wojtuła [Fri, 30 Jan 2015 14:55:17 +0000 (15:55 +0100)]
[BUGFIX] t3lib_div::getAllFilesAndFoldersInPath no md5 for folders

Added md5 hash for folders keys in returned array
in method GeneralUtility::getAllFilesAndFoldersInPath

Change-Id: Ibfaa910c53a4ffac21be791e51aecc9212c40b49
Resloves: #37701
Releases: master
Reviewed-on: http://review.typo3.org/36435
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Failing unit test in Dbal\DatabaseConnectionTest 47/36447/2
Nicole Cordes [Fri, 30 Jan 2015 16:15:15 +0000 (17:15 +0100)]
[BUGFIX] Failing unit test in Dbal\DatabaseConnectionTest

There is one test to be sure 64bit integer values are stored correctly
in the database. This test obviously has to fail on 32bit systems as
they can't handle 64bit values. The patch disables the test for
unsupported systems.

Releases: master, 6.2
Resolves: #64651
Change-Id: I4f1047c19f4ba79df79ffdc92e38fb4f151d0add
Reviewed-on: http://review.typo3.org/36447
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Code Cleanup EXT:feedit 85/33785/6
Mathias Schreiber [Tue, 4 Nov 2014 13:22:56 +0000 (14:22 +0100)]
[CLEANUP] Code Cleanup EXT:feedit

Refactor the code to go green in PHPStorm.
Main tasks:
* Initialize variables
* Centralize objects in $GLOBALS

Resolves: #62691
Releases: master
Change-Id: Iaf4659bc9ef4cdeffbccd53fde2969a9b4c592c4
Reviewed-on: http://review.typo3.org/33785
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Pagination in recycler is broken 50/36450/5
Andreas Fernandez [Fri, 30 Jan 2015 16:24:43 +0000 (17:24 +0100)]
[BUGFIX] Pagination in recycler is broken

Due to the use of a wrong _GP variable, the recycler can only load the
first two pages. Also, reset the paginator upon table change.

Resolves: #64652
Releases: master
Change-Id: I0519b5fd721e46f07e9b9e0003d812317d88660e
Reviewed-on: http://review.typo3.org/36450
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Code cleanup EXT:filelist 79/36279/7
Christian M\üllenhagen [Mon, 26 Jan 2015 22:04:39 +0000 (23:04 +0100)]
[CLEANUP] Code cleanup EXT:filelist

Refactor the code to go green in PHPStorm.
Main tasks:
* Initialize variables
* Centralize objects in $GLOBALS

Resolves: #64496
Releases: master
Change-Id: I3c5803e818bb7f5b1fded7935b4590e4aaf312f6
Reviewed-on: http://review.typo3.org/36279
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!] [TASK] Remove legacy CSS Styled Content TS prior to 6.2 22/36422/3
Benjamin Mack [Fri, 30 Jan 2015 13:22:01 +0000 (14:22 +0100)]
[!!!] [TASK] Remove legacy CSS Styled Content TS prior to 6.2

In the process of removing legacy code, the states
for CSS Styled Content Templates for 6.1, 6.0, 4.7, 4.6, 4.5
are removed without substitution.

Resolves: #64637
Releases: master
Change-Id: I6bf7abde4527b847c40e5f40ab757f1ca416989a
Reviewed-on: http://review.typo3.org/36422
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: G. Bodenschatz <coding@46halbe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Remove unused global variable for temporary files 49/36449/4
Benjamin Mack [Fri, 30 Jan 2015 16:18:42 +0000 (17:18 +0100)]
[TASK] Remove unused global variable for temporary files

GraphicalFunctions uses
$GLOBALS[TEMP_IMAGES_ON_PAGE]
to store temporary images used on a page,
but the core does not use the functionality
since ages, not even in 4.5.

Releases: master
Resolves: #64655
Change-Id: Ie1b3409d2726ab5c8cf6ec20f8d6aa0ea14c192d
Reviewed-on: http://review.typo3.org/36449
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[!!!][TASK] Remove feature enable_typo3temp_db_tracking 34/36434/5
Benjamin Mack [Fri, 30 Jan 2015 14:50:06 +0000 (15:50 +0100)]
[!!!][TASK] Remove feature enable_typo3temp_db_tracking

The functionality for enabling the tracking
of the files within typo3temp/ created by
GraphicalFunctions and its according
DB table have been removed.

The according option
$TYPO3_CONF_VARS[GFX][enable_typo3temp_db_tracking]
has been removed.

Resolves: #64643
Releases: master
Change-Id: I3ef1a7de7246ea6090a83efbda93d73bd39a8892
Reviewed-on: http://review.typo3.org/36434
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Cleanup FAL exception messages 78/36378/3
Philipp Gampe [Thu, 29 Jan 2015 17:52:03 +0000 (18:52 +0100)]
[TASK] Cleanup FAL exception messages

Some exception messages fail to include available data that can help the
integrator or developer to track down the error quickly.
Fix spelling mistakes.

Resolves: #64613
Releases: master
Change-Id: I3ac1f066020ffe36a3597734ae7dd583b439524d
Reviewed-on: http://review.typo3.org/36378
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Tested-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Remove compatibility6 content objects from Unit Tests 48/36448/2
Benjamin Mack [Fri, 30 Jan 2015 16:14:29 +0000 (17:14 +0100)]
[BUGFIX] Remove compatibility6 content objects from Unit Tests

Resolves: #64653
Releases: master
Change-Id: I0bef80f5779cb4a535bfbdfc6636305a99044c19
Reviewed-on: http://review.typo3.org/36448
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Display correct list of file ids in BE module list 82/36382/4
alinafleser [Thu, 29 Jan 2015 19:42:23 +0000 (21:42 +0200)]
[BUGFIX] Display correct list of file ids in BE module list

TYPO3\CMS\Backend\Utility\BackendUtility::getProcessedValue is now
considering foreign_match_fields when processing IRRE fields

Resolves: #62755
Releases: master, 6.2
Change-Id: I45c742bca0b3a2822411f5693d8b9129bb101b24
Reviewed-on: http://review.typo3.org/36382
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] New Scheduler Task are executed now 24/36424/2
Roman Schuermann [Fri, 30 Jan 2015 13:39:14 +0000 (14:39 +0100)]
[BUGFIX] New Scheduler Task are executed now

If you create a new scheduler task, it will not be executed.

Resolves: #64636
Releases: master
Change-Id: I0940ad7a0b7e529b5db196a6f3dbe928299f51e8
Reviewed-on: http://review.typo3.org/36424
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Failling unit test in GeneralUtilityTest for Windows system 37/36437/2
Nicole Cordes [Fri, 30 Jan 2015 15:13:20 +0000 (16:13 +0100)]
[BUGFIX] Failling unit test in GeneralUtilityTest for Windows system

In GeneralUtilityTest a test for the TYPO3_SITE_PATH parses the result
for a starting slash. This test fails on Windows system as the don't
provide slashes but drive letters. This patch skips the test on Windows
systems and provides a new test to check for absolute paths with drive
letters.

Releases: master, 6.2
Resolves: #64644
Change-Id: I87bb9c7df7debd6e5d44602330587eff3c1cf4fd
Reviewed-on: http://review.typo3.org/36437
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Move old legacy content objects to compatibility6 26/36426/3
Benjamin Mack [Fri, 30 Jan 2015 14:00:53 +0000 (15:00 +0100)]
[!!!][TASK] Move old legacy content objects to compatibility6

The following content objects are moved to
EXT:compatibility6, as they are considered
not state-of-the-art anymore.

 * CTABLE
 * OTABLE
 * HRULER
 * CLEARGIF
 * COLUMNS

They are not used inside the core anymore.

Resolves: #64639
Releases: master
Change-Id: I8e4a04997e2f7edff0ebeb8801158cf381dec06a
Reviewed-on: http://review.typo3.org/36426
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix handling of TCA allowed flag in ElementBrowser 92/36392/4
Sascha Egerer [Thu, 29 Jan 2015 23:23:19 +0000 (00:23 +0100)]
[BUGFIX] Fix handling of TCA allowed flag in ElementBrowser

If the 'allowed' flag in the element browser contains a '*', which
means any type of file, no file is displayed. This is because a filter
is added that only files are displayed that have a '*' as file ext.

The filter should not be added if the allowed value is '*' or empty.

Resolves: #54504
Documentation: #64609
Releases: master, 6.2
Change-Id: I941566dd51284ecaaa92b42e6e59988c884d91c1
Reviewed-on: http://review.typo3.org/36392
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] Deprecate BackendUtility::implodeTSParams 36/36436/2
Benjamin Mack [Fri, 30 Jan 2015 15:12:35 +0000 (16:12 +0100)]
[TASK] Deprecate BackendUtility::implodeTSParams

The method is unused in the TYPO3 CMS Core.

Resolves: #46523
Releases: master
Change-Id: Ib54af30533c4f11e8e400d8c8d46cd1a65e501d8
Reviewed-on: http://review.typo3.org/36436
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Reduced sys_file_processedfile.checksum to correct size 88/36388/2
Mathias Schreiber [Thu, 29 Jan 2015 21:24:45 +0000 (22:24 +0100)]
[BUGFIX] Reduced sys_file_processedfile.checksum to correct size

Since only a shortMD5 (of 10 characters length) is used in this field
the size is changed to 10 characters and the field type has been set to
char instead of varchar.

Resolves: #54730
Releases: master, 6.2
Change-Id: I8e846786230b55d42464f6ea791202579e6d7873
Reviewed-on: http://review.typo3.org/36388
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Tested-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Pid property not set after insert 74/35474/3
Mathias Brodala [Mon, 15 Dec 2014 11:13:25 +0000 (12:13 +0100)]
[BUGFIX] Pid property not set after insert

After adding and persisting a new object, its uid property is set,
the same should happen for its pid property. This way the caller
can get to know where the object ended up being stored.

Resolves: #60544
Releases: master, 6.2
Change-Id: Ibd11918c06b52deac69a8c3b83c454e3f24462a8
Reviewed-on: http://review.typo3.org/35474
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Remove only 'CType' keys from wizard 18/36418/4
Göran Bodenschatz [Fri, 30 Jan 2015 13:00:58 +0000 (14:00 +0100)]
[BUGFIX] Remove only 'CType' keys from wizard

Check for key name of 'CType' before removing the content
element from new content wizard.

This is a regression from #23864 where a hardcoded
CType column check was removed that is actually required
in this case.

Resolves: #61114
Related: #23864
Releases: master
Change-Id: Ib65410dee4f7328a3b8bbceaa21c8367843905f3
Reviewed-on: http://review.typo3.org/36418
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add title for 'edit localized metadata' button 70/36370/6
Jan Helke [Thu, 29 Jan 2015 16:39:52 +0000 (17:39 +0100)]
[TASK] Add title for 'edit localized metadata' button

This patch adds the title to the edit localized metadata button
in the filelist module. Because we don't have any translations
for the language names the title is done hardcoded in the class.

Resolves: #64598
Releases: master
Change-Id: I6220da7dccf09fce67fafb7336a5f5fb713aa81e
Reviewed-on: http://review.typo3.org/36370
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Add missing htmlspecialchars in DocumentTemplate 91/36391/3
Sascha Egerer [Thu, 29 Jan 2015 22:44:20 +0000 (23:44 +0100)]
[BUGFIX] Add missing htmlspecialchars in DocumentTemplate

XSS is possible when using a special filename. The file has to be
created directly in the storage as uploading files with those names
is not possible.
Add a missing htmlspecialchars to prevent html injection.

Resolves: #64618
Releases: master, 6.2
Change-Id: I192e736fe629a37e923cc02a740fa2aadea20ee1
Reviewed-on: http://review.typo3.org/36391
Reviewed-by: Ingo Schmitt <is@marketing-factory.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Proper error handling of ResourceDoesNotExistException 75/36375/5
ruud [Thu, 29 Jan 2015 17:44:19 +0000 (18:44 +0100)]
[BUGFIX] Proper error handling of ResourceDoesNotExistException

Handles and displaying a proper error message when
ResourceDoesNotExistException is thrown.

Resolves: #56997
Releases: master, 6.2
Change-Id: I193f9eac929f856d2d195307110d2c18122c8bb9
Reviewed-on: http://review.typo3.org/36375
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Weiske <christian.weiske@netresearch.de>
Tested-by: Christian Weiske <christian.weiske@netresearch.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Return InaccessibleFolder for non existing processed folder 36/32836/5
Frans Saris [Fri, 30 Jan 2015 08:50:03 +0000 (09:50 +0100)]
[BUGFIX] Return InaccessibleFolder for non existing processed folder

When the processed folder of a folder isn't present the ResourceStorage
tries to create it. When storage is offline or write-only this will fail
and as a result you run into exceptions on several places in BE.

This change makes sure there is a InaccessibleFolder object returned
in these cases.

Resolves: #61688
Releases: master, 6.2
Change-Id: Ie32c09f8d322914234860903c18ca44ff5cbf5db
Reviewed-on: http://review.typo3.org/32836
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
4 years ago[BUGFIX] Ensure salted passwords are written to DB 14/35614/5
Markus Klein [Sun, 21 Dec 2014 13:43:45 +0000 (14:43 +0100)]
[BUGFIX] Ensure salted passwords are written to DB

Ensure that salted passwords are written to DB also when importing
data from t3d files.

Resolves: #61506
Releases: master, 6.2
Change-Id: Ia3ec443def54dcc98d12784da17e7abb6243c8f9
Reviewed-on: http://review.typo3.org/35614
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nils Heuermann <nils@world-of-scripts.de>
Tested-by: Nils Heuermann <nils@world-of-scripts.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Allow cObject registration during runtime 46/36146/8
Benjamin Mack [Tue, 20 Jan 2015 19:20:27 +0000 (20:20 +0100)]
[FEATURE] Allow cObject registration during runtime

Instead of having a hard-coded list of available
content Objects with complex hook registration,
any extension can now register its own cObject
by adding or overwriting an AbstractContentObject
in ext_localconf.php via
$GLOBALS['TYPO3_CONF_VARS']['FE']['ContentObjects']

This way it is also possible to move legacy content objects
to other extensions than EXT:frontend.

Resolves: #64386
Releases: master
Change-Id: Iac3e13cb32fa99685c6ff9e284ff8c49b26f9759
Reviewed-on: http://review.typo3.org/36146
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Subgroups field in usergroup edit form should be renamed 96/36396/4
Zbigniew Jacko [Fri, 30 Jan 2015 09:05:31 +0000 (10:05 +0100)]
[BUGFIX] Subgroups field in usergroup edit form should be renamed

Change misleading translation in backend group edit.

Resolves: #24303
Releases: master
Change-Id: I7b7a8b597f94c75948bae21ab153eb103627a215
Reviewed-on: http://review.typo3.org/36396
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Tested-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[CLEANUP] Move ConditionMatcherTests into one place 55/36355/7
Mateusz Wojtuła [Thu, 29 Jan 2015 13:53:31 +0000 (14:53 +0100)]
[CLEANUP] Move ConditionMatcherTests into one place

Moved core ConditionMatcherTest to Backend extension.

Change-Id: I7bd63d728c172046fa808329807d28feb458de87
Resolves: #64324
Releases: master
Reviewed-on: http://review.typo3.org/36355
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Use dirname/basename from PathUtility 61/36361/3
Philipp Thiele [Thu, 29 Jan 2015 15:04:55 +0000 (16:04 +0100)]
[BUGFIX] Use dirname/basename from PathUtility

PathUtility methods dirname() & basename() instead of php functions

Resolves: #64309
Releases: master
Change-Id: I62e3c2c5cc0afafb4427f2d7c9f3df221b95c00d
Reviewed-on: http://review.typo3.org/36361
Reviewed-by: Thomas Deuling <tdeuling@gmail.com>
Tested-by: Thomas Deuling <tdeuling@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Remove duplicated form tag in login 56/36356/2
Georg Ringer [Thu, 29 Jan 2015 14:11:33 +0000 (15:11 +0100)]
[BUGFIX] Remove duplicated form tag in login

Remove a wrong second form tag in the backend login

Change-Id: I50ad624adcfbf6987f555dfe4951c90d661727ff
Resolves: #64592
Releases: master
Reviewed-on: http://review.typo3.org/36356
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Move @param and @var long names to short names 89/36389/2
Wouter Wolters [Thu, 29 Jan 2015 21:52:26 +0000 (22:52 +0100)]
[TASK] Move @param and @var long names to short names

Resolves: #64622
Releases: master
Change-Id: Ia48d3ed317bbc264beda5da5d34994142736665b
Reviewed-on: http://review.typo3.org/36389
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] FAL: Add edit button for files in content element fal list 64/36364/4
Michael Oehlhof [Thu, 29 Jan 2015 15:57:16 +0000 (16:57 +0100)]
[TASK] FAL: Add edit button for files in content element fal list

Added a button for editing the metadata of a file out of the
file list in a content element open for editing.

Resolves: #49676
Releases: master
Change-Id: Ia3f2b6f6df0a48ce3907d289aefa9fb7a738b291
Reviewed-on: http://review.typo3.org/36364
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Fix HTML output in ElementBrowser 79/36379/2
Wouter Wolters [Thu, 29 Jan 2015 18:22:37 +0000 (19:22 +0100)]
[BUGFIX] Fix HTML output in ElementBrowser

Resolves: #64614
Releases: master
Change-Id: Id76bb057e98593c1fe1c659a179bfe1daa0b0d6f
Reviewed-on: http://review.typo3.org/36379
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Deprecate GeneralUtility::array_merge() 77/36377/4
Göran Bodenschatz [Thu, 29 Jan 2015 17:51:46 +0000 (18:51 +0100)]
[TASK] Deprecate GeneralUtility::array_merge()

1. Mark and log as deprecated
2. Change function call throughout Core to native php '+' operator

Resolves: #64596
Releases: master
Change-Id: I389a794352d2e5f37f284448884cd6077fb018c8
Reviewed-on: http://review.typo3.org/36377
Reviewed-by: Zbigniew Jacko <z.jacko@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] FAL: Removed html tags from hover in fileadmin 76/36376/2
Michael Oehlhof [Thu, 29 Jan 2015 17:43:03 +0000 (18:43 +0100)]
[BUGFIX] FAL: Removed html tags from hover in fileadmin

The hover text of folders in the fileadmin with a bold name
contained the html tags <strong></strong>.

The html tags are now removed from the title attribute.

Resolves: #64612
Releases: master
Change-Id: I3ac6d3865cfc0592fbbc6a4e0e48d1735ad58382
Reviewed-on: http://review.typo3.org/36376
Reviewed-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Tested-by: Ruud Silvrants <ruudsilvrants@gmail.com>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Reload module menu upon extension install from TER 65/36265/2
Andreas Fernandez [Mon, 26 Jan 2015 10:58:33 +0000 (11:58 +0100)]
[TASK] Reload module menu upon extension install from TER

Reloads the module menu after installing an extension from TER. The
list gets already reloaded if (un)installing an extension from the local
extension list.

Resolves: #64503
Releases: master
Change-Id: I9725ce720a3265c3587df9e472a42f5d9c445f6c
Reviewed-on: http://review.typo3.org/36265
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Increase Install Tool font-size to 75% 29/36129/4
Mathias Schreiber [Mon, 19 Jan 2015 23:13:39 +0000 (00:13 +0100)]
[FEATURE] Increase Install Tool font-size to 75%

Since the font-size of the backend is bigger, the Install Tools font-
size is now bigger too.

Resolves: #64366
Releases: master, 6.2
Change-Id: If659e61a51a22d9a1ee64ea06c149958e15ef952
Reviewed-on: http://review.typo3.org/36129
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Improve styling of "raw search in all fields" 15/34515/4
Georg Ringer [Sun, 23 Nov 2014 21:22:53 +0000 (22:22 +0100)]
[TASK] Improve styling of "raw search in all fields"

The raw search needs some love for CMS 7.

Resolves: #63276
Releases: master
Change-Id: I98b1d4afd9e4af3b17527c8615be0f794dbda1ff
Reviewed-on: http://review.typo3.org/34515
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix import for fields of type input with link wizard 71/30171/6
Marc Bastian Heinrichs [Fri, 16 May 2014 10:41:06 +0000 (12:41 +0200)]
[BUGFIX] Fix import for fields of type input with link wizard

Fields of type import and link wizard could also contain a path to
a local file in addition to a direct file reference (file:42). The
refindex correctly analyse this relation and saves a db relation to
the uid of the sys_file records.

On imports this is not correct resolved back, but a value
"sys_file_{uid}" is saved.

In addition this patch fixes also a redundant inclusion of files
stored in fileadmin for such a field type, because of having a
sys_file db relation and a softreference.

Resolves: #58843
Releases: master, 6.2
Change-Id: I32bb0e82212295f71c22dfa4935d7d940eb3c95e
Reviewed-on: http://review.typo3.org/30171
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Less strict first install file recognition 50/36350/3
Tymoteusz Motylewski [Thu, 29 Jan 2015 12:25:45 +0000 (13:25 +0100)]
[TASK] Less strict first install file recognition

Now install tool will recognize all files which starts
with FIRST_INSTALL (case insensitive) as a correct
first install file.

This solves common issue beginners hit on Windows
where files are saved with ".txt" extension,
and the extension is hidden by default.

Resolves: #63340
Releases: master
Change-Id: Ia2399e9764a299a416997f16bdbf3c5f915540f3
Reviewed-on: http://review.typo3.org/36350
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Cleanup CoreUpdateService.php 51/36351/3
Frederic Gaus [Thu, 29 Jan 2015 13:06:51 +0000 (14:06 +0100)]
[CLEANUP] Cleanup CoreUpdateService.php

Refactor the name of the variable $currentCoreLocation. This name is
misleading because this variable stores the path to the symlink typo3_src
and not the path to the currently used core files.

Add some use statements to reduce the amount of fully qualified class names.

Change-Id: I7c5a7fda436ba1a147d768967ac86139deaa4032
Resolves: #64591
Releases: master
Reviewed-on: http://review.typo3.org/36351
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Change highlight color on folder change 42/36342/4
Benjamin Mack [Thu, 29 Jan 2015 09:46:44 +0000 (10:46 +0100)]
[BUGFIX] Change highlight color on folder change

Clicking on folder in filelist results in JS error.

When using the filelist main frame
for navigation through the folder structure
there is still some leftover from the old
code, which changes the highlighted
item when clicking on a folder.

The patch solves the issue by properly
addressing the navigation frame and
the JS method.

This part is actually a leftover from pre-4.2
code which was not changed by me in 4.2
with the introduction of the AJAX-based
folder tree with prototype.js.

Resolves: #64572
Releases: master, 6.2
Change-Id: Iff7c7aff07454e428fe78194532ba95df2bd25d0
Reviewed-on: http://review.typo3.org/36342
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>