Packages/TYPO3.CMS.git
6 months ago[TASK] Improve database analyzer UX 55/58355/3
Christian Kuhn [Thu, 20 Sep 2018 16:53:20 +0000 (18:53 +0200)]
[TASK] Improve database analyzer UX

Give earlier feedback when opening the database analyzer
modal, block the buttons again if executing changes and
update the progress bar with what is currently going on.

Resolves: #86335
Releases: master
Change-Id: Ib1e01427fc7bb364d9a030ca1978804a7c1a8b49
Reviewed-on: https://review.typo3.org/58355
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Do not crash install tool if a modal fails 50/58350/4
Christian Kuhn [Thu, 20 Sep 2018 13:09:16 +0000 (15:09 +0200)]
[TASK] Do not crash install tool if a modal fails

* Direct action buttons (eg. clear cache) catch ajax errors
  and turn them into a notification, so the main frame of
  the install tool does not die.
* Server side errors triggered by ajax calls from within
  modals no longer kill the main install tool frame, but
  render the error message into the modal.
* Improved error display with more info on how to recover
  and a (collapsed) output of the generic server side
  error message or backtrace depending on error settings.

Resolves: #86330
Releases: master
Change-Id: I9fa7602d0ea26d979f832022e03b78975b9877af
Reviewed-on: https://review.typo3.org/58350
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Add first acceptance test for sites module 54/58354/2
Susanne Moog [Thu, 20 Sep 2018 15:24:46 +0000 (17:24 +0200)]
[TASK] Add first acceptance test for sites module

Resolves: #86334
Releases: master
Change-Id: Ie2d5b16844bed3b57679d9771b0b29280bf3bae9
Reviewed-on: https://review.typo3.org/58354
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Initialize site configuration for new sites 52/58352/3
Georg Ringer [Thu, 20 Sep 2018 13:46:28 +0000 (15:46 +0200)]
[BUGFIX] Initialize site configuration for new sites

Since a regression in #86323 the site configuration for new sites
must be initialized correctly to avoid exceptions.

Resolves: #86333
Related: #86323
Releases: master
Change-Id: I4d44c01e7789f62811208e1e29655c92821e6b95
Reviewed-on: https://review.typo3.org/58352
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Use SiteFinder in indexed_search 48/58248/6
Georg Ringer [Mon, 10 Sep 2018 17:42:54 +0000 (19:42 +0200)]
[TASK] Use SiteFinder in indexed_search

Instead of only supporting sys_domain records the
SiteFinder should be used for showing a related domain.

Resolves: #86218
Releases: master
Change-Id: Iec66aa4e4ad81449d8265fde7ac53c0aef454b3f
Reviewed-on: https://review.typo3.org/58248
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Silent upgrade wizard changes unrelated field definitions 53/58353/4
Christian Kuhn [Thu, 20 Sep 2018 14:20:10 +0000 (16:20 +0200)]
[BUGFIX] Silent upgrade wizard changes unrelated field definitions

The silent upgrade wizard that should add missing cache
database tables also tends to change fields of not related
tables. The good thing is that this silent upgrader is
not really needed anymore since the "check for missing fields"
step that is always executed afterwards does find and create
cache tables, too.

Resolves: #86228
Releases: master
Change-Id: I9747da74118a6af6368032aa63f6022e0f6c7514
Reviewed-on: https://review.typo3.org/58353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Provide more tests for Extbase rendering in languages 76/58276/13
Tymoteusz Motylewski [Fri, 14 Sep 2018 12:05:47 +0000 (14:05 +0200)]
[TASK] Provide more tests for Extbase rendering in languages

Some tests are just documenting current, buggy behavior.
So once bugs are fixed assertions needs to be updated.
See inline comments for details (and list of related issues below).

Resolves: #86327
Related: #45873
Related: #68672
Releases: master
Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4
Reviewed-on: https://review.typo3.org/58276
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Improve the scheduler task group table listing 11/58311/15
Josef Glatz [Wed, 5 Sep 2018 04:29:28 +0000 (06:29 +0200)]
[TASK] Improve the scheduler task group table listing

This patch basically adjusts the HTML markup for the listAction
to make the scheduler task tables look like the recordlist module.
Toggling of the tables was migrated to Bootstrap collapse which
is already in use inside the TYPO3 Install Tool.

Furthermore, an infobox will now be displayed if erroneous
scheduler tasks are found and the instructions are improved.

A scheduler task group is hidden from now on, if a task group
does not have any executable tasks at all (what will happen when
all scheduler tasks  of a scheduler task group are shown in the
missingClasses scheduler task table).

Last but not least, automatic CGL were applied to the fluid
template. Incorrectly positioned CSS has been moved. Superfluous
CSS was removed.

Command `yarn build-css` was used to compile the CSS changes
for this patch.

Releases: master
Resolves: #86291
Change-Id: I4615841cd6e4db40b6633f47acfe625ea254ff10
Reviewed-on: https://review.typo3.org/58311
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
6 months ago[TASK] Streamline expressionLanguage usage in core 32/58232/33
Susanne Moog [Sat, 8 Sep 2018 14:12:08 +0000 (16:12 +0200)]
[TASK] Streamline expressionLanguage usage in core

* provide same functions across contexts / methods
* provide same way to extend expressionLanguage everywhere
* provide way to load context specific variables and functions
* prepare compile step

Resolves: #86196
Related: #86243
Releases: master
Change-Id: I86cc04ec7051293c195879f823d90d894d160ff0
Reviewed-on: https://review.typo3.org/58232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[FEATURE] Allow static route resolving 15/58315/15
Susanne Moog [Tue, 18 Sep 2018 14:19:35 +0000 (16:19 +0200)]
[FEATURE] Allow static route resolving

Resolving for predefined routes has been introduced.

Static routes can be configured on a per-site level
to provide for example robots.txt or sitemap.xml
routes.

Routes are resolved directly after site resolving
in a middleware and directly return content if found.

Static routes can be configured to deliver static text
defined in site configuration or fetch content from
a file, page or url.

The GUI uses the link wizard for providing URLs.

Resolves: #86214
Releases: master
Change-Id: I6d07529cf535a02472b2e03a763a00ff049270e8
Reviewed-on: https://review.typo3.org/58315
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Provide page ID in pagetree overview 95/58295/9
Guido Schmechel [Sun, 16 Sep 2018 16:47:44 +0000 (18:47 +0200)]
[BUGFIX] Provide page ID in pagetree overview

Implement the page ID in pagetree and localization overview. And
make it controllable with User TS Config.

Resolves: #86269
Releases: master
Change-Id: Ie6fc1824aa3ecc781d3386017744c58604fb36e4
Reviewed-on: https://review.typo3.org/58295
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Deprecate extbase annotation @flushesCaches 28/58328/3
Anja [Wed, 19 Sep 2018 07:18:07 +0000 (09:18 +0200)]
[TASK] Deprecate extbase annotation @flushesCaches

The annotation has been introduced during backport from FLOW, but
was never implemented to do anything useful. It will be removed
without substitution.

Change-Id: I34e337ecfd81185a965beb4d2495256ba6b35670
Resolves: #85981
Releases: master
Related: #82703
Reviewed-on: https://review.typo3.org/58328
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Update styleguide to 9.2.1 48/58348/3
Christian Kuhn [Thu, 20 Sep 2018 10:00:22 +0000 (12:00 +0200)]
[TASK] Update styleguide to 9.2.1

A series of small patches have been applied to styleguide.

composer require --dev typo3/cms-styleguide:~9.2.1

Resolves: #86325
Releases: master
Change-Id: I94ba7a2e0d3c8a65fe5f21d3f7863d3984f34af3
Reviewed-on: https://review.typo3.org/58348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Make edit button visible for admin 96/58296/3
Guido Schmechel [Sun, 16 Sep 2018 17:42:36 +0000 (19:42 +0200)]
[BUGFIX] Make edit button visible for admin

If user is logged in as admin, the edit buttons are always displayed.

Resolves: #86277
Releases: master
Change-Id: I80f96df09c2f4fab886e03cf5aa4cb91cb1bf06c
Reviewed-on: https://review.typo3.org/58296
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[DOCS] Fix typo for canonical link feature 46/58346/2
Xavier Perseguers [Thu, 20 Sep 2018 08:16:51 +0000 (10:16 +0200)]
[DOCS] Fix typo for canonical link feature

Related: #20051
Releases: master
Change-Id: I3891aaa4b62de99a86bf19b3500aabaec6daafc9
Reviewed-on: https://review.typo3.org/58346
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] add propertyName to _isDirty() check 45/58345/3
Daniel Lorenz [Thu, 20 Sep 2018 08:13:34 +0000 (10:13 +0200)]
[BUGFIX] add propertyName to _isDirty() check

_isDirty() without the propertyName returns false if
propertyValue is an instance of DomainObjectInterface.

Resolves: #86252
Related: #86083
Releases: master
Change-Id: I3b916f6b3a416de6cd120bd1ff0bf5cfd0926445
Reviewed-on: https://review.typo3.org/58345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Streamline $TSFE->simUserGroup usages 42/58342/3
Benni Mack [Thu, 20 Sep 2018 06:27:14 +0000 (08:27 +0200)]
[TASK] Streamline $TSFE->simUserGroup usages

First, this patch streamlines some naming issue in $TSFE->applyPreviewSettings()
(introduced by myself).

On top, it sorts out the usages of $TSFE->simUserGroup within
EXT:adminpanel.

So far this patch is "just" cosmetics but allows to further
sort out "simUserGroup" in TYPO3 v10.0.

Resolves: #86322
Releases: master
Change-Id: I5fabb90f36b83e206b390e5c7b1a7191461f85fe
Reviewed-on: https://review.typo3.org/58342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Remove superfluous indention level in site configuration yaml 41/58341/3
Susanne Moog [Wed, 19 Sep 2018 21:02:09 +0000 (23:02 +0200)]
[TASK] Remove superfluous indention level in site configuration yaml

The site configuration is in folder "sites" in a file called config and
does not need a "site" key to identify its purpose. To keep writing the
config as easy as possible the site configuration moved one level up and
now resides directly in config.yaml.

Additionally on writing top level keys that are not written by the GUI
will be kept, so extension authors can add additional configuration to
the site object without needing to configure the GUI (as that is hardly
extensible in the current state). Array keys // top level objects that
are configurable via GUI are however overwritten completely.

Resolves: #86323
Releases: master
Change-Id: I6100dbf53b0953e593a6156837de1fe013a74fae
Reviewed-on: https://review.typo3.org/58341
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] SiteResolver middleware must not care for non int id parameters 37/58337/7
Anja [Wed, 19 Sep 2018 12:50:56 +0000 (14:50 +0200)]
[BUGFIX] SiteResolver middleware must not care for non int id parameters

The FileList module uses the 'id' parameter to pass the directory around,
which makes the parameter a string in this case.
Site Resolver Middleware will no longer care for a parameter named 'id',
which is not strictly an integer.

Change-Id: Ib780ed4e27b78e8f8594ab8b4a6c31f90737a715
Resolves: #86153
Releases: master
Reviewed-on: https://review.typo3.org/58337
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[FEATURE] Add support for the "canonical" tag 71/58271/16
Kevin Appelt [Thu, 13 Sep 2018 20:58:47 +0000 (22:58 +0200)]
[FEATURE] Add support for the "canonical" tag

TYPO3 will now out-of-the box create the canonical tag if you have
installed the core extension SEO. The canonical tag is based on the
settings in the page properties. First it will check if you defined
a canonical link. If not, it will check for the Show content from page
and if both are not set, it will generate an absolute url to the
current page.

Resolves: #20051
Releases: master
Change-Id: I1ae01e419a1f822b8659bf71ba99523051a2e77c
Reviewed-on: https://review.typo3.org/58271
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Replace middlewares in stack on duplicate occurence 40/58340/4
Susanne Moog [Wed, 19 Sep 2018 14:39:12 +0000 (16:39 +0200)]
[BUGFIX] Replace middlewares in stack on duplicate occurence

Use array_replace_recursive instead of array_merge_recursive to
avoid an exception if a middleware is defined twice.

Additionally move the replacement out of the loop.

Resolves: #86319
Releases: master
Change-Id: Ie59fe1d54b9498475c630fd0043b0b5d193b608c
Reviewed-on: https://review.typo3.org/58340
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Mark internal $TSFE properties as protected 09/58309/3
Benni Mack [Tue, 18 Sep 2018 04:42:45 +0000 (06:42 +0200)]
[TASK] Mark internal $TSFE properties as protected

Due to some PHP4 legacy code, most properties in TSFE
were Public API. As some arguments are only used internally
within TSFE and _should_ only used internally, their
visibility has been modified to be protected, and the properties
themselves have also an additional @internal annotation.

For v9, accessing the properties from the outside will still
work but trigger a deprecation message.

Resolves: #86320
Releases: master
Change-Id: Idb15078c41b2128631e75f594e3aa1f0ca85f7ec
Reviewed-on: https://review.typo3.org/58309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Init simulate usergroup correctly in admin panel 30/58330/3
Frank Naegler [Wed, 19 Sep 2018 09:01:10 +0000 (11:01 +0200)]
[BUGFIX] Init simulate usergroup correctly in admin panel

The PreviewModule must be run before initializeFrontendPreview is called,
to ensure the settings from adminpanel are available if the init preview happens.

Resolves: #84198
Releases: master
Change-Id: I74366e652b9195e46aaaa724f2de343b125343ed
Reviewed-on: https://review.typo3.org/58330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Limit number of items per XML sitemap 27/58227/16
Richard Haeser [Sat, 8 Sep 2018 11:45:05 +0000 (13:45 +0200)]
[TASK] Limit number of items per XML sitemap

Sitemaps of pages are now by default limited to 1000 pages per sitemap
to avoid exceeding Google limits. It will generate multiple (paginated)
sitemaps if the number of items exceeds the number of items per sitemap.

Resolves: #86169
Releases: master
Change-Id: I006656239aa05632b1f58a2286475fcba0295b9b
Reviewed-on: https://review.typo3.org/58227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Cache generated meta tags 61/58261/9
Richard Haeser [Wed, 12 Sep 2018 19:17:44 +0000 (21:17 +0200)]
[BUGFIX] Cache generated meta tags

Cache generated meta tags to prevent losing meta tags when a
non-cached content element is on the page.

Resolves: #86234
Releases: master
Change-Id: I6d48feee40716fb07c694b787a329940d2740ad6
Reviewed-on: https://review.typo3.org/58261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Add stdWrap for SVG content object renderMode=inline 19/58319/3
Josef Glatz [Tue, 18 Sep 2018 16:59:04 +0000 (18:59 +0200)]
[BUGFIX] Add stdWrap for SVG content object renderMode=inline

This patch adds stdWrap to the SVG content object if the
renderMode is set to inline.

This patch also adds the missing tsref configuration for the
EXT:t3editor auto completion.

Releases: master
Resolves: #86299
Change-Id: Ib812569ad9b06d19cddf181808799223d1126632
Reviewed-on: https://review.typo3.org/58319
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Thorsten Griebenow <tgr@starfinanz.de>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Streamline EM dependency resolving 23/58323/3
Josef Glatz [Tue, 18 Sep 2018 20:50:20 +0000 (22:50 +0200)]
[TASK] Streamline EM dependency resolving

Adjust the style of the action accordingly and
add a small description to the main header.

Resolves: #86304
Releases: master, 8.7
Change-Id: I37a199d0a9626d4c87354ada7bce662bb089418f
Reviewed-on: https://review.typo3.org/58323
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Remove unused reconstitutedEntitiesData from extbase Session 31/58331/3
Łukasz Uznański [Wed, 19 Sep 2018 09:27:22 +0000 (11:27 +0200)]
[TASK] Remove unused reconstitutedEntitiesData from extbase Session

This property is not used

Releases: master
Resolves: #86309
Change-Id: I38cba224bd765304040a6dfaea4546361fe8ecc1
Reviewed-on: https://review.typo3.org/58331
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Streamline paste modal color schema 34/58334/2
Josef Glatz [Wed, 19 Sep 2018 12:16:52 +0000 (14:16 +0200)]
[BUGFIX] Streamline paste modal color schema

This patch calls the paste modal with the severity level "warning"
to improve the UX between the page and the list backend module
while pasting e.g. a content element record.

Releases: master
Resolves: #86316
Change-Id: I7f58a3b6e3c5d87fc91b6a4d61457d32e125f118
Reviewed-on: https://review.typo3.org/58334
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Chunk requests in documentation viewer to improve performance 99/58299/11
Andreas Fernandez [Mon, 17 Sep 2018 04:54:39 +0000 (06:54 +0200)]
[BUGFIX] Chunk requests in documentation viewer to improve performance

Improve performance of „View Upgrade Documentation“ module by reading
changelogs in chunks.

At first, all available versions are loaded. After that, all files are
loaded chunked by their respective version.

Resolves: #86281
Releases: master
Change-Id: I4c07842d9389028c1899022721f66b866fb81919
Reviewed-on: https://review.typo3.org/58299
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Fetch configuration of FlexForm fields in edit wizard 93/56493/8
Christian Kuhn [Wed, 19 Sep 2018 11:37:49 +0000 (13:37 +0200)]
[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Resolves: #78422
Releases: master, 8.7
Change-Id: Ic628824abb36e23935ad9b493a2e401fe8e734c7
Reviewed-on: https://review.typo3.org/56493
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Handle formEngine add wizard select in flex forms 32/58332/2
Christian Kuhn [Wed, 19 Sep 2018 10:27:58 +0000 (12:27 +0200)]
[BUGFIX] Handle formEngine add wizard select in flex forms

addRecord fieldControl fails for type=select fields
in flex forms in AddController since existing values
are not resolved to an array structure as it is done
for type=group fields. Handle that case.

Resolves: #86313
Related: #82049
Releases: master, 8.7
Change-Id: I59e6cb1c11adf1ac7ebaf0293daad24aa1fd01b4
Reviewed-on: https://review.typo3.org/58332
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Harden system maintainer handling 14/58314/6
Christian Kuhn [Tue, 18 Sep 2018 13:13:35 +0000 (15:13 +0200)]
[TASK] Harden system maintainer handling

Better information handling and restrictions for non
system maintainer trying to change admin flag or password
of system maintainers.

Resolves: #86297
Releases: master
Change-Id: I1849c6ed7edfb78327b4802f4bc9b20f1fd701aa
Reviewed-on: https://review.typo3.org/58314
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Use module state of reports module 36/58336/2
Christian Kuhn [Wed, 19 Sep 2018 12:42:50 +0000 (14:42 +0200)]
[BUGFIX] Use module state of reports module

The reports module stores its latest action selection in
backend user uc and should select that action on next
call again. This broke with the refactoring of #84231

Resolves: #86318
Related: #84231
Releases: master
Change-Id: If3cfe27361bcdc7b15c2f1cfaa34a8cc0c1e88c9
Reviewed-on: https://review.typo3.org/58336
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Improve UI of „Upgrade Wizard“ 94/58294/5
Andreas Fernandez [Sun, 16 Sep 2018 15:54:20 +0000 (17:54 +0200)]
[TASK] Improve UI of „Upgrade Wizard“

Loading the list of available upgrade wizards may take some time. To give
a hint what is currently done, the progress bar now shows a text that
describes the currently processed step. On initial load, the progress
bar of the "done" wizards is rendered as well.

When a upgrade wizard is about to get executed, the viewport scrolls to
the correct position now to attract attention.

Resolves: #86278
Releases: master
Change-Id: Ie9c7d4cdf7e125374f8560fca559e7821b204110
Reviewed-on: https://review.typo3.org/58294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Migrate upgrade wizards in install extension 93/58293/8
Christian Kuhn [Sun, 16 Sep 2018 13:06:09 +0000 (15:06 +0200)]
[TASK] Migrate upgrade wizards in install extension

Resolves: #86201
Related: #86172
Releases: master
Change-Id: I9d38ca04ee8a71ff6ffa325a2f0ce2c8c6cde183
Reviewed-on: https://review.typo3.org/58293
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Use passed severity for modal construction 33/58333/2
Andreas Fernandez [Wed, 19 Sep 2018 11:50:36 +0000 (13:50 +0200)]
[BUGFIX] Use passed severity for modal construction

The `severity` parameter must be passed to `advanced()` to have a proper
styling of the modal header.

Resolves: #86315
Related: #82596
Releases: master
Change-Id: I8904700198fd2ac6d5a0ac7817c3232cc84da4d1
Reviewed-on: https://review.typo3.org/58333
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Add correct moment-timezone file 25/58325/5
Josef Glatz [Tue, 18 Sep 2018 21:43:20 +0000 (23:43 +0200)]
[BUGFIX] Add correct moment-timezone file

This patch adds the correct moment-timezone javascript
file v0.5.20 which did not make it with the former patch
for #85223.

The following command was used:
- yarn upgrade moment-timezone@0.5.20

Releases: master
Resolves: #86306
Related: #85223
Change-Id: Ifc23c4e3d94d308370a7bd9a8071b2a06592047f
Reviewed-on: https://review.typo3.org/58325
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months agoRevert "[TASK] Improve TranslateViewHelper compiling" 22/58322/2
Christian Kuhn [Tue, 18 Sep 2018 19:57:30 +0000 (21:57 +0200)]
Revert "[TASK] Improve TranslateViewHelper compiling"

The micro optimization introduced a bug, fixing the bug
would basically lead to the same code that is within
renderStatic() already. There is then no advantage in
having an inline compiled solution in comparison to a
static call to the class anymore. The initial patch and
its follow up are reverted.

This reverts commit e6f470ebd2ddac7f0c864fd7c18c3d12a9009c30.
This reverts commit 852ad1d9ad6f3bac4c977d2466d1875f9e632e01.

Resolves: #86292
Reverts: #82454
Releases: master
Change-Id: I573a4298b0b9aedf83d51416919204bf910ae4bf
Reviewed-on: https://review.typo3.org/58322
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[TASK] Ignore every .log file to simplify core development 21/58321/3
Josef Glatz [Tue, 18 Sep 2018 19:14:55 +0000 (21:14 +0200)]
[TASK] Ignore every .log file to simplify core development

This patch adds .log files to .gitignore.

Releases: master
Resolves: #86302
Change-Id: If19c37208fb6d2d7004a03daca8d58821f2fae42
Reviewed-on: https://review.typo3.org/58321
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Check $prefix in ActionTask 20/58320/2
Andreas Fernandez [Tue, 18 Sep 2018 18:43:33 +0000 (20:43 +0200)]
[BUGFIX] Check $prefix in ActionTask

Check if the prefix is not an empty string to avoid a warning thrown by
strpos().

Resolves: #86300
Related: #85477
Releases: master
Change-Id: I68a1fc83745594524c088600258c2925eccf3015
Reviewed-on: https://review.typo3.org/58320
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Deprecate FrontendBackendUserAuthentication methods 05/58305/3
Benni Mack [Mon, 17 Sep 2018 14:33:01 +0000 (16:33 +0200)]
[TASK] Deprecate FrontendBackendUserAuthentication methods

The last methods within FrontendBackendUser (BE_USER in FE mode)
are now deprecated in favor of Admin Panel and middlewares:
- checkBackendAccessSettingsFromInitPhp()
- extPageReadAccess()
- extGetTreeList()
- extGetLL()

Resolves: #86288
Releases: master
Change-Id: I6752589a4b7a5353ae1699f3786be743c6f1f13d
Reviewed-on: https://review.typo3.org/58305
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Execute TCA group data provider after columns override 26/53526/4
Sascha Egerer [Sat, 15 Jul 2017 17:19:15 +0000 (19:19 +0200)]
[BUGFIX] Execute TCA group data provider after columns override

The TCA group dataprovider is currently executet very early and before
the ColumnsOverride dataprovider. Because of that it is not possible
to override settings of a tca field of type group. The DataProviders
have been reorderd so that the GroupDataProvider is executed at a later point.

Resolves: #81618
Releases: master
Change-Id: Ic6f9e860b8a7abd5dd1e483dcb35c15f7b8e5ecf
Reviewed-on: https://review.typo3.org/53526
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Suppress mount point resolving if there are none 90/58290/4
Christian Kuhn [Sun, 16 Sep 2018 08:03:31 +0000 (10:03 +0200)]
[TASK] Suppress mount point resolving if there are none

BE admins without mountpoints set have value '0' in
$this->groupData['webmounts']. If this is checked additonally
to empty string, some 'where uid=0' database calls can be suppressed.

Resolves: #86272
Releases: master
Change-Id: I4142034c3d3fac3c9319649fd39200da7955a8db
Reviewed-on: https://review.typo3.org/58290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[DOCS] Explain that L10n signal/slot is not affected 13/58313/4
Xavier Perseguers [Tue, 18 Sep 2018 12:36:11 +0000 (14:36 +0200)]
[DOCS] Explain that L10n signal/slot is not affected

The breaking change documentation is adapted to explicitly mention that
the signal/slot registration is kept untouched.

This will prevent confusion for developers reading the list of breaking changes.

Related: #50467
Related: #62983
Related: #84131
Related: #84691
Releases: master
Change-Id: I43ff5a6882e84c29844495fa9f10e6a35f07b1ff
Reviewed-on: https://review.typo3.org/58313
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Add more migration hints for config.tx_extbase.objects 10/58310/5
Benjamin Franzke [Tue, 18 Sep 2018 06:55:41 +0000 (08:55 +0200)]
[BUGFIX] Add more migration hints for config.tx_extbase.objects

The suggested migration (xclasses) does not work for Models
mapped using the PropertyMapper.
It also fails if additional injections have been configured.
(though that could be fixed using
`GeneralUtility::makeInstance(ObjectManager::class)->get()`)

Change-Id: If22b98526fce575435662e731a4f2efca9a014f3
Releases: master
Resolves: #86290
Related: #86270
Reviewed-on: https://review.typo3.org/58310
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Do not mark wizards implementing RepeatableInterface done 01/58301/3
Christian Kuhn [Mon, 17 Sep 2018 11:03:05 +0000 (13:03 +0200)]
[BUGFIX] Do not mark wizards implementing RepeatableInterface done

Resolves: #86283
Releases: master
Change-Id: Id2fad147fd081e86ecb1b40e0b407b17f60c74d8
Reviewed-on: https://review.typo3.org/58301
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Add missing language file for ContextMenu 86/58186/3
Stefan Froemken [Tue, 4 Sep 2018 15:01:29 +0000 (17:01 +0200)]
[BUGFIX] Add missing language file for ContextMenu

Confirmation Modal shows buttons with translated button labels now, if
you try to delete a page from page-tree.

Resolves: #79879
Releases: master, 8.7
Change-Id: Iff2ed8205bdcc54b48ba301035cd0aac9c2de826
Reviewed-on: https://review.typo3.org/58186
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Fix casting in GalleryProcessing data processor 12/58312/3
Thomas [Tue, 18 Sep 2018 09:41:29 +0000 (11:41 +0200)]
[BUGFIX] Fix casting in GalleryProcessing data processor

Removing the integer casting, so that the cropVariant can also be a string identifier.

Resolves: #86294
Releases: master, 8.7
Change-Id: Id4a80a7b879ddb8539e8cf4b47eeff1fc111029e
Reviewed-on: https://review.typo3.org/58312
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Migrate form upgrade wizard to new API 08/58308/4
Susanne Moog [Mon, 17 Sep 2018 18:59:47 +0000 (20:59 +0200)]
[TASK] Migrate form upgrade wizard to new API

Resolves: #86275
Releases: master
Change-Id: I767f02c75b5f505e9b7ec78e933513d427dba2ae
Reviewed-on: https://review.typo3.org/58308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Don’t do greedy merges in extension scanner 02/58302/2
Andreas Fernandez [Mon, 17 Sep 2018 11:04:55 +0000 (13:04 +0200)]
[BUGFIX] Don’t do greedy merges in extension scanner

The extension scanner merges all matches into an array. This is done in a
loop, which is pretty greedy as it impacts CPU and RAM.

Instead, it's possible to do a single array_merge() at the end of the
loop.

See this document for reference:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Resolves: #86282
Releases: master
Change-Id: I09b45468dfd9f60ce6bd9e264ecfc3cbfcb54fa1
Reviewed-on: https://review.typo3.org/58302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[TASK] Simplify PackageManager caching 82/58282/4
Benjamin Franzke [Sat, 15 Sep 2018 07:31:32 +0000 (09:31 +0200)]
[TASK] Simplify PackageManager caching

We do not want to pollute $GLOBALS to be able to inject PackageManager
as $GLOBALS['TYPO3_currentPackageManager']. to cache-restored Package
objects (during unserialize).
Therefore this patch drops the PackageManager dependency from the Package
class.

The global injected PackageManager was used to calculate the
package metadata on demand. Package metadata is a small array
that doesn't harm to be created during Package object construction,
(it's cached afterwards anyway).
This allows us to drop the PackageManager reference, which
simplifies serialize/unserialize logic (we can drop __sleep and __wakeup).

We also combine the PackageManger and PackageObjects cache
into one cache file instead of two. There is no advantage
in having to read two files from the filesystem. The prior argument
(introduced with the initial PackageManager patch in 2013) "so PHP does
not have to parse the serialized string" is actually invalid:
The serialized string has to be parsed anyway.
PHP did not need to parse the var_export'd variant, true.
BUT: The var_export'd variant is theoretically php opcache'able, while
reading a file and passing the file contents to serialize() is not.
That means the previous solution actually hampered native optimizations.

Ideally we could drop the serialize/unserialize thing and just use
var_export for Package objects, but for that to work the Package class
(and all of it's properties) would need to implement the magic
__set_state() method (which is used by var_export to create objects).
That's currently not possible, because the composerManifest (which
is read from json_decode) is a stdClass and does not provide a
__set_state() method. We'd need to rewrite all that code to an array
or so. Maybe something for a later patch.

As a drive-by fix we now hash the TYPO3_version value into the
cacheEntryIdentifier like other core caches do.

Change-Id: I764dc92c64165ede24c8020c44cd2360b3faa00c
Releases: master
Resolves: #86261
Reviewed-on: https://review.typo3.org/58282
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Omit checkbox for unselectable tree items 63/58263/3
Sebastian Michaelsen [Thu, 13 Sep 2018 09:49:42 +0000 (11:49 +0200)]
[BUGFIX] Omit checkbox for unselectable tree items

TCA select fields with renderType = 'selectTree' have the option
treeConfig.appearance.nonSelectableLevels, which doesn't seem
to work anymore since TYPO3 v7. The items are correctly flagged
with node.selectable = false in PHP but the JavaScript doesn't
check for that property.

Resolves: #84708
Releases: master, 8.7
Change-Id: Iefe98e1c9fd316f05c27ad1230d63236a7069bf1
Reviewed-on: https://review.typo3.org/58263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Trigger deprecation when using $TSFE->sys_language_* 03/58303/4
Benni Mack [Mon, 17 Sep 2018 12:11:32 +0000 (14:11 +0200)]
[BUGFIX] Trigger deprecation when using $TSFE->sys_language_*

When deprecating TSFE->sys_language_mode and TSFE->sys_language_uid
it was forgotten (by myself) to set the visibility to protected.

This way, the deprecation layer (with compat calls) is never
used, and legacy code gets wrong results.

Resolves: #86285
Related: #85543
Releases: master
Change-Id: I2d809b577e5265054f2f54d54ecfbb8e441b6bdc
Reviewed-on: https://review.typo3.org/58303
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects 88/58288/5
Benjamin Franzke [Sun, 16 Sep 2018 05:01:31 +0000 (07:01 +0200)]
[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects

If we want to introduce a system wide container in v10,
the non deterministic behaviour of object (re)configurations
during runtime in extbase will be a problem.
Compiled containers like symfony DI do not allow runtime
reconfigurations.

Also the concept of per plugin overwrites is broken anyway,
and should therefore be dropped:
The "objects" configured through plugin.tx_%name%.objects
are are never reset, that means:
Plugin A might overwrite an object and plugin B will implictly use
that overriden class, despite not having configured that at all.
(depending on the fact whether plugin A is rendered before or not)

config.tx_extbase.object class overwrites can be replaced by XCLASSes.
If config.tx_extbase.object was/is used to conditionally overwrite
classes (through sys_template or conditions), these
occasions should be changed to XCLASSes as well. In that case the
conditional overwrite needs to be moved into the xclass itself.

Change-Id: I2ef839bcbb7f941c3afa0010767560d20e15f98b
Releases: master
Resolves: #86270
Reviewed-on: https://review.typo3.org/58288
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Streamline hooks and middlewares related to PSR-15 53/58253/6
Benni Mack [Wed, 12 Sep 2018 06:53:02 +0000 (08:53 +0200)]
[TASK] Streamline hooks and middlewares related to PSR-15

With PSR-15 it is not necessary to use any custom hooks during
the frontend request setup process anymore, as middlewares
are flexible enough to manipulate anything people want to do.

On top, various middlewares are also declared internal as
the usages are not really necessary to be publically exposed.
- typo3/cms-core/normalized-params-attribute
- typo3/cms-backend/legacy-document-template
- typo3/cms-backend/output-compression
- typo3/cms-backend/response-headers
- typo3/cms-frontend/timetracker
- typo3/cms-frontend/preprocessing
- typo3/cms-frontend/eid
- typo3/cms-frontend/content-length-headers
- typo3/cms-frontend/tsfe
- typo3/cms-frontend/output-compression
- typo3/cms-frontend/prepare-tsfe-rendering
- typo3/cms-frontend/shortcut-and-mountpoint-redirect

Resolves: #86279
Releases: master
Change-Id: I14fbd7b026acdc84fb23ca43cd395de5b7b9c4b6
Reviewed-on: https://review.typo3.org/58253
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Change visibility of TSFE properties and methods 83/58083/8
Benni Mack [Thu, 30 Aug 2018 10:55:12 +0000 (12:55 +0200)]
[TASK] Change visibility of TSFE properties and methods

The following properties have changed their
visibility to be protected from public.

* pageAccessFailureHistory
* workspacePreview (not in use anymore)
* ADMCMD_preview_BEUSER_uid (not in use anymore)
* debug (not in use anymore)
* MP_defaults (not in use anymore outside of TSFE)
* loginAllowedInBranch (use checkIfLoginAllowedInBranch())

The following methods have changed their signature to be
protected, as their purpose is to be called from within
TypoScriptFrontendController.

- tempPageCacheContent()
- realPageCacheContent()
- setPageCacheContent()
- clearPageCacheContent_pidList()
- setSysLastChanged()
- contentStrReplace()

Resolves: #86047
Releases: master
Change-Id: I98f54f4a75023b963b69c12457b73e5117469497
Reviewed-on: https://review.typo3.org/58083
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Destroy install tool session on backend user logout 97/58297/6
Christian Kuhn [Sun, 16 Sep 2018 19:05:26 +0000 (21:05 +0200)]
[TASK] Destroy install tool session on backend user logout

If a system maintainer used the install tool from within the
backend, the session is now destroyed on logout explicitely.

Resolves: #86249
Resolves: #85404
Releases: master
Change-Id: I6bf4f2a724ec85b60854e8f92c00a10e7614f140
Reviewed-on: https://review.typo3.org/58297
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Make hreflang generator use PSR7 interface 74/58274/7
Richard Haeser [Fri, 14 Sep 2018 09:28:09 +0000 (11:28 +0200)]
[TASK] Make hreflang generator use PSR7 interface

Use the Uri class to check if a host is given in the url
to determine if an absolute url should be generated.

Resolves: #86253
Releases: master
Change-Id: Ib84d391b0564f29352eda93a814f5d9b46696f37
Reviewed-on: https://review.typo3.org/58274
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Suppress avatar file resolving if there is none 91/58291/3
Christian Kuhn [Sun, 16 Sep 2018 08:16:15 +0000 (10:16 +0200)]
[TASK] Suppress avatar file resolving if there is none

Suppress a where uid=0 call on sys_file table if the
backend user has not avatar assigned.

Resolves: #86273
Releases: master
Change-Id: Id67e80dbb906ce27af3954f9c20ee49a5c7050ee
Reviewed-on: https://review.typo3.org/58291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Suppress db call for rootline with uid 0 89/58289/7
Christian Kuhn [Sun, 16 Sep 2018 07:38:20 +0000 (09:38 +0200)]
[TASK] Suppress db call for rootline with uid 0

Page uid 0 has no rootline by definition. The patch adds an
early return to RootlineUtility to suppress some cache->get()
calls. This happens in BE quite often. Additionally, the
SiteFinder does not query RootlineUtility for page uid 0 at
all to save a series of instance creations.

Resolves: #86271
Releases: master
Change-Id: I63c819c6dcd5e5c7a0e226ae16b0ecd6cf391e30
Reviewed-on: https://review.typo3.org/58289
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Update wording in Core Upgrade dialog 92/58292/2
Michael Schams [Sun, 16 Sep 2018 08:47:48 +0000 (18:47 +1000)]
[BUGFIX] Update wording in Core Upgrade dialog

This change updates the text in the Core Upgrade dialog and fixes a
typo as well as introduces some basic styles.

Resolves: #86274
Releases: master
Change-Id: Ie6433a9fa3a5f8b8d1c808955872dda91d10788a
Reviewed-on: https://review.typo3.org/58292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers 85/58285/4
Christian Kuhn [Sat, 15 Sep 2018 13:55:01 +0000 (15:55 +0200)]
[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers

Some DB drivers like pdo_mysql and our postgres flavor return
values from DB always as string. Classes with enabled strict_types
then tend to fail if those values that should be integers but are
strings are fed to functions that accept integers only. The patch
fixes two places in SchedulerModuleController where a db value
is directly sent to date(), which needs an int as second argument.

Resolves: #86263
Releases: master
Change-Id: I00ce0425774762fef235373f643f8b69bdd072bb
Reviewed-on: https://review.typo3.org/58285
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Provide loading indicator for Install Tool 81/58281/4
Markus Klein [Sat, 15 Sep 2018 08:26:27 +0000 (10:26 +0200)]
[TASK] Provide loading indicator for Install Tool

Resolves: #86259
Releases: master
Change-Id: I0a5c7020d879250cf38ca1975a8f63e65f1a0649
Reviewed-on: https://review.typo3.org/58281
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Migrate DatabaseRowsUpdateWizard to UpgradeWizardInterface 78/58278/2
Christian Kuhn [Fri, 14 Sep 2018 14:00:45 +0000 (16:00 +0200)]
[TASK] Migrate DatabaseRowsUpdateWizard to UpgradeWizardInterface

Resolves: #86200
Related: #86172
Releases: master
Change-Id: I9f6412ed7a6adb8b00f62cbca7476a49bed6985d
Reviewed-on: https://review.typo3.org/58278
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Prevent TypoScript condition expressions breaking TYPO3 80/58280/5
Frank Naegler [Fri, 14 Sep 2018 19:24:04 +0000 (21:24 +0200)]
[BUGFIX] Prevent TypoScript condition expressions breaking TYPO3

This patch introduces error handling to mitigate a missing type check
in the Symfony Expression Language handler. In case a condition
uses the "in" or "not in" check in combination with a non-array a PHP
warning is thrown.

Example: [1 in "foo"] or ["bar" in "foo,baz"]
These conditions are broken, but they will break the complete installation
including the backend. To mitigate the problem we do the following:

1) In FE an InvalidTypoScriptConditionException is thrown (if strictSyntax is enabled)
2) In FE catch this error silently and log it (if strictSyntax is disabled)
3) In BE catch this error silently and log it, but never break the backend.

Resolves: #86257
Releases: master
Change-Id: I2a54f819383775a300af6848cfc85e9f626bec21
Reviewed-on: https://review.typo3.org/58280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Improve install tool temporary assets removal 37/57837/11
Christian Kuhn [Fri, 14 Sep 2018 21:01:16 +0000 (23:01 +0200)]
[BUGFIX] Improve install tool temporary assets removal

Maintenance > Remove temporary assets now properly lists
statistics for FAL processed files and allows to clear them.

Releases: master
Resolves: #83034
Change-Id: Ic9238c88648d98a76a0cbd4015820d51bffde0fa
Reviewed-on: https://review.typo3.org/57837
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[TASK] Improve .rst file formatting 79/58279/2
Christian Kuhn [Fri, 14 Sep 2018 17:51:06 +0000 (19:51 +0200)]
[TASK] Improve .rst file formatting

Resolves: #86256
Releases: master
Change-Id: I6b108342ebb7439657afec296c68de7ba45bf29e
Reviewed-on: https://review.typo3.org/58279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig 75/58275/3
Frank Naegler [Fri, 14 Sep 2018 11:01:41 +0000 (13:01 +0200)]
[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig

This patch fix broken TSConfig condition because of missing backend user aspect.

Resolves: #86229
Releases: master
Change-Id: I6528b5d48a5b5711cad8710d4bfcc6222f9fef9c
Reviewed-on: https://review.typo3.org/58275
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Correct condition in TemplateService 77/58277/3
Christian Kuhn [Fri, 14 Sep 2018 12:22:38 +0000 (14:22 +0200)]
[BUGFIX] Correct condition in TemplateService

Issue #85092 introduced a copy & paste bug in TemplateService.

Resolves: #86255
Related: #85092
Releases: master
Change-Id: If0d92e0886e625db8793991f264628030ccfdad4
Reviewed-on: https://review.typo3.org/58277
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[TASK] Use SiteFinder in EXT:felogin 57/58257/5
Georg Ringer [Wed, 12 Sep 2018 18:06:46 +0000 (20:06 +0200)]
[TASK] Use SiteFinder in EXT:felogin

Instead of only checking the sys_domains with a database query
the SiteFinder and PseudoSiteFinder should be used.

Resolves: #86219
Releases: master
Change-Id: I99f9367258f9b19ef3a1310cb2fd61076083333c
Reviewed-on: https://review.typo3.org/58257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[TASK] Migrate extension install upgrade wizards to new API 33/58233/4
Susanne Moog [Wed, 5 Sep 2018 21:22:34 +0000 (23:22 +0200)]
[TASK] Migrate extension install upgrade wizards to new API

Migrates all upgrade wizards based on the
`AbstractDownloadExtensionUpdate` class to the new API.

Related: #86172
Resolves: #86199
Releases: master
Change-Id: I79ffa702a1448bb66324074ef2debf41922d95e8
Reviewed-on: https://review.typo3.org/58233
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[BUGFIX] Make JavaScript of SlugElement a real independent instance 73/58273/4
Andreas Fernandez [Fri, 14 Sep 2018 08:17:23 +0000 (10:17 +0200)]
[BUGFIX] Make JavaScript of SlugElement a real independent instance

The JavaScript for the SlugElement is partially designed to be a
independent instance for each slug field. However, this does not work for
mass editing the slug fields, as the `initialize()` method is always
called on the same instance.

This patch does multiple things:

- The JavaScript is converted to a TypeScript basis, which allows better
  handling of each instance
- The "Regenerate slug" button is disabled in case the "feeder" fields
  are not available to avoid getting bogus values

Resolves: #86221
Releases: master
Change-Id: I458247beb597c77407e94ce633314ae2e2d7095a
Reviewed-on: https://review.typo3.org/58273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[TASK] Make hreflang links absolute 62/58262/5
Richard Haeser [Wed, 12 Sep 2018 20:51:46 +0000 (22:51 +0200)]
[TASK] Make hreflang links absolute

Create absolute URL's for the hreflang links by using the configuration
of the current site.

Resolves: #86224
Releases: master
Change-Id: Id3196542875862b20145418956fcfdfcc3834241
Reviewed-on: https://review.typo3.org/58262
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
7 months ago[BUGFIX] Do not show wizards marked as done in install tool 70/58270/3
Susanne Moog [Thu, 13 Sep 2018 16:56:29 +0000 (18:56 +0200)]
[BUGFIX] Do not show wizards marked as done in install tool

Wizards marked as done are no longer displayed as executable
in the install tool, the missing state check has been included.

Resolves: #86246
Releases: master
Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a
Reviewed-on: https://review.typo3.org/58270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Use correct language in l18n_cfg checks 67/58267/8
Daniel Goerz [Thu, 13 Sep 2018 13:12:25 +0000 (15:12 +0200)]
[BUGFIX] Use correct language in l18n_cfg checks

The check for pages.l18n_cfg is wrong now, as this is
always done against pages.sys_language_uid=0 records (as
"resolvePage" is called right before).

So, these if-statements have to go further south.

On top, the getPageOverlay call needs to be done - on top.

resolvePage -> get default language of page
getPageOverlay -> put the wanted translation on top

A fix for pages.alias has to be in place, as DataHandler
cannot handle pages.alias yet.

Resolves: #86242
Releases: master
Change-Id: Ief99e5f934f6e9d31973b9543cb9a6e599d2d33c
Reviewed-on: https://review.typo3.org/58267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[BUGFIX] Use class name to mark upgrade wizards done 97/58197/4
Helmut Hummel [Thu, 6 Sep 2018 10:15:24 +0000 (12:15 +0200)]
[BUGFIX] Use class name to mark upgrade wizards done

To make the registry for done wizards consistent and stay backwards
compatible once all upgrade wizards are converted to use the
new interface, always store the class name of the wizard
instead of its identifier in the registry.

Additionally we now add checks for valid identifiers
to all API methods that receive one.

Releases: master
Resolves: #86165
Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e
Reviewed-on: https://review.typo3.org/58197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Adapt view related install tool details 69/58269/6
Christian Kuhn [Thu, 13 Sep 2018 14:35:42 +0000 (16:35 +0200)]
[BUGFIX] Adapt view related install tool details

With the install tool move to modals, various details on CSS
level broke: The modal HTML is on top level in backend and thus
not within the content-iframe, so styles defined in install.css
loaded in the iframe do not kick in. Since the standalone install
tool does not use iframes, there are various differences on view
level between standalone and embedded-in-backend version, usually
with the embedded version looking more ugly than standalone.

The install.css is not very different from backend.css anyway,
so we resolve various details with the patch, kick install.css
entirely and rely soley on backend.css, even for the installer.

Details:
* <hr> shows a border again in modals in embedded, broken since
  modal patch
* image processing view has borders and other details again in
  embedded verision, broken since modal patch
* removed 'fixed save button location' for 'all configuration' code.
  This broke with the modal patch, the code does not do anything
  useful at the moment. A solution needs a change of the modal js
  to render the buttons to modal-footer instead. This is too complex
  for this patch and may be done with another patch.
* A couple of classes to easily limit styles to installer and
  maintenance parts
* Remove left overs from old install-tool menu approach that
  have not been cleanup up, yet.

Resolves: #86245
Related: #84772
Releases: master
Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7
Reviewed-on: https://review.typo3.org/58269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Add postProcessMirrorUrl to language updater again 65/58265/2
Christian Kuhn [Thu, 13 Sep 2018 11:25:41 +0000 (13:25 +0200)]
[BUGFIX] Add postProcessMirrorUrl to language updater again

With moving the language pack updater to the install tool, a
signal got lost that allowed overriding the base download url
of language packs per extension.
The patch introduces this signal again.

Resolves: #84691
Related: #84131
Releases: master
Change-Id: I659a8829b292d9c268ee3ee9df851d971ba5ddd7
Reviewed-on: https://review.typo3.org/58265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Delius <me@jandelius.eu>
Tested-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Use SiteFinder for fetching related domain in page tree 93/58193/11
Georg Ringer [Wed, 5 Sep 2018 18:16:23 +0000 (20:16 +0200)]
[TASK] Use SiteFinder for fetching related domain in page tree

The SiteFinder retrieves the correct domain for root pages
also for pages having a site configuration.

Resolves: #86158
Releases: master
Change-Id: If99da2deea08ca7bbe05c13f37472a070ffc6d62
Reviewed-on: https://review.typo3.org/58193
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[BUGFIX] Evaluate config.defaultGetVars in middleware 66/58266/3
Benni Mack [Thu, 13 Sep 2018 11:41:29 +0000 (13:41 +0200)]
[BUGFIX] Evaluate config.defaultGetVars in middleware

The config.defaultGetVars is executed and $_GET is modified,
but not the middleware where this method is called.

In order to also modify the middleware's request object, the
option config.defaultGetVars is also evaluted again in the PSR-15
middleware.

Resolves: #86241
Related: #86046
Releases: master
Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74
Reviewed-on: https://review.typo3.org/58266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Allow recycler page in rootline in BE 43/58243/5
Susanne Moog [Wed, 12 Sep 2018 16:15:25 +0000 (18:15 +0200)]
[BUGFIX] Allow recycler page in rootline in BE

The recycler doktype should be allowed in rootline in BE.

Resolves: #86209
Releases: master
Change-Id: I173c2deca5cd395d566a6fd9d6499538ef20d2e6
Reviewed-on: https://review.typo3.org/58243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Bring back the exception code in exception messages 60/58260/4
Anja Leichsenring [Wed, 12 Sep 2018 18:38:46 +0000 (20:38 +0200)]
[TASK] Bring back the exception code in exception messages

If an exception identifies itself with a code, display it
next to the Exception title.

Change-Id: Ib24b7ce4e0bef426dd4e0f4b7f25c4f5338e02c6
Resolves: #86238
Releases: master
Reviewed-on: https://review.typo3.org/58260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Bring back the paths in exception messages 58/58258/6
Susanne Moog [Wed, 12 Sep 2018 18:14:19 +0000 (20:14 +0200)]
[TASK] Bring back the paths in exception messages

Resolves: #86237
Releases: master
Change-Id: Id139dcabb6367b03fb5584a6c7d4a673595eb88e
Reviewed-on: https://review.typo3.org/58258
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php 56/58256/2
Tymoteusz Motylewski [Wed, 12 Sep 2018 15:13:55 +0000 (17:13 +0200)]
[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php

Resolves: #86235
Releases: master
Change-Id: I1e75309abd8bc1aa38d861dae4a48a958b9750dd
Reviewed-on: https://review.typo3.org/58256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Fix code formatting changelog rst files 54/58254/4
Tymoteusz Motylewski [Wed, 12 Sep 2018 11:32:55 +0000 (13:32 +0200)]
[TASK] Fix code formatting changelog rst files

Double backticks are now replace with single ones,
fixed some typos like missing colon.

Resolves: #86233
Releases: master
Change-Id: I5889a285a5b9a7d65b8bcf7931801298d539e9df
Reviewed-on: https://review.typo3.org/58254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Deprecate BaseScriptClass and AbstractFunctionModule 49/58249/3
Christian Kuhn [Mon, 10 Sep 2018 21:48:19 +0000 (23:48 +0200)]
[TASK] Deprecate BaseScriptClass and AbstractFunctionModule

With latest refactorings, the good old backend module classes
BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule
(t3lib_extobjbase) are finally unused.
These spaghetti classes have been a hindrance to refactor
modules that used them for a long time already due to their
hard to follow code flow, bad method namings, global variable
usages and having everything declared public.
It's time to get rid of them to unlock refactoring of controllers
and allow dropping of various global variables in v10.

Resolves: #86225
Releases: master
Change-Id: I3b5bb35b693c7991052f4e0855c2aae4e39f02a1
Reviewed-on: https://review.typo3.org/58249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Deprecate @internal annotation in extbase commands 39/58039/7
Alexander Schnitzler [Sat, 25 Aug 2018 15:35:38 +0000 (17:35 +0200)]
[TASK] Deprecate @internal annotation in extbase commands

The @internal annotation – which is a regular phpDocumentor annotation
that is used to denote that associated structural elements are elements
internal to the application or library, has been misused by extbase to
tell if a command is internal and thus should not be exposed through
help texts, user documentation etc. – is deprecated without any
replacement.

TYPO3 does no longer support the use of the @internal annotation to
influence the behaviour of the code.

Releases: master
Resolves: #85980
Change-Id: I7f3b998b56e270b30e5193d494d35329f5608603
Reviewed-on: https://review.typo3.org/58039
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Catch non existing directories for import syntax 51/58251/2
Georg Ringer [Tue, 11 Sep 2018 17:27:05 +0000 (19:27 +0200)]
[BUGFIX] Catch non existing directories for import syntax

Catch exceptions for non existing directories which are imported using
the @import syntax for TypoScript and return those as warning in the
template module.

Resolves: #86230
Releases: master
Change-Id: Ie4a6376407eeeaa7a717cb01ede5cabefa8a443f
Reviewed-on: https://review.typo3.org/58251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Add method getBase to SiteInterface 50/58250/2
Georg Ringer [Tue, 11 Sep 2018 05:53:06 +0000 (07:53 +0200)]
[TASK] Add method getBase to SiteInterface

Resolves: #86226
Releases: master
Change-Id: Idcffc65e6e040ab4f09e352f268aa4919c2abc59
Reviewed-on: https://review.typo3.org/58250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Readd missing initialisation of $tsfe 52/58252/2
Georg Ringer [Tue, 11 Sep 2018 17:39:04 +0000 (19:39 +0200)]
[BUGFIX] Readd missing initialisation of $tsfe

During the refactoring of #85543 a line too much has been removed.
Readd the initialisation of $tsfe.

Resolves: #86223
Releases: master
Change-Id: Icd7bf93fe1d04e845b4a8cc497f171c7429d0d55
Reviewed-on: https://review.typo3.org/58252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[FEATURE] Use utf8mb4 on mysql for new instances 40/56440/10
Lienhart Woitok [Fri, 23 Mar 2018 12:54:40 +0000 (13:54 +0100)]
[FEATURE] Use utf8mb4 on mysql for new instances

If installing a new TYPO3 instance on mysql, utf8mb4 is now used as
default charset for the database connection and as default collation.

Upgraders may change LocalConfiguration to use utf8mb4, too. They
however need to take care of changing their collations and setting
according table detaults on their own.

A reports status check verifies there is no mixed collation.

Resolves: #80398
Resolves: #82080
Resolves: #82551
Releases: master
Change-Id: I6bf464a22c6ed74631bf5aacff9c2cfe670077da
Reviewed-on: https://review.typo3.org/56440
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Tested-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Reviewed-by: Georg Großberger <garfieldius67@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
7 months ago[TASK] Deprecate cObject FILE 28/58028/5
Benni Mack [Fri, 24 Aug 2018 16:14:04 +0000 (18:14 +0200)]
[TASK] Deprecate cObject FILE

The cObject FILE has a strange behaviour, and rather became low-level since
Fluid's rise in rendering Frontend.

FILE shows an image if the file is jpg,jpeg,gif,png (but not SVG), and if has a
different file ending, it will check if the file is less than 1MB, it will get its contents
and output that. If the file is 1 byte bigger, nothing is done.

This _magic_ is sketchy, and obsolete, as Fluid offers more flexibility nowadays.

Thus, cObject FILE will be removed from TYPO3 Core in v10.0, however due
to the flexibility of custom cObject, an extension author could just re-implement
the functionality in a custom extension within minutes.

Resolves: #85970
Releases: master
Change-Id: I792ec89486e29051da478c5ec0855d2f9cf913a1
Reviewed-on: https://review.typo3.org/58028
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Add functional tests for copying a record into another language 46/58246/7
Oliver Hader [Mon, 10 Sep 2018 14:40:21 +0000 (16:40 +0200)]
[TASK] Add functional tests for copying a record into another language

The expected behavior is that the copied record is not synchronized
when modifying the language parent record (since it is not in connected
mode).

Resolves: #86215
Releases: master, 8.7
Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc
Reviewed-on: https://review.typo3.org/58246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Protect info extension 41/58241/2
Christian Kuhn [Sun, 9 Sep 2018 19:04:16 +0000 (21:04 +0200)]
[TASK] Protect info extension

Last patch in the protect controller patch series. This time the
Web->Info module controller no longer extends BaseScriptClass and
the single sub controller classed don't extend AbstractFunctionModule
anymore. The patch sets as much as possible to protected to allow
further refactoring of these classes in v10.

Resolves: #86210
Releases: master
Change-Id: I5c474e6cc0bc093c58b2e939e408b47020547a6b
Reviewed-on: https://review.typo3.org/58241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Protect tstemplate extension 40/58240/2
Christian Kuhn [Sun, 9 Sep 2018 15:42:23 +0000 (17:42 +0200)]
[TASK] Protect tstemplate extension

The patch disentangles the tstemplate extension controller
classes. The main controller class no longer extends
BaseScriptClass and the sub controllers no longer extend
AbstractFunctionModule. The classes set as many properties
and methods to protected to allow further refactoring of this
module in v10.

Resolves: #86207
Releases: master
Change-Id: If9ad462a423be5f0e370e0894ebb848b822ee66b
Reviewed-on: https://review.typo3.org/58240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Protect TaskModuleController Part 2 39/58239/3
Christian Kuhn [Sun, 9 Sep 2018 11:06:22 +0000 (13:06 +0200)]
[TASK] Protect TaskModuleController Part 2

TaskModuleController no longer extends BaseScriptClass. Properties
and methods are copied over to the controller and most of them are
set to protected. An instance of the controller class is given
to single class that fetch and set the one or the other information,
so not everything can be made protected. The patch should still
allow us to have more refactoring freedom in v10 in this area.

Resolves: #86204
Related: #86182
Releases: master
Change-Id: I171b22ddbcee67205234b6ca23acf9c95da6ac1b
Reviewed-on: https://review.typo3.org/58239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Use 403 header instead of 401 header 99/57399/3
Markus Klein [Wed, 27 Jun 2018 17:00:12 +0000 (19:00 +0200)]
[BUGFIX] Use 403 header instead of 401 header

The usage of a 401 header must be accompanied by a valid
www-authenticate header, which does not support form-based logins.

Resolves: #85411
Releases: master, 8.7
Change-Id: I71062c58a7d846214f1fec41e78cce4ae72955f3
Reviewed-on: https://review.typo3.org/57399
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Prevent fatal error in DebugExceptionHandler 42/58242/2
Nicole Cordes [Sun, 9 Sep 2018 20:42:58 +0000 (22:42 +0200)]
[BUGFIX] Prevent fatal error in DebugExceptionHandler

This patch fixes an error if no argument was given for a trace step.

Resolves: #86211
Releases: master
Change-Id: Iee26940df2c463fc0badde245f9da92e73f6740e
Reviewed-on: https://review.typo3.org/58242
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Protect ImportExportController 28/58228/3
Christian Kuhn [Sat, 8 Sep 2018 12:04:16 +0000 (14:04 +0200)]
[TASK] Protect ImportExportController

To gain freedom in v10 refactoring this controller, the class
no longer extends BaseScriptClass, copies over properties and
methods from the base class and sets them to protected.

Resolves: #85031
Releases: master
Change-Id: I3c71ede5f2e00e93b5dc5cd0c9c540540d7e5058
Reviewed-on: https://review.typo3.org/58228
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>