Packages/TYPO3.CMS.git
12 months ago[TASK] Streamline site handling functional tests 55/57955/4
Oliver Hader [Sat, 18 Aug 2018 11:48:24 +0000 (13:48 +0200)]
[TASK] Streamline site handling functional tests

Some additional tests are added and the scenario
is extended with pagetrees without a site (sys_domain
in use).

Resolves: #85897
Releases: master
Change-Id: I5c6f61c59e9383de2199dbbc687fdd0924cde1af
Reviewed-on: https://review.typo3.org/57955
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Cleanup in LiveSearch class 46/57946/3
Wouter Wolters [Fri, 17 Aug 2018 11:56:47 +0000 (13:56 +0200)]
[TASK] Cleanup in LiveSearch class

* Simplify FQN of QueryParser
* Use correct typehint for $pageIdList, is an array and not a string
* Switch if statement order to use the less expensive one first
* Surround hard to read or-statement with parentheses
* Directyly return result in getAvailablePageIds

Resolves: #85889
Releases: master
Change-Id: I93b11a4d1480767902435d392a6f6af518bac53f
Reviewed-on: https://review.typo3.org/57946
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[SECURITY] Ensure validity of parameters submitted to ThumbnailController 43/57943/7
Oliver Hader [Fri, 17 Aug 2018 06:49:14 +0000 (08:49 +0200)]
[SECURITY] Ensure validity of parameters submitted to ThumbnailController

Parameters submitted to ThumbnailController via HTTP GET query parameters
can contain arbitrary information. Thus, it has to be verified that those
parameters are valid by signing them with a HMAC.

Prior to that the source code was vulnerable to information disclosure as
well as denial of service attacks due to unsanitized user input. A valid
backend user account was required in order to make use of these flaws.

Since the change which introduced this behavior was not released yet, the
security fixes are handled in public without additional announcements.

Resolves: #85875
Releases: master, 8.7
Change-Id: Ia53ba3756f140b0728b8fd1fb7e0527836639a6b
Reviewed-on: https://review.typo3.org/57943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[BUGFIX] Fix "enabled" in array representation of SiteLanguage 51/57951/4
Benni Mack [Fri, 17 Aug 2018 12:46:40 +0000 (14:46 +0200)]
[BUGFIX] Fix "enabled" in array representation of SiteLanguage

A minor issue with the wrong property when calling enabled()
vs. "isEnabled()" was introduced.

Resolves: #85164
Releases: master
Change-Id: I99afd802db480c6c4b03263c5972867a4273020e
Reviewed-on: https://review.typo3.org/57951
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[BUGFIX] Correct extension scanner matcher definitions 50/57950/3
Christian Kuhn [Fri, 17 Aug 2018 12:43:50 +0000 (14:43 +0200)]
[BUGFIX] Correct extension scanner matcher definitions

Add a couple of missing numberOfMandatoryArguments lines
to the MethodCallMatcher definitions to fix the extension
scanner that validates these files at runtime.

Change-Id: I029d16d4d63b275c134b0483200a716111c913c2
Resolves: #85893
Releases: master
Reviewed-on: https://review.typo3.org/57950
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[BUGFIX] Trigger close & save modal if an IRRE record was removed 47/57947/2
Daniel Goerz [Fri, 17 Aug 2018 11:58:01 +0000 (13:58 +0200)]
[BUGFIX] Trigger close & save modal if an IRRE record was removed

Resolves: #85890
Releases: master
Change-Id: I73972920dbb7046e8ab7cf95577cb2f5af99c095
Reviewed-on: https://review.typo3.org/57947
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Improve description for EidUtility deprecation 45/57945/2
Wouter Wolters [Fri, 17 Aug 2018 11:39:42 +0000 (13:39 +0200)]
[TASK] Improve description for EidUtility deprecation

Resolves: #85878
Releases: master
Change-Id: If35be25607823ab40ad1dc91843bc60562e6752f
Reviewed-on: https://review.typo3.org/57945
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
12 months ago[TASK] Extract Persistence of FrontendEditing in separate class 32/57932/6
Benni Mack [Thu, 16 Aug 2018 19:33:49 +0000 (21:33 +0200)]
[TASK] Extract Persistence of FrontendEditing in separate class

FrontendEditingController calls up DataHandler if the right
get/post parameters are added. This code is specific for
EXT:feedit and extracted into EXT:feedit, as FrontendEditingController
is mixing concerns (rendering panels and persisting).

Resolves: #85877
Releases: master
Change-Id: Ib39fe8b7ddcf68fb9e93d8a08564ae7f550e95f3
Reviewed-on: https://review.typo3.org/57932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Deprecate PageGenerator class 41/57941/9
Benni Mack [Fri, 17 Aug 2018 05:49:58 +0000 (07:49 +0200)]
[TASK] Deprecate PageGenerator class

The static class PageGenerator is a list of
static methods previouly found in "pagegen.php", which
has now been moved within the RequestHandler which
is now fully responsible for turning a request object
with support from TSFE and PageRenderer into a response object.

This removes one further dependency built around a
legacy class and enjoys the concept that RequestHandler+TSFE
now share the responsibility for building $TSFE->content.

This also means that all tests can now be built without
having to use any global variables or some special Singleton
functionality but with a clean structure in mind.

Resolves: #85884
Related: #85822
Releases: master
Change-Id: I298795ea485f3c9850af23c0c5e69a3a6d43df99
Reviewed-on: https://review.typo3.org/57941
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[BUGFIX] Port for Symfony-Route must be a string 28/57928/2
Julian Wundrak [Thu, 16 Aug 2018 11:41:36 +0000 (13:41 +0200)]
[BUGFIX] Port for Symfony-Route must be a string

We use parse_url to determine the port, but symfony-route requires a string.

Resolves: #85872
Releases: master
Change-Id: I45140e0c3c1820e77dcdd9b9b41d68a7755d7477
Reviewed-on: https://review.typo3.org/57928
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[BUGFIX] Ensure cObj only contains valid property objects 44/57944/2
Benni Mack [Fri, 17 Aug 2018 09:49:01 +0000 (11:49 +0200)]
[BUGFIX] Ensure cObj only contains valid property objects

If a cObj instance is serialized (which happens very often), all sub-objects are
serialized with it.

This has a bad side-effect with Logging (as we've seen in other places like scheduler tasks)
when a logger with a FileWriter (to a resource pointer) is used, as the __wakeup() basically
destroys everything.

Therefore the logger is instantiated separately in __wakeup() - the same behaviour
as done with TSFE in ContentObjectRenderer.

Additionally, in order to improve memory footprint, the MarkerBasedTemplateService
is only instantiated whenever used (and not serialized).

Resolves: #85886
Releases: master
Change-Id: I3347485c2a6dcb6cf86a4f8182df6aa004582bb5
Reviewed-on: https://review.typo3.org/57944
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[FEATURE] Enable/disable a specific SiteLanguage in Frontend 34/57934/5
Benni Mack [Thu, 16 Aug 2018 20:25:28 +0000 (22:25 +0200)]
[FEATURE] Enable/disable a specific SiteLanguage in Frontend

When adding a new language/translation it is quite common
to disable a language until it's "going live", so only logged-in
users can see the language variant.

A new checkbox "enabled in Frontend" is added to the site
configuration.

Resolves: #85164
Releases: master
Change-Id: Ib4265e76f3ace29c4942cd165182191042ae54a6
Reviewed-on: https://review.typo3.org/57934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Fix click path to configure trustedHostsPattern 42/57942/2
Jan Helke [Fri, 17 Aug 2018 08:19:32 +0000 (10:19 +0200)]
[TASK] Fix click path to configure trustedHostsPattern

Replace the click path from the old install tool with the one of
the new admin tools.

Releases: master
Resolves: #85885
Change-Id: I3bedae58ee4a020a4edbbc0fcf8df1be25e15430
Reviewed-on: https://review.typo3.org/57942
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[BUGFIX] Fix calling checkIncludeLines non statically in BackendLayoutView 39/57939/2
Wouter Wolters [Thu, 16 Aug 2018 21:19:51 +0000 (23:19 +0200)]
[BUGFIX] Fix calling checkIncludeLines non statically in BackendLayoutView

The method checkIncludeLines in TypoScriptParser should be called
statically in the class BackendLayoutView.

Resolves: #85882
Releases: master,8.7
Change-Id: Ib774ee41528741953576acb82f046ed45e7acc75
Reviewed-on: https://review.typo3.org/57939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
12 months ago[TASK] Centralize sending HTTP headers in TSFE 40/57940/3
Benni Mack [Fri, 17 Aug 2018 05:37:29 +0000 (07:37 +0200)]
[TASK] Centralize sending HTTP headers in TSFE

This patch marks the last change of reordering
sending HTTP response headers via TSFE via
header(), sending all headers within TSFE->processOutput().

Once centralized, the headers can now put into a
PSR-7 response object, if wanted.

Resolves: #85883
Releases: master
Change-Id: I4c9289a43748f02fb571421e34aa7f66ce34cc4a
Reviewed-on: https://review.typo3.org/57940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[BUGFIX] Fix non-static call to getLogger in TypoScriptParser 38/57938/2
Wouter Wolters [Thu, 16 Aug 2018 21:03:31 +0000 (23:03 +0200)]
[BUGFIX] Fix non-static call to getLogger in TypoScriptParser

The method getLogger is static and is called statically now.

Resolves: #85881
Releases: master
Change-Id: Ia9bf834f011e113c05b1da46d34dace0d0c5012c
Reviewed-on: https://review.typo3.org/57938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[BUGFIX] Fix calling getInstance() twice to get ResourceFactory 37/57937/3
Wouter Wolters [Thu, 16 Aug 2018 20:55:57 +0000 (22:55 +0200)]
[BUGFIX] Fix calling getInstance() twice to get ResourceFactory

In the class MetaInformation the ResourceFactory instance is fetched
twice instead of once. Remove one call that is too much.

Resolves: #85880
Releases: master
Change-Id: Ic22b82ff2f68fc2936a0583ae77cb3c0226a0c3d
Reviewed-on: https://review.typo3.org/57937
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[BUGFIX] Make headline of adminpanel sub module settings dynamic 31/57931/2
Susanne Moog [Thu, 16 Aug 2018 18:30:52 +0000 (20:30 +0200)]
[BUGFIX] Make headline of adminpanel sub module settings dynamic

The headline of an admin panel submodule settings group was hardcoded
to "Submodule Settings". This has been changed to "<Submodule Name>
Settings". In addition two missing translations have been introduced.

Releases: master
Resolves: #85876
Change-Id: Ifea4898317a04465776671b766418dbdcf29fcc3
Reviewed-on: https://review.typo3.org/57931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Deprecate EidUtility and methods within TSFE 76/57876/9
Benni Mack [Sat, 11 Aug 2018 18:16:17 +0000 (20:16 +0200)]
[TASK] Deprecate EidUtility and methods within TSFE

EidUtility is a poor-mans middleware functionality with
lots of side-effects, and is marked as deprecated.

On top, the following methods in
TypoScriptFrontendController are deprecated:
- initFEuser()
- storeSessionData()
- previewInfo()
- hook_eofe()
- addTempContentHttpHeaders()
- sendCacheHeaders()

Additionally, the PreviewInfo Hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo']
is deprecated, as the eofe hook solves the same issues.

Resolves: #85878
Releases: master
Change-Id: I49cdb8c9c0b3cdf08fa90ce54cc5e570cfd13dce
Reviewed-on: https://review.typo3.org/57876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[BUGFIX] Use non-static method getCache in Avatar class 35/57935/2
Wouter Wolters [Thu, 16 Aug 2018 20:28:03 +0000 (22:28 +0200)]
[BUGFIX] Use non-static method getCache in Avatar class

The getCache method is not static but called as static twice.
Use $this->getCache() instead.

Resolves: #85879
Releases: master,8.7
Change-Id: Icfb28989c201894d0bfd2867642d7703426fabc2
Reviewed-on: https://review.typo3.org/57935
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Clean up FrontendEditing Controller 25/57925/2
Benni Mack [Wed, 15 Aug 2018 20:19:07 +0000 (22:19 +0200)]
[TASK] Clean up FrontendEditing Controller

The FrontendEditingController class in EXT:core does two things:
- persisting incoming GET/POST requests (actually only when EXT:feedit is installed)
- rendering editIcons and editIconPanel

In order to separate these concerns, the first patch extracts some minor functionality into
EXT:feedit, and cleans up code which should have been done long ago.

The next iteration will be to deprecate unused methods and properties, and to move
FrontendEditingController into EXT:feedit, however, using an Interface to
render editIcons and editPanels instead.

Resolves: #85869
Releases: master
Change-Id: I78ed1da9e619099dc56b970961c90c34f8dff1e4
Reviewed-on: https://review.typo3.org/57925
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Raise typo3/testing-framework to 4.4.0 27/57927/4
Christian Kuhn [Thu, 16 Aug 2018 11:12:24 +0000 (13:12 +0200)]
[TASK] Raise typo3/testing-framework to 4.4.0

composer require --dev typo3/testing-framework:~4.4.0

With the removal of all '$suppressNotices = true' settings from
existing unit tests, this flag has now been removed from the
testing-framework. Core unit tests from now on must never trigger
notices, or fix the subject code along with new tests.

Resolves: #84280
Releases: master
Change-Id: Iffe6f6fa056a0203d2cb5474c25c36d2ef651578
Reviewed-on: https://review.typo3.org/57927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make GeneralUtility tests notice free 26/57926/3
Christian Kuhn [Thu, 16 Aug 2018 10:38:59 +0000 (12:38 +0200)]
[TASK] Make GeneralUtility tests notice free

Resolves: #85871
Releases: master
Change-Id: Idca3e0bef85849eff4de818e0c736ac9aec281c2
Reviewed-on: https://review.typo3.org/57926
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Make DataHandler tests notice free 13/57913/7
Wouter Wolters [Wed, 15 Aug 2018 13:12:12 +0000 (15:12 +0200)]
[TASK] Make DataHandler tests notice free

Resolves: #85862
Releases: master
Change-Id: I19ef49799b2a5a0704072b1758ceba7a28aaee5f
Reviewed-on: https://review.typo3.org/57913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[BUGFIX] Make functional frontend tests work again 94/57894/2
Helmut Hummel [Tue, 14 Aug 2018 13:31:26 +0000 (15:31 +0200)]
[BUGFIX] Make functional frontend tests work again

On systems that populate $_ENV['_'] with the path
to the PHP binary, frontend functional tests fail.

This is due to the fact that TYPO3 tries to determine paths
based on a cli environment, while we in fact emulate
a frontend (HTTP server) environment in this scenario.

This can be fixed with checking for the "magic"
context "Testing/Frontend", which was added beforehand
already in a different place.

At the same time we simplify the code used to make
functional tests work without process isolation, to
make it better communicate the intention and also
make it more robust.

Resolves: #85842
Related: #85712
Related: #85649
Releases: master
Change-Id: Ie1f9d220f70ecfe5ff00d8bf421e58df2b411d23
Reviewed-on: https://review.typo3.org/57894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make sysext/core/Tests/Unit/Resource/ notice free 28/57228/8
Jan Helke [Fri, 22 Jun 2018 16:00:27 +0000 (18:00 +0200)]
[TASK] Make sysext/core/Tests/Unit/Resource/ notice free

Releases: master
Resolves: #85270
Change-Id: I31794c8e5ac90cce3c93bca8a8c0b502ada42c24
Reviewed-on: https://review.typo3.org/57228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[BUGFIX] Move test file to right location 22/57922/4
Benni Mack [Wed, 15 Aug 2018 17:53:44 +0000 (19:53 +0200)]
[BUGFIX] Move test file to right location

The tests in change https://review.typo3.org/57370/
have been put in the wrong folder and are never
executed by the TYPO3 Core Unit Test suite.

This patch moves the file into the right location.

Resolves: #85868
Related: #81620
Releases: master, 8.7
Change-Id: I8cb95031c3198d1955ee800b2137b770400acde8
Reviewed-on: https://review.typo3.org/57922
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Make EnumerationTest.php notice free 61/57061/6
Jan Helke [Mon, 28 May 2018 11:45:06 +0000 (13:45 +0200)]
[TASK] Make EnumerationTest.php notice free

Releases: master
Resolves: #85090
Change-Id: Ibfaf40586bec2e3f20205b2bafc78a70464e7e1d
Reviewed-on: https://review.typo3.org/57061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Deprecate GeneralUtility::clientInfo() 09/57909/3
Benni Mack [Wed, 15 Aug 2018 09:08:01 +0000 (11:08 +0200)]
[TASK] Deprecate GeneralUtility::clientInfo()

The functionality for parsing the HTTP_USER_AGENT server variable is only
used in one place within TYPO3 core and can be substituted directly with
the proper HTTP_USER_AGENT string.

Resolves: #85858
Releases: master
Change-Id: Ie299ebbe157f346caa46ac562fb27250f7daf5d3
Reviewed-on: https://review.typo3.org/57909
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Make ContentObjectRendererTest notice free 06/57906/6
Christian Kuhn [Tue, 14 Aug 2018 22:06:22 +0000 (00:06 +0200)]
[TASK] Make ContentObjectRendererTest notice free

Change-Id: Icbfa4bbc470650848b0ef22d6e4f348173c6a3ef
Resolves: #84456
Releases: master
Reviewed-on: https://review.typo3.org/57906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make ExtensionManagementUtilityTest notice free 07/57907/2
Christian Kuhn [Tue, 14 Aug 2018 23:21:29 +0000 (01:21 +0200)]
[TASK] Make ExtensionManagementUtilityTest notice free

Resolves: #85855
Releases: master
Change-Id: I85991ab3f999760eba0d6c5c918fd8b9c4fdce3d
Reviewed-on: https://review.typo3.org/57907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make AbstractMenuContentObjectTest notice free 05/57905/3
Christian Kuhn [Tue, 14 Aug 2018 19:44:08 +0000 (21:44 +0200)]
[TASK] Make AbstractMenuContentObjectTest notice free

Resolves: #85854
Releases: master
Change-Id: I63f47689cca188cbecf30a3cc25de8f26634cb86
Reviewed-on: https://review.typo3.org/57905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Make FluidTemplateContentObjectTest notice free 04/57904/2
Christian Kuhn [Tue, 14 Aug 2018 19:31:52 +0000 (21:31 +0200)]
[TASK] Make FluidTemplateContentObjectTest notice free

Resolves: #85853
Releases: master
Change-Id: I53677566e9b2af971fafed47e4d6f0a0669911bd
Reviewed-on: https://review.typo3.org/57904
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make felogin/Test/Unit notice free 03/57903/2
Christian Kuhn [Tue, 14 Aug 2018 19:12:41 +0000 (21:12 +0200)]
[TASK] Make felogin/Test/Unit notice free

Resolves: #85852
Releases: master
Change-Id: Ifb95317341b9912cd59eb9a0c9fc5ebb9abeb6f4
Reviewed-on: https://review.typo3.org/57903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
12 months ago[TASK] Make frontend/Tests/Unit/Controller notice free 02/57902/2
Christian Kuhn [Tue, 14 Aug 2018 18:59:59 +0000 (20:59 +0200)]
[TASK] Make frontend/Tests/Unit/Controller notice free

Resolves: #85851
Releases: master
Change-Id: I8e9ac42b8176a0b37237ecd65a67efe8f8db8c82
Reviewed-on: https://review.typo3.org/57902
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make frontend/Tests/Unit/ContentObject/FilesContentObjectTest notice free 99/57899/4
Wouter Wolters [Tue, 14 Aug 2018 18:18:21 +0000 (20:18 +0200)]
[TASK] Make frontend/Tests/Unit/ContentObject/FilesContentObjectTest notice free

Resolves: #85850
Releases: master
Change-Id: I6f0b7fbe5a59cebd382e2c5c0cb761d3e561f0c4
Reviewed-on: https://review.typo3.org/57899
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Make frontend/Tests/Unit/Page notice free 00/57900/2
Christian Kuhn [Tue, 14 Aug 2018 18:21:17 +0000 (20:21 +0200)]
[TASK] Make frontend/Tests/Unit/Page notice free

Resolves: 85849
Related: master
Change-Id: I3b8b163cf488a82cdeedfc84c409268a52eca359
Reviewed-on: https://review.typo3.org/57900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make frontend/Tests/Unit/Plugin notice free 98/57898/2
Christian Kuhn [Tue, 14 Aug 2018 17:57:08 +0000 (19:57 +0200)]
[TASK] Make frontend/Tests/Unit/Plugin notice free

Resolves: #85848
Releases: master
Change-Id: I215768fd8d2b43f2885654cf53dc198416216bb1
Reviewed-on: https://review.typo3.org/57898
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Make frontend/Tests/Unit/DataProcessing notice free 97/57897/4
Christian Kuhn [Tue, 14 Aug 2018 17:35:08 +0000 (19:35 +0200)]
[TASK] Make frontend/Tests/Unit/DataProcessing notice free

Resolves: #85847
Releases: master
Change-Id: I2fee7a27c3cc5a06f6ef3298ddb1b75b766b2db7
Reviewed-on: https://review.typo3.org/57897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Add more tests for ConditionMatcher 86/57886/8
Frank Naegler [Mon, 13 Aug 2018 16:13:25 +0000 (18:13 +0200)]
[TASK] Add more tests for ConditionMatcher

Resolves: #85835
Releases: master
Change-Id: Ia9c66139b74ac15bcf9b5b693b57b840b706e188
Reviewed-on: https://review.typo3.org/57886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[TASK] Make frontend/Tests/Unit/Typolink/ tests notice free 96/57896/4
Christian Kuhn [Tue, 14 Aug 2018 17:11:00 +0000 (19:11 +0200)]
[TASK] Make frontend/Tests/Unit/Typolink/ tests notice free

Resolves: #85846
Releases: master
Change-Id: I9a7338d7bbd706482854c26db8866aaa353bdef7
Reviewed-on: https://review.typo3.org/57896
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Make indexed search tests notice free 95/57895/2
Christian Kuhn [Tue, 14 Aug 2018 16:40:00 +0000 (18:40 +0200)]
[TASK] Make indexed search tests notice free

Resolves: #85845
Releases: master
Change-Id: Id72acfdf7c880f1d0b63a62b912301c724ed500d
Reviewed-on: https://review.typo3.org/57895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Remove dependency between SiteLanguage and Site 93/57893/4
Benni Mack [Tue, 14 Aug 2018 13:09:49 +0000 (15:09 +0200)]
[TASK] Remove dependency between SiteLanguage and Site

The entity of SiteLanguage is re-connected to a
site. However this circular dependency makes it impossible
to serialize or compile any of the site configuration.

As this was introduced at the very early stage of
Site Handling where the API wasn't clear, this can
be removed, as "site" and "language" are both
always available in a PSR-7 request.

Resolves: #85841
Releases: master
Change-Id: Id061def7b0299b9c355ae83e1903cf64b6127149
Reviewed-on: https://review.typo3.org/57893
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Make sysext/extbase/Tests/Unit notice free 21/57221/3
Christian Kuhn [Tue, 14 Aug 2018 16:47:56 +0000 (18:47 +0200)]
[TASK] Make sysext/extbase/Tests/Unit notice free

Releases: master
Resolves: #85264
Change-Id: Iadf459660471c2d0361cee091a83d0e87d7a19fb
Reviewed-on: https://review.typo3.org/57221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[TASK] Make extbase/Tests/Unit/Persistence/Generic/Mapper notice free 24/57224/5
Christian Kuhn [Tue, 14 Aug 2018 13:38:46 +0000 (15:38 +0200)]
[TASK] Make extbase/Tests/Unit/Persistence/Generic/Mapper notice free

Releases: master
Resolves: #85267
Change-Id: I2c7ad4775ee9d29903ef914a2ae54d17e0c111d9
Reviewed-on: https://review.typo3.org/57224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Make extbase/Tests/Unit/Persistence/Generic/Storage/ notice free 26/57226/5
Jan Helke [Fri, 15 Jun 2018 10:57:55 +0000 (12:57 +0200)]
[TASK] Make extbase/Tests/Unit/Persistence/Generic/Storage/ notice free

Releases: master
Resolves: #85269
Change-Id: Id9037ca76e3279b00ecdd1266b2665447278a8e8
Reviewed-on: https://review.typo3.org/57226
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Deprecate several constants from SystemEnvironmentBuilder 43/57843/5
Wouter Wolters [Thu, 9 Aug 2018 14:41:02 +0000 (16:41 +0200)]
[TASK] Deprecate several constants from SystemEnvironmentBuilder

Deprecate 9 URL constants and NUL, TAB and SUB constants.

Resolves: #85793
Releases: master
Change-Id: I01a8fbb7635ffe5db40f2042b77c8dadd6fb8d60
Reviewed-on: https://review.typo3.org/57843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[BUGFIX] Field Wizards use FormEngine JS functions for has-change checks 61/52961/10
Ralf Hettinger [Mon, 29 May 2017 16:52:42 +0000 (18:52 +0200)]
[BUGFIX] Field Wizards use FormEngine JS functions for has-change checks

AddRecord, ListModule and TableWizard fieldControl wizard buttons now use
FormEngine JavaScript function to prevent elderly, incomplete (buggy)
has-change checks as implemented in TBE_EDITOR.isFormChanged.

Resolves: #81360
Releases: master
Change-Id: Ie633e04d7e9c01af2abda39b032c262502d888c8
Reviewed-on: https://review.typo3.org/52961
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Deprecate BackendUtility::getTCAtypes 87/57887/3
Wouter Wolters [Mon, 13 Aug 2018 18:33:21 +0000 (20:33 +0200)]
[TASK] Deprecate BackendUtility::getTCAtypes

Resolves: #85836
Releases: master
Change-Id: I7480cc7ddd6a661a6b13e43ed7dfbc5d0783763f
Reviewed-on: https://review.typo3.org/57887
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[FEATURE] Add path where reference records are located to record info 35/57735/7
Kevin Ditscheid [Tue, 31 Jul 2018 07:10:48 +0000 (09:10 +0200)]
[FEATURE] Add path where reference records are located to record info

This change is enhancing the reference infos of records by adding the
path in the pagetree to the table of record references. This path is
similar to the path in the record edit view on the top right corner

Resolves: #85691
Releases: master
Change-Id: I7d2379fb8a9b41d726f0a1c38a3db7288e689437
Reviewed-on: https://review.typo3.org/57735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Add error trigger to deprecated method body 79/57879/5
Joerg Kummer [Sun, 12 Aug 2018 07:15:50 +0000 (09:15 +0200)]
[TASK] Add error trigger to deprecated method body

Add missing PHP trigger_error() to the deprecated method.

Resolves: #81430
Releases: master
Change-Id: I41e73afc1d05d13dafdc90b41c8509e62cd56ad9
Reviewed-on: https://review.typo3.org/57879
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[TASK] Add unit tests for CommandUtility::unQuoteFilenames 88/57888/3
Wouter Wolters [Mon, 13 Aug 2018 18:43:30 +0000 (20:43 +0200)]
[TASK] Add unit tests for CommandUtility::unQuoteFilenames

While moving this method to CommandUtility class the unit tests
were missing. They are re-added now.

Resolves: #85837
Releases: master
Change-Id: I993a06d6da107a333d186706dcbee1fcc4b2731e
Reviewed-on: https://review.typo3.org/57888
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[BUGFIX] Fix wrong configuration values for password hashes 91/57891/3
Markus Klein [Tue, 14 Aug 2018 08:42:26 +0000 (10:42 +0200)]
[BUGFIX] Fix wrong configuration values for password hashes

And also fix wrong backwards compatibility class declarations.

Resolves: #85838
Related: #85833
Releases: master
Change-Id: I6140f999c99e6903e08f6fa726e06bdf295b8f5b
Reviewed-on: https://review.typo3.org/57891
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Merge EXT:saltedpasswords into EXT:core 85/57885/13
Christian Kuhn [Mon, 13 Aug 2018 11:56:35 +0000 (13:56 +0200)]
[TASK] Merge EXT:saltedpasswords into EXT:core

Move all classes and other resources from EXT:saltedpasswords to
EXT:core.

Classes live in TYPO3\CMS\Core\Crypto\PasswordHashing. This namespace
will be clean in v10 when the classes that are currently only kept for
backwards compatibility are removed.

The documentation has been integrated into the "Core API" docs at
https://docs.typo3.org/typo3cms/CoreApiReference/stable/ApiOverview/PasswordHashing/

Resolves: #85833
Resolves: #85026
Releases: master
Change-Id: Ie6ac7fbf215fe61711f0acdd6dc5a318bce1ad35
Reviewed-on: https://review.typo3.org/57885
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[FEATURE] Move expression language handling into EXT:core 84/57884/10
Frank Naegler [Mon, 13 Aug 2018 10:41:06 +0000 (12:41 +0200)]
[FEATURE] Move expression language handling into EXT:core

The implementation of the symfony expression language has been moved
into EXT:core to centralize the functionality and make it usable
in other scopes.

Resolves: #85828
Releases: master
Change-Id: I5c64001d24a610fd1c3ee4a6bb58e4c1923ec78a
Reviewed-on: https://review.typo3.org/57884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
12 months ago[FEATURE] Add Log Module to AdminPanel 24/57724/12
Susanne Moog [Sun, 29 Jul 2018 21:30:30 +0000 (23:30 +0200)]
[FEATURE] Add Log Module to AdminPanel

Add a log module to the admin panel that can display
logging entries generated through the current request.

Resolves: #84606
Releases: master
Change-Id: Id596d99273f751c05d0112a57eb3c32f7f9a6149
Reviewed-on: https://review.typo3.org/57724
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[BUGFIX] Use params set in db in recordLinkHandler 70/57370/5
Susanne Moog [Mon, 25 Jun 2018 18:39:31 +0000 (20:39 +0200)]
[BUGFIX] Use params set in db in recordLinkHandler

Resolving of links with a custom record link handler is now done
in the following order:

- TypoScriptConfiguration Parameters
- Parameters set in link field in content element
- If param is empty in link field but set in config that is taken into
account as a fallback
- It is _not_ possible to unset a value (class, title, target, link) in
the link field if it _is_ set to a default value in TypoScript

Caveat: Overwriting attributes only works if they are set via parameter
in configuration _not_ if they are set via ATagParams.

Resolves: #81620
Releases: master, 8.7
Change-Id: Ie723e7d7d36a03bac4ec97211749317d7311dd3e
Reviewed-on: https://review.typo3.org/57370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Add hint to Site Configuration without pages 59/57659/2
Mathias Brodala [Mon, 23 Jul 2018 12:53:09 +0000 (14:53 +0200)]
[TASK] Add hint to Site Configuration without pages

Resolves: #85620
Releases: master
Change-Id: I71185161afc5b50ed7b27a8f6298bcf32809a5a4
Reviewed-on: https://review.typo3.org/57659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[TASK] Deprecate PageGenerator::renderContent 80/57880/3
Benni Mack [Sun, 12 Aug 2018 11:18:51 +0000 (13:18 +0200)]
[TASK] Deprecate PageGenerator::renderContent

The PSR-15 RequestHandler should be responsible for compiling content, avoiding
a call to a static method which uses global objects again, which are available
already in the RequestHandler.

Therefore this logic is moved into RequestHandler.

Resolves: #85822
Releases: master
Change-Id: Id37887152a11739b9a43abaa577695daa1957905
Reviewed-on: https://review.typo3.org/57880
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[BUGFIX] Modify SQL Server IDENTITY_INSERT when creating records 75/57875/5
Oliver Hader [Sat, 11 Aug 2018 19:38:40 +0000 (21:38 +0200)]
[BUGFIX] Modify SQL Server IDENTITY_INSERT when creating records

In SQL Server (MSSQL), hard setting uid auto-increment primary keys is
only allowed if the table is prepared for such an operation beforehand.

Resolves: #85818
Releases: master
Change-Id: I28f1c4c6a98b571d5d19521b37ba9bd69ffcf76b
Reviewed-on: https://review.typo3.org/57875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
12 months ago[BUGFIX] Avoid exception on non-existing error handler 77/57877/6
Benni Mack [Sat, 11 Aug 2018 18:41:37 +0000 (20:41 +0200)]
[BUGFIX] Avoid exception on non-existing error handler

When a site is configured, but has no error handler
for a specific error case (e.g. a site has no
configured 404 page), then the regular error handler
should kick in.

This also allows to enable some previously wrong
tests (expected!).

Resolves: #85819
Releases: master
Change-Id: Iefc0e23460de0389b66083da4e6d7aca12b82c59
Reviewed-on: https://review.typo3.org/57877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[BUGFIX] Add missing icon overlay for pages in page tree 68/57868/2
Joerg Kummer [Sat, 11 Aug 2018 00:31:09 +0000 (02:31 +0200)]
[BUGFIX] Add missing icon overlay for pages in page tree

Extend default fields of page tree repository to transmit page properties
for icon overlay rendering in page tree, like in version 8.7

Resolves: #85782
Releases: master
Change-Id: Ia3a30ea93669608cd73ab63e2963357958816773
Reviewed-on: https://review.typo3.org/57868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[TASK] Deprecate unused functionality in Core Bootstrap 71/57871/4
Benni Mack [Sat, 11 Aug 2018 11:52:34 +0000 (13:52 +0200)]
[TASK] Deprecate unused functionality in Core Bootstrap

Due to heavy refactoring with PSR-15 within
the TYPO3 Core Bootstrap, a lot of functionality
can be deprecated.

Resolves: #85821
Releases: master
Change-Id: Ib65ccc9d58a5202d63cd2e8e4f63fa49383ec512
Reviewed-on: https://review.typo3.org/57871
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[TASK] Render wizards of FormEngine elements only if needed 14/57614/3
Georg Ringer [Tue, 17 Jul 2018 02:23:54 +0000 (04:23 +0200)]
[TASK] Render wizards of FormEngine elements only if needed

Reduce the HTML of a record form by rendering divs of wizards only
if those are required.

Resolves: #85577
Releases: master
Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df
Reviewed-on: https://review.typo3.org/57614
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Add more tests to site resolving 78/57878/3
Benni Mack [Sat, 11 Aug 2018 19:02:10 +0000 (21:02 +0200)]
[TASK] Add more tests to site resolving

This patch adds additional tests for resolving
multi-site nested sites and domains.

Resolves: #85820
Releases: master
Change-Id: I4b9083c9cddebbe972874664308fa65d8fc01e56
Reviewed-on: https://review.typo3.org/57878
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[FEATURE] Use symfony/routing for Site Resolving 51/57851/17
Benni Mack [Fri, 10 Aug 2018 11:38:21 +0000 (13:38 +0200)]
[FEATURE] Use symfony/routing for Site Resolving

Use symfony/router 4.1 for resolving a site based on the
current request.

This actually removes some simple resolving built previously
by myself, which was stupid code to detect a site base.

With the symfony/routing component, it is now possible to
have site base prefixes without a scheme (just the domain)
and allow to handle both prefixes. It is also possible to
just add "/site1" and "/site2" as base for domains as
well, allowing to listen to any incoming domain.

As this Routing component will be used for further
page-based routing, the introduced symfony-specific
code might change and encapsulated in other places.

With this patch we now require symfony 4.1 components
or higher, as symfony/routing became fast with 4.1,
and symfony/routing 4.1 is incompatible with various 3.x
components we use. Composer-based installations might
not be able to upgrade, if they have a strong
dependency on a lower symfony version.

The composer command used:
    composer req symfony/console:^4.1 symfony/expression-language:^4.1 \
    symfony/finder:^4.1 symfony/routing:^4.1 symfony/yaml:^4.1 \
    --update-with-dependencies

Resolves: #85719
Resolves: #85165
Releases: master
Change-Id: If21ff3581552ca98af28739a76236a160508f16d
Reviewed-on: https://review.typo3.org/57851
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
12 months ago[TASK] Deprecate second argument of PageRenderer::addInlineLanguageLabelArray 58/57858/3
Wouter Wolters [Fri, 10 Aug 2018 12:36:21 +0000 (14:36 +0200)]
[TASK] Deprecate second argument of PageRenderer::addInlineLanguageLabelArray

Calling `PageRenderer::addInlineLanguageLabelArray` with a second
parameter set to "true" is deprecated. Use the LanguageService directly
when defining your labels.

Resolves: #85806
Releases: master
Change-Id: I92b5186a8e540f91b5873f007934624c4facf1fb
Reviewed-on: https://review.typo3.org/57858
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Clean up Admin Panel Code 70/57870/5
Benni Mack [Sat, 11 Aug 2018 09:42:35 +0000 (11:42 +0200)]
[TASK] Clean up Admin Panel Code

Due to the Admin Panel refactoring, some helper methods
were deprecated, but need a better description.

Also, the $BE_USER->uc property is set to "AdminPanel"
instead of cryptic string "TSFE_adminConfig" since
AdminPanel is not related to TSFE anymore.

Additionally, some helper methods and properties which
are not in use are removed.

Resolves: #85815
Releases: master
Change-Id: I7f875acd0f883690f69e895c814b6ad335d86601
Reviewed-on: https://review.typo3.org/57870
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Move Preview Info hook to hook_eofe 72/57872/2
Benni Mack [Sat, 11 Aug 2018 14:52:33 +0000 (16:52 +0200)]
[TASK] Move Preview Info hook to hook_eofe

The Frontend Request uses two hooks separately to
allow modifying the content via TSFE. In order
to deprecate one (previewInfo), the Frontend Hook
to show the "Preview" info box, is moved to the
hook_eofe hook.

Resolves: #85816
Releases: master
Change-Id: I66fe66a43364c670bdaf7837793180122e329e7b
Reviewed-on: https://review.typo3.org/57872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Make password hash selection an install tool preset 50/57850/18
Christian Kuhn [Thu, 9 Aug 2018 22:41:39 +0000 (00:41 +0200)]
[TASK] Make password hash selection an install tool preset

With this change, the password hash code in salted passwords is
reduced to the SaltFactory with two methods and the single hash
classes that implement SaltInterface without further public
methods. Everything else including the utility classes is
deprecated.
The change moves the LocalConfiguration.php config options around,
adds a settings preset for hash mechanism selection, adds according
silent upgrades, adds 'best available' hash mechanism selection
at installation time and drops the last saltedpasswords
ext_conf_template.txt option.

Details:
* Remove the password hash selection from saltedpasswords config
  namespace and put to TYPO3_CONF_VARS/BE/passwordHashing/className
  and TYPO3_CONF_VARS/FE/passwordHashing/className
* Move available password hash registry from
  TYPO3_CONF_VARS/SC_OPTIONS/ext/saltedpasswords/saltMethods
  to TYPO3_CONF_VARS/SYS/availablePasswordHashAlgorithms
* Add a setting preset to select one of argon2i (preferred),
  bcrypt, pbkdf2 or phpass (last fallback)
* Use 'best matching preset' during installation to select a good
  salt mechanism by default
* Silently upgrade existing password hash selection and upgrade
  to one of the four hash algorithms above
* Allow algorithm specific options in
  TYPO3_CONF_VARS/BE/passwordHashing/options and
  TYPO3_CONF_VARS/FE/passwordHashing/options for admins who
  know what they are doing and need to fiddle with hash details.
* Simplify and refactor the single password hash classes. Deprecate
  a huge list of methods along the way.

Change-Id: I773e2ee27a121c9f0d5302695ebf4aa561170400
Resolves: #85804
Resolves: #83760
Releases: master
Reviewed-on: https://review.typo3.org/57850
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Use full namespace in a documentation file 73/57873/3
Franz Holzinger [Sat, 11 Aug 2018 15:35:17 +0000 (17:35 +0200)]
[TASK] Use full namespace in a documentation file

Releases: master, 8.7
Resolves: #85817
Change-Id: Ifac7a5545d9467a6973bfef55e264fe263d10396
Reviewed-on: https://review.typo3.org/57873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Move FlexFormService from EXT:extbase to EXT:core 54/57854/3
Wouter Wolters [Fri, 10 Aug 2018 09:56:02 +0000 (11:56 +0200)]
[TASK] Move FlexFormService from EXT:extbase to EXT:core

Resolves: #85802
Releases: master
Change-Id: I878bb4552ae8709ed4a1ec32afdfbfd7abaaa2e6
Reviewed-on: https://review.typo3.org/57854
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Correctly initialize environment for DataHandler in tests 69/57869/4
Oliver Hader [Sat, 11 Aug 2018 07:46:25 +0000 (09:46 +0200)]
[TASK] Correctly initialize environment for DataHandler in tests

Since importing data scenarios in tests relies on DataHandler, it is
required to correctly initialize $GLOBALS['LANG'] as well. Since not
all tests were failing, this probably points out side effects during
test execution in terms of reusing globals settings of other tests.

Besides that, a misbehavior in typo3/testing-framework lead to the
situation that not all entities have been created - which would have
triggered DataHandler log entries that rely on previously mentioned
$GLOBALS['LANG'] instance.

Resolves: #85814
Releases: master
Change-Id: I4e2745cfeed6e2576f7ae23dd4d4ea4b49572a3f
Reviewed-on: https://review.typo3.org/57869
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
12 months ago[TASK] Add frontend functional tests for site handling 67/57867/4
Oliver Hader [Fri, 10 Aug 2018 21:20:29 +0000 (23:20 +0200)]
[TASK] Add frontend functional tests for site handling

Integrate functional tests for legacy frontend requests
(index.php?id=123) without having any site configuration,
as well as dedicated tests for frontend requests using
the new v9 site handling feature.

Resolves: #85813
Releases: master
Change-Id: I5e08c41010a7482f779e7aa578597cf771429ebd
Reviewed-on: https://review.typo3.org/57867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Throw PSR-7 Responses up to Application 66/57866/5
Oliver Hader [Fri, 10 Aug 2018 20:21:18 +0000 (22:21 +0200)]
[TASK] Throw PSR-7 Responses up to Application

In order to properly handle PSR-7 response objects explicit die()
or exit() calls should be avoided since those states cannot be
handle nor analyzed further. As a current work-around a new
ImmediateResponseException is introduced that throws the exception
up to application object that transforms the emitted message into
a proper response object. This API is internal and considered as
intermediate - the real solution would be to completely refactor
TypoScriptFrontendController processing and only use
request/response consequently.

Resolves: #85812
Releases: master
Change-Id: I047ad82fd5734c38160b8552aa754b1e7c356417
Reviewed-on: https://review.typo3.org/57866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
12 months ago[TASK] Use view helper to configure ModuleTemplate in log module 88/51088/17
Helmut Hummel [Sun, 1 Jan 2017 12:56:01 +0000 (13:56 +0100)]
[TASK] Use view helper to configure ModuleTemplate in log module

With implementation of ModuleTemplate as view helpers,
we can remove class inheritance for the two purposes
where we render the log module and use Fluid layouts for that.

By doing so, we can clean up the Fluid templates,
add xml based namespace registration, remove unnecessary partials
and also get rid of persistent object inheritance of
the filter DTO.

Resolves: #85521
Releases: master
Change-Id: I5e35ea97ce419fc3a7ffbee309c466118e22ab80
Reviewed-on: https://review.typo3.org/51088
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
12 months ago[TASK] Split site configuration loading into separate method 62/57862/2
Benni Mack [Fri, 10 Aug 2018 18:29:19 +0000 (20:29 +0200)]
[TASK] Split site configuration loading into separate method

Resolves: #85810
Releases: master
Change-Id: I329b343715895536fde5013b2ece9e2717c3834d
Reviewed-on: https://review.typo3.org/57862
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
12 months ago[BUGFIX] Use proper phpDoc in PSR-7 implementation 63/57863/2
Benni Mack [Fri, 10 Aug 2018 18:39:47 +0000 (20:39 +0200)]
[BUGFIX] Use proper phpDoc in PSR-7 implementation

This fixes some IDE issues when working with PSR-7 classes within TYPO3.

Resolves: #85811
Releases: master, 8.7
Change-Id: I69b9fed8a603b32ac6bfed57c251907d09dcae19
Reviewed-on: https://review.typo3.org/57863
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
12 months ago[FEATURE] Select first element of PageTree toolbar on initialization 15/57815/6
Paweł Rogowicz [Sun, 5 Aug 2018 09:47:20 +0000 (11:47 +0200)]
[FEATURE] Select first element of PageTree toolbar on initialization

The first element of the PageTree toolbar is selected when initialized.
The possibility to close/hide a toolbar option has been removed. Either
the page type or the filter/search is displayed.

Releases: master
Resolves: #13265
Change-Id: I055c877d300ba023ae880679a9a602f95a40c374
Reviewed-on: https://review.typo3.org/57815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
12 months ago[TASK] Deprecate EnvironmentService::isEnvironmentInCliMode 59/57859/2
Wouter Wolters [Fri, 10 Aug 2018 13:09:33 +0000 (15:09 +0200)]
[TASK] Deprecate EnvironmentService::isEnvironmentInCliMode

Resolves: #85807
Releases: master
Change-Id: I4737a11e4e673e33553aa5ff835999bcc9a4afb5
Reviewed-on: https://review.typo3.org/57859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Add php extension PDO to master and sub packages 55/57855/4
Anja [Fri, 10 Aug 2018 09:50:02 +0000 (11:50 +0200)]
[TASK] Add php extension PDO to master and sub packages

composer command:

composer require ext-pdo:"*"

Releases: master
Resolves: #85803
Change-Id: Ied0f9b60bf1dc8b8ada66b1da622bc6bf49cf80a
Reviewed-on: https://review.typo3.org/57855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Add documentation render directories to .gitignore 71/57771/3
Sybille Peters [Thu, 2 Aug 2018 08:30:49 +0000 (10:30 +0200)]
[TASK] Add documentation render directories to .gitignore

Add directory created by documentation rendering to .gitignore.

Rendering the docs locally is helpful for checking if it will render
correctly on the server. This will create the rendered files in
typo3/sysext/*/Documentation-GENERATED-temp/.

Adding this to .gitignore will prevent accidentally adding the generated
documentation to a patch.

Resolves: #85725
Releases: master, 8.7
Change-Id: Ibcff2570b961e1f1add519ead49e565c671a28ba
Reviewed-on: https://review.typo3.org/57771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Improve TS Template module information on root level list 06/57806/16
Joerg Kummer [Sat, 4 Aug 2018 13:52:09 +0000 (15:52 +0200)]
[TASK] Improve TS Template module information on root level list

The template tool on root level, which displays an overview of pages
including templates, now displays instead of the count of templates
all related templates of a page with several informations like:
- title
- state (by icon)
- is root or extend
- direct link to edit (with ID ans site-title as link title)
Pages in rootline, which do not includes templates itself are no longer
linked to the template modul.
Database query has been streamlined, and all render logic of
Html specific output has been moved to FLUID templating.
This offers the possibility to add filter or search to this view.
An issue with page sorting in page tree, when rootline pages does not
contain TS templates has been fixed.

Resolves: #81430
Releases: master, 8.7
Change-Id: I5250c53df1acc4a1a29839ce4a472f3e863ae992
Reviewed-on: https://review.typo3.org/57806
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
12 months ago[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array 70/57770/7
Benni Mack [Thu, 2 Aug 2018 08:06:48 +0000 (10:06 +0200)]
[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array

Calling `GeneralUtility::explodeUrl2Array` with a second
parameter "true" can be simplified by using PHP's
native parse_str() method directly.

The second parameter is then deprecated.

All occurrences are replaced with "parse_str()" where
the second parameter was set to true.

Resolves: #85801
Releases: master
Change-Id: Ifd590bc17626cb93495f3f43935671e3f2296c7b
Reviewed-on: https://review.typo3.org/57770
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[TASK] Clean up code due to Context API deprecations 52/57852/2
Benni Mack [Fri, 10 Aug 2018 07:41:23 +0000 (09:41 +0200)]
[TASK] Clean up code due to Context API deprecations

The TSFE object does not use $gr_list, $showHiddenPage, $loginUser etc.
anymore, and the deprecations in place (via magic methods) do not expect the
properties to be filled at all anymore.

Some comments are adjusted.

Additionally, some tests where a global TSFE is not necessary anymore, are adapted.

Resolves: #85800
Releases: master
Change-Id: I3b10e3d28d200cb1533bc418b3ad24cf47f452d4
Reviewed-on: https://review.typo3.org/57852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Richard Vollebregt <richard.vollebregt@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
12 months ago[BUGFIX] Fix fluid error in admin panel 62/57762/4
Susanne Moog [Wed, 1 Aug 2018 19:14:57 +0000 (21:14 +0200)]
[BUGFIX] Fix fluid error in admin panel

Resolves: #85702
Releases: master
Change-Id: I6dc4dabdf565b14fd4271c476881fbd8d06d9a77
Reviewed-on: https://review.typo3.org/57762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
12 months ago[TASK] Refactor SaltFactory 47/57847/11
Christian Kuhn [Thu, 9 Aug 2018 15:47:30 +0000 (17:47 +0200)]
[TASK] Refactor SaltFactory

The patch deprecates static SaltFactory::getSaltingInstance()
and replaces it with the two new non-static methods.
The ->get() method returns a hash instance to check a given password
against a given hash, and ->getDefaultHashInstance() which returns
an instance of the configured default hash method to calculate
a hash for a new password.

The new methods are now strict, non-static and throw exceptions if
something goes wrong. This simplifies mocking in tests and sanitizes
password hash handling in the core.

Change-Id: I186576593202cb6d052bc7c1ca6f81314eddbaf2
Resolves: #85796
Releases: master
Reviewed-on: https://review.typo3.org/57847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[TASK] Change URL of TYPO3_URL_DONATE constant 45/57845/2
Wouter Wolters [Thu, 9 Aug 2018 14:58:38 +0000 (16:58 +0200)]
[TASK] Change URL of TYPO3_URL_DONATE constant

Resolves: #85791
Releases: master,8.7
Change-Id: Ib90b3a0dcc77ba5f6006232ac8357e5a50ec782a
Reviewed-on: https://review.typo3.org/57845
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
12 months ago[BUGFIX] Select first element in tree when deleting selected node 91/57791/14
Paweł Rogowicz [Fri, 3 Aug 2018 13:49:04 +0000 (15:49 +0200)]
[BUGFIX] Select first element in tree when deleting selected node

This patch fixes a bug which occured when deleting a currently selected
node. After deleting this node the first element of the tree is
displayed.

Releases: master
Resolves: #85431
Change-Id: I64cd7c4ebd8415a2c261da3f62f8e412575b0075
Reviewed-on: https://review.typo3.org/57791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
12 months ago[BUGFIX] Remove double zip extension when downloading in EM 34/57834/2
Wouter Wolters [Wed, 8 Aug 2018 11:48:33 +0000 (13:48 +0200)]
[BUGFIX] Remove double zip extension when downloading in EM

The download as zip action outputs the zip file with double .zip
extension. Remove the second .zip from the header.

Resolves: #85770
Releases: master,8.7
Change-Id: Iecc69676cd019060f2bd9e86f97d6adc0e9b6c2b
Reviewed-on: https://review.typo3.org/57834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Deprecate GeneralUtility::unQuoteFilenames 21/57821/3
Wouter Wolters [Sun, 5 Aug 2018 13:04:35 +0000 (15:04 +0200)]
[TASK] Deprecate GeneralUtility::unQuoteFilenames

Moves the method over to CommandUtility as that is the only usage
in the core.

Resolves: #85760
Releases: master
Change-Id: I6d1831a6f6288365e5cb879c056ee06b7bb6fb74
Reviewed-on: https://review.typo3.org/57821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Improve readability of 8.x Changelog 29/57829/9
Daniel Siepmann [Tue, 7 Aug 2018 10:55:29 +0000 (12:55 +0200)]
[TASK] Improve readability of 8.x Changelog

Only breaking changes and important changes were adjusted for now.

* Fix rst syntax issues, like missing blank line before list.
* Add roles for highlighting of inline files and code.
* Add link to mentioned issues.
* Prefix PHP Globals with $GLOBALS[] to keep things as they are in real
  world and to keep it the same between all files.
* Use single formats, e.g. always '*' for lists. This will make
  refactorings and other stuff easier.

Resolves: #85771
Releases: master, 8.7
Change-Id: I47f7db732ab1da751c6f84469152d7209e065c19
Reviewed-on: https://review.typo3.org/57829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[BUGFIX] Fix wrong changelog information for #82794 38/57838/2
Daniel Siepmann [Thu, 9 Aug 2018 06:29:28 +0000 (08:29 +0200)]
[BUGFIX] Fix wrong changelog information for #82794

The introduced keyword is called pageNotFound and is available for the
existing keyword content_fallback.
"stop" and "fallback" were wrong.

* Fix wrong syntax to allow rendering of list.
* Add roles for syntax highlighting of TS.
* Add styling to inline configuration.

Resolves: #85771
Releases: master, 8.7
Change-Id: I6cb36d2b680527ab402c0fc8cb8245d90c5accd7
Reviewed-on: https://review.typo3.org/57838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Reduce number of needed SQL queries for resorting of records 18/57218/41
Markus Klein [Tue, 24 Jul 2018 13:25:09 +0000 (15:25 +0200)]
[TASK] Reduce number of needed SQL queries for resorting of records

This reduces the resorting to require only a single update statement
in contrast to "number of records" statements.
It also only updates the records after the current one, so less records
are touched when resorting.

Now handling of the sorting value is following:
- if no record exists: set interval as sorting number
- if inserted before an element: put in the middle of the existing elements
- if inserted behind the last element: add interval to last sorting number
- if collision: move all subsequent records by 2 * interval, insert
  new record with sorting = collision + interval

Before, in case of the collision all the records from given pid were
resorted. The first item was getting 512 (2*sortIntervals) as sorting,
following records were getting value of
previous record + sortIntervals (768,1024,...).

Note:
I case we have multiple records with the same sorting value,
resorting will not fix that, but just move them up.

New algorithm drawback:
Sorting column values will grow quicker in time as we're always
increasing the sorting value and never tidying the whole table
(thus possibly lowering the max used value).
The current implementation still allows to insert some 80 million
records per colpos if sizeof(int) is only 32bit.
A lot more if we have 64bit.

Changes to the DataHandler->getSortNumber method are mostly comments and
formatting (added guard clause), no change in behavior except for
additional sorting by uid. The additional sorting was required to have
the same test results across database servers.

Description of updated tests:

- workspaces/.../IRRE/ForeignField/Publish/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/copyPageWHotelBeforeParentContent.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/copyPageWHotelBeforeParentContent.csv

  Now copied tx_irretutorial_1nff_price records have the same
  sorting values/order as original records (1,2,3 instead of 1,3,2).
  So workspace actions result in the same values as live operations.

- backend/.../Controller/Page/Localization/CSV/DataSet/CreatedElementOrdering.csv
  Order of the records in both languages is kept (before and after the patch),
  It might look wrong that a record 2.5 in translation is between 1 and 2
  and not between 2 and 3, but keep in mind that colpos is taken into account.
  So record 2.5 has just to be after record 1 (only the two are in colpos 0).

- install/.../Updates/RowUpdater/DataSet/recordsCanBeUpdated.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  core/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeNCopyPageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWExclude.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv
  core/.../IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv
  core/.../IRRE/ForeignField/Modify/DataSet/copyParentContentToLanguageWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/copyPage.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/Modify/DataSet/copyPageWHotelBeforeParentContent.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/localizeParentContentWAllChildren.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv
  workspaces/.../IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv

  Order of the records is kept, less records have changed sorting values,
  as now we're just resorting records after the current one.

- impexp/.../DatabaseAssertions/importPagesAndRelatedTtContentWithDifferentImageToExistingData.csv
  impexp/.../DatabaseAssertions/importPagesAndRelatedTtContentWithSameImageToExistingData.csv
  now existing page sorting is not changed when importing data.

- workspaces/.../IRRE/CSV/Publish/DataSet/moveParentContentToDifferentPageNChangeSorting.csv
  workspaces/.../IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageNChangeSorting.csv
  workspaces/.../IRRE/CSV/PublishAll/DataSet/moveParentContentToDifferentPageNChangeSorting.csv

  in CSV relation we don't care about the child sorting field as
  the order is determined by the value of the CSV field.

Resolves: #85300
Releases: master
Change-Id: I033acae475be8778d10dfb5d506d63804aa941e0
Reviewed-on: https://review.typo3.org/57218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Allow C-style comments on a single line in TypoScript 63/57763/4
Markus Klein [Wed, 1 Aug 2018 19:38:15 +0000 (21:38 +0200)]
[TASK] Allow C-style comments on a single line in TypoScript

Resolves: #16681
Releases: master
Change-Id: I8a0e3e4a0ef9e6debabe581e1d8b05a32055621f
Reviewed-on: https://review.typo3.org/57763
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[BUGFIX] Use correct server variable for domain lock evaluation 33/57833/4
Markus Klein [Tue, 7 Aug 2018 21:39:35 +0000 (23:39 +0200)]
[BUGFIX] Use correct server variable for domain lock evaluation

Patch https://review.typo3.org/57759 introduced a regression by using
REMOTE_HOST instead of HTTP_HOST for matching an authenticating user
against a configured domain lock.

Resolves: #85776
Related: #85761
Releases: master
Change-Id: I1d0087fa0c86506fedccba83fa83502963bd5f6f
Reviewed-on: https://review.typo3.org/57833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[BUGFIX] Remove wrong parameters for log entries and remove REMOTE_HOST 32/57832/2
Markus Klein [Tue, 7 Aug 2018 21:31:58 +0000 (23:31 +0200)]
[BUGFIX] Remove wrong parameters for log entries and remove REMOTE_HOST

Patch https://review.typo3.org/57313 introduced a number of wrong
log entry calls, which provide too much data for sprintf().
This patch removes those unneeded entries.

Moreover, this patch removes the REMOTE_HOST from log entries as those
would exact matching of the IP address, which is not desired. (GDPR)

Resolves: #85773
Related: #85316
Releases: master
Change-Id: Ic7eb288efde53f6232ee699e6786d965a67d2e7f
Reviewed-on: https://review.typo3.org/57832
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
12 months ago[!!!][TASK] Merge salted passwords auth service into default service 59/57759/14
Christian Kuhn [Wed, 1 Aug 2018 17:05:45 +0000 (19:05 +0200)]
[!!!][TASK] Merge salted passwords auth service into default service

The patch merges the default 'authUserBE' and 'authUserFE' authentication
service of extension saltedpasswords on priority 70 into the default
authentication service of the core on priority 50.

The now unused SaltedPasswordService is deprecated with this class.
Last inactive ways for authentication against stored plain text
passwords are removed.

While this is in almost all cases not a problem for existing instances
when upgrading, an edge case when this may lead to a security relevant
breaking change is described in a changelog file.

The new 'authUser' of the default core authentication method is
rewritten and carefully crafted to be much easier to understand, much
more defensive, better documented and tested.

Change-Id: Ie21e891b6f8b5ceed694b412f933ad6435240ff9
Resolves: #85761
Releases: master
Reviewed-on: https://review.typo3.org/57759
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 months ago[TASK] Update Breaking-72360-RemovedDeprecatedEntryPointFallback.rst 28/57828/2
Daniel Siepmann [Tue, 7 Aug 2018 08:19:05 +0000 (10:19 +0200)]
[TASK] Update Breaking-72360-RemovedDeprecatedEntryPointFallback.rst

Use link reference to issue.

Releases: master
Resolves: #85769
Change-Id: Iceed7dc91c9e6db032ab682bca5fb1db880a8857
Reviewed-on: https://review.typo3.org/57828
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
12 months ago[TASK] Update Breaking-72293-APIChangeInExceptionHandlerInterface.rst 27/57827/2
Daniel Siepmann [Tue, 7 Aug 2018 07:43:45 +0000 (09:43 +0200)]
[TASK] Update Breaking-72293-APIChangeInExceptionHandlerInterface.rst

Use link reference to issue.

Releases: master
Resolves: #85768
Change-Id: I2ab05a39637a85e815b986931846292da4497f85
Reviewed-on: https://review.typo3.org/57827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>