Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Do not devlog bad code smells of core classes 54/52054/3
Markus Klein [Sun, 12 Mar 2017 15:58:51 +0000 (16:58 +0100)]
[BUGFIX] Do not devlog bad code smells of core classes

Releases: 7.6, 6.2
Resolves: #48544
Change-Id: If58f3a5c9c6a1003a0301bd2d68622ee8ccba843
Reviewed-on: https://review.typo3.org/52054
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Bruckmoser <dev@abavo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Inline references are bound to versioned page 43/52343/2
Oliver Hader [Mon, 3 Apr 2017 16:25:59 +0000 (18:25 +0200)]
[BUGFIX] Inline references are bound to versioned page

When modifying inline child elements that belong to a page
as parent record in a workspace, the pid values of these
inline children are bound to the page version instead of
the according counterpart (real record or placeholder)
of the live workspace.

Change-Id: I113b5c36672e767d4151f8a41ff9c5fa20b11877
Resolves: #80663
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52343
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Fix check to determine RTEhtmlarea is in fullscreen mode 39/52339/2
Wouter Wolters [Mon, 3 Apr 2017 13:11:32 +0000 (15:11 +0200)]
[BUGFIX] Fix check to determine RTEhtmlarea is in fullscreen mode

Due to the implementation of routes the check fails. Check against
the route instead.

Resolves: #78731
Releases: 7.6
Change-Id: Ifef945aa076c36755bc7193bc4702651402181c7
Reviewed-on: https://review.typo3.org/52339
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use English labels if browser's preferred language is English 25/52325/2
Xavier Perseguers [Mon, 3 Apr 2017 09:13:01 +0000 (11:13 +0200)]
[BUGFIX] Use English labels if browser's preferred language is English

Change-Id: Ic9cb3f3e3e0547e4a0d34bf50f481e2f3844f610
Resolves: #80593
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update readme copyright date to 2017 27/52327/2
Dennis [Mon, 3 Apr 2017 08:02:54 +0000 (10:02 +0200)]
[TASK] Update readme copyright date to 2017

Releases: master,7.6
Resolves: #80645
Change-Id: I346a18f4f8983ee570bb5f0cae1e6635335f7d73
Reviewed-on: https://review.typo3.org/52327
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] MM relations of localizations not resolved in functional tests 18/52318/2
Oliver Hader [Sun, 2 Apr 2017 17:39:36 +0000 (19:39 +0200)]
[BUGFIX] MM relations of localizations not resolved in functional tests

* value of _ORIG_uid -> version record
* value of _LOCALIZED_UID -> localized record
* value of uid -> non-overlaid record

Change-Id: I35cc1e94b68a7725e71a469e557bc34f7c952a21
Resolves: #80638
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52318
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Fix scheduler task logging in case of an exception 92/52292/2
Christian Wolff [Fri, 31 Mar 2017 07:23:49 +0000 (09:23 +0200)]
[BUGFIX] Fix scheduler task logging in case of an exception

Correctly log the message if a Scheduler task throws an exception.
The exception code is now part of the logged message too.

Resolves: #80566
Releases: master, 7.6
Change-Id: Ic4eb25608094869733b4a23057d209fab1a1bccf
Reviewed-on: https://review.typo3.org/52292
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] FAL: Correctly iterate folder content with offset 87/52287/2
Markus Klein [Thu, 30 Mar 2017 22:06:58 +0000 (00:06 +0200)]
[BUGFIX] FAL: Correctly iterate folder content with offset

Whenever a list of files of a folder is queried with an offset
make sure we handle filtered files correctly by not taking them
into account when searching for the first eligible file for the
result.

A direct seek() to the start position is wrong as those first files
may contain files would be later on filtered.
The solution is to iterate the whole file list and only count
non-filtered elements to reach the correct starting point.

Releases: master, 7.6, 6.2
Resolves: #80589
Change-Id: I79a6d298599d31aa49c36fd51cc5bbe2cf2ccf3a
Reviewed-on: https://review.typo3.org/52287
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack() 57/52257/2
Thomas Hohn [Mon, 6 Feb 2017 11:01:25 +0000 (12:01 +0100)]
[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack()

DataHandler's hook processDatamap_afterDatabaseOperations is processed
in two ways. In case modifications do not contain any new relation that
just has been created, the hook is executed directly. If that's not the
case, executing this hook is deferred and will happen after the remap
stack has been processed.

Calling the hook directly happens exactly once for each modified record,
where invocations in DataHandler::processRemapStack() might happen more
than once, depending on the amount of relation fields that contain new
references and have been remapped.

This change coalesces these invocations which results that the hooks
processDatamap_afterDatabaseOperations is exactly called once for each
modified record - which is the expected behavior.

Change-Id: Ib7e65ce170c8f9ba8f7577b79073b1ed9213a0b9
Resolves: #79635
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51552
Reviewed-on: https://review.typo3.org/52257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Integrate tests for DataHandler hook invocations 54/52254/3
Oliver Hader [Mon, 27 Mar 2017 16:28:02 +0000 (18:28 +0200)]
[TASK] Integrate tests for DataHandler hook invocations

Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139
Resolves: #80494
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52190
Reviewed-on: https://review.typo3.org/52254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] JS: Fix FormEngine initialization 08/52208/4
Markus Klein [Mon, 27 Mar 2017 13:51:07 +0000 (15:51 +0200)]
[BUGFIX] JS: Fix FormEngine initialization

The FormEngine initialization process needs to be very careful
when the DOM is accessed.
This patch separates the routines and encapsulates those in
a DOMready handler, which are critical.

This solves a possible race condition when JS is executed faster
than DOM is built.

Releases: master, 7.6
Resolves: #80481
Resolves: #80366
Change-Id: I205aebc9f87a25f06942f923497f7f535fdb0c8f
Reviewed-on: https://review.typo3.org/52208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix namespace declaration for checkboxes in plain form mails 29/52229/3
Ronny Sternecker [Wed, 29 Mar 2017 06:50:53 +0000 (08:50 +0200)]
[BUGFIX] Fix namespace declaration for checkboxes in plain form mails

In system extension form emails from form data are generated by a
PostProcessor. The partial for checkbox elements on plain text mails
missed a preliminary blancket in namespace declaration
(first character in this file). This bracket is added.

Resolves: #80518
Releases: 7.6
Change-Id: Ib3b4e27d645d86c4dc75a0da66c86ebb48f0242a
Reviewed-on: https://review.typo3.org/52229
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Check correct variable in BrowseLinksController 15/52215/2
Christer Vindberg [Tue, 28 Mar 2017 07:10:31 +0000 (09:10 +0200)]
[BUGFIX] Check correct variable in BrowseLinksController

Make sure to check the correct variable classesAnchorDefaultTitle
when fetching the title of anchors.

This affects CKeditor as well as htmlarea.

Resolves: #80209
Releases: master, 7.6
Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706
Reviewed-on: https://review.typo3.org/52215
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] JS: Invert dependency definition for FormEngine and Validation 07/52207/3
Markus Klein [Mon, 27 Mar 2017 13:45:58 +0000 (15:45 +0200)]
[BUGFIX] JS: Invert dependency definition for FormEngine and Validation

FormEngineValidation is meant as integral part of FormEngine.
The current dependency definition is inverted, such that FormEngine
now depends on FormEngineValidation and not the other way around.
Note that FormEngineValidation does not need any other feature
of FormEngine, so this is safe.

This solves a possible race condition with other modules.

Releases: master, 7.6
Resolves: #80459
Change-Id: Ie2cb9dd90220b37a98bc8e3ca174fd074488cc8d
Reviewed-on: https://review.typo3.org/52207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid remapping empty value in checkValueForInline 71/52171/2
Claus Due [Wed, 21 Dec 2016 15:44:14 +0000 (16:44 +0100)]
[BUGFIX] Avoid remapping empty value in checkValueForInline

This change prevents checkValueForInline from processing
empty values. The existing check would process empty
values since one of the true matches is when value cannot
be interpreted as an integer.

Change-Id: Iacd38363bcc23453da9fcc2eea359680c6b91175
Resolves: #79063
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51015
Reviewed-on: https://review.typo3.org/52171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Decrease z-index for disabled fields in FormEngine 65/52165/2
Andreas Fernandez [Sat, 25 Mar 2017 15:55:48 +0000 (16:55 +0100)]
[BUGFIX] Decrease z-index for disabled fields in FormEngine

The z-index for disabled input fields is decreased to a much lower value
to avoid overlaying the module header bar.

Resolves: #80428
Releases: master, 7.6
Change-Id: Ia6f861fc66269b843571720e31f4f935d5cc9614
Reviewed-on: https://review.typo3.org/52165
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Start click binding only after DOM is ready 43/52143/3
Frank Naegler [Thu, 23 Mar 2017 13:46:51 +0000 (14:46 +0100)]
[BUGFIX] Start click binding only after DOM is ready

This patch fixes a loading issue on poor internet connections.
In case of a slow internet connection the icons are not loaded and the
click binding does not work. A DOM ready check should solve the issue.

Resolves: #80416
Releases: master, 7.6
Change-Id: Ia79f14e9dbe0b44a22c5916073b4649211b0bd7b
Reviewed-on: https://review.typo3.org/52143
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Ensure correct sorting of extension configuration 35/52135/2
Nicole Cordes [Tue, 7 Mar 2017 22:18:00 +0000 (23:18 +0100)]
[BUGFIX] Ensure correct sorting of extension configuration

If an extension uses a default subcategory for its configuration but does
not define a sorting order, using PHP >= 7 the order is reversed. This
patch ensures an previously introduced counter is used as identifier.

Resolves: #80180
Related: #76386
Releases: master, 7.6
Change-Id: Ib480632213ebe090688da5ba30c031ca116cf9a9
Reviewed-on: https://review.typo3.org/51980
Reviewed-on: https://review.typo3.org/52135
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix tooltip after changing permissions 28/52128/2
Josef Glatz [Wed, 22 Mar 2017 08:29:30 +0000 (09:29 +0100)]
[BUGFIX] Fix tooltip after changing permissions

Fix js tooltip after permission settings are changed
in the permissions backend module.

Resolves: #80387
Releases: master, 7.6
Change-Id: I6be57ff0a48b3245c5e2d1aabc4260720c480e5f
Reviewed-on: https://review.typo3.org/52128
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add support for target attribute to form viewhelper 73/51973/2
Susanne Moog [Tue, 7 Mar 2017 07:48:48 +0000 (08:48 +0100)]
[BUGFIX] Add support for target attribute to form viewhelper

<f:form> now supports setting target="" as attribute.

Change-Id: Id6bd5f136b3ca6a4083f08780796b408ceaf0116
Releases: master,7.6
Resolves: #80159
Reviewed-on: https://review.typo3.org/51971
Reviewed-on: https://review.typo3.org/51973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Check if install tool enable file exists before removing it 01/52101/2
Michael Stucki [Mon, 20 Mar 2017 13:04:43 +0000 (14:04 +0100)]
[BUGFIX] Check if install tool enable file exists before removing it

The is_file() check got lost during the refactoring in
d855b4707ba1198b6c1dbf856c4377e230da4c4b.

Change-Id: Ia1688099a7ccd32667562e8c7f83fd54bb669f4a
Resolves: #80354
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52101
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Escape dots of flexform field names 82/52082/2
Georg Ringer [Wed, 21 Dec 2016 11:47:06 +0000 (12:47 +0100)]
[BUGFIX] Escape dots of flexform field names

To make inline proper working in JS, the name of the field must be escaped
as it can contain dots.

Resolves: #78985
Releases: master, 7.6
Change-Id: I18c1d85906b9710c25b326b89e8104f3ea3c8a29
Reviewed-on: https://review.typo3.org/52082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Return to content element after un-/hide 55/52055/2
Josef Glatz [Wed, 15 Mar 2017 12:26:46 +0000 (13:26 +0100)]
[TASK] Return to content element after un-/hide

Add the current content element as section to the un-/hide link.

Releases: master, 7.6
Resolves: #80274
Change-Id: I0d6ec4ea8274f82f6d4c66a4e9e77860819d4d15
Reviewed-on: https://review.typo3.org/52055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Return to content element after closing 53/52053/2
Georg Ringer [Tue, 14 Mar 2017 13:28:30 +0000 (14:28 +0100)]
[TASK] Return to content element after closing

Add the current content element as section to the edit link.
Since #70074, the edit link in the header has been already
improved but other links have been missing.

Resolves: #80273
Releases: master, 7.6
Change-Id: Id7cc236819ccd3306d4638cb65e87aee011a35b3
Reviewed-on: https://review.typo3.org/52053
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Recordlist shows content of wrong folder 52/52052/2
Stefan Fruhen [Tue, 7 Mar 2017 13:21:03 +0000 (14:21 +0100)]
[BUGFIX] Recordlist shows content of wrong folder

Subfolder requires identifier when parent folder is expanded.

Resolves: #80166
Releases: master, 7.6
Change-Id: I5226f425951f9124dcaa3e9780b52354e266382d
Reviewed-on: https://review.typo3.org/52052
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Localize tt_content_defValues in new content element wizard 51/52051/2
Eric Chavaillaz [Mon, 30 Jan 2017 13:09:33 +0000 (14:09 +0100)]
[BUGFIX] Localize tt_content_defValues in new content element wizard

Resolves: #79551
Releases: master, 7.6
Change-Id: I76bf3996b3f76b18f9ff9cc95b70b2e41bbc4143
Reviewed-on: https://review.typo3.org/52051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not overwrite inlineData in mergeResult 50/52050/2
Helmut Hummel [Wed, 8 Mar 2017 20:54:49 +0000 (21:54 +0100)]
[BUGFIX] Do not overwrite inlineData in mergeResult

Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Releases: master, 7.6
Resolves: #80181
Change-Id: I56cef1c56a36d1760a99c239130c6791869a1978
Reviewed-on: https://review.typo3.org/52050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Missing max value for title in file reference TCA 47/52047/2
Torben Hansen [Fri, 3 Mar 2017 18:35:53 +0000 (19:35 +0100)]
[BUGFIX] Missing max value for title in file reference TCA

Add a max value of 255 chars for the field "title" and
increase size of field "alternative" in sys_file_reference to
the same size of "parent" field sys_file_metadata in db definition.

Resolves: #80122
Releases: master, 7.6
Change-Id: I9f1e4ef57fbd56e5d6a253409186e16a58c60e2b
Reviewed-on: https://review.typo3.org/52047
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] colPos_list gets respected in language view 44/52044/2
Tobias Kretschmann [Tue, 14 Mar 2017 13:55:23 +0000 (14:55 +0100)]
[BUGFIX] colPos_list gets respected in language view

mod.SHARED.colPos_list is now also respected in
Web > Page > Language View.

Since TYPO3 6.2 the setting was only respected in
Page > Columns View, but should also be taken
into account by the Language View as it is a
SHARED setting.

Releases: master, 7.6
Resolves: #80275
Change-Id: Ibdc90103208d5abbcfba1dbbfee3b87d045885f9
Reviewed-on: https://review.typo3.org/52044
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Bypass fetch of database record if already loaded 03/52003/5
Xavier Perseguers [Thu, 2 Mar 2017 14:51:38 +0000 (15:51 +0100)]
[TASK] Bypass fetch of database record if already loaded

Change-Id: I737f76e497ef4a9c2ce1439cfe09b0b1e75afd73
Resolves: #80100
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52003
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Make InvalidXmlFileException for language files more verbose 02/52002/2
Andreas Fernandez [Fri, 10 Mar 2017 11:14:45 +0000 (12:14 +0100)]
[TASK] Make InvalidXmlFileException for language files more verbose

The message of the InvalidXmlFileException, thrown when parsing broken
language files now always shows the last occured error in libxml with
the affected file and line.

Resolves: #80224
Releases: master, 7.6
Change-Id: I49949119db73f0c09d997a3e2cf45bf86a9587c8
Reviewed-on: https://review.typo3.org/52002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EM: Highlighting for insecure/outdated extensions 68/51968/2
Josef Glatz [Tue, 7 Mar 2017 07:22:18 +0000 (08:22 +0100)]
[BUGFIX] EM: Highlighting for insecure/outdated extensions

- Fix styles for extensions marked insecure or outdated
  within the TYPO3 extension manager list.
- Fix and update styles for the extension upload form.

Resolves: #80114
Releases: master, 7.6
Change-Id: If6b6fbf7331c292605c3e0b17aafbaea301825f7
Reviewed-on: https://review.typo3.org/51968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Respect TypoScript code after not matched include 67/51967/2
Helmut Hummel [Mon, 6 Mar 2017 11:30:46 +0000 (12:30 +0100)]
[BUGFIX] Respect TypoScript code after not matched include

When parsing TypoScript with <INCLUDE which has a condition,
following TypoScript code which is not in an <INCLUDE statement
will be discarded.

Before early returning from a non matched condition, this
code needs to be added.

Resolves: #80150
Releases: master, 7.6
Change-Id: I4ea839012c57e5e7945dde3705aa96839afc58a0
Reviewed-on: https://review.typo3.org/51967
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Incorrect usages of string as array in QueryGenerator 44/51944/2
Christer Vindberg [Wed, 1 Mar 2017 11:46:47 +0000 (12:46 +0100)]
[BUGFIX] Incorrect usages of string as array in QueryGenerator

Changed so an empty $queryConfig is always an array.

$queryConfig is declared as an array but can be used as an array or
string, therefore in PHP 7.1 an exception was thrown.

Resolves: #80075
Releases: master, 7.6
Change-Id: Ifd8b89e0ccce4f93a6c7bee5afe10bf52fa73634
Reviewed-on: https://review.typo3.org/51944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Felogin: Only wrap header/message if not empty 43/51943/2
Benni Mack [Fri, 3 Mar 2017 10:21:16 +0000 (11:21 +0100)]
[BUGFIX] Felogin: Only wrap header/message if not empty

When adding felogin template the wraps defined by default
of EXT:felogin are always outputted even though it just adds
an empty div/h3 tag around, which looks odd in most installations.

The patch adds a proper required tag to see if the value is actually not
empty.

Resolves: #80110
Releases: master, 7.6
Change-Id: Ia9e4c7d3dc294b30db3f10cdde96f95899aa18ef
Reviewed-on: https://review.typo3.org/51943
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Bind live search click event to search field container 30/51930/2
Andreas Fernandez [Thu, 2 Mar 2017 19:27:28 +0000 (20:27 +0100)]
[BUGFIX] Bind live search click event to search field container

To prevent issues with the click event of the live search which is also
triggered on any other dropdown menu of the topbar, the click event is now
bound to the container that holds the search field and the result list.

Change-Id: Ia5b459580fdc345c26d32fb0181e9005efa92c69
Resolves: #80099
Related: #79938
Releases: 7.6
Reviewed-on: https://review.typo3.org/51930
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid stripping tags for generating diffs 33/51933/2
Georg Ringer [Mon, 9 Jan 2017 18:16:10 +0000 (19:16 +0100)]
[BUGFIX] Avoid stripping tags for generating diffs

Tags must not be stripped away for creating diffs as
those are essential for editors. Otherwise it is not
possible to see changed links or changing a header from
h1 to h2.

Resolves: #78767
Resolves: #79205
Releases: master, 7.6
Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7
Reviewed-on: https://review.typo3.org/51933
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update autocomplete JS widget for BE 63/51763/10
Markus Klein [Mon, 20 Feb 2017 00:41:08 +0000 (01:41 +0100)]
[TASK] Update autocomplete JS widget for BE

Resolves: #79938
Releases: master, 7.6
Change-Id: I50e84f11595ea6e79280084bfbf94d75be646de1
Reviewed-on: https://review.typo3.org/51763
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Set file size to 0 instead to string in ImportExport 99/51899/2
Georg Ringer [Mon, 27 Feb 2017 19:28:55 +0000 (20:28 +0100)]
[BUGFIX] Set file size to 0 instead to string in ImportExport

To avoid errors with PHP 7.1 which is more strict regarding
strings and integers, the file size for soft refs must be
set to 0 instead of an empty string.

Resolves: #79644
Releases: master, 7.6
Change-Id: I246e5ac1599da50b97dac3bdb4fcc959af813ce9
Reviewed-on: https://review.typo3.org/51899
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Set TYPO3 version to 7.6.17-dev 95/51895/2
TYPO3 Release Team [Tue, 28 Feb 2017 10:43:54 +0000 (11:43 +0100)]
[TASK] Set TYPO3 version to 7.6.17-dev

Change-Id: I024470dc57502ab68a894bed56dec109325f5081
Reviewed-on: https://review.typo3.org/51895
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.16 94/51894/2 7.6.16 TYPO3_7-6-16
TYPO3 Release Team [Tue, 28 Feb 2017 10:42:32 +0000 (11:42 +0100)]
[RELEASE] Release of TYPO3 7.6.16

Change-Id: Id88f3ba69fb637beb3a0d8b1f70e49bbfb39040e
Reviewed-on: https://review.typo3.org/51894
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[SECURITY] Prevent possible XSS in Fluid templates 89/51889/2
Nicole Cordes [Tue, 28 Feb 2017 10:22:25 +0000 (11:22 +0100)]
[SECURITY] Prevent possible XSS in Fluid templates

This patch ensures proper encoding of the output of if-ViewHelpers when
using in inline notation.

The regular expression to find possibly affected usages is:
\{\s*f:if\s*\(.+,\s*(?:then|else):(?>\s*)[^']

Resolves: #79911
Releases: master, 7.6
Security-Commit: c187889fb52c6037abf9ffe033f65903c39f715a
Security-Bulletin: TYPO3-CORE-SA-2017-003
Change-Id: Ia509265b5ce9e0baecc62f33031789c08145df55
Reviewed-on: https://review.typo3.org/51889
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Multiple InlineCSS overrides each other 80/51780/5
Haco [Tue, 21 Feb 2017 12:01:09 +0000 (13:01 +0100)]
[BUGFIX] Multiple InlineCSS overrides each other

The 'Default CSS' (eg. from extensions) & 'Specific Page CSS'
(from TYPO3) can now be used together when "inlineStyle2TempFile = 0"
is set.

Resolves: #77534
Releases: master, 7.6
Change-Id: I22bb68938068a82691ce2132866ef191eac672fd
Reviewed-on: https://review.typo3.org/51780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EM: Add title attribute to showAllVersions links 71/51871/2
Josef Glatz [Mon, 27 Feb 2017 06:00:18 +0000 (07:00 +0100)]
[BUGFIX] EM: Add title attribute to showAllVersions links

Add meaningful title attributes to all links which leads to the
showAllVersions action.

Resolves: #80029
Releases: master, 7.6
Change-Id: I85b9ee21514fbffd84734c4149d67237abb19652
Reviewed-on: https://review.typo3.org/51871
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix parameter type in BackendModuleRequestHandler 68/51868/2
Benni Mack [Mon, 27 Feb 2017 05:37:18 +0000 (06:37 +0100)]
[BUGFIX] Fix parameter type in BackendModuleRequestHandler

The function
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
->getPagePermsClause accepts only an integer value as parameter,
but a boolean value is given in
TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule

Resolves: #79949
Releases: master, 7.6
Change-Id: I6d0e6049ce2f68f361853f5c5ea50984c9448347
Reviewed-on: https://review.typo3.org/51868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Prevent different constants marker in TS parsing 67/51867/2
Nicole Cordes [Tue, 4 Oct 2016 13:21:57 +0000 (15:21 +0200)]
[BUGFIX] Prevent different constants marker in TS parsing

Currently each time the TypoScript is parsed a new marker for constants,
which are replaces by their value, is generated. This prevents conditions
with replaced constants to be displayed as active. This patch ensures
markers are generated by constants values and therefore stay the same
in different requests.

Resolves: #78142
Related: #72413
Releases: master, 7.6
Change-Id: I4eea83908927ac48930abdd731e7412c04e529c1
Reviewed-on: https://review.typo3.org/51867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE 65/51865/2
Nicole Cordes [Mon, 12 Dec 2016 16:53:10 +0000 (17:53 +0100)]
[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE

The patch adds the current database row to the data passed to the select
field rendered by foreign_selector of IRRE.
This data is necessary to properly resolve the ###CURRENT_PID### marker
in a foreign_table_where clause.

Resolves: #78960
Releases: master, 7.6
Change-Id: I17f6b4a78d20c101ef7caab227d23c87f138e8ce
Reviewed-on: https://review.typo3.org/51865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Extbase: correct handling of mm relations 75/51775/6
Markus Klein [Mon, 20 Feb 2017 23:52:23 +0000 (00:52 +0100)]
[BUGFIX] Extbase: correct handling of mm relations

Resolves: #79931
Releases: 7.6
Change-Id: I5c3aa875e9a083836f29f6af69365d91b99904fa
Reviewed-on: https://review.typo3.org/51775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Add button to reload static database data of an extension 64/51864/2
Nicole Cordes [Fri, 13 Jan 2017 19:16:20 +0000 (20:16 +0100)]
[TASK] Add button to reload static database data of an extension

This patch re-adds the possibility to manually trigger a reload of
static database data an extension might ships. In the EM list view, an
inconspicuous button is added for each extension which has an own
ext_tables_static+adt.sql file. Furthermore the import is changed, so
that a md5 hash of the file content is stored in the database. If the
extension is updated and the content if the file changes, a more visible
button is shown to indicate an update should be considered.

Resolves: #60748
Releases: master, 7.6
Change-Id: I8ccb01d7e1f98a4adfc70a4d1aa80db4e76bbc9d
Reviewed-on: https://review.typo3.org/51864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Update TYPO3 Icons to v1.1.0 47/51847/2
Josef Glatz [Thu, 9 Feb 2017 18:23:40 +0000 (19:23 +0100)]
[TASK] Update TYPO3 Icons to v1.1.0

Update bower dependency. Add 22 new icons via bower
copy task and register them in the IconRegistry.

Resolves: #79715
Releases: master
Change-Id: I76fa9090e5a26bdea01afc52c3edba281bac2771
Reviewed-on: https://review.typo3.org/51847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent installing incompatible extensions without confirmation 63/51863/2
Nicole Cordes [Fri, 24 Feb 2017 15:32:09 +0000 (16:32 +0100)]
[BUGFIX] Prevent installing incompatible extensions without confirmation

Currently it is possible to install incompatible extensions without
confirming the overlay popup. This patch prevents submitting the
overlay if the button is still disabled.

Resolves: #80005
Releases: master, 7.6
Change-Id: Ia68539cb9ce2a82f1e90aef3823f60cfadee2ce1
Reviewed-on: https://review.typo3.org/51863
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix non-302 redirects for PSR-7 response objects 15/51815/2
Benjamin Franzke [Tue, 20 Dec 2016 06:26:42 +0000 (07:26 +0100)]
[BUGFIX] Fix non-302 redirects for PSR-7 response objects

All redirect status codes (e.g. 201,301,303,307) are incorrectly
sent as 302.

We need to set the response code before setting the Location header,
as a call to header('Location: ...'); sets the response code
implicitly to 302 (unless it has already been set to 201 or 3xx) [1].
By settings the status code/header first, header('Location: ..') will
not change the status code, if the PSR-7 response object contains a
proper redirect status code.

[1] http://php.net/manual/en/function.header.php
    The second special case is the "Location:" header.
    Not only does it send this header back to the browser, but it also
    returns a REDIRECT (302) status code to the browser unless the 201
    or a 3xx status code has already been set.

Change-Id: Ifa076e6393c6ed42d93959fe8c3a5b79cee145a4
Fixes: #79043
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] InvalidXmlFileException for invalid locallang.xml 57/51857/2
Sascha Egerer [Sun, 19 Feb 2017 20:34:53 +0000 (21:34 +0100)]
[BUGFIX] InvalidXmlFileException for invalid locallang.xml

Throw a meaningful InvalidXmlFileException when an invalid locallang.xml
file is detected.

Resolves: #79908
Releases: master, 7.6
Change-Id: Idc5586166d2475edeaeef407128525ea57fb9a09
Reviewed-on: https://review.typo3.org/51857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Correct handling of ObjectStorage objects in PaginateController 49/51849/2
Nicole Cordes [Mon, 30 Jan 2017 18:01:32 +0000 (19:01 +0100)]
[BUGFIX] Correct handling of ObjectStorage objects in PaginateController

The current implementation for getting paginated items from ObjectStorage
objects in TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController
enforces null items if the count of objects is lower than the
itemsPerPage count. This patch calculates the correct count and returns
valid items only.

Resolves: #79559
Releases: master, 7.6
Change-Id: I5746d83120474d6246da949f67096459ed1076d7
Reviewed-on: https://review.typo3.org/51849
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList 45/51845/3
Nicole Cordes [Mon, 13 Feb 2017 13:22:39 +0000 (14:22 +0100)]
[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList

Due to some security changes in GeneralUtility::validPathStr some
wrongly encoded files are now returned as invalid. This breaks e.g. the
file list.
This patch adds a try/catch block to ignore invalid files and return the
valid ones.

Resolves: #79776
Releases: master, 7.6, 6.2
Change-Id: Iaa3697b04c123bba61a426fdf39ee3959f68b705
Reviewed-on: https://review.typo3.org/51845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Fix append and prepend function of valuePicker 16/51816/2
Mona Muzaffar [Fri, 24 Feb 2017 08:09:58 +0000 (09:09 +0100)]
[BUGFIX] Fix append and prepend function of valuePicker

valuePicker appends and prepends now in the correct order.

Change-Id: Ic97b8a66469d43d9269f67f1de3f0cb40d1e8321
Resolves: #79937
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51816
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation 05/51805/2
Sascha Nowak [Mon, 2 Jan 2017 10:59:58 +0000 (11:59 +0100)]
[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation

In the current implementation it is not possible to create a new translations outside
of the default translation. So we can readd the new translation option when the record
has a default translation.

Change-Id: I89c4200ff847dadfdeec03b5f43a6577f40702e3
Resolves: #72797
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
(cherry picked from commit 00fa1cd5c876406952d655592b804f4333c42191)
Reviewed-on: https://review.typo3.org/51805

2 years ago[TASK] Include table name in TCA deprecation message for feInterface 89/51789/2
Xavier Perseguers [Wed, 22 Feb 2017 07:09:22 +0000 (08:09 +0100)]
[TASK] Include table name in TCA deprecation message for feInterface

Resolves: #79947
Releases: 7.6
Change-Id: I1caaa6d71070aeadc97b672660f280ef73727393
Reviewed-on: https://review.typo3.org/51789
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove ignored file from GIT index 58/51758/2
Markus Klein [Sun, 19 Feb 2017 18:17:26 +0000 (19:17 +0100)]
[CLEANUP] Remove ignored file from GIT index

The AcceptanceTester.php file is removed from GIT, as it is
listed in the .gitignore file.

Resolves: #79905
Releases: 7.6
Change-Id: I45f6d0b400a4da3a3c72587a087c40d13f5ad508
Reviewed-on: https://review.typo3.org/51758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix localization guard for "pages_language_overlay" 28/51728/2
Mathias Brodala [Thu, 16 Feb 2017 15:42:39 +0000 (16:42 +0100)]
[BUGFIX] Fix localization guard for "pages_language_overlay"

Resolves: #79859
Related: #78191
Releases: master, 7.6
Change-Id: Ia2a3ed9b1a793c1be554f73fa99362e3015313df
Reviewed-on: https://review.typo3.org/51728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] UriBuilder: Do not skip empty parameters 18/51718/2
Markus Klein [Wed, 15 Feb 2017 15:55:41 +0000 (16:55 +0100)]
[BUGFIX] UriBuilder: Do not skip empty parameters

This is not the job of the uri builder to decide this.
It must simply build an URL from all given parameters.

In general, empty parameters can be intended by a dev.

Resolves: #79835
Releases: master, 7.6
Change-Id: I0ec3e7c41a78b40ecd81e52381f1d744a1e65608
Reviewed-on: https://review.typo3.org/51718
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Update file list module access in backend groups and users 83/50983/4
Nicole Cordes [Thu, 15 Dec 2016 23:53:09 +0000 (00:53 +0100)]
[TASK] Update file list module access in backend groups and users

As the file list module was renamed, backend groups and users access
lists need adjustments. This patch updates the module name and
removes the non-existing "file" module from those lists.

Resolves: #78979
Releases: master, 7.6
Change-Id: I06bd10523399f38e2a0ec6fdf5740cbfea6dd509
Reviewed-on: https://review.typo3.org/50983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop() 94/51694/2
Andreas Fernandez [Wed, 8 Feb 2017 16:52:25 +0000 (17:52 +0100)]
[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop()

PHP’s `array_pop()` requires its argument being passed as reference,
but the result of `array_keys()` is directly used.
The result of `array_keys()` is now stored into a variable which gets
passed to `array_pop()`.

Resolves: #79686
Releases: master, 7.6
Change-Id: Icda3040abefbffad64e93acf0d7ae632ccee00bf
Reviewed-on: https://review.typo3.org/51694
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Truncate long GIFBUILDER file names 75/51675/2
Thoams Oliver Moll [Fri, 13 Jan 2017 14:05:50 +0000 (15:05 +0100)]
[BUGFIX] Truncate long GIFBUILDER file names

GIFBUILDER generates file names from serialized data from
the GIFBUILDER setup (typoscript).
This can result in too long file names when the GIFBUILDER
is called with many parameters and on filesystems with
a max filename/path length.

The comment of the function fileName() states that the filename
should be shortened to 100 chars, but this doesn't happen.

This patch introduces a simple substring to enforce this limit.

Change-Id: Iaa17760bbf34fc6c01a9bc5ea8d1f8b6b242fecb
Resolves: #79301
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51675
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix broken svg flag 67/51667/2
Josef Glatz [Mon, 13 Feb 2017 22:13:15 +0000 (23:13 +0100)]
[BUGFIX] Fix broken svg flag

The vietnam svg flag is somewhat garbled. The external lib "region-flags"
isn't broken. It seems as if it was mutilated while adding it to the core
last time.

The broken svg icon is fixed by a re-run of `grunt svgmin` task.

Resolves: #79793
Releases: master, 7.6
Change-Id: Ic1337a1a7037fa95d739937571a1a4ed381e1dae
Reviewed-on: https://review.typo3.org/51667
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Allow customData in FormEngine data compiler 34/51634/2
Andreas Fernandez [Sat, 11 Feb 2017 13:42:09 +0000 (14:42 +0100)]
[TASK] Allow customData in FormEngine data compiler

FormEngine is a two-fold process: First all dependent data is
compiled into main "data array" by data providers, then the render
engine uses this array to render forms.

The main data array is restricted, top level keys can not be added
or removed by single data providers.

With the recent refactorings on element level, it is now much easier
to create powerful extensions to single elements. Those may need
additional data, the rest of the FormEngine doesn't know about.

To allow custom data providers adding data that is not related
to other keys from the data array, a general "customData" is
introduced to the array. This is not filled nor used by core
related classes, but it can be used by extensions to park data here.

For v9, we will probably see another patch giving the form data groups
control about the data array structure, but that may follow later.
For v8 and v7, allowing custom data should solve the one or
the other data provider usage for now.

Change-Id: I8e88ec8f9e55eed7fc4a58590cbb5ead19baaae3
Resolves: #79747
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Show record title for inline element 26/51626/2
Nicole Cordes [Wed, 4 Jan 2017 14:06:38 +0000 (15:06 +0100)]
[BUGFIX] Show record title for inline element

Currently no record titles for nested inline elements are shown. Due to
the current method to resolve a record title for an inline element
always an empty title is returned as there is the same processing as for
select fields. This patch introduces an own resolving method according to
the already resolved children attached to the current field.

Resolves: #78726
Releases: master, 7.6
Change-Id: I7f62ad843552534b36c0ccd91488c79ff796ec0c
Reviewed-on: https://review.typo3.org/51626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix JS errors in context menu 62/51262/3
Tymoteusz Motylewski [Thu, 9 Feb 2017 11:28:39 +0000 (12:28 +0100)]
[BUGFIX] Fix JS errors in context menu

Fixes two issues: syntax error (missing semicolon),
and "Uncaught TypeError: Cannot read property 'refresh' of undefined"
when e.g. deleting a page or a file.

In file module, refresh is not needed as all actions are refreshing
the frames anyway.

Releases: master, 7.6
Resolves: #79091
Change-Id: Icfc9f786c24099c55d8e60cf30f72f035ae28231
Reviewed-on: https://review.typo3.org/51262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer 67/51567/2
Wouter Wolters [Mon, 6 Feb 2017 11:57:43 +0000 (12:57 +0100)]
[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer

Status codes are only returned when running in dry-run mode.

Resolves: #79641
Releases: master,7.6
Change-Id: I3ca770d3f8c0af5aba5793cd4155722b8b68298c
Reviewed-on: https://review.typo3.org/51567
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Show warning label for linkhandler if no label is defined 58/51558/2
Markus Klein [Fri, 3 Feb 2017 21:25:33 +0000 (22:25 +0100)]
[BUGFIX] Show warning label for linkhandler if no label is defined

If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a hint
that the configuration is evaluated correctly.

Resolves: #79621
Releases: master, 7.6
Change-Id: Ib00a86be339908408c4e31eedb3c8ea57468fa87
Reviewed-on: https://review.typo3.org/51558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Wrong position of init 50/51550/2
Stefan Froemken [Wed, 18 Jan 2017 14:48:00 +0000 (15:48 +0100)]
[BUGFIX] Wrong position of init

As storeIncomingData depends on some data,
which is generated in init, the init method
has to be called before.

Resolves: #79374
Releases: master, 7.6
Change-Id: I55e9f1317db83205b3a9ad0105eb8b493203ced7
Reviewed-on: https://review.typo3.org/51550
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Limit primary key length on be_session and fe_session table 39/51539/5
Christian Kuhn [Sat, 4 Feb 2017 12:44:51 +0000 (13:44 +0100)]
[BUGFIX] Limit primary key length on be_session and fe_session table

Patch for issue #79566 increased the field length of ses_name in
fe_session and be_session table from 32 to 255.
This field is used together with ses_id as primary key.
With utf8, this now exceeds maximum key length of 757 bytes.
To fix the issue, ses_name is cut down to 100 for the time being,
the patch should be fine for master and 7.6 this way.

Change-Id: I06abecca0f8df483590cf0a3c193134083e8f5f1
Resolves: #79628
Related: #79566
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51539
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix missing variable initialization in AbstractTreeView 28/51528/4
Markus Klein [Fri, 3 Feb 2017 20:42:34 +0000 (21:42 +0100)]
[TASK] Fix missing variable initialization in AbstractTreeView

https://review.typo3.org/49750 introduced code that lacks
proper variable initialization.
Get this straight.

Resolves: #79620
Releases: master, 7.6
Change-Id: I1b5735807f7f0fc476a5370f23d6b7d4654e4599
Reviewed-on: https://review.typo3.org/51528
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow long cookie names 05/51505/2
Marco Huber [Tue, 31 Jan 2017 10:29:36 +0000 (11:29 +0100)]
[BUGFIX] Allow long cookie names

With this patch cookie names longer than 32 chars are possible.

Resolves: #79566
Releases: master, 7.6
Change-Id: I5132defab6e7524ed4aaf48ea29e44da40aee516
Reviewed-on: https://review.typo3.org/51505
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Clear search field in Install Tool with ESC 86/51486/2
Georg Ringer [Tue, 31 Jan 2017 10:33:30 +0000 (11:33 +0100)]
[TASK] Clear search field in Install Tool with ESC

As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on the
ESC key to clear the search again.

Resolves: #79567
Releases: master, 7.6
Change-Id: I9a304bb455153429f99354a4ef684326b1baa612
Reviewed-on: https://review.typo3.org/51486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[CLEANUP] Simplify updating of timestamp in writeForeignField 54/51454/2
Thomas Hohn [Thu, 15 Dec 2016 10:45:22 +0000 (11:45 +0100)]
[CLEANUP] Simplify updating of timestamp in writeForeignField

There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both a call to getRecord and a loop through fields,
casting and checking each field value comparing to DB.

Change-Id: Ic807030c5cea83d36e543ed0f75cf980c3872d1e
Releases: master, 7.6
Resolves: #79004
Reviewed-on: https://review.typo3.org/51454
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Change EM composer mode message to info level 50/51450/2
Benjamin Franzke [Thu, 29 Dec 2016 12:10:17 +0000 (13:10 +0100)]
[BUGFIX] Change EM composer mode message to info level

As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer mode message
should no longer be a warning but an info.

Releases: master, 7.6
Fixes: #79107
Change-Id: Ic9fcb134c113172de504833ed81f7a46a0ba4e2c
Reviewed-on: https://review.typo3.org/51450
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Persist traversable domain objects via identifier 46/51446/2
Mathias Brodala [Thu, 12 Jan 2017 13:03:04 +0000 (14:03 +0100)]
[BUGFIX] Persist traversable domain objects via identifier

Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implement the
Traversable interface.

Change-Id: Iccb53d6e7ded9b6b5300e111e8503641b10615f4
Resolves: #79294
Related: #57255
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51446
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Only perform reindex if data has indeed changed 45/51445/2
Thomas Hohn [Tue, 13 Dec 2016 20:46:38 +0000 (21:46 +0100)]
[BUGFIX] Only perform reindex if data has indeed changed

Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add .php_cs.cache to .gitignore 44/51444/2
Georg Ringer [Thu, 26 Jan 2017 20:24:52 +0000 (21:24 +0100)]
[TASK] Add .php_cs.cache to .gitignore

The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.

Resolves: #79510
Releases: master, 7.6
Change-Id: Ia85f825416ad767a07d280de35a18c318e1a5133
Reviewed-on: https://review.typo3.org/51444
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup code of LocalizationController::process 36/51436/2
Manuel Selbach [Wed, 18 Jan 2017 20:12:16 +0000 (21:12 +0100)]
[TASK] Cleanup code of LocalizationController::process

Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://review.typo3.org/51436
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Adjust Cs-Fixer 2.0 hits 33/51433/3
Anja Leichsenring [Wed, 25 Jan 2017 21:23:39 +0000 (22:23 +0100)]
[TASK] Adjust Cs-Fixer 2.0 hits

With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
applying those suggested changes.

Change-Id: I1326b698da1a9615729733d8408b583d150de284
Resolves: #79469
Relates: #79361
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51433
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update php-cs-fixer to version 2.0 32/51432/4
Anja Leichsenring [Wed, 25 Jan 2017 20:49:57 +0000 (21:49 +0100)]
[TASK] Update php-cs-fixer to version 2.0

Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Debugger output: split lines before escaping them 35/51435/2
Markus Klein [Fri, 20 Jan 2017 09:16:29 +0000 (10:16 +0100)]
[BUGFIX] Debugger output: split lines before escaping them

This fixes the issue that lines are wrapped within a HTML entity.

Resolves: #79398
Releases: master, 7.6
Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002
Reviewed-on: https://review.typo3.org/51435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Render metatags on uncached pages 03/51403/2
Daniel Dorndorf [Thu, 5 Jan 2017 10:11:11 +0000 (11:11 +0100)]
[BUGFIX] Render metatags on uncached pages

Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to adding any
entries with the 'render-preProcess' hook.

Resolves: #79162
Releases: master, 7.6
Change-Id: I2142a5c91fcb0840993d9235caa1e883bbb0c2b4
Reviewed-on: https://review.typo3.org/51403
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix broken links to permission module 01/51401/2
Frank Naegler [Mon, 16 Jan 2017 17:37:05 +0000 (18:37 +0100)]
[BUGFIX] Fix broken links to permission module

This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring:
http://review.typo3.org/33402

Resolves: #79329
Related: #62339
Releases: master, 7.6
Change-Id: Iafe66352a7bac593e249ef09c07f1c9dc9b15359
Reviewed-on: https://review.typo3.org/51401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] FormEngine: Do not add <br> to readonly textarea content 90/51390/2
Markus Klein [Fri, 20 Jan 2017 14:57:12 +0000 (15:57 +0100)]
[BUGFIX] FormEngine: Do not add <br> to readonly textarea content

Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.

Resolves: #79399
Releases: master, 7.6
Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7
Reviewed-on: https://review.typo3.org/51390
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use official TYPO3.Icon repository 78/51378/2
Benjamin Kott [Sat, 21 Jan 2017 11:04:52 +0000 (12:04 +0100)]
[TASK] Use official TYPO3.Icon repository

The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/TYPO3/TYPO3.Icons

Resolves: #79404
Releases: master, 7.6
Change-Id: I9c4a78bbf52f681d61e69f2e7245fb1c2cac561f
Reviewed-on: https://review.typo3.org/51378
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1 71/51371/2
Sascha Egerer [Fri, 13 Jan 2017 09:00:16 +0000 (10:00 +0100)]
[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1

The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Since PHP 7.1 there is
a different handling of invalid array usage. If a variable is
accessed as an array but is not an array the value of that variable
becomes a string 'A'.

PHP 7
php > $config = '';
php > $config['foo'] = 'bar';
php > print_r($config)
Array
(
    [foo] => bar
)

PHP 7.1
php > $config = '';
php > $config['foo'] = 'bar';
> Warning: Illegal string offset 'foo' in php shell code on line 1
php > print_r($config)
A

Related PHP "Bug" (It's not a bug, it's a feature)
https://bugs.php.net/bug.php?id=73081

Change-Id: I6d5b75ed60f0506ecacdead01a318fdc26757394
Resolves: #79052
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51302
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
(cherry picked from commit f39c2f1c0fcf92c8c4923f9a4e77cc0631834fd5)
Reviewed-on: https://review.typo3.org/51371

2 years ago[BUGFIX] Restrict l10n fallback to cms extension 48/51348/4
Philipp Gampe [Wed, 18 Jan 2017 15:53:20 +0000 (16:53 +0100)]
[BUGFIX] Restrict l10n fallback to cms extension

The check for the l10n fallback for the cms extension was too wide, also
covering arbitrary extension names starting with "cms".

Restrict the check to "cms/" now.

Resolves: #79377
Releases: 7.6
Change-Id: Idb07d4499fe0b75a0027e58a0d421c377054624f
Reviewed-on: https://review.typo3.org/51348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Use reflection information in getGettablePropertyNames 61/51361/3
Nicole Cordes [Wed, 12 Oct 2016 15:55:27 +0000 (17:55 +0200)]
[BUGFIX] Use reflection information in getGettablePropertyNames

In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Currently all get/is/has
methods are joined as they can be fetch from Extbase as well. But for
those methods it is necessary to respect their arguments as Extbase
calls those functions without any argument.
This can trigger PHP warnings.

The patch uses a class reflection to get public properties and inspect
the method arguments. Only those functions without arguments or only
optional arguments are considered as valid property name.

Resolves: #78270
Releases: master, 7.6
Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d
Reviewed-on: https://review.typo3.org/51361
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Fix minor typo in DateTimePicker.js 47/51347/2
Wouter Wolters [Wed, 18 Jan 2017 15:25:19 +0000 (16:25 +0100)]
[BUGFIX] Fix minor typo in DateTimePicker.js

Heven't replaced with haven't

Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332602e
Reviewed-on: https://review.typo3.org/51347
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Make persistent connections available for Redis cache backend 12/51312/3
Kasper Ligaard [Thu, 15 Dec 2016 13:59:26 +0000 (14:59 +0100)]
[BUGFIX] Make persistent connections available for Redis cache backend

The Redis cache backend allows configuration of all connection
setting, except setting persistent connections. This omission
is fixed by this patch. Being unable to use persistent connections
under high load can hurt performance in cloud setups. Persistent
connections has been part of phpredis since 2010 and thus is
broadly available, but is impossible to use with TYPO3.

Resolves: #79005
Releases: master, 7.6
Change-Id: Ie5476e894072bb9979691f28bc7a1e10e86ef454
Reviewed-on: https://review.typo3.org/51312
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years agoRevert "[BUGFIX] Skip main extension repository check in Composer mode" 81/51281/2
Nicole Cordes [Thu, 12 Jan 2017 09:08:51 +0000 (10:08 +0100)]
Revert "[BUGFIX] Skip main extension repository check in Composer mode"

This reverts commit e538ed3f154f447ddbaf78785a31c9ab2ee72a17.

We do need the information about the main repository status as there is
currently no other possibility to get information about the (security)
status of extension besides the TER itself.

Resolves: #79285
Related: #79277
Releases: master, 7.6
Change-Id: Ia769dc95eaeff405f291d5929b7790a50c332a83
Reviewed-on: https://review.typo3.org/51281
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Skip main extension repository check in Composer mode 79/51279/2
Mathias Brodala [Wed, 11 Jan 2017 14:41:36 +0000 (15:41 +0100)]
[BUGFIX] Skip main extension repository check in Composer mode

Extensions are not installed and updated from the main extension
repository in Composer mode, thus skip this check completely.

Change-Id: If5bad978ed7eae92954198f9569a90effc123525
Resolves: #79277
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51279
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Filelist: Info dialog shows image dimensions 75/51275/3
Michael Oehlhof [Wed, 28 Dec 2016 08:03:36 +0000 (09:03 +0100)]
[TASK] Filelist: Info dialog shows image dimensions

The file info modal now contains the width and height of images

Resolves: #65822
Releases: master, 7.6
Change-Id: Iadb64ae3db4558bf74f15aaeac1fe29848120563
Reviewed-on: https://review.typo3.org/51275
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] ResourceCompressor does not persist external resources 74/51274/2
Benni Mack [Wed, 11 Jan 2017 17:05:50 +0000 (18:05 +0100)]
[BUGFIX] ResourceCompressor does not persist external resources

The condition in the ResourceCompressor for fetching
external files never worked, as it was a simple typo
to update an external resource.

So the first time the local file did not exist (and thus, the md5
did not match) and the file was fetched but due to the
wrong check, the file never got updated.

Resolves: #79269
Releases: master, 7.6
Change-Id: If6942284ccd46f400e23d199e827d4e7a696961d
Reviewed-on: https://review.typo3.org/51274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments 69/51269/2
Oliver Hader [Wed, 11 Jan 2017 14:17:12 +0000 (15:17 +0100)]
[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments

ADMCMD arguments are not filtered when calculating the cache-hash
which results in a page not found error. The behavior can be
triggered by creating and opening a preview link in the workspace
module which implicitly sets ADMCMD_previewWS during runtime.

Resolves: #79275
Releases: master, 7.6, 6.2
Change-Id: I339c2787e7de1adf47bb1322c91e0a78c476f790
Reviewed-on: https://review.typo3.org/51269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use POST for storing uc-related Storage in BE 63/51263/2
Benni Mack [Wed, 11 Jan 2017 01:14:08 +0000 (02:14 +0100)]
[BUGFIX] Use POST for storing uc-related Storage in BE

The AJAX call to store uc settings should be handled
as POST request, and not a GET request to ensure that
even long data can be stored on the server and not
run in Firewall/HTTP GET length restrictions.

Additionally a really bad typo did not allow any
POST requests in UserSettingsController as the key
evaluation was wrong.

Resolves: #79266
Releases: master, 7.6
Change-Id: I0fd10090416b1a16f6a9bdc6a07efceccf147336
Reviewed-on: https://review.typo3.org/51263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Correct declaration of $rL_uidRegister 74/50974/5
Kasper Ligaard [Thu, 15 Dec 2016 12:30:42 +0000 (13:30 +0100)]
[BUGFIX] Correct declaration of $rL_uidRegister

$rL_uidRegister was declared as a string but was
used as an array therefore in PHP 7.1 an exception was
thrown.

This is a delayed backport of https://review.typo3.org/48799/.

Resolves: #79001
Related: #76934
Releases: 7.6
Change-Id: Ia0285bb60b6f0f9c5ccde732cce33505c195eb0a
Reviewed-on: https://review.typo3.org/50974
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>