Packages/TYPO3.CMS.git
14 months ago[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls 49/57249/3
Wouter Wolters [Sun, 17 Jun 2018 15:01:21 +0000 (17:01 +0200)]
[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls

Resolves: #85293
Releases: master
Change-Id: Ifabbb20c1ef4ad482df676fe9999dcbdf18eb704
Reviewed-on: https://review.typo3.org/57249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Setting BE-debug appends fieldnames to labels 99/57499/2
Stefan Neufeind [Sun, 8 Jul 2018 07:41:26 +0000 (09:41 +0200)]
[TASK] Setting BE-debug appends fieldnames to labels

The description so far says fieldnames are prepended.

Resolves: #85507
Releases: master
Change-Id: I06fccdc2aee70a95e64cb14adccba0e24a22c1cb
Reviewed-on: https://review.typo3.org/57499
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Deprecate TypoScriptFrontendController->getUniqueId 97/57597/4
Benni Mack [Fri, 13 Jul 2018 20:26:45 +0000 (22:26 +0200)]
[TASK] Deprecate TypoScriptFrontendController->getUniqueId

The unused method TypoScriptFrontendController->getUniqueId() is marked
as deprecated, as this method conceptually should go into a custom
service with a singleton pattern or a runtime cache, but not within
TypoScriptFrontendController.

Resolves: #85555
Releases: master
Change-Id: Ib3af4b32e3c03d90b832ee725dcf9846af92f9ba
Reviewed-on: https://review.typo3.org/57597
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Extract request processing from ShortcutToolbarItem 31/56331/24
Mathias Brodala [Sat, 17 Mar 2018 17:16:47 +0000 (18:16 +0100)]
[TASK] Extract request processing from ShortcutToolbarItem

Change-Id: I9f396da2084880b3dd813c8d7f0777c36ac989d9
Resolves: #84414
Releases: master
Reviewed-on: https://review.typo3.org/56331
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
14 months ago[BUGFIX] Fix apc/apcu cache backend tests 21/57621/4
Christian Kuhn [Tue, 17 Jul 2018 20:52:52 +0000 (22:52 +0200)]
[BUGFIX] Fix apc/apcu cache backend tests

bamboo php 7.2 has apc & apcu support again. Two
unit tests fail. These two however don't make much
sense in the first place since they md5(internal-knowledge).
Remove them.

Resolves: #85584
Releases: master
Change-Id: I5f1e1589189866508e684a7ca1bb6cae87d22fad
Reviewed-on: https://review.typo3.org/57621
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Bamboo proper passwd mapping 18/57618/3
Christian Kuhn [Tue, 17 Jul 2018 17:08:48 +0000 (19:08 +0200)]
[TASK] Bamboo proper passwd mapping

The bamboo containers need a better passwd mapping
per agent to set a proper home directory, otherwise
ssh tasks may fail.

Resolves: #85582
Releases: master, 8.7, 7.6
Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c
Reviewed-on: https://review.typo3.org/57618
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Test rendering of translated select MM relations in Extbase 74/57474/6
Tymoteusz Motylewski [Mon, 16 Jul 2018 11:41:40 +0000 (13:41 +0200)]
[TASK] Test rendering of translated select MM relations in Extbase

It's based on tt_content and categories.

Releases: master, 8.7
Resolves: #85493
Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599
Reviewed-on: https://review.typo3.org/57474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] Also add doctrine/lexer to typo3/cms-core 03/57603/3
Markus Klein [Sat, 14 Jul 2018 20:57:29 +0000 (22:57 +0200)]
[BUGFIX] Also add doctrine/lexer to typo3/cms-core

Resolves: #85552
Releases: master, 8.7
Change-Id: I1056a5825fd79df4c495894970721713b10728cd
Reviewed-on: https://review.typo3.org/57603
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[TASK] Turn redis cache backend unit into functional tests 07/57607/4
Christian Kuhn [Mon, 16 Jul 2018 00:08:31 +0000 (02:08 +0200)]
[TASK] Turn redis cache backend unit into functional tests

Our unit tests should not rely on running daemons, there is
a functional test environment to take care of this. The patch
turns redis cache backend unit tests into funcitional tests
and adapts the unit test setup to no longer start dependencies.

Resolves: #85565
Releases: master
Change-Id: I8d81209ed339d35af11bb06fb7cb191845b6b587
Reviewed-on: https://review.typo3.org/57607
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Run tests on new bamboo infrastructure 22/57522/50
Christian Kuhn [Mon, 9 Jul 2018 22:41:03 +0000 (00:41 +0200)]
[TASK] Run tests on new bamboo infrastructure

A new bamboo agent infrastructure has been deployed that
significantly changes how tests are executed: The agent
docker containers are now "stupid" and no longer bundle
specific php versions or daemons. Instead, they can run
own containers to start needed daemons for specific jobs
and execute needed php commands in ad-hoc containers that
provide the required php version.
Daemons needed for single jobs are defined in a
docker-compose.yml file provided by core itself.
This docker-compose.yml file can not be used directly for
local test execution since it has to fiddle quite a bit
with docker volume mounts, networks and executing users
that is specific to the bamboo environment.
However, another yml file can be added later to ease local
test execution in a similar way.
The patch rewrites the bamboo plan pre-merge and nightly
specs of core master to use the new infrastructure and brings
a couple of minor changes to tests that rely on a running
memcached or redis to retrieve the daemon host from an
environment variable.
There will be separated patche for older core versions.

Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af
Resolves: #85563
Resolves: #36934
Releases: master
Reviewed-on: https://review.typo3.org/57522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Use same line endings in test as in function 01/57501/3
Jigal van Hemert [Sun, 8 Jul 2018 09:42:58 +0000 (11:42 +0200)]
[BUGFIX] Use same line endings in test as in function

In CommandTest::testGetDescription() now also LF is used as line ending,
just as in the tested function.

Resolves: #85509
Releases: master, 8.7
Change-Id: I907e24b19d87d94a3fb1b3cbee9947d68358e5cc
Reviewed-on: https://review.typo3.org/57501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] Use static constant call for PageRepository 99/57599/2
Benni Mack [Fri, 13 Jul 2018 21:44:20 +0000 (23:44 +0200)]
[TASK] Use static constant call for PageRepository

Minor fix to use the static constant directly, like in all other usages.

Resolves: #85559
Releases: master
Change-Id: I163bea97ddd78b6f37945daaf7aecaab6c47bdff
Reviewed-on: https://review.typo3.org/57599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[BUGFIX] Require doctrine/lexer to get removed lexer classes 89/57589/4
Andreas Fernandez [Fri, 13 Jul 2018 18:15:30 +0000 (20:15 +0200)]
[BUGFIX] Require doctrine/lexer to get removed lexer classes

With the release of doctrine/dbal in version 2.8, the class
`Doctrine\Common\Lexer` got removed. To circumvent this issue, the
package `doctrine/lexer` will be used.

Used composer command:

    composer require doctrine/lexer:^1.0

Resolves: #85552
Releases: master, 8.7
Change-Id: I5dd007c3b95be42dfd3305f750606ae4fcabedf2
Reviewed-on: https://review.typo3.org/57589
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir 87/57587/3
Oliver Hader [Fri, 13 Jul 2018 14:45:43 +0000 (16:45 +0200)]
[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Resolves: #85547
Releases: master, 8.7, 7.6
Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930
Reviewed-on: https://review.typo3.org/57587
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Add LanguageAspect to Contexts 24/57424/24
Benni Mack [Sun, 1 Jul 2018 12:46:04 +0000 (14:46 +0200)]
[TASK] Add LanguageAspect to Contexts

This change adds a new Aspect called "Language" which bundles
most existing TypoScript options on frontend language fetching.
A factory allows to migrate the logic from TSFE.

Major / Important Changes:
- RootlineUtility is decoupled from PageRepository
- TSFE->sys_language_mode is not necessary anymore
- TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect
- A new PageRepository->getLanguageOverlay() bundles all other methods
- A lot of common public properties in TSFE are now deprecated

Next steps:
- Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE
- Migrate PageRepository "-1" parameters to "null"
- Migrate usages PageRepository->getRootline() to RootlineUtility::__construct()
- Then deprecate PageRepository->getRootLine()
- Migrate Extbase QuerySettings to Contexts

Resolves: #85543
Releases: master
Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20
Reviewed-on: https://review.typo3.org/57424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Move verbosity settings into TemplateService 81/57581/4
Benni Mack [Thu, 12 Jul 2018 18:13:45 +0000 (20:13 +0200)]
[TASK] Move verbosity settings into TemplateService

The constructor of TemplateService now has
a context, which knows everything to define
public settings to define if tt_track and verbose
should be set.

Resolves: #85542
Releases: master
Change-Id: I11306a57c64e8c5cb0d0a069b73e06f066b72d8e
Reviewed-on: https://review.typo3.org/57581
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[FEATURE] Add context check for TypoScript 88/57588/3
Benni Mack [Fri, 13 Jul 2018 14:46:09 +0000 (16:46 +0200)]
[FEATURE] Add context check for TypoScript

The new Context API is added so TypoScript
can check this in cObject like this:

10 = TEXT
10.data = context:workspace:id

where as the key is context:[aspectName]:[propertyName]

Arrays are automatically converted to comma-separated lists,
which is useful for reading info on user groups.

Resolves: #85550
Releases: master
Change-Id: I86673055e088ec4e65288df6145399f8e45055c8
Reviewed-on: https://review.typo3.org/57588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Add Content-Type to test mail plain part 36/57536/2
Mathias Brodala [Thu, 12 Jul 2018 07:53:55 +0000 (09:53 +0200)]
[BUGFIX] Add Content-Type to test mail plain part

Resolves: #85536
Releases: master, 8.7
Change-Id: Ie1f5c97af1a315eb5b8d7bf4bc7a31872362750d
Reviewed-on: https://review.typo3.org/57536
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] LanguagePackCommand: Hide progress output by default 30/57530/10
Josef Glatz [Wed, 11 Jul 2018 08:54:23 +0000 (10:54 +0200)]
[BUGFIX] LanguagePackCommand: Hide progress output by default

Show progress bar only if verbosity level is set. The default output
of this command is disabled by default to limit the amount of e-mails
sent by the TYPO3 scheduler (which normally makes only sense, if any
error occurs).

You can activate the output if you set the verbosity while calling the
command ("-v" option).

Resolves: #85533
Releases: master
Change-Id: I6f95559cc1228afd66192f7382e81f9ae91c0ed8
Reviewed-on: https://review.typo3.org/57530
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Remove post-autoload-dump section from composer.json 37/57537/7
Anja [Thu, 12 Jul 2018 08:23:09 +0000 (10:23 +0200)]
[TASK] Remove post-autoload-dump section from composer.json

The included task in not subject to be executed upon each
`composer install`.

Resolves: #85537
Related: #83249
Releases: master, 8.7
Change-Id: I12240cbd7ea571b1872effd6942a3bd65bf37a89
Reviewed-on: https://review.typo3.org/57537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fix test isolation and pre-requisites 70/57570/5
Susanne Moog [Thu, 12 Jul 2018 10:37:06 +0000 (12:37 +0200)]
[BUGFIX] Fix test isolation and pre-requisites

FormDefinitionValidationServiceTest modified the encryption key in
test data-provider functions. Those functions are executed prior to
actually executing the tests and causes side-effects during running
the test suite.

Resolves: #85539
Releases: master, 9.3, 8.7
Change-Id: I9fbd60905eb37470fa3661225b681476ff9df3c3
Reviewed-on: https://review.typo3.org/57570
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Fix CGL issues 65/57565/2
Oliver Hader [Thu, 12 Jul 2018 09:58:10 +0000 (11:58 +0200)]
[TASK] Fix CGL issues

Resolves: #.....
Releases: master, 8.7
Change-Id: Iace5c4d064182c628e9d3b03876c73e19dd725cd
Reviewed-on: https://review.typo3.org/57565
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY][TASK] Remove support for native PHP yaml extension 63/57563/2
Oliver Hader [Thu, 12 Jul 2018 09:36:39 +0000 (11:36 +0200)]
[SECURITY][TASK] Remove support for native PHP yaml extension

Resolves: #85424
Releases: master, 8.7
Security-Commit: 82619eb231e725d77fb8196f0b6bfca9f722bc4f
Security-Bulletin: TYPO3-CORE-SA-2018-004
Change-Id: Ic104c79ebfc1daff0b05b0f5531345b5bf7ce74b
Reviewed-on: https://review.typo3.org/57563
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Filter disallowed properties in form editor 62/57562/2
Ralf Zimmermann [Thu, 12 Jul 2018 09:36:23 +0000 (11:36 +0200)]
[SECURITY] Filter disallowed properties in form editor

The form editor save and preview actions now check the submitted
form definition against configured possibilities within the form
editor setup.

Releases: master, 8.7
Resolves: #85044
Security-Commit: f4a1a09378ed286f3744d6a72f09bfa11a6ba87e
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: Ibf6083ab98b9fe73effe217380f555892c9c6bb0
Reviewed-on: https://review.typo3.org/57562
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[!!!][SECURITY] Deny direct FAL commands for form definitions 61/57561/2
Susanne Moog [Thu, 12 Jul 2018 09:36:05 +0000 (11:36 +0200)]
[!!!][SECURITY] Deny direct FAL commands for form definitions

Before this change, form definitions have been persisted in regular
`.yaml` files. In order to make the meaning and purpose of those
files more explicit, the new file ending `.form.yaml` is introduced.

Invocations of the file abstraction layer API for those form files
have to be allowed explicitly by granting commands individually using
`FilePersistenceSlot::allowInvocation`.

New form definitions are created with the new file ending per default.
An upgrade wizard renames existing form definitions that are stored in
according storage folders (`allowedFileMounts`). In addition references
in FlexForm of content elements are adjusted to the new file names as
well - in case a form definition has been referenced before.

The file list user interface disabled according direct actions for
`.form.yaml` files or redirects those to the according form module.

Using just `.yaml` instead of `.form.yaml` from site packages
is deprecated. Using just `.yaml` instead of `.form.yaml` from
file storages is not allowed anymore.

Resolves: #84910
Releases: master, 8.7
Security-Commit: 444f9dc4f1902871391bd1f139d19b46a63a162f
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: I456c03f745e614729cdbf2915efc6b5e6d11fc0f
Reviewed-on: https://review.typo3.org/57561
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Explicitly deny object deserialization 60/57560/2
Oliver Hader [Thu, 12 Jul 2018 09:35:49 +0000 (11:35 +0200)]
[SECURITY] Explicitly deny object deserialization

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: f4d645d131fabc98cbbdcefcffb951040d2dd246
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Ia138f22856c7dd754e373803af799273868c622b
Reviewed-on: https://review.typo3.org/57560
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Mitigate phar stream wrapper 59/57559/2
Christian Kuhn [Thu, 12 Jul 2018 09:35:37 +0000 (11:35 +0200)]
[SECURITY] Mitigate phar stream wrapper

SoftReferenceIndex throws exceptions on phar streams
LegacyLinkNotationConverter throws exceptions on phar streams

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: 4fde9d6a2333435af9033f55e9a5e2d428f6ea0d
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I69333fff4d94dc7369ba729333a39e8be5dda7a3
Reviewed-on: https://review.typo3.org/57559
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Introduce PHP stream wrapper for phar:// protocol 58/57558/2
Oliver Hader [Thu, 12 Jul 2018 09:35:24 +0000 (11:35 +0200)]
[SECURITY] Introduce PHP stream wrapper for phar:// protocol

This custom stream wrapper for the phar:// protocol overrides
PHP's native handling. In case Phar bundles shall be loaded from
a valid directory, the custom wrapper falls back to the native PHP
wrapper in order to invoke Phar-related actions.

In case the location is not trustworthy, an according exception
is thrown. The custom stream wrapper is registered in the beginning
of TYPO3's bootstrap class.

Truested locations are those in typo3conf/ext/* - anything else is
denied and not considered as trustworthy.

Releases: master, 8.7, 7.6
Resolves: #85385
Security-Commit: efa085d9a5aebfac6b92309ea53c455b95a81fcc
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Ifd38eab7a5757e6cfbd6f773a3fed8f3d742e09d
Reviewed-on: https://review.typo3.org/57558
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[SECURITY] Deny authentication bypass using blowfish/md5 encryption 57/57557/2
Oliver Hader [Thu, 12 Jul 2018 09:35:12 +0000 (11:35 +0200)]
[SECURITY] Deny authentication bypass using blowfish/md5 encryption

Using password hashing methods that are related by class inheritance
can lead to authentication bypass by just knowing a valid username.

Resolves: #84703
Releases: master, 8.7, 7.6
Security-Commit: 2951c4fc0529ec0fd6047786edd3b7189428e574
Security-Bulletin: TYPO3-CORE-SA-2018-001
Change-Id: I859a20c85305291e1cd79b61e630bbbfc4e0568a
Reviewed-on: https://review.typo3.org/57557
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Streamline usage of Logging 15/57515/2
Benni Mack [Mon, 9 Jul 2018 12:33:42 +0000 (14:33 +0200)]
[TASK] Streamline usage of Logging

The Logger can be used with the LoggerAwareInterface+Trait combination
and was fogot for FAL related areas.

The LocalImageProcessor and FileProcessingService did not have any usage
of the logger, thus, they were removed.

Additionally, one should reference against the interfaces, not the implementation
classes directly.

Resolves: #85519
Releases: master
Change-Id: Ie381b1fc9a7007e76ea1c487fa9b1bda4a793bc0
Reviewed-on: https://review.typo3.org/57515
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Simplify setting BE/warning_mode 00/57500/2
Stefan Neufeind [Sun, 8 Jul 2018 09:06:02 +0000 (11:06 +0200)]
[TASK] Simplify setting BE/warning_mode

The setting used bits 1 and 2. But useful values were only 0/1/2.
So this setting can be simplified.

Resolves: #85508
Releases: master
Change-Id: Ib78174035bcefdec7658f37dae9071062dcb52c1
Reviewed-on: https://review.typo3.org/57500
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[FEATURE] Introduce conditional variants for form elements 82/54982/64
Ralf Zimmermann [Fri, 8 Dec 2017 08:03:38 +0000 (09:03 +0100)]
[FEATURE] Introduce conditional variants for form elements

Variants allow you to change properties of a form element.

Variants can contain conditions. If a concrete condition
is TRUE the variant is applied. If no condition exists the
variant will be ignored.

Variants make it possible to manipulate form element values,
validator options, and finisher options based on conditions.
This allows you among other things:

* translation of form element values depending on the frontend
  language
* set and remove validators of one form element depending on the
  value of another form element
* hide entire pages depending on the value of a form element
* set finisher values depending on the value of a form element
* hiding a form element in certain finishers and on the
  summary page

This feature implements variants for the frontend rendering and
the ability to define variants in the formDefinition. The
implementation to define variants in the form editor is out of
scope of this patchset.

Releases: master
Resolves: #84133
Change-Id: I9efeeea5af67df2d2f9252339c26baf8a03cf9c8
Reviewed-on: https://review.typo3.org/54982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Simplify and clean up error log system information 13/57513/2
Helmut Hummel [Mon, 9 Jul 2018 10:59:06 +0000 (12:59 +0200)]
[TASK] Simplify and clean up error log system information

Remove inheritance from abstract log module

Inheritance was used only to be able to get the time
from which to start to look for errors. This however never
really worked, because the constraint only had a startTimestamp
value set, if the user selected a custom time frame when viewing the log.

Therefore we can just assume errors have not been seen, unless
they are confirmed through the system information toolbar.

Resolves: #85517
Releases: master
Change-Id: Id6aa21fbbe0c56baeb19633aba0f9f7ff6215c0e
Reviewed-on: https://review.typo3.org/57513
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
15 months ago[BUGFIX] Use real HTTP status code as default for redirects 10/57510/6
Michael Giek [Mon, 9 Jul 2018 08:52:53 +0000 (10:52 +0200)]
[BUGFIX] Use real HTTP status code as default for redirects

TCA defines default status code as 307, which seems
like a good default. However the SQL definition should
match this definition to avoid any invalid redirect
status codes.

Releases: master
Resolves: #85513
Related: #85488
Change-Id: I972d83bd782592c77b6606cd6f7d6a1fc82d2414
Reviewed-on: https://review.typo3.org/57510
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Remove superfluous Doctrine restriction check 12/57512/4
Benni Mack [Mon, 9 Jul 2018 10:37:39 +0000 (12:37 +0200)]
[BUGFIX] Remove superfluous Doctrine restriction check

Similar to https://review.typo3.org/#/c/57434/
the check for TSFE->showHiddenRecords is unneeded
as the RestrictionContainer evaluates this information
(now done via aspects) directly anyway.

Resolves: #85516
Releases: master
Change-Id: Icc88b1995fe603f3707c9a83e83bf03ff549422e
Reviewed-on: https://review.typo3.org/57512
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Bring back the maintenance information message 06/56706/7
Frank Naegler [Tue, 17 Apr 2018 10:09:17 +0000 (12:09 +0200)]
[BUGFIX] Bring back the maintenance information message

In case the adminOnly flag is set, an information window is shown.
The middleware now creates a valid JSON response to show
the information window again.

Resolves: #84765
Releases: master
Change-Id: Ibe36b9d2c06b730bb2687d528d011268af4da660
Reviewed-on: https://review.typo3.org/56706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Scheduler: Show correct description for ipAnonymization-task 07/57507/3
Stefan Neufeind [Mon, 9 Jul 2018 08:15:13 +0000 (10:15 +0200)]
[BUGFIX] Scheduler: Show correct description for ipAnonymization-task

Resolves: #85512
Releases: master, 8.7, 7.6
Change-Id: I4077fe7481063feb97014048580c3fb1b1ca5e2a
Reviewed-on: https://review.typo3.org/57507
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Use ServerRequestInterface in SchedulerModuleController 64/56264/18
Łukasz Uznański [Fri, 16 Mar 2018 22:17:10 +0000 (23:17 +0100)]
[TASK] Use ServerRequestInterface in SchedulerModuleController

* replace usages of _GP, getIndpEnv
* add return hints

Resolves: #84387
Releases: master
Change-Id: I156f9005c132ab91abfbd72b97084ede6708d0dc
Reviewed-on: https://review.typo3.org/56264
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Refactor acceptance tests 61/57461/17
Davert [Wed, 4 Jul 2018 15:02:15 +0000 (18:02 +0300)]
[TASK] Refactor acceptance tests

typo3/testing-framework got a major release:
composer update typo3/testing-framework ^4.0

* codeception acceptance tests now live in a proper php namespace
* merged installation suites yml files into one
* installer tests are now one suite with different environment settings
* aligned with changes in typo3/testing-framework
* renamed Acceptance test suite to Backend test suite
* removed Admin/Editor steps, replaced with useExistingLogin('role')

Resolves: #85472
Releases: master
Change-Id: Ia049b43f5f9f645dddb509bde557ad83a7ac9023
Reviewed-on: https://review.typo3.org/57461
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Document loginSecurityLevel change when removing rsaauth 82/57482/4
moger-xx [Fri, 6 Jul 2018 13:49:09 +0000 (15:49 +0200)]
[TASK] Document loginSecurityLevel change when removing rsaauth

Releases: master
Resolves: #85500
Change-Id: I060e27a52a2a840dca2fd65db0e206f73dc5c8f9
Reviewed-on: https://review.typo3.org/57482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Re-add .panel-collapsed for caret handling 95/57495/2
Andreas Fernandez [Fri, 6 Jul 2018 20:38:19 +0000 (22:38 +0200)]
[BUGFIX] Re-add .panel-collapsed for caret handling

Resolves: #85505
Releases: master
Change-Id: I73315ce0c958cccbce401875b13514b7dae58f27
Reviewed-on: https://review.typo3.org/57495
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Set „scanned“ flag when scanning all extensions 94/57494/2
Andreas Fernandez [Fri, 6 Jul 2018 20:33:15 +0000 (22:33 +0200)]
[BUGFIX] Set „scanned“ flag when scanning all extensions

Resolves: #85504
Releases: master
Change-Id: I75580fb05c0217b1c28a2109b7f6bc2147d458d8
Reviewed-on: https://review.typo3.org/57494
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Use str_replace instead of strtr to improve readability and clarity purposes 65/57465/3
Wouter Wolters [Wed, 4 Jul 2018 18:08:27 +0000 (20:08 +0200)]
[TASK] Use str_replace instead of strtr to improve readability and clarity purposes

Resolves: #85476
Releases: master
Change-Id: I879bb7546e7e7ca0d46e8d682eb739f76df61b01
Reviewed-on: https://review.typo3.org/57465
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Scan extension by clicking panel 93/57493/3
Andreas Fernandez [Fri, 6 Jul 2018 19:41:48 +0000 (21:41 +0200)]
[BUGFIX] Scan extension by clicking panel

The extension scanner now scans an extension by opening its
panel again.

Resolves: #85440
Releases: master
Change-Id: I7b72f8c658d200c5c4d4ca90f7d6b55828c33efd
Reviewed-on: https://review.typo3.org/57493
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Fix orientiation of carets in panels 92/57492/2
Andreas Fernandez [Fri, 6 Jul 2018 19:08:39 +0000 (21:08 +0200)]
[BUGFIX] Fix orientiation of carets in panels

The styling of the caret was only applied, if it is a child of
`.panel-collapsed`, which is no official Bootstrap markup.

The CSS is now changed to rotate the caret icon with the correct
markup, too. This fixes the issue in the System Maintenance Area
that the caret rotation is broken.

Resolves: #85503
Releases: master
Change-Id: I095b7339c3ae8d86e6642fb1953d3bff2b042bfb
Reviewed-on: https://review.typo3.org/57492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Replace misused in_array calls 63/57463/4
Wouter Wolters [Wed, 4 Jul 2018 17:55:09 +0000 (19:55 +0200)]
[TASK] Replace misused in_array calls

Resolves: #85474
Releases: master
Change-Id: I62b1fe0b5ea3e1b5340aa18c216c7491d2d64fad
Reviewed-on: https://review.typo3.org/57463
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Check for exceptions instead of number of affected rows 58/57358/2
Georg Ringer [Sun, 24 Jun 2018 16:22:30 +0000 (18:22 +0200)]
[BUGFIX] Check for exceptions instead of number of affected rows

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Resolves: #85366
Releases: master, 8.7
Change-Id: I474e16478cb09ad4940aaab5fe1d3eb21498c4c4
Reviewed-on: https://review.typo3.org/57358
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Migrate EXT:backend LoginRefresh to TypeScript 75/57475/7
Frank Naegler [Thu, 5 Jul 2018 11:25:09 +0000 (13:25 +0200)]
[TASK] Migrate EXT:backend LoginRefresh to TypeScript

Resolves: #82595
Releases: master
Change-Id: Iebec35d3f1be6b70e3976a04c9820c9277a845e3
Reviewed-on: https://review.typo3.org/57475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Convert date objects to string in SaveToDatabase finisher 05/57205/6
Ralf Zimmermann [Tue, 12 Jun 2018 16:57:56 +0000 (18:57 +0200)]
[BUGFIX] Convert date objects to string in SaveToDatabase finisher

The SaveToDatabase now converts DateTime(Immutable) objects to strings
to make it possible to save values from "Date" or "DatePicker" form elements
into the database.

Resolves: #85246
Releases: master, 8.7
Change-Id: I1533252d462d08bf7b743884d4e8e5fab12f6423
Reviewed-on: https://review.typo3.org/57205
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Lidia Demin <typecat@gmx.net>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl 79/57479/5
Markus Klein [Thu, 5 Jul 2018 20:26:14 +0000 (22:26 +0200)]
[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl

When fetching only headers from an URL there is no need
to download the whole content.
This was overlooked when migrating the core to use Guzzle.

Resolves: #85491
Releases: master, 8.7
Change-Id: I6475b405d51135372e022b5e133368f15a917687
Reviewed-on: https://review.typo3.org/57479
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Migrate LayoutModule/DragDrop.js to TypeScript 81/56281/8
Andreas Wolf [Sat, 17 Mar 2018 10:01:47 +0000 (11:01 +0100)]
[TASK] Migrate LayoutModule/DragDrop.js to TypeScript

Change-Id: If29efc14acf4155ac820dfbd966fd7cdc8003fe2
Resolves: #84168
Releases: master
Reviewed-on: https://review.typo3.org/56281
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Code cleanup in /frontend/Tests/Unit/ContentObject/ 81/57481/6
Jan Helke [Fri, 6 Jul 2018 12:41:08 +0000 (14:41 +0200)]
[TASK] Code cleanup in /frontend/Tests/Unit/ContentObject/

This patch is just groundwork for upcomming "make test xxx notice free"
patches.

Resolves: #85497
Related: #84456
Releases: master
Change-Id: Ib4517cbccadced40e828ded0f76115f00abb5530
Reviewed-on: https://review.typo3.org/57481
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jord de Jong <jord.dejong@windinternet.nl>
Tested-by: Jord de Jong <jord.dejong@windinternet.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Use in_array instead of array_search 69/57469/2
Wouter Wolters [Wed, 4 Jul 2018 19:04:04 +0000 (21:04 +0200)]
[TASK] Use in_array instead of array_search

Resolves: #85480
Releases: master
Change-Id: I0c666be36a30add9742fdba33d8211daf839fcf9
Reviewed-on: https://review.typo3.org/57469
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Streamline templates in System Maintenance Area 54/57454/9
Andreas Fernandez [Tue, 3 Jul 2018 07:40:35 +0000 (09:40 +0200)]
[TASK] Streamline templates in System Maintenance Area

- Introduce proper `<html>` tag
- Use callouts instead of alerts
- Deleted obsolete template files
- Streamline handling of inline vs. modal
- Fix CSS for nested panels, if parent is `flat`

Resolves: #85463
Releases: master
Change-Id: Ide545367d2153da5c170eda1e69397005bb8ed58
Reviewed-on: https://review.typo3.org/57454
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jord de Jong <jord.dejong@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[TASK] Add various Composer scripts 59/54959/44
Mathias Brodala [Thu, 7 Dec 2017 11:05:07 +0000 (12:05 +0100)]
[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

    composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

    composer t:p:u

Also arbitrary arguments can be passed to the executed command:

    composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54959
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Tested-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[TASK] Use secure deserialization in extension manager 58/57458/3
Oliver Hader [Tue, 3 Jul 2018 14:16:19 +0000 (16:16 +0200)]
[TASK] Use secure deserialization in extension manager

In order to harden the deserialization of scalar and array values
in extension manager unserialize() calls are hardened further to
disallow object reconstitution. The information is retrieved from
the TYPO3 extension repository (TER) where according countermeasures
are in place to protect object injections - that's why this change
is considered as hardening and not as security issue.

Resolves: #85466
Releases: master, 8.7
Change-Id: I65b61d61e08d0c50b27ae9102d7ba4c4518a8788
Reviewed-on: https://review.typo3.org/57458
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Fix double slashes in RequireJS config of install tool 70/57470/2
Benni Mack [Wed, 4 Jul 2018 19:37:39 +0000 (21:37 +0200)]
[BUGFIX] Fix double slashes in RequireJS config of install tool

RequireJS configs do not have a slash at the end of the path.

The Debug Console shows that files are loaded with double
slashes in the install tool, so they should be avoided.

Resolves: #85481
Releases: master
Change-Id: I80326d176c6dbd54847f1c188d312da1c5e55078
Reviewed-on: https://review.typo3.org/57470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example 62/57462/3
Daniel Siepmann [Wed, 4 Jul 2018 15:26:25 +0000 (17:26 +0200)]
[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example

Releases: master, 8.7, 7.6
Resolves: #85473
Change-Id: Ic0ac284bb8f02c7275e17bde67e79bb20a7fd919
Reviewed-on: https://review.typo3.org/57462
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fixing login logo height in IE 20/57320/3
Roberto Presedo [Fri, 22 Jun 2018 21:41:16 +0000 (23:41 +0200)]
[BUGFIX] Fixing login logo height in IE

Resolves: #78592
Releases: master, 8.7
Change-Id: Ia7b3a25f6af61fce5376a68c1188c9564d603a23
Reviewed-on: https://review.typo3.org/57320
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Robert Vierke <robert.vierke+typo3@gmail.com>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Update complete database after extension installation 29/57429/11
Nicole Cordes [Sun, 1 Jul 2018 14:54:19 +0000 (16:54 +0200)]
[BUGFIX] Update complete database after extension installation

If an extension and its dependencies get installed, the whole
database needs to be updated instead of executing each extensions
SQL on its own.

Resolves: #79094
Releases: master, 8.7
Change-Id: I9a870e0efb6af241eeae563adbaa14af100edaec
Reviewed-on: https://review.typo3.org/57429
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Stabilize acceptance tests 60/57460/2
Christian Kuhn [Wed, 4 Jul 2018 14:22:37 +0000 (16:22 +0200)]
[TASK] Stabilize acceptance tests

This is one patch in the 'stabilize acceptance tests'
again mission. It changes various details in the Cest files.
At the same time changes within typo3/testing-framework
and the bamboo test execution are prepared, the version
bumps for those will follow with single patches later.

Resolves: #85470
Releases: master
Change-Id: I6ebe2499337e075f818b2726886ed02d743bb144
Reviewed-on: https://review.typo3.org/57460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Bodnarchuk <davert.ua@gmail.com>
Tested-by: Michael Bodnarchuk <davert.ua@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Improve custom CE explanation in FSC 53/57453/4
Mathias Brodala [Tue, 3 Jul 2018 07:26:53 +0000 (09:26 +0200)]
[TASK] Improve custom CE explanation in FSC

Resolves: #85459
Releases: master, 8.7
Change-Id: I1732782fa920ffa0f7bfd42016a45ac6437bff0a
Reviewed-on: https://review.typo3.org/57453
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Tested-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Fix „templates“ of Extension scanner 56/57456/2
Andreas Fernandez [Tue, 3 Jul 2018 11:36:28 +0000 (13:36 +0200)]
[BUGFIX] Fix „templates“ of Extension scanner

Due to a wrong change on the template container, the extension scanner
broke. This change recovers the functionality.

Resolves: #85464
Related: #85455
Releases: master
Change-Id: I3c62e89c59f0424e5381b485f7a11319a303296c
Reviewed-on: https://review.typo3.org/57456
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Fix „templates“ of Upgrade Wizards 55/57455/2
Andreas Fernandez [Tue, 3 Jul 2018 07:45:37 +0000 (09:45 +0200)]
[BUGFIX] Fix „templates“ of Upgrade Wizards

Due to a wrong change on the template container, the upgrade wizards
broke. This change recovers the functionality.

Resolves: #85460
Related: #85455
Releases: master
Change-Id: Iac97a9fac50fb7d7df60f163ba334d0f0012f1aa
Reviewed-on: https://review.typo3.org/57455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Store System Maintenance tokens in data attributes 51/57451/3
Andreas Fernandez [Mon, 2 Jul 2018 14:42:23 +0000 (16:42 +0200)]
[TASK] Store System Maintenance tokens in data attributes

The tokens used in the System Maintenance area are stored in hidden
`<div>` elements, which is syntactically wrong and considered bad
practice.
Instead, the tokens are now stored in data attributes.

Resolves: #85455
Releases: master
Change-Id: I3a3be24897caa56c20355f0d36c7e7c4ae702640
Reviewed-on: https://review.typo3.org/57451
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Use correct type for getSections $mode parameter comment 84/57384/2
Tymoteusz Motylewski [Tue, 26 Jun 2018 20:40:12 +0000 (22:40 +0200)]
[BUGFIX] Use correct type for getSections $mode parameter comment

Resolves: #85399
Releases: master
Change-Id: I981886a920a0229fcb2f9fbb12ff7c914c563fb6
Reviewed-on: https://review.typo3.org/57384
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Synchronize .rst files between core versions 49/57449/2
Christian Kuhn [Mon, 2 Jul 2018 13:14:53 +0000 (15:14 +0200)]
[TASK] Synchronize .rst files between core versions

Resolve some minor differences between v8 and master
according to Changelog/Howto.rst. v7 is ok.

Resolves: #85454
Releases: master, 8.7
Change-Id: I07aba0283b09a5f0c2a2b4336cae4df17bbb46af
Reviewed-on: https://review.typo3.org/57449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Deprecate ContentObjectRenderer->calcIntExplode() 38/57438/5
Benni Mack [Mon, 2 Jul 2018 10:04:31 +0000 (12:04 +0200)]
[TASK] Deprecate ContentObjectRenderer->calcIntExplode()

The method ContentObjectRenderer->calcIntExplode() is only used
within GraphicalMenuObject and can be migrated into the method call.

Resolves: #85451
Releases: master
Change-Id: Ia463fa8698d63a0aaa9a1810da6660d53e670f73
Reviewed-on: https://review.typo3.org/57438
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
15 months ago[BUGFIX] Display documentation changelog files with same issue number 09/57409/4
Anja [Thu, 28 Jun 2018 16:45:33 +0000 (18:45 +0200)]
[BUGFIX] Display documentation changelog files with same issue number

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Change-Id: I3aef23b3bbc0d63486b1f75c38a54648991633b5
Resolves: #85420
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57409
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Streamline initialization of PageRepository 31/57431/5
Benni Mack [Sun, 1 Jul 2018 15:24:21 +0000 (17:24 +0200)]
[TASK] Streamline initialization of PageRepository

PageRepository ($TSFE->sys_page) has an init() function, which sets
some public properties, but is also called from the constructor.

However, there is the ominous $TSFE->setSysPageWhereClause()
which can only be set once the frontend user groups have been resolved.

In order to achieve that, the usergroup initialization within TSFE has
been moved before the intantiation of $TSFE->sys_page, allowing the
pagerepository constructor to set the variables directly, moving all
of the initialization code into PageRepository itself.

Resolves: #85450
Releases: master
Change-Id: I53dbdc0531076a47bcdf04617bfb1eae70e74279
Reviewed-on: https://review.typo3.org/57431
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Make search field in install tool document viewer clearable 12/57412/2
Anja [Thu, 28 Jun 2018 18:29:42 +0000 (20:29 +0200)]
[TASK] Make search field in install tool document viewer clearable

The clear button comes in handy after every performed search to
empty the search input field without need for several keystrokes
or the need to mark all chars and press the backspace key.

Change-Id: Ica0242934664c6639ade99a3fc52de1b043d3ed3
Resolves: #85421
Releases: master
Reviewed-on: https://review.typo3.org/57412
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christoph Pascher <c.pascher@browserwerk.de>
Tested-by: Christoph Pascher <c.pascher@browserwerk.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Decouple TemplateService->getFileName 03/57403/10
Benni Mack [Thu, 28 Jun 2018 07:22:46 +0000 (09:22 +0200)]
[TASK] Decouple TemplateService->getFileName

TemplateService in TYPO3 frontend is responsible for
fetching sys_template records and sorting TypoScript
related things out, but also contains one method,
which is nowadays completely separate from
sys_template: "getFileName".

This method checks for valid syntax and returns
a proper string then (resolves "EXT:... syntax"
and valdiates against available paths).

The logic is frontend-related, thus moved
to EXT:frontend/FilePathSanitizer.

The old functionality in TemplateService is
deprecated, along with the public property "fileCache".

Resolves: #85445
Releases: master
Change-Id: Id52ef476d0cd6a67de2560a0e427339b7310427e
Reviewed-on: https://review.typo3.org/57403
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Adapt glitches of context patch 36/57436/3
Christian Kuhn [Mon, 2 Jul 2018 08:54:28 +0000 (10:54 +0200)]
[BUGFIX] Adapt glitches of context patch

Some type hinting related and test changes from the main
context patch are fixed with the patch.

Resolves: #85447
Related: #85389
Releases: master
Change-Id: I674fd1cc253929643361a71ad7c5084d4429ddc5
Reviewed-on: https://review.typo3.org/57436
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
15 months ago[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again 87/57387/2
Frédéric Lebel [Wed, 27 Jun 2018 02:57:49 +0000 (02:57 +0000)]
[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again

Fix the link browser to not drop the CSS-Class value with multiple classes
if editing the same link.

Resolves: #85182
Releases: master, 8.7
Change-Id: Id7819f25c6a456c379de406816e44d7d1d76157e
Reviewed-on: https://review.typo3.org/57387
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Remove unused Doctrine restriction 34/57434/2
Benni Mack [Sun, 1 Jul 2018 18:13:56 +0000 (20:13 +0200)]
[BUGFIX] Remove unused Doctrine restriction

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Resolves: #85446
Releases: master, 8.7
Change-Id: Ib9dd0aa0197ee7d8379110a8067c31eba2ff73e8
Reviewed-on: https://review.typo3.org/57434
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Migrate Extbase Typo3DbBackend to Context API 01/57401/5
Benni Mack [Thu, 28 Jun 2018 05:27:39 +0000 (07:27 +0200)]
[TASK] Migrate Extbase Typo3DbBackend to Context API

Due to the introduction of Contexts, it is now possible
for Extbase to use the global context and to modify
it to set up a new instance of "PageRepository"
with just a context initialized. This way,
dependencies to $BE_USER and $TSFE->sys_page
are removed.

In further steps, the method should actually just work
with the context object which should be handed in,
however, some more work regarding language handling
has to be implemented first.

Resolves: #85413
Releases: master
Change-Id: If657d25943d92a69a754a29c22461d43b97c4095
Reviewed-on: https://review.typo3.org/57401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Fix regressions and leftovers in Context API 96/57396/12
Benni Mack [Wed, 27 Jun 2018 13:31:53 +0000 (15:31 +0200)]
[BUGFIX] Fix regressions and leftovers in Context API

Some usages where now-deprecated properties are used,
have been adjusted.

The RST file has been enhanced to clarify when to clone
the context, and when to override an aspect.

Additionally, the usage within TemplateService has been
optimized to also receive an optional context object,
similar to the initial patch's PageRepository approach.

Resolves: #85408
Related: #85389
Releases: master
Change-Id: I178ff07cbfe999a90bf7d5dd4f20a6170876d003
Reviewed-on: https://review.typo3.org/57396
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Streamline FAL pre-emit signals for createFile and setContent 18/57418/2
Oliver Hader [Fri, 29 Jun 2018 13:02:29 +0000 (15:02 +0200)]
[TASK] Streamline FAL pre-emit signals for createFile and setContent

In order to streamline the FAL API the following signals have been added.
The according post-processing signals have been available already before:

+ ResourceStorageInterface::SIGNAL_PreFileCreate
+ ResourceStorageInterface::SIGNAL_PreFileSetContents

Resolves: #85434
Releases: master, 8.7
Change-Id: I41fc07afbc4e1a393c8a26fe02f431a7b62015d8
Reviewed-on: https://review.typo3.org/57418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
15 months ago[BUGFIX] Adjust Headline of documentation file 10/57410/4
Anja [Thu, 28 Jun 2018 17:20:43 +0000 (19:20 +0200)]
[BUGFIX] Adjust Headline of documentation file

With the correct delimiter, the category feature for the documentation
file can be properly retrieved and does not get sorted into its
own, exclusive category.

Change-Id: I228c46377190c3d1bd0eb5459df8d63975a6895b
Resolves: #85422
Reselases: master, 8.7
Reviewed-on: https://review.typo3.org/57410
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer 41/57341/9
Daniel Goerz [Sat, 23 Jun 2018 12:45:01 +0000 (14:45 +0200)]
[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Resolves: #85362
Releases: master, 8.7
Change-Id: I00bfc9d7e3bbf97d8a68fbf825a6cf3dd8b2d3aa
Reviewed-on: https://review.typo3.org/57341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Ensure extension icon exists before calling ImageInfo 93/57393/2
Nicole Cordes [Wed, 27 Jun 2018 10:07:39 +0000 (12:07 +0200)]
[BUGFIX] Ensure extension icon exists before calling ImageInfo

As the extension icon is not required, this patch prevents warnings
that are triggered because no image size can be fetched.

Resolves: #85363
Releases: master, 8.7
Change-Id: I4c98fbaed385b2f269e940b8531c45e948ab8d36
Reviewed-on: https://review.typo3.org/57393
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
15 months ago[TASK] Migrate "GFX/processor_effects" to boolean 91/57391/5
Mathias Brodala [Wed, 27 Jun 2018 07:27:30 +0000 (09:27 +0200)]
[TASK] Migrate "GFX/processor_effects" to boolean

Ensure "GFX/processor_effects" is a true boolean as suggested in
the settings module and silently migrate integer/string values
accordingly.

Resolves: #83591
Releases: master
Change-Id: I006e907e75e273009333363a4d42661183ba8721
Reviewed-on: https://review.typo3.org/57391
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Separate icon and text in inline record control buttons 04/57404/2
Mathias Brodala [Thu, 28 Jun 2018 09:47:17 +0000 (11:47 +0200)]
[BUGFIX] Separate icon and text in inline record control buttons

Resolves: #85415
Releases: master, 8.7
Change-Id: I5cee4230bb415dcb3d7dfcd0aae7614489cec7eb
Reviewed-on: https://review.typo3.org/57404
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Drop usages of PATH_typo3, PATH_typo3conf 42/57242/11
Christian Kuhn [Fri, 15 Jun 2018 20:06:42 +0000 (22:06 +0200)]
[TASK] Drop usages of PATH_typo3, PATH_typo3conf

After PATH_site usages have been dropped, this patch drops
the other path related constants PATH_typo3 and PATH_typo3conf.

Next steps (out of scope for this patch):
- Make typo3conf/l10n/ flexible (= var/labels)
- Move PackageStates and autoload/autoload-tests into typo3conf/ext/typo3/
- Analyze usages of "typo3conf" and "typo3/sysext" strings currently hardcoded

Change-Id: I4f0ca5dfab363fd3c14d030592318b9659721ecb
Resolves: #85286
Releases: master
Reviewed-on: https://review.typo3.org/57242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Do not cache results of LiveSearch 98/57398/2
Andreas Fernandez [Wed, 27 Jun 2018 16:50:13 +0000 (18:50 +0200)]
[TASK] Do not cache results of LiveSearch

Resolves: #85412
Releases: master, 8.7
Change-Id: I7cac1b53f9cc7c7fa3c6c9e1752b7b2513d39c5d
Reviewed-on: https://review.typo3.org/57398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Add Error Codes to Page Failure Reasons 01/57201/8
Benni Mack [Tue, 12 Jun 2018 12:23:01 +0000 (14:23 +0200)]
[TASK] Add Error Codes to Page Failure Reasons

A new class with constants is added to make the TYPO3 internal errors
why a page cannot be displayed in the frontend more speakable.

Resolves: #17794
Releases: master
Change-Id: I8b9999e95f109666a524ee9157f89f498b21ca6d
Reviewed-on: https://review.typo3.org/57201
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[FEATURE] Add Contexts for storing data access modes 04/57104/21
Benni Mack [Thu, 21 Jun 2018 20:23:58 +0000 (22:23 +0200)]
[FEATURE] Add Contexts for storing data access modes

A new "Context" concept is added which allows to keep
the state of common TYPO3 Request Data in form of
so-called Aspects.

An aspect contains properties which can be fetched,
but only the ones that are really necessary, instead of
exposing a full object (e.g. BE_USER).

The main goal is to centralize some global variables
distributed in various places.

In the first step the following variables are considered:

- $TSFE->showHiddenPages
- $TSFE->showHiddenRecords
- $TSFE->beUserLogin
- $TSFE->gr_list
- $TSFE->loginUser
- $GLOBALS[SIM_EXEC_TIME]
- $GLOBALS['BE_USER']->workspace

For now the Context is a singleton object, but should
be fetched from a DI container.

Sometimes a custom context is necessary, so it is
cloned (see usage in TSFE).

The difference to the PSR-7 request attributes is that the
context is ONLY related to data access (like permissions / visibility)
and also independent if TYPO3 is running via HTTP or CLI
(thus, can be used in CLI mode as well).

Next Steps:
- Migrate PageRepository->versioningWorkspaceId
- Migrate TSFE->simUserGroup
- Use DateTimeAspect everywhere
- Introduce Language + Page Aspects
- Introduce the context object into ContentObjectRenderer and cObjects
- Use Contexts in RestrictionContainers
- Use Contexts in TYPO3 Backend
- Decouple sys_page behaviour from TSFE where applicable
- Ensure TypoScript conditions continue to work / have a documented alternative

Resolves: #85389
Releases: master
Change-Id: I9e27e581a1632fcd8c3c6a9e0954b76b91f42c52
Reviewed-on: https://review.typo3.org/57104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Tested-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[!!!][TASK] Drop "documentation" extension 85/57385/7
Christian Kuhn [Tue, 26 Jun 2018 20:35:46 +0000 (22:35 +0200)]
[!!!][TASK] Drop "documentation" extension

The docs team is working on a new docs.typo3.org rendering
chain that can come with some new long awaited features.
One blocker is the core internal documentation extension
that needs various hard to maintain resources from
docs.typo3.org.

The suggested solution was to drop the backend inline
manual fetching and display and thus obsolete the
extension.

For v8 and below, the 'latest' state of the various
json, xml and zip files the extension relies on, will
be frozen by the docs team to not break the module.

The documentation extension has various flaws, it for
instance tends to download outdated manual versions, the
acceptance within the community is not very high
and people are used to look up latest docs online.

The patch drops ext:documentation from the core to
free up the docs team from maintaining the clumsy
requirements at some point in time entirely.

Resolves: #85398
Releases: master
Change-Id: I4152381c49d3223b2586a742388cdf940aafe983
Reviewed-on: https://review.typo3.org/57385
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[!!!][FEATURE] Add property to disable form elements/finishers 49/57049/14
Ralf Zimmermann [Fri, 25 May 2018 09:30:33 +0000 (11:30 +0200)]
[!!!][FEATURE] Add property to disable form elements/finishers

Add a new rendering option called 'enabled' to control
the visibility for form elements and finishers.

Releases: master
Resolves: #85080
Change-Id: I593df2cfa4ca15ed3ac39b8774e5cd8bde8d24de
Reviewed-on: https://review.typo3.org/57049
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Re-Init CKEditor after re-sorting of inline records 82/57382/4
Frank Naegler [Tue, 26 Jun 2018 20:01:22 +0000 (22:01 +0200)]
[BUGFIX] Re-Init CKEditor after re-sorting of inline records

This patch triggers an event and uses this event to re-init the
CKEditor after re-sorting inline records.

Resolves: #79468
Releases: master, 8.7
Change-Id: Ib7d0ad6c1b0cb6b292b3dfa8488a6528ff74ceee
Reviewed-on: https://review.typo3.org/57382
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Only import extensions from 2015+ into EM 06/57306/5
Benni Mack [Fri, 22 Jun 2018 19:06:47 +0000 (21:06 +0200)]
[TASK] Only import extensions from 2015+ into EM

As proposed here https://decisions.typo3.org/t/reduce-size-of-extension-manager-db-table/329/
the EM only imports entries into the database from
TER that are uploaded from 2015-11-10 on, reducing
the database table size by 2/3.

As long as extensions.xml from TER does not
restrict this (e.g. by version) this reduces
import time when updating the extension list
and search handling within the Extension Manager.

Resolves: #85393
Releases: master
Change-Id: I1d45cde0fc895d0edb978729dc4b42df70e97d5c
Reviewed-on: https://review.typo3.org/57306
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Add LoginType enumeration 90/57390/2
Benni Mack [Wed, 27 Jun 2018 06:17:39 +0000 (08:17 +0200)]
[TASK] Add LoginType enumeration

A new enumeration class "LoginType" is added to simplify readability and validation
of correct strings within the TYPO3 Authentication process.

Resolves: #85402
Releases: master
Change-Id: Ib53ed304de5662f5bd8628509a229b2832ff18fa
Reviewed-on: https://review.typo3.org/57390
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Repair relative path resolvement in ResourceCompressor 03/56803/11
Pascal Rinker [Wed, 25 Apr 2018 09:51:47 +0000 (11:51 +0200)]
[BUGFIX] Repair relative path resolvement in ResourceCompressor

This patch repairs the relative path resolvment when using EXT:
for JavaScript/CSS paths.

Resolves: #84261
Releases: master, 8.7
Change-Id: Ieeb35041bf049728c41465edb617529550629258
Reviewed-on: https://review.typo3.org/56803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[TASK] Remove console.log call in ContextHelp.js 83/57383/2
Frank Naegler [Tue, 26 Jun 2018 20:19:50 +0000 (22:19 +0200)]
[TASK] Remove console.log call in ContextHelp.js

Resolves: #85397
Releases: master
Change-Id: If0551d96a751474b7281c71c84262da2fa0e7816
Reviewed-on: https://review.typo3.org/57383
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Move csh handling to backend extension 81/57381/2
Christian Kuhn [Tue, 26 Jun 2018 19:10:15 +0000 (21:10 +0200)]
[TASK] Move csh handling to backend extension

The core and documentation team decided to drop the inline
manual view from core for various reasons that will be further
outlined with a second patch.

The documentation extension currently does both the manual
display, and also the "csh" rendering. The latter has been
merged from ext:cshmanual into ext:documentation quite
recently with core version v9.0.

The patch extracts this csh handling from ext:documentation
again and puts it into ext:backend. The patch is similar to
the v9.0 patch, only slight additions are applied along the way.
This changes also unmarks the documentation extension from
"partOfMinimalUsableSystem" since the direct dependency of
ext:backend to ext:documentation is gone with the csh merge
into backend extension.

Resolves: #85396
Related: #81574
Releases: master
Change-Id: Ib5d8f50d097696bf88f0d1e26be9cac40f1e2578
Reviewed-on: https://review.typo3.org/57381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Make TSConfig preview configuration work again 80/57380/2
Tymoteusz Motylewski [Tue, 26 Jun 2018 18:52:41 +0000 (20:52 +0200)]
[BUGFIX] Make TSConfig preview configuration work again

Fixes regression introduced in https://review.typo3.org/#/c/56693/
the Page TSConfig is now properly fetched.

Resolves: #85395
Releases: master
Change-Id: I6b1d521139f84d3d55db1cb40167140134f0eba6
Reviewed-on: https://review.typo3.org/57380
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Deprecate TYPO3\CMS\Core\Database\PdoHelper 79/57379/2
Christian Kuhn [Tue, 26 Jun 2018 17:55:18 +0000 (19:55 +0200)]
[TASK] Deprecate TYPO3\CMS\Core\Database\PdoHelper

The PdoHelper class with its single method importSql() has
been added for the Pdo cache backend which is also still
the only usage of that helper class.
With the migration to doctrine, that class feels misplaced
and obsolete. The code is moved over as protected method
into Pdo cache backend directly and the PdoHelper class
is marked as deprecated.

Resolves: #85394
Releases: master
Change-Id: I4a22bd193caefced3cc601b2c1cf79f12961981d
Reviewed-on: https://review.typo3.org/57379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Fix override handling for element specific field values 48/57348/3
Frank Naegler [Sat, 23 Jun 2018 18:09:58 +0000 (20:09 +0200)]
[BUGFIX] Fix override handling for element specific field values

This patch fixes a broken JavaScript code which removes the field and
placeholder divs in FormeEngine.js field override handling.

Resolves: #84689
Related: #79440
Related: #70032
Releases: master, 8.7
Change-Id: I91d40b6ff7baa9fa9ea121458a7a9faaa00ec6f9
Reviewed-on: https://review.typo3.org/57348
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] RTE: Disable autolink functionality in source-mode 71/57371/2
Josef Glatz [Mon, 25 Jun 2018 20:21:10 +0000 (22:21 +0200)]
[BUGFIX] RTE: Disable autolink functionality in source-mode

Limit the functionality only to the wysiwyg-mode. This also
prevents javascript errors in source-mode.

Resolves: #85332
Releases: master, 8.7
Change-Id: I0adc30400fb27745713f0a86b7916a8865609428
Reviewed-on: https://review.typo3.org/57371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] CKEditor RTE: Add button to insert soft hyphen 44/57344/8
Josef Glatz [Sat, 23 Jun 2018 12:21:57 +0000 (14:21 +0200)]
[TASK] CKEditor RTE: Add button to insert soft hyphen

This patch re-adds a missing functionality to CKEditor.

Due to the move from htmlArea to CKEditor, the well-known and actually
important button/shortcut "soft hyphen" for text in responsive webdesign
was gone.

The button is added per default to the existing CKEditor presets "default"
and "full". Existing translations from htmlArea have been migrated and
more were added.

Pasting a soft hyphen is possible via the UI button and a keyboard
shortcut: 'CTRL' + '-'. The shortcut can be deactivated in custom
RTE presets.

Resolves: #85361
Releases: master, 8.7
Change-Id: Iec97f4c9d1ede269e2df5cb4fe795df0ef5ca558
Reviewed-on: https://review.typo3.org/57344
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sebastian Klein <laitnin@gmx.net>
Tested-by: Sebastian Klein <laitnin@gmx.net>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>