Packages/TYPO3.CMS.git
2 years ago[TASK] Use direct array assignments instead of array_push 49/52049/4
Cedric Ziel [Wed, 15 Mar 2017 09:36:14 +0000 (10:36 +0100)]
[TASK] Use direct array assignments instead of array_push

Direct assignments are usually 2x faster and often more readable
when pushing one value only.

Releases: master
Fixes: #80283
Change-Id: I16fc1938f74550d1a3d9f9c0cbafe85dc2ff1c5b
Reviewed-on: https://review.typo3.org/52049
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move all marker-based logic from cObj to MarkerBasedTemplateService 20/52220/2
Benni Mack [Tue, 28 Mar 2017 15:21:02 +0000 (17:21 +0200)]
[TASK] Move all marker-based logic from cObj to MarkerBasedTemplateService

Now, all functionality for marker-based templates are encapsulated in
MarkerBasedTemplateService, instead of polluting cObjectRenderer which
is used a lot in the frontend, even though no markers are in use.

All methods within ContentObjectRenderer have been marked as deprecated.

Resolves: #80527
Releases: master
Change-Id: If7a27281470935af893d1a9838f06ca77a3041c1
Reviewed-on: https://review.typo3.org/52220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Deprecate config.setJS_mouseOver and config.setJS_openPic 13/52213/3
Benni Mack [Tue, 28 Mar 2017 11:08:37 +0000 (13:08 +0200)]
[TASK] Deprecate config.setJS_mouseOver and config.setJS_openPic

The TypoScript properties config.setJS_mouseOver and config.setJS_openPic
have been marked as deprecated.

Resolves: #80516
Releases: master
Change-Id: Ida5de8b3e873adfe7e27decf6e43813e7dc5cc2e
Reviewed-on: https://review.typo3.org/52213
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate DocumentTemplate->extJScode property 10/52210/2
Benni Mack [Tue, 28 Mar 2017 10:34:00 +0000 (12:34 +0200)]
[TASK] Deprecate DocumentTemplate->extJScode property

The public property DocumentTemplate->extJScode can be used to fill in
ExtJS-specific code to be loaded on "onExtReady". The functionality is not
used in the core anymore, as there are better ways to include JavaScript
code in a backend response.

Resolves: #80512
Releases: master
Change-Id: I4cf24f6b096a79d76e1d30f587f25dcc8ca10fa4
Reviewed-on: https://review.typo3.org/52210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate DataHandler->destPathFromUploadFolder() 11/52211/2
Benni Mack [Tue, 28 Mar 2017 10:52:16 +0000 (12:52 +0200)]
[TASK] Deprecate DataHandler->destPathFromUploadFolder()

The method in DataHandler->destPathFromUploadFolder is basically
useless nowadays and should be avoided, since it just prepends PATH_site
to a string.

The fourth parameter for extFileFunctions() is also useless as the method
only is triggered for "deleteAll" and no other value is allowed.

Resolves: #80513
Releases: master
Change-Id: I371fd9233bbe63dd2d3775e4ddd8212358164ced
Reviewed-on: https://review.typo3.org/52211
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate PageRepository::setHash and storeHash 17/52217/2
Benni Mack [Tue, 28 Mar 2017 14:49:40 +0000 (16:49 +0200)]
[TASK] Deprecate PageRepository::setHash and storeHash

The two static methods are sole wrappers for the Caching Framework nowadays
which can simply be dealt with in a custom way.

Use the Caching Framework directly instead!

Resolves: #80524
Releases: master
Change-Id: I8fced0800a2c72705f1a01e0a3d6e52aeaf5daef
Reviewed-on: https://review.typo3.org/52217
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not rely on sys_page when storing cached data in cObj 81/52181/3
Benni Mack [Mon, 27 Mar 2017 13:53:17 +0000 (15:53 +0200)]
[TASK] Do not rely on sys_page when storing cached data in cObj

ContentObject renderer has an unnecessary call to $TSFE->sys_page
for calling a static method in a non-static way.

It should directly use the caching framework instead.

Resolves: #80482
Releases: master
Change-Id: Iaa93de3c1e98cf5e639605dcf49cb5715a28b5d7
Reviewed-on: https://review.typo3.org/52181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Do not mis-use sys_page for using cache_hash in ExtDirectApi 14/52214/2
Benni Mack [Tue, 28 Mar 2017 11:14:38 +0000 (13:14 +0200)]
[TASK] Do not mis-use sys_page for using cache_hash in ExtDirectApi

The ExtDirectApi simply calls PageRepository to store data in the "cache_hash"
cache. This can be simplified by just using the Caching Framework directly
without depending on a EXT:frontend class in a EXT:core class.

Resolves: #80517
Releases: master
Change-Id: I77825bf71264621fb984b39f79009baf71cfdec3
Reviewed-on: https://review.typo3.org/52214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Finetune avatar size in backend toolbar 98/52198/4
Benjamin Kott [Mon, 27 Mar 2017 20:40:40 +0000 (22:40 +0200)]
[TASK] Finetune avatar size in backend toolbar

Resolves: #80501
Releases: master
Change-Id: I5371b546bb7ebffdfc78a5bbfe1b86699a4f4a43
Reviewed-on: https://review.typo3.org/52198
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Deprecate AbstractFunctionModule->incLocalLang() 09/52209/4
Benni Mack [Tue, 28 Mar 2017 10:17:14 +0000 (12:17 +0200)]
[TASK] Deprecate AbstractFunctionModule->incLocalLang()

Loading a locallang.xlf inside the abstract function module now uses the regular
$GLOBALS['LANG']->includeLLFile() of the current file, instead of doing a manual
check on .xml and .php extensions, which the LanguageService/LanguageFactory
is taking care of anyway.

The PHP method incLocalLang() and the now not necessarily needed $thisPath
are therefore marked as deprecated.

Resolves: #80511
Releases: master
Change-Id: I3a9d27bf794a4cd8c1f2d31ed9250d634aa68ee8
Reviewed-on: https://review.typo3.org/52209
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Replace clearable icon with SVG from TYPO3 icon set 95/52195/6
Benjamin Kott [Mon, 27 Mar 2017 19:53:54 +0000 (21:53 +0200)]
[TASK] Replace clearable icon with SVG from TYPO3 icon set

Resolves: #80498
Releases: master
Change-Id: I139922f0bb86e1ff1dc4bd9258491bd5eedaedc2
Reviewed-on: https://review.typo3.org/52195
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Check correct variable in BrowseLinksController 05/52205/3
Christer Vindberg [Tue, 28 Mar 2017 07:10:31 +0000 (09:10 +0200)]
[BUGFIX] Check correct variable in BrowseLinksController

Make sure to check the correct variable classesAnchorDefaultTitle
when fetching the title of anchors.

This affects CKeditor as well as htmlarea.

Resolves: #80209
Releases: master, 7.6
Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706
Reviewed-on: https://review.typo3.org/52205
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Add preset for mail SMTP settings in install tool 67/52167/8
Frank Naegler [Sun, 26 Mar 2017 13:35:20 +0000 (15:35 +0200)]
[TASK] Add preset for mail SMTP settings in install tool

The current mail presets only allow to modify sendmail
settings, but it's not possible to configure SMTP settings.

Resolves: #80457
Releases: master
Change-Id: Ib70351c9048c0ceec2b2a585d43a3ad04c81424e
Reviewed-on: https://review.typo3.org/52167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate cObj->URLqMark 82/52182/3
Benni Mack [Mon, 27 Mar 2017 14:03:54 +0000 (16:03 +0200)]
[TASK] Deprecate cObj->URLqMark

The method cObject->URLqMark() adds a question mark to a string
to append it. This method should not be in scope of cObject, but rather
be put in e.g. StringUtility or GeneralUtility... however, since the functionality
is rather simple, it can be achieved without any helper method as a one-liner.

Resolves: #80510
Releases: master
Change-Id: I5230c5a4e27f8ef198190defd15598023279c1c2
Reviewed-on: https://review.typo3.org/52182
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Ensure module menu is correctly closed after click on overlay 99/52199/4
Benjamin Kott [Mon, 27 Mar 2017 20:55:30 +0000 (22:55 +0200)]
[BUGFIX] Ensure module menu is correctly closed after click on overlay

Resolves: #80502
Releases: master
Change-Id: I01cac3870381c1783e0a1bb1226c0ab537619455
Reviewed-on: https://review.typo3.org/52199
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Streamline return tags in phpdocs 86/51686/12
Wouter Wolters [Tue, 14 Feb 2017 20:08:46 +0000 (21:08 +0100)]
[TASK] Streamline return tags in phpdocs

The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix position of carets in accordions in install tool 06/52206/4
Frank Naegler [Tue, 28 Mar 2017 07:59:16 +0000 (09:59 +0200)]
[BUGFIX] Fix position of carets in accordions in install tool

Resolves: #80507
Releases: master
Change-Id: I5494a9a61829d6245fa2410c3bafe8c6bc4a9043
Reviewed-on: https://review.typo3.org/52206
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use correct property for images in FrontendUser 46/52146/2
Georg Ringer [Sat, 25 Mar 2017 09:52:57 +0000 (10:52 +0100)]
[BUGFIX] Use correct property for images in FrontendUser

As the image field has been changed to FAL, also the model must
be adopted.

Resolves: #80437
Releases: master
Change-Id: I09b6ef8db190467ee5dfea67e5e66ded12b99dcd
Reviewed-on: https://review.typo3.org/52146
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Nikolai Townsend <info@nikolaitownsend.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Streamline indexed_search template files 19/52119/3
Benjamin Kott [Wed, 22 Mar 2017 10:02:50 +0000 (11:02 +0100)]
[TASK] Streamline indexed_search template files

For a more streamlined rendering this patch adds nessesary html tags
with fluid namespaces to all indexed_search templates, unifies indention
and adds an empty space before closing bracket of self-closing tags.

Resolves: #80392
Releases: master
Change-Id: Ia6bc46c8fb602b4f3592094ad963691bbf412d7d
Reviewed-on: https://review.typo3.org/52119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Header should not disappear when page is dropped to trash 83/52183/4
Benjamin Kott [Mon, 27 Mar 2017 14:05:45 +0000 (16:05 +0200)]
[BUGFIX] Header should not disappear when page is dropped to trash

Resolves: #80484
Releases: master
Change-Id: Ie17a8cc5cb118c9ecd381355b96d9e60cd278712
Reviewed-on: https://review.typo3.org/52183
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Add proper comments to PHP code 00/52200/3
Benni Mack [Mon, 27 Mar 2017 20:58:56 +0000 (22:58 +0200)]
[TASK] Add proper comments to PHP code

There are some places where PHP comments have been done wrong (using doccomments)
or where there is no comment at all.

Resolves: #80503
Releases: master
Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af
Reviewed-on: https://review.typo3.org/52200
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Use SVG Icons for permission actions 02/52202/2
Benjamin Kott [Mon, 27 Mar 2017 22:02:28 +0000 (00:02 +0200)]
[TASK] Use SVG Icons for permission actions

Resolves: #80505
Releases: master
Change-Id: I8188f7c9c63776a41a2f4e5c5077139e55312281
Reviewed-on: https://review.typo3.org/52202
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup Localization Charset code 85/52185/3
Benni Mack [Mon, 27 Mar 2017 14:27:48 +0000 (16:27 +0200)]
[TASK] Cleanup Localization Charset code

The protected property "AbstractXmlParser->charset" is set from
the outside but never used anymore in either the abstract class nor
in the subclasses.

The protected method "getCharset()" is basically useless:
a) it's never called or in use
b) it has nothing to do with the XmlParser as it does not work
with any properties / functionalities of the XmlParser itself.

The protected method "initialize()" is called solely in the
contructor which can be dealt with directly in the constructor
(that's what a constructor is there for).

The third parameter $charset within getParsedData() is
now not needed anymore within the Parsers, as all expect
UTF-8 for files.

Resolves: #80486
Releases: master
Change-Id: I929c3960fb5b94f5448a2d29f4a73fbb5d81a500
Reviewed-on: https://review.typo3.org/52185
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] EXT:form - make 'grid rows' independent from 'grid containers' 66/52166/5
Ralf Zimmermann [Sun, 26 Mar 2017 10:54:07 +0000 (12:54 +0200)]
[TASK] EXT:form - make 'grid rows' independent from 'grid containers'

* Create 'grid rows' without 'grid container' wrappers
* Disable 'grid containers' within the form editor by default
  because twitter bootstrap prohibits container nesting

Resolves: #80455
Releases: master
Change-Id: I3997943858ac3b235094b765697f724cb1e4c95d
Reviewed-on: https://review.typo3.org/52166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Restore highlighting of livesearch box 96/52196/2
Benjamin Kott [Mon, 27 Mar 2017 20:29:46 +0000 (22:29 +0200)]
[BUGFIX] Restore highlighting of livesearch box

Resolves: #80499
Releases: master
Change-Id: I820ac450c5bd32c9d992dcfd39983b20c304799f
Reviewed-on: https://review.typo3.org/52196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate TSFE->whichWorkspace parameter 84/52184/3
Benni Mack [Mon, 27 Mar 2017 14:13:27 +0000 (16:13 +0200)]
[TASK] Deprecate TSFE->whichWorkspace parameter

The parameter of the $TSFE->whichWorkspace() method decides
whether the UID of the current workspace should be returned or
the actual "title" of the sys_workspace record.

As this parameter is not in use anymore and clearly makes this function
harder to understand why and when someone could use this, this property
is marked as deprecated.

Instead, fetching the workspace title should happen in the place where it
is needed.

Resolves: #80485
Releases: master
Change-Id: I06512e40c48b35826c0d0a89cc8c4cdcdc8773e6
Reviewed-on: https://review.typo3.org/52184
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Integrate tests for DataHandler hook invocations 90/52190/2
Oliver Hader [Mon, 27 Mar 2017 16:28:02 +0000 (18:28 +0200)]
[TASK] Integrate tests for DataHandler hook invocations

Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139
Resolves: #80494
Releases: master
Reviewed-on: https://review.typo3.org/52190
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Avoid live ID processing if EXT:version not loaded 70/50970/7
Thomas Hohn [Tue, 13 Dec 2016 20:08:07 +0000 (21:08 +0100)]
[BUGFIX] Avoid live ID processing if EXT:version not loaded

DataHandler does not need to force "live ID" processing to
be enabled on RelationHandler when EXT:version is not loaded.

Avoiding this saves some semi-expensive operations inside
the RelationHandler class.

Resolves: #78998
Releases: master
Change-Id: If53cdd73db15352d6f4854a5aef4b407836cb6ce
Reviewed-on: https://review.typo3.org/50970
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Do not allow dots in ratio IDs 94/52194/2
Helmut Hummel [Mon, 27 Mar 2017 18:01:04 +0000 (20:01 +0200)]
[BUGFIX] Do not allow dots in ratio IDs

Due to usage of Fluid dynamic variable parts in the template,
ratio IDs must not contain a "."

Resolves: #80214
Releases: master
Change-Id: I12dac926169c827c9e3022320dd90a058f72913b
Reviewed-on: https://review.typo3.org/52194
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup BE user authentication in Frontend 77/52177/3
Benni Mack [Mon, 27 Mar 2017 13:44:52 +0000 (15:44 +0200)]
[TASK] Cleanup BE user authentication in Frontend

The Frontend Controller (TSFE) does some initialization which
should belong to the FrontendBackendUserAuthentication directly.

Additionally, some further code cleanups are made for this area.

Resolves: #80479
Releases: master
Change-Id: I32d9c98bb511f1eaa1f56203c4678358107aa7bc
Reviewed-on: https://review.typo3.org/52177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Extbase should not use deprecated CLI admin role methods 88/52188/3
Benni Mack [Mon, 27 Mar 2017 16:15:26 +0000 (18:15 +0200)]
[BUGFIX] Extbase should not use deprecated CLI admin role methods

Resolves: #80492
Releases: master
Change-Id: Id835329586bf0fa315dc46377bc195ace005da61
Reviewed-on: https://review.typo3.org/52188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not rely on sys_page cache shortcut for fetching TSconfig 79/52179/2
Benni Mack [Mon, 27 Mar 2017 13:47:40 +0000 (15:47 +0200)]
[TASK] Do not rely on sys_page cache shortcut for fetching TSconfig

The TypoScript Frontend Controller has a unnecessary dependency
to a static call (which is made non-static !) of PageRepository
which can be done exactly 1:1 by instantiating the cacheManager
and fetching the "cache_hash" cache directly by storing and fetching
the contents itself.

Resolves: #80480
Releases: master
Change-Id: If6f5976a6c07ea754915b9c612264d733a6b1a41
Reviewed-on: https://review.typo3.org/52179
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add version check to /install/index.php 93/52193/2
Frank Naegler [Mon, 27 Mar 2017 17:43:50 +0000 (19:43 +0200)]
[BUGFIX] Add version check to /install/index.php

This patch adds a missing PHP version check to the /install/index.php file which
exists only for the redirect to the install tool. Because of this missing version check
an installation without PHP 7.0 will fatal with an parsing error.

Resolves: #80496
Releases: master
Change-Id: Iec97021fb18ac7a4cfa0dcf1961675c3d58305ee
Reviewed-on: https://review.typo3.org/52193
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] JS: Invert dependency definition for FormEngine and Validation 78/52178/2
Markus Klein [Mon, 27 Mar 2017 13:45:58 +0000 (15:45 +0200)]
[BUGFIX] JS: Invert dependency definition for FormEngine and Validation

FormEngineValidation is meant as integral part of FormEngine.
The current dependency definition is inverted, such that FormEngine
now depends on FormEngineValidation and not the other way around.
Note that FormEngineValidation does not need any other feature
of FormEngine, so this is safe.

This solves a possible race condition with other modules.

Releases: master, 7.6
Resolves: #80459
Change-Id: Ie2cb9dd90220b37a98bc8e3ca174fd074488cc8d
Reviewed-on: https://review.typo3.org/52178
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate VERY old BackendController hooks 87/52187/3
Benni Mack [Mon, 27 Mar 2017 15:34:07 +0000 (17:34 +0200)]
[TASK] Deprecate VERY old BackendController hooks

When the BackendController was just a plain backend.php file (back in TYPO3 6.2)
there were some hooks available to load ExtJS components and JS/CSS files
via include statements and relative paths.

There are now better hooks within BackendController, so CSS and JS resources
can be loaded via PageRenderer and within the BackendController scope.

The obsolete methods and hooks are marked as deprecated.

Resolves: #80491
Releases: master
Change-Id: I9e0e72df7237ab958ec06f7d58a9fa41c75ba890
Reviewed-on: https://review.typo3.org/52187
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Deprecate cliKeys logic and cli_dispatch.phpsh entrypoint 73/52173/7
Benni Mack [Mon, 27 Mar 2017 10:13:03 +0000 (12:13 +0200)]
[TASK] Deprecate cliKeys logic and cli_dispatch.phpsh entrypoint

The way of calling CLI scripts from within TYPO3 via the "cliKeys"
functionality and the typo3/cli_dispatch.phpsh entrypoint have been
superseded by the new Symfony Console integration.

All code related to this functionality has been marked as deprecated.

Calling the CliRequestHandler (which is the main entry point for the
cli_dispatch.phpsh) will trigger a deprecation message warning.

Resolves: #80468
Releases: master
Change-Id: Ib72ab93bee27421163c9117ebedcc0e97e17d41e
Reviewed-on: https://review.typo3.org/52173
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure badge variants use correct loading order and styling 86/52186/3
Benjamin Kott [Mon, 27 Mar 2017 14:29:58 +0000 (16:29 +0200)]
[BUGFIX] Ensure badge variants use correct loading order and styling

Resolves: #80487
Releases: master
Change-Id: I23db288f4592cc09fe183c32ec17931e99b4ea74
Reviewed-on: https://review.typo3.org/52186
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years agoRevert "[BUGFIX] JS: Add missing dependency on FormEngineValidation" 76/52176/2
Markus Klein [Mon, 27 Mar 2017 13:35:02 +0000 (14:35 +0100)]
Revert "[BUGFIX] JS: Add missing dependency on FormEngineValidation"

This reverts commit b07bb2e9fb011a999a01ffb5ab323691f866179d.

The patch is replaced by a better solution.
Revert is only done for master, backport was
not done yet.

Change-Id: Ibcabb095e0043dd21cd694142d93baea7dc8e8c5
Reverts: #80459
Releases: master
Reviewed-on: https://review.typo3.org/52176
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] JS: Add missing dependency on FormEngineValidation 68/52168/2
Markus Klein [Sun, 26 Mar 2017 17:54:42 +0000 (19:54 +0200)]
[BUGFIX] JS: Add missing dependency on FormEngineValidation

The code must not use the nested FormEngine.Validation module
without specifying a dependency on this module as well.

Releases: master, 7.6
Resolves: #80459
Change-Id: Iaea325a679ac8bae116b33b912e3e9e2f7cd9163
Reviewed-on: https://review.typo3.org/52168
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FEATURE] Allow Extbase CLI commands to be available via new CLI API 86/51886/8
Benni Mack [Tue, 28 Feb 2017 07:51:15 +0000 (08:51 +0100)]
[FEATURE] Allow Extbase CLI commands to be available via new CLI API

This ensures to call extbase commands & command controllers automatically
via the new CLI binary.

Extbase now also overrides the help command by symfony to allow extbase
custom HelpCommandController to come into play when an Extbase command
was called.

This patch is critical for v8 so all core-internal CLI commands are available via
"typo3/sysext/core/bin/typo3", otherwise we'd need to explain every admin
that there are two CLI entrypoints for v8 which are relevant, because Extbase is
still solely using "typo3/cli_dispatch.phpsh" until now, while all other entry
points have been migrated already.

Resolves: #80452
Releases: master
Change-Id: I70e56c2cbef993cf16dfb212ba1a11add0017a01
Reviewed-on: https://review.typo3.org/51886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[TASK] Extbase commands do not need to ensure admin role 50/51250/6
Benni Mack [Mon, 27 Mar 2017 07:39:34 +0000 (09:39 +0200)]
[TASK] Extbase commands do not need to ensure admin role

The methods in Extbase's command controller to request
the admin role for $BE_USER are not needed anymore,
because CLI users are always admins nowadays.

The methods are therefore marked as deprecated.

Resolves: #79591
Releases: master
Change-Id: I79865af20a45d455a9417ceca42e4068cc15dc3f
Reviewed-on: https://review.typo3.org/51250
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Avoid remapping empty value in checkValueForInline 15/51015/10
Claus Due [Wed, 21 Dec 2016 15:44:14 +0000 (16:44 +0100)]
[BUGFIX] Avoid remapping empty value in checkValueForInline

This change prevents checkValueForInline from processing
empty values. The existing check would process empty
values since one of the true matches is when value cannot
be interpreted as an integer.

Change-Id: Iacd38363bcc23453da9fcc2eea359680c6b91175
Resolves: #79063
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51015
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Migrate backend styles from LESS to SASS 51/52151/12
Benjamin Kott [Sat, 25 Mar 2017 16:08:58 +0000 (17:08 +0100)]
[TASK] Migrate backend styles from LESS to SASS

In preparation for upcomming switch from bootstrap to SASS the backend
style sources have been migrated to SASS. The autoprefixer configuration
was corrected to match CMS8 LTS requirements and minification of CSS
files is now enabled. Automatic style checks are now available through
grunt. The tasks `grunt format` and `grunt lint` will now check sources
files for consistency.

Resolves: #80453
Releases: master
Change-Id: I9ba23aea78014a1f0cce229db533a81d5ffcd02f
Reviewed-on: https://review.typo3.org/52151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marco Christian Krenn <krenn@webconsulting.at>
Tested-by: Marco Christian Krenn <krenn@webconsulting.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Provide update wizard for ext:compatibility7 90/51690/9
Wouter Wolters [Tue, 14 Feb 2017 21:44:32 +0000 (22:44 +0100)]
[TASK] Provide update wizard for ext:compatibility7

Remove the extension at the same time.

Resolves: #79734
Releases: master
Change-Id: I457f29b64596a91e612b0f99a020aea46f4a2425
Reviewed-on: https://review.typo3.org/51690
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:Scheduler: Post only fields of selected class on save 27/51027/3
Michael Oehlhof [Thu, 22 Dec 2016 16:08:45 +0000 (17:08 +0100)]
[BUGFIX] EXT:Scheduler: Post only fields of selected class on save

When saving a new task, now only the extra fields of the selected class
where submitted via post and no longer all extra fields of all possible
classes.
This prevents saving the wrong value if extra fields of different classes
have the same id.

Resolves: #25805
Releases: master
Change-Id: I4f0ae67694fbc3b284e763e3edd123804d078350
Reviewed-on: https://review.typo3.org/51027
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] EXT:form - Use PHP's native array_replace_recursive 55/52155/3
Benni Mack [Sat, 25 Mar 2017 17:27:48 +0000 (18:27 +0100)]
[TASK] EXT:form - Use PHP's native array_replace_recursive

Resolves: #80443
Releases: master
Change-Id: I3e9c2b3f984068f2ce4d1096cd14670700d77aa6
Reviewed-on: https://review.typo3.org/52155
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Move MonitorUtility to compatiblity7 64/52164/2
Christian Kuhn [Sat, 25 Mar 2017 23:09:16 +0000 (00:09 +0100)]
[TASK] Move MonitorUtility to compatiblity7

Move the MonitorUtility to ext:compatibility7, implement the static call
as eofe hook and move the reports system status to compat7, too.

Change-Id: I152a726d9d47e9a1f38dc2416384551727bbcc88
Resolves: #80450
Releases: master
Reviewed-on: https://review.typo3.org/52164
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Decrease z-index for disabled fields in FormEngine 49/52149/2
Andreas Fernandez [Sat, 25 Mar 2017 15:55:48 +0000 (16:55 +0100)]
[BUGFIX] Decrease z-index for disabled fields in FormEngine

The z-index for disabled input fields is decreased to a much lower value
to avoid overlaying the module header bar.

Resolves: #80428
Releases: master, 7.6
Change-Id: Ia6f861fc66269b843571720e31f4f935d5cc9614
Reviewed-on: https://review.typo3.org/52149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate GeneralUtility::csvValues 63/52163/2
Frank Naegler [Sat, 25 Mar 2017 23:09:17 +0000 (00:09 +0100)]
[TASK] Deprecate GeneralUtility::csvValues

Resolves: #80451
Releases: master
Change-Id: I7ba0a97b3ca4bfb98b1f5072a830d10b66e640fd
Reviewed-on: https://review.typo3.org/52163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Optimize colors in modulemenu 62/52162/3
Marco Christian Krenn [Sat, 25 Mar 2017 22:13:37 +0000 (23:13 +0100)]
[TASK] Optimize colors in modulemenu

changes colors and use the base variables set in the file.
cleanup of pagetree svg icon and add class icon-color.

Resolves: #80023
Releases: master
Change-Id: I6809e7930c118d9e4cc55035f0cf687c02a5958b
Reviewed-on: https://review.typo3.org/52162
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid double escaping in content element wizard 47/52147/2
Georg Ringer [Sat, 25 Mar 2017 10:13:41 +0000 (11:13 +0100)]
[BUGFIX] Avoid double escaping in content element wizard

Fluid escapes the header already, therfore there is no
need to do it before in the controller.

Resolves: #80288
Releases: master
Change-Id: I7f16fb2aa1319cdfbc3a8c9226a86e98a8e8457a
Reviewed-on: https://review.typo3.org/52147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Deprecate RemoveXSS 61/52161/3
Frank Naegler [Sat, 25 Mar 2017 21:40:45 +0000 (22:40 +0100)]
[FOLLOWUP][TASK] Deprecate RemoveXSS

This patch adds the missing logDeprecatedFunction() call.

Resolves: #76164
Releases: master
Change-Id: I70da92799b6fe9345468b600b73ce30273c25836
Reviewed-on: https://review.typo3.org/52161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate EXT:lowlevel ArrayBrowser->wrapValue 53/52153/3
Benni Mack [Sat, 25 Mar 2017 17:05:14 +0000 (18:05 +0100)]
[TASK] Deprecate EXT:lowlevel ArrayBrowser->wrapValue

The method ArrayBrowser->wrapValue() only does a htmlspecialchars()
call nowadays and can be replaced easily by PHP native functions.

Resolves: #80440
Releases: master
Change-Id: I1646adc0c501b386ed289f428420b3e6ec6a5000
Reviewed-on: https://review.typo3.org/52153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move config.beLoginLinkIPList to compat7 56/52156/4
Benni Mack [Sat, 25 Mar 2017 19:39:07 +0000 (20:39 +0100)]
[TASK] Move config.beLoginLinkIPList to compat7

The functionality to output a login link / logout link when coming from
a certain IP address (set via TypoScript config.beLoginLinkIPList) was
moved to EXT:compatibility7.

Resolves: #80444
Releases: master
Change-Id: I1b754cfd454abd3376642a290c056442c5be733d
Reviewed-on: https://review.typo3.org/52156
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Deprecate GeneralUtility::freetypeDpiComp 60/52160/4
Benni Mack [Sat, 25 Mar 2017 21:27:04 +0000 (22:27 +0100)]
[TASK] Deprecate GeneralUtility::freetypeDpiComp

The Freetype related method "GeneralUtility::freetypeDpiComp"
has been marked as deprecated and moved to GraphicalFunctions
where it belongs to.

Resolves: #80449
Releases: master
Change-Id: Iaa549051c38993a24415c2bfdb785715c1d6e74d
Reviewed-on: https://review.typo3.org/52160
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - avoid php warnings 52/52152/2
Ralf Zimmermann [Sat, 25 Mar 2017 16:47:35 +0000 (17:47 +0100)]
[BUGFIX] EXT:form - avoid php warnings

Avoid php warnings if no individual validation errors are defined.

Resolves: #80439
Releases: master
Change-Id: Idc3f566eb922afe3fc167d5738da54c09f78f83e
Reviewed-on: https://review.typo3.org/52152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Patrick Broens <patrick@patrickbroens.nl>
Tested-by: Patrick Broens <patrick@patrickbroens.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - do not wrap in anonymous function 54/52154/2
Benni Mack [Sat, 25 Mar 2017 17:07:43 +0000 (18:07 +0100)]
[BUGFIX] EXT:form - do not wrap in anonymous function

There are no local variables in ext_tables.php that would
justify having a call_user_func() wrap around the
registration of the Form module.

Resolves: #80441
Releases: master
Change-Id: Idd927141ca10c22fcf43b0c553b82518925995cd
Reviewed-on: https://review.typo3.org/52154
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Patrick Broens <patrick@patrickbroens.nl>
Tested-by: Patrick Broens <patrick@patrickbroens.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup legacy IMv4 options 59/52159/2
Benni Mack [Sat, 25 Mar 2017 21:06:11 +0000 (22:06 +0100)]
[TASK] Cleanup legacy IMv4 options

The GraphicalFunctions options $V5_EFFECTS and $_NO_IM_EFFECTS
are no the exact opposite all times, due to the removal of IM4 support.

For this reason, the property $V5_EFFECTS can be removed.

Resolves: #80448
Releases: master
Change-Id: I935a5d89a98ebc16b04be46e492d26346fa10f82
Reviewed-on: https://review.typo3.org/52159
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[TASK] Clean up code in jsfunc.inline.js 58/52158/3
Benni Mack [Sat, 25 Mar 2017 20:23:14 +0000 (21:23 +0100)]
[TASK] Clean up code in jsfunc.inline.js

There are some methods that are handled differently these days and
are not necessary anymore due to some IRRE refactorings in the last
months.

Resolves: #80446
Releases: master
Change-Id: Icadfbfda1c1471c547dc1dbcaad989fb1a623b66
Reviewed-on: https://review.typo3.org/52158
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate printContent methods 57/52157/2
Frank Naegler [Sat, 25 Mar 2017 20:02:03 +0000 (21:02 +0100)]
[TASK] Deprecate printContent methods

The methods TaskModuleController::printContent() and
PageLayoutController::printContent()  have been marked as deprecated.

Resolves: #80445
Releases: master
Change-Id: Ia79101ca6ff66e7a0896dad930276698791989ce
Reviewed-on: https://review.typo3.org/52157
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use TYPO3_version constant for Extbase help command 50/52150/2
Benni Mack [Sat, 25 Mar 2017 16:03:36 +0000 (17:03 +0100)]
[TASK] Use TYPO3_version constant for Extbase help command

The output which version of Extbase is used, does not need to be
fetched via getExtensionVersion() of EXT:extbase. The TYPO3_version
contains the same information as the information in EXT:extbase/ext_emconf.php.

Resolves: #80438
Releases: master
Change-Id: I69be6c5949f39dac2c6a953d74c6cbfa7eaecd35
Reviewed-on: https://review.typo3.org/52150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] EXT:form - support multiple form elements per row 37/52037/20
Ralf Zimmermann [Tue, 14 Mar 2017 03:07:25 +0000 (04:07 +0100)]
[FEATURE] EXT:form - support multiple form elements per row

Make it possible to define multiple form elements per row.
The default configuration works for Twitter Bootstrap.

Resolves: #80196
Releases: master
Change-Id: I28b9f648d2bc202c03b6c6b474f6e975ef1459bd
Reviewed-on: https://review.typo3.org/52037
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Avoid warning dialog when closing records with dateTime fields 40/52140/3
Frank Naegler [Fri, 24 Mar 2017 11:12:43 +0000 (12:12 +0100)]
[BUGFIX] Avoid warning dialog when closing records with dateTime fields

In case a record contains a DateTimePicker field, the validation is triggered to early
and mark each DateTime field as changed. This patch fix this wrong behavior.

Resolves: #80008
Releases: master
Change-Id: I9a2d81c6cf5b544d5a6f08f43fd2fea86b415d6a
Reviewed-on: https://review.typo3.org/52140
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Set language uid for inline children by default 48/52148/2
Nicole Cordes [Sat, 25 Mar 2017 15:04:09 +0000 (16:04 +0100)]
[FOLLOWUP][BUGFIX] Set language uid for inline children by default

Resolves: #48883
Resolves: #76048
Resolves: #73609
Releases: master, 7.6
Change-Id: Id782bd41bfe30d9f9574e4b444d6e361ac76d0c6
Reviewed-on: https://review.typo3.org/52148
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Set language uid for inline children by default 61/52061/11
Nicole Cordes [Wed, 15 Mar 2017 16:11:27 +0000 (17:11 +0100)]
[BUGFIX] Set language uid for inline children by default

On creating child records for an inline field, currently no language
is set and the children are stored with sys_language_uid 0. This patch
adds the proper configuration to ensure a default children language
according to its parent language.

Resolves: #48883
Resolves: #76048
Resolves: #73609
Releases: master, 7.6
Change-Id: Id9e449dbb06fed11670eedec45a92529fb4acb6f
Reviewed-on: https://review.typo3.org/52061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Unify configuration for overriding child TCA 30/52130/9
Helmut Hummel [Wed, 22 Mar 2017 21:43:10 +0000 (22:43 +0100)]
[TASK] Unify configuration for overriding child TCA

The configuration possibilities to override child TCA
from the TCA of an inline parent

foreign_types
foreign_record_defaults
foreign_selector_fieldTcaOverride
overrideCropVariants

Are now replaced with a new generic one

overrideChildTca

The old TCA is migrated to the new version.

Resolves: #80000
Releases: master
Change-Id: Iebe4e0794517bc51f8bb2406aec80d95dfcb374e
Reviewed-on: https://review.typo3.org/52130
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] EXT:form - simplify translation file includes 08/52008/25
Ralf Zimmermann [Sat, 11 Mar 2017 22:11:42 +0000 (23:11 +0100)]
[TASK] EXT:form - simplify translation file includes

With this patch, an integrator has prototype wide translation settings
for the 4 aspects of the form framework. Furthermore, the integrator is
able to define multiple translation files to avoid copying the whole
default translation files or using locallangXMLOverride.

Resolves: #80241
Releases: master
Change-Id: I96ff6afec42159fbbd9c9fcd9d4540e12e1221cd
Reviewed-on: https://review.typo3.org/52008
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Start click binding only after DOM is ready 36/52136/3
Frank Naegler [Thu, 23 Mar 2017 13:46:51 +0000 (14:46 +0100)]
[BUGFIX] Start click binding only after DOM is ready

This patch fixes a loading issue on poor internet connections.
In case of a slow internet connection the icons are not loaded and the
click binding does not work. A DOM ready check should solve the issue.

Resolves: #80416
Releases: master, 7.6
Change-Id: Ia79f14e9dbe0b44a22c5916073b4649211b0bd7b
Reviewed-on: https://review.typo3.org/52136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tabea Oertel <tabea.oertel@dkd.de>
Tested-by: Tabea Oertel <tabea.oertel@dkd.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Log exception when metadata extraction fails 65/51965/16
Thomas Hohn [Mon, 6 Mar 2017 19:13:39 +0000 (20:13 +0100)]
[TASK] Log exception when metadata extraction fails

When the FAL metadata extraction task fails with an exception
this exception will now be logged via logException(), which is
added as a new method to AbstractTask. This method logs via
GeneralUtility::sysLog and the Logging API.

Resolves: #66217
Releases: master
Change-Id: If7d56148d9ee3ec3ea143bc422eeff4f2f4b8c03
Reviewed-on: https://review.typo3.org/51965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Mark login attempts as failed for anonymous sessions 16/52116/4
Mads Jensen [Wed, 22 Mar 2017 09:08:46 +0000 (10:08 +0100)]
[BUGFIX] Mark login attempts as failed for anonymous sessions

Fixes a bug where login attempts would not be marked with loginFailure
when an existing anonymous session exists.

Resolves: #80389
Releases: master
Change-Id: Id421d95fd5239c7a16e771463db3d9eb372d0340
Reviewed-on: https://review.typo3.org/52116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Morten Pless <mpl@systime.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] EXT:form - ignore removed form definitions in page module 17/52117/5
Ralf Zimmermann [Wed, 22 Mar 2017 09:28:55 +0000 (10:28 +0100)]
[BUGFIX] EXT:form - ignore removed form definitions in page module

Do not show labels from removed, renamed or invalid form
definitions within the page module preview hook.

Resolves: #80390
Releases: master
Change-Id: Ifc3f9a342ac1bda19831b9388dee04e34639503e
Reviewed-on: https://review.typo3.org/52117
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix typo in UserElement.php 38/52138/2
Jan Delius [Thu, 23 Mar 2017 16:22:40 +0000 (17:22 +0100)]
[BUGFIX] Fix typo in UserElement.php

Correct configuration is in fieldConf

Resolves: #80423
Releases: master
Change-Id: I605b9c76367081f1332c6ad61d4c342216992f1d
Reviewed-on: https://review.typo3.org/52138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix broken require / validation handling for ckeditor 34/52134/3
Frank Naegler [Thu, 23 Mar 2017 13:16:57 +0000 (14:16 +0100)]
[BUGFIX] Fix broken require / validation handling for ckeditor

This patch fix the broken require / validation handling for ckeditor.
To revalidate the form, the field is now updated on change and the
validation will be started.

Reolves: #80415
Releases: master
Change-Id: I731ffeb6a7fa217aa2c07004cdb424ea2a20f932
Reviewed-on: https://review.typo3.org/52134
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - add empty option to select elements 18/52018/7
Ralf Zimmermann [Mon, 13 Mar 2017 00:14:06 +0000 (01:14 +0100)]
[TASK] EXT:form - add empty option to select elements

Add configuration for fluid's select VH attribute 'prependOptionLabel'.

Resolves: #80192
Releases: master
Change-Id: Id045fac0d4d65ab4127607ec4ed1384757a0201f
Reviewed-on: https://review.typo3.org/52018
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Show only pages_language_overlay records with a defined language 33/52133/3
Georg Ringer [Thu, 23 Mar 2017 11:59:49 +0000 (12:59 +0100)]
[TASK] Show only pages_language_overlay records with a defined language

The list module must not use any pages_language_overlay records with
a sys_language_uid=0. First this doesn't make sense and furthermore
this has ugly side effects like an empty localize button.

Resolves: #80402
Releases: master
Change-Id: I97155ab66b2185d681e833a67448d3e565c7f521
Reviewed-on: https://review.typo3.org/52133
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Ensure correct sorting of extension configuration 80/51980/2
Nicole Cordes [Tue, 7 Mar 2017 22:18:00 +0000 (23:18 +0100)]
[BUGFIX] Ensure correct sorting of extension configuration

If an extension uses a default subcategory for its configuration but does
not define a sorting order, using PHP >= 7 the order is reversed. This
patch ensures an previously introduced counter is used as identifier.

Resolves: #80180
Related: #76386
Releases: master, 7.6
Change-Id: Ib480632213ebe090688da5ba30c031ca116cf9a9
Reviewed-on: https://review.typo3.org/51980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Wrong computed baseURL with FE editing RTE 89/51489/2
Pierrick Caillon [Tue, 31 Jan 2017 11:30:31 +0000 (12:30 +0100)]
[BUGFIX] Wrong computed baseURL with FE editing RTE

Frontend editing button for editing a content now
url encode the return URL. The HTMLAREA baseURL
computation now excludes query parameters and anchor
from the document URL.

Resolves: #79568
Related: #65705
Related: #65608
Releases: master
Change-Id: I57ae5257ab62cff1398a0b2d088fe7ba3b126c76
Reviewed-on: https://review.typo3.org/51489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] AllowLanguageSynchronization processes null values twice 91/52091/5
Oliver Hader [Sat, 18 Mar 2017 22:38:26 +0000 (23:38 +0100)]
[BUGFIX] AllowLanguageSynchronization processes null values twice

TCA columns having 'l10n_mode' defined to either 'exclude' or
'mergeIfNotBlank' (later is autotatically migrated to the according
'allowLanguageSynchronization' behavior) are processed twice on handling
modifications in DataHandler. In a result an exeception is throws which
prevents recursions on chained translations.

Checking null values with plain isset() is replaced with a new method
using array_key_exists() to consider null values as well.

Change-Id: I3f1b0cdf3f62845f3bae3632f6aaa9b2dfdc6e0b
Resolves: #80338
Releases: master
Reviewed-on: https://review.typo3.org/52091
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Refactor methods in DataHandler related to page delete access 97/51497/2
Stephan Großberndt [Wed, 1 Feb 2017 13:05:25 +0000 (14:05 +0100)]
[TASK] Refactor methods in DataHandler related to page delete access

* Removes usage of `rmComma()` and deprecates it
* Replaces usage of `noRecordsFromUnallowedTables()` with protected
method and deprecates it
* Removes duplicated code
* Improves variable names and type safety

Fixes: #79580
Releases: master
Change-Id: Ic9b95ede11adf73397b19f10acee58ba920624f7
Reviewed-on: https://review.typo3.org/51497
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Make frontend login compatible with csc and fsc 10/52110/7
Benjamin Kott [Tue, 21 Mar 2017 00:30:19 +0000 (01:30 +0100)]
[TASK] Make frontend login compatible with csc and fsc

Frontend login now uses fluid styled content as default rendering
definition. Additionally the loading order is changed to be always first
to enable more reliable overriding, also typoscript constants are now
available for the most common configurations.

Resolves: #80374
Releases: master
Change-Id: I81b6eca5d90284029c5bfaa99e82547ca248d5b0
Reviewed-on: https://review.typo3.org/52110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline form template files 21/52121/6
Benjamin Kott [Wed, 22 Mar 2017 13:13:52 +0000 (14:13 +0100)]
[TASK] Streamline form template files

For a more streamlined rendering this patch adds nessesary html tags
with fluid namespaces to all form templates, unifies indention
and adds an empty space before closing bracket of self-closing tags.
In addition the invalid end tag for thematic breaks was removed.

Resolves: #80393
Releases: master
Change-Id: Id9d8917b5d5f48a480da711490656cc24f18061d
Reviewed-on: https://review.typo3.org/52121
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] LocalizationStateSelector with new records 27/52127/3
Christian Kuhn [Wed, 22 Mar 2017 16:53:09 +0000 (17:53 +0100)]
[BUGFIX] LocalizationStateSelector with new records

The LocalizationStateSelector field wizard on new, not yet persisted records
casts the ['databaseRow']['uid'] to integer which leads to 0 if the uid is
'NEW1234...'.

Example (wrong) field name in formEngine:
 data[pages_language_overlay][0][l10n_state][subtitle]
Should:
 data[pages_language_overlay][NEW1234][l10n_state][subtitle]

Thus, field wizards values different from default are not stored.
The patch changes the int cast to an htmlspecialchars() to transfer
correct record uid for new records, too.

Change-Id: Ic77bf1c1e5fc0ebfcf8837bf6848ab1a201852a4
Resolves: #80405
Releases: master
Reviewed-on: https://review.typo3.org/52127
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] EXT:form - do not write placeholder attribute if empty 13/52113/2
Ralf Zimmermann [Tue, 21 Mar 2017 22:27:37 +0000 (23:27 +0100)]
[TASK] EXT:form - do not write placeholder attribute if empty

Do not write the placeholder html attribute if its value
is empty within the form editor.

Resolves: #80383
Releases: master
Change-Id: Icf514b49c73d3ccc9daa913dc55678bf7a57baa5
Reviewed-on: https://review.typo3.org/52113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update jQuery from 3.1.1 to 3.2.1 69/52069/6
Anders Kostending [Fri, 17 Mar 2017 08:15:28 +0000 (09:15 +0100)]
[TASK] Update jQuery from 3.1.1 to 3.2.1

Release notes:
 * Added support for custom CSS properties (#3144).
 * Deprecated jQuery.holdReady (#3288).
 * Deprecated jQuery.nodeName (#3475).
 * Deprecated jQuery.inArray (#2961).
 * Fixed a bug in .width(), .height(), and related
 methods where CSS transforms were included in the
 calculations. For instance, an element with the
 style transform: scale(2x) should not have its
 width and height values doubled (#3193).
 * Added support for <template> elements to the
 .contents() method (#3436).
 * Added back the deprecated module to the slim build.
 This change is largely insignificant given the
 module’s small size. We believe it makes more sense
 to remove deprecated pieces from the slim build
 at the same time as the main jQuery build (#3237).
* Ensure jQuery.holdReady is in the right place (#3573)
* Ensure we get proper values for width and height on
 elements with display “inline” (#3571)
* Ensure trigger data is passed to radio click event
 handlers (#3579)
* Revert: Trigger checkbox and radio click events identically
* Revert: Add radio click triggering tests

ChangeLog Compare:
https://github.com/jquery/jquery/compare/3.1.1...3.2.1

Resolves: #80313
Releases: master
Change-Id: I3f98247f28279bf68a0af4787aee996209ed1833
Reviewed-on: https://review.typo3.org/52069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Upgrade version of D3.js to version 4.7.3 73/52073/3
Anders Kostending [Fri, 17 Mar 2017 09:33:34 +0000 (10:33 +0100)]
[TASK] Upgrade version of D3.js to version 4.7.3

Release notes:
4.7.2
 * Optimize d3.pack.
 * Fix string coercion in transition.style and
 transition.attr.
 * Update dependencies.

4.7.3
 * Fix the Mercator projection’s built-in clipping when
 projection.rotate is used.
 * Fix the transverse Mercator projection’s built-in
 clipping when projection.rotate is used.
 * Fix the transverse Mercator projection’s built-in
 clipping when projection.clipExtent is used.

Resolves: #80320
Releases: master
Change-Id: Ief0e4c58506e162062e32fc166df9edcac9f87d2
Reviewed-on: https://review.typo3.org/52073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix tooltip after changing permissions 15/52115/2
Josef Glatz [Wed, 22 Mar 2017 08:29:30 +0000 (09:29 +0100)]
[BUGFIX] Fix tooltip after changing permissions

Fix js tooltip after permission settings are changed
in the permissions backend module.

Resolves: #80387
Releases: master, 7.6
Change-Id: I6be57ff0a48b3245c5e2d1aabc4260720c480e5f
Reviewed-on: https://review.typo3.org/52115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Deprecate BackendUtility::getRecordRaw 25/52125/2
Christian Kuhn [Wed, 22 Mar 2017 15:45:27 +0000 (16:45 +0100)]
[FOLLOWUP][TASK] Deprecate BackendUtility::getRecordRaw

Rename .rst file since the colons give headaches on windows.

Change-Id: I710a030ce7335b294d081e237a019cec6b7ca74f
Resolves: #80317
Releases: master
Reviewed-on: https://review.typo3.org/52125
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not clear constants in CSS Styled Content 18/52118/2
Benni Mack [Wed, 22 Mar 2017 09:32:57 +0000 (10:32 +0100)]
[TASK] Do not clear constants in CSS Styled Content

The constants within `styles.content` were cleared
via CSS Styled Content which did not allow to define
any constants before the TypoScript template was
included in that space.

Releases: master
Resolves: #80391
Change-Id: Ia96c3a3883d87eb9dba3f0a2b193738d9252d263
Reviewed-on: https://review.typo3.org/52118
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Deprecate BackendUtility::getRecordRaw 75/52075/9
Manuel Selbach [Fri, 17 Mar 2017 10:34:06 +0000 (11:34 +0100)]
[TASK] Deprecate BackendUtility::getRecordRaw

Since we follow the principle of "prepared statement", the method
getRecordRaw will break this behaviour. Within the "where" parameter
of the function it is possible to pass a malformed query part.

Thus we should remove it, as the queryBuilder should be used everywhere
in the future to increase visiblity of which query will be processed at
a concrete point of code and to force the concept of prepared statements.

Resolves: #80317
Releases: master
Change-Id: If0028bf897ddee4517228a9e399390fe7266215e
Reviewed-on: https://review.typo3.org/52075
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Flex form section container with group elements 05/52105/3
Christian Kuhn [Mon, 20 Mar 2017 17:28:17 +0000 (18:28 +0100)]
[BUGFIX] Flex form section container with group elements

The "create new flex form section container" ajax request fails to set
initialized data values of the data compiler to the render engine.
As a result, data values that expect to be at least an empty array
are null and for instance the GroupElement stumbles. Properly assign
calculated container data to the render engine to fix this.

Change-Id: I1205c2814608bbb23d4842333f0b047bc356b02a
Resolves: #80222
Releases: master
Reviewed-on: https://review.typo3.org/52105
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Language label and css loading in inline and flex sections 89/52089/3
Christian Kuhn [Fri, 17 Mar 2017 17:53:30 +0000 (18:53 +0100)]
[BUGFIX] Language label and css loading in inline and flex sections

Loading additional stylesheets from elements in inline scope fails if using
'EXT:' syntax, for flex section containers, this was not evaluated at all.
The patch adds code to resolve an EXT: prefix stylesheet file from an element
result array ['stylesheetFiles'] to properly handle loading of this CSS in
JS, and uses it in both inline and flex ajax controller. This issue is easily
reproducible with ext:styleguide 'elements_t3editor', which registers
t3editor.css to load. Without patch, This fail (404) in 'in inline'
't3editor_inline_1' 'Create New'.
Additionally, additional language file handling was not implemented for
flex section container ajax calls, which is also added by the patch,
similar to the solution done in inline ajax.

Change-Id: I617b9f1ed3e0c4718fb0867a42f2c37b604d7afe
Resolves: #80335
Releases: master
Reviewed-on: https://review.typo3.org/52089
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Clean up ['ctrl'] sortby and default_sortby 08/52108/2
Christian Kuhn [Mon, 20 Mar 2017 19:43:33 +0000 (20:43 +0100)]
[TASK] Clean up ['ctrl'] sortby and default_sortby

sortby: An integer field with an explicit sorting value

default_sortby: A query->orderBy statement to sort records
if no explicit sortby field is given.

default_sortby is ignored if sortby is given. The patch removes
a couple of TCA ['ctrl']['default_sortby'] declarations where both
were defined.

default_sortby needs no "ORDER BY" prefix. The patch removes it
from those TCA tables where this prefix was still defined.

Additionally, the TCA reference docs have been improved in this
area to hint about both fields and their correlation. It is especially
evil if that is confused and a field like 'title' is set as sortby:
The DataHandler would happily write integers into that field on save.

Change-Id: Ib5c38a538cd3f60d3e05033488363a144f756505
Resolves: #80361
Releases: master
Reviewed-on: https://review.typo3.org/52108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Preview pages with publish dates 98/52098/11
Susanne Moog [Mon, 20 Mar 2017 06:12:34 +0000 (07:12 +0100)]
[BUGFIX] Preview pages with publish dates

The view module already adds simTime to pages that have a publish date
set. With this change all places generating page preview links behave
in the same way, namely adding the simTime commands if the page has
publish date restrictions.

This change reverts f012052 and implements the behavior in a less
intrusive way.

Resolves: #66451
Releases: master
Change-Id: Idc740477d821ac32cd74dbec7b616b2794165ea9
Reviewed-on: https://review.typo3.org/52098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FOLLOWUP][TASK] EXT:form - change signal slots to hooks 88/52088/10
Ralf Zimmermann [Fri, 17 Mar 2017 16:46:07 +0000 (17:46 +0100)]
[FOLLOWUP][TASK] EXT:form - change signal slots to hooks

Resolves: #80333
Releases: master
Change-Id: I201392bc67228864e31d9e7117880fbb401af279
Reviewed-on: https://review.typo3.org/52088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:form - change type of getRendererClassName() to string 97/51997/5
Martin Kutschker [Fri, 3 Mar 2017 23:12:51 +0000 (23:12 +0000)]
[BUGFIX] EXT:form - change type of getRendererClassName() to string

Fix incompatible return types of getRendererClassName()
Make sure it is a string in all interfaces and implementations.

Resolves: #80230
Releases: master
Change-Id: I59cd0a1222e3aa67c742ca41331af2ddc4a1ee51
Reviewed-on: https://review.typo3.org/51997
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Check if install tool enable file exists before removing it 00/52100/3
Michael Stucki [Mon, 20 Mar 2017 13:04:43 +0000 (14:04 +0100)]
[BUGFIX] Check if install tool enable file exists before removing it

The is_file() check got lost during the refactoring in
d855b4707ba1198b6c1dbf856c4377e230da4c4b.

Change-Id: Ia1688099a7ccd32667562e8c7f83fd54bb669f4a
Resolves: #80354
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52100
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup FSC/CSC typoscript 95/52095/2
Josef Glatz [Sun, 19 Mar 2017 21:16:28 +0000 (22:16 +0100)]
[TASK] Cleanup FSC/CSC typoscript

* remove/update inline comments
* improve legibility by proper indentation and CGL

Resolves: #80346
Releases: master
Change-Id: I51207c0a54b18f78b1a0dd4313b398908ea2f021
Reviewed-on: https://review.typo3.org/52095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - Render form name in form tree correctly 94/52094/3
Martin Kutschker [Sat, 4 Mar 2017 20:48:19 +0000 (20:48 +0000)]
[BUGFIX] EXT:form - Render form name in form tree correctly

Do not double-encode name with HTML entities.

Resolves: #80343
Releases: master
Change-Id: If8e3757f0d34712f0daf03122e61b6ef06a1ccd0
Reviewed-on: https://review.typo3.org/52094
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not compile parent config in inline ajax controller 77/52077/4
Christian Kuhn [Fri, 17 Mar 2017 11:14:29 +0000 (12:14 +0100)]
[BUGFIX] Do not compile parent config in inline ajax controller

Using the signed parent tca config incoming via ajax request in the
inline ajax controller solves a series of issues in 'new' and other
scopes.
The expensive calculation of inline parent TCA config within the
controller can be dropped.

Change-Id: I4ff31d0398ebfa1bb311bbe6ea97c839aa2df1ac
Resolves: #80325
Resolves: #76671
Releases: master
Reviewed-on: https://review.typo3.org/52077
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use correct language sorting in TCA field language of pages_language_overlay 99/52099/2
Georg Ringer [Mon, 20 Mar 2017 12:34:40 +0000 (13:34 +0100)]
[TASK] Use correct language sorting in TCA field language of pages_language_overlay

Since #77652 the languages are sorted manually using a sorting field. Use this
field also in the language selection of pages_language_overlay.

Resolves: #80351
Releases: master
Change-Id: I490aa5c477cc2c45110a658e05b42e75f0528610
Reviewed-on: https://review.typo3.org/52099
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>