Packages/TYPO3.CMS.git
5 years ago[BUGFIX] List module pagination broken 49/29949/3
Markus Klein [Thu, 8 May 2014 18:07:13 +0000 (20:07 +0200)]
[BUGFIX] List module pagination broken

A wrong formula is used to calculate the pointer
for the pages.
This patch also introduces a central function for
calculating the pointer to a page.

Resolves: #55320
Releases: 6.2
Change-Id: Ia4eec61f4f87b52d0d5e940e542998f9f82aa140
Reviewed-on: https://review.typo3.org/29949
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Old TYPO3 logo still in use in ext:workspaces 48/30548/2
Wouter Wolters [Tue, 3 Jun 2014 21:38:05 +0000 (23:38 +0200)]
[BUGFIX] Old TYPO3 logo still in use in ext:workspaces

Replace old logo with the new logo.

Resolves: #59321
Releases: 6.2
Change-Id: I1b4386e0ee614096b4033f00d9fe9136d11a63c7
Reviewed-on: https://review.typo3.org/30548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] DataHandler::log() must not return NULL 79/30479/3
Markus Klein [Wed, 28 May 2014 17:38:29 +0000 (19:38 +0200)]
[BUGFIX] DataHandler::log() must not return NULL

Ensure the DataHandler::log() function does return integers
in all cases as denoted in the doc header.

Resolves: #59185
Releases: 6.2, 6.1, 6.0
Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1
Reviewed-on: https://review.typo3.org/30479
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Check and use current file hash and size on export 61/30061/3
Marc Bastian Heinrichs [Tue, 13 May 2014 14:26:11 +0000 (16:26 +0200)]
[TASK] Check and use current file hash and size on export

On creating exports the file hash and size is used from the
sys_file table. Since this could be not up-to-date in real live
projects, those files fail to be imported.

To prevent this, use the correct data for the export and show
an error to the user.

Resolves: #58761
Releases: 6.2
Change-Id: I7aacc6f00c52bc01c753af4ee32202a9219c02a1
Reviewed-on: https://review.typo3.org/30061
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use created folder object for adding images in impexp 84/29984/2
Marc Bastian Heinrichs [Fri, 9 May 2014 16:04:34 +0000 (18:04 +0200)]
[BUGFIX] Use created folder object for adding images in impexp

A folder to be created could change the name by sanitizing. So
the name of the created folder could differ from the requested
name. For adding the image the returned folder object should be
used.

To avoid that sanitized ones should be created over and over again
a mapping is buffered.

Resolves: #58682
Releases: 6.2
Change-Id: Ia3443c36c6dda8531c8791c221d2a835b25b10b2
Reviewed-on: https://review.typo3.org/29984
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ElementBrowser: correct link attributes 83/30483/3
Markus Klein [Thu, 29 May 2014 10:40:58 +0000 (12:40 +0200)]
[BUGFIX] ElementBrowser: correct link attributes

This is a regression fix for #55983, which introduced
additional urlencoding for title, class, ...

Remove the encoding again.

Resolves: #59199
Releases: 6.2
Change-Id: I28650676f4ae0b74256a770af12054750027cbfa
Reviewed-on: https://review.typo3.org/30483
Reviewed-by: Markus Bucher
Tested-by: Markus Bucher
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix wrong JS function name in RTE 31/30531/2
Markus Klein [Tue, 3 Jun 2014 10:02:04 +0000 (12:02 +0200)]
[BUGFIX] Fix wrong JS function name in RTE

RTE feature "userlinks" generates a wrong JS function
name due to the automatic replacement during the
namespace conversion.

Revert this line to use the correct JS function name.

Resolves: #59302
Releases: 6.2, 6.1, 6.0
Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97
Reviewed-on: https://review.typo3.org/30531
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Canonicalize path before checking existence 32/30532/3
Nils Blattner [Tue, 3 Jun 2014 11:14:57 +0000 (13:14 +0200)]
[BUGFIX] Canonicalize path before checking existence

ResourceFactory fails to detect files in symlinked
scenarios, because the path is not canonicalized before
file existence is checked.

Solution is to canonicalize it and check then.

Resolves: #59303
Releases: 6.2
Change-Id: I4fd763f7076e909f2163af79ed2b7f8642da8ed7
Reviewed-on: https://review.typo3.org/30532
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Request update broken for select fields 44/30044/2
Francois Suter [Tue, 13 May 2014 11:09:32 +0000 (13:09 +0200)]
[BUGFIX] Request update broken for select fields

For select-type fields displayed as two side-by-side selectors
which are registered as "requestUpdate" fields, the form submission
happens before the value is copied to the left-hand selector.
The form is thus saved without value.

Full description in the bug report, which also contains a
test extension and steps to reproduce.

Resolves: #58755
Releases: 6.2
Change-Id: Ie94def723537202287655c650cee7dfa09815f4f
Reviewed-on: https://review.typo3.org/30044
Reviewed-by: Peter Foerger
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Tomas Norre Mikkelsen
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA maxitems for FAL permissions wrong 18/30518/2
Markus Klein [Mon, 2 Jun 2014 13:49:03 +0000 (15:49 +0200)]
[BUGFIX] TCA maxitems for FAL permissions wrong

The setting for maxitems in the TCA of be_users and be_groups for
FAL permissions are wrong.
Fix the value to match the number of available options.

Resolves: #59263
Releases: 6.2
Change-Id: Ib38aab8bbd1f5fe9287ff0523139f88520f27e37
Reviewed-on: https://review.typo3.org/30518
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Make object access work with ObjectStorage 23/29923/6
Helmut Hummel [Wed, 7 May 2014 17:30:57 +0000 (19:30 +0200)]
[BUGFIX] Make object access work with ObjectStorage

ObjectAccess->getPropertyPath() does not work with
ObjectStorage and numerical indexes, but it should be
because without it form fluid fields cannot be
properly handled as the value is always null.

Fixing fetching objects from ObjectStorage by index
will also enable shorter access of single objects in Fluid.

Imagine you want to render the first image in your
template. Previously you had to write this:

<f:for each="{object.images}" as="image" iteration="iterator">
<f:if condition="{iterator.isFirst}">
<f:image image="{image}" alt="" width="50"/>
</f:if>
</f:for>

Now you can just write:

<f:image image="{object.images.0}" alt="" width="50"/>

Resolves: #37126
Related: #37000
Releases: 6.2
Change-Id: I45122bd145b5a179ad3e9e3894520f9a614906c8
Reviewed-on: https://review.typo3.org/29923
Reviewed-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Fabien Udriot
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Keep session cookie if session data is present 85/30485/5
Helmut Hummel [Sun, 1 Jun 2014 12:20:17 +0000 (14:20 +0200)]
[BUGFIX] Keep session cookie if session data is present

The AbstractUserAuthentication::checkAuthentication() method calls
the logoff() method on every failed login attempt.

Since a logoff also causes a removal of the cookie,
any (anonymous) session data will be left unaccessible.

Keep the cookie when session data is present.

Releases: 6.2
Resolves: #58713
Change-Id: I744456f62197a7278635d8564d4883564d954dd2
Reviewed-on: https://review.typo3.org/30485
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Always add wrapping div if dividers2tabs is disabled 61/30461/3
Frans Saris [Wed, 28 May 2014 08:04:09 +0000 (10:04 +0200)]
[BUGFIX] Always add wrapping div if dividers2tabs is disabled

TCEforms is not wrapped in a div when dividers2tabs is disabled
and a inline-element form element is present. As a result there
is no background image/color shown.

This changes removes the check as the wrap is also needed when
inline-elements are present.

Resolves: #59163
Releases: 6.2
Change-Id: I8772fce0d99bacdf18692308c700c02c0a0defcf
Reviewed-on: https://review.typo3.org/30461
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Do not use self:: within closures 89/30489/2
Markus Klein [Thu, 29 May 2014 14:39:20 +0000 (16:39 +0200)]
[BUGFIX] Do not use self:: within closures

This is not possible in PHP 5.3.

Resolves: #59203
Releases: 6.2
Change-Id: I108578f7635c50493a3b5d7a7fc81c021805abf8
Reviewed-on: https://review.typo3.org/30489
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Flexform element title is cropped to hardcoded length 42/30242/3
Sebastian Michaelsen [Wed, 21 May 2014 07:53:52 +0000 (09:53 +0200)]
[BUGFIX] Flexform element title is cropped to hardcoded length

The title of a flexform element is cropped to maximum length of 30
characters. Instead it should obey the maximum title length in the user
settings.

Resolves: #58910
Releases: 6.2, 6.1
Change-Id: I28c6fc94b2d492217479bf014ff8f67463b4e98f
Reviewed-on: https://review.typo3.org/30242
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Admin panel text selection 18/30118/5
Goran Medakovic [Wed, 14 May 2014 16:26:35 +0000 (18:26 +0200)]
[BUGFIX] Admin panel text selection

Fixes: #58485
Releases: 6.2
Change-Id: I9c3243b2cca9edb89d262a4d3f9cde17b906d440
Reviewed-on: https://review.typo3.org/30118
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use self:: where possible in GeneralUtility 57/30257/2
Sebastian Michaelsen [Wed, 21 May 2014 14:10:16 +0000 (16:10 +0200)]
[TASK] Use self:: where possible in GeneralUtility

It's common sense to use self:: where possible because it's quicker and
makes code better understandable.

This change fixes 2 violations in \TYPO3\CMS\Core\Utility\GeneralUtility

Releases: 6.2
Resolves: #59001
Change-Id: Ie56a6697186426e3ff082b1694572c885c8420f5
Reviewed-on: https://review.typo3.org/30257
Reviewed-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix redirect to install tool in new installations 76/30376/6
Markus Klein [Sat, 24 May 2014 18:45:17 +0000 (20:45 +0200)]
[BUGFIX] Fix redirect to install tool in new installations

When setting up a new TYPO3 installation, TYPO3 should redirect
to the install tool, when accessing the frontend or backend.

This redirect fails since introduction of the trustedHostsPattern
since no configuration is available at this point, while the
request itself is a BE or FE request, which will be denied in this
case.
Solution is to set the REQUEST_TYPE to INSTALL before doing the redirect
to install tool so that creating the redirect is allowed.

Resolves: #59087
Releases: 6.2, 6.1
Change-Id: I31bcbc20fa1c9bca0d6bf2b940bf26b9affe893b
Reviewed-on: https://review.typo3.org/30376
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] EM: Handle missing dependencies in emconf 47/29947/2
Markus Klein [Thu, 8 May 2014 16:48:11 +0000 (18:48 +0200)]
[BUGFIX] EM: Handle missing dependencies in emconf

ext_emconf.php may lack the dependencies array. This will cause
a PHP warning in a foreach loop.

Fix this by checking for the type first.

Resolves: #58640
Releases: 6.2
Change-Id: Ifb04268e04f5349282f895f6b3d7354dbc45affc
Reviewed-on: https://review.typo3.org/29947
Reviewed-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Indexed search static call to non-static function 69/30069/3
Markus Klein [Tue, 13 May 2014 15:57:58 +0000 (17:57 +0200)]
[BUGFIX] Indexed search static call to non-static function

Resolves: #58756
Releases: 6.2
Change-Id: Ide09c7792e9b24afe480230893cac18570ce4f19
Reviewed-on: https://review.typo3.org/30069
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Correct minor typo in "About TYPO3 CMS" 76/30476/3
Michael Schams [Wed, 28 May 2014 14:52:53 +0000 (00:52 +1000)]
[BUGFIX] Correct minor typo in "About TYPO3 CMS"

This patch corrects a minor typo in module: Web -> About TYPO3 CMS.
It currently reads "TYPO3 CMS is a enterprise-class...", but it should
read: "...is an enterprise..." ("an" with a "n").

Resolves: #59187
Releases: 6.2
Change-Id: I4e77e54dded08ef4cbdd484d81660a1e39241986
Reviewed-on: https://review.typo3.org/30476
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Parent language is not applied to new child records 48/30448/2
David Greiner [Tue, 27 May 2014 14:07:41 +0000 (16:07 +0200)]
[BUGFIX] Parent language is not applied to new child records

If localizing a parent-child structure, usually the language
of the parent element shall be applied to related child records
as well as new child records.

Due to a missing array segment, the accordant section in the
the InlineElement source code never was processed.

Resolves: #57063
Releases: 6.2, 6.1
Change-Id: I7e563044f9889538f9b8171f71f7685722db8266
Reviewed-on: https://review.typo3.org/30448
Reviewed-by: Markus Klein
Reviewed-by: David Greiner
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Added missing TCEforms palette-header padding 58/30458/3
Frans Saris [Wed, 28 May 2014 07:09:27 +0000 (09:09 +0200)]
[BUGFIX] Added missing TCEforms palette-header padding

With the cleanup of the backend styles a padding of the
pallete header got missing.

This patch adds this padding just like the other headers
in the TCEforms.

Resolves: #59160
Releases: 6.2
Change-Id: I25ca0ccb0bbd7f4f6d014e12f1cebe1b12050718
Reviewed-on: https://review.typo3.org/30458
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] New content elements are always stored on pid 0 89/30389/3
Nicole Cordes [Sun, 25 May 2014 17:30:54 +0000 (19:30 +0200)]
[BUGFIX] New content elements are always stored on pid 0

Due to patch https://review.typo3.org/#/c/30305/ the string comparison
on colPos fails and new content elements are always stored on pid 0.
This patch corrects the check for an integer colPos type by setting the
unused variable to NULL.

Resolves: #59059
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Iecd7f0cacf5c9315d882eebeb3893bcfa63ae7eb
Reviewed-on: https://review.typo3.org/30389
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Inserting custom element in RTE throws exception 21/30221/2
Stanislas Rolland [Tue, 20 May 2014 00:15:50 +0000 (20:15 -0400)]
[BUGFIX] Inserting custom element in RTE throws exception

Problem: Token validation fails.
Solution: Use BackendUtility::getModuleUrl to ensure validity of token.

Resolves: #58371
Releases: 6.2
Change-Id: I334826dbeb2a11a6b28d4fd610670fe4d7558e1a
Reviewed-on: https://review.typo3.org/30221
Tested-by: Chris Müller
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Alternative implementations for view helpers do not work 57/24057/8
Marc Bastian Heinrichs [Sat, 15 Feb 2014 10:29:55 +0000 (11:29 +0100)]
[BUGFIX] Alternative implementations for view helpers do not work

Extbase allows to register alternative implementations for
objects. However that does not work for view helpers using
a closing tag. The resolved (alternative) object is compared
to the name of the original view helper and throws an
exception like:

  #1224485398: Templating tags not properly nested. Expected:
  "AlternativeViewHelper"; Actual: "OriginalViewHelper"

A simple solution is to save the class name of the object returned
from the object manager in a runtime cache and check this when
resolving a view helper name. A nice side effect is, that a same
view helper name must not be calculated over and over again.

Fixes: #52272
Releases: 6.0, 6.1, 6.2
Change-Id: Ie49e5e83c779b4748dc2059f8fbc85552ce4b406
Reviewed-on: https://review.typo3.org/24057
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Raise maximum settable numbers in export 02/30202/2
Marc Bastian Heinrichs [Mon, 19 May 2014 09:43:07 +0000 (11:43 +0200)]
[TASK] Raise maximum settable numbers in export

The maximums for today's exports are limited to strict.
It's 10MB for a settable file size included in exports;
raise it to 1000MB. The maximum settable number of
records is 10000; raise it to 1000000.

Resolves: #58912
Releases: 6.2
Change-Id: If2613b453cfbfda5c4909770064f112c23eca83b
Reviewed-on: https://review.typo3.org/30202
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[CLEANUP] Code cleanup for LanguageService 60/30260/3
Sebastian Michaelsen [Wed, 21 May 2014 15:00:36 +0000 (17:00 +0200)]
[CLEANUP] Code cleanup for LanguageService

* Avoid unnecessary fully qualified class names
* Add return NULL for consistency if a method only returns a value
  in some cases

Releases: 6.2
Resolves: #59006
Change-Id: I8c005a3e20fc49d65123e415025bef1c41ad7854
Reviewed-on: https://review.typo3.org/30260
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix saving non public export presets 12/30112/2
Marc Bastian Heinrichs [Wed, 14 May 2014 14:34:42 +0000 (16:34 +0200)]
[BUGFIX] Fix saving non public export presets

Fix sql error "Column 'public' cannot be null" on saving
with unchecked box public.

Resolves: #57405
Releases: 6.2
Change-Id: I1582728cc56781fdc12409956008fc82a6cd0d03
Reviewed-on: https://review.typo3.org/30112
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Set default permissions for new files to 0664 13/30113/2
Caspar Stuebs [Wed, 14 May 2014 14:34:52 +0000 (16:34 +0200)]
[BUGFIX] Set default permissions for new files to 0664

Change-Id: I4c71414dca763d9ba29ab93b18a0389941f51af7
Resolves: #58809
Releases: 6.2
Reviewed-on: https://review.typo3.org/30113
Reviewed-by: Dmitry Dulepov
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix url for youtube embeds 52/29952/3
Thomas Löffler [Thu, 8 May 2014 19:14:16 +0000 (21:14 +0200)]
[BUGFIX] Fix url for youtube embeds

Additionally solve the problem when http:// is missing
due to usage of the link wizard.

Change-Id: I676d14b4ddf81d5d3ec0fc0d0ebb32d08910047a
Resolves: #58569
Resolves: #58986
Releases: 6.2
Reviewed-on: https://review.typo3.org/29952
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Wrong HTML in locallang_csh_pages.xlf 20/30220/2
Markus Klein [Mon, 19 May 2014 18:38:30 +0000 (20:38 +0200)]
[BUGFIX] Wrong HTML in locallang_csh_pages.xlf

lang/4.5/locallang_csh_pages.xlf contains invalid
HTML structure a <p> tag should actually be a <b> tag.

Resolves: #58936
Releases: 6.2, 6.1, 4.5
Change-Id: Id37d424296628202d8d434e0cf9cafd8529da2c3
Reviewed-on: https://review.typo3.org/30220
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix relative path resolution in include static 68/29468/4
Markus Klein [Mon, 14 Apr 2014 23:01:50 +0000 (01:01 +0200)]
[BUGFIX] Fix relative path resolution in include static

Fix the usage of relative paths in INCLUDE_TYPOSCRIPT inclusions of
static templates from extensions.

EXT:myext/Configuration/TypoScript/setup.txt:
<INCLUDE_TYPOSCRIPT: source="DIR:./Setup/">

EXT:myext/Configuration/TypoScript/Setup/ holds some TS files.

Resolves: #57447
Releases: 6.2
Change-Id: I64ba190fa6959eb27a2d6f1c278cfb9c9c3cbfaf
Reviewed-on: https://review.typo3.org/29468
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jan Kiesewetter
Tested-by: Jan Kiesewetter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath 67/29467/4
Markus Klein [Mon, 14 Apr 2014 22:50:49 +0000 (00:50 +0200)]
[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath

PathUtility::getAbsolutePathOfRelativeReferencedFileOrPath()
Add a check to the function to identify a given basepath as described
in the function header.

Resolves: #57918
Releases: 6.2, 6.1
Change-Id: I8de12cb917b2f32490bb160686ce06a036abfd85
Reviewed-on: https://review.typo3.org/29467
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix failing unit tests for HTTP host check in CLI mode 23/30323/4
Helmut Hummel [Thu, 22 May 2014 09:33:09 +0000 (11:33 +0200)]
[BUGFIX] Fix failing unit tests for HTTP host check in CLI mode

The unit tests for the recent HTTP host fix are failing
if executed in CLI mode.
In CLI mode no server environments and HTTP headers are available,
that's why the behavior needs to know about the
test execution process.

We solve this by mocking allowed request types.

Resolves: #59022
Releases: 6.2, 6.1, 6.0
Change-Id: I3c93d181dcec5f34064798e7c31240877fde610d
Reviewed-on: https://review.typo3.org/30323
Reviewed-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.2.4-dev 17/30317/2
TYPO3 Release Team [Thu, 22 May 2014 08:33:00 +0000 (10:33 +0200)]
[TASK] Set TYPO3 version to 6.2.4-dev

Change-Id: Ic42722b40b91e61dfd839241b91b9ff31a322259
Reviewed-on: https://review.typo3.org/30317
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.3 16/30316/2 6.2.3 TYPO3_6-2-3
TYPO3 Release Team [Thu, 22 May 2014 08:32:30 +0000 (10:32 +0200)]
[RELEASE] Release of TYPO3 6.2.3

Change-Id: Ib7b6505d59bdec51f537afec80678c11c0ad0b89
Reviewed-on: https://review.typo3.org/30316
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[SECURITY] Add trusted HTTP_HOST configuration 07/30307/2
Helmut Hummel [Thu, 22 May 2014 07:34:08 +0000 (09:34 +0200)]
[SECURITY] Add trusted HTTP_HOST configuration

TYPO3 uses the values of HTTP_HOST in several
places without validating them. This could
lead to a situation where links are generated
using the host part from HTTP_HOST.

Since HTTP_HOST headers are user input and
can be spoofed by an attacker, it leads
into several potential and actual security issues.

To address this, a configuration option for
trusted hosts is added, which is evaluated every
time getIndpEnv('HTTP_HOST') is called.

The configuration option is

$GLOBALS['TYPO3_CONF_VARS']['SYS']['trustedHostsPattern']

and can contain either a regular expression or the
value "SERVER_NAME"

To properly output the exception message in case
the trustedHostPattern does not match,
we need to adapt the exception handlers slightly
to not log information in this case and to actually
show the message even in production context to not
confuse admins on what is currently going wrong.

To not break all existing installations, the default
pattern is set to 'SERVER_NAME' which allows all
HTTP_HOST values matching the SERVER_NAME (and
optionally the SERVER_PORT if a port is specified
in the HTTP_HOST value).

This will secure all installation which use properly
configured name based virtual hosts, but leaves
installations where the web server is not bound
to a specific host name still in an insecure state.

Change-Id: I42fe77fe919755942636108a71c31175647449a9
Fixes: #30377
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30307
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in (old) extension manager information function 06/30306/2
Nicole Cordes [Thu, 22 May 2014 07:34:03 +0000 (09:34 +0200)]
[SECURITY] XSS in (old) extension manager information function

Needs to be fixed also in 6.x, but the affected function is not
used anymore.

Change-Id: If10b0cf25015eada0657aaebc19da3e3364f738a
Fixes: #54111
Fixes: #54113
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: d23f0ccc8960832c184a0e6c5daced98a0b6d096
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30306
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in new content element wizard 05/30305/2
Marcus Krause [Thu, 22 May 2014 07:33:58 +0000 (09:33 +0200)]
[SECURITY] XSS in new content element wizard

Sanitize user-input colPos in new content element wizard.

Change-Id: Ifa90ea1ede3b6c2a5436c505993c533803306d01
Fixes: #48695
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: bad0160450fb5786e1cb1e393c76c3da38c2ffe7
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30305
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in template tools on root page 04/30304/2
Marc Bastian Heinrichs [Thu, 22 May 2014 07:33:51 +0000 (09:33 +0200)]
[SECURITY] XSS in template tools on root page

Change-Id: I2b5214e666d1c9edc5354dd3983401038e9aaf66
Fixes: #54109
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: e17bc3297e95f6ffd5d1df682235bfaac7a5ad53
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30304
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in Backend Layout Wizard 03/30303/2
Helmut Hummel [Thu, 22 May 2014 07:33:47 +0000 (09:33 +0200)]
[SECURITY] XSS in Backend Layout Wizard

Change-Id: I096d26b3eee20493b146633bda11529890be59dc
Fixes: #57576
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: b49bd72b12f709e1c3dffd4f471d138ad1dcceb5
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30303
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Encode URL for use in JavaScript 02/30302/2
Jigal van Hemert [Thu, 22 May 2014 07:33:41 +0000 (09:33 +0200)]
[SECURITY] Encode URL for use in JavaScript

The url for the Open in New Window button must be quoted for
use in JavaScript to prevent XSS issues.

Change-Id: I3e55f31c3c857989d71a5ef1a0368b96aa5e2c31
Fixes: #48693
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 4d9cd3e6f589c77b5a366497a33f7eb2099dc749
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30302
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Session timeout can be circumvented once 01/30301/2
Markus Klein [Thu, 22 May 2014 07:33:36 +0000 (09:33 +0200)]
[SECURITY] Session timeout can be circumvented once

Fix the AbstractUserAuthentication class to properly invalidate
the current session if it timed out.

Change-Id: Id50ee1abd197674fa9379b52b46b63ecf770c964
Fixes: #57673
Releases: 6.2
Security-Commit: 38e24be1ff26fa181f16b91c57a0fcbe4da5065a
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30301
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] Remove charts.swf to get rid of XSS vulnerability 00/30300/2
Helmut Hummel [Thu, 22 May 2014 07:33:31 +0000 (09:33 +0200)]
[SECURITY] Remove charts.swf to get rid of XSS vulnerability

The file charts.swf is vulnerable to XSS, is delivered
by ExtJS but not used in TYPO3 CMS at all.

Since the vendor of ExtJS did not fix this vulnerability,
we decided to remove it from TYPO3 sources.

Change-Id: Ib30cac84983f5a30956d0a09af933b0fbca1d6ff
Fixes: #54526
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Security-Commit: 2402b6cfa3ab2a054ef3e28f3d8de8f7dfee17ec
Security-Bulletin: TYPO3-CORE-SA-2014-001
Reviewed-on: https://review.typo3.org/30300
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] RTE Remove Format removes too much 23/30223/2
Stanislas Rolland [Tue, 20 May 2014 01:08:22 +0000 (21:08 -0400)]
[BUGFIX] RTE Remove Format removes too much

The remove format function with msword selected removes too much
content when there is more than one style block in content.

Note: Thanks to Volker Burggräf

Resolves: #58310
Releases: 6.2, 6.1, 4.5
Change-Id: Ia29767239d92fde20ceee97ece47786d3fd3a9a5
Reviewed-on: https://review.typo3.org/30223
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] indexed_search plugin cannot be translated 03/30103/5
Robert Vock [Wed, 14 May 2014 11:30:34 +0000 (13:30 +0200)]
[BUGFIX] indexed_search plugin cannot be translated

The experimental extbase plugin of indexed_search is not
translatable on Pootle because it is still using locallang.xml
instead of a XLIFF translation file.

Change-Id: Ia3a45573737f8be0f802bfdbf5bd4f36add66b07
Resolves: #58796
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30103
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Missing check if $row[t3ver_state] is set in IconUtility 52/30152/5
Frans Saris [Thu, 15 May 2014 20:21:57 +0000 (22:21 +0200)]
[BUGFIX] Missing check if $row[t3ver_state] is set in IconUtility

As a result of a missing check if $row['t3ver_state'] exists,
an exception is thrown when IconUtility::getIcon() is called
with only the required params set.

This patch adds the missing check.

Resolves: #58846
Releases: 6.2
Change-Id: I70da9ee79a5c0ee1ad4fe8892e8ed28f904a11da
Reviewed-on: https://review.typo3.org/30152
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Cleanup DataHandler functional tests 77/30177/3
Oliver Hader [Fri, 16 May 2014 12:27:29 +0000 (14:27 +0200)]
[TASK] Cleanup DataHandler functional tests

Some DataHandler functional test cases are duplicated or are not
required anymore. Here's a list of what has changed and moved
into some existing testing structure:

Core:
* DataHandlerTest::canCreateTtContent
** Regular\Modify\ActionTest::createContents
* DataHandlerTest::canLocalizeTtContent
** Regular\Modify\ActionTest::localizeContent
* DataHandlerTest::canCopyPasteTtContent
** Regular\Modify\ActionTest::copyPasteContent
* DataHandlerTest::canCutPasteTtContent
** Regular\Modify\ActionTest::movePasteContentToDifferentPage
* IRRE\MtoNMMAsymetricLocalizationKeepTest::*
** IRRE\CSV\Modify\ActionTest::localizeParentContent*
** IRRE\ForeignField\Modify\ActionTest::localizeParentContent*
* IRRE\MtoNMMAsymetricLocalizationSelectTest::*
** IRRE\CSV\Modify\ActionTest::localizeParentContent*
** IRRE\ForeignField\Modify\ActionTest::localizeParentContent*

Workspaces:
* IRRE\MToNMMTest::*
** ManyToMany\Modify\ActionTest::*
** ManyToMany\Publish\ActionTest::*
** ManyToMany\PublishAll\ActionTest::*
* IRRE\OneToNCSVTest::*
** IRRE\CSV\Modify\ActionTest::*
** IRRE\CSV\Publish\ActionTest::*
** IRRE\CSV\PublishAll\ActionTest::*
* IRRE\OneToNForeignFieldTest::*
** IRRE\ForeignField\Modify\ActionTest::*
** IRRE\ForeignField\Publish\ActionTest::*
** IRRE\ForeignField\PublishAll\ActionTest::*

Resolves: #58870
Releases: 6.2
Change-Id: I0c75fcf826d05f8515a5609cb00c153992ba7b44
Reviewed-on: https://review.typo3.org/30177
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Extend DataHandler IRRE functional tests 76/30176/3
Oliver Hader [Fri, 16 May 2014 11:40:33 +0000 (13:40 +0200)]
[TASK] Extend DataHandler IRRE functional tests

Extend CSV and ForeignField test with
* copyParentContentToDifferentPage
* modifyHotelChild

Resolves: #58854
Releases: 6.2
Change-Id: Iba332ccee1728bf1e28ff5719029b6ab73a30c53
Reviewed-on: https://review.typo3.org/30176
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Unify DataHandler test structure 75/30175/2
Oliver Hader [Fri, 16 May 2014 11:23:31 +0000 (13:23 +0200)]
[TASK] Unify DataHandler test structure

Resolves: #58868
Releases: 6.2
Change-Id: I0f5aeb1d211e542cb323fba11b07a0b8be7d3ed0
Reviewed-on: https://review.typo3.org/30175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong system requirements link 50/30150/3
Markus Klein [Thu, 15 May 2014 17:08:06 +0000 (19:08 +0200)]
[BUGFIX] Wrong system requirements link

Resolves: #58842
Releases: 6.2, 6.1
Change-Id: Ibaf87d32778349d5a87009bcd2b365447e6488fa
Reviewed-on: https://review.typo3.org/30150
Reviewed-by: Johannes Kasberger
Tested-by: Johannes Kasberger
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Wrong path reference for installToolPassword option 27/30027/4
Markus Klein [Mon, 12 May 2014 17:01:02 +0000 (19:01 +0200)]
[BUGFIX] Wrong path reference for installToolPassword option

The [BE][installToolPassword] contains a suggestion to additionally
protect the Install Tool by protecting its folder by some server means.
The path specified is the legacy path /typo3/install/ which is only
a redirect to typo3/sysext/install/Start/, so the protection should
be on that folder.

Resolves: #58720
Releases: 6.2
Change-Id: I593b54878d0be7bd0307a6a5625173e6bbc58fa0
Reviewed-on: https://review.typo3.org/30027
Reviewed-by: Christian Ludwig
Tested-by: Christian Ludwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Restore registers before early returns 80/28280/3
Jo Hasenau [Tue, 11 Mar 2014 22:34:04 +0000 (23:34 +0100)]
[BUGFIX] Restore registers before early returns

Having an empty image list or a list of images with empty values
will not restore the loaded registers.
So we must restore the registers before any return.

Additionally, the $conf array does not need to contain any
values when calling RESTORE_REGISTER, since it won't handle
parameters anyway, so parameters would just waste memory.

Resolves: #56796
Releases: 6.2
Change-Id: I3e81c614b5c37a14da4b97e18a310e202ae7b766
Reviewed-on: https://review.typo3.org/28280
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Don't rely on not found database records impexp 93/29993/3
Marc Bastian Heinrichs [Fri, 9 May 2014 16:51:45 +0000 (18:51 +0200)]
[BUGFIX] Don't rely on not found database records impexp

The function exec_SELECTgetSingleRow could also return
FALSE in addition to NULL, so add a additional check.

Resolves: #58688
Resolves: #57348
Releases: 6.2
Change-Id: Ic04071f67f02cce12b11c34d46c084bc28ccc83a
Reviewed-on: https://review.typo3.org/29993
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] MM relations are not correctly resolved in Backend view 37/30037/2
Oliver Hader [Tue, 13 May 2014 08:19:58 +0000 (10:19 +0200)]
[BUGFIX] MM relations are not correctly resolved in Backend view

DataPreprocessor is taking care of preparing data for the form
view processed in the FormEngine. However, MM relations are not
correctly resolved in a workspace context.

The method DataPreprocessor::getDataIdList() is used for a mixed
kind of relations there, without properly applying the differences
for MM records. The rule is, to always use the live default id,
except for MM relations - use the specific workspace value.

Resolves: #58735
Releases: 6.2
Change-Id: I256969adb46bfea80681160e2901387a8c7c9a7d
Reviewed-on: https://review.typo3.org/30037
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Invalid module token in openid wizard 26/30026/2
Markus Klein [Mon, 12 May 2014 16:54:56 +0000 (18:54 +0200)]
[BUGFIX] Invalid module token in openid wizard

Fix the double htmlspecialchars call by removing the one
in the controller. Fluid does it anyway.

Resolves: #58719
Releases: 6.2
Change-Id: I1a62c41b94150494e429cec913eb43e1ec3f7ca8
Reviewed-on: https://review.typo3.org/30026
Reviewed-by: Mathias Brodala
Tested-by: Mathias Brodala
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Sprite icons not shown 46/30046/2
Frans Saris [Tue, 13 May 2014 11:56:40 +0000 (13:56 +0200)]
[BUGFIX] Sprite icons not shown

If first hit after clearing cache was not in BE context
some icons are not part of the sprite css.

This patch makes sure that these icons are registered
in every context.

Releases: 6.2
Resolves: #58758
Change-Id: I4c44c0f241f096c15e8257975b665ec89b60d2e4
Reviewed-on: https://review.typo3.org/30046
Reviewed-by: Fabien Udriot
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Category tab not shown for file when filemetadata installed 45/29945/5
Frans Saris [Thu, 8 May 2014 16:02:08 +0000 (18:02 +0200)]
[BUGFIX] Category tab not shown for file when filemetadata installed

As a result of the TCA caching changes the order of
the manipulations done in the sys_file_metadata TCA
have changed. As a result the categories tab disappears
when you install ext:filemetadata.

This patch ads an extra check in the TCA override and
adds the categories tab when sys_file_metadata is categorized.

Resolves: #58620
Releases: 6.2
Change-Id: I75c7d7ccf40d5a2cc200c7d0a4e69f674024f628
Reviewed-on: https://review.typo3.org/29945
Reviewed-by: Jan Kiesewetter
Tested-by: Jan Kiesewetter
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Remove failing extension installations 23/29123/12
Nicole Cordes [Wed, 2 Apr 2014 19:13:55 +0000 (21:13 +0200)]
[BUGFIX] Remove failing extension installations

This patch takes care about removing extracted extension folders if an
installation fails. For new extensions the folder is simply removed, for
already existing ones a backup in typo3temp is done before the
installation process and restored if anything fails.

Resolves: #57606
Releases: 6.2
Change-Id: If6f251ebc5950aecfcdb97d722146d95cb7cfa74
Reviewed-on: https://review.typo3.org/29123
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] DataProviderContext uses wrong member field in setter 28/30028/2
Tim Schreiner [Mon, 12 May 2014 17:21:19 +0000 (19:21 +0200)]
[BUGFIX] DataProviderContext uses wrong member field in setter

Resolves: #58731
Releases: 6.2
Change-Id: Ic3c5417d19b165009ae500a19b565569e2d8b2b2
Reviewed-on: https://review.typo3.org/30028
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Update to phpunit 4.1 84/29584/6
Christian Kuhn [Sun, 20 Apr 2014 12:46:13 +0000 (14:46 +0200)]
[TASK] Update to phpunit 4.1

Do not forget to "composer update" test instances!

Updating from phpunit 3.7 to 4.1 is smooth, except two details:

* The mock framework dropped staticExpects, two test cases must
  be refactored to circumvent this.

* The mocker now tries to resolve method argument type hints, so
  those classes must exist and autoloaded, some FLOW dependencies
  are affected here.

Change-Id: Ie74bdad000182dde808d3771fa6eec4764a133da
Resolves: #58676
Releases: 6.2
Reviewed-on: https://review.typo3.org/29584
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[SECURITY] Extbase must not cache dynamic parts of queries 32/29932/7
Markus Klein [Thu, 8 May 2014 01:31:21 +0000 (03:31 +0200)]
[SECURITY] Extbase must not cache dynamic parts of queries

Do not cache the enable fields part of queries. This part
needs to be added on each query dynamically to reflect the
current context. (Time restrictions, User restrictions)

Resolves: #58369
Releases: 6.2
Change-Id: I492d5983ff6a06d72cd18cf9a08a0d62d304ac2b
Reviewed-on: https://review.typo3.org/29932
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Jan Kiesewetter
Tested-by: Jan Kiesewetter
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Check if storage exists before accessing it 34/29634/5
Christian Weiske [Thu, 24 Apr 2014 09:23:26 +0000 (11:23 +0200)]
[BUGFIX] Check if storage exists before accessing it

When editing a file mount in the backend, we need to check if
the storage backend actually exists.

Change-Id: I76e677f9b44eea7694005a4939eb9489dc4f71de
Fixes: #57986
Releases: 6.2
Reviewed-on: https://review.typo3.org/29634
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Use file name in delete confirmation message 35/29635/4
Christian Weiske [Thu, 24 Apr 2014 09:48:06 +0000 (11:48 +0200)]
[BUGFIX] Use file name in delete confirmation message

Instead of using the file identifier, the actual file name
is used when asking if a file should be deleted.

This is important for non-local FAL storage drivers that
do not use paths as identifiers.

Change-Id: I34e42ed1716f08a4133e02bbc36ee805c6a108c7
Fixes: #58150
Releases: 6.2
Reviewed-on: https://review.typo3.org/29635
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Sebastian Fischer
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] LocalizationUtility methods should be static 21/29921/3
Christian Kuhn [Wed, 7 May 2014 14:52:34 +0000 (16:52 +0200)]
[BUGFIX] LocalizationUtility methods should be static

All public methods of LocalizationUtility are static, but two
protected methods are not. Make those static, too.

Change-Id: I267805cad3f008f24e053f69670fac0f805f7ad2
Resolves: #58600
Releases: 6.2
Reviewed-on: https://review.typo3.org/29921
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add PHP 5.6 as travis-ci environment 13/29913/3
Christian Kuhn [Tue, 6 May 2014 21:39:25 +0000 (23:39 +0200)]
[TASK] Add PHP 5.6 as travis-ci environment

travis-ci already provides a PHP 5.6 beta build.
It currently executes unit, functional and linting successfully
and is added to the list of standard environments for now.

Change-Id: Ibde2364564afe18f602f75174b779527b55c25bc
Reviewed-on: https://review.typo3.org/29913
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Set TYPO3 version to 6.2.3-dev 11/29911/2
TYPO3 Release Team [Tue, 6 May 2014 22:09:02 +0000 (00:09 +0200)]
[TASK] Set TYPO3 version to 6.2.3-dev

Change-Id: I14eab875e340e6d779b4f224de9cc801d84559d1
Reviewed-on: https://review.typo3.org/29911
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.2 10/29910/2 6.2.2 TYPO3_6-2-2
TYPO3 Release Team [Tue, 6 May 2014 22:08:30 +0000 (00:08 +0200)]
[RELEASE] Release of TYPO3 6.2.2

Change-Id: Id59a7279b29d882221d8afa1f582c5c1ff791d33
Reviewed-on: https://review.typo3.org/29910
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] IndexSearch still uses require_once 98/29898/7
Markus Klein [Tue, 6 May 2014 13:44:02 +0000 (15:44 +0200)]
[BUGFIX] IndexSearch still uses require_once

Remove the old magic as classes are loaded properly already.

Resolves: #58567
Related: #47852
Releases: 6.2
Change-Id: Iec20bf0dbd6955950225936911eba604faf720d6
Reviewed-on: https://review.typo3.org/29898
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix exporting content elements 03/29903/2
Wouter Wolters [Tue, 6 May 2014 19:48:45 +0000 (21:48 +0200)]
[BUGFIX] Fix exporting content elements

Exporting a content element leads to a fatal error.
A wrong url encoding is the cause of the problem.

Resolves: #58576
Releases: 6.2
Change-Id: Ib2105aa9dc95e35eba9515cfc3d62b174919870a
Reviewed-on: https://review.typo3.org/29903
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Skip APC tests if on cli and enable_cli is off 04/29904/2
Wouter Wolters [Tue, 6 May 2014 20:13:39 +0000 (22:13 +0200)]
[BUGFIX] Skip APC tests if on cli and enable_cli is off

Resolves: #58451
Releases: 6.2
Change-Id: I296720fd83343ea0d82b4461aaae46c4c9a14932
Reviewed-on: https://review.typo3.org/29904
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Flag compressed files to exclude from compression 79/29579/3
Helmut Hummel [Sat, 19 Apr 2014 14:16:38 +0000 (16:16 +0200)]
[BUGFIX] Flag compressed files to exclude from compression

Resolves: #58582
Related: #58010
Related: #57294
Releases: 6.2
Change-Id: I89e9bea10c24944ad2efb1fb9029ec75dc2f78db
Reviewed-on: https://review.typo3.org/29579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Clarify reset in page renderer comment 82/29582/4
Helmut Hummel [Sun, 20 Apr 2014 10:44:34 +0000 (12:44 +0200)]
[TASK] Clarify reset in page renderer comment

Also add tests to enforce this behavior.

Resolves: #58581
Releases: 6.2
Change-Id: Ife3894fe6dd5fc476bba9c9c74ae26bf310b9245
Reviewed-on: https://review.typo3.org/29582
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Find functional tests automatically, optimize travis-ci 01/29901/2
Christian Kuhn [Tue, 6 May 2014 18:15:39 +0000 (20:15 +0200)]
[TASK] Find functional tests automatically, optimize travis-ci

Simalar to UnitTests.xml, FunctionalTests.xml no longer register
single test suites but find all functional tests cases using a
wildcard.

For travis-ci, single tests cases are now given to parallel using
gnu find. This leads to a nice performance improvement on travis
since more but shorter processes are executed, sharing the available
hardware more effectively.

Change-Id: I8dc34ed2fcc1ae8390bc05dbe6f5e7009af17a36
Resolves: #58578
Related: #58533
Releases: 6.2
Reviewed-on: https://review.typo3.org/29901
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Clean up functional tests 48/29848/3
Felix Oertel [Sun, 4 May 2014 11:45:11 +0000 (13:45 +0200)]
[CLEANUP] Clean up functional tests

To allow running of all functional tests, instead of
relying on travis.yml, we want to clean up broken and
abandoned tests.

So we remove the tests that fatal because they are not
meant to be used in the functional testing framework.

Resolves: #58445
Releases: 6.2
Change-Id: I8fd021a9814dec43f71200641c9ba1ebbc0e32d0
Reviewed-on: https://review.typo3.org/29848
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ext:rsaauth cliBackend pollutes cli output 77/29877/7
Christian Kuhn [Mon, 5 May 2014 16:50:52 +0000 (18:50 +0200)]
[BUGFIX] ext:rsaauth cliBackend pollutes cli output

The CommandLineBackend using exec "openssl genrsa" outputs its key
generation to standard error. If SAPI is cli (eg. in unit tests),
this is is shown to the user. The patch silences openssl by
redirecting stderr to /dev/null (NUL on Windows systems).

Resolves: #58530
Related: #51436
Releases: 6.2
Change-Id: I702d2d3180bc2e32e5548a4402d4eefb02dd2523
Reviewed-on: https://review.typo3.org/29877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler 90/21390/9
Alexander Opitz [Thu, 13 Jun 2013 13:48:17 +0000 (15:48 +0200)]
[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler

The var pageNotFound is set, if the called page has access
restrictions. Afterwards starts a searching for an accessible page
in the rootline upwards.

If that page is a short link which also isn't accessible we stop
instead of searching again in this new rootline. Limiting this to a
maximum of 20 iterations to prevent endless loops.

If an accessible page is found we do not reset the pageNotFound var.
The PageNotFound handler reacts on this var and redirects to the 404
page instead of presenting the accessible page we found later on.

You can reproduce this with the introduction package, for example
change the access to the Example/Tables page to "Customer".
Afterwards go to http://yourdomain/?id=38 and you will see the 404
page. If you disable the pageNotFound_handling you will see the
content of the Example page.

Resolves: #16472
Releases: 6.2, 6.1
Change-Id: I1e58ec1f96422c6bf3e5c9c74f1b1c1666b68762
Reviewed-on: https://review.typo3.org/21390
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] EXT:saltedpasswords remove dependency on EXT:setup 56/29656/8
Markus Klein [Fri, 25 Apr 2014 13:26:11 +0000 (15:26 +0200)]
[BUGFIX] EXT:saltedpasswords remove dependency on EXT:setup

As saltedpasswords is required for backend and can't be uninstalled, we
can remove the implicit dependency on extension "setup" by adjusting
the default settings there.

Resolves: #58192
Releases: 6.2
Change-Id: I6490b9962924c0e384243f663f3e5057c947749e
Reviewed-on: https://review.typo3.org/29656
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Always convert webroot to unix styled path 93/29893/2
Nicole Cordes [Tue, 6 May 2014 10:28:38 +0000 (12:28 +0200)]
[BUGFIX] Always convert webroot to unix styled path

This patch adds the conversion from Windows styled to unix styled path.

Resolves: #58559
Releases: 6.2
Change-Id: I2b5b431fe60531ab1ad1c75bf9fd7749414c4df2
Reviewed-on: https://review.typo3.org/29893
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Properly check existence of array item 43/29343/6
Markus Klein [Thu, 10 Apr 2014 16:01:56 +0000 (18:01 +0200)]
[BUGFIX] Properly check existence of array item

The flexform converter in ContentObjectRenderer tries to access
an array element on a non-array.

Check existence with isset() first.

Resolves: #57809
Releases: 6.2, 6.1
Change-Id: I8e6111afee3a639b3077dc59bc2e32b72fa12f5c
Reviewed-on: https://review.typo3.org/29343
Reviewed-by: Oliver Klee
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Reviewed-by: Julian Wundrak
Tested-by: Julian Wundrak
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] DependencyUtility does count() on an integer 76/29876/3
Markus Klein [Mon, 5 May 2014 16:51:16 +0000 (18:51 +0200)]
[BUGFIX] DependencyUtility does count() on an integer

Remove the superfluous count() call.

Resolves: #58529
Releases: 6.2, 6.1, 6.0
Change-Id: I0933650b52063009de52268034480f6e06af56ac
Reviewed-on: https://review.typo3.org/29876
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Don't send HTTP headers in CLI context 54/29554/2
Gabe Blair [Thu, 17 Apr 2014 20:26:42 +0000 (13:26 -0700)]
[BUGFIX] Don't send HTTP headers in CLI context

Resolves: #58029
Releases: 6.2
Change-Id: If2a5f41e8524c457a20dec810f711f546d4fbb8c
Reviewed-on: https://review.typo3.org/29554
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Set internalUploadMap on upload in ExtendedFileUtility 20/29820/2
Marc Bastian Heinrichs [Sat, 3 May 2014 17:34:24 +0000 (19:34 +0200)]
[BUGFIX] Set internalUploadMap on upload in ExtendedFileUtility

Since introducing FAL the internalUploadMap array in
ExtendedFileUtility was not set on uploading files.

Resolves: #58463
Releases: 6.2, 6.1, 6.0
Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851
Reviewed-on: https://review.typo3.org/29820
Reviewed-by: Sascha Wilking
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Group permissions for new pages are not set 75/29875/2
Markus Klein [Mon, 5 May 2014 16:06:55 +0000 (18:06 +0200)]
[BUGFIX] Group permissions for new pages are not set

This is a regression to #54085 which accidentally converted a !strcmp()
to !==.

Resolves: #56393
Releases: 6.2
Change-Id: Ie0b2e169916e6b0ea848510e615b05d68be02199
Reviewed-on: https://review.typo3.org/29875
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Find all tests automatically 79/29879/2
Christian Kuhn [Mon, 5 May 2014 17:56:55 +0000 (19:56 +0200)]
[TASK] Tests: Find all tests automatically

All regular unit tests are located at
typo3/sysext/"extension"/Tests/Unit. The patch substitutes the single
suite registration in UnitTests.xml with a wildcard, only "Legacy"
and "Integration" tests are still registered as special locations.

Following this schema, tests located at default locations within
extensions will be found automatically without explicit registration.

Resolves: #58533
Related: #51436
Releases: 6.2
Change-Id: Ic822a68f60060437d2e3aabea7754f5b1e72af50
Reviewed-on: https://review.typo3.org/29879
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Activate ext:rsaauth test suite 78/29878/2
Christian Kuhn [Mon, 5 May 2014 17:16:56 +0000 (19:16 +0200)]
[TASK] Tests: Activate ext:rsaauth test suite

The test suite of ext:rsaauth is missing in UnitTests.xml, add it.

Resolves: #58531
Related: #58530
Related: #51436
Releases: 6.2
Change-Id: I5c1c8bbf415ed53270a09bdf68df300e28eb5f09
Reviewed-on: https://review.typo3.org/29878
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Search box list module not shown 73/29873/2
Frans Saris [Mon, 5 May 2014 15:21:05 +0000 (17:21 +0200)]
[BUGFIX] Search box list module not shown

The search box at the bottom of the BE List module
disappears when you search for something and there
are no records found.

This patch makes sure the search box is also shown
when a search was done.

Resolves: #58526
Releases: 6.2
Change-Id: I95385bbdd988c4fb036d8bdc0c6b30638020a1cc
Reviewed-on: https://review.typo3.org/29873
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Tests: Refactor and activate dbal tests 74/29874/2
Christian Kuhn [Mon, 5 May 2014 15:21:49 +0000 (17:21 +0200)]
[TASK] Tests: Refactor and activate dbal tests

Our unit test environment is finally ready to execute existing dbal
unit tests, even if no database connection exists.

The patch refactors unit tests of ext:dbal, modernizes their codebase
and adds them to the build.

Resolves: #52527
Related: #51436
Releases: 6.2
Change-Id: I70507591dc89331d658d50196dfcaea002caa7d5
Reviewed-on: https://review.typo3.org/29874
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] saltedpasswords: Check rsaauth loading 59/29859/7
Nicole Cordes [Sun, 4 May 2014 17:45:48 +0000 (19:45 +0200)]
[BUGFIX] saltedpasswords: Check rsaauth loading

This patch adds the loading check of rsaauth before trying to access the
BackendFactory of rsaauth. Otherwise the extension manager gets broken
on entering extension configuration.

Resolves: #58504
Releases: 6.2, 6.1
Change-Id: I197fb5e032b31e6add388269f77e6fc834e45b54
Reviewed-on: https://review.typo3.org/29859
Reviewed-by: Markus Klein
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix broken impexp functional tests 57/29857/3
Markus Klein [Sun, 4 May 2014 15:34:05 +0000 (17:34 +0200)]
[BUGFIX] Fix broken impexp functional tests

Issue #58484 fixed the inclusion of CSS class
attributes in typolinks, but did not adjust the
impexp tests. Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: Ib71d50d03d045db37cd411523b54f8c6a1837833
Reviewed-on: https://review.typo3.org/29857
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years agoRevert "[BUGFIX] Fix broken impexp functional test" 56/29856/2
Marc Bastian Heinrichs [Sun, 4 May 2014 17:12:16 +0000 (19:12 +0200)]
Revert "[BUGFIX] Fix broken impexp functional test"

Doesn't fix the tests completely.

This reverts commit 8ae7a4b9eb9efc6b392fba3151cfe34ea51d2099

Change-Id: Ifadcc61d2bf159c5d70f4f1b5b8d436471a79f76
Reviewed-on: https://review.typo3.org/29856
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix broken impexp functional test 54/29854/4
Markus Klein [Sun, 4 May 2014 15:34:05 +0000 (17:34 +0200)]
[BUGFIX] Fix broken impexp functional test

Issue #58484 fixed the inclusion of CSS classes
in typolinks, but did not adjust the tests.
Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: I511847bda3e393f104f1f141fb3a0bed4a97c1b1
Reviewed-on: https://review.typo3.org/29854
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] SoftReferenceIndex support for more values in class attribute 46/29846/2
Marc Bastian Heinrichs [Sun, 4 May 2014 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] SoftReferenceIndex support for more values in class attribute

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29846
Reviewed-by: Wouter Wolters
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix file handling in import/export module 94/25294/8
Oliver Hader [Tue, 12 Nov 2013 00:26:56 +0000 (01:26 +0100)]
[BUGFIX] Fix file handling in import/export module

The file handling (downloading/storing or uploading/fetching
existing T3D/XML files) is currently not full FAL compatible in the
import/export module of the TYPO3 CMS backend. Also saving
export file to folder on server shows an error, but the file is saved.

In further TYPO3 version the .htaccess protected folder
fileadmin/_temp_/ was used to store the export files. This was lately
changed to the public accessible users default upload folder,
normally fileadmin/user_upload/. This patch changes this
back to a .htaccess protected folder, namely _temp_/importexport/
below users default upload folder.

Resolves: #53552
Releases: 6.2
Change-Id: I250e08188d9e9aac011c759fccf7e831fea037fb
Reviewed-on: https://review.typo3.org/25294
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Enhance localization behavior of pages.media 39/29839/2
Oliver Hader [Sun, 4 May 2014 09:01:45 +0000 (11:01 +0200)]
[TASK] Enhance localization behavior of pages.media

With issue #57488 the pages.media field became localizable again,
however the selective approach turns out to be problematic in
terms of overlaying data in the frontend (the "mergeIfNotBlank"
settings and the like).
Thus, instead of letting the editor localize the references after
persisting the parent and having to overlay/fallback in the
frontend, now the references are already shown in the edit view
during the localization (still before being persisted).

Resolves: #58476
Releases: 6.2
Change-Id: Id6980f2a5cfea109375afce27f62cad8c101c58e
Reviewed-on: https://review.typo3.org/29839
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Disable removal of installed extensions 49/29849/3
Nicole Cordes [Sun, 4 May 2014 11:54:04 +0000 (13:54 +0200)]
[BUGFIX] Disable removal of installed extensions

This patch removes the deletion possibility for installed extension in
the list view of the extension manager. Furthermore the javascript can
be adopted as the check for installed extensions can be removed as well.

Resolves: #58493
Related: #53459
Releases: 6.2
Change-Id: I713bbb93230108db144044be9184e77f484931c9
Reviewed-on: https://review.typo3.org/29849
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Limit FileTableSplittingUpdate to TYPO3 6.0/6.1 24/29024/6
Alexander Opitz [Tue, 1 Apr 2014 12:56:04 +0000 (14:56 +0200)]
[BUGFIX] Limit FileTableSplittingUpdate to TYPO3 6.0/6.1

If the database field does not exist it may be that we have an
installation before 6.0 or after 6.1 so we do not need to migrate
the data to sys_file_metadata. This prevents empty metadata
information which may lead to other issues.
(width/height=0 for images)

Resolves: #57492
Related: #46020
Releases: 6.2
Change-Id: Id5826ea480d4139f2e232587fc2b119928b28bc8
Reviewed-on: https://review.typo3.org/29024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Reviewed-by: Jan Runte
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix dragging of elements in page module 37/29837/4
Jan Runte [Sat, 3 May 2014 21:01:33 +0000 (23:01 +0200)]
[BUGFIX] Fix dragging of elements in page module

When dragging content elements in the page module, the element gets
overlayed by TCEform elements. It loses its hover state, when dragged
outside the viewport or very rapidly.

* Set z-index higher than 4000
* Add a css class to stabilize active drag state
* Remove duplicated javascript code in page module

Resolves: #58473
Releases: 6.2, 6.1
Change-Id: I87577d30e5d6bb16f6999d466bef92da95b2add3
Reviewed-on: https://review.typo3.org/29837
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
5 years ago[BUGFIX] Flush caches in group should throw exception 81/26981/9
Helmut Hummel [Tue, 21 Jan 2014 14:31:51 +0000 (15:31 +0100)]
[BUGFIX] Flush caches in group should throw exception

If a not existent cache group is specified
to the flushCachesInGroup methods, there is no
indication that actually nothing happened.

Throw an exception instead, so that calling code
can easily be fixed.

Resolves: #58465
Releases: 6.2
Change-Id: I9617fcee9abfa27a9cb76a3fd12543c62420e719
Reviewed-on: https://review.typo3.org/26981
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel