Packages/TYPO3.CMS.git
7 months ago[SECURITY] Explicitly deny object deserialization 46/57546/2
Oliver Hader [Thu, 12 Jul 2018 09:32:17 +0000 (11:32 +0200)]
[SECURITY] Explicitly deny object deserialization

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: 6a294ad6b15677b41b90d93ad8690b92048404fe
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I710a0b7d6bfdb425380aebe3cbd7f88e73eb6b21
Reviewed-on: https://review.typo3.org/57546
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[SECURITY] Mitigate phar stream wrapper 45/57545/2
Christian Kuhn [Thu, 12 Jul 2018 09:32:06 +0000 (11:32 +0200)]
[SECURITY] Mitigate phar stream wrapper

SoftReferenceIndex throws exceptions on phar streams
LegacyLinkNotationConverter throws exceptions on phar streams

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: f11da6bc371729fd8ab556af8e2b84c9f8501704
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Iad230e9a0fe876b879eac810b6fa14b6d9f4fcdb
Reviewed-on: https://review.typo3.org/57545
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[SECURITY] Introduce PHP stream wrapper for phar:// protocol 44/57544/2
Oliver Hader [Thu, 12 Jul 2018 09:31:53 +0000 (11:31 +0200)]
[SECURITY] Introduce PHP stream wrapper for phar:// protocol

This custom stream wrapper for the phar:// protocol overrides
PHP's native handling. In case Phar bundles shall be loaded from
a valid directory, the custom wrapper falls back to the native PHP
wrapper in order to invoke Phar-related actions.

In case the location is not trustworthy, an according exception
is thrown. The custom stream wrapper is registered in the beginning
of TYPO3's bootstrap class.

Truested locations are those in typo3conf/ext/* - anything else is
denied and not considered as trustworthy.

Releases: master, 8.7, 7.6
Resolves: #85385
Security-Commit: 2af49af902fe57e476d97d49487008557b5dc2bc
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I256f5061075b64dd74b3b065b7f9bacda27a63bb
Reviewed-on: https://review.typo3.org/57544
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[SECURITY] Deny authentication bypass using blowfish/md5 encryption 43/57543/2
Oliver Hader [Thu, 12 Jul 2018 09:31:43 +0000 (11:31 +0200)]
[SECURITY] Deny authentication bypass using blowfish/md5 encryption

Using password hashing methods that are related by class inheritance
can lead to authentication bypass by just knowing a valid username.

Resolves: #84703
Releases: master, 8.7, 7.6
Security-Commit: 17853c536776b6a7332b05b1e10385f4d87868ae
Security-Bulletin: TYPO3-CORE-SA-2018-001
Change-Id: If7a13d3699e217d7d853886b93b84b46f7e22b11
Reviewed-on: https://review.typo3.org/57543
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
7 months ago[BUGFIX] Support fragment/section for record links 34/57334/2
Mathias Brodala [Tue, 10 Oct 2017 10:58:20 +0000 (12:58 +0200)]
[BUGFIX] Support fragment/section for record links

This allows for setting fragments e.g. by adding a custom recordlist
RecordLinkHandler.

Resolves: #82717
Releases: master, 8.7
Change-Id: I1535a3bb5e446e2f154cd6214e5665887ae6fd0d
Reviewed-on: https://review.typo3.org/57334
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
7 months ago[BUGFIX] Repair relative path resolvement in ResourceCompressor 86/57386/3
Pascal Rinker [Wed, 25 Apr 2018 09:51:47 +0000 (11:51 +0200)]
[BUGFIX] Repair relative path resolvement in ResourceCompressor

This patch repairs the relative path resolvment when using EXT:
for JavaScript/CSS paths.

Resolves: #84261
Releases: master, 8.7
Change-Id: Ieeb35041bf049728c41465edb617529550629258
Reviewed-on: https://review.typo3.org/57386
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Scheduler: Show correct description for ipAnonymization-task 08/57508/2
Stefan Neufeind [Mon, 9 Jul 2018 08:15:13 +0000 (10:15 +0200)]
[BUGFIX] Scheduler: Show correct description for ipAnonymization-task

Resolves: #85512
Releases: master, 8.7, 7.6
Change-Id: I4077fe7481063feb97014048580c3fb1b1ca5e2a
Reviewed-on: https://review.typo3.org/57508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Update complete database after extension installation 86/57486/3
Nicole Cordes [Sun, 1 Jul 2018 14:54:19 +0000 (16:54 +0200)]
[BUGFIX] Update complete database after extension installation

If an extension and its dependencies get installed, the whole
database needs to be updated instead of executing each extensions
SQL on its own.

Resolves: #79094
Releases: master, 8.7
Change-Id: I9a870e0efb6af241eeae563adbaa14af100edaec
Reviewed-on: https://review.typo3.org/57486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
7 months ago[BUGFIX] Check for exceptions instead of number of affected rows 91/57491/4
Georg Ringer [Sun, 24 Jun 2018 16:22:30 +0000 (18:22 +0200)]
[BUGFIX] Check for exceptions instead of number of affected rows

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Resolves: #85366
Releases: master, 8.7
Change-Id: I474e16478cb09ad4940aaab5fe1d3eb21498c4c4
Reviewed-on: https://review.typo3.org/57491
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Convert date objects to string in SaveToDatabase finisher 90/57490/2
Ralf Zimmermann [Tue, 12 Jun 2018 16:57:56 +0000 (18:57 +0200)]
[BUGFIX] Convert date objects to string in SaveToDatabase finisher

The SaveToDatabase now converts DateTime(Immutable) objects to strings
to make it possible to save values from "Date" or "DatePicker" form elements
into the database.

Resolves: #85246
Releases: master, 8.7
Change-Id: I1533252d462d08bf7b743884d4e8e5fab12f6423
Reviewed-on: https://review.typo3.org/57490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl 88/57488/2
Markus Klein [Thu, 5 Jul 2018 20:26:14 +0000 (22:26 +0200)]
[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl

When fetching only headers from an URL there is no need
to download the whole content.
This was overlooked when migrating the core to use Guzzle.

Resolves: #85491
Releases: master, 8.7
Change-Id: I6475b405d51135372e022b5e133368f15a917687
Reviewed-on: https://review.typo3.org/57488
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Use unknown OS icon instead of Windows as fallback 62/57362/3
Jan Stockfisch [Wed, 25 Apr 2018 14:38:48 +0000 (16:38 +0200)]
[BUGFIX] Use unknown OS icon instead of Windows as fallback

Resolves: #84870
Releases: master, 8.7
Change-Id: Ia89f4ba0aa70616e185cad6cc29858157ef0e656
Reviewed-on: https://review.typo3.org/57362
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[TASK] Add various Composer scripts 80/57480/2
Mathias Brodala [Thu, 7 Dec 2017 11:05:07 +0000 (12:05 +0100)]
[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

    composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

    composer t:p:u

Also arbitrary arguments can be passed to the executed command:

    composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57480
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[TASK] Use secure deserialization in extension manager 77/57477/2
Oliver Hader [Tue, 3 Jul 2018 14:16:19 +0000 (16:16 +0200)]
[TASK] Use secure deserialization in extension manager

In order to harden the deserialization of scalar and array values
in extension manager unserialize() calls are hardened further to
disallow object reconstitution. The information is retrieved from
the TYPO3 extension repository (TER) where according countermeasures
are in place to protect object injections - that's why this change
is considered as hardening and not as security issue.

Resolves: #85466
Releases: master, 8.7
Change-Id: I65b61d61e08d0c50b27ae9102d7ba4c4518a8788
Reviewed-on: https://review.typo3.org/57477
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
7 months ago[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example 72/57472/2
Daniel Siepmann [Wed, 4 Jul 2018 15:26:25 +0000 (17:26 +0200)]
[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example

Releases: master, 8.7, 7.6
Resolves: #85473
Change-Id: Ic0ac284bb8f02c7275e17bde67e79bb20a7fd919
Reviewed-on: https://review.typo3.org/57472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Fixing login logo height in IE 71/57471/2
Roberto Presedo [Fri, 22 Jun 2018 21:41:16 +0000 (23:41 +0200)]
[BUGFIX] Fixing login logo height in IE

Resolves: #78592
Releases: master, 8.7
Change-Id: Ia7b3a25f6af61fce5376a68c1188c9564d603a23
Reviewed-on: https://review.typo3.org/57471
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Improve custom CE explanation in FSC 59/57459/2
Mathias Brodala [Tue, 3 Jul 2018 07:26:53 +0000 (09:26 +0200)]
[TASK] Improve custom CE explanation in FSC

Resolves: #85459
Releases: master, 8.7
Change-Id: I1732782fa920ffa0f7bfd42016a45ac6437bff0a
Reviewed-on: https://review.typo3.org/57459
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Ensure extension icon exists before calling ImageInfo 13/57413/2
Nicole Cordes [Thu, 28 Jun 2018 19:11:13 +0000 (21:11 +0200)]
[BUGFIX] Ensure extension icon exists before calling ImageInfo

As the extension icon is not required, this patch prevents warnings
that are triggered because no image size can be fetched.

Resolves: #85363
Releases: master, 8.7
Change-Id: I4c98fbaed385b2f269e940b8531c45e948ab8d36
Reviewed-on: https://review.typo3.org/57413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
7 months ago[TASK] Synchronize .rst files between core versions 50/57450/2
Christian Kuhn [Mon, 2 Jul 2018 13:16:36 +0000 (15:16 +0200)]
[TASK] Synchronize .rst files between core versions

Resolve some minor differences between v8 and master
according to Changelog/Howto.rst. v7 is ok.

Resolves: #85454
Releases: master, 8.7
Change-Id: I07aba0283b09a5f0c2a2b4336cae4df17bbb46af
Reviewed-on: https://review.typo3.org/57450
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Display documentation changelog files with same issue number 46/57446/2
Anja [Thu, 28 Jun 2018 16:45:33 +0000 (18:45 +0200)]
[BUGFIX] Display documentation changelog files with same issue number

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Change-Id: I3aef23b3bbc0d63486b1f75c38a54648991633b5
Resolves: #85420
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57446
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Handle missing repository mirrors in Languages module 09/56709/3
Mathias Brodala [Tue, 17 Apr 2018 12:57:11 +0000 (14:57 +0200)]
[BUGFIX] Handle missing repository mirrors in Languages module

If no extension repository mirror is present, properly throw the
(actually advertised) exception which is handled in the
TranslationService already.

Resolves: #83135
Releases: 8.7
Change-Id: Ic24eecd03262ae54d8ef987c4f38143575260fba
Reviewed-on: https://review.typo3.org/56709
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again 39/57439/2
Frédéric Lebel [Wed, 27 Jun 2018 02:57:49 +0000 (02:57 +0000)]
[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again

Fix the link browser to not drop the CSS-Class value with multiple classes
if editing the same link.

Resolves: #85182
Releases: master, 8.7
Change-Id: Id7819f25c6a456c379de406816e44d7d1d76157e
Reviewed-on: https://review.typo3.org/57439
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Remove unused Doctrine restriction 37/57437/2
Benni Mack [Sun, 1 Jul 2018 18:13:56 +0000 (20:13 +0200)]
[BUGFIX] Remove unused Doctrine restriction

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Resolves: #85446
Releases: master, 8.7
Change-Id: Ib9dd0aa0197ee7d8379110a8067c31eba2ff73e8
Reviewed-on: https://review.typo3.org/57437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Try to translate given help text of select items 83/57283/2
Mathias Brodala [Thu, 21 Jun 2018 10:11:43 +0000 (12:11 +0200)]
[BUGFIX] Try to translate given help text of select items

Use the LanguageService for help texts of select items.
This can be tested with the element 'select_checkbox_3' of the
styleguide extension.

Resolves: #78984
Releases: master, 8.7
Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81
Reviewed-on: https://review.typo3.org/57283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[TASK] Streamline FAL pre-emit signals for createFile and setContent 21/57421/2
Oliver Hader [Fri, 29 Jun 2018 13:02:29 +0000 (15:02 +0200)]
[TASK] Streamline FAL pre-emit signals for createFile and setContent

In order to streamline the FAL API the following signals have been added.
The according post-processing signals have been available already before:

+ ResourceStorageInterface::SIGNAL_PreFileCreate
+ ResourceStorageInterface::SIGNAL_PreFileSetContents

Resolves: #85434
Releases: master, 8.7
Change-Id: I41fc07afbc4e1a393c8a26fe02f431a7b62015d8
Reviewed-on: https://review.typo3.org/57421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
7 months ago[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer 15/57415/4
Daniel Goerz [Fri, 29 Jun 2018 08:36:12 +0000 (10:36 +0200)]
[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Resolves: #85362
Releases: master, 8.7
Change-Id: I00bfc9d7e3bbf97d8a68fbf825a6cf3dd8b2d3aa
Reviewed-on: https://review.typo3.org/57415
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
7 months ago[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes 25/57325/2
Frans Saris [Fri, 22 Jun 2018 22:28:05 +0000 (00:28 +0200)]
[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes

With the new chrome auto play policies we need to add a additional allow
attribute to the iframe to support autoplay.

https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Resolves: #85233
Releases: master, 8.7
Change-Id: I19116a011b410933cf020b5b9606dc32d61e698d
Reviewed-on: https://review.typo3.org/57325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[BUGFIX] Adjust Headline of documentation file 16/57416/2
Anja [Thu, 28 Jun 2018 17:20:43 +0000 (19:20 +0200)]
[BUGFIX] Adjust Headline of documentation file

With the correct delimiter, the category feature for the documentation
file can be properly retrieved and does not get sorted into its
own, exclusive category.

Change-Id: I228c46377190c3d1bd0eb5459df8d63975a6895b
Resolves: #85422
Reselases: master, 8.7
Reviewed-on: https://review.typo3.org/57410
Reviewed-on: https://review.typo3.org/57416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
7 months ago[BUGFIX] Separate icon and text in inline record control buttons 07/57407/2
Mathias Brodala [Thu, 28 Jun 2018 09:47:17 +0000 (11:47 +0200)]
[BUGFIX] Separate icon and text in inline record control buttons

Resolves: #85415
Releases: master, 8.7
Change-Id: I5cee4230bb415dcb3d7dfcd0aae7614489cec7eb
Reviewed-on: https://review.typo3.org/57407
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Do not cache results of LiveSearch 02/57402/2
Andreas Fernandez [Thu, 28 Jun 2018 06:41:18 +0000 (08:41 +0200)]
[TASK] Do not cache results of LiveSearch

Resolves: #85412
Releases: master, 8.7
Change-Id: I7cac1b53f9cc7c7fa3c6c9e1752b7b2513d39c5d
Reviewed-on: https://review.typo3.org/57402
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Drop unused code in SilentConfigurationUpgradeService 95/57395/2
Mathias Brodala [Wed, 27 Jun 2018 07:27:30 +0000 (09:27 +0200)]
[TASK] Drop unused code in SilentConfigurationUpgradeService

This removes unused code which is left over from the fix for #83591.

Resolves: #83591
Releases: 8.7
Change-Id: Ibdf283c973e333ec7eb6d1ecb82fe0198465b69e
Reviewed-on: https://review.typo3.org/57395
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Re-Init CKEditor after re-sorting of inline records 92/57392/2
Frank Naegler [Tue, 26 Jun 2018 20:01:22 +0000 (22:01 +0200)]
[BUGFIX] Re-Init CKEditor after re-sorting of inline records

This patch triggers an event and uses this event to re-init the
CKEditor after re-sorting inline records.

Resolves: #79468
Releases: master, 8.7
Change-Id: Ib7d0ad6c1b0cb6b292b3dfa8488a6528ff74ceee
Reviewed-on: https://review.typo3.org/57392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] CKEditor RTE: Add button to insert soft hyphen 73/57373/2
Josef Glatz [Sat, 23 Jun 2018 12:21:57 +0000 (14:21 +0200)]
[TASK] CKEditor RTE: Add button to insert soft hyphen

This patch re-adds a missing functionality to CKEditor.

Due to the move from htmlArea to CKEditor, the well-known and actually
important button/shortcut "soft hyphen" for text in responsive webdesign
was gone.

The button is added per default to the existing CKEditor presets "default"
and "full". Existing translations from htmlArea have been migrated and
more were added.

Pasting a soft hyphen is possible via the UI button and a keyboard
shortcut: 'CTRL' + '-'. The shortcut can be deactivated in custom
RTE presets.

Resolves: #85361
Releases: master, 8.7
Change-Id: Iec97f4c9d1ede269e2df5cb4fe795df0ef5ca558
Reviewed-on: https://review.typo3.org/57373
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Add index to pid column in sys_file_metadata 72/57372/3
Frédéric Lebel [Tue, 26 Jun 2018 02:59:14 +0000 (02:59 +0000)]
[BUGFIX] Add index to pid column in sys_file_metadata

This improves the performance of the page tree in workspaces.

Resolves: #85387
Releases: 8.7
Change-Id: I55609d3af95c8352216f1958ea233ed0ef5802f5
Reviewed-on: https://review.typo3.org/57372
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Fix override handling for element specific field values 77/57377/2
Frank Naegler [Sat, 23 Jun 2018 18:09:58 +0000 (20:09 +0200)]
[BUGFIX] Fix override handling for element specific field values

This patch fixes a broken JavaScript code which removes the field and
placeholder divs in FormeEngine.js field override handling.

Resolves: #84689
Related: #79440
Related: #70032
Releases: master, 8.7
Change-Id: I91d40b6ff7baa9fa9ea121458a7a9faaa00ec6f9
Reviewed-on: https://review.typo3.org/57377
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
7 months ago[BUGFIX] RTE: Disable autolink functionality in source-mode 74/57374/2
Josef Glatz [Mon, 25 Jun 2018 20:21:10 +0000 (22:21 +0200)]
[BUGFIX] RTE: Disable autolink functionality in source-mode

Limit the functionality only to the wysiwyg-mode. This also
prevents javascript errors in source-mode.

Resolves: #85332
Releases: master, 8.7
Change-Id: I0adc30400fb27745713f0a86b7916a8865609428
Reviewed-on: https://review.typo3.org/57374
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] CKEditor: show selectAll button in preset "full" 69/57369/3
Josef Glatz [Mon, 25 Jun 2018 15:45:07 +0000 (17:45 +0200)]
[BUGFIX] CKEditor: show selectAll button in preset "full"

Resolves: #85383
Releases: master, 8.7
Change-Id: I108167eef9ba1028991d332d952c68cecd0fa649
Reviewed-on: https://review.typo3.org/57369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
7 months ago[BUGFIX] Better handling of requests in ExternalLinktype 56/57356/2
Sybille Peters [Fri, 18 May 2018 18:03:07 +0000 (20:03 +0200)]
[BUGFIX] Better handling of requests in ExternalLinktype

- Always check for existing response
- If HEAD request fails, a GET request should always be triggered
- Restructured, moved some local variables to class variables
- In case of redirect loop, output exception message instead of
  location and status code

Resolves: #83611
Resolves: #85067
Releases: master, 8.7
Change-Id: I1cf6ef4e3dbaa5fbc683affc7cf96a0dbeea75cd
Reviewed-on: https://review.typo3.org/57356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[BUGFIX] Use unique keys for includeJSLibs and addJsFooterLibrary 60/57360/2
Georg Ringer [Sat, 23 Jun 2018 18:23:52 +0000 (20:23 +0200)]
[BUGFIX] Use unique keys for includeJSLibs and addJsFooterLibrary

As both TS configurations use its key the latter must use a prefix
to avoid an instant override of rendered JS file.

Resolves: #85353
Releases: master, 8.7
Change-Id: Icb685eb0ed278aafead274c1fcf86436c9e6865d
Reviewed-on: https://review.typo3.org/57360
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[BUGFIX] Do not link l18n_cfg restricted pages 45/57345/2
Nicole Cordes [Sat, 23 Jun 2018 16:08:35 +0000 (18:08 +0200)]
[BUGFIX] Do not link l18n_cfg restricted pages

Prevent linking a page that is either restricted for the default
language or where any fallback is forbidden.

Resolves: #85063
Releases: master, 8.7
Change-Id: I9dd1f7b5b357c60114f72898ddffa9ecf7305bf2
Reviewed-on: https://review.typo3.org/57345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths 51/57351/2
Claus Due [Fri, 22 Jun 2018 13:16:59 +0000 (15:16 +0200)]
[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths

This patch avoids calling GeneralUtility::removeDotsFromTs
on the entire TS array, instead selectively calling it only on
the sub-array and only if a sub-array was actually resolved.

In my extremely small testing setup this patch avoids 1,100
calls in FE and 6,000 calls in BE (in page module with fluid
previews being rendered).

Change-Id: I7195aa310711d82de4861df8dcb2a9fbda309520
Releases: master, 8.7
Resolves: #85341
Reviewed-on: https://review.typo3.org/57351
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[BUGFIX] Fetch Vimeo preview in higher quality 43/57343/2
Frans Saris [Fri, 22 Jun 2018 14:12:48 +0000 (16:12 +0200)]
[BUGFIX] Fetch Vimeo preview in higher quality

Resolves: #85176
Releases: master, 8.7
Change-Id: Ic90137b3e58cc7c178eb899448a2efa828f9fb25
Reviewed-on: https://review.typo3.org/57343
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Fix collection of allowed pages in suggest receiver 36/57336/2
Alexander Stehlik [Mon, 11 Jun 2018 20:03:50 +0000 (22:03 +0200)]
[BUGFIX] Fix collection of allowed pages in suggest receiver

When using the pidList and pidDepth TSconfig settings of the
suggest wizard the recursive collection of the allowed
pages does not abort too early any more due to an invalid condition.

Resolves: #85229
Relates: #77049
Releases: master, 8.7
Change-Id: I2c94f5cc64f57be1319f9e76ed05310fbea0db16
Reviewed-on: https://review.typo3.org/57336
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
7 months ago[BUGFIX] Remove reset of GFX/processor_effects to -1 39/57339/2
Marc Willmann [Fri, 22 Jun 2018 21:32:00 +0000 (23:32 +0200)]
[BUGFIX] Remove reset of GFX/processor_effects to -1

When entering the Install Tool and the GFX/processor is set to
GraphicsMagick the value for GFX/processor_effects is reset to -1,
overwriting any value that might have been set before.
Also adjust tests for the new expectations.

Resolves: #83591
Releases: master, 8.7
Change-Id: I7baa247a404166332a9a727983bb5eb83dfe37af
Reviewed-on: https://review.typo3.org/57339
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
7 months ago[BUGFIX] Remove mediace extraction update 23/57323/2
Alexander Stehlik [Fri, 22 Jun 2018 22:27:28 +0000 (00:27 +0200)]
[BUGFIX] Remove mediace extraction update

The mediace Extension is only available for TYPO3 7.6.

There is no point for this update in TYPO3 8.

Resolves: #83508
Releases: 8.7
Change-Id: Ib1476059534f57446799ca8ebb0c5d6deb757e58
Reviewed-on: https://review.typo3.org/57323
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
7 months ago[BUGFIX] Remove Byte Order Mark from TypoScript includes 27/57327/3
Andreas Fernandez [Fri, 22 Jun 2018 20:52:13 +0000 (22:52 +0200)]
[BUGFIX] Remove Byte Order Mark from TypoScript includes

If TypoScript files have a Byte Order Mark (BOM) set, the TypoScript
parser may fail as the invisible characters disturb the parsing process.

The BOM gets removed from the TypoScript strings with this patch.

Resolves: #56483
Releases: master, 8.7
Change-Id: I59318f9d2d92efb224d62906fb404fcb41459f8f
Reviewed-on: https://review.typo3.org/57327
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[BUGFIX] Fix exception for folder move/copy between storages 09/57309/2
Mathias Brodala [Mon, 18 Jun 2018 13:35:22 +0000 (15:35 +0200)]
[BUGFIX] Fix exception for folder move/copy between storages

This ensures that the user is shown the correct error message.

Resolves: #85302
Releases: master, 8.7
Change-Id: Ide2c1231fa1ec5bcbd710c1b3810253ce2bfe3c4
Reviewed-on: https://review.typo3.org/57309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[TASK] Add .ddev to ignore 07/57307/2
Harry [Thu, 21 Jun 2018 09:08:44 +0000 (11:08 +0200)]
[TASK] Add .ddev to ignore

Resolves: #85324
Releases: master, 8.7, 7.6
Change-Id: I90461715f59cd74c72571151f3e37cb4ee374b7f
Reviewed-on: https://review.typo3.org/57307
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Show infobox for records which are set to readOnly 84/57284/4
Mathias Brodala [Thu, 21 Jun 2018 10:31:30 +0000 (12:31 +0200)]
[TASK] Show infobox for records which are set to readOnly

Records can be set to readOnly by setting 'readOnly` in the TCA ctrl section.
Inform editors by rendering an infobox above the record.

Additionally improve the code of the record note rendering.

Resolves: #85244
Releases: master, 8.7
Change-Id: I46c84f18b22332c5691f7fb41836a0b97f8dafa2
Reviewed-on: https://review.typo3.org/57284
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[TASK] Allow preload Tag in VideoTagRenderer 05/57305/2
Guido Schmechel [Fri, 22 Jun 2018 18:38:40 +0000 (20:38 +0200)]
[TASK] Allow preload Tag in VideoTagRenderer

Add the preload parameter to the VideoTagRenderer.

Resolves: #84523
Releases: master, 8.7
Change-Id: I961eee2c204d74321854a3a6f093225e2f873aba
Reviewed-on: https://review.typo3.org/57305
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Add modestbranding to YouTubeRenderer 04/57304/2
Guido Schmechel [Wed, 20 Jun 2018 15:59:33 +0000 (17:59 +0200)]
[TASK] Add modestbranding to YouTubeRenderer

Add the modestbranding parameter to the YoutubeRender.

Resolves: #85114
Releases: master, 8.7
Change-Id: Id76c0dd9ec764c820c2319c5dd57069e18c2cc71
Reviewed-on: https://review.typo3.org/57304
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Improve wording of upgrade wizards in Install Tool 82/57282/2
Nicole Cordes [Thu, 21 Jun 2018 10:01:08 +0000 (12:01 +0200)]
[TASK] Improve wording of upgrade wizards in Install Tool

Change the misleading headling "Available wizards" and
switch color of progress bar to success if 100% reached.

Resolves: #85299
Releases: master, 8.7
Change-Id: I6e08da59313fe9efc51f3e4e061a4d3068cadc80
Reviewed-on: https://review.typo3.org/57282
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Avoid prev/next arrows if only 1 system news is shown 78/57278/2
Georg Ringer [Wed, 20 Jun 2018 17:15:30 +0000 (19:15 +0200)]
[BUGFIX] Avoid prev/next arrows if only 1 system news is shown

If only one system news is shown, it makes no sense to render arrows
to switch to other news records. Therefore those should only be
shown if there are at least 2 records.

Resolves: #85322
Releases: master, 8.7
Change-Id: I636b90121729bb2f12c2313a3cb7e8b858367970
Reviewed-on: https://review.typo3.org/57278
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
8 months ago[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility 54/57254/2
Wouter Wolters [Sun, 17 Jun 2018 17:23:41 +0000 (19:23 +0200)]
[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility

while (strlen($this->primary) < 4 || strlen($this->secondary < 4)) {

should be

while (strlen($this->primary) < 4 || strlen($this->secondary) < 4) {

Resolves: #85296
Releases: master,8.7
Change-Id: I1820218410538c095f3e3c907190726f8e970410
Reviewed-on: https://review.typo3.org/57254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Do not use named parameter for list of orphan records ids 30/57230/2
Sascha Egerer [Wed, 13 Jun 2018 19:18:30 +0000 (21:18 +0200)]
[BUGFIX] Do not use named parameter for list of orphan records ids

The OrphanRecordsCommand fetches records by a list of ids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85257
Related: #80875
Releases: master, 8.7
Change-Id: Ia6b9398f4e54157301abb57fac5adb7f51130907
Reviewed-on: https://review.typo3.org/57230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Fix namespace of validation error in form 12/57212/5
Justus Moroni [Wed, 13 Jun 2018 18:42:31 +0000 (20:42 +0200)]
[BUGFIX] Fix namespace of validation error in form

The FormElementHooks now uses the correct namespace
for the generated error.

The TranslateElementErrorViewHelper requires the submitted
error to be an instance of TYPO3\CMS\Extbase\Validation\Error.
The error was an instance of TYPO3\CMS\Extbase\Error\Error.
As the instance was wrong, an exception was thrown.

Resolves: #85255
Releases: master, 8.7
Change-Id: I6ccce5fb6370d2bf34f494141d73cc602eb923ce
Reviewed-on: https://review.typo3.org/57212
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Repair failing acceptance test 06/57206/2
Anja Leichsenring [Sun, 10 Jun 2018 16:13:37 +0000 (18:13 +0200)]
[TASK] Repair failing acceptance test

The test uses now a method to check on the element that takes the
DOM into consideration, and not the visibility on the interface.

Not the backend changed anything, but the testing methods of
codeception cause this failure. Using the correct testing method
solves the problem.

Resolves: #85208
Releases: master, 8.7
Change-Id: I349a555de2ab04c9f6181e5d71e4602fa9552df3
Reviewed-on: https://review.typo3.org/57206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix comments in various places 00/57200/2
Benni Mack [Tue, 12 Jun 2018 08:21:15 +0000 (10:21 +0200)]
[BUGFIX] Fix comments in various places

There are some places where phpdoc comments and return types are wrong,
(an IDE shows this ASAP to you if you open up the file).

The patch fixes the small glitches.

Resolves: #85231
Releases: master, 8.7
Change-Id: I3550e7631b31144989d09feee79d1c96da3079db
Reviewed-on: https://review.typo3.org/57195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
(cherry picked from commit 721dea9726deca920639d026169b33acf4842b9a)
Reviewed-on: https://review.typo3.org/57200

8 months ago[TASK] Set TYPO3 version to 8.7.17-dev 89/57189/3
Oliver Hader [Mon, 11 Jun 2018 17:43:38 +0000 (19:43 +0200)]
[TASK] Set TYPO3 version to 8.7.17-dev

Change-Id: I08618a16f6276cdf1e307e232405b560c777b1e6
Reviewed-on: https://review.typo3.org/57189
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 8.7.16 88/57188/2 8.7.16 TYPO3_8-7-16 v8.7.16
Oliver Hader [Mon, 11 Jun 2018 17:18:08 +0000 (19:18 +0200)]
[RELEASE] Release of TYPO3 8.7.16

Change-Id: Ib1e4b5f5ea828910c0eefa16ace597fa62301a80
Reviewed-on: https://review.typo3.org/57188
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Don’t cut urls in link browser 84/57184/3
Frank Naegler [Mon, 11 Jun 2018 13:31:27 +0000 (15:31 +0200)]
[BUGFIX] Don’t cut urls in link browser

Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to
200 characters for any input value. The parameter is rather useless and
its usage can be simply removed to allow URLs with more than 200
characters.

Resolves: #85226
Releases: master, 8.7
Change-Id: I8391488d6fb21ede9280041dd41e3feb7e19dbd1
Reviewed-on: https://review.typo3.org/57184
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Improve overall recycler performance 13/57113/2
Andreas Fernandez [Sun, 11 Mar 2018 21:09:06 +0000 (22:09 +0100)]
[TASK] Improve overall recycler performance

To improve the overall performance of the recycler, these things are done:

- Improve how permissions are checked for each record
  Instead of running multiple SQL requests per record, the check now
  instantly stops if the user is either an admin, or has no permission
  to modify a certain table.

- Drop sorting of records by page tree structure
  The records get sorted by the page tree structure, to mime the tree in
  a flat view. However, this feature is rather useless and also
  considered buggy in a huge record set.

Resolves: #84711
Releases: master, 8.7
Change-Id: I0c5177546489ce2a0ba84435fed3879267a5a871
Reviewed-on: https://review.typo3.org/57113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[TASK] Exclude tests from Composer packages 51/57151/2
Jigal van Hemert [Fri, 8 Jun 2018 19:01:38 +0000 (21:01 +0200)]
[TASK] Exclude tests from Composer packages

Resolves: #85119
Releases: master, 8.7
Change-Id: If9c00379c1ac671bd6bb622ace47864866c34446
Reviewed-on: https://review.typo3.org/57151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
8 months ago[BUGFIX] Fix broken additional fields for garbarge collection task 64/57164/2
Frank Naegler [Thu, 7 Jun 2018 09:41:17 +0000 (11:41 +0200)]
[BUGFIX] Fix broken additional fields for garbarge collection task

The new IpAnonymizationAdditionalFieldProvider introduced the same
JavaScript variable which breaks the garbage collection task.
The JavaScript initialization has been removed and the field provider
simplified.

Resolves: #85068
Releases: master, 8.7, 7.6
Change-Id: Ibb307ee37d6fea33a721373bdc50bbbd3fee1453
Reviewed-on: https://review.typo3.org/57164
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Extend ResourceStorage API to check for applied filters 28/57128/2
Nicole Cordes [Thu, 3 May 2018 10:21:59 +0000 (12:21 +0200)]
[BUGFIX] Extend ResourceStorage API to check for applied filters

Currently only the DriverInterface cares about applied filters.
The ResourceStorage received a new API function to validate a file or
folder object against applied filters as well. This ensures proper
validation for objects fetched without driver calls.

Resolves: #84908
Releases: master, 8.7
Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199
Reviewed-on: https://review.typo3.org/57128
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[BUGFIX] Make ckeditor link browser not drop additional link params 39/57139/2
Kevin Ditscheid [Fri, 18 May 2018 14:13:49 +0000 (16:13 +0200)]
[BUGFIX] Make ckeditor link browser not drop additional link params

Fix the link browser to not drop the additional link params if
editing a link with additional link params set.

Resolves: #85040
Releases: master, 8.7
Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237
Reviewed-on: https://review.typo3.org/57139
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[BUGFIX] Always prefer HTTPS for cross-domain links 86/57086/2
Mathias Brodala [Tue, 29 May 2018 14:17:23 +0000 (16:17 +0200)]
[BUGFIX] Always prefer HTTPS for cross-domain links

This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.

Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57086
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Properly validate DateTimeImmutable objects 58/57058/2
Mathias Brodala [Fri, 25 May 2018 13:10:21 +0000 (15:10 +0200)]
[BUGFIX] Properly validate DateTimeImmutable objects

Change-Id: I29159e835d362e3f0e06c2145e84c1119df152cf
Resolves: #85083
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57058
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor 14/57114/2
Frederik Holz [Wed, 2 May 2018 15:41:09 +0000 (17:41 +0200)]
[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor

Menues provided by MenuProcessor will display restricted
pages, if the configuration value is set to true. This is the
same behavior as known from pure TypoScript provided menues.

Resolves: #82755
Releases: master, 8.7
Change-Id: Idf600f3ce151e2accba828c69dc601e26771686c
Reviewed-on: https://review.typo3.org/57114
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[BUGFIX] Correctly resolve RTE preset configuration for link browser 09/57109/2
Tymoteusz Motylewski [Tue, 29 May 2018 22:40:49 +0000 (00:40 +0200)]
[BUGFIX] Correctly resolve RTE preset configuration for link browser

Replaces hardcoded RTE configuration in BrowseLinksController
with one resolved by Formengine when rendering a field.
This takes into account e.g. column overrides.

The RTE configuration preset name is now kept by Formengine in
['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName']

Then it's being passed as parameter P[richtextConfigurationName] from RTE field
to the BrowseinksController

Resolves: #84943
Releases: master, 8.7
Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda
Reviewed-on: https://review.typo3.org/57109
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] PHP 7 Reflection error for default value 92/57092/2
Daniel Siepmann [Tue, 15 May 2018 12:46:55 +0000 (14:46 +0200)]
[BUGFIX] PHP 7 Reflection error for default value

In PHP 7, under some circumstances the exception is not caught
as expected.
Therefore we use a check (as already done in ReflectionService.php).

Releases: 8.7, 7.6
Resolves: #85011
Change-Id: I41d58c3dbb508a7b17b4534ebd1c5ca79914af94
Reviewed-on: https://review.typo3.org/57092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Only list valid forms 11/57111/3
Ralf Zimmermann [Thu, 31 May 2018 20:05:27 +0000 (22:05 +0200)]
[BUGFIX] Only list valid forms

Only list valid forms within the form manger and the form plugin.

Valid forms have an "identifier" and a "type" and the type must be "Form".

Resolves: #85132
Releases: master, 8.7
Change-Id: I2f473925b3edf839d5f965136b6b02030671350a
Reviewed-on: https://review.typo3.org/57111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Handle access restrictions on recycler search 05/57105/2
Nicole Cordes [Fri, 25 May 2018 12:05:16 +0000 (14:05 +0200)]
[BUGFIX] Handle access restrictions on recycler search

Fetching a parent folder may throws an error if the user hasn't
access to the parent. This exception needs to be caught and the
search for an existing recycler folder needs to be stopped
immediately.

Furthermore the patch removes the comparison with the root level
folder but checks the parent folder doesn't equal the folder itself.

Another loop is fixed by calling moveFile on the correct
ResourceStorge and not the current one.

Resolves: #85079
Related: #81836
Releases: master, 8.7
Change-Id: I51f5e20d7fa7da9b350ac0ca60cab05866a4d337
Reviewed-on: https://review.typo3.org/57105
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
8 months ago[BUGFIX] Allow value for CLI command cleanup:versions --action argument 00/57100/2
Simon Gilli [Fri, 25 May 2018 17:48:07 +0000 (19:48 +0200)]
[BUGFIX] Allow value for CLI command cleanup:versions --action argument

Allow the usage of a value for --action argument of the CLI command
cleanup:versions as mentioned in the documentation and the
implementation.

Resolves: #85085
Related: #79109
Related: #82653
Releases: master, 8.7
Change-Id: I6c07303728bcb527b44a6c5bf811870f25398a21
Reviewed-on: https://review.typo3.org/57100
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Fix indexed search TypoScript settings documentation 98/57098/2
Tymoteusz Motylewski [Wed, 30 May 2018 20:31:59 +0000 (22:31 +0200)]
[BUGFIX] Fix indexed search TypoScript settings documentation

Releases: master, 8.7
Resolves: #85117
Related: #32030
Change-Id: I6af62c8337865e8a76c2dd8593f5afa38e0c2d26
Reviewed-on: https://review.typo3.org/57098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[TASK] Consistent date and time rendering in FormEngine 87/57087/2
Georg Ringer [Wed, 23 May 2018 09:07:30 +0000 (11:07 +0200)]
[TASK] Consistent date and time rendering in FormEngine

Use methods of BackendUtility to have a consistent look of date and
time fields in the backend.

Resolves: #85002
Releases: master, 8.7
Change-Id: I6f0b6aca1530524ff3f83922a1b4b2dd72b1ea84
Reviewed-on: https://review.typo3.org/57087
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Ignore timezone for admin panel simulated time 80/57080/4
Tizian Schmidlin [Tue, 29 May 2018 09:35:52 +0000 (11:35 +0200)]
[BUGFIX] Ignore timezone for admin panel simulated time

By default, the simulated time of the admin panel does not take the server
timezone into account. This leads to several issues described in the
Forge ticket.

This fix makes sure that the timezone is removed from the users passed
value from the admin panel.

Since the admin panel was reworked in TYPO3 9, this patch does not apply
to master.

Resolves: #66793
Releases: 8.7, 7.6
Change-Id: Ifd86a5f78c10cec54a9fbc4210fd8a68c2be7d6f
Reviewed-on: https://review.typo3.org/57080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Show all content elements with mod.web_layout.defLangBinding 32/56932/3
Nicole Cordes [Sat, 12 May 2018 10:39:52 +0000 (12:39 +0200)]
[BUGFIX] Show all content elements with mod.web_layout.defLangBinding

The option is meant to show translated content elements
alligned with their translation parent element (connected mode).

However this also made content elements diasppear, which were
added individually in a language (free mode).

With this change, elements for a language in free mode
are also shown, when the option is set.

Resolves: #62550
Releases: master, 8.7
Change-Id: I96f754ecf4ddb98f22d0d8c7d7da6001fa774d6b
Reviewed-on: https://review.typo3.org/56932
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Ensure Extbase translation tests fulfill expectations 53/57053/2
Nicole Cordes [Fri, 25 May 2018 10:14:15 +0000 (12:14 +0200)]
[BUGFIX] Ensure Extbase translation tests fulfill expectations

Ensure the test is executed as expected.

Resolves: #85082
Releases: master, 8.7
Change-Id: Ia0dfbdc12eeefbb28996f69dade4298b1464afa6
Reviewed-on: https://review.typo3.org/57053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
8 months ago[TASK] Set TYPO3 version to 8.7.16-dev 44/57044/2
Oliver Hader [Wed, 23 May 2018 11:32:28 +0000 (13:32 +0200)]
[TASK] Set TYPO3 version to 8.7.16-dev

Change-Id: I0af64591684339c5467c624060f99a78f6f742b1
Reviewed-on: https://review.typo3.org/57044
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 8.7.15 43/57043/2 8.7.15 TYPO3_8-7-15 v8.7.15
Oliver Hader [Wed, 23 May 2018 11:31:11 +0000 (13:31 +0200)]
[RELEASE] Release of TYPO3 8.7.15

Change-Id: I12ab5bc79610b960aed6dafc758740472422af44
Reviewed-on: https://review.typo3.org/57043
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Add missing use statement 39/57039/4
Anja [Tue, 22 May 2018 14:57:16 +0000 (16:57 +0200)]
[BUGFIX] Add missing use statement

Resolves: #85064
Related: #78600
Releases: 8.7
Change-Id: I000ba42c2dde11b25508674397696450c739ba35
Reviewed-on: https://review.typo3.org/57039
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[TASK] Set TYPO3 version to 8.7.15-dev 35/57035/2
Oliver Hader [Tue, 22 May 2018 13:52:14 +0000 (15:52 +0200)]
[TASK] Set TYPO3 version to 8.7.15-dev

Change-Id: I75dc05d54a7ed78473dff6e7b3361b60fbe99f50
Reviewed-on: https://review.typo3.org/57035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[RELEASE] Release of TYPO3 8.7.14 34/57034/2 8.7.14 TYPO3_8-7-14 v8.7.14
Oliver Hader [Tue, 22 May 2018 13:51:04 +0000 (15:51 +0200)]
[RELEASE] Release of TYPO3 8.7.14

Change-Id: I1756abb25e65cabe6b678bfdb359421b3c42b678
Reviewed-on: https://review.typo3.org/57034
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Add SYS/ipAnonymization to DefaultConfiguration 28/57028/6
Andreas Fernandez [Tue, 22 May 2018 09:57:01 +0000 (11:57 +0200)]
[BUGFIX] Add SYS/ipAnonymization to DefaultConfiguration

Resolves: #85060
Related: #84053
Releases: master, 9.2, 8.7, 7.6
Change-Id: I04dba093dc8e423adbf75e2198c31e5c013864cb
Reviewed-on: https://review.typo3.org/57028
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[FEATURE] Allow adding additional query restrictions 56/56956/3
Helmut Hummel [Fri, 11 May 2018 22:33:04 +0000 (00:33 +0200)]
[FEATURE] Allow adding additional query restrictions

Make it possible to add additional query restrictions,
that will be applied to every query.

Resolves: #84244
Releases: master, 8.7
Change-Id: I0d0a5546629587306e537da51d8a2557d7e95fce
Reviewed-on: https://review.typo3.org/56956
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
8 months ago[BUGFIX] Add int cast for GFX/processor_effects check 23/57023/3
Frank Naegler [Tue, 22 May 2018 08:54:49 +0000 (10:54 +0200)]
[BUGFIX] Add int cast for GFX/processor_effects check

Resolves: #85059
Related: #81700
Releases: 8.7
Change-Id: Icf7112d938c7905e2c9bda03a9b48cc8e9cfac0b
Reviewed-on: https://review.typo3.org/57023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] getTreeList must return comma-separated list 84/56984/2
Guido Schmechel [Tue, 13 Mar 2018 20:22:03 +0000 (21:22 +0100)]
[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/56984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Add missing docs for youtube no-cookie domain change 20/57020/3
Mathias Brodala [Thu, 17 May 2018 07:13:20 +0000 (09:13 +0200)]
[BUGFIX] Add missing docs for youtube no-cookie domain change

The doc file was only added for v7, it must also be added to master
and v8.

Resolves: #85029
Related: #84843
Releases: master, 8.7
Change-Id: I2e372eae6bc90a0da0e441237b087b98319a183e
Reviewed-on: https://review.typo3.org/57020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Skip adding child elements if a nested form element is unknown 21/57021/2
Ralf Zimmermann [Sat, 21 Apr 2018 08:06:37 +0000 (10:06 +0200)]
[BUGFIX] Skip adding child elements if a nested form element is unknown

Skip adding child elements within the form factory if a nested form
element is unknown.

Resolves: #84833
Releases: master, 8.7
Change-Id: I1cbb87b4c460bd45b58aa6bcca27a88c61a7e92f
Reviewed-on: https://review.typo3.org/57021
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Use better icons for backend layout grid editor actions 08/57008/2
Mathias Brodala [Tue, 15 May 2018 08:01:33 +0000 (10:01 +0200)]
[BUGFIX] Use better icons for backend layout grid editor actions

Change-Id: Ie2ca536b5e1bd6e28e46af8073aaff4e298ddecf
Resolves: #85008
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57008
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
9 months ago[TASK] Log message when typolink fails 06/57006/3
Mathias Brodala [Thu, 17 May 2018 13:39:44 +0000 (15:39 +0200)]
[TASK] Log message when typolink fails

We log this as debug to not fill system logs by default.

Resolves: #85034
Releases: master, 8.7
Change-Id: Ica686e42fa7a2ef09f2f5c4bf9b91781f5c14dc9
Reviewed-on: https://review.typo3.org/57006
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Prevent endless loop in recycler folder detection 02/57002/2
Alexander Stehlik [Wed, 16 May 2018 21:16:22 +0000 (23:16 +0200)]
[BUGFIX] Prevent endless loop in recycler folder detection

Compare folder identifiers instead of folder objects because
objects pointing to the same folder might still be different
object instances.

Change-Id: I78e21b9e68fbaae245d12ac4efb96312b246a847
Releases: master, 8.7
Resolves: #85019
Reviewed-on: https://review.typo3.org/57002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Improve form documentation 98/56998/2
Björn Jacob [Thu, 17 May 2018 15:27:55 +0000 (17:27 +0200)]
[TASK] Improve form documentation

* introduce new role for inline YAML code styles
* fix some internal and external links

Resolves: #85037
Releases: master, 8.7
Change-Id: Ie5581bcc911914c49511ff86c5679f04c45c9f00
Reviewed-on: https://review.typo3.org/56998
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Add documentation for DatePicker formats 82/56982/2
Björn Jacob [Wed, 16 May 2018 15:06:16 +0000 (17:06 +0200)]
[TASK] Add documentation for DatePicker formats

This patch adds some documentation for the DatePicker
form element and the available date formats.

Resolves: #82508
Releases: master, 8.7
Change-Id: I1277c024112633ec7e38f4c8cbe30efb97375ce3
Reviewed-on: https://review.typo3.org/56982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[TASK] Make honeypot field accessible 96/56996/2
Björn Jacob [Thu, 17 May 2018 11:35:51 +0000 (13:35 +0200)]
[TASK] Make honeypot field accessible

The honeypot field now passes the accessibility tests WCAG 2.0 (tested
with Google Lighthouse).

Instead of inserting a label tag or a title attribute - which would be
counterproductive by revealing the purpose of the honeypot - the patch
adds an aria-hidden attribute.

Resolves: #75591
Releases: master, 8.7
Change-Id: Ie4b0b7a245f5c0edf3e01ece60dcb638b2f9bdc1
Reviewed-on: https://review.typo3.org/56996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[BUGFIX] Set opt-in for override checkbox in TCA input elements 89/56989/2
Tim Schreiner [Thu, 29 Mar 2018 21:21:40 +0000 (23:21 +0200)]
[BUGFIX] Set opt-in for override checkbox in TCA input elements

When useOrOverridePlaceholder mode is used for TCA input type,
use opt-in for the checkbox when placeholder is empty.

In some cases, the placeholder can be empty. Especially when the
placeholder uses data from another field. When information is added
to the corresponding field, the input field does not take this in account
because the override checkbox is set by default.

This can lead to problems for title and alternative fields in the
sys_file_metadata table. When adding a file reference and setting the
title or alternative field afterwards in the original file, the reference
is still using the empty override from file reference.

Resolves: #84563
Releases: master, 8.7
Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a
Reviewed-on: https://review.typo3.org/56989
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Document 'defaultValue' handling of form 93/56993/2
Björn Jacob [Thu, 17 May 2018 10:58:52 +0000 (12:58 +0200)]
[TASK] Document 'defaultValue' handling of form

The form framework supports setting a 'defaultValue' for most
of the form elements. This patch adds some information about
this setting and outlines the difference to the 'prependOptionValue'
setting.

Resolves: #82422
Releases: master, 8.7
Change-Id: Ic3bbe76ebe69ac0655e11ba501d62ee19b2d143f
Reviewed-on: https://review.typo3.org/56993
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[TASK] Add clarification regarding honeypot and caching 88/56988/2
Björn Jacob [Wed, 16 May 2018 17:30:01 +0000 (19:30 +0200)]
[TASK] Add clarification regarding honeypot and caching

This patch adds some documentation regarding the automatic
inclusion of the honeypot and (static) site caching.

Resolves: #83212
Releases: master, 8.7
Change-Id: I9e7b56a8e515172f6a91274512db13488b41eacb
Reviewed-on: https://review.typo3.org/56988
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[BUGFIX] Fix deletion of invalid tasks 73/56973/2
Mathias Brodala [Mon, 14 May 2018 09:37:57 +0000 (11:37 +0200)]
[BUGFIX] Fix deletion of invalid tasks

If the class of a registered task is missing, e.g. because the related
extension has been removed, the task itself will be unserialized into
an __PHP_Incomplete_Class object. Checking the task execution is an
invalid access in this case and must be avoided for such tasks to be
deleted.

Resolves: #84973
Releases: master, 8.7
Change-Id: Iaec8a5e346a0d6257a942cbead50b214036ed700
Reviewed-on: https://review.typo3.org/56973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>