Packages/TYPO3.CMS.git
4 years ago[TASK] Removes eval() in core general utility unit tests 46/40446/5
Pierrick Caillon [Thu, 18 Jun 2015 12:56:00 +0000 (14:56 +0200)]
[TASK] Removes eval() in core general utility unit tests

Adds and updates fixtures JavaScript minifying error test, class
replacement test, instantiation with constructor parameters test
and deprecated log permissions test and removes the ugly usage of
eval() from GeneralUtilityTest in unit tests.

Resolves: #67600
Related: #67468
Releases: master
Change-Id: Id5990bb21b2c395787ac5013a1440c5a71462e23
Reviewed-on: http://review.typo3.org/40446
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in core path utility unit tests 35/40435/3
Pierrick Caillon [Thu, 18 Jun 2015 10:39:56 +0000 (12:39 +0200)]
[TASK] Removes eval() in core path utility unit tests

Adds fixture for a Windows environment PathUtility and removes the
ugly usage of eval() from PathUtilityTest in unit tests.

Resolves: #67596
Related: #67468
Releases: master
Change-Id: I0f4135e6f9200c529854a28acefa01953c8bdf89
Reviewed-on: http://review.typo3.org/40435
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in core mailer unit test 48/40448/3
Pierrick Caillon [Thu, 18 Jun 2015 13:26:53 +0000 (15:26 +0200)]
[TASK] Removes eval() in core mailer unit test

Adds fixture for FakeTransport and removes the ugly usage of
eval() from MailerTest in unit tests.

Resolves: #67604
Related: #67468
Releases: master
Change-Id: I37011a5eaadc0abac38e1c53bcd20bbe3e62f4fd
Reviewed-on: http://review.typo3.org/40448
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Properly escape data in SelectImage 27/40327/2
Wouter Wolters [Tue, 16 Jun 2015 18:32:16 +0000 (20:32 +0200)]
[BUGFIX] Properly escape data in SelectImage

Resolves: #67527
Releases: master
Change-Id: Id4e80a03a9553eab742e3dd1b44117e04a5180b7
Reviewed-on: http://review.typo3.org/40327
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[CLEANUP] EXT:backend/Classes/Controller/*.php 49/37849/13
Michael Oehlhof [Sun, 15 Mar 2015 01:55:38 +0000 (02:55 +0100)]
[CLEANUP] EXT:backend/Classes/Controller/*.php

Refactor the code to go green in PHPStorm.

- declare missing class variables
- add getter for LanguageService
- add getter for BackendUser
- add getter for TimeTracker
- add getter for DocumentTemplate
- add getter for DatabaseConnection
- fix code style issues "Unnecessary fully qualified name"

Resolves: #65738
Releases: master
Change-Id: I5a870c2760d73da9a17062165be977ae253ab81d
Reviewed-on: http://review.typo3.org/37849
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in core version number utility unit tests 31/40431/3
Pierrick Caillon [Thu, 18 Jun 2015 10:16:00 +0000 (12:16 +0200)]
[TASK] Removes eval() in core version number utility unit tests

Adds fixture for specifying current version in VersionNumberUtility
and removes the ugly usage of eval() from VersionNumberUtilityTest.

Resolves: #67594
Related: #67468
Releases: master
Change-Id: Ia4b256c1a1e61dc117519c243d0e465fb36e8662
Reviewed-on: http://review.typo3.org/40431
Reviewed-by: Alexander Krist <mail@alex-krist.de>
Tested-by: Alexander Krist <mail@alex-krist.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Properly resolve link format to page type 87/38687/4
Daniel Schmidt [Tue, 14 Apr 2015 10:55:38 +0000 (12:55 +0200)]
[BUGFIX] Properly resolve link format to page type

This fixes the resolving of link format to target page type
when creating frontend links with the UriBuilder.

Resolves: #66352
Releases: master, 6.2
Change-Id: I6bb6ec805212cd7411ecd17e4abc3ac542f7a337
Reviewed-on: http://review.typo3.org/38687
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Save pixels: hide Workspace toolbar item when unused 68/40368/5
Felix Kopp [Wed, 17 Jun 2015 15:21:37 +0000 (17:21 +0200)]
[TASK] Save pixels: hide Workspace toolbar item when unused

In use case where EXT: workspaces is installed and activated but no
additional Workspaces (sys_workspace) records are added TYPO3
should assume that Workspaces are unused. No permanently visible
button should sit in the topbar.

Resolves: #67568
Releases: master
Change-Id: I1a4bd40df79458690ce1c0d9e141dd71247d8cbf
Reviewed-on: http://review.typo3.org/40368
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add missing break statements 52/40452/2
Markus Klein [Thu, 18 Jun 2015 19:15:03 +0000 (21:15 +0200)]
[BUGFIX] Add missing break statements

UserSettingsController misses break statements in a switch
control structure. Add them.

Resolves: #67615
Releases: master
Change-Id: I9cd42d77324993b10b304ea85436537d448fe56e
Reviewed-on: http://review.typo3.org/40452
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Show expected targetType on "Object not found" errors 41/40141/3
Mathias Brodala [Wed, 10 Jun 2015 07:06:11 +0000 (09:06 +0200)]
[TASK] Show expected targetType on "Object not found" errors

If the ``PersistentObjectConverter`` cannot find an object by
given identity the error message shows the identity but not the
expected object type. Adding it helps a lot in debugging such errors.

Resolves: #67382
Releases: master
Change-Id: Ib13e1e7927b2b56cb6c23555608703dfcda060b9
Reviewed-on: http://review.typo3.org/40141
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Check if file exists before deletion 38/40238/2
Christoph Lehmann [Mon, 15 Jun 2015 08:16:34 +0000 (10:16 +0200)]
[BUGFIX] Check if file exists before deletion

File deletion in "processed" folder no longer throws an exception when
trying to delete a file that does not exist.

Resolves: #67432
Releases: master, 6.2
Change-Id: I59acdcbb04725ce4425ca3f333093e5a870046ca
Reviewed-on: http://review.typo3.org/40238
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[FEATURE] Custom attribute name and multiple values for meta tags 20/40120/17
Alexander Kontos [Thu, 11 Jun 2015 22:32:23 +0000 (00:32 +0200)]
[FEATURE] Custom attribute name and multiple values for meta tags

To support a broader range of possible meta tags we need a specify
the used attribute name. Also now it is possible to ad the same
meta tag with different values.

Resolves: #67360
Releases: master
Change-Id: Ic8f8e03a7b137302af6613edfbe7e89a50e25e12
Reviewed-on: http://review.typo3.org/40120
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Fix check for import / export folder 38/40338/2
Alexander Stehlik [Wed, 17 Jun 2015 09:45:18 +0000 (11:45 +0200)]
[BUGFIX] Fix check for import / export folder

When the import / export folder is not available a NULL value
is returned. The condition that checks if a vaild folder is
found now checks for NULL values instead of FALSE.

Releases: master, 6.2
Resolves: #67543
Change-Id: Ie9d6314506f9c8bbea19ed445e29b5bd1d8a544b
Reviewed-on: http://review.typo3.org/40338
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Tested-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
4 years ago[BUGFIX] Use single quotes for password check 36/40436/3
Andreas Fernandez [Thu, 18 Jun 2015 10:46:14 +0000 (12:46 +0200)]
[BUGFIX] Use single quotes for password check

Use single quotes for the password check in
SaltedPasswordsUtility::getNumberOfBackendUsersWithInsecurePassword
to tell other DBMS to expect a value and not an identifier.

Using double quotes for values violates the SQL standard.

Resolves: #67599
Releases: master, 6.2
Change-Id: I4d17f2eb24e77421da2368cc899a021c435cfff8
Reviewed-on: http://review.typo3.org/40436
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
4 years ago[CLEANUP] Code duplication in DataHandler::copyRecord_processManyToMany() 23/40423/5
Andreas Wolf [Wed, 17 Jun 2015 18:54:07 +0000 (20:54 +0200)]
[CLEANUP] Code duplication in DataHandler::copyRecord_processManyToMany()

There was a foreach loop that only differed in one line, but was
duplicated due to the complex condition around it. This commit splits
the condition, introduces helper variables and moves the condition
inside the foreach loop to get rid of the duplication.

Additionally, duplicated lines for purging the items of the relation
analyzer are also removed.

Resolves: #67579
Releases: master
Change-Id: Ibb9277dfb32960cc77aee17839d7df3bf57fc6da
Reviewed-on: http://review.typo3.org/40423
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Check access to folder in FileListController 08/39108/9
Nicole Cordes [Thu, 30 Apr 2015 16:12:27 +0000 (18:12 +0200)]
[BUGFIX] Check access to folder in FileListController

Currently if a folder isn't accessible for the user, the root folder
is taken as fallback solution. But this folder might be inaccessible as
well. This patch adds an access check for the returned folder and
turns thrown errors into flash messages.

Releases: master, 6.2
Resolves: #66693
Resolves: #56641
Change-Id: I310df8061edc790dde1034a27136365b4253ac7f
Reviewed-on: http://review.typo3.org/39108
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] dbal: Ignore MySQL ENGINE in database schema compare 55/40055/3
Morton Jonuschat [Sat, 6 Jun 2015 18:04:26 +0000 (20:04 +0200)]
[FEATURE] dbal: Ignore MySQL ENGINE in database schema compare

Ignore the database engine when comparing the expected and the
current schema information if DBAL is enabled. The MySQL specific
storage engines are not available on other DBMS.

Resolves: #67302
Releases: master
Change-Id: Ic57233de7c4294454609955e802498053f186326
Reviewed-on: http://review.typo3.org/40055
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] dbal: Always initialize the DBMS specifics 35/40135/2
Morton Jonuschat [Tue, 9 Jun 2015 18:37:35 +0000 (20:37 +0200)]
[BUGFIX] dbal: Always initialize the DBMS specifics

Make default DBMS specifics available when no DBAL handler has
been configured to fix errors in the install tool.

Resolves: #67380
Releases: master
Change-Id: I8140fbe570628a5747e21a6e07920b8fbdc820b1
Reviewed-on: http://review.typo3.org/40135
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Add basic unit tests for ContentObjectRenderer::typoLink 91/40391/3
Nicole Cordes [Wed, 17 Jun 2015 19:43:20 +0000 (21:43 +0200)]
[TASK] Add basic unit tests for ContentObjectRenderer::typoLink

Resolves: #67586
Releases: master, 6.2
Change-Id: I0c20b13469d9bb9af844f92ee87181a55bacc906
Reviewed-on: http://review.typo3.org/40391
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] RTE: Remove tt_content rte_enabled and flag handling 80/40380/2
Christian Kuhn [Wed, 17 Jun 2015 18:01:20 +0000 (20:01 +0200)]
[!!!][TASK] RTE: Remove tt_content rte_enabled and flag handling

The tt_content field rte_enabled is not really useful anymore, RTE
can be disabled on a per-user basis. The field is removed from DB
together with the "flag" handling.

Resolves: #67577
Releases: master
Change-Id: I214baf45228a91d2193b54fbbc9ee71632e39bdf
Reviewed-on: http://review.typo3.org/40380
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Extend FileMount-Model with description-field 86/40386/2
Daniel Maier [Wed, 17 Jun 2015 19:01:14 +0000 (21:01 +0200)]
[TASK] Extend FileMount-Model with description-field

The new description-field that was recently added to table sys_filemounts
is now also added to the FileMount-Model.

Resolves: #67581
Related: #59570
Releases: master
Change-Id: I70d174d2bd9b10fe913fb06b713f5899c35f8bf9
Reviewed-on: http://review.typo3.org/40386
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Early continue in DataHandler::process_* 95/40295/2
Andreas Wolf [Tue, 16 Jun 2015 10:20:28 +0000 (12:20 +0200)]
[CLEANUP] Early continue in DataHandler::process_*

Resolves: #67500
Releases: master
Change-Id: Iaab030099f565deb10d22c254856af7a07ecd3e9
Reviewed-on: http://review.typo3.org/40295
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Split DataHandler::copyRecord_procBasedOnFieldType 11/40311/6
Andreas Wolf [Tue, 16 Jun 2015 11:36:20 +0000 (13:36 +0200)]
[TASK] Split DataHandler::copyRecord_procBasedOnFieldType

This is the first part to get this method down to an understandable
size. The two factored out methods should be further simplified/split
up.

Resolves: #67510
Releases: master
Change-Id: Ice6692cf916591687aaaf9296d8834ef3d352ca5
Reviewed-on: http://review.typo3.org/40311
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Properly escape option value for groups 21/40321/2
Wouter Wolters [Tue, 16 Jun 2015 17:18:55 +0000 (19:18 +0200)]
[BUGFIX] Properly escape option value for groups

Resolves: #56296
Releases: master,6.2
Change-Id: I2960cc23b6fdb44e5159c74c126feaa6070eb7bf
Reviewed-on: http://review.typo3.org/40321
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
4 years ago[FOLLOWUP][TASK] Convert dropdowns in clipboard to TWBS 82/40382/3
Andreas Fernandez [Wed, 17 Jun 2015 18:18:01 +0000 (20:18 +0200)]
[FOLLOWUP][TASK] Convert dropdowns in clipboard to TWBS

Remove double quotes from URL.

Releases: master
Resolves: #67560
Change-Id: I4097f7096b58a6aa3a7fde0bac521e43bf638a81
Reviewed-on: http://review.typo3.org/40382
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Hide "Create ..." buttons, if maxitems is reached 57/40257/7
Jonathan IROULIN [Mon, 15 Jun 2015 15:54:29 +0000 (17:54 +0200)]
[BUGFIX] Hide "Create ..." buttons, if maxitems is reached

This patch hide "Creation relation", "Create new ..." and
"Select & Upload" button when the edit form is generated if there
is a maxitems limit in the TCA. The buttons are not immediately
hidden/shown if the number of relation changes. That would involve
JavaScript magic and could be done in a follow up.

Resolves: #45125
Releases: master
Change-Id: I725aee28568c67dfc3b2feebb62d39ec5432d149
Reviewed-on: http://review.typo3.org/40257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Convert dropdowns in clipboard to TWBS 62/40362/3
Jan Helke [Wed, 17 Jun 2015 13:55:27 +0000 (15:55 +0200)]
[TASK] Convert dropdowns in clipboard to TWBS

This patch converts the dropdowns in the clipboard from select options to
ul li list to follow the TWBS guidelines.

Releases: master
Resolves: #67560
Change-Id: Ic1f3d769170a59b0217198030c9ef30aa9a5124a
Reviewed-on: http://review.typo3.org/40362
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
4 years ago[BUGFIX] Fix SQL error on recursive TypoScript template inclusion 47/40147/2
Andreas Fernandez [Wed, 10 Jun 2015 11:09:16 +0000 (13:09 +0200)]
[BUGFIX] Fix SQL error on recursive TypoScript template inclusion

If TypoScript templates are included recusively (a > b > a), the
$basedOnIds array is empty and creates an invalid SQL query.

Resolves: #64654
Releases: master, 6.2
Change-Id: Ia3001e1e620d6bb4d2d1f3ad016816bc5636dff1
Reviewed-on: http://review.typo3.org/40147
Reviewed-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Tested-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Move language file of EXT:opendocs 54/40354/4
Andreas Fernandez [Wed, 17 Jun 2015 12:22:25 +0000 (14:22 +0200)]
[!!!][TASK] Move language file of EXT:opendocs

Move the language file to Resources/Private/Language/locallang.xlf.

Resolves: #67557
Releases: master
Change-Id: I46eb8a7931d82babda1fee78b925367cd12bf59d
Reviewed-on: http://review.typo3.org/40354
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] RTE: Remove unused css files 70/40370/2
Christian Kuhn [Wed, 17 Jun 2015 16:23:05 +0000 (18:23 +0200)]
[TASK] RTE: Remove unused css files

A number of .css files within RTE are referenced in the plugin files
but never included since addIconsToSkin is not 1. The patch removes
those files and cleans up ext_localconf a bit.

Resolves: #67571
Releases: master
Change-Id: I07daa2c56563a6e627c58a472707372b8199a292
Reviewed-on: http://review.typo3.org/40370
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][FEATURE] Support IEC/SI units in file size formatting 91/40291/12
Pierrick Caillon [Tue, 16 Jun 2015 11:35:01 +0000 (13:35 +0200)]
[!!!][FEATURE] Support IEC/SI units in file size formatting

The new labels "iec" and "si" are added to GeneralUtility::formatSize,
where "iec" is the new default label.

A new parameter "base" has been added for specifying the base unit
multiplier expecting 1000 and 1024 as value and defaulting to 1024
when using the old labels.

Resolves: #22175
Releases: master
Change-Id: Iaa255f639b0421e508f561557a6c6b2e2b226bc9
Reviewed-on: http://review.typo3.org/40291
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] FormEngine: Size equals to 1 if none set on multi-selects 29/27829/7
Daniel Maier [Wed, 17 Jun 2015 10:36:03 +0000 (12:36 +0200)]
[BUGFIX] FormEngine: Size equals to 1 if none set on multi-selects

Having a FormEngine select element with maxitems=10
and no size set, then a typical single-select element
is rendered, with no chance of using the up- and
down buttons provided, as the single select does not
allow to use more than one entry in rendering.

The browser behavior is not adopted and if size
is not given, a broken state is rendered.

Releases: master
Resolves: #56259
Change-Id: I9963503cb046353b81f13b0c624bddbd7e5b74f8
Reviewed-on: http://review.typo3.org/27829
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] RTE: Remove empty locallang files 58/40358/3
Christian Kuhn [Wed, 17 Jun 2015 13:37:29 +0000 (15:37 +0200)]
[TASK] RTE: Remove empty locallang files

Some locallang.xlf files in RTE are empty. Remove them
together with their references.

Resolves: #67559
Releases: master
Change-Id: I3d08bf1c9f142cdb0719d7b0284293481db15df3
Reviewed-on: http://review.typo3.org/40358
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add description-field for filemounts 85/40285/3
Daniel Maier [Tue, 16 Jun 2015 10:08:36 +0000 (12:08 +0200)]
[FEATURE] Add description-field for filemounts

With the new field it is possible to give a short description what a
certain filemount should be used for or which documents they contain, etc.

Change-Id: Ia0e9d8385d8a6f0620b20581f4acc497dc9ffca9
Resolves: #59570
Releases: master
Reviewed-on: http://review.typo3.org/40285
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Misleading annotation in createVersionNumberedFilename 44/40344/2
Christian Kuhn [Wed, 17 Jun 2015 11:19:32 +0000 (13:19 +0200)]
[BUGFIX] Misleading annotation in createVersionNumberedFilename

The method returns a string.

Resolves: #67549
Releases: master
Change-Id: I7b9b6a1000ddfbb3394b545f42370ba39dcbecbe
Reviewed-on: http://review.typo3.org/40344
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][TASK] Deprecate init.php 42/40342/5
Wouter Wolters [Wed, 17 Jun 2015 11:11:10 +0000 (13:11 +0200)]
[FOLLOWUP][TASK] Deprecate init.php

Add missing TYPO3_MODE in two places.

Resolves: #67471
Releases: master
Change-Id: I02a77209dabe4267a4df57b754048160482e2c50
Reviewed-on: http://review.typo3.org/40342
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install 36/40336/4
Jonathan IROULIN [Wed, 17 Jun 2015 08:15:39 +0000 (10:15 +0200)]
[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install

fe_login is a preinstalled extension but the "/uploads/tx_felogin" folder
was not created during step-2 installation process.
This patch add "tx_felogin" folder in "uploads" folder
during the process installation.

Resolves: #60261
Releases: master, 6.2
Change-Id: If4914b958b7117dc9f33d303d29850124b775b50
Reviewed-on: http://review.typo3.org/40336
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add table of content page for 7.3 35/40335/3
Wouter Wolters [Wed, 17 Jun 2015 08:10:09 +0000 (10:10 +0200)]
[TASK] Add table of content page for 7.3

Resolves: #67536
Releases: master
Change-Id: I1527b99395ab44263194922579cb482bbe567542
Reviewed-on: http://review.typo3.org/40335
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Update Bootstrap to 3.3.5 20/40320/2
Andreas Fernandez [Tue, 16 Jun 2015 17:18:25 +0000 (19:18 +0200)]
[TASK] Update Bootstrap to 3.3.5

Resolves: #67522
Releases: master
Change-Id: Iceae001a8519fbf33f8661425b732349e969fbf6
Reviewed-on: http://review.typo3.org/40320
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove unused icons in typo3/gfx/ 17/40317/2
Benjamin Mack [Tue, 16 Jun 2015 17:02:30 +0000 (19:02 +0200)]
[TASK] Remove unused icons in typo3/gfx/

Resolves: #67520
Releases: master
Change-Id: I4db740c6eead3d2b77cd7a879a8f5912b6b97db9
Reviewed-on: http://review.typo3.org/40317
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Restore the layout of the clipboard 19/40319/2
Jan Helke [Tue, 16 Jun 2015 17:12:55 +0000 (19:12 +0200)]
[BUGFIX] Restore the layout of the clipboard

Reposition the thumbnail back in another column than the icon.

Releases: master
Resolves: #67521
Change-Id: I2506635e555eaae9cc0ee6c2b9f82c0f72c2c5f5
Reviewed-on: http://review.typo3.org/40319
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Removes eval() in abstract backend unit tests 88/40288/5
Alexander Krist [Tue, 16 Jun 2015 10:57:34 +0000 (12:57 +0200)]
[TASK] Removes eval() in abstract backend unit tests

Adds a new AccessibleProxy for AbstractBackend and removes the ugly
usage of eval() from AbstractBackendTest in unit tests.

Change-Id: I3c471219fe37ecf8a51cb02b60c75130fbb4ad25
Resolves: #67489
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40288
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove show/hide thumbnails button from clipboard 07/40307/4
Jan Helke [Tue, 16 Jun 2015 14:37:43 +0000 (16:37 +0200)]
[TASK] Remove show/hide thumbnails button from clipboard

This patch remove the button to show and hide the thumbnails of images
from the clipboard. The thumbnails will be shown by default.

Releases: master
Resolves: #67509
Change-Id: Ic1e714e9f46b02555e310fc9399ba1c6e9ebde7c
Reviewed-on: http://review.typo3.org/40307
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Clean up unused t3skin variables in ext_tables.php 14/40314/2
Benjamin Mack [Tue, 16 Jun 2015 16:10:47 +0000 (18:10 +0200)]
[TASK] Clean up unused t3skin variables in ext_tables.php

There are several options and references within
EXT:t3skin/ext_tables.php which are not in use anymore
and can simple be removed.

Resolves: #67518
Releases: master
Change-Id: I6aafadc558a3ee8108964928464038ccf4b828c5
Reviewed-on: http://review.typo3.org/40314
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove usage of _icon_website.gif 13/40313/3
Benjamin Mack [Tue, 16 Jun 2015 16:00:39 +0000 (18:00 +0200)]
[TASK] Remove usage of _icon_website.gif

The occurence of _icon_website.gif was still used in two places
instead of using the proper sprite icon. The patch changes the
places to use sprite icons.

Resolves: #67517
Releases: master
Change-Id: I14222563aebfc08c2eb030b3550525d82597358a
Reviewed-on: http://review.typo3.org/40313
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 years ago[!!!][FEATURE] "Content-Language" HTTP header now added when rendering 65/40265/5
Romain L [Mon, 15 Jun 2015 17:54:10 +0000 (19:54 +0200)]
[!!!][FEATURE] "Content-Language" HTTP header now added when rendering

The "Content-Language" is now sent as a both meta tag and HTTP header.
Previously page language information was only sent as meta tag.

By default new and existing installations will send a header
"Content-language: XX" where "XX" is the iso code of the
sys_language_content if that is properly defined by the sys_language
record representing the sys_language_uid.
A new Typoscript configuration "config.disableLanguageHeader" allows
to disable this behavior.
You must set "config.disableLanguageHeader" to get the previous
behavior (no header).

Resolves: #33071
Releases: master
Change-Id: I2de9ad3deb93b9e2266ff03cb68d3fb60250bf41
Reviewed-on: http://review.typo3.org/40265
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Deprecate IconUtility::getIcon and clean up "gfx/i/" 05/40305/2
Benjamin Mack [Tue, 16 Jun 2015 14:32:40 +0000 (16:32 +0200)]
[TASK] Deprecate IconUtility::getIcon and clean up "gfx/i/"

The method IconUtility::getIcon was used for returning
overlaid icons before TYPO3 CMS 4.4, based on raw icons
inside gfx/i/ and created temporary icons when not present.

The left-over function calls are replaced with sprite icon calls.

Additionally, in order to thin out typo3/gfx/, all icons which have
always been overlaid with t3skin already have been removed. All
other files from typo3/gfx/i/ are moved to EXT:t3skin to
stay compatible.

With TYPO3 CMS 8, the folder EXT:t3skin/icons/gfx/i/ will
be completely removed with the function itself.

Resolves: #67506
Releases: master
Change-Id: Idc20fadd36ffeb26782d8d54e27802a0412f9516
Reviewed-on: http://review.typo3.org/40305
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] ViewHelper Exceptions are logged in Production 12/40212/6
Helmut Hummel [Fri, 12 Jun 2015 15:20:17 +0000 (17:20 +0200)]
[BUGFIX] ViewHelper Exceptions are logged in Production

In Production context all Exceptions from ViewHelpers
will be silently logged.
Additionally, the output is discarded from rendering.
In Development they will be re-thrown, so the
global exception handler will be triggered.

Resolves: #32528
Releases: master
Change-Id: I4af4d03ff6048fcc8999f4a48d5c2897dc43fc4e
Reviewed-on: http://review.typo3.org/40212
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Peter Niederlag <peter.niederlag@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Fix small typo in EditDocumentController 06/40306/2
Wouter Wolters [Tue, 16 Jun 2015 14:34:04 +0000 (16:34 +0200)]
[TASK] Fix small typo in EditDocumentController

Resolves: #67508
Releases: master
Change-Id: I185300d1cf50a9d8407421c03c8996d66fc79262
Reviewed-on: http://review.typo3.org/40306
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] 404 error after closing edit wizard 87/40287/4
Gilles FOUET [Tue, 16 Jun 2015 10:06:45 +0000 (12:06 +0200)]
[BUGFIX] 404 error after closing edit wizard

The returnUrl parameter was double encoded around getModuleUrl.
Now it's encoded only one time.

Resolves: #67473
Releases: master
Change-Id: I59345018f61717abbd6cfea02891c28441158b61
Reviewed-on: http://review.typo3.org/40287
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove icons from clipboard menu 01/40301/3
Jan Helke [Tue, 16 Jun 2015 13:47:38 +0000 (15:47 +0200)]
[TASK] Remove icons from clipboard menu

This patch removes the scissor + paper icon from the dropdown
menu of the Clipboard in the List module and the File list module.
As they do not fit the style logic anymore and do not describe
the actions "Move" and "Copy" properly, they are removed without
substitution.

Releases: master
Resolves: #67504
Change-Id: I562dac0b6475ac1b1c23976c5c0d612d6ca0e3e3
Reviewed-on: http://review.typo3.org/40301
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Unify handling of TYPO3_PROCEED_IF_NO_USER 33/38033/8
Benjamin Mack [Mon, 23 Mar 2015 12:29:24 +0000 (13:29 +0100)]
[TASK] Unify handling of TYPO3_PROCEED_IF_NO_USER

The constant TYPO3_PROCEED_IF_NO_USER
allows for calling the Backend boostrap without
a authenticated user. The constant is now moved
mainly to the Request Handlers so it is encapsulated
in that area for now.

Once the Request Handler logic is streamlined better
the constant can be dropped in the core with a
deprecation layer.

Resolves: #65932
Releases: master
Change-Id: I02dfb384660be749247ea27e05038d3f0b373896
Reviewed-on: http://review.typo3.org/38033
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][CLEANUP] Early returns for DataHandler::copyRecord() and friends 99/40299/2
Christian Kuhn [Tue, 16 Jun 2015 13:42:28 +0000 (15:42 +0200)]
[FOLLOWUP][CLEANUP] Early returns for DataHandler::copyRecord() and friends

A missing parenthesis destroys the boolean logic so a
couple of functional tests fail.

Related: #67336
Releases: master
Change-Id: I4544ebf5b339d85f65bcf2aa1fa03daf39c7b656
Reviewed-on: http://review.typo3.org/40299
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate $disable Option in PageRepository->getExtURL 73/39473/4
Benjamin Mack [Tue, 12 May 2015 04:13:46 +0000 (12:13 +0800)]
[TASK] Deprecate $disable Option in PageRepository->getExtURL

The disable option to check whether redirects are allowed
should be handled outside of the call to simplify code readability
and maintainability.

Resolves: #66904
Releases: master
Change-Id: Ica85c0703641ff4764233b626d0c08a64bb65d28
Reviewed-on: http://review.typo3.org/39473
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[CLEANUP] Early returns for DataHandler::copyRecord() and friends 81/40281/2
Andreas Wolf [Sun, 7 Jun 2015 09:10:23 +0000 (11:10 +0200)]
[CLEANUP] Early returns for DataHandler::copyRecord() and friends

Related: #67336
Releases: master
Change-Id: I40e944e0833ff75c7bdc77829d52fa3c868b7575
Reviewed-on: http://review.typo3.org/40281
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Early returns in various DataHandler methods 80/40280/2
Andreas Wolf [Sun, 7 Jun 2015 08:55:34 +0000 (10:55 +0200)]
[CLEANUP] Early returns in various DataHandler methods

Related: #67336
Releases: master
Change-Id: Ied575832fdb942f5cb0e82116148e9b336e01715
Reviewed-on: http://review.typo3.org/40280
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce early returns in DataHandler::moveRecord() 79/40279/2
Andreas Wolf [Sun, 7 Jun 2015 08:51:57 +0000 (10:51 +0200)]
[TASK] Introduce early returns in DataHandler::moveRecord()

Related: #67336
Releases: master
Change-Id: I790c40184d435c918d3a63a3a1e4d8225fcacde2
Reviewed-on: http://review.typo3.org/40279
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Empty item group in selectElement 04/40204/3
ajahn [Fri, 12 Jun 2015 08:42:37 +0000 (10:42 +0200)]
[BUGFIX] Empty item group in selectElement

Item groups that do not have any items are ignored and not rendered

Change-Id: I458a1491788fa8a78321a9c129949c08e62e375f
Resolves: #67394
Releases: master
Reviewed-on: http://review.typo3.org/40204
Tested-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Reviewed-by: Alexander Jahn <jahn.typo3@googlemail.com>
Tested-by: Alexander Jahn <jahn.typo3@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Change order of public static to static public 83/40283/5
Wouter Wolters [Tue, 16 Jun 2015 09:39:09 +0000 (11:39 +0200)]
[TASK] Change order of public static to static public

Do this also for protected static.

Resolves: #67487
Releases: master
Change-Id: I045bfb897bdfbfe58c9895792c3dcd340fc477b5
Reviewed-on: http://review.typo3.org/40283
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Removes eval() in scheduler unit tests 78/40278/5
Alexander Krist [Mon, 15 Jun 2015 18:02:13 +0000 (20:02 +0200)]
[TASK] Removes eval() in scheduler unit tests

Adds a new AccessibleProxy for NormalizeCommand and removes
the ugly usage of eval() from NormalizeCommandTest in unit tests.

Change-Id: I2465be5918167582fae5e3e612c89a69b6b22657
Resolves: #67485
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40278
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FEATURE] Allow .ts file extension for static typoscript templates 64/40264/6
Pierrick Caillon [Mon, 15 Jun 2015 17:20:01 +0000 (19:20 +0200)]
[FEATURE] Allow .ts file extension for static typoscript templates

Static TypoScript support alternative primary names for constants and
setup file:
* constants.ts
* setup.ts

Old names are still working:
* constants.txt
* setup.txt

Resolves: #34922
Releases: master
Change-Id: I6868c22c95337812e6946f16655f024f2ed80471
Reviewed-on: http://review.typo3.org/40264
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] File metadata can’t be edited inline 86/37586/6
Benjamin Mack [Mon, 15 Jun 2015 10:04:51 +0000 (12:04 +0200)]
[BUGFIX] File metadata can’t be edited inline

Since 2012, there is a special mechanism to allow some tables for
editing even if their records reside on a page that is inaccessible for
the user. This is checked for regular forms in
``EditDocumentController``, but the check for inline elements was
missing until this patch.

Resolves: #65563
Releases: master, 6.2
Change-Id: I6d984c28672e2b3ba225ea91f6c7292aa3e1127d
Reviewed-on: http://review.typo3.org/37586
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Include of flowplayer for 6.2 static template is wrong 71/40271/2
Wouter Wolters [Mon, 15 Jun 2015 18:51:43 +0000 (20:51 +0200)]
[BUGFIX] Include of flowplayer for 6.2 static template is wrong

Resolves: #67475
Releases: master
Change-Id: Ib8cfdd76f57c601f8162467168c3ec043809a3b9
Reviewed-on: http://review.typo3.org/40271
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove last usage of two icons from gfx folder and remove files 40/38440/8
Jan Helke [Thu, 2 Apr 2015 16:26:34 +0000 (18:26 +0200)]
[TASK] Remove last usage of two icons from gfx folder and remove files

Remove the last two usages of gfx/icon_note.gif and
gfx/icon_warning2.gif after the merge of
https://forge.typo3.org/issues/65992 .
These files are only used in TimeTracker.

TimeTracker is rendered in the AdminPanel, go to TypoScript accordion and
select "Display Messages"

Resolves: #66250
Related: #65992
Releases: master
Change-Id: I8d0485d3d4a66a41bce26a6c0a38c978dee52b88
Reviewed-on: http://review.typo3.org/38440
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update TYPO3 version in ext_emconf.php and composer.json 73/40273/2
Wouter Wolters [Mon, 15 Jun 2015 21:15:37 +0000 (23:15 +0200)]
[TASK] Update TYPO3 version in ext_emconf.php and composer.json

Resolves: #67478
Releases: master
Change-Id: I49cebb422ff87d245d757f7736a3b8b969e8b243
Reviewed-on: http://review.typo3.org/40273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Make use of bool/int in DocComments 75/40275/2
Frank Nägler [Mon, 15 Jun 2015 22:05:57 +0000 (00:05 +0200)]
[CLEANUP] Make use of bool/int in DocComments

Resolves: #67480
Releases: master
Change-Id: Ic59854fb05fa3b1593ecc37e49d91042be9b0d3a
Reviewed-on: http://review.typo3.org/40275
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Make use of bool/int in @param DocComments 74/40274/2
Wouter Wolters [Mon, 15 Jun 2015 21:29:28 +0000 (23:29 +0200)]
[CLEANUP] Make use of bool/int in @param DocComments

Resolves: #67479
Releases: master
Change-Id: Id857ad3f6f78e2c132a2af7569d4aecbf60dced9
Reviewed-on: http://review.typo3.org/40274
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[TASK] Deprecate init.php 41/40241/4
Benjamin Mack [Mon, 15 Jun 2015 09:11:24 +0000 (11:11 +0200)]
[TASK] Deprecate init.php

In order to move all unneeded files from typo3/, the originally lengthy init.php
is now deprecated in favor of using the bootstrap initialization code directly in
the TYPO3 Backend.

Resolves: #67471
Releases: master
Change-Id: Ibb6eb5fc44e985842fa5058cf9cdae50e87d114f
Reviewed-on: http://review.typo3.org/40241
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Update TYPO3 version to TYPO3 7.4-dev 68/40268/2
Benjamin Mack [Mon, 15 Jun 2015 18:27:36 +0000 (20:27 +0200)]
[TASK] Update TYPO3 version to TYPO3 7.4-dev

Releases: master
Change-Id: I7b4847cccc33dbbebe8d09af2a32001f5de238dd
Reviewed-on: http://review.typo3.org/40268
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Set TYPO3 version to 7.3.1-dev 67/40267/2
TYPO3 Release Team [Mon, 15 Jun 2015 18:26:09 +0000 (20:26 +0200)]
[TASK] Set TYPO3 version to 7.3.1-dev

Change-Id: I3efcdaf57aab3f931c4db936050baed4fc244299
Reviewed-on: http://review.typo3.org/40267
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[RELEASE] Release of TYPO3 7.3.0 66/40266/2 7.3.0 TYPO3_7-3-0
TYPO3 Release Team [Mon, 15 Jun 2015 18:25:21 +0000 (20:25 +0200)]
[RELEASE] Release of TYPO3 7.3.0

Change-Id: Ia515c614e2f43a2c3708cbd06343f5e5dd6e9292
Reviewed-on: http://review.typo3.org/40266
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[BUGFIX] Palettes "more options" can not be extended if new record is added 62/40262/2
Frank Nägler [Mon, 15 Jun 2015 17:12:04 +0000 (19:12 +0200)]
[BUGFIX] Palettes "more options" can not be extended if new record is added

HTML ID attribute must not contain a dot, which happens if a new record
is created. In this case the toggle button not work.
This patch replace the dot with an underscore.

Resolves: #67472
Releases: master
Change-Id: I8aa727bb4762e62b42f4dcdbb47477013023f879
Reviewed-on: http://review.typo3.org/40262
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Scheduler now throws OutOfBoundsException on SQL query error 56/40256/2
Mathias Schreiber [Mon, 15 Jun 2015 15:59:48 +0000 (17:59 +0200)]
[BUGFIX] Scheduler now throws OutOfBoundsException on SQL query error

If the query for fetchTask fails for whatever reason, scheduler will
now gracefully throw an exception instead of assuming it had gotten
a valid resource pointer

Resolves: #67463
Related: #39085
Releases: master, 6.2
Change-Id: I26819df3fd173b36de6121100a6398ed4b701319
Reviewed-on: http://review.typo3.org/40256
Reviewed-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Tested-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Data merging in FormEngine 61/40261/2
Christian Kuhn [Mon, 15 Jun 2015 16:51:08 +0000 (18:51 +0200)]
[BUGFIX] Data merging in FormEngine

Data is merged in a wrong way and kills for instance
the required handling.

Resolves: #67470
Related: #67400
Releases: master
Change-Id: I0b78fb34b443be89663188b14db192b58804fc5b
Reviewed-on: http://review.typo3.org/40261
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Always use MCRYPT_DEV_URANDOM if using mcrypt 51/40251/4
Helmut Hummel [Mon, 15 Jun 2015 14:00:27 +0000 (16:00 +0200)]
[BUGFIX] Always use MCRYPT_DEV_URANDOM if using mcrypt

Using MCRYPT_RAND was introduced because of a bug in PHP versions lower
than 5.3.7 on Windows in combination with IIS.

Since we require higher PHP versions in all maintained versions we can
remove this workaround and use MCRYPT_DEV_URANDOM again. By doing so we
fix a bug on Windows caused by not enough randomness.

Releases: 6.2, master
Resolves: #53034
Change-Id: Ibe74eb0277934e9300ffd9b00cc89a5f8bb008fb
Reviewed-on: http://review.typo3.org/40251
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Update Documentation for release of TYPO3 CMS 7.3 52/40252/2
Mathias Schreiber [Mon, 15 Jun 2015 14:15:34 +0000 (16:15 +0200)]
[TASK] Update Documentation for release of TYPO3 CMS 7.3

Releases: master
Change-Id: Ib9cc9e07ada7a60cf6fc1bbc878c16ff83c5df27
Reviewed-on: http://review.typo3.org/40252
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Deprecate AbstractDomainObject::__wakeup and document changes 45/40245/5
Christian Kuhn [Mon, 15 Jun 2015 11:31:58 +0000 (13:31 +0200)]
[TASK] Deprecate AbstractDomainObject::__wakeup and document changes

Resolves: #67402
Related: #66473
Releases: master
Change-Id: I4a493bd778b2fefdc39fbd7783f406d3fbbebabb
Reviewed-on: http://review.typo3.org/40245
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Make ToolBar in AdminPanel working again 46/40246/4
Daniel Maier [Mon, 15 Jun 2015 11:44:43 +0000 (13:44 +0200)]
[BUGFIX] Make ToolBar in AdminPanel working again

Adjust paths to respective backend-modules by removing the TYPO3_mainDir
part added directly in AdminPanelView, as this is done by
BackendUtility::getModuleUrl() as well

Resolves: #67461
Releases: master
Change-Id: I804b99c248afe4ca8bc9116ff8b73f2e28ea4f05
Reviewed-on: http://review.typo3.org/40246
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 years ago[BUGFIX] Follow-up for cleanup FAL exception messages 47/40247/3
Marc Bastian Heinrichs [Mon, 15 Jun 2015 11:51:43 +0000 (13:51 +0200)]
[BUGFIX] Follow-up for cleanup FAL exception messages

Fixes a fatal error introduced on cleaning up the exception
messages.

Resolves: #67462
Relates: #64613
Releases: master
Change-Id: Ia1911d56a39283a32b591bc051b0e95292ced206
Reviewed-on: http://review.typo3.org/40247
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Show icons of feedit again 58/40058/3
Georg Ringer [Sun, 7 Jun 2015 19:25:26 +0000 (21:25 +0200)]
[BUGFIX] Show icons of feedit again

Load the required CSS code to show font-awesome icons in feedit.

Change-Id: Ifb5df8119d192683a1631fd812c4ba91af24beaf
Resolves: #66358
Releases: master
Reviewed-on: http://review.typo3.org/40058
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Tested-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] CONTENT cObject slide does not loop 44/40244/2
Benjamin Mack [Mon, 15 Jun 2015 10:47:01 +0000 (12:47 +0200)]
[BUGFIX] CONTENT cObject slide does not loop

The CONTENT cObject is looping over the SQL query
when sliding the rootline and/or collecting but never
repeats due to missing braces.

This happened during a cleanup merge in commit
4722b6cf5c97ab415d3d35687ed77750b97e3258.

The patch re-adds the braces.

Resolves: #67034
Related: #54091
Releases: master
Change-Id: Ifc912ea8d5d2861d6888ddc5ac7bd755e3ff6bb4
Reviewed-on: http://review.typo3.org/40244
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Remove version number from generator tag 45/37945/7
Wouter Wolters [Thu, 19 Mar 2015 09:55:31 +0000 (10:55 +0100)]
[TASK] Remove version number from generator tag

This change will not increase the security of TYPO3 CMS.
This information can be misused by an attacker for a more targeted attack.

Resolves: #64429
Releases: master,6.2
Change-Id: I9151ed99e454e878b10ec1894cbec2ad83165e57
Reviewed-on: http://review.typo3.org/37945
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Write ClassInformation for every installed extension 31/40231/2
Helmut Hummel [Sat, 13 Jun 2015 17:42:04 +0000 (19:42 +0200)]
[BUGFIX] Write ClassInformation for every installed extension

The class information generator caches the currently active packages.
This runtime cache needs to be flushed every time the class information
is written, so that class information of newly activated extensions in one
request is taken into account.

Releases: master
Resolves: #67439
Related: #67212
Change-Id: I107bd692c5ad217dcd4d0d49e98fa294b4e470e4
Reviewed-on: http://review.typo3.org/40231
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FOLLOWUP][TASK] Document DI happening before initializeObject() 13/40213/3
Morton Jonuschat [Fri, 12 Jun 2015 17:00:08 +0000 (19:00 +0200)]
[FOLLOWUP][TASK] Document DI happening before initializeObject()

Clarify that the changes to dependency injection only affect domain
models retrieved from the database backend.

Resolves: #67401
Related: #67274
Related: #67272
Related: #66473
Releases: master
Change-Id: I04876b77c3ae5d061bae4b6b238d820a7f875740
Reviewed-on: http://review.typo3.org/40213
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE not loading while mass edit in list module 05/40205/2
Frank Nägler [Fri, 12 Jun 2015 11:51:10 +0000 (13:51 +0200)]
[BUGFIX] RTE not loading while mass edit in list module

This patch fix a regression from FormEngine: The extendables patch.

Resolves: #67429
Related: #67229
Releases: master
Change-Id: I6a900e8ce8460440eb9feb146ada54ea8995112d
Reviewed-on: http://review.typo3.org/40205
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Document DI happening before initializeObject() 95/40195/3
Morton Jonuschat [Thu, 11 Jun 2015 17:00:54 +0000 (19:00 +0200)]
[TASK] Document DI happening before initializeObject()

Changes in the execution of dependency injection and object
initialization have been documented as an important change.

Resolves: #67401
Related: #67274
Related: #67272
Related: #66473
Releases: master
Change-Id: Iab0cb89d7ed77ceaeafb1f87b19b750f73f45eda
Reviewed-on: http://review.typo3.org/40195
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] RTE not loading if multiple content elements are opened 97/40197/2
Frank Nägler [Thu, 11 Jun 2015 17:44:58 +0000 (19:44 +0200)]
[BUGFIX] RTE not loading if multiple content elements are opened

This patch fixes a bug when multiple content elements are processed
at once. This happens if the edit link in page module is used to open
all elements of one column at once.

Resolves: #67400
Releases: master
Change-Id: I605cedaff8f03947363bda002ab23235693dfc50
Reviewed-on: http://review.typo3.org/40197
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] ExtJS cards do not work 87/40187/2
Bernhard Kraft [Thu, 11 Jun 2015 14:46:00 +0000 (16:46 +0200)]
[BUGFIX] ExtJS cards do not work

The commit "fd5eae7e06dd0e0ba89585fd50a9d41a766f7b98" introduced a bug
for the ExtJS cards feature. Altough this feature is not used by any
core extensions it could break third party extensions. The line:

this.loadedModule = mod;

Simply got removed from
"typo3/sysext/backend/Resources/Public/JavaScript/modulemenu.js" in
the mentioned commit while changing indenting.

Change-Id: Ic0b70489d4b14fb95487a4ddc336eb82e630d593
Resolves: #67422
Releases: master
Reviewed-on: http://review.typo3.org/40187
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Use late static binding for compilable viewhelpers 84/40184/5
Markus Klein [Thu, 11 Jun 2015 12:58:37 +0000 (14:58 +0200)]
[BUGFIX] Use late static binding for compilable viewhelpers

Using self::renderStatic() in the render method of the viewhelpers
forces extending viewhelpers to copy the render method, which is
useless overhead.

Adjust all viewhelpers to use static::renderStatic() instead to
allow for late static binding.

Resolves: #67420
Releases: master
Change-Id: I12ca42a16365ee2baceeca6a17193e5f6877ed27
Reviewed-on: http://review.typo3.org/40184
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Manuel Selbach <m.selbach@reply.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix padding for FlashMessages 78/40178/4
Andreas Fernandez [Thu, 11 Jun 2015 10:44:57 +0000 (12:44 +0200)]
[BUGFIX] Fix padding for FlashMessages

Resolves: #67418
Releases: master
Change-Id: Icdec4c9822aac1fc2983142e34739ae55800b66f
Reviewed-on: http://review.typo3.org/40178
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Improve extbase object creation tests 61/40161/2
Christian Kuhn [Wed, 10 Jun 2015 22:17:36 +0000 (00:17 +0200)]
[TASK] Improve extbase object creation tests

The patch is a follow-up to the "initializeObject() no longer
called after instatiation was fixed" patch with commit ec4f49f69f.
It makes the tests a bit more picky and does some minor cleanups.

Patch is for master only, 6.2 will receive different patch sets.

Resolves: #67407
Related: #67272
Releases: master
Change-Id: Iee371a6a62d66613b35623af55ac5ca4595eb947
Reviewed-on: http://review.typo3.org/40161
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Remove cache_classes from LocalConfiguration 67/40167/2
Christian Kuhn [Thu, 11 Jun 2015 08:19:58 +0000 (10:19 +0200)]
[BUGFIX] Remove cache_classes from LocalConfiguration

With class loader removal in #67212 cache_classes was removed from
the system :)
The patch adds cache_classes to the silent configuration upgrader of
the install tool to remove this configuration part from
LocalConfiguration.

Resolves: #67411
Related: #67212
Releases: master
Change-Id: Ieb39b44b74ecdeeaf8db4975bf9044a2ac6fd57a
Reviewed-on: http://review.typo3.org/40167
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Register runtime class loading info on ext update 60/40160/3
Helmut Hummel [Wed, 10 Jun 2015 21:56:13 +0000 (23:56 +0200)]
[BUGFIX] Register runtime class loading info on ext update

Since the runtime class loading information is
set during activation of the package, we need to ensure
that this code is called.

Releases: master
Resolves: #67410
Change-Id: I635e858b58c15d8563b4da54c009004e0a7416f9
Reviewed-on: http://review.typo3.org/40160
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Clean up DataMapper::convertClassNameToTableName 00/39900/3
Mathias Brodala [Tue, 2 Jun 2015 15:19:31 +0000 (17:19 +0200)]
[TASK] Clean up DataMapper::convertClassNameToTableName

This removes pointless code which ends up doing strtolower(NULL).

Also make the class name argument mandatory since it does not make
sense to pass nothing or NULL and the core does not do this in any
case.

The latter change makes this mildly breaking if code relies on the
old behavior.

Resolves: #67248
Releases: master
Change-Id: I3f3339ea005831fc3d78974d8883c20ad04ec4ec
Reviewed-on: http://review.typo3.org/39900
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] EM: Use EXEC_TIME for extension export zip filename 59/40159/3
Christian Kuhn [Wed, 10 Jun 2015 20:55:29 +0000 (22:55 +0200)]
[BUGFIX] EM: Use EXEC_TIME for extension export zip filename

Extension export as .zip file uses date() to make file
names "unique". Instead of timestamp "now", $GLOBALS['EXEC_TIME']
is now used as base time stamp since this value
does not change during one call.
The according test is stabilized a bit and additionally sets
$GLOBALS['EXEC_TIME'] to a stable value.

Releases: master
Resolves: #67405
Change-Id: I0ccb7210711fc7ab65135dc458d0b4a8587353d5
Reviewed-on: http://review.typo3.org/40159
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: Set "magic" as default image mode 55/40155/3
Andreas Fernandez [Wed, 10 Jun 2015 18:32:51 +0000 (20:32 +0200)]
[BUGFIX] RTE: Set "magic" as default image mode

Sets the image mode to "magic" on first call, as "New Magic Image"
is the first tab being called.

Resolves: #65821
Releases: master
Change-Id: If3064b93a16c9a86a3898afa0cccb56322d5b1cf
Reviewed-on: http://review.typo3.org/40155
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] typo in class bootstrap comment 58/40158/2
Christian Kuhn [Wed, 10 Jun 2015 20:30:15 +0000 (22:30 +0200)]
[BUGFIX] typo in class bootstrap comment

everthing -> everything

Releases: master
Resolves: #67404
Change-Id: I2c48d6ead5afa19bae98a138f0288e5b07c7071f
Reviewed-on: http://review.typo3.org/40158
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years agoRevert "[TASK] Massive performance improvement for page tree" 54/40154/2
Frank Nägler [Wed, 10 Jun 2015 18:30:05 +0000 (20:30 +0200)]
Revert "[TASK] Massive performance improvement for page tree"

This patch needs to be reverted, because of a regression with
the page tree and the double click behavior.

Releases: master
Resolves: #66912
Resolves: #67322
Reverts: #63591

This reverts commit a89d3765663c0ed05c8435ad767f106fa9d60bf8.

Change-Id: I35b9d80f25fa1f2f3951bf70bbbe9e02dafdc28d
Reviewed-on: http://review.typo3.org/40154
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[!!!][FEATURE] Discard TYPO3 class loader 27/39827/21
Helmut Hummel [Sat, 30 May 2015 11:34:18 +0000 (13:34 +0200)]
[!!!][FEATURE] Discard TYPO3 class loader

Use composer class loader instead of the TYPO3 class loader
when TYPO3 is not installed via composer, thus building the same
class information logic during runtime (and caching it away) as
composer does with its "dump-autoload" command.

Releases: master
Resolves: #67212
Change-Id: Id032411a690d67ca690a724748c3c796d2bb5f6e
Reviewed-on: http://review.typo3.org/39827
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Check $http_response_headers in GeneralUtility::getUrl() 42/40142/3
Andreas Fernandez [Wed, 10 Jun 2015 07:19:07 +0000 (09:19 +0200)]
[BUGFIX] Check $http_response_headers in GeneralUtility::getUrl()

If one queries a local, non-existing file with GeneralUtility::getUrl()
AND sets the $report parameter, implode() fails because
$http_response_headers remains NULL, as there is no HTTP request.
Check the existance of $http_response_headers and alternatively use the
URL for logging.

Resolves: #67383
Releases: master, 6.2
Change-Id: I796935fbef090061c7d12502593190f4223765b3
Reviewed-on: http://review.typo3.org/40142
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>