Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Fix wrong hideTable check in SuggestWizard 45/48645/2
Georg Ringer [Tue, 21 Jun 2016 20:21:00 +0000 (22:21 +0200)]
[BUGFIX] Fix wrong hideTable check in SuggestWizard

Due to a regression in #67593 a wrong check is used which needs to be
fixed.

Resolves: #76722
Releases: master, 7.6
Change-Id: I6a0d1a95096c212354a64f66996c85b9789a47e7
Reviewed-on: https://review.typo3.org/48645
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] EXT:form - mandatoryValidationMessages unset after submit 19/48619/2
Ralf Zimmermann [Wed, 15 Jun 2016 09:11:22 +0000 (11:11 +0200)]
[BUGFIX] EXT:form - mandatoryValidationMessages unset after submit

Build the validation rules within the initializeShowAction

Resolves: #73218
Releases: master, 7.6
Change-Id: I1b441db52da57b8db6a574f87a1600b5332154df
Reviewed-on: https://review.typo3.org/48619
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use BackendUtility::deleteClause in LinkAnalyzer 07/48607/2
Georg Ringer [Tue, 14 Jun 2016 13:52:13 +0000 (15:52 +0200)]
[BUGFIX] Use BackendUtility::deleteClause in LinkAnalyzer

To avoid wrong sql statements the method BackendUtility::deleteClause
must be used.

Resolves: #76628
Releases: master, 7.6
Change-Id: Ida8165b501c4898d2b79586710b2921f47d6963f
Reviewed-on: https://review.typo3.org/48607
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] baseUrlWrap can handle url without scheme again 06/48606/2
Wouter Wolters [Wed, 15 Jun 2016 08:39:51 +0000 (10:39 +0200)]
[BUGFIX] baseUrlWrap can handle url without scheme again

Since #54091 the baseUrlWrap method can't handle urls
without a scheme anymore. Fix this by checking the scheme
exists or not.

Resolves: #76403
Releases: master,7.6
Change-Id: I2a28519ef1fbafd245ececaa4b6cbedc716c0fa5
Reviewed-on: https://review.typo3.org/48606
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] EXT:form - Fix broken inArray validator 94/48594/2
Daniel Lorenz [Wed, 15 Jun 2016 10:42:57 +0000 (12:42 +0200)]
[BUGFIX] EXT:form - Fix broken inArray validator

Handle different configuration types and multiselect values.

Resolves: #75576
Releases: master, 7.6
Change-Id: I42c0bcbc5f5307d125484149108495ea971a692e
Reviewed-on: https://review.typo3.org/47661
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <info@extco.de>
Tested-by: Daniel Lorenz <info@extco.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 3e06e04aa6706c87444ff6503596738b8b5bdf57)
Reviewed-on: https://review.typo3.org/48594

2 years ago[BUGFIX] Make Install Tool forms submitable via keyboard 56/48556/3
Markus Klein [Sun, 29 May 2016 13:15:16 +0000 (15:15 +0200)]
[BUGFIX] Make Install Tool forms submitable via keyboard

Additionally fix missing input-label association and simplify
Fluid inline if usage.

Resolves: #76363
Releases: master, 7.6
Change-Id: I8a01047c3eb5b28494313fce0e031a296696ece9
Reviewed-on: https://review.typo3.org/48556
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Raise minimum version for typo3/cms-composer-installers 69/48569/2
Helmut Hummel [Mon, 13 Jun 2016 13:56:51 +0000 (15:56 +0200)]
[BUGFIX] Raise minimum version for typo3/cms-composer-installers

typo3/cms-composer-installers conflicts with specific
composer/installers versions, but this conflict was unfortunately wrongly
specified. This is now fixed upstream, but we need to update
the TYPO3 core dependencies as well to require the fixed version.

Resolves: #76617
Releases: master, 7.6, 6.2
Change-Id: I7900b81fa6893d8c3b1a735682b8323efd20babd
Reviewed-on: https://review.typo3.org/48569
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2 years ago[BUGFIX] Prevent reset of user settings in getFromDottedNotation() 63/48563/2
Daniel Goerz [Wed, 1 Jun 2016 08:34:55 +0000 (10:34 +0200)]
[BUGFIX] Prevent reset of user settings in getFromDottedNotation()

Change-Id: Idd9bd02e81ffb5b3ed02f5bf47d6fa3a9be7cdbd
Resolves: #76406
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48563
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix flexform inline record editing with empty uc 53/48553/2
Jörg Bösche [Thu, 9 Jun 2016 14:50:30 +0000 (16:50 +0200)]
[BUGFIX] Fix flexform inline record editing with empty uc

When the uc of a backend user is empty a unserialize error
will be shown. Fix this by checking the uc['inlineView']
correctly.

Resolves: #76561
Releases: master, 7.6
Change-Id: Ic7ad77333312b570bb29f46a908838085f020f50
Reviewed-on: https://review.typo3.org/48553
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Apply CGL compatibility (PSR-1 and PSR-2) 45/48545/2
Wouter Wolters [Fri, 10 Jun 2016 07:50:27 +0000 (09:50 +0200)]
[TASK] Apply CGL compatibility (PSR-1 and PSR-2)

Resolves: #76449
Releases: 7.6
Change-Id: I8a58a83f75673d340370c2cd6546f3154c31d3d2
Reviewed-on: https://review.typo3.org/48545
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Improve domObjectId splitting for inline in flexform 18/48518/4
Anja Leichsenring [Wed, 8 Jun 2016 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Improve domObjectId splitting for inline in flexform

We use a regex to retrieve relevant informations for the handling
of flexform datastructures and inline records. It failed for some
use cases like deeply nested structures.
A rework of the regex and some additional unit tests stabilize
this fragile area.

Resolves: #76268
Relates: #73004
Releases: master, 7.6
Change-Id: I4f2afed7f07b3f4f0346bf7a63541e8313f7a992
Reviewed-on: https://review.typo3.org/48518
Reviewed-by: ToM <mail@interactive-values.at>
Tested-by: ToM <mail@interactive-values.at>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
2 years ago[BUGFIX] Fix Livesearch for Editors 19/48519/2
Marcus Schwemer [Fri, 3 Jun 2016 09:41:14 +0000 (11:41 +0200)]
[BUGFIX] Fix Livesearch for Editors

Fix searchlevel comparision for editors using pageUID "0" in livesearch,
because "-1" is also a valid searchlevel.

Resolves: #76432
Releases: master, 7.6
Change-Id: I62a2059a7c7f8cf602e452bc0763c6c2cc3fbbe8
Reviewed-on: https://review.typo3.org/48519
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Wrong issue number reference in .rst file 17/48517/2
Christian Kuhn [Wed, 8 Jun 2016 19:17:58 +0000 (21:17 +0200)]
[BUGFIX] Wrong issue number reference in .rst file

Change-Id: I887df6b6a32773c997f8c3e420bbdf8c5a55ab28
Resolves: #76529
Related: #64190
Releases: 7.6
Reviewed-on: https://review.typo3.org/48517
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Scheduler to show checkbox if "bool" typehint used in Controller 07/48507/2
Roland Waldner [Tue, 7 Jun 2016 15:18:02 +0000 (17:18 +0200)]
[BUGFIX] Scheduler to show checkbox if "bool" typehint used in Controller

Until now if you wanted to use a checkbox you had to use "boolean" in that
typehint. If you used "bool" EXT:scheduler output a common input field. As
it seems to be encouraged by the TYPO3 core team to use "bool" PHPDoc
blocks, this commit makes sure that EXT:scheduler will also output a
checkobx if you use "bool" typehints.

Resolves: #76500
Releases: master, 7.6
Change-Id: Ie371e88e3a8e0a23d0cae2f893c5e7f14323068c
Reviewed-on: https://review.typo3.org/48507
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix output of DebugUtility 98/48398/3
Helmut Hummel [Wed, 25 May 2016 17:26:52 +0000 (19:26 +0200)]
[BUGFIX] Fix output of DebugUtility

This change prettifies the output of the debug output
methods, by using the Extbase DebuggerUtility for that purpose.

The benefits are consistent, well readable, properly encoded output
for every case the class provides.

In the long run, this class should be replaced with
a more object oriented approach.

Resolves: #76302
Releases: master, 7.6
Change-Id: Iacbb48701f6c98139bd7db86795952a123e076da
Reviewed-on: https://review.typo3.org/48398
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2 years ago[BUGFIX] Only check 'CType' when removing items from NewContentElementWizard 97/48497/2
Morton Jonuschat [Fri, 20 May 2016 15:28:55 +0000 (17:28 +0200)]
[BUGFIX] Only check 'CType' when removing items from NewContentElementWizard

Fix the behavior of keepItems in the NewContentElementWizard to only
remove invalid items based on the CType key. Without this patch any
invalid value in tt_content_defValues would result in the content
element being invisible in the wizard.

Change-Id: Iee4d13ff05088b9c71a9a8fb1d258766e97dcf75
Resolves: #76242
Related: #61114
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48497
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow to add custom styles for admin panel 81/48481/2
Zbigniew Jacko [Tue, 10 May 2016 10:35:03 +0000 (13:35 +0300)]
[BUGFIX] Allow to add custom styles for admin panel

Allow to add custom styles for admin panel, which are included
below the main styles.

Resolves: #76030
Releases: master, 7.6
Change-Id: If945982a3192f9fca8a008179f4b353eb2e65d76
Reviewed-on: https://review.typo3.org/48481
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
2 years ago[BUGFIX] Fix password evaluation for TCA input field 57/48457/2
mtoscanelli [Sun, 5 Jun 2016 09:34:58 +0000 (11:34 +0200)]
[BUGFIX] Fix password evaluation for TCA input field

Password evaluation is only used for display purpose.

Skip password evaluation value processing.
Set the correct value in main and human readable fields.

Resolves: #76456
Releases: master, 7.6
Change-Id: I58d1e2b9922ee21b7ccacb83e7989c9c9c2df02f
Reviewed-on: https://review.typo3.org/48457
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] getPageOverlay_preProcess respect changes done in hooks 79/48479/2
Andreas Allacher [Tue, 3 May 2016 14:03:15 +0000 (16:03 +0200)]
[BUGFIX] getPageOverlay_preProcess respect changes done in hooks

Due to the implementation of getPagesOverlay the individual page array
is passed to the getPageOverlay_preProcess hook without
being able to use changes done in user function
to the page array.
Now the page array can be modified again.
The change was introduced by adding the feature
PageRepository::getPagesOverlay() in http://review.typo3.org/36054

Change-Id: If4a07b232b3e34eb146f8ea06abe32efc7b72fdb
Releases: master, 7.6
Resolves: #76031
Relates: #64258
Reviewed-on: https://review.typo3.org/48479
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install Tool: target="_blank" on externals links 77/48477/2
Ian SEBBAGH [Tue, 7 Jun 2016 10:15:31 +0000 (12:15 +0200)]
[BUGFIX] Install Tool: target="_blank" on externals links

Add target="_blank" to the external links at the bottom of the About
module in the Install Tool in order to avoid problems with
X-Frame-Options of typo3.org

Resolves: #76482
Releases: master, 7.6
Change-Id: Icb7f9697769d510a641301df2a889d28f735707e
Reviewed-on: https://review.typo3.org/48477
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[WIP][BUGFIX] Introduce exception for using offset without limit 73/48473/4
Ian SEBBAGH [Mon, 6 Jun 2016 15:42:26 +0000 (17:42 +0200)]
[WIP][BUGFIX] Introduce exception for using offset without limit

In Typo3DbBackend::createQueryCommandParametersFromStatementParts,
if an offset is defined, but no limit is, an LogicException is thrown.

SQL does not provide possibility to set offset without limit.
To retrieve all rows from a certain offset up to the end of the
result set, you can use some large number for the limit.
See: http://dev.mysql.com/doc/refman/5.7/en/select.html

Resolves: #65789
Releases: master, 7.6
Change-Id: Icf4db2fbe8dfac21e5da2e32fe5dada38ffd3a77
Reviewed-on: https://review.typo3.org/48473
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Functional tests for LocalizationController 70/48470/2
Andreas Fernandez [Thu, 17 Mar 2016 14:21:15 +0000 (15:21 +0100)]
[TASK] Functional tests for LocalizationController

The LocalizationController used by the localization wizard is
now covered by some functional tests.
For better testability, the DataHandler processing in the
controller is moved into its own method.

Resolves: #75160
Related: #73617
Releases: master, 7.6
Change-Id: I3275f51d3dfec55ace3d8dbe7130c3f18b963341
Reviewed-on: https://review.typo3.org/48470
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Make DataHandler aware of relations behind special=languages 68/48468/2
Markus Klein [Mon, 8 Feb 2016 16:43:58 +0000 (17:43 +0100)]
[BUGFIX] Make DataHandler aware of relations behind special=languages

The special TCA option "languages" makes some other TCA options like
foreign_table unnecessary which have been removed from
the sys_language_uid fields.

But DataHandler relies on the 'foreign_table' setting and therefore
needs some more information to resolve the related table
behind the "languages" option.

Resolves: #73182
Releases: master, 7.6
Change-Id: Id8f7f995d424f69fd5dce8e28cb1fc9db33fa0b0
Reviewed-on: https://review.typo3.org/48468
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add textmedia CE's bodytext to BE search 64/48464/2
Markus Klein [Mon, 6 Jun 2016 12:59:07 +0000 (14:59 +0200)]
[BUGFIX] Add textmedia CE's bodytext to BE search

Resolves: #76466
Releases: master, 7.6
Change-Id: Ib54d9c1434e2de8f783180a1c4789cac702afd73
Reviewed-on: https://review.typo3.org/48464
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install current version of mediace extension 63/48463/2
Nicole Cordes [Fri, 3 Jun 2016 11:12:08 +0000 (13:12 +0200)]
[TASK] Install current version of mediace extension

Resolves: #76445
Releases: master, 7.6
Change-Id: I052d44c11e98ca7dc8f04bc408c03f911f7633b9
Reviewed-on: https://review.typo3.org/48463
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Changes forge links to https 62/48462/2
Thomas Löffler [Mon, 6 Jun 2016 13:44:53 +0000 (15:44 +0200)]
[TASK] Changes forge links to https

Change-Id: I14b51216f19a9fc613ee8b75d7ac2223d3cdca07
Resolves: #76467
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48462
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Ensure ordering of TS constants in editor 12/48412/3
Markus Klein [Tue, 31 May 2016 09:04:29 +0000 (11:04 +0200)]
[BUGFIX] Ensure ordering of TS constants in editor

Resolves: #76386
Releases: master, 7.6
Change-Id: I827b6ab143520f647668773411d3b67792299c97
Reviewed-on: https://review.typo3.org/48412
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Automatically select the custom preset when values are changed 96/48396/9
Markus Klein [Sun, 29 May 2016 13:59:38 +0000 (15:59 +0200)]
[TASK] Automatically select the custom preset when values are changed

If the user changes a field in a custom preset in the Install Tool
the custom preset's radio box must be selected too.

Resolves: #76365
Releases: master, 7.6
Change-Id: Iee499d61574e88ef094d690bea7ff827aa7507dc
Reviewed-on: https://review.typo3.org/48396
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Render the creator of a record in ElementInformationController 58/48458/2
Georg Ringer [Mon, 6 Jun 2016 08:05:03 +0000 (10:05 +0200)]
[BUGFIX] Render the creator of a record in ElementInformationController

The ElementInformationController must show the creator user and not
the current one.

Resolves: #76461
Releases: master, 7.6
Change-Id: Ibeae9970783aa6d0fc3b0e190956140c872a9ac9
Reviewed-on: https://review.typo3.org/48458
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] FAL relations duplicated when saving in workspaces 13/47313/2
Andreas Wolf [Thu, 22 Oct 2015 17:40:11 +0000 (19:40 +0200)]
[BUGFIX] FAL relations duplicated when saving in workspaces

In a workspace, when a record is saved which contains an IRRE-managed
relation in a flexform field, the relation is duplicated. The reason is
that the workspace information is lost along the way when processing the
flexform content.

This commit introduces an additional method parameter to the relevant
flexform processing callbacks.

Additionally, this fixes an error in the Flexform XML fixture, which
(apparently) made the test go into an endless loop.

Work time for this patch was sponsored by Matthias Krappitz (aemka.de),
the time for developing the test was sponsored by me.

Releases: master, 7.6, 6.2
Resolves: #70962
Change-Id: If6d71cf966408fcf976365fc01e6a2529bf1902d
(cherry picked from commit a0cd456491740ae3adee1206d193f2f67b6677b1)
Reviewed-on: https://review.typo3.org/47313
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
2 years ago[BUGFIX] Do not manipulate minitems/maxitems 51/48451/2
Markus Klein [Tue, 31 May 2016 10:19:47 +0000 (12:19 +0200)]
[BUGFIX] Do not manipulate minitems/maxitems

We must only manipulate minitems and maxitems for valdiation
when we have a select-field with renderType selectTree.
The existing check is not enough, since it lacks the check
for the actual type and applies the changes also if
any other type is used and minitems=maxitems=1.

Resolves: #76388
Releases: master, 7.6
Change-Id: I9697521a710c3debc49f40c2c4db87baac8f2d97
Reviewed-on: https://review.typo3.org/48451
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Checkboxes with itemProcFunc are not saved 50/48450/2
Anja Leichsenring [Wed, 11 May 2016 14:54:51 +0000 (16:54 +0200)]
[BUGFIX] Checkboxes with itemProcFunc are not saved

Retrieve items added by an itemProcFunc before validating the current
set of selected checkboxes.

This fixes the bug that a item set consisting of mixed predefined and
dynamically added items always stored all predefined checkboxes as
selected (and no dynamic items).

It also fixes the case that a checkbox list consisting of purely
dynamically added items would never store a selection in the database,
showing all checkboxes as unselected.

Resolves: #76147
Releases: master, 7.6
Change-Id: I254a2936974f5bb5fbb6800a17667b66e1a86ca2
Reviewed-on: https://review.typo3.org/48450
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Use `enableMultiSelectFilterTextfield` in pages and tt_content 47/48447/2
Andreas Fernandez [Fri, 3 Jun 2016 10:03:41 +0000 (12:03 +0200)]
[TASK] Use `enableMultiSelectFilterTextfield` in pages and tt_content

Enable the usage of `enableMultiSelectFilterTextfield` for the field
`fe_group` in the TCA of pages and tt_content.

Resolves: #76444
Releases: master, 7.6
Change-Id: Ia4b3fd509b8a5e338f5f46e0fd49e89d600da982
Reviewed-on: https://review.typo3.org/48447
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Load CSH for flexforms again 44/48444/2
Wouter Wolters [Sun, 29 May 2016 10:48:35 +0000 (12:48 +0200)]
[BUGFIX] Load CSH for flexforms again

The cshKey is not correctly set up. Check for array as well and use
the first key if it exists.

Resolves: #73574
Releases: master,7.6
Change-Id: I263806a4628ea0cdb28413eefa3f9d2af4141a2c
Reviewed-on: https://review.typo3.org/48444
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Natural sorting for integer keys 43/48443/2
Frank Naegler [Mon, 30 May 2016 14:22:05 +0000 (16:22 +0200)]
[BUGFIX] Natural sorting for integer keys

LocalDriver has a sorting bug if multiple files have
the same timestamp or size.
This patch adds a character to the sorting key to sort correctly.

Resolves: #73754
Releases: master, 7.6
Change-Id: Ie1ae0c11eea5a3bdf9ad23b0d4855364e5a62bab
Reviewed-on: https://review.typo3.org/48443
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CSS inline style for image border gets corrupted after saving 41/48441/2
Frank Naegler [Mon, 30 May 2016 16:33:33 +0000 (18:33 +0200)]
[BUGFIX] CSS inline style for image border gets corrupted after saving

Resolves: #66844
Releases: master, 7.6, 6.2
Change-Id: I20fe7367433fe98a118890cc95306ee5e45504f4
Reviewed-on: https://review.typo3.org/48441
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove wrong example in ShortcutButton 35/48435/2
Wouter Wolters [Wed, 1 Jun 2016 18:17:27 +0000 (20:17 +0200)]
[TASK] Remove wrong example in ShortcutButton

Resolves: #76415
Releases: master,7.6
Change-Id: I7e5694cfe1c104fdd3cb764af39acad690ffc4b9
Reviewed-on: https://review.typo3.org/48435
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Exclude non-production files from Git archives 29/48429/5
Mathias Brodala [Fri, 6 Mar 2015 13:52:46 +0000 (14:52 +0100)]
[TASK] Exclude non-production files from Git archives

This excludes various directories and files from release
archives as generated by Github and fetched via Composer.

These files and directories are not relevant for production
and excluding them reduces the size of release archives.

Such files are usually identified as security risk in security
reviews and should therefore be removed by default from production systems.

As an addition it also avoids issues with long file paths when installing
on Windows systems.

Resolves: #65570
Resolves: #68998
Resolves: #70810
Releases: 7.6, master
Change-Id: I615e0c7a4cafaea471c79e88e9df2c78c55b92ac
Reviewed-on: https://review.typo3.org/48429
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2 years ago[BUGFIX] Display validation errors again in FormEngine 17/48417/3
Markus Klein [Tue, 31 May 2016 10:47:04 +0000 (12:47 +0200)]
[BUGFIX] Display validation errors again in FormEngine

Resolves: #76392
Releases: 7.6
Change-Id: Ib74400e1bf988ff0802c3c2e5cd5965a69b6eb9a
Reviewed-on: https://review.typo3.org/48417
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Ensure correct return type for AbstractFile getters 01/48401/2
Markus Klein [Tue, 17 May 2016 12:23:24 +0000 (14:23 +0200)]
[BUGFIX] Ensure correct return type for AbstractFile getters

Resolves: #76212
Releases: master, 7.6
Change-Id: I7b7ded93ff1d31f00f8d067f9697cd8f71305881
Reviewed-on: https://review.typo3.org/48401
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Use native Placeholder.js intead of the jQuery adapter 67/48367/2
Wouter Wolters [Sat, 28 May 2016 16:20:27 +0000 (18:20 +0200)]
[BUGFIX] Use native Placeholder.js intead of the jQuery adapter

Resolves: #76106
Releases: 7.6
Change-Id: I4e6c11263275c75bf899d32f35bcdeb488f9ed7b
Reviewed-on: https://review.typo3.org/48367
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow typesList=0 when using makeCategorizable 86/48386/2
Wouter Wolters [Sat, 28 May 2016 15:41:50 +0000 (17:41 +0200)]
[BUGFIX] Allow typesList=0 when using makeCategorizable

Due to a wrong condition which is using !empty() typesList=0 is not possible.
Change the condition to check this the correct way.

Resolves: #76141
Releases: master, 7.6
Change-Id: Ieca9bd2a59e42d112c4eb8058bd76da8d73b86ab
Reviewed-on: https://review.typo3.org/48386
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add hint what to do when a CSRF token check failed 85/48385/2
Wouter Wolters [Sat, 28 May 2016 18:48:10 +0000 (20:48 +0200)]
[TASK] Add hint what to do when a CSRF token check failed

Resolves: #75776
Releases: master, 7.6
Change-Id: I499c8a4e87e1abda99179329b69b7cdd67f7a748
Reviewed-on: https://review.typo3.org/48385
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Correct type for constants linkWrap height and width 82/48382/2
Wouter Wolters [Sat, 28 May 2016 19:33:14 +0000 (21:33 +0200)]
[BUGFIX] Correct type for constants linkWrap height and width

The height and width have a default value with a "m" in it.
This is stripped of because the wrong data type is used. Use string
instead to circumvent the automatic stripping of the letter "m".

Resolves: #75520
Releases: master,7.6
Change-Id: I36c18e955db50ecd981efd24a0f842706d8d0fdc
Reviewed-on: https://review.typo3.org/48382
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Better explain when a cookie with a lifetime will be set 81/48381/2
Wouter Wolters [Sat, 28 May 2016 15:01:56 +0000 (17:01 +0200)]
[TASK] Better explain when a cookie with a lifetime will be set

A cookie with a lifetime will only be set when the option permalogin
is greater than or equals to 0. If this is not true it will become
a session cookie.

Resolves: #76168
Releases: master,7.6
Change-Id: Ibd5d431107713a118c93295d0f08df721bc3b6c4
Reviewed-on: https://review.typo3.org/48381
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove unused variables from LiveSearch getRecordArray 80/48380/2
Wouter Wolters [Sat, 28 May 2016 14:21:51 +0000 (16:21 +0200)]
[BUGFIX] Remove unused variables from LiveSearch getRecordArray

Resolves: #76248
Releases: master, 7.6
Change-Id: Iadf5c209bf12ad199ae92f654d2348b70001c053
Reviewed-on: https://review.typo3.org/48380
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Display content_date in sys_file_metadata TCA 76/48376/2
Stephan Großberndt [Mon, 23 May 2016 11:35:57 +0000 (13:35 +0200)]
[TASK] Display content_date in sys_file_metadata TCA

Display content_creation_date and content_modification_date of images,
audio files and videos in the TCA of sys_file_metadata records.

Resolves: #76267
Releases: master, 7.6
Change-Id: I77dd1b35f5ba7e1f4dbd975ad1ad339e8a0ada6e
Reviewed-on: https://review.typo3.org/48376
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess 61/48361/3
Stephan Großberndt [Sat, 28 May 2016 12:17:21 +0000 (14:17 +0200)]
[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess

Resolves: #76352
Releases: master, 7.6
Change-Id: I8332c93f1171d030d4198091779c8f1242c9337b
Reviewed-on: https://review.typo3.org/48361
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add proper comments in DefaultConfiguration options 49/48349/2
Benni Mack [Fri, 27 May 2016 15:06:27 +0000 (17:06 +0200)]
[BUGFIX] Add proper comments in DefaultConfiguration options

Some descriptions of options in DefaultConfiguration are not visible in
the Install Tool. These are added and made sure to be rendered
in the Install Tool.

Resolves: #76333
Releases: master, 7.6
Change-Id: I87d90b7614d5c90a1d212d0a214ef26dc2d5fcfc
Reviewed-on: https://review.typo3.org/48349
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not add error flash messages twice 47/48347/3
Helmut Hummel [Mon, 2 Nov 2015 21:49:17 +0000 (22:49 +0100)]
[BUGFIX] Do not add error flash messages twice

Error messages published by ExtendedFileUtility get added to the flash
message queue in a translated version so it's unnecessary to publish an
untranslated version based on the log entries as well.

Resolves: #76337
Related: #72175
Related: #71255
Releases: 7.6
Change-Id: I818541916f182b63151a866590bb1541a0c02d39
Reviewed-on: https://review.typo3.org/48347
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Re-enables fileDenyPattern check for admin users 29/48329/2
Torben Hansen [Thu, 26 May 2016 19:20:23 +0000 (21:20 +0200)]
[BUGFIX] Re-enables fileDenyPattern check for admin users

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Resolves: #60173
Releases: master, 7.6, 6.2
Change-Id: I3b819e70cf2218a4580203ac7b7a6b0c3c5087ab
Reviewed-on: https://review.typo3.org/48329
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2 years ago[BUGFIX] Fix undefined property rUri in TableController 39/48339/2
Wouter Wolters [Fri, 27 May 2016 13:38:27 +0000 (15:38 +0200)]
[BUGFIX] Fix undefined property rUri in TableController

Resolves: #76329
Releases: master,7.6
Change-Id: Ie5320e71aa8ded5b744997b6f1ca71c3542aa2f0
Reviewed-on: https://review.typo3.org/48339
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix broken disable overlay in FormEngine 28/48328/2
Frank Naegler [Fri, 13 May 2016 08:24:55 +0000 (10:24 +0200)]
[BUGFIX] Fix broken disable overlay in FormEngine

Resolves: #75397
Releases: master, 7.6
Change-Id: I7cb4f04e38e3d9f755aaf92012eb56d71a1ad6f7
Reviewed-on: https://review.typo3.org/48328
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration 19/48319/2
Andreas Fernandez [Fri, 27 May 2016 10:49:41 +0000 (12:49 +0200)]
[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration

Use `$table` for logging instead of the hardcoded `pages` table.

Resolves: #74125
Releases: master, 7.6
Change-Id: I13b4306bdc54cf461d23c401d54c04983059df46
Reviewed-on: https://review.typo3.org/48319
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Check if `$rows` is an array before iteration 15/48315/2
Andreas Fernandez [Fri, 27 May 2016 08:59:26 +0000 (10:59 +0200)]
[BUGFIX] Check if `$rows` is an array before iteration

In case `$rows` in the method `DataHandler::copySpecificPage()` is null,
the foreach loop will throw an error.
`$rows` may become null if an extension brings TCA but the table does not
have `uid` field, for example.

It's now checked whether the result being iterated is an array, otherwise
an error is logged.

Resolves: #74125
Releases: master, 7.6
Change-Id: I20cb101155632309b9e08600fcd33e655c1c9d2f
Reviewed-on: https://review.typo3.org/48315
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager 12/48312/2
Morton Jonuschat [Fri, 20 May 2016 04:50:26 +0000 (06:50 +0200)]
[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager

Instead of passing the simple value "1" to QueryGenerator->getTreeList()
use a page permission clause created using $BE_USER->getPagePermsClause()
when determining the recursive storage pids. Passing the unprocessed value
"1" causes invalid SQL statements and does not perform any access checks.

Releases: master, 7.6
Resolves: #75912
Change-Id: I6edadd627c0a9c01a78c3cb55805455fed710d14
Reviewed-on: https://review.typo3.org/48220
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 5b4563b284df88f1eb04aeb54c95cf751bcb3416)
Reviewed-on: https://review.typo3.org/48312

2 years ago[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab 95/48295/2
Markus Klein [Wed, 25 May 2016 21:51:23 +0000 (23:51 +0200)]
[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab

Resolves: #76303
Releases: master, 7.6
Change-Id: Ia03f62ccc1c7c989a4284de36ac814758c63d288
Reviewed-on: https://review.typo3.org/48295
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Improve rendering of file paths in reports 89/48289/2
Georg Ringer [Wed, 25 May 2016 21:12:20 +0000 (23:12 +0200)]
[TASK] Improve rendering of file paths in reports

By using the <code>-tag, the output of paths is improved:

- XCLASS usage
- Path to ENABLE_INSTALL_TOOL
- Path to deprecation log

Resolves: #76288
Releases: master, 7.6
Change-Id: I591009cd52ba1dec6d25ff135e76b7b536b84193
Reviewed-on: https://review.typo3.org/48289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Suggest wizard inserts correct items again 78/48278/2
Markus Klein [Tue, 24 May 2016 13:41:03 +0000 (15:41 +0200)]
[BUGFIX] Suggest wizard inserts correct items again

The patch for #70463 introduced a regression which caused
added elements to include HTML markup.

Resolves: #76286
Releases: master, 7.6
Change-Id: I596602b03fd65f2e8d95171c2f2f79ff57006f14
Reviewed-on: https://review.typo3.org/48278
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Adds missing tablename sys_language in fetchOriginLanguage function 45/48045/4
Marvin Dettinger [Mon, 9 May 2016 15:38:10 +0000 (17:38 +0200)]
[BUGFIX] Adds missing tablename sys_language in fetchOriginLanguage function

Resolves: #76098
Releases: master, 7.6
Change-Id: I4ceb644328671cd3355340d6b6991d60e88b265a
Reviewed-on: https://review.typo3.org/48045
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Set TYPO3 version to 7.6.10-dev 72/48272/2
TYPO3 Release Team [Tue, 24 May 2016 10:03:15 +0000 (12:03 +0200)]
[TASK] Set TYPO3 version to 7.6.10-dev

Change-Id: I9b4af29d664e624e26b9636d4ed6137a9514c530
Reviewed-on: https://review.typo3.org/48272
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.9 71/48271/2 7.6.9 TYPO3_7-6-9
TYPO3 Release Team [Tue, 24 May 2016 10:02:31 +0000 (12:02 +0200)]
[RELEASE] Release of TYPO3 7.6.9

Change-Id: I7866e19750326b2e0673529c63a9b3ceef5b7169
Reviewed-on: https://review.typo3.org/48271
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] Allow non critical request arguments with @ 66/48266/2
Helmut Hummel [Tue, 24 May 2016 09:08:23 +0000 (11:08 +0200)]
[BUGFIX] Allow non critical request arguments with @

Resolves: #76278
Releases: master, 8.1, 7.6, 6.2
Change-Id: Iedb71737ab3b69f2873292ea1cab165e0ec21cec
Reviewed-on: https://review.typo3.org/48266
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2 years ago[TASK] Set TYPO3 version to 7.6.9-dev 62/48262/2
TYPO3 Release Team [Tue, 24 May 2016 07:56:02 +0000 (09:56 +0200)]
[TASK] Set TYPO3 version to 7.6.9-dev

Change-Id: I7254f42405b33fe87e55e52b2824fb34e668cf7e
Reviewed-on: https://review.typo3.org/48262
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.8 61/48261/2 7.6.8 TYPO3_7-6-8
TYPO3 Release Team [Tue, 24 May 2016 07:55:19 +0000 (09:55 +0200)]
[RELEASE] Release of TYPO3 7.6.8

Change-Id: I4d70a820e1eda9274a088820b5c79608fffe1e82
Reviewed-on: https://review.typo3.org/48261
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[SECURITY] Validate complete referring request 56/48256/2
Helmut Hummel [Tue, 24 May 2016 07:44:08 +0000 (09:44 +0200)]
[SECURITY] Validate complete referring request

Instead of only checking for valid request arguments by using a hmac,
we now check the complete request including action, controller and vendor
to avoid spoofing these arguments and bypassing other security checks
during forwarding to the referring action.

Additionally, ReferringRequest is now separate from regular Request.
The meaning of properties starting with "@" is only valid for
processing a referring request. To avoid mixed concerns in using
the same Request implementation for regular requests and referring
requests, they are separated now.

Resolves: #76231
Resolves: #76256
Releases: master, 7.6, 6.2
Security-Commit: e4eb0e63ace525a68f172aa9be1af23d69ea2ab2
Security-Bulletin: TYPO3-CORE-SA-2016-013
Change-Id: I334b2aa9ea3de0778adb38f007b1bd5e5a6a1be5
Reviewed-on: https://review.typo3.org/48256
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Use `find()` to get option tags from select 09/48209/2
Andreas Fernandez [Mon, 9 May 2016 15:04:25 +0000 (17:04 +0200)]
[BUGFIX] Use `find()` to get option tags from select

Using `children()` to get the option tags from the select fields
will fail if the select field contains `optgroup` tags (e.g. rendered
by a hook).

This patch replaces `children()` with `find()` to cover this
edge case.

Resolves: #76097
Releases: master, 7.6
Change-Id: Ib80f422d465d9e48232b1820e524a01a97eb94e6
Reviewed-on: https://review.typo3.org/48209
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fixes rendering of page content titles 07/48207/2
Tomita Militaru [Thu, 12 May 2016 15:41:54 +0000 (17:41 +0200)]
[BUGFIX] Fixes rendering of page content titles

Removes the htmlspecialchars from the rendering of
page content titles / tooltips.

Resolves: #76149
Releases: master, 7.6
Change-Id: Ia5ad3df56101fe3962e4a5814df53dabdf5a4bbc
Reviewed-on: https://review.typo3.org/48207
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Make driver registry TCA change cacheable 04/48204/2
Helmut Hummel [Mon, 9 May 2016 17:54:04 +0000 (19:54 +0200)]
[TASK] Make driver registry TCA change cacheable

Instead of calling the driver registry on every request,
we can cache the TCA addition, by putting the call into overrides.

Resolves: #76102
Releases: 7.6, master
Change-Id: I8cfc72f0e7dbb133eecc754fd3cb774637a0d4bf
Reviewed-on: https://review.typo3.org/48204
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Set TYPO3 version to 7.6.8-dev 97/48197/2
TYPO3 Release Team [Tue, 17 May 2016 12:31:02 +0000 (14:31 +0200)]
[TASK] Set TYPO3 version to 7.6.8-dev

Change-Id: I50706e01a75fb52770d3aa51fdb2e9d15be614c2
Reviewed-on: https://review.typo3.org/48197
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[RELEASE] Release of TYPO3 7.6.7 96/48196/2 7.6.7 TYPO3_7-6-7
TYPO3 Release Team [Tue, 17 May 2016 12:30:18 +0000 (14:30 +0200)]
[RELEASE] Release of TYPO3 7.6.7

Change-Id: I2ec251a965a0de4057185ee1d954dbad0c2fa14f
Reviewed-on: https://review.typo3.org/48196
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
3 years ago[BUGFIX] Use push parser instead of pull parser on fetching extension list 88/48188/2
Oliver Hader [Tue, 17 May 2016 10:15:49 +0000 (12:15 +0200)]
[BUGFIX] Use push parser instead of pull parser on fetching extension list

Issue #75022 reported problems with libxml and operations on compressed
file streams. The work around for that patch showed drawbacks with memory
consumption. That's why the push parser is used as default now.

Resolves: #75721
Related: #75022
Releases: master, 7.6, 6.2
Change-Id: I6daadd4b375634cf45272bb249e4bfa083f03646
Reviewed-on: https://review.typo3.org/48188
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Correctly treat uploaded file when replacing a file 94/48194/2
Markus Klein [Tue, 17 May 2016 08:38:28 +0000 (10:38 +0200)]
[BUGFIX] Correctly treat uploaded file when replacing a file

Uploaded files must be moved with the specific PHP function,
otherwise permissions may be wrong.

Resolves: #76205
Releases: master, 7.6
Change-Id: Ic96e6b8927ed5d21131952004805fa72fb8b6857
Reviewed-on: https://review.typo3.org/48194
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years agoRevert "[BUGFIX] Load XML files of Extension Manager properly" 83/48183/2
Oliver Hader [Tue, 17 May 2016 09:53:15 +0000 (11:53 +0200)]
Revert "[BUGFIX] Load XML files of Extension Manager properly"

This reverts commit 558f618f576a6fc9b87b592698856c80701aeb94.

This change did not completely solve the libxml issue and introduced
additional trouble on memory consumption with the current pull parsers.

Related: #75022
Releases: master, 7.6, 6.2
Change-Id: I42454d61ab444860fc53b29715df69e65a2f0475
Reviewed-on: https://review.typo3.org/48183
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Make "$hookObject must implement interface FooInterface" more verbose 77/48177/2
Andreas Fernandez [Fri, 13 May 2016 14:59:05 +0000 (16:59 +0200)]
[TASK] Make "$hookObject must implement interface FooInterface" more verbose

The exceptions show now the affected class that does not
implement the required interface. Where possible, the FQCN
in the exception message string was replaced with the shorter
::class syntax.

Resolves: #76187
Releases: master, 7.6
Change-Id: Id2c290a0cf29bdec5da504a8959996bb747f1c27
Reviewed-on: https://review.typo3.org/48177
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Removes extra space from important 09/48109/3
Tomita Militaru [Thu, 12 May 2016 12:40:36 +0000 (14:40 +0200)]
[BUGFIX] Removes extra space from important

Removes extra space from between ! and important
override from rtehtmlarea CSS.

Resolves: #75958
Releases: master,7.6
Change-Id: If19ff8cc80c11fe650c12e914a07d5b6938a8ab8
Reviewed-on: https://review.typo3.org/48109
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[FOLLOWUP][TASK] Hide selected items in multipleSideBySide 07/48107/2
Andreas Fernandez [Tue, 10 May 2016 11:53:18 +0000 (13:53 +0200)]
[FOLLOWUP][TASK] Hide selected items in multipleSideBySide

The original patch introduced some regressions which are fixed now:

- Deletion of multiple items works correctly now
- Inserting items by the Element Browser does not throw an error anymore

Resolves: #76071
Releases: master, 7.6
Change-Id: Ie16a1d404c2f12e6c952dc5022caff08ec6af171
Reviewed-on: https://review.typo3.org/48107
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Make the whole update button in extension manager clickable 98/48098/3
Gianluigi Martino [Thu, 12 May 2016 08:28:48 +0000 (10:28 +0200)]
[TASK] Make the whole update button in extension manager clickable

The click area of the update button in extension manager was to small.
The click handler is now assigned to the whole button.

Change-Id: I8b2103dcbde5dcc37a7968780719abca384528a1
Resolves: #76136
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48098
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Raise hostname length to 255 characters 83/48083/2
Anja Leichsenring [Wed, 11 May 2016 08:11:08 +0000 (10:11 +0200)]
[BUGFIX] Raise hostname length to 255 characters

When installing TYPO3 in a cloud environment, the 50 character
limit is not high enough. Therefor it is raised to 255 chars,
what most protocols define as the max limit.

Releases: master, 7.6
Resolves: #76132
Change-Id: I59383911e791b635fc80cb6b6b3c76d4433c8e0d
Reviewed-on: https://review.typo3.org/48083
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Show new content button for editors in page module again 63/48063/2
Gianluigi Martino [Tue, 10 May 2016 08:48:26 +0000 (10:48 +0200)]
[BUGFIX] Show new content button for editors in page module again

Editors (group) doesn't see the new content button without page edit
permission in page module. with this bugfix editors can insert new content
again.

Change-Id: Ie8957b3386dfca8a91b7718bedba16af7559b373
Resolves: #76036
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48063
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Hide selected items in multipleSideBySide 54/48054/2
Andreas Fernandez [Sat, 7 May 2016 08:30:06 +0000 (10:30 +0200)]
[TASK] Hide selected items in multipleSideBySide

If a multipleSideBySide form element is not allowed to add the same
value multiple times, its selected values are hidden now and it's not
possible to add them again unless the values are removed from the
selection.

Resolves: #76071
Releases: master, 7.6
Change-Id: I99d6c609ca081f4b8cb6f8ad07f74385a23b7a5c
Reviewed-on: https://review.typo3.org/48054
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Don't disable redirect after logout with showLogoutFormAfterLogin=1 48/48048/2
Daniel Goerz [Fri, 6 May 2016 13:44:14 +0000 (15:44 +0200)]
[BUGFIX] Don't disable redirect after logout with showLogoutFormAfterLogin=1

This patch fixes a regression where showLogoutFormAfterLogin was added
as a condition to disable redirects in fe_login at all when it should
only disable redirects after login.

Change-Id: Ide5c17f202618c9c0696bc777473a7be1b089276
Resolves: #73144
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48048
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Allow opening custom doktype in the frontend 39/48039/2
Wouter Wolters [Sat, 7 May 2016 15:20:43 +0000 (17:20 +0200)]
[BUGFIX] Allow opening custom doktype in the frontend

A few doktype are checked now to open the frontend page.
Others will redirect to the homepage. Allow custom doktypes now
too with opening the frontend page.

Resolves: #75499
Resolves: #70094
Releases: master,7.6
Change-Id: Iaffe03dfff3f1181f26964f26611d80e71406b5c
Reviewed-on: https://review.typo3.org/48039
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Harden database select step 67/47967/4
Helmut Hummel [Fri, 29 Apr 2016 10:50:38 +0000 (12:50 +0200)]
[BUGFIX] Harden database select step

Currently this step does not do precautions, when
the selected database does not exist. Additionally the step
silently skips when the chosen database already has tables.

Although the UI currently does not allow to select a non
empty database, there are situations imaginable, where the database
is empty during generation of the input form but is filled directly
after that, or a database was empty but then got deleted, which
previously ended up with a fatal error.

This change now takes care of both cases and outputs a nice error
message accordingly.

Resolves: #75964
Releases: 7.6, master
Change-Id: Ibc7083aa120f420d6201e512f3f41699f55c5f7f
Reviewed-on: https://review.typo3.org/47967
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Prevent temp file generation in Unit Test 32/48032/2
Nicole Cordes [Fri, 6 May 2016 17:10:55 +0000 (19:10 +0200)]
[BUGFIX] Prevent temp file generation in Unit Test

Running Unit Tests creates file /tmp/typo3.log. On Windows systems
this file is stored on the root of the drive. This patch uses the
defined temp folder for storing the file.

Resolves: #76070
Releases: master, 7.6, 6.2
Change-Id: Id77684e41020feb1a1ecff5051a80d2919250bf8
Reviewed-on: https://review.typo3.org/48032
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Make .htaccess Apache 2.4 suitable 29/48029/2
Marc von Schalscha-Ehrenfeld [Fri, 6 May 2016 11:25:22 +0000 (13:25 +0200)]
[TASK] Make .htaccess Apache 2.4 suitable

This patch makes EXT:documentation/Resources/Private/.htaccess and
EXT:extbase/Resources/Private/.htaccess Apache 2.4 suitable

Resolves: #76066
Resolves: #76064
Releases: master, 7.6, 6.2
Change-Id: I91c6e683eeb1bc92e1192d2b3800d2dcb8a9d4b9
Reviewed-on: https://review.typo3.org/48029
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Set correct ordering in EM "A/D" 21/48021/2
Markus Sommer [Fri, 6 May 2016 08:14:36 +0000 (10:14 +0200)]
[BUGFIX] Set correct ordering in EM "A/D"

Resolves: #72211
Releases: master, 7.6
Change-Id: I3c7539743b534c0584e7f6685d1a96066063ca51
Reviewed-on: https://review.typo3.org/48021
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Only focus RTE if current focus is on body tag 19/48019/2
Andreas Fernandez [Thu, 7 Apr 2016 08:09:44 +0000 (10:09 +0200)]
[BUGFIX] Only focus RTE if current focus is on body tag

Focus the RTE (or its textarea fallback) only if the current focus
is on the body tag, which is the default after loading a page.
This prevents focus stealing if the focus is e.g. on an input field
before the RTE was initialized.

Resolves: #72900
Releases: master, 7.6
Change-Id: I238cd0ce1972f41e451ace674eeff350690cb427
Reviewed-on: https://review.typo3.org/48019
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add class form-control to textarea in image tests 02/48002/3
Markus Sommer [Fri, 5 Feb 2016 12:47:47 +0000 (13:47 +0100)]
[TASK] Add class form-control to textarea in image tests

Resolves: #75977
Releases: 7.6
Change-Id: I21a558ed54559d345fed1878fcb7665860ba09e8
Reviewed-on: https://review.typo3.org/48002
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Disallow access to documentation folders 17/48017/2
Markus Klein [Wed, 27 Apr 2016 08:12:51 +0000 (10:12 +0200)]
[TASK] Disallow access to documentation folders

Update the default .htaccess file. The users must update their
actual configuration (.htaccess or server config) manually.

Resolves: #75934
Releases: master, 7.6, 6.2
Change-Id: I8e40263c72f68c44cb8fd8c1944a44e4d38d9daa
Reviewed-on: https://review.typo3.org/48017
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Supply renderType definition in flexform of EXT:felogin 16/48016/2
Andreas Fernandez [Thu, 5 May 2016 16:11:53 +0000 (18:11 +0200)]
[BUGFIX] Supply renderType definition in flexform of EXT:felogin

This patch adds the renderType definition into the flexform
of the felogin extension.

Resolves: #76059
Releases: master, 7.6
Change-Id: Ia31135f94c2018ae188aef4897edcec1552efc3f
Reviewed-on: https://review.typo3.org/48016
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Correctly initialize content object for plugins 12/48012/2
Helmut Hummel [Wed, 4 May 2016 18:49:56 +0000 (20:49 +0200)]
[BUGFIX] Correctly initialize content object for plugins

For rendering plugins FSC uses the cObjecViewHelper,
but misses to set the table name.

This leads to an incompletely initialized content object
being used when rendering the plugin.

cObj->currentRecord will stay empty, but some functionality
relies on this value to be correctly set.

Resolves: #76052
Releases: master, 7.6
Change-Id: I66b725adb3a0311609cfc60c29951eba5aa2217c
Reviewed-on: https://review.typo3.org/48012
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Make "No renderType definition" exception more verbose 10/48010/2
Andreas Fernandez [Wed, 4 May 2016 16:22:10 +0000 (18:22 +0200)]
[TASK] Make "No renderType definition" exception more verbose

To make the exception message more helpful, it contains now
the table name and the field name of the bogus TCA.

Resolves: #76051
Releases: master, 7.6
Change-Id: I93ca6ebde517756da14e7171d42cdcd8ef598888
Reviewed-on: https://review.typo3.org/48010
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use correct identifier for copyFile permission 01/48001/2
Markus Klein [Tue, 3 May 2016 15:35:10 +0000 (17:35 +0200)]
[BUGFIX] Use correct identifier for copyFile permission

Update the TCA to provide correct defaults for file and folder
permissions of BE users and groups.

Resolves: #76033
Releases: master, 7.6
Change-Id: I4cbc8c28d89e6dc23d415eb95fe851742e599068
Reviewed-on: https://review.typo3.org/48001
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Streamline styling of RTE context menu 82/47982/3
Andreas Fernandez [Sun, 1 May 2016 10:25:00 +0000 (12:25 +0200)]
[TASK] Streamline styling of RTE context menu

The visual appearance of the context menu of the RTE is streamlined with
the non-ExtJS context menus. The "scroller" areas are now larger and
easier to hit.
The shadow which is behind the context menu has been removed.

Resolves: #75992
Releases: master, 7.6
Change-Id: I3b360ce3fa2e9cae68d796e0a612c8f443c0141d
Reviewed-on: https://review.typo3.org/47982
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Add confirm dialog on delete again 81/47981/2
Frank Naegler [Sat, 30 Apr 2016 20:21:11 +0000 (22:21 +0200)]
[BUGFIX] Add confirm dialog on delete again

In the backend user module, the delete icon shows again a confirm modal to
prevent accidently deleting a backend user.

Resolves: #75994
Releases: master, 7.6
Change-Id: I066f94237301eb923ac982fdacb5566c396a5e43
Reviewed-on: https://review.typo3.org/47979
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit eb2ca5d215c37524f6136efc0edef37127f7ff05)
Reviewed-on: https://review.typo3.org/47981

3 years ago[BUGFIX] RTE: Determine correct context menu position 77/47977/2
Andreas Fernandez [Sat, 30 Apr 2016 12:39:43 +0000 (14:39 +0200)]
[BUGFIX] RTE: Determine correct context menu position

The context menu of the RTE is now correctly positioned with this patch.
The position is now based on the cursor's position. The `targetPosition` is
removed now as it has strange side-effects if the context menu is opened
at formatted text.

The method `constrainScroll` is overridden to circumvent a bug in ExtJS
where the menu is repositioned and the height is changed to show
as much items as possible, even if the ``maxHeight`` setting is set.

Resolves: #74332
Releases: master, 7.6
Change-Id: I9e2e42c98ca578101945f65f7c50e32a615806b7
Reviewed-on: https://review.typo3.org/47977
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Fix JavaScript error for GMENU rollover 75/47975/2
Frank Naegler [Fri, 29 Apr 2016 14:50:47 +0000 (16:50 +0200)]
[BUGFIX] Fix JavaScript error for GMENU rollover

Resolves: #75983
Releases: master, 7.6
Change-Id: I9851418d2add84daf326257fa27f91574e532923
Reviewed-on: https://review.typo3.org/47972
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 65141417e3c37dd178e77312bbd9074eb074f05e)
Reviewed-on: https://review.typo3.org/47975

3 years ago[BUGFIX] Set semantic value to autocomplete 73/47973/2
Nicole Cordes [Wed, 20 Apr 2016 14:05:24 +0000 (16:05 +0200)]
[BUGFIX] Set semantic value to autocomplete

To enforce Chrome to respect the disabled autocompletion for fields,
the value of the autocomplete attribute is set to some semantic
value.

Resolves: #75809
Releases: master, 7.6
Change-Id: Ib30fdfe7d7a9ff3f564b8e016331a0706ff0db01
Reviewed-on: https://review.typo3.org/47973
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Allow maxitem=1 in TCA treeSelect again 71/47971/2
Alexander Bigga [Wed, 27 Apr 2016 13:50:31 +0000 (15:50 +0200)]
[BUGFIX] Allow maxitem=1 in TCA treeSelect again

Introduced with ec7b229 #75519, it was not possible to set maxitem=1 to
TCA treeSelect. This occures e.g. on setting the parent of a
sys_category.

The reason is the "selected" array which gets initialized with all
selected items. If there is no item selected, it is initialized with an
empty value and "selected.lenght" is 1 but should be 0. Selecting a new
value is impossible now.

The proposed path checks if items are selected or not on
initialization.

Change-Id: I0c8d21ad753dccb2d993febde404afc83a39b9b3
Resolves: #75947
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/47971
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>