Packages/TYPO3.CMS.git
4 years ago[TASK] Make t3skin a protected extension 45/37545/2
Benjamin Kott [Wed, 4 Mar 2015 22:12:44 +0000 (23:12 +0100)]
[TASK] Make t3skin a protected extension

To ensure the backend is always in a usable and wellformed
state the t3skin extension needs to be always activated.

Releases: master
Resolves: #65528
Change-Id: I7e873a925834722158085500e2fcf2b80ef54f1e
Reviewed-on: http://review.typo3.org/37545
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Streamline Scheduler 10/37110/10
Andreas Fernandez [Mon, 23 Feb 2015 13:15:43 +0000 (14:15 +0100)]
[TASK] Streamline Scheduler

Streamline the layout of the scheduler.

Resolves: #65233
Releases: master
Change-Id: I2f91f187e21359d2228e81efb198b9bf9134d400
Reviewed-on: http://review.typo3.org/37110
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] General code cleanup in ext:sv 99/37299/3
Wouter Wolters [Thu, 26 Feb 2015 22:25:32 +0000 (23:25 +0100)]
[TASK] General code cleanup in ext:sv

Resolves: #65370
Releases: master
Change-Id: If444c38cf263b0e089adb155cf0d2da7eb4dd9f5
Reviewed-on: http://review.typo3.org/37299
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] EM: Fix icon leftovers 14/37514/2
Andreas Fernandez [Wed, 4 Mar 2015 08:10:51 +0000 (09:10 +0100)]
[TASK] EM: Fix icon leftovers

The "Update extension" task uses an FA icon now. The obsolete file
"ExtensionUpdateScript.png" is removed.

Resolves: #65500
Releases: master
Change-Id: If527b0e8fd77a059c8b25db16a926c5c80356331
Reviewed-on: http://review.typo3.org/37514
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Code cleanup EXT:backend/Classes/File/*.php 13/37513/3
Michael Oehlhof [Tue, 3 Mar 2015 22:57:25 +0000 (23:57 +0100)]
[TASK] Code cleanup EXT:backend/Classes/File/*.php

- add missing return values
- add missing phpdoc comments
- remove unused variable assingments
- add getter for LanguageService
- add getter for BackendUser

Resolves: #65498
Releases: master
Change-Id: I0314fa03b9ac885c46e281a167d04f060fb10617
Reviewed-on: http://review.typo3.org/37513
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove RemoveXSS credit link 34/37534/2
Christian Kuhn [Wed, 4 Mar 2015 18:45:25 +0000 (19:45 +0100)]
[BUGFIX] Remove RemoveXSS credit link

The current link to RemoveXSS project is broken and
no new one can be found. The patch removes the link
from about module but keeps other references in the
source files

Change-Id: Iff9590aae3cd093c17553a94d1d5c88afde54834
Releases: master, 6.2
Resolves: #65485
Reviewed-on: http://review.typo3.org/37534
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Reload extension list after update 02/37502/3
Nicole Cordes [Tue, 3 Mar 2015 14:10:12 +0000 (15:10 +0100)]
[BUGFIX] Reload extension list after update

If an extension was updated the list should be reloaded to show
update information.

Releases: master, 6.2
Resolves: #64733
Change-Id: I27598995fd365745eab14a1e095fd342cd198093
Reviewed-on: http://review.typo3.org/37502
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Regression when scaling/cropping in GIFBUILDER 83/37483/6
Torben Hansen [Tue, 3 Mar 2015 08:34:41 +0000 (09:34 +0100)]
[BUGFIX] Regression when scaling/cropping in GIFBUILDER

The fix for issue #64224 introduced a regression in GIFBUILDER
resulting in problems with image scaling/cropping.

For $fileInfo and $maskInfo: use 'processedFile' for FAL files
if available and correctly distinguish between FAL- and non-FAL files
otherwise by checking for 'origFile'.

Resolves: #65378
Related: #64224
Releases: master, 6.2
Change-Id: Ib472bdcdc7f814e50ebd18e084f5fbe7d09fc410
Reviewed-on: http://review.typo3.org/37483
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Christoph Lehmann <christoph.lehmann@networkteam.com>
Tested-by: Philipp Mueller <philipp.mueller@lavitto.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove Closure in signalSlotDispatcher 85/37485/6
Nicole Cordes [Tue, 3 Mar 2015 09:49:34 +0000 (10:49 +0100)]
[BUGFIX] Remove Closure in signalSlotDispatcher

As the classAliasMap is a singleton we don't need to initialize it on
every dispatch, but we can call the method directly on the instance.
This prevents a closure for signalSlotDispatcher which otherwise throws
an exception on serialization.

Releases: master
Resolves: #65473
Change-Id: I1280a4a054f3b63b4b5e71262d4d054b511f001b
Reviewed-on: http://review.typo3.org/37485
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Avoid getTCAtypeValue-calls in DataHandler->fillInFieldArray 27/35227/3
Stephan Großberndt [Wed, 10 Dec 2014 10:13:43 +0000 (11:13 +0100)]
[BUGFIX] Avoid getTCAtypeValue-calls in DataHandler->fillInFieldArray

DataHandler->fillInFieldArray fetches BackendUtility::getTCAtypeValue
for each record but uses the value only if several RTE-transformation-
related conditions are met.

Fetch BackendUtility::getTCAtypeValue only if the RTE-transformation-
related conditions are met for the first time and keep it afterwards.

Resolves: #63728
Releases: master, 6.2
Change-Id: I14b307c45cab2d778968f3fd98c18348b666be3d
Reviewed-on: http://review.typo3.org/35227
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix access to time tracker in eID scripts 03/37503/2
Mathias Brodala [Tue, 3 Mar 2015 14:44:11 +0000 (15:44 +0100)]
[BUGFIX] Fix access to time tracker in eID scripts

During refactoring of request handling setup of the global time
tracker was removed for eID scripts.

This also fixes the setup order in the frontend request handler
since this happened before the "preprocessRequest" hook was executed
in the old index_ts.php

Resolves: #65488
Releases: master
Change-Id: I5b0c63db37360039fdb9d9e0ff29adfa38da22c5
Reviewed-on: http://review.typo3.org/37503
Reviewed-by: Juan Manuel Vergés Solanas <juanmanuel.vergessolanas@gmail.com>
Tested-by: Juan Manuel Vergés Solanas <juanmanuel.vergessolanas@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Reset global ajaxID for ajax requests 93/37493/2
Nicole Cordes [Tue, 3 Mar 2015 12:32:46 +0000 (13:32 +0100)]
[BUGFIX] Reset global ajaxID for ajax requests

Due to patch https://review.typo3.org/#/c/37409/ the global ajaxID
isn't set anymore. This variable is needed by several ajax requests and
expected to be set in global context. This patch sets the given ajaxID
globally.

Releases: master
Resolves: #65477
Change-Id: Id06d9b6a4d7bf41061e917ed6049a3dfefbf32f0
Reviewed-on: http://review.typo3.org/37493
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Code cleanup: Clipboard.php 02/37402/2
Michael Oehlhof [Sun, 1 Mar 2015 11:29:26 +0000 (12:29 +0100)]
[TASK] Code cleanup: Clipboard.php

backend/Classes/Clipboard/Clipboard.php
To get it "green" in PhpStorm several changes were made:

- set correct parameter type in PhpDoc comment
- set correct return type in PhpDoc comment
- add missing return values
- add getter for LanguageService
- add getter for BackendUser
- add getter for DatabaseConnection

Resolves: #65428
Releases: master
Change-Id: I3079a845242239325616b682683cc79da36ee4f8
Reviewed-on: http://review.typo3.org/37402
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Do not fetch records from tables without references 91/35191/28
Stephan Großberndt [Tue, 9 Dec 2014 13:42:05 +0000 (14:42 +0100)]
[BUGFIX] Do not fetch records from tables without references

If no field of a table can contain a reference by its TCA definition
do not fetch record from this table at all. For tables with fields
which can possibly contain references fetch only these fields instead
of all.

Cache list of fields which don't have to be checked in the local member
'nonRelationFields' instead of recreating the list for each and every
record.

Don't try to update references for tables sys_log, sys_history and
tx_extensionmanager_domain_model_extension since they cannot contain
references and usually have a big amount of records.

Introduce some early returns to make code more readable.

Improves performance for both bulk inserts and updating the reference
index from the command line.

Resolves: #63676
Resolves: #63782
Releases: master, 6.2
Change-Id: Ibc6f988bfde6042339595bf7b3e18125c64ae72d
Reviewed-on: http://review.typo3.org/35191
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Additional params for HtmlParser attribute userFunc 35/30935/7
Alexander Stehlik [Sun, 1 Feb 2015 12:34:41 +0000 (13:34 +0100)]
[FEATURE] Additional params for HtmlParser attribute userFunc

Sub parameters passed to the HtmlParser tag configuration like:

fixAttrib.[attribute].userFunc.myparam = test1

will be passed to the configured user function in an array. The
attribute value will be stored in the attributeValue array key.

To keep backward compatibility the attribute value will be passed as
string to the user function when no additional attributes exist.

Releases: master
Resolves: #59712
Change-Id: Ib073dad0759fa2b20a82bf976f8d04f39d9135f0
Reviewed-on: http://review.typo3.org/30935
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Allow stripping of empty tags in HtmlParser 75/16975/19
Alexander Stehlik [Mon, 2 Mar 2015 19:07:34 +0000 (20:07 +0100)]
[FEATURE] Allow stripping of empty tags in HtmlParser

Add a stripEmptyTags method to the HtmlParser
It can be enabled by TypoScript or TSConfig:

HTMLparser.stripEmptyTags = 1
HTMLparser.stripEmptyTags.tags = h2, h3
HTMLparser.stripEmptyTags.treatNonBreakingSpaceAsEmpty = 1

Resolves: #20555
Releases: master
Change-Id: I640486e9f32da6ac1eba05e3c38d15a0aba41055
Reviewed-on: http://review.typo3.org/16975
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move cache configuration to DefaultConfiguration 68/37468/3
Christian Kuhn [Mon, 2 Mar 2015 18:23:49 +0000 (19:23 +0100)]
[TASK] Move cache configuration to DefaultConfiguration

ext:fluid and ext:exbase configure additional caches in ext_localconf.
Since both extensions are required and always loaded, those cache
configurations are moved to ext:core DefaultConfiguration.php to
have an easier life for admins who reconfigure those caches in
LocalConfiguration.

Resolves: #65467
Releases: master
Change-Id: I63ac633f15d0a0774deffa3620d67a405af1e5df
Reviewed-on: http://review.typo3.org/37468
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[CLEANUP] Unused maxListPerPage property in indexed_search 69/37469/3
Alexander Stehlik [Mon, 2 Mar 2015 18:39:30 +0000 (19:39 +0100)]
[CLEANUP] Unused maxListPerPage property in indexed_search

The maxListPerPage class property in the indexed_search Administration
controller ist not used any more and therefore removed.

Releases: master, 6.2
Resolves: #65468
Change-Id: Ic1e13bf0e6f7426d5efb54b0996323ac681c2ed4
Reviewed-on: http://review.typo3.org/37469
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Allow AjaxDataHandler to pick button labels for Modal 67/37467/2
Felix Kopp [Mon, 2 Mar 2015 18:26:10 +0000 (19:26 +0100)]
[TASK] Allow AjaxDataHandler to pick button labels for Modal

Use AjaxDataHandler with Modal API without TYPO3.Language inline.
Allow Modal API to pick button labels when wrapped in AjaxDataHandler

Resolves: #65466
Releases: master
Change-Id: Ibe1385e41a8481620af74a3af6b3c4a49485fe4f
Reviewed-on: http://review.typo3.org/37467
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Properly handle XLF translation file detection 67/37167/6
Markus Klein [Wed, 25 Feb 2015 13:26:51 +0000 (14:26 +0100)]
[BUGFIX] Properly handle XLF translation file detection

The GeneralUtility::llXmlAutoFileName() method will now also correctly
handle paths to files that are not placed within a known directory
(ext, sysext, etc.) if the call is made with $sameFile = TRUE.
This allows placing language files in arbitrary storage.

This change finally re-enables the usage of locallang files in TypoScript
or f:translate-ViewHelpers which use the XLIFF format and are not placed
within an extension.
This has always been working with files in the XML format.

Resolves: #65273
Releases: master, 6.2
Change-Id: Ibb647cea32a9fc04e9dfdf707a5e8690ad399d5c
Reviewed-on: http://review.typo3.org/37167
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[!!!][BUGFIX] Skip cache hash for URIs to non-cacheable actions 94/31594/13
Mathias Brodala [Fri, 11 Jul 2014 11:51:47 +0000 (13:51 +0200)]
[!!!][BUGFIX] Skip cache hash for URIs to non-cacheable actions

When building an URI for a non-cacheable action, while the current
request also is uncached, we can skip the cache hash for the target URI
to avoid unnecessary page cache entries.

Since this is a change in behavior during link generation, which other
code may rely upon, this is marked as breaking change.

Resolves: #60272
Releases: master
Change-Id: I448c33d23b790de1064eff95d0a940878b0299ac
Reviewed-on: http://review.typo3.org/31594
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Cache cache_imagesizes using the Caching Framework 86/35686/9
Benjamin Mack [Wed, 31 Dec 2014 00:17:16 +0000 (01:17 +0100)]
[TASK] Cache cache_imagesizes using the Caching Framework

Streamline the code by moving the functionality to cache image sizes
processed by GraphicalFunctions (local-only so far) from the database
table cache_imagesizes to the Caching Framework.

The following changes are done:
* use sha1 instead of md5
* use Caching Framework instead of hardcoded DB table
* store only necessary data in the cache

The new Caching Framework configuration is stored
in a new group called "lowlevel" which is only emptied
when pressing the clear cache button in the install tool.

The former table cache_imagesizes has been filled automatically and
never been cleaned except manually in the Install Tool area "Cleanup".
This means there could be a lot of leftover entries. Now the cache is
cleared when using the common clear caches button in the install tool.

Resolves: #28484
Releases: master
Change-Id: Ia68410eb382163e90654718aeb17165dc48e40cc
Reviewed-on: http://review.typo3.org/35686
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Add property "uidLocal" to extbase FileReference model 17/37417/6
Jost Baron [Sun, 1 Mar 2015 16:07:33 +0000 (17:07 +0100)]
[BUGFIX] Add property "uidLocal" to extbase FileReference model

This is needed so extbase persists FileReferences created in the
frontend correctly. Otherwise the field "uid_local" would always
be set to 0 in the database, creating an invalid file reference.

Resolves: #48965
Related: #5718

Releases: 6.2, master
Change-Id: I1e620c18d60546fdc081410b1d27a1b1de6f3e5b
Reviewed-on: http://review.typo3.org/37417
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add scheduler task to remove deleted records 13/9013/22
Philipp Bergsmann [Mon, 13 Feb 2012 18:19:47 +0000 (19:19 +0100)]
[FEATURE] Add scheduler task to remove deleted records

Scheduler task to remove deleted records from
content table(s) which are older than x days.

If a deleted record also contains an upload field,
then the file is also deleted.

Releases: master
Resolves: #32651
Change-Id: I58577c05a1a3b228579c05578cc8fdf2e3b393fa
Reviewed-on: http://review.typo3.org/9013
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Show data of valid columns in element info 60/27360/4
Marc Bastian Heinrichs [Wed, 5 Feb 2014 15:18:42 +0000 (16:18 +0100)]
[BUGFIX] Show data of valid columns in element info

The element information show rows for the data from
the special fields crdate, cruser_id and tstamp also if they
are not defined in TCA. They are also hardcoded and
doesn't rely on the settings in TCA ctrl.

Resolves: #55699
Releases: master, 6.2
Change-Id: I7c9a387c75d367618117ffcb6f04592ee519cecc
Reviewed-on: http://review.typo3.org/27360
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add a Format.Case ViewHelper 13/36913/5
Alexander Schnitzler [Sat, 14 Feb 2015 20:02:43 +0000 (21:02 +0100)]
[FEATURE] Add a Format.Case ViewHelper

This adds a Format.Case ViewHelper that changes
a string's case in various manners like uppercase,
lowercase, (un-)capitalization and
each-word-capitalization.

Resolves: #58621
Releases: master
Change-Id: I182fae00a8bf11b6188e73bdd9cf15011ed3620d
Reviewed-on: http://review.typo3.org/36913
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Recycler: Rename table to record type 10/36710/3
Frederic Gaus [Fri, 6 Feb 2015 07:56:40 +0000 (08:56 +0100)]
[TASK] Recycler: Rename table to record type

Rename label "table" to "record type" in recycler

Change-Id: I81226203e3bcb705320563bc508d74f69d8142c1
Resolves: #43368
Releases: master
Reviewed-on: http://review.typo3.org/36710
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Fluid RenderViewHelper compilable 53/37453/4
Christian Kuhn [Mon, 2 Mar 2015 11:24:05 +0000 (12:24 +0100)]
[TASK] Fluid RenderViewHelper compilable

Resolves: #65451
Releases: master
Change-Id: Ia08ec9b586a2b080763f07ee2fe6e257ca484397
Reviewed-on: http://review.typo3.org/37453
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Code cleanup ContextMenuConfiguration.php 43/37443/3
Michael Oehlhof [Sun, 1 Mar 2015 23:25:53 +0000 (00:25 +0100)]
[TASK] Code cleanup ContextMenuConfiguration.php

backend/Classes/ContextMenu/Pagetree/Extdirect/ContextMenuConfiguration.php
To get it "green" in PhpStorm several changes were made:

- set correct parameter type in PhpDoc comment
- add missing return value

Resolves: #65444
Releases: master
Change-Id: Iebb9c4c789612f229f4d4562cfd1445d98703594
Reviewed-on: http://review.typo3.org/37443
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Invalid back path of ImageViewHelper in TYPO3 backend 07/37407/2
Oliver Hader [Sun, 1 Mar 2015 13:36:27 +0000 (14:36 +0100)]
[BUGFIX] Invalid back path of ImageViewHelper in TYPO3 backend

If rendering an image in the TYPO3 backend, the regular case is
to prepend "../" to an URI with the assumption that the original
HTTP request was handled by typo3/backend.php.

For the page module for instance, the request points to
typo3/sysext/cms/layout/db_layout.php, thus the back path way
does not work anymore.

To overcome that behavior the absolute path shall be used
instead by determining TYPO3_SITE_PATH. For the case that
some custom processing relies on "../" this change might
be breaking.

Resolves: #65433
Releases: master, 6.2
Change-Id: I969f6a3bdd000b7efb7607e533d1117c8d363959
Reviewed-on: http://review.typo3.org/37407
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Refactor module dispatcher to RequestHandler 30/37430/7
Helmut Hummel [Mon, 8 Dec 2014 15:21:56 +0000 (16:21 +0100)]
[TASK] Refactor module dispatcher to RequestHandler

In order to move the mod.php global logic into
a unified way, the global code is moved to its
own RequestHandler for modules.

Releases: master
Resolves: #65452
Change-Id: Ic1dedaf7d98b460739da9cb33dcbbf5772ed05d4
Reviewed-on: http://review.typo3.org/37430
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getters for $GLOBALS in TranslationStatusController 35/37435/2
Wouter Wolters [Sun, 1 Mar 2015 21:09:31 +0000 (22:09 +0100)]
[TASK] Introduce getters for $GLOBALS in TranslationStatusController

Resolves: #65441
Releases: master
Change-Id: Ic9e790d2b2db17e930558dbafe4f458af948fc9a
Reviewed-on: http://review.typo3.org/37435
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Introduce getters for $GLOBALS in PageRepository 36/37436/2
Wouter Wolters [Sun, 1 Mar 2015 21:52:18 +0000 (22:52 +0100)]
[TASK] Introduce getters for $GLOBALS in PageRepository

Resolves: #65442
Releases: master
Change-Id: I7493bbae4bee93c7e2957e1d458d22036249de36
Reviewed-on: http://review.typo3.org/37436
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move RemoveXSS to EXT:core 48/37448/3
Benjamin Mack [Mon, 2 Mar 2015 10:50:42 +0000 (11:50 +0100)]
[TASK] Move RemoveXSS to EXT:core

The external library RemoveXSS placed
within typo3/contrib/ is moved to EXT:core
and also loaded via composer in order
to avoid a require_once.

Additionally, some other changes in
the static composer class loader shipped
with typo3/contrib/vendor are updated
as well.

Resolves: #65450
Releases: master
Change-Id: I804754df10288924247f58dc93a8e46f9268aa3b
Reviewed-on: http://review.typo3.org/37448
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Prevent redirection loop for shortcuts 46/37446/2
Nicole Cordes [Mon, 2 Mar 2015 10:05:16 +0000 (11:05 +0100)]
[BUGFIX] Prevent redirection loop for shortcuts

This patch prevents the redirection to another page if the returned
URL is empty which would trigger a redirection loop.

Releases: master, 6.2
Resolves: #65447
Change-Id: Ida0fc65c83d32ca7ae45db2d02b87d7eb0c8d345
Reviewed-on: http://review.typo3.org/37446
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Move leftover code from cms to frontend 47/37447/2
Benjamin Mack [Mon, 2 Mar 2015 10:30:56 +0000 (11:30 +0100)]
[TASK] Move leftover code from cms to frontend

Leftover code that registers modules
that are located within EXT:frontend should
be moved from EXT:cms to EXT:frontend

Resolves: #65449
Releases: master
Change-Id: Icde91ae85eee74c5fc5492a7263afcd0bc85c82f
Reviewed-on: http://review.typo3.org/37447
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Introduced getter for $GLOBALS in backend/Classes/ContextMenu 44/37444/3
Michael Oehlhof [Sun, 1 Mar 2015 23:36:39 +0000 (00:36 +0100)]
[TASK] Introduced getter for $GLOBALS in backend/Classes/ContextMenu

- add getter for LanguageService
- add getter for BackendUser

Resolves: #65445
Releases: master
Change-Id: I985f9b0aa619ea7f90f35fe169122c26850a73df
Reviewed-on: http://review.typo3.org/37444
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Introduce unified RequestHandling for all requests 09/37409/5
Benjamin Mack [Sun, 1 Mar 2015 13:47:15 +0000 (14:47 +0100)]
[TASK] Introduce unified RequestHandling for all requests

The TYPO3 Bootstrap gets a new function run() to unify
existing entrypoints in FE, BE, CLI and Install Tool.

This way the "visible" part of the bootstrap is reduced
to solely using the new "run()" method, which resolves
to a proper RequestHandler depending on the following
constraints.

* Install Tool
* Frontend: eID
* Frontend: TSFE
* Backend: Regular request
* Backend: AJAX
* Command-Line (CLIkeys)

The interface behaves exactly like TYPO3 Flow.

Unlike Flow, the request handlers are currently hardcoded
inside the bootstrap, but can be extended later.

Each RequestHandler logic is currently put from the global
scope into the main "handleRequest()" method.

Further changes are the deprecation of init.php and
the streamlining of Backend requests, as well as diagram
of the bootstrap process.

Resolves: #65437
Releases: master
Change-Id: I3a2ffe60e59005955c5ef3d3c541b61de2b97526
Reviewed-on: http://review.typo3.org/37409
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make BaseViewHelper Compilable 31/37431/3
Anja Leichsenring [Sun, 1 Mar 2015 19:47:09 +0000 (20:47 +0100)]
[TASK] Make BaseViewHelper Compilable

Change-Id: If0d763b4fb79ffb1584ea5c60804af63d4da3d7b
Resolves: #65440
Releases: master
Reviewed-on: http://review.typo3.org/37431
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Make browser.php dispatched 32/37432/2
Wouter Wolters [Sun, 1 Mar 2015 19:56:05 +0000 (20:56 +0100)]
[TASK] Make browser.php dispatched

Use dispatching for browser.php

Resolves: #65289
Releases: master
Change-Id: I8edb2fb1182af39d5a87e8291e8b208067a70a9c
Reviewed-on: http://review.typo3.org/37432
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Use jQuery UI's "sortable" in page module 62/37262/4
Andreas Fernandez [Wed, 25 Feb 2015 10:11:56 +0000 (11:11 +0100)]
[TASK] Use jQuery UI's "sortable" in page module

Port the code to use jQuery UI's "sortable" instead of draggable and
droppable, which solves some issues:

- The element position is stored after dropping it, solving the
"hang" effect.
- In "Languages" view, the elements are now properly movable. Moving
the elements between languages, which is error prone, is now not
possible anymore (it was possible before, but it was not saved).

Resolves: #65311
Releases: master
Change-Id: I5af23e258e057eb8c855760bc2ad5fa6989e6686
Reviewed-on: http://review.typo3.org/37262
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Make AliasViewHelper Compilable 28/37428/3
Anja Leichsenring [Sun, 1 Mar 2015 18:45:05 +0000 (19:45 +0100)]
[TASK] Make AliasViewHelper Compilable

Change-Id: Ib3e5093902b5d2b46d4b2c6a3365abf8340da6ed
Resolves: #65438
Releases: master
Reviewed-on: http://review.typo3.org/37428
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Remove unused code in PageLayoutView.php 62/25662/9
Jan Helke [Fri, 30 Jan 2015 18:04:25 +0000 (19:04 +0100)]
[TASK] Remove unused code in PageLayoutView.php

Changing the backend view to use grid elements caused an ancient
piece of code in PageLayoutView.php to be never executed. In fact
an if statement in PageLayoutController.php always evaluates to
"FALSE" which lets the code in PageLayoutView.php never get
executed.

Change-Id: I4f97690b54efeb7659f86f1ef15fa8603e97f69b
Resolves: #53898
Releases: master
Reviewed-on: http://review.typo3.org/25662
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Cleanup EXT:viewpage JavaScript 67/35767/5
Benjamin Mack [Sun, 4 Jan 2015 11:11:21 +0000 (12:11 +0100)]
[TASK] Cleanup EXT:viewpage JavaScript

The Extension viewpage (Web => View)
is still using a mixture of ExtJS and jQuery.

In order to use the logic from the new
Storage API (which replaces the ExtJS Part
for this module) the whole JavaScript
was rewritten in RequireJS.

The shipped jquery-ui JavaScript file
is not necessary anymore, as it is
loaded from the contrib/ directory
as a AMD module (new version).

Resolves: #64103
Releases: master
Change-Id: Ic0cc1dd0eb56b0440a5d8c78c40ac2120aa0f215
Reviewed-on: http://review.typo3.org/35767
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Adjust INSTALL.md to TYPO3 CMS 7 29/37429/2
Wouter Wolters [Sun, 1 Mar 2015 18:47:21 +0000 (19:47 +0100)]
[TASK] Adjust INSTALL.md to TYPO3 CMS 7

Furthermore the copyright year is adjusted.

Resolves: #65439
Releases: master
Change-Id: I332321bd4e84c66e381140caacbd23ef381441e2
Reviewed-on: http://review.typo3.org/37429
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Make logout.php dispatched 11/37411/2
Wouter Wolters [Sun, 1 Mar 2015 13:50:48 +0000 (14:50 +0100)]
[TASK] Make logout.php dispatched

Use dispatching for logout.php

Resolves: #65291
Releases: master
Change-Id: Ic003ec6dda083f69da2aaf0373ad48ea3bf4f56f
Reviewed-on: http://review.typo3.org/37411
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] UnitTests for TranslateViewHelper 16/37416/8
Anja Leichsenring [Sun, 1 Mar 2015 15:19:46 +0000 (16:19 +0100)]
[TASK] UnitTests for TranslateViewHelper

The TranslateViewHelper has no unit tests so far.

Change-Id: Ib7bdedf7e64276fcfcb7280fafc5d48c860f21c8
Resolves: #65436
Releases: master
Reviewed-on: http://review.typo3.org/37416
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
4 years ago[BUGFIX] Let Scheduler handle storage indexing exception 56/37156/3
Francois Suter [Tue, 24 Feb 2015 09:05:43 +0000 (10:05 +0100)]
[BUGFIX] Let Scheduler handle storage indexing exception

The FileStorageIndexingTask should not handle exceptions itself.
Instead it should let them bubble up to let the Scheduler take
care of the reporting.

Resolves: #65248
Releases: 6.2, master
Change-Id: Ib29c20b40de8abd27869682c9f6d4479718d25f5
Reviewed-on: http://review.typo3.org/37156
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][BUGFIX] Respect interfaces as well when checking class existence 23/37423/2
Helmut Hummel [Sun, 1 Mar 2015 17:36:51 +0000 (18:36 +0100)]
[FOLLOWUP][BUGFIX] Respect interfaces as well when checking class existence

Add accidentally forgotten guard clause for case insensitivity.

Releases: master, 6.2
Resolves: #65434
Change-Id: I374a7201f3c5ef356883302fc0825f9a02ef0c30
Reviewed-on: http://review.typo3.org/37423
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Invalid reference count on storing new child records in FlexForm 45/37345/2
Oliver Hader [Sat, 28 Feb 2015 15:08:45 +0000 (16:08 +0100)]
[BUGFIX] Invalid reference count on storing new child records in FlexForm

If creating a new parent record that contains inline child
records as part of a FlexForm configuration, the resulting
reference count is the temporary "NEW..." identifier. The
expected result is to have the number of child references
in that case as well.

Resolves: #58307
Releases: master, 6.2
Change-Id: I36a4dd06a38ad5d9f197190658b97f8a3b5fa234
Reviewed-on: http://review.typo3.org/37345
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Respect interfaces as well when checking class existence 12/37412/2
Helmut Hummel [Sun, 1 Mar 2015 14:22:48 +0000 (15:22 +0100)]
[BUGFIX] Respect interfaces as well when checking class existence

As a backwards compatibility measure, the composer class loader
checked for class existence before requiring a class file, which
could only happen if wrong class name casing was used before.

We now enable this also for interfaces.

Releases: master, 6.2
Resolves: #65434
Change-Id: I6dc1dc6cbf8cb7018ceeff1eb881c80658c11e33
Reviewed-on: http://review.typo3.org/37412
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Streamline extension configuration 93/37093/6
Benjamin Kott [Sun, 22 Feb 2015 14:48:29 +0000 (15:48 +0100)]
[TASK] Streamline extension configuration

- make type color working again
- use wizard_colorpicker instead of farbtastic
- streamline styling with formengine

Releases: master
Resolves: #65427
Change-Id: Ib175a794521ee346341325757a76091b03c52326
Reviewed-on: http://review.typo3.org/37093
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT 38/37038/8
Andreas Allacher [Fri, 20 Feb 2015 09:23:40 +0000 (10:23 +0100)]
[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Change-Id: I92ef213d31c4d62ba797e2741d5a0beaa042c6b3
Resolves: #62280
Releases: master
Reviewed-on: http://review.typo3.org/37038
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Remove module URI storage in global variable 06/37406/2
Helmut Hummel [Sun, 1 Mar 2015 12:29:59 +0000 (13:29 +0100)]
[!!!][TASK] Remove module URI storage in global variable

Previously the URI to a module which was dispatched through mod.php was stored
in a global variable $GLOBALS['MCONF']['_']

In terms of cleanup of global variable usage and
module configuration cleanup, this functionality is removed without substitution.

Instead BackendUtility::getModuleUrl() API must be used now.

Releases: master
Resolves: #65432
Change-Id: Iad436056e96d2334357320278cd8243f0f975538
Reviewed-on: http://review.typo3.org/37406
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Code cleanup: ColorpickerController.php 04/37404/3
Michael Oehlhof [Sun, 1 Mar 2015 12:21:26 +0000 (13:21 +0100)]
[TASK] Code cleanup: ColorpickerController.php

backend/classes/Controller/Wizard/ColorpickerController.php
To get it "green" in PhpStorm several changes were made:

- set correct return type in PhpDoc comment
- makeInstance of GraphicalFunctions to call non-static function
  imageCreateFromFile
- change local variable names to lowerCamelCase

Resolves: #65431
Releases: master
Change-Id: I54182c8ed17423e1cbc1c97e424d92a58dd5e3a9
Reviewed-on: http://review.typo3.org/37404
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Code completion in t3editor behind operator 04/36804/2
Frederic Gaus [Tue, 10 Feb 2015 16:02:07 +0000 (17:02 +0100)]
[BUGFIX] Code completion in t3editor behind operator

Fix code completion in t3editor when substituing a value with
completed code behind a typoscript operator.

Change-Id: Id1fbb99aba850ee0787dba4b8562d0a22c119979
Resolves: #25594
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36804
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Check default storage first to find default upload folder 59/37159/2
Frans Saris [Tue, 24 Feb 2015 10:22:34 +0000 (11:22 +0100)]
[BUGFIX] Check default storage first to find default upload folder

Resolves: #65040
Releases: master, 6.2
Change-Id: I14d6d362db1796c90b03254f6339cb131f152a45
Reviewed-on: http://review.typo3.org/37159
Reviewed-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Tested-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Deprecate DataHandler property stripslashes_values 16/37316/4
Jigal van Hemert [Fri, 27 Feb 2015 10:11:36 +0000 (11:11 +0100)]
[CLEANUP] Deprecate DataHandler property stripslashes_values

The functionality is unnecessary and it's confusing when using
DataHandler that it must be explicitly set to FALSE to handle properly
prepared data. The only place in the core where it was set to TRUE only
handles integer values.

Releases: master
Resolves: #65381
Change-Id: I968fccc9311bb9ad5f9153217ecf84ff4777df4a
Reviewed-on: http://review.typo3.org/37316
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Code cleanup RenameFileController.php 98/37398/2
Michael Oehlhof [Sun, 1 Mar 2015 08:07:26 +0000 (09:07 +0100)]
[TASK] Code cleanup RenameFileController.php

backend/Classes/Controller/File/RenameFileController.php
To get it "green" in PhpStorm several changes are made:

- set correct parameter type in PhpDoc comment
- set correct return type in PhpDoc comment
- add getter for LanguageService
- add getter for DocumentTemplate

Resolves: #65426
Releases: master
Change-Id: I1794d12fed33ab06d460c043632139bc30682a76
Reviewed-on: http://review.typo3.org/37398
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make show_item.php dispatched 86/37186/8
Wouter Wolters [Tue, 24 Feb 2015 20:29:26 +0000 (21:29 +0100)]
[TASK] Make show_item.php dispatched

Use dispatching for show_item.php

Resolves: #65283
Releases: master
Change-Id: If70f513ecc50445ea67b7e68bf7cd1df44cbf013
Reviewed-on: http://review.typo3.org/37186
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] t3editor: Add code autocompletion for listNum 93/36793/4
Frederic Gaus [Tue, 10 Feb 2015 14:21:54 +0000 (15:21 +0100)]
[BUGFIX] t3editor: Add code autocompletion for listNum

Add code autocompletion for property listNum and property
preIfEmptyListNum in t3editor.

Resolves: #25732
Releases: master, 6.2
Change-Id: I13c15e2e262a926e8444d7f50933823b27cdcd9d
Reviewed-on: http://review.typo3.org/36793
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Introduced getters for $GLOBALS in ext:info_pagetsconfig 07/37307/4
Michael Oehlhof [Thu, 26 Feb 2015 23:53:11 +0000 (00:53 +0100)]
[TASK] Introduced getters for $GLOBALS in ext:info_pagetsconfig

Resolves: #65376
Releases: master
Change-Id: If06b63748fba645f7bdd4dce3938d313e598a1ae
Reviewed-on: http://review.typo3.org/37307
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move EXT:cms/layout/res/ files to correct location 93/37293/3
Wouter Wolters [Thu, 26 Feb 2015 21:06:57 +0000 (22:06 +0100)]
[TASK] Move EXT:cms/layout/res/ files to correct location

Resolves: #65296
Releases: master
Change-Id: I08a3c8b6f89c029efacad06e13ea137560370e43
Reviewed-on: http://review.typo3.org/37293
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Introduced getters for $GLOBALS in ext:func 06/37306/2
Michael Oehlhof [Thu, 26 Feb 2015 23:34:21 +0000 (00:34 +0100)]
[TASK] Introduced getters for $GLOBALS in ext:func

Resolves: #65375
Releases: master
Change-Id: I880f4f467e3a634cbabd375d13cb0e9f0029107c
Reviewed-on: http://review.typo3.org/37306
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate alias cObjects COBJ_ARRAY and CASEFUNC 79/37379/2
Benjamin Mack [Sat, 28 Feb 2015 21:02:11 +0000 (22:02 +0100)]
[TASK] Deprecate alias cObjects COBJ_ARRAY and CASEFUNC

The alias cObjects COBJ_ARRAY for COA and CASEFUNC
for CASE are moved to compatibility6.

Resolves: #65422
Change-Id: I419997c3b70d0dfd9e23d9bc67bf909295e4faff
Reviewed-on: http://review.typo3.org/37379
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Do not respect autoload info if core repo is composer root 73/37373/2
Helmut Hummel [Sat, 28 Feb 2015 20:33:18 +0000 (21:33 +0100)]
[TASK] Do not respect autoload info if core repo is composer root

Doing a composer install directly in typo3 source has been
a requirement for core development for a while and a convenient shortcut
to quickly set up a TYPO3 installation for executing tests for extensions.

Respecting the class loading information generated in that location is
unfortunate however as it would require editing of the core composer.json
if additional classes from the core should respected.

Instead of respecting this as valid composer autoload file location,
we always fall back to the hard coded and committed class loading info
if no autoload file of a composer distribution call is found.

Releases: master, 6.2
Resolves: #65420
Change-Id: I1953303c6d2b5b221017deb7d2d7a0b43e4d08bf
Reviewed-on: http://review.typo3.org/37373
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Allow file:// links in Element Browser 70/37370/2
Nicole Cordes [Sat, 28 Feb 2015 19:19:43 +0000 (20:19 +0100)]
[FOLLOWUP][BUGFIX] Allow file:// links in Element Browser

This patch allows the use of links with file scheme in typolink().

Releases: master, 6.2
Resolves: #65358
Change-Id: I25a8ca88637d1ecab4881127cf2228214b6c954a
Reviewed-on: http://review.typo3.org/37370
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][TASK] Move Media cObject and CTypes 77/37377/2
Benjamin Mack [Sat, 28 Feb 2015 20:52:45 +0000 (21:52 +0100)]
[FOLLOWUP][TASK] Move Media cObject and CTypes

Missed some removal of old classes,
also make sure that they are registered for FE and BE.

Resolves: #64719
Releases: master
Change-Id: I416d1a9fa19aacb5950e8f33e0e085b020f4d242
Reviewed-on: http://review.typo3.org/37377
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] SelectViewHelper must respect option(Value|Label)Field for arrays 09/36909/2
Alexander Schnitzler [Sat, 14 Feb 2015 16:32:28 +0000 (17:32 +0100)]
[BUGFIX] SelectViewHelper must respect option(Value|Label)Field for arrays

The SelectViewHelper tries to resolve the value and label
field as long as options are of type object, i.e. domain
objects but that functionality must also exist for arrays
because their structure is similar to objects.

Example:
<f:form.select
options="{items}"
optionValueField="uid"
optionLabelField="title"
/>

$items = array(
    0 => array(
        'uid' => 1,
        'title' => 'Foo'
    ),
);

Currently the view helper tries to use the array key as
value field (i.e. 0) and the array value (i.e. array) as
label and fails calling htmlspecialchars on the array.

This patch allows values to be arrays themselves and to
be treated like domain objects.

Resolves: #65073
Releases: master, 6.2
Change-Id: Ia803ceb38c1f7488d48863f5a6781b229def50c4
Reviewed-on: http://review.typo3.org/36909
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Andy Grunwald <andygrunwald@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move frontend registration from EXT:cms to EXT:frontend 68/37368/2
Benjamin Mack [Sat, 28 Feb 2015 18:56:46 +0000 (19:56 +0100)]
[TASK] Move frontend registration from EXT:cms to EXT:frontend

EXT:cms still registers logic that is completely placed
inside EXT:frontend (classes, content element wizards, tables, CTypes).

These leftovers are moved to EXT:frontend.

Resolves: #65418
Releases: master
Change-Id: I3919340de863a7b1c07149161d2ce758e42de4db
Reviewed-on: http://review.typo3.org/37368
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] General code cleanup in ext:rsaauth 03/37303/2
Wouter Wolters [Thu, 26 Feb 2015 22:50:46 +0000 (23:50 +0100)]
[TASK] General code cleanup in ext:rsaauth

Resolves: #65374
Releases: master
Change-Id: I64d942327a49d6e5cb6d292ee260b4c37b459374
Reviewed-on: http://review.typo3.org/37303
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Prevent wrong ref_index for fields with soft references 86/37086/2
Nicole Cordes [Thu, 19 Feb 2015 09:55:13 +0000 (10:55 +0100)]
[BUGFIX] Prevent wrong ref_index for fields with soft references

If you add a page link to a field which is defined as softrefs, the
ReferenceIndex creates an index to a FAL record if there exists a file
record with the page id. As file links are always prefixed with 'file:'
this patch adds a proper check before generating a file ref_index.

Because the functional tests of impexp extension still use a hardcoded
file path for the header_link field the patch corrects the value to
refer to a file.

Furthermore if you add a file or folder link, the field is referenced
twice for the FAL record. So we have to suppress the softreference for
those records.

Releases: master, 6.2
Resolves: #60226
Change-Id: I969224e2a291491cb7ece1f61b375071bf0eaebc
Reviewed-on: http://review.typo3.org/37086
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move media libraries to EXT:mediace 67/37367/2
Benjamin Mack [Sat, 28 Feb 2015 18:48:38 +0000 (19:48 +0100)]
[TASK] Move media libraries to EXT:mediace

Files related solely to the media Content Element
are moved from typo3/contrib/ to the
extension itself.

Resolves: #65417
Releases: master
Change-Id: I8223f204ccf35c4f4399760da90a90d6a7d1e46d
Reviewed-on: http://review.typo3.org/37367
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Add back button from info page to element browser wizard 48/36848/4
Stanislas Rolland [Wed, 11 Feb 2015 19:15:52 +0000 (14:15 -0500)]
[BUGFIX] Add back button from info page to element browser wizard

When using the element browser for image insertion in backend form
or in RTE, there should be some Back button on the Info page to go back
to the wizard form.
Currently, one has to close the window and start over.

Releases: master
Resolves: #55787
Change-Id: I909767feaacf260736707b3b28cb34efe2bf82e6
Reviewed-on: http://review.typo3.org/36848
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Escape regex chars when building sWordRegEx 28/37328/2
Alexander Stehlik [Fri, 27 Feb 2015 19:13:53 +0000 (20:13 +0100)]
[BUGFIX] Escape regex chars when building sWordRegEx

The submitted sword_list GET parameters are parsed through
preg_quote() when loaded into  TSFE->sWordRegEx to prevent
invalid regular expressions.

The initialization is moved to a seperate method
PageGenerator::initializeSearchWordDataInTsfe() and unit
tests are added.

Releases: master, 6.2
Resolves: #41728
Change-Id: Id96fd5e201c25b06001f7e1c7811d6c38239aafa
Reviewed-on: http://review.typo3.org/37328
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Allow file:// links in Element Browser 29/37329/2
Nicole Cordes [Fri, 27 Feb 2015 19:20:36 +0000 (20:20 +0100)]
[BUGFIX] Allow file:// links in Element Browser

Due to FAL checks it's not possible to link to a file:// resource as
external link. This patch checks for correct "file:" prefix for FAL
relations and allows the use of file:// as external link scheme.

Furthermore a Javascript error is resolved which prevents the closing
of the Element Browser in Chrome.

Releases: master, 6.2
Resolves: #65358
Change-Id: I706fd975654bf82a0830d9901f08ae9de7cc49bf
Reviewed-on: http://review.typo3.org/37329
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Browse for records in edit document popup works again 89/37089/4
Michael Oehlhof [Sun, 22 Feb 2015 02:01:01 +0000 (03:01 +0100)]
[BUGFIX] Browse for records in edit document popup works again

When editing a group in the edit document popup the browse for records
button was without function, this is now fixed.

Resolves: #65215
Releases: master
Change-Id: I1bed83669d8a62f193f6b92d3fd3a39f5250707f
Reviewed-on: http://review.typo3.org/37089
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Make edit button in FormEngine wizard work again 59/37359/2
Benjamin Mack [Sat, 28 Feb 2015 16:56:53 +0000 (17:56 +0100)]
[BUGFIX] Make edit button in FormEngine wizard work again

When clicking on the edit button wizard in FormEngine
(e.g. when editing a be_group inside the be_user record)
then there is a JS error preventing from opening a popup.

Resolves: #65415
Relates: #63846
Releases: master
Change-Id: Iafac6759054d0e2ce229b34b17b6a5312e1408df
Reviewed-on: http://review.typo3.org/37359
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Always load scriptaculous in FormEngine 60/37360/2
Benjamin Mack [Sat, 28 Feb 2015 17:01:59 +0000 (18:01 +0100)]
[BUGFIX] Always load scriptaculous in FormEngine

As the refactoring of FormEngine now always
includes the suggest JS code,
scriptaculous needs to be loaded all the time
as well for the time being (as long as scriptaculous
is still needed).

Resolves: #65416
Relates: #55575
Releases: master
Change-Id: I276448c7c0dc6745926eb18a0ffae49836c718f2
Reviewed-on: http://review.typo3.org/37360
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Streamline TS registration for sysexts 39/37239/3
Benjamin Mack [Wed, 25 Feb 2015 17:37:50 +0000 (18:37 +0100)]
[TASK] Streamline TS registration for sysexts

For historical reasons the "Static Template #43"
was "content.default" and the possibility to add
TypoScript after this default rendering was introduced
in order to have CTypes and plugins register their
TypoScript just after e.g. "content.default" or
"css_styled_content".

Since TYPO3 CMS 6.2 the preferred option is
called "defaultContentRendering" instead of
the magic number "43".

Some leftover parts in sysexts are replaced
with "defaultContentRendering", as well
as some more descriptive information on
how the legacy number exists.

Releases: master
Resolves: #65346
Change-Id: I7268ec9ee8454d1eb4b0fda9f12fdfb5cb191ba8
Reviewed-on: http://review.typo3.org/37239
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] File must use MIME type from index record 14/37214/2
Andreas Wolf [Wed, 25 Feb 2015 12:52:22 +0000 (13:52 +0100)]
[BUGFIX] File must use MIME type from index record

The MIME type is stored in a field "mimetype" in the drivers, while the
field is called "mime_type" in the database. As the file object deals
with both when retrieving the type, it must respect this mismatch.

Change-Id: I06882c4d77e38284a48f7f7d7527bfc1c535edf3
Resolves: #65335
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/37214
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Unification of function naming 23/36823/2
Frederic Gaus [Wed, 11 Feb 2015 09:56:58 +0000 (10:56 +0100)]
[CLEANUP] Unification of function naming

The usage of getBackendUser and getBackendUserAuthentication is mixed
up in the core. But at least in inheritance this should be consistent.

Rename ScheduleModuleController::getBackendUserAuthentication to
ScheduleModuleController::getBackendUser

Change-Id: Icf21b4565ed66d3dabaf1df2d62d6b022c07248c
Resolves: #64982
Releases: master
Reviewed-on: http://review.typo3.org/36823
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Rethrow Extbase scheduler task exceptions 85/36985/4
Mathias Brodala [Wed, 18 Feb 2015 08:10:37 +0000 (09:10 +0100)]
[BUGFIX] Rethrow Extbase scheduler task exceptions

This makes sure exception details thrown in Extbase scheduler tasks
can be shown by the Scheduler.

Resolves: #49071
Releases: master, 6.2
Change-Id: Ic703568715bf92523a9cbd0dcab6c5606ea278bb
Reviewed-on: http://review.typo3.org/36985
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Ensure new deep dirs don't contain double slashes 99/36399/8
Thomas Deuling [Fri, 30 Jan 2015 10:06:42 +0000 (11:06 +0100)]
[BUGFIX] Ensure new deep dirs don't contain double slashes

The method of GeneralUtility::mkdir_deep has two parameters, which are
concatenated. This could end up in a double slashes. To prevent that,
the parameters are modified to concat them with only one slash.

Additionally fix a Bug with double slash in FileStreamWrapper.

Resolves: #63920
Releases: master, 6.2
Change-Id: I2d15f6c33550f9045db9b7730f7b074ae54a18dc
Reviewed-on: http://review.typo3.org/36399
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Move Media cObject and CTypes to new extension 72/36572/5
Benjamin Mack [Mon, 2 Feb 2015 20:25:41 +0000 (21:25 +0100)]
[TASK] Move Media cObject and CTypes to new extension

In order to separate features and also consolidate code for specific
features into one place, a new system extension is created.

The extension "mediace" ships with the core (not installed by default)
for now but could be moved to TER in future releases.

Next steps are:
- move third-party files from typo3/contrib/ to EXT:mediace
- find a proper solution to move the MediaWizard provider
- (optionally) create a Update Wizard that checks if the system uses
   media or multimedia elements or the "multimedia" and install the extension automatically.

Change-Id: I312ba6c15fece3a1319de23c085790590a659755
Resolves: #64719
Releases: master
Reviewed-on: http://review.typo3.org/36572
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[!!!][TASK] Improve FormEngine and sub classes separation 65/37265/6
Christian Kuhn [Sat, 7 Feb 2015 20:19:13 +0000 (21:19 +0100)]
[!!!][TASK] Improve FormEngine and sub classes separation

This patch improves the separation of FormEngine and its sub
classes. Currently, all sub classes like single element and wizard
classes get an instance of the parent object to call various methods
and properties on them. This is very hard to refactor and the mesh
of call trees must be simplified to ease further refactoring and
improve maintainability of code.

This patch follows a divide & conquer approach:
* Methods only used by sub elements are moved to AbstractFormElement
* Properties FormEngine "knows" that are needed by element classes
  are given down in a data array during element instatiation to have
  a clear definition of what element classes know.
* Methods used by both FormEngine and sub classes that do not need
  an instance of FormEngine are moved to a static helper for now to
  reduce the amount of code in FormEngine and to mark certain areas
  as stateless.
* Class instances are not created on a global level anymore but
  created only in the scope where they are used
* Class instances injected by outer code are created internally
  for enabling the using code to be moved around.

All in all, this patch is mostly a preparation of defining a
fully separated structure with defined concerns for every sub class.

Most methods are moved around "as is" without changing functionality.
The only area that is refactored codewise is renderWizards().

There is still a nasty circular dependency between FormEngine,
FlexFormElement and InlineElement. This is not resolved by the patch,
but the surrounding code is now separated enough that this structure
could be refactored to a tree. This may follow with other patches.

This patch evolved on catharsis in branch formengine with 53 single
patches. Details can be looked up there, all single patches are
prefixed with [FormEngine].
https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine

Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
Releases: master
Resolves: #65357
Resolves: #63848
Resolves: #63849
Resolves: #63851
Resolves: #63853
Resolves: #63855
Resolves: #63857
Resolves: #63867
Resolves: #63868
Resolves: #63869
Resolves: #63870
Resolves: #63871
Resolves: #63872
Resolves: #63873
Resolves: #63874
Resolves: #63875
Resolves: #63877
Resolves: #63879
Resolves: #63880
Resolves: #63884
Resolves: #63885
Resolves: #63886
Resolves: #63887
Resolves: #63888
Resolves: #63890
Resolves: #63892
Reviewed-on: http://review.typo3.org/37265
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][TASK] Introduce getters for $GLOBALS in ext:setup 09/37309/2
Wouter Wolters [Fri, 27 Feb 2015 08:07:55 +0000 (09:07 +0100)]
[FOLLOWUP][TASK] Introduce getters for $GLOBALS in ext:setup

Resolves: #65372
Releases: master
Change-Id: I19d67cb8de220f25f74667bc39a5ca25c62c9500
Reviewed-on: http://review.typo3.org/37309
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:sys_action 05/37305/2
Wouter Wolters [Thu, 26 Feb 2015 23:08:14 +0000 (00:08 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:sys_action

Resolves: #65302
Releases: master
Change-Id: I215fc48ba7a1ac72e5be5c7357a2dd1557413d1f
Reviewed-on: http://review.typo3.org/37305
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:wizard_sortpages 37/37237/3
Wouter Wolters [Wed, 25 Feb 2015 17:15:51 +0000 (18:15 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:wizard_sortpages

Resolves: #65297
Releases: master
Change-Id: I7822f7aa48fc47940300467ea15422d5910767cb
Reviewed-on: http://review.typo3.org/37237
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Replace $GLOBALS[‘LANG’] with local property in ext:aboutmodules 97/37297/2
Michael Oehlhof [Thu, 26 Feb 2015 21:59:52 +0000 (22:59 +0100)]
[TASK] Replace $GLOBALS[‘LANG’] with local property in ext:aboutmodules

The local property languageService was only used in the indexAction.
In getModulesData and getSubModuleData there was still $GLOBALS[‘LANG’]
used, which is now changed to the local property languageService.

Resolves: #65368
Releases: master
Change-Id: Ibae1f34b7baa37d5693bdb8220f59c23c5bbac0c
Reviewed-on: http://review.typo3.org/37297
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Wrong signal class name in DatabaseTreeDataProvider 52/37252/15
Andreas Allacher [Thu, 26 Feb 2015 12:18:07 +0000 (13:18 +0100)]
[BUGFIX] Wrong signal class name in DatabaseTreeDataProvider

In the emitPostProcessTreeDataSignal of the DatabaseTreeDataProvider
the namespace for the SlotDispatcher to get the class name is wrong.
TableConfiguration is used twice here. This patch removes the doubled
namespace.

Releases: master
Resolves: #65360
Change-Id: Iff4f02ad63cc0f7ed6f0176a624aa293c5b1f4cc
Reviewed-on: http://review.typo3.org/37252
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getter for $GLOBALS['LANG'] in ext:context_help 98/37298/2
Michael Oehlhof [Thu, 26 Feb 2015 22:22:43 +0000 (23:22 +0100)]
[TASK] Introduce getter for $GLOBALS['LANG'] in ext:context_help

Resolves: #65369
Releases: master
Change-Id: Id488fb523c3b3dcc255f9c5d36af537abec267d0
Reviewed-on: http://review.typo3.org/37298
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:setup 01/37301/2
Wouter Wolters [Thu, 26 Feb 2015 22:32:34 +0000 (23:32 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:setup

Resolves: #65372
Releases: master
Change-Id: I631590fd7ccb108aded2cd9b957331d0891e0bf8
Reviewed-on: http://review.typo3.org/37301
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduced getter for $GLOBALS['LANG'] in ext:cshmanual 00/37300/2
Michael Oehlhof [Thu, 26 Feb 2015 22:33:28 +0000 (23:33 +0100)]
[TASK] Introduced getter for $GLOBALS['LANG'] in ext:cshmanual

Resolves: #65371
Releases: master
Change-Id: I6832775eda3c97229b764bdb258b5f3ffb813402
Reviewed-on: http://review.typo3.org/37300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:taskcenter 90/37290/2
Wouter Wolters [Thu, 26 Feb 2015 17:58:47 +0000 (18:58 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:taskcenter

Resolves: #65299
Releases: master
Change-Id: I3d3d9409e8994f9e61a487b02a132cc2db6c14df
Reviewed-on: http://review.typo3.org/37290
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move ext:sys_action/x-sys_action.png to correct location 89/37289/2
Wouter Wolters [Thu, 26 Feb 2015 17:54:00 +0000 (18:54 +0100)]
[TASK] Move ext:sys_action/x-sys_action.png to correct location

Resolves: #65301
Releases: master
Change-Id: I1f479807f684952d183bee7dcfa1a26897c33c1d
Reviewed-on: http://review.typo3.org/37289
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Align submit and action button's positions 38/36738/9
Felix Kopp [Sat, 21 Feb 2015 23:42:21 +0000 (00:42 +0100)]
[TASK] Align submit and action button's positions

Unify button positions as last column in tables and obvious submit
buttons underneath tables.

+ extension manager - switch state/action columns
+ scheduler - add button style to overview/info
+ func wizards sort - add submit button style

Resolves: #64926
Releases: master
Change-Id: If6a413d24c7af769284ac77d5764cced7b14f5bc
Reviewed-on: http://review.typo3.org/36738
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix cookie evaluation order 30/37030/6
Helmut Hummel [Sun, 22 Feb 2015 08:11:06 +0000 (09:11 +0100)]
[BUGFIX] Fix cookie evaluation order

The workaround added for IE8 in #22084 is not needed any more
and removed without substitution.

This avoids problems with multiple cookies which might be sent
due to nested instances or due to moving an instance around in the
folder hierarchy.

Resolves: #65187
Releases: master, 6.2
Change-Id: I75c3ebcde62257cef91837bf1fc8272e2dd77eac
Reviewed-on: http://review.typo3.org/37030
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Streamline ext_localconf.php / ext_tables.php of sysexts 40/37240/4
Benjamin Mack [Wed, 25 Feb 2015 18:33:36 +0000 (19:33 +0100)]
[TASK] Streamline ext_localconf.php / ext_tables.php of sysexts

In order to have a proper "way to do things" for extension
developers to look up registration process the following
parts were streamlined:

- Discouraged usage of the pseudo-global variable $_EXTKEY inside
  ext_localconf.php and ext_tables.php in favor of strings.
  For module registrations this part was left out for now as
  module registration will be streamlined separately.
- Use PHP5.5-style ::class in all occurrences instead of escaped
  strings for class names.
- Use $GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS.

Releases: master
Resolves: #65347
Change-Id: Iad03e42d38d65ae1483ef8190f755430ec617e45
Reviewed-on: http://review.typo3.org/37240
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Move EXT:cms/layout/wizard_backend_layout.png 09/37209/2
Wouter Wolters [Wed, 25 Feb 2015 12:01:13 +0000 (13:01 +0100)]
[TASK] Move EXT:cms/layout/wizard_backend_layout.png

Resolves: #65295
Releases: master
Change-Id: I072b91e1085bf4def958dc2fdf51a45a01995492
Reviewed-on: http://review.typo3.org/37209
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>