Packages/TYPO3.CMS.git
2 years ago[BUGFIX] FormEngine: returnUrl handling in inline 43/54543/3
Christian Kuhn [Fri, 3 Nov 2017 11:42:09 +0000 (12:42 +0100)]
[BUGFIX] FormEngine: returnUrl handling in inline

If an inline child, opened via ajax request, generates links leaving
the current records and opening a different one, on closing that
record the returnUrl is wrong and points to the url of the inline
ajax request.
The original return url of the main record is lost in the compile chain.
The returnUrl data provider sets $data['returnUrl'] to current url if not
otherwise given.
The patch hands over the original return url to the inline ajax controller
and lets it 'sink down' in the data compile chain to inline children so
the original return url is available when container or elements generate urls.
Additionally some broken 'returnURL' handling in InlineRecordContainer
and jsfunc.inline.js is cleaned up and removed.

Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5
Resolves: #82525
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54543
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kjeld Schumacher <k.schumacher@familie-redlich.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Set JS .editorconfig indent style to 2 spaces 34/54534/3
Tymoteusz Motylewski [Thu, 2 Nov 2017 15:23:25 +0000 (16:23 +0100)]
[TASK] Set JS .editorconfig indent style to 2 spaces

Resolves: #82900
Releases: master
Change-Id: I9e80f662981dc107d5bcd1e4fc28bcf9d2ff3b4a
Reviewed-on: https://review.typo3.org/54534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove unused ExtJS inclusion in System->Log 42/54542/2
Benni Mack [Fri, 3 Nov 2017 11:04:19 +0000 (12:04 +0100)]
[BUGFIX] Remove unused ExtJS inclusion in System->Log

Resolves: #82908
Releases: master
Change-Id: I96d661e294a737e36a084d4fa7423cc9257d1578
Reviewed-on: https://review.typo3.org/54542
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Deprecate ClientUtility 38/54538/4
Georg Ringer [Thu, 2 Nov 2017 19:37:19 +0000 (20:37 +0100)]
[TASK] Deprecate ClientUtility

The class ClientUtility is outdated and not used anymore and can be
deprecated.

Resolves: #82903
Releases: master
Change-Id: I616b4518bfebac8239ecca0b48cad1b037c0ba6d
Reviewed-on: https://review.typo3.org/54538
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Make SVG category tree use JS Icon API 68/54468/7
Tymoteusz Motylewski [Tue, 24 Oct 2017 11:27:08 +0000 (13:27 +0200)]
[TASK] Make SVG category tree use JS Icon API

This change make SVG tree expect icon identifier instead of icon source
in JSON node data.
Tree fetches icon source via JS Icon API only once per icon type.
This makes JSON response few times smaller.

Resolves: #82849
Releases: master
Change-Id: I8954837f68cee3bcc316bc56e30788e0d16c81d6
Reviewed-on: https://review.typo3.org/54468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Ensure cache tags are strings in workspaces 35/54535/2
Susanne Moog [Thu, 2 Nov 2017 15:24:33 +0000 (16:24 +0100)]
[BUGFIX] Ensure cache tags are strings in workspaces

On SQLServer you cannot insert integers in varchar
columns therefore the workspaces module ajax requests
are failing and you cannot use the module.

Cast the workspaceId to a string before using it as a
cache tag.

Change-Id: I0827dd6dddd9203fb7846934a034b826a515cdf3
Resolves: #82901
Releases: master
Reviewed-on: https://review.typo3.org/54535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Streamline ExtensionManagementUtility 23/54523/5
Benni Mack [Thu, 2 Nov 2017 05:54:47 +0000 (06:54 +0100)]
[!!!][TASK] Streamline ExtensionManagementUtility

The following functionality within this API class is marked as deprecated:
- siteRelPath()
- getExtensionKeyByPrefix()
- removeCacheFiles()
- second parameter of isLoaded()

Additionally, the following more strict rules apply now:
- addNavigationComponent() always requires an $extensionKey
- First parameter of addLLrefForTCAdescr() must not be empty
- addService() requires $serviceType and $info to be non-empty
- addPlugin() always requires an $extensionKey
- addStaticFile() throws exceptions if no extension key or path is set
- addTypoScript() expects $type to be either "setup" or "constants"

This is meant for extension developers using the current API more properly
than before.

Resolves: #82899
Releases: master
Change-Id: Ie5beddd4787da25f05f76ff37c6ec55a92257001
Reviewed-on: https://review.typo3.org/54523
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Add checks to ReflectionService to have correct return values 10/54510/6
Markus Klein [Tue, 31 Oct 2017 06:51:35 +0000 (07:51 +0100)]
[BUGFIX] Add checks to ReflectionService to have correct return values

Resolves: #82885
Releases: master, 8.7
Change-Id: I422f920187186fe83b6043f806fc1be9a16c8a25
Reviewed-on: https://review.typo3.org/54510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Migrate EXT:version into EXT:workspaces 14/54514/8
Benni Mack [Tue, 31 Oct 2017 20:24:43 +0000 (21:24 +0100)]
[!!!][TASK] Migrate EXT:version into EXT:workspaces

The concept of versioning records based on how it is
integrated into TYPO3 only makes sense in conjunction
with workspaces / stages. All other methods are not
supported. Thus, the logic of versioning of records
is moved into EXT:workspaces, making EXT:version
obsolete.

Checks against EXT:version is now handled against
"workspaces" throughout the core, with a fallback
within ExtensionManagementUtility::isLoaded().

Resolves: #82896
Releases: master
Change-Id: I8887b868892c8aa6c36db7d2841f6edf5476d6f7
Reviewed-on: https://review.typo3.org/54514
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[CLEANUP] Minor argument and comment cleanup 24/54524/2
Benni Mack [Thu, 2 Nov 2017 06:16:55 +0000 (07:16 +0100)]
[CLEANUP] Minor argument and comment cleanup

Some methods are called with default arguments, which can be omitted
when calling the methods.

Additionally, some PHPdoc comments was wrongly defined, which were
modified.

No change of behaviour.

Resolves: #82897
Releases: master
Change-Id: I1a22e7e3c4aff74f32c67bacb406a6a97d96b0d0
Reviewed-on: https://review.typo3.org/54524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Handle returnUrl for access module 04/54504/2
Markus Klein [Mon, 30 Oct 2017 19:56:30 +0000 (20:56 +0100)]
[BUGFIX] Handle returnUrl for access module

With this fix the access module again returns to the correct
page the user expects it to return to.

Resolves: #82883
Releases: master, 8.7, 7.6
Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184
Reviewed-on: https://review.typo3.org/54504
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Access module preselects owner/group when changed via AJAX 07/54507/2
Markus Klein [Mon, 30 Oct 2017 20:42:05 +0000 (21:42 +0100)]
[BUGFIX] Access module preselects owner/group when changed via AJAX

Resolves: #79915
Releases: master, 8.7, 7.6
Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6
Reviewed-on: https://review.typo3.org/54507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Remove global variable PARSETIME_START 17/54517/3
Benni Mack [Wed, 1 Nov 2017 11:34:37 +0000 (12:34 +0100)]
[!!!][TASK] Remove global variable PARSETIME_START

The global variable $GLOBALS['PARSETIME_START'] is removed,
as it has been superseded by $GLOBALS['TYPO3_MISC']['microtime_start']
for a long time already.

Resolves: #82893
Releases: master
Change-Id: Ic738ebb1ae4dd19aff426fcd32b8f7a3594ca2e4
Reviewed-on: https://review.typo3.org/54517
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Show allowed media sources in "Add media by URL" modal 37/54437/10
Gianluigi Martino [Wed, 18 Oct 2017 15:16:52 +0000 (17:16 +0200)]
[TASK] Show allowed media sources in "Add media by URL" modal

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Resolves: #82545
Releases: master, 8.7
Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034
Reviewed-on: https://review.typo3.org/54437
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
2 years ago[TASK] Unify spelling of "YAML" throughout the core 16/54516/3
Riccardo De Contardi [Wed, 1 Nov 2017 10:54:46 +0000 (11:54 +0100)]
[TASK] Unify spelling of "YAML" throughout the core

The correct spelling of the abbreviation is "YAML".
Standardized throughout the comments.

Resolves: #82459
Releases: master
Change-Id: I60847674b5dd8fc6222ae18c226f8ab584e3be84
Reviewed-on: https://review.typo3.org/54516
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Set _localizedUid in OriginColumnName 76/54376/5
Alexander Opitz [Tue, 7 Jul 2015 12:28:10 +0000 (14:28 +0200)]
[BUGFIX] Set _localizedUid in OriginColumnName

While saving an object the _localizedUid will be saved into the DB
column which is defined in TranslationOriginalColumnName.

Resolves: #66535
Releases: master,8.7
Change-Id: Ib23b97f90e805bd1107a3aac5b199f010ab231b3
Reviewed-on: https://review.typo3.org/54376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove obsolete IE6 condition in debug exception handler 15/54515/3
Benni Mack [Tue, 31 Oct 2017 20:40:55 +0000 (21:40 +0100)]
[TASK] Remove obsolete IE6 condition in debug exception handler

Some very lonesome IE6 check can be removed for
debugging purposes now, since IE6 support has been dropped
for a long time, and for debugging purposes especially this
use-case does not exist anymore.

Resolves: #82891
Releases: master
Change-Id: I166d5becea3b1c6a53e1a1e50dcb1731332229e6
Reviewed-on: https://review.typo3.org/54515
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile 89/53789/5
Helmut Hummel [Wed, 23 Aug 2017 11:01:36 +0000 (13:01 +0200)]
[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile

This follow-up patch ensures the link is properly generated when
generating it from a Backend context, e.g., when embedding an image
within CKEditor and when TYPO3 is within a subdirectory.

Change-Id: I9783344c70c8cdfd6660a69dff72b251b2964c16
Resolves: #81486
Releases: master
Reviewed-on: https://review.typo3.org/53789
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[BUGFIX] Move doctrine initalization to connect() method 32/54432/4
Alexander Stehlik [Wed, 18 Oct 2017 02:40:16 +0000 (04:40 +0200)]
[BUGFIX] Move doctrine initalization to connect() method

The event and custom type initalization of doctrine is moved
to an overwritten connect() method in the Connection class.

This prevents a premature establishment of a database connection
by calls to getDatabasePlatform().

This fixes the page unavailable during the connectToDB() in
the Frontend request handling.

Change-Id: Id6087002c7cbb9ed3938c4627d63b77515a7108f
Releases: master, 8.7
Resolves: #82795
Reviewed-on: https://review.typo3.org/54432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema 82/54482/2
Alexander Schnitzler [Fri, 27 Oct 2017 10:23:36 +0000 (12:23 +0200)]
[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema

Increase test coverage of ClassSchema and ReflectionService

Releases: master
Resolves: #57594
Resolves: #55654
Change-Id: If413dc0b428f94dffef13e1875e3a7af4f9939b7
Reviewed-on: https://review.typo3.org/54482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] EXT:form - really disable records overview in redirect finisher 35/54435/2
Mathias Brodala [Wed, 18 Oct 2017 07:38:42 +0000 (09:38 +0200)]
[BUGFIX] EXT:form - really disable records overview in redirect finisher

Resolves: #82786
Releases: master, 8.7
Change-Id: I9cdfbcd5e0f25b832ea546f1b8c70a9f544b31aa
Reviewed-on: https://review.typo3.org/54435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement 69/54469/4
Georg Ringer [Tue, 24 Oct 2017 14:37:27 +0000 (16:37 +0200)]
[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement

Catch another exception to avoid a breaking backend.

Resolves: #82850
Releases: master, 8.7
Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969
Reviewed-on: https://review.typo3.org/54469
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix foreign_table_where GROUP BY handling 73/54473/5
Wolfgang Klinger [Wed, 25 Oct 2017 10:39:31 +0000 (12:39 +0200)]
[BUGFIX] Fix foreign_table_where GROUP BY handling

Unpack the array elements before passing them on

Resolves: #82159
Releases: master, 8.7
Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0
Reviewed-on: https://review.typo3.org/54473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Show default site name in installation wizard 90/54490/2
Nicole Cordes [Sat, 28 Oct 2017 10:44:33 +0000 (12:44 +0200)]
[BUGFIX] Show default site name in installation wizard

Currently in step 4 the input box for the site name is empty. This patch
re-adds the default site name from FactoryConfiguration.php as initial
value.

Resolves: #82876
Releases: master
Change-Id: I391254cf7ae6e5f8aa45003035aebaf513e733d3
Reviewed-on: https://review.typo3.org/54490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[!!!][BUGFIX] Throw exception on invalid charset 71/54471/3
Mathias Brodala [Wed, 25 Oct 2017 07:45:08 +0000 (09:45 +0200)]
[!!!][BUGFIX] Throw exception on invalid charset

This gives users a clear hint if e.g. config.metaCharset contains
an invalid value instead of showing a blank page.

Change-Id: I9cdb37cc7e61af10e2d1985ef43f488e53b17a48
Resolves: #82852
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54471
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Ensure correct page is selected in page tree 91/54491/3
Helmut Hummel [Sat, 28 Oct 2017 10:35:24 +0000 (12:35 +0200)]
[BUGFIX] Ensure correct page is selected in page tree

There are several actions in the backend that should
trigger a certain page to be selected in the tree.

Among others these are: open documents toolbar, live search,
favorites.

Fix every scenario in which these actions are triggered
(e.g. page tree was already initialized or not), make
sure the desired page will always be selected and
properly store the selection in the various states
so that the selection persists tree refreshes.

In addition we ensure that the content frame will
be called with the correct id, if the module uses
the page tree as navigation component.

Releases: master, 8.7
Resolves: #82877
Change-Id: I1904c02b2246f01202c6607a9b718aebe0e33341
Reviewed-on: https://review.typo3.org/54491
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix usages of config.additionalHeaders 85/54485/4
Markus Klein [Fri, 27 Oct 2017 13:49:00 +0000 (15:49 +0200)]
[BUGFIX] Fix usages of config.additionalHeaders

Update some internal usages of config.additionalHeaders in tests
and other places to use the correct new syntax.

Resolves: #82871
Releases: master, 8.7
Change-Id: I44868a736751647c3aa62bd5dc29f0bce5588c10
Reviewed-on: https://review.typo3.org/54485
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add .tsconfig files to .editorconfig 93/54493/3
Peter Kraume [Sun, 29 Oct 2017 12:06:28 +0000 (13:06 +0100)]
[TASK] Add .tsconfig files to .editorconfig

Add definition for new TSConfig filetype .tsconfig to .editorconfig
file.

Change-Id: I3fd87abc8a8fe554692f61e548e37d4d02f74fa4
Resolves: #82879
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54493
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Flexform Form ID should not contain brackets 71/52771/7
Benjamin Serfhos [Thu, 11 May 2017 12:30:15 +0000 (14:30 +0200)]
[BUGFIX] Flexform Form ID should not contain brackets

Using brackets in flexform elements caused the javascript to be disabled
for the element.
While using a custom form id that can be used as HTML id="" this is
bypassed and fixes all javascript interaction.

Releases: master, 8.7
Resolves: #80908
Change-Id: I91f39b2fed61076b7139603fedc7b268546d64cd
Reviewed-on: https://review.typo3.org/52771
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[!!!][TASK] Remove DB field pages.no_cache 89/54489/4
Benni Mack [Fri, 27 Oct 2017 19:22:21 +0000 (21:22 +0200)]
[!!!][TASK] Remove DB field pages.no_cache

Having an option to completely disable the page rendering
cache available per page for editors is a real risk. This
option is largely hard to understand for an editor,
or an admin.

Integrators can still use `config.no_cache = 1` in
TypoScript on a condition basis to achieve the same
result.

Resolves: #82878
Releases: master
Change-Id: Ie6989acc0044a75e711253e4304f9b2b9d96a7e1
Reviewed-on: https://review.typo3.org/54489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Only fetch fileReferences from localized table if column exist 79/54479/5
Benjamin Kott [Thu, 26 Oct 2017 15:54:56 +0000 (17:54 +0200)]
[BUGFIX] Only fetch fileReferences from localized table if column exist

Only if a localized table also contains the requested column for file
references it will overlay the previous generated resultset.

Resolves: #82860, #67741
Releases: master, 8.7
Change-Id: I21fd60454123488ea312d6c6241f2622eab3f14c
Reviewed-on: https://review.typo3.org/54479
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions 67/54467/2
Markus Klein [Mon, 23 Oct 2017 16:12:35 +0000 (18:12 +0200)]
[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions

Also use the silent upgrade wizard to correct existing settings.

Resolves: #82721
Releases: master
Change-Id: I8d163799cf0d1acfaaa9c2589a70b932144b6dc6
Reviewed-on: https://review.typo3.org/54467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Avoid race condition in JS Icon API 70/54470/3
Tymoteusz Motylewski [Tue, 24 Oct 2017 19:46:44 +0000 (21:46 +0200)]
[BUGFIX] Avoid race condition in JS Icon API

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Resolves: #82851
Releases: master, 8.7
Change-Id: I4110f84d32c7f1856c1664a02d3c9a2ba59168a6
Reviewed-on: https://review.typo3.org/54470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Allow multiline strings in foreign_table_where 74/54474/3
Wolfgang Klinger [Wed, 25 Oct 2017 11:48:15 +0000 (13:48 +0200)]
[BUGFIX] Allow multiline strings in foreign_table_where

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Resolves: #82854
Releases: master, 8.7
Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2
Reviewed-on: https://review.typo3.org/54474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes 60/54460/2
Benni Mack [Fri, 20 Oct 2017 14:10:52 +0000 (16:10 +0200)]
[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes

Adds missing unit tests for this change.

Resolves: #82543
Releases: master, 8.7
Change-Id: Ica7f5c2f99dd991042e3c1166f7806534bf24421
Reviewed-on: https://review.typo3.org/54460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Do not force content_fallback to default page language 26/54426/7
Benni Mack [Tue, 17 Oct 2017 22:06:21 +0000 (00:06 +0200)]
[BUGFIX] Do not force content_fallback to default page language

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Resolves: #82794
Releases: master, 8.7
Change-Id: I90af4e9f9685ffc7db8c562207e3df08786c0ca9
Reviewed-on: https://review.typo3.org/54426
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] MenuProcessor doesn't accept necessary sub keys 44/54444/2
Thorben Nissen [Thu, 19 Oct 2017 08:28:43 +0000 (10:28 +0200)]
[BUGFIX] MenuProcessor doesn't accept necessary sub keys

Adds subproperty keys for levels, expandAll, includeSpacer and
titleField to $allowedConfigurationKeys.
Adds the subproperty keys also $removeConfigurationKeysForHmenu.

Resolves: #82810
Releases: master, 8.7
Change-Id: Idd2e50b0b7a203ce0a0ecc490199bdf5305bef47
Reviewed-on: https://review.typo3.org/54444
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Introduce new @import syntax for TS includes 46/54446/6
Benni Mack [Thu, 19 Oct 2017 14:27:16 +0000 (16:27 +0200)]
[FEATURE] Introduce new @import syntax for TS includes

The original '<INCLUDE_TYPOSCRIPT...>' syntax is hard to understand,
error-prone and overloaded with features.

This patch introduces a new way to include files based on SymfonyFinder
and simple logic to allow to include files or folders:

The following syntax (leaned towards SASS imports) is added:
Imports one file:

- @import 'EXT:myext/Configuration/TypoScript/myfile.typoscript'

Imports all files in a folder (always sorted by name):
- @import 'EXT:myext/Configuration/TypoScript/*'
- @import 'EXT:myext/Configuration/TypoScript/'

Imports all files ending with ".typoscript":
- @import 'EXT:myext/Configuration/TypoScript/*.typoscript'

Automatically adds '.typoscript' file ending and includes setup.typoscript
- @import 'EXT:myext/Configuration/TypoScript/setup'

This is all done with Symfony Finder to find the files.

Resolves: #82812
Releases: master
Change-Id: I4b64a087ef8c6aa85063c19c1882c9ed3448d9b5
Reviewed-on: https://review.typo3.org/54446
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[FEATURE] TCA: Allow label in palette array 49/54449/3
Christian Kuhn [Thu, 19 Oct 2017 22:34:20 +0000 (00:34 +0200)]
[FEATURE] TCA: Allow label in palette array

Allow 'label' within the 'palettes' array in TCA next
to 'showitem'. This defines a default label rendered as
the palette label in FormEngine if not overridden in
a 'types' definition like '--palette--;labelReference;thePalette'.

The patch introduces this feature in PaletteAndSingleContainer
of FormEngine code and adapts core TCA definitions to introduce
the default labels for palettes.

This makes the 'types' definitions shorter and much better readable
and gives the core an opportunity to steer the labels for palettes
which are often re-used by extension authors.

Change-Id: I185340d4e037d713eebbb6cd676287e6fe85705b
Resolves: #82826
Releases: master
Reviewed-on: https://review.typo3.org/54449
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Allow longer file-endings in typoscript directory includes 43/54443/3
Mathias Schreiber [Wed, 18 Oct 2017 23:13:52 +0000 (01:13 +0200)]
[BUGFIX] Allow longer file-endings in typoscript directory includes

Directory includes now allow more liberal substrings to include files
not only based on their extension (*.typoscript) but based on the last
part of their filename (*.setup.typoscript).

Resolves: #82543
Releases: master, 8.7
Change-Id: Ic2111b98a6e3935b542addfd712f4256aa40f888
Reviewed-on: https://review.typo3.org/54443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Scheduler: Drop "use atd" based execution 55/54455/2
Christian Kuhn [Fri, 20 Oct 2017 11:05:12 +0000 (13:05 +0200)]
[!!!][TASK] Scheduler: Drop "use atd" based execution

The feature to execute scheduler tasks via the "at daemon"
on unix found extremely little use in the wild and is
dropped from the core.

The implementation is rather clumsy, too, so we take
the opportunity to just drop this feature.

Change-Id: Ia3786953c41580ef6ea3b3c3ee21c1a82cab3dcd
Resolves: #82832
Releases: master
Reviewed-on: https://review.typo3.org/54455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix adding avatars to user profile 51/54451/2
Susanne Moog [Fri, 20 Oct 2017 10:07:05 +0000 (12:07 +0200)]
[BUGFIX] Fix adding avatars to user profile

Check opener for null before usage.

Change-Id: I1ed9ac13bab5b76ef5ed8a24c04b07f9dd6d7f85
Resolves: #82829
Releases: master
Reviewed-on: https://review.typo3.org/54451
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Show upload files button in filelist options if folder 45/54345/4
Gianluigi Martino [Tue, 10 Oct 2017 06:24:27 +0000 (08:24 +0200)]
[TASK] Show upload files button in filelist options if folder

At the moment there is only a clickmenu entry to upload files
without entering the folder. With this patch the uploads files button is
also listed as button in option list.

Resolves: #82711
Releases: master, 8.7
Change-Id: Ice84d96a8ee5fad8dbcb9dbc728312ebb63df720
Reviewed-on: https://review.typo3.org/54345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool extension scanner .rst file core version 50/54450/2
Christian Kuhn [Fri, 20 Oct 2017 09:58:13 +0000 (11:58 +0200)]
[BUGFIX] Install tool extension scanner .rst file core version

The core version indicator in the extension scanner of the install
tool on reST files is broken on windows OS since path is split by
/ instead of \. Use DIRECTORY_SEPARATOR to fix this.

Change-Id: I57928468c1a4cae2a439bd55b00874d13f3569dc
Resolves: #82830
Releases: master
Reviewed-on: https://review.typo3.org/54450
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Add renderType to select 47/54447/2
Susanne Moog [Thu, 19 Oct 2017 21:24:20 +0000 (23:24 +0200)]
[BUGFIX] Add renderType to select

Add missing renderType for select box in form
flexform.

Change-Id: I58ade2720cf763cf26fc1d1e74457044ddfa054f
Resolves: #82825
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54447
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update friendsofphp/php-cs-fixer to latest version 42/54442/3
Wouter Wolters [Wed, 18 Oct 2017 21:13:46 +0000 (23:13 +0200)]
[TASK] Update friendsofphp/php-cs-fixer to latest version

Resolves: #82806
Releases: master,8.7
Change-Id: I071c114db90b292936f5c3fd76c7ac74fd52bd60
Reviewed-on: https://review.typo3.org/54442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable 45/54445/4
Susanne Moog [Thu, 19 Oct 2017 12:49:50 +0000 (14:49 +0200)]
[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable

Add new tests for fetchPagesWithVersionsInTable and correct comments.

Change-Id: I2fe08656ecddf3f7391e6012bb969dd85c2cfb24
Resolves: #82811
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Delete unavailable "recently switched to" users from UC 33/54433/7
Andreas Fernandez [Wed, 18 Oct 2017 06:57:41 +0000 (08:57 +0200)]
[BUGFIX] Delete unavailable "recently switched to" users from UC

If a user who appears in the "Recently switched to" list became
unavailable for some reason, only the placeholder avatar was rendered,
giving a slight hint of life in the past.

Such users are now deleted from UC and do not appear in the list anymore.
Furthermore, the section label was slightly modified to be more
understandable.

For performance reasons, only one query is triggered now and sorting is
done based on the array of UIDs stored in UC.

Resolves: #82796
Related: #80581
Releases: master
Change-Id: Ieff8a779639f277de1c0cb7feaa0fe2b82bd97c5
Reviewed-on: https://review.typo3.org/54433
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove "content_doktypes" 38/54438/4
Benni Mack [Wed, 18 Oct 2017 18:41:21 +0000 (20:41 +0200)]
[!!!][TASK] Remove "content_doktypes"

The global option "content_doktypes" is
1. outdated (still contains doktypes 2 which was removed in 4.x)
2. only in use for Workspace Preview Links and Frontend Editing to query page trees

However, the idea was to disallow content editing (QuickEdit) and skip
search of other doktypes for simple DB search (removed in TYPO3 v7)

This is not the case anymore and nowadays a hidden feature which is only
10% implemented, and just another tedious option bloating the system.

The option has been removed and also cleaned via SilentConfigurationUpgradeService.

Resolves: #82803
Releases: master
Change-Id: I4ca868f721142d2ac9f1de0c1a7bccc33086989b
Reviewed-on: https://review.typo3.org/54438
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Move AjaxLoginHandler to AjaxLoginController 41/54441/2
Benni Mack [Wed, 18 Oct 2017 21:02:19 +0000 (23:02 +0200)]
[TASK] Move AjaxLoginHandler to AjaxLoginController

The AjaxLoginHandler which does AJAX logic for login timeouts is be moved
to the proper location, as it is a controller.

A class alias is in place.

Resolves: #82805
Releases: master
Change-Id: I6a9fed6236d6d82150dec2ac7c2ce61bd194b8ec
Reviewed-on: https://review.typo3.org/54441
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove style attribute in LiveSearch 39/54439/2
Andreas Fernandez [Wed, 18 Oct 2017 19:49:36 +0000 (21:49 +0200)]
[BUGFIX] Remove style attribute in LiveSearch

Currently, `beforeRender` removes some inline CSS so adjust the layout
of the suggest list. If the first search has no result, the layout is
broken because `beforeRender` is not called in case there are no results.

This patch removes the style attribute as early as possible.

Resolves: #82757
Releases: master, 8.7
Change-Id: I844b81aca43bd469dfdbb46516366f4786d0935f
Reviewed-on: https://review.typo3.org/54439
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] CKEditor: Make link editable 15/54415/3
Christoph Lehmann [Tue, 17 Oct 2017 14:37:06 +0000 (16:37 +0200)]
[BUGFIX] CKEditor: Make link editable

Fixes the TypeError

htmlspecialchars() expects parameter 1 to be string, null given

Resolves: #82787
Releases: master,8.7
Change-Id: I38a689022ed45c34a8ae78c046abe51803eb0f4c
Reviewed-on: https://review.typo3.org/54415
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Allow setting translateToMessage to empty 29/54429/3
Susanne Moog [Tue, 17 Oct 2017 23:06:30 +0000 (01:06 +0200)]
[BUGFIX] Allow setting translateToMessage to empty

Unsetting TCEMAIN.translateToMessage was not possible
due to a default fallback to a hardcoded string in
data handler.

This patch sets the default via PageTSConfig and
simplifies the condition / fallback logic.

Change-Id: Ie06410126a83de0e158c43cbfd6ee3d45176c363
Resolves: #82523
Releases: master
Reviewed-on: https://review.typo3.org/54429
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:indexed_search: Dont add stat record for empty search 96/53396/3
Daniel Goerz [Tue, 4 Jul 2017 12:07:24 +0000 (14:07 +0200)]
[BUGFIX] EXT:indexed_search: Dont add stat record for empty search

Resolves: #81786
Releases: master, 8.7
Change-Id: I1bc5e93fdfb3a1068a09ae37c47e51b1811d58b5
Reviewed-on: https://review.typo3.org/53396
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Update tstamp on inline relation addition 23/54423/2
Susanne Moog [Tue, 17 Oct 2017 21:05:45 +0000 (23:05 +0200)]
[BUGFIX] Update tstamp on inline relation addition

If in a record with an inline relation a new relation
is added and nothing else is changed the timestamp
was not updated.

The logic to update the timestamp has now been added
to the remapStack processing.

Change-Id: I2eae7d1fb54b21dddc6e3609b1585ba484980b06
Resolves: #82576
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54423
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Localization State does not properly sanitize and enrich 22/54422/3
Oliver Hader [Tue, 17 Oct 2017 20:59:31 +0000 (22:59 +0200)]
[BUGFIX] Localization State does not properly sanitize and enrich

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
* localization state could contain fields that were not defined in TCA
  having support for the `allowLanguageSynchronization` setting
* state values different than `custom`, `source` or `parent` have not
  been overridden by the default `parent` value

Resolves: #82793
Releases: 8.7, master
Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694
Reviewed-on: https://review.typo3.org/54422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - "label" is not set for the FormDefinition class 27/54227/2
Ralf Zimmermann [Thu, 28 Sep 2017 08:09:57 +0000 (10:09 +0200)]
[BUGFIX] EXT:form - "label" is not set for the FormDefinition class

Set the "label" property for the root form element
TYPO3\CMS\Form\Domain\Model\FormDefinition

Resolves: #82573
Releases: master,8.7
Change-Id: I57c45765e4af91da6094f8f7a469a1df2f6da1f5
Reviewed-on: https://review.typo3.org/54227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Sonja Großewinkelmann <s.grossewinkelmann@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make ReferenceIndex caching optional 84/53384/5
Benni Mack [Mon, 3 Jul 2017 13:21:03 +0000 (15:21 +0200)]
[BUGFIX] Make ReferenceIndex caching optional

The runtime caches used in the ReferenceIndex class
added in TYPO3 8.7.2 should not be added by default
but included on a per-runtime basis when extensions
would use the ReferenceIndex. Otherwise this issue
might lead to side-effects.

For master/9.0 the caches are enabled by default.

Relates: #78634
Resolves: #81771
Releases: master, 8.7
Change-Id: If7ca173d93c05658bce5f57c38842555a439d2ea
Reviewed-on: https://review.typo3.org/53384
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add parseFunc handling to pre tags 19/54419/2
Susanne Moog [Tue, 17 Oct 2017 18:22:54 +0000 (20:22 +0200)]
[BUGFIX] Add parseFunc handling to pre tags

Pre tags are currently not passed through parseFunc
resulting in non-parsed t3:// links in the frontend.

As <pre> tags allow links (and other tags) inside, we
should parse them, too.

Change-Id: I5647f02b0d93b05ecaed8297c794b91255ea6d54
Resolves: #82789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Refresh iconElement after its content has been replaced 58/53258/5
Nikita Hovratov [Sun, 18 Jun 2017 22:46:57 +0000 (23:46 +0100)]
[BUGFIX] Refresh iconElement after its content has been replaced

The variable iconElement refers now correctly to the original jQuery
object and is really reverted to the old class as the comment implies.

Resolves: #82624
Releases: master, 8.7
Change-Id: I13615bbee6d5148fe940bac49b72c2766c0a1de7
Reviewed-on: https://review.typo3.org/53258
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Replace ClassInfo with ClassSchema 81/54381/23
Alexander Schnitzler [Thu, 12 Oct 2017 14:58:33 +0000 (16:58 +0200)]
[!!!][TASK] Replace ClassInfo with ClassSchema

Extbase came along with two main caches for reflection data.
extbase_reflection and extbase_object. The latter mostly stored
information that were relevant to the dependency injection, like
inject methods and properties and constructor parameters. The
information was gathered by actual reflection and by analysing
doc blocks of properties and methods.

extbase_reflection stored similar reflection and doc block data
about objects but mainly for the parts outside dependency injection.
For example, the validation resolver used it to identify @validate
tags, the ActionController used it to identity which properties not
to validate. The ORM also used it a lot to find annotated types via
@var and so on.

There were a few issues with these two approaches:

- A lot of redundant data was fetched
- Data was fetched multiple times at different locations
- The extbase_reflection cache was stored each plugin seperately,
  resulting in a lot of redundant cache data for each plugin cache
- At a lot of places, the reflection service was used to reflect
  objects, but the data wasn't cached or taken from a cache resulting
  in performance drawbacks

This patch solves these issues with several approaches:

- The extbase_object cache has been removed completely and all
  necessary information about objects, mainly @inject stuff, is
  now fetched from the ReflectionService as well.
- The ReflectionService does still create ClassSchema instances
  but these were improved a lot. All necessary information is now
  gathered during the instantiation of ClassSchema instances. That
  means that all necessary data is fetched once and then it can be
  used everywhere making any further reflection superfluous.
- As runtime reflection has been removed completey, along with it
  several reflection classes, that analyzed doc blocks, have been
  removed as well. These are no longer necessary.
- The extbase_reflection cache is no longer plugin based and will
  no longer be stored in the database in the first place. Serialized
  ClassSchema instances will stored in typo3temp.

Releases: master
Resolves: #57594
Resolves: #55654
Change-Id: I93b905c85c4f28775f014ca8b585347bf6f1e7d3
Reviewed-on: https://review.typo3.org/54381
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Use BE_USER->isAdmin() 14/54414/2
Benni Mack [Tue, 17 Oct 2017 11:02:48 +0000 (13:02 +0200)]
[TASK] Use BE_USER->isAdmin()

TYPO3 Core does not use isAdmin() API of BackendUsers
consistently, as there are some places where a direct
access to $BE_USER->[admin].

Resolves: #82783
Releases: master
Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826
Reviewed-on: https://review.typo3.org/54414
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move BackendController addInlineSettings calls to _construct 13/54413/3
Tymoteusz Motylewski [Tue, 17 Oct 2017 08:59:21 +0000 (10:59 +0200)]
[TASK] Move BackendController addInlineSettings calls to _construct

Move calls to addInlineSettings out of the foreach loop, and place them
together with other similar calls.

Resolves: #82781
Releases: master
Change-Id: Ia2269833f7649559a1552a9290773984bebcc102
Reviewed-on: https://review.typo3.org/54413
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Use LanguageService inside TSFE 99/52799/9
Benni Mack [Thu, 7 Sep 2017 08:06:31 +0000 (10:06 +0200)]
[TASK] Use LanguageService inside TSFE

TSFE does the same logic as $GLOBALS['LANG'] (= LanguageService) for
fetching labels and language files, but with a different language key.

However, LanguageService is not a singleton, so it _can_ be used
multiple times at the same request, so why not use the LanguageService
for labels based on config.sys_language, and the $GLOBALS['LANG'] record
based on the current backend user.

So, TSFE only acts as a wrapper for LanguageService instead of having
duplicate code.

A few now useless internal properties are dropped, some other
methods are deprecated:

- TSFE->LL_files_cache
- TSFE->LL_labels_cache

- TSFE->readLLfile()
- TSFE->getLLL()
- TSFE->initLLvars()

Resolves: #81217
Releases: master
Change-Id: Iae85ac2eda4d7f77960de2d66b9069f6017c31d8
Reviewed-on: https://review.typo3.org/52799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Cleanup DataHandler - again and again 08/54408/4
Benni Mack [Mon, 16 Oct 2017 16:24:53 +0000 (18:24 +0200)]
[TASK] Cleanup DataHandler - again and again

This patch straightens several areas to use proper API calls,
and separates bigger methods into smaller methods.

Resolves: #82778
Releases: master
Change-Id: Ibfa80589a026966f4cbd0f2e6e7e4062033b3ab8
Reviewed-on: https://review.typo3.org/54408
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Code cleanup in ModuleMenu.js 06/54406/3
Tymoteusz Motylewski [Mon, 16 Oct 2017 15:13:04 +0000 (17:13 +0200)]
[CLEANUP] Code cleanup in ModuleMenu.js

Adds some JS doc and renames few properties to make code more readable.

Resolves: #82775
Releases: master
Change-Id: I8cb66ee1d52be00ea6e556d369607aecc7e4e2fb
Reviewed-on: https://review.typo3.org/54406
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Enable backendlayouts/ tsConfig on doktype menu separator 10/53810/7
Riccardo De Contardi [Sat, 26 Aug 2017 15:54:02 +0000 (17:54 +0200)]
[TASK] Enable backendlayouts/ tsConfig on doktype menu separator

Adds to page with doktype=199 (spacer) the tab "Appereance" with palette
"backend layout" and the tab "Resources" with palette "TSConfig".

Resolves: #77892
Releases: master
Change-Id: I3c5a47fcc551858bc889a7fe127d241b0f961faf
Reviewed-on: https://review.typo3.org/53810
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove internal log method from ConditionMatcher 02/54402/2
Benni Mack [Mon, 16 Oct 2017 10:21:20 +0000 (12:21 +0200)]
[TASK] Remove internal log method from ConditionMatcher

ConditionMatcher has a log method which is never used.

Resolves: #82770
Releases: master
Change-Id: I8554f253260601a8511dacdbca3ddfc894be80bd
Reviewed-on: https://review.typo3.org/54402
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Clean up graphical functions library 18/54318/4
Benni Mack [Sun, 8 Oct 2017 12:29:23 +0000 (14:29 +0200)]
[!!!][TASK] Clean up graphical functions library

Properties which are only accessed inside of
GraphicalFunctions and should remain inside are marked
as protected, are migrated to arrays (to avoid inList calls
instead of in_array()), removed or renamed to remove
classic kasper's-style double negation namings.

Resolves: #82768
Releases: master
Change-Id: If45a9198c3a2979a6fe0a1619a9841bd37a2708e
Reviewed-on: https://review.typo3.org/54318
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Show the "Today" button in DateTimePicker 96/54396/4
Gianluigi Martino [Sun, 15 Oct 2017 12:40:44 +0000 (14:40 +0200)]
[TASK] Show the "Today" button in DateTimePicker

This patch enable the "Today" button on the bottom of the DateTimePicker.
Clicking the "Today" button will set the date and time to now.

Resolves: #82723
Releases: master, 8.7
Change-Id: I262e0206754b2a9e785a6f1184712ba8cc26ad12
Reviewed-on: https://review.typo3.org/54396
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Streamline ext_localconf.php and ext_tables.php 33/52533/32
Benni Mack [Fri, 28 Apr 2017 09:33:23 +0000 (11:33 +0200)]
[TASK] Streamline ext_localconf.php and ext_tables.php

The goal is to minimize TYPO3_MODE usage in ext_localconf and ext_tables and
provide a clear process for extension developers where to put what.

This extension streamlines the whole usage within all system extensions,
and documents the expected behaviour of all third-party extensions, which
will also be included in docs.typo3.org.

Resolves: #82692
Releases: master
Change-Id: Id83ff0dfc6198564443f2f42e273bcd4f6f25e3e
Reviewed-on: https://review.typo3.org/52533
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Cleanup DataHandler (again) 01/54401/4
Benni Mack [Mon, 16 Oct 2017 09:01:15 +0000 (11:01 +0200)]
[TASK] Cleanup DataHandler (again)

The following changes were made:

1. enableLogging is now only checked within the log methods (if no extra
CPU / DB requests were made in the if statements).

2. Introduce a getter for $GLOBALS['LANG'] instead of using the hard-coded
object (and using IF statements, although the comment on top of the
PHP class states that LanguageService MUST be initialized).

3. Simplify switch-cases / nested-if statement to a regular IF condition

4. Use Logger API instead of plain debug() calls

Resolves: #82769
Releases: master
Change-Id: Icd74057ac64ec8fc219c55b7996f766020fd5ad8
Reviewed-on: https://review.typo3.org/54401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Migrate `Utility` to TypeScript 51/54251/6
Andreas Fernandez [Sun, 1 Oct 2017 11:17:10 +0000 (13:17 +0200)]
[TASK] Migrate `Utility` to TypeScript

The RequireJS module `TYPO3/CMS/Backend/Utility` is migrated to
TypeScript. This patch marks the global object `TYPO3.Utility` as
deprecated. Any occurrence is migrated to properly use the module instead.

Resolves: #82609
Releases: master
Change-Id: Ic0deaa29074080edd71928891fd09c3fb2af63fd
Reviewed-on: https://review.typo3.org/54251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Show user who deleted a record in recycler 79/54379/3
Georg Ringer [Thu, 12 Oct 2017 11:20:24 +0000 (13:20 +0200)]
[FEATURE] Show user who deleted a record in recycler

Add the user who deleted a record to the recycler information and also
show the avatar of the user.

Resolves: #69340
Releases: master
Change-Id: Id7d86d737b2759c6746baefa4b60659b6e9527eb
Reviewed-on: https://review.typo3.org/54379
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
2 years ago[BUGFIX] Better error messages for FLUIDTEMPLATE object 73/37273/7
Georg Ringer [Wed, 20 Sep 2017 19:23:35 +0000 (21:23 +0200)]
[BUGFIX] Better error messages for FLUIDTEMPLATE object

When using FLUIDTEMPLATE with Typoscript "template.file = filename",
it will fail silently if filename does not point to a file.

Also check for template source when using Typoscript
"file = filename" in FLUIDTEMPLATE object.

Resolves: #65340
Releases: master
Change-Id: Id6aa148408cad14e49b65c0a9f4c7887cfb3fa16
Reviewed-on: https://review.typo3.org/37273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set 71/54171/11
Nicole Cordes [Tue, 19 Sep 2017 13:15:47 +0000 (15:15 +0200)]
[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set

This patch adds missing functional tests for
\TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction

Related: #82330
Releases: master, 8.7, 7.6
Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d
Reviewed-on: https://review.typo3.org/54171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Context menu is not completely visible in filelist with scrollbar 90/54390/2
Gianluigi Martino [Fri, 13 Oct 2017 06:31:56 +0000 (08:31 +0200)]
[BUGFIX] Context menu is not completely visible in filelist with scrollbar

If the foldertree in filelist is to long, the rightclick context menu on
the bottom of the window is not completly visible. With this patch the
position of the menu is calculated based on the windows width and height
and so completly visible.

Resolves: #82732
Releases: master, 8.7
Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d
Reviewed-on: https://review.typo3.org/54390
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] cast systemMaintainer values to int 83/54383/3
Frank Naegler [Thu, 12 Oct 2017 17:35:10 +0000 (19:35 +0200)]
[BUGFIX] cast systemMaintainer values to int

Resolves: #82751
Releases: master
Change-Id: Ie87cccc2d890ffaf93fe8558f2a67da82ee8c495
Reviewed-on: https://review.typo3.org/54383
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle 82/54382/3
Loek Hilgersom [Thu, 12 Oct 2017 16:38:35 +0000 (18:38 +0200)]
[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle

Resolves: #82749
Releases: master, 8.7
Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845
Reviewed-on: https://review.typo3.org/54382
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Clean up ext:lowlevel ConfigurationController 89/54389/2
Christian Kuhn [Thu, 12 Oct 2017 23:40:18 +0000 (01:40 +0200)]
[TASK] Clean up ext:lowlevel ConfigurationController

Modernize the code base of the lowlevel ConfigurationController:
* No more _GP usages
* Get rid of MOD_SETTINGS and friends
* Don't use BackendUtility::funcModule and other crude helpers
* Get and apply changes to be_user->uc directly
* Move last html pieces to view

Change-Id: I24af6c53b9c55c82e0e1fc1ee79de97768fd9b2c
Resolves: #82754
Releases: master
Reviewed-on: https://review.typo3.org/54389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Migrate EXT:backend Tabs.js to TypeScript 67/54367/3
Frank Naegler [Tue, 10 Oct 2017 22:18:45 +0000 (00:18 +0200)]
[TASK] Migrate EXT:backend Tabs.js to TypeScript

Resolves: #82604
Releases: master
Change-Id: I9b9ff38c635902f2713602955ad9a3d04734ec88
Reviewed-on: https://review.typo3.org/54367
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use strict flag in signalslot dispatcher 72/54372/3
Georg Ringer [Thu, 12 Oct 2017 07:03:30 +0000 (09:03 +0200)]
[BUGFIX] Use strict flag in signalslot dispatcher

To avoid exceptions with complex structures, the strict flag
must be used in the in_array check.

Resolves: #82736
Releases: master, 8.7, 7.6
Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957
Reviewed-on: https://review.typo3.org/54372
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Configuration->"Use regular expression" 77/54377/2
Christian Kuhn [Thu, 12 Oct 2017 12:43:20 +0000 (14:43 +0200)]
[BUGFIX] Configuration->"Use regular expression"

Setting / unsetting the checkbox "Use regular expression"
fails with JavaScript error "jumpToUrl is not defined".
Add that to the document body.

Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8
Resolves: #82746
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54377
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Rename ext:lowlevel/View to ext:lowlevel/Controller 75/54375/2
Christian Kuhn [Thu, 12 Oct 2017 11:11:02 +0000 (13:11 +0200)]
[TASK] Rename ext:lowlevel/View to ext:lowlevel/Controller

The two "view" classes are clearly controllers and are
renamed with this patch accordingly.

Change-Id: Ic1cdc405ae24b87aa6224cda79b7226ce5eeec64
Resolves: #82744
Releases: master
Reviewed-on: https://review.typo3.org/54375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] SchedulerModuleController: Don't extend BaseScriptClass 64/54364/4
Christian Kuhn [Tue, 10 Oct 2017 20:14:13 +0000 (22:14 +0200)]
[TASK] SchedulerModuleController: Don't extend BaseScriptClass

To further phase out BaseScriptTask "SOBE", the scheduler
controller class no longer extends it and copies left over
usages to itself.

A general cleanup is applied along with this patch:
* Hard code some general variables like "moduleName"
* Remove some duplicate class attributes
* Additional namespace usages

Change-Id: I937b66e0b59d65591547144763026dbbd2d6c5f0
Resolves: #82727
Releases: master
Reviewed-on: https://review.typo3.org/54364
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] ConfigurationView: Don't extend BaseScriptClass 65/54365/3
Christian Kuhn [Tue, 10 Oct 2017 20:43:53 +0000 (22:43 +0200)]
[TASK] ConfigurationView: Don't extend BaseScriptClass

To reduce BaseScriptClass "SOBE" usages, the lowlevel
controller "ConfigurationView" no longer extends this class
and inlines some of the detail methods into routing
target "mainAction".

Change-Id: Icc284f5a3b4f0f9d50482a9f8865b0d7d1c16f4f
Resolves: #82728
Releases: master
Reviewed-on: https://review.typo3.org/54365
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] DatabaseIntegrityView: Don't extend BaseScriptClass 66/54366/2
Christian Kuhn [Tue, 10 Oct 2017 21:18:15 +0000 (23:18 +0200)]
[TASK] DatabaseIntegrityView: Don't extend BaseScriptClass

To reduce BaseScriptClass "SOBE" usages, the lowlevel
controller "DatabaseIntegrityView" no longer extends this class
and inlines some of the detail methods into routing
target "mainAction".

Change-Id: I67b0bae5848607166d19988cb005c91301754413
Resolves: #82729
Releases: master
Reviewed-on: https://review.typo3.org/54366
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Properly detect record link dialog tab 69/54369/4
Stanislas Rolland [Wed, 11 Oct 2017 19:00:03 +0000 (15:00 -0400)]
[BUGFIX] Properly detect record link dialog tab

RecordLinkHandler->canHandleLink should check record identifier,
otherwise the element browser may open the wrong tab when multiple
record identifiers are configured.

Resolves: #82737
Releases: master, 8.7
Change-Id: Ie12c6d7484bdb51577dfe02a653e80fe1d7b63ea
Reviewed-on: https://review.typo3.org/54369
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Deprecate ConfigurationForm 62/54362/5
Christian Kuhn [Tue, 10 Oct 2017 17:38:01 +0000 (19:38 +0200)]
[TASK] Deprecate ConfigurationForm

The call tree of the extension manager "configuration form"
ext_conf_template.txt parser is a mess:
The ext:extensionmanager ConfigurationUtility calls ext:core
ConfigurationForm which is a class that extends ExtendedTemplateService
which extends TemplateService. The "TypoScript" a-like parsing then uses
class TypoScriptParser. This compiles to a huge list of dependencies.

The patch compiles this mess down to a series of methods within
ConfigurationUtility directly, effectively adding needed parts
of TypoScriptParser and ConfigurationForm as protected methods.
The class ends up with way less direct and indirect dependencies.

The various detail parsing methods are still messy and hard to follow,
but rewriting the parser heart does not really make sense since the
ext_conf_template.txt format will bite the dust sooner or later anyway
and having all in one place is already much better than before.
So putting some days of energy into rewriting these specific parts
of the TypoScript parsing did not seem to be worth it, even if it in
the end could probably solved with 1/4 of code.

Class ConfigurationForm is deprecated but could also be removed
as breaking patch later if anyone wants to refactor the remaining
ExtendedTemplateService and TemplateService classes in v9.

Note this patch is an intermediate step before the ConfigurationUtility
class form ext:em is moved into the install tool.

Change-Id: I62d9fafb6444d954e17c980358e6367a83b033b8
Resolves: #82725
Releases: master
Reviewed-on: https://review.typo3.org/54362
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update codemirror to 5.30 and drop codemirror-minified again 46/54346/4
Andreas Fernandez [Tue, 10 Oct 2017 06:17:59 +0000 (08:17 +0200)]
[TASK] Update codemirror to 5.30 and drop codemirror-minified again

The package `codemirror-minified` used as a drop-in replacement of
`codemirror` is not maintained well and is replaced with the original
package again. To still get the benefits of page loading speed, at least
the JavaScript files are compressed by our own toolchain now.

CSS can't get compressed now as the original copyright gets replaced by
our own "banner".

Resolves: #82713
Releases: master
Change-Id: Ic12a7e9e70c63f2c0ae322e470453fe056c99155
Reviewed-on: https://review.typo3.org/54346
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Record list: Fix condition for unlimited records 41/54341/4
Andreas Fernandez [Mon, 9 Oct 2017 13:36:31 +0000 (15:36 +0200)]
[BUGFIX] Record list: Fix condition for unlimited records

This patch fixes a condition that fails when a CSV export in the record
list is requested. The maximum limit of records is set, if `$iLimit` is
larger than 0 to avoid a `LIMIT 0` query.

Resolves: #82710
Related: #81651
Releases: master
Change-Id: I49779e4fa4b31e44d5457f90939e6f96a41e497b
Reviewed-on: https://review.typo3.org/54341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Correct fixture for metadata in impexp functional tests 52/54352/3
Tymoteusz Motylewski [Tue, 10 Oct 2017 14:23:28 +0000 (16:23 +0200)]
[BUGFIX] Correct fixture for metadata in impexp functional tests

Resolves: #82726
Releases: master, 8.7
Change-Id: I779dbf4cdecf931cae4f2734f561aa1c9eab4efb
Reviewed-on: https://review.typo3.org/54352
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Avoid corrupted session when IP changes 47/54347/3
Markus Klein [Mon, 9 Oct 2017 11:45:41 +0000 (13:45 +0200)]
[BUGFIX] Avoid corrupted session when IP changes

If the IP of the client changes and is not within the
lockIP range anymore a new session is now created.

Resolves: #82490
Releases: master, 8.7
Change-Id: I7dc5033318fa9eb1efc929af126b38cc9840e964
Reviewed-on: https://review.typo3.org/54347
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Franz Holzinger <franz@ttproducts.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Set correct image dimensions in impexp fixture data 50/54350/2
Tymoteusz Motylewski [Tue, 10 Oct 2017 12:13:50 +0000 (14:13 +0200)]
[BUGFIX] Set correct image dimensions in impexp fixture data

Fixture data for functional tests in impexp contains correct height
for one image now.

Resolves: #82722
Releases: master, 8.7
Change-Id: I3fea831a5a030eb525fabe9bbb6e891a3a722fd7
Reviewed-on: https://review.typo3.org/54350
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Workspaces: Always consider references 19/54319/5
Benni Mack [Sun, 8 Oct 2017 12:33:06 +0000 (14:33 +0200)]
[!!!][TASK] Workspaces: Always consider references

Previously, it was possible to disable the handling
of references / child-parent relations in workspaces
on publishing, due to legacy functionality this was
an option introduced back in v4.

The behaviour (option switch via TSconfig) was
enabled by default on all installations.

It automatically resolves dependencies
(= publishing dependencies in relations automatically),
having this option disabled could lead to side effects
in the past.

Resolves: #82701
Releases: master
Change-Id: I4f152fd337e4c405eaa0f1386601629a688a05d4
Reviewed-on: https://review.typo3.org/54319
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Only access FAL security checks when in Backend 15/54315/2
Benni Mack [Fri, 6 Oct 2017 15:34:52 +0000 (17:34 +0200)]
[BUGFIX] Only access FAL security checks when in Backend

The FAL security checks which adds additional checks for Backend Users
are currently placed within TYPO3_MODE === BE which applies to CLI as well.

In order to even use the FAL API via CLI, a user has to be authenticated (just for
browsing files). Therefore, the check needs to be handled via TYPO3_REQUEST_TYPE
which excludes symfony commands on CLI basis.

Additionally, the REQUEST TYPE checks are handled within the Slot and not
when to register the hook (see other cleanup patch as well).

Resolves: #82691
Releases: master, 8.7
Change-Id: I7b895a119a17ea166331eb1dbcb75e57fffbd388
Reviewed-on: https://review.typo3.org/54315
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] IRRE: Always consider "localizeChildrenAtParentLocalization" 26/54326/11
Benni Mack [Sun, 8 Oct 2017 15:59:23 +0000 (17:59 +0200)]
[!!!][TASK] IRRE: Always consider "localizeChildrenAtParentLocalization"

The TCA Inline behaviour option "localizeChildrenAtParentLocalization" is dropped.
This functionality is now always enabled.

A TCA migration wizard is removing the option.

On a side note, the removed functional tests when removing
"localizationMode=select" were re-added.

Resolves: #82709
Releases: master
Change-Id: Idad3443417bf08fc4c93fa6475079ac2fd779c1e
Reviewed-on: https://review.typo3.org/54326
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Popup content element id on the right side of "Record selector" 40/54340/2
Gianluigi Martino [Mon, 9 Oct 2017 12:53:49 +0000 (14:53 +0200)]
[TASK] Popup content element id on the right side of "Record selector"

On the left side of the "Record selector" window a popup with the content
element id is showing hovering the content element icon. With this patch
it works also on the right lower side icons in the same window.

Resolves: #82708
Releases: master, 8.7
Change-Id: Ib091f61b13923d787e94cb93e85257c39978dbb5
Reviewed-on: https://review.typo3.org/54340
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Raphael Graf <graf@netvertising.ch>
Tested-by: Raphael Graf <graf@netvertising.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Deprecate second argument of GeneralUtility::mkdir_deep() 23/54323/6
Benni Mack [Sun, 8 Oct 2017 13:16:10 +0000 (15:16 +0200)]
[TASK] Deprecate second argument of GeneralUtility::mkdir_deep()

The syntax is very confusing, and the second argument is not necessarily
needed - most of the TYPO3 Core code uses only the first argument.

In order to streamline the API the second method argument is deprecated
but still works as before.

Resolves: #82702
Releases: master
Change-Id: Ib2238ff90edf932f9410cf87c214e23d0a1c4826
Reviewed-on: https://review.typo3.org/54323
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep 17/54317/3
Joshua Westerheide [Sat, 7 Oct 2017 18:45:53 +0000 (20:45 +0200)]
[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep

Resolves: #82697
Releases: master, 8.7, 7.6
Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90
Reviewed-on: https://review.typo3.org/54317
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>