Packages/TYPO3.CMS.git
3 months ago[TASK] Use new subdomain for new translation server 42/62742/2
Georg Ringer [Wed, 18 Dec 2019 13:59:54 +0000 (14:59 +0100)]
[TASK] Use new subdomain for new translation server

Use the final subdomain localize.typo3.org instead of
beta-translation.typo3.org. The latter is still available
and will be removed at later time.

Resolves: #89988
Releases: master
Change-Id: Ic7188d9edea0bbd4753b136242d992d195196880
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62742
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Apply rector set php56 48/62448/10
Alexander Schnitzler [Sun, 1 Dec 2019 14:16:28 +0000 (15:16 +0100)]
[TASK] Apply rector set php56

    php bin/rector process

Releases: master
Resolves: #89807
Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Introduce functional test for RequestBuilder 80/62580/4
Alexander Schnitzler [Sun, 8 Dec 2019 17:16:49 +0000 (18:16 +0100)]
[TASK] Introduce functional test for RequestBuilder

The now introduced functional tests are a replacement
for the unit tests which were only possible by mocking
the hell out of the RequestBuilder.

Releases: master
Resolves: #89898
Change-Id: Iccbd768ab0842e29d4954755e8f34f62bdc564f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62580
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Speed up tests 47/62547/16
Benni Mack [Thu, 5 Dec 2019 18:57:55 +0000 (19:57 +0100)]
[TASK] Speed up tests

Some tests use "accessibleMock" (= eval() code) where
it is completely unnecessary as not even a mock is needed.

Resolves: #89974
Releases: master
Change-Id: I6d44a251e670ec97787a45b68b40e8f4bef2946f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62547
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Fix closure comparison in test 37/62737/3
Susanne Moog [Wed, 18 Dec 2019 07:26:55 +0000 (08:26 +0100)]
[TASK] Fix closure comparison in test

ExactValueMatching of Closures in Prophecy may
result in Comparison Failures causing the test
to fail in newer PHPUnit Versions. Instead of
an exact match of that closure, a type comparison
is enough - as calling the closure is tested via
following assertions.

Resolves: #89982
Releases: master, 9.5
Change-Id: I23ef94a291a07d02e0c8857a1aeaf14931406af0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62737
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Include .htaccess file in extension packages 82/62582/3
Georg Ringer [Mon, 9 Dec 2019 13:52:06 +0000 (14:52 +0100)]
[BUGFIX] Include .htaccess file in extension packages

Adopt the excludeForPackaging to include also .htaccess files in
extension downloads of extension manager.

Resolves: #89876
Releases: master, 9.5, 8.7
Change-Id: If5a00956165bab386a980bc897f5750a3ffc73da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[TASK] Remove redundancies in install tool ext conf template 48/62648/2
Claus Due [Mon, 16 Dec 2019 10:55:18 +0000 (11:55 +0100)]
[TASK] Remove redundancies in install tool ext conf template

This patch:

1. Removes a redundant usage of a "NoSpace" VH and
   the associated namespace import since there are no
   other usages.
2. Deletes the VH class since it is not used elsewhere.
3. Removes an always-true and therefore redundant "if"

Releases: master
Resolves: #89956
Change-Id: I943653e04fa731cdc4bdcbc8d6e32663e3ca30c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView 20/62720/2
Frank Naegler [Tue, 17 Dec 2019 09:53:24 +0000 (10:53 +0100)]
[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView

Resolves: #89005
Releases: master, 9.5, 8.7
Security-Commit: 82656cf8149d04f31b1441a03415b5e9a067c614
Security-Bulletin: TYPO3-CORE-SA-2019-026
Change-Id: If312a53b24d919439fa70f5df96be383876957a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62720
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator 19/62719/2
Frank Naegler [Tue, 17 Dec 2019 09:53:17 +0000 (10:53 +0100)]
[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator

Resolves: #89452
Releases: master, 9.5, 8.7
Security-Commit: d73e50f02afc5459f737282ede6cc70579fe7181
Security-Bulletin: TYPO3-CORE-SA-2019-025
Change-Id: I55afb17f4b1509a3dfc945e28e5d35671f6c28f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62719
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Avoid directory traversal on archive extraction 18/62718/2
Andreas Fernandez [Tue, 17 Dec 2019 09:53:08 +0000 (10:53 +0100)]
[SECURITY] Avoid directory traversal on archive extraction

The Extension Manager and Language Pack Manager receive Zip archives as
input from foreign sources and extract them on the disk. However, the
previous approach is considered insecure as the target directory is not
checked per file and directory traversal was possible.

This patch adds a new service class that handles the extraction of Zip
archives via PHP's internal ZipArchive class, which can handle such
cases on its own.

Resolves: #88764
Releases: master, 9.5, 8.7
Security-Commit: a02f19c73211a5f1c0286ab44bee27da9b73f026
Security-Bulletin: TYPO3-CORE-SA-2019-024
Change-Id: I701a577f54410344867b868409a38cc44339f976
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62718
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] XSS in file list through file extension 17/62717/2
Andreas Fernandez [Tue, 17 Dec 2019 09:52:59 +0000 (10:52 +0100)]
[SECURITY] XSS in file list through file extension

FAL currently filters invalid characters from file names stored by its
API. However, this sanitization took no effect when the file was placed
by e.g. uploads via FTP, which doesn't trigger FAL.

This patch adds a missing `htmlspecialchars` call when the file
extension is rendered and could not be sanitized before due to mentioned
circumstances.

Resolves: #88931
Releases: master, 9.5, 8.7
Security-Commit: 296c6a6723826b4ad2babbb1de5b9d23dfd256ea
Security-Bulletin: TYPO3-CORE-SA-2019-023
Change-Id: I24cbc623f6390944a608eadf3ebe7a13d294e0ae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62717
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Avoid XSS by correctly encoding typolink results 16/62716/2
Oliver Hader [Tue, 17 Dec 2019 09:52:50 +0000 (10:52 +0100)]
[SECURITY] Avoid XSS by correctly encoding typolink results

In order to avoid XSS through typolink, anchor text is encoded
correctly to be used in a HTML context. Fallback link texts of
links to pages are encoded per default in case lib.parseFunc
has not been configured.

Resolves: #88635
Releases: master, 9.5, 8.7
Security-Commit: b62f71c4e098156052ff33e775208981c2ef512b
Security-Bulletin: TYPO3-CORE-SA-2019-022
Change-Id: I76b0f06ad52a487e1aebc820531c11166ad45117
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62716
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent XSS in EXT:form error message output 15/62715/2
Frank Naegler [Tue, 17 Dec 2019 09:52:42 +0000 (10:52 +0100)]
[SECURITY] Prevent XSS in EXT:form error message output

Resolves: #88629
Releases: master, 9.5, 8.7
Security-Commit: df38c239aa9c627fb7b6f1c384d45ff0940d98fa
Security-Bulletin: TYPO3-CORE-SA-2019-021
Change-Id: Ib12dc0affe7f15f1869cff57ea09d9999a0d632a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62715
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Streamline frontend user password recovery process 90/62690/2
Oliver Hader [Sun, 15 Dec 2019 19:34:47 +0000 (20:34 +0100)]
[TASK] Streamline frontend user password recovery process

The ext:felogin recovery process is using a non-typesafe comparison
which might be exploited with a probability of 0.000000294% and is
storing the recovery token as plain MD5-hash in database.

In order to streamline the process non-typesafe comparison is using
PHP's hash_equals() method; for keeping backward compatibility just
HMAC-SHA1 is applied to the recovery token in database.

Since exploitations to this scenario are very unlikely (for a 50%
chance an attacker would have to trigger the creation of around
170 million recovery requests) it is not handled with a security
workflow - but using the public workflow.

Resolves: #89952
Releases: master, 10.2, 9.5, 8.7
Change-Id: Idcb7b7d6eb418124dc17f1707284b6abe8a8b63b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62690
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Don't import PHP class in ext_localconf.php 87/62687/3
Andreas Fernandez [Tue, 17 Dec 2019 06:17:50 +0000 (07:17 +0100)]
[BUGFIX] Don't import PHP class in ext_localconf.php

Resolves: #89970
Releases: master
Change-Id: I5b7e22c853993e7434c086c22a3898eefbe07899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62687
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Revert FolderCheck for clipboard actions 21/62321/2
Guido Schmechel [Wed, 13 Nov 2019 20:25:44 +0000 (21:25 +0100)]
[BUGFIX] Revert FolderCheck for clipboard actions

Due to a faulty query in #85425 it was no longer possible
to copy files at the clipboard multi-selection-mode.

This must be possible if the user has the permission to copy files,
but not to copy folders.

Resolves: #89669
Releases: master, 9.5
Change-Id: I1c26696a6c3886dd5669957cdce8ca472b17b577
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62321
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Ensure correct return values in Workspace middleware 51/62651/2
Benni Mack [Mon, 16 Dec 2019 11:21:18 +0000 (12:21 +0100)]
[BUGFIX] Ensure correct return values in Workspace middleware

When setting config.disablePreviewNotification = 1 in workspaces
context, the preview middleware returns "null", although the method
signature says it always requires a string return value.

Resolves: #89959
Releases: master, 9.5
Change-Id: Icdef1891989db2869c2351adb07e6b4778d25e09
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62651
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Simplify chunking of test-plan jobs 40/62640/3
Markus Klösges [Sat, 14 Dec 2019 15:01:59 +0000 (16:01 +0100)]
[TASK] Simplify chunking of test-plan jobs

To make the code for splitting all test-jobs into stages of equal size
simpler and easier to maintain, a helper class is introduced
that supports chunking two lists into equally sized chunks, while
ensuring that each chunk only contains a limited number of elements
from one of the lists.

Using this utility, the number of mssql jobs can easily be limited,
while keeping the spec-code easy to follow.

Releases: master, 9.5, 8.7
Resolves: #89948
Change-Id: I9e1677e19fb2ea6df7d9e964e8f772ffb7324ec8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Fix return value in command site:list 21/62621/5
Georg Ringer [Fri, 13 Dec 2019 14:06:17 +0000 (15:06 +0100)]
[BUGFIX] Fix return value in command site:list

Return 0 instead of null.

Resolves: #89936
Releases: master, 9.5
Change-Id: Ic3345975b60fca38537750c9617d68ba9d19cc3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62621
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[DOCS] Extend docs of DeleteUploads finisher 97/61997/5
Jonas Schwabe [Tue, 15 Oct 2019 07:48:43 +0000 (07:48 +0000)]
[DOCS] Extend docs of DeleteUploads finisher

Releases: master, 9.5
Resolves: #89416
Change-Id: I4565d846bb86077c3e03534416f3047e2f7f0ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61997
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[BUGFIX] Always allow dividers in TCA auth mode check 42/62342/5
Alexander Stehlik [Mon, 18 Nov 2019 19:10:01 +0000 (20:10 +0100)]
[BUGFIX] Always allow dividers in TCA auth mode check

This brings back the optgroups in the CType and list_type fields
for normal editors.

Additionally some tests for checkAuthMode are added.

Releases: master, 9.5
Resolves: #89707
Change-Id: Ib3e6dbf3598ad767910161225a31ad2db939b3d6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Rename method getName of TypoScriptConstants VH 41/62541/2
Claus Due [Thu, 5 Dec 2019 13:58:59 +0000 (14:58 +0100)]
[TASK] Rename method getName of TypoScriptConstants VH

The name "getName" will be reserved in Fluid 3.0 and is
ambiguous. This patch renames that method to become
"getFieldName" which is less ambiguous and conflict free.

Additionally the ViewHelper is changed so it no longer
accesses deprecated property AbstractViewHelper->
viewHelperVariableContainer, instead accessing the
ViewHelperVariableContainer via $this->renderingContext.

Resolves: #89861
Releases: master
Change-Id: Iea474625917293afe67326f765c6a77f7fbe9b73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62541
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Thin out SystemEnvironmentBuilder 28/62628/4
Benni Mack [Fri, 13 Dec 2019 18:28:41 +0000 (19:28 +0100)]
[TASK] Thin out SystemEnvironmentBuilder

This a pre-patch to clean up the functionality of the SystemEnvironmentBuilder,
which was originally introduced as part of the Bootstrap logic in 6.0.

However, a few cross-concerns can be cut in TYPO3 v10:
- Calling the deprecated GeneralUtility::presetApplicationContext() is not
needed anymore, as it can be populated on-demand when the deprecated
GeneralUtility::getApplicationContext() method is called via Environment API.
This way, the ApplicationContext initialization can be put directly in the
Environment API initialization call.
- The static "isFunctionDisabled" method with a nasty runtime cache is only
used in one place in backend, so does not belong to "building system environment",
and is therefore removed.
- The now unused "exitWithMessage" protected method is removed,
removing a dependency to the HttpUtility class.

Resolves: #89943
Releases: master
Change-Id: I31156b1a1ded306d99bcf2d51de43bc919a0b3e0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62628
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] Convert URLs with ampersands in Linkvalidator 34/62634/2
Sybille Peters [Sat, 14 Dec 2019 11:15:12 +0000 (12:15 +0100)]
[BUGFIX] Convert URLs with ampersands in Linkvalidator

The linkref functions return the URLs as they are displayed in the
BE form. This will return '&' as '&amp;' HTML entity.

Linkvalidator should correctly decode the HTML entity.

Resolves: #89488
Resolves: #89682
Releases: master, 9.5
Change-Id: I17b421354d45297423437373b92a93dfbe53d2d9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62634
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Remove incorrect slash in extension paths 26/62626/6
Ron Gebauer [Fri, 13 Dec 2019 16:14:48 +0000 (16:14 +0000)]
[DOCS] Remove incorrect slash in extension paths

An incorrect slash has been removed in multiple extension
paths. The slash could lead to exceptions (e.g. within the
form framework's `PersistenceManagerException` configuration),
as those paths cannot be resolved,

Additionally, a proper role has been added to some of
those paths.

Releases: master, 9.5
Resolves: #89942
Change-Id: I70f5e67d5cc7f58e66507242158e565cd8c70720
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62626
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Remove "Adding Your Own Content Elements" 41/62641/2
Sybille Peters [Sat, 14 Dec 2019 19:20:49 +0000 (20:20 +0100)]
[DOCS] Remove "Adding Your Own Content Elements"

Content has been migrated to "TYPO3 Explained"

Reduce the content to a stub and add link.

Resolves: #89949
Releases: master, 9.5, 8.7
Change-Id: I4c69c8a1f74bea223110b9b6a07e035a03183d87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62641
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Use correct data type for DependencyOrdering 10/62610/3
pfuju [Thu, 12 Dec 2019 15:47:59 +0000 (15:47 +0000)]
[DOCS] Use correct data type for DependencyOrdering

As the new additional file processors registration
also uses the DependencyOrderingService the value
of `before` must be an array instead of a string.

Releases: master
Resolves: #89931
Change-Id: I8eea65c56f68ae94cddb239ac9e08c18a59ee036
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62610
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Avoid controller methods on Fluid RenderingContext 39/62539/4
Claus Due [Thu, 5 Dec 2019 13:51:28 +0000 (14:51 +0100)]
[TASK] Avoid controller methods on Fluid RenderingContext

The getter/setter methods related to controller name
and action name will be removed in Fluid 3.0.

An equally valid solution is to specify the template
path and filename, which also avoids the lookup
logic in Fluid from running and further increases the
failsafe operation of this controller.

Resolves: #89859
Releases: master
Change-Id: I8a3422681bef4b8ada043877ffa3c57eba82d8be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62539
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Move target to general tab for pages of type External URL 33/62633/2
Benni Mack [Fri, 13 Dec 2019 22:21:30 +0000 (23:21 +0100)]
[TASK] Move target to general tab for pages of type External URL

To increase usability for editors when using External URL links,
the "target" field is moved right below the "Target URL" field.

In addition the Target URL field has an increased size, to match
the others.

Resolves: #79317
Releases: master
Change-Id: I9aec38780713df006f98be370e4fadd5c61118aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62633
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Adjust name for PageTitle API in documentation 25/62625/3
Stefan Neufeind [Fri, 13 Dec 2019 15:26:45 +0000 (16:26 +0100)]
[DOCS] Adjust name for PageTitle API in documentation

The funtionality was named titleTag before. But the new API is
called PageTitle API.

Resolves: #89940
Releases: master, 9.5
Change-Id: Idd42c5c5f53d999351c787ac7edb474795132f48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62625
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Mix test jobs in stages 35/62635/2
Anja Leichsenring [Sat, 14 Dec 2019 11:32:26 +0000 (12:32 +0100)]
[TASK] Mix test jobs in stages

In order to spread computing load more evenly trough the test plan,
stages receive a shuffled mix of all available jobs with a maximum
of 25 mssql related functional test jobs.

Resolves: #89946
Releases: master, 9.5, 8.7
Change-Id: I368530899c709bd93d455078606f978a2626679c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62635
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Name "default language" consistently 02/62602/3
Benni Mack [Thu, 12 Dec 2019 06:33:39 +0000 (07:33 +0100)]
[BUGFIX] Name "default language" consistently

When working with the "pages.l18n_cfg" bitset flag, there is an
option "default translation", which commonly refers to language
with sys_language_uid=0. In most other cases, also in various
documentation pieces, the naming is "default language" instead
of "default translation" which is more correct in this case.

All places are now properly named "default language"
and no "default translation" is there anymore, making the
functionality more consistent.

Resolves: #89924
Releases: master, 9.5
Change-Id: Ibe9ad9371615119eff7535cb45d0f25b858d04da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62602
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Remove unused imports 04/62604/3
Oliver Bartsch [Thu, 12 Dec 2019 09:55:01 +0000 (10:55 +0100)]
[TASK] Remove unused imports

Cleanup code by removing unused imports in various classes.

Also changes the corresponding ExtensionScanner tests because they
are counting the line numbers which changed by removing the imports.

Resolves: #89926
Releases: master, 9.5
Change-Id: I588a3aa778a342c6c1154bb431cd325497fd4d18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62604
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Mark guzzlehttp/guzzle >= 6.5.0 as conflict 06/62606/3
Benni Mack [Thu, 12 Dec 2019 10:21:59 +0000 (11:21 +0100)]
[BUGFIX] Mark guzzlehttp/guzzle >= 6.5.0 as conflict

Due to the INTL/ICU bug, which we
have seen on various places, Guzzle, which
does not cover our edge cases yet, ran
in the same issue as our Core versions earlier
in 2019.

See
https://github.com/guzzle/guzzle/issues/2448
https://github.com/guzzle/guzzle/pull/2454

For the time being, lets mark guzzle as
incompatible until Guzzle has solved the issue
and released a new version, so we can loosen
the conflict constraint.

Related: #87953
Resolves: #89904
Releases: master, 9.5, 8.7
Change-Id: If64fb9472d046f020c850cd0551beeaf78796b60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62606
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Apply thumbscrews to sqlserver 11/62611/5
Andreas Fernandez [Fri, 13 Dec 2019 07:53:02 +0000 (08:53 +0100)]
[BUGFIX] Apply thumbscrews to sqlserver

sqlserver is a special race that welcomes high memory servers as its
habitat. However, we are short on resources and need to offer a very
small amout of RAM for a living which already acts as server cruelty.

While we're on it, it gets a nice bed to put some data on the RAM disk
in the hope its job gets done at least quickier.

Resolves: #89935
Releases: master, 9.5, 8.7
Change-Id: Ic06f4b7071ed1d16ec9d0cd5a0a57f05dde171f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62611
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Use AJAX API in top toolbar items 78/62578/5
Andreas Fernandez [Sun, 8 Dec 2019 08:34:53 +0000 (09:34 +0100)]
[TASK] Use AJAX API in top toolbar items

The top toolbar items now use our AJAX API instead of $.ajax().

Resolves: #89897
Releases: master
Change-Id: I134ea97f2038097d486947f30545304e47a31dff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62578
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Bump chosen-js to 1.8.7 09/62609/2
Andreas Fernandez [Thu, 12 Dec 2019 15:39:47 +0000 (16:39 +0100)]
[TASK] Bump chosen-js to 1.8.7

Executed commands:

  yarn add chosen-js@^1.8.7 --dev
  grunt build

Resolves: #89884
Releases: master
Change-Id: I242b8925f108d3bfa26191f1c58ea24a1149f0ff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62609
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Fix typo in cHash option description 03/62603/2
Benni Mack [Thu, 12 Dec 2019 08:40:57 +0000 (09:40 +0100)]
[BUGFIX] Fix typo in cHash option description

Resolves: #89925
Releases: master, 9.5, 8.7
Change-Id: I3449606aa143c23dd656dd566c87aec08ae19425
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62603
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[DOCS] Correct code-block directive 00/62600/3
Chris Müller [Wed, 11 Dec 2019 17:49:49 +0000 (18:49 +0100)]
[DOCS] Correct code-block directive

The code-block directive needs two colons to be rendered
correctly.

Resolves: #89922
Related: #89463
Releases: master
Change-Id: Ida99628710cc3558a0dbdc39272e788c390ca154
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62600
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[FEATURE] Add PSR-14 event to control hreflang tags to be rendered 59/59059/38
Richard Haeser [Fri, 7 Dec 2018 21:07:06 +0000 (22:07 +0100)]
[FEATURE] Add PSR-14 event to control hreflang tags to be rendered

A PSR-14 event is introduced to make it possible to control the
hreflang tags that will be rendered.

Additionally the class HrefLangGenerator is migrated to be a
listener to the new event.

Resolves: #86614
Releases: master
Change-Id: I51a5a79da6996148e62301c793b0ad257aada102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] Supply origin to URL if domain is missing 76/62576/5
Andreas Fernandez [Fri, 6 Dec 2019 22:15:39 +0000 (23:15 +0100)]
[BUGFIX] Supply origin to URL if domain is missing

The AJAX API fails to send a request if the API receives a non-absolute
URL like /typo3/index.php?foo=bar, since the domain is missing. To fix
this issue, the origin of the triggering request is added as well as
`base` argument of URL().

Resolves: #89893
Releases: master
Change-Id: Ice61a71fc8d4627e6d0b3b9d0f5ab524000361ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62576
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[TASK] Remove ampersands from doc block params 94/62594/2
Alexander Schnitzler [Tue, 10 Dec 2019 16:10:08 +0000 (17:10 +0100)]
[TASK] Remove ampersands from doc block params

As a prepatory work for a better static code analysis
all ampersands have been removed from doc block params.

The doc block must not reflect whether a variable is
passed by value or reference.

Releases: master
Resolves: #89912
Change-Id: Ibead2ec2db6487e32bcd5fc271a6566bab46d255
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62594
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Expose none existing user in forgot password dialog 82/62482/12
Jan Stockfisch [Fri, 29 Nov 2019 11:15:06 +0000 (12:15 +0100)]
[TASK] Expose none existing user in forgot password dialog

Shows error flash message while
`exposeNonexistentUserInForgotPasswordDialog` is set to `1`

Resolves: #88111
Releases: master
Change-Id: I193e2ca22c45a83450aa4f0e44e3dce46696b16c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62482
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Exclude StringClassNameToClassConstantRector in rector.yml 81/62581/5
Alexander Schnitzler [Mon, 9 Dec 2019 10:12:54 +0000 (11:12 +0100)]
[TASK] Exclude StringClassNameToClassConstantRector in rector.yml

As the StringClassNameToClassConstantRector would convert
string class names that are deliberately defined as string,
this rector has been disabled.

Releases: master
Resolves: #89899
Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Remove leading slash from backendLogo path 93/62293/3
Oliver Bartsch [Mon, 11 Nov 2019 09:40:38 +0000 (10:40 +0100)]
[BUGFIX] Remove leading slash from backendLogo path

As the extension configuration field `backendLogo` isn't resolved
by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`,
it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage)
not possible to add a path with a leading slash.

As this is neither explicit allowed nor disallowed, this unifies the
behavior by removing a possible leading slash from the defined path
before it gets resolved as it's already the case for the other fields.

Resolves: #89636
Releases: master, 9.5
Change-Id: I3f7a72f1005bc403c72b837cf66e5303962a8a42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62293
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Disable lockIP by default 59/62559/12
Rasmus Larsen [Fri, 6 Dec 2019 12:58:16 +0000 (13:58 +0100)]
[BUGFIX] Disable lockIP by default

IPLock breaks modern IPv6 setups because of the Fast fallback
aka. Happy Eyeballs algorithm that can cause users to jump between
IPv4 and IPv6 arbitrarily.
Enabling lockIP should be a very conscious decision, not a default.

Resolves: #89869
Releases: master
Change-Id: I4b0fde1f767bfca613276d4763b91d9feb86ea27
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62559
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Use existing API instead of ContentObjectRenderer 27/62527/2
Michael Binder [Tue, 3 Dec 2019 12:39:08 +0000 (13:39 +0100)]
[BUGFIX] Use existing API instead of ContentObjectRenderer

This Patch allows the usage of an HMENU with special = directory and
the Fallback Type 'Free mode'

Resolves: #88344
Related: #89368
Releases: master, 9.5
Change-Id: Ib7f53b4e061b6387e6b29b2545696a3eb2d015a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62527
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Raise platform settings for tarball distributions 65/62565/3
Benni Mack [Fri, 6 Dec 2019 16:25:51 +0000 (17:25 +0100)]
[BUGFIX] Raise platform settings for tarball distributions

In order to use the final LTS distributions from Symfony for
our latest stable, we need to set proper platform requirements
for the root composer.json.

Our packages rely on the settings so the base package
can properly raise dependencies.

Symfony has the requirements due to other PHP bugs (fixed
very early already), however using the tarballs in
7.2.0 / 7.0.0 would still work, as the symfony changes
only fix issues we dont rely on.

v10: 7.2.5
v9: 7.2.5
v8: 7.0.8

Used composer commands:

  composer config platform.php 7.2.5
  composer update --lock

Resolves: #89882
Releases: master, 9.5, 8.7
Change-Id: Ib51ec076e643581603fced3ed0daa0de0aadb12c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62565
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Replace usage of legacy PageRepository class 86/62586/3
Alexander Schnitzler [Mon, 9 Dec 2019 18:45:34 +0000 (19:45 +0100)]
[TASK] Replace usage of legacy PageRepository class

In two places, TYPO3\CMS\Frontend\Page\PageRepository had been
used instead of TYPO3\CMS\Core\Domain\Repository\PageRepository.

As this will eventually fail in the future, the wrong usage has
been fixed.

Releases: master
Resolves: #89901
Change-Id: I5799bcb93486e3c8aa4a71fe4ad03cfce34948d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62586
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Allow rector to process tests 83/62583/4
Alexander Schnitzler [Mon, 9 Dec 2019 15:35:45 +0000 (16:35 +0100)]
[TASK] Allow rector to process tests

In order to let rector process tests, the autoloading
of all processed classes needs to be intact.

In TYPO3 there were a bunch of classes whose namespace
were a bit wrong according to PSR-4 and there were some
class that didn't fit the PSR-4 standard at all.

Classes that could easily be fixed have been fixed.
All others have either been registered via a class map
in composer.json or they have been excluded from the
processing of rector.

This change does not apply rector rules to tests,
it only enables rector to operate on tests due to
fixed autoloading.

Releases: master
Resolves: #89900
Change-Id: Iaa4a5bb2677a5a9af374d780423d962dcc09ade2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62583
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Do not set GeneralUtility::$container in unit tests 73/62573/4
Benjamin Franzke [Fri, 6 Dec 2019 20:26:45 +0000 (21:26 +0100)]
[TASK] Do not set GeneralUtility::$container in unit tests

The GeneralUtility $container instance should only be set/used
in functional tests as we a) can not reset the instance (which
means other unit tests are affected) and b) should mock/inject
dependencies in unit tests.

TreeDataProviderFactoryTest is therefore changed to to use
GeneralUtility::addInstance() (which is intended for unit tests)
instead of GeneralUtility::setContainer().

Change-Id: I9fc0e76077cc1cc2a6935d025b97309efc315f4f
Releases: master
Resolves: #89890
Related: #89733
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62573
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Remove reqCHash functionality for plugins 67/62267/9
Benni Mack [Sat, 9 Nov 2019 21:48:22 +0000 (22:48 +0100)]
[TASK] Remove reqCHash functionality for plugins

Since TYPO3 v10.0, all links generated by TYPO3 contain
a cHash if
- there are arguments that are not mapped within the routing
- there are arguments that are not explicitly "excluded" from cHash (e.g. fbclid)
- there are arguments that are not internal (L,id,MP).

The PageArgumentValidator middleware now always evaluates the
arguments properly at every request and decides to disable
caching or throw a 404, if an incoming request does not have
a cHash or an invalid cHash.

Through the middleware, any plugin is automatically checked
for the cHash, and it does not matter anymore for plugins,
so it does not matter for integrators or template authors as well
as cHash is managed internally by TYPO3 Core now (with no way
to disable it, for security reasons).

All functionality regarding cHash that can be dropped:
- CacheHashEnforcer and Extbase option
- TSFE->reqCHash() can be marked as deprecated
- the option within PiBased Plugins is now irrelevant as well.

This change jointly decouples cHash evaluation from any other
part than Url Generation (= PageRouter) and Resolver (PageArgumentValidator),
finally streamlining all logic of cHash functionality.

Resolves: #89868
Releases: master
Change-Id: I7a694fbc95fa1ea4dc85b12a94b0a06b3722fd11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62267
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Deprecate Extbase's WebRequest and WebResponse 17/62317/5
Alexander Schnitzler [Wed, 13 Nov 2019 11:57:09 +0000 (12:57 +0100)]
[TASK] Deprecate Extbase's WebRequest and WebResponse

In order to simplify the request/response handling in
Extbase and to prepare the introduction of PSR-7 compatible
request and response objects, the web versions of Extbase's
request and response have been deprecated. All relevant
logic has been moved into the base classes to stay api
compatible and not introduce a breaking change.

Along with the simplification of the request and response
objects, quite a lot of instance checks have been removed
to ease the transition to having a public api that is
defined by interfaces and not concrete implementations.

Releases: master
Resolves: #89673
Change-Id: Ie920ae7d38e6de3167ff57f93fa6e98af2936d9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62317
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Bump datatables to 1.10.18 72/62572/2
Andreas Fernandez [Fri, 6 Dec 2019 18:39:29 +0000 (19:39 +0100)]
[TASK] Bump datatables to 1.10.18

Executed commands:

  yarn upgrade datatables
  grunt build

Resolves: #89888
Releases: master
Change-Id: I73ea78f4d217c2846b0c79cf0e5ad06aea1a8e9e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62572
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump sortablejs to 1.10.1 71/62571/2
Andreas Fernandez [Fri, 6 Dec 2019 18:32:42 +0000 (19:32 +0100)]
[TASK] Bump sortablejs to 1.10.1

Executed commands:

  yarn add sortablejs@^1.10.1 --dev
  grunt build

Resolves: #89886
Releases: master
Change-Id: I871faaca63f19bf7fe2e782d6741cf3e476156b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62571
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump requirejs to 2.3.6 69/62569/2
Andreas Fernandez [Fri, 6 Dec 2019 18:23:29 +0000 (19:23 +0100)]
[TASK] Bump requirejs to 2.3.6

Executed commands:

  yarn upgrade requirejs
  grunt build

Resolves: #89887
Releases: master
Change-Id: I5b2347ebec049e1663a3684ce4246c323228befb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62569
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump moment to 2.24.0 and moment-timezone to 0.5.27 70/62570/2
Andreas Fernandez [Fri, 6 Dec 2019 18:27:49 +0000 (19:27 +0100)]
[TASK] Bump moment to 2.24.0 and moment-timezone to 0.5.27

Executed commands:

  yarn add moment@^2.24.0 moment-timezone@^0.5.27 --dev
  grunt build

Resolves: #89885
Releases: master
Change-Id: I6a6a7122fb1a0a343206c04c5cc3ce6a9a891d02
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62570
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump typescript to 3.7.3 68/62568/2
Andreas Fernandez [Fri, 6 Dec 2019 18:16:05 +0000 (19:16 +0100)]
[TASK] Bump typescript to 3.7.3

Executed commands:

  yarn upgrade typescript
  grunt build

Resolves: #89889
Releases: master
Change-Id: I1152fbbc89b30cae9ba34f1fa11494c071a7fe4a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62568
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[FEATURE] API for AJAX requests 72/62372/14
Andreas Fernandez [Fri, 22 Nov 2019 10:46:17 +0000 (11:46 +0100)]
[FEATURE] API for AJAX requests

In order to become independent of jQuery, a new API to perform AJAX
requests is introduced. This API implements the fetch API available
in all modern browsers.

Resolves: #89738
Releases: master
Change-Id: Ibdc1a7047b29402dea21b6dd7a48217b9afb849e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62372
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Make clear cache error notification translatable 69/62269/4
Oliver Bartsch [Sun, 10 Nov 2019 17:34:24 +0000 (18:34 +0100)]
[BUGFIX] Make clear cache error notification translatable

Move title and description of the clear cache error notification
to a xlf file to make it translatable.

Resolves: #89447
Releases: master
Change-Id: I925773de216ee8283336981b2cff2bd9a087a927
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62269
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Bump autosize to 4.0.2 66/62566/2
Andreas Fernandez [Fri, 6 Dec 2019 16:32:27 +0000 (17:32 +0100)]
[TASK] Bump autosize to 4.0.2

Executed commands:

  yarn add autosize@^4.0.2
  grunt build

Resolves: #89883
Releases: master
Change-Id: I0bf8f30bb22ffceea9eda9e4c71bb0fc5d661a4a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62566
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Bump jquery to 3.4.1 64/62564/3
Andreas Fernandez [Fri, 6 Dec 2019 16:23:41 +0000 (17:23 +0100)]
[TASK] Bump jquery to 3.4.1

Executed commands:

  yarn upgrade jquery
  grunt build

Resolves: #89881
Releases: master
Change-Id: I48c48de69f977e949563957d59789156bd5989fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62564
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Bump jquery.minicolors to 2.3.4 62/62562/2
Andreas Fernandez [Fri, 6 Dec 2019 16:15:39 +0000 (17:15 +0100)]
[TASK] Bump jquery.minicolors to 2.3.4

Executed commands:

  yarn add @claviska/jquery-minicolors@^2.3.4 --dev
  grunt build

Also, since the mentioned issues have been solved meanwhile, the library
is copied by grunt again.

Resolves: #89880
Related: #77317
Releases: master
Change-Id: I0d08fec8777b2e6090a98a85115deeb761c20e92
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62562
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add missing tooltips in various modules 75/62175/4
Oliver Bartsch [Fri, 1 Nov 2019 20:13:10 +0000 (21:13 +0100)]
[TASK] Add missing tooltips in various modules

This (re)adds various tooltips through the backend to
further increase the accessibility. Especially for buttons
that have a different meaning than normal in a particular context.

In most cases, they were simply missed but some of them referenced
to not longer existing locallang keys or to locallang keys of
another sysext which is no dependency of the one where it is referenced.

The tooltips are (re)added at following places:
- Creating new content element in ext:core new record view
- Multiple buttons in ext:core element information modal
- Multiple buttons in ext:beuser listing and compare view
- Multiple buttons in ext:form form management and form editor view
- Multiple buttons in ext:info pagetree overview
- New content element record button in ext:recordlist listing view
- View redirect button in ext:redirect listing view

Resolves: #89566
Releases: master
Change-Id: I66cd16413b0e4f188627df06f233a0bba73c3056
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62175
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Add check if update of all language packs is possible 71/62171/11
Oliver Bartsch [Thu, 31 Oct 2019 13:24:24 +0000 (14:24 +0100)]
[BUGFIX] Add check if update of all language packs is possible

The update all button in the table head of the extensionMatrix
is now disabled by default and only gets enabled if at least
one active language pack is installed.

This prevents interoperability of the entire card when
entering the language pack update process.

Resolves: #89561
Releases: master, 9.5
Change-Id: I8f04e0266d45b1257314ec937cc55a2fea603f83
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62171
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Deprecate switchable controller actions 11/61511/13
Alexander Schnitzler [Mon, 21 Oct 2019 10:13:34 +0000 (12:13 +0200)]
[TASK] Deprecate switchable controller actions

The usage of switchable controller actions, both via
flexforms and typoscript, is deprecated and will be
removed in one the next major versions of TYPO3,
probably version 11.0 or 12.0.

Switchable controller actions allowed to override the
php plugin configuration and to create god plugins, i.e.
plugins that can be set into multiple different modes
and therefore take care of all possible use cases.

Every plugin should serve a single purpose, therefore
the usage of switchable controller actions is an anti
pattern which will be removed.

The switchable controller action mechanic will be
removed without replacement which means, that there
is no migration path to a similar feature.

Instead, extension authors need to create multiple,
dedicated plugins for different use cases.

Releases: master
Resolves: #89463
Change-Id: I41afac9303205f97f390f208803908177e00cda5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Update build stack 86/62486/7
Andreas Fernandez [Fri, 29 Nov 2019 12:32:29 +0000 (13:32 +0100)]
[TASK] Update build stack

All frontend stack related packages get updated to their latest version
and a full build is generated.

Executed commands:

  yarn add \
    @typescript-eslint/eslint-plugin@^2.10.0 \
    @typescript-eslint/parser@^2.10.0 \
    @typescript-eslint/typescript-estree@^2.10.0 \
    autoprefixer@^9.7.3 \
    eslint@^6.7.2 \
    grunt-stylelint@^0.12.0 \
    grunt-terser@^1.0.0 \
    karma@^4.4.1 \
    node-sass@^4.13.0 \
    typescript@^3.7.2 --dev
  yarn build

Resolves: #89804
Releases: master
Change-Id: I48f00a01fb4191b39e76e0859d1f1476644ad07b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62486
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months agoRevert "[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable" 51/62551/3
Benjamin Franzke [Fri, 6 Dec 2019 09:06:53 +0000 (10:06 +0100)]
Revert "[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable"

This reverts commit 26c9a8e32637d506249989318941c923171b7658.

The schedulers *primary* task is to *schedule* tasks, not to execute them
from the backend. The backend-execution is only an additional
functionality, which is available because it's sometime handy for manual
tasks/testing.

We shouldn't mark commands as non-schedulable when scheduling them is a
perectly valid usecase.
Usecases for scheduling backend locks are:
* Planned maintenance locks:
  schedule a backend lock for a planned update or migration where you
  agreed to stop editing as of a certain date.
* Regular edit-locks, e.g.:
  schedule a backend lock for let's say every friday as of 8pm
  schedule backend unlock on mondays at 8am.

The reverted patch tried to fix the situation where the lock task was
executed from the backend scheduler overview. If we'd want to fix that,
the proper fix would be to add another property which states that this
command must not be executed from the backend.

Releases: master, 9.5
Resolves: #89873
Reverts: #89387
Change-Id: I782809ff065c05adba0653aa208d37e1241eb41a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62551
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
4 months ago[BUGFIX] Use RequestFactory for downloading mirrors and check response properly 96/62496/6
Andreas Fernandez [Fri, 29 Nov 2019 17:18:49 +0000 (18:18 +0100)]
[BUGFIX] Use RequestFactory for downloading mirrors and check response properly

The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.

In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.

Resolves: #89810
Releases: master, 9.5
Change-Id: Ie4e8bcf02c33eb18e58f505f1a791c1233d6f593
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[BUGFIX] Fix keyboard behaviour on pagetree root node 44/62544/4
Michael Telgkamp [Thu, 5 Dec 2019 14:47:46 +0000 (15:47 +0100)]
[BUGFIX] Fix keyboard behaviour on pagetree root node

- Do not toggle node with canToggle!==true
- Check if node has parent before trying to go to parent node

Resolves: #89847
Resolves: #89864
Releases: master
Change-Id: I49f112c15e64103e707481cecb7f61bd58fa8182
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62544
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Add more tests for TypoLink handling in fluid 20/62520/2
Frank Naegler [Tue, 3 Dec 2019 08:19:30 +0000 (09:19 +0100)]
[TASK] Add more tests for TypoLink handling in fluid

Resolves: #89834
Releases: master, 9.5
Change-Id: I914c6e8a0739c4380be4fa1c1d165f3eb4f1aecd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62520
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Check if header variable is set before using it 40/62540/4
Susanne Moog [Thu, 5 Dec 2019 13:55:45 +0000 (14:55 +0100)]
[BUGFIX] Check if header variable is set before using it

Avoid a TypeError exception in NewContentElementController in
newer PHP versions because of an undefined array access.

Resolves: #89860
Releases: master, 9.5
Change-Id: I5728638a3f5800588f17bef202fe5814e79d7f2f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Tobias D. <tobias.doll@snk.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Restructure nightly plans in stages a 50 jobs 46/62546/2
Anja Leichsenring [Thu, 5 Dec 2019 16:03:11 +0000 (17:03 +0100)]
[TASK] Restructure nightly plans in stages a 50 jobs

The rearranged stages structure will prevent the host
machines and also gerrit from being overwhelmed with a
high amount of running jobs all at once.
Instead, the equal size of each stage keeps the load
on an average height, but it will increase the total
runtime of a plan. We prefer stability over quick runs
in nightlies.

Resolves: #89865
Releases: master, 9.5, 8.7
Change-Id: Ib915053e83d087007242c05886619faf8d7cee0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62546
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Streamline test names 35/62535/2
Oliver Hader [Thu, 5 Dec 2019 08:01:30 +0000 (09:01 +0100)]
[TASK] Streamline test names

Resolves: #89854
Releases: master, 9.5
Change-Id: I07aaab48ae504ee2b9e0fa5e37b725c6bb873e67
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62535
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Move ChangeLog files to 10.2 folder 33/62533/2
Oliver Hader [Wed, 4 Dec 2019 15:47:31 +0000 (16:47 +0100)]
[TASK] Move ChangeLog files to 10.2 folder

Resolves: #89849
Releases: master
Change-Id: I0780f857cd058c38692344106af3f6fef9f7d549
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62533
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Use PHP 7.4 for pre-merge tests on functionals and acceptance 30/62530/2
Anja Leichsenring [Tue, 3 Dec 2019 16:35:08 +0000 (17:35 +0100)]
[TASK] Use PHP 7.4 for pre-merge tests on functionals and acceptance

At least one functional and one acceptance tests run on pre-merge
tests should use PHP 7.4. There are three (with tree DB systems),
so each one uses now one of the supported PHP versions and one of
the supported DBMS.
A complete test run is done during nightly runs due to time
constraints.

Resolves: #89841
Releases: master, 9.5, 8.7
Change-Id: Ie0bbe7309b63142f425bd2ff45c247e70d58fd06
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62530
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Provide PHP 7.4 test run configuration 16/62316/3
Anja Leichsenring [Tue, 3 Dec 2019 14:45:21 +0000 (15:45 +0100)]
[TASK] Provide PHP 7.4 test run configuration

Resolves: #89668
Releases: master, 9.5, 8.7
Change-Id: I098c573aaa13846f45c1f1904f46db5cdecf4db1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62316
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Set TYPO3 version to 10.3.0-dev 25/62525/2
Benni Mack [Tue, 3 Dec 2019 11:41:35 +0000 (12:41 +0100)]
[TASK] Set TYPO3 version to 10.3.0-dev

Change-Id: I0e8abdb62a45326896fc75d9872eead478615dce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62525
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[RELEASE] Release of TYPO3 10.2.0 23/62523/2 v10.2.0
Benni Mack [Tue, 3 Dec 2019 11:16:19 +0000 (12:16 +0100)]
[RELEASE] Release of TYPO3 10.2.0

Change-Id: I09bb29716abb1a7b1f4c8010c1d98c15ae90d808
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62523
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make LinkAnalyzer available for DI 22/62522/2
Andreas Fernandez [Tue, 3 Dec 2019 10:41:42 +0000 (11:41 +0100)]
[BUGFIX] Make LinkAnalyzer available for DI

Resolves: #89837
Related: #89813
Releases: master
Change-Id: Idfb9274c7a5415e6bef7dee61a6ca65728d96674
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62522
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Cleanup new frontend login form 16/62516/9
Benni Mack [Mon, 2 Dec 2019 21:41:13 +0000 (22:41 +0100)]
[BUGFIX] Cleanup new frontend login form

Some changes were made:

- Upgrade Wizard works
- Visibility on RedirectHandler is sorted out
- TreeUidListProvider is removed - cObject does everything already, less dependencies
- PasswordChangeEvent is actually executed now (and works!)
- RedirectConfiguration now has a factory
- Do not use ConnectionPool as dependency as it contains state
- Most "final" and "private" were put back to "protected" (as the rest of core) - except events
- Additional hmac check in Repository
- Add lifetime validation of hash in changePassword action as well

Resolves: #89828
Related: #84262
Releases: master
Change-Id: I813a2fc86c8e4f61fd923467aa761246187af901
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62516
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Avoid resolving default values of static property in ClassSchema 18/62518/5
Oliver Hader [Mon, 2 Dec 2019 23:12:31 +0000 (00:12 +0100)]
[BUGFIX] Avoid resolving default values of static property in ClassSchema

Building reflection cache in ClassSchema on static class properties will
lead to side-effects. For instance when ConnectionPool is analyzed for
being used with Extbase dependency injection and has been used already
during runtime - which is very likely - static property $connections is
going to hold all runtime connections.

https://www.php.net/manual/en/reflectionclass.getdefaultproperties.php:
> This method only works for static properties when used on internal
> classes. The default value of a static class property can not be
> tracked when using this method on user defined classes.

That's why default values of static properties are not resolved anymore.

Resolves: #89830
Releases: master
Change-Id: I0040c3e4327d084b3192017874154ab5d8466508
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62518
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Raise testing framework to ~6.1.0 19/62519/3
Susanne Moog [Tue, 3 Dec 2019 08:25:13 +0000 (09:25 +0100)]
[TASK] Raise testing framework to ~6.1.0

composer require --dev typo3/testing-framework:~6.1.0

Also reverts changes to tests for phpunit 8.3 only.

Resolves: #89833
Releases: master
Change-Id: I834f70452775ea18960da162bb2affe459b8556a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62519
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Show toolbar select only if at least 2 options 17/62517/2
Georg Ringer [Mon, 2 Dec 2019 22:50:39 +0000 (23:50 +0100)]
[BUGFIX] Show toolbar select only if at least 2 options

Simplify the UI of the toolbar by hiding the select field
if there is only one option to choose from which doesn't make sense.

Resolves: #89829
Releases: master
Change-Id: I6e58aae1bab25777bca21f058524e447f569d73a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62517
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update testing framework to 6.0 02/62502/11
Susanne Moog [Sat, 30 Nov 2019 19:09:52 +0000 (20:09 +0100)]
[TASK] Update testing framework to 6.0

The testing framework has been reworked and slimmed down.
To make use of it, tests had to be adjusted.

   composer require --dev typo3/testing-framework:"~6.0.0"

Resolves: #89815
Releases: master
Change-Id: Ib0a8d7436070ef17be96a5f4011f796dd15b09fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62502
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Filter empty values from language list 97/62497/3
Andreas Fernandez [Fri, 29 Nov 2019 17:43:20 +0000 (18:43 +0100)]
[BUGFIX] Filter empty values from language list

In case an old installation still has empty values stored in
`EXTCONF/lang/availableLanguages` (which has been fixed in #63546),
e.g. the language matrix in the "Manage Language Packs" is unusable.

This patch therefore removes empty values from the mentioned
configuration, as similar solved in the old issue.

Resolves: #89772
Related: #63546
Releases: master, 9.5
Change-Id: Id7473e5f17878d84914fec4df629ac6617256b55
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62497
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[FEATURE] Reintroduce keyboard accessible version of the pagetree 51/62051/31
Michael Telgkamp [Tue, 22 Oct 2019 20:20:27 +0000 (22:20 +0200)]
[FEATURE] Reintroduce keyboard accessible version of the pagetree

- Pagetree is focusable via tab key
- Keyboard navigation with arrow keys inside pagetree is enabled
- Implement accessible tree structure for tree nodes (role=tree)

Resolves: #86818
Releases: master

Change-Id: Ic948fb0de8461a8c5b4b5297b94e5cb94465ec42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62051
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
4 months ago[TASK] Add missing documentation for 10.2 release 15/62515/4
Susanne Moog [Mon, 2 Dec 2019 17:41:40 +0000 (18:41 +0100)]
[TASK] Add missing documentation for 10.2 release

Some change log entries should be documented in extension manuals
or in ViewHelpers. The missing docs have been added.

Resolves: #89827
Releases: master
Change-Id: I6c76dc2d532b151275c60e85feb44f227ca80919
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62515
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[DOCS] Fix syntax issues in changelog 10/62510/3
Daniel Siepmann [Mon, 2 Dec 2019 16:07:41 +0000 (17:07 +0100)]
[DOCS] Fix syntax issues in changelog

There were some minor syntax issues within changelog that are now fixed.
They prevented:

* Rendering of lists
* Rendering of code blocks
* Rendering of inline code

Resolves: #89825
Releases: master
Change-Id: Ic272e989e7841eac8c6f04f4819354b0926cd6df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62510
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Avoid cross-dependency in Extbase dispatcher 08/62508/5
Benni Mack [Mon, 2 Dec 2019 13:42:20 +0000 (14:42 +0100)]
[BUGFIX] Avoid cross-dependency in Extbase dispatcher

Extbase's old signal slot dispatcher / core should not
use classes that are not explicitly
required for the miminum packages.

Resolves: #89823
Releases: master
Change-Id: I41f7e378ed3d99e62daebfdd5631ef0234761772
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62508
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Do not apply default node settings when invoking command 07/62507/4
Andreas Fernandez [Mon, 2 Dec 2019 13:36:15 +0000 (14:36 +0100)]
[BUGFIX] Do not apply default node settings when invoking command

The issue #89687 introduced a smaller response for page tree nodes by
moving sane default attributes to JavaScript and overriding with the
actual result.

However, this is also done if a new page is created via drag&drop, the
attribute get in a mixed state and page tree hurts itself in confusion.

The default attributes are now applied only if no DataHandler command is
invoked.

Additionally, some variables in TreeController were wrongly used, which
has been fixed as well.

Resolves: #89822
Related: #89687
Releases: master, 9.5
Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507
Tested-by: Claus Due <claus@phpmind.net>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 months ago[TASK] Use mssql-2017-cu17 11/62511/4
Andreas Fernandez [Mon, 2 Dec 2019 16:22:05 +0000 (17:22 +0100)]
[TASK] Use mssql-2017-cu17

docker-compose is updated to use the latest cumulative update (cu) of
MSSQL 2017.

Since mssql is probably still eager to fail, its stages are executed at
last in the nightly builds now.

Resolves: #89826
Releases: master, 9.5, 8.7
Change-Id: Ic1e8195f9b4f90747b5843d03630fd453ebe0bc6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62511
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Use inject methods instead of "inject" base test method 03/62503/3
Benni Mack [Mon, 2 Dec 2019 09:12:07 +0000 (10:12 +0100)]
[TASK] Use inject methods instead of "inject" base test method

There are numereous places where reflection is used
in our test cases to inject dependencies, however
there are methods available doing so, so the tests
can be adapted, which will speed up tests.

In addition, the $callInaccessibleMethod() function
is also replaced by the accessible mock functionality,
resulting in faster results than reflection.

Resolves: #89824
Releases: master
Change-Id: Ia2fc8a8ee4d3b5fc7b0d2de8759a7e5e9ceb7b87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62503
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Raise fluid standalone dependency to 2.6.8 04/62504/2
Benni Mack [Mon, 2 Dec 2019 10:34:45 +0000 (11:34 +0100)]
[TASK] Raise fluid standalone dependency to 2.6.8

Using the freshly released version 2.6.8
in our packages adds PHP 7.4 support for Fluid
Standalone.

composer req "typo3fluid/fluid:^2.6.8"

Resolves: #89819
Releases: master, 9.5, 8.7
Change-Id: I986b3f8e73e3114af3aef9f65b42c3bf109f9f39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62504
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make EventDispatcher argument in LanguagePackService constructor optional 06/62506/2
Andreas Fernandez [Mon, 2 Dec 2019 11:07:14 +0000 (12:07 +0100)]
[BUGFIX] Make EventDispatcher argument in LanguagePackService constructor optional

Resolves: #89820
Related: #89813
Change-Id: I165dbb813079fbb0f25ac7b1c8ab57f292f73b16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62506
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[FEATURE] Migrate various Signals to PSR-14 events in system extensions 22/62422/15
Benni Mack [Sat, 23 Nov 2019 22:36:33 +0000 (23:36 +0100)]
[FEATURE] Migrate various Signals to PSR-14 events in system extensions

The following new PSR-14 events are added:

TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent
TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent
TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent
TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent
TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent
TYPO3\CMS\Impexp\Event\BeforeImportEvent
TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent
TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent
TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent
TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent
TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent

They replace the following "old" signals with a deprecation layer:

TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer
TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter
TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter
TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude
TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser
TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation
TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl
TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord
TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss

Relates: #89733
Resolves: #89813
Releases: master
Change-Id: I13f2454fd8f4efb5f4c5248d0b839634b77578db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62422
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Provide necessary info for NewContentElementWizardHook again 80/62480/3
Jo Hasenau [Fri, 29 Nov 2019 10:44:51 +0000 (11:44 +0100)]
[BUGFIX] Provide necessary info for NewContentElementWizardHook again

Due to deprecations (in v9) and marking properties from public to
protected, some hooks are not as powerful anymore, so special getter
methods are provided to overcome this issue.

Resolves: #87064
Releases: master, 9.5
Change-Id: I5a05bb8b31c2a9df2801092bd9ead60061bbd15f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62480
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Migrate Tests from _callRef to _call 93/62493/4
Benni Mack [Fri, 29 Nov 2019 14:46:36 +0000 (15:46 +0100)]
[TASK] Migrate Tests from _callRef to _call

Tests should be consistent and reflect the
way we do things in Core. However, testing
framework offers too many different ways to do things,
and "_callRef" is one of that.

Resolves: #89817
Releases: master
Change-Id: I44759df255365d0f90e0928f3f5726b66ecf9f3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62493
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Fix broken Fluid templates 50/62450/2
Patrick Broens [Thu, 28 Nov 2019 14:09:18 +0000 (15:09 +0100)]
[BUGFIX] Fix broken Fluid templates

In some versions of PHP there is a PCRE bug, which will be triggered when
using an unquoted array syntax in Fluid templates, leading to an error
and possibly not able to display the rendered template.

This is solved by using the quoted array syntax where it is not used yet.

Resolves: #87970
Releases: master, 9.5
Change-Id: I36f4ee86765fae24f7daa0e7e59ff9fc6741144f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62450
Reviewed-by: Rens Admiraal <rens@simplyadmire.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Update doctrine/annotations dependency 98/62498/2
Benni Mack [Fri, 29 Nov 2019 20:43:26 +0000 (21:43 +0100)]
[TASK] Update doctrine/annotations dependency

TYPO3 Core now requires at least doctrine/annotations
1.7, effectively helping to upgrade to PHP 7.4.

Resolves: #89812
Releases: master, 9.5
Change-Id: I8ca951711bbcb19d935baad67ff69705d8e51aa2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62498
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>