Packages/TYPO3.CMS.git
20 months ago[BUGFIX] PHP7.2: Check value for NULL before count 41/54041/2
Alexander Opitz [Thu, 7 Sep 2017 07:04:47 +0000 (09:04 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82275
Releases: master, 8.7, 7.6
Change-Id: I77dc811456f4bbd759e28c27284c4652ad09dd23
Reviewed-on: https://review.typo3.org/54041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update typo3/testing-framework to 1.1.3 37/54037/2
Christian Kuhn [Fri, 8 Sep 2017 16:44:10 +0000 (18:44 +0200)]
[TASK] Update typo3/testing-framework to 1.1.3

Three smaller patches to improve functional testing.

Change-Id: I7ff6b9c6b4d5b22b42ab2d09e670337e5bad8162
Resolves: #82389
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54037
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Enforce checkout with linux lf for yaml files 40/54040/2
Benjamin Kott [Fri, 8 Sep 2017 19:06:20 +0000 (21:06 +0200)]
[BUGFIX] Enforce checkout with linux lf for yaml files

Resolves: #82392
Releases: master, 8.7
Change-Id: I2ba42454a6b16aa8b4dd97a5741251b4fe265c0e
Reviewed-on: https://review.typo3.org/54040
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] SplitButtons: Abort click event if requested 32/54032/2
Andreas Fernandez [Thu, 7 Sep 2017 18:13:17 +0000 (20:13 +0200)]
[BUGFIX] SplitButtons: Abort click event if requested

If any callback is registered by `SplitButtons.addPreSubmitCallback()` and
requests to stop the event by `stopPropagation()`, the event must be
aborted and not only possibly stacked events.
Additionally, the `preventExec` flag gets reset.

Resolves: #82355
Related: #77942
Releases: master, 8.7, 7.6
Change-Id: Ib8478ef4c51915365c804c1c408b3fc16a13da0b
Reviewed-on: https://review.typo3.org/54032
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] EXT:form - catch YAML parsing errors 27/54027/2
Daniel Lorenz [Fri, 8 Sep 2017 11:52:32 +0000 (13:52 +0200)]
[BUGFIX] EXT:form - catch YAML parsing errors

Catche YAML parsing errors and display this them alongside
their form definition files in form module and plugin.

Resolves: #82369
Releases: master, 8.7
Change-Id: Icf71027d21d0a8e30c238a51369676715de2e5c5
Reviewed-on: https://review.typo3.org/54027
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FOLLOWUP][BUGFIX] Fix minor error handler code bugs 19/54019/2
Benni Mack [Fri, 8 Sep 2017 12:21:33 +0000 (14:21 +0200)]
[FOLLOWUP][BUGFIX] Fix minor error handler code bugs

ErrorHandler should deal with the same severity for trigger_error()
for E_USER_DEPRECATED as GeneralUtility::deprecationLog()
when calling GeneralUtility::devLog().

Resolves: #82375
Releases: master, 8.7
Change-Id: Iaff5f96f5bd0a2d94bb3bc76d9d3fec2d019c901
Reviewed-on: https://review.typo3.org/54019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix configuration of distribution packages 13/54013/2
Markus Hoelzle [Fri, 8 Sep 2017 10:24:34 +0000 (12:24 +0200)]
[BUGFIX] Fix configuration of distribution packages

Fix link to configuration of distribution packages
and redirect after saving this confiuration.

Releases: master,8.7
Resolves: #82376
Change-Id: I7f054a32187260e102b30c097937d5348ec121a6
Reviewed-on: https://review.typo3.org/54013
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Separators shown in explicit allow/deny section 18/54018/2
Oliver Hader [Fri, 8 Sep 2017 10:49:01 +0000 (12:49 +0200)]
[BUGFIX] Separators shown in explicit allow/deny section

The explicit allow/deny section of backend user groups (be_groups)
render separators (--div--) in the backend which need to be skipped.

Change-Id: Iac578d43a7a561618d095819b9d667c613621f2b
Resolves: #82379
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix minor error handler code bugs 11/54011/2
Benni Mack [Fri, 8 Sep 2017 10:00:11 +0000 (12:00 +0200)]
[BUGFIX] Fix minor error handler code bugs

ErrorHandler has a few minor quirks:

1. the protected property is an integer (bitwise-comparison) but initialized as array
2. small indention and repeatable string introduction
3. human-readable text for E_USER_DEPRECATED missing
4. error handling when no autoloader is available is obsolete.

The patch fixes all these minor issues.

Resolves: #82375
Releases: master, 8.7
Change-Id: Id6f9616602021e04ac6a50737438253a62da788c
Reviewed-on: https://review.typo3.org/54011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months agoRevert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class" 10/54010/2
Christian Kuhn [Fri, 8 Sep 2017 10:14:36 +0000 (12:14 +0200)]
Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac
Releases: master, 8.7
Resolves: #82131
Reverts: #82131
Reviewed-on: https://review.typo3.org/54004
Reviewed-on: https://review.typo3.org/54010
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Add the full namespace to afterInitializeCurrentPage 03/54003/2
Daniel [Thu, 7 Sep 2017 20:16:17 +0000 (22:16 +0200)]
[TASK] Add the full namespace to afterInitializeCurrentPage

Releases: master, 8.7
Resolves: #82362
Change-Id: I36a4341aea620027822af1b8714e9197ff4bcb00
Reviewed-on: https://review.typo3.org/54003
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[BUGFIX] Show spaces of content elements in page module 01/54001/2
Christoph Lehmann [Mon, 4 Sep 2017 15:24:23 +0000 (17:24 +0200)]
[BUGFIX] Show spaces of content elements in page module

Resolves: #82290
Releases: master,8.7
Change-Id: Ie988290ae4431f8a77dc2c38397429b9fa0c95ef
Reviewed-on: https://review.typo3.org/54001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Unify labels for space before/after 00/54000/2
Stefan Neufeind [Thu, 7 Sep 2017 06:52:46 +0000 (08:52 +0200)]
[BUGFIX] Unify labels for space before/after

Resolves: #82321
Releases: master, 8.7
Change-Id: Idd47fbb0b7af3f5668d45a6aee545c794ec17a1a
Reviewed-on: https://review.typo3.org/54000
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[BUGFIX] PHP7.2: Check value for NULL before count 85/53985/2
Alexander Opitz [Thu, 7 Sep 2017 07:48:21 +0000 (09:48 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82322
Releases: master, 8.7, 7.6
Change-Id: I31f7bc2db61337e10be7ffd44ac294b77c44d07b
Reviewed-on: https://review.typo3.org/53985
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update typo3/cms-cli to latest version 41/53941/2
Helmut Hummel [Thu, 7 Sep 2017 09:28:38 +0000 (11:28 +0200)]
[TASK] Update typo3/cms-cli to latest version

Composer command:
composer req typo3/cms-cli ^1.0.2

This eases composer install --no-dev for users of clones
because we removed the backwards dependency
in typo3/cms-cli with that version.

Resolves: #82329
Releases: 8.7
Change-Id: I77a7c22d003ede5509ad84a8f507e5fd7fbac93a
Reviewed-on: https://review.typo3.org/53941
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
20 months ago[BUGFIX] EXT:form - fix values with dots within form editor 84/53984/2
Ralf Zimmermann [Thu, 7 Sep 2017 15:16:13 +0000 (17:16 +0200)]
[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] EXT:form - fix error on single database insert 82/53982/2
Mathias Brodala [Thu, 7 Sep 2017 18:37:13 +0000 (20:37 +0200)]
[BUGFIX] EXT:form - fix error on single database insert

Resolves: #81805
Releases: master, 8.7
Change-Id: I8ee3582170db9812d7be2b9710cb4d46335ec86a
Reviewed-on: https://review.typo3.org/53982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] EXT:form - change naming and icon in new content element wizard 79/53979/2
Thomas Kieslich [Thu, 7 Sep 2017 15:04:00 +0000 (17:04 +0200)]
[TASK] EXT:form - change naming and icon in new content element wizard

Change language labels and move them to ext:form locallang.xlf.
Change the icon to content-form.

Resolves: #81650
Releases: master, 8.7
Change-Id: I1c497b78da92dc589ad9d7a47dde35c5aeba488a
Reviewed-on: https://review.typo3.org/53979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] EXT:form - cleanup of leftovers, better wording 60/53960/2
protos [Thu, 7 Sep 2017 14:04:08 +0000 (16:04 +0200)]
[TASK] EXT:form - cleanup of leftovers, better wording

Change some wording for better understanding in frontend and backend.

Resolves: #82326
Releases: master, 8.7
Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae
Reviewed-on: https://review.typo3.org/53960
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] EXT:form - fix missing id attribute 64/53964/2
protos [Thu, 7 Sep 2017 15:33:32 +0000 (17:33 +0200)]
[BUGFIX] EXT:form - fix missing id attribute

Insert missing id attribute for image and file upload element.

Resolves: #82223
Releases: master, 8.7
Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd
Reviewed-on: https://review.typo3.org/53964
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Properly render multiline form values 54/53954/2
Daniel Lorenz [Thu, 7 Sep 2017 13:25:50 +0000 (15:25 +0200)]
[BUGFIX] Properly render multiline form values

Properly render multiline form values in summary page
and HTML emails.

Resolves: #82026
Releases: master, 8.7
Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587
Reviewed-on: https://review.typo3.org/53954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] EXT:form - fix page drag & drop 55/53955/2
Ralf Zimmermann [Thu, 7 Sep 2017 13:29:54 +0000 (15:29 +0200)]
[BUGFIX] EXT:form - fix page drag & drop

Fix JavaScript errors on page drag & drop within the form editor

Resolves: #82337
Releases: master, 8.7
Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb
Reviewed-on: https://review.typo3.org/53955
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[TASK] Tests for rendering tt_content with FAL in Extbase 48/53948/2
Tymoteusz Motylewski [Wed, 6 Sep 2017 07:01:49 +0000 (09:01 +0200)]
[TASK] Tests for rendering tt_content with FAL in Extbase

Functional tests checking Extbase rendering of tt_content
records with FAL images.

Also fixes two typos in fixture data.

Resolves: #82298
Releases: master, 8.7, 7.6
Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5
Reviewed-on: https://review.typo3.org/53948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[BUGFIX] EXT:form - catch exceptions within page module and form engine 42/53942/2
Ralf Zimmermann [Thu, 4 May 2017 10:58:06 +0000 (12:58 +0200)]
[BUGFIX] EXT:form - catch exceptions within page module and form engine

* Show messages within page module and form engine if the backend user
does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
ext:form configuration is invalid.

Resolves: #80678
Resolves: #81113
Releases: master, 8.7
Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d
Reviewed-on: https://review.typo3.org/53942
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Kieslich <thomas.kieslich@gmail.com>
Tested-by: Thomas Kieslich <thomas.kieslich@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[TASK] Set TYPO3 version to 8.7.7-dev 35/53935/2
Benni Mack [Thu, 7 Sep 2017 06:12:29 +0000 (08:12 +0200)]
[TASK] Set TYPO3 version to 8.7.7-dev

Change-Id: I4764c7378dabf4923f09856b0630d35ced292f8d
Reviewed-on: https://review.typo3.org/53935
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Prevent empty sorting field to be quoted and put into an array 27/53927/2
Xavier Perseguers [Tue, 5 Sep 2017 14:17:26 +0000 (16:17 +0200)]
[BUGFIX] Prevent empty sorting field to be quoted and put into an array

Change-Id: I807a888ac7d977606d94f5ad9ccdfeee07ee61ec
Resolves: #82307
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[RELEASE] Release of TYPO3 8.7.6 34/53934/2 8.7.6 TYPO3_8-7-6 v8.7.6
Benni Mack [Thu, 7 Sep 2017 06:10:10 +0000 (08:10 +0200)]
[RELEASE] Release of TYPO3 8.7.6

Change-Id: I79cc3e303f1d80b9792bf9daf963b926118a5db6
Reviewed-on: https://review.typo3.org/53934
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Revert "Update CKEditor to 4.7.2" 33/53933/2
Benni Mack [Thu, 7 Sep 2017 05:52:03 +0000 (07:52 +0200)]
[TASK] Revert "Update CKEditor to 4.7.2"

Ensure that no side-effects happen on 8.7.6 because of this patch.

Reverts: #82143
Resolves: #82320
Releases: 8.7
This reverts commit c762b3871ecaf4731a7c5172a0f91aad429a685c.

Change-Id: Ie5310422763dfbfc03b2fc02603b6c76f14de493
Reviewed-on: https://review.typo3.org/53933
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Remove runtime cache and early return from TemplatePaths 32/53932/2
Claus Due [Tue, 5 Sep 2017 15:10:18 +0000 (17:10 +0200)]
[BUGFIX] Remove runtime cache and early return from TemplatePaths

This patch removes the previously introduced runtime cache
and early returns from TemplatePaths, both of which were
implemented in an attempt to prevent excessive TypoScript
parsing - an issue which has since been solved by optimising
the TypoScript parsing enough that a cache and early return
is no longer necessary (no longer constitutes a significant
performance increase).

The early return and caching introduced regressions described
in the related forge issues. Removing both solves those problems.

In addition, the method resolving TypoScript paths is now
covered by extensive unit tests confirming everything from
merging to sorting of template paths. An average of 8 tests
cover the method's lines. Each of the expected behaviors
is now declared as specific test.

Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63
Resolves: #82196
Resolves: #82181
Related: #79662
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53932
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[TASK] Update guzzlehttp/guzzle dependency to 6.3.0 25/53925/2
Benni Mack [Wed, 6 Sep 2017 08:01:42 +0000 (10:01 +0200)]
[TASK] Update guzzlehttp/guzzle dependency to 6.3.0

This brings PHP 7.2 support for guzzle functionality.

Verified that guzzle still runs with PHP7.0 (min requirement for us)

Resolves: #82313
Releases: master, 8.7
Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e
Reviewed-on: https://review.typo3.org/53925
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Space before class has a typo in access list for page content 76/53876/2
Jörg Bösche [Mon, 4 Sep 2017 11:15:30 +0000 (13:15 +0200)]
[BUGFIX] Space before class has a typo in access list for page content

The locallang_ttc.xlf has a typo in the key "space_before_class" which
is shown in the access list of a page content field.

Resolves: #82284
Releases: master, 8.7
Change-Id: Id61c8c7d5c5da11b8f7bb3e55e49d7613e593730
Reviewed-on: https://review.typo3.org/53876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Allow string as $subpartContent 22/53922/2
Sebastian Fischer [Tue, 5 Sep 2017 14:40:13 +0000 (16:40 +0200)]
[TASK] Allow string as $subpartContent

The parameter $subpartContent of substituteSubpart() can be either
string or array. IDEs need to have both present in the comment to not
show warnings for given parameters that are correct.

Resolves: #82308
Releases: master, 8.7
Change-Id: Ifcceb8dcd5ad8be56695cef161949046ff74c994
Reviewed-on: https://review.typo3.org/53922
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Add functional tests for rendering translated tt_content with FAL 14/53914/2
Tymoteusz Motylewski [Mon, 4 Sep 2017 12:07:01 +0000 (14:07 +0200)]
[TASK] Add functional tests for rendering translated tt_content with FAL

Functional tests checking TypoScript rendering of tt_content
records with FAL images.

Releases: master, 8.7, 7.6
Resolves: #82187
Change-Id: I5889ab13183b28dc2ff1ccc2c00c18f01ceacc76
Reviewed-on: https://review.typo3.org/53914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Set TYPO3 version to 8.7.6-dev 12/53912/2
Benni Mack [Tue, 5 Sep 2017 10:46:53 +0000 (12:46 +0200)]
[TASK] Set TYPO3 version to 8.7.6-dev

Change-Id: I0150b331e8e9b0223bc0a556c9978db2c52825aa
Reviewed-on: https://review.typo3.org/53912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[RELEASE] Release of TYPO3 8.7.5 11/53911/2 8.7.5 TYPO3_8-7-5 v8.7.5
Benni Mack [Tue, 5 Sep 2017 10:45:04 +0000 (12:45 +0200)]
[RELEASE] Release of TYPO3 8.7.5

Change-Id: Idc222d0cf241024cd54dcb10a9ddcb4627868466
Reviewed-on: https://review.typo3.org/53911
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Apply CGL fixes 06/53906/2
Oliver Hader [Tue, 5 Sep 2017 09:54:28 +0000 (11:54 +0200)]
[TASK] Apply CGL fixes

Releases: master, 8.7, 7.6
Change-Id: I167c68d7d04dd4b8c876b1f6f8f939cf3d933478
Reviewed-on: https://review.typo3.org/53906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] Add composer dependencies to individual packages 91/53891/2
Helmut Hummel [Tue, 5 Sep 2017 08:57:06 +0000 (10:57 +0200)]
[BUGFIX] Add composer dependencies to individual packages

For the individual (subtree splitted) packages to work,
we need to add dependencies of typo3/cms to these
packages.

Since most dependencies are direct dependencies to typo3/cms-core
we can simply add them to this packge.

Resolves: #82295
Releases: master, 8.7
Change-Id: I69defd8dc745c648b60c2ec110b3be31cdf50b40
Reviewed-on: https://review.typo3.org/53891
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[SECURITY] Disallow pht as file extension 00/53900/2
Susanne Moog [Tue, 5 Sep 2017 09:37:08 +0000 (11:37 +0200)]
[SECURITY] Disallow pht as file extension

Some web servers allow and accept pht files as PHP files
and execute them. Thus, pht should be part of the default
file deny pattern and PHP file extensions.

Resolves: #82078
Releases: master, 8.7, 7.6
Security-Commit: 11e39b2ff8ff037379fe9e9e819728fe64fb058b
Security-Bulletin: TYPO3-CORE-SA-2017-007
Change-Id: I0b06badbf505761065c3c3881ff0fd2493954884
Reviewed-on: https://review.typo3.org/53900
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[SECURITY] Remove version from default User-Agent 99/53899/2
Susanne Moog [Tue, 5 Sep 2017 09:37:01 +0000 (11:37 +0200)]
[SECURITY] Remove version from default User-Agent

TYPO3 does no longer send the concrete TYPO3 version as
part of the default User-Agent header when doing requests.

Resolves: #82072
Releases: master, 8.7, 7.6
Security-Commit: 48139416459ed6a79b1bc9c018371575fa97591b
Security-Bulletin: TYPO3-CORE-SA-2017-006
Change-Id: Iafa15ce1d3f967e50124e37a8d0aff4a1d41e5ef
Reviewed-on: https://review.typo3.org/53899
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[SECURITY] Respect permissions of storages in a file collection 98/53898/2
Georg Ringer [Tue, 5 Sep 2017 09:36:54 +0000 (11:36 +0200)]
[SECURITY] Respect permissions of storages in a file collection

If a user creates a sys_file_collection record, only those
storage records must be shown which are allowed for the
user.

Resolves: #82029
Releases: master, 8.7, 7.6
Security-Commit: 2592124689d6625e394a2f63ca1a12510c402609
Security-Bulletin: TYPO3-CORE-SA-2017-005
Change-Id: Idf5b79d6939f54edeb20a432ea41e9341e970bc5
Reviewed-on: https://review.typo3.org/53898
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[SECURITY] Escape record title in RecordsOverview 97/53897/2
Georg Ringer [Tue, 5 Sep 2017 09:36:47 +0000 (11:36 +0200)]
[SECURITY] Escape record title in RecordsOverview

The record title must be properly escaped.

Resolves: #81967
Releases: master, 8.7
Security-Commit: de3b93658fc0ab0542903d943455c33834456a60
Security-Bulletin: TYPO3-CORE-SA-2017-004
Change-Id: I89a8c14fc6ce043d7dab09f63c9d820519a19532
Reviewed-on: https://review.typo3.org/53897
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[TASK] Synchronize composer.json with ext_emconf.php 24/53624/5
Helmut Hummel [Wed, 5 Jul 2017 05:44:24 +0000 (07:44 +0200)]
[TASK] Synchronize composer.json with ext_emconf.php

Description, dependencies between core packages and
core package versions are now in sync in ext_emconf.php
and composer.json

Now also added extension key information explicitly
in composer.json

What still should be done later is adding further
dependencies to these files if required.

This change was mostly automated using
helhum/ext-tools with the command:

typo3cms composerjson:sync 'typo3/sysext/*'

Resolves: #82003
Releases: master, 8.7
Change-Id: Ife913038142e8ecc137d21d4d43e2cdf467fb0f9
Reviewed-on: https://review.typo3.org/53624
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser 74/53874/3
Georg Ringer [Mon, 4 Sep 2017 06:44:56 +0000 (08:44 +0200)]
[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser

Remove a not needed </td> tag which has not been removed with the
refactoring.

Resolves: #82279
Releases: master, 8.7
Change-Id: I2077e9e0b0119e6b064b0a6d4ebb9c3dc1d848a4
Reviewed-on: https://review.typo3.org/53874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[TASK] Improve performance of Fluid TemplatePaths 62/53862/2
Claus Due [Mon, 28 Aug 2017 20:27:26 +0000 (22:27 +0200)]
[TASK] Improve performance of Fluid TemplatePaths

This patch improves the performance of TemplatePaths
in two ways:

* GeneralUtility::removeDotsFromTS() is called on a far
  smaller array instead of all TypoScript.
* Fallback paths are allowed to be cached in the runtime
  cache which avoids re-reading TypoScript when no
  paths are configured in TS.

Saves several thousand calls to removeDotsFromTs
which in turn saves several tens of thousands of calls
to in_array.

Change-Id: Ib8aef69dc9136d355441ac05f21fe391e524eacc
Resolves: #82232
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Fix broken validation translation form docs 61/53861/2
Justus Leon Moroni [Thu, 31 Aug 2017 16:59:39 +0000 (18:59 +0200)]
[TASK] Fix broken validation translation form docs

The TranslationService uses the additional key 'error' in its translations
of the validation errors.

See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Service/TranslationService.php#L428.

Releases: master,8.7
Resolves: #82264
Change-Id: Id00b60de0bf1b2b882f583f538be9bc8e40c010f
Reviewed-on: https://review.typo3.org/53861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[TASK] Remove suhosin checks 57/53857/5
Christian Kuhn [Thu, 31 Aug 2017 19:12:27 +0000 (21:12 +0200)]
[TASK] Remove suhosin checks

The patch removes suhosin specific checks from ext:install
environment checks. Core v8 needs at least PHP 7.0 and the
suhosin project is still in a pre-alpha "don't use in production"
state and can be considered dead and is of little help in
our application in current state and likely not used anywhere.
For the sake of a cleaner check class, suhosin specific checks
are removed. This has been done in master already with the
related issue.

Change-Id: If003a8db37660662c65290a1e1bf25ef61375b80
Resolves: #82267
Related: #82257
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Improve exception for invalid transOrigPointerField 46/53846/2
Mathias Brodala [Wed, 23 Aug 2017 06:52:09 +0000 (08:52 +0200)]
[TASK] Improve exception for invalid transOrigPointerField

Resolves: #82175
Releases: master, 8.7
Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed
Reviewed-on: https://review.typo3.org/53846
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Upgrade version of D3.js to version 4.10.0 29/53829/2
Anders Kostending [Mon, 24 Jul 2017 07:37:16 +0000 (09:37 +0200)]
[TASK] Upgrade version of D3.js to version 4.10.0

Updates D3.js to the latest release version, 4.10.0.

Release notes:
https://github.com/d3/d3/releases/tag/v4.10.0

Fixes:
 * Add d3.areaRadial; deprecate d3.radialArea.
 * Add d3.lineRadial; deprecate d3.radialLine.
 * Add d3.pointRadial.
 * Add zoom.translateTo.
 * Re-implement d3.packEnclose using Matoušek-Sharir-Welzl.
 * Fix d3.packSiblings to center the circles more consistently
 around a fixed origin.
 * Fix axis rendering when a scale has a non-numeric range.
 * Fix interval.offset on filtered time intervals when step
 is negative.
 * Fix invocation of requestAnimationFrame in Edge.
 * Invoke nest.sortValues comparator prior to nest.rollup
 aggregator.
 * Drag & zoom behaviors now only register touch event
 listeners when touch is supported.
 * Drag & zoom behaviors now set the touch-action style to
 “none” when touch is supported.

Resolves: #81945
Releases: master, 8.7
Change-Id: Idcd0826d2bd50467558d1bd6229d84651b93f4b0
Reviewed-on: https://review.typo3.org/53829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Fix broken identifier in form docs 44/53844/2
Daniel Siepmann [Tue, 29 Aug 2017 09:32:04 +0000 (11:32 +0200)]
[TASK] Fix broken identifier in form docs

Within the docs, an incorrect identifier is used for a custom finisher.
This has been fixed and is in line with the example code above.

Releases: master,8.7
Resolves: #82234
Change-Id: I41881f825e7961f4945805360683c3189f2f9fcb
Reviewed-on: https://review.typo3.org/53844
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] EXT:form - use configured finisher identifiers for translations 43/53843/2
Ralf Zimmermann [Fri, 30 Jun 2017 08:12:19 +0000 (10:12 +0200)]
[BUGFIX] EXT:form - use configured finisher identifiers for translations

Use the configured finisher identifier for translation keys instead of
the finisher class name.

Resolves: #81591
Releases: master, 8.7
Change-Id: Ib78e942121b4b6e299ae394c30261603760444f7
Reviewed-on: https://review.typo3.org/53843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Prevent command exit status overflow to non-error status 39/53839/4
Oliver Eglseder [Wed, 30 Aug 2017 13:53:48 +0000 (15:53 +0200)]
[BUGFIX] Prevent command exit status overflow to non-error status

If a command throws an exception the exception code will be used
as exit code of the CLI command. This will result in an integer overflow
since exit codes are limited to 255, whereas 255 is reserved for PHP.
(See PHP exit documentation)

This commit checks if the return code will result in a 0 and change it to 1 instead.
In TYPO3 v9 the exit code is limited by Symfony Console so no change in master is needed.

Resolves: #82246
Releases: 8.7, 7.6
Change-Id: Id85fcbb61d6f0b4dd7f5ee9a1aaf55e648819b9c
Reviewed-on: https://review.typo3.org/53839
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update typo3/testing-framework to 1.1.2 41/53841/2
Christian Kuhn [Thu, 31 Aug 2017 10:45:52 +0000 (12:45 +0200)]
[TASK] Update typo3/testing-framework to 1.1.2

Brings a bug fix in frontend functional test parsing.

Change-Id: I3e95f4ee12069bbbfc225fb5045793273eff6f95
Resolves: #82256
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Use proper key name in db config 38/53838/2
Ludwig Rafelsberger [Wed, 30 Aug 2017 07:47:32 +0000 (09:47 +0200)]
[BUGFIX] Use proper key name in db config

Releases: master,8.7
Resolves: #82239
Change-Id: I90d4ecdb4917c567a652a7bf5d24b55b39d646fd
Reviewed-on: https://review.typo3.org/53838
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[TASK] Update CKEditor to 4.7.2 28/53828/3
Anders Kostending [Mon, 21 Aug 2017 10:38:12 +0000 (12:38 +0200)]
[TASK] Update CKEditor to 4.7.2

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/release-notes

Fixes:
 * Added Advanced Content Filter integration with the Justify plugin.
 * [Chrome] Fixed: Clicking the scrollbar throws an Uncaught TypeError:
 element.is is not a functionerror.
 * Fixed: Widgets cannot be properly pasted into a table cell.
 * Fixed: Internal cke_table-faked-selection-table class is visible
 in the Stylesheet Classes field of the Table Properties dialog.
 * [Edge] Fixed: Error thrown when pressing the Select All button
 in Source Mode.
 * Fixed: Double slash in the path to stylesheet needed by the
 Table Selection plugin.
 * Fixed: Unnecessary dependency on the Editor Toolbar plugin inside
 the Notification plugin.
 * Fixed: Error thrown into the browser console after opening the
 Styles Combo plugin menu in the editor without any selection.
 * Fixed: Double click does not open the dialog for modifying anchors
 inserted via the Link plugin.
 * [IE8-9] Fixed: Clicking inside an empty read-only editor throws
 an error.
 * [IE10] Fixed: Clicking below a single horizontal rule throws
 an error.
 * Fixed: The range.cloneContents method selects the whole element when
 the selection starts at the beginning of that element.
 * Fixed: The range.extractContents method returns an incorrect result
 when multiple nodes are selected.
 * Fixed: The elementPath.contains method incorrectly excludes the last
 element instead of root when the fromTop parameter is set to true.
 * Fixed: SCAYT leaves underlined word after the CKEditor Replace
 dialog corrects it.
 * Added the CKEDITOR.dom.nodeList.toArray method which returns an
 array representation of a node list.

Resolves: #82143
Releases: master, 8.7
Change-Id: I6f6037e48d768e4a2887c799c1791f3201ce40c8
Reviewed-on: https://review.typo3.org/53828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] Always show input field for empty link fields 26/53826/2
Johannes Schlier [Wed, 23 Aug 2017 14:34:01 +0000 (16:34 +0200)]
[BUGFIX] Always show input field for empty link fields

The trigger values can be hardcoded here, as the previous
filtering only gives us fields for which we want to hide
the explanation and show the input field.
Previuosly each time a new link field was created  (as an
IRRE element for example) the input and explanation fields
were triggered. This created confusion with editors and
also broke the trigger button, so that fields that were in
the explanation mode could not be triggered back to input mode.

Resolves: #82179
Releases: master, 8.7
Change-Id: Ic92129c6cdafe5fab19fbc76b9e9b7713b9e8736
Reviewed-on: https://review.typo3.org/53826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Make extbase language handling consistent with TYPO3 v7 20/53820/2
Tymoteusz Motylewski [Wed, 23 Aug 2017 19:05:56 +0000 (21:05 +0200)]
[BUGFIX] Make extbase language handling consistent with TYPO3 v7

During doctrine migration a change of behaviour was introduced.
In v7 when a translated record is hidden, it's not shown,
while before this patch, a record from default language was shown.

Resolves: #82161
Releases: master, 8.7
Change-Id: Ib8127eff7218f9dd064febbab4956af44f3164b9
Reviewed-on: https://review.typo3.org/53820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] Extbase distinct query result handling 70/53670/5
Oliver Hader [Mon, 21 Aug 2017 08:13:20 +0000 (10:13 +0200)]
[BUGFIX] Extbase distinct query result handling

Since Doctrine DBAL has been integrated into the TYPO3 core during
version 8 development and Extbase queries have been adjusted with
TYPO3 version 8.4.0, the behavior on distinct query results were
mixed up as well.

Extbase queries using the query-builder until TYPO3 7 LTS contained a
dedicated `SELECT DISTINCT` when retrieving data which lead to unique
entities, especially when implicit `LEFT JOIN` statements have been
added to the query to resolve cardinalities of the types one-to-many
and many-to-many.

Besides that using `GROUP BY` is not reliable in this particular
Extbase scenario. Further details can be found in MySQL documentation:
https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html

Change-Id: Ic5fd1d4752eefec7fcff37d8d62f55ea7299e8d6
Resolves: #80380
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit f8aaf85cc5602a45a6f6b949a77ce109bbacc8f8)
Reviewed-on: https://review.typo3.org/53670
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[TASK] Cleanup .gitignore 63/53663/6
Philipp Gampe [Sun, 13 Aug 2017 10:39:30 +0000 (12:39 +0200)]
[TASK] Cleanup .gitignore

Make sure root level excludes are prefix with
a forward slash (/).

Sort the .gitignore into logical groups.

Releases: 7.6, 8.7, master
Resolves: #81992
Change-Id: If1cb4105e57fb7ab3c28448abc3eaeb898da60e3
Reviewed-on: https://review.typo3.org/53663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Update php-cs-fixer to 2.5.0 95/53795/2
Wouter Wolters [Wed, 23 Aug 2017 16:45:54 +0000 (18:45 +0200)]
[TASK] Update php-cs-fixer to 2.5.0

Add 2 new rules

* no_superfluous_elseif
* no_useless_else

Both rules only apply if the if-statement contains a return. If this
is the case the obsolete else/elseif part is dropped.

Resolves: #82183
Releases: master,8.7
Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a
Reviewed-on: https://review.typo3.org/53795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class 93/53793/3
Mathias Brodala [Fri, 18 Aug 2017 12:53:03 +0000 (14:53 +0200)]
[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class

Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7
Resolves: #82131
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] CGL fixes after upgrade to php-cs-fixer 1.4 92/53792/2
Christian Kuhn [Tue, 22 Aug 2017 17:33:24 +0000 (19:33 +0200)]
[TASK] CGL fixes after upgrade to php-cs-fixer 1.4

Change a series of cgl details after update of php-cs-fixer
from 1.0 to 1.4.

Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f
Resolves: #82171
Related: #82164
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Mark not set Install Tool password as secure 86/53786/3
Frans Saris [Mon, 21 Aug 2017 13:59:35 +0000 (15:59 +0200)]
[BUGFIX] Mark not set Install Tool password as secure

To completely disable the Install Tool you can just leave the
`installToolPassword` value empty in your LocalConfiguration.
Problem here is that not all password hashing methods can handle an
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install
password hashing/check when there is no password.

Releases: master, 8.7
Resolves: #82147
Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5
Reviewed-on: https://review.typo3.org/53786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
21 months ago[BUGFIX] Throw exception if encryption key is not set 84/53784/2
Helmut Hummel [Thu, 17 Aug 2017 16:41:39 +0000 (18:41 +0200)]
[BUGFIX] Throw exception if encryption key is not set

The encryption key is a vital part to ensure security
of TYPO3. Not having it set (by accident) can lead
to severe security issues.

Therefore enforce it to be set and throw an exception
in case it isn't, instead of just reporting a warning.

Releases: master, 8.7, 7.6
Resolves: #82169
Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3
Reviewed-on: https://review.typo3.org/53784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[!!!][TASK] Extension manager: Drop "Download SQL Dump" 83/53783/3
Christian Kuhn [Tue, 22 Aug 2017 19:13:54 +0000 (21:13 +0200)]
[!!!][TASK] Extension manager: Drop "Download SQL Dump"

Remove the "Download SQL Dump" button from extension manager.

Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070
Resolves: #82148
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] travis-ci: Execute unit test only 81/53781/2
Christian Kuhn [Tue, 22 Aug 2017 18:11:00 +0000 (20:11 +0200)]
[TASK] travis-ci: Execute unit test only

travis-ci still chockes on executing the functional tests
which take ages, even with various tricks in place.
The patch reduces the travis execution to unit tests
only since all main tests are executed via our bamboo
environment anyway beforehand.

Change-Id: I809f38d79f0ac7848e6b7e155d35aab575f4d81a
Resolves: #82172
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] travis-ci: Less parallel jobs 78/53778/2
Christian Kuhn [Tue, 22 Aug 2017 16:54:52 +0000 (18:54 +0200)]
[TASK] travis-ci: Less parallel jobs

travis-ci still chockes on functional tests, even if
splitting them among lots of single tasks. Run less
tests in parallel and split to ever more jobs to have
a higher chance for 10 minute output with given cpu
constraints.

Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7
Resolves: #82170
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl 77/53777/2
Jan Helke [Fri, 4 Aug 2017 10:04:38 +0000 (12:04 +0200)]
[TASK] Remove file Tests/Functional/Fixtures/Frontend/request.tpl

This file is only used by typo3/testing-framework and has
been moved to that repository since version 1.1.1.

Releases: master, 8.7
Resolves: #81900
Change-Id: I5f88bd89c4cadd2fe65f4d0bc9f4494e172f4d2a
Reviewed-on: https://review.typo3.org/53777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update typo3/testing-framework to 1.1.1 74/53774/2
Christian Kuhn [Tue, 22 Aug 2017 16:30:27 +0000 (18:30 +0200)]
[TASK] Update typo3/testing-framework to 1.1.1

Fix three issues blocking core patches.

Change-Id: I07deff6294061d04e15bd1a7707e504413bb30c9
Resolves: #82168
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update dev dependencies 72/53772/3
Wouter Wolters [Tue, 22 Aug 2017 14:26:33 +0000 (16:26 +0200)]
[TASK] Update dev dependencies

* codeception/codeception (2.3.3 => 2.3.5)
* enm1989/chromedriver (2.30 => 2.31)
* friendsofphp/php-cs-fixer (v2.0.0 => v2.4.1)

Resolves: #82164
Releases: master, 8.7
Change-Id: I2543b99a7e4751c09ebd733335cc3eddc025d189
Reviewed-on: https://review.typo3.org/53772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Functional tests for translated tt_content rendering in Extbase 56/53756/2
Tymoteusz Motylewski [Sat, 19 Aug 2017 17:16:49 +0000 (19:16 +0200)]
[TASK] Functional tests for translated tt_content rendering in Extbase

Introduce and Extbase version of the LocalizedContentRenderingTest.
It tests how language related TS settings influences content rendering.

Also changes exception code in ContentController, to make bamboo happy.

This test suite is documenting current behaviour, which is in fact
inconsistent with TypoScript tt_content rendering.

The next step is to provide a fix for extbase with a feature switch,
so this test suite will become a version with feature swich being disabled.

Resolves: #81823
Releases: master, 8.7, 7.6
Change-Id: Ia616e5089b0209cfb895216726f7192f39c88a45
Reviewed-on: https://review.typo3.org/53756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[TASK] Remove non existing param from checkForUpdate 55/53755/2
Frans Saris [Mon, 21 Aug 2017 09:49:05 +0000 (11:49 +0200)]
[TASK] Remove non existing param from checkForUpdate

Releases: master, 8,7
Resolves: #82144
Change-Id: I24b2d57e37f6ff95b7ec7bdab7cda0f21e85c90b
Reviewed-on: https://review.typo3.org/53755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[TASK] travis-ci: Split functional tests into more parts 53/53753/2
Christian Kuhn [Mon, 21 Aug 2017 11:43:47 +0000 (13:43 +0200)]
[TASK] travis-ci: Split functional tests into more parts

With the ever growing number of functional tests, we
split the suite into more parts to prevent
"No output has been received in the last 10 mins".

Change-Id: I55665c723f91f77347b376992f7a7a28da67b0fd
Resolves: #82145
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Catch error due to invalid record in Linkvalidator scheduler task 41/53741/2
Andreas Fernandez [Tue, 15 Aug 2017 12:42:06 +0000 (14:42 +0200)]
[BUGFIX] Catch error due to invalid record in Linkvalidator scheduler task

Resolves: #82103
Releases: master, 8.7, 7.6
Change-Id: I3e04559c05381c49ab390dc3ad0d3eebddc5a57f
Reviewed-on: https://review.typo3.org/53741
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record 46/53746/2
Wouter Wolters [Tue, 15 Aug 2017 18:05:14 +0000 (20:05 +0200)]
[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record

The type field contains a non existing field. Do not select this
field in the query.

Resolves: #82105
Releases: master, 8.7, 7.6
Change-Id: I9840712f4f87135740512ddf91a2b921b2515612
Reviewed-on: https://review.typo3.org/53746
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Prevent XSS in scheduler extension 36/53736/3
Wouter Wolters [Thu, 17 Aug 2017 11:37:20 +0000 (13:37 +0200)]
[BUGFIX] Prevent XSS in scheduler extension

Releases: master,8.7,7.6
Resolves: #82079
Change-Id: I21a6ebcff4ebd0c6f2d2c83e0aa6d9e2c03d32d9
Reviewed-on: https://review.typo3.org/53736
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
21 months ago[TASK] Change upper limits for endtime of various records 35/53735/2
Georg Ringer [Thu, 3 Aug 2017 18:23:56 +0000 (20:23 +0200)]
[TASK] Change upper limits for endtime of various records

Instead of using 2020 use the technical limit of 32bit
which is 2038.

Resolves: #81940
Releases: master, 8.7
Change-Id: If0b1bee101b4917d7a974dd0e91f79bc24139227
Reviewed-on: https://review.typo3.org/53735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[BUGFIX] Fix hide and delete button in SysAction->RecordList 32/53732/2
Wouter Wolters [Fri, 18 Aug 2017 11:50:05 +0000 (13:50 +0200)]
[BUGFIX] Fix hide and delete button in SysAction->RecordList

The AjaxDataHandler JavaScript must be loaded to add the on
click handlers.

Resolves: #81685
Releases: master,8.7
Change-Id: If3616ee99a73171be3a878abce40de7e5c0e8225
Reviewed-on: https://review.typo3.org/53732
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
21 months ago[BUGFIX] Prevent XSS in PageLayoutController 33/53733/2
Wouter Wolters [Thu, 17 Aug 2017 11:32:01 +0000 (13:32 +0200)]
[BUGFIX] Prevent XSS in PageLayoutController

Correctly use htmlspecialchars for the link.

Resolves: #82077
Releases: master,8.7,7.6
Change-Id: I87ea4010aa187f5f601c31423fb1a0fc05a23107
Reviewed-on: https://review.typo3.org/53733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[BUGFIX] Drop sorting in COUNT() query in list module 80/53680/2
Susanne Moog [Fri, 11 Aug 2017 11:07:18 +0000 (13:07 +0200)]
[BUGFIX] Drop sorting in COUNT() query in list module

The list module throws an exception on mssql as there
is a COUNT(*) query done with an ORDER BY sorting.

Sorting the count is pretty useless and has been
removed.

Change-Id: I8d94da2dc3dfecb7c20308180e9916b16b152b01
Resolves: #82084
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Remove leftover code for db_mountpoints in ActionTask 27/53727/2
Wouter Wolters [Thu, 17 Aug 2017 14:00:59 +0000 (16:00 +0200)]
[TASK] Remove leftover code for db_mountpoints in ActionTask

Resolves: #81999
Releases: master,8.7
Change-Id: Ib3311a4f10d7393b41c04fd193e8614d5984f35f
Reviewed-on: https://review.typo3.org/53727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Correct type of argument passed to BackendUtility::viewOnClick 28/53728/2
Tymoteusz Motylewski [Thu, 17 Aug 2017 15:12:41 +0000 (17:12 +0200)]
[BUGFIX] Correct type of argument passed to BackendUtility::viewOnClick

Third argument passed to BackendUtility::viewOnClick should be
an array or null.

Resolves: #82124
Releases: master, 8.7
Change-Id: I330d2fcbbc30d9f22f4758ad84599755a1d707ad
Reviewed-on: https://review.typo3.org/53728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Use DriverInterface instead AbstractDriver for method signature 25/53725/2
Franz Koch [Sat, 12 Aug 2017 08:14:28 +0000 (10:14 +0200)]
[BUGFIX] Use DriverInterface instead AbstractDriver for method signature

FAL drivers are not obligated to extend the AbstractDriver but only
to implement the DriverInterface. Having custom drivers that are not
based on AbstractDriver (because they are f.e. non hierarchical)
currently causes an Exception because PreviewProcessing expects an
instance of AbstractDriver as method argument.

This patch changes te signature from AbstractDriver to DriverInterface.

Resolves: #82114
Releases: master, 8.7, 7.6
Change-Id: Ia27c6c1c7510ecfe5afd0f7d8bedf81bf3d31c84
Reviewed-on: https://review.typo3.org/53725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Changes indentation in new page wizard 16/53716/2
Thomas Löffler [Mon, 14 Aug 2017 16:26:45 +0000 (18:26 +0200)]
[BUGFIX] Changes indentation in new page wizard

On a page without subpages the indentation for
creating a new page below this page was wrong.
This fix changes the indentation in this special case.

Resolves: #72011
Releases: master, 8.7, 7.6
Change-Id: I505a96126ab8cf69ebae32c5a84aa9dbfa59c87f
Reviewed-on: https://review.typo3.org/53716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Extend Lowlevel lost_files to accept customPath 60/53660/2
Tomas Norre Mikkelsen [Thu, 13 Jul 2017 16:08:37 +0000 (18:08 +0200)]
[BUGFIX] Extend Lowlevel lost_files to accept customPath

This allows the lowlevel lost_files cleaner to use
customPaths as input too.

Resolves: #72202
Releases: master,8.7
Change-Id: I1481d036c8c337eee54a97d8a192d6a39a6af404
Reviewed-on: https://review.typo3.org/53660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Do not allow users to edit doktypes without permissions 61/53661/2
Markus Hoelzle [Wed, 22 Feb 2017 09:27:49 +0000 (10:27 +0100)]
[BUGFIX] Do not allow users to edit doktypes without permissions

Disallow backend users to edit pages which doktypes are not allowed
via backend usergroup permissions.

Resolves: #79954
Releases: master, 8.7, 7.6
Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720
Reviewed-on: https://review.typo3.org/53661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Implode array values in SaveToDatabaseFinisher 05/53705/2
Andreas Fernandez [Wed, 9 Aug 2017 10:11:47 +0000 (12:11 +0200)]
[BUGFIX] Implode array values in SaveToDatabaseFinisher

Array values being processed by SaveToDatabaseFinisher are now
imploded by a comma. This may happen when using a `MultiCheckbox` element.

Resolves: #82061
Releases: master, 8.7
Change-Id: Ic84af11ba00611aa89b043cd3b1c36dedb356c68
Reviewed-on: https://review.typo3.org/53705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] YouTubeRenderer "controls" option 08/53708/2
Česlav Przywara [Mon, 7 Aug 2017 09:40:11 +0000 (11:40 +0200)]
[BUGFIX] YouTubeRenderer "controls" option

The "controls" parameter appended to YouTube embed URL is either set to
value provided in $options array or to default backwards-compatible
value (controls=2).

Specifically, if controls option is set to 0, the controls parameter
must be present in URL, because default value for it is 1.

Fix is applied to related unit test too.

Resolves: #82044
Releases: master, 8.7, 7.6
Change-Id: I1519b5f515f85eb473f590762171b250d26f32c4
Reviewed-on: https://review.typo3.org/53708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[TASK] Allow to override RTE config presets via PageTS 06/53706/2
Hannes Lau [Sun, 16 Jul 2017 11:51:58 +0000 (13:51 +0200)]
[TASK] Allow to override RTE config presets via PageTS

Reorder the steps to load the RTE configuration, so that presets can be
overridden by additional PageTS configuration.

Resolves: #81882
Releases: master, 8.7
Change-Id: I0189822f8a4a0cf3b8293d6651eac4f8b5159566
Reviewed-on: https://review.typo3.org/53706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[BUGFIX] _LOCAL_LANG overwrite via TypoScript with nested keys 04/53704/2
Susanne Moog [Tue, 15 Aug 2017 07:41:08 +0000 (09:41 +0200)]
[BUGFIX] _LOCAL_LANG overwrite via TypoScript with nested keys

If language labels are set for the top level key and sub
keys in TypoScript the top level key was not taken into
account as it got stored with 'typoScriptNodeValue' as key.

Special handling for that specific key was introduced, to
make overwriting of top level keys possible again.

Change-Id: Ibd5f5a939b1de530ba93840cfb7ba5ab5bc85c2f
Resolves: #81095
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53704
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[TASK] Cover rendering of hidden tt_content with functional tests 02/53702/2
Tymoteusz Motylewski [Mon, 31 Jul 2017 15:16:14 +0000 (17:16 +0200)]
[TASK] Cover rendering of hidden tt_content with functional tests

Two new cases are covered in LocalizedContentRenderingTest:
- when record is hidden in default language but its translation
  is not hidden
- when visible default language record has hidden translation

Resolves: #82012
Releases: master, 8.7, 7.6
Change-Id: I924c0082f010bf9d9de642111cc3d65844f00f1f
Reviewed-on: https://review.typo3.org/53702
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Filter http/verify option for guzzle to boolean 98/53698/3
Wolfgang Klinger [Mon, 7 Aug 2017 06:30:26 +0000 (08:30 +0200)]
[BUGFIX] Filter http/verify option for guzzle to boolean

guzzle expects a real boolean value.
This fix filters the given verify option to either the boolean
equivalent or leaves any other string (path to certificate) as is.

Resolves: #78729
Releases: master, 8.7
Change-Id: I3cc74692303e74b724683e54edad10ecb37e75c7
Reviewed-on: https://review.typo3.org/53698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Do not render <li> in section menu when CE has no header 97/53697/2
Tymoteusz Motylewski [Mon, 14 Aug 2017 14:14:11 +0000 (16:14 +0200)]
[BUGFIX] Do not render <li> in section menu when CE has no header

Section menu is now not rendering empty <li> when CE has no header.

Resolves: #82099
Releases: master, 8.7
Change-Id: I095be0050ac9fa6c4a70ea4d4c942c01def0432f
Reviewed-on: https://review.typo3.org/53697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] EXT:form - fix templateRootPaths support for email finishers 92/53692/2
Ralf Zimmermann [Fri, 30 Jun 2017 09:17:05 +0000 (11:17 +0200)]
[BUGFIX] EXT:form - fix templateRootPaths support for email finishers

Fixes "templateRootPaths" support for email finishers.
"templatePathAndFilename" is still functional to avoid breaking changes.

Resolves: #80974
Releases: master, 8.7
Change-Id: Ic8055a925c0608a9166f98b52c34435ac2a56082
Reviewed-on: https://review.typo3.org/53692
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Set anchor in all preview links of content elements 91/53691/2
Dan Untenzu [Tue, 4 Jul 2017 12:06:03 +0000 (14:06 +0200)]
[BUGFIX] Set anchor in all preview links of content elements

The button »View webpage« in the list module opens a popup
with a link to the current page and an anchor to the
selected content element. This behaviour is expected as well
while selecting the »Show« option in the context menu of
content elements or the »Save and view page« button in
edit forms. Both places didn't added the anchor.

Resolves: #81250
Releases: master, 8.7
Change-Id: Ifa8da940eb12820f9b0c54957928fd8d9f3703b5
Reviewed-on: https://review.typo3.org/53691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] parseInt values before comparison for Fluid be.widget.paginate 88/53688/2
Wolfgang Klinger [Sat, 12 Aug 2017 18:15:48 +0000 (20:15 +0200)]
[BUGFIX] parseInt values before comparison for Fluid be.widget.paginate

Resolves: #82034
Releases: master, 8.7
Change-Id: If56166e33c048a45b01ab70a5938a51525a49db4
Reviewed-on: https://review.typo3.org/53688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Allow translating content on MSSQL 81/53681/2
Susanne Moog [Fri, 11 Aug 2017 10:31:02 +0000 (12:31 +0200)]
[BUGFIX] Allow translating content on MSSQL

Translating content on MSSQL installations has
been impossible due to SQL errors.

The GROUP BY statements in page module and
localizationRepository have been fixed.

Change-Id: I20a4778e3c0858aca80060ba333ce6a47e42ce38
Resolves: #82085
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53681
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
21 months ago[BUGFIX] Let all toplevel exceptions extend the core exception 75/53675/2
Mathias Brodala [Mon, 7 Aug 2017 10:50:16 +0000 (12:50 +0200)]
[BUGFIX] Let all toplevel exceptions extend the core exception

This is a small step to unify exception handling in TYPO3 by
ensuring no internal and 3rd party code is forced to catch the
toplevel PHP exception.

This change e.g. actually allows the FormPagePreviewRenderer to
handle form loading errors.

Resolves: #82052
Releases: master, 8.7
Change-Id: I5cb0b8f2c56a6bbbecc34d87474d6d8b3ad2015c
Reviewed-on: https://review.typo3.org/53675
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Add cglFixMyCommit.bat 78/53678/2
Susanne Moog [Thu, 10 Aug 2017 07:09:38 +0000 (09:09 +0200)]
[TASK] Add cglFixMyCommit.bat

This patch introduces a bat file to run php-cs-fixer
with TYPO3 core config on Windows. It does not disable xdebug
like its linux counterpart.

Change-Id: If4543cac0b5026a8eab469f16e234130f999ba78
Resolves: #81949
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Add sorting to group by for SQL compatibility 76/53676/2
Susanne Moog [Fri, 11 Aug 2017 08:16:01 +0000 (10:16 +0200)]
[BUGFIX] Add sorting to group by for SQL compatibility

Page module, view module and edit document selected data
with an incomplete group by statement, missing the sorting
column. This resulted in an error on mssql servers.

The sorting field was added to the relevant queries.

Change-Id: If1fb314542e0f27cdf18989fa2b8427c1e31e2d3
Resolves: #79298
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53676
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
21 months ago[TASK] Move install tool entry point to typo3/install.php 20/53620/6
Helmut Hummel [Mon, 24 Jul 2017 13:57:28 +0000 (15:57 +0200)]
[TASK] Move install tool entry point to typo3/install.php

To streamline and unify the entry scripts, the install tool
entry point is now moved to typo3/install.php

Calling the old entry scripts and the shortcut typo3/install/
is deprecated.

All access to public resources is changed to properly use
the resource view helper, so that the path to the assets
are not hard coded any more.

Resolves: #81951
Releases: master, 8.7
Change-Id: Ia8827130bb041802e743767907d16269cda2fef0
Reviewed-on: https://review.typo3.org/53620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Sedef Serin <s.serin@neusta.de>