Packages/TYPO3.CMS.git
2 months ago[TASK] Move TYPO3_version constant to a dedicated class 40/62740/8
Benni Mack [Wed, 18 Dec 2019 12:48:50 +0000 (13:48 +0100)]
[TASK] Move TYPO3_version constant to a dedicated class

To optimize TYPO3 for Opcaching and speeding up performance,
as well as simplyfing the bootstrap (also for the testing framework)
the constants
* TYPO3_version
* TYPO3_branch
are moved to a new PHP class "Typo3Version".

This reduces the necessity to define the constants, and since
TYPO3 Bootstrap continues to use the class, the constants
are defined in the constructor for TYPO3 v10, and will be removed
in TYPO3 v11.

Resolves: #90007
Releases: master
Change-Id: I18942023c0e234a328d45f724a6b3092c801982c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62740
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 months ago[TASK] Migrate linkvalidator results from serializable to json storage 31/62631/2
Benni Mack [Fri, 13 Dec 2019 22:14:25 +0000 (23:14 +0100)]
[TASK] Migrate linkvalidator results from serializable to json storage

LinkAnalyzer now stores the response as JSON instead of PHP serialize.

A fallback mechanism when unpacking uses unserialize() as fallback
to keep records in the database.

Resolves: #89944
Releases: master
Change-Id: Ic3a2ba058d916936cc5c46a0a8e279bc07bfe60c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62631
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Remove unused property in RelationHandler 29/62829/3
Benni Mack [Tue, 7 Jan 2020 22:45:54 +0000 (23:45 +0100)]
[TASK] Remove unused property in RelationHandler

RelationHandler->dbPaths was added in 2003 by kasper,
but NEVER ever used since then in TYPO3 Core, or does it
serve any purpose.

So this property can safely be removed.

Resolves: #90065
Releases: master
Change-Id: I361925e68e1025436799ceb97c7e1156d45e250a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62829
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Refactor & streamline TypoLinkViewHelper implementations 75/62775/5
Oliver Hader [Fri, 27 Dec 2019 20:12:19 +0000 (21:12 +0100)]
[TASK] Refactor & streamline TypoLinkViewHelper implementations

* avoid assigning and forwarding multiple variables
* preparation for further enhancements of view helpers
* Uri UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest) and to 1/3 a simple additionalParams case
* Link UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest)

Resolves: #90022
Releases: master
Change-Id: If65e42d4ca8085855f3f335d1eb2604be9a36fe0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Add max_line_length to .editorconfig for rst files 18/62818/2
Chris Müller [Sat, 4 Jan 2020 18:28:03 +0000 (19:28 +0100)]
[TASK] Add max_line_length to .editorconfig for rst files

The maximum line length of documentation files (80 characters)
should be reflected in the .editorconfig as described in
https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/GeneralConventions/CodingGuidelines.html#line-length

Resolves: #90054
Releases: master, 9.5
Change-Id: Ib1c3f2f2fbae999b7d157949f1a59876c2ff451d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62818
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Use PermutationUtility::meltStringItems in test cases 21/62821/4
Oliver Hader [Mon, 6 Jan 2020 10:34:53 +0000 (11:34 +0100)]
[TASK] Use PermutationUtility::meltStringItems in test cases

Resolves: #90057
Releases: master, 9.5
Change-Id: Ifee8153c4f49b7fdde544a51bc19ee7d6e21b323
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62821
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[DOCS] Update Deprecation 79440 Changelog entry 22/62822/5
Naderio [Mon, 6 Jan 2020 11:40:35 +0000 (11:40 +0000)]
[DOCS] Update Deprecation 79440 Changelog entry

Correct formatting of codeblock in "Link Browser" description.

Releases: master, 9.5, 8.7
Resolves: #90058
Change-Id: Ifbfff20a38cadef84e7e9c500fb846f2bbdccd3b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62822
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Rudy Gnodde <rudy@famouswolf.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Rudy Gnodde <rudy@famouswolf.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Introduce PermutationUtility 19/62819/7
Oliver Hader [Sat, 4 Jan 2020 20:03:26 +0000 (21:03 +0100)]
[TASK] Introduce PermutationUtility

Permutations are currently used in test cases - however it would
be possible to make use of this functionality in regular sources
as well. That's why corresponding methods are moved into a new
PermutationUtility implementation.

Resolves: #90055
Releases: master, 9.5
Change-Id: I05d978ada2021c7db1b7abeb8a21a825472ae8cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62819
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[FEATURE] Add argument "fields" to editRecord ViewHelpers 98/62298/8
Sybille Peters [Mon, 11 Nov 2019 15:24:58 +0000 (16:24 +0100)]
[FEATURE] Add argument "fields" to editRecord ViewHelpers

The <be:link.editRecord> and <be:url.editRecord> now have an option
argument "fields" which can be used to limit the edit form to only
these fields (instead of the entire record).

The fields should be passed in a comma separated list.

Resolves: #89644
Releases: master
Change-Id: I28913c072578aacd1da95c3bacebea35f8958bac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62298
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Return integer value from Command::execute() 80/62780/2
Michael Schams [Sun, 29 Dec 2019 05:32:05 +0000 (16:32 +1100)]
[BUGFIX] Return integer value from Command::execute()

Symfony version 5 expects an integer as the return value from
Command::execute() in the Command class. This bugfix returns 0 to
satisfy Symfony version 5 requirements.

Resolves: #90032
Releases: master
Change-Id: Id759707091f6695388b19b9d081beaf8c137c3cf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62780
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Use correct variable naming for PID value in DataHandler 12/62812/3
Benni Mack [Tue, 31 Dec 2019 11:49:04 +0000 (12:49 +0100)]
[BUGFIX] Use correct variable naming for PID value in DataHandler

The change of issue #90019 introduced a mis-spelling in hte variable naming,
where the variable was named "$tscPid" but the original code was "$tscPID"
which should be used as well.

Resolves: #90041
Releases: master
Change-Id: Idaad179968fb4b0953f7b12a8c7660793797cf02
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62812
Tested-by: Rudy Gnodde <rudy@famouswolf.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Rudy Gnodde <rudy@famouswolf.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Avoid starting superfluous PHP session 73/60173/7
Oliver Hader [Mon, 11 Mar 2019 23:33:37 +0000 (00:33 +0100)]
[TASK] Avoid starting superfluous PHP session

TYPO3 backend does not need PHP session handling since
it has its own session handling implementation.

Resolves: #90024
Releases: master
Change-Id: I9d8ccaf38c62b86d3b6945b2c631a2602b4aa73f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60173
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Clean up Page Permission handling in DataHandler 63/62763/6
Benni Mack [Fri, 27 Dec 2019 07:03:41 +0000 (08:03 +0100)]
[TASK] Clean up Page Permission handling in DataHandler

TYPO3's page permissions are based on five fields and a bitset.

- perms_userid
- perms_groupid
- perms_user
- perms_group
- perms_everybody

For permissions of a page there is
- show page ("show")
- edit page properties ("edit page")
- edit page contents / records ("edit content")
- delete page ("delete")
- create new subpages ("new")

In addition, these can be pre-set globally or via PageTSconfig.

The DataHandler currently uses a mix between strings and integers
for defining these values.

A new PagePermissionAssembler class builds together the page permissions
now, allowing to thin out certain parts of DataHandlers responsibility.

The following properties and methods are now deprecated:
- DataHandler->defaultPermissions
- DataHandler->pMap
- DataHandler->setTSconfigPermissions()
- DataHandler->assemblePermissions()

The methods
- DataHandler->doesRecordExist()
- DataHandler->recordInfoWithPermissionCheck()
should only be called with integers as permission argument in the future.

Resolves: #90019
Releases: master
Change-Id: I3724cb8661fe2b7cc5e1f8ab34d17dd4fa68c11b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62763
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] PopulatePageSlugs return the most recent slug 54/62754/3
Herman Kremer [Fri, 20 Dec 2019 09:40:08 +0000 (10:40 +0100)]
[BUGFIX] PopulatePageSlugs return the most recent slug

The populate page slugs functionality in de upgrade wizard does not
work correct for pages with multiple title adjustments.

Realurl keeps for every page title change a record in
tx_realurl_pathdata.

In order to get the latest change a order should be added to the
query in getSuggestedSlugs.

Resolves: #89964
Releases: master, 9.5
Change-Id: I4b7fad14fc559e6c9e8a4fb6f6a2a112a290d7e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Haupt <mail@danielhaupt.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Remove leftover "menu_type" occurrences 85/62785/2
Benni Mack [Mon, 30 Dec 2019 08:46:16 +0000 (09:46 +0100)]
[TASK] Remove leftover "menu_type" occurrences

With TYPO3 v8.6, the new Content Types for menus were introduced
where each menu type is not stored in the database field "menu_type"
anymore, but moved to a separate "CType" property. This change
was breaking, however some left-over code was there but never
removed. The code does not do anything anymore but handle the
special "menu_type" cases like in Page Module CType Previews
or categorization handling.

FYI: This is a pre-patch to streamline the category API.

Resolves: #90035
Releases: master
Change-Id: I180fc5b1e2d33f74cf05d2565ab11049cc361c49
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62785
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Avoid buildAccessibleProxy in tests 89/62789/3
Benni Mack [Mon, 30 Dec 2019 10:48:13 +0000 (11:48 +0100)]
[TASK] Avoid buildAccessibleProxy in tests

Tests should use getAccessibleMock() in all cases so
our testing API is used consistently everywhere.

The tests also show that some changes could be
made without having accessible proxies nowadays.

Resolves: #90037
Releases: master
Change-Id: I4a3f2948d9f645d736949fed4161cd91b1f3df0c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62789
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Replace usage of BaseTestCase::getUniqueId() with core function 74/62774/5
Anja Leichsenring [Fri, 27 Dec 2019 15:33:17 +0000 (16:33 +0100)]
[TASK] Replace usage of BaseTestCase::getUniqueId() with core function

Tests can use the core function StringUtility::getUniqueId(), after both
functions provide the same service.

Resolves: #90021
Releases: master
Change-Id: I57fc362e3e93b1aa963ea497f210144cab5cea1e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62774
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Apply rector set php71 51/62751/5
Alexander Schnitzler [Thu, 19 Dec 2019 14:49:31 +0000 (15:49 +0100)]
[TASK] Apply rector set php71

    php bin/rector process

A couple of rectors have been disabled due to different reasons:

- Rector\Php71\Rector\FuncCall\CountOnNullRector
  This rector has been disabled as it creates rather long and
  complex structures to avoid calling count on null.

  This rector will be enabled as soon as TYPO3 uses at least
  PHP 7.3 which introduces a "is_countable" method.

- Rector\Php71\Rector\Assign\AssignArrayToStringRector
  This rector has been disabled as it does not work properly.
  The default types of parameters have been changed although
  their types could properly be inferred by a doc block or
  by value assignments.

- Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector
  This rector has been disabled as it does not work properly.
  A bug report is filed and to be found here:
  https://github.com/rectorphp/rector/issues/2454

- Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector
  This rector has been disabled as it does not work properly.
  It removed arguments in tests, especially when using
  prophecies.

Releases: master
Resolves: #90002
Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Disallow .php8 file extensions for uploading 76/62776/2
Benni Mack [Fri, 27 Dec 2019 20:35:33 +0000 (21:35 +0100)]
[TASK] Disallow .php8 file extensions for uploading

With PHP 8 on the horizon, TYPO3 Core should be prepared
to also disallow files with the file extension ".php8" for uploading.

Resolves: #90023
Releases: master, 9.5, 8.7
Change-Id: I670755c5ae09ccf6ffd49c4b91b4617956f76ad7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62776
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX][DOCS] Rename RST file from "Galacian" to "Galician" 77/62777/3
Benni Mack [Fri, 27 Dec 2019 22:23:43 +0000 (23:23 +0100)]
[BUGFIX][DOCS] Rename RST file from "Galacian" to "Galician"

Resolves: #90027
Releases: master
Change-Id: I0783db5e26ceaba836a618f6dfce104080a4762d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62777
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[DOCS] Correct code block for site configuration 72/62772/4
Stephan Salzmann [Fri, 27 Dec 2019 13:08:32 +0000 (13:08 +0000)]
[DOCS] Correct code block for site configuration

The example claims to result in'.../detail/...', site configuration
needs to reflect that.

Releases: master, 9.5
Resolves: #90017
Change-Id: I3d6d133294763ee0e3e089c102a325a70ca3e1ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62772
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[DOCS] Update Context API usage example 98/62198/4
Tymoteusz Motylewski [Tue, 5 Nov 2019 16:07:24 +0000 (17:07 +0100)]
[DOCS] Update Context API usage example

Releases: master, 9.5
Resolves #90025

Change-Id: I8e155f7f15bf291bddf11c74cead8c68c91de49f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62198
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Add index to slug field 03/61403/6
Tizian Schmidlin [Fri, 2 Aug 2019 14:27:39 +0000 (14:27 +0000)]
[TASK] Add index to slug field

`TYPO3\CMS\Core\Routing\PageRouter::getPagesFromDatabaseForCandidates`
looks-up candidates for the page using the `slug` field (and also sorts by
this value). This has some serious impact on the website performance on
systems with lots of pages. In order to optimize this, an index should be
set.

Releases: master
Resolves: #88896
Change-Id: I1aecca781db9562243a15341819b3ce261708836
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61403
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Fix /date|time|int/ regex in backend search 85/61885/4
Christian Eßl [Fri, 4 Oct 2019 14:18:22 +0000 (16:18 +0200)]
[BUGFIX] Fix /date|time|int/ regex in backend search

Several parts of the core use the regular expression /date|time|int/ to
test, if an 'eval' TCA configuration of a field contains one of these
evaluation strings. This regex would however match any other string that
contains one of those words. This patch fixes this behaviour by matching
only the exact words.

Resolves: #40347
Releases: master, 9.5
Change-Id: I2af1e3bf5b5cc4056f0e3875645c549a01e6dbd0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61885
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Reset evaluate permissions to previous value 45/62545/2
Susanne Moog [Thu, 5 Dec 2019 15:08:35 +0000 (16:08 +0100)]
[BUGFIX] Reset evaluate permissions to previous value

Resolves: #89842
Releases: master, 9.5
Change-Id: I42ffcc313290867d0410265f4c900225ceb554e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62545
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[FEATURE] Add galacian flag 59/62759/4
Benni Mack [Mon, 23 Dec 2019 21:36:38 +0000 (22:36 +0100)]
[FEATURE] Add galacian flag

The flag for TYPO3's supported galacian is now added with the "gl.png" flag.

TYPO3 core previously had the "greenlandic" ("kl") named under the same
file, which was now renamed.

Resolves: #89929
Releases: master
Change-Id: Ia267dbf7f3e4a2bec67d6534bf26eddc4aaf71b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62759
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Test failure due to erroneous usage of uniqueId() function 73/62773/4
Anja Leichsenring [Fri, 27 Dec 2019 14:36:27 +0000 (15:36 +0100)]
[BUGFIX] Test failure due to erroneous usage of uniqueId() function

The function in testing-framework provides a string that is target to be
used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it
to produce a random userId, which needs to be an integer.
If the randomly produced string contains not only numbers, the cast
operation converts the uid to 0 and therefor prevents a DB query
from execution. This prevention results in a not consumed mock object,
which in turn causes a integration test failure.

Resolves: #90018
Releases: master, 9.5
Change-Id: I559041591a600a04da86e8b4a85cf5e6dd176475
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62773
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field 48/62748/5
Tobias Gaertner [Thu, 19 Dec 2019 08:30:34 +0000 (09:30 +0100)]
[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field

For upgrading from an old versions where EXT:realurl was used
the PopulatePagesSlugs upgradeWizard is in place.
It now also respects the tx_realurl_pathsegment field in generatorOptions.

The workflow is now, that it takes the page:tx_realurl_pathsegment field
and if empty falls back to page:title.

Resolves: #89069
Releases: master, 9.5
Change-Id: Ia9c6367d46713a8a1a609ef13c6bbd8878ec6bed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62748
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Acceptance tests for keyboard interaction with pagetree 21/62521/5
Michael Telgkamp [Tue, 22 Oct 2019 20:20:27 +0000 (22:20 +0200)]
[TASK] Acceptance tests for keyboard interaction with pagetree

Add keyboard interaction acceptance tests for the pagetree interactions.

Currently testing Home key, End key, navigation with Up and Down keys,
opening a selected entry with Enter and collapsing and expanding of
subtrees with Left / Right keys.

Resolves: #89832
Resolves: #89955
Releases: master
Change-Id: Ibe3c83fe6142296e333a66e68d67e283e2000957
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62521
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Remove report for ext:compatibility7 74/62674/3
Anja Leichsenring [Mon, 16 Dec 2019 12:27:20 +0000 (13:27 +0100)]
[TASK] Remove report for ext:compatibility7

The extension does not exist for TYPO3 versions above 8, so the report
must not exist either in these versions.

Resolves: #89963
Releases: master, 9.5
Change-Id: I0de6b2646253a755b554b48dadabbfcb2bc1b795
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62674
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Correctly nest testing template instructions in DOM 70/62770/4
Oliver Hader [Fri, 27 Dec 2019 10:33:53 +0000 (11:33 +0100)]
[TASK] Correctly nest testing template instructions in DOM

Resolves: #90016
Releases: master, 9.5
Change-Id: Id7fc792515cfc333118105ae832c2f283e455535
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62770
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Remove repository polling trigger from pre-merge test plans 21/62721/2
Anja Leichsenring [Tue, 17 Dec 2019 09:47:21 +0000 (10:47 +0100)]
[TASK] Remove repository polling trigger from pre-merge test plans

The trigger will cause the plan to be executed after merge, which
is not needed because nightly plans take care of it.

Resolves: #89972
Releases: master, 9.5, 8.7
Change-Id: Iafc32174d2234439915c2e741020c4626391f98a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62721
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] COMPOSER_ROOT_VERSION raise to current version 10.2.0 34/62734/2
Anja Leichsenring [Tue, 17 Dec 2019 14:35:57 +0000 (15:35 +0100)]
[TASK] COMPOSER_ROOT_VERSION raise to current version 10.2.0

Resolves: #89976
Releases: master, 9.5, 8.7
Change-Id: I82d5811d9532ee47bcf2254c6bc18e4a3e0e74d0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62734
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Avoid showing telephone element for route link browser 57/62757/4
Oliver Hader [Sun, 22 Dec 2019 12:03:26 +0000 (13:03 +0100)]
[BUGFIX] Avoid showing telephone element for route link browser

Affects following site configuration aspects in site management module:
* page based error handling source field in link popup
* URI base static source field in link popup

Resolves: #90004
Releases: master
Change-Id: I2d8548141f20d5bf328dccc7145bdd54e59d6603
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Update codeception and phpunit to latest versions 38/62738/3
Benni Mack [Thu, 19 Dec 2019 12:36:45 +0000 (13:36 +0100)]
[TASK] Update codeception and phpunit to latest versions

Updating codeception (3.2.1) and phpunit (8.5.0)
to latest versions allows for further updating other dependencies
TYPO3 is using.

Used command:
composer update codeception/codeception
composer update phpunit/phpunit

Resolves: #89984
Releases: master, 9.5, 8.7
Change-Id: I33a398fccadfb5c29056d33c7ff35429c263eb92
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62738
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Simplify checks on Import about allowed filenames 27/62627/3
Benni Mack [Fri, 13 Dec 2019 16:06:06 +0000 (17:06 +0100)]
[TASK] Simplify checks on Import about allowed filenames

In TYPO3 v10, BasicFileUtility is not used by DataHandler anymore,
and never initialized with other file permissions than "allow
any file ending", which is why the simple check on the fileDenyPattern
can be used directly in Import functionality.

The next patch would then allow to clean up BasicFileUtility
where the methods which belong to "internal_type=file" are not in use
anymore.

Resolves: #89941
Releases: master
Change-Id: I58a28a1cd1f6d284d241479a324c877a2824e7bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62627
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner" 39/62639/5
Andreas Fernandez [Sat, 14 Dec 2019 13:01:21 +0000 (14:01 +0100)]
[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner"

The "Broken Extension Scanner" has some flaws that are fixed with this
patch:

- Only one request is sent to scan all ext_localconf.php /
  ext_tables.php files, each
- ext_tables.php is only scanned if ext_localconf.php was successful,
  since those are dependent
- Protected extensions (mandatory to the system) cannot get uninstalled
- After uninstalling an extension all caches are cleared

Resolves: #89947
Releases: master, 9.5
Change-Id: I63aa7e67df9d061fded42af34c72727db629258a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62639
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[TASK] Apply rector set php70 92/62592/3
Alexander Schnitzler [Tue, 10 Dec 2019 13:26:35 +0000 (14:26 +0100)]
[TASK] Apply rector set php70

    php bin/rector process

The Rector\Php70\Rector\List_\ListSwapArrayOrderRector rector
has been disabled as this needs proper testing and a separate
patch.

Releases: master
Resolves: #89907
Change-Id: I56b296221622afdc72feb5a48145431efd993ea1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62592
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Update rector/rector 99/62599/5
Alexander Schnitzler [Wed, 11 Dec 2019 11:59:54 +0000 (12:59 +0100)]
[TASK] Update rector/rector

    composer remove --dev rector/rector
    composer require --dev rector/rector:~0.6

The update of rector brings important bugfixes and
enables the installation of the latest version of
phpstan/phpstan.

Releases: master
Resolves: #89918
Change-Id: I406aa56b19e88db23260033023e2c785425aef5e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62599
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Increase wait limit for mssql containers 39/62739/3
Anja Leichsenring [Wed, 18 Dec 2019 12:35:56 +0000 (13:35 +0100)]
[TASK] Increase wait limit for mssql containers

For testing mssql based jobs, the wait limit for the database
to answer gets raised from 60 to 120 seconds to avoid build
failures solely caused by the container being up too late.

Releases: master, 9.5, 8.7
Resolves: #89986
Change-Id: If88949ed4dd978af1e349b524a40069b606dcb63
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62739
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Adjust parameters of implode() for PHP 7.4 45/62745/2
Susanne Moog [Wed, 18 Dec 2019 17:15:57 +0000 (18:15 +0100)]
[BUGFIX] Adjust parameters of implode() for PHP 7.4

The TimeTracker has been using the wrong order of glue
and pieces, the PageLayoutView has used implode with only
one parameter. Both occurences have been adjusted.

Resolves: #89991
Releases: master, 9.5, 8.7
Change-Id: Id600409548cf89b24832afcb5d0784c24be1d1b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62745
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Use correct implode(string, array) syntax 41/62741/3
Anja Leichsenring [Wed, 18 Dec 2019 13:56:41 +0000 (14:56 +0100)]
[BUGFIX] Use correct implode(string, array) syntax

The usage of implode(array, string) has been marked as
deprecated by PHP and triggers PHP Deprecation warnings
by using PHP 7.4.

Resolves: #89987
Releases: master, 9.5
Change-Id: I4094744bd067203856dc305bb7e1651797d0c959
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62741
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klösges <mkloesges@gmx.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Use new subdomain for new translation server 42/62742/2
Georg Ringer [Wed, 18 Dec 2019 13:59:54 +0000 (14:59 +0100)]
[TASK] Use new subdomain for new translation server

Use the final subdomain localize.typo3.org instead of
beta-translation.typo3.org. The latter is still available
and will be removed at later time.

Resolves: #89988
Releases: master
Change-Id: Ic7188d9edea0bbd4753b136242d992d195196880
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62742
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Apply rector set php56 48/62448/10
Alexander Schnitzler [Sun, 1 Dec 2019 14:16:28 +0000 (15:16 +0100)]
[TASK] Apply rector set php56

    php bin/rector process

Releases: master
Resolves: #89807
Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Introduce functional test for RequestBuilder 80/62580/4
Alexander Schnitzler [Sun, 8 Dec 2019 17:16:49 +0000 (18:16 +0100)]
[TASK] Introduce functional test for RequestBuilder

The now introduced functional tests are a replacement
for the unit tests which were only possible by mocking
the hell out of the RequestBuilder.

Releases: master
Resolves: #89898
Change-Id: Iccbd768ab0842e29d4954755e8f34f62bdc564f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62580
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Speed up tests 47/62547/16
Benni Mack [Thu, 5 Dec 2019 18:57:55 +0000 (19:57 +0100)]
[TASK] Speed up tests

Some tests use "accessibleMock" (= eval() code) where
it is completely unnecessary as not even a mock is needed.

Resolves: #89974
Releases: master
Change-Id: I6d44a251e670ec97787a45b68b40e8f4bef2946f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62547
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Fix closure comparison in test 37/62737/3
Susanne Moog [Wed, 18 Dec 2019 07:26:55 +0000 (08:26 +0100)]
[TASK] Fix closure comparison in test

ExactValueMatching of Closures in Prophecy may
result in Comparison Failures causing the test
to fail in newer PHPUnit Versions. Instead of
an exact match of that closure, a type comparison
is enough - as calling the closure is tested via
following assertions.

Resolves: #89982
Releases: master, 9.5
Change-Id: I23ef94a291a07d02e0c8857a1aeaf14931406af0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62737
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[BUGFIX] Include .htaccess file in extension packages 82/62582/3
Georg Ringer [Mon, 9 Dec 2019 13:52:06 +0000 (14:52 +0100)]
[BUGFIX] Include .htaccess file in extension packages

Adopt the excludeForPackaging to include also .htaccess files in
extension downloads of extension manager.

Resolves: #89876
Releases: master, 9.5, 8.7
Change-Id: If5a00956165bab386a980bc897f5750a3ffc73da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62582
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[TASK] Remove redundancies in install tool ext conf template 48/62648/2
Claus Due [Mon, 16 Dec 2019 10:55:18 +0000 (11:55 +0100)]
[TASK] Remove redundancies in install tool ext conf template

This patch:

1. Removes a redundant usage of a "NoSpace" VH and
   the associated namespace import since there are no
   other usages.
2. Deletes the VH class since it is not used elsewhere.
3. Removes an always-true and therefore redundant "if"

Releases: master
Resolves: #89956
Change-Id: I943653e04fa731cdc4bdcbc8d6e32663e3ca30c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62648
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView 20/62720/2
Frank Naegler [Tue, 17 Dec 2019 09:53:24 +0000 (10:53 +0100)]
[SECURITY] Avoid insecure deserialization in QueryGenerator & QueryView

Resolves: #89005
Releases: master, 9.5, 8.7
Security-Commit: 82656cf8149d04f31b1441a03415b5e9a067c614
Security-Bulletin: TYPO3-CORE-SA-2019-026
Change-Id: If312a53b24d919439fa70f5df96be383876957a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62720
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator 19/62719/2
Frank Naegler [Tue, 17 Dec 2019 09:53:17 +0000 (10:53 +0100)]
[SECURITY] Prevent SQLi in ext:lowlevel QueryGenerator

Resolves: #89452
Releases: master, 9.5, 8.7
Security-Commit: d73e50f02afc5459f737282ede6cc70579fe7181
Security-Bulletin: TYPO3-CORE-SA-2019-025
Change-Id: I55afb17f4b1509a3dfc945e28e5d35671f6c28f3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62719
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Avoid directory traversal on archive extraction 18/62718/2
Andreas Fernandez [Tue, 17 Dec 2019 09:53:08 +0000 (10:53 +0100)]
[SECURITY] Avoid directory traversal on archive extraction

The Extension Manager and Language Pack Manager receive Zip archives as
input from foreign sources and extract them on the disk. However, the
previous approach is considered insecure as the target directory is not
checked per file and directory traversal was possible.

This patch adds a new service class that handles the extraction of Zip
archives via PHP's internal ZipArchive class, which can handle such
cases on its own.

Resolves: #88764
Releases: master, 9.5, 8.7
Security-Commit: a02f19c73211a5f1c0286ab44bee27da9b73f026
Security-Bulletin: TYPO3-CORE-SA-2019-024
Change-Id: I701a577f54410344867b868409a38cc44339f976
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62718
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] XSS in file list through file extension 17/62717/2
Andreas Fernandez [Tue, 17 Dec 2019 09:52:59 +0000 (10:52 +0100)]
[SECURITY] XSS in file list through file extension

FAL currently filters invalid characters from file names stored by its
API. However, this sanitization took no effect when the file was placed
by e.g. uploads via FTP, which doesn't trigger FAL.

This patch adds a missing `htmlspecialchars` call when the file
extension is rendered and could not be sanitized before due to mentioned
circumstances.

Resolves: #88931
Releases: master, 9.5, 8.7
Security-Commit: 296c6a6723826b4ad2babbb1de5b9d23dfd256ea
Security-Bulletin: TYPO3-CORE-SA-2019-023
Change-Id: I24cbc623f6390944a608eadf3ebe7a13d294e0ae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62717
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Avoid XSS by correctly encoding typolink results 16/62716/2
Oliver Hader [Tue, 17 Dec 2019 09:52:50 +0000 (10:52 +0100)]
[SECURITY] Avoid XSS by correctly encoding typolink results

In order to avoid XSS through typolink, anchor text is encoded
correctly to be used in a HTML context. Fallback link texts of
links to pages are encoded per default in case lib.parseFunc
has not been configured.

Resolves: #88635
Releases: master, 9.5, 8.7
Security-Commit: b62f71c4e098156052ff33e775208981c2ef512b
Security-Bulletin: TYPO3-CORE-SA-2019-022
Change-Id: I76b0f06ad52a487e1aebc820531c11166ad45117
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62716
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent XSS in EXT:form error message output 15/62715/2
Frank Naegler [Tue, 17 Dec 2019 09:52:42 +0000 (10:52 +0100)]
[SECURITY] Prevent XSS in EXT:form error message output

Resolves: #88629
Releases: master, 9.5, 8.7
Security-Commit: df38c239aa9c627fb7b6f1c384d45ff0940d98fa
Security-Bulletin: TYPO3-CORE-SA-2019-021
Change-Id: Ib12dc0affe7f15f1869cff57ea09d9999a0d632a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62715
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Streamline frontend user password recovery process 90/62690/2
Oliver Hader [Sun, 15 Dec 2019 19:34:47 +0000 (20:34 +0100)]
[TASK] Streamline frontend user password recovery process

The ext:felogin recovery process is using a non-typesafe comparison
which might be exploited with a probability of 0.000000294% and is
storing the recovery token as plain MD5-hash in database.

In order to streamline the process non-typesafe comparison is using
PHP's hash_equals() method; for keeping backward compatibility just
HMAC-SHA1 is applied to the recovery token in database.

Since exploitations to this scenario are very unlikely (for a 50%
chance an attacker would have to trigger the creation of around
170 million recovery requests) it is not handled with a security
workflow - but using the public workflow.

Resolves: #89952
Releases: master, 10.2, 9.5, 8.7
Change-Id: Idcb7b7d6eb418124dc17f1707284b6abe8a8b63b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62690
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Don't import PHP class in ext_localconf.php 87/62687/3
Andreas Fernandez [Tue, 17 Dec 2019 06:17:50 +0000 (07:17 +0100)]
[BUGFIX] Don't import PHP class in ext_localconf.php

Resolves: #89970
Releases: master
Change-Id: I5b7e22c853993e7434c086c22a3898eefbe07899
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62687
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Revert FolderCheck for clipboard actions 21/62321/2
Guido Schmechel [Wed, 13 Nov 2019 20:25:44 +0000 (21:25 +0100)]
[BUGFIX] Revert FolderCheck for clipboard actions

Due to a faulty query in #85425 it was no longer possible
to copy files at the clipboard multi-selection-mode.

This must be possible if the user has the permission to copy files,
but not to copy folders.

Resolves: #89669
Releases: master, 9.5
Change-Id: I1c26696a6c3886dd5669957cdce8ca472b17b577
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62321
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Ensure correct return values in Workspace middleware 51/62651/2
Benni Mack [Mon, 16 Dec 2019 11:21:18 +0000 (12:21 +0100)]
[BUGFIX] Ensure correct return values in Workspace middleware

When setting config.disablePreviewNotification = 1 in workspaces
context, the preview middleware returns "null", although the method
signature says it always requires a string return value.

Resolves: #89959
Releases: master, 9.5
Change-Id: Icdef1891989db2869c2351adb07e6b4778d25e09
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62651
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Simplify chunking of test-plan jobs 40/62640/3
Markus Klösges [Sat, 14 Dec 2019 15:01:59 +0000 (16:01 +0100)]
[TASK] Simplify chunking of test-plan jobs

To make the code for splitting all test-jobs into stages of equal size
simpler and easier to maintain, a helper class is introduced
that supports chunking two lists into equally sized chunks, while
ensuring that each chunk only contains a limited number of elements
from one of the lists.

Using this utility, the number of mssql jobs can easily be limited,
while keeping the spec-code easy to follow.

Releases: master, 9.5, 8.7
Resolves: #89948
Change-Id: I9e1677e19fb2ea6df7d9e964e8f772ffb7324ec8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62640
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Fix return value in command site:list 21/62621/5
Georg Ringer [Fri, 13 Dec 2019 14:06:17 +0000 (15:06 +0100)]
[BUGFIX] Fix return value in command site:list

Return 0 instead of null.

Resolves: #89936
Releases: master, 9.5
Change-Id: Ic3345975b60fca38537750c9617d68ba9d19cc3e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62621
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[DOCS] Extend docs of DeleteUploads finisher 97/61997/5
Jonas Schwabe [Tue, 15 Oct 2019 07:48:43 +0000 (07:48 +0000)]
[DOCS] Extend docs of DeleteUploads finisher

Releases: master, 9.5
Resolves: #89416
Change-Id: I4565d846bb86077c3e03534416f3047e2f7f0ce6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61997
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[BUGFIX] Always allow dividers in TCA auth mode check 42/62342/5
Alexander Stehlik [Mon, 18 Nov 2019 19:10:01 +0000 (20:10 +0100)]
[BUGFIX] Always allow dividers in TCA auth mode check

This brings back the optgroups in the CType and list_type fields
for normal editors.

Additionally some tests for checkAuthMode are added.

Releases: master, 9.5
Resolves: #89707
Change-Id: Ib3e6dbf3598ad767910161225a31ad2db939b3d6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62342
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Rename method getName of TypoScriptConstants VH 41/62541/2
Claus Due [Thu, 5 Dec 2019 13:58:59 +0000 (14:58 +0100)]
[TASK] Rename method getName of TypoScriptConstants VH

The name "getName" will be reserved in Fluid 3.0 and is
ambiguous. This patch renames that method to become
"getFieldName" which is less ambiguous and conflict free.

Additionally the ViewHelper is changed so it no longer
accesses deprecated property AbstractViewHelper->
viewHelperVariableContainer, instead accessing the
ViewHelperVariableContainer via $this->renderingContext.

Resolves: #89861
Releases: master
Change-Id: Iea474625917293afe67326f765c6a77f7fbe9b73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62541
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Thin out SystemEnvironmentBuilder 28/62628/4
Benni Mack [Fri, 13 Dec 2019 18:28:41 +0000 (19:28 +0100)]
[TASK] Thin out SystemEnvironmentBuilder

This a pre-patch to clean up the functionality of the SystemEnvironmentBuilder,
which was originally introduced as part of the Bootstrap logic in 6.0.

However, a few cross-concerns can be cut in TYPO3 v10:
- Calling the deprecated GeneralUtility::presetApplicationContext() is not
needed anymore, as it can be populated on-demand when the deprecated
GeneralUtility::getApplicationContext() method is called via Environment API.
This way, the ApplicationContext initialization can be put directly in the
Environment API initialization call.
- The static "isFunctionDisabled" method with a nasty runtime cache is only
used in one place in backend, so does not belong to "building system environment",
and is therefore removed.
- The now unused "exitWithMessage" protected method is removed,
removing a dependency to the HttpUtility class.

Resolves: #89943
Releases: master
Change-Id: I31156b1a1ded306d99bcf2d51de43bc919a0b3e0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62628
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] Convert URLs with ampersands in Linkvalidator 34/62634/2
Sybille Peters [Sat, 14 Dec 2019 11:15:12 +0000 (12:15 +0100)]
[BUGFIX] Convert URLs with ampersands in Linkvalidator

The linkref functions return the URLs as they are displayed in the
BE form. This will return '&' as '&amp;' HTML entity.

Linkvalidator should correctly decode the HTML entity.

Resolves: #89488
Resolves: #89682
Releases: master, 9.5
Change-Id: I17b421354d45297423437373b92a93dfbe53d2d9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62634
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Remove incorrect slash in extension paths 26/62626/6
Ron Gebauer [Fri, 13 Dec 2019 16:14:48 +0000 (16:14 +0000)]
[DOCS] Remove incorrect slash in extension paths

An incorrect slash has been removed in multiple extension
paths. The slash could lead to exceptions (e.g. within the
form framework's `PersistenceManagerException` configuration),
as those paths cannot be resolved,

Additionally, a proper role has been added to some of
those paths.

Releases: master, 9.5
Resolves: #89942
Change-Id: I70f5e67d5cc7f58e66507242158e565cd8c70720
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62626
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Remove "Adding Your Own Content Elements" 41/62641/2
Sybille Peters [Sat, 14 Dec 2019 19:20:49 +0000 (20:20 +0100)]
[DOCS] Remove "Adding Your Own Content Elements"

Content has been migrated to "TYPO3 Explained"

Reduce the content to a stub and add link.

Resolves: #89949
Releases: master, 9.5, 8.7
Change-Id: I4c69c8a1f74bea223110b9b6a07e035a03183d87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62641
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Use correct data type for DependencyOrdering 10/62610/3
pfuju [Thu, 12 Dec 2019 15:47:59 +0000 (15:47 +0000)]
[DOCS] Use correct data type for DependencyOrdering

As the new additional file processors registration
also uses the DependencyOrderingService the value
of `before` must be an array instead of a string.

Releases: master
Resolves: #89931
Change-Id: I8eea65c56f68ae94cddb239ac9e08c18a59ee036
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62610
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Avoid controller methods on Fluid RenderingContext 39/62539/4
Claus Due [Thu, 5 Dec 2019 13:51:28 +0000 (14:51 +0100)]
[TASK] Avoid controller methods on Fluid RenderingContext

The getter/setter methods related to controller name
and action name will be removed in Fluid 3.0.

An equally valid solution is to specify the template
path and filename, which also avoids the lookup
logic in Fluid from running and further increases the
failsafe operation of this controller.

Resolves: #89859
Releases: master
Change-Id: I8a3422681bef4b8ada043877ffa3c57eba82d8be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62539
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Move target to general tab for pages of type External URL 33/62633/2
Benni Mack [Fri, 13 Dec 2019 22:21:30 +0000 (23:21 +0100)]
[TASK] Move target to general tab for pages of type External URL

To increase usability for editors when using External URL links,
the "target" field is moved right below the "Target URL" field.

In addition the Target URL field has an increased size, to match
the others.

Resolves: #79317
Releases: master
Change-Id: I9aec38780713df006f98be370e4fadd5c61118aa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62633
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[DOCS] Adjust name for PageTitle API in documentation 25/62625/3
Stefan Neufeind [Fri, 13 Dec 2019 15:26:45 +0000 (16:26 +0100)]
[DOCS] Adjust name for PageTitle API in documentation

The funtionality was named titleTag before. But the new API is
called PageTitle API.

Resolves: #89940
Releases: master, 9.5
Change-Id: Idd42c5c5f53d999351c787ac7edb474795132f48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62625
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Mix test jobs in stages 35/62635/2
Anja Leichsenring [Sat, 14 Dec 2019 11:32:26 +0000 (12:32 +0100)]
[TASK] Mix test jobs in stages

In order to spread computing load more evenly trough the test plan,
stages receive a shuffled mix of all available jobs with a maximum
of 25 mssql related functional test jobs.

Resolves: #89946
Releases: master, 9.5, 8.7
Change-Id: I368530899c709bd93d455078606f978a2626679c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62635
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Name "default language" consistently 02/62602/3
Benni Mack [Thu, 12 Dec 2019 06:33:39 +0000 (07:33 +0100)]
[BUGFIX] Name "default language" consistently

When working with the "pages.l18n_cfg" bitset flag, there is an
option "default translation", which commonly refers to language
with sys_language_uid=0. In most other cases, also in various
documentation pieces, the naming is "default language" instead
of "default translation" which is more correct in this case.

All places are now properly named "default language"
and no "default translation" is there anymore, making the
functionality more consistent.

Resolves: #89924
Releases: master, 9.5
Change-Id: Ibe9ad9371615119eff7535cb45d0f25b858d04da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62602
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Remove unused imports 04/62604/3
Oliver Bartsch [Thu, 12 Dec 2019 09:55:01 +0000 (10:55 +0100)]
[TASK] Remove unused imports

Cleanup code by removing unused imports in various classes.

Also changes the corresponding ExtensionScanner tests because they
are counting the line numbers which changed by removing the imports.

Resolves: #89926
Releases: master, 9.5
Change-Id: I588a3aa778a342c6c1154bb431cd325497fd4d18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62604
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Mark guzzlehttp/guzzle >= 6.5.0 as conflict 06/62606/3
Benni Mack [Thu, 12 Dec 2019 10:21:59 +0000 (11:21 +0100)]
[BUGFIX] Mark guzzlehttp/guzzle >= 6.5.0 as conflict

Due to the INTL/ICU bug, which we
have seen on various places, Guzzle, which
does not cover our edge cases yet, ran
in the same issue as our Core versions earlier
in 2019.

See
https://github.com/guzzle/guzzle/issues/2448
https://github.com/guzzle/guzzle/pull/2454

For the time being, lets mark guzzle as
incompatible until Guzzle has solved the issue
and released a new version, so we can loosen
the conflict constraint.

Related: #87953
Resolves: #89904
Releases: master, 9.5, 8.7
Change-Id: If64fb9472d046f020c850cd0551beeaf78796b60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62606
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Apply thumbscrews to sqlserver 11/62611/5
Andreas Fernandez [Fri, 13 Dec 2019 07:53:02 +0000 (08:53 +0100)]
[BUGFIX] Apply thumbscrews to sqlserver

sqlserver is a special race that welcomes high memory servers as its
habitat. However, we are short on resources and need to offer a very
small amout of RAM for a living which already acts as server cruelty.

While we're on it, it gets a nice bed to put some data on the RAM disk
in the hope its job gets done at least quickier.

Resolves: #89935
Releases: master, 9.5, 8.7
Change-Id: Ic06f4b7071ed1d16ec9d0cd5a0a57f05dde171f6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62611
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Use AJAX API in top toolbar items 78/62578/5
Andreas Fernandez [Sun, 8 Dec 2019 08:34:53 +0000 (09:34 +0100)]
[TASK] Use AJAX API in top toolbar items

The top toolbar items now use our AJAX API instead of $.ajax().

Resolves: #89897
Releases: master
Change-Id: I134ea97f2038097d486947f30545304e47a31dff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62578
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Bump chosen-js to 1.8.7 09/62609/2
Andreas Fernandez [Thu, 12 Dec 2019 15:39:47 +0000 (16:39 +0100)]
[TASK] Bump chosen-js to 1.8.7

Executed commands:

  yarn add chosen-js@^1.8.7 --dev
  grunt build

Resolves: #89884
Releases: master
Change-Id: I242b8925f108d3bfa26191f1c58ea24a1149f0ff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62609
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Fix typo in cHash option description 03/62603/2
Benni Mack [Thu, 12 Dec 2019 08:40:57 +0000 (09:40 +0100)]
[BUGFIX] Fix typo in cHash option description

Resolves: #89925
Releases: master, 9.5, 8.7
Change-Id: I3449606aa143c23dd656dd566c87aec08ae19425
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62603
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[DOCS] Correct code-block directive 00/62600/3
Chris Müller [Wed, 11 Dec 2019 17:49:49 +0000 (18:49 +0100)]
[DOCS] Correct code-block directive

The code-block directive needs two colons to be rendered
correctly.

Resolves: #89922
Related: #89463
Releases: master
Change-Id: Ida99628710cc3558a0dbdc39272e788c390ca154
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62600
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[FEATURE] Add PSR-14 event to control hreflang tags to be rendered 59/59059/38
Richard Haeser [Fri, 7 Dec 2018 21:07:06 +0000 (22:07 +0100)]
[FEATURE] Add PSR-14 event to control hreflang tags to be rendered

A PSR-14 event is introduced to make it possible to control the
hreflang tags that will be rendered.

Additionally the class HrefLangGenerator is migrated to be a
listener to the new event.

Resolves: #86614
Releases: master
Change-Id: I51a5a79da6996148e62301c793b0ad257aada102
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <look@susi.dev>
3 months ago[BUGFIX] Supply origin to URL if domain is missing 76/62576/5
Andreas Fernandez [Fri, 6 Dec 2019 22:15:39 +0000 (23:15 +0100)]
[BUGFIX] Supply origin to URL if domain is missing

The AJAX API fails to send a request if the API receives a non-absolute
URL like /typo3/index.php?foo=bar, since the domain is missing. To fix
this issue, the origin of the triggering request is added as well as
`base` argument of URL().

Resolves: #89893
Releases: master
Change-Id: Ice61a71fc8d4627e6d0b3b9d0f5ab524000361ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62576
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
3 months ago[TASK] Remove ampersands from doc block params 94/62594/2
Alexander Schnitzler [Tue, 10 Dec 2019 16:10:08 +0000 (17:10 +0100)]
[TASK] Remove ampersands from doc block params

As a prepatory work for a better static code analysis
all ampersands have been removed from doc block params.

The doc block must not reflect whether a variable is
passed by value or reference.

Releases: master
Resolves: #89912
Change-Id: Ibead2ec2db6487e32bcd5fc271a6566bab46d255
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62594
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
3 months ago[TASK] Expose none existing user in forgot password dialog 82/62482/12
Jan Stockfisch [Fri, 29 Nov 2019 11:15:06 +0000 (12:15 +0100)]
[TASK] Expose none existing user in forgot password dialog

Shows error flash message while
`exposeNonexistentUserInForgotPasswordDialog` is set to `1`

Resolves: #88111
Releases: master
Change-Id: I193e2ca22c45a83450aa4f0e44e3dce46696b16c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62482
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[TASK] Exclude StringClassNameToClassConstantRector in rector.yml 81/62581/5
Alexander Schnitzler [Mon, 9 Dec 2019 10:12:54 +0000 (11:12 +0100)]
[TASK] Exclude StringClassNameToClassConstantRector in rector.yml

As the StringClassNameToClassConstantRector would convert
string class names that are deliberately defined as string,
this rector has been disabled.

Releases: master
Resolves: #89899
Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Remove leading slash from backendLogo path 93/62293/3
Oliver Bartsch [Mon, 11 Nov 2019 09:40:38 +0000 (10:40 +0100)]
[BUGFIX] Remove leading slash from backendLogo path

As the extension configuration field `backendLogo` isn't resolved
by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`,
it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage)
not possible to add a path with a leading slash.

As this is neither explicit allowed nor disallowed, this unifies the
behavior by removing a possible leading slash from the defined path
before it gets resolved as it's already the case for the other fields.

Resolves: #89636
Releases: master, 9.5
Change-Id: I3f7a72f1005bc403c72b837cf66e5303962a8a42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62293
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Disable lockIP by default 59/62559/12
Rasmus Larsen [Fri, 6 Dec 2019 12:58:16 +0000 (13:58 +0100)]
[BUGFIX] Disable lockIP by default

IPLock breaks modern IPv6 setups because of the Fast fallback
aka. Happy Eyeballs algorithm that can cause users to jump between
IPv4 and IPv6 arbitrarily.
Enabling lockIP should be a very conscious decision, not a default.

Resolves: #89869
Releases: master
Change-Id: I4b0fde1f767bfca613276d4763b91d9feb86ea27
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62559
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Use existing API instead of ContentObjectRenderer 27/62527/2
Michael Binder [Tue, 3 Dec 2019 12:39:08 +0000 (13:39 +0100)]
[BUGFIX] Use existing API instead of ContentObjectRenderer

This Patch allows the usage of an HMENU with special = directory and
the Fallback Type 'Free mode'

Resolves: #88344
Related: #89368
Releases: master, 9.5
Change-Id: Ib7f53b4e061b6387e6b29b2545696a3eb2d015a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62527
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tobias Gaertner <tobias.gaertner@benaja-websolutions.com>
Reviewed-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Raise platform settings for tarball distributions 65/62565/3
Benni Mack [Fri, 6 Dec 2019 16:25:51 +0000 (17:25 +0100)]
[BUGFIX] Raise platform settings for tarball distributions

In order to use the final LTS distributions from Symfony for
our latest stable, we need to set proper platform requirements
for the root composer.json.

Our packages rely on the settings so the base package
can properly raise dependencies.

Symfony has the requirements due to other PHP bugs (fixed
very early already), however using the tarballs in
7.2.0 / 7.0.0 would still work, as the symfony changes
only fix issues we dont rely on.

v10: 7.2.5
v9: 7.2.5
v8: 7.0.8

Used composer commands:

  composer config platform.php 7.2.5
  composer update --lock

Resolves: #89882
Releases: master, 9.5, 8.7
Change-Id: Ib51ec076e643581603fced3ed0daa0de0aadb12c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62565
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Replace usage of legacy PageRepository class 86/62586/3
Alexander Schnitzler [Mon, 9 Dec 2019 18:45:34 +0000 (19:45 +0100)]
[TASK] Replace usage of legacy PageRepository class

In two places, TYPO3\CMS\Frontend\Page\PageRepository had been
used instead of TYPO3\CMS\Core\Domain\Repository\PageRepository.

As this will eventually fail in the future, the wrong usage has
been fixed.

Releases: master
Resolves: #89901
Change-Id: I5799bcb93486e3c8aa4a71fe4ad03cfce34948d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62586
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
3 months ago[TASK] Allow rector to process tests 83/62583/4
Alexander Schnitzler [Mon, 9 Dec 2019 15:35:45 +0000 (16:35 +0100)]
[TASK] Allow rector to process tests

In order to let rector process tests, the autoloading
of all processed classes needs to be intact.

In TYPO3 there were a bunch of classes whose namespace
were a bit wrong according to PSR-4 and there were some
class that didn't fit the PSR-4 standard at all.

Classes that could easily be fixed have been fixed.
All others have either been registered via a class map
in composer.json or they have been excluded from the
processing of rector.

This change does not apply rector rules to tests,
it only enables rector to operate on tests due to
fixed autoloading.

Releases: master
Resolves: #89900
Change-Id: Iaa4a5bb2677a5a9af374d780423d962dcc09ade2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62583
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Do not set GeneralUtility::$container in unit tests 73/62573/4
Benjamin Franzke [Fri, 6 Dec 2019 20:26:45 +0000 (21:26 +0100)]
[TASK] Do not set GeneralUtility::$container in unit tests

The GeneralUtility $container instance should only be set/used
in functional tests as we a) can not reset the instance (which
means other unit tests are affected) and b) should mock/inject
dependencies in unit tests.

TreeDataProviderFactoryTest is therefore changed to to use
GeneralUtility::addInstance() (which is intended for unit tests)
instead of GeneralUtility::setContainer().

Change-Id: I9fc0e76077cc1cc2a6935d025b97309efc315f4f
Releases: master
Resolves: #89890
Related: #89733
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62573
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Remove reqCHash functionality for plugins 67/62267/9
Benni Mack [Sat, 9 Nov 2019 21:48:22 +0000 (22:48 +0100)]
[TASK] Remove reqCHash functionality for plugins

Since TYPO3 v10.0, all links generated by TYPO3 contain
a cHash if
- there are arguments that are not mapped within the routing
- there are arguments that are not explicitly "excluded" from cHash (e.g. fbclid)
- there are arguments that are not internal (L,id,MP).

The PageArgumentValidator middleware now always evaluates the
arguments properly at every request and decides to disable
caching or throw a 404, if an incoming request does not have
a cHash or an invalid cHash.

Through the middleware, any plugin is automatically checked
for the cHash, and it does not matter anymore for plugins,
so it does not matter for integrators or template authors as well
as cHash is managed internally by TYPO3 Core now (with no way
to disable it, for security reasons).

All functionality regarding cHash that can be dropped:
- CacheHashEnforcer and Extbase option
- TSFE->reqCHash() can be marked as deprecated
- the option within PiBased Plugins is now irrelevant as well.

This change jointly decouples cHash evaluation from any other
part than Url Generation (= PageRouter) and Resolver (PageArgumentValidator),
finally streamlining all logic of cHash functionality.

Resolves: #89868
Releases: master
Change-Id: I7a694fbc95fa1ea4dc85b12a94b0a06b3722fd11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62267
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
4 months ago[TASK] Deprecate Extbase's WebRequest and WebResponse 17/62317/5
Alexander Schnitzler [Wed, 13 Nov 2019 11:57:09 +0000 (12:57 +0100)]
[TASK] Deprecate Extbase's WebRequest and WebResponse

In order to simplify the request/response handling in
Extbase and to prepare the introduction of PSR-7 compatible
request and response objects, the web versions of Extbase's
request and response have been deprecated. All relevant
logic has been moved into the base classes to stay api
compatible and not introduce a breaking change.

Along with the simplification of the request and response
objects, quite a lot of instance checks have been removed
to ease the transition to having a public api that is
defined by interfaces and not concrete implementations.

Releases: master
Resolves: #89673
Change-Id: Ie920ae7d38e6de3167ff57f93fa6e98af2936d9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62317
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Bump datatables to 1.10.18 72/62572/2
Andreas Fernandez [Fri, 6 Dec 2019 18:39:29 +0000 (19:39 +0100)]
[TASK] Bump datatables to 1.10.18

Executed commands:

  yarn upgrade datatables
  grunt build

Resolves: #89888
Releases: master
Change-Id: I73ea78f4d217c2846b0c79cf0e5ad06aea1a8e9e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62572
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump sortablejs to 1.10.1 71/62571/2
Andreas Fernandez [Fri, 6 Dec 2019 18:32:42 +0000 (19:32 +0100)]
[TASK] Bump sortablejs to 1.10.1

Executed commands:

  yarn add sortablejs@^1.10.1 --dev
  grunt build

Resolves: #89886
Releases: master
Change-Id: I871faaca63f19bf7fe2e782d6741cf3e476156b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62571
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump requirejs to 2.3.6 69/62569/2
Andreas Fernandez [Fri, 6 Dec 2019 18:23:29 +0000 (19:23 +0100)]
[TASK] Bump requirejs to 2.3.6

Executed commands:

  yarn upgrade requirejs
  grunt build

Resolves: #89887
Releases: master
Change-Id: I5b2347ebec049e1663a3684ce4246c323228befb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62569
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump moment to 2.24.0 and moment-timezone to 0.5.27 70/62570/2
Andreas Fernandez [Fri, 6 Dec 2019 18:27:49 +0000 (19:27 +0100)]
[TASK] Bump moment to 2.24.0 and moment-timezone to 0.5.27

Executed commands:

  yarn add moment@^2.24.0 moment-timezone@^0.5.27 --dev
  grunt build

Resolves: #89885
Releases: master
Change-Id: I6a6a7122fb1a0a343206c04c5cc3ce6a9a891d02
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62570
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Bump typescript to 3.7.3 68/62568/2
Andreas Fernandez [Fri, 6 Dec 2019 18:16:05 +0000 (19:16 +0100)]
[TASK] Bump typescript to 3.7.3

Executed commands:

  yarn upgrade typescript
  grunt build

Resolves: #89889
Releases: master
Change-Id: I1152fbbc89b30cae9ba34f1fa11494c071a7fe4a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62568
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>