Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Use single quotes for password check 38/40438/2
Andreas Fernandez [Thu, 18 Jun 2015 10:46:14 +0000 (12:46 +0200)]
[BUGFIX] Use single quotes for password check

Use single quotes for the password check in
SaltedPasswordsUtility::getNumberOfBackendUsersWithInsecurePassword
to tell other DBMS to expect a value and not an identifier.

Using double quotes for values violates the SQL standard.

Resolves: #67599
Releases: master, 6.2
Change-Id: I4d17f2eb24e77421da2368cc899a021c435cfff8
Reviewed-on: http://review.typo3.org/40438
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] File metadata can't be edited inline 23/40323/2
Benjamin Mack [Mon, 15 Jun 2015 10:04:51 +0000 (12:04 +0200)]
[BUGFIX] File metadata can't be edited inline

Since 2012, there is a special mechanism to allow some tables for
editing even if their records reside on a page that is inaccessible for
the user. This is checked for regular forms in
``EditDocumentController``, but the check for inline elements was
missing until this patch.

Resolves: #65563
Releases: master, 6.2
Change-Id: I6d984c28672e2b3ba225ea91f6c7292aa3e1127d
Reviewed-on: http://review.typo3.org/40323
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[TASK] Add basic unit tests for ContentObjectRenderer::typoLink 05/40405/3
Nicole Cordes [Wed, 17 Jun 2015 19:43:20 +0000 (21:43 +0200)]
[TASK] Add basic unit tests for ContentObjectRenderer::typoLink

Resolves: #67586
Releases: master, 6.2
Change-Id: I0c20b13469d9bb9af844f92ee87181a55bacc906
Reviewed-on: http://review.typo3.org/40405
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Properly escape option value for groups 83/40383/2
Wouter Wolters [Tue, 16 Jun 2015 17:18:55 +0000 (19:18 +0200)]
[BUGFIX] Properly escape option value for groups

Resolves: #56296
Releases: master,6.2
Change-Id: I2960cc23b6fdb44e5159c74c126feaa6070eb7bf
Reviewed-on: http://review.typo3.org/40383
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix SQL error on recursive TypoScript template inclusion 78/40378/2
Andreas Fernandez [Wed, 17 Jun 2015 17:47:18 +0000 (19:47 +0200)]
[BUGFIX] Fix SQL error on recursive TypoScript template inclusion

If TypoScript templates are included recusively (a > b > a), the
$basedOnIds array is empty and creates an invalid SQL query.

Resolves: #64654
Releases: master, 6.2
Change-Id: Ia3001e1e620d6bb4d2d1f3ad016816bc5636dff1
Reviewed-on: http://review.typo3.org/40378
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install 37/40337/3
Jonathan IROULIN [Wed, 17 Jun 2015 08:15:39 +0000 (10:15 +0200)]
[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install

fe_login is a preinstalled extension but the "/uploads/tx_felogin" folder
was not created during step-2 installation process.
This patch add "tx_felogin" folder in "uploads" folder
during the process installation.

Resolves: #60261
Releases: master, 6.2
Change-Id: If4914b958b7117dc9f33d303d29850124b775b50
Reviewed-on: http://review.typo3.org/40337
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Always use MCRYPT_DEV_URANDOM if using mcrypt 58/40258/2
Helmut Hummel [Mon, 15 Jun 2015 14:00:27 +0000 (16:00 +0200)]
[BUGFIX] Always use MCRYPT_DEV_URANDOM if using mcrypt

Using MCRYPT_RAND was introduced because of a bug in PHP versions lower
than 5.3.7 on Windows in combination with IIS.

Since we require higher PHP versions in all maintained versions we can
remove this workaround and use MCRYPT_DEV_URANDOM again. By doing so we
fix a bug on Windows caused by not enough randomness.

Releases: 6.2, master
Resolves: #53034
Change-Id: Ibe74eb0277934e9300ffd9b00cc89a5f8bb008fb
Reviewed-on: http://review.typo3.org/40258
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Scheduler now throws OutOfBoundsException on SQL query error 63/40263/2
Mathias Schreiber [Mon, 15 Jun 2015 15:59:48 +0000 (17:59 +0200)]
[BUGFIX] Scheduler now throws OutOfBoundsException on SQL query error

If the query for fetchTask fails for whatever reason, scheduler will
now gracefully throw an exception instead of assuming it had gotten
a valid resource pointer

Resolves: #67463
Related: #39085
Releases: master, 6.2
Change-Id: I26819df3fd173b36de6121100a6398ed4b701319
(cherry picked from commit d975ed579a4ce510cfbea86cc8cf1b60c9017071)
Reviewed-on: http://review.typo3.org/40263
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove version number from generator tag 43/40243/2
Wouter Wolters [Thu, 19 Mar 2015 09:55:31 +0000 (10:55 +0100)]
[TASK] Remove version number from generator tag

This change will not increase the security of TYPO3 CMS.
This information can be misused by an attacker for a more targeted attack.

Resolves: #64429
Releases: master,6.2
Change-Id: I9151ed99e454e878b10ec1894cbec2ad83165e57
Reviewed-on: http://review.typo3.org/40243
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Nail down php 5.6 instantiation issues in tests 63/40163/3
Christian Kuhn [Wed, 10 Jun 2015 14:54:57 +0000 (16:54 +0200)]
[TASK] Nail down php 5.6 instantiation issues in tests

We know PHP 5.6 has issues in 6.2 in extbase object creation.
The patch adds the unit test from the "instantiator" patch
of issue #66473. This test fails, so travis-ci is configured
with PHP 5.6 as known failure at the moment.

With the instantiator patch applied, initializeObject() was
no longer called in some PHP versions, another test is added
to verify this regression can not show up again.

The test bed currently ensures:
* PHP 5.6 fails with current version
* PHP 5.4, 5.5 and 5.6 would fail if only "instantiator" patch
from #66473 is applied
* PHP 5.3 fails with "initializeObject is called twice" if patch
from #67274 is applied

Later is to get 5.6 green again with no further failure in other
PHP versions with other patches in 6.2 without changing tests.

Resolves: #67408
Related: #66473
Related: #67274
Releases: 6.2
Change-Id: Id4e81877e696dd1abc5b39497a19fa20a702048c
Reviewed-on: http://review.typo3.org/40163
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Check $http_response_headers in GeneralUtility::getUrl() 50/40150/2
Andreas Fernandez [Wed, 10 Jun 2015 07:19:07 +0000 (09:19 +0200)]
[BUGFIX] Check $http_response_headers in GeneralUtility::getUrl()

If one queries a local, non-existing file with GeneralUtility::getUrl()
AND sets the $report parameter, implode() fails because
$http_response_headers remains NULL, as there is no HTTP request.
Check the existance of $http_response_headers and alternatively use the
URL for logging.

Resolves: #67383
Releases: master, 6.2
Change-Id: I796935fbef090061c7d12502593190f4223765b3
Reviewed-on: http://review.typo3.org/40150
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Set TYPO3 version to 6.2.14-dev 49/40149/2
TYPO3 Release Team [Wed, 10 Jun 2015 11:41:49 +0000 (13:41 +0200)]
[TASK] Set TYPO3 version to 6.2.14-dev

Change-Id: Iac1f4e69066af21917c2bc10be1d7a8c8ae0ca34
Reviewed-on: http://review.typo3.org/40149
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years ago[RELEASE] Release of TYPO3 6.2.13 48/40148/2 6.2.13 TYPO3_6-2-13
TYPO3 Release Team [Wed, 10 Jun 2015 11:41:08 +0000 (13:41 +0200)]
[RELEASE] Release of TYPO3 6.2.13

Change-Id: I960bb95536eedb25b68208d1a63281a1a66c43fc
Reviewed-on: http://review.typo3.org/40148
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
4 years agoRevert "[BUGFIX] Fix serializable object creation with PHP 5.6" 33/40133/2
Helmut Hummel [Tue, 9 Jun 2015 15:18:27 +0000 (17:18 +0200)]
Revert "[BUGFIX] Fix serializable object creation with PHP 5.6"

This change causes issues with initializeObject calling

Resolves: #67272
Releases: 6.2
This reverts commit 3e8f5c46e4c8968038acb22053ca421fec48f903.

Change-Id: I07a3de74e9ad78e42542cb85e5211efd173cc4b4
Reviewed-on: http://review.typo3.org/40133
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Avoid unnecessary generation of processed files 43/40143/3
Alexander Opitz [Wed, 10 Jun 2015 07:49:18 +0000 (09:49 +0200)]
[BUGFIX] Avoid unnecessary generation of processed files

Removing [GFX] off the checksum data used to identify a processed file
ensures that data type inconsistencies within [GFX] do not cause a
regeneration of the processed file.

A new upgrade wizard for the Install Tool is added to migrate existing
processed files without the need to regenerate those.

Resolves: #66614
Releases: master, 6.2
Change-Id: Id90ce923b26ee726d15cf3d0cfcafc4ec4d7405d
Reviewed-on: http://review.typo3.org/40143
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] SQL parser does not support string as join condition 45/40145/2
Xavier Perseguers [Wed, 10 Jun 2015 09:20:18 +0000 (11:20 +0200)]
[BUGFIX] SQL parser does not support string as join condition

The SQL parser is capable of parsing

    JOIN T1 ON T1.some_field = T2.some_other_field

and

    JOIN T1 ON T1.some_field = 4

but not

    JOIN T1 ON T1.some_field = 'some string'

Change-Id: I7806699ea44685ab717cc0e8a75f7b53a1b2b1cc
Resolves: #67385
Related: #66614
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/40145
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Reduce diff size on PackageStates changes 52/40052/2
Markus Klein [Sat, 6 Jun 2015 13:55:27 +0000 (15:55 +0200)]
[TASK] Reduce diff size on PackageStates changes

Sorting the available packages by key before running the
DependencyResolver ensures that equivalent (loading order does not matter)
packages have a fixed order in the PackageStates in the end.

Resolves: #67330
Releases: master, 6.2
Change-Id: Ibd7061aa8b1735f2bd5b7cbb9df2ba19b90bb884
Reviewed-on: http://review.typo3.org/40052
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] InstallTool: connect to DBMS before retrieving current schema 46/40046/2
Morton Jonuschat [Wed, 3 Jun 2015 20:59:40 +0000 (22:59 +0200)]
[BUGFIX] InstallTool: connect to DBMS before retrieving current schema

SqlSchemaMigrationService needs to explicitly connect to the database
before retrieving the current schema. On native MySQL connections this
happens implicitly when using sql_select_db(), on DBAL a connectDB() is
required.

Resolves: #67286
Releases: master, 6.2
Change-Id: I2c93111f1f6919f31d71b4b46fd353d9a3629dbc
Reviewed-on: http://review.typo3.org/40046
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Respect _FILE/_STRING in versioning 45/40045/2
Alexander Opitz [Mon, 1 Jun 2015 09:32:48 +0000 (11:32 +0200)]
[BUGFIX] Respect _FILE/_STRING in versioning

References with _FILE/_STRING as ref_table have special meanings and
can't be loaded from database.

Resolves: #66572
Releases: master, 6.2
Change-Id: Ibc942c600652a005368e1eab67cbc24f4efb7dde
Reviewed-on: http://review.typo3.org/40045
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Correct dependency handling in workspaces module 44/40044/2
Dominique Kreemers [Wed, 22 Apr 2015 13:42:19 +0000 (15:42 +0200)]
[BUGFIX] Correct dependency handling in workspaces module

This patch fixes a bug where records, which have references
pointing to them, are in a table that is disabled for
workspaces throw an element not found RuntimeException.

Without this change, you will get an error in the workspace module
for tables that are not workspace-enabled, but have file references
pointing to them.

Change-Id: I16c42f0347e0c1c6d916e24f865eb2af643929da
Resolves: #66523
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/40044
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Show backend user in record info popup 40/40040/2
Markus Klein [Fri, 5 Jun 2015 23:19:05 +0000 (01:19 +0200)]
[BUGFIX] Show backend user in record info popup

This solves a regression to #55699.

Resolves: #67309
Releases: master, 6.2
Change-Id: Ia1c3f0efe871ba2742029883e7fcc919e3145ae9
Reviewed-on: http://review.typo3.org/40040
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Open element browser in sys_action 97/39897/2
Nicole Cordes [Tue, 2 Jun 2015 13:25:09 +0000 (15:25 +0200)]
[BUGFIX] Open element browser in sys_action

If you try to add a new backend user with a sys_action task, you can't
select any db mount point due to a JavaScript error. This patch ensures
all FormEngine scripts are loaded properly.

Resolves: #67239
Releases: 6.2
Change-Id: I93cdb6314c9240f20fa6c2bd00a35dda639a8054
Reviewed-on: http://review.typo3.org/39897
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Illegal string offset ´showitem´ in ExtensionManagementUtility 88/39988/2
Wouter Wolters [Wed, 3 Jun 2015 18:57:06 +0000 (20:57 +0200)]
[BUGFIX] Illegal string offset ´showitem´ in ExtensionManagementUtility

Resolves: #67285
Releases: master,6.2
Change-Id: I1e02ef7af6b8a4ee8301fa8b2fdaaf3928316815
Reviewed-on: http://review.typo3.org/39988
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update to phpunit 4.7 81/39981/2
Christian Kuhn [Fri, 5 Jun 2015 11:44:03 +0000 (13:44 +0200)]
[TASK] Update to phpunit 4.7

Update to latest stable for no specific reason. Since
we are trying to keep master & 6.2 in sync on the testing
side, the patch is requested for 6.2 as well.

Resolves: #67312
Releases: master, 6.2
Change-Id: I7b42083a80a1b0ba2af9074793d9413c6008820f
Reviewed-on: http://review.typo3.org/39981
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Adjust Log tests for changed exception format in PHP7 78/39978/2
Alexander Opitz [Mon, 1 Jun 2015 10:51:57 +0000 (12:51 +0200)]
[TASK] Adjust Log tests for changed exception format in PHP7

https://github.com/php/php-src/commit/3ae995f03c8f60c4a4c9718262545cf5a6a08da3

Resolves: #67189
Releases: master, 6.2
Change-Id: Icc94ebb403d963b6cdb367df8e7a590c581e940c
Reviewed-on: http://review.typo3.org/39978
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Fix FileList ordering for upper/lowercase 67/39967/2
Alexander Opitz [Thu, 26 Feb 2015 09:44:39 +0000 (10:44 +0100)]
[BUGFIX] Fix FileList ordering for upper/lowercase

File names which only differ in upper/lowercase writing are now sorted
stable with uppercase first.

Resolves: #65319
Releases: master, 6.2
Change-Id: Ib1b907cb8aed6364aadc4f028cfc9294b5c18884
Reviewed-on: http://review.typo3.org/39967
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Do not try to resolve a path to t3lib 68/39968/2
Markus Klein [Wed, 3 Jun 2015 07:40:36 +0000 (09:40 +0200)]
[BUGFIX] Do not try to resolve a path to t3lib

Resolves: #67267
Releases: master, 6.2
Change-Id: Ic866968a02a4e41df74ae56acd160d21177537d7
Reviewed-on: http://review.typo3.org/39968
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] PropertyMapper now normalizes simple types 59/39959/2
Wouter Wolters [Wed, 20 May 2015 09:00:18 +0000 (11:00 +0200)]
[BUGFIX] PropertyMapper now normalizes simple types

This fixes a bug where the property mapper was unable to find a
valid typeconverter for properties annotated with int or bool.

Resolves: #67044
Releases: master,6.2
Change-Id: Ie15b6d83e70c5857a09f1d8baa21c168924d63b4
Reviewed-on: http://review.typo3.org/39959
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Delete FAL records + relations in ResourceStorage::deleteFolder() 60/39960/2
Frans Saris [Thu, 4 Jun 2015 15:08:50 +0000 (17:08 +0200)]
[BUGFIX] Delete FAL records + relations in ResourceStorage::deleteFolder()

When deleting a folder (recursive) also delete all FAL records and
relations to keep the FAL index up-to-date.

Resolves: #67084
Releases: master, 6.2
Change-Id: Ic3ae51a568ad43e6283e3900da24796656c9347c
Reviewed-on: http://review.typo3.org/39960
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Initialize database connection in ClearCacheService 50/39950/2
Morton Jonuschat [Wed, 20 May 2015 19:06:03 +0000 (21:06 +0200)]
[BUGFIX] Initialize database connection in ClearCacheService

Without calling initialize() on the DatabaseConnection object
the DBAL the resulting connection configuration will default
to the "native" driver type (MySQL) which results in an error
as there is no MySQL server to contact with the given connection
parameters.

Resolves: #67066
Releases: master, 6.2
Change-Id: Id5d70a122dcca806ee1122cecacad0c8aef27547
Reviewed-on: http://review.typo3.org/39950
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Import Selection with TYPO3 Element Browser 06/39906/2
Frank Nägler [Tue, 26 May 2015 14:07:56 +0000 (16:07 +0200)]
[BUGFIX] Import Selection with TYPO3 Element Browser

This patch fixes the "Import Selection" link in the element browser.

Resolves: #47322
Releases: master, 6.2
Change-Id: Ic9b7ed37f0bd25d47e6b97036e1244b97b218f3b
Reviewed-on: http://review.typo3.org/39906
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Clear cache_treelist table in Install Tool 35/39935/2
Wouter Wolters [Wed, 3 Jun 2015 11:24:41 +0000 (13:24 +0200)]
[BUGFIX] Clear cache_treelist table in Install Tool

This is not implemented in the caching framework and
needs to be cleared manually.

Resolves: #67275
Releases: master,6.2
Change-Id: I05f4fb96eedff1002b843ef51b184bbd50493290
Reviewed-on: http://review.typo3.org/39935
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] addToAllTCAtypes() must replace fields correctly 20/39920/2
Markus Klein [Wed, 3 Jun 2015 08:40:51 +0000 (10:40 +0200)]
[BUGFIX] addToAllTCAtypes() must replace fields correctly

The changes made in #57824 cause the replace functionality to fail.

Resolves: #67259
Releases: master, 6.2
Change-Id: If0d5773f2905bdae50ab7aa607c01422d18e7f81
Reviewed-on: http://review.typo3.org/39920
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Type checking at PageRepository::getFileReferences() call 05/39905/2
Alina Fleser [Fri, 30 Jan 2015 22:17:25 +0000 (00:17 +0200)]
[BUGFIX] Type checking at PageRepository::getFileReferences() call

Verification of parent element ($element) type before
PageRepository::getFileReferences() call
in FilesContentObject::handleFileReferences
to avoid PHP error in case of null value

Resolves: #64239
Resolves: #62616
Releases: master, 6.2
Change-Id: I8b89710af97eb37eee9518392e89ddeceb5b9f57
Reviewed-on: http://review.typo3.org/39905
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser 64/39864/2
Andreas Fernandez [Mon, 1 Jun 2015 12:51:08 +0000 (14:51 +0200)]
[FOLLOWUP][BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser

Restructure the nested condition for the sake of readability.

Releases: master, 6.2
Resolves: #67224
Change-Id: I25161348509245dee56b61f3a1f15d9bc778500b
Reviewed-on: http://review.typo3.org/39864
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser 60/39860/2
Peter Niederlag [Wed, 19 Feb 2014 16:17:04 +0000 (17:17 +0100)]
[BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser

The workspace preview adds the GET parameter ADMCMD_noBeUser
when requesting the frame for live preview.

$GLOBALS[BE_USER] is unset in index_ts.php when seeing ADMCMD_noBeUser.

In TypoScriptFrontendController fePreview=2 must not be set when
ADMCMD_noBeUser parameter is present to prevent fatal errors on
calling methods on a non-existent $GLOBALS[BE_USER]

Releases: master, 6.2
Resolves: #30643
Change-Id: Idff7febcaaa8b87bd65a993b1860ad378e09b22f
Reviewed-on: http://review.typo3.org/39860
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FOLLOWUP][BUGFIX] Show full folder path in file list title 87/39787/2
Frans Saris [Thu, 28 May 2015 06:57:26 +0000 (08:57 +0200)]
[FOLLOWUP][BUGFIX] Show full folder path in file list title

In old situation the full path to of the folder was shown.
With #64759 only the accessible part is shown. The logic
to determine what the root is of the 'current' filemount
is not suitable for this and will always return the root path of
the first filemount within the storage. This could result in a wrong
root identifier.

This patch fixes the output of the readable path to the
full path by using the real storage root instead of the storage root
defined by the filemount.

Resolves: #67148
Related: #64759
Releases: master, 6.2
Change-Id: Ie00fa2dc7d3833f798c5a2913bb9674b2b15b6e7
Reviewed-on: http://review.typo3.org/39787
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Only persist processedFile if processing was successful 26/39826/2
Frans Saris [Mon, 25 May 2015 07:19:24 +0000 (09:19 +0200)]
[BUGFIX] Only persist processedFile if processing was successful

Due to multiple reasons (for instance target folder is not writable)
the processing of a file can fail.

This change prevents wrong data being saved in sys_file_processedfile
when processing failed.

Resolves: #67094
Releases: master, 6.2
Change-Id: I6051d503ba74629dc6493b7bac9f28bf320aeb66
Reviewed-on: http://review.typo3.org/39826
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FEATURE] Add "processed files" cleanup tool to Install Tool 83/39783/4
Markus Klein [Fri, 22 May 2015 00:27:39 +0000 (02:27 +0200)]
[FEATURE] Add "processed files" cleanup tool to Install Tool

Resolves: #67071
Releases: master, 6.2
Change-Id: I1320833f0f7cfd852ca8ba458fa9367cb3b16ea0
Reviewed-on: http://review.typo3.org/39783
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] PHP7 is_numeric change 82/39782/2
Alexander Opitz [Tue, 26 May 2015 14:09:34 +0000 (16:09 +0200)]
[TASK] PHP7 is_numeric change

With PHP 7 the string 0x0 isn't any longer a numeric, so the test
fails. But the test itself makes no sense and is removed.

Resolves: #65320
Releases: master, 6.2
Change-Id: Id7569dfb859ecee7c85c595640515781b1423614
Reviewed-on: http://review.typo3.org/39782
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Print controller->action if required argument is not set 48/39748/2
Andreas Fernandez [Tue, 26 May 2015 09:36:34 +0000 (11:36 +0200)]
[TASK] Print controller->action if required argument is not set

Extend the exception message to hint to the action of the controller
that misses a required argument.

Resolves: #67139
Releases: master, 6.2
Change-Id: I70a256d73545ad90852fd1165f2fde127ac12441
Reviewed-on: http://review.typo3.org/39748
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add missing int-cast for checking uid zero 29/39729/2
Markus Klein [Tue, 26 May 2015 07:55:55 +0000 (09:55 +0200)]
[BUGFIX] Add missing int-cast for checking uid zero

The change #24250 introduced a strict comparison without ensuring
proper data types on both sides of the comparison.

Add the missing int-cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands

Resolves: #67138
Releases: master,6.2
Change-Id: I51dc33fd64a6d42963237ac49e0385c2abf66b71
Reviewed-on: http://review.typo3.org/39729
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Adhere "suggestions" when resolving ext loading order 11/39711/2
Markus Klein [Sun, 24 May 2015 22:55:43 +0000 (00:55 +0200)]
[BUGFIX] Adhere "suggestions" when resolving ext loading order

The issue #58701 introduced the functionality to fetch suggestions defined
in composer.json or ext_emconf.php into the Package class.
A copy and paste error causes the loading of the suggestions to
actually fail, so those never reach the DependencyResolver.

This patch fixes the tiny mistake and thus ensures that suggestions
really influence the loading order of extensions.

Resolves: #51069
Releases: master, 6.2
Change-Id: Ib12e7f91f49c0b2bda56fdb4394a604e322b741c
Reviewed-on: http://review.typo3.org/39711
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Streamline TS registration for sysexts 87/39687/2
Benjamin Mack [Wed, 25 Feb 2015 17:37:50 +0000 (18:37 +0100)]
[TASK] Streamline TS registration for sysexts

For historical reasons the "Static Template #43"
was "content.default" and the possibility to add
TypoScript after this default rendering was introduced
in order to have CTypes and plugins register their
TypoScript just after e.g. "content.default" or
"css_styled_content".

Since TYPO3 CMS 6.2 the preferred option is
called "defaultContentRendering" instead of
the magic number "43".

Some leftover parts in sysexts are replaced
with "defaultContentRendering", as well
as some more descriptive information on
how the legacy number exists.

Releases: master, 6.2
Resolves: #65346
Change-Id: I7268ec9ee8454d1eb4b0fda9f12fdfb5cb191ba8
Reviewed-on: http://review.typo3.org/39687
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Don't add TypoScript twice to defaultContentRendering 83/39683/2
Markus Klein [Sat, 23 May 2015 17:14:02 +0000 (19:14 +0200)]
[BUGFIX] Don't add TypoScript twice to defaultContentRendering

Calling the addTypoScript() method with last parameter set to
'defaultContentRendering' must not add the TypoScript twice.

Resolves: #67116
Releases: master, 6.2
Change-Id: I3161c62ac0ab25369fabc3f8163e5d92356aa0ca
Reviewed-on: http://review.typo3.org/39683
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Generate thumbnails for files without width/height 55/39655/2
Markus Klösges [Thu, 30 Apr 2015 10:06:32 +0000 (12:06 +0200)]
[BUGFIX] Generate thumbnails for files without width/height

Thumbnails should not upscale images, therefore we check for the
original size against thumbnail size. If original size is 0 (as for
pdf-Files) this leads to not generating thumbnails for those files. Now
checking original width/height against 0 to prevent this and generate
thumbs for those files again.

Resolves: #66679
Related: #66270
Releases: master, 6.2
Change-Id: I5823142a6be19e6068fea358027dc808f5fd3185
Reviewed-on: http://review.typo3.org/39655
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Check page access only if integer in ModuleRunner 51/39651/2
Nicole Cordes [Thu, 21 May 2015 11:25:59 +0000 (13:25 +0200)]
[BUGFIX] Check page access only if integer in ModuleRunner

If you register a module in main module "file" an error is thrown
because the ModuleRunner checks page access for the variable "id".
In any file module the id is a FAL identifier which can't be converted
to an integer value and the check fails.

This patch adds a limitation to the ModuleRunner to check page access
only if the id can be interpreted as integer value.

Releases: master, 6.2
Resolves: #67079
Change-Id: Iba44499b9b13172818aee48aefb01d102f810285
Reviewed-on: http://review.typo3.org/39651
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Show full folder path in file list title 41/39641/2
Christian Weiske [Fri, 17 Apr 2015 15:25:29 +0000 (17:25 +0200)]
[BUGFIX] Show full folder path in file list title

We have to use the name and cannot rely on the identifier, since
they can be random UUID values.

This also fixes a wrong folder name in the paste confirm message.

Change-Id: I092efdc5b666c9010717136bc063b155479eadab
Resolves: #64759
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39641
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Readonly fields must not render links to allowed tables 57/39457/2
Georg Ringer [Mon, 11 May 2015 17:37:26 +0000 (19:37 +0200)]
[BUGFIX] Readonly fields must not render links to allowed tables

If a field is configured as readOnly, the allowed tables below
should not be linked to the Element Browser

Resolves: #66870
Releases: master, 6.2
Change-Id: Iac82233ad365d923098d4b331af895b64542e082
Reviewed-on: http://review.typo3.org/39457
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Ensure new deep dirs don't contain double slashes 24/39624/2
Thomas Deuling [Fri, 30 Jan 2015 10:06:42 +0000 (11:06 +0100)]
[BUGFIX] Ensure new deep dirs don't contain double slashes

The method of GeneralUtility::mkdir_deep has two parameters, which are
concatenated. This could end up in a double slashes. To prevent that,
the parameters are modified to concat them with only one slash.

Resolves: #63920
Releases: master, 6.2
Change-Id: I2d15f6c33550f9045db9b7730f7b074ae54a18dc
Reviewed-on: http://review.typo3.org/39624
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Uncheck prefix domain for new domain records 19/38519/3
Simon Schaufelberger [Sat, 4 Apr 2015 13:24:33 +0000 (15:24 +0200)]
[BUGFIX] Uncheck prefix domain for new domain records

Change default value for prefixing new domain records to zero since
creating multiple domains with prefix can lead to unexpected behavior.

Resolves: #22542
Releases: master, 6.2
Change-Id: I79a1d45c9fb13100f564b5a9526127c7135508ef
Reviewed-on: http://review.typo3.org/38519
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Add missing comma in ViewHelper example 19/39619/2
Georg Ringer [Tue, 19 May 2015 11:03:40 +0000 (13:03 +0200)]
[BUGFIX] Add missing comma in ViewHelper example

A comma needs to be added in an example of f:uri.image

Resolves: #66851
Releases: master, 6.2
Change-Id: Ib0a8f3d97a3f51b075b1e0e6a2208ae4c659ed6d
Reviewed-on: http://review.typo3.org/39619
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Prevent wrong record copies 16/39616/2
Andreas Fernandez [Tue, 19 May 2015 10:09:38 +0000 (12:09 +0200)]
[BUGFIX] Prevent wrong record copies

Before starting any record copy process, we have to check if the
destination page can handle the record type. Currently if you copy a
record with IRRE references, the references are copied first but the
original record isn't copied because of missing permissions. The
copied IRRE elements stay and pollute the original record as the
references are added to it. This patch adds a check if the destination
page can handle the mother record type and starts copy process only if
allowed.

Resolves: #66920
Releases: master, 6.2
Change-Id: I274792b13170f37e3e799ff892ea877ba44d90a8
Reviewed-on: http://review.typo3.org/39616
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Resolve dependencies on extension update 03/39603/2
Nicole Cordes [Tue, 3 Mar 2015 13:32:07 +0000 (14:32 +0100)]
[BUGFIX] Resolve dependencies on extension update

For installed extensions the (new) dependencies have to be resolved
on extension update. If the extension isn't installed yet,
the dependencies are fetched on update anyway,
so this doesn't have to be tackled.

Releases: master, 6.2
Resolves: #65484
Change-Id: I5c1e8622b3b15b6c25d7181c6cb1fc07f271437d
Reviewed-on: http://review.typo3.org/39603
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] remove wrong code suggestion from GMENU 02/39602/2
Frederic Gaus [Tue, 10 Feb 2015 16:11:40 +0000 (17:11 +0100)]
[BUGFIX] remove wrong code suggestion from GMENU

Remove the wrong code suggestion "wrapItemAndSub" from GMENU in t3editor

Change-Id: Ibcac99c49bc0d4a68e759b4878eb1c9493355eda
Resolves: #25955
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39602
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] felogin: Use correct regex in redirect evaluation 01/39601/3
Markus Klein [Mon, 18 May 2015 17:28:00 +0000 (19:28 +0200)]
[BUGFIX] felogin: Use correct regex in redirect evaluation

Resolves: #67013
Releases: master, 6.2
Change-Id: Ifaf0a3125ac6b5c0f9e13c2f5c3d4db94aa43ea9
Reviewed-on: http://review.typo3.org/39601
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Correctly insert session data after deleting them 99/39599/2
Markus Klein [Mon, 18 May 2015 11:07:36 +0000 (13:07 +0200)]
[BUGFIX] Correctly insert session data after deleting them

Reset session data timestamp when removing session data in order to
assure that new session data are stored via INSERT later again.

Resolves: #67007
Releases: master, 6.2
Change-Id: I181017687f9569d4e2a16ca3a970367b05cf7d52
Reviewed-on: http://review.typo3.org/39599
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Indexed_search Make results per page work (Extbase plugin) 83/39383/2
Tymoteusz Motylewski [Sat, 18 Apr 2015 18:35:28 +0000 (20:35 +0200)]
[BUGFIX] Indexed_search Make results per page work (Extbase plugin)

Replaces wrong setting "results" and uses "numberOfResults" instead.
Protects PageBrowskingViewHelper from division by zero warning.
Fix wrong path to the page_links setting in the template.

Resolves: #40280
Releases: master, 6.2
Change-Id: I6636c6796b92181dbe298562df2fb59a4f1f1ec2
Reviewed-on: http://review.typo3.org/39383
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[BUGFIX] Valid Content-Type header for jpg thumbnails 67/39567/3
Andreas Fernandez [Fri, 15 May 2015 12:56:45 +0000 (14:56 +0200)]
[BUGFIX] Valid Content-Type header for jpg thumbnails

Use "Content-Type: image/jpeg" instead of invalid "image/jpg" derived
from the file extension. The invalid Content-Type in combination with
"X-Content-Type-Options: nosniff" leads to thumbnails not showing up in
Internet Explorer.

While at it also correct the case of "Etag" to "ETag".

Resolves: #66913
Releases: master, 6.2
Change-Id: I9a31817e32e4e8b2b99b3008f8381608c5ac06e9
Reviewed-on: http://review.typo3.org/39567
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Temporary filename collision in imageMagickConvert() 73/39373/4
Morton Jonuschat [Fri, 8 May 2015 19:58:02 +0000 (21:58 +0200)]
[BUGFIX] Temporary filename collision in imageMagickConvert()

Add more entropy to the temporary filename used by imageMagickConvert()
to ensure different processing configurations resulting in the same
output dimensions get different temporary names.

In combination with LocalDriver moving the temporary file to a different
location and file_exists_typo3temp_file() having a 30s window where it
doesn't detect the moved file (when the user enabled
$TYPO3_CONF_VARS['GFX']['enable_typo3temp_db_tracking']) this
leads to entries in the sys_processed_file table with a width and
height of 0, thus referencing the original file and resulting in
unscaled images showing in the frontend.

Resolves: #65842
Resolves: #63519
Resolves: #60215
Related: #65378
Releases: 6.2
Change-Id: I42748d0899bf1e24f9f92f2e55802d64309c5704
Reviewed-on: http://review.typo3.org/39373
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Add extension precedence 44/39544/2
Helmut Hummel [Thu, 14 May 2015 14:20:49 +0000 (16:20 +0200)]
[FOLLOWUP][BUGFIX] Add extension precedence

Before calling TYPO3 package methods, we must ensure
we have the correct instance.

All active composer packages are instance of the Flow package class
which does not implement the methods
isPartOfFactoryDefault or isPartOfMinimalUsableSystem

Resolves: #66955
Related: #59147
Releases: master, 6.2
Change-Id: I5f08cce5e4b0329927d6a302d643f680822e4ad6
Reviewed-on: http://review.typo3.org/39544
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Allow protocol in TCEMAIN.previewDomain 42/39542/2
Wouter Wolters [Wed, 13 May 2015 08:16:24 +0000 (10:16 +0200)]
[BUGFIX] Allow protocol in TCEMAIN.previewDomain

If a backend uses https as protocol and the installation
is a muti domain installation, the https protocol can lead
to problems with previewing, when other domains don't support https.

Fix this by allowing a protocol to be set in TCEMAIN.previewDomain

Resolves: #62129
Releases: master,6.2
Change-Id: Ifffef57ff8a535aedb2141f0e3cbf01b1d8baac6
Reviewed-on: http://review.typo3.org/39542
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Travis: Verify no git submodule exists 97/39497/2
Christian Kuhn [Tue, 12 May 2015 13:27:44 +0000 (15:27 +0200)]
[TASK] Travis: Verify no git submodule exists

With backport of issue #66473 a git submodule definition was
accidently commited. The patch adds an additional travis-ci
check to make the suite fail in case this happens again.

Resolves: #66911
Releases: master, 6.2
Change-Id: I88d22ceea3c82a805db4e9e61cb1fdd8aec76383
Reviewed-on: http://review.typo3.org/39497
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] use include for checking update scripts 78/39478/2
Jigal van Hemert [Mon, 11 May 2015 21:18:32 +0000 (23:18 +0200)]
[TASK] use include for checking update scripts

Instead of using eval() the EM includes temporary files with the
modified contents of class.ext_update.php to check if the update
script can be called.

Resolves: #66740
Releases: 6.2, master
Change-Id: I9495d97ad78f2bb100c306ae122aacee6f32b24a
Reviewed-on: http://review.typo3.org/39478
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Allow closures in filters methods for directory items 44/39444/2
Nicole Cordes [Mon, 11 May 2015 14:23:56 +0000 (16:23 +0200)]
[FOLLOWUP][BUGFIX] Allow closures in filters methods for directory items

This patch adjust the name of the helper function to create a driver
mock as it was renamed in current master.

Releases: 6.2
Resolves: #65244
Change-Id: I645037880f791945b9b15f61efa590a61d1e350b
Reviewed-on: http://review.typo3.org/39444
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Fix serializable object creation with PHP 5.6 92/39392/9
Helmut Hummel [Fri, 17 Apr 2015 15:47:43 +0000 (17:47 +0200)]
[BUGFIX] Fix serializable object creation with PHP 5.6

This makes use of doctrine/instantiator to catch this and many
other PHP issues when instantiating objects without constructor.

Resolves: #66473
Resolves: #66885
Releases: master, 6.2
Change-Id: Ic60b4fda6f4d7aa3f61ce46263011a89f6301f3d
Reviewed-on: http://review.typo3.org/39392
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Allow closures in filters methods for directory items 39/39439/2
Christoph Dörfel [Tue, 24 Feb 2015 07:23:28 +0000 (08:23 +0100)]
[BUGFIX] Allow closures in filters methods for directory items

Instead of checking if a given filter is callable a is_array check
is done. But the filter can also be a closure and a is_array would
fail then.

This patch changes the is_array check to is_callable.

Resolves: #65244
Releases: master, 6.2
Change-Id: I1a1e9ce0e789bd36a4fa36e91389e8b62c50116e
Reviewed-on: http://review.typo3.org/39439
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Simplify PHP lint execution 25/39425/2
Mathias Brodala [Wed, 15 Apr 2015 13:00:58 +0000 (15:00 +0200)]
[TASK] Simplify PHP lint execution

This simplifies PHP lint execution in Travis by ensuring lint
errors are outputted to stderr and drops everything else. If
any check fails, the exit code 1 is returned.

The Composer vendor directory is excluded from linting.

Resolves: #66437
Releases: 6.2
Change-Id: I588a880f548c248a0db44f3a3f1274fcec2edd00
Reviewed-on: http://review.typo3.org/39425
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Display info about registered Extractors in Task "Metadata Extract" 21/39421/2
Andreas Fernandez [Mon, 11 May 2015 07:54:48 +0000 (09:54 +0200)]
[TASK] Display info about registered Extractors in Task "Metadata Extract"

In the context of the Scheduler, the task "Metadata Extract" will have no
effect if no Extractor is registered - which is the by default case.
This quite confusing for the End User since it would expect something
to happen upon running the task.

The solution is to display a message to the End User about the registered
Extractors in the Task itself. In case no Extractor is present, the
message will make it clear that the Task will have no effect.

Change-Id: Id2dff904ca90f3cc182189db57064cf2b6daa574
Resolves: #64884
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39421
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Activate runtimeActivatedPackages without cache clearing 78/39378/2
Nicole Cordes [Sun, 3 May 2015 08:54:25 +0000 (10:54 +0200)]
[BUGFIX] Activate runtimeActivatedPackages without cache clearing

Currently you have to clear all caches manually to use runtime activated
packages because they are not included in the building process of the
cache identifier. This patch defines the TYPO3_CONF_VARS setting per
default and includes it in the cache identifier. Furthermore runtime
activated packages are excluded from being disabled in EM.

Release: master, 6.2
Resolves: #66768
Resolves: #58874
Change-Id: Idbda3c4f1f3c827c2b26c6f7759a9121cc260068
Reviewed-on: http://review.typo3.org/39378
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years agoRevert "[BUGFIX] Fix serializable object creation with PHP 5.6" 90/39390/2
Michael Stucki [Sat, 9 May 2015 21:46:18 +0000 (23:46 +0200)]
Revert "[BUGFIX] Fix serializable object creation with PHP 5.6"

This reverts commit 169a6b2f0ea77e9d050dd8de4139ecdd72facc9d.

This commit added a submodule for
typo3/contrib/vendor/typo3/cms-composer-installers.
Revert until this is fixed.

Change-Id: I093a232d62af2e282958fb86571383bd4387bcf6
Reviewed-on: http://review.typo3.org/39390
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Tested-by: Michael Stucki <michael.stucki@typo3.org>
4 years ago[BUGFIX] Fix broken link to anchor 64/39364/2
Andreas Fernandez [Fri, 8 May 2015 11:43:34 +0000 (13:43 +0200)]
[BUGFIX] Fix broken link to anchor

Due to wrong quoting, the links to anchors are broken.

Resolves: #66854
Releases: master, 6.2
Change-Id: I4a52dc6cead27fc499e93618dfaefd824ebd525c
Reviewed-on: http://review.typo3.org/39364
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Show sectionIndex from referenced page 81/39381/2
Nico de Haen [Mon, 3 Mar 2014 13:55:06 +0000 (14:55 +0100)]
[BUGFIX] Show sectionIndex from referenced page

If a page is configured to show content from another pid the menu
of type sectionIndex has to fetch the content elements from the
referenced page instead of the page itself.

Thanks to Christian Finkemeyer for the patch.

Resolves: #46448
Releases: master, 6.2
Change-Id: Ia903cdc085dd665f89df5c90dad962cbc9f09535
(cherry picked from commit 969f75063a5d63c3b7f4aae1c2e52f25ecba7e5d)
Reviewed-on: http://review.typo3.org/39381
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix serializable object creation with PHP 5.6 77/39377/5
Mathias Brodala [Fri, 17 Apr 2015 15:47:43 +0000 (17:47 +0200)]
[BUGFIX] Fix serializable object creation with PHP 5.6

This makes use of doctrine/instantiator to catch this and many
other PHP issues when instantiating objects without constructor.

Resolves: #66473
Releases: master, 6.2
Change-Id: Iaba0de638b8b555a811dad22a140d0348c168eb5
Reviewed-on: http://review.typo3.org/39377
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search 44/38744/2
Tymoteusz Motylewski [Tue, 24 Mar 2015 19:08:49 +0000 (20:08 +0100)]
[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search

Add three getters for IndexSearchRepository and SearchFormController
to have a common api for accessing data needed by FulltextIndexHook.

Unify the processing of $page_where as in one class it
was expected that it returns statement with 'AND' and in other without.

Unify the formatting of select statements in both classes to make
differences easier to spot (fix missing $wordSel statement
in the extbase plugin in the process).

Resolves: #65989
Resolves: #52277
Releases: master, 6.2
Change-Id: I9fcb86d44208e8fe6d205667f344022b0ad62505
Reviewed-on: http://review.typo3.org/38744
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[BUGFIX] Respect file create mask for PackageStates file 48/39348/2
Mathias Brodala [Thu, 9 Apr 2015 09:00:29 +0000 (11:00 +0200)]
[BUGFIX] Respect file create mask for PackageStates file

The PackagesStates file needs to respect the configured file create
mask upon creation.

Resolves: #66337
Releases: master, 6.2
Change-Id: I4f4ecb91caa58fb67e42429c4313c6e342bdea61
Reviewed-on: http://review.typo3.org/39348
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] DBAL: Permission error when saving a new record 36/39336/2
Xavier Perseguers [Thu, 7 May 2015 15:04:35 +0000 (17:04 +0200)]
[BUGFIX] DBAL: Permission error when saving a new record

Last generated ID is not stored and makes the authorization
check fail when the record is saved and edited.

Change-Id: I5b3da01219239c2ecb559f2caa492c460a310332
Releases: master, 6.2
Resolves: #66843
Related: #66680
Reviewed-on: http://review.typo3.org/39334
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/39336

4 years ago[BUGFIX] ADOdb: mssqlnative driver is not properly initialized 35/39335/2
Xavier Perseguers [Thu, 7 May 2015 10:29:01 +0000 (12:29 +0200)]
[BUGFIX] ADOdb: mssqlnative driver is not properly initialized

Problems:

- Empty username/password should use Windows Authentication
- Character set is not used when connecting
- Port is not properly passed as argument

Change-Id: I7d45949dfd3dc6f8fd74033e9d39c8df80029db5
Releases: master, 6.2
Resolves: #66830
Resolves: #63070
Reviewed-on: http://review.typo3.org/39324
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/39335

4 years ago[FOLLOWUP][BUGFIX] File list breaks with DBAL 21/39321/2
Andreas Fernandez [Thu, 7 May 2015 08:38:10 +0000 (10:38 +0200)]
[FOLLOWUP][BUGFIX] File list breaks with DBAL

Releases: master, 6.2
Resolves: #66825
Change-Id: I5c649ddea7d0d5a9b8cffca09844c86d321fa85e
Reviewed-on: http://review.typo3.org/39321
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] File list breaks with DBAL 19/39319/2
Xavier Perseguers [Thu, 7 May 2015 07:44:20 +0000 (09:44 +0200)]
[BUGFIX] File list breaks with DBAL

Unsupported double quotes used in database statements.

Change-Id: I8461d1d3acc57a3d543dbdf1d6450d2513eb661d
Releases: master, 6.2
Resolves: #66825
Reviewed-on: http://review.typo3.org/39319
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Travis: composer install without --dev 01/39301/2
Christian Kuhn [Wed, 6 May 2015 11:38:25 +0000 (13:38 +0200)]
[TASK] Travis: composer install without --dev

Dev packages are installed by default now. This throws a
deprecation message from composer in travis for 6.2.

Releases: 6.2
Change-Id: I3cf6e45120298bb97de23b9b2b9f178c125ce62e
Reviewed-on: http://review.typo3.org/39301
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Upgrade to phpunit 4.6 00/39300/2
Christian Kuhn [Wed, 6 May 2015 11:19:36 +0000 (13:19 +0200)]
[TASK] Upgrade to phpunit 4.6

Resolves: #66816
Releases: master, 6.2
Change-Id: Ia89add5a1988292770034119f6f93d13045fd784
Reviewed-on: http://review.typo3.org/39300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Streamline queue objects on dependency check 77/39277/3
Nicole Cordes [Tue, 5 May 2015 10:18:05 +0000 (12:18 +0200)]
[BUGFIX] Streamline queue objects on dependency check

The data stored in different download queues mixes arrays and objects.
Therefore you cannot loop over all queues and call functions of extension
objects. This patch streamlines all objects and make sure always objects
are returned.

Releases: master, 6.2
Resolves: #66798
Change-Id: I6eedefb614145b8645c7c52ff5daa7ad6c9c38e7
Reviewed-on: http://review.typo3.org/39277
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Improve dependency check in extension manager 42/39242/3
Nicole Cordes [Sun, 3 May 2015 14:18:09 +0000 (16:18 +0200)]
[BUGFIX] Improve dependency check in extension manager

This patch solves multiple problems currently occurring
if you try to install an extension:

* check dependencies recursively and merge errors
* prevent download if dependency errors occur
* prevent downgrading an extension
* improve information and error messages
* catch exceptions and display flash message

Releases: master, 6.2
Resolves: #52051
Resolves: #65332
Resolves: #65479
Resolves: #65916
Resolves: #60777
Change-Id: I0e9715d920e2fb43adb77fd61fde52938229431a
Reviewed-on: http://review.typo3.org/39242
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Prevent root folder listing for users 14/39214/6
Andreas Fernandez [Sat, 2 May 2015 19:55:14 +0000 (21:55 +0200)]
[BUGFIX] Prevent root folder listing for users

If a user hasn't any file mount defined or the defined file mounts
don't exist the root folder of the storage is shown. To prevent
disallowed listing of folders only admin users are allowed see and
browse root folder and editors get an information that no file mounts
are configured.

Releases: master, 6.2
Resolves: #66687
Change-Id: I301d05773f10885351034dae2b0bbd16ac20ac55
Reviewed-on: http://review.typo3.org/39214
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Prevent infinite loop in FAL access check 43/39243/2
Nicole Cordes [Thu, 30 Apr 2015 16:32:20 +0000 (18:32 +0200)]
[BUGFIX] Prevent infinite loop in FAL access check

If you have a storage which defines the processed folder in another
storage an infinite loop occurs when accessing the file list as
non-admin user. This is because the function getProcessingFolders
is called within the access check and starts access check for the
processed folder as well. This patch creates folder objects without
any access check (because processed folders should be readable and
writeable for everyone). Furthermore the processed folders for a storage
are cached after first fetch.

Releases: master, 6.2
Resolves: #66695
Change-Id: I9dade448466160f8c66f6118622d074f52bff702
Reviewed-on: http://review.typo3.org/39243
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Reload classAliasMap after extension installation 17/39217/4
Nicole Cordes [Thu, 30 Apr 2015 19:48:04 +0000 (21:48 +0200)]
[BUGFIX] Reload classAliasMap after extension installation

If an extension is installed at least the system cache is cleared
which throws away all defined class aliases as well. Those are only
loaded by bootstrap at the very beginning of an request and need to
be reloaded by the install process manually. This patch adds the
necessary call to ClassLoader.

Releases: master, 6.2
Resolves: #66696
Related: #65141
Change-Id: I4ace91789c43855acba91ac356b2263171cc921a
Reviewed-on: http://review.typo3.org/39217
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Add extension precedence 19/39219/2
Nicole Cordes [Fri, 1 May 2015 11:29:12 +0000 (13:29 +0200)]
[TASK] Add extension precedence

This patch re-adds the possibility to overwrite system or global
extensions with local ones from typoconf/ext.

Releases: master, 6.2
Resolves: #59147
Change-Id: I1f01677791db26d2be4e70c0a81d96e42ca5147c
Reviewed-on: http://review.typo3.org/39219
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Resolve dependencies on extension upload 08/39208/2
Nicole Cordes [Sat, 2 May 2015 12:41:07 +0000 (14:41 +0200)]
[BUGFIX] Resolve dependencies on extension upload

Currently no dependency is checked if an extension is installed by
uploading an extension file (t3x, zip). This might break the system if
any dependency needed is not available.

Releases: master, 6.2
Resolves: #62305
Change-Id: I79fc8157c7b2190f4bd857107dedee0a6de67423
Reviewed-on: http://review.typo3.org/39208
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Force hardware acceleration on scrollable elements 98/39198/2
Benjamin Kott [Sat, 2 May 2015 13:52:47 +0000 (15:52 +0200)]
[BUGFIX] Force hardware acceleration on scrollable elements

Chrome has problems with repaints on HDPI
devices, this results in empty views after a repaint
that can only brought back by resizing the browser.

To prevent this issue we are forcing hardware
acceleration on scrollable elements.

Releases: 6.2
Resolves: #66742
Change-Id: I69c4198e5aa75282272c72b885a3520c53c2817e
Reviewed-on: http://review.typo3.org/39198
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Improve retrieving distribution list 89/39189/2
Nicole Cordes [Sat, 2 May 2015 09:12:35 +0000 (11:12 +0200)]
[TASK] Improve retrieving distribution list

If you open the "Get preconfigured distribution" extension manager
function the extension list is retrieved twice. Furthermore database
queries are executed multiple times. This patch improves retrieving the
extension list, prevents database queries and catches thrown errors to
prevent errors.

Releases: master, 6.2
Resolves: #66730
Change-Id: Ice1bd36e1233fde121bb33232f98a4e25480b0e0
Reviewed-on: http://review.typo3.org/39189
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add translation params for category 91/39191/3
Markus Sommer [Fri, 1 May 2015 12:22:52 +0000 (14:22 +0200)]
[FEATURE] Add translation params for category

Add l10n_mode and l10n_display to TCA Config for category view.

Resolves: #66681
Releases: master, 6.2
Change-Id: I3f895c0578b8506179493f077f94ff0270b78167
Reviewed-on: http://review.typo3.org/39191
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Persistent classes with more than five name parts in extbase 56/39156/2
Artus Kolanowski [Thu, 16 Apr 2015 19:10:09 +0000 (21:10 +0200)]
[BUGFIX] Persistent classes with more than five name parts in extbase

Resolve the table name of a corresponding class correctly when the name
has more than five parts.

This avoids unexpected SQL syntax errors when you have a full qualified
class names like "\Vendor\Extension\Domain\Model\Foo\Bar\Baz".

Resolves: #66425
Releases: master, 6.2
Change-Id: If31fe53bc34a3b2f2080732b2a0237d3480de79f
Reviewed-on: http://review.typo3.org/38749
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
(cherry picked from commit c4886bbf9197855bb39bfb6cf82117fcf159da81)
Reviewed-on: http://review.typo3.org/39156
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Prevent sorting incomplete loaded packages 47/39147/2
Nicole Cordes [Fri, 1 May 2015 08:52:43 +0000 (10:52 +0200)]
[BUGFIX] Prevent sorting incomplete loaded packages

If an extension is defined in PackageStates.php but missing in file
system the package gets unloaded and the PackageStates.php is rewritten.
If a core extension is missing (e.g. extra_page_cm_options) the file
is rewritten with incomplete loaded package information and gets wrongly
sorted.

Releases: master, 6.2
Resolves: #66699
Change-Id: I18e4bb83cf1676537a45ea4b07b9228335e34ec7
Reviewed-on: http://review.typo3.org/39147
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Cannot use equal operator on data type text 94/39094/2
Xavier Perseguers [Thu, 30 Apr 2015 12:50:29 +0000 (14:50 +0200)]
[BUGFIX] Cannot use equal operator on data type text

MSSQL does not allow a column of type "text" to be compared with
an equal operator. It fails with:

    The data types text and varchar are incompatible in the equal to operator

Change-Id: I59e955e53127854fb44ec1af9d81388801438222
Releases: master, 6.2
Resolves: #66686
Reviewed-on: http://review.typo3.org/39086
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/39094

4 years ago[TASK] Do not use sequence table when uid field is auto-incremented 93/39093/2
Xavier Perseguers [Thu, 30 Apr 2015 10:43:42 +0000 (12:43 +0200)]
[TASK] Do not use sequence table when uid field is auto-incremented

A sequence table should not be used when the underlying ADOdb driver
is capable of properly using and retrieving auto-incremented fields.

Change-Id: I8d474e253c927d2dcb4d6ebc9ad6eb5bb4d06f2d
Releases: master, 6.2
Resolves: #66680
Reviewed-on: http://review.typo3.org/39079
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/39093

4 years ago[BUGFIX] ADOdb: mssqlnative driver fails to create sequences 87/39087/2
Xavier Perseguers [Thu, 30 Apr 2015 09:56:29 +0000 (11:56 +0200)]
[BUGFIX] ADOdb: mssqlnative driver fails to create sequences

Change-Id: Ie251d2b9776be4d7c8d3a450cfa1252a57ce07a3
Resolves: #66678
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39075
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-on: http://review.typo3.org/39087

4 years ago[BUGFIX] Adhere absRefPrefix for storages 84/39084/2
Markus Klein [Thu, 23 Apr 2015 22:46:41 +0000 (00:46 +0200)]
[BUGFIX] Adhere absRefPrefix for storages

If plain images from local storages are rendered to FE,
absRefPrefix will now be applied correctly.

Resolves: #66496
Releases: master, 6.2
Change-Id: I9c7c4590d5ca53bb4669da383462dfa63f7ab3ab
Reviewed-on: http://review.typo3.org/39084
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Invalid check for NULL with ISNULL 72/39072/2
Xavier Perseguers [Thu, 30 Apr 2015 08:56:40 +0000 (10:56 +0200)]
[BUGFIX] Invalid check for NULL with ISNULL

MySQL's ISNULL() function cannot be used when EXT:dbal is loaded.

Resolves: #66676
Releases: 6.2
Change-Id: I335c4b53d39d903d1fc9c93a61d15da2db523db8
Reviewed-on: http://review.typo3.org/39072
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] exec_SELECTcountRows where clause must not be empty 74/39074/2
Xavier Perseguers [Thu, 30 Apr 2015 08:25:27 +0000 (10:25 +0200)]
[BUGFIX] exec_SELECTcountRows where clause must not be empty

When using DBAL, the where clause of database query must not be
left empty. exec_SELECTcountRows() defaults to an empty string
and causes the Install Tool to fail to create the tables for the
extension manager.

Change-Id: I9fd66147bf662bbf7e527860756d83ca247a2260
Resolves: #66675
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39074
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>