Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT 38/37038/8
Andreas Allacher [Fri, 20 Feb 2015 09:23:40 +0000 (10:23 +0100)]
[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Change-Id: I92ef213d31c4d62ba797e2741d5a0beaa042c6b3
Resolves: #62280
Releases: master
Reviewed-on: http://review.typo3.org/37038
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Remove module URI storage in global variable 06/37406/2
Helmut Hummel [Sun, 1 Mar 2015 12:29:59 +0000 (13:29 +0100)]
[!!!][TASK] Remove module URI storage in global variable

Previously the URI to a module which was dispatched through mod.php was stored
in a global variable $GLOBALS['MCONF']['_']

In terms of cleanup of global variable usage and
module configuration cleanup, this functionality is removed without substitution.

Instead BackendUtility::getModuleUrl() API must be used now.

Releases: master
Resolves: #65432
Change-Id: Iad436056e96d2334357320278cd8243f0f975538
Reviewed-on: http://review.typo3.org/37406
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Code cleanup: ColorpickerController.php 04/37404/3
Michael Oehlhof [Sun, 1 Mar 2015 12:21:26 +0000 (13:21 +0100)]
[TASK] Code cleanup: ColorpickerController.php

backend/classes/Controller/Wizard/ColorpickerController.php
To get it "green" in PhpStorm several changes were made:

- set correct return type in PhpDoc comment
- makeInstance of GraphicalFunctions to call non-static function
  imageCreateFromFile
- change local variable names to lowerCamelCase

Resolves: #65431
Releases: master
Change-Id: I54182c8ed17423e1cbc1c97e424d92a58dd5e3a9
Reviewed-on: http://review.typo3.org/37404
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Code completion in t3editor behind operator 04/36804/2
Frederic Gaus [Tue, 10 Feb 2015 16:02:07 +0000 (17:02 +0100)]
[BUGFIX] Code completion in t3editor behind operator

Fix code completion in t3editor when substituing a value with
completed code behind a typoscript operator.

Change-Id: Id1fbb99aba850ee0787dba4b8562d0a22c119979
Resolves: #25594
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36804
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Check default storage first to find default upload folder 59/37159/2
Frans Saris [Tue, 24 Feb 2015 10:22:34 +0000 (11:22 +0100)]
[BUGFIX] Check default storage first to find default upload folder

Resolves: #65040
Releases: master, 6.2
Change-Id: I14d6d362db1796c90b03254f6339cb131f152a45
Reviewed-on: http://review.typo3.org/37159
Reviewed-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Tested-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Deprecate DataHandler property stripslashes_values 16/37316/4
Jigal van Hemert [Fri, 27 Feb 2015 10:11:36 +0000 (11:11 +0100)]
[CLEANUP] Deprecate DataHandler property stripslashes_values

The functionality is unnecessary and it's confusing when using
DataHandler that it must be explicitly set to FALSE to handle properly
prepared data. The only place in the core where it was set to TRUE only
handles integer values.

Releases: master
Resolves: #65381
Change-Id: I968fccc9311bb9ad5f9153217ecf84ff4777df4a
Reviewed-on: http://review.typo3.org/37316
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Code cleanup RenameFileController.php 98/37398/2
Michael Oehlhof [Sun, 1 Mar 2015 08:07:26 +0000 (09:07 +0100)]
[TASK] Code cleanup RenameFileController.php

backend/Classes/Controller/File/RenameFileController.php
To get it "green" in PhpStorm several changes are made:

- set correct parameter type in PhpDoc comment
- set correct return type in PhpDoc comment
- add getter for LanguageService
- add getter for DocumentTemplate

Resolves: #65426
Releases: master
Change-Id: I1794d12fed33ab06d460c043632139bc30682a76
Reviewed-on: http://review.typo3.org/37398
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make show_item.php dispatched 86/37186/8
Wouter Wolters [Tue, 24 Feb 2015 20:29:26 +0000 (21:29 +0100)]
[TASK] Make show_item.php dispatched

Use dispatching for show_item.php

Resolves: #65283
Releases: master
Change-Id: If70f513ecc50445ea67b7e68bf7cd1df44cbf013
Reviewed-on: http://review.typo3.org/37186
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] t3editor: Add code autocompletion for listNum 93/36793/4
Frederic Gaus [Tue, 10 Feb 2015 14:21:54 +0000 (15:21 +0100)]
[BUGFIX] t3editor: Add code autocompletion for listNum

Add code autocompletion for property listNum and property
preIfEmptyListNum in t3editor.

Resolves: #25732
Releases: master, 6.2
Change-Id: I13c15e2e262a926e8444d7f50933823b27cdcd9d
Reviewed-on: http://review.typo3.org/36793
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Introduced getters for $GLOBALS in ext:info_pagetsconfig 07/37307/4
Michael Oehlhof [Thu, 26 Feb 2015 23:53:11 +0000 (00:53 +0100)]
[TASK] Introduced getters for $GLOBALS in ext:info_pagetsconfig

Resolves: #65376
Releases: master
Change-Id: If06b63748fba645f7bdd4dce3938d313e598a1ae
Reviewed-on: http://review.typo3.org/37307
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move EXT:cms/layout/res/ files to correct location 93/37293/3
Wouter Wolters [Thu, 26 Feb 2015 21:06:57 +0000 (22:06 +0100)]
[TASK] Move EXT:cms/layout/res/ files to correct location

Resolves: #65296
Releases: master
Change-Id: I08a3c8b6f89c029efacad06e13ea137560370e43
Reviewed-on: http://review.typo3.org/37293
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Introduced getters for $GLOBALS in ext:func 06/37306/2
Michael Oehlhof [Thu, 26 Feb 2015 23:34:21 +0000 (00:34 +0100)]
[TASK] Introduced getters for $GLOBALS in ext:func

Resolves: #65375
Releases: master
Change-Id: I880f4f467e3a634cbabd375d13cb0e9f0029107c
Reviewed-on: http://review.typo3.org/37306
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate alias cObjects COBJ_ARRAY and CASEFUNC 79/37379/2
Benjamin Mack [Sat, 28 Feb 2015 21:02:11 +0000 (22:02 +0100)]
[TASK] Deprecate alias cObjects COBJ_ARRAY and CASEFUNC

The alias cObjects COBJ_ARRAY for COA and CASEFUNC
for CASE are moved to compatibility6.

Resolves: #65422
Change-Id: I419997c3b70d0dfd9e23d9bc67bf909295e4faff
Reviewed-on: http://review.typo3.org/37379
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Do not respect autoload info if core repo is composer root 73/37373/2
Helmut Hummel [Sat, 28 Feb 2015 20:33:18 +0000 (21:33 +0100)]
[TASK] Do not respect autoload info if core repo is composer root

Doing a composer install directly in typo3 source has been
a requirement for core development for a while and a convenient shortcut
to quickly set up a TYPO3 installation for executing tests for extensions.

Respecting the class loading information generated in that location is
unfortunate however as it would require editing of the core composer.json
if additional classes from the core should respected.

Instead of respecting this as valid composer autoload file location,
we always fall back to the hard coded and committed class loading info
if no autoload file of a composer distribution call is found.

Releases: master, 6.2
Resolves: #65420
Change-Id: I1953303c6d2b5b221017deb7d2d7a0b43e4d08bf
Reviewed-on: http://review.typo3.org/37373
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Allow file:// links in Element Browser 70/37370/2
Nicole Cordes [Sat, 28 Feb 2015 19:19:43 +0000 (20:19 +0100)]
[FOLLOWUP][BUGFIX] Allow file:// links in Element Browser

This patch allows the use of links with file scheme in typolink().

Releases: master, 6.2
Resolves: #65358
Change-Id: I25a8ca88637d1ecab4881127cf2228214b6c954a
Reviewed-on: http://review.typo3.org/37370
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][TASK] Move Media cObject and CTypes 77/37377/2
Benjamin Mack [Sat, 28 Feb 2015 20:52:45 +0000 (21:52 +0100)]
[FOLLOWUP][TASK] Move Media cObject and CTypes

Missed some removal of old classes,
also make sure that they are registered for FE and BE.

Resolves: #64719
Releases: master
Change-Id: I416d1a9fa19aacb5950e8f33e0e085b020f4d242
Reviewed-on: http://review.typo3.org/37377
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] SelectViewHelper must respect option(Value|Label)Field for arrays 09/36909/2
Alexander Schnitzler [Sat, 14 Feb 2015 16:32:28 +0000 (17:32 +0100)]
[BUGFIX] SelectViewHelper must respect option(Value|Label)Field for arrays

The SelectViewHelper tries to resolve the value and label
field as long as options are of type object, i.e. domain
objects but that functionality must also exist for arrays
because their structure is similar to objects.

Example:
<f:form.select
options="{items}"
optionValueField="uid"
optionLabelField="title"
/>

$items = array(
    0 => array(
        'uid' => 1,
        'title' => 'Foo'
    ),
);

Currently the view helper tries to use the array key as
value field (i.e. 0) and the array value (i.e. array) as
label and fails calling htmlspecialchars on the array.

This patch allows values to be arrays themselves and to
be treated like domain objects.

Resolves: #65073
Releases: master, 6.2
Change-Id: Ia803ceb38c1f7488d48863f5a6781b229def50c4
Reviewed-on: http://review.typo3.org/36909
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Andy Grunwald <andygrunwald@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move frontend registration from EXT:cms to EXT:frontend 68/37368/2
Benjamin Mack [Sat, 28 Feb 2015 18:56:46 +0000 (19:56 +0100)]
[TASK] Move frontend registration from EXT:cms to EXT:frontend

EXT:cms still registers logic that is completely placed
inside EXT:frontend (classes, content element wizards, tables, CTypes).

These leftovers are moved to EXT:frontend.

Resolves: #65418
Releases: master
Change-Id: I3919340de863a7b1c07149161d2ce758e42de4db
Reviewed-on: http://review.typo3.org/37368
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] General code cleanup in ext:rsaauth 03/37303/2
Wouter Wolters [Thu, 26 Feb 2015 22:50:46 +0000 (23:50 +0100)]
[TASK] General code cleanup in ext:rsaauth

Resolves: #65374
Releases: master
Change-Id: I64d942327a49d6e5cb6d292ee260b4c37b459374
Reviewed-on: http://review.typo3.org/37303
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Prevent wrong ref_index for fields with soft references 86/37086/2
Nicole Cordes [Thu, 19 Feb 2015 09:55:13 +0000 (10:55 +0100)]
[BUGFIX] Prevent wrong ref_index for fields with soft references

If you add a page link to a field which is defined as softrefs, the
ReferenceIndex creates an index to a FAL record if there exists a file
record with the page id. As file links are always prefixed with 'file:'
this patch adds a proper check before generating a file ref_index.

Because the functional tests of impexp extension still use a hardcoded
file path for the header_link field the patch corrects the value to
refer to a file.

Furthermore if you add a file or folder link, the field is referenced
twice for the FAL record. So we have to suppress the softreference for
those records.

Releases: master, 6.2
Resolves: #60226
Change-Id: I969224e2a291491cb7ece1f61b375071bf0eaebc
Reviewed-on: http://review.typo3.org/37086
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Göran Bodenschatz <coding@46halbe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Move media libraries to EXT:mediace 67/37367/2
Benjamin Mack [Sat, 28 Feb 2015 18:48:38 +0000 (19:48 +0100)]
[TASK] Move media libraries to EXT:mediace

Files related solely to the media Content Element
are moved from typo3/contrib/ to the
extension itself.

Resolves: #65417
Releases: master
Change-Id: I8223f204ccf35c4f4399760da90a90d6a7d1e46d
Reviewed-on: http://review.typo3.org/37367
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Add back button from info page to element browser wizard 48/36848/4
Stanislas Rolland [Wed, 11 Feb 2015 19:15:52 +0000 (14:15 -0500)]
[BUGFIX] Add back button from info page to element browser wizard

When using the element browser for image insertion in backend form
or in RTE, there should be some Back button on the Info page to go back
to the wizard form.
Currently, one has to close the window and start over.

Releases: master
Resolves: #55787
Change-Id: I909767feaacf260736707b3b28cb34efe2bf82e6
Reviewed-on: http://review.typo3.org/36848
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Escape regex chars when building sWordRegEx 28/37328/2
Alexander Stehlik [Fri, 27 Feb 2015 19:13:53 +0000 (20:13 +0100)]
[BUGFIX] Escape regex chars when building sWordRegEx

The submitted sword_list GET parameters are parsed through
preg_quote() when loaded into  TSFE->sWordRegEx to prevent
invalid regular expressions.

The initialization is moved to a seperate method
PageGenerator::initializeSearchWordDataInTsfe() and unit
tests are added.

Releases: master, 6.2
Resolves: #41728
Change-Id: Id96fd5e201c25b06001f7e1c7811d6c38239aafa
Reviewed-on: http://review.typo3.org/37328
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Allow file:// links in Element Browser 29/37329/2
Nicole Cordes [Fri, 27 Feb 2015 19:20:36 +0000 (20:20 +0100)]
[BUGFIX] Allow file:// links in Element Browser

Due to FAL checks it's not possible to link to a file:// resource as
external link. This patch checks for correct "file:" prefix for FAL
relations and allows the use of file:// as external link scheme.

Furthermore a Javascript error is resolved which prevents the closing
of the Element Browser in Chrome.

Releases: master, 6.2
Resolves: #65358
Change-Id: I706fd975654bf82a0830d9901f08ae9de7cc49bf
Reviewed-on: http://review.typo3.org/37329
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Browse for records in edit document popup works again 89/37089/4
Michael Oehlhof [Sun, 22 Feb 2015 02:01:01 +0000 (03:01 +0100)]
[BUGFIX] Browse for records in edit document popup works again

When editing a group in the edit document popup the browse for records
button was without function, this is now fixed.

Resolves: #65215
Releases: master
Change-Id: I1bed83669d8a62f193f6b92d3fd3a39f5250707f
Reviewed-on: http://review.typo3.org/37089
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Make edit button in FormEngine wizard work again 59/37359/2
Benjamin Mack [Sat, 28 Feb 2015 16:56:53 +0000 (17:56 +0100)]
[BUGFIX] Make edit button in FormEngine wizard work again

When clicking on the edit button wizard in FormEngine
(e.g. when editing a be_group inside the be_user record)
then there is a JS error preventing from opening a popup.

Resolves: #65415
Relates: #63846
Releases: master
Change-Id: Iafac6759054d0e2ce229b34b17b6a5312e1408df
Reviewed-on: http://review.typo3.org/37359
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Always load scriptaculous in FormEngine 60/37360/2
Benjamin Mack [Sat, 28 Feb 2015 17:01:59 +0000 (18:01 +0100)]
[BUGFIX] Always load scriptaculous in FormEngine

As the refactoring of FormEngine now always
includes the suggest JS code,
scriptaculous needs to be loaded all the time
as well for the time being (as long as scriptaculous
is still needed).

Resolves: #65416
Relates: #55575
Releases: master
Change-Id: I276448c7c0dc6745926eb18a0ffae49836c718f2
Reviewed-on: http://review.typo3.org/37360
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Streamline TS registration for sysexts 39/37239/3
Benjamin Mack [Wed, 25 Feb 2015 17:37:50 +0000 (18:37 +0100)]
[TASK] Streamline TS registration for sysexts

For historical reasons the "Static Template #43"
was "content.default" and the possibility to add
TypoScript after this default rendering was introduced
in order to have CTypes and plugins register their
TypoScript just after e.g. "content.default" or
"css_styled_content".

Since TYPO3 CMS 6.2 the preferred option is
called "defaultContentRendering" instead of
the magic number "43".

Some leftover parts in sysexts are replaced
with "defaultContentRendering", as well
as some more descriptive information on
how the legacy number exists.

Releases: master
Resolves: #65346
Change-Id: I7268ec9ee8454d1eb4b0fda9f12fdfb5cb191ba8
Reviewed-on: http://review.typo3.org/37239
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] File must use MIME type from index record 14/37214/2
Andreas Wolf [Wed, 25 Feb 2015 12:52:22 +0000 (13:52 +0100)]
[BUGFIX] File must use MIME type from index record

The MIME type is stored in a field "mimetype" in the drivers, while the
field is called "mime_type" in the database. As the file object deals
with both when retrieving the type, it must respect this mismatch.

Change-Id: I06882c4d77e38284a48f7f7d7527bfc1c535edf3
Resolves: #65335
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/37214
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Unification of function naming 23/36823/2
Frederic Gaus [Wed, 11 Feb 2015 09:56:58 +0000 (10:56 +0100)]
[CLEANUP] Unification of function naming

The usage of getBackendUser and getBackendUserAuthentication is mixed
up in the core. But at least in inheritance this should be consistent.

Rename ScheduleModuleController::getBackendUserAuthentication to
ScheduleModuleController::getBackendUser

Change-Id: Icf21b4565ed66d3dabaf1df2d62d6b022c07248c
Resolves: #64982
Releases: master
Reviewed-on: http://review.typo3.org/36823
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Rethrow Extbase scheduler task exceptions 85/36985/4
Mathias Brodala [Wed, 18 Feb 2015 08:10:37 +0000 (09:10 +0100)]
[BUGFIX] Rethrow Extbase scheduler task exceptions

This makes sure exception details thrown in Extbase scheduler tasks
can be shown by the Scheduler.

Resolves: #49071
Releases: master, 6.2
Change-Id: Ic703568715bf92523a9cbd0dcab6c5606ea278bb
Reviewed-on: http://review.typo3.org/36985
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Ensure new deep dirs don't contain double slashes 99/36399/8
Thomas Deuling [Fri, 30 Jan 2015 10:06:42 +0000 (11:06 +0100)]
[BUGFIX] Ensure new deep dirs don't contain double slashes

The method of GeneralUtility::mkdir_deep has two parameters, which are
concatenated. This could end up in a double slashes. To prevent that,
the parameters are modified to concat them with only one slash.

Additionally fix a Bug with double slash in FileStreamWrapper.

Resolves: #63920
Releases: master, 6.2
Change-Id: I2d15f6c33550f9045db9b7730f7b074ae54a18dc
Reviewed-on: http://review.typo3.org/36399
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Move Media cObject and CTypes to new extension 72/36572/5
Benjamin Mack [Mon, 2 Feb 2015 20:25:41 +0000 (21:25 +0100)]
[TASK] Move Media cObject and CTypes to new extension

In order to separate features and also consolidate code for specific
features into one place, a new system extension is created.

The extension "mediace" ships with the core (not installed by default)
for now but could be moved to TER in future releases.

Next steps are:
- move third-party files from typo3/contrib/ to EXT:mediace
- find a proper solution to move the MediaWizard provider
- (optionally) create a Update Wizard that checks if the system uses
   media or multimedia elements or the "multimedia" and install the extension automatically.

Change-Id: I312ba6c15fece3a1319de23c085790590a659755
Resolves: #64719
Releases: master
Reviewed-on: http://review.typo3.org/36572
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[!!!][TASK] Improve FormEngine and sub classes separation 65/37265/6
Christian Kuhn [Sat, 7 Feb 2015 20:19:13 +0000 (21:19 +0100)]
[!!!][TASK] Improve FormEngine and sub classes separation

This patch improves the separation of FormEngine and its sub
classes. Currently, all sub classes like single element and wizard
classes get an instance of the parent object to call various methods
and properties on them. This is very hard to refactor and the mesh
of call trees must be simplified to ease further refactoring and
improve maintainability of code.

This patch follows a divide & conquer approach:
* Methods only used by sub elements are moved to AbstractFormElement
* Properties FormEngine "knows" that are needed by element classes
  are given down in a data array during element instatiation to have
  a clear definition of what element classes know.
* Methods used by both FormEngine and sub classes that do not need
  an instance of FormEngine are moved to a static helper for now to
  reduce the amount of code in FormEngine and to mark certain areas
  as stateless.
* Class instances are not created on a global level anymore but
  created only in the scope where they are used
* Class instances injected by outer code are created internally
  for enabling the using code to be moved around.

All in all, this patch is mostly a preparation of defining a
fully separated structure with defined concerns for every sub class.

Most methods are moved around "as is" without changing functionality.
The only area that is refactored codewise is renderWizards().

There is still a nasty circular dependency between FormEngine,
FlexFormElement and InlineElement. This is not resolved by the patch,
but the surrounding code is now separated enough that this structure
could be refactored to a tree. This may follow with other patches.

This patch evolved on catharsis in branch formengine with 53 single
patches. Details can be looked up there, all single patches are
prefixed with [FormEngine].
https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine

Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
Releases: master
Resolves: #65357
Resolves: #63848
Resolves: #63849
Resolves: #63851
Resolves: #63853
Resolves: #63855
Resolves: #63857
Resolves: #63867
Resolves: #63868
Resolves: #63869
Resolves: #63870
Resolves: #63871
Resolves: #63872
Resolves: #63873
Resolves: #63874
Resolves: #63875
Resolves: #63877
Resolves: #63879
Resolves: #63880
Resolves: #63884
Resolves: #63885
Resolves: #63886
Resolves: #63887
Resolves: #63888
Resolves: #63890
Resolves: #63892
Reviewed-on: http://review.typo3.org/37265
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][TASK] Introduce getters for $GLOBALS in ext:setup 09/37309/2
Wouter Wolters [Fri, 27 Feb 2015 08:07:55 +0000 (09:07 +0100)]
[FOLLOWUP][TASK] Introduce getters for $GLOBALS in ext:setup

Resolves: #65372
Releases: master
Change-Id: I19d67cb8de220f25f74667bc39a5ca25c62c9500
Reviewed-on: http://review.typo3.org/37309
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:sys_action 05/37305/2
Wouter Wolters [Thu, 26 Feb 2015 23:08:14 +0000 (00:08 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:sys_action

Resolves: #65302
Releases: master
Change-Id: I215fc48ba7a1ac72e5be5c7357a2dd1557413d1f
Reviewed-on: http://review.typo3.org/37305
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:wizard_sortpages 37/37237/3
Wouter Wolters [Wed, 25 Feb 2015 17:15:51 +0000 (18:15 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:wizard_sortpages

Resolves: #65297
Releases: master
Change-Id: I7822f7aa48fc47940300467ea15422d5910767cb
Reviewed-on: http://review.typo3.org/37237
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Replace $GLOBALS[‘LANG’] with local property in ext:aboutmodules 97/37297/2
Michael Oehlhof [Thu, 26 Feb 2015 21:59:52 +0000 (22:59 +0100)]
[TASK] Replace $GLOBALS[‘LANG’] with local property in ext:aboutmodules

The local property languageService was only used in the indexAction.
In getModulesData and getSubModuleData there was still $GLOBALS[‘LANG’]
used, which is now changed to the local property languageService.

Resolves: #65368
Releases: master
Change-Id: Ibae1f34b7baa37d5693bdb8220f59c23c5bbac0c
Reviewed-on: http://review.typo3.org/37297
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Wrong signal class name in DatabaseTreeDataProvider 52/37252/15
Andreas Allacher [Thu, 26 Feb 2015 12:18:07 +0000 (13:18 +0100)]
[BUGFIX] Wrong signal class name in DatabaseTreeDataProvider

In the emitPostProcessTreeDataSignal of the DatabaseTreeDataProvider
the namespace for the SlotDispatcher to get the class name is wrong.
TableConfiguration is used twice here. This patch removes the doubled
namespace.

Releases: master
Resolves: #65360
Change-Id: Iff4f02ad63cc0f7ed6f0176a624aa293c5b1f4cc
Reviewed-on: http://review.typo3.org/37252
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getter for $GLOBALS['LANG'] in ext:context_help 98/37298/2
Michael Oehlhof [Thu, 26 Feb 2015 22:22:43 +0000 (23:22 +0100)]
[TASK] Introduce getter for $GLOBALS['LANG'] in ext:context_help

Resolves: #65369
Releases: master
Change-Id: Id488fb523c3b3dcc255f9c5d36af537abec267d0
Reviewed-on: http://review.typo3.org/37298
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:setup 01/37301/2
Wouter Wolters [Thu, 26 Feb 2015 22:32:34 +0000 (23:32 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:setup

Resolves: #65372
Releases: master
Change-Id: I631590fd7ccb108aded2cd9b957331d0891e0bf8
Reviewed-on: http://review.typo3.org/37301
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduced getter for $GLOBALS['LANG'] in ext:cshmanual 00/37300/2
Michael Oehlhof [Thu, 26 Feb 2015 22:33:28 +0000 (23:33 +0100)]
[TASK] Introduced getter for $GLOBALS['LANG'] in ext:cshmanual

Resolves: #65371
Releases: master
Change-Id: I6832775eda3c97229b764bdb258b5f3ffb813402
Reviewed-on: http://review.typo3.org/37300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce getters for $GLOBALS in ext:taskcenter 90/37290/2
Wouter Wolters [Thu, 26 Feb 2015 17:58:47 +0000 (18:58 +0100)]
[TASK] Introduce getters for $GLOBALS in ext:taskcenter

Resolves: #65299
Releases: master
Change-Id: I3d3d9409e8994f9e61a487b02a132cc2db6c14df
Reviewed-on: http://review.typo3.org/37290
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move ext:sys_action/x-sys_action.png to correct location 89/37289/2
Wouter Wolters [Thu, 26 Feb 2015 17:54:00 +0000 (18:54 +0100)]
[TASK] Move ext:sys_action/x-sys_action.png to correct location

Resolves: #65301
Releases: master
Change-Id: I1f479807f684952d183bee7dcfa1a26897c33c1d
Reviewed-on: http://review.typo3.org/37289
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Align submit and action button's positions 38/36738/9
Felix Kopp [Sat, 21 Feb 2015 23:42:21 +0000 (00:42 +0100)]
[TASK] Align submit and action button's positions

Unify button positions as last column in tables and obvious submit
buttons underneath tables.

+ extension manager - switch state/action columns
+ scheduler - add button style to overview/info
+ func wizards sort - add submit button style

Resolves: #64926
Releases: master
Change-Id: If6a413d24c7af769284ac77d5764cced7b14f5bc
Reviewed-on: http://review.typo3.org/36738
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix cookie evaluation order 30/37030/6
Helmut Hummel [Sun, 22 Feb 2015 08:11:06 +0000 (09:11 +0100)]
[BUGFIX] Fix cookie evaluation order

The workaround added for IE8 in #22084 is not needed any more
and removed without substitution.

This avoids problems with multiple cookies which might be sent
due to nested instances or due to moving an instance around in the
folder hierarchy.

Resolves: #65187
Releases: master, 6.2
Change-Id: I75c3ebcde62257cef91837bf1fc8272e2dd77eac
Reviewed-on: http://review.typo3.org/37030
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Streamline ext_localconf.php / ext_tables.php of sysexts 40/37240/4
Benjamin Mack [Wed, 25 Feb 2015 18:33:36 +0000 (19:33 +0100)]
[TASK] Streamline ext_localconf.php / ext_tables.php of sysexts

In order to have a proper "way to do things" for extension
developers to look up registration process the following
parts were streamlined:

- Discouraged usage of the pseudo-global variable $_EXTKEY inside
  ext_localconf.php and ext_tables.php in favor of strings.
  For module registrations this part was left out for now as
  module registration will be streamlined separately.
- Use PHP5.5-style ::class in all occurrences instead of escaped
  strings for class names.
- Use $GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS.

Releases: master
Resolves: #65347
Change-Id: Iad03e42d38d65ae1483ef8190f755430ec617e45
Reviewed-on: http://review.typo3.org/37240
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Move EXT:cms/layout/wizard_backend_layout.png 09/37209/2
Wouter Wolters [Wed, 25 Feb 2015 12:01:13 +0000 (13:01 +0100)]
[TASK] Move EXT:cms/layout/wizard_backend_layout.png

Resolves: #65295
Releases: master
Change-Id: I072b91e1085bf4def958dc2fdf51a45a01995492
Reviewed-on: http://review.typo3.org/37209
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Travis-ci: Add PHP 7 nightly 48/37248/3
Christian Kuhn [Wed, 25 Feb 2015 22:45:05 +0000 (23:45 +0100)]
[TASK] Travis-ci: Add PHP 7 nightly

Add PHP to monitor the situation and fix issues
as soon as the environment stabilized.

Change-Id: Ic08a6464c6be1fe43bc98a62d2bdca1acd6c814f
Releases: master
Reviewed-on: http://review.typo3.org/37248
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Wrong reference to icon in EXT:taskcenter 06/37206/2
Wouter Wolters [Wed, 25 Feb 2015 11:52:06 +0000 (12:52 +0100)]
[BUGFIX] Wrong reference to icon in EXT:taskcenter

The icon was moved with #61200

Resolves: #65298
Releases: master
Change-Id: I0326e2d496905d5e4edb4e842cdd67fb86967290
Reviewed-on: http://review.typo3.org/37206
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Typo in Rst documentation for issue #61459 41/37241/2
Benjamin Mack [Wed, 25 Feb 2015 18:36:08 +0000 (19:36 +0100)]
[BUGFIX] Typo in Rst documentation for issue #61459

Replace "typo/" with "typo3/".

Releases: master
Resolves: #65348
Related: #61459
Change-Id: I39d7f1516a41172dadf71a51f5743bdfa67f243f
Reviewed-on: http://review.typo3.org/37241
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Streamline BE User Initialization with TYPO3_OS 33/37233/2
Benjamin Mack [Wed, 25 Feb 2015 16:40:29 +0000 (17:40 +0100)]
[TASK] Streamline BE User Initialization with TYPO3_OS

The BE User initialization in the core uses the TYPO3_OS
constant in various places. The initialization can be
done in the constructor directly. Also, the property
itself ($BE_USER->OS) is not in use directly by the core
and it is encouraged to use the constant directly. The
property is therefore marked for deprecation.

Releases: master
Resolves: #65343
Change-Id: I527f871bab419274c5a712a6a146d978be13d5cf
Reviewed-on: http://review.typo3.org/37233
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] MENU Content Object classes 84/36584/5
Markus Klein [Sun, 4 Jan 2015 02:23:10 +0000 (03:23 +0100)]
[CLEANUP] MENU Content Object classes

Change-Id: Ie911ce6da7fa60babc90104c27a45371c15492b4
Resolves: #64099
Releases: master
Reviewed-on: http://review.typo3.org/36584
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Workspaces: Fix broken buttons in frontend 97/37097/5
Andreas Fernandez [Mon, 23 Feb 2015 07:08:45 +0000 (08:08 +0100)]
[BUGFIX] Workspaces: Fix broken buttons in frontend

Adds a font size to the button text, so the button text in the
"send stage" windows in the workspace dialogs used in the
frontend become visible again. Also, a background color is
added to the top buttons to fix the "cut".

Resolves: #65102
Releases: master, 6.2
Change-Id: I928299e602829b322e3c6515367bcf1ac59b2479
Reviewed-on: http://review.typo3.org/37097
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Improve description in ext:sys_note/ext_localconf.php 07/37207/2
Wouter Wolters [Wed, 25 Feb 2015 11:55:59 +0000 (12:55 +0100)]
[TASK] Improve description in ext:sys_note/ext_localconf.php

Improve the description of the manual registering of
"switchableControllerActions"

Resolves: #65300
Releases: master
Change-Id: I8d376611d1db4c0c128fe8b3d2a4929d0a7c06c9
Reviewed-on: http://review.typo3.org/37207
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Updated copyright year in typo3/sysext/README.txt 08/37208/2
Wouter Wolters [Wed, 25 Feb 2015 11:57:34 +0000 (12:57 +0100)]
[TASK] Updated copyright year in typo3/sysext/README.txt

Resolves: #65294
Releases: master
Change-Id: I56de58378c291d79127c713251b0fe99085bc02f
Reviewed-on: http://review.typo3.org/37208
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix faulty negation in FileInfo implementation 05/37205/2
Sascha Egerer [Wed, 25 Feb 2015 11:45:35 +0000 (12:45 +0100)]
[BUGFIX] Fix faulty negation in FileInfo implementation

A faulty negation in the FileInfo class could end in a fatal
error if `finfo` is not supported by the php version and ends up
in not using `finfo` but `mime_content_type` if `finfo` is
supported.

Resolves: #65329
Releases: master
Change-Id: I768d70501ee4a8f03317563cef2d95e59e791e7d
Reviewed-on: http://review.typo3.org/37205
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Prevent duplicate '/' in filepath when uploading file 04/37104/3
Sascha Egerer [Mon, 23 Feb 2015 11:02:46 +0000 (12:02 +0100)]
[BUGFIX] Prevent duplicate '/' in filepath when uploading file

To prevent a duplicate '/' in a filepath the function
LocalDriver::getAbsolutePath should be used instead of
concatenating strings by hand.
This fixes also an issue that file uploads are not
possible on windows machines due to a incorrect filepath.

Resolves: #65230
Releases: master, 6.2
Change-Id: Ibe6ff9c8c1d6579c8da24f14cfd6e528f57a8e4f
Reviewed-on: http://review.typo3.org/37104
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Set extension version and dependencies to 7.2 89/37189/2
Wouter Wolters [Tue, 24 Feb 2015 20:59:44 +0000 (21:59 +0100)]
[TASK] Set extension version and dependencies to 7.2

Resolves: #65286
Releases: master
Change-Id: I7c8576ebb76bb02582396e1345e253ba0e9a1623
Reviewed-on: http://review.typo3.org/37189
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove the closing PHP tag 87/37187/2
Wouter Wolters [Tue, 24 Feb 2015 20:38:54 +0000 (21:38 +0100)]
[TASK] Remove the closing PHP tag

Resolves: #65284
Releases: master
Change-Id: Icff258aac434e815a629e47290b41263674502f4
Reviewed-on: http://review.typo3.org/37187
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Show "Add task" after stopping a running task 13/37113/3
Andreas Fernandez [Mon, 23 Feb 2015 14:01:23 +0000 (15:01 +0100)]
[BUGFIX] Show "Add task" after stopping a running task

Check if CMD is "stop" to make "Add task" visible.

Resolves: #65235
Releases: master, 6.2
Change-Id: Ia5b87f6105e14e224e8db0541d6fe36a021d8ba3
Reviewed-on: http://review.typo3.org/37113
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Set TYPO3 version to 7.2.0-dev 70/37170/2
Oliver Hader [Tue, 24 Feb 2015 14:39:28 +0000 (15:39 +0100)]
[TASK] Set TYPO3 version to 7.2.0-dev

Releases: master
Change-Id: I901675473bf00227e94c51edca5c2df065627a41
Reviewed-on: http://review.typo3.org/37170
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Set TYPO3 version to 7.1.1-dev 69/37169/2
TYPO3 Release Team [Tue, 24 Feb 2015 15:08:00 +0000 (16:08 +0100)]
[TASK] Set TYPO3 version to 7.1.1-dev

Change-Id: Ie8b44f5886414885ec5132821f3565185f99425c
Reviewed-on: http://review.typo3.org/37169
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
4 years ago[RELEASE] Release of TYPO3 7.1.0 68/37168/2 7.1.0 TYPO3_7-1-0
TYPO3 Release Team [Tue, 24 Feb 2015 15:07:24 +0000 (16:07 +0100)]
[RELEASE] Release of TYPO3 7.1.0

Change-Id: Ia2e6ab0c8274d2c2bfc3cc61b3b72447ca9741d8
Reviewed-on: http://review.typo3.org/37168
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
4 years agoRevert "[BUGFIX] Properly handle translation file detection" 66/37166/2
Markus Klein [Tue, 24 Feb 2015 14:21:24 +0000 (15:21 +0100)]
Revert "[BUGFIX] Properly handle translation file detection"

This reverts commit 81ec05a3fc39845426f302412d53ef6480fc7c3a.

The patch is reverted as it was merged in a merge-freeze
by accident.
Backport has not been merged yet.

Change-Id: I805393f32e9ddf0c635d492a298ec0c3d2d50132
Releases: master
Reviewed-on: http://review.typo3.org/37166
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Properly handle translation file detection 85/34285/7
Mathias Schreiber [Thu, 18 Dec 2014 10:24:21 +0000 (11:24 +0100)]
[BUGFIX] Properly handle translation file detection

The GeneralUtility::llXmlAutoFileName() method will now also correctly
handle paths to files that are not placed within a known directory (ext,
sysext, test etc.) if the call is made with $sameFile = TRUE.

This allows placing language files in storages like fileadmin.

Resolves: #35093
Resolves: #34728
Releases: master, 6.2
Change-Id: Ic5901c3fa98233978abf26db377666dade16f8e6
Reviewed-on: http://review.typo3.org/34285
Reviewed-by: Gernot Ploiner <gp@webprofil.at>
Tested-by: Gernot Ploiner <gp@webprofil.at>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Element browser: importing a selection of images does not work 60/36960/2
Stanislas Rolland [Mon, 16 Feb 2015 21:13:44 +0000 (16:13 -0500)]
[BUGFIX] Element browser: importing a selection of images does not work

When using the element browser wizard to import a selection of images
into an images or text+images content element, the list of uid's of
images to import is malformed and insertion fails.

Releases: master
Resolves: #65109
Change-Id: Ib32043507ef0dd6969c60d57738eaf16f2597192
Reviewed-on: http://review.typo3.org/36960
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Andy Grunwald <andygrunwald@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add missing isset() check in HTMLParser 15/37115/2
Markus Klein [Mon, 23 Feb 2015 15:23:47 +0000 (16:23 +0100)]
[BUGFIX] Add missing isset() check in HTMLParser

This is a regression fix for #54091.
It has been forgotten to add an isset() check for 'fixAttrib.set'.

Releases: master
Resolves: #65239
Change-Id: Ia39ef0760dab61bdb5bbfb71e525cc96e15f3077
Reviewed-on: http://review.typo3.org/37115
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Enable clipboard by default 46/37046/3
Andreas Fernandez [Fri, 20 Feb 2015 13:52:38 +0000 (14:52 +0100)]
[TASK] Enable clipboard by default

The clipboard is enabled by default now, which displays the copy /
cut / paste actions.

Resolves: #55950
Releases: master
Change-Id: If2410be70209530284ac370f0f987f155caf2e69
Reviewed-on: http://review.typo3.org/37046
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Make new content element button in page view speaking 57/37057/4
Benjamin Kott [Fri, 20 Feb 2015 18:31:36 +0000 (19:31 +0100)]
[TASK] Make new content element button in page view speaking

The new content element button is hard to spot for new users
and not self explaining / missleading in the first place.

Unifying the "new record here" button with the corresponding
title from the new record view makes it more clear what kinds
of records will be available to place in a column and at the place
the user has chosen.

Resolves: #65206
Releases: master
Change-Id: Icbe897f943d27771cdbb5e70505d1f47f6adfbdf
Reviewed-on: http://review.typo3.org/37057
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years agoRevert "[BUGFIX] Prevent wrong ref_index for fields with soft references" 82/37082/2
Nicole Cordes [Sat, 21 Feb 2015 20:25:50 +0000 (21:25 +0100)]
Revert "[BUGFIX] Prevent wrong ref_index for fields with soft references"

This reverts commit 7dfd4607ab7e54e54b4bf710cff1e8e690cd6a67.

Change-Id: I695b897597deb8d252cd9988e671175ebd8a1835
Reviewed-on: http://review.typo3.org/37082
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Prevent wrong ref_index for fields with soft references 16/37016/5
Nicole Cordes [Thu, 19 Feb 2015 09:55:13 +0000 (10:55 +0100)]
[BUGFIX] Prevent wrong ref_index for fields with soft references

If you add a page link to a field which is defined as softrefs, the
ReferenceIndex creates an index to a FAL record if there exists a file
record with the page id. As file links are always prefixed with 'file:'
this patch adds a proper check before generating a file ref_index.

Furthermore if you add a file or folder link, the field is referenced
twice for the FAL record. So we have to suppress the softreference for
those records.

Releases: master, 6.2
Resolves: #60226
Change-Id: Ieb9179d393e23eda4fdb1bb47ba4693bd92e75d9
Reviewed-on: http://review.typo3.org/37016
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Prevent cut off font icons on zoom 70/37070/3
Benjamin Kott [Sat, 21 Feb 2015 15:23:23 +0000 (16:23 +0100)]
[BUGFIX] Prevent cut off font icons on zoom

Font icons were cut off on top when browser is zoomed
or subpixel placement is not ideal.

Also corrected the wrong placed CSS classes in the
extension manager on extension import.

Releases: master
Resolves: #65212
Change-Id: If073b9a65550caaa816e68adde3c7758dd9586e3
Reviewed-on: http://review.typo3.org/37070
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Use current domain if found in domain record 37/37037/9
Helmut Hummel [Fri, 20 Feb 2015 15:46:55 +0000 (16:46 +0100)]
[BUGFIX] Use current domain if found in domain record

The introduction of domain record cache with #24389 introduced a regression.
Previously if multiple domain names were found for one subtree,
the domain name which matched the current host name was preferred.
After the introduction of the cache, only the first domain record was
considered.

This patch properly checks the domain records against the current domain
in use and selects the most appropriate one.

Releases: master, 6.2
Resolves: #62556
Change-Id: I9cae580af9c9de0c1f6ed02d5ac8ad6a90a0fa2b
Reviewed-on: http://review.typo3.org/37037
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Remove space between buttons in button-group 54/37054/2
Benjamin Kott [Fri, 20 Feb 2015 15:19:01 +0000 (16:19 +0100)]
[FOLLOWUP][BUGFIX] Remove space between buttons in button-group

Prevent overlapping of buttons in irre-header.

Releases: master
Resolves: #65110
Change-Id: I96f5b384dc91d0c38c253f5fc2e397f12482d0c4
Reviewed-on: http://review.typo3.org/37054
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Streamline page position map 63/37063/5
Benjamin Kott [Sat, 21 Feb 2015 00:50:25 +0000 (01:50 +0100)]
[TASK] Streamline page position map

- Reduce usage of custom CSS in page position map
  for inserting/moving content elements.
- Add missing language file
- Remove unused CSS

Releases: master
Resolves: #65210
Change-Id: Icfec5fbc927d291129fd2dc663633b76ebb2ad7e
Reviewed-on: http://review.typo3.org/37063
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Display error message for "Check for broken extensions" 24/37024/4
Nicole Cordes [Thu, 19 Feb 2015 16:24:08 +0000 (17:24 +0100)]
[BUGFIX] Display error message for "Check for broken extensions"

If you try to uninstall an extension, which is needed by another one,
the process triggers an error without any information for the user. This
patch catches the exception and shows it in frontend.

Releases: master, 6.2
Resolves: #63672
Change-Id: I339b3cb533e7ec22cbdd27a2661e1b775ac665c0
Reviewed-on: http://review.typo3.org/37024
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Prevent warning in FAL "Update storage index" scheduler task 36/37036/5
Nicole Cordes [Fri, 20 Feb 2015 08:47:24 +0000 (09:47 +0100)]
[BUGFIX] Prevent warning in FAL "Update storage index" scheduler task

Due to the use of intval within array_walk a warning is triggered,
because array_walk calls the function with two parameters where intval
only expects one. This patch replaces the array_walk function with
DatabaseConnection::cleanIntArray.

Releases: master, 6.2
Resolves: #65189
Change-Id: Ic487f2da589e1610bd9ac7ec721d48a2735ef980
Reviewed-on: http://review.typo3.org/37036
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Recycler: Reload table list on "reload" 40/37040/3
Andreas Fernandez [Fri, 20 Feb 2015 10:03:59 +0000 (11:03 +0100)]
[BUGFIX] Recycler: Reload table list on "reload"

Clicking "reload" now also reloads the table list.

Resolves: #65191
Releases: master
Change-Id: I9105aaf7598e6aef4ac4d1fa9a02410ef117e5c4
Reviewed-on: http://review.typo3.org/37040
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Johannes Kasberger <johannes.kasberger@v-i-p.tv>
Tested-by: Johannes Kasberger <johannes.kasberger@v-i-p.tv>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Add domain model validators only once 15/36915/2
Alexander Schnitzler [Sat, 14 Feb 2015 22:04:48 +0000 (23:04 +0100)]
[BUGFIX] Add domain model validators only once

If a domain model validator is present and a controller
action accepts this domain model as argument, the validator
is added twice to the validation tree.

It is added in
ValidatorResolver::buildMethodArgumentsValidatorConjunctions()
and in ValidatorResolver::addCustomValidators() which is called
from ValidatorResolver::getBaseValidatorConjunction()

Both methods are called when building the validation tree in
ActionController::initializeActionMethodValidators()

Resolves: #52607
Releases: master, 6.2
Change-Id: Ic1674bacfb027840d9b8fcd1d66586ebb0e75ad6
Reviewed-on: http://review.typo3.org/36915
Reviewed-by: Patrick Schriner <patrick.schriner@diemedialen.de>
Tested-by: Patrick Schriner <patrick.schriner@diemedialen.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Andy Grunwald <andygrunwald@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Streamline layout of "New file or folder wizard" 18/37018/5
Andreas Fernandez [Thu, 19 Feb 2015 11:52:29 +0000 (12:52 +0100)]
[TASK] Streamline layout of "New file or folder wizard"

Update the forms to the new layout used in the backend. Remove the
redundant "Cancel" buttons, as the same action is in the top bar
already.

Resolves: #65171
Releases: master
Change-Id: Ie056210ceefd01460c37b370c88e64ba5526354e
Reviewed-on: http://review.typo3.org/37018
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Install tool error message if session file not writeable 25/37025/3
Christian Kuhn [Thu, 19 Feb 2015 16:32:21 +0000 (17:32 +0100)]
[BUGFIX] Install tool error message if session file not writeable

In a rare case it may happen that the install tool created a session
file in typo3temp/InstallToolSessions and later those files can not
be written or updated due to permission problems.
The install tool then fails silently without error message.
Since write out of session data happens in __destruct() a proper
error message can not be created at this point anymore. Solution
is to "test write" the session file after opening it and throw
an exception if that fails.

Resolves: #65014
Releases: master, 6.2
Change-Id: I9478f0cfb58a047842d48350b7005e64f50f52ff
Reviewed-on: http://review.typo3.org/37025
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix static access to enumeration constants 94/36794/2
Mathias Brodala [Tue, 10 Feb 2015 14:27:59 +0000 (15:27 +0100)]
[BUGFIX] Fix static access to enumeration constants

Enumeration constants need to be loaded on static access
without requiring a instance before.

Resolves: #64971
Releases: master,6.2
Change-Id: Iaaefe5648ab70743cfc2efc73c81f870833b730d
Reviewed-on: http://review.typo3.org/36794
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Database integrity check: Display correct hover text 82/36982/4
Michael Oehlhof [Tue, 17 Feb 2015 22:39:18 +0000 (23:39 +0100)]
[BUGFIX] Database integrity check: Display correct hover text

In the overview of the database integrity check the title and alt tag
of the 4 icons were displayed with a non translated text.
Now the correct text is shown.

Resolves: #65135
Releases: master
Change-Id: Idd03fe024448c18ec207fc8ff4ad1250fb9e23e7
Reviewed-on: http://review.typo3.org/36982
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Introduce CSS based trees 07/36807/7
Andreas Fernandez [Tue, 10 Feb 2015 15:45:00 +0000 (16:45 +0100)]
[TASK] Introduce CSS based trees

A new CSS based tree is introduced. As first step, the
trees in the "New record" wizard are ported to use it.

Resolves: #65039
Releases: master
Change-Id: Ibd8c8d4120157e83f0a11ea1c2ce66fc1951cae1
Reviewed-on: http://review.typo3.org/36807
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Andy Grunwald <andygrunwald@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Correct placement of radio button in content element wizard 01/37001/3
Benjamin Kott [Wed, 18 Feb 2015 20:14:48 +0000 (21:14 +0100)]
[BUGFIX] Correct placement of radio button in content element wizard

Releases: master
Resolves: #65157
Change-Id: I6cf70773b1765e649d4e6f722bdec5e225dd735b
Reviewed-on: http://review.typo3.org/37001
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Properly size icons in translation overview 62/36962/4
Michael Oehlhof [Tue, 17 Feb 2015 00:49:19 +0000 (01:49 +0100)]
[BUGFIX] Properly size icons in translation overview

Limit size of extension icons and use styling of app icons.

Resolves: #65114
Releases: master
Change-Id: I95584bb5d9a328560fa97069b94c9aad73602047
Reviewed-on: http://review.typo3.org/36962
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Install tool fatal with options for cache_classes 99/36999/2
Christian Kuhn [Wed, 18 Feb 2015 18:17:58 +0000 (19:17 +0100)]
[BUGFIX] Install tool fatal with options for cache_classes

Setting an option like cacheDirectory for cache_classes or
cache_core triggers a fatal if calling the install tool.
This happens because the install tool calls the bootstrap
loadConfigurationAndInitialize() with $allowCaching = FALSE
which then calls disableCoreAndClassesCache() and sets the
backend of both caches to NullBackend. The cacheDirectory
option however is not supported by this backend.
Solution is to unset any options configured for these caches
within disableCoreAndClassesCache().

Resolves: #65153
Releases: master, 6.2
Change-Id: I3200d6752794c1769fe4e049c301ee8fa185ecf9
Reviewed-on: http://review.typo3.org/36999
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Center legacy extension icons 86/36986/3
Andreas Fernandez [Wed, 18 Feb 2015 08:43:55 +0000 (09:43 +0100)]
[BUGFIX] Center legacy extension icons

Add a horizontal margin to typo3-app-icon to ensure legacy extension
icons are centered.

Resolves: #65139
Releases: master
Change-Id: I4669237173194e6c265b2ca40c2736b3c73b12b3
Reviewed-on: http://review.typo3.org/36986
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Remove space between buttons in button-group 93/36993/2
Benjamin Kott [Wed, 18 Feb 2015 14:53:12 +0000 (15:53 +0100)]
[BUGFIX] Remove space between buttons in button-group

Hide the whitespace between buttons in button groups.

Releases: master
Resolves: #65110
Change-Id: I250fb1958d5056a9da0078fc6499f047d68aba1d
Reviewed-on: http://review.typo3.org/36993
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Harmonize new button in record list view 92/36992/2
Benjamin Kott [Wed, 18 Feb 2015 14:07:46 +0000 (15:07 +0100)]
[TASK] Harmonize new button in record list view

To keep focus on the list items the green styling from the
new element button was removed.

Added the missing btn-default class for clipboard actions in list view.

Releases: master
Resolves: #65147
Change-Id: I1b449c50d30e4a6cb90d251f200d4d75eff895d9
Reviewed-on: http://review.typo3.org/36992
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[FOLLOWUP][BUGFIX] Fix regression in GeneralUtility::rmFromList() 91/36991/2
Markus Klein [Wed, 18 Feb 2015 11:01:07 +0000 (12:01 +0100)]
[FOLLOWUP][BUGFIX] Fix regression in GeneralUtility::rmFromList()

Add missing text in phpdoc

Resolves: #65123
Releases: master
Change-Id: If5b41ace61d7279cc4e7a564274bded9a2cdc031
Reviewed-on: http://review.typo3.org/36991
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix regression in GeneralUtility::rmFromList() 67/36967/10
Markus Klein [Tue, 17 Feb 2015 12:55:20 +0000 (13:55 +0100)]
[BUGFIX] Fix regression in GeneralUtility::rmFromList()

Removing multiple occurrences of the same element now works again.

Resolves: #65123
Releases: master, 6.2
Change-Id: I3e973f019b68ebe19cee0e01f20b9e51e6a7ae28
Reviewed-on: http://review.typo3.org/36967
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Gregor Favre <gregor.favre@insor.ch>
Tested-by: Gregor Favre <gregor.favre@insor.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] RTE: Extract JavaScript from select image php controller 84/36984/3
Stanislas Rolland [Tue, 17 Feb 2015 21:45:20 +0000 (16:45 -0500)]
[TASK] RTE: Extract JavaScript from select image php controller

Releases: master
Resolves: #65133
Change-Id: I82c0592a9f0d2f24e37a3f3c0c21dfcda497f5eb
Reviewed-on: http://review.typo3.org/36984
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Don't trigger clearable on ENTER 64/36964/3
Andreas Fernandez [Tue, 17 Feb 2015 08:36:29 +0000 (09:36 +0100)]
[BUGFIX] Don't trigger clearable on ENTER

Add a type="button" to the clearable button to prevent trigger stealing
by pressing enter in it's input field.

Resolves: #65079
Releases: master
Change-Id: I5009f94839587c5918e23167a190e67cf4043f53
Reviewed-on: http://review.typo3.org/36964
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Prevent Javascript loop for RTE-enabled fields 60/36860/11
Stanislas Rolland [Sat, 14 Feb 2015 18:40:25 +0000 (13:40 -0500)]
[BUGFIX] Prevent Javascript loop for RTE-enabled fields

Problem: If a collapsed IRRE element with a RTE-enabled field is added,
a JavaScript loop is triggered because of missing widths of the select
fields within the RTE toolbar. This is caused by change in the way IRRE
nested inline elements are made visible using class attribute rather than
display property of style attribute. This also applies to new tab menus.
The change also affects the properties of the nested elements whose
mutations must be observe in order to detect when the RTE iframe becomes
visible.
Solution: Adjust the list of attributes to be observed on nested inline
elements. Adjust also detection of nested elements visibility state as
well as the walk to make them hidden with the visibility property of
the style attribute while the RTE framework is being rendered.

There is also a check added for TYPO3.settings.Textarea that is not
present when RTE fields are hidden by DisplayCond for a child element
that gets expanded/opened.

Releases: master
Resolves: #64930
Change-Id: I6f3bea4e9e72c33f2ae773734e9e6d794fe38ee9
Reviewed-on: http://review.typo3.org/36860
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Fix broken combobox styling 55/36955/2
Andreas Fernandez [Mon, 16 Feb 2015 19:28:34 +0000 (20:28 +0100)]
[BUGFIX] Fix broken combobox styling

Add a lightgrey background color to ExtJS comboboxes.

Resolves: #65101
Releases: master
Change-Id: I31e51b75d44794f09d6087e014816031db8c8ba1
Reviewed-on: http://review.typo3.org/36955
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Remove duplicate quotes from clickmenu "hide" 53/36953/2
Mathias Schreiber [Mon, 16 Feb 2015 17:27:46 +0000 (18:27 +0100)]
[BUGFIX] Remove duplicate quotes from clickmenu "hide"

Rebuilding the clickmenu resulted in a small typo with double quotes
leading to a JS error if clickmenu hide was clicked.

Resolves: #65098
Releases: master
Change-Id: I93c36542b2915eafb60eb6d9e7ea93214ffd2cfc
Reviewed-on: http://review.typo3.org/36953
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Initialize DateTimePicker on IRRE fields 44/36944/2
Andreas Fernandez [Mon, 16 Feb 2015 13:50:07 +0000 (14:50 +0100)]
[BUGFIX] Initialize DateTimePicker on IRRE fields

Reinitialize the DateTimePicker properly by calling the initialize()
method in the callback.

Resolves: #65092
Releases: master
Change-Id: I653dab6d476f6cf65d7739c05141fc73f7217027
Reviewed-on: http://review.typo3.org/36944
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] foreign_selector size > 1 create new relation link is not needed 96/36596/6
Andreas Allacher [Mon, 2 Feb 2015 07:16:26 +0000 (08:16 +0100)]
[BUGFIX] foreign_selector size > 1 create new relation link is not needed

if there are inline records with a foreign_selector that has a size > 1
there is no need for the create new relation link and it is only puzzling
to users.

Change-Id: Id2dba765e57cd9e724f7c4b88eb1199b7e7e9028
Resolves: #64728
Releases: master
Reviewed-on: http://review.typo3.org/36596
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>