Susanne Moog [Thu, 15 Feb 2018 15:23:58 +0000 (16:23 +0100)]
[BUGFIX] Remove side effects from ErrorController tests
Resolves: #83921
Releases: master
Change-Id: Icaa53e211ed2ca6ea9824a930960c2d9cee688ef
Reviewed-on: https://review.typo3.org/55737
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Christian Kuhn [Thu, 15 Feb 2018 01:56:34 +0000 (02:56 +0100)]
[BUGFIX] Notice free InlineStackProcessor testing
Change-Id: I77a4782f250a4b37051eb321fd5c6670b4366e24
Resolves: #83908
Releases: master
Reviewed-on: https://review.typo3.org/55726
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benni Mack [Mon, 12 Feb 2018 21:12:33 +0000 (22:12 +0100)]
[TASK] Separate Error handling from TSFE
The goal is to decouple error handling from TSFE.
For that, a new ErrorController is added which can be
called and returns a Response object instead of
exits the current request.
In order to keep full backwards-compatibility,
TSFE currently does not return a response, but
instead exists with a response object.
Next step:
- Move the pageUnavailable_force functionality into a middleware
- See what can be further abstracted to return a response
Resolves: #83883
Releases: master
Change-Id: I41f5f1a32a3f7edd48eb5c0464a26762ad4a946f
Reviewed-on: https://review.typo3.org/55690
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Christian Kuhn [Thu, 15 Feb 2018 03:55:37 +0000 (04:55 +0100)]
[TASK] Allow chaining in class ModuleTemplate
For slightly more dense code ModuleTemplate now
returns $this on setter methods to allow chaining.
Change-Id: Icd92d37370529a0535b4c2d5dcf2e588bd50a6ae
Resolves: #83910
Releases: master
Reviewed-on: https://review.typo3.org/55728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Fernandez [Wed, 14 Feb 2018 14:18:39 +0000 (15:18 +0100)]
[TASK] Let Bamboo check for clean TypeScript build
To avoid having stale TypeScript builds, Bamboo now recompiles every
TypeScript via grunt and checks for unwanted modifications.
Change-Id: I1d96bb81eff4d5c42332d0a27cce0a98a7d27478
Resolves: #83914
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Gianluigi Martino [Wed, 14 Feb 2018 15:14:49 +0000 (16:14 +0100)]
[TASK] Hide "Group by page" if only one page is shown in EXT:belog
It is unnecessary to show the "Group by page" checkbox if "This page" is
selected in the "Depth" dropdown.
Thus, the checkbox is hidden in that case.
Resolves: #83896
Releases: master, 8.7
Change-Id: Idd3e0252c6bb06d2442ed4db95056e1e6d292c6c
Reviewed-on: https://review.typo3.org/55718
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Frank Naegler [Wed, 14 Feb 2018 12:10:00 +0000 (13:10 +0100)]
[BUGFIX] Show duplicate button only if it makes sense
Resolves: #83892
Related: #77685
Releases: master
Change-Id: I16a7d57efa7d75e712bba24724d4da365b0aa40a
Reviewed-on: https://review.typo3.org/55713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Georg Ringer [Wed, 14 Feb 2018 16:11:55 +0000 (17:11 +0100)]
[TASK] Move check if workspaces extension is loaded to the controller
Instead of using a ViewHelper the logic can be moved to the controller
where it belongs.
As the ViewHelper is not a public API it can be dropped without a
RST file.
Resolves: #83900
Releases: master
Change-Id: I8d089761b8a168f00cb0739742fa658d40687379
Reviewed-on: https://review.typo3.org/55719
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benni Mack [Wed, 14 Feb 2018 13:04:54 +0000 (14:04 +0100)]
[TASK] Set about module free from Extbase
The whole Extbase stack for the about module
is not necessary, as there is only one action
in this controller, and it's a simple Fluid
action.
The module name is kept as "help_AboutAbout"
due to the uncool naming handling of Extbase magic.
Resolves: #83899
Releases: master
Change-Id: I6353c30528d619f849ea77774b16ff0eb499e820
Reviewed-on: https://review.typo3.org/55714
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Wed, 14 Feb 2018 13:08:02 +0000 (14:08 +0100)]
[TASK] Update typo3/cms-styleguide
composer update typo3/cms-styleguide
Version 9.0.2 brings examples of the new checkbox renderTypes
and a fal example using allowLanguageSynchronization
Change-Id: Ia5e8f6627a15a1db9aa20f9a7c9be39a375fc401
Resolves: #83893
Releases: master
Reviewed-on: https://review.typo3.org/55715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benni Mack [Wed, 7 Feb 2018 21:53:45 +0000 (22:53 +0100)]
[TASK] Show ordered PSR-15 middlewares in Configuration module
In order to find out what middlewares are called in which order,
the Configuration module now has an additional list of all
registered middlewares for "frontend" and "backend" stack.
Resolves: #83882
Releases: master
Change-Id: I99d8478bb07437efa65d292221ccdb03d5dd3161
Reviewed-on: https://review.typo3.org/55597
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Sun, 11 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[FEATURE] Add normalized server parameters to PSR-7 requests
To slowly substitute GeneralUtility::getIndpEnv() with a
better API, a new class is introduced that calculates all
normalized server parameters.
The object is added as PSR-7 request attribute in a frontend
and backend middleware.
For a transition phase, the request is made available
as $GLOBALS['TYPO3_REQUEST'] until enough core code has
been refactored to get rid of this again.
Resolves: #83736
Releases: master
Change-Id: I96c8cb6dda4cc38bbb51b64439b8e81f2c00d7ac
Reviewed-on: https://review.typo3.org/55506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benni Mack [Tue, 13 Feb 2018 23:34:26 +0000 (00:34 +0100)]
[TASK] Remove overkill extension classes in about module
When the about module (EXT:about) was refactored into
Extbase, a Repository and Domain Model for Extensions was
added to render title, key and authors of an extension.
For modules this was done directly in the controller,
which is 100% sufficient in this one-time case, instead
of doing it the Extbase(tm) persistence way.
This way, all data is fetched the same way in the about module.
The two domain model / repository classes are removed,
and due to the fact that they are not part of the API,
a RST file is not added.
Resolves: #83890
Releases: master
Change-Id: I1169336452d7497ea0ed2e1a99553c164ec78612
Reviewed-on: https://review.typo3.org/55710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Wolfgang Klinger [Tue, 9 Jan 2018 19:17:56 +0000 (20:17 +0100)]
[FEATURE] Add possibility to use session data in TS conditions
Since the session API has been adjusted it is no longer possible
to access the (now protected) sesData property of the fe_user object.
Using TSFE:fe_user|sesData|foo|bar in a TS condition will trigger
a deprecation log entry.
Instead a cleaner approach is now available:
[globalVar = session:foo|bar =
1234567]
Resolves: #83506
Releases: master
Change-Id: Idbb079334186eac1dfe062a71a601e556a9bd247
Reviewed-on: https://review.typo3.org/55310
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Christian Kuhn [Tue, 13 Feb 2018 14:32:21 +0000 (15:32 +0100)]
[!!!][TASK] Handle E_NOTICE free unit tests
Raise typo3/testing-framework from 2.0.4 to 3.0.0:
composer require --dev typo3/testing-framework ^3.0
The new typo3/testing-framework version comes with a change
that no longer suppresses E_NOTICE PHP errors by default and lets
tests fail that raise them.
The static property $suppressNotices in unit test files is set to
true for all test cases that currently raise E_NOTICE errors to
suppress them on a by-file basis.
Further patches should remove this property one-by-one again by
fixing the system under test the unit test case handles.
Change-Id: I7d44fe3723ce5820a37051ae31f16b2f142ffba6
Resolves: #83889
Related: #83888
Releases: master
Reviewed-on: https://review.typo3.org/55697
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Benni Mack [Tue, 13 Feb 2018 21:51:19 +0000 (22:51 +0100)]
[BUGFIX] Cleanup Spool Mailer feature
The default file path is not set, so the admin has to set this
to a sensible default outside the web folder when he/she wants
to use it.
Additionally, some CGL fixes and cleanups are applied.
Resolves: #83880
Related: #76349
Releases: master
Change-Id: Ibb3ce564cdfeb474f963c5900fc4bb21e4b7d1a4
Reviewed-on: https://review.typo3.org/55707
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Christian Kuhn [Tue, 13 Feb 2018 21:57:59 +0000 (22:57 +0100)]
[TASK] Update typo3/testing-framework
Raise from 2.0.3 to 2.0.4 in master and
from 1.2.2 to 1.2.3 in v8. Brings a patch
to hopefully stabilize acceptance tests again.
composer command used:
composer update typo3/testing-framework
Change-Id: I87d5a65b52bca6eceae805c5edbb13c7eccd1010
Resolves: #83887
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Fernandez [Tue, 13 Feb 2018 21:46:26 +0000 (22:46 +0100)]
[BUGFIX] Remove console.log() from compiled InfoWindow.js
Resolves: #83886
Related: #83844
Releases: master
Change-Id: I2eca96de481c9b3d4a660f7cfded99099ea87743
Reviewed-on: https://review.typo3.org/55706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Thorben Nissen [Thu, 27 Apr 2017 08:13:03 +0000 (10:13 +0200)]
[BUGFIX] Handle settings for report / check in linkvalidator
The level and link type checkmark options are now handled seperately
for the "Report" and "Check Links" tab. This way, the options can
be changed independantly on each tab.
Resolves: #81035
Releases: master, 8.7
Change-Id: I772f885940791a17269c413185d3bea46695ff19
Reviewed-on: https://review.typo3.org/52628
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Richard Haeser [Mon, 18 Apr 2016 15:11:23 +0000 (17:11 +0200)]
[FEATURE] Add interlace option for image conversion
When the option $GLOBALS['TYPO3_CONF_VARS'][GFX][processor_interlace]
is set, all images will be generated with the given interlace scheme.
Resolves: #48013
Releases: master
Change-Id: I9b78f8f27dd5223ac8e96ff33d1c26b5d1d6e1c9
Reviewed-on: https://review.typo3.org/47753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Stephan Großberndt [Sat, 16 Dec 2017 12:41:21 +0000 (13:41 +0100)]
[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView
Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.
Resolves: #83354
Releases: master, 8.7
Change-Id: I71c463e1a2912aa20535c7a1bbc0c690560f7e63
Reviewed-on: https://review.typo3.org/55111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Christian Kuhn [Tue, 13 Feb 2018 12:02:33 +0000 (13:02 +0100)]
[TASK] Remove two unused settings from LocalConfiguration
The two (internal) settings 'SYS/isInitialInstallationInProgress' and
'SYS/isInitialDatabaseImportDone' have been obsoleted with
the install tool rewrite in v9 and can be removed from
LocalConfiguration using the SilentConfigurationUpgradeService.
Change-Id: I6c80506f2389004093f43ff9fc3df49b002e1438
Resolves: #83878
Releases: master
Reviewed-on: https://review.typo3.org/55696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Willi Wehmeier [Sat, 3 Jun 2017 18:35:05 +0000 (20:35 +0200)]
[FEATURE] Add duplicate button
This patch provides a new "duplicate" button inside of the topbar of the
edit record form next to the close button. This button creates and opens
a new copy of the current element which is positioned right below the
existing one.
If there are unsaved changes in the currently open record, a modal
appears with options to cancel, dismiss the changes and clone or save
the changes and clone the changed record.
Resolves: #77685
Releases: master
Change-Id: I9e2a0f02fc9c4452f0a7d868ea17aeacb9375d95
Reviewed-on: https://review.typo3.org/53101
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Wolfgang Klinger [Tue, 13 Feb 2018 07:12:54 +0000 (08:12 +0100)]
[BUGFIX] Add missing space in regular expression
DataHandler::clearPrefixFromValue is missing a space
in the regular expression when removing the prependAtCopy
label. That leads to wrong headers in copied elements.
Releases: master
Resolves: #83870
Change-Id: I49cde9a9a20686715d9b042173f89bfeb2bd112f
Reviewed-on: https://review.typo3.org/55694
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Benjamin Franzke [Mon, 12 Feb 2018 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Fix backend user check in ProductionExceptionHandler
Uncaught Error: Call to a member function isBackendUserLoggedIn() on null
in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103
Change-Id: I0052c2c1cd617282dbc65320933f8577038ab41c
Releases: master, 8.7
Resolves: #83867
Reviewed-on: https://review.typo3.org/55688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tymoteusz Motylewski [Mon, 12 Feb 2018 21:02:44 +0000 (22:02 +0100)]
[BUGFIX] Show ImageMagick command on failure
Install tool now shows an ImageMagick command which
failed.
Resolves: #83868
Releases: master
Change-Id: I4555d2ccdf68eea9180b8c7d2671b11e9b637709
Reviewed-on: https://review.typo3.org/55689
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benjamin Franzke [Thu, 8 Feb 2018 23:40:18 +0000 (00:40 +0100)]
[TASK] Directly wire Application and RequestHandler
The frontend and backend Application and RequestHandler classes
are tightly coupled since the frontend eID request handler was
moved into a middleware and the backend ajax request handler
was merged with the regular request handler. (1:1 relationship)
There is no (longer) need to resolve the request handler in
Bootstap. For the install application we are still using two
request handlers but will dispatch them from within the
application now.
That means the call chain is now:
Application -> RequestHandler
instead of:
Application -> Bootstrap -> RequestHandler
That allows us to deprecate all HTTP related code in Bootstrap (with
a separate commit) and instead implement that in an HTTP specific
ApplicationTrait.
This patch introduces a legacy RequestHandler dispatcher middleware
which ensures that registering custom request handlers using
Bootstrap::registerAdditionalRequestHandler() still works for the
frontend and backend.
(although it is marked @internal, there is interest to not just
drop this)
Change-Id: Id80158bb3d078719f6508ae950b2f32f018e1ac4
Releases: master
Resolves: #83864
Reviewed-on: https://review.typo3.org/55642
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Benni Mack [Mon, 12 Feb 2018 08:49:07 +0000 (09:49 +0100)]
[TASK] Use Logging API for scheduler logging
The custom logging of the scheduler pollutes the sys_log table
by default in all installations.
Switching to proper logging API allows to log to more custom processors.
Resolves: #83866
Releases: master
Change-Id: I2bd0a13cf55f70f8accc6a799099f713c648aac2
Reviewed-on: https://review.typo3.org/55670
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
René Bigler [Mon, 13 Mar 2017 15:13:18 +0000 (16:13 +0100)]
[FEATURE] Add signal slot for user switch
Resolves: #80263
Releases: master
Change-Id: Ida7b06961c2e9e813a03586fc6c8f26b3bcde3d8
Reviewed-on: https://review.typo3.org/52032
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Frank Naegler [Mon, 12 Feb 2018 18:08:11 +0000 (19:08 +0100)]
[BUGFIX] Catch __PHP_Incomplete_Class classes
Resolves: #66587
Releases: master, 8.7
Change-Id: I444c818e9f81d3595ca68513800c85d9f993f9b4
Reviewed-on: https://review.typo3.org/55685
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Claus Due [Sat, 3 Jun 2017 12:10:26 +0000 (14:10 +0200)]
[TASK] Deprecate StringFrontend cache frontend
Can be drop-in replaced by VariableFrontend. There are no
occurrences in core code except for in tests and comments.
Configurations using this frontend can be automatically
migrated on-the-fly. Such auto-migration is not part of this
patch - this patch only touches the PHPDOC and documents
the deprecation.
Change-Id: I3b4b4979534857fa30b56d9967e8f919fc046ab9
Resolves: #81434
References: #81432
Releases: master
Reviewed-on: https://review.typo3.org/53084
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Michael Oehlhof [Sun, 17 Dec 2017 23:34:48 +0000 (00:34 +0100)]
[BUGFIX] Updated class name in scheduler docs
Resolves: #66587
Releases: master, 8.7
Change-Id: If5fbb4df430aeb08122cc0713167a8cc464e6d55
Reviewed-on: https://review.typo3.org/55142
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Łukasz Uznański [Thu, 30 Nov 2017 10:23:25 +0000 (11:23 +0100)]
[BUGFIX] Show hidden translated record only once in clipboard
Right now, when user in workspace move element with translation
to the clipboard, translation is rendered twice in clipboard.
This bugfix prevents this behaviour.
Resolves: #82804
Releases: master, 8.7
Change-Id: I21a38800d2d5474650f8220340621841cb33f852
Reviewed-on: https://review.typo3.org/54883
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Benjamin Franzke [Mon, 12 Feb 2018 08:27:51 +0000 (09:27 +0100)]
[BUGFIX] Convert eID null return values to a NullResponse
An eID script (like FileDumpController) might return null.
We need to convert that to a NullResponse in order to be
propagatable back through the middleware stack.
Change-Id: I75dde1a019a9925fd70ab36bd2dddc6efb110d4c
Releases: master
Resolves: #83854
Reviewed-on: https://review.typo3.org/55671
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
guppy42 [Mon, 12 Feb 2018 14:50:01 +0000 (15:50 +0100)]
[TASK] Fix escaping in documentation of EXT:scheduler
Releases: master
Resolves: #83862
Change-Id: Iba543f6511949b9b4bebd73d65cedd77c4c4a5f2
Reviewed-on: https://review.typo3.org/55682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Ralf Zimmermann [Mon, 29 Jan 2018 13:56:45 +0000 (14:56 +0100)]
[TASK] Use native array_replace_recursive implementation
The custom implementation of array_replace_recursive in YamlSource
has been replaced with the native PHP version of the same method.
Resolves: #83860
Releases: master, 8.7
Change-Id: Ibc0c9ea55e7a510b84c39689890f51bfa01ebafa
Reviewed-on: https://review.typo3.org/55672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Sybille Peters [Sun, 11 Feb 2018 18:10:10 +0000 (19:10 +0100)]
[BUGFIX] Handle Guzzle exceptions in linkvalidator
* The Guzzle exceptions are handled in order to produce better,
localized error messages in the Report
* Add a new language key for "Network error"
Resolves: #83611
Releases: master, 8.7
Change-Id: I6480c349cbc3325315f25187df56a4914922e463
Reviewed-on: https://review.typo3.org/55666
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Fernandez [Sun, 11 Feb 2018 18:49:08 +0000 (19:49 +0100)]
[BUGFIX] Use `file.identifier` in search result of filelist
The search results of the filelist access the property
`file.combinedIdentifier`. The property is not available anymore, so this
patch uses `file.identifier`, which maps to `FileFacade::identifier()`
and returns a handcrafted combined identifier.
Resolves: #83849
Releases: master, 8.7
Change-Id: I98bcd9e40c9fdebddf1079ad0240a1d3f6ac8d6e
Reviewed-on: https://review.typo3.org/55667
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Stefan Froemken [Wed, 31 Jan 2018 16:42:09 +0000 (17:42 +0100)]
[!!!][BUGFIX] Reorder processing of TCA select items
It's now possible again to add and remove items via
pageTSconfig after itemsProcFunc has been processed
for TCA select fields.
Resolves: #75834
Releases: master
Change-Id: I6535f73c951a03abf3548c84877a08c4ea1ee2fa
Reviewed-on: https://review.typo3.org/55513
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Susanne Moog [Mon, 12 Feb 2018 11:17:50 +0000 (12:17 +0100)]
[TASK] Skip test for Yaml PHP extension if not loaded
Resolves: #83861
Releases: master, 8.7
Change-Id: I235e5e37405b264ce071c8d6ecb2b0c13f64357c
Reviewed-on: https://review.typo3.org/55673
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Manuel Selbach [Thu, 8 Feb 2018 17:51:43 +0000 (18:51 +0100)]
[BUGFIX] Make it possible to translate selectMultipleSideBySide
For the default language it was possible to view the field, but on
translating the dataset, the following exception is thrown:
'PHP Warning: Invalid argument supplied for foreach() in
backend/Classes/Form/Element/SelectMultipleSideBySideElement.php line 66'
As the defaultLanguageRow keeps to be "unparsed", the $selectedItems
could be a comma separated string within the method
TYPO3\CMS\Backend\Form\Element\SelectMultipleSideBySideElement::renderReadOnly
if the TCA configuration of a field is set to 'defaultAsReadonly'.
Resolves: #77155
Releases: master, 8.7, 7.6
Change-Id: Id9380fe3761e683352166565ed1a7e56f5e64190
Reviewed-on: https://review.typo3.org/55607
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benjamin Kott [Sat, 10 Feb 2018 22:04:53 +0000 (23:04 +0100)]
[TASK] Move info popups to modal windows
Resolves: #83844
Releases: master
Change-Id: I5fef80a48d52da9800a7a9a2a23445d60168e8b5
Reviewed-on: https://review.typo3.org/55659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Benni Mack [Sat, 10 Feb 2018 23:35:03 +0000 (00:35 +0100)]
[TASK] Unify Backend Request Handlers
Due to the middleware PSR-15 concept, the AjaxRequestHandler can
be migrated easily into the generic Backend RequestHandler.
Thus, the AjaxRequestHandler is marked as deprecated.
Resolves: #83853
Releases: master
Change-Id: If7823e2bc30bdea5839a0f07e943971eeeec00c3
Reviewed-on: https://review.typo3.org/55662
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Stefan Neufeind [Sun, 11 Feb 2018 23:30:29 +0000 (00:30 +0100)]
[TASK] Update php-cs-fixer to v2.10.2
Adjusts comment-indentions for else/elseif.
Commands used:
* composer update friendsofphp/php-cs-fixer --with-dependencies
* Build/Scripts/cglFixMyCommit.sh (modified to run on all php-files)
Resolves: #83851
Releases: master
Change-Id: I0390b3fd612ea2c495696faf9364418a078cd586
Reviewed-on: https://review.typo3.org/55669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benni Mack [Fri, 9 Feb 2018 13:06:14 +0000 (14:06 +0100)]
[TASK] FE: Move Content-Length header to middleware
Resolves: #83828
Releases: master
Change-Id: Id5f85a5ae38260cc1a1bf730b365a9b1c425bc7e
Reviewed-on: https://review.typo3.org/55627
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Andreas Fernandez [Fri, 9 Feb 2018 21:18:21 +0000 (22:18 +0100)]
[BUGFIX] Set default values in TCA of sys_file_collection
Resolves: #83838
Releases: master, 8.7
Change-Id: I3f27f3e610fd4eae7ac37349a0cf4ff03faa1189
Reviewed-on: https://review.typo3.org/55638
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Esteban Marín [Wed, 30 Nov 2016 14:57:05 +0000 (15:57 +0100)]
[BUGFIX] HTML5: use self-closing tags only if allowed
For HTML5 only certain HTML tags are allowed to be self-closing
(e.g. <img src="..." />), so this needs to be checked when
parsing HTML.
Resolves: #78844
Releases: master, 8.7
Change-Id: If2a319fa83a4baf7d78559aa23ce34903d42d342
Reviewed-on: https://review.typo3.org/50812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Gianluigi Martino [Fri, 20 Oct 2017 08:08:20 +0000 (10:08 +0200)]
[TASK] Popup file id on the right side of "File selector"
With this patch on the right side of the "File selector" window a popup
with the file id is showing hovering the file icon. The file size was
moved to the popup hovering the title.
Resolves: #82831
Releases: master
Change-Id: I28c256e1d445d5c3291d1ef8ab67946e2e637794
Reviewed-on: https://review.typo3.org/54452
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Raphael Graf [Sun, 8 Oct 2017 18:17:09 +0000 (20:17 +0200)]
[FEATURE] Add readonly and required attributes to TextareaViewHelper
The f:form.textarea view helper now supports the HTML attributes
`readonly` and `required`.
Resolves: #82704
Releases: master
Change-Id: I890f8551fb5eccd30dedd2ad8185aa9e9a24c86e
Reviewed-on: https://review.typo3.org/54328
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Stephan Großberndt [Sat, 16 Dec 2017 13:03:13 +0000 (14:03 +0100)]
[BUGFIX] Fix quoting and cleanup in AdminPanelView
In EXT:frontend/Classes/View/AdminPanelView.php add missing
htmlspecialchars() calls, remove unnecessary ones, add quoteJSvalues()
and do cleanup.
Resolves: #83357
Releases: master, 8.7
Change-Id: Ib546bcfaebf5342e187f8b707a9091947a97ca72
Reviewed-on: https://review.typo3.org/55116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Remo H [Sun, 24 Jul 2016 18:23:36 +0000 (20:23 +0200)]
[FEATURE] Integrate Swift Mailer's spool transport
Adds new configuration to the install tool and provides an
extbase schedular task and command.
A small refactoring was required:
* Moved transport creation from mailer to a factory
Possible issues are:
* sending of memory-spooled messages is a bit hacky
Resolves: #76349
Releases: master
Change-Id: I9736d4f943eea2052bf935ac1fc055c336894397
Reviewed-on: https://review.typo3.org/49182
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Stefan Neufeind [Tue, 18 Oct 2016 13:25:03 +0000 (15:25 +0200)]
[FEATURE] Allow setting a default replyTo-email-address
If no other email-address is set as reply-to use this address
as default. This is similar to the existing defaultMailFromAddress.
Change-Id: Iabdf282203c1989036867a6c97b9cbe329e61f60
Resolves: #78332
Releases: master
Reviewed-on: https://review.typo3.org/50263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Andreas Fernandez [Fri, 9 Feb 2018 22:53:06 +0000 (23:53 +0100)]
[TASK] Apply uglify to TypeScript builds
The Grunt task `copy:ts_files` now modifies the uglify configuration
on-the-fly to minify the files compiled by TypeScript.
Resolves: #83251
Releases: master
Change-Id: I11faf7ae39f2605b4e8a8a6972f4f16c4b80138f
Reviewed-on: https://review.typo3.org/55639
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Anja Leichsenring [Fri, 9 Feb 2018 19:45:39 +0000 (20:45 +0100)]
[TASK] Fix flaky Acceptance Tests
The current default timeout to wait for elements is 10 seconds.
Turn up to 30 sec to stabilize the situation.
Change-Id: I2dd6cbe14a7d05cfe3cf6f7ad3437e0b235c96f1
Resolves: #83836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Mathias Brodala [Fri, 22 Dec 2017 16:48:54 +0000 (17:48 +0100)]
[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge
Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.
Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55203
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benjamin Franzke [Sat, 10 Feb 2018 12:26:50 +0000 (13:26 +0100)]
[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome
When used with the Chrome browser, the RTE CKEditor misplaces the
position of its dropdowns/context menus (opened via right-click)
when the viewport is scrolled. CKEditor calculates the offset relative
to the <body> and assumes <body> is as long as the content and that
the scrollbar is placed on <html> (both browser defaults).
As the TYPO3 backend uses 'overflow:auto' on <body> and 'overflow: hidden'
on <html> these assumptions conflict: Once the calculated offset exceeds
the <body> height (due tue scrolling) the chrome browser scrols up.
We now move the vertical scollbar into .module-body which implicitly
fixes the CKEditor offset calculation: The calculated menu offsets are
now relative to <body> (as assumed by CKEditor) and the scroll issues
disappear as we removed the scroll bar from <body>.
Resolves: #80116
Resolves: #82780
Releases: master, 8.7
Change-Id: I0481d4aaac1068577c9bad39e607486533ad4b6c
Reviewed-on: https://review.typo3.org/55647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Andreas Fernandez [Sat, 10 Feb 2018 19:32:32 +0000 (20:32 +0100)]
[BUGFIX] Check if UC of recycler was ever set
Resolves: #83839
Releases: master
Change-Id: I1e72f959a7ec91c3834fc04ddf175c5c8cb441f2
Reviewed-on: https://review.typo3.org/55656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Andreas Fernandez [Fri, 9 Feb 2018 23:36:15 +0000 (00:36 +0100)]
[TASK] Update UC in recycler only once per action
The UC of a backend user is now updated only once per request, if there
are actual changes.
Resolves: #83839
Releases: master, 8.7
Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad
Reviewed-on: https://review.typo3.org/55641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Benjamin Kott [Sat, 10 Feb 2018 15:49:31 +0000 (16:49 +0100)]
[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers
Browsers on iOS are ignoring the width property for iframes,
this resulted in iframes beeing rendered too wide and prevented
scrolling on the horizontal axis.
Resolves: #83841
Releases: master, 8.7
Change-Id: I825d6f911959fdb588f1f164f0ec4bbbf5c067c0
Reviewed-on: https://review.typo3.org/55649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Mathias Schreiber [Sat, 10 Feb 2018 11:01:52 +0000 (12:01 +0100)]
[BUGFIX] Fix false icons widths in FormEngine IconSelect
The width of Icons in TCA selects adjusted in https://review.typo3.org/c/55568/
has been corrected to have Icons use their proper width (128px) again.
Resolves: #83840
Releases: master, 8.7
Change-Id: Ia1e6dee77012b772c3fd5cae7199b075c66389d7
Reviewed-on: https://review.typo3.org/55645
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Georg Ringer [Tue, 6 Feb 2018 02:42:36 +0000 (03:42 +0100)]
[BUGFIX] Show active state for SelectIcons
Highlight the selected icon. This useful feature has been
removed with the FormEngine rewrite.
Resolves: #83781
Releases: master, 8.7
Change-Id: I06376b073585d39d14de6f40bd02172168425944
Reviewed-on: https://review.typo3.org/55568
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Michael Oehlhof [Sun, 28 Jan 2018 16:26:30 +0000 (17:26 +0100)]
[BUGFIX] EXT:filelist Fixed exception when the base path does not exists
Resolves: #79785
Releases: master, 8.7
Change-Id: I50cf03273747b1fa32a1f8e4aac993a3fbc7b7f0
Reviewed-on: https://review.typo3.org/55476
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reiner Teubner [Fri, 9 Feb 2018 13:30:43 +0000 (14:30 +0100)]
[BUGFIX] Fix typo in field description SYS:ddmmyy
'Date' should be 'Day'.
Resolves: #83829
Related: master, 8.7
Change-Id: If422279d147598b02e342a00f3ebcbb3d3f26723
Reviewed-on: https://review.typo3.org/55630
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Michael Schams [Mon, 5 Feb 2018 10:04:46 +0000 (21:04 +1100)]
[BUGFIX] Do not check HTTP referrer anymore
Under certain circumstances some browsers do not set the HTTP referrer
anymore due to privacy reasons. Hence, checking the referrer breaks
functionality.
The configuration option [SYS][doNotCheckReferer] is also removed as
it is not needed anymore.
Resolves: #83768
Releases: master, 8.7, 7.6
Change-Id: Ia8f882e07a9e2091ceb38aee814badb97403250d
Reviewed-on: https://review.typo3.org/55556
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Benjamin Kott [Fri, 9 Feb 2018 13:17:48 +0000 (14:17 +0100)]
[BUGFIX] Cast values always to string before applying through ini_set
Resolves: #83826
Releases: master
Change-Id: I55d7141ffb26126215be029547e143ed2f777707
Reviewed-on: https://review.typo3.org/55629
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Benjamin Franzke [Fri, 9 Feb 2018 14:19:10 +0000 (15:19 +0100)]
[TASK] Make extension scanner aware of the deprecated EidRequestHandler
Change-Id: I2a664d445ba501a79a13aa634a8e943ef1726cf0
Releases: master
Resolves: #83831
Related: #83511
Related: #83803
Reviewed-on: https://review.typo3.org/55631
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Pat [Fri, 9 Feb 2018 12:33:44 +0000 (13:33 +0100)]
[BUGFIX] Add missing character in upgrade wizard SectionFrameToFrameClassUpdate
Resolves: #83827
Releases: master
Change-Id: Id1d3c7ab540949d8c83bffbd921f57c6b13da879
Reviewed-on: https://review.typo3.org/55628
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Christian Kuhn [Thu, 8 Feb 2018 23:11:35 +0000 (00:11 +0100)]
[BUGFIX] Use MissingArrayPathException in InheritancesResolverService
With change for issue #83238 the specific exception
MissingArrayPathException has been accidently changed
back to a generic \RuntimeException, fix this again.
Change-Id: I60f189c48a21bc7a6e648f4e811f4ae312ccc9ef
Releases: master
Resolves: #83815
Related: #83238
Related: #83615
Reviewed-on: https://review.typo3.org/55624
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tomita Militaru [Wed, 11 May 2016 21:33:29 +0000 (23:33 +0200)]
[FEATURE] Add constraint hook in DatabaseRecordList->makeSearchString
A newly introduced hook in DatabaseRecordList->makeSearchString allows to
modify the constraints which are applied to the search string.
Resolves: #71911
Releases: master
Change-Id: I7513ce9c17a9dfef76caa4e78a61f8efed21d540
Reviewed-on: https://review.typo3.org/48090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
rschueppel [Wed, 6 Dec 2017 16:44:00 +0000 (17:44 +0100)]
[TASK] Resolve Todos in InheritancesResolverService
Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.
Resolves: #83238
Releases: master, 8.7
Change-Id: I3aed06a76b609ef78641530a19e3379f202c84ec
Reviewed-on: https://review.typo3.org/54948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Mathias Schreiber [Thu, 8 Feb 2018 19:27:18 +0000 (20:27 +0100)]
[BUGFIX] Align Storage “is_public” checkbox with checkbox styles
The markup generated by the UserStorageCapabilityService is now
in line with the overall styling of checkboxes in TCA.
Resolves: #83810
Releases: master
Change-Id: I59bb480587bf30e054b855370e33e3d2dbfdfa91
Reviewed-on: https://review.typo3.org/55615
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benjamin Franzke [Tue, 6 Feb 2018 22:34:20 +0000 (23:34 +0100)]
[TASK] Use PSR-7 Response objects for external URL redirects
Instead of immediately exiting, allow to post-process the response
through the middleware chain.
Change-Id: Icfb47f7cd84c80201a3c3b9927267e8b8aaef440
Releases: master
Resolves: #83794
Reviewed-on: https://review.typo3.org/55586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benni Mack [Sat, 3 Feb 2018 21:08:49 +0000 (22:08 +0100)]
[TASK] Move BE-related bootstrap code to PSR-15 middleware
Various functionality used by both backend request handlers is moved
into PSR-15 compatible middleware, making the following Bootstrap
methods obsolete:
- checkLockedBackendAndRedirectOrDie()
- checkBackendIpOrDie()
- checkSslBackendAndRedirectIfNeeded()
- initializeBackendTemplate()
- initializeOutputCompression()
- sendHttpHeaders()
The following methods are still needed in other contexts however
- initializeBackendRouter()
- loadExtTables()
- endOutputBufferingAndCleanPreviousOutput()
- initializeBackendAuthentication()
- initializeBackendUser()
- initializeLanguageObject()
Resolves: #83792
Releases: master
Change-Id: I6772bbb73f17100dfc5116f58f1202f52fee1e8d
Reviewed-on: https://review.typo3.org/55538
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Wouter Wolters [Thu, 8 Feb 2018 20:08:26 +0000 (21:08 +0100)]
[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting
The bootstrap throws an exception when the setting SYS/displayErrors
is not set to "-1", "0" or "1". In the Install Tool TYPO3 should not crash.
Instead allow to silently migrate the value to -1
Resolves: #82782
Resolves: #83787
Releases: master,8.7
Change-Id: Ie0180b34a551a81667bb4ac32c6ab2699d9b3d4f
Reviewed-on: https://review.typo3.org/55619
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Alexander Opitz [Fri, 12 Jan 2018 16:08:07 +0000 (17:08 +0100)]
[BUGFIX] Allow workspace preview inside another rootline
The rootline for page view now depends on the webmounts of the workspace
the preview link was generated on and not the webmounts the beuser, who
generated the preview link, is at the moment of calling the preview
link.
Resolves: #83547
Releases: master, 8.7
Change-Id: I53c8d45260b79c4d5679f00084fe81b502668ee7
Reviewed-on: https://review.typo3.org/55341
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Frank Naegler [Thu, 8 Feb 2018 14:32:29 +0000 (15:32 +0100)]
[TASK] Deprecate page.javascriptLibs.*
The settings page.javascriptLibs and page.javascriptLibs.jQuery
have been marked as deprecated and will be removed in CMS 10.
Resolves: #83806
Releases: master
Change-Id: I72d20919a30c724716a6c75ba409679f0671c68c
Reviewed-on: https://review.typo3.org/55605
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Frank Naegler [Thu, 8 Feb 2018 15:02:23 +0000 (16:02 +0100)]
[BUGFIX] Remove usage of fluid legacy classes
With https://review.typo3.org/#/c/54068/ a lot of fluid classes
were changed and replaced by fluid standalone classes.
Some ViewHelpers still use the legacy classes.
This patch switches all usages to the fluid standlone classes.
Resolves: #83811
Releases: master
Change-Id: If0ee1b694c573d0c8c1a4ea0d9f873997511127e
Reviewed-on: https://review.typo3.org/55606
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Gianluigi Martino [Fri, 22 Dec 2017 13:44:30 +0000 (14:44 +0100)]
[TASK] Improve file overwriting dialog of the filelist module
- Remove grey background box
- Move buttons on the same row
- Better position for alternatively actions
- Some margins for better positions
Resolves: #82838
Releases: master, 8.7
Change-Id: I2fc1323d8c9acdfbb2b99b3af36e10bd5ea8a7f6
Reviewed-on: https://review.typo3.org/55199
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tymoteusz Motylewski [Wed, 7 Feb 2018 11:02:22 +0000 (12:02 +0100)]
[BUGFIX] Respect TSconfig option showHistory
The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.
Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.
Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/51090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Mathias Brodala [Fri, 14 Oct 2016 08:29:27 +0000 (10:29 +0200)]
[BUGFIX] Fix unset bits in options.alertPopup bitmask
The validation in JsConfirmation did not allow for a value
based on JsConfirmation:ALL with some bits unset.
Change-Id: I74d43d59ee3cd06498bbebd6b7b7682ca1d79cd5
Resolves: #78240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/50223
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Benjamin Franzke [Wed, 7 Feb 2018 19:57:30 +0000 (20:57 +0100)]
[TASK] Rewrite eID handling as PSR-15 middleware
Releases: master
Resolves: #83803
Change-Id: Id704c5235e5e844d8e42482dd55948e0ad4a2162
Reviewed-on: https://review.typo3.org/55596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Anja Leichsenring [Wed, 7 Feb 2018 20:19:30 +0000 (21:19 +0100)]
[TASK] Show warning when deleting an element which has references
Show the same warning in the page module as done in the list module,
except without the title and the table:uid combination, as this is
not needed in page module. It will always be tt_content records there.
Resolves: #78912
Releases: master
Change-Id: I4dea94204475e322fabf30d7a0772dc5e30edb60
Reviewed-on: https://review.typo3.org/50895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Frank Naegler [Wed, 31 Jan 2018 15:09:33 +0000 (16:09 +0100)]
[BUGFIX] Deprecate broken buildQueryParameters hook
This change deprecates the "buildQueryParameters" hook in three
different classes and adds two new hooks in DatabaseRecordList
and PageLayoutView to modify the current query.
With #82334 a cleanup of AbstractRecordList has introduced
the same hook into multiple classes, which breaks existing
hooks, because of the sixth parameter which can be one of three
different classes without a common parent class or interface.
This makes it impossible to use a type hint in the hook class.
Another problem is: an extension which implements the hook
for the list module and uses a type hint will break the page module.
The same query manipulation can be achieved with the two
new hooks, which have a separate identifier.
Resolves: #83740
Related: #82334
Releases: master
Change-Id: Ie3b2c8082f86c6632400a8194dca4ca244b428bc
Reviewed-on: https://review.typo3.org/55512
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Benni Mack [Wed, 7 Feb 2018 18:46:35 +0000 (19:46 +0100)]
[TASK] Add backwards-compatibility for old BE modules
Handling of "&M" parameters is added back in order to make
the transition for Backend modules easier.
Resolves: #83800
Related: #82406
Releases: master
Change-Id: Iaa237b62254804d78314b48d80dfbea563fd7af4
Reviewed-on: https://review.typo3.org/55589
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Wouter Wolters [Wed, 7 Feb 2018 20:37:57 +0000 (21:37 +0100)]
[BUGFIX] Remove wrong phpDoc for defineTypo3RequestTypes function
There is no return value, drop the @return tag.
Also add @param int $requestType to setRequestType
Resolves: #83801
Releases: master
Change-Id: I1f371effb5a56c02860af716ca4071ac3db3c4da
Reviewed-on: https://review.typo3.org/55593
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benjamin Franzke [Wed, 24 Jan 2018 19:31:28 +0000 (20:31 +0100)]
[TASK] Rewrite the redirect handler as PSR-15 HTTP middleware
The code is restructured to clearly distinct between aborting
the middleware chain – returning an own response – and forwarding
the request to the next middleware/request handler.
Change-Id: I51d88b9f9fae8d2aafca343da1e67bf60182d765
Releases: master
Resolves: #83727
Reviewed-on: https://review.typo3.org/55539
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benjamin Franzke [Wed, 7 Feb 2018 20:30:39 +0000 (21:30 +0100)]
[BUGFIX] Fix timetracker and pre-process middleware sequence
Correct middleware configuration to preserve the ordering
timetracker initialization and pre-process hook had prior
the re-implementation as middleware.
The timetracker initialization needs to be first, pre-process second.
Change-Id: Ieecfff459000566f75b692516f27f5d7e176149b
Resolves: #83802
Releases: master
Reviewed-on: https://review.typo3.org/55594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Thomas Hohn [Mon, 19 Dec 2016 05:48:49 +0000 (06:48 +0100)]
[TASK] Implement runtime_cache for DataHandler->recUpdateAccessCache
Removes "public internal" cache variable and implements runtime_cache
instead.
Change-Id: I8262a699d60db9e9eb04f23c3f7da78ef7e1149d
Resolves: #79071
Releases: master
Reviewed-on: https://review.typo3.org/51019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Daniel Windloff [Sun, 4 Jun 2017 17:29:27 +0000 (19:29 +0200)]
[TASK] Use existing js listeners in page module
Resolves: #81466
Releases: master, 8.7
Change-Id: Icf9dace3b00667e4d6a17cc5d3559782beffb725
Reviewed-on: https://review.typo3.org/53265
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Markus Sommer [Thu, 29 Jun 2017 14:36:16 +0000 (16:36 +0200)]
[TASK] Reenable all additionals in video tag
Enable all additionalAttributes and additionalConfig’s to cover w3c and special spacs.
Resolves: #81743, #81741
Releases: master, 8.7
Change-Id: Ibfce2bd66e6de95eeb7c05eab160eec40ae437ef
Reviewed-on: https://review.typo3.org/53356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Jasmina Ließmann [Fri, 14 Jul 2017 16:38:56 +0000 (18:38 +0200)]
[TASK] Unify layout of tables in submodules
Use the same layout for tables in submodules of module 'Info'.
Resolves: #81457
Releases: master
Change-Id: I1135bbf57eaa033fd09538c242192907b5b20ee4
Reviewed-on: https://review.typo3.org/53479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Christoph Lehmann [Thu, 7 Sep 2017 20:24:17 +0000 (22:24 +0200)]
[TASK] Improve prevention of redirect loop
This prevents a redirect loop with realurl where an editor
doesn't see the pagetree of his login domain in his workspace
and opens his login domain in the FE. As result he sees the
requested page.
Resolves: #82297
Releases: master, 8.7
Change-Id: Ie948f6defa21e3e1d8766533f54a48769d2220c9
Reviewed-on: https://review.typo3.org/53977
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
David Wong [Fri, 6 Jan 2017 08:02:51 +0000 (09:02 +0100)]
[TASK] Properly select Chinese (Simplified) in DatePicker.js
The language identifier key for Chinese in TYPO3s backend is ‘ch’.
The valid identifier should be ‘zh-cn’, but we cannot change the entire translation server
in a meaningful way.
Releases: master
Resolves: #79179
Change-Id: I5fee14f2eceacc5676588bdb8cac2aeceb88fff6
Reviewed-on: https://review.typo3.org/51161
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Benni Mack [Tue, 6 Feb 2018 12:01:35 +0000 (13:01 +0100)]
[TASK] Use TSFE->isBackendUserLoggedIn() instead of public variable
The public method TSFE->isBackendUserLoggedIn() instead of
TSFE->beUserLogin (public property).
Resolves: #83785
Releases: master
Change-Id: I1e54b7365b3b6810b606e93b0f888a7790492014
Reviewed-on: https://review.typo3.org/55575
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Benni Mack [Sat, 3 Feb 2018 20:53:48 +0000 (21:53 +0100)]
[TASK] Move frontend pre-process functionality to PSR-15 middleware
This patch moves logic out of the RequestHandlers into PSR-15 compatible
middleware classes to call a hook and initialize the time tracker.
Resolves: #83765
Releases: master
Change-Id: I200fdc80390625fb45564a4c09cecd00d846fad8
Reviewed-on: https://review.typo3.org/55584
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Benjamin Franzke [Sat, 3 Feb 2018 22:56:37 +0000 (23:56 +0100)]
[FEATURE] Add support for PSR-15 HTTP middlewares
PSR-15 middlewares are hooks on steroids for HTTP requests.
Due to chaining middlewares and the core request handler(s),
middlewares can execute code before and after the application.
Middlewares may return early, that means they can prevent
consecutive middleware and the core application from being executed
at all.
A full middleware coverage for *all* requests will need
a lot of changes to the core and extensions.
We'll eventually need to stop using header()/exit()/die()
or HttpUtility::{redirect,sendRespose}(). Those method calls
need to be replaced by manipulation of PSR-7 message objects.
PSR-15 interfaces are provided by psr/http-server-middleware:
composer require psr/http-server-middleware:^1.0
Change-Id: Ia906d51da2e4309a37fb47a7966b52f873782d8f
Releases: master
Resolves: #83725
Reviewed-on: https://review.typo3.org/55544
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reiner Teubner [Wed, 31 Jan 2018 14:30:21 +0000 (15:30 +0100)]
[BUGFIX] Replace calls to the deprecated PHP function each()
This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().
Resolves: #83737
Releases: master, 8.7, 7.6
Change-Id: Ie61a6d44fcdbd4ce6105a6c185085a3a68866fd8
Reviewed-on: https://review.typo3.org/55510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Michael Oehlhof [Sun, 10 Dec 2017 21:58:46 +0000 (22:58 +0100)]
[BUGFIX] Only scan package base paths if subdirectories exist
Include possible package base paths only if subdirectories are available.
Otherwise no extension can be found in the base path anyway.
Resolves: #83070
Releases: master, 8.7, 7.6
Change-Id: I503623c607554a60bd144c83e3f69e78fe5a7ea0
Reviewed-on: https://review.typo3.org/55018
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Georg Ringer [Sun, 28 Jan 2018 11:37:17 +0000 (12:37 +0100)]
[BUGFIX] Forward header in DebugUtility:debug to renderDump
Improve the debug output by forwarding the given title.
Resolves: #83688
Releases: master, 8.7
Change-Id: I160b5676c5ff70c056319446733c9549a663569a
Reviewed-on: https://review.typo3.org/55473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Jasmina Liessmann [Sat, 7 Oct 2017 12:22:56 +0000 (14:22 +0200)]
[TASK] Update screenshots in 'TYPO3 Manual'
Resolves: #82442
Releases: master
Change-Id: I90b596839a85c43c59c2d45870b344c09e59769d
Reviewed-on: https://review.typo3.org/54316
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>