Packages/TYPO3.CMS.git
13 months ago[BUGFIX] Upgrade Wizard must work also on records marked as deleted 37/52537/5
Christian Toffolo [Fri, 21 Apr 2017 05:36:58 +0000 (07:36 +0200)]
[BUGFIX] Upgrade Wizard must work also on records marked as deleted

Deleted records can be restored using the recycler, therefore the
wizards should check deleted records as well.

Resolves: #80836
Releases: master,8.7
Change-Id: I56a27c9dab4433c47c536edaa9649c5ebc73faad
Reviewed-on: https://review.typo3.org/52537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Trigger submit of RSA encrypted form properly 43/56143/2
Andreas Fernandez [Wed, 14 Mar 2018 08:29:55 +0000 (09:29 +0100)]
[BUGFIX] Trigger submit of RSA encrypted form properly

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Resolves: #84253
Related: #76120
Releases: master, 8.7, 7.6
Change-Id: Id30f4536dccec28edc0d909114c8fde71614bc30
Reviewed-on: https://review.typo3.org/56143
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[BUGFIX] checkIntegrityCsvFixtures.php displays error reason 98/56198/2
Markus Klein [Mon, 12 Mar 2018 23:25:16 +0000 (00:25 +0100)]
[BUGFIX] checkIntegrityCsvFixtures.php displays error reason

- output details about the columns if a mismatch is detected
- support windows paths for output formatting

Resolves: #84228
Releases: master, 8.7
Change-Id: I02bee0cb4ff99c18632907395989ea7f96c1c625
Reviewed-on: https://review.typo3.org/56198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Cast return value of postProcessDatabaseInsert to integer 95/56195/2
Susanne Moog [Thu, 15 Mar 2018 14:03:13 +0000 (15:03 +0100)]
[BUGFIX] Cast return value of postProcessDatabaseInsert to integer

Connection::lastInsertId returns a string but
DataHandler::postProcessDatabaseInsert has a strict integer return
value, so the value has to be casted to integer on return.

Additionally, when using sqlserver doctrine fails to fetch the last
inserted id under certain circumstances. An additional retrieval
method was introduced to mitigate that error.

Resolves: #84219
Releases: master, 8.7
Change-Id: I94dc0dc964aef26380703f641691c6a80ec5180d
Reviewed-on: https://review.typo3.org/56195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Restore getUrl support for list of headers 49/56149/3
Felix Buenemann [Wed, 7 Mar 2018 22:39:24 +0000 (23:39 +0100)]
[BUGFIX] Restore getUrl support for list of headers

The change of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the format of the $requestHeaders param was
implicitly changed from an array of header strings to an associative
array where the key is the header name and the value is either a single
or an array of values for that header.

This adds back support for the old list of headers format by detecting a
non-associative array and converting it to the Guzzle key/value(s) style.

At the same time the 'old' way is deprecated.

Resolves: #84171
Related: #70056
Releases: master, 8.7
Change-Id: I41b23993957288dfd5294129fa8039aab717461d
Reviewed-on: https://review.typo3.org/56149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Unbind load event after page tree refresh 70/56170/3
Andreas Fernandez [Thu, 15 Mar 2018 14:34:22 +0000 (15:34 +0100)]
[BUGFIX] Unbind load event after page tree refresh

When an action in the page tree is called via the context menu that
enforces a reload of the page tree, the tree is reloaded every time once
the content container is refreshed.

Change the event binding to use `one` to unbind automatically once the
tree was reloaded.

Resolves: #84294
Related: #82970
Releases: 8.7
Change-Id: Ife69dfbceb602a0d610397f313ea539fd9b93711
Reviewed-on: https://review.typo3.org/56170
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kluge <b.kluge@neusta.de>
Tested-by: Benjamin Kluge <b.kluge@neusta.de>
13 months ago[BUGFIX] LinkHandler creates wrong TS configuration 66/56166/2
Stefan Froemken [Thu, 15 Mar 2018 09:06:45 +0000 (10:06 +0100)]
[BUGFIX] LinkHandler creates wrong TS configuration

DatabaseRecordLinkBuilder creates a wrong
TypoScript configuration because of using
array_merge_recursive which joins all array elements
instead of replacing them.

Resolves: #84116
Releases: master,8.7
Change-Id: I212b70f86baf2929f9466fa665cec30fe477c6b8
Reviewed-on: https://review.typo3.org/56166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Apply potential changes after form editor save operation 62/56162/2
Ralf Zimmermann [Wed, 28 Feb 2018 23:21:36 +0000 (00:21 +0100)]
[BUGFIX] Apply potential changes after form editor save operation

Apply potential form definition changes within the form editor,
if the form definition changes while saving it.
This is possible through the hook ['ext/form']['beforeFormSave']

Releases: master, 8.7
Resolves: #84081
Change-Id: I0c20e0d20f9ec9ec8ccc0f279f68f9b4ebdfc306
Reviewed-on: https://review.typo3.org/56162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Accept configuration for external plugins from presets in ckeditor 57/56157/2
Marcus Schwemer [Thu, 18 May 2017 20:57:25 +0000 (22:57 +0200)]
[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Resolves: #81263
Releases: master,8.7
Change-Id: I4fc7c4f6f6ab40fe06e495e3ff98e067427c7d03
Reviewed-on: https://review.typo3.org/56157
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Correct path to translation in ReplaceFile template 50/56150/2
Wouter Wolters [Wed, 14 Mar 2018 19:02:15 +0000 (20:02 +0100)]
[BUGFIX] Correct path to translation in ReplaceFile template

The path is pointing to the wrong location. Language file was moved into
the Resources/Private/Language structure.

Resolves: #84268
Releases: 8.7
Change-Id: I1c5646d7134cdf544ad607b7605a5947913e7cbc
Reviewed-on: https://review.typo3.org/56150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGFIX] Correctly reference sys_file_metadata.language in TCA 48/56148/2
Christian Heindl [Sun, 11 Mar 2018 19:14:38 +0000 (20:14 +0100)]
[BUGFIX] Correctly reference sys_file_metadata.language in TCA

Palette "language" does not exists on table "sys_file_metadata" resulting
in an empty "language" tab, when editing a file's metadata.
Thus referencing language field directly.

Releases: master, 8.7
Resolves: #84200
Change-Id: I44b2b169bbce7948826fdade9f10a760b32df2c7
Reviewed-on: https://review.typo3.org/56148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Make hidden records searchable in top search 45/56145/2
Georg Ringer [Wed, 14 Mar 2018 07:06:06 +0000 (08:06 +0100)]
[BUGFIX] Make hidden records searchable in top search

Hidden records must be found by the top search again.

Resolves: #84248
Releases: master, 8.7
Change-Id: Ic41eff5ab3300746c7fe6a78f9ce2a305372f7ab
Reviewed-on: https://review.typo3.org/56145
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Set TYPO3 version to 8.7.12-dev 35/56135/2
Oliver Hader [Tue, 13 Mar 2018 12:46:05 +0000 (13:46 +0100)]
[TASK] Set TYPO3 version to 8.7.12-dev

Change-Id: Ie531010203764a9a134cdde887b1686872470764
Reviewed-on: https://review.typo3.org/56135
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[RELEASE] Release of TYPO3 8.7.11 34/56134/2 8.7.11 TYPO3_8-7-11 v8.7.11
Oliver Hader [Tue, 13 Mar 2018 12:44:28 +0000 (13:44 +0100)]
[RELEASE] Release of TYPO3 8.7.11

Change-Id: I7ab21ce9b0840faf4a329cd773a3dad2ff42bf0d
Reviewed-on: https://review.typo3.org/56134
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[TASK] Add missing documentation files and correct errors 32/56132/2
Christian Kuhn [Tue, 13 Mar 2018 12:05:51 +0000 (13:05 +0100)]
[TASK] Add missing documentation files and correct errors

Resolves: #84242
Releases: master, 8.7, 7.6
Change-Id: I049c053dee291e7c31dbf5c81aacde0619d0f244
Reviewed-on: https://review.typo3.org/56132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Ensure TSconfig order is identical in BE and FE 27/56127/2
Markus Klein [Mon, 12 Mar 2018 22:04:29 +0000 (23:04 +0100)]
[BUGFIX] Ensure TSconfig order is identical in BE and FE

Make sure the inclusion order of TSconfig (files and record field)
are identical in BE and FE. As BE and FE use different algorithms,
FE is adjusted to match the BE behaviour, which is the expected one.

Resolves: #84227
Releases: master, 8.7
Change-Id: Idb4afbd736ed65890850ee75d572a55c3a5ab24d
Reviewed-on: https://review.typo3.org/56127
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again 26/56126/2
Oliver Hader [Mon, 12 Mar 2018 12:10:42 +0000 (13:10 +0100)]
[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Resolves: #83630
Releases: master, 8.7
Change-Id: Ib01f698c14fb646173ec24e26027c7d657700f87
Reviewed-on: https://review.typo3.org/56126
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Add upgrade wizard to keep sorting of sys_language records 23/56123/2
Georg Ringer [Tue, 27 Feb 2018 20:40:12 +0000 (21:40 +0100)]
[BUGFIX] Add upgrade wizard to keep sorting of sys_language records

To keep the sorting after an upgrade from 7.6 to 8.7 and later, an
upgrade wizard is added.

Resolves: #82538
Releases: master, 8.7
Change-Id: If1b5fbc56d445239bc6e4eaecb695889aeb9819b
Reviewed-on: https://review.typo3.org/56123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Add functional test for runtimeActivatedPackages 20/56120/2
Nicole Cordes [Mon, 12 Mar 2018 14:32:44 +0000 (15:32 +0100)]
[TASK] Add functional test for runtimeActivatedPackages

Resolves: #84215
Releases: master, 8.7, 7.6
Change-Id: I9a642bb90278b22e61b97634022d3ab7af514e10
Reviewed-on: https://review.typo3.org/56120
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Add missing element description field to form editor 19/56119/2
Benjamin Kott [Mon, 12 Mar 2018 17:47:23 +0000 (18:47 +0100)]
[BUGFIX] Add missing element description field to form editor

To avoid the unsetting of previously set element descriptions for
input fields in the form editor, the field elementDescription was
added to all supported element types and is now available to editors.

Resolves: #84225
Releases: master, 8.7
Change-Id: Ide68a1fc95670d98df4e243436e93aa812bf9290
Reviewed-on: https://review.typo3.org/56119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Correct automatic grid column calculation for forms 17/56117/3
Benjamin Kott [Mon, 12 Mar 2018 09:23:15 +0000 (10:23 +0100)]
[BUGFIX] Correct automatic grid column calculation for forms

The calculation now only includes direct children of the
row elements to produce a meaningful division
of the available space. If the available space is already
consumed by elements the next auto calculated
elements will now consume the space of a full row.

Resolves: #84207
Releases: master, 8.7
Change-Id: I5dabddbcd8c7b84236fdbbef3925d27197e99a39
Reviewed-on: https://review.typo3.org/56117
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element 66/56066/3
Benjamin Kott [Mon, 12 Mar 2018 14:18:13 +0000 (15:18 +0100)]
[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element

Resolves: #84181
Releases: master, 8.7
Change-Id: If55767b54071809e9622f9c29829bf4a76c66409
Reviewed-on: https://review.typo3.org/56066
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method 01/56101/2
Christian Kuhn [Sun, 11 Mar 2018 19:41:27 +0000 (20:41 +0100)]
[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method

With refactoring in #79159 one method has accidently been set
public while it is obvious it should be protected. Fix that. Patch
is not considered to be breaking since the method is an internal
method of that abstract class.

Resolves: #84201
Related: #79159
Releases: master, 8.7
Change-Id: I0c04ff2d3fe9d68420c80af8831df361eb6f8a13
Reviewed-on: https://review.typo3.org/56101
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Allow empty date/time in strict database modes 64/56064/2
Oliver Hader [Thu, 8 Mar 2018 14:57:53 +0000 (15:57 +0100)]
[BUGFIX] Allow empty date/time in strict database modes

Empty date/time values are represented by the FormEngine as empty
string (''). Trying to persist this value in database management systems
using strict mode (which is enabled per default in MySQL 5.7),
will cause an SQL error since field types do not match.

Since it's known for the TYPO3 core which field types are used in
particular database tables, it's also possible to enforce this
type to be casted to integer values. This is done by using the
according TCA evaluation function 'int'.

Resolves: #82756
Releases: master, 8.7
Change-Id: I487caae785a3943916bceebc0c484d58e900a841
Reviewed-on: https://review.typo3.org/56064
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Update fluid from 2.5.2 to 2.5.3 07/56107/2
Christian Kuhn [Mon, 12 Mar 2018 12:09:18 +0000 (13:09 +0100)]
[BUGFIX] Update fluid from 2.5.2 to 2.5.3

composer update typo3fluid/fluid

This fixes a count bug in if conditions and
a template resolving issue.

Resolves: #83812
Releases: master, 8.7
Change-Id: Ie5845614ffeac50dc5a5796d587d61015c4f1059
Reviewed-on: https://review.typo3.org/56107
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Streamline package management in PackageManager 11/56111/2
Nicole Cordes [Mon, 12 Feb 2018 20:30:43 +0000 (21:30 +0100)]
[BUGFIX] Streamline package management in PackageManager

This bugfix resolves an issue that all available Packages
are scanned at each request. At the same time, it fixes
an issue related to runtimeActivatedPackages.

We now
- resolve package key with api usage
- distinguish between registered and available packages
- remove superfluous exception annotations
- prevent superfluous scans on getPackage() and isPackageAvailable() calls

Releases: master, 8.7
Resolves: #83820
Change-Id: I2b8bff3d4bb5287fd76418217653477c77467a8e
Reviewed-on: https://review.typo3.org/56111
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] For links across domains check if absRefPrefix is set 09/56109/2
Stefan Neufeind [Fri, 9 Mar 2018 16:42:27 +0000 (17:42 +0100)]
[BUGFIX] For links across domains check if absRefPrefix is set

Prevent PHP-error if absRefPrefix is not set.

Resolves: #84188
Releases: master, 8.7
Change-Id: Ic04184554281cdcaa74037290930aa0110696a07
Reviewed-on: https://review.typo3.org/56109
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Adding novalidate Attribute to Fluid Form ViewHelper 38/53738/3
Pascal Langhals [Wed, 21 Jun 2017 14:31:11 +0000 (16:31 +0200)]
[TASK] Adding novalidate Attribute to Fluid Form ViewHelper

At the moment there is no possibility to disable the client side
validation for the fluid form tag.

Releases: master,8.7
Resolves: #81654
Change-Id: I8adbd51f0d50528e8a7d92fc4aeb2315aefafee7
Reviewed-on: https://review.typo3.org/53738
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Properly HTML encode site name in page module 85/56085/2
Helmut Hummel [Fri, 9 Mar 2018 21:14:09 +0000 (22:14 +0100)]
[BUGFIX] Properly HTML encode site name in page module

Resolves: #84191
Releases: master, 8.7, 7.6
Change-Id: Id0f2da6f77b3c01293478329503dc922ccd7e72c
Reviewed-on: https://review.typo3.org/56085
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
13 months ago[BUGFIX] Unify value for $report['lib'] to GuzzleHttp 91/56091/2
Felix Buenemann [Wed, 7 Mar 2018 19:30:43 +0000 (20:30 +0100)]
[BUGFIX] Unify value for $report['lib'] to GuzzleHttp

GeneralUtility::getUrl() now always returns 'GuzzleHttp' as lib
in the report, instead of returning
"GuzzleHttp" if an exception was caught and "http" otherwise.

Resolves: #84170
Related: #70056
Releases: master, 8.7
Change-Id: I6a28cb7921a3d784c37912c12f9b250f6b4d493c
Reviewed-on: https://review.typo3.org/56091
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
13 months ago[BUGFIX] Do not check HTTP referrer anymore 18/55818/4
Benni Mack [Tue, 20 Feb 2018 07:46:24 +0000 (08:46 +0100)]
[BUGFIX] Do not check HTTP referrer anymore

Under certain circumstances some browsers do not set the HTTP referrer
anymore due to privacy reasons. Hence, checking the referrer breaks
functionality.

Resolves: #83768
Releases: master, 8.7, 7.6
Change-Id: Ia8f882e07a9e2091ceb38aee814badb97403250d
Reviewed-on: https://review.typo3.org/55818
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Simulate submit button for rsaauth form submit 88/56088/2
Nicole Cordes [Sat, 28 May 2016 17:12:38 +0000 (19:12 +0200)]
[BUGFIX] Simulate submit button for rsaauth form submit

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

Resolves: #76120
Releases: master, 8.7, 7.6
Change-Id: I3f0fdc7e933267689114d5bcf62d3fcfe2db5146
Reviewed-on: https://review.typo3.org/56088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Set correct default connection charset "utf8" 86/56086/2
Wolfgang Klinger [Fri, 9 Mar 2018 21:12:14 +0000 (22:12 +0100)]
[BUGFIX] Set correct default connection charset "utf8"

Resolves: #84180
Releases: master, 8.7
Change-Id: Id868d3f379d131c3a51e039e6a862e4dcabf2fda
Reviewed-on: https://review.typo3.org/56086
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Assign elementClassAttribute to ImageUpload element 76/56076/2
Benjamin Kott [Thu, 8 Mar 2018 14:22:52 +0000 (15:22 +0100)]
[BUGFIX] Assign elementClassAttribute to ImageUpload element

Resolves: #84179
Releases: master, 8.7
Change-Id: I061674ab878dbfbd2483c17e46a48e2f606ddd87
Reviewed-on: https://review.typo3.org/56076
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Proper returnUrl editing permissions from context menu 74/56074/2
Christian Kuhn [Fri, 9 Mar 2018 00:03:44 +0000 (01:03 +0100)]
[BUGFIX] Proper returnUrl editing permissions from context menu

Context menu on pages -> More options -> Access call the
permissions module without proper returnUrl, doc header
"save and close" then fails redirecting to last view.
Fix using similar tec as used in other places like filelist
by providing a proper returnUrl.

Resolves: #83685
Releases: master, 8.7
Change-Id: Ib2136caaee8278438de3ff56faf5a940b7caf1d1
Reviewed-on: https://review.typo3.org/56074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Do not mark "current" links as broken 72/56072/2
Susanne Moog [Thu, 8 Mar 2018 09:53:25 +0000 (10:53 +0100)]
[BUGFIX] Do not mark "current" links as broken

The linkhandler can resolve pages by uid or by using the
special keyword "current" which links the current page id.

The RteHtmlParser marked links to "current" as broken as the check
on whether the page record exists fails with a non-int uid.

The check has been disabled for links to the current page, as in that
context "current" has to be a valid page record (else content could
not be edited on it).

Resolves: #83423
Releases: master, 8.7
Change-Id: Iefde294a5f84e28a5faa1bc1262b7cc84e625f7e
Reviewed-on: https://review.typo3.org/56072
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Check registry for upgrade wizard report 49/56049/2
Jigal van Hemert [Thu, 8 Mar 2018 07:29:31 +0000 (08:29 +0100)]
[BUGFIX] Check registry for upgrade wizard report

In the Reports module the check for unfinished upgrade wizards also
checks the registry to see if a wizard is marked as done. Upgrade
wizards can be marked as done even if their function
shouldRenderWizard() indicates that they are not finished. The
Reports module now shows the same status as the Install Tool.

Resolves: #84146
Releases: 8.7
Change-Id: I994f362545437743216cfc9a64fbf0d6af394379
Reviewed-on: https://review.typo3.org/56049
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings 69/56069/2
René Pflamm [Mon, 22 Jan 2018 15:02:04 +0000 (16:02 +0100)]
[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings

If typolinks are generated using LinkHandler, the values defined in
typoscript (such as classes and titles) are now retained.

Resolves: #81903
Releases: master, 8.7
Change-Id: I9ec63e2cf972a3c4e7439b9259c63e2ab9b4b60d
Reviewed-on: https://review.typo3.org/56069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Allow range options to work for date/time fields 60/56060/2
Jigal van Hemert [Tue, 6 Mar 2018 10:22:35 +0000 (11:22 +0100)]
[BUGFIX] Allow range options to work for date/time fields

Date and time fields can contain ISO-8601 values. To apply lower and
upper limits the value must first be converted to a UNIX timestamp.

Resolves: #83240
Releases: master, 8.7
Change-Id: Ic15e9486cf7a4bcdf557c8a197d957ad88302b61
Reviewed-on: https://review.typo3.org/56060
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
13 months ago[BUGFIX] Change getUrl() $report['content_type'] to string 57/56057/2
Felix Buenemann [Thu, 8 Mar 2018 08:18:34 +0000 (09:18 +0100)]
[BUGFIX] Change getUrl() $report['content_type'] to string

In the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the type of the $report['content_type'] field
was changed from a string to an array of strings.

This changes the field back to a string.

Also updated ErrorController getUrl test double to reflect the changes.

Resolves: #84173
Related: #84167
Releases: master, 8.7
Change-Id: Ia0eb60c42e920d66ce63afd0bd659c4b56d6d05b
Reviewed-on: https://review.typo3.org/56057
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Catch all exceptions in page module of form framework 56/56056/2
Ralf Zimmermann [Tue, 20 Feb 2018 16:40:22 +0000 (17:40 +0100)]
[BUGFIX] Catch all exceptions in page module of form framework

Catch the toplevel \Exception within the preview renderer hook. This
prevents that the page module shows an exception stacktrace if a
formDefinition - which is referenced within a form plugin - is moved
manually to a different location.
The problem occurs because the TYPO3\CMS\Core\Resource\Driver\LocalDriver
throws some top level exceptions (e.g. within getFileInfoByIdentifier()).

Resolves: #83777
Releases: master, 8.7
Change-Id: I686adb9e38b6f1b0bcb9830fe71d318ba0199a75
Reviewed-on: https://review.typo3.org/56056
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[!!!][BUGFIX] Fix wrong error path of validation 53/56053/3
Daniel Siepmann [Fri, 15 Sep 2017 22:55:34 +0000 (00:55 +0200)]
[!!!][BUGFIX] Fix wrong error path of validation

Add the form name as top level property to the validation results to let
the form field viewhelper attribute "errorClass" work.

Releases: master, 8.7
Resolves: #82093
Change-Id: I2d1c0845c5ab15d68393d5b491bf26db8f3f17c0
Reviewed-on: https://review.typo3.org/56053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
13 months ago[BUGFIX] Add missing AND concatenation in generated SQL statement 40/55840/2
Nicole Cordes [Tue, 20 Feb 2018 18:48:24 +0000 (19:48 +0100)]
[BUGFIX] Add missing AND concatenation in generated SQL statement

This patch adds a missing AND concatenation in
\TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRecordList::makeQueryArray.
As the search string is returned as plain SQL constraint and is added
to an already existing statement, it needs to be prefix with "AND".

Resolves: #83984
Releases: 8.7
Change-Id: I9b62a26f39b0899a1b6e3549eb4a6a488ad1aaac
Reviewed-on: https://review.typo3.org/55840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Pass original extbase response object to form framework finishers 48/56048/2
Benjamin Franzke [Wed, 21 Feb 2018 00:21:50 +0000 (01:21 +0100)]
[BUGFIX] Pass original extbase response object to form framework finishers

The original extbase response was passed as second parameter
to ObjectManager->get() – that did effectively nothing. The second get()
parameter is not a fallback parameter (as probably supposed by the author)
but the first constructor argument (but Response has no constructor).
Now, rather use a coalesce operator to use the original response or create
an own, if required.

Also handle the StopActionException in case no extbase response
is available (e.g. when rendered through FluidTemplateContentObject).

Due to this fixes the redirect finisher can be adapted to stop echo'ing
the response content on it's own. Directly echo'ing the response content
caused wrong Content-Length headers to be generated as the core didn't
know that content has been echo'ed. (The redirect response contains both a
header based redirect and html meta redirect; due to early echo that meta
redirect is prepended to the regular html output, and is missing in the
Content-Length calculation.)
That casused certain server environments (e.g. gzip, keep-alive,
proxy) and browsers (e.g. Android, Opera desktop) to display gzip
compressed data as garbage in the browser.

Resolves: #83822
Releases: master, 8.7
Change-Id: I4cb56e7626ea786d4b5265782b5940e60e3d2ec0
Reviewed-on: https://review.typo3.org/56048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Convert URLs to punycode 51/56051/2
Sybille Peters [Wed, 21 Feb 2018 20:15:42 +0000 (21:15 +0100)]
[BUGFIX] Convert URLs to punycode

Resolves: #55155
Releases: master, 8.7
Change-Id: If7c099647a73d25f86ac38bdda67935deb4930e0
Reviewed-on: https://review.typo3.org/56051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl 47/56047/2
Felix Buenemann [Wed, 7 Mar 2018 20:51:52 +0000 (21:51 +0100)]
[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl

This fixes a negation bug introduced when the GeneralUtility::getUrl
code was converted to use GuzzleHttp instead of cURL.

Also updated ErrorController test doubles that where asserting the
wrong behavior.

Resolves: #84167
Releases: master, 8.7
Change-Id: I9b8982dc34f8a4ac22769beb7f837f090ce73f23
Reviewed-on: https://review.typo3.org/56047
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths" 45/56045/2
Benjamin Franzke [Wed, 7 Mar 2018 12:06:28 +0000 (13:06 +0100)]
[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths"

This reverts commit 5c048a4c8017e4d50ab5f2343970a0fd33e4aaed
as introduced in https://review.typo3.org/54416

That workaround for a fluid bug had side effects when DataProviders
expected a ConfigurationManager instance to be available. That is
nothing officially supported but broke some (bad behaving) DataProviders.
As the fluid bug has been fixed in https://github.com/TYPO3/Fluid/pull/342
(contained in release 2.5.2) we can revert the workaround now.

The functional test that was introduced next to the bugfix is not reverted,
as do want to keep that obviously.

Resolves: #84071
Releases: master, 8.7
Change-Id: Ie6f5541f0f217fee7e85df954bb964a32fd27367
Reviewed-on: https://review.typo3.org/56045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Update display of form fields in module 'view' 92/55892/2
Jasmina Liessmann [Fri, 2 Jun 2017 16:40:02 +0000 (18:40 +0200)]
[TASK] Update display of form fields in module 'view'

Adapt style of other modules to form fields in module 'view', correct position of resize handle bar.

Resolves: #77576
Releases: master, 8.7
Change-Id: I7366016902ebca8e7da984a52a3b83d8dd227f79
Reviewed-on: https://review.typo3.org/55892
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check 72/54672/4
Wolfgang Klinger [Sat, 12 Aug 2017 18:53:00 +0000 (20:53 +0200)]
[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check

In case of handling a translated page record, use the according
proper uid value of the containing page of default language.

Resolves: #82053
Releases: master, 8.7
Change-Id: I0d0b5a268f4b87ef44d892f046ef474624b18058
Reviewed-on: https://review.typo3.org/54672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Remove trailing tab char on rst snippet 38/56038/3
Mathias Schreiber [Wed, 7 Mar 2018 17:16:59 +0000 (18:16 +0100)]
[BUGFIX] Remove trailing tab char on rst snippet

Resolves: #84166
Releases: 8.7
Change-Id: Iae8d1908d45304f8c5da09fe1beff079c44c9f12
Reviewed-on: https://review.typo3.org/56038
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Access element in Viewport cleanup correctly 37/56037/2
Andreas Fernandez [Wed, 7 Mar 2018 15:27:38 +0000 (16:27 +0100)]
[BUGFIX] Access element in Viewport cleanup correctly

Resolves: #84164
Releases: 8.7
Change-Id: I5b4efcd3abb1d7f516ac89ba0f37f6857de8e5ee
Reviewed-on: https://review.typo3.org/56037
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Update Fluid dependency to 2.5.2 34/56034/2
Claus Due [Wed, 7 Mar 2018 12:01:51 +0000 (13:01 +0100)]
[TASK] Update Fluid dependency to 2.5.2

This patch updates the Fluid dependency, to solve:

* Array keys now preserved when using reverse=1 on
   f:for - https://github.com/TYPO3/Fluid/commit/227a05a322bf584254544ef1c948d63e1af7bbd4
* TemplatePaths cache is made non-static -
   https://github.com/TYPO3/Fluid/commit/fa1b8aaeb957729478c958e495623dd7de1d14a1

Change-Id: Id10a80455f47300bfd29d734c83d9add87e17640
Releases: master, 8.7
Resolves: #84160
Reviewed-on: https://review.typo3.org/56034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Use correct issue reference in allowLanguageSynchronization documentation 26/56026/2
Oliver Hader [Tue, 6 Mar 2018 15:42:51 +0000 (16:42 +0100)]
[TASK] Use correct issue reference in allowLanguageSynchronization documentation

Replace the Gerrit review ID by the related Forge ticket number.

Resolves: #84150
Releases: master, 8.7
Change-Id: I53fe0699e74949b4c64020a955294b3a1ef3f726
Reviewed-on: https://review.typo3.org/56026
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Unset internal properties of processed file on delete 05/53505/4
Helmut Hummel [Mon, 20 Mar 2017 18:28:12 +0000 (19:28 +0100)]
[BUGFIX] Unset internal properties of processed file on delete

When a processed file is deleted because it needs reprocessing, set the
internal deleted property to true and unset its properties as well, as
they are stale anyway.

This is important as in the later processing it is checked whether the
current object is persisted (which it is not anymore) and an SQL update
is triggered, which then fails leading to another processing run in
subsequent requests.

When unsetting the internal properties a new row will be inserted
in the same request.

Resolves: #80359
Releases: 7.6, 8.7, master
Change-Id: I39eec59ed4ac071883ff97eab7018d1ede92fb95
Reviewed-on: https://review.typo3.org/53505
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
13 months ago[BUGFIX] RootlineUtility only resolves defined relation fields 19/56019/3
Benni Mack [Mon, 5 Mar 2018 18:49:50 +0000 (19:49 +0100)]
[BUGFIX] RootlineUtility only resolves defined relation fields

The RootlineUtility first selects all fields, which have been added
via the config option "addRootLineFields". After that, it iterates
over all(!) columns that are defined as relation.

The change modifies the loop so that only relations are resolved for
field pages.media (predefined) and those fields that have been added
to $GLOBALS[TYPO3_CONF_VARS][FE][addRootLineFields].

Resolves: #84144
Releases: master, 8.7
Change-Id: I3150f7cdd14aff3f25d5070f4ce190d510ba3614
Reviewed-on: https://review.typo3.org/56019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGIFX] MediaceExtractionUpdate in Install Tool always requiring an update 84/55884/4
Joshua Westerheide [Sat, 24 Feb 2018 10:30:06 +0000 (11:30 +0100)]
[BUGIFX] MediaceExtractionUpdate in Install Tool always requiring an update

Due to recent refactoring to use the Doctrine Query Builder the
`checkForUpdate()` method of MediaceExtractionUpdate broke.
`\Doctrine\DBAL\Driver\ResultStatement::fetchColumn` may return
a string depending on used db driver.

Fixes changes made by I77dd213b75acbb129954ccdcf70a3722bf1a6675.

Resolves: #84029
Releases: 8.7
Change-Id: I379de745a26dfb58d04429f13bbe5009f15fb659
Reviewed-on: https://review.typo3.org/55884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] bamboo: Hard kill php web server processes 14/56014/2
Christian Kuhn [Mon, 5 Mar 2018 15:39:40 +0000 (16:39 +0100)]
[TASK] bamboo: Hard kill php web server processes

bamboo acceptance test shut down sometimes fails to stop
the 'php -S' web server process for unknown reasons.
A next job on the same agent then fails to bind to the
port, leading to broken builds.
Switch from SIGTERM to SIGKILL during test shut down
to see if that improves the situation.

Resolves: #84143
Releases: master, 8.7
Change-Id: I838a2341f1f8e25fa461b8747337406391b52241
Reviewed-on: https://review.typo3.org/56014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Synchronize RST files 11/56011/2
Christian Kuhn [Mon, 5 Mar 2018 12:43:25 +0000 (13:43 +0100)]
[TASK] Synchronize RST files

* Various .rst file index fixes, NotScanned usually does not make
  sense on Important- and Feature- files.
* Add a missing extension scanner config
* Sync 7* and 8* folders to other core branches

Resolves: #84141
Releases: master, 8.7, 7.6
Change-Id: Ifc19d774d45395cb30bd51f50d9121af409f48bb
Reviewed-on: https://review.typo3.org/56011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Allow multi-byte characters in live search 08/56008/2
Sven Burkert [Sat, 3 Mar 2018 23:12:40 +0000 (00:12 +0100)]
[BUGFIX] Allow multi-byte characters in live search

Resolves: #83539
Releases: master, 8.7
Change-Id: I4d589d0654ab7ee091b664957fbb8c6d101be663
Reviewed-on: https://review.typo3.org/56008
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Replace star icon properly after saving shortcut 05/56005/2
Andreas Fernandez [Sun, 4 Mar 2018 18:28:10 +0000 (19:28 +0100)]
[BUGFIX] Replace star icon properly after saving shortcut

Resolves: #84130
Releases: 8.7
Change-Id: If501bcf839a66d5eebe5432a959d207a1fede7e6
Reviewed-on: https://review.typo3.org/56005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Have extractFileInformation extract atime only once 95/55995/2
Guido Schmechel [Sat, 3 Mar 2018 09:25:57 +0000 (10:25 +0100)]
[BUGFIX] Have extractFileInformation extract atime only once

Remove duplicate "atime" entry to prevent duplicate
call of "atime" property extraction.

Resolves: #83992
Releases: master, 8.7
Change-Id: I2e09bc07b12b07eb89bd6fb247d0fed4431c8ef6
Reviewed-on: https://review.typo3.org/55995
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
13 months ago[TASK] Don't mark ConnectionPool::getConnectionByName() as internal 89/55989/2
Georg Ringer [Fri, 2 Mar 2018 12:18:22 +0000 (13:18 +0100)]
[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Resolves: #84100
Releases: master, 8.7
Change-Id: I9bbf524905c436097264c465e92d8b689994c253
Reviewed-on: https://review.typo3.org/55989
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Add +repage option when cropping images 80/55980/2
Frans Saris [Thu, 4 Jan 2018 20:16:07 +0000 (21:16 +0100)]
[BUGFIX] Add +repage option when cropping images

To be sure the image (especialy gif format) is correctly repaged after
cropping it the +repage option needs to be added to the full command.

This patch adds the option for the LocalCropScaleMaskHelper and the
ImageBuilder cropscaling `crs` option.

Resolves: #83407
Releases: master, 8.7
Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9
Reviewed-on: https://review.typo3.org/55980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix imagemagick commands when setting stripProfile to "0" 79/55979/2
Paul Golmann [Thu, 9 Mar 2017 11:12:50 +0000 (12:12 +0100)]
[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"

Remove the ###SkipStripProfile### flag from command parameters added
by e.g. stripProfile in TypoScript if
GFX[processor_stripColorProfileByDefault] is disabled in global
configuration to prevent erroneous imagemagick commands.

Resolves: #80208
Releases: master, 8.7
Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4
Reviewed-on: https://review.typo3.org/55979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Properly append/prepend with "addRecord" wizard 78/55978/2
Mathias Brodala [Tue, 20 Feb 2018 14:47:59 +0000 (15:47 +0100)]
[BUGFIX] Properly append/prepend with "addRecord" wizard

For relations the internal field value contains a list of UIDs instead
of full related records.

Resolves: #82461
Releases: master, 8.7
Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63
Reviewed-on: https://review.typo3.org/55978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Put commit hooks into Build/git-hooks directory 73/55973/2
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55973
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Update typo3fluid/fluid to 2.5.1 72/55972/2
Markus Klein [Wed, 28 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.1

- Allows any protocol or wrapper for template sources
- Ignores empty path specifications

composer command used:
composer update typo3fluid/fluid

Resolves: #84095
Releases: master, 8.7
Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3
Reviewed-on: https://review.typo3.org/55972
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Remove undocumented values from Soft Reference Index data 69/55969/2
Markus Klein [Wed, 28 Feb 2018 14:28:06 +0000 (15:28 +0100)]
[BUGFIX] Remove undocumented values from Soft Reference Index data

The fix for #80991 introduced new data in the data structure returned
by the SoftReferenceIndex class' methods.
This new data stems from LinkHandlers, which may provide arbitrary
data. This causes side effects for consumers of the SoftReferenceIndex
like the reference index and the export functionality.

By removing this extra data - which is not used anywhere at all - the
returned data is again conforming to what is documented and keeps
the interface to the SoftReferenceIndex clean.

Resolves: #84080
Releases: master, 8.7
Change-Id: Ic39a8b593cb239aca698e857d1ee602bdeaf229f
Reviewed-on: https://review.typo3.org/55969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix linktype selection in Linkvalidator report 66/55966/5
Sybille Peters [Thu, 22 Feb 2018 13:46:42 +0000 (14:46 +0100)]
[BUGFIX] Fix linktype selection in Linkvalidator report

* handle uninitialized values
* do not show all results in report if no linktypes checked

Resolves: #84010
Releases: master, 8.7
Change-Id: Id04d2eed1b1390f2cbf67fd971d7cc4d61539f15
Reviewed-on: https://review.typo3.org/55966
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Respect "recursive" flag when restoring records in recycler 47/55947/2
Benjamin Kluge [Wed, 28 Feb 2018 19:00:29 +0000 (20:00 +0100)]
[BUGFIX] Respect "recursive" flag when restoring records in recycler

Resolves: #81214
Releases: master, 8.7
Change-Id: I45129dd0ff91fc339f520e8e5d9a65ece4a701a8
Reviewed-on: https://review.typo3.org/55947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Finalize rowDescription for sys_file_collection 59/55959/2
Josef Glatz [Wed, 28 Feb 2018 20:33:22 +0000 (21:33 +0100)]
[BUGFIX] Finalize rowDescription for sys_file_collection

Add missing TCA configuration for descriptionColumn in
sys_file_collection records. The database column already
exists in ext_tables.sql.

Change-Id: I696e982145604114181240bef321683569187bcd
Resolves: #84093
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55959
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere 57/55957/2
Georg Ringer [Tue, 27 Feb 2018 06:44:11 +0000 (07:44 +0100)]
[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere

Avoid using a prepared statement to return the final query part.

Resolves: #84022
Releases: master, 8.7
Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a
Reviewed-on: https://review.typo3.org/55957
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Add space in lockedRecords messages for translated languages 51/55951/2
Josef Glatz [Wed, 28 Feb 2018 19:03:55 +0000 (20:03 +0100)]
[BUGFIX] Add space in lockedRecords messages for translated languages

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d
Resolves: #84088
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55951
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Allow browser notifications only on encrypted connection 46/55946/2
Frank Naegler [Tue, 27 Feb 2018 09:36:36 +0000 (10:36 +0100)]
[BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55946
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Improve strictness of resource access blocking in _.htaccess 42/55942/2
Markus Klein [Wed, 28 Feb 2018 12:50:53 +0000 (13:50 +0100)]
[TASK] Improve strictness of resource access blocking in _.htaccess

For Apache HTTP versions 2.3+ there is a better way to avoid conflicts
in priority of sections. Since the `if` condition has been introduced
it is ranked the highest priority, hence it is most suitable for
rules to protect sensitive data.

Resolves: #81849
Releases: master, 8.7
Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9
Reviewed-on: https://review.typo3.org/55942
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Avoid renumbering array keys on writing configuration 43/55943/2
Helmut Hummel [Wed, 28 Feb 2018 12:41:49 +0000 (13:41 +0100)]
[BUGFIX] Avoid renumbering array keys on writing configuration

Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.

Therefore this pure visual optimization is removed
when writing LocalConfiguration.php

At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.

Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Initiate correct storage of processed file during reconstitution 35/55935/2
Frans Saris [Tue, 27 Feb 2018 16:07:25 +0000 (17:07 +0100)]
[BUGFIX] Initiate correct storage of processed file during reconstitution

Releases: master, 8.7
Resolves: #84069
Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824
Reviewed-on: https://review.typo3.org/55935
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Make sure that mass actions actually process all changes 96/55896/3
Benedikt Huß [Wed, 28 Feb 2018 08:37:12 +0000 (09:37 +0100)]
[BUGFIX] Make sure that mass actions actually process all changes

Evaluate number of total items and trigger subsequent requests to
process the remaining items, so that all changes are actually
processed.

Resolves: #84037
Releases: master, 8.7
Change-Id: I92f388b50328320973abcc290de52083f05655dd
Reviewed-on: https://review.typo3.org/55896
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Avoid PHP warnings within DatePickerViewHelper 34/55934/2
Ralf Zimmermann [Tue, 27 Feb 2018 13:47:58 +0000 (14:47 +0100)]
[BUGFIX] Avoid PHP warnings within DatePickerViewHelper

Avoid PHP warnings within ext:form DatePickerViewHelper if the property
properties.additionalAttributes.placeholder is not defined within
the form definition.

Releases: master, 8.7
Resolves: #84065
Change-Id: I49e0bb3a9548f0be402e1a4794c60c1b42744fac
Reviewed-on: https://review.typo3.org/55934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive 24/55924/2
Markus Klein [Tue, 27 Feb 2018 14:57:58 +0000 (15:57 +0100)]
[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive

Add a new test to make sure that identical input arrays also deliver
an empty result as difference.

Resolves: #84067
Releases: master, 8.7, 7.6
Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e
Reviewed-on: https://review.typo3.org/55924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Show error message when hiding page from context menu 03/55903/2
Tymoteusz Motylewski [Mon, 26 Feb 2018 12:51:58 +0000 (13:51 +0100)]
[BUGFIX] Show error message when hiding page from context menu

Renamed key in the response to match what is expected
in actions.js evaluateResponse method.

Releases: 8.7, 7.6
Resolves: #82282
Change-Id: I4528963aded3a8203ab144c8353fc0509aa8a1e7
Reviewed-on: https://review.typo3.org/55903
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Update readme copyright date to 2018 97/55897/3
Guido Schmechel [Sat, 24 Feb 2018 08:35:34 +0000 (09:35 +0100)]
[TASK] Update readme copyright date to 2018

Releases: master, 8.7, 7.6
Resolves: #84028
Change-Id: Ia6094c57c976ecf6e89b1d99aca0a1b12684e0b2
Reviewed-on: https://review.typo3.org/55897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Use Icon API for date picker icons 79/55879/2
Frank Naegler [Fri, 23 Feb 2018 13:45:48 +0000 (14:45 +0100)]
[BUGFIX] Use Icon API for date picker icons

In the scheduler edit task view, a FontAwesome icon for the
date picker was used. This patch uses the IconViewHelper to
use the same icon as everywhere in the backend.

Resolves: #84024
Releases: master, 8.7
Change-Id: Ie1e8846ba8e3fc2eee4134cd2d97b43345b3c0e6
Reviewed-on: https://review.typo3.org/55879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Show workspace preview text again 93/55893/2
Benni Mack [Sat, 24 Feb 2018 10:24:57 +0000 (11:24 +0100)]
[BUGFIX] Show workspace preview text again

Due to refactorings in various places, a simple copy/paste
mistake was done when showing the preview text of a
workspace. Due to the bug, previewing a workspace
only showed "PREVIEW", instead of "Preview of Workspace
XYZ" and the logout button.

Resolves: #84030
Related: #38735
Related: #83158
Releases: master, 8.7
Change-Id: Id4dacd7e5608d75ad52216729011a5234f57fb7a
Reviewed-on: https://review.typo3.org/55893
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Append pageId variable to string properly 73/55873/2
Andreas Fernandez [Fri, 23 Feb 2018 13:29:48 +0000 (14:29 +0100)]
[BUGFIX] Append pageId variable to string properly

Resolves: #84023
Releases: 8.7
Change-Id: I15c717b3087d18151a2a696e608ede481f7543f2
Reviewed-on: https://review.typo3.org/55873
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Add data attributes in backend toolbar and menu components 76/55876/2
Thomas Deuling [Mon, 27 Mar 2017 20:18:44 +0000 (22:18 +0200)]
[TASK] Add data attributes in backend toolbar and menu components

Add data attributes in backend toolbar and backend menu components,
to have general identifier for binding guided tours popover and
more features that can be based on this.

Resolves: #80500
Releases: master, 8.7
Change-Id: I2add8b8c28ecd37967b7b23f71392aa71f209da5
Reviewed-on: https://review.typo3.org/55876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Fix timestamp handling in QueryGenerator 77/55877/2
Reiner Teubner [Fri, 2 Feb 2018 13:55:36 +0000 (14:55 +0100)]
[BUGFIX] Fix timestamp handling in QueryGenerator

Since https://review.typo3.org/c/51242/ all hidden
FormEngine fields work with ISO dates but the
QueryGenerator can only handle unix timestamp.
This patch fix the query building process for
timestamp record fields.

Resolves: #83675
Releases: master, 8.7
Change-Id: I79227762c4159984612d86dea640bdfd8b3a2784
Reviewed-on: https://review.typo3.org/55877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Hide readonly elements in summary page and emails 37/55837/5
Ralf Zimmermann [Wed, 13 Sep 2017 10:51:37 +0000 (12:51 +0200)]
[BUGFIX] Hide readonly elements in summary page and emails

Hide readonly form elements within the summary page and emails.

Resolves: #82471
Releases: master, 8.7
Change-Id: I9c42754c935c0b2c62ff1a70f43e7a13d3594f82
Reviewed-on: https://review.typo3.org/55837
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] Don't download language packs of not loaded extensions 63/55863/2
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55863
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Tested-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Snychronize form framework documentation 61/55861/2
Björn Jacob [Thu, 22 Feb 2018 08:28:07 +0000 (09:28 +0100)]
[TASK] Snychronize form framework documentation

This patch synchronizes the documentation of the form framework
for TYPO3 v8.

Resolves: #83967
Releases: 8.7
Change-Id: I71770385f951b7c84ab54e19aecb246b71ba4ea3
Reviewed-on: https://review.typo3.org/55861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Rename /prototypes to /proto of form docs 51/55851/3
Björn Jacob [Wed, 21 Feb 2018 08:10:20 +0000 (09:10 +0100)]
[TASK] Rename /prototypes to /proto of form docs

The folder /prototypes of the form documentation is renamed to /proto.
This is a first step to synchronize the documentation of TYPO3 v8 and v9.

Resolves: #83988
Releases: 8.7
Change-Id: I6fa329a2d0971c89ef2c1416f07ff3fb284d30ef
Reviewed-on: https://review.typo3.org/55851
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Use sys_file as soft reference for formDefinitions 43/55843/2
Ralf Zimmermann [Tue, 20 Feb 2018 15:55:03 +0000 (16:55 +0100)]
[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Add placeholder to date picker form elements 41/55841/2
Ralf Zimmermann [Tue, 20 Feb 2018 17:20:01 +0000 (18:20 +0100)]
[BUGFIX] Add placeholder to date picker form elements

Add the possibility to define a placeholder html attribute for
date picker form elements.

Resolves: #82514
Releases: master, 8.7
Change-Id: I7bf272d4e1e9b0af1c15e6ceeb6e1b91afba327e
Reviewed-on: https://review.typo3.org/55841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
14 months ago[BUGFIX] Refactor record querying in deep nested structures in recycler 42/55842/2
Andreas Fernandez [Sat, 27 Jan 2018 23:14:11 +0000 (00:14 +0100)]
[BUGFIX] Refactor record querying in deep nested structures in recycler

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Resolves: #83702
Releases: master, 8.7
Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197
Reviewed-on: https://review.typo3.org/55842
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Fix miscellaneous palette in pages table 39/55839/2
Armin Vieweg [Tue, 20 Feb 2018 11:30:15 +0000 (12:30 +0100)]
[BUGFIX] Fix miscellaneous palette in pages table

Removed unnecessary locallang reference for field "editlock"
in showitem string. This field has been moved to access tab.

Resolves: #83974
Branches: master, 8.7
Change-Id: I85201f552a67badca420386bb615bcc571a712db
Reviewed-on: https://review.typo3.org/55839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] EXT:form - fix design glitches of new element modal 36/55836/2
Andreas Steiger [Tue, 20 Feb 2018 16:19:30 +0000 (17:19 +0100)]
[BUGFIX] EXT:form - fix design glitches of new element modal

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Resolves: #82444
Releases: master, 8.7
Change-Id: Ifceac76a70dd4744f52da3b08ca8baea5f4adb7d
Reviewed-on: https://review.typo3.org/55836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments 25/55825/2
Joerg Kummer [Fri, 16 Feb 2018 18:05:16 +0000 (19:05 +0100)]
[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments

Let 8.7 installtool upgrade wizard L10nModeUpdater ignore synchronization if parent entry of given translations is set to deleted

Resolves: #83940
Releases: master, 8.7
Change-Id: Ie240f71ecf42564c0547abd2dfa5c5efb23c6385
Reviewed-on: https://review.typo3.org/55825
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib" 21/55821/2
Ralf Zimmermann [Tue, 20 Feb 2018 06:50:42 +0000 (07:50 +0100)]
[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib"

Move folder typo3/sysext/form/Resources/Public/JavaScript/Backend/Vendor
to typo3/sysext/form/Resources/Public/JavaScript/Contrib.

Resolves: #83879
Releases: master, 8.7
Change-Id: I35cefa13bcfa621d4877273267d58ff4e26cd5bd
Reviewed-on: https://review.typo3.org/55821
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
14 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 10/55810/2
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/55810
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] Fix source collection for GIFBUILDER 17/55817/2
Marco Huber [Mon, 22 Aug 2016 11:49:34 +0000 (13:49 +0200)]
[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>