Packages/TYPO3.CMS.git
20 months ago[BUGFIX] Fix source collection for GIFBUILDER 37/49537/9
Marco Huber [Mon, 22 Aug 2016 11:49:34 +0000 (13:49 +0200)]
[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/49537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Possibility to set sessionTimeout for Frontend Users 54/50654/11
Alexander Opitz [Mon, 14 Nov 2016 15:54:50 +0000 (16:54 +0100)]
[FEATURE] Possibility to set sessionTimeout for Frontend Users

Currently it was only possible to set the session timeout for the backend users
You can define the sessionTimeout with the new configuration option
$GLOBALS['TYPO3_CONF_VARS']['FE']['sessionTimeout'].

Resolves: #78695
Releases: master
Change-Id: I628ccc4448230af6dd2bf1533777375ef7e5624d
Reviewed-on: https://review.typo3.org/50654
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Clarify description of FE|sessionDataLifetime 71/54871/3
Markus Klein [Wed, 29 Nov 2017 17:39:18 +0000 (18:39 +0100)]
[BUGFIX] Clarify description of FE|sessionDataLifetime

The FE|sessionDataLifetime option is solely used for anonymous
frontend sessions. It does not influence any other session(-data).
Document this clearly.

Resolves: #83168
Releases: master, 8.7
Change-Id: I8b16bc73c6d79b5bc6015b4448c6ec4604bdd780
Reviewed-on: https://review.typo3.org/54871
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Simplify the Clear temp file section in Install Tool 15/54215/4
Georg Ringer [Tue, 26 Sep 2017 05:41:52 +0000 (07:41 +0200)]
[TASK] Simplify the Clear temp file section in Install Tool

Hide the button for cleaning a directory if the directory is
empty.

Resolves: #82561
Releases: master
Change-Id: I06e76f79b1d814aa5a04a68be544a4c102d7392a
Reviewed-on: https://review.typo3.org/54215
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Install tool: Racy clear tables 69/54869/2
Christian Kuhn [Wed, 29 Nov 2017 17:06:54 +0000 (18:06 +0100)]
[BUGFIX] Install tool: Racy clear tables

JS ajax call to reload stats must be called after
clear table finished and not in parallel.

Change-Id: Ifdaa6f89eafe042b5c57b130e189001b1ca0a3fe
Resolves: #83166
Releases: master
Reviewed-on: https://review.typo3.org/54869
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[!!!][TASK] Migrate backend_layout.icon to FAL 30/54830/8
Benni Mack [Tue, 28 Nov 2017 11:57:38 +0000 (12:57 +0100)]
[!!!][TASK] Migrate backend_layout.icon to FAL

The last place in TYPO3 Core to use internal_type=file (backend_layout.icon)
is now moved to FAL with sys_file_reference.

An upgrade wizard is in place to migrate existing icons from uploads/media
to sys_file.

FormEngine is migrated to also allow to use sys_file_references for the
TCA ctrl property "selicon_field".

With this change, a followup could be integrated to deprecate "old-style"
internal_type=file code, and also to not create the uploads/ folder at all anymore
within TYPO3 installations.

Additionally, the functionality of "selicon_field_path" should be deprecated
in the future.

Resolves: #83153
Releases: master
Change-Id: I578fd68b7e1f7bc6a1991b90e7750b903d3ec28b
Reviewed-on: https://review.typo3.org/54830
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths 16/54416/7
Benjamin Franzke [Tue, 17 Oct 2017 14:53:28 +0000 (16:53 +0200)]
[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths

FLUIDTEMPLATE variables may contain content elements (e.g. recursive
FLUIDTEMPLATE's) which may instantiate own TemplateViews
(e.g. StandaloneView).
A recursive StandaloneView will statically(!!) cache used TemplatesPaths
in \TYPO3Fluid\Fluid\View\Templates::resolvedFiles.

If StandaloneView is instantiated before, but the fluid layout path is
calculated after inner content objects are being rendering,
the altered statically cached `resolvedFiles` cache is used
and contains invalid layoutRootPaths.

Short term solution:
Defer the initialization of the StandaloneView (which flushes those
buggy caches) until all variables have been processed.

Change-Id: Idf053b3d0f0835a352790e0ed971344d67844bbc
Releases: master, 8.7
Resolves: #79760
Resolves: #82745
Reviewed-on: https://review.typo3.org/54416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Use booleans where currently 1/0 are used 71/54671/6
Stefan Neufeind [Fri, 17 Nov 2017 09:26:42 +0000 (10:26 +0100)]
[TASK] Use booleans where currently 1/0 are used

Releases: master
Resolves: #83023
Change-Id: I9fe436f94a1223020b5fd0c308fa5bdb1b81ec39
Reviewed-on: https://review.typo3.org/54671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[!!!][TASK] Remove TYPO3.LLL usages in TYPO3 core 60/54860/7
Pawel Cieslik [Wed, 29 Nov 2017 12:03:54 +0000 (13:03 +0100)]
[!!!][TASK] Remove TYPO3.LLL usages in TYPO3 core

Remove TYPO3.LLL after moving to new JS API for translations TYPO3.lang

Resolves: #83161
Releases: master
Change-Id: I815b15349c8bfe6ca71f4d1ce59b7b01e670eae2
Reviewed-on: https://review.typo3.org/54860
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Apply correct button styles on EDITPANEL for pages 59/54859/2
Benjamin Kott [Wed, 29 Nov 2017 11:50:48 +0000 (12:50 +0100)]
[BUGFIX] Apply correct button styles on EDITPANEL for pages

Resolves: #83162
Releases: master, 8.7
Change-Id: I76bc60d9ac94eb1fe510bfe324cf49c0ed3bf896
Reviewed-on: https://review.typo3.org/54859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Use $pathsToProvideInTestInstance in functional import tests 62/54862/3
Oliver Hader [Wed, 29 Nov 2017 12:58:11 +0000 (13:58 +0100)]
[TASK] Use $pathsToProvideInTestInstance in functional import tests

$pathsToProvideInTestInstance offers the possibility to use real
duplicates instead of linked resources in the filesystem - especially
in scenarios when files shall be modified inside a testing instance this
is the better approach and avoid side-effects during test execution.

Resolves: #83163
Releases: master, 8.7
Change-Id: I5e5825d2f999401533afffdf9c6e8d83ac55c94e
Reviewed-on: https://review.typo3.org/54862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Ignore translations from other workspaces 30/53330/4
Markus Goldbach [Mon, 26 Jun 2017 11:42:17 +0000 (13:42 +0200)]
[BUGFIX] Ignore translations from other workspaces

Ignore translations of content elements (tt_content) which are created in
other workspace, so it is able to create a new/other translation in
another workspace even inside the live workspace

Change-Id: Ifef673b8677ae81f238068ed3a0bfdd1ca8e7932
Resolves: #81691
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] URL validator for Extbase 92/52092/15
Roland Golla [Sun, 19 Mar 2017 14:42:39 +0000 (15:42 +0100)]
[FEATURE] URL validator for Extbase

Add a new Extbase validator to check if a value is a valid URL.

Change-Id: Ic4ce6ee0f8a38f082e869c094ae6013493d7fb96
Resolves: #80342
Releases: master
Reviewed-on: https://review.typo3.org/52092
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] Determine Chinese simplified Han "Accept-Language" header 56/51056/13
DavidsWONG [Thu, 29 Dec 2016 09:02:30 +0000 (10:02 +0100)]
[BUGFIX] Determine Chinese simplified Han "Accept-Language" header

Internet Explorer (IE11 & Edge) changed the submitted HTTP header
for "Accept-Language" from "zh-cn" to "zh-hans-cn". In order to
determine the Chinese language correctly, this value is added.

Releases: master, 8.7
Resolves: #81858
Change-Id: I477f88950313aa9bf0aeabbf6603bd15247a52ba
Reviewed-on: https://review.typo3.org/51056
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] System information: set error filter in link to log 05/48005/3
Felix Althaus [Tue, 3 May 2016 21:48:17 +0000 (23:48 +0200)]
[BUGFIX] System information: set error filter in link to log

The link in system information menu "We have found 2 errors.
Please check your system log" will now set the appropriate filter in log
to only show errors. Before this patch user‘s last filter state was
spawned. This could result in errors not even being displayed at all.

Resolves: #76009
Releases: master
Change-Id: Id90ac9950ff71cd1fb5db1724590cf939fc22823
Reviewed-on: https://review.typo3.org/48005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
20 months ago[FEATURE] Add support to native SQL time column type 50/52250/23
Eric Chavaillaz [Wed, 29 Mar 2017 14:47:42 +0000 (16:47 +0200)]
[FEATURE] Add support to native SQL time column type

This patch introduce a new key "time" to the TCA property
"dbType" to allow using native SQL time column type.

Resolves: #80557
Releases: master
Change-Id: Id03045ccf219a9a7e9d851b2f4501bed60ab4ea0
Reviewed-on: https://review.typo3.org/52250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section 48/54848/7
Benni Mack [Wed, 29 Nov 2017 09:22:17 +0000 (10:22 +0100)]
[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section

The main issue is that the core ships a TCA column without a config section.

If EXT:filemetadata is available, this is overridden, so no issue here.

Further steps are (not scope of this patch) would be a TCA migration checker
to ensure that all TCA columns have a config section.

Resolves: #73076
Related: #77619
Related: #83152
Releases: master, 8.7
Change-Id: I3454780f1122ee5f4ef2bd65b19a9699daa73f33
Reviewed-on: https://review.typo3.org/54848
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] Preview information should not conflict with frontend layout 53/54853/2
Benjamin Kott [Wed, 29 Nov 2017 11:05:02 +0000 (12:05 +0100)]
[BUGFIX] Preview information should not conflict with frontend layout

The preview information badge was reworked and now has a fixed
always visible position. Clicks on the preview badge are now prevended
and passed through to the underlaying/covered elements.

Resolves: #83158
Releases: master, 8.7
Change-Id: Ie71420e5185e42b850ac3bb11d8eb4edd26bb4ad
Reviewed-on: https://review.typo3.org/54853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Remove unused method isLocalizationEnabled 51/54851/2
Susanne Moog [Wed, 29 Nov 2017 10:53:52 +0000 (11:53 +0100)]
[TASK] Remove unused method isLocalizationEnabled

Change-Id: Ib7fd53d28dfd08ba8cc81b14e854812981db268f
Resolves: #83156
Releases: master
Reviewed-on: https://review.typo3.org/54851
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Prevent catchable error during workspace publishing 14/49614/4
Benni Mack [Wed, 29 Nov 2017 09:50:58 +0000 (10:50 +0100)]
[BUGFIX] Prevent catchable error during workspace publishing

When publishing a workspace, incorrect TCA might lead to a catchable
fatal error. This happened, when TCA for a field did not contain a
config-entry.

Resolves: #77619
Releases: master, 8.7, 7.6
Change-Id: I81a3b727320ee984908c964d0729551c4c264f8d
Reviewed-on: https://review.typo3.org/49614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Port TYPO3.LLL usages to TYPO3.lang 36/54836/3
Pawel Cieslik [Tue, 28 Nov 2017 16:23:17 +0000 (17:23 +0100)]
[TASK] Port TYPO3.LLL usages to TYPO3.lang

TYPO3 core uses new JS api for fetching language labels - TYPO3.lang.

Resolves: #83142
Releases: master
Change-Id: I690b667b27d1152556b147e7198260fae018c62b
Reviewed-on: https://review.typo3.org/54836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[BUGFIX] Allow to upload online media via file list 47/54847/4
Benni Mack [Wed, 29 Nov 2017 08:48:00 +0000 (09:48 +0100)]
[BUGFIX] Allow to upload online media via file list

It was not possible due to a form name mixup to add online media files
via the FileList in TYPO3 v9 anymore.

Related: #82436
Related: #81763
Resolves: #83151
Releases: master
Change-Id: Ica0ed049f685bf20b98f0a599adf61ec3874017a
Reviewed-on: https://review.typo3.org/54847
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Remove hard-coded l10n_parent fields for pages 64/54664/11
Benni Mack [Thu, 16 Nov 2017 14:08:42 +0000 (15:08 +0100)]
[TASK] Remove hard-coded l10n_parent fields for pages

Due to the change of the pages_language_overlay migration, a lot
of hard-coded "l10n_parent" and "sys_language_uid" fields for
pages have been introduced.

This should be changed into a common function in DataHandler
and the TCA option should be used instead.

Resolves: #83013
Releases: master
Change-Id: I43a33aac1015436109d1ca7b3ea200c78d2a2fb9
Reviewed-on: https://review.typo3.org/54664
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[!!!][TASK] Remove BE/fileExtensions/webspace 34/54634/11
Benni Mack [Tue, 14 Nov 2017 06:47:14 +0000 (07:47 +0100)]
[!!!][TASK] Remove BE/fileExtensions/webspace

The option $TYPO3_CONF_VARS[BE][fileExtensions][webspace][*]
is removed.

It was only used in some specific cases, whereas fileDenyPattern usage
is more consistently done and replaces this setting.

Resolves: #83081
Releases: master
Change-Id: I1327ad000c08d8619366c03838b01261f91fa945
Reviewed-on: https://review.typo3.org/54634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[!!!][TASK] Remove stdWrap options space, spaceBefore, spaceAfter 02/54802/6
Georg Ringer [Mon, 27 Nov 2017 19:24:41 +0000 (20:24 +0100)]
[!!!][TASK] Remove stdWrap options space, spaceBefore, spaceAfter

The stdWrap options 'space', 'spaceBefore', 'spaceAfter'
are rarely used and should be better done completely by CSS.

Resolves: #83123
Releases: master
Change-Id: Ic3ed819e64e84f57f77fde1ff72404b78fd74009
Reviewed-on: https://review.typo3.org/54802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Separately extract @validate annotations 38/54838/3
Alexander Schnitzler [Tue, 28 Nov 2017 18:01:10 +0000 (19:01 +0100)]
[TASK] Separately extract @validate annotations

Separately exctracting the @validate annotations
makes resolving these annotations more testable.

Also this allows to deprecate the usage of @validate
in favor of a doctrine annotation.

Releases: master
Resolves: #83143
Change-Id: I4dfd93b58e08cd5c458abebee36e82e9ce03ad47
Reviewed-on: https://review.typo3.org/54838
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Add missing delete button for Documentation 17/54817/12
Łukasz Uznański [Tue, 28 Nov 2017 09:22:28 +0000 (10:22 +0100)]
[TASK] Add missing delete button for Documentation

Add a  missing delete button within the Documentation module. Right now,
a user can't delete previously downloaded documentation.

Resolves: #80575
Releases: master, 8.7
Change-Id: I9077270c66ec225f1eb7a26e505da0d98d5f7f0e
Reviewed-on: https://review.typo3.org/54817
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Hint for 'Check for broken extensions' if install tool crashes 59/54559/5
Christian Kuhn [Tue, 28 Nov 2017 17:55:34 +0000 (18:55 +0100)]
[BUGFIX] Hint for 'Check for broken extensions' if install tool crashes

If the install tool crashes in cards that load ext_* files from extensions,
it currently clears html body and only renders a message "Something went wrong".

This will later become a recovery view which can analyze where and how the
error happened to show the user good option on how to resurrect the instance.

For now, the message is extended a bit linking to the "Upgrade" menu saying
one should use the "Check for broken extensions". This way - until a bigger
solution evolved - we at least have a link to click on, and the user does not
need to fiddle with the url bar of the browser. This is especially useful
in install tool standalone mode where the whole content including the left
main menu is currently substituted by the error message.

Change-Id: I8e1c450949d9f00f8c2e0e1e95a847979973c124
Resolves: #82922
Releases: master
Reviewed-on: https://review.typo3.org/54559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Disable column sys_file_reference.sorting 42/54342/12
Stephan Großberndt [Mon, 9 Oct 2017 16:48:39 +0000 (18:48 +0200)]
[BUGFIX] Disable column sys_file_reference.sorting

Disable the column sys_file_reference.sorting by its according TCA
definition as it is not useful and leads to severe performance issues
adding new references when there are already many references.

Releases: master, 8.7
Resolves: #80800
Change-Id: I7b34a1be7efe3cf4818b43919389d9c815e74ec6
Reviewed-on: https://review.typo3.org/54342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] UpgradeWizard check for utf8 is wrong 35/54835/2
Susanne Moog [Tue, 28 Nov 2017 16:06:36 +0000 (17:06 +0100)]
[BUGFIX] UpgradeWizard check for utf8 is wrong

The upgrade wizard checking for utf-8 sets a
variable called charsetOk which worked
differently on MySQL compared to other DBMS.

On MySQL it contained true if the charset was
not OK, in all other cases it was true if ok.

This is now consistently handled according to
the variable name.

Change-Id: Iee347b6c2469ad9a33e9bd4109d361dc337a63a0
Resolves: #83141
Releases: master
Reviewed-on: https://review.typo3.org/54835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] Add support for addQueryString to TypolinkViewHelper 98/54798/10
Sebastian Hofer [Mon, 27 Nov 2017 18:08:22 +0000 (19:08 +0100)]
[FEATURE] Add support for addQueryString to TypolinkViewHelper

This enables {Link,Uri}/TypoLinkViewHelper to support addQueryString,
addQueryString.method and addQueryString.exclude.

Resolves: #81358
Releases: master
Change-Id: I96f0a2035997513eced06ba543a718b164b9da63
Reviewed-on: https://review.typo3.org/54798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded 23/54823/9
Jonathan IROULIN [Tue, 28 Nov 2017 10:18:25 +0000 (11:18 +0100)]
[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded

Show a warning message during the installation process if
the PHP fileinfo extension is not loaded.
It only displays a warning because the fileinfo extension is just
a suggestions and not required.
The fileinfo extension is useful to extract file metadata.

Resolves: #78702
Releases: master, 8.7
Change-Id: Iea0fa087d96d5615056308b7b2fef082b9154a2d
Reviewed-on: https://review.typo3.org/54823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Streamline page translation localization modes for enableFields 51/54751/4
Benni Mack [Fri, 24 Nov 2017 22:12:54 +0000 (23:12 +0100)]
[BUGFIX] Streamline page translation localization modes for enableFields

During the migration of page translations from pages_language_overlay
some fields have been migrated to a localization mode.

hidden, starttime and endtime can currently not be configured on a
per language-basis, which was possible before.

The fields are now settable on a per-language basis.

Resolves: #83082
Releases: master
Change-Id: Ibd401c38f3f8f8dfaaab9e459e1df284ecb625ea
Reviewed-on: https://review.typo3.org/54751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months agoRevert "[BUGFIX] Fix language of placeholder for relations" 26/54826/4
Christian Kuhn [Tue, 28 Nov 2017 11:06:00 +0000 (12:06 +0100)]
Revert "[BUGFIX] Fix language of placeholder for relations"

This reverts commit 5be3ec134bf1186260e3172832e8c69dfd13913d.

Further issues popped up in the master patch.

Reverts: #75040
Releases: master
Change-Id: I8ed284060b9b8ef018f4097c772032e81e3e885b
Reviewed-on: https://review.typo3.org/54826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Also show port when trustedHosts pattern mismatches 21/54821/6
Oliver Thiele [Tue, 28 Nov 2017 09:34:17 +0000 (10:34 +0100)]
[BUGFIX] Also show port when trustedHosts pattern mismatches

Add the port information to the error message when the
trustedHostsPattern mismatches. This is important as
the SERVER_NAME may match, but the SERVER_PORT might be
different from the default ports.

Releases: master, 8.7
Resolves: #83133
Change-Id: I8a25cc0bd2c9578b611986cea4bb7f270dff927b
Reviewed-on: https://review.typo3.org/54821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[FOLLOWUP][BUGFIX] Check simplexml return type in ImageInfo 29/54829/2
Christian Kuhn [Tue, 28 Nov 2017 11:51:26 +0000 (12:51 +0100)]
[FOLLOWUP][BUGFIX] Check simplexml return type in ImageInfo

Fix unit test which fails on current master since last patch
set has been too long ago and no re-run was triggered after
subject class changed meanwhile.

Change-Id: Iade31ab04fff4a48bd87f3c0052a93ea54005109
Resolves: #79881
Releases: master
Reviewed-on: https://review.typo3.org/54829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Check simplexml return type in ImageInfo 35/51735/6
Tim Spiekerkötter [Fri, 17 Feb 2017 10:05:13 +0000 (11:05 +0100)]
[BUGFIX] Check simplexml return type in ImageInfo

According to the php documentation[1] simplexml_load_file may return
false on failure. We need to check for this before we call the
attributes method on the expected SimpleXMLElement.

[1] http://php.net/manual/en/function.simplexml-load-file.php

Resolves: #79881
Releases: master, 8.7
Change-Id: Ic84710ab56796e9aafc5a85c8e41d7b08a676e0c
Reviewed-on: https://review.typo3.org/51735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Properly escape "dropzone-target" selector in DragUploader.js 16/53416/8
Giannis Economou [Thu, 6 Jul 2017 11:20:21 +0000 (14:20 +0300)]
[BUGFIX] Properly escape "dropzone-target" selector in DragUploader.js

We properly escape some characters of "dropzone-target" data attribute,
since it is being used as a CSS selector to insert the dropzone in
our DOM. The "dropzone-target" might contain characters that have a
special meaning in CSS, like for example a dot. Especially the dot
is typical for cases like flexforms fields.

This allows drag and drop file uploads even on such cases (like for
example working drag and drop file uploads in DCE content elements).

Resolves: #81812
Releases: master, 8.7
Change-Id: Ib1f5b5063e390f08436fd3a51978842754b698ef
Reviewed-on: https://review.typo3.org/53416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Allow nested GET-parameters for config.linkVars 96/54496/6
Markus Klein [Sun, 29 Oct 2017 18:35:21 +0000 (19:35 +0100)]
[FEATURE] Allow nested GET-parameters for config.linkVars

Resolves: #22439
Releases: master
Change-Id: I013d455c2024caede7897551240a0c4fe5c6e1e1
Reviewed-on: https://review.typo3.org/54496
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Make `top.TYPO3.Storage` available again 04/54704/3
Andreas Fernandez [Mon, 20 Nov 2017 18:13:17 +0000 (19:13 +0100)]
[BUGFIX] Make `top.TYPO3.Storage` available again

`top.TYPO3.Storage` is now globally available again, it's not necessary to
load this module via RequireJS. Please keep in mind this module is
deprecated.

Resolves: #83049
Related: #82603
Releases: master
Change-Id: I72796f377063c683f024a223818a599edade5367
Reviewed-on: https://review.typo3.org/54704
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Disable edit of file metadata without translation 78/54778/5
Łukasz Uznański [Mon, 27 Nov 2017 10:15:00 +0000 (11:15 +0100)]
[BUGFIX] Disable edit of file metadata without translation

This avoids an error in case file metadata is edited through a file
reference and there is no file metadata translation for the current
language.

Resolves: #76262
Resolves: #82178
Releases: master, 8.7
Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f
Reviewed-on: https://review.typo3.org/54778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix language of placeholder for relations 22/54722/3
Nicole Cordes [Wed, 22 Nov 2017 11:28:37 +0000 (12:28 +0100)]
[BUGFIX] Fix language of placeholder for relations

When a parent record (e.g. tt_content) has inline relations
(e.g. sys_file_reference)and these relations show a placeholder
for records related to them (e.g. sys_file and sys_file_metadata)
then we need to pass the context of the language so that
the placeholders are shown in the correct language.

We now do so by putting the value of the language field
of the parent record into the data set and update it
in case child records are also translatable.

This way when going down the list of children, we always
know the language id of the last applicable parent element,
even if one element in between was not translatable (e.g. sys_file)

If we know the language, we can pick the correct record uid
out of the list of possible related uids, instead of
just picking the last one.

Resolves: #75040
Releases: master, 8.7
Change-Id: Iff1b5350138d3043df470d2bdbdfebc83ec8cc5a
Reviewed-on: https://review.typo3.org/54722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[CLEANUP] Add missing rst changelog docs 16/54816/3
Markus Klein [Tue, 28 Nov 2017 08:58:47 +0000 (09:58 +0100)]
[CLEANUP] Add missing rst changelog docs

Add the rst files which have been added meanwhile in the 8.7 branch.

Resolves: #83130
Releases: master, 8.7
Change-Id: I9b552fcdda64a5a1a9a8c1d1e06d20d0ed43cad0
Reviewed-on: https://review.typo3.org/54816
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] Set correct HTTP header when page access is denied 95/54495/4
Markus Klein [Sun, 29 Oct 2017 17:37:52 +0000 (18:37 +0100)]
[BUGFIX] Set correct HTTP header when page access is denied

Accessing an existing page with insufficient permissions should
not set a 404 header but a 403 header.

Resolves: #23178
Releases: master, 8.7
Change-Id: I2470434f7600b28eaa613ee4e1669e78ceaaaec3
Reviewed-on: https://review.typo3.org/54495
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Use correct language file in element information popup 12/54812/2
Georg Ringer [Tue, 28 Nov 2017 06:59:17 +0000 (07:59 +0100)]
[BUGFIX] Use correct language file in element information popup

Use the correct language file which changed by accident during
the fluid transformation.

Resolves: #83126
Releases: master, 8.7
Change-Id: I9da27976ac3c72a5c1161adf605d10fbf422bf6e
Reviewed-on: https://review.typo3.org/54812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[FEATURE] Introduce scheduler task to execute console commands 04/54104/14
Alexander Schnitzler [Sun, 10 Sep 2017 15:17:08 +0000 (17:17 +0200)]
[FEATURE] Introduce scheduler task to execute console commands

This commit introduces a task that is similar to the extbase
task that can run command controllers via the scheduler.

Since TYPO3 8.7 LTS, a lot of command controllers have already
been migrated to symfony console commands, which is breaking
considering the fact that the command controllers could have
been registered as scheduler tasks.

Therefore TYPO3 needs a way to dispatch regular console commands
via the scheduler. This will be achieved by introducing a new
task provided by the scheduler extension which provides a safe
migration path for tx_scheduler records.

Resolves: #82390
Resolves: #79462
Releases: master
Change-Id: Ie488a3d46965a3dafbd649ab5d432ca14d09a25e
Reviewed-on: https://review.typo3.org/54104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[FEATURE] Replace @ignorevalidation with @Extbase\IgnoreValidation 62/54762/9
Alexander Schnitzler [Sat, 25 Nov 2017 15:25:02 +0000 (16:25 +0100)]
[FEATURE] Replace @ignorevalidation with @Extbase\IgnoreValidation

This patch introduces the "TYPO3\CMS\Extbase\Annotation\IgnoreValidation"
annotation that replaces the @ignorevalidation annotation which is
deprecated from now on.

Releases: master
Resolves: #83094
Change-Id: Ic8b05d754a9d5da3097b971780f1c229b06ac1c8
Reviewed-on: https://review.typo3.org/54762
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] IRRE actions should render error messages from DataHandler 59/54659/2
Benni Mack [Thu, 16 Nov 2017 11:05:03 +0000 (12:05 +0100)]
[BUGFIX] IRRE actions should render error messages from DataHandler

When IRRE actions (localize/synchronize) are triggered that result in a
DataHandler error (e.g. "Localization failed, "languageField" and
"transOrigPointerField" must be defined for the table") because of a missing
configuration, the current implementation does not evaluate DataHandler
results in the JSON response.

The change adds the same functionality as for other DataHandler calls
to evaluate the JSON response.

Resolves: #83011
Releases: master, 8.7
Change-Id: I7a2069b78cd9c3fa031b7ac194ae5b18596b6a3e
Reviewed-on: https://review.typo3.org/54659
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[BUGFIX] Validate page error handler result to report wrong configuration 94/54494/8
Markus Klein [Sun, 29 Oct 2017 17:05:15 +0000 (18:05 +0100)]
[BUGFIX] Validate page error handler result to report wrong configuration

Resolves: #50186
Releases: master, 8.7
Change-Id: I082a2d48608d43856cd60076852a19aec8a21a7e
Reviewed-on: https://review.typo3.org/54494
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Resolve translated page IDs to default language page in FE 70/54670/6
Benni Mack [Thu, 16 Nov 2017 21:26:52 +0000 (22:26 +0100)]
[TASK] Resolve translated page IDs to default language page in FE

Currently, when accessing a translated page ID via index.php?id=23,
the TypoScript cannot be resolved, as the GET parameter is no valid
page where records (e.g. sys_template etc).

In order to achieve this, the TYPO3 Frontend now resolves the $id
to the default page ID, but also sets $this->sys_language_uid and
$this->sys_language_content.

Resolves: #83017
Releases: master
Change-Id: I910909ce52c2efdb02717952d67e17d8897f4d17
Reviewed-on: https://review.typo3.org/54670
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] Correctly resolve dots inside flexform field names 36/51236/6
Christian Weiske [Tue, 10 Jan 2017 13:23:34 +0000 (14:23 +0100)]
[BUGFIX] Correctly resolve dots inside flexform field names

When a flexform field index attribute contained a dot, only
the last value was kept.
We now correctly append the new values to the existing ones now.

Change-Id: I73e541e834c143c33ba34f7e3f3ea7a22726b074
Resolves: #79245
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/51236
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Visual tweak of "SelectMultipleSideBySideElement" 30/54730/2
Gianluigi Martino [Mon, 20 Nov 2017 12:47:43 +0000 (13:47 +0100)]
[TASK] Visual tweak of "SelectMultipleSideBySideElement"

The position of the buttons aside the wizard are not correct.

Releases: master, 8.7
Resolves: #83072

Change-Id: Ib60a4015b6a51997ee56381ec63fea79605b16c1
Reviewed-on: https://review.typo3.org/54730
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Prepared statement contains too many placeholders 01/54801/3
Pawel Cieslik [Mon, 27 Nov 2017 19:06:31 +0000 (20:06 +0100)]
[BUGFIX] Prepared statement contains too many placeholders

Fix method findInStorageAndNotInUidList where $uidList
contains more then 65536 records in MySQL, 64000 in Oracle,
34464 in PostgreSQL by avoiding using prepared statements
and just passing values directly in query.

Resolves: #82233
Releases: master, 8.7
Change-Id: Ic72fa540936631274ae542d3c02128e159bd3fb1
Reviewed-on: https://review.typo3.org/54801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Only update fe_users.is_online if user is logged in 56/54756/3
Benni Mack [Fri, 24 Nov 2017 22:35:08 +0000 (23:35 +0100)]
[BUGFIX] Only update fe_users.is_online if user is logged in

The field is_online is updated in TSFE right after a user has authenticated,
but if the user has no usergroup, he/she is not logged in.

The update should be moved in the TSFE->fe_user and the check
should only be called when a logged-in user is found.

Resolves: #83086
Releases: master
Change-Id: I14b31662d99772b29e0e37153d44925b4309d69c
Reviewed-on: https://review.typo3.org/54756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] Redirect to the list after save&close in text file edit form 57/54757/4
Tymoteusz Motylewski [Fri, 24 Nov 2017 23:00:24 +0000 (00:00 +0100)]
[BUGFIX] Redirect to the list after save&close in text file edit form

Clicking on the Save & Close button in the FileList
text file editing form redirects back to the list view.

Releases: master
Resolves: #83090
Change-Id: I14576da7a77835232ca9573a8964f0d754f52aff
Reviewed-on: https://review.typo3.org/54757
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Switch isset() and is_array() to null coalesce 16/52416/13
Tymoteusz Motylewski [Mon, 20 Nov 2017 10:33:42 +0000 (11:33 +0100)]
[TASK] Switch isset() and is_array() to null coalesce

Several hundred function calls and vast numbers
of indentations can be saved by using the null
coalesce operator instead of checking empty/array.

Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a
Releases: master
Resolves: #80812
Reviewed-on: https://review.typo3.org/52416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Deprecate BE/FE delete clause methods 69/54769/5
Benni Mack [Mon, 27 Nov 2017 07:20:34 +0000 (08:20 +0100)]
[TASK] Deprecate BE/FE delete clause methods

Prior to Doctrine DBAL, all queries used the deleteClause for BE/FE
in various places, but this is gone, and this functionality is now handled
via TYPO3's Restrictions functionality within the new database API.

The left-over methods are deprecated and will be removed in TYPO3 v10.

Resolves: #83118
Releases: master
Change-Id: Iae35782b95ccd0ce180908f91de8c7430e4b83ae
Reviewed-on: https://review.typo3.org/54769
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Deprecate BackendUtility::getHash/storeHash 58/54758/4
Benni Mack [Fri, 24 Nov 2017 23:07:57 +0000 (00:07 +0100)]
[TASK] Deprecate BackendUtility::getHash/storeHash

The methods are only wrappers for the Caching framework, and come
from the time where the caching framework wasn't available.

Resolves: #83116
Releases: master
Change-Id: I6e3293f1bde654ee6548898742daa77d044d2107
Reviewed-on: https://review.typo3.org/54758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Deprecate DataHandler->newlog2() 96/54796/4
Benni Mack [Mon, 27 Nov 2017 17:14:37 +0000 (18:14 +0100)]
[TASK] Deprecate DataHandler->newlog2()

The "shorthand" method "newlog2()" is deprecated in favor of starting
to integrate a better logging API.

Resolves: #83121
Releases: master
Change-Id: Ieff947e021efb9547fd11d1c527dd072d443d6d8
Reviewed-on: https://review.typo3.org/54796
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Separation of search result path to title, uri, linkTag 49/54149/7
Joerg Boesche [Fri, 15 Sep 2017 13:34:53 +0000 (15:34 +0200)]
[FEATURE] Separation of search result path to title, uri, linkTag

For styling and individual html markup of the result of indexed_search
it is now possible to get the path information in separate keys.
Introduced keys: pathTitle, pathUri.

Resolves: #82260
Releases: master
Change-Id: Iacb0e155c36778a5f1d5ed96db55c35794f6d091
Reviewed-on: https://review.typo3.org/54149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Tested-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[BUGFIX] Colorpicker in irre records 31/54731/4
Frank Naegler [Thu, 23 Nov 2017 16:04:16 +0000 (17:04 +0100)]
[BUGFIX] Colorpicker in irre records

This patch checks if a value is set before writing
a possbile empty value to the field.

Resolves: #83000
Releases: master, 8.7
Change-Id: I3badd9b9ff1a567351d971b5ae0199bf347e0f72
Reviewed-on: https://review.typo3.org/54731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Changed logical operator. 10/53610/3
Gabriel Comte [Thu, 27 Jul 2017 08:34:33 +0000 (10:34 +0200)]
[BUGFIX] Changed logical operator.

As the Exception says: It is not allowed to have a section without a type
OR a type without a section. So it is not allowed to have one without the
other, but it's allowed to have both or none of them. --> This is a
EXCLUSIVE OR situation.

Releases: master
Resolves: #81985
Change-Id: I00594b75c99b02d1950be106dc4c3389709af231
Reviewed-on: https://review.typo3.org/53610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Use general functionality for fetching templates 53/54753/3
Benni Mack [Fri, 24 Nov 2017 22:27:52 +0000 (23:27 +0100)]
[TASK] Use general functionality for fetching templates

Some places in the TYPO3 Core can use the general coding functionality
to fetch absolute URLs, but "GeneralUtility::getFileAbsFileName" should
be used in these places.

Resolves: #83084
Releases: master
Change-Id: Ic723060b4b01eac51256d54e619a7770e0ad65fa
Reviewed-on: https://review.typo3.org/54753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Replace @cascade with @Extbase\ORM\Cascade 61/54761/4
Alexander Schnitzler [Sat, 25 Nov 2017 13:57:05 +0000 (14:57 +0100)]
[FEATURE] Replace @cascade with @Extbase\ORM\Cascade

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Cascade"
annotation that replaces the @cascade annotation which is
deprecated from now on.

Releases: master
Resolves: #83093
Change-Id: I1637d69b8bed0cdf85c009b43c3afd45ee7d29ff
Reviewed-on: https://review.typo3.org/54761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Send correct Cache-Control header if no client side caching 88/54788/5
Łukasz Uznański [Mon, 27 Nov 2017 12:20:45 +0000 (13:20 +0100)]
[BUGFIX] Send correct Cache-Control header if no client side caching

Add 'Cache-Control: no-store' if conditions allowing client caching
are not met. This change will prevent caching content by browser.

Resolves: #81160
Releases: master, 8.7, 7.6
Change-Id: Ia91a339178b8cd8387706679bbea40ed0d1b0548
Reviewed-on: https://review.typo3.org/54788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] fix missing l18n fields in blog tag table 86/54786/9
Sebastian Hofer [Mon, 27 Nov 2017 11:47:11 +0000 (12:47 +0100)]
[BUGFIX] fix missing l18n fields in blog tag table

The field l18n_parent was missing in table
tx_blogexample_domain_model_tag, but configured in TCA.
This causes an exception with adding a new tag in BE.
Also the field l18n_diffsource was missing in TCA and database.

* Add the fields l18n_parent and l18_diffsource to
  the databse table tx_blogexample_domain_model_tag
* Add TCA configuration for field l18n_diffsource to
  tx_blogexample_domain_model_tag TCA

Also add missing icon and label for
tx_blogexample_domain_model_dateexample.

Remove "allow tables on standard pages". This is not
necessary.

Fixes: #83113
Releases: master, 8.7
Change-Id: I10f809cc4b00df07c6e5a064bb89018578f3abf3
Reviewed-on: https://review.typo3.org/54786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Move llXmlAutoFileName() into AbstractXmlParser 52/54752/3
Benni Mack [Fri, 24 Nov 2017 22:24:48 +0000 (23:24 +0100)]
[TASK] Move llXmlAutoFileName() into AbstractXmlParser

The global function in GeneralUtility is moved into the AbstractXmlParser.

Resolves: #83083
Releases: master
Change-Id: If4caa3c6253f994e572e5fe36bcb791e1aec2599
Reviewed-on: https://review.typo3.org/54752
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Replace @transient with @Extbase\ORM\Transient 60/54760/5
Alexander Schnitzler [Sat, 25 Nov 2017 13:13:29 +0000 (14:13 +0100)]
[FEATURE] Replace @transient with @Extbase\ORM\Transient

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Transient"
annotation that replaces the @transient annotation which is
deprecated from now on.

Releases: master
Resolves: #83092
Change-Id: Ib678b5e1b9d0c3034962b9c708d84b0a3c6b0671
Reviewed-on: https://review.typo3.org/54760
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] Replace @lazy with @Extbase\ORM\Lazy 47/54747/6
Alexander Schnitzler [Fri, 24 Nov 2017 12:38:51 +0000 (13:38 +0100)]
[FEATURE] Replace @lazy with @Extbase\ORM\Lazy

This patch introduces the "TYPO3\CMS\Extbase\Annotation\ORM\Lazy"
annotation that replaces the @lazy annotation which is
deprecated from now on.

Releases: master
Resolves: #83078
Change-Id: Ic90ee3acf220288824d506c8ed63979e1236e583
Reviewed-on: https://review.typo3.org/54747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[BUGFIX] Use config.extTarget for menu links to external URLs 54/54754/3
Benni Mack [Fri, 24 Nov 2017 22:28:50 +0000 (23:28 +0100)]
[BUGFIX] Use config.extTarget for menu links to external URLs

Resolves: #78151
Releases: master
Change-Id: I65356a01f76d1c693a45e4ba84884f6ad01cdf65
Reviewed-on: https://review.typo3.org/54754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
20 months ago[TASK] Use proper PHPdoc type annotations in Extbase error layer 82/54782/2
Oliver Hader [Mon, 27 Nov 2017 10:58:17 +0000 (11:58 +0100)]
[TASK] Use proper PHPdoc type annotations in Extbase error layer

Resolves: #83111
Releases: master, 8.7
Change-Id: Ifde44802b9cf120f1a6ba3490022ccda1458e00d
Reviewed-on: https://review.typo3.org/54782
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonathan IROULIN <joniroutypo3@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL 36/54436/3
Stephan Großberndt [Wed, 18 Oct 2017 14:01:26 +0000 (16:01 +0200)]
[BUGFIX] Fix editing a FileStorage from FileTree on PostgreSQL

Avoid a SQL error on PostgreSQL when editing a FileStorage from FileTree
by passing the UID instead of a combined identifier like '1:/' to
EditDocumentController. Additionally fix the possibility for an SQL
error in BackendUtility::getRecord() by casting the UID.

Releases: master, 8.7
Resolves: #82799
Change-Id: I5cfde8b53767da1166ebd5f778e36ca85825a173
Reviewed-on: https://review.typo3.org/54436
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Use @DoctrineAnnotation ruleset for php-cs-fixer 80/54780/2
Alexander Schnitzler [Mon, 27 Nov 2017 10:36:48 +0000 (11:36 +0100)]
[TASK] Use @DoctrineAnnotation ruleset for php-cs-fixer

As doctrine annotations have been introduced in the core
the ruleset for proper formatting should be enabled.

Releases: master
Resolves: #83110
Change-Id: I3269fb04f4c28c066615060f98cd54290e3b5b46
Reviewed-on: https://review.typo3.org/54780
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[TASK] Ensure introduction package is properly installed 38/54038/9
Andreas Fernandez [Fri, 8 Sep 2017 18:59:28 +0000 (20:59 +0200)]
[TASK] Ensure introduction package is properly installed

Resolves: #83108
Releases: master, 8.7
Change-Id: I72d30fdab6ea3cc72078d5cf50b38915ff388fa2
Reviewed-on: https://review.typo3.org/54038
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[CLEANUP] Alwas put null at the last position 79/54779/2
Alexander Schnitzler [Mon, 27 Nov 2017 10:25:34 +0000 (11:25 +0100)]
[CLEANUP] Alwas put null at the last position

This patch applies the phpdoc_types_order rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order

Releases: master, 8.7
Resolves: #83109
Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad
Reviewed-on: https://review.typo3.org/54779
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] bamboo: Label parsing 74/54774/3
Christian Kuhn [Mon, 27 Nov 2017 09:23:05 +0000 (10:23 +0100)]
[BUGFIX] bamboo: Label parsing

The bamboo test setup relies on a funny solution to determine the
gerrit patch id and patch set, used for reporting results back
to gerrit.

The regex based solution started behaving weird with latest
bamboo versions and is now quoted slightly differently to fix that.

Special thanks to atlassian support for being friendly, helpful,
quick and providing a working solution to our issue.

Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc
Resolves: #83107
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[CLEANUP] The correct case must be used for standard PHP types in phpdoc 70/54770/4
Alexander Schnitzler [Mon, 27 Nov 2017 08:10:31 +0000 (09:10 +0100)]
[CLEANUP] The correct case must be used for standard PHP types in phpdoc

This patch applies the phpdoc_types rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types

Releases: master, 8.7
Resolves: #83106
Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770
Reviewed-on: https://review.typo3.org/54770
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[BUGFIX] Add missing initialization of GraphicalFunctions 17/54717/5
Joschi Kuphal [Wed, 22 Nov 2017 09:53:06 +0000 (10:53 +0100)]
[BUGFIX] Add missing initialization of GraphicalFunctions

Add missing initialization of the GraphicalFunctions helper
during image processing.

Resolves: #83058
Releases: master, 8.7
Change-Id: Ic5552c573f866faf3dcb0e0bc11012d83c805033
Reviewed-on: https://review.typo3.org/54717
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[CLEANUP] Remove/Replace non-standard phpdoc annotations 68/54768/3
Alexander Schnitzler [Sun, 26 Nov 2017 16:41:42 +0000 (17:41 +0100)]
[CLEANUP] Remove/Replace non-standard phpdoc annotations

Over the years many different non-standard phpdoc anotations
made it into that core which will now break the AnnotationReader
of doctrine. Therefore either all these annotations need to be
ignored or removed/replaced.

As it is easier to actually solve the issues instead of hiding them
this patch removes or replaces most non-standard annotations and
configures to ignore some of them like @extensionScannerIgnoreFile
and @extensionScannerIgnoreLine which are introduced by TYPO3 but
cannot be replaced as they provide a decent functionality

Releases: master
Resolves: #83103
Change-Id: Iba8f39600fe7273dd560592cef40ad56f83a5e73
Reviewed-on: https://review.typo3.org/54768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs 02/54602/13
Frank Naegler [Thu, 9 Nov 2017 14:02:47 +0000 (15:02 +0100)]
[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs

Because of the broken dependency manager logic in NPM this patch introduce
yarn as dependency manager for node modules.
Also this patch downgrade some libs, which was updated accidentally in past.

To install node modules you have to install yarn first and call
`yarn install`, do not use `yarn update` until you really want
update a dependency.

Resolves: #83038
Releases: master, 8.7
Change-Id: I842636241d76b88f2b9e3836230fdb6629d22fc3
Reviewed-on: https://review.typo3.org/54602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
20 months ago[BUGFIX] Don't show “cut” and “cut release” at the same time 32/54732/4
Frank Naegler [Thu, 23 Nov 2017 16:13:35 +0000 (17:13 +0100)]
[BUGFIX] Don't show “cut” and “cut release” at the same time

This patchs prevents showing “cut” and “cut release” at the same time in
the clickmenu of the page tree.

Resolves: #81890
Releases: master, 8.7
Change-Id: Ibfc07efec0f2064ffc9885047fce246cd935d368
Reviewed-on: https://review.typo3.org/54732
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
20 months ago[FEATURE] Exclude doktypes in path of search result 71/53671/3
Jörg Bösche [Thu, 10 Aug 2017 11:32:20 +0000 (13:32 +0200)]
[FEATURE] Exclude doktypes in path of search result

The search result has a path with the pagetree structure.
It must be possible to exclude doktypes from the path.

Releases: master
Resolves: #82070
Change-Id: I15d6bb0765aa237ab86cb75e6ffff0c26d8f504d
Reviewed-on: https://review.typo3.org/53671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
20 months ago[TASK] EXT:Scheduler: Extract HTML markup from "editAction" into Fluid 62/50962/11
Michael Oehlhof [Wed, 14 Dec 2016 22:19:44 +0000 (23:19 +0100)]
[TASK] EXT:Scheduler: Extract HTML markup from "editAction" into Fluid

Resolves: #68683
Releases: master
Change-Id: I5bb4327b685d18b6575137f166d18d9640662af2
Reviewed-on: https://review.typo3.org/50962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
20 months ago[BUGFIX] Use correct runtime cache identifier for locked records 26/54726/4
Benni Mack [Wed, 22 Nov 2017 22:44:52 +0000 (23:44 +0100)]
[BUGFIX] Use correct runtime cache identifier for locked records

The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.

A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.

Related: #79345
Resolves: #83068
Releases: master, 8.7
Change-Id: Id422fbc81b145db3559c194774334692863b4699
Reviewed-on: https://review.typo3.org/54726
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[!!!][TASK] Remove fixed year 2038 in FormEngine validation JavaScript 88/54488/8
Frank Naegler [Fri, 27 Oct 2017 15:59:47 +0000 (17:59 +0200)]
[!!!][TASK] Remove fixed year 2038 in FormEngine validation JavaScript

This patch removes the fixed year 2038 from the validation.
The validation has been simplified.

Resolves: #81973
Releases: master
Change-Id: If5577b1ce59c8a0310e6a63a8e1ac14dd8944387
Reviewed-on: https://review.typo3.org/54488
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
20 months ago[TASK] Migrate EXT:backend Login.js and UserPassLogin.js to TypeScript 71/54371/9
Frank Naegler [Wed, 11 Oct 2017 22:05:42 +0000 (00:05 +0200)]
[TASK] Migrate EXT:backend Login.js and UserPassLogin.js to TypeScript

Resolves: #82594
Resolves: #82608
Releases: master
Change-Id: Ibc3fce2983d5a193db17d8acc1c4dab2baee31db
Reviewed-on: https://review.typo3.org/54371
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
20 months ago[TASK] Optimize FormEngineValidation, Part II 92/48192/8
Andreas Fernandez [Wed, 30 Mar 2016 13:12:08 +0000 (15:12 +0200)]
[TASK] Optimize FormEngineValidation, Part II

Some functions inside FormEngineValidation are optimized to reduce
runtime or run multiple validations on fields that are already
marked as "failed".

Resolves: #81053
Releases: master
Change-Id: I751d5e99df2b58c14f629c84b305ec49bcc0d411
Reviewed-on: https://review.typo3.org/48192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
20 months ago[BUGFIX] Fix broken back button in EXT:form 16/54716/4
Frank Naegler [Tue, 21 Nov 2017 13:04:27 +0000 (14:04 +0100)]
[BUGFIX] Fix broken back button in EXT:form

This patch fix a regression, introduced with #82668

Resolves: #83057
Related: #82668
Releases: master, 8.7
Change-Id: I421be116be6696c52733a77a94a61f81c84864f4
Reviewed-on: https://review.typo3.org/54716
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Felix Nagel <info@felixnagel.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[BUGFIX] Make category tree filterable for editors with category mounts 41/54141/6
Christoph Lehmann [Wed, 13 Sep 2017 21:34:45 +0000 (23:34 +0200)]
[BUGFIX] Make category tree filterable for editors with category mounts

TCEFORM.pages.categories.config.treeConfig.rootUid should filter
the category tree. Non-Admin users with category mounts currently
need every child category of rootUid in their category mounts
since the rootline of rootUid is not checked against the category
mounts.

Resolves: #78274
Releases: master, 8.7
Change-Id: Id02ae69111df7397207939a034ed05797eb160ad
Reviewed-on: https://review.typo3.org/54141
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
20 months ago[BUGFIX] Page tree nodes can be (un)mounted again 06/54706/2
Andreas Fernandez [Mon, 20 Nov 2017 18:55:06 +0000 (19:55 +0100)]
[BUGFIX] Page tree nodes can be (un)mounted again

(Un)mounting nodes in the page tree is now possible again by fixing calls
to the page tree objects.

Resolves: #83051
Releases: master, 8.7
Change-Id: I978308e301b712fa75d677337d790e4895dc997a
Reviewed-on: https://review.typo3.org/54706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Use `Storage/Persistent` in page tree 05/54705/4
Andreas Fernandez [Mon, 20 Nov 2017 18:15:54 +0000 (19:15 +0100)]
[BUGFIX] Use `Storage/Persistent` in page tree

There is a left over usage of `top.TYPO3.Storage` in the ExtJS based
page tree. This usage is replaced with the `Storage/Persistent` module.

Resolves: #83050
Related: #82603
Releases: master
Change-Id: I68a33d257599f316eb8e169121ec8408397748e8
Reviewed-on: https://review.typo3.org/54705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE 15/54715/2
Stefan Neufeind [Tue, 21 Nov 2017 12:05:42 +0000 (13:05 +0100)]
[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE

Add for/id so clicking the label toggles the checkbox.

Resolves: #83040
Releases: master, 8.7, 7.6
Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326
Reviewed-on: https://review.typo3.org/54715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
20 months ago[BUGFIX] Use correct argument name in PageViewHelper 19/54719/2
Georg Ringer [Wed, 22 Nov 2017 06:55:12 +0000 (07:55 +0100)]
[BUGFIX] Use correct argument name in PageViewHelper

Fix a variable name which has been changed with the latest
refactoring to make it possible again to set links without
a cHash.

Resolves: #83063
Releases: master
Change-Id: I684d42f85a94179f19dabef5df47f09ce6b34df8
Reviewed-on: https://review.typo3.org/54719
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Fix thrown \InvalidArgumentException in access module 13/54713/2
Andreas Fernandez [Tue, 21 Nov 2017 07:10:55 +0000 (08:10 +0100)]
[BUGFIX] Fix thrown \InvalidArgumentException in access module

The returnUrl is not available if the access module is accessed via
context menu of the page tree. The module now checks whether the
returnUrl is available and renders the close button only in such case.

Resolves: #83053
Releases: master, 8.7
Change-Id: I37c5c65c1505b42acf7ac734fbc7a9f53629a6a1
Reviewed-on: https://review.typo3.org/54713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] GIFBUILDER files cannot be delivered via web server 77/54677/2
Oliver Hader [Fri, 17 Nov 2017 13:53:10 +0000 (14:53 +0100)]
[BUGFIX] GIFBUILDER files cannot be delivered via web server

GIFBUILDER uses provided file names and text snippets in order to
generate the final name for files to be written to. In case text
snippets start with a dot, this is also reflected into the file
name - preventing some web servers to deliver the file since it's
considered to be internal.

Resolves: #83029
Releases: master, 8.7
Change-Id: Iebed832c1c2429c7400373a6af4d5ae14a9ea18e
Reviewed-on: https://review.typo3.org/54677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] Reload page tree if `extendToSubpages` flag changes 09/54709/2
Andreas Fernandez [Mon, 20 Nov 2017 19:28:05 +0000 (20:28 +0100)]
[BUGFIX] Reload page tree if `extendToSubpages` flag changes

Resolves: #83052
Releases: master, 8.7
Change-Id: I9d86c38f8d1749583e154bd52c77b168d20af7dc
Reviewed-on: https://review.typo3.org/54709
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] Prevent javascript error in backend 94/54694/4
Markus Günther [Mon, 20 Nov 2017 08:18:27 +0000 (09:18 +0100)]
[BUGFIX] Prevent javascript error in backend

Adding a condition to check if a backend user has permissions on the
search to prevent a JS error while initializing the autocomplete module.

Fixes: #82969
Releases: master, 8.7, 7.6
Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6
Reviewed-on: https://review.typo3.org/54694
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
21 months ago[BUGFIX] Catch Exception while extracting metadata 34/53834/5
rickymk [Tue, 29 Aug 2017 11:18:10 +0000 (16:48 +0530)]
[BUGFIX] Catch Exception while extracting metadata

Catch InsufficientFileAccessPermissionsException while extracting
metadata. Reason for this exception could be that the file extension is
not allowed by the ['BE']['fileDenyPattern'] setting.

This patch makes sure that the indexer doesn't break and is able to
extract the other files from storage.

Resolves: #82060
Release: master, 8.7, 7.6
Change-Id: I37950aa70f4f59b388c6b9203e1922708ad07b71
Reviewed-on: https://review.typo3.org/53834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ricky Mathew <ricky.mk@pitsolutions.com>
Tested-by: Ricky Mathew <ricky.mk@pitsolutions.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Fix sorting extensions in "Get Extensions" module 99/54699/3
Nicole Cordes [Mon, 20 Nov 2017 14:33:53 +0000 (15:33 +0100)]
[BUGFIX] Fix sorting extensions in "Get Extensions" module

During some Doctrine cleanup the constraint for fetching extension by
extension key got messed up. This patch removes double named parameter
in search constraint.

Resolves: #80555
Releases: master, 8.7
Change-Id: I84636b4a86d8b3946c552031e3cb23ae69cd3f2a
Reviewed-on: https://review.typo3.org/54699
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Fix notices in Filelist module 51/54651/4
Tymoteusz Motylewski [Thu, 16 Nov 2017 12:01:20 +0000 (13:01 +0100)]
[BUGFIX] Fix notices in Filelist module

Resolves: #83002
Releases: master
Change-Id: I06c09f282df7fdcc0d8af11d65c5113f33a9c849
Reviewed-on: https://review.typo3.org/54651
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>