Packages/TYPO3.CMS.git
21 months ago[BUGFIX] Element Browser should only render default language pages 36/55536/2
Benni Mack [Sat, 3 Feb 2018 19:57:43 +0000 (20:57 +0100)]
[BUGFIX] Element Browser should only render default language pages

The Browseable Trees (Element Browser) show pages with
language > 0 (page translations), due to a missing fix
during the pages_language_overlay refactoring.

The patch adds the restriction on deleted pages
and sys_language_uid=0 pages, just like PageTreeView
and the new page tree do it.

Resolves: #83764
Releases: master
Change-Id: I90d76a37a0ee146ea549adcbb3aeff027fe42d26
Reviewed-on: https://review.typo3.org/55536
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] D3.js uses basic authentication credentials cached in browser 34/55534/2
Tymoteusz Motylewski [Fri, 2 Feb 2018 16:15:57 +0000 (17:15 +0100)]
[BUGFIX] D3.js uses basic authentication credentials cached in browser

Chrome 64 changed the behaviour regarding xhr.open() calls when passing
null values as password and username.
The d3.js file is manually patched.
Once PR https://github.com/d3/d3-request/pull/34/files is merged we can
use official d3.js version again.

Resolves: #83741
Releases: master, 8.7
Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125
Reviewed-on: https://review.typo3.org/55534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Require "fluid" for "fluid_styled_content" 31/55531/5
Thomas Löffler [Fri, 2 Feb 2018 10:04:56 +0000 (11:04 +0100)]
[TASK] Require "fluid" for "fluid_styled_content"

When requiring fluid_styled_content in an extension
by composer, the extension fluid should be required and
installed, too.

Releases: master
Resolves: #83756
Change-Id: I1cdd00e842e4b0918db0746ccdf58bb871b8790c
Reviewed-on: https://review.typo3.org/55531
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Apply proper button class to BE Layout Modal 32/55532/2
Mathias Schreiber [Fri, 2 Feb 2018 12:42:29 +0000 (13:42 +0100)]
[BUGFIX] Apply proper button class to BE Layout Modal

The modal “OK” button of the BE layout column assignment now sports the correct color
for the button.

Resolves: #83662
Releases: master
Change-Id: I13587241f5f79a555ef7edab6071d1d3f0265ad0
Reviewed-on: https://review.typo3.org/55532
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[TASK] Ensure HTTP RequestHandlers always return a PSR-7 Repsonse 98/55498/10
Benjamin Franzke [Wed, 24 Jan 2018 21:25:52 +0000 (22:25 +0100)]
[TASK] Ensure HTTP RequestHandlers always return a PSR-7 Repsonse

This is in preparation for PSR-15 middleware support which
will require PSR-7 RespnseInterface return type declarations
for request handlers.

As TSFE powers a concept of outputting nothing [see isOutputting()]
we need to add NullResponse (which implements the PSR-7 ResponseInterface)
which Core/Bootstrap can detect, to stop invoking header() and echo.

Change-Id: Ie3169a4365a85d0472523138cc73bb47cbbcb70f
Releases: master
Resolves: #83724
Reviewed-on: https://review.typo3.org/55498
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Fix "Select & upload files" button for FAL in flexform 16/55516/6
Armin Vieweg [Thu, 1 Feb 2018 09:20:15 +0000 (10:20 +0100)]
[BUGFIX] Fix "Select & upload files" button for FAL in flexform

Fix regular expression in escapeCssSelector method, to convert
e.g. "." to "\.".

Resolves: #83747
Branches: master, 8.7
Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954
Reviewed-on: https://review.typo3.org/55516
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js 17/55517/4
Frank Naegler [Thu, 1 Feb 2018 10:32:01 +0000 (11:32 +0100)]
[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js

This patch removes the uglify task of jquery-ui/sortable.js.
With https://review.typo3.org/#/c/55389/ the lib was patched
and already uglified. This patch prevents a double uglify of the file.

Resolves: #83593
Releases: master, 8.7
Change-Id: I16edd94fc8d3165159b4dc0a47ac7365ff34e37f
Reviewed-on: https://review.typo3.org/55517
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[TASK] Set TYPO3 version to 9.2.0-dev 05/55505/5
Oliver Hader [Tue, 30 Jan 2018 15:33:03 +0000 (16:33 +0100)]
[TASK] Set TYPO3 version to 9.2.0-dev

Change-Id: I221d472b3bd9ac035221cb804601740cf77847b0
Reviewed-on: https://review.typo3.org/55505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[RELEASE] Release of TYPO3 9.1.0 04/55504/2 v9.1.0
Oliver Hader [Tue, 30 Jan 2018 15:30:49 +0000 (16:30 +0100)]
[RELEASE] Release of TYPO3 9.1.0

Change-Id: I8ebeca67eb5524682846a2fb7d55ee8bbde1a318
Reviewed-on: https://review.typo3.org/55504
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA 00/55500/3
Stephan Großberndt [Tue, 30 Jan 2018 11:12:43 +0000 (12:12 +0100)]
[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA

By casting the JavaScript variable to string this patch avoids an error
if 'eval' => 'int,nospace' is used in a TCA column definition.

Resolves: #83731
Releases: master, 8.7
Change-Id: I5be79bf6cd748ac184505f0aa4bd97c7d934eebd
Reviewed-on: https://review.typo3.org/55500
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[BUGFIX] Fix example code for TCA "fieldControl" 01/55501/2
Stephan Großberndt [Tue, 30 Jan 2018 14:22:13 +0000 (15:22 +0100)]
[BUGFIX] Fix example code for TCA "fieldControl"

Resolves: #83732
Releases: master, 8.7
Change-Id: I7dccb42445dba584ed1c9a814f62525335d26ab1
Reviewed-on: https://review.typo3.org/55501
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
21 months ago[BUGFIX] EXT:filelist Canceling the file exists already modal works now 18/55418/3
Michael Oehlhof [Sun, 21 Jan 2018 01:49:04 +0000 (02:49 +0100)]
[BUGFIX] EXT:filelist Canceling the file exists already modal works now

When renaming a file with the name of an existing file a modal is shown.
Pressing the cancel button no longer renames the file with an unique name.

Resolves: #83624
Releases: master
Change-Id: I9963f6ce0b476f63043056d74e38af251ea0cd3e
Reviewed-on: https://review.typo3.org/55418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
21 months ago[DOCS] 1/1 9.1 Documentation 65/55465/8
Mathias Schreiber [Fri, 26 Jan 2018 19:58:59 +0000 (20:58 +0100)]
[DOCS] 1/1 9.1 Documentation

Proofread documentation for CMS 9.1.

Two rst snippets remain in Changelog/master in order to ease a scheduled
revert by @helhum.

Resolves: #83700
Releases: master
Change-Id: Iebf3db03bd95a6f20b0b786e9776fc84b77d6e3b
Reviewed-on: https://review.typo3.org/55465
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months agoRevert "[FEATURE] EXT:form - introduce YAML "imports"" 22/55422/5
Helmut Hummel [Sun, 21 Jan 2018 17:40:15 +0000 (18:40 +0100)]
Revert "[FEATURE] EXT:form - introduce YAML "imports""

While the intended feature is great (having the possiblity
to extract and re-use parts of the form definition),
implementation wise it needs some rework.

To be able to release 9.1 as stable as possible,
we now revert this implementation for now
and bring it in for 9.2 again.

This reverts commit a52a99220ca24251186ea88d11b3db43436a8156.

Reverts: #82089
Resolves: #83729
Releases: master
Change-Id: I850401d232b642e712801613d3780816f873966a
Reviewed-on: https://review.typo3.org/55422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[FEATURE] Option to globally enable redirect hit count 97/55497/2
Susanne Moog [Mon, 29 Jan 2018 19:15:27 +0000 (20:15 +0100)]
[FEATURE] Option to globally enable redirect hit count

Most websites probably use custom analytics for page
hit statistics or are not interested in the count of
hits on a redirect. Therefor the redirect hit count
has been disabled by default. The option to enable
the hit count globally via LocalConfiguration has been
added.

Change-Id: I71c57784d8c6e0f17c81b1f899aa43e91d37cd76
Resolves: #83677
Releases: master
Reviewed-on: https://review.typo3.org/55497
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Improved extension configuration API 34/55434/10
Christian Kuhn [Tue, 23 Jan 2018 12:42:43 +0000 (13:42 +0100)]
[TASK] Improved extension configuration API

The patch implements feedback from the new
ExtensionConfiguration API.
get() now falls back to a parsing of ext_conf_template,
so the parser is moved from the install tool
to the ext:core class. This prevents a chicken-egg
issue in early setup phases.

The move of the synchronize* methods forces a raise
of the testing-framework:

composer require --dev typo3/testing-framework ^2.0.3

Change-Id: I9a6700fc66fe78d9df09038a89ea95f8dba81031
Resolves: #83666
Releases: master
Reviewed-on: https://review.typo3.org/55434
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] NewContentElementWizardController to NewContentElementController 79/55479/6
Oliver Hader [Sun, 28 Jan 2018 22:38:22 +0000 (23:38 +0100)]
[BUGFIX] NewContentElementWizardController to NewContentElementController

NewContentElementWizardController, which has been introduced for TYPO3 v9
to render the new content element process in a dedicated modal was just a
duplicate of the existing NewContentElementController class with some
minor adjustments and code flow enhancements (names, empty checks).

However, there have been several side effects like:
* hook implementing NewContentElementWizardHookInterface would have been
  called by both object instances, having different public properties -
  the most common access to $parentObject->id or ~->sys_language would
  have failed to to property visibility and change names
* the JavaScript closure callback to adjust the URL when interacting in
  the browser was hard-coded to modal rendering, with still having the
  possibility to render the old behavior e.g. in the web>list view

To overcome these flaws both mentioned classes have been merged since the
functionality was not that much different anyway. Besides that different
JavaScript client scopes ('window' or 'list_frame') are forwarded to the
according object instances.

Resolves: #83705
Releases: master
Change-Id: I472a7ec8a5d06c05e6c7053bf98b5cfacb69f9d9
Reviewed-on: https://review.typo3.org/55479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Invalid session token on creating content element in admin panel 88/55488/2
Oliver Hader [Mon, 29 Jan 2018 15:29:33 +0000 (16:29 +0100)]
[BUGFIX] Invalid session token on creating content element in admin panel

When creating a new content element in the frontend using the according
button in the "editing" section of the admin panel, the request to the
TYPO3 backend is rejected due to an invalid XSRF session token:

Validating the security token of this form has failed.
Please reload the form and submit it again.

The reason is, that the URL after issue #70055 looks like the following
"token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became
part of the XSRF session token.

Resolves: #83719
Releases: master, 8.7, 7.6
Change-Id: Ibdd252b2e59d9e8de78bb0be14a95e0789dc0d17
Reviewed-on: https://review.typo3.org/55488
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Correct example in redirects feature documentation 91/55491/2
Benjamin Kott [Mon, 29 Jan 2018 17:17:55 +0000 (18:17 +0100)]
[BUGFIX] Correct example in redirects feature documentation

Resolves: #83723
Releases: master
Change-Id: I010796bd056e6c70d21010ef649f127c4d006a21
Reviewed-on: https://review.typo3.org/55491
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Properly check `serialized_executions` to avoid warnings with PHP 7.2 74/55474/5
Georg Ringer [Sun, 28 Jan 2018 11:42:17 +0000 (12:42 +0100)]
[BUGFIX] Properly check `serialized_executions` to avoid warnings with PHP 7.2

To avoid warnings with PHP 7.2, `serialized_executions` must be checked
for being not an empty value.

Resolves: #83691
Releases: master, 8.7, 7.6
Change-Id: I5855a03d6669ec0e82931cfc0110c2b7ca134ad4
Reviewed-on: https://review.typo3.org/55474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] EXT:filelist Fixed exception when creating new text file 19/55419/2
Michael Oehlhof [Sun, 21 Jan 2018 11:50:51 +0000 (12:50 +0100)]
[BUGFIX] EXT:filelist Fixed exception when creating new text file

The exception does not occur with the LocalDriver.
For testing use the driver mentioned in the forge issue.

Resolves: #83627
Releases: master, 8.7
Change-Id: Iae5fef2cc1ca704998975aba4fb6f5e48aeec4b1
Reviewed-on: https://review.typo3.org/55419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Change documentation of [BE][interfaces] 78/55478/2
Susanne Moog [Sun, 28 Jan 2018 18:14:04 +0000 (19:14 +0100)]
[BUGFIX] Change documentation of [BE][interfaces]

The order of the options given is irrelevant as
they will always be rendered in the same order.

The documentation was updated to reflect that fact.

Change-Id: I409e8a26a3b1186a12761cbb84a4f6afe94b464b
Resolves: #82431
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55478
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
21 months ago[BUGFIX] Add preview icon in overview and link to record edit 81/55481/2
Frank Naegler [Mon, 29 Jan 2018 09:26:29 +0000 (10:26 +0100)]
[BUGFIX] Add preview icon in overview and link to record edit

In the overview table of the redirects module the source path now links
to edit record view (like everywhere in the backend) and a new preview icon
is now available in case the source path is not a RegExp.

Resolves: #83709
Related: #83708
Releases: master
Change-Id: Ie92e434f675a5f66e5e779e0d739d75a0a774caa
Reviewed-on: https://review.typo3.org/55481
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[TASK] Show language mode in Page module 64/55464/8
Mathias Schreiber [Fri, 26 Jan 2018 18:43:23 +0000 (19:43 +0100)]
[TASK] Show language mode in Page module

Editors can now immediately see whether a page is in Free, Connected or
Mixed mode in a certain language.

Resolves: #83696
Releases: master, 8.7
Change-Id: I2985c2094e83535df636fa124aea962aa7ca105d
Reviewed-on: https://review.typo3.org/55464
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
21 months ago[BUGFIX] Use fallback for source link in wildcard redirects 55/55455/9
Jigal van Hemert [Thu, 25 Jan 2018 11:45:38 +0000 (12:45 +0100)]
[BUGFIX] Use fallback for source link in wildcard redirects

If a wildcard source host is used in a redirect record the link in
the list of redirects the view domain for the first page in the
page tree is used now.

Resolves: #83658
Releases: master
Change-Id: Id7d64711c359ad744639ebd7159581ad606bf097
Reviewed-on: https://review.typo3.org/55455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[TASK] Make ext:redirect part of factory default 70/55470/2
Christian Kuhn [Sat, 27 Jan 2018 13:24:06 +0000 (14:24 +0100)]
[TASK] Make ext:redirect part of factory default

The extension is now loaded by default when installing
the system.

Change-Id: I9bd887b3e4d8779c2591ddec171de627899fd073
Resolves: #83701
Releases: master
Reviewed-on: https://review.typo3.org/55470
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] Add renderType to redirect target statuscode field 62/55462/3
Mathias Brodala [Fri, 26 Jan 2018 14:58:39 +0000 (15:58 +0100)]
[BUGFIX] Add renderType to redirect target statuscode field

Change-Id: I029e0a9e3522adde7c35a82349ecd15c595848d7
Resolves: #83692
Releases: master
Reviewed-on: https://review.typo3.org/55462
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] Fix incomplete validation of source_host field 67/55467/3
Frank Naegler [Fri, 26 Jan 2018 21:50:52 +0000 (22:50 +0100)]
[BUGFIX] Fix incomplete validation of source_host field

This patch complete the validation of source_host field and
add some tests for the server side validation.
Also a client side validation / manipulation is added.

Resolves: #83659
Releases: master
Change-Id: I5117bd353d116f1366ca779c37ba868fec9f34c8
Reviewed-on: https://review.typo3.org/55467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[BUGFIX] Catch DatabaseRecordException when editing record with deleted relation 97/55197/8
Andreas Fernandez [Fri, 22 Dec 2017 10:35:05 +0000 (11:35 +0100)]
[BUGFIX] Catch DatabaseRecordException when editing record with deleted relation

Editing a record with a deleted related record leads to an uncaught
DatabaseRecordException. This patch catches the exception and
ignores such records, but logs a warning.

Due to possible errors occurring with certain DBMS (e.g. MySQL
strict) columns may require a default value now in TCA.

Resolves: #83412
Releases: master, 8.7
Change-Id: I5adaf385443350ce245dd83da6e5f1a16d9c9afb
Reviewed-on: https://review.typo3.org/55197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] use horizontal ellipsis instead of 3 dots 63/55463/2
Daniel Ruf [Fri, 26 Jan 2018 18:32:55 +0000 (19:32 +0100)]
[TASK] use horizontal ellipsis instead of 3 dots

Releases: master
Resolves: #83697
Change-Id: I6f7217f8a479298249a92ff43eb650638077d8e5
Reviewed-on: https://review.typo3.org/55463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[BUGFIX] Only reference existing locallang files 66/55466/3
Daniel Goerz [Fri, 26 Jan 2018 21:36:30 +0000 (22:36 +0100)]
[BUGFIX] Only reference existing locallang files

Resolves: #83698
Releases: master, 8.7
Change-Id: I7bfe3c32c5fec6e7098462dcbe0353afd9258900
Reviewed-on: https://review.typo3.org/55466
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
21 months ago[TASK] Timebased redirects shown correctly 42/55442/9
Reiner Teubner [Wed, 24 Jan 2018 10:08:02 +0000 (11:08 +0100)]
[TASK] Timebased redirects shown correctly

When a timebased redirect is not active now a
sheduled-end icon with additional information
is displayed.

Resolves: #83663
Releases: master
Change-Id: I345364ec9a83c8af317ac2cafe2e7a70d570a159
Reviewed-on: https://review.typo3.org/55442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Remove validation for field source_path 60/55460/2
Frank Naegler [Fri, 26 Jan 2018 14:38:19 +0000 (15:38 +0100)]
[BUGFIX] Remove validation for field source_path

This patch removes the validation of the source_path field.
It is not possible to validate the input because a RegExp is
allowed for this field which can’t be validated with this checks.

Resolves: #83660
Releases: master
Change-Id: I9420997ba35e3fc312ad2eb4b0a439d56e7b2fe7
Reviewed-on: https://review.typo3.org/55460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Use SVG icons in EXT:redirects 56/55456/2
Jigal van Hemert [Thu, 25 Jan 2018 15:01:35 +0000 (16:01 +0100)]
[TASK] Use SVG icons in EXT:redirects

The module icon is in SVG format with a background color from
the TYPO3 icon set. A similar icon for the record type has been
added too. The old PNG icons were removed.
In a future clean-up of the TYPO3 icon set these will be added to the
collection.

Resolves: #83653
Releases: master
Change-Id: Iec1a8b0344b91c43e501efa4deea9584ddf8b561
Reviewed-on: https://review.typo3.org/55456
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Fix system maintainer checkbox size 58/55458/2
Mathias Brodala [Fri, 26 Jan 2018 13:24:17 +0000 (14:24 +0100)]
[BUGFIX] Fix system maintainer checkbox size

Change-Id: Ibdd234c7f6c32c5edb9af25ea5e5e74ef91feb57
Resolves: #83690
Releases: master
Reviewed-on: https://review.typo3.org/55458
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Set correct PHPDoc hint for addPageTSConfig and addUserTSConfig 57/55457/3
Frans Saris [Fri, 26 Jan 2018 09:02:46 +0000 (10:02 +0100)]
[BUGFIX] Set correct PHPDoc hint for addPageTSConfig and addUserTSConfig

Resolves: #83687
Releases: master, 8.7
Change-Id: Ifa705340bc0523e914c688eea00dbb2812bbedd0
Reviewed-on: https://review.typo3.org/55457
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Show and hide arrow correctly in page tree 37/55437/2
Manuel Selbach [Tue, 23 Jan 2018 14:22:56 +0000 (15:22 +0100)]
[BUGFIX] Show and hide arrow correctly in page tree

This will set the attribute "visibility" to the correct value "visible"
or "hidden" instead of "collapse" so the arrow icon of the page tree
acts accordingly in all browsers.

Resolves: #83585
Releases: master
Change-Id: I17b8705ed9f7e0f0ac966294572ede5c9a151857
Reviewed-on: https://review.typo3.org/55437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[BUGFIX] Add language parameter to preview url in list module 41/52341/9
Gianluigi Martino [Mon, 3 Apr 2017 14:18:22 +0000 (16:18 +0200)]
[BUGFIX] Add language parameter to preview url in list module

The language parameter was not set if the "View webpage" button was used
within the context menu of an element in the page module or the
"View webpage" button in the record list of a desired language.

Resolves: #80599
Releases: master, 8.7
Change-Id: I40fb5749cbd56c0075a8aa2c5ec3b2d8dea66501
Reviewed-on: https://review.typo3.org/52341
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[TASK] Display ApacheThreadStackSize message correctly during installation 98/55198/3
Gianluigi Martino [Fri, 22 Dec 2017 12:25:16 +0000 (13:25 +0100)]
[TASK] Display ApacheThreadStackSize message correctly during installation

With this patch the html chars inside the
"ApacheThreadStackSize" flashmessage during the installation are displayed
correctly

Resolves: #83413
Releases: master
Change-Id: If49ea5cd96ca8c0ef005e7a23b917b44149a88cd
Reviewed-on: https://review.typo3.org/55198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Migrate getPagesTSconfig to runtime cache 33/54133/10
Stefan Froemken [Wed, 13 Sep 2017 12:11:14 +0000 (14:11 +0200)]
[TASK] Migrate getPagesTSconfig to runtime cache

BackendUtility::getPagesTSconfig() uses local
method static properties as cache.
This prevents dedicated flushing, which may
be needed in rare cases to prevent for instance
from exceeded memory during huge imports.
The patch switches that to cache framework
cache_runtime which is already used at other
places within BackendUtility.

Resolves: #82473
Related: #63629
Releases: master, 8.7
Change-Id: I4d54819f05a6c7b8ce175bc827b626277e2d4c04
Reviewed-on: https://review.typo3.org/54133
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Hide redirect table header when no records exist 43/55443/8
Reiner Teubner [Wed, 24 Jan 2018 10:37:20 +0000 (11:37 +0100)]
[TASK] Hide redirect table header when no records exist

Resolves: #83661
Release: master
Change-Id: I8a7307986896fa2d68b5013d1defc235eff1d3e4
Reviewed-on: https://review.typo3.org/55443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Use correct default value for field data_page_reg1 28/55428/2
Georg Ringer [Tue, 23 Jan 2018 04:22:48 +0000 (05:22 +0100)]
[BUGFIX] Use correct default value for field data_page_reg1

The field data_page_reg1 of table index_phash is defined as integer.
Therefore the default value must be 0 instead of an empty string.

Resolves: #83641
Releases: master, 8.7, 7.6
Change-Id: I4c1f115b8c8bbcb961627d7f5a5a413a8d5cf419
Reviewed-on: https://review.typo3.org/55428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Use … instead of dots for a correct typography 41/55441/2
Georg Ringer [Wed, 24 Jan 2018 09:37:11 +0000 (10:37 +0100)]
[TASK] Use … instead of dots for a correct typography

The correct typography is to use  the character "…"
instead of "...".

Resolves: #83614
Releases: master, 8.7
Change-Id: I151db0f1edb290d2a3aeff3236e1be1e9c19fa8a
Reviewed-on: https://review.typo3.org/55441
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] EXT:filelist Removed cut and copy buttons from "Extended view" 69/55369/2
Michael Oehlhof [Mon, 15 Jan 2018 23:06:32 +0000 (00:06 +0100)]
[BUGFIX] EXT:filelist Removed cut and copy buttons from "Extended view"

The cut and copy buttons were shown twice in filelist module.
Once in “Extended view” and once in “Show clipboard”

Resolves: #83575
Releases: master, 8.7
Change-Id: I8cbb9b516aaa1ff42a363d4daf4ffa7e20c9d461
Reviewed-on: https://review.typo3.org/55369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] EXT:form - set of additional unit tests 24/54024/18
Marcel Jürgen Falk [Fri, 8 Sep 2017 13:58:11 +0000 (15:58 +0200)]
[TASK] EXT:form - set of additional unit tests

Resolves: #82386
Releases: master
Change-Id: I40b83041149b8955b51c3a2c54d8690392356ae1
Reviewed-on: https://review.typo3.org/54024
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] EXT:redirects - Wrong variable name in phpdoc of class SourceHost 40/55440/6
Joerg Boesche [Wed, 24 Jan 2018 07:54:06 +0000 (08:54 +0100)]
[TASK] EXT:redirects - Wrong variable name in phpdoc of class SourceHost

- Resolves a wrong variable definition in phpdoc
- Adds type safe method parameter
- Adds return type string to method

Resolves: #83665
Releases: master
Change-Id: I0ed52e0b2086d6d006885964f480b3c99b7942e7
Reviewed-on: https://review.typo3.org/55440
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[BUGFIX] Process large uid lists in chunks in RelationHandler 93/53193/19
Sascha Egerer [Mon, 12 Jun 2017 14:57:33 +0000 (16:57 +0200)]
[BUGFIX] Process large uid lists in chunks in RelationHandler

Uid lists in the relation handler can be very big. To avoid exceeding
query limits like maximum number of placeholder per query or the max
allowed statement length these large lists are split into chunks of
safe length before processing.

Change-Id: I176acb85feb91c6162a77016c1918cf5a992625c
Resolves: #81555
References: #80875
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53193
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] Add drawHeaderHook to EXT:recordlist 23/55423/2
Georg Ringer [Mon, 22 Jan 2018 09:11:29 +0000 (10:11 +0100)]
[FEATURE] Add drawHeaderHook to EXT:recordlist

Add an additional hook to the EXT:recordlist which makes
it possible to add content above any other content.

Resolves: #61170
Releases: master
Change-Id: I2f6ad79cfb5ff19f57da63346735b743947ddf99
Reviewed-on: https://review.typo3.org/55423
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[TASK] Add LICENSE.txt to ext:redirects 38/55438/2
Christian Kuhn [Tue, 23 Jan 2018 17:18:32 +0000 (18:18 +0100)]
[TASK] Add LICENSE.txt to ext:redirects

Change-Id: I59846db22964a26f610a304fab85f570884b063d
Resolves: #83651
Releases: master
Reviewed-on: https://review.typo3.org/55438
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[TASK] Specific exception in ArrayUtility::removeByPath() 24/55424/3
Christian Kuhn [Mon, 22 Jan 2018 13:36:42 +0000 (14:36 +0100)]
[TASK] Specific exception in ArrayUtility::removeByPath()

Similar to getValueByPath(), removeByPath() now throws
a specific exception if the path to remove does not
exist in given array to avoid catching global \RuntimeException'
in consuming code.
The same "MissingArrayPathException" is used here since
both cases have identical semantic.

Change-Id: I69447c47d24e28110cf03929ea5ed28cf5e43024
Resolves: #83636
Related: #83615
Releases: master
Reviewed-on: https://review.typo3.org/55424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[!!!][TASK] Remove sys_domain redirect functionality 27/55427/5
Benni Mack [Mon, 22 Jan 2018 15:43:37 +0000 (16:43 +0100)]
[!!!][TASK] Remove sys_domain redirect functionality

The existing functionality of sys_domain database records that redirect to a
different target has been migrated into the new "redirects" core extension.

An upgrade wizard ensures that old (and even deleted) sys_domain records
with a redirect target (database field "redirectTo") are properly migrated into
the redirects extension.

The following database fields have been dropped:
- sys_domain.redirectTo
- sys_domain.redirectHttpStatusCode
- sys_domain.prepend_params

These values are not evaluated anymore in the TYPO3 Frontend.

Resolves: #83638
Releases: master
Change-Id: I0577a5bfb9db9e0b5d06b7c5f2d0c6f428c8a4ba
Reviewed-on: https://review.typo3.org/55427
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Set focus on the search input field in page tree 36/55436/2
Tymoteusz Motylewski [Tue, 23 Jan 2018 14:14:16 +0000 (15:14 +0100)]
[BUGFIX] Set focus on the search input field in page tree

After clicking on the filter button in the page tree,
the focus is set on the input field allowing to type
search word right away.

Resolves: #83535
Releases: master
Change-Id: I78c9b81e7c9e23efb4f9e8bf2d2a222a5e97436c
Reviewed-on: https://review.typo3.org/55436
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[FEATURE] Add system extension "redirects" 58/55358/50
Benni Mack [Sat, 13 Jan 2018 21:31:58 +0000 (22:31 +0100)]
[FEATURE] Add system extension "redirects"

A new system extension "redirects" is added, which ships a flexible
handling of HTTP redirects, useful both for marketeers and
site administrators.

It adds a new module called "Site Management => Redirects".

Site Management will be the starting point also for templating and
domain setups in the future.

A new DB table "sys_redirect" is added, which allows to configure
a redirect from a source (host+path) to a destination target.
The destination target can be any kind of Uri
(used by the LinkService).

In the short run, redirects superseeds the redirect logic from
sys_domain.redirectTo (see followup patch), but more features
are already sketched out, however, this change only
adds the basic functionality.

Any time a redirect is added or modified, a list
of all redirects is added to the cache management,
allowing to fetch all redirects at once,
reducing the number of queries to the DB in the
frontend to 1 query (or to one query to the FS, as
the power lies in the caching framework).

A simple hit statistics counter is implemented as well.

The redirects functionality later will serve
for URL Routing if a page will be registered under
a different URL, and a redirect could automatically be added.

Further improvements (out of scope for this change):
- Move icons into the TYPO3 iconset
- Check for recursive / loops, or existing redirects
- Add further conditions for redirects
- Export redirects as VCL, nginx or .htaccess rules for performance reasons
- Bulk import of redirects
- Selection of existing sys_domain redirects in source_
- Sanitize source_host to only include a domain name, and/or allow ports
- Allow query parameters in source_path

Resolves: #83631
Releases: master
Change-Id: Ibf25c2ee07f41edbaf14b97a7f115d36f901cc62
Reviewed-on: https://review.typo3.org/55358
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
21 months ago[BUGFIX] Show correct file reference information 58/55158/5
Nicole Cordes [Tue, 19 Dec 2017 10:15:48 +0000 (11:15 +0100)]
[BUGFIX] Show correct file reference information

This patch corrects how file references (from softrefs) are stored in
sys_refindex table as this was changed with patch
https://review.typo3.org/53219/.

Resolves: #81831
Related: #80991
Related: #80988
Releases: master, 8.7
Change-Id: I776d2db47dffd83217a3c5527860093ddbca58c6
Reviewed-on: https://review.typo3.org/55158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benjamin Kluge <b.kluge@neusta.de>
Tested-by: Benjamin Kluge <b.kluge@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
21 months ago[BUGFIX] Fix minor typos in ReST of #83637 29/55429/2
Andreas Fernandez [Tue, 23 Jan 2018 07:42:12 +0000 (08:42 +0100)]
[BUGFIX] Fix minor typos in ReST of #83637

Resolves: #83644
Related: #83637
Releases: master
Change-Id: Ifdee387950181b869c9dfa1df2644bd5b51e6ce0
Reviewed-on: https://review.typo3.org/55429
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[BUGFIX] Fresh tag in TypoScriptConstantsViewHelper per call 73/55273/5
steffenk [Fri, 5 Jan 2018 09:32:37 +0000 (10:32 +0100)]
[BUGFIX] Fresh tag in TypoScriptConstantsViewHelper per call

With current fluid, the TypoScriptConstantsViewHelper is
instantiated only once and re-used if called multiple times.
$this->tag is then polluted from previous runs and creates
funny results.
Fix by re-initializing that property each call.

Resolves: #83319
Releases: master
Change-Id: Idf9e14ca69e76278bd0d6eaca1fec9b93c238fd5
Reviewed-on: https://review.typo3.org/55273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] Execute hooks on backend user login 19/55319/7
Michael Schams [Fri, 19 Jan 2018 05:27:57 +0000 (16:27 +1100)]
[FEATURE] Execute hooks on backend user login

When a user successfully logs in to the backend of TYPO3, registered
hooks are executed. This allows for the development of further actions
such as notification services.

Resolves: #83529
Releases: master
Change-Id: I26b060463ae76075a4d40f25c8e695534fe69875
Reviewed-on: https://review.typo3.org/55319
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Schams <typo3@2018.schams.net>
Tested-by: Michael Schams <typo3@2018.schams.net>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] Add new main module "Site" 25/55425/3
Benni Mack [Mon, 22 Jan 2018 15:32:29 +0000 (16:32 +0100)]
[FEATURE] Add new main module "Site"

A new main module for the TYPO3 Backend is introduced, named "site",
which serves a main entry point for integrators and site admins to configure
the "Frontend" and the "How" of a TYPO3 website, and not the "what" (= content).

The site management module's purpose for now is to include Redirect Management,
but will be extended during v9 development to also contain Domain/Site/404
URL handling, TypoScript and Templating / Fluid configuration.

Resolves: #83637
Releases: master
Change-Id: I06c88d09fa16a40fa8c0f6176ed05f002629498c
Reviewed-on: https://review.typo3.org/55425
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Tested-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[TASK] Add getter for TemplateService->rootId 15/55415/3
Benni Mack [Sat, 20 Jan 2018 13:32:47 +0000 (14:32 +0100)]
[TASK] Add getter for TemplateService->rootId

The rootID holds the page ID where the root sys_template
record was found.

As this is crucial for some hooks this property
should be publically available but is marked as
deprecated during v9 development, a getter is added
to provide a public API.

Resolves: #83619
Releases: master
Change-Id: Ief651f2e2d758350f0620b3104dd47e0c06fa2f4
Reviewed-on: https://review.typo3.org/55415
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
21 months ago[BUGFIX] Install: Typo in category of extension configuration 16/55416/3
Michael Oehlhof [Sat, 20 Jan 2018 14:31:30 +0000 (15:31 +0100)]
[BUGFIX] Install: Typo in category of extension configuration

Resolves: #83620
Releases: master
Change-Id: I903207c22daa20312447c18d6b9ddd8f1cd61a5a
Reviewed-on: https://review.typo3.org/55416
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
21 months ago[BUGFIX] Extension config: Write LocalConfiguration only if needed 13/55413/3
Christian Kuhn [Fri, 19 Jan 2018 16:30:11 +0000 (17:30 +0100)]
[BUGFIX] Extension config: Write LocalConfiguration only if needed

The extension configuration is currently written by the
install tool silent updater each time the install tool
is entered, even if no configuration detail changed.
This is unfortunate on systems with read-only LocalConfiguration
since the install tool then throws an early fatal.
Prevent that write operation in case nothing changed.

Change-Id: I70d419690bcb633049ffcc9546e660d2f3b75a4c
Resolves: #83616
Releases: master
Reviewed-on: https://review.typo3.org/55413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[TASK] Specific exception in ArrayUtility::getValueByPath() 12/55412/9
Christian Kuhn [Fri, 19 Jan 2018 13:34:21 +0000 (14:34 +0100)]
[TASK] Specific exception in ArrayUtility::getValueByPath()

If ArrayUtility::getValueByPath() does not find a given
path in an array structure, it currently throws a generic
\RuntimeException. Checking the path is one of the key
components of the method and consuming code may not know
if the path exists at all, which is fine.

Throwing global \RuntimeException thus forces various
places to catch \RuntimeException which possibly
hides away programming errors and mis-uses.

The patch makes getValueByPath() throw a specific exception
if path does not exists. Catching that specific exception
reduces the number of global 'catch \RuntimeException'
significantly.

The patch also adds another catch in early install tool
to fix a not recoverable fatal if LocalConfiguration
'EXTENSIONS' array does not yet exist, for instance if
upgrading from v8 to v9.

Change-Id: If65b1b6ba2181b4cd7de2ce41776c0d78a5b513f
Resolves: #83615
Resolves: #83590
Releases: master
Reviewed-on: https://review.typo3.org/55412
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Minor annotation and sanitation improvements 11/55411/3
Christian Kuhn [Fri, 19 Jan 2018 10:13:15 +0000 (11:13 +0100)]
[TASK] Minor annotation and sanitation improvements

Various changes throughout the system improving
method annotations here and there or sanitizing
code a bit better.

Change-Id: Ieeee41ede160e301a59aa8a534ca26e3499a4fcd
Resolves: #83612
Releases: master
Reviewed-on: https://review.typo3.org/55411
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Reiner Teubner <reiner.teubner@me.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Improve documentation of forge issue #33071 10/55410/4
Riccardo De Contardi [Thu, 18 Jan 2018 21:17:11 +0000 (22:17 +0100)]
[TASK] Improve documentation of forge issue #33071

Some rewording on a .rst file and some additional information
to make more clear what is meant.

Releases: master
Resolves: #83610
Resolves: #69316
Related: #33071
Change-Id: Ie87ecb212f51158cb721a3133a49955096000ca3
Reviewed-on: https://review.typo3.org/55410
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[BUGFIX] Filter pages in page tree by uid 05/55405/3
Tymoteusz Motylewski [Thu, 18 Jan 2018 12:08:36 +0000 (13:08 +0100)]
[BUGFIX] Filter pages in page tree by uid

Brings back the possibility to filter pages by uid
in the new SVG page tree.

Resolves: #83245
Releases: master
Change-Id: Ideded401d222c812fd0fcab1892082d2bd63a7c6
Reviewed-on: https://review.typo3.org/55405
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] impexp: Remove size handling 91/55391/9
Christian Kuhn [Wed, 17 Jan 2018 23:55:50 +0000 (00:55 +0100)]
[TASK] impexp: Remove size handling

ext:impexp has a "size" display and adds size information
to export formats for records file sizes. This is entirely
removed with the patch - both from interface and .xml/.t3d
exports:

* The size handling on db records always made little sense,
  the default maximum size of 1MB was "never" hit, there
  wasn't even an input box to raise that limit, ever.
  This information is now just removed from the export formats.
* The size handling on files is rather irrelevant with FAL,
  since FAL file integrity is checked with sha1 already. The
  size display during export in the interface for FAL files
  never worked since FAL migration in core v6.0 - It always
  displayed 0. Nobody ever cared, there is not even a forge
  issue about that.
* Removing the 'size' column in the export interface - which
  only carried rather irrelevant information on record "size"
  only - simplifies the interface a bit.
* The record size information in exports depends on used
  dbms due to different internal database types. Removing that
  makes exports more dbms agnostic. This can be seen with
  all the functional test fixture file changes coming with
  the patch - removing that reduces a maintenance nightmare
  in this area and improves the chance to align exports
  in between the functional testes on different dbms again.

Note that exporting .xml/.t3d in v9 and importing it
in a v8 instance does not work anyway due to more
significant DB field related changes in v9 already.
The effects of this patch could be easily mitigated
on v8, but we were unable to create anything in v9 that
is able to be imported in v8 again - and ext:impexp
is not created to be an upgrade / download helper
in the first place. Thus, ignoring size checks in
v8 to mitigate effects of the file format change
does not seem to be necessary and is not done.

Change-Id: I0cae7b371b6ac027e27c9192ffa273dabc9795c7
Resolves: #83606
Releases: master
Reviewed-on: https://review.typo3.org/55391
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] impexp: Streamline position and layout of CSH 86/55386/6
Frank Naegler [Wed, 17 Jan 2018 18:54:26 +0000 (19:54 +0100)]
[TASK] impexp: Streamline position and layout of CSH

This patch streamlines the position and layout for the content help buttons
in ext:impexp. Like already done in FormEngine, the CSH now wraps
around field labels.

Resolves: #83602
Releases: master
Change-Id: Iccfdd8f26649176004a17967d7a05d6f76c6d021
Reviewed-on: https://review.typo3.org/55386
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Fix wrong position on sorting inline records 89/55389/2
Frank Naegler [Wed, 17 Jan 2018 21:17:02 +0000 (22:17 +0100)]
[BUGFIX] Fix wrong position on sorting inline records

This patch fix a wrong position of sortable elements in inline records.
This is a known issue which was never fixed in jquery-ui.
For this reason this patch aplly the changes to the sortable lib.

Resolves: #83593
Releases: master, 8.7
Change-Id: I5efeee6202b0b181f04e71538a5bc72b306cd02e
Reviewed-on: https://review.typo3.org/55389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Update composer.json license definition 04/55404/3
Oliver Hader [Thu, 18 Jan 2018 10:24:07 +0000 (11:24 +0100)]
[TASK] Update composer.json license definition

Composer license definition GPL-2.0+ has been deprecated
and has to be replaced with GPL-2.0-or-later.

Resolves: #83607
Releases: master, 8.7, 7.6, 6.2
Change-Id: I6113bc3a90cb6a56830b930522dde2eaacd5025e
Reviewed-on: https://review.typo3.org/55404
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
21 months ago[BUGFIX] Filelist list look alike list module 88/55388/2
Christian Kuhn [Wed, 17 Jan 2018 21:08:11 +0000 (22:08 +0100)]
[BUGFIX] Filelist list look alike list module

File list table needs a wrapper div to have borders
and shadows to look alike tables of the list module.

Change-Id: Id68f9b328c65e3d2dc59281a730bebd0430a179d
Resolves: #83604
Releases: master
Reviewed-on: https://review.typo3.org/55388
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Add more UnitTests for GeneralUtility::xml2array() 73/55373/8
Frank Naegler [Tue, 16 Jan 2018 13:13:29 +0000 (14:13 +0100)]
[TASK] Add more UnitTests for GeneralUtility::xml2array()

Resolves: #83578
Related: #83580
Releases: master
Change-Id: I2c97edd4bac854b33501ba571ed479bdefc288d7
Reviewed-on: https://review.typo3.org/55373
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[TASK] impexp: Remove "Max file size" restriction 82/55382/2
Christian Kuhn [Wed, 17 Jan 2018 13:56:12 +0000 (14:56 +0100)]
[TASK] impexp: Remove "Max file size" restriction

The export modules has a file size restriction
that skips file exports if they are bigger than
by default 1MB. This can be raised with an input
field.
The patch removes that input field:
* Configured maximum file sizes are checked during
  upload already. A well configured system should
  expect existing files are ok and just export everything
* The 1MB default size is old fashioned. Typical images
  are often bigger in size and resized only during FE
  rendering
* Skipping arbitrary files in export has a negative
  impact on data consistency of the export.
* Single files can still be excluded from export if
  needed
* Users up until now usually had manually raised the
  limit to some value high enough to make all files fit

Change-Id: Ib70dc48de44d215067474b4c3f6fff8988ab7712
Resolves: #83596
Releases: master
Reviewed-on: https://review.typo3.org/55382
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[BUGFIX] impexp: File upload in import broken 85/55385/2
Christian Kuhn [Wed, 17 Jan 2018 15:03:47 +0000 (16:03 +0100)]
[BUGFIX] impexp: File upload in import broken

Uploading import files broke with patch for issue #81763
Fix by renaming POST array back from 'data' to 'file'.

Change-Id: I8de880775e2949951ef8a3f45b0a704c2ef3ac76
Resolves: #83599
Related: #81763
Releases: master
Reviewed-on: https://review.typo3.org/55385
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
21 months ago[TASK] impexp: Use XML as default export format 83/55383/3
Christian Kuhn [Wed, 17 Jan 2018 14:22:51 +0000 (15:22 +0100)]
[TASK] impexp: Use XML as default export format

The TYPO3 specific .t3d export format is a funny binary format
and rather hard to read and decipher, even if not compressed.
The XML format is at least some easy to read text file instead
of a binary format and exists for quite some time in the system.
Use XML as default export format by just swapping the option
box entries.

Change-Id: I5b25d8dc0b33158e98d1aafba27ab7669edeb725
Resolves: #83597
Releases: master
Reviewed-on: https://review.typo3.org/55383
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
21 months ago[TASK] impexp: Remove 'max number of records' restriction 81/55381/3
Christian Kuhn [Wed, 17 Jan 2018 11:35:56 +0000 (12:35 +0100)]
[TASK] impexp: Remove 'max number of records' restriction

The 'export' module has a restriction to limit the number
of exported records. The patch removes this from the
interface:
* The default limit is arbitrary, removing that limit
  declutters the interface a little bit
* Users probably always did just set this to some number
  high enough to export everything they wanted
* It was not clear what exactly is counted. At least it
  was not the total number of exported records ...
* The error and flash messages were unclear and sometimes
  not shown at all
* The limit could lead to data integrity issues in the
  export file, for example if a page links to some other
  page that is not exported
* Presets that increased the limit still work
* To prevent a breaking patch, the affected PHP method
  arguments deprecate some arguments instead of fully
  removing them in v9

Change-Id: Iadb365ff2ccd77ed38cbde81b76e37990a0c6f17
Resolves: #83592
Releases: master
Reviewed-on: https://review.typo3.org/55381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[BUGFIX] Improve exception output for ImageService 70/55370/6
Georg Ringer [Tue, 16 Jan 2018 10:28:05 +0000 (11:28 +0100)]
[BUGFIX] Improve exception output for ImageService

Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the
image in ImageService->getImage() fails.

Resolves: #83570
Releases: master, 8.7, 7.6
Change-Id: Icc3c78f5b747842cee89d184134ff298b8e04a3a
Reviewed-on: https://review.typo3.org/55370
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mattia D <mattia.dorigatti@brandnamic.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Adjust response usage for `file/exists` route 71/55371/2
Andreas Fernandez [Tue, 16 Jan 2018 11:21:06 +0000 (12:21 +0100)]
[BUGFIX] Adjust response usage for `file/exists` route

With #83267 a JSON response object was introduced. The patch has the side
effect that any response is now an array but some usages in JavaScript
were not adjusted.

This patch does two things:

- `FileController::fileExistsInFolderAction()` does now either return an
  array for falsy results OR the file object.
- The JavaScript code is adjusted to check for a valid file object by
  requiring the `uid` property instead.

Resolves: #83568
Related: #83267
Releases: master
Change-Id: I9878f5f70b8af3ba8ec151a6ed514780547ec1ea
Reviewed-on: https://review.typo3.org/55371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[TASK] Make EXT:rsaauth no longer part of factory-configuration 63/55363/3
Stefan Neufeind [Mon, 15 Jan 2018 11:16:13 +0000 (12:16 +0100)]
[TASK] Make EXT:rsaauth no longer part of factory-configuration

Since the extension is deprecated, don't activate it by default
(factory-configuration).

Resolves: #81852
Releases: master
Change-Id: I10ecba6978daa16b43775a7adb28d723c8138ce0
Reviewed-on: https://review.typo3.org/55363
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
21 months ago[BUGFIX] impexp: Wrong FAL references after import 65/55365/6
Christian Kuhn [Mon, 15 Jan 2018 14:54:57 +0000 (15:54 +0100)]
[BUGFIX] impexp: Wrong FAL references after import

Fix a case during ext:impexp FAL uid mapping where
sys_file_reference end up pointing to wrong sys_file
records in case new sys_file uids also already exist
in import file, due to multiple mappings.
Power the patch with a functional test - it fails
without the change in Import.php and is ok with the
change.
See the test method comments for more details
on what exactly is checked here.

Change-Id: I472cad2652e8d6f5d30e4ebc68ff1ae93de71ea1
Resolves: #67188
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55365
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Mark EXT:rsaauth as deprecated 58/53458/10
Georg Ringer [Thu, 13 Jul 2017 09:56:13 +0000 (11:56 +0200)]
[TASK] Mark EXT:rsaauth as deprecated

Only https can really secure a connection. Therefore rsaauth
should be marked as deprecated. An additional report checks the
usage of the extension and https.

Resolves: #81852
Releases: master
Change-Id: I5d12e1e7c97d55869379228b39fa5e87b2287e88
Reviewed-on: https://review.typo3.org/53458
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
21 months ago[BUGFIX] GeneralUtility::copyDirectory() should mkdir_deep() destination dir 60/55360/3
Christian Kuhn [Sun, 14 Jan 2018 17:10:38 +0000 (18:10 +0100)]
[BUGFIX] GeneralUtility::copyDirectory() should mkdir_deep() destination dir

If path to the destination directory does not exist yet,
copyDirectory() does not copy anything. Use mkdir_deep() for directories.

As example, have directory 'typo3temp' and call copyDirectory()
with a destination 'typo3temp/foo/bar', where 'foo' does not
exist, yet. Without patch, this operation fails.

Change-Id: Id8eb5d6cd30c288ca073e98d35a3025c8489c182
Resolves: #83564
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55360
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[FEATURE] EXT:form - make FinisherVariableProvider iterable 08/55308/4
Ralf Zimmermann [Tue, 9 Jan 2018 14:52:32 +0000 (15:52 +0100)]
[FEATURE] EXT:form - make FinisherVariableProvider iterable

Makes it possible to iterate through FinisherVariableProvider items.

Resolves: #83396
Releases: master
Change-Id: I0b778b9a6d4ede4d2df8190d6b4821903caee6a4
Reviewed-on: https://review.typo3.org/55308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Use @TYPO3\CMS\Extbase\Annotation\Inject in core extensions 14/55314/4
Alexander Schnitzler [Tue, 9 Jan 2018 20:05:01 +0000 (21:05 +0100)]
[TASK] Use @TYPO3\CMS\Extbase\Annotation\Inject in core extensions

Releases: master
Resolves: #83522
Change-Id: Ie1f9db6e3180c1d32e3d8b99e37ff88669ede86d
Reviewed-on: https://review.typo3.org/55314
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Use @TYPO3\CMS\Extbase\Annotation\ORM\Cascade in core extensions 13/55313/4
Alexander Schnitzler [Tue, 9 Jan 2018 19:55:39 +0000 (20:55 +0100)]
[TASK] Use @TYPO3\CMS\Extbase\Annotation\ORM\Cascade in core extensions

Releases: master
Resolves: #83521
Change-Id: I8bd477ccf2ae6fca478b758cf61654a1bec388cd
Reviewed-on: https://review.typo3.org/55313
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
21 months ago[TASK] Use @TYPO3\CMS\Extbase\Annotation\ORM\Lazy in core extensions 12/55312/4
Alexander Schnitzler [Tue, 9 Jan 2018 19:46:33 +0000 (20:46 +0100)]
[TASK] Use @TYPO3\CMS\Extbase\Annotation\ORM\Lazy in core extensions

Releases: master
Resolves: #83520
Change-Id: Idd10aa62692198f7aa20af1492fb9670149d5ac9
Reviewed-on: https://review.typo3.org/55312
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Ensure PackageManager scans every possible directory 56/55356/2
Nicole Cordes [Sat, 13 Jan 2018 21:08:44 +0000 (22:08 +0100)]
[BUGFIX] Ensure PackageManager scans every possible directory

If a scanAvailablePackages() of the PackageManager is triggered, we
need to make sure all possible packagesBasePaths are taken into account.
As new extensions might have been downloaded, we need to re-check those
possible paths unless all were found.

Resolves: #83560
Releases: master, 8.7
Change-Id: I4a65a2f384163b6a3cc3071711e80d88eaf22971
Reviewed-on: https://review.typo3.org/55356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
22 months ago[BUGFIX] Return correct available package information 26/55326/3
Nicole Cordes [Wed, 10 Jan 2018 16:40:39 +0000 (17:40 +0100)]
[BUGFIX] Return correct available package information

The PackageManager needs to scan over all package location to be able
to decide whether a package is available or not.

Resolves: #83531
Releases: master, 8.7
Change-Id: Ib21c18a559b4c02d8efce146c8d5addf66b25f1f
Reviewed-on: https://review.typo3.org/55326
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Enable deletion of translated sys_file_metadata records 40/55340/4
Wolfgang Klinger [Fri, 12 Jan 2018 10:57:24 +0000 (11:57 +0100)]
[BUGFIX] Enable deletion of translated sys_file_metadata records

UserTS disableDelete was set for sys_file_metadata globally
and therefore also prevented the deletion of translated file metadata.
By preventing deletion of sys_file_metadata records only for default
language records, the user can remove translated ones again at will.

Resolves: #83066
Relates: #71678
Releases: master, 8.7
Change-Id: I3b83a3dd63b02b94bdd34dd8f002436af14ad45d
Reviewed-on: https://review.typo3.org/55340
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Update extension scanner docs.typo3.org link 53/55353/2
Christian Kuhn [Sat, 13 Jan 2018 18:08:06 +0000 (19:08 +0100)]
[BUGFIX] Update extension scanner docs.typo3.org link

The extension scanner docs has recently been moved around
within core api docs. Update the link within the upgrade
module accordingly.

Change-Id: Id74a3fa162db63a4257a1d8d2b6b9037bd661467
Resolves: #83558
Releases: master
Reviewed-on: https://review.typo3.org/55353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] CGL: Whitespace fixes 52/55352/2
Christian Kuhn [Sat, 13 Jan 2018 17:06:33 +0000 (18:06 +0100)]
[TASK] CGL: Whitespace fixes

Apply a series of CGL whitespace fixes, mostly:
* No whitespace after type cast
* One space around '='

Change-Id: I6279e083a4bd867bfb70c9567c35b6bab1412043
Resolves: #83557
Releases: master
Reviewed-on: https://review.typo3.org/55352
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] CGL: Fix a series of minor indentation issues 50/55350/3
Christian Kuhn [Sat, 13 Jan 2018 16:19:33 +0000 (17:19 +0100)]
[TASK] CGL: Fix a series of minor indentation issues

Apply various minor indentation CGL fixes, as suggested
by scrutinizer-ci, mostly related to places where indentation
is done with 1 or 3 spaces instead of 4.

Change-Id: Ie3345c7391c0735e8074fd633dd9523616a6b82d
Resolves: #83555
Releases: master
Reviewed-on: https://review.typo3.org/55350
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Add spaces around '=' of 'strict_types=1' 49/55349/3
Christian Kuhn [Sat, 13 Jan 2018 14:14:44 +0000 (15:14 +0100)]
[TASK] Add spaces around '=' of 'strict_types=1'

This cosmetical CGL change just substitutes all

declare(strict_types=1);
with
declare(strict_types = 1);

to be in line with the general 'spaces around ='
rule. While that is cosmetical, it makes scrutinizer-ci
a bit more happy and prevents it from creating
auto-patches for these cases.

Change-Id: Ic754b3fd2a0f06624909e6188ed270bd2797745c
Resolves: #83554
Releases: master
Reviewed-on: https://review.typo3.org/55349
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[TASK] Context menu rename "Export to .t3d" to "Export" 46/55346/3
Christian Kuhn [Sat, 13 Jan 2018 11:52:21 +0000 (12:52 +0100)]
[TASK] Context menu rename "Export to .t3d" to "Export"

Patch renames the context menu options "Export to .t3d"
to "Export" and "Import from .t3d" to "Import".
The technical format detail is no good additional information
and also misleading since xml exports are possible, too.

Change-Id: I0d5bb6b1c390a6c74f58d41b06aac935bad82ec0
Resolves: #83552
Releases: master
Reviewed-on: https://review.typo3.org/55346
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Show folder meta information next to path 18/55318/5
Wolfgang Klinger [Wed, 10 Jan 2018 11:14:40 +0000 (12:14 +0100)]
[BUGFIX] Show folder meta information next to path

Output folder meta information (file count and
total file size) next to the folder path in Filelist again.
Additionally fix a typo in a condition above.

Resolves: #83528
Releases: master, 8.7
Change-Id: I6969966405655d54528059ec937018078caea9d9
Reviewed-on: https://review.typo3.org/55318
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Harden ValidatorResolver and add functional tests 75/55275/4
Alexander Schnitzler [Fri, 5 Jan 2018 11:21:52 +0000 (12:21 +0100)]
[BUGFIX] Harden ValidatorResolver and add functional tests

This patch mainly converts several unit tests with heavy
mocking to functional tests with real fixtures instead of
'eval()'ed classes.

During that seperation two minor bugs have been fixed:

- "resolveValidatorObjectName" tried to find non FQCN
  validators by checking for a colon, an underscore or
  a backslash. That way it found shorthand validators
  like "TYPO3.CMS.Extbase:NotEmpty" and validators
  without any extension reference. e.g. "NotEmpty".

  While that check itself is not a problem, the resolver
  furthermore explodes the validator name by colons,
  which fails for validator names without extension
  reference. This has been fixed by an additional elseif.

- Another small bug has been fixed in the method
  "buildBaseValidatorConjunction".

  While aggregating the validator annotations, the
  method "parseValidatorAnnotation" is called that
  returns an array with the annotation information.
  If the information is built for a method param,
  the key argumentName is set. However, this is not
  the case for properties but following code relied
  on argumentName being present. argumentName is
  now explicitly set to null if not given.

Releases: master
Resolves: #83481
Change-Id: I413b85ad905c19f6ae7daef8f5d97aeeab2edb90
Reviewed-on: https://review.typo3.org/55275
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update UnicodeData.txt 34/55334/3
Markus Klein [Thu, 11 Jan 2018 12:52:51 +0000 (13:52 +0100)]
[TASK] Update UnicodeData.txt

Source: http://unicode.org/Public/UNIDATA/UnicodeData.txt

Releases: master, 8.7
Resolves: #83541
Change-Id: I0ba23c774f24be120c562239c7665c8a1732cbb1
Reviewed-on: https://review.typo3.org/55334
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[TASK] Drop 'typo3/ should be link' recommendation 43/55343/3
Christian Kuhn [Fri, 12 Jan 2018 17:25:07 +0000 (18:25 +0100)]
[TASK] Drop 'typo3/ should be link' recommendation

The recommendation of FolderStructure having index.php and typo3/
folder as links is old fashioned, even if not using composer
based instances. The config has no functional meaning in the
install tool and can just be dropped.

Change-Id: Ie8addd1713cadeb381a11cf9a362ac255da6e72c
Resolves: #83550
Releases: master
Reviewed-on: https://review.typo3.org/55343
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[BUGFIX] fixPermissions() on install tool test image 42/55342/2
Christian Kuhn [Fri, 12 Jan 2018 17:43:08 +0000 (18:43 +0100)]
[BUGFIX] fixPermissions() on install tool test image

One of the environment image tests misses an explicit
fixPermissions() call on a created image resulting in
potentially broken file permissions on that file.

Change-Id: Ib7e9da2269aaabdd9cc815d8ff2f0d3841b45444
Resolves: #83549
Releases: master
Reviewed-on: https://review.typo3.org/55342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[TASK] Test cases for function specCharsToASCII() 33/55333/11
Reiner Teubner [Thu, 11 Jan 2018 10:40:34 +0000 (11:40 +0100)]
[TASK] Test cases for function specCharsToASCII()

Add a new test for the function specCharsToASCII().

Resolves: #83546
Related: #20612
Releases: master
Change-Id: Id255ab953ef7c1865a7db1892b9b5d5fac87c547
Reviewed-on: https://review.typo3.org/55333
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Introduce Matcher for required arguments in static calls 68/55268/6
Anja Leichsenring [Fri, 5 Jan 2018 07:13:52 +0000 (08:13 +0100)]
[TASK] Introduce Matcher for required arguments in static calls

Add a matcher that is able to detect hits of method calls that do
not comply to a minimum amount of arguments, where new arguments
have been introduced or previously optional ones have been made
mandatory.

Resolves: #83471
Relates: #82899
Releases: master
Change-Id: I96eedb06bfcd88a8927902060224b12b64f6f470
Reviewed-on: https://review.typo3.org/55268
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>